Re: [openstreetmap/openstreetmap-website] Installation on Ubuntu 24.04 Failure with MIni Racer (Issue #5733)
jessequinn left a comment (openstreetmap/openstreetmap-website#5733) https://github.com/user-attachments/assets/620e4c6c-949a-46ad-aba3-45b11a55c8d2"; /> -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5733#issuecomment-2691346948 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Switch to using annotaterb for annotations (PR #5716)
@tomhughes pushed 3 commits. a52558ecc440d37f2aefc27f81e2a7596a428bfd Switch to using annotaterb for annotations 1213e7009aac7448ac1478c4536cba81fa74f679 Update model annotations ab4f96261fe043ba704616e8b6f7cf77e79817bf Drop explicit lengths from bigint columns -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5716/files/866747c49dafd8ff783eb117e3980897ca3be977..ab4f96261fe043ba704616e8b6f7cf77e79817bf You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Add permalinks to changeset comments (PR #4789)
tomhughes left a comment (openstreetmap/openstreetmap-website#4789) Can you rebase this on current master please, to get rid of the merge commits, and also squash any fixup commits into the commit they are fixing. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4789#issuecomment-2695137819 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Remove obsolete element from docker-compose.yml (PR #5743)
Merged #5743 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5743#event-16538438442 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Add pluralizers to I18n (PR #5654)
@tomhughes commented on this pull request. > @@ -1,6 +1,7 @@ <%= tag.head :data => application_data do %> <%= render :partial => "layouts/meta" %> <%= javascript_include_tag "turbo", :type => "module" %> + <%= javascript_include_tag "make-plural/cardinals" %> Obviously that global namespace pollution is poor but I don't see why it would break anything, and having tried it myself I can't reproduce any problem once the assets are properly rebuilt. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5654#discussion_r1978149546 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Removes optional using first comments records (PR #5744)
tomhughes left a comment (openstreetmap/openstreetmap-website#5744) I don't think this is the right approach to the tests - a factory that modifies the record's parent seems wrong to me. Probably the `note_comment` factory shouldn't be defaulting to creating an `opened` comment now, as in the future there won't be any such thing. It should probably default to `commented` and the `note` factory should generate food defaults for the initial open and tests should be adapted to all that. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5744#issuecomment-2695474775 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Add permalinks to changeset comments (PR #4789)
@gy-mate pushed 1 commit. 2db5b718047d8dfb494fdc8fdd6012bf73f3f0ab Add button instead of hyperlinking time_ago -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4789/files/56c38f7466728951ca021e83c90340fe29e9e997..2db5b718047d8dfb494fdc8fdd6012bf73f3f0ab You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Add permalinks to changeset comments (PR #4789)
gy-mate left a comment (openstreetmap/openstreetmap-website#4789) @tomhughes This seemed too complicated for me but I've cut the Gordian knot by basically squashing all commits into one and rebasing it on top of the master. Is it okay this way? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4789#issuecomment-2695513575 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Replace CC-BY-SA icon with SVG (PR #4792)
@hlfan commented on this pull request. > + + + + + + + + + + + + + + Let's not make it more complex than what is needed: ```suggestion ``` -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4792#pullrequestreview-2655183396 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] I18n fallback fixes (PR #5745)
hlfan left a comment (openstreetmap/openstreetmap-website#5745) Shouldn't this affect the change put in place in #5527 too? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5745#issuecomment-2695912284 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
[openstreetmap/openstreetmap-website] Bump @stylistic/eslint-plugin-js from 4.1.0 to 4.2.0 (PR #5746)
Bumps [@stylistic/eslint-plugin-js](https://github.com/eslint-stylistic/eslint-stylistic/tree/HEAD/packages/eslint-plugin-js) from 4.1.0 to 4.2.0.Release notes
Sourced from
@stylistic/eslint-plugin-js's releases.v4.2.0
4.2.0; (2025-03-03)
Features
- config: update
yield-star-spacingandgenerator-star-spacingconfig to align with Prettier (86d17c8;)Documentation
Changelog
Sourced from
@stylistic/eslint-plugin-js's changelog.4.2.0; (2025-03-03)
Features
- config: update
yield-star-spacingandgenerator-star-spacingconfig to align with Prettier (86d17c8;)Documentation
Commits
c430ddf; chore: release v4.2.0 (main) (#706;)- See full diff in compare view
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) ---You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5746 -- Commit Summary -- * Bump @stylistic/eslint-plugin-js from 4.1.0 to 4.2.0 -- File Changes -- M yarn.lock (6) -- Patch Links -- https://github.com/openstreetmap/openstreetmap-website/pull/5746.patch https://github.com/openstreetmap/openstreetmap-website/puDependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot showignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Re: [openstreetmap/openstreetmap-website] Add permalinks to changeset comments (PR #4789)
tomhughes left a comment (openstreetmap/openstreetmap-website#4789) Given that it winds up with one tiny change, yes, that is perfect. Do we actually use that icon anywhere else at the moment? It seems very bold to me, and poorly aligned:  -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4789#issuecomment-2695708451 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
[openstreetmap/openstreetmap-website] I18n fallback fixes (PR #5745)
A few fixes and cleanups for I18n fallback: * Disable client side fallback in javascript that isn't doing anything as we only load one locale - note that in the embed view the story is different as we load all locales there. * Drop an old monkey patch that no longer seems to be needed. * Fix the Norwegian fallback to work - currently it is being overwritten after it is added. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5745 -- Commit Summary -- * Disable client side I18n fallbacks * Drop monkey patch that no longer seems to be needed * Wait until rails has initialised to update I18n fallbacks -- File Changes -- M app/assets/javascripts/application.js (1) M config/initializers/i18n.rb (12) -- Patch Links -- https://github.com/openstreetmap/openstreetmap-website/pull/5745.patch https://github.com/openstreetmap/openstreetmap-website/pull/5745.diff -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5745 You are receiving this because you are subscribed to this thread. Message ID:___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
[openstreetmap/openstreetmap-website] Activity indexes (PR #5747)
### Description This PR adds database indexes to improve query performance for the user activity feature as part of #5298. Specifically, it adds concurrent indexes on: - `gpx_files` table: `[user_id, timestamp]` index to optimize retrieval of user's GPS trace uploads - `notes` table: `[user_id, created_at]` index to optimize retrieval of user's note activities These indexes will support efficient querying of user activities without table scans, improving performance for the activity feed implementation. ### How has this been tested? Testing was performed by: 1. Running the migrations locally to verify successful index creation 2. Checking the database schema to confirm indexes are present You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5747 -- Commit Summary -- * Add index on gpx_files.user_id and timestamp * Add index on notes.user_id and created_at -- File Changes -- A db/migrate/20250304172700_add_gpx_files_user_id_timestamp_index.rb (7) A db/migrate/20250304172701_add_notes_user_id_created_at_index.rb (7) -- Patch Links -- https://github.com/openstreetmap/openstreetmap-website/pull/5747.patch https://github.com/openstreetmap/openstreetmap-website/pull/5747.diff -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5747 You are receiving this because you are subscribed to this thread. Message ID:___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Replace CC-BY-SA icon with SVG (PR #4792)
@AntonKhorev commented on this pull request. > + + + + + + + + + + + + + + The simplest thing is to just not change anything because this statement is not exactly true: > to ensure screens with high pixel densities can display the OpenStreetMap > website See https://github.com/openstreetmap/openstreetmap-website/pull/4792#issuecomment-2112728908 I'll say that a png is simpler than a svg containing paths with 0.0001 pixel precision. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4792#discussion_r1978717332 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Installation on Ubuntu 24.04 Failure with Mini Racer (Issue #5733)
Hatsune39 left a comment (openstreetmap/openstreetmap-website#5733) I had the same issue before, check this path: `/var/lib/gems/3.2.0/gems/libv8-node-18.19.0.0-x86_64-linux/vendor/v8/x86_64-linux-gnu/libv8/obj/libv8_monolith.a` If the v8 directory contains x86_64-linux instead of x86_64-linux-gnu, rename the x86_64-linux folder to x86_64-linux-gnu, and the issue should be resolved. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5733#issuecomment-2696457264 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
[openstreetmap/openstreetmap-website] Removes optional using first comments records (PR #5744)
### Description PR removes optional using of note's first comments records for retrieving note's description and author in Note model file. Also, adds note's initializing when created using `note_comments` factory by initializing note's `description`, `user_ip` and `user_id` from note's comment (this is used only when notes are created by `create(:note_comment, ...)`) in unit tests. ### How has this been tested? Automated unit tests and manual testing on previously created set of notes (with special cases). You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5744 -- Commit Summary -- * Removes optional using first comments records * Improves initializing note's records in test factory -- File Changes -- M app/models/note.rb (17) M test/factories/note_comments.rb (4) M test/models/note_test.rb (9) -- Patch Links -- https://github.com/openstreetmap/openstreetmap-website/pull/5744.patch https://github.com/openstreetmap/openstreetmap-website/pull/5744.diff -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5744 You are receiving this because you are subscribed to this thread. Message ID:___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Remove obsolete element from docker-compose.yml (PR #5743)
tomhughes left a comment (openstreetmap/openstreetmap-website#5743) Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5743#issuecomment-2695133542 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Use svg symbols for routing icons (PR #4901)
@hlfan commented on this pull request. > + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + If you add `fill="none" stroke="currentColor" stroke-width="1"` to the use element when filling the `turnByTurnTable`, you can clean up the icon definitions. ```suggestion ``` -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4901#pullrequestreview-2655360499 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
