Re: [opensource-dev] Review Request: The world map can point to the wrong URL

[Vadim ProductEngine]

> On 2010-12-23 05:16:08, Vadim ProductEngine wrote:
> > indra/newview/llstartup.cpp, lines 3098-3099
> > 
> >
> > Frankly speaking, I'm not a fan of adding another setting to only use 
> > it as a global variable.
> > 
> > I would search for a more proper way, maybe adding 
> > get/setMapServerURL() methods to LLWorldMap.
> > Perhaps a person more familiar with the world map code than me would 
> > suggest a better approach.
> 
> Merov Linden wrote:
> I don't like it either but, unfortunately, the LLWorldMap is lazy 
> instantiated in LLFloaterWorldMap::createWorldMapView() and I can't guarantee 
> that it exists at that point in llstartup.cpp. So I either store the 
> map_server_url response in an ad-hoc global or, as I did, in a setting which 
> a different sort of global when you think about it but somewhat cleaner 
> (documented at least and with specific usage). I choose the second solution.
> 
>

I see. Then what about storing the URL in a static member of LLWorldMap (and 
using static getter/setter), so we don't need it to be instantiated? Or even 
store in LLWorldMipmap?


- Vadim


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/61/#review76
---


On 2010-12-22 22:15:00, Merov Linden wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/61/
> ---
> 
> (Updated 2010-12-22 22:15:00)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Implements the processing of map-server-url correctly so not to overwrite the 
> default value (which can still be useful if a grid does not implement 
> map-server-url).
> 
> 
> This addresses bug STORM-805.
> http://jira.secondlife.com/browse/STORM-805
> 
> 
> Diffs
> -
> 
>   indra/newview/app_settings/settings.xml 5d69e36a53ee 
>   indra/newview/llstartup.cpp 5d69e36a53ee 
>   indra/newview/llworldmipmap.cpp 5d69e36a53ee 
> 
> Diff: http://codereview.secondlife.com/r/61/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Merov
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] LLMatrix3::orthogonalize test (was: LL_TESTS for standalone out-of-source builds)

[Robin Cornelius]

On Wed, Oct 13, 2010 at 12:37 PM, Boroondas Gupte
 wrote:
> On 10/13/2010 03:42 AM, WolfPup Lowenhar wrote:
>
> On the subject of the reason for killing test here is another reason that I
> have attached this is from a full build I did today. The error listed in the
> file is actually coded around and in visual studio you have to set that test
> to not treat warnings as errors so that it will not fail!
>
> I tried removing the skip line to re-enable the test, like so:
>
> diff -r 27535365bd4c indra/llmath/tests/m3math_test.cpp
> --- a/indra/llmath/tests/m3math_test.cpp  Fri Oct 08 01:13:23 2010 +0200
> +++ b/indra/llmath/tests/m3math_test.cpp  Wed Oct 13 13:16:30 2010 +0200
> @@ -280,7 +280,6 @@
>   llmat_obj.setRows(llvec1, llvec2, llvec3);
>   llmat_obj.orthogonalize();
>
> - skip("Grr, LLMatrix3::orthogonalize test is failing.  Has it 
> ever
> worked?");
>   ensure("LLMatrix3::orthogonalize failed ",
>  is_approx_equal(0.19611613f, llmat_obj.mMatrix[0][0]) &&
>  is_approx_equal(0.78446454f, llmat_obj.mMatrix[0][1]) &&
>
> On my system that test seems to work fine after that:
>
> LD_LIBRARY_PATH += ['/home/das-g/slsrc/hg/build/build/llcommon', '/usr/lib',
> '/usr/local/lib']
> LD_LIBRARY_PATH =
> '/usr/local/lib:/home/das-g/slsrc/hg/build/build/llcommon:/usr/lib'
> Running: /home/das-g/slsrc/hg/build/build/llmath/INTEGRATION_TEST_m3math
> Unit test group_started name=m3math_h
> Unit test group_completed name=m3math_h
>   Total Tests:13
>   Passed Tests:   13  YAY!! \o/
>
> Maybe someone has fixed LLMatrix3::orthogonalize but forgot to re-enable the
> test? Or is LLMatrix3::orthogonalize behaving differently on different
> platforms? (That should affect quaternion calculations and auto-leveling in
> Flycam mode, so it's unlikely to go unnoticed.)
>
> Anyway, would be good if others could re-enable the test, too, and see
> whether it also passes for them.

Bumping this as i've just looked at it myself, the test is working
fine on windows for me too and it does not appear that it needs
skipping and as noticed previously in this (old) thread that the
skip() is causing a unreachable code error in the test. So any reason
why the test cannot be reenabled?

Robin
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Anyone playing with Android and Second Life?

[Opensource Obscure]

Anyone playing with the Android platform together with Second Life?

I'm an Android newbie but I would be available to help (testing,
feedback, marketing) anyone developing a solution for this platform.

Until now I could only find a closed-source viewer that runs on Android,
and it's not even included in the Third Party Viewer Directory. I ignore
if they ever apply for it and got refused, or if they never applied for.

http://www.mobilegridclient.com - you may also want to read a
perplexed developer's opinion about them: http://t.co/wH0hYyu

Hopefully they're actually not violating TPVP and could apply for
inclusion in the Directory, but it's a bit hard to trust them right now.
(what do you think?)

bye,
Opensource Obscure
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Anyone playing with Android and Second Life?

[Robin Cornelius]

On Tue, Dec 28, 2010 at 3:30 PM, Opensource Obscure
 wrote:

> Hopefully they're actually not violating TPVP and could apply for
> inclusion in the Directory, but it's a bit hard to trust them right now.
> (what do you think?)

There is a stricter requirement to be listed in the Third Party Viewer
list than to actually connect to the SL Grid, so the fact they are a
closed source solution, whist fine with the TPVP in general, would not
allow them to be listed due to clause 6.a.iv.B/C, but would allow them
to be used to connect.

The other issue is, if they are using a central server to perform the
connection to SL then transmitting revelant data to your handset,
unless they have been very clever to avoid TPV clause 2.e, and it
seems to be this that is mentioned in the linked discussion, then that
would be considered a serious issue by LL, even if they had all good
intentions.

Robin
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Anyone playing with Android and Second Life?

[Robin Cornelius]

On Tue, Dec 28, 2010 at 3:55 PM, Robin Cornelius
 wrote:

> The other issue is, if they are using a central server to perform the
> connection to SL then transmitting revelant data to your handset,
> unless they have been very clever to avoid TPV clause 2.e, and it
> seems to be this that is mentioned in the linked discussion, then that
> would be considered a serious issue by LL, even if they had all good
> intentions.

And in the worst possible email etiquette, replying to ones self..

Their changelog says

 v1.13.852
* the whole login process is now handled by the mobile device itself,
from now on no passwords nor their hashes are transfered to our
servers.

So that avoids 2.e

Robin
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Anyone playing with Android and Second Life?

[Tateru Nino]

On 29/12/2010 2:57 AM, Robin Cornelius wrote:
> On Tue, Dec 28, 2010 at 3:55 PM, Robin Cornelius
>   wrote:
>
>> The other issue is, if they are using a central server to perform the
>> connection to SL then transmitting revelant data to your handset,
>> unless they have been very clever to avoid TPV clause 2.e, and it
>> seems to be this that is mentioned in the linked discussion, then that
>> would be considered a serious issue by LL, even if they had all good
>> intentions.
> And in the worst possible email etiquette, replying to ones self..
>
> Their changelog says
>
>   v1.13.852
> * the whole login process is now handled by the mobile device itself,
> from now on no passwords nor their hashes are transfered to our
> servers.
>
> So that avoids 2.e
I'd be more concerned about capabilities URIs, myself. The login 
credentials are only the front-gate.

-- 
Tateru Nino
http://dwellonit.taterunino.net/

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Anyone playing with Android and Second Life?

[Robin Cornelius]

On Tue, Dec 28, 2010 at 4:05 PM, Tateru Nino  wrote:

>>
>> So that avoids 2.e
> I'd be more concerned about capabilities URIs, myself. The login
> credentials are only the front-gate.
>

Thats absolutly true, and it would be trivial to inject a pay packet
or any other packet into the data stream. But its probably far far
easier to place malicious code in a TVP binary. So unless you are
going to download the source to a TPV and diff it against LL code
base, then compile yourself (ensuring all dependencies are also
provided by LL/built by yourself), are you really any more at risk? ,
i'm just being a bit of a devils advocate here, my first comments were
a literal comparison of if they met the TPV rules for listing.

Robin
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Anyone playing with Android and Second Life?

[Tateru Nino]

On 29/12/2010 3:12 AM, Robin Cornelius wrote:
> On Tue, Dec 28, 2010 at 4:05 PM, Tateru Nino  wrote:
>
>>> So that avoids 2.e
>> I'd be more concerned about capabilities URIs, myself. The login
>> credentials are only the front-gate.
>>
> Thats absolutly true, and it would be trivial to inject a pay packet
> or any other packet into the data stream. But its probably far far
> easier to place malicious code in a TVP binary. So unless you are
> going to download the source to a TPV and diff it against LL code
> base, then compile yourself (ensuring all dependencies are also
> provided by LL/built by yourself), are you really any more at risk? ,
> i'm just being a bit of a devils advocate here, my first comments were
> a literal comparison of if they met the TPV rules for listing.
Ultimately it all comes down to trust, yes - regardless of who provides 
the application.

-- 
Tateru Nino
http://dwellonit.taterunino.net/

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] LLMatrix3::orthogonalize test (was: LL_TESTS for standalone out-of-source builds)

[WolfPup Lowenhar]

Ever since I found that this test is working I have been having to change
that one line in the test although TrotiosHG makes it easy to keep the
change even though it is not committed (shelve changes) any time I create a
new local repository I have to go in and edit that one file so that the test
dose not fail building in visual studio as the test when building treats
warnings as errors and thus fails to even build.

 

From: opensource-dev-boun...@lists.secondlife.com
[mailto:opensource-dev-boun...@lists.secondlife.com] On Behalf Of Robin
Cornelius
Sent: Tuesday, December 28, 2010 9:45 AM
To: Boroondas Gupte
Cc: opensource-dev@lists.secondlife.com
Subject: Re: [opensource-dev] LLMatrix3::orthogonalize test (was: LL_TESTS
for standalone out-of-source builds)

 

On Wed, Oct 13, 2010 at 12:37 PM, Boroondas Gupte
 wrote:
> On 10/13/2010 03:42 AM, WolfPup Lowenhar wrote:
>
> On the subject of the reason for killing test here is another reason that
I
> have attached this is from a full build I did today. The error listed in
the
> file is actually coded around and in visual studio you have to set that
test
> to not treat warnings as errors so that it will not fail!
>
> I tried removing the skip line to re-enable the test, like so:
>
> diff -r 27535365bd4c indra/llmath/tests/m3math_test.cpp
> --- a/indra/llmath/tests/m3math_test.cpp  Fri Oct 08 01:13:23 2010
+0200
> +++ b/indra/llmath/tests/m3math_test.cpp  Wed Oct 13 13:16:30 2010
+0200
> @@ -280,7 +280,6 @@
>   llmat_obj.setRows(llvec1, llvec2, llvec3);
>   llmat_obj.orthogonalize();
>
> - skip("Grr, LLMatrix3::orthogonalize test is failing.  Has it
ever
> worked?");
>   ensure("LLMatrix3::orthogonalize failed ",
>  is_approx_equal(0.19611613f, llmat_obj.mMatrix[0][0])
&&
>  is_approx_equal(0.78446454f, llmat_obj.mMatrix[0][1])
&&
>
> On my system that test seems to work fine after that:
>
> LD_LIBRARY_PATH += ['/home/das-g/slsrc/hg/build/build/llcommon',
'/usr/lib',
> '/usr/local/lib']
> LD_LIBRARY_PATH =
> '/usr/local/lib:/home/das-g/slsrc/hg/build/build/llcommon:/usr/lib'
> Running: /home/das-g/slsrc/hg/build/build/llmath/INTEGRATION_TEST_m3math
> Unit test group_started name=m3math_h
> Unit test group_completed name=m3math_h
>   Total Tests:13
>   Passed Tests:   13  YAY!! \o/
>
> Maybe someone has fixed LLMatrix3::orthogonalize but forgot to re-enable
the
> test? Or is LLMatrix3::orthogonalize behaving differently on different
> platforms? (That should affect quaternion calculations and auto-leveling
in
> Flycam mode, so it's unlikely to go unnoticed.)
>
> Anyway, would be good if others could re-enable the test, too, and see
> whether it also passes for them.

Bumping this as i've just looked at it myself, the test is working
fine on windows for me too and it does not appear that it needs
skipping and as noticed previously in this (old) thread that the
skip() is causing a unreachable code error in the test. So any reason
why the test cannot be reenabled?

Robin
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting
privileges 

  _  

No virus found in this message.
Checked by AVG - www.avg.com
Version: 10.0.1191 / Virus Database: 1435/3344 - Release Date: 12/28/10

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Anyone playing with Android and Second Life?

[Ponzu]

You mean Android on a mobile device?  Or Android on a powerful desktop.

What about the LL browser effort?  I did not get accepted, and know nothing
more about it.  Seems to me that would be a way to go.

Also, the Chrome OS beta that is just starting.  If the LL viewer for
browsers will support Chrome, then maybe that is a decent mobile SL for the
future.

Lastly, maybe someday in the future, they will separate the rendering from
the visual, ala X Windows.  You could render on the powerhouse box in the
garage, but display on the lightweight client on your lap.  Then, all you
would need is a mobile device with high powered haptics 8-) 8-)

ponzu

On Tue, Dec 28, 2010 at 11:14 AM, Tateru Nino  wrote:

>
>
> On 29/12/2010 3:12 AM, Robin Cornelius wrote:
> > On Tue, Dec 28, 2010 at 4:05 PM, Tateru Nino
>  wrote:
> >
> >>> So that avoids 2.e
> >> I'd be more concerned about capabilities URIs, myself. The login
> >> credentials are only the front-gate.
> >>
> > Thats absolutly true, and it would be trivial to inject a pay packet
> > or any other packet into the data stream. But its probably far far
> > easier to place malicious code in a TVP binary. So unless you are
> > going to download the source to a TPV and diff it against LL code
> > base, then compile yourself (ensuring all dependencies are also
> > provided by LL/built by yourself), are you really any more at risk? ,
> > i'm just being a bit of a devils advocate here, my first comments were
> > a literal comparison of if they met the TPV rules for listing.
> Ultimately it all comes down to trust, yes - regardless of who provides
> the application.
>
> --
> Tateru Nino
> http://dwellonit.taterunino.net/
>
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting
> privileges
>
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Review Request: Reenable the LLMatrix3::orthogonalize test in llmath/tests/m3math_test.cpp

[Wolfpup Lowenhar]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/67/
---

Review request for Viewer.


Summary
---

This patch is to fix https://jira.secondlife.com/browse/VWR-24332 this test is 
working in Windows environments


Diffs
-

  indra/llmath/tests/m3math_test.cpp 940cd25d4b78 

Diff: http://codereview.secondlife.com/r/67/diff


Testing
---

Re-enabled the test and built the viewer including all tests and have no errors 
and all of the test done in m3math_test are reporting that they all succeed. 


Thanks,

Wolfpup

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Reenable the LLMatrix3::orthogonalize test in llmath/tests/m3math_test.cpp

[Wolfpup Lowenhar]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/67/
---

(Updated 2010-12-28 10:05:04.987644)


Review request for Viewer.


Changes
---

move location of link to jira


Summary (updated)
---

This patch is to fix this test is working in Windows environments


This addresses bug https://jira.secondlife.com/browse/VWR-24332.

http://jira.secondlife.com/browse/https://jira.secondlife.com/browse/VWR-24332


Diffs
-

  indra/llmath/tests/m3math_test.cpp 940cd25d4b78 

Diff: http://codereview.secondlife.com/r/67/diff


Testing
---

Re-enabled the test and built the viewer including all tests and have no errors 
and all of the test done in m3math_test are reporting that they all succeed. 


Thanks,

Wolfpup

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Reenable the LLMatrix3::orthogonalize test in llmath/tests/m3math_test.cpp

[Aleric Inglewood]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/67/#review101
---


I think this line should be deleted, not commented out. If there still is a 
reason to think that it might need to be uncommented later than apparently we 
aren't sure the test really works, in which case I think it should be skipped 
until we are certain and this is fixed on all platforms.

- Aleric


On 2010-12-28 10:05:04, Wolfpup Lowenhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/67/
> ---
> 
> (Updated 2010-12-28 10:05:04)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> This patch is to fix this test is working in Windows environments
> 
> 
> This addresses bug https://jira.secondlife.com/browse/VWR-24332.
> 
> http://jira.secondlife.com/browse/https://jira.secondlife.com/browse/VWR-24332
> 
> 
> Diffs
> -
> 
>   indra/llmath/tests/m3math_test.cpp 940cd25d4b78 
> 
> Diff: http://codereview.secondlife.com/r/67/diff
> 
> 
> Testing
> ---
> 
> Re-enabled the test and built the viewer including all tests and have no 
> errors and all of the test done in m3math_test are reporting that they all 
> succeed. 
> 
> 
> Thanks,
> 
> Wolfpup
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: The world map can point to the wrong URL

[Merov Linden]

> On 2010-12-23 05:16:08, Vadim ProductEngine wrote:
> > indra/newview/llstartup.cpp, lines 3098-3099
> > 
> >
> > Frankly speaking, I'm not a fan of adding another setting to only use 
> > it as a global variable.
> > 
> > I would search for a more proper way, maybe adding 
> > get/setMapServerURL() methods to LLWorldMap.
> > Perhaps a person more familiar with the world map code than me would 
> > suggest a better approach.
> 
> Merov Linden wrote:
> I don't like it either but, unfortunately, the LLWorldMap is lazy 
> instantiated in LLFloaterWorldMap::createWorldMapView() and I can't guarantee 
> that it exists at that point in llstartup.cpp. So I either store the 
> map_server_url response in an ad-hoc global or, as I did, in a setting which 
> a different sort of global when you think about it but somewhat cleaner 
> (documented at least and with specific usage). I choose the second solution.
> 
>
> 
> Vadim ProductEngine wrote:
> I see. Then what about storing the URL in a static member of LLWorldMap 
> (and using static getter/setter), so we don't need it to be instantiated? Or 
> even store in LLWorldMipmap?

Hmmm... That'll require to include llworldmipmap.h or llworldmap.h in 
llstartup.cpp, creating yet another dependency. It's possible but I don't like 
it. Hard coupling (explicit calls between object instances) can become issues 
later, with too many code snippets knowing too many objects by name just 
because they need one generic access to them. Here, llstartup shouldn't have 
any notion of the existence of a map. It just gets some data at login from the 
server and save them for whoever needs them later. I prefer soft coupling where 
a general context is created (here by settings) and have object instances 
checking this context when needed. That scheme has issues also but it's more 
flexible. Imagine for instance what we throw the map UI and use a web based 
panel to display the map in the viewer (likely scenario BTW). Whoever code that 
will simply get the root URL from the settings, ignoring when and how it got 
there and ignoring the old llworldmipmap. If we create a static in 
llworldmipmap, that devs will have to keep llworldmipmap around or relocate 
that static in a new object, therefore modifying llstartup.
The bottom line I think is that llstartup shouldn't be concerned by the 
existence of a map object. It receives some info at login and should save them 
in a global context. May be we should have a global "grid" context/global but I 
don't think we have one and the closest thing to it is a set of data saved in 
settings.


- Merov


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/61/#review76
---


On 2010-12-22 22:15:00, Merov Linden wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/61/
> ---
> 
> (Updated 2010-12-22 22:15:00)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Implements the processing of map-server-url correctly so not to overwrite the 
> default value (which can still be useful if a grid does not implement 
> map-server-url).
> 
> 
> This addresses bug STORM-805.
> http://jira.secondlife.com/browse/STORM-805
> 
> 
> Diffs
> -
> 
>   indra/newview/app_settings/settings.xml 5d69e36a53ee 
>   indra/newview/llstartup.cpp 5d69e36a53ee 
>   indra/newview/llworldmipmap.cpp 5d69e36a53ee 
> 
> Diff: http://codereview.secondlife.com/r/61/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Merov
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] LLMatrix3::orthogonalize test (was: LL_TESTS for standalone out-of-source builds)

[Philippe (Merov) Bossut]

Hi,

I think that test works fine on all platforms now and should be re-enabled.
Is there a JIRA for it?

Cheers,
- Merov

On Wed, Oct 13, 2010 at 4:37 AM, Boroondas Gupte  wrote:

>  On 10/13/2010 03:42 AM, WolfPup Lowenhar wrote:
>
>  On the subject of the reason for killing test here is another reason that
> I have attached this is from a full build I did today. The error listed in
> the file is actually coded around and in visual studio you have to set that
> test to not treat warnings as errors so that it will not fail!
>
> I tried removing the skip line to re-enable the test, like so:
>
> *diff -r 27535365bd4c indra/llmath/tests/m3math_test.cpp*--- 
> a/indra/llmath/tests/m3math_test.cpp Fri Oct 08 01:13:23 2010 +0200+++ 
> b/indra/llmath/tests/m3math_test.cpp  Wed Oct 13 13:16:30 2010 +0200@@ -280,7 
> +280,6 @@
>   llmat_obj.setRows(llvec1, llvec2, llvec3);
>   llmat_obj.orthogonalize();
>  -skip("Grr, LLMatrix3::orthogonalize test is failing.  Has it 
> ever worked?");
>   ensure("LLMatrix3::orthogonalize failed ",
>  is_approx_equal(0.19611613f, llmat_obj.mMatrix[0][0]) &&
>  is_approx_equal(0.78446454f, llmat_obj.mMatrix[0][1]) &&
>
>  On my system that test seems to work fine after that:
>
> LD_LIBRARY_PATH += ['/home/das-g/slsrc/hg/build/build/llcommon', '/usr/lib', 
> '/usr/local/lib']
> LD_LIBRARY_PATH = 
> '/usr/local/lib:/home/das-g/slsrc/hg/build/build/llcommon:/usr/lib'
> Running: /home/das-g/slsrc/hg/build/build/llmath/INTEGRATION_TEST_m3math
> Unit test group_started name=m3math_h
> Unit test group_completed name=m3math_h
>   Total Tests:13
>   Passed Tests:   13  YAY!! \o/
>
>  Maybe someone has fixed LLMatrix3::orthogonalize but forgot to re-enable
> the test? Or is LLMatrix3::orthogonalize behaving differently on different
> platforms? (That should affect quaternion calculations and auto-leveling in
> Flycam mode, so it's unlikely to go unnoticed.)
>
> Anyway, would be good if others could re-enable the test, too, and see
> whether it also passes for them.
>
> Cheers,
> Boroondas
>
> PS: LLMatrix3::orthogonalize is a bit of a misnomer. Without having looked
> at its code (just at input and desired output in the test) it seems to
> orthogonalize *and* normalize (or "ortho*normalize*" for short). Should
> the method be renamed to reflect this?
>
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting
> privileges
>
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] LLMatrix3::orthogonalize test (was: LL_TESTS for standalone out-of-source builds)

[Philippe (Merov) Bossut]

On Tue, Dec 28, 2010 at 10:52 AM, Philippe (Merov) Bossut <
me...@lindenlab.com> wrote:

>
> I think that test works fine on all platforms now and should be re-enabled.
>
> Is there a JIRA for it?
>

Duh: https://jira.secondlife.com/browse/VWR-24332

Sorry about that.
- Merov
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: The world map can point to the wrong URL

[Vadim ProductEngine]

> On 2010-12-23 05:16:08, Vadim ProductEngine wrote:
> > indra/newview/llstartup.cpp, lines 3098-3099
> > 
> >
> > Frankly speaking, I'm not a fan of adding another setting to only use 
> > it as a global variable.
> > 
> > I would search for a more proper way, maybe adding 
> > get/setMapServerURL() methods to LLWorldMap.
> > Perhaps a person more familiar with the world map code than me would 
> > suggest a better approach.
> 
> Merov Linden wrote:
> I don't like it either but, unfortunately, the LLWorldMap is lazy 
> instantiated in LLFloaterWorldMap::createWorldMapView() and I can't guarantee 
> that it exists at that point in llstartup.cpp. So I either store the 
> map_server_url response in an ad-hoc global or, as I did, in a setting which 
> a different sort of global when you think about it but somewhat cleaner 
> (documented at least and with specific usage). I choose the second solution.
> 
>
> 
> Vadim ProductEngine wrote:
> I see. Then what about storing the URL in a static member of LLWorldMap 
> (and using static getter/setter), so we don't need it to be instantiated? Or 
> even store in LLWorldMipmap?
> 
> Merov Linden wrote:
> Hmmm... That'll require to include llworldmipmap.h or llworldmap.h in 
> llstartup.cpp, creating yet another dependency. It's possible but I don't 
> like it. Hard coupling (explicit calls between object instances) can become 
> issues later, with too many code snippets knowing too many objects by name 
> just because they need one generic access to them. Here, llstartup shouldn't 
> have any notion of the existence of a map. It just gets some data at login 
> from the server and save them for whoever needs them later. I prefer soft 
> coupling where a general context is created (here by settings) and have 
> object instances checking this context when needed. That scheme has issues 
> also but it's more flexible. Imagine for instance what we throw the map UI 
> and use a web based panel to display the map in the viewer (likely scenario 
> BTW). Whoever code that will simply get the root URL from the settings, 
> ignoring when and how it got there and ignoring the old llworldmipmap. If we 
> create a static in llworldmipmap, that devs will have to keep llworldmipmap 
> around or relocate that static in a new object, therefore modifying llstartup.
> The bottom line I think is that llstartup shouldn't be concerned by the 
> existence of a map object. It receives some info at login and should save 
> them in a global context. May be we should have a global "grid" 
> context/global but I don't think we have one and the closest thing to it is a 
> set of data saved in settings.

Right, sounds reasonable.


- Vadim


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/61/#review76
---


On 2010-12-22 22:15:00, Merov Linden wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/61/
> ---
> 
> (Updated 2010-12-22 22:15:00)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Implements the processing of map-server-url correctly so not to overwrite the 
> default value (which can still be useful if a grid does not implement 
> map-server-url).
> 
> 
> This addresses bug STORM-805.
> http://jira.secondlife.com/browse/STORM-805
> 
> 
> Diffs
> -
> 
>   indra/newview/app_settings/settings.xml 5d69e36a53ee 
>   indra/newview/llstartup.cpp 5d69e36a53ee 
>   indra/newview/llworldmipmap.cpp 5d69e36a53ee 
> 
> Diff: http://codereview.secondlife.com/r/61/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Merov
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: The world map can point to the wrong URL

[Vadim ProductEngine]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/61/#review103
---

Ship it!


- Vadim


On 2010-12-22 22:15:00, Merov Linden wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/61/
> ---
> 
> (Updated 2010-12-22 22:15:00)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Implements the processing of map-server-url correctly so not to overwrite the 
> default value (which can still be useful if a grid does not implement 
> map-server-url).
> 
> 
> This addresses bug STORM-805.
> http://jira.secondlife.com/browse/STORM-805
> 
> 
> Diffs
> -
> 
>   indra/newview/app_settings/settings.xml 5d69e36a53ee 
>   indra/newview/llstartup.cpp 5d69e36a53ee 
>   indra/newview/llworldmipmap.cpp 5d69e36a53ee 
> 
> Diff: http://codereview.secondlife.com/r/61/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Merov
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] STORM-34 Test Binaries

[Celierra Darling]

It seems a little unclear to try to communicate "this can have privacy
implications" by putting the setting on the privacy tab.  It might be better
to write the setting label so it's more explicit (i.e. something like "Show
my favorites to anyone under 'Start At' before logging in" or "Show my
favorites under 'Start At' on login (before authenticating)" or etc.).

Celi


On Mon, Dec 27, 2010 at 11:59 AM, Carlo Wood  wrote:

> > I kinda have to agree with hitomi.
>
> I agree with Andrew; it's a privacy sensitive thing
> and users shouldn't accidently flip it without thinking
> because it's on the normal 'General' page.
> If they need or want it, then I'm sure they'll find it,
> like they find everything else. Also, it will take a
> while before a user needs links to favourite places
> on their login page: those are not newbies. It's sufficient
> to put the option in a place that requires more knowledge
> (and exploration) of the viewer interface.
>
> --
> Carlo Wood 
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting
> privileges
>
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Test binary for in review JIRAs

[Trilo Byte]

Great stuff!

* STORM-34 : As a User, I want a list of my favorite locations available on the 
login screen so i can log in to SL right where I want to be.
Works well in 217881, Mac client. Ghosted (and disabled) before login. Once 
enabled, favorites appear in drop-down, and logging in to a saved Favorite 
location works as expected.

* STORM-242 : Server version dialog message has incorrect release notes link 
(modulo one build issue fixed...)
Nice one! I've occasionally noticed incorrect release notes links in the past, 
but always chalked it up to incorrect link data coming from the server. Tested 
in developer build 217881, Mac client while flying around the multi-region 
Caledon community, and when crossing into regions on different versions the 
links worked correctly.

* STORM-398 : Message from nearby chat appears for avatar in Busy mode
Works well in build 217881, Mac client.

* STORM-466 : 2.x minimap cannot be reset to default zoom.
Works great in developer build 217881, Mac client.  Woohoo for Default Zoom!

* STORM-467 : 2.x minimap zoom does not persist to the next session.
Works well in developer build 217881, Mac client.

* STORM-485 : 'Cancel' button exceed the bounds of 'Group Invitation' floater.
Works in developer build 217881. Mac client :)

* STORM-682 : IM and notification toasts appear in wrong position if switch on 
mouse look when side tray is expanded 
In developer build 217881, Mac client, works well (but only after I remember to 
re-enable incoming IM popups haha)

* STORM-737 : Inventory Recent tab is missing "+" control at bottom of panel
Developer build 217881, Mac client.  Only the New Folder option is grayed out 
when using the + menu on the recent tab.  Works as I'd expect.



On Dec 27, 2010, at 11:55 PM, Philippe (Merov) Bossut wrote:

> Hi,
> 
> We're having a lot of JIRAs in the "In Review" swim lane for sprint 9 waiting 
> for reviews from PO and/or devs. I created a Mac binary (others building 
> right now) for those:
> http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/merov_viewer-development-import/rev/217880/arch/Darwin/index.html
> 
> JIRAs merged in there:
> * STORM-34 : As a User, I want a list of my favorite locations available on 
> the login screen so i can log in to SL right where I want to be.
> * STORM-242 : Server version dialog message has incorrect release notes link 
> (modulo one build issue fixed...)
> * STORM-398 : Message from nearby chat appears for avatar in Busy mode
> * STORM-466 : 2.x minimap cannot be reset to default zoom.
> * STORM-467 : 2.x minimap zoom does not persist to the next session.
> * STORM-485 : 'Cancel' button exceed the bounds of 'Group Invitation' floater.
> * STORM-682 : IM and notification toasts appear in wrong position if switch 
> on mouse look when side tray is expanded 
> * STORM-737 : Inventory Recent tab is missing "+" control at bottom of panel
> * STORM-805 : The world map can point to the wrong URL 
> 
> Cheers,
> - Merov
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting privileges

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Anyone playing with Android and Second Life?

[Opensource Obscure]

On Tue, Dec 28, 2010 at 18:51, Ponzu  wrote:
> You mean Android on a mobile device?

Yeah - I'm looking for a text-only client that could run on
existing low-end (non-rooted) mobile devices running Android.

Opensource Obscure
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Indicating privacy implications of preference settings (was: STORM-34 Test Binaries)

[Boroondas Gupte]

On 12/28/2010 09:40 PM, Celierra Darling wrote:
> It seems a little unclear to try to communicate "this can have privacy
> implications" by putting the setting on the privacy tab.  It might be
> better to write the setting label so it's more explicit (i.e.
> something like "Show my favorites to anyone under 'Start At' before
> logging in" or "Show my favorites under 'Start At' on login (before
> authenticating)" or etc.).
I have to agree that placing settings on the "privacy" tab is not a good
way to indicate the fact that they have privacy implications. It goes
against the principle that a setting should be placed where users expect
it. I.e., if you know (or suspect) a setting exists, but don't know
where to find it, where would you first look for it? Education about the
consequences of changing the setting can be postponed until after you
found it.

Of course, besides looking at tab labels, placing similar or related
settings together can help in finding them. But the common property
"affects privacy" seems to me too week a reason for placing settings on
the same tab, when that property is not the goal of a setting but rather
a side effect (even although a side effect inherent to the goal itself,
not just to the setting's implementation).

Further, when a user finds a setting on the "privacy" tab *and* realizes
this placement means the setting has privacy implications, how would she
or he know whether enabling or disabling the setting grants higher
privacy? Of course, if one can derive from the description of a setting
what it actually does and then thinks it all through, one gets the
answer as well as how one's privacy would be affected. While the users
are probably well capable to do that, do they want to do that---when
they could just as well be told openly about the setting's effect, e.g.
like in Celierra's labeling proposals above?

Boroondas
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Indicating privacy implications of preference settings (was: STORM-34 Test Binaries)

[Lance Corrimal]

Am Dienstag, 28. Dezember 2010 schrieb Boroondas Gupte:
> On 12/28/2010 09:40 PM, Celierra Darling wrote:
> > It seems a little unclear to try to communicate "this can have
> > privacy implications" by putting the setting on the privacy tab.
> >  It might be better to write the setting label so it's more
> > explicit (i.e. something like "Show my favorites to anyone under
> > 'Start At' before logging in" or "Show my favorites under 'Start
> > At' on login (before authenticating)" or etc.).
> 
> I have to agree that placing settings on the "privacy" tab is not a
> good way to indicate the fact that they have privacy implications.
> It goes against the principle that a setting should be placed
> where users expect it. I.e., if you know (or suspect) a setting
> exists, but don't know where to find it, where would you first
> look for it? Education about the consequences of changing the
> setting can be postponed until after you found it.


possible solution: "make it so" that enabling this displays a popup 
telling the user "this might disclose your favorite places to anyone 
who has physical access to your computer", similar to the "restart the 
viewer" popup that appears on changing some other settings.


bye,
LC
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] saved logins (was: STORM-34 Test Binaries)

[Lance Corrimal]

loosely related to storm-34: I would really see my saved logins back 
in 2.x, similar to snowglobe 1.5...

and yes, i am aware of the fact that with that anyone with physical 
access to my computer can log in under my avatar, and pass all my 
money to someone, and delete all that i own, and pixelrape my 
pixelwife with noone the wiser.

problem with that, that someone needs my cellphone within bluetooth 
reception range to unlock my screensaver.

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Anyone playing with Android and Second Life?

[Ponzu]

/me imagines a viewer that uses various ascii characters to render the
graphics...



On Tue, Dec 28, 2010 at 4:37 PM, Opensource Obscure <
opensourceobsc...@gmail.com> wrote:

> On Tue, Dec 28, 2010 at 18:51, Ponzu  wrote:
> > You mean Android on a mobile device?
>
> Yeah - I'm looking for a text-only client that could run on
> existing low-end (non-rooted) mobile devices running Android.
>
> Opensource Obscure
>
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Reenable the LLMatrix3::orthogonalize test in llmath/tests/m3math_test.cpp

[Boroondas Gupte]

> On 2010-12-28 10:10:54, Aleric Inglewood wrote:
> > I think this line should be deleted, not commented out. If there still is a 
> > reason to think that it might need to be uncommented later than apparently 
> > we aren't sure the test really works, in which case I think it should be 
> > skipped until we are certain and this is fixed on all platforms.

I agree: Delete the line, don't just comment it out. The fact that it was once 
there will be preserved in the revision history, which should be sufficient.


- Boroondas


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/67/#review101
---


On 2010-12-28 10:05:04, Wolfpup Lowenhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/67/
> ---
> 
> (Updated 2010-12-28 10:05:04)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> This patch is to fix this test is working in Windows environments
> 
> 
> This addresses bug https://jira.secondlife.com/browse/VWR-24332.
> 
> http://jira.secondlife.com/browse/https://jira.secondlife.com/browse/VWR-24332
> 
> 
> Diffs
> -
> 
>   indra/llmath/tests/m3math_test.cpp 940cd25d4b78 
> 
> Diff: http://codereview.secondlife.com/r/67/diff
> 
> 
> Testing
> ---
> 
> Re-enabled the test and built the viewer including all tests and have no 
> errors and all of the test done in m3math_test are reporting that they all 
> succeed. 
> 
> 
> Thanks,
> 
> Wolfpup
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Is there supposed to be a login web page for the development viewer? (An SL screenshot, maybe some text, like the regular viewer has)

[SuezanneC Baskerville]

I'm getting that question mark with the development viewer.

On Tue, Nov 23, 2010 at 12:45 PM, Joshua Bell  wrote:

> On Mon, Nov 22, 2010 at 4:58 PM, Chuck Baggett 
> wrote:
>
>> When I log in with the development viewer there is no login web page, just
>> a little question mark.  The part at the bottom where you enter your
>> username, password, etc. works fine.  Is there supposed to be an SL
>> screenshot, maybe some text, like the regular viewer has?
>>
>
> This should be working now. Apparently we changed the channel name and/or
> page logic at some point and didn't ensure all of the resources were in
> place for the "Second Life Development" channel.
>
>
>
>
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting
> privileges
>



-- 
v i r t u a l   w o r l d   e n t h u s i a s t
-- http://www.google.com/profiles/s u e z a n n e --
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Anyone playing with Android and Second Life?

[Jamey Fletcher]

Ponzu wrote:

> /me imagines a viewer that uses various ascii characters to render the
> graphics...

*COULD* someone be insane enough to hook up AAlib or libcaca to the 
viewer?  What a scary thought!
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Indicating privacy implications of preference settings (was: STORM-34 Test Binaries)

[Carlo Wood]

Ok, good points. I take back what I said :).
The best way forward seems to put it where people might first
look and then make clear that everyone can see them with text
right there.

On Tue, Dec 28, 2010 at 10:58:01PM +0100, Boroondas Gupte wrote:
> On 12/28/2010 09:40 PM, Celierra Darling wrote:
> 
> It seems a little unclear to try to communicate "this can have privacy
> implications" by putting the setting on the privacy tab.  It might be
> better to write the setting label so it's more explicit (i.e. something
> like "Show my favorites to anyone under 'Start At' before logging in" or
> "Show my favorites under 'Start At' on login (before authenticating)" or
> etc.).
> 
> I have to agree that placing settings on the "privacy" tab is not a good way 
> to
> indicate the fact that they have privacy implications. It goes against the
> principle that a setting should be placed where users expect it. I.e., if you
> know (or suspect) a setting exists, but don't know where to find it, where
> would you first look for it? Education about the consequences of changing the
> setting can be postponed until after you found it.
> 
> Of course, besides looking at tab labels, placing similar or related settings
> together can help in finding them. But the common property "affects privacy"
> seems to me too week a reason for placing settings on the same tab, when that
> property is not the goal of a setting but rather a side effect (even although 
> a
> side effect inherent to the goal itself, not just to the setting's
> implementation).
> 
> Further, when a user finds a setting on the "privacy" tab and realizes this
> placement means the setting has privacy implications, how would she or he know
> whether enabling or disabling the setting grants higher privacy? Of course, if
> one can derive from the description of a setting what it actually does and 
> then
> thinks it all through, one gets the answer as well as how one's privacy would
> be affected. While the users are probably well capable to do that, do they 
> want
> to do that—when they could just as well be told openly about the setting's
> effect, e.g. like in Celierra's labeling proposals above?
> 
> Boroondas

> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting privileges


-- 
Carlo Wood 
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Anyone playing with Android and Second Life?

[Ibrew Meads]

There are two mono implementations for Android (one open source in
alpha and one soon to be released by Novell) and several text based
clients that run on mono, so i expect that there will be one available
very soon. Otherwise there's the pay-as-you-go Mobile Grid client
discussed earlier. Or you could access via a browser by setting up a
private server with ajaxlife on it, or use the soon to be released LL
web interface.

Ibrew

On Tue, Dec 28, 2010 at 1:37 PM, Opensource Obscure
 wrote:
> On Tue, Dec 28, 2010 at 18:51, Ponzu  wrote:
>> You mean Android on a mobile device?
>
> Yeah - I'm looking for a text-only client that could run on
> existing low-end (non-rooted) mobile devices running Android.
>
> Opensource Obscure
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting privileges
>
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: KDU Improvements: add unit tests for llkdu

[Merov Linden]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/63/
---

(Updated 2010-12-28 22:45:28.345670)


Review request for Viewer.


Changes
---

Here's a new diff that changes a bit the llimagej2ckdu.cpp code so that it 
works consistently for unit tests on all build options on all platforms. I 
added extra comments in the llimagej2ckdu_test.cpp to explain the result.
Clearly, we also need to create integration tests for this but that should be 
another JIRA.


Summary
---

Unit tests addition:
- add tests for llkdu
- turned back on and fix unit tests for llimage
- turned back on and fix unit tests for llworldmap and llworldmipmap


This addresses bug STORM-744.
http://jira.secondlife.com/browse/STORM-744


Diffs (updated)
-

  indra/llimage/CMakeLists.txt 43cf4a37774c 
  indra/llimage/tests/llimageworker_test.cpp 43cf4a37774c 
  indra/llimagej2coj/llimagej2coj.h 43cf4a37774c 
  indra/llimagej2coj/llimagej2coj.cpp 43cf4a37774c 
  indra/llkdu/CMakeLists.txt 43cf4a37774c 
  indra/llkdu/llimagej2ckdu.h 43cf4a37774c 
  indra/llkdu/llimagej2ckdu.cpp 43cf4a37774c 
  indra/llkdu/tests/llimagej2ckdu_test.cpp PRE-CREATION 
  indra/newview/CMakeLists.txt 43cf4a37774c 
  indra/newview/tests/llworldmap_test.cpp 43cf4a37774c 
  indra/newview/tests/llworldmipmap_test.cpp 43cf4a37774c 

Diff: http://codereview.secondlife.com/r/63/diff


Testing
---


Thanks,

Merov

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges