> On 2010-12-28 10:10:54, Aleric Inglewood wrote: > > I think this line should be deleted, not commented out. If there still is a > > reason to think that it might need to be uncommented later than apparently > > we aren't sure the test really works, in which case I think it should be > > skipped until we are certain and this is fixed on all platforms.
I agree: Delete the line, don't just comment it out. The fact that it was once there will be preserved in the revision history, which should be sufficient. - Boroondas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/67/#review101 ----------------------------------------------------------- On 2010-12-28 10:05:04, Wolfpup Lowenhar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/67/ > ----------------------------------------------------------- > > (Updated 2010-12-28 10:05:04) > > > Review request for Viewer. > > > Summary > ------- > > This patch is to fix this test is working in Windows environments > > > This addresses bug https://jira.secondlife.com/browse/VWR-24332. > > http://jira.secondlife.com/browse/https://jira.secondlife.com/browse/VWR-24332 > > > Diffs > ----- > > indra/llmath/tests/m3math_test.cpp 940cd25d4b78 > > Diff: http://codereview.secondlife.com/r/67/diff > > > Testing > ------- > > Re-enabled the test and built the viewer including all tests and have no > errors and all of the test done in m3math_test are reporting that they all > succeed. > > > Thanks, > > Wolfpup > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
