Re: git-cl upload has stopped working (so has patchy)
Il giorno sab 30 mag 2015 alle 20:57, David Kastrup ha scritto: "Trevor Daniels" writes: David Kastrup wrote Saturday, May 30, 2015 2:53 PM At any rate, I can go ask on Savannah if people think that could be a viable hosting option. OK, that seems a sensible next step. http://lists.gnu.org/archive/html/savannah-hackers/2015-05/msg00033.html> I've read the first two replies. I would accept the offer to install and maintain on GNU server whatever software will be decided. Allura can be installed within a python virtualenv. Dependencies are listed in a requirements.txt file. Installing it was quite simple; I only had to remove a pin to a specific version of PIL (I guess the pinned version failed to compile on my system because of some system dependency). I cannot be more precise because I installed Allura on my computer at work, which I won't see before Wednesday. ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: [PATCH 1/5] Remove parser/location global variable setup
Am 31.05.2015 um 07:47 schrieb David Kastrup: [...] Well, that was actually more what I considered strange: the lack of comment on the result/merits rather than on the particular implementation. I can just speak for myself, but the actual benefit of this patch was not obviously clear for me, but I have to admit that the (define-music-function (parser location ...)) was (and still ist) some black magic making stuff work. So the patch itself is a great step forward for all users trying to get used to the scheme stuff that makes lilypond a really powerful tool. I assume that I am not the only one who did not fully understand the importance of this patch at first glance, but I appreciate it a lot! Thanks for your work! Cheers, Marc ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: git-cl upload has stopped working (so has patchy)
Il giorno sab 30 mag 2015 alle 18:37, Trevor Daniels ha scritto: James Lowe wrote Friday, May 29, 2015 8:08 AM On 28/05/15 18:18, Trevor Daniels wrote: Given this problem I thought it prudent to see if I could still import the Issues DB from GoogleCode to Allura in SourceForge. I started the import at 12 noon today (28 May) and after a disconcertingly long pause before anything happened it now seems to be proceeding normally. I haven't really been following the back-and-forth here, but are we now 'decided' on which tracker website we are using? Seems not yet. Allura at SourceForge works and looks viable. It appears to be reasonably actively maintained there. A more-or-less up-to-date copy of our Issues DB is already loaded. Savannah may be prepared to install, maintain and host Allura, or they may be prepared to let us install and maintain it. Don't know who 'us' would be - not me, I have no *nix experience. David says he'll contact them to ask. So far it looks like they are happy to offer hosting but we'll have to install and maintain Allura or whatever we choose eventually. At any rate, I wouldn't use Sourceforge: http://helb.github.io/goodbye-sourceforge/ or any third party server which we do not trust. AFAIK there is no alternative to Allura on the table, so that seems a de facto decision. And of course the scripts still have to be re-engineered to make life easier, whichever option is chosen (or forced on us). What about Gitlab? https://about.gitlab.com/features/ I vaguely remember that Urs is using it for his projects, maybe he can give us some feedback and warn about any possible limitation. What if Google decides shutting down even Rietveld? Gitlab has also code review. ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: git-cl upload has stopped working (so has patchy)
Federico Bruni writes: > Il giorno sab 30 mag 2015 alle 18:37, Trevor Daniels > >> Savannah may be prepared to install, maintain and host Allura, or >> they may be prepared to let us install and maintain it. Don't know >> who 'us' would be - not me, I have no *nix experience. David says >> he'll contact them to ask. > > So far it looks like they are happy to offer hosting but we'll have to > install and maintain Allura or whatever we choose eventually. > At any rate, I wouldn't use Sourceforge: > http://helb.github.io/goodbye-sourceforge/ > > or any third party server which we do not trust. > >> AFAIK there is no alternative to Allura on the table, so that seems >> a de facto decision. >> >> And of course the scripts still have to be re-engineered to make >> life easier, whichever option is chosen (or forced on us). > > What about Gitlab? > https://about.gitlab.com/features/ > > I vaguely remember that Urs is using it for his projects, maybe he can > give us some feedback and warn about any possible limitation. > What if Google decides shutting down even Rietveld? Gitlab has also > code review. Personally, I'd consider it better to work with a combined site in this respect since it would mean that any tools we develop for our workflows (like our own personal git-cl fork) are not LilyPond-only. Gitlab is implemented in Ruby, no idea whether that means any of the quite-harder-to-make-secure-than-getting-it-up warnings for Ruby-on-Rails are applicable here. It has separate community and (non-free) enterprise editions which basically differ in support of directory services IIRC. So that might mean that sharing/integrating user management with Savannah might be non-trivial. It does import projects from Github, and Github imports projects from Google Code. So an experimental setup of LilyPond on Gitlab itself (which is not totally representative as Gitlab's servers don't run the community edition) should be possible pretty easily. As long as Github does not give users the finger who employ its resources for the sake of moving a project elsewhere. Gitorious had no separate free and proprietary editions but they have been bought by Gitlab basically in order to get the project closed down. So I'm basically a bit wary regarding the upstream project and its owners' intentions but, uhm, we are comparing this with Sourceforge here. -- David Kastrup ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: git-cl upload has stopped working (so has patchy)
Federico Bruni wrote Sunday, May 31, 2015 8:14 AM > Il giorno sab 30 mag 2015 alle 20:57, David Kastrup ha > scritto: >> "Trevor Daniels" writes: >> >>> David Kastrup wrote Saturday, May 30, 2015 2:53 PM >>> At any rate, I can go ask on Savannah if people think that could be a viable hosting option. >>> >>> OK, that seems a sensible next step. >> >> http://lists.gnu.org/archive/html/savannah-hackers/2015-05/msg00033.html> >> > > I've read the first two replies. > I would accept the offer to install and maintain on GNU server whatever > software will be decided. > > Allura can be installed within a python virtualenv. Dependencies are > listed in a requirements.txt file. Installing it was quite simple; I > only had to remove a pin to a specific version of PIL (I guess the > pinned version failed to compile on my system because of some system > dependency). I cannot be more precise because I installed Allura on my > computer at work, which I won't see before Wednesday. Thanks for stepping up, Federico! That's one of the uncertainties removed. And it seems no one is suggesting using anything other than Allura, which is available and open-source. Another decision made, I think. The two replies from Savannah clearly say there is no support there for migrating to Allura, but both suggest a virtual server might be made available for LilyPond, without giving a definite commitment. Reading between the lines I think they would welcome someone else, ie LP, installing and running Allura with a view to their offering it to others once it was up and running. The next step is to decide our preference: do we want to take on the commitment to maintain Allura ourselves or use the maintained version at SourceForge. Which would we prefer? (FWIW my preference would be to run Allura at Savannah as our primary DB, with a backup being maintained at SF, which I would be happy to do on a monthly basis.) Trevor ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: git-cl upload has stopped working (so has patchy)
I do run Gitlab but can't give any serious feedback. It's like Github, but we had some limitations with assignment of pull request IIRC. In all it's maybe not extensive enough for LilyPond, but maybe it can be integrated with other tools. For example there's gitlab-ci that can be integrated. Generally I find the pull request approach *very* useful for contributing and review. With the concept of forks it's also very good at opening paths for new contributors. Can't say more ATM. Urs Am 31. Mai 2015 10:23:00 MESZ, schrieb David Kastrup : >Federico Bruni writes: > >> Il giorno sab 30 mag 2015 alle 18:37, Trevor Daniels >> >>> Savannah may be prepared to install, maintain and host Allura, or >>> they may be prepared to let us install and maintain it. Don't know >>> who 'us' would be - not me, I have no *nix experience. David says >>> he'll contact them to ask. >> >> So far it looks like they are happy to offer hosting but we'll have >to >> install and maintain Allura or whatever we choose eventually. >> At any rate, I wouldn't use Sourceforge: >> http://helb.github.io/goodbye-sourceforge/ >> >> or any third party server which we do not trust. >> >>> AFAIK there is no alternative to Allura on the table, so that seems >>> a de facto decision. >>> >>> And of course the scripts still have to be re-engineered to make >>> life easier, whichever option is chosen (or forced on us). >> >> What about Gitlab? >> https://about.gitlab.com/features/ >> >> I vaguely remember that Urs is using it for his projects, maybe he >can >> give us some feedback and warn about any possible limitation. >> What if Google decides shutting down even Rietveld? Gitlab has also >> code review. > >Personally, I'd consider it better to work with a combined site in this >respect since it would mean that any tools we develop for our workflows >(like our own personal git-cl fork) are not LilyPond-only. > >Gitlab is implemented in Ruby, no idea whether that means any of the >quite-harder-to-make-secure-than-getting-it-up warnings for >Ruby-on-Rails are applicable here. It has separate community and >(non-free) enterprise editions which basically differ in support of >directory services IIRC. So that might mean that sharing/integrating >user management with Savannah might be non-trivial. > >It does import projects from Github, and Github imports projects from >Google Code. So an experimental setup of LilyPond on Gitlab itself >(which is not totally representative as Gitlab's servers don't run the >community edition) should be possible pretty easily. As long as Github >does not give users the finger who employ its resources for the sake of >moving a project elsewhere. > >Gitorious had no separate free and proprietary editions but they have >been bought by Gitlab basically in order to get the project closed >down. > >So I'm basically a bit wary regarding the upstream project and its >owners' intentions but, uhm, we are comparing this with Sourceforge >here. > >-- >David Kastrup > >___ >lilypond-devel mailing list >lilypond-devel@gnu.org >https://lists.gnu.org/mailman/listinfo/lilypond-devel ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: git-cl upload has stopped working (so has patchy)
> do we want to take on the commitment to maintain Allura ourselves or > use the maintained version at SourceForge. Which would we prefer? Lilypond is a GNU project, thus I strongly favour Savannah as the primary site for everything. > (FWIW my preference would be to run Allura at Savannah as our > primary DB, with a backup being maintained at SF, which I would be > happy to do on a monthly basis.) This sounds like a sensible approach. Werner ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: git-cl upload has stopped working (so has patchy)
Werner LEMBERG writes: >> do we want to take on the commitment to maintain Allura ourselves or >> use the maintained version at SourceForge. Which would we prefer? > > Lilypond is a GNU project, thus I strongly favour Savannah as the > primary site for everything. > >> (FWIW my preference would be to run Allura at Savannah as our >> primary DB, with a backup being maintained at SF, which I would be >> happy to do on a monthly basis.) > > This sounds like a sensible approach. Given the reports that SourceForge distributes Adware (and there even have been virus-ridden versions of it) on its Windows installers, I'm somewhat wary here. It would be sort of strange to use project facilities there without offering downloads, and I suspect if we do that, SourceForge might decide to put "enhanced" downloads there by themselves. A bit of a pity: they've been a rather important resource and rallying point for free software at one point of time. -- David Kastrup ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: git-cl upload has stopped working (so has patchy)
Il giorno dom 31 mag 2015 alle 10:23, David Kastrup ha scritto: Personally, I'd consider it better to work with a combined site in this respect since it would mean that any tools we develop for our workflows (like our own personal git-cl fork) are not LilyPond-only. IIUC, there's already this tool (not documented): https://github.com/gpocentek/python-gitlab Gitlab is implemented in Ruby, no idea whether that means any of the quite-harder-to-make-secure-than-getting-it-up warnings for Ruby-on-Rails are applicable here. It has separate community and (non-free) enterprise editions which basically differ in support of directory services IIRC. So that might mean that sharing/integrating user management with Savannah might be non-trivial. Yes, there are cons... It does import projects from Github, and Github imports projects from Google Code. So an experimental setup of LilyPond on Gitlab itself (which is not totally representative as Gitlab's servers don't run the community edition) should be possible pretty easily. As long as Github does not give users the finger who employ its resources for the sake of moving a project elsewhere. Actually, Google Code exports to Github. I tried, just to see what happens and it turned out that the standard export works only for issues <1000. Here's the FAQ: https://code.google.com/p/support-tools/wiki/GitHubExporterFAQ#Error_%22Project_cannot_be_migrated_because_it_has_too_many_i Only an owner on Google Code (I'm a committer only) can try Google Takeout: https://code.google.com/p/support-tools/wiki/IssueExporterTool I wonder if the JSON dump can contain images... There's also a script to export to Gitlab: https://gitlab.com/o9000/google-code-to-gitlab ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: git-cl upload has stopped working (so has patchy)
>>> (FWIW my preference would be to run Allura at Savannah as our >>> primary DB, with a backup being maintained at SF, which I would be >>> happy to do on a monthly basis.) >> >> This sounds like a sensible approach. > > Given the reports that SourceForge distributes Adware (and there > even have been virus-ridden versions of it) on its Windows > installers, I'm somewhat wary here. [...] If I understand Trevor correctly, he talks about the bug tracker only. Werner ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Add Netpbm messages to verbose output (issue 240950043 by truer...@gmail.com)
Patch counted down - please push https://codereview.appspot.com/240950043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Fix png filename handling (issue 241760043 by truer...@gmail.com)
Patch counted down - please push https://codereview.appspot.com/241760043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
PATCHES: Countdown for June 3rd 2015
Hello, Here is the current patch countdown list. The next countdown will (hopefully) be on June 3rd. You can always view the most current countdown list here: http://code.google.com/p/lilypond/issues/list?q=Patch%3Apush%2Ccountdown%2Creview%2Cnew%2Cwaiting&colspec=Patch%20Owner%20ID%20Summary&sort=patch PUSH: James Lowe: Patch: Add Netpbm messages to verbose output http://code.google.com/p/lilypond/issues/detail?id=4420 James Lowe: Patch: Fix png filename handling http://code.google.com/p/lilypond/issues/detail?id=4417 Phil Holmes: Patch: Remove CR LF from snippets using makelsr http://code.google.com/p/lilypond/issues/detail?id=4416 COUNTDOWN: David Kastrup: Patch: Fix some CG musing about music functions http://code.google.com/p/lilypond/issues/detail?id=4425 Trevor Daniels: Add a Solo staff to the satb.ly template http://code.google.com/p/lilypond/issues/detail?id=4424 Dan Eble: Part_combine_iterator: eliminate array of context handles http://code.google.com/p/lilypond/issues/detail?id=4423 David Kastrup: Obsolete parser/location arguments to music functions http://code.google.com/p/lilypond/issues/detail?id=4422 David Kastrup: Patch: Make music functions callable from Scheme http://code.google.com/p/lilypond/issues/detail?id=4421 REVIEW: James Lowe: Patch: add stencil-whiteout-outline function http://code.google.com/p/lilypond/issues/detail?id=4418 WAITING: Urs Liska: Patch: Issue 3916: Add \alternatingTimeSignatures http://code.google.com/p/lilypond/issues/detail?id=3918 Mike Solomon: Patch: Prevents vertical axis groups with empty skylines http://code.google.com/p/lilypond/issues/detail?id=3156 Mike Solomon: Patch: Removes the translate_axis call from axis-group-interface outside-staff positioning. http://code.google.com/p/lilypond/issues/detail?id=3134 David Kastrup: Patch: Implement music functions in Scheme rather than C++ http://code.google.com/p/lilypond/issues/detail?id=2716 Valentin Villenave: Attach lilypond source in pdf http://code.google.com/p/lilypond/issues/detail?id=2643 Thank you, James ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: git-cl upload has stopped working (so has patchy)
David Kastrup wrote Sunday, May 31, 2015 11:02 AM > Given the reports that SourceForge distributes Adware (and there even > have been virus-ridden versions of it) on its Windows installers, I'm > somewhat wary here. It would be sort of strange to use project > facilities there without offering downloads, and I suspect if we do > that, SourceForge might decide to put "enhanced" downloads there by > themselves. A bit of a pity: they've been a rather important resource > and rallying point for free software at one point of time. I have received several promotional emails since I registered with SourceForge (when I foolishly omitted to tick the box turning them off), and so far my attempts to turn them off post hoc have been ignored, but none of the emails contained malware, and they are not terribly frequent. But I am certainly not suggesting offering downloads from SF. It may be strange to use their project facilities without offering downloads, but I suspect lots of projects there are in development prior to achieving (and probably many are unlikely ever to achieve) a download-capable state. It doesn't seem to be against their rules. Trevor ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: add stencil-whiteout-outline function (issue 236480043 by paulwmor...@gmail.com)
Hello, Am 31.05.2015 um 03:07 schrieb k-ohara5...@oco.net: I realize I am changing my opinion here on a few points: […] (A convert-ly rule may be needed… maybe in any case to change whiteout to whiteout-box? ...or maybe not?) Looking at the existing uses of \whiteout Xxx.whiteout, it does seem best to leave the plain box whiteout in existing scores. Convert-ly to \whiteout-box one way to preserve the behavior, but it would be better to leave the old markup function \whiteout for the old behavior, and add \whiteout-outline. If I may chime in here: I think this is unnecessarily conservative. The new method for whiteout is certainly much more elegant and more what one would expect in the first place, than the method we have been using. It’s rather going to be special cases in which \whiteout-box would be preferable, and in most cases it will be \whiteout-outline, not the other way around. \whiteout-outline is just a bit too clumsy to be used for what is a real improvement. So my vote goes toward \whiteout-box for the old and simply \whiteout for the new markup command. Concerning the grob property: what about .whiteout = #'box for the old and .whiteout = #⟨x⟩ for the new behaviour, x being the thickness, measured in line-thickness? Regards, Simon ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: git-cl upload has stopped working (so has patchy)
Federico Bruni wrote Sunday, May 31, 2015 11:09 AM > Actually, Google Code exports to Github. I tried, just to see what > happens and it turned out that the standard export works only for > issues <1000. Here's the FAQ: > https://code.google.com/p/support-tools/wiki/GitHubExporterFAQ#Error_%22Project_cannot_be_migrated_because_it_has_too_many_i That's not much use then. > Only an owner on Google Code (I'm a committer only) can try Google > Takeout: > https://code.google.com/p/support-tools/wiki/IssueExporterTool > > I wonder if the JSON dump can contain images... I used the IssueExporterTool way back in March. The JSON file contains only references to images; you have then to write a script to process the JSON file, extract the urls, and somehow reattach them to the Issue posts after the Issues have been loaded into a DB. Maybe not too difficult, but I've not tried it. Fortunately Allura does all this automatically, although it does take 36 hours, probably due to a activity-limiting control. Trevor ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: git-cl upload has stopped working (so has patchy)
Werner LEMBERG wrote Sunday, May 31, 2015 11:41 AM (FWIW my preference would be to run Allura at Savannah as our primary DB, with a backup being maintained at SF, which I would be happy to do on a monthly basis.) >>> >>> This sounds like a sensible approach. >> >> Given the reports that SourceForge distributes Adware (and there >> even have been virus-ridden versions of it) on its Windows >> installers, I'm somewhat wary here. [...] > > If I understand Trevor correctly, he talks about the bug tracker only. Yes. Trevor ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Fix png filename handling (issue 241760043 by truer...@gmail.com)
I've pushed Issue 4417 / 3: Fix png filename handling authorMasamichi Hosoda Sun, 24 May 2015 14:20:30 + (23:20 +0900) committer Masamichi Hosoda Sun, 31 May 2015 13:27:28 + (22:27 +0900) commit6a59207988b737482012aee97c6d3d5c1458a750 Issue 4417 / 2: Use ly:system in make-ps-images (ps-to-png.scm) authorMasamichi Hosoda Sun, 24 May 2015 13:14:53 + (22:14 +0900) committer Masamichi Hosoda Sun, 31 May 2015 13:27:27 + (22:27 +0900) commite 951c7975ad91c03e52856b954206d83fa04dcb1 Issue 4417 / 1: Delete duplicate procedures in ps-to-png.scm authorMasamichi Hosoda Sun, 24 May 2015 05:28:43 + (14:28 +0900) committer Masamichi Hosoda Sun, 31 May 2015 13:27:27 + (22:27 +0900) commit42494c126671d9b70f7274ef502c9dc33e72177f https://codereview.appspot.com/241760043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Add Netpbm messages to verbose output (issue 240950043 by truer...@gmail.com)
Reviewers: J_lowe, Message: I've pushed. Issue 4420: Add Netpbm messages to verbose output authorMasamichi Hosoda Mon, 25 May 2015 14:41:16 + (23:41 +0900) committer Masamichi Hosoda Sun, 31 May 2015 13:39:19 + (22:39 +0900) commitb666e5959e3eb170e57bb1937f9589cfbe7c0ae4 Description: Add Netpbm messages to verbose output Messages of Netpbm commands (pngtopnm, pnmscale, pnmtopng) output to /dev/null. So those messages couldn't be read. This patch can add them to verbose output, and they can be read. Please review this at https://codereview.appspot.com/240950043/ Affected files (+20, -15 lines): M scm/ps-to-png.scm Index: scm/ps-to-png.scm diff --git a/scm/ps-to-png.scm b/scm/ps-to-png.scm index 3b6b6c2452c719aa9963685d30861944172af19c..a0ad39253a03b85bd2c80d923d7ced8ce660a3fe 100644 --- a/scm/ps-to-png.scm +++ b/scm/ps-to-png.scm @@ -71,20 +71,25 @@ (if exit-on-error (exit 1 status) -(define (scale-down-image be-verbose factor file) - (define (with-pbm) -(let* ((status 0) - (old (string-append file ".old"))) - - (rename-file file old) - (my-system - be-verbose #t - (format #f - "pngtopnm \"~a\" | pnmscale -reduce ~a 2>/dev/null | pnmtopng -compression 9 2>/dev/null > \"~a\"" - old factor file)) - (delete-file old))) - - (with-pbm)) +(define (scale-down-image factor file) + (let* ((old (string-append file ".old")) + ;; Netpbm commands (pngtopnm, pnmscale, pnmtopng) + ;; outputs only standard output instead of a file. + ;; So we need pipe and redirection. + ;; However, ly:system can't handle them. + ;; Therefore, we use /bin/sh for handling them. + ;; FIXME: MinGW (except Cygwin) doesn't have /bin/sh. + (cmd + (list + "/bin/sh" + "-c" + (ly:format +"pngtopnm \"~a\" | pnmscale -reduce ~a | pnmtopng -compression 9 > \"~a\"" +old factor file + +(rename-file file old) +(ly:system cmd) +(delete-file old))) (define-public (ps-page-count ps-name) (let* ((byte-count 10240) @@ -177,5 +182,5 @@ (if (not (= 1 anti-alias-factor)) (for-each - (lambda (f) (scale-down-image be-verbose anti-alias-factor f)) files)) + (lambda (f) (scale-down-image anti-alias-factor f)) files)) files))) ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: add stencil-whiteout-outline function (issue 236480043 by paulwmor...@gmail.com)
On Sun, 31 May 2015 05:03:05 -0700, Simon Albrecht wrote: (A convert-ly rule may be needed… maybe in any case to change whiteout to whiteout-box? ...or maybe not?) Looking at the existing uses of \whiteout Xxx.whiteout, it does seem best to leave the plain box whiteout in existing scores. Convert-ly to \whiteout-box one way to preserve the behavior, but it would be better to leave the old markup function \whiteout for the old behavior, and add \whiteout-outline. If I may chime in here: I think this is unnecessarily conservative. The new method for whiteout is certainly much more elegant and more what one would expect in the first place, than the method we have been using. It’s rather going to be special cases in which \whiteout-box would be preferable, and in most cases it will be \whiteout-outline, not the other way around. \whiteout-outline is just a bit too clumsy to be used for what is a real improvement. The markup-function name could easily be shortened so something like \outline. Searching mutopiaproject.org for 'whiteout' I found a few uses like this \markup \whiteout \pad-markup #0.4 \dynamic ff which work differently with the new behavior so the padding no longer affects the white-out dimension. That is what made me more conservative. A convert-ly rule to preserve the old behavior would be fine. ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Music_iterator::process timekeeping
I have some questions about this. > void > Auto_change_iterator::process (Moment m) > { > Music_wrapper_iterator::process (m); > > Moment now = get_outlet ()->now_mom (); > Moment *splitm = 0; > if (start_moment_.main_part_.is_infinity () && start_moment_ < 0) > start_moment_ = now; 1. Is there any input for which m != now? Favoring an implicit parameter (now) over an explicit parameter (m) smells fishy, but that’s about all I can say at the moment; the iteration code is rather complicated, and there are not many comments to help me. 2. Is there any input for which start_moment_ != this->music_start_mom()? I tried using “m” and “music_start_mom()” in lieu of the above, both in Auto_change_iterator and in Part_combine_iterator. I found no difference in any of the regression tests. You can see my experimental changes at https://codereview.appspot.com/242900043/ . Thanks, — Dan ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Issue 4427: clean up finding & changing of contexts in C++ (issue 238670043 by nine.fierce.ball...@gmail.com)
Reviewers: , Description: clean up finding & changing of contexts in C++ Combine the key feature of Change_iterator and Auto_change_iterator into a common function (favoring the logic of Change_iterator). Define functions for various context-search loops. Please review this at https://codereview.appspot.com/238670043/ Affected files (+128, -146 lines): M lily/accidental-engraver.cc M lily/auto-change-iterator.cc M lily/change-iterator.cc M lily/context.cc M lily/grace-engraver.cc M lily/include/change-iterator.hh M lily/include/context.hh M lily/lyric-combine-music-iterator.cc M lily/lyric-engraver.cc M lily/note-head-line-engraver.cc ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: git-cl upload has stopped working (so has patchy)
2015-05-28 10:41 GMT+02:00 David Kastrup : > James Lowe writes: > >> On 28/05/15 07:20, David Kastrup wrote: >>> And no idea what this means for Patchy. >> >> Well you cannot run any of the test/accept/reject scripts. >> >> The last two are not a huge deal but test-patchy means I probably won't >> be able to be as productive during normal working hours as before (i.e. >> I'll need to manually run the test-baseline/apply/check commands. >> >> That's not anything complicated but just a little more (attended) work. > > Well, too much attended work wears people down. Very true. I was beaten as well: https://code.google.com/p/lilypond/issues/detail?id=4428 I'd appreciate some advice for a dummy. Read that as "advice for a dummy of a trained monkey" ... Right now I'm too tired to try what was mentioned already in this thread cheers, Harm > But with regard to > using Google Code, we are forced into a transition anyway, so work we > invest here will be good for a few months only. Which is still > something. So it may still be worth getting a rough version of > automatism back to work, even though finetuning it would seem like a > waste of time. > > -- > David Kastrup > > ___ > lilypond-devel mailing list > lilypond-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/lilypond-devel ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Music_iterator::process timekeeping
Dan Eble writes: > I have some questions about this. > >> void >> Auto_change_iterator::process (Moment m) >> { >> Music_wrapper_iterator::process (m); >> >> Moment now = get_outlet ()->now_mom (); >> Moment *splitm = 0; >> if (start_moment_.main_part_.is_infinity () && start_moment_ < 0) >> start_moment_ = now; > > 1. Is there any input for which m != now? First thing that comes to mind is inside of \grace { ... } > 2. Is there any input for which start_moment_ != this->music_start_mom()? zero-length music before grace notes? -- David Kastrup ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: git-cl upload has stopped working (so has patchy)
Trevor Daniels treda.co.uk> writes: > The next step is to decide our preference: do we want to take on the > commitment to maintain Allura ourselves or use the maintained version at > SourceForge. Which would we prefer? (FWIW my preference would be > to run Allura at Savannah as our primary DB, with a backup being maintained > at SF, which I would be happy to do on a monthly basis.) I just read the threads since March on this topic. I'm not willing to help with administration, so appreciate everyone who is. If running Allura on savannah.gnu.org is possible that does seem best. There is another fallback in the native bug-tracking on Savane. It does handle a larger project https://savannah.gnu.org/bugs/?group=octave and accepts images, but you have to click the attachment links to see them http://savannah.gnu.org/bugs/?func=detailitem&item_id=28346 The user interface is nostalgic, but usable. ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel