Re: additional dictionaries

[julien2412]

JE G wrote
> ...
> What are the requirements to get a word list like this into a specialized
> spelling dictionary? Is there software to do it or a special format?

Hello,

There's this https://wiki.documentfoundation.org/Development/Dictionaries
about dictionaries but I don't think it would help in your case.

It could be an extension, eg:
http://extensions.libreoffice.org/extension-center?getCategories=Dictionary&getCompatibility=any&sort_on=positive_ratings&path=%2FLibreOffice-Extensions-and-Templates%2Fextension-center&portal_type=PSCProject&SearchableText=
I found this link
https://wiki.documentfoundation.org/Development/Extension_Development
I must recognize, I never made an extension so couldn't help more about it.

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/additional-dictionaries-tp4116200p4116513.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Some dialogs don't work in OS X (master branch)

[julien2412]

I could reproduce this with master sources updated today and MacOs 10.9.4.
Would it be possible you submit a new bugtracker by using this link:
https://www.libreoffice.org/get-help/bug/
?

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/Some-dialogs-don-t-work-in-OS-X-master-branch-tp4116738p4116811.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Suspicious attribute style:repeat="scale"

[julien2412]

After some Googling, I only found this:
https://wiki.openoffice.org/wiki/User:Frank_Sch%C3%B6nheit/ODF_Proposals/Image_Control_Scale



--
View this message in context: 
http://nabble.documentfoundation.org/Suspicious-attribute-style-repeat-scale-tp4117240p4117258.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Questions about getCppuType

[julien2412]

As you may have seen, I've begun to replace occurences.
Just to be sure, is "Sequence" always a shortcut of "css::uno::Sequence" or
could it be something else sometimes? (I mean something not related to
css::uno)
Idem for "Reference", could it be something else that "css::uno::Reference"?

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/Questions-about-getCppuType-tp4106361p4108300.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[SOLVED] Re: About removing macros

[julien2412]

About "DECL_PROP1IMPL", "DECL_PROP0" and others, patches pushed on master
(eg:
http://cgit.freedesktop.org/libreoffice/core/commit/?id=aa214079b4e9df493b57fbf815460b7164225f2b
http://cgit.freedesktop.org/libreoffice/core/commit/?id=0fadbdbbdbd55cf60f9a202f1cf7b1d60517078c)

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/About-removing-macros-tp4106620p4108694.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Question unoType for getXmlToken (dbaccess/reportdesign module)

[julien2412]

Hello,

I noticed this:
s_aTypeNameMap[GetXMLToken( XML_FLOAT)] = ::cppu::UnoType::get();
present at 2 locations:
See
http://opengrok.libreoffice.org/search?q=%22GetXMLToken%28+XML_FLOAT%29%22&project=core&defs=&refs=&path=&hist=

Why shouldn't be this:
s_aTypeNameMap[GetXMLToken( XML_FLOAT)] = ::cppu::UnoType::get();
?

(If "double" is ok, I'll comment the code accordingly).

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/Question-unoType-for-getXmlToken-dbaccess-reportdesign-module-tp4109071.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Wrong copy paste in ucbcmds.cxx? (ucb module)

[julien2412]

Hello,

I noticed this part:
236 CommandProcessorInfo::CommandProcessorInfo()
237 {
238 m_pInfo = new uno::Sequence< ucb::CommandInfo >( 2 );
239 
240 (*m_pInfo)[ 0 ]
241 = ucb::CommandInfo(
242 OUString( GETCOMMANDINFO_NAME ), // Name
243 GETCOMMANDINFO_HANDLE, // Handle
244 getCppuVoidType() ); // ArgType
245 (*m_pInfo)[ 1 ]
246 = ucb::CommandInfo(
247 OUString( GLOBALTRANSFER_NAME ), // Name
248 GLOBALTRANSFER_HANDLE, // Handle
249 cppu::UnoType::get()
); // ArgType
250 (*m_pInfo)[ 2 ]
251 = ucb::CommandInfo(
252 OUString( CHECKIN_NAME ), // Name
253 CHECKIN_HANDLE, // Handle
254 cppu::UnoType::get()
); // ArgType
255 }
See
http://opengrok.libreoffice.org/xref/core/ucb/source/core/ucbcmds.cxx#257

I wonder if line 254 could be a wrong copy paste and should be:
cppu::UnoType::get() ); 

Any idea?

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/Wrong-copy-paste-in-ucbcmds-cxx-ucb-module-tp4109103.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Questions about getCppuType

[julien2412]

I noticed that if I did this:
diff --git a/cppu/qa/test_unotype.cxx b/cppu/qa/test_unotype.cxx
index bbea200..f0d2b03 100644
--- a/cppu/qa/test_unotype.cxx
+++ b/cppu/qa/test_unotype.cxx
@@ -271,8 +271,8 @@ void Test::testUnoType() {
 void Test::testGetTypeFavourUnsigned() {
 CPPUNIT_ASSERT(typeid(::sal_Unicode) == typeid(::sal_uInt16));
 CPPUNIT_ASSERT(
-::getCppuType(static_cast< ::sal_Unicode * >(0)) ==
-::getCppuType(static_cast< ::sal_uInt16 * >(0)));
+cppu::UnoType::get() ==
+cppu::UnoType::get() );

make cppu gives this:
/home/julien/compile-libreoffice/libreoffice/cppu/qa/test_unotype.cxx:275:(anonymous
namespace)::Test::testGetTypeFavourUnsigned
assertion failed
- Expression: cppu::UnoType::get() ==
cppu::UnoType::get()

test_unotype.cxx:275:Assertion
Test name: (anonymous namespace)::Test::testGetTypeFavourUnsigned
assertion failed
- Expression: cppu::UnoType::get() ==
cppu::UnoType::get()

Failures !!!
Run: 3   Failure total: 1   Failures: 1   Errors: 0

I don't understand why it's failing in this case.
Any idea?

Also, I noticed this:
273 CPPUNIT_ASSERT(
274 ::getCppuType(static_cast< ::sal_Unicode * >(0)) ==
275 ::getCppuType(static_cast< ::sal_uInt16 * >(0)));


551 CPPUNIT_ASSERT(
552 ::getCppuType< ::sal_Unicode >() == ::getCppuType<
::sal_uInt16 >());
How could the line 552 be converted to remove getCppuType? (compared with
first case)

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/Questions-about-getCppuType-tp4106361p4109104.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[SOLVED] Re: Question unoType for getXmlToken (dbaccess/reportdesign module)

[julien2412]

Thank you Lionel for your detailed feedback!

I quoted you for the comment, see
http://cgit.freedesktop.org/libreoffice/core/commit/?id=f62de9113a4866f7152acbe0e8221c594b7a7b68

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/Question-unoType-for-getXmlToken-dbaccess-reportdesign-module-tp4109071p4109125.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Questions about getCppuType

[julien2412]

I noticed there are a lot of "Reference" without prefix.
Is there a way to be sure it's ok to replace these occurences by
cppu::UnoType... ?



--
View this message in context: 
http://nabble.documentfoundation.org/Questions-about-getCppuType-tp4106361p4109226.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Questions about getCppuType

[julien2412]

Athomas: indeed, I hope there's another way because I'm running a simple
regexp to replace the occurences:-)



--
View this message in context: 
http://nabble.documentfoundation.org/Questions-about-getCppuType-tp4106361p4109260.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[SOLVED] Re: Wrong copy paste in ucbcmds.cxx? (ucb module)

[julien2412]

sberg wrote
> ...
>> I wonder if line 254 could be a wrong copy paste and should be:
>> cppu::UnoType
> 
> ::get() );
> 
> Yes, that's wrong.  (See UniversalContentBroker::execute in 
> ucb/source/core/ucb.cxx, where CHECKIN_HANDLE/CHECKIN_NAME expects to 
> get a CheckinArgument, not a GlobalTransferCommandArgument.

Thank you Stephan for your feedback.
I pushed the fix on master (see
http://cgit.freedesktop.org/libreoffice/core/commit/?id=f332958999cc38ad778ac381cc67d249e9bd918a)
I didn't "gerrit review" on 4.2 since it's not related to a known bug but if
you want to, I can.

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/Wrong-copy-paste-in-ucbcmds-cxx-ucb-module-tp4109103p4109522.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Questions about getCppuType

[julien2412]

After lots of changes, there are still Sequence cases + things like:
::getCppuType(&m_sFilter));

just to be sure, should it replaced by "cppu::UnoType< type of m_sFilter
>::get();" ?

Also, are there special cases to take into account for these?

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/Questions-about-getCppuType-tp4106361p4109975.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

About removing Browser Plugin

[julien2412]

Hello,

Following https://bugs.freedesktop.org/show_bug.cgi?id=45071, it seems
"Browser plugin" can be removed from 4.4

To do this, I thought git removing core/extensions/source/plugin/, + tune
some mk file in core/extensions and finally core/configure.ac should be ok.

1) Is it ok? Am I forgetting something?
2) Should this be removed from 4.3 too?
3) In a second time, I thought about putting all "Browser plugin"
bugtrackers at WONTFIX, ok for this?

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/About-removing-Browser-Plugin-tp4110455.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

LibreOffice, about avoiding "attempt to erase from container with a past-the-end iterator"

[julien2412]

Hello,

I noticed this interesting change
http://cgit.freedesktop.org/libreoffice/core/commit/?id=72827968e606adcdf8c16e5381b887180975ae46
("Try to avoid "attempt to erase from container with a past-the-end
iterator")
I tried to search similar cases in Opengrok and found some of them (because
quite often a same mistake is made several times)

See
http://opengrok.libreoffice.org/search?q=%22erase%28+std%3A%3Afind%22&project=core&defs=&refs=&path=&hist=

Should we apply the fix for all of them or it's not so automatic because in
some cases we're 100% sure "find" function retrieves a dereferenceable
iterator?

Remark : some would say, no bug no change, I'd tend to think to prevent from
waiting for the bugs if we can be sure of the fix.

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/LibreOffice-about-avoiding-attempt-to-erase-from-container-with-a-past-the-end-iterator-tp4110615.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[SOLVED] Re: LibreOffice, about avoiding "attempt to erase from container with a past-the-end iterator"

[julien2412]

Thank you Stephan for your feedback, so I'll let this as it is.

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/LibreOffice-about-avoiding-attempt-to-erase-from-container-with-a-past-the-end-iterator-tp4110615p4110679.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Strange part in connectivity/source/drivers/jdbc/tools.cxx

[julien2412]

Hello,

I noticed this part:
113 // this is a special property to find the jdbc driver
114 if  (   pBegin->Name.compareToAscii( "JavaDriverClass" )
115 &&  pBegin->Name.compareToAscii( "JavaDriverClassPath" )
116 &&  pBegin->Name.compareToAscii( "SystemProperties" )
117 &&  pBegin->Name.compareToAscii( "CharSet" )
etc.

See
http://opengrok.libreoffice.org/xref/core/connectivity/source/drivers/jdbc/tools.cxx#113

Looking at git history, I found:
- initial import (in 2000), if(!bFound ||
pBegin->Name.compareToAscii("JDBCDRV")) 
- then f(!pBegin->Name.compareToAscii("JDBCDRV"))
(1d58d0115e25d2be02cdbccbf10573927a1d6371)
- if(!pBegin->Name.compareToAscii("JavaDriverClass"))
(a3a2a42839a754c604e24f02f7dc8629525435ea)

But then:
- if(pBegin->Name.compareToAscii("JavaDriverClass")) from 2001
(53ca3ba5619c2952bb39d643f45a916f8e5005b2)
- if( pBegin->Name.compareToAscii("JavaDriverClass") &&
pBegin->Name.compareToAscii("CharSet"))
(e8ffa01cda7c46398e4d85d51c90b5d1092595b5)

and it goes on...

1) So either all the "&&" should be replaced by "||" or "!" should be put
back and set for each one or did I miss something obvious?

2) Should we complete this similar list here:
http://opengrok.libreoffice.org/xref/core/dbaccess/source/inc/stringconstants.inc#220
(used here :
http://opengrok.libreoffice.org/xref/core/dbaccess/source/ui/dlg/DbAdminImpl.cxx#175)
and use alias macros? 

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/Strange-part-in-connectivity-source-drivers-jdbc-tools-cxx-tp4110680.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [SOLVED] Re: Strange part in connectivity/source/drivers/jdbc/tools.cxx

[julien2412]

Lionel Elie Mamane wrote
>> ...or, of course, even better yet,
> 
>>   pBegin->Name != "JavaDriverClass" ...
> 
> Yes, Julien, this one is IMHO worth doing. It makes the code that much
> more readable :)

Done now on master, see
http://cgit.freedesktop.org/libreoffice/core/commit/?id=6cc359f8d739a92c2695a5248dfbb49f43d1ca6e

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/Strange-part-in-connectivity-source-drivers-jdbc-tools-cxx-tp4110680p4110871.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: avoiding cppunit zerodiv correction

[julien2412]

Matteo Casalin-3 wrote
> ...
> I don't have any comment about your proposal, but just would like to
> add that unless we know for sure that nHeight!=0 at that point, in
> both codes the check should be
> 
> if( nHeight <= 0 )
> 
> in order to solve the division by 0 completely.

You're right of course.

Sorrry for this change which was indeed wrong, I reverted it (see
http://cgit.freedesktop.org/libreoffice/core/commit/?id=ea15c9dc4da75fcd56e6b0dbce473b9e912fa4e2)

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/avoiding-cppunit-zerodiv-correction-tp4110788p4110872.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Some checkings related to

[julien2412]

Hello,

Taking a look at https://bugs.freedesktop.org/show_bug.cgi?id=79499, I
opengroked xub_StrLen and found some references.
Most of them are just comments but there are associated checks
See
http://opengrok.libreoffice.org/search?q=xub_StrLen&project=core&defs=&refs=&path=&hist=
I wonder if these checks may be wrong now.

Any idea?

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/Some-checkings-related-to-tp4110999.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Build fail with MacOs in connectivity part

[julien2412]

Hello,

I gave a try to a MacOs build and had this error:
[build CXX] connectivity/source/drivers/odbc/OTools.cxx
/lo/core/connectivity/source/drivers/odbc/OPreparedStatement.cxx:338:9:
error: static_assert failed "sizeof(SQLWCHAR) == 2"
BOOST_STATIC_ASSERT( sizeof(SQLWCHAR)== 2 );
^
/lo/core/workdir/UnpackedTarball/boost/boost/static_assert.hpp:78:41: note:
expanded from macro 'BOOST_STATIC_ASSERT'
# define BOOST_STATIC_ASSERT( ... ) static_assert(__VA_ARGS__,
#__VA_ARGS__)
^
[build CXX] connectivity/source/drivers/odbc/ODatabaseMetaDataResultSet.cxx
1 error generated.
make[1]: ***
[/lo/core/workdir/CxxObject/connectivity/source/drivers/odbc/OPreparedStatement.o]
Error 1
make[1]: *** Waiting for unfinished jobs
/lo/core/connectivity/source/drivers/odbc/OTools.cxx:420:9: error:
static_assert failed "sizeof(SQLWCHAR) == 2"
BOOST_STATIC_ASSERT(sizeof(SQLWCHAR)== 2);
^   
/lo/core/workdir/UnpackedTarball/boost/boost/static_assert.hpp:78:41: note:
expanded from macro 'BOOST_STATIC_ASSERT'
# define BOOST_STATIC_ASSERT( ... ) static_assert(__VA_ARGS__,
#__VA_ARGS__)
^
1 error generated.
make[1]: ***
[/lo/core/workdir/CxxObject/connectivity/source/drivers/odbc/OTools.o] Error
1
make: *** [build] Error 2

I use MacOs 10.9.3
XCode: 5.1.1

autogen.input:
--with-system-odbc
--enable-ext-barcode
--enable-ext-diagram
--enable-ext-hunart
--enable-ext-nlpsolver
--enable-ext-ct2n
--enable-ext-numbertext
--enable-postgresql-sdbc
--enable-ext-typo
--enable-ext-validator
--enable-ext-watch-window
--enable-ext-wiki-publisher
--enable-dbus
--enable-graphite
--enable-werror
--enable-debug
--enable-dbgutil
--enable-crashdump
--enable-dependency-tracking
--enable-online-update
--enable-extra-sample
--enable-extra-template
--enable-extra-gallery
--enable-python=internal
#--enable-ext-mariadb-connector
#--with-system-mariadb
#--enable-bundle-mariadb
--enable-avahi
--enable-eot
--disable-gstreamer-0.10
--enable-gstreamer
--enable-odk
#--with-lang=en-US it fr de es pt ru cs hu pl da sv el sk is nl
--with-lang=ALL
--with-myspell-dicts
--without-junit

Any idea?

Julien





--
View this message in context: 
http://nabble.documentfoundation.org/Build-fail-with-MacOs-in-connectivity-part-tp4111804.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Build fail with MacOs in connectivity part

[julien2412]

Trying to unwind, I found this:
http://opengrok.libreoffice.org/xref/core/external/unixODBC/inc/odbc/sqltypes.h#112
112 #ifdef SQL_WCHART_CONVERT
113 typedef wchar_t WCHAR;
114 #else
115 typedef unsigned short  WCHAR;
116 #endif

After a test, I confirm that unsigned short has a size of 2 bytes.
So it means that WCHAR is made from wchart_t

but then I'm stuck because I don't know where's defined  SQL_WCHART_CONVERT
(and what it is)




--
View this message in context: 
http://nabble.documentfoundation.org/Build-fail-with-MacOs-in-connectivity-part-tp4111804p4111807.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Build fail with MacOs in connectivity part

[julien2412]

Sorry Lionel, I had just checked my emails, not the forum. I'll take a look

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/Build-fail-with-MacOs-in-connectivity-part-tp4111804p4111817.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Build fail with MacOs in connectivity part

[julien2412]

Indeed Norbert is right, I got this:
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.8.sdk/usr/include/odbcinst.h
and SQLWCHAR is defined as Norbert indicated.

I suppose it's 64 bits since config.log displays this:
build='x86_64-apple-darwin13.2.0'
build_cpu='x86_64'
host_cpu='x86_64'

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/Build-fail-with-MacOs-in-connectivity-part-tp4111804p4111839.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Build fail with MacOs in connectivity part

[julien2412]

Thank you Tor for these advice, I removed them.

About Ant, Autoconf and Automake, I used brew. Concerning Junit, I disabled
it.
About 64 bits, indeed I hadn't put --enable-64-bits, I added it.
Finally about Windows, I'm aware there's a pb with 64 build. I did try 1 or
2 years ago to build (just simple 32 bits) on Windows with Cygwin and had
failed. Perhaps I'll give a try another time since I was on Vista and  now
I've got Seven :-)

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/Build-fail-with-MacOs-in-connectivity-part-tp4111804p4111854.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Access2Base - New release

[julien2412]

Hi,

I read the whole thread and tried to understand, "tried" because I'm not
enough "fluent" in these technical/internal LO part.

Why A2B must be quickly (I mean without waiting for next LO version)
"upgradable"?
Either it's stable and so we don't absolutely need to upgrade it quickly or
it's unstable and therefore it shouldn't access to LO core parts anyway.
In first case, A2B could be bundled extension, in the second case  a simple
extension because there'll be fix upgrades to become stable (or at least
"enough stable").
So if A2B can be considered as enough stable and therefore can be a bundled
extension, it means fixes from A2B can be included in the different versions
(not only major) from LO 4.3.1, 4.3.2, etc. (like external libs)

Now about new LO version which would include last patches from A2B compared
with old LO version, yes companies should upgrade in this case or they're
still have the possibility to build LO from the sources with the required
patches, they're free to do it as we're free to try to harden LO a bit.

In conclusion IMHO b534967caca6767cd2100da363b1da2433640ddd should be
reverted.

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/Access2Base-New-release-tp4108421p4112581.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Build fails on CppunitTest_svl_qa_cppunit

[julien2412]

Hello,

With master sources updated today, the build fails with this console logs:
/home/julien/compile-libreoffice/libreoffice/svl/qa/unit/svl.cxx:403:(anonymous
namespace)::Test::testFdo44286
equality assertion failed
- Expected: 1902-04-22
- Actual  : -04-DD

svl.cxx:403:Assertion
Test name: (anonymous namespace)::Test::testFdo44286
equality assertion failed
- Expected: 1902-04-22
- Actual  : -04-DD

Failures !!!
Run: 7   Failure total: 1   Failures: 1   Errors: 0

I didn't see this problem on TBs so thought it might interest you.

Here's my autogen.input:
--with-system-odbc
--enable-ext-barcode
--enable-ext-diagram
--enable-ext-hunart
--enable-ext-nlpsolver
--enable-ext-ct2n
--enable-ext-numbertext
--enable-postgresql-sdbc
--enable-ext-typo
--enable-ext-validator
--enable-ext-watch-window
--enable-ext-wiki-publisher
--enable-dbus
--enable-graphite
--enable-werror
--enable-debug
--enable-dbgutil
--enable-crashdump
--enable-dependency-tracking
--enable-online-update
--enable-extra-sample
--enable-extra-template
--enable-extra-gallery
--enable-python=internal
--enable-ext-mariadb-connector
--with-system-mariadb
--enable-bundle-mariadb
--enable-avahi
--enable-eot
--disable-gstreamer-0.10
--enable-gstreamer
--enable-odk
--with-lang=ALL
--with-myspell-dicts

Any idea?

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/Build-fails-on-CppunitTest-svl-qa-cppunit-tp4112827.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[SOLVED] Re: Build fails on CppunitTest_svl_qa_cppunit

[julien2412]

Solved thanks to Lionel and Isamu (see
http://nabble.documentfoundation.org/fdo-44286-unittest-fails-in-non-English-locale-td4112845.html)



--
View this message in context: 
http://nabble.documentfoundation.org/Build-fails-on-CppunitTest-svl-qa-cppunit-tp4112827p4112855.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: I need to better understand our css::uno::Reference

[julien2412]

Hello,

Sorry for this certainly naive and humble (because I wouldn't be able at all
to help here) question, but just by curiosity, is there some plan to rewrite
partly/clean UNO in order to:
- not depend on vtables implementation
- avoid to use of reinterpret_cast (and therefore possibly detect errors
during build)
- more generally make things clearer/simplify
- (multiple inheritance but do we want/need it?)
?

Of course I know that historical can have a huge impact so I would
understand easily there's no plan for the moment.

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/I-need-to-better-understand-our-css-uno-Reference-tp4112779p4113340.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Cppcheck:"Logical disjunction always evaluates to true" in svdotextdecomposition.cxx (svx module)

[julien2412]

Hello,

Cppcheck reported this:
1237incorrectLogicOperator  style   Logical disjunction always evaluates to
true: nRepeat||!nRepeat.
in svx/source/svdraw/svdotextdecomposition.cxx
Indeed, we've got this:
   1236 // loop. In loop, move through
   1237 if(nRepeat || 0L == nRepeat)
   1238 {
   1239 drawinglayer::animation::AnimationEntryLoop aLoop(nRepeat ?
nRepeat : ENDLESS_LOOP);
   1240 drawinglayer::animation::AnimationEntryLinear
aThrough(fTimeFullPath, fFrequency, bForward ? 0.0 : 1.0, bForward ? 1.0 :
0.0);
   1241 aLoop.append(aThrough);
   1242 rAnimList.append(aLoop);
   1243 }
See
http://opengrok.libreoffice.org/xref/core/svx/source/svdraw/svdotextdecomposition.cxx#1237

First I thought about removing the test about nRepeat == 0L but line 1239
expects to have nRepeat different or equal to 0.

Any idea?

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/Cppcheck-Logical-disjunction-always-evaluates-to-true-in-svdotextdecomposition-cxx-svx-module-tp4121365.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Missing image warning

[julien2412]

Hello Chris,

You might be interested in this bugtracker:
https://bugs.freedesktop.org/show_bug.cgi?id=83315
Other: could not load image http://nabble.documentfoundation.org/Missing-image-warning-tp4121972p4122004.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

About recent commits for C++11 building

[julien2412]

Hello,

Following last commits for MacOs which increases compatibility with C++11,
I'd like to know if:
1)  we can replace all the workaround about the erase iterator management
for some containers (with a temp iterator) and directly use for every case
for eg:
it = itcontainer.erase(it);
2) we can use expm1, log1p (eg: https://gerrit.libreoffice.org/#/c/11434/2)

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/About-recent-commits-for-C-11-building-tp4122219.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[ABANDONNED] Re: About recent commits for C++11 building

[julien2412]

Ok we're still not compatible C++11, see
http://ci.libreoffice.org/job/buildbot/2477/
Sorry for the noise.

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/About-recent-commits-for-C-11-building-tp4122219p413.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Building pb OTools.cxx in MacOs (connectivity part)

[julien2412]

Hello,

On Mac OS 10.9 and master sources updated about 2 days ago, I've got this
building problem:
lo/core/connectivity/source/drivers/odbc/OTools.cxx:462:23: error: no
matching member function for call to 'append'
aData.append(waCharArray, nReadChars);
~~^~
lo/core/include/rtl/ustrbuf.hxx:475:22: note: candidate function not viable:
no known conversion from 'SQLWCHAR [2048]' to 'const sal_Unicode *' (aka
'const unsigned short *') for 1st argument
OUStringBuffer & append( const sal_Unicode * str, sal_Int32 len)
 ^
lo/core/include/rtl/ustrbuf.hxx:661:22: note: candidate function not viable:
no known conversion from 'SQLWCHAR [2048]' to 'sal_Int32' (aka 'int') for
1st argument
OUStringBuffer & append(sal_Int32 i, sal_Int16 radix = 10 )
 ^
lo/core/include/rtl/ustrbuf.hxx:679:22: note: candidate function not viable:
no known conversion from 'SQLWCHAR [2048]' to 'sal_Int64' (aka 'long') for
1st argument
OUStringBuffer & append(sal_Int64 l, sal_Int16 radix = 10 )
 ^
lo/core/include/rtl/ustrbuf.hxx:488:87: note: candidate function template
not viable: requires single argument 'literal', but 2 arguments were
provided
typename libreoffice_internal::ConstCharArrayDetector< T,
OUStringBuffer& >::Type append( T& literal )

 
^
lo/core/include/rtl/ustrbuf.hxx:502:21: note: candidate function template
not viable: requires single argument 'c', but 2 arguments were provided
OUStringBuffer& append( const OUStringConcat< T1, T2 >& c )
^
lo/core/include/rtl/ustrbuf.hxx:586:9: note: candidate function template not
viable: requires 1 argument, but 2 were provided
append( T* ) SAL_DELETED_FUNCTION;
^
lo/core/include/rtl/ustrbuf.hxx:420:22: note: candidate function not viable:
requires single argument 'str', but 2 arguments were provided
OUStringBuffer & append(const OUString &str)
^
lo/core/include/rtl/ustrbuf.hxx:437:22: note: candidate function not viable:
requires single argument 'str', but 2 arguments were provided
OUStringBuffer & append(const OUStringBuffer &str)
 ^
lo/core/include/rtl/ustrbuf.hxx:457:22: note: candidate function not viable:
requires single argument 'str', but 2 arguments were provided
OUStringBuffer & append( const sal_Unicode * str )
 ^
lo/core/include/rtl/ustrbuf.hxx:573:22: note: candidate function not viable:
requires single argument 'b', but 2 arguments were provided
OUStringBuffer & append(bool b)
 ^
lo/core/include/rtl/ustrbuf.hxx:594:22: note: candidate function not viable:
requires single argument 'str', but 2 arguments were provided
OUStringBuffer & append(rtl_uString* str)
 ^
lo/core/include/rtl/ustrbuf.hxx:610:22: note: candidate function not viable:
requires single argument 'b', but 2 arguments were provided
OUStringBuffer & append(sal_Bool b)
 ^
lo/core/include/rtl/ustrbuf.hxx:628:22: note: candidate function not viable:
requires single argument 'c', but 2 arguments were provided
OUStringBuffer & append(char c)
 ^
lo/core/include/rtl/ustrbuf.hxx:644:22: note: candidate function not viable:
requires single argument 'c', but 2 arguments were provided
OUStringBuffer & append(sal_Unicode c)
 ^
lo/core/include/rtl/ustrbuf.hxx:696:22: note: candidate function not viable:
requires single argument 'f', but 2 arguments were provided
OUStringBuffer & append(float f)
 ^
lo/core/include/rtl/ustrbuf.hxx:713:22: note: candidate function not viable:
requires single argument 'd', but 2 arguments were provided
OUStringBuffer & append(double d)
 ^
1 error generated.
make[1]: ***
[/Users/marylinevogel/lo/core/workdir/CxxObject/connectivity/source/drivers/odbc/OTools.o]
Error 1


Any idea?

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/Building-pb-OTools-cxx-in-MacOs-connectivity-part-tp4122263.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Should we use boost::math::log1p/expm1 instead of rtl_math_log1p/expm1 ?

[julien2412]

Hello,

Following
http://cgit.freedesktop.org/libreoffice/core/commit/?id=a3ad01dc1e07da21182077bd899094fd73f57714,
should  it worth it to replace rtl_math_log1p/rtl_math_expm1 and related by
boost::math::log1p/expm1 ?
Or should we let the code as it is right now?

Since we already use Boost, I thought it could be interesting to use it even
more, waiting by a even more C++11 compatibility (since this standard
includes these 2 functions).

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/Should-we-use-boost-math-log1p-expm1-instead-of-rtl-math-log1p-expm1-tp4122334.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Should we use boost::math::log1p/expm1 instead of rtl_math_log1p/expm1 ?

[julien2412]

Andrew Douglas Pitonyak wrote
> Julien, I am curious if you have done any testing.
> ...

Hi Andrew,

First thank you for your feedback.
I must recognize that no, I didn't made any tests.


Andrew Douglas Pitonyak wrote
> No differences were found in this little test. Then again, on Fedora, 
> Boost may be configured to use the built-in implementation, I don't 
> really know. I did not check our source code, but, it might reduce the 
> LO code complexity a little bit, that might be a gain.

Ok, let's wait for a building expert about this.

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/Should-we-use-boost-math-log1p-expm1-instead-of-rtl-math-log1p-expm1-tp4122334p4122614.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[SOLVED] Re: Build fails (-Werror=deprecated-declarations), vcl module

[julien2412]

Thank you Stephan for your patch.

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/Build-fails-Werror-deprecated-declarations-vcl-module-tp4104605p4104688.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Searching help to build LibreOffice

[julien2412]

Hi,

Here's the main page for developpers:
https://wiki.documentfoundation.org/Development
and for LO building on Linux:
https://wiki.documentfoundation.org/Development/BuildingOnLinux

Now which sources are you trying to build? (master, 4.2 branch, ...)

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/Searching-help-to-build-LibreOffice-tp4105103p4105105.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

What encoding is used?

[julien2412]

Hello,

The use of cppcheck-htmlreport to convert raw cppcheck reports errors to
html fails for some files because of the encodings.
Here's an example message:
cppcheck/htmlreport/cppcheck-htmlreport", line 287, in 
content = input_file.read()
  File "/usr/lib/python2.7/codecs.py", line 296, in decode
(result, consumed) = self._buffer_decode(data, self.errors, final)
UnicodeDecodeError: 'utf8' codec can't decode byte 0xfc in position 3546:
invalid start byte

Here's the list of files which give this problem:
./hwpfilter/source/hcode.cxx
./hwpfilter/source/hwpread.cxx
./hwpfilter/source/hbox.h
./hwpfilter/source/formula.cxx
./hwpfilter/source/hwpfile.cxx
./hwpfilter/source/hwpeq.cxx
./chart2/source/view/charttypes/Splines.cxx (was containing 2 "ü" but was
detected as iso-8859-1 and not as utf8 by "file -i"), now converted (see
http://cgit.freedesktop.org/libreoffice/core/commit/?id=42d494e7925249c36f62206e7268d849437e219d)
./hwpfilter/source/hbox.cxx
./hwpfilter/source/hinfo.cxx

I gave a try to ./hwpfilter/source/hinfo.cxx
Initial view on vi (Debian testing x86-64, French)
 56 /**
 57  * ¹®¼­Á¤º¸¸¦ ÀоîµéÀÌ´Â ÇÔ¼ö ( 128 bytes )
 58  * ¹®¼­Á¤º¸´Â ÆÄÀÏÀνÄÁ¤º¸( 30 bytes ) ´ÙÀ½¿¡ À§Ä¡ÇÑ Á¤º¸ÀÌ´Ù.
 59  */
 60 bool HWPInfo::Read(HWPFile & hwpf)

since README from hwpfilter indicates "Hangul Word Processor" and "Korea", I
gave a try with "iconv -f EUC-KR -t utf8 hwpfilter/source/hinfo.cxx >
stdout.txt", I retrieved this:
  56 /**
 57  * 문서정보를 읽어들이는 함수 ( 128 bytes )
 58  * 문서정보는 파일인식정보( 30 bytes ) 다음에 위치한 정보이다.
 59  */
 60 bool HWPInfo::Read(HWPFile & hwpf)

I gave a try to Google translate which detected the language as Korean
(hopefully! :-)) and translated this:
"Function to read the document information"
which seems ok according to the name of the function.
Remark : I don't know what means "( 128 bytes )" or "( 30 bytes)", is it a
pb in conversion?

Anyway, would this conversion be ok on these files or might we lose some
information?
Of course, I prefer cppcheck to fail the html conversion of some reports
than losing important information in these files.
Perhaps too, it's a cppcheck bug or Python bug which should be fixed.

Any idea?

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/What-encoding-is-used-tp4105106.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: HarfBuzz performance problem

[julien2412]

Hi,

Just taking a look to Harfbuzz releases, I noticed there was a 0.9.27
version, current download.lst indicates 0.9.23 (see
http://opengrok.libreoffice.org/xref/core/download.lst).
Even if changelog indicates only micro optim, perhaps it could be
interesting to give it a try. If it doesn't work, at least, investigation in
harfbuzz would start from the most recent version.

Julien




--
View this message in context: 
http://nabble.documentfoundation.org/HarfBuzz-performance-problem-tp4105389p4105434.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Build fail on master

[julien2412]

Hi,

On pc Debian x86-64 with master sources updated today + make clean, I've got
this:
In file included from
/home/julien/compile-libreoffice/libo/basic/source/runtime/methods1.cxx:41:0:
/home/julien/compile-libreoffice/libo/basic/source/inc/runtime.hxx: In
function ‘void SbRtl_CallByName(StarBASIC*, SbxArray&, sal_Bool)’:
/home/julien/compile-libreoffice/libo/basic/source/inc/runtime.hxx:351:10:
error: ‘void SbiRuntime::StepSET_Impl(SbxVariableRef&, SbxVariableRef&,
bool)’ is private
 void StepSET_Impl( SbxVariableRef& refVal, SbxVariableRef& refVar, bool
bDefaultHandling = false );
  ^
/home/julien/compile-libreoffice/libo/basic/source/runtime/methods1.cxx:184:65:
error: within this context
 pRT->StepSET_Impl( pValVar, rFindVar, false );

(gcc (Debian 4.8.2-16) 4.8.2)
autogen.input:
--with-system-odbc
--enable-ext-barcode
--enable-ext-diagram
--enable-ext-hunart
--enable-ext-nlpsolver
--enable-ext-ct2n
--enable-ext-numbertext
--enable-postgresql-sdbc
--enable-ext-typo
--enable-ext-validator
--enable-ext-watch-window
--enable-ext-wiki-publisher
--enable-dbus
--enable-graphite
--enable-werror
--enable-debug
--enable-dbgutil
--enable-crashdump
--enable-dependency-tracking
--enable-online-update
--enable-extra-sample
--enable-extra-template
--enable-extra-gallery
--enable-python=internal
--enable-ext-mariadb-connector
--with-system-mariadb
--enable-bundle-mariadb
--enable-avahi
--enable-eot
--disable-gstreamer-0.10
--enable-gstreamer
--enable-odk

Any idea?



--
View this message in context: 
http://nabble.documentfoundation.org/Build-fail-on-master-tp4105630.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Äbout cpplint

[julien2412]

Hi,

I gave a try to cpplint
(http://google-styleguide.googlecode.com/svn/trunk/cpplint/cpplint.py) with
some changes so it scan subdirectories.
Except pure formatting warnings, it reports things like this:
1) ./drawinglayer/source/primitive2d/polygonprimitive2d.cxx:274:  Consider
using rand_r(...) instead of rand(...) for improved thread safety. 
[runtime/threadsafe_fn]
(other functions quoted in the py script:
 asctime_r, ctime_r, getgrgid_r, getgrnam_r, getlogin_r, getpwnam_r,
getpwuid_r, gmtime_r, localtime_r, strtok_r, ttyname_r)

2) ./fpicker/source/win32/filepicker/comptr.hxx:100:  Unary operator& is
dangerous.  Do not use it.  [runtime/operator] [4]

3) ./crashrep/source/unx/main.cxx:64:  For a static/global string constant,
use a C style string instead: "static char g_strProductKey[]". 
[runtime/string]

4) ./sd/source/ui/remotecontrol/Transmitter.cxx:10:  Streams are highly
discouraged.  [readability/streams]

5) ./sd/source/ui/remotecontrol/mDNSResponder/CommonServices.h:488:  Are you
taking an address of a cast?  This is dangerous: could be a temp var.  Take
the address before doing the cast, rather than after  [runtime/casting]

6) ./include/comphelper/sequenceashashmap.hxx:81:  Single-argument
constructors should be marked explicit.  [runtime/explicit]

7) ./oox/source/helper/binaryoutputstream.cxx:122:  Do not use
variable-length arrays.  Use an appropriately named ('k' followed by
CamelCase) compile-time constant for the size.  [runtime/arrays]

There are other different types of warnings about headers/include guards but
would you have some opinion about these first?

Julien




--
View this message in context: 
http://nabble.documentfoundation.org/About-cpplint-tp4105821.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[SOLVED] Re: About cpplint

[julien2412]

Thank you Stephan for your feedback, so let's drop it.

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/About-cpplint-tp4105821p4106051.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Dead code in escherex.cxx (filter module)

[julien2412]

Hello,

Taking a look to this part:
   4442 if ( nErrCode == ERRCODE_NONE )
   4443 {
    p_EscherBlibEntry->meBlibType = ( eGraphicType
== GRAPHIC_BITMAP ) ? PNG : EMF;
   4445 aStream.Seek( STREAM_SEEK_TO_END );
   4446 p_EscherBlibEntry->mnSize = aStream.Tell();
   4447 pGraphicAry = (sal_uInt8*)aStream.GetData();
   4448 
   4449 if ( p_EscherBlibEntry->meBlibType == WMF )
// the fileheader is not used
   4450 {
   4451 p_EscherBlibEntry->mnSize -= 22;
   4452 pGraphicAry += 22;
   4453 }
   4454 }

I wonder if in line 4449 'WMF' should be changed to 'EMF' or the contrary on
line .
See
http://opengrok.libreoffice.org/xref/core/filter/source/msfilter/escherex.cxx#
A research in Opengrok didn't help:
http://opengrok.libreoffice.org/search?q=%22eGraphicType+%3D%3D+GRAPHIC_BITMAP%22&project=core&defs=&refs=&path=&hist=

Any idea?

Julien 



--
View this message in context: 
http://nabble.documentfoundation.org/Dead-code-in-escherex-cxx-filter-module-tp4106079.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Questions about getCppuType

[julien2412]

Hello,

Seeing the number of times getCppuType is used, I've got several questions
about this:
- what's the use of it? It resembles at the first look to "typeid" but I
suppose it's not this.
- could there be an alternative? (eg a more "native"/straightforward C++
way)?
- if it still must be used, could the C style cast be changed in static cast
(to be sure the cast is in build time and so the check is also  in build
time)?

Julien 



--
View this message in context: 
http://nabble.documentfoundation.org/Questions-about-getCppuType-tp4106361.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Questions about getCppuType

[julien2412]

sberg wrote
> ...
> getCppuType is not without flaws though, and cppu::UnoType should be 
> used instead.
> ...
> What cast are you talking about?  The one in the typical usage like 
> getCppuType((T*)0)?  Sure, nothing keeps you from writing that as 
> getCppuType(static_cast(0)), or better yet, cppu::UnoType
> 
> ::get(), 
> instead.

Thank you Stephan for your feedback and the detailed explanations.
Yes I was talking about this typical usage.
Great if cppu::UnoType::get() is better than getCppuType usage!
It will serve 2 goals then:
1) a better usage
2) a fix to cppcheck report "Expression is always false because 'else if'
condition matches previous condition at line..." for this type of case
(of course, I consider 1) more important but it will kill 2 birds with one
stone)

Eg in sfx2/source/toolbox/tbxitem.cxx, I could change:
else if ( pType == ::getCppuType((const sal_uInt32*)0) )
to 
else if ( pType == cppu::UnoType::get() )

Just to be sure, it would then mean that getCppuType could be removed after
having replaced all the occurences of getCppuType by cppu::UnoType... or are
there some special/specific cases?

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/Questions-about-getCppuType-tp4106361p4106403.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Questions about getCppuType

[julien2412]

I've begun to replace some parts and had this when I've changed this:
else if ( pType == ::getCppuType((const sal_uInt16*)0) )
into this:
else if ( pType == cppu::UnoType::get() )
:
cd /home/julien/compile-libreoffice/libreoffice/sfx2 && make -j 4 -rs
[build CXX] sfx2/source/toolbox/tbxitem.cxx
[build LOC] top level modules: sfx2
[build LOC] loaded modules: sfx2
In file included from
/home/julien/compile-libreoffice/libreoffice/include/com/sun/star/uno/Any.h:25:0,
 from
/home/julien/compile-libreoffice/libreoffice/workdir/UnoApiHeadersTarget/udkapi/normal/com/sun/star/uno/XInterface.hdl:9,
 from
/home/julien/compile-libreoffice/libreoffice/workdir/UnoApiHeadersTarget/udkapi/normal/com/sun/star/lang/XComponent.hdl:10,
 from
/home/julien/compile-libreoffice/libreoffice/workdir/UnoApiHeadersTarget/offapi/normal/com/sun/star/frame/XFrame.hdl:13,
 from
/home/julien/compile-libreoffice/libreoffice/workdir/UnoApiHeadersTarget/offapi/normal/com/sun/star/frame/XFrame.hpp:8,
 from
/home/julien/compile-libreoffice/libreoffice/sfx2/source/toolbox/tbxitem.cxx:27:
/home/julien/compile-libreoffice/libreoffice/include/cppu/unotype.hxx: In
instantiation of ‘static const com::sun::star::uno::Type& cppu::UnoType<
 >::get() [with T = const short unsigned int]’:
/home/julien/compile-libreoffice/libreoffice/sfx2/source/toolbox/tbxitem.cxx:550:69:
  
required from here
/home/julien/compile-libreoffice/libreoffice/include/cppu/unotype.hxx:267:60:
error: invalid conversion from ‘const short unsigned int*’ to ‘const
sal_Int16* {aka const short int*}’ [-fpermissive]
 return cppu_detail_getUnoType(static_cast< T * >(0));
^
/home/julien/compile-libreoffice/libreoffice/include/cppu/unotype.hxx:133:1:
error:   initializing argument 1 of ‘const com::sun::star::uno::Type&
cppu::detail::cppu_detail_getUnoType(const sal_Int16*)’ [-fpermissive]
 cppu_detail_getUnoType(SAL_UNUSED_PARAMETER ::sal_Int16 const *) {
 ^
make[1]: ***
[/home/julien/compile-libreoffice/libreoffice/workdir/CxxObject/sfx2/source/toolbox/tbxitem.o]
Erreur 1
make: *** [sfx2] Erreur 2

The other conversions were ok (I mean gcc hasn't complained).
gcc (Debian 4.8.2-16)

Any idea?

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/Questions-about-getCppuType-tp4106361p4106451.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

About ANIMATIONMODE_VIEW in slideshow module

[julien2412]

Hello,

Just taking a look at slideshow module, I searched about ANIMATIONMODE_VIEW
to understand the difference between it and ANIMATIONMODE_SHOW.
Here is the result:
- once in the enum
- once in a test
so it seems no var can have this value
see
http://opengrok.libreoffice.org/search?q=ANIMATIONMODE_VIEW&project=core&defs=&refs=&path=&hist=

Ok to remove ANIMATIONMODE_VIEW or did I miss something?

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/About-ANIMATIONMODE-VIEW-in-slideshow-module-tp4106488.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Cppcheck reports "Deallocation of an auto-variable results in undefined behaviour" in vcl part

[julien2412]

Hello,

Cppcheck reported this:
[vcl/source/gdi/bitmap4.cxx:229]: (error) Deallocation of an auto-variable
results in undefined behaviour
137 long(*pKoeff)[ 256 ] = new long[ 9 ][ 256 ];
...
229 delete[] pKoeff;
See http://opengrok.libreoffice.org/xref/core/vcl/source/gdi/bitmap4.cxx#137

False positive?
Moreover, I searched info about declaring 2D arrays and this notation new
T[x][y] isn't supposed to work (see
http://stackoverflow.com/questions/936687/how-do-i-declare-a-2d-array-in-c-using-new)
Any idea?

Julien 



--
View this message in context: 
http://nabble.documentfoundation.org/Cppcheck-reports-Deallocation-of-an-auto-variable-results-in-undefined-behaviour-in-vcl-part-tp4106524.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[SOLVED] Re: About ANIMATIONMODE_VIEW in slideshow module

[julien2412]

Thorsten Behrens wrote
> Julien Nabet wrote:
>> Ok to remove ANIMATIONMODE_VIEW or did I miss something?
>> 
> Yep, looks fine to me.

Thank you Thorsten for your feedback, I pushed the patch on master (see
http://cgit.freedesktop.org/libreoffice/core/commit/?id=916cbd94d1c848bc69166915b96ff89ac380c913)

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/About-ANIMATIONMODE-VIEW-in-slideshow-module-tp4106488p4106603.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

About removing macros

[julien2412]

Hello,

I noticed the use of macros like "DECL_PROP1IMPL", "DECL_PROP0" (see
http://opengrok.libreoffice.org/search?q=DECL_PROP1IMPL&project=core&defs=&refs=&path=&hist=).
Does it worth it to remove them?

More generally, what macros could/should be removed?

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/About-removing-macros-tp4106620.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

About Svgreader

[julien2412]

Hello,

Reading bugtrackers about SVG, I noticed there were 2 locations with
svgreader:
- filter/source/svg/svgreader.cxx
- svgio/source/svgreader (there's also svgio/source/svguno)

There's no README for svgio/ and the README of filter isn't detailed.

Someone to explain (perhaps update/add README)? Above all, what part is used
to read svg?

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/About-Svgreader-tp4107050.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[SOLVED] Re: About Svgreader

[julien2412]

Thank you Christina for your feedback, I used it for
http://cgit.freedesktop.org/libreoffice/core/commit/?id=1cb924de8a6f03827ae34aa2d66137b6b5e34112

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/About-Svgreader-tp4107050p4107174.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

About "glyph fallback" message (vcl module)

[julien2412]

Hello,

On pc Debian x86-64 with master source updated yesterday, I've got this
message on console when going to Options/Language Settings/Languages:
warn:vcl:26860:1:vcl/generic/fontmanager/fontconfig.cxx:868: In glyph
fallback throwing away the language property of en because the detected
script for '0x9f3' is Bengali and that language doesn't make sense.
Autodetecting instead.

In my autogen.input, to give a try to some localization bugs, I put this:
--with-lang=en-US it fr de es pt ru cs hu pl da sv el sk is nl
--with-myspell-dicts

Any idea?

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/About-glyph-fallback-message-vcl-module-tp4107287.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Question about debugging cppunit tests

[julien2412]

Hello,

I'm trying to run gdb on cppunit failing by following this:
to rerun just this failed test without all others, run:

make JunitTest_chart2_unoapi

cd into the module dir to run the tests faster
Or to do interactive debugging (non-Windows), run two shells with:

make debugrun
make gb_JunitTest_DEBUGRUN=T JunitTest_chart2_unoapi

So I open 2 console shells.
On first one, I run "make debugrun"
On second one, I run "make gb_JunitTest_DEBUGRUN=T JunitTest_chart2_unoapi"

But first one just always displays this:
Reading symbols from
/home/julien/compile-libreoffice/libreoffice/instdir/program/soffice.bin...done.
(gdb)
and that's all.

It must be obvious but I miss the point.
https://wiki.documentfoundation.org/Development/How_to_debug seems outdated
since it doesn't talk about this way. Moreover, I tried 'export
CPPUNITTRACE="gdb --args"' and it does nothing when running then 'make
JunitTest_chart2_unoapi' for example.

Any idea?

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/Question-about-debugging-cppunit-tests-tp4107499.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[SOLVED] Re: Questions about getCppuType

[julien2412]

sberg wrote
> ...
> With cppu::UnoType, instead use cppu::UnoUnsignedShortType and 
> cppu::UnoCharType as template arguments, respectively.  (And do get rid 
> of the useless "const" in the template arguments.)

Thank you Stephan for your feedback, I'll use these and remove const  for
all the replacements (not only those with sal_uInt16)

Julien




--
View this message in context: 
http://nabble.documentfoundation.org/Questions-about-getCppuType-tp4106361p4107641.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [patch] [solved] build failure

[julien2412]

Sorry Terrence, my fault here :-(
Thanks to Kohei, I could fix these at the beginning of the morning (UTC+2)

It could be useful to force building in C++98 or at least put an option in
autogen.input.

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/patch-solved-build-failure-tp4107754p4107778.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Questions about getCppuType

[julien2412]

Thank you Stephan for these information.

In fact, my primary goal was to clean this use of getCppuType because it was
reported by cppcheck (when they were used in if/else if blocks)
Then I wanted to remove all of them. The problem is there are 33 Opengrok
pages of these and I don't know enough about regexp to remove them quickly.
I tried things like this:
fgrep -lR 'getCppuType((const sal_Int32*)0)' |xargs -i sed -i 
's/getCppuType[(][(]const sal_Int32[*])0)/cppu::UnoType::get()/g'
{}
But it's still too naive to get rid of them. (I wanted to put "const"
optional but didn't even find how to do it)

Any regexp wizard here?

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/Questions-about-getCppuType-tp4106361p4107939.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] problem of master build cannot launch.

[julien2412]

Yifan J wrote:
> 
> Firstly, I found smoketest fails on the HEAD (with error
> officeconnection.cxx:140), then I tried to launch soffice.bin in
> solver/350
> manually, but soffice.bin crashes immedialy even before splash screen
> appears.
> 
I came back yesterday and made from scratch a new local repository and I've
still got this same pb.
I compile on a Linux x86 with this autogen :
--enable-symbols
--enable-binfilters
--enable-ext-barcode
--enable-ext-diagram
--enable-ext-google-docs
--enable-ext-hunart
--enable-ext-lightproof
--enable-ext-nlpsolver
--enable-ext-ct2n
--enable-ext-numbertext
--enable-ext-oooblogger
--enable-ext-pdfimport
--enable-ext-presenter-console
--enable-ext-presenter-minimizer
--enable-ext-report-builder
--enable-ext-scripting-beanshell
--enable-ext-scripting-javascript
--enable-ext-scripting-python
--enable-ext-typo
--enable-ext-validator
--enable-ext-watch-window
--enable-ext-wiki-publisher
--enable-dbus
--enable-graphite
--enable-evolution2
--enable-werror
--enable-debug
--enable-dbgutil
--enable-crashdump
--enable-kde4
--enable-dependency-tracking

gcc (Debian 4.6.1-1) 4.6.1 with kernel 2.6.39-2-686-pae
For the moment, I found nothing which explains this, I'm still searching.

Julien.


--
View this message in context: 
http://nabble.documentfoundation.org/problem-of-master-build-cannot-launch-tp3147505p3177627.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Make dev-install without running smoketests

[julien2412]

Lionel Elie Mamane wrote:
> 
> On Wed, Aug 03, 2011 at 04:51:13PM +0100, Caolán McNamara wrote:
> 
>> What are your configure options for me to see if I can replicate this ?
>> Looks like evilness which should be fixed.
> 
> I'm in a similar situation on master branch, but for me the smoketest
> fails in officeconnection.cxx in function OfficeConnection::setUp(),
> at that assertion:
> 
> for (;;) {
> try {
> context_ =
> css::uno::Reference< css::uno::XComponentContext >(
> resolver->resolve(
> rtl::OUString(RTL_CONSTASCII_USTRINGPARAM("uno:"))
>   +
> desc +
> rtl::OUString(
> RTL_CONSTASCII_USTRINGPARAM(
> ";urp;StarOffice.ComponentContext"))),
> css::uno::UNO_QUERY_THROW);
> break;
> } catch (css::connection::NoConnectException &) {}
> if (process_ != 0) {
> TimeValue delay = { 1, 0 }; // 1 sec
> CPPUNIT_ASSERT_EQUAL(
> osl_Process_E_TimedOut,
> osl_joinProcessWithTimeout(process_, &delay));
> }
> }
> 
> I changed the last lines to:
> 
> oslProcessError
> 
> if (process_ != 0) {
> TimeValue delay = { 1, 0 }; // 1 sec
>   oslProcessError rv = osl_joinProcessWithTimeout(process_, &delay);
>   fprintf(stderr, "%d\n", rv);
>CPPUNIT_ASSERT_EQUAL(
> osl_Process_E_TimedOut,
> rv);
> }
> 
> And then I see that the assertion succeeds several times, and then
> finally fails, when the return value of the function call becomes
> osl_Process_E_None (that is, 0).
> 
> -- 
> Lionel
> 
I noticed exactly the same thing but then I don't know how to go on the
investigation. On IRC, Moggi told me this was a know issue but it doesn't
happen on every machine. I'm curious to know if it happens on Mac or
Windows.

Julien.


--
View this message in context: 
http://nabble.documentfoundation.org/Make-dev-install-without-running-smoketests-tp3221086p3223566.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] SfxItemSet reimplementation (was: va_start without va_end)

[julien2412]

Bjoern Michaelsen wrote:
> 
> Hi Norbert, all,
> 
> On Thu, 4 Aug 2011 20:47:43 -0500
> Norbert Thiebaud 
> wrote:
> 
>> The va_end manpage, on linux says:
>> "Each invocation of va_start() must be matched by a corresponding
>> invocation of va_end() in the _same function_"
>>  (emphasis is mine)
>>  so it's not just ugly, but also 'wrong'...
> 
> FWIW, I tried a clean new from the group up reimplementation of
> SfxItemset once in cws new_itemsets:
> ...
> Maybe somebody is interested in integrating the replacement Itemset? I
> added an EasyHack for it:
>  https://bugs.freedesktop.org/show_bug.cgi?id=39849
> Although that is a truely challenging task, it would also be most
> rewarding.
> 
> Best,
> 
> Bjoern
> 
> 
> -- 
> https://launchpad.net/~bjoern-michaelsen
> 
> 
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
> 
I don't know if i can do this easyhack but what about the 3 cases of vm_end
? Should vm_end be added ?
If yes, i can commit and pushed them for the 2 first cases. For the third
case, i can also do it but I can't check before since it impacts above all
Windows parts and I compile on Linux.

Julien.

--
View this message in context: 
http://nabble.documentfoundation.org/va-start-without-va-end-tp3223648p3235171.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] va_start without va_end

[julien2412]

I commited and pushed the first and second case.
I let the third case for the moment.

Julien.

--
View this message in context: 
http://nabble.documentfoundation.org/va-start-without-va-end-tp3223648p3236981.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] build error in tail_build

[julien2412]

Cor Nouws wrote:
> 
> ...
> But hey, better then summing up more reasons:
> what command(s) do I use to move to the new master?
> ...___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
> 
Hello,

I don't think there's a script for this. Just create your local repo from
scratch by following this url :
http://wiki.documentfoundation.org/Development/Native_Build (this page has
been updated).

You could save your autogen.lastrun if you want to preserve the options you
usually passed for the compilation.
Then after the autogen.sh part, copy the backup in your repo and rerun
autogen.sh before running the compilation with "make".

Hope I forgot nothing or misunderstood anything :-)

Julien.
PS : "make" fetches dictionnary and help repositories by default

--
View this message in context: 
http://nabble.documentfoundation.org/build-error-in-tail-build-tp3238515p3238689.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] http://libreoffice.boldandbusted.com/ cppcheck report jobs stalled

[julien2412]

Excellent ! Even if I would have preferred a git version, it's great to see
this report updated again. Cppcheck is a really good tool to detect
problems.

Julien.

--
View this message in context: 
http://nabble.documentfoundation.org/http-libreoffice-boldandbusted-com-cppcheck-report-jobs-stalled-tp2745270p3243534.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] Throwing exception in destructor

[julien2412]

Hello,

cppcheck has detected 1 Throwing exception in destructor" line 88 of
core/bridges/test/java_uno/acquire/testacquire.cxx
(sorry I mentionned 2 locations on IRC cause I forgot about the new git repo
: it was in core and old ure repo)
Could it be replaced by just a log (which function should be used for this
kind of case ?) or something since a throw in destructor should be avoided ?

Julien

--
View this message in context: 
http://nabble.documentfoundation.org/Throwing-exception-in-destructor-tp3243968p3243968.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] http://libreoffice.boldandbusted.com/ cppcheck report jobs stalled... no longer! :)

[julien2412]

I noticed that cppcheck made its report on the old repositories too, is it
possible to remove the cppcheck scan on these ?

Julien.

--
View this message in context: 
http://nabble.documentfoundation.org/http-libreoffice-boldandbusted-com-cppcheck-report-jobs-stalled-tp2745270p3244910.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Throwing exception in destructor

[julien2412]

Stephan Bergmann wrote:
> 
> On Aug 10, 2011, at 11:22 PM, julien2412 wrote:
> ...
>> Could it be replaced by just a log (which function should be used for
>> this
>> kind of case ?) or something since a throw in destructor should be
>> avoided ?
> Given that assertNotNull() further down in that file uses std::abort to
> signal failure, the best fix probably is to use that in ~WaitCondition,
> too:
> 
> if (m_condition.wait() != osl::Condition::result_ok) {
> std::cerr << "osl::Condition::wait failed\n";
> std::abort()
> }
> 
Ok thank you for the answer, I commited and pushed on master.

Julien.

--
View this message in context: 
http://nabble.documentfoundation.org/Throwing-exception-in-destructor-tp3243968p3247197.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PUSHED] [PATCH] SAL_ALLOW_LINKOO_SYMLINKS, libreoffice-3-4 sal module with dbglevel=2: init test fails

[julien2412]

Lionel Elie Mamane wrote:
> 
> ...
> You mean I can just run "build" in a module and
> ./install/program/soffice will use it, without rerunning "make
> dev-install"? Ah yes, it works, you just increased my productivity!
> ...
> 
Hello,

Unless it has changed or I forget/misunderstand something but with dmake
system, you must just run "build" + "deliver".

Julien.

--
View this message in context: 
http://nabble.documentfoundation.org/PATCH-compiling-libreoffice-3-4-sal-module-with-dbglevel-2-init-test-fails-tp3224965p3248381.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Rebuild LO

[julien2412]

swagat sharma wrote:
> 
> Hi,
> 
> I have successfully built LibreOffice and also installed it.. by make
> install.
> 
> Now I have modified the source and want to rebuild it. I want to make the
> whole build again.
> I did 'make clean',
> Then changed some configure options, but its not building .
> Gives error in compiling tail_end module.
> I have LO 3.4.2 source code. Any help?
> 
> Also its says the error is because of threaded build. what is a threaded
> build?
> --
> Swagat
> 
> 
Hello,

Could you give us more information like :
- how have you got the sources (git, tar gz pack, ...) ?
- what are your changes ?
- detailed logs ?

About threaded build, it can be single thread or multithread (2, 3, ..., n).
It depends on your processor and the configuration options you gave for the
compilation.
A multithread build is faster than a single thread because several parts are
compiled in same time.

Julien.

--
View this message in context: 
http://nabble.documentfoundation.org/Rebuild-LO-tp3251787p3251920.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] java LO part with Eclipse

[julien2412]

Hello,

I asked on the IRC but I had to leave so I certainly haven't let enough time
to people to respond. I'd like to know if there's a wiki page or something
which describes how to manage Java specific parts of LO in Eclipse.
I found these 2 pages :
- http://cedric.bosdonnat.free.fr/wordpress/?p=57
- http://wiki.services.openoffice.org/wiki/Java_and_OpenOffice.org

But I'd like to know how to create a workspace well configured to debug from
scratch.

Julien.

--
View this message in context: 
http://nabble.documentfoundation.org/java-LO-part-with-Eclipse-tp3251988p3251988.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] java LO part with Eclipse

[julien2412]

Jenei Gábor wrote:
> 
> Hello Julien,
> 
> I had this problem less than a week ago, if you read Cédric's website 
> you should find there the right way. First you have to set LO's JVM 
> setting. you have to set to listen on a port for remote debugger(in the 
> example it was 8000) and you have to set anotheroption,after this you 
> restart LO,and  with nmap you should see that port 8000 is open. Now, in 
> eclipse you go to debug configurations window, it's under the run 
> toolbar point. And there you have to set localhost and port 8000, after 
> this if you toogle a breakpoint it should work. For me it worked at 
> yesterday;)
> 
> Good luck:
> 
>> LibreOffice mailing list
>> LibreOffice@lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/libreoffice
> 
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
> 
Hello Jenei,

Thank you for the information but I'm far to have reached this step. I'd
like to know how, step by step, create a workspace  "ready to use" with LO
Java part.

Julien.

--
View this message in context: 
http://nabble.documentfoundation.org/java-LO-part-with-Eclipse-tp3251988p3252052.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice-commits] core.git: use startsWith() instead of compareToAscii()

[julien2412]

Lionel Elie Mamane wrote
> Thanks Stephan, good catch!
> 
> Short version: this was, and should remain, an equality test and not a
> "string begins with, but can continue with anything" test.
> ...

Lionel, could this point explain these logs I had put in
https://bugs.freedesktop.org/show_bug.cgi?id=61725#c7) :
warn:legacy.osl:22802:1:dbaccess/source/core/misc/dsntypes.cxx:369:
ODsnTypeCollection::implDetermineType : missing the second colon !
warn:legacy.osl:22802:1:dbaccess/source/core/misc/dsntypes.cxx:369:
ODsnTypeCollection::implDetermineType : missing the second colon !
warn:vcl.control:22802:1:vcl/source/control/button.cxx:2357: No new-style
group set on radiobutton, using old-style digging around
warn:legacy.osl:22802:1:dbaccess/source/core/misc/dsntypes.cxx:369:
ODsnTypeCollection::implDetermineType : missing the second colon !
warn:legacy.osl:22802:1:dbaccess/source/core/misc/dsntypes.cxx:344:
ODsnTypeCollection::implDetermineType : missing the colon !
warn:legacy.osl:22802:1:dbaccess/source/core/misc/dsntypes.cxx:344:
ODsnTypeCollection::implDetermineType : missing the colon !

Julien




--
View this message in context: 
http://nabble.documentfoundation.org/Re-Libreoffice-commits-core-git-use-startsWith-instead-of-compareToAscii-tp4042967p4042997.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

About coverity 704144 (XSLTFilter)

[julien2412]

Hello,

Scan coverity detected this:
Resource leak in object (CTOR_DTOR_LEAK)1. alloc_fn: Calling allocation
function "osl_createCondition()". [show details]
(see
http://opengrok.libreoffice.org/xref/core/filter/source/xsltfilter/XSLTFilter.cxx#164)

osl_createCondition in unx part calls a malloc function  (see
http://opengrok.libreoffice.org/xref/core/sal/osl/unx/conditn.cxx#43)
and osl_destroyCondition frees the element (see
http://opengrok.libreoffice.org/xref/core/sal/osl/unx/conditn.cxx#92)

First I thought about adding a destructor for "XSLTFilter" which would just
call "osl_destroyCondition"
but then I noticed the class "XSLTFilter" which inherits from
"WeakImplHelper4" which itself inherits from "OWeakObject"
Finally I must recognize I don't know if these classes do the trick to free
the memory or if a destructor in "XSLTFilter"  is relevant.

Any idea?

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/About-coverity-704144-XSLTFilter-tp4043364.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

About coverity 705665 (javaunohelper.cxx)

[julien2412]

Hello,

Scan coverity detected this:
leaked_storage: Variable "lib" going out of scope leaks the storage it
points to. line 236
(see
http://opengrok.libreoffice.org/xref/core/javaunohelper/source/javaunohelper.cxx#236)
I just thought adding 
osl_unloadModule(lib) just before line 235, so last line of the block if
(lib)

Now I'm not sure because I don't know at all the mechanism of modules and
wonder if the declaration of "lib" would do the trick:
oslModule lib = osl_loadModule( aLibName.pData, SAL_LOADMODULE_LAZY |
SAL_LOADMODULE_GLOBAL );
Would " SAL_LOADMODULE_LAZY" mean unload "automagically" when necessary for
example?

Julien 



--
View this message in context: 
http://nabble.documentfoundation.org/About-coverity-705665-javaunohelper-cxx-tp4043372.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: About coverity 705665 (javaunohelper.cxx)

[julien2412]

The following discussion is interesting but shows that it's not a quick
and/or easy fix for casual contributor like me. So I let the experts keep on
about this and determine if there's something to change or not.
Thank you for your feedback about this  Michael, Tor and Matúš

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/About-coverity-705665-javaunohelper-cxx-tp4043372p4043387.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

About coverity 705732 (svdundo.cxx from svx module)

[julien2412]

Hello,

Scan coverity reported this:
leaked_storage: Variable "pText1" going out of scope leaks the storage it
points to.
See
http://opengrok.libreoffice.org/xref/core/svx/source/svdraw/svdundo.cxx#1137
   1137 void SdrUndoObjSetText::Redo()
   1138 {
   1139 // copy text for Undo, because the original now belongs to
SetOutlinerParaObject()
   1140 OutlinerParaObject* pText1 = pNewText;
   1141 
   1142 if(pText1)
   1143 pText1 = new OutlinerParaObject(*pText1);
   1144 
   1145 SdrText* pText = static_cast< SdrTextObj*>( pObj
)->getText(mnText);
   1146 if( pText )
   1147 static_cast< SdrTextObj* >( pObj
)->NbcSetOutlinerParaObjectForText( pText1, pText );
   1148 
   1149 pObj->ActionChanged();
   1150 
   1151 // Trigger PageChangeCall
   1152 ImpShowPageOfThisObject();
   1153 }

I noticed several things:
1) we could replace "if (pText1)" by "if (pNewText)". Of course if blocks
must be changed
2) if pText1 corresponds to a new OutlinerParaObject and !pText, it seems
there's a leak
3) why pObj->ActionChanged() and  ImpShowPageOfThisObject() are always
called ?

So I thought about this patch:
void SdrUndoObjSetText::Redo()
{
SdrText* pText = static_cast< SdrTextObj*>( pObj )->getText(mnText);
if( pText && pNewText)
{
// copy text for Undo, because the original now belongs to
SetOutlinerParaObject()
OutlinerParaObject* pText1 = new OutlinerParaObject(*pNewText);
static_cast< SdrTextObj* >( pObj )->NbcSetOutlinerParaObjectForText(
pText1, pText );
 
pObj->ActionChanged();

// Trigger PageChangeCall
ImpShowPageOfThisObject();
}
}

Any comment?

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/About-coverity-705732-svdundo-cxx-from-svx-module-tp4043389.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: About coverity 705732 (svdundo.cxx from svx module)

[julien2412]

Thorsten, Caolán,

Following your respective feedback about this, thank you for this, I thought
about "gerrit submitting" on master as it is since Caolán seems quite
confident and it may allow an easier review.
In general, in bug triaging, cppcheck and very recently scan coverity, my
purpose is to grab the low hanging fruits when I've got time. So I must
recognize I didn't spend hours about this one just grabbed a coverity report
and tried to find a fix entirely "locally".

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/About-coverity-705732-svdundo-cxx-from-svx-module-tp4043389p4043516.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

About coverity 705746 (pormulti.cxx from sw module)

[julien2412]

Hello,

Scan coverity detected this:
27. overwrite_var: Overwriting "pMarg" in "pMarg = new SwMarginPortion(0)"
leaks the storage that "pMarg" points to

(http://opengrok.libreoffice.org/xref/core/sw/source/core/text/pormulti.cxx#738)
738 if( nLeft || nRight )
739 {
740 if( !pCurr->GetPortion() )
741 pCurr->SetPortion( new SwTxtPortion( *pCurr ) );
742 SwMarginPortion *pMarg = new SwMarginPortion( 0 );
743 if( nLeft )
744 {
745 pMarg->AddPrtWidth( nLeft );
746 pMarg->SetPortion( pCurr->GetPortion() );
747 pCurr->SetPortion( pMarg );
748 }
749 if( nRight )
750 {
751 pMarg = new SwMarginPortion( 0 );
752 pMarg->AddPrtWidth( nRight );
753 pCurr->FindLastPortion()->Append( pMarg );
754 }
755 }

I don't understand the line 751, shouldn't it simply removed or does it lack
something too?

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/About-coverity-705746-pormulti-cxx-from-sw-module-tp4043862.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: About coverity 705746 (pormulti.cxx from sw module)

[julien2412]

Noel Grandin wrote
> I would guess that someone meant to move line 742 inside the first "if" 
> statement, but only did half the job.

Hello Noël,

Perhaps I'm too sleepy this morning but I don't see the interest to
duplicate the "new" part. Any hint?

Julien




--
View this message in context: 
http://nabble.documentfoundation.org/About-coverity-705746-pormulti-cxx-from-sw-module-tp4043862p4043957.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: About coverity 705746 (pormulti.cxx from sw module)

[julien2412]

Oups, I was wrong , if they're not exclusive, "new" line is required for each
block

Sorry Noël and Riccardo for the noise. Can you push a patch about this and
update coverity?
If not, I'll do it but only during week-end because I won't have much time.
Thank you for having very patiently answered to me:-)

Julien





--
View this message in context: 
http://nabble.documentfoundation.org/About-coverity-705746-pormulti-cxx-from-sw-module-tp4043862p4043978.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [RESOLVED] About coverity 705746 (pormulti.cxx from sw module)

[julien2412]

Caolán McNamara wrote
> Pushed the agreed fix (I agree too) and updated coverity.

Thank you Caolán! One additional fix on LO and one coverity scan report less
to deal :-)

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/About-coverity-705746-pormulti-cxx-from-sw-module-tp4043862p4044017.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

About coverity 738980 (ssfrm.cxx from sw module)

[julien2412]

Hello,

Scan coverity detected this: 
22. pass_freed_arg: Passing freed pointer "pAnchoredObj" as an argument to
function "SwSortedObjs::Remove(SwAnchoredObject &)".

This problem appears twice in the file:
576 SwAnchoredObject* pAnchoredObj =
(*pFrm->GetDrawObjs())[0];
577 if ( pAnchoredObj->ISA(SwFlyFrm) )
578 delete pAnchoredObj;
579 else
580 {
581 SdrObject* pSdrObj = pAnchoredObj->DrawObj();
582 SwDrawContact* pContact =
583
static_cast(pSdrObj->GetUserCall());
584 OSL_ENSURE( pContact,
585 " - missing contact for
drawing object" );
586 if ( pContact )
587 {
588 pContact->DisconnectObjFromLayout( pSdrObj
);
589 }
590 }
591 if ( pFrm->GetDrawObjs() &&
592  nCnt == pFrm->GetDrawObjs()->Count() )
593 {
594 pFrm->GetDrawObjs()->Remove( *pAnchoredObj ); 
 pAnchoredObj has been deleted!
595 }


and here (same logic):
608 SwAnchoredObject* pAnchoredObj = (*GetDrawObjs())[0];
609 if ( pAnchoredObj->ISA(SwFlyFrm) )
610 delete pAnchoredObj;
611 else
612 {
613 SdrObject* pSdrObj = pAnchoredObj->DrawObj();
614 SwDrawContact* pContact =
615
static_cast(pSdrObj->GetUserCall());
616 OSL_ENSURE( pContact,
617 " - missing contact for
drawing object" );
618 if ( pContact )
619 {
620 pContact->DisconnectObjFromLayout( pSdrObj );
621 }
622 }
623 if ( GetDrawObjs() && nCnt == GetDrawObjs()->Count() )
624 {
625 GetDrawObjs()->Remove( *pAnchoredObj );  
pAnchoredObj has been deleted!
626 }

Should "delete pAnchoredObj;" be followed by pAnchoredObj = null; in the if
part
then  if ( GetDrawObjs() && nCnt == GetDrawObjs()->Count() ) should be
replaced by:
 if ( GetDrawObjs() && nCnt == GetDrawObjs()->Count()  && pAnchoredObj) ?

Or:
 if ( GetDrawObjs() && nCnt == GetDrawObjs()->Count() ) part included in
else block?

Or should it be otherwise?

Julien 



--
View this message in context: 
http://nabble.documentfoundation.org/About-coverity-738980-ssfrm-cxx-from-sw-module-tp4044145.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

cppcheck: Variables reassigned before the old one has been used (vcl/kde4 part)

[julien2412]

Hello,

Cppcheck reported this: 
[KDESalFrame.cxx:301] -> [KDESalFrame.cxx:304]: (performance) Variable
'aMenuFore' is reassigned a value before the old one has been used.
[KDESalFrame.cxx:302] -> [KDESalFrame.cxx:305]: (performance) Variable
'aMenuBack' is reassigned a value before the old one has been used.

Indeed, there are the lines:
292 // Menu
293 style.SetSkipDisabledInMenus( TRUE );
294 KMenuBar* pMenuBar = new KMenuBar();
295 if ( pMenuBar )
296 {
297 // Color
298 QPalette qMenuCG = pMenuBar->palette();
299 
300 // Menu text and background color, theme specific
301 Color aMenuFore = toColor( qMenuCG.color(
QPalette::WindowText ) );
302 Color aMenuBack = toColor( qMenuCG.color( QPalette::Window )
);
303 
304 aMenuFore = toColor( qMenuCG.color( QPalette::ButtonText )
);
305 aMenuBack = toColor( qMenuCG.color( QPalette::Button ) );
(See
http://opengrok.libreoffice.org/xref/core/vcl/unx/kde4/KDESalFrame.cxx#292)

Must we keep QPalette::WindowText and QPalette::Window or 
QPalette::ButtonText and QPalette::Button ?

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/cppcheck-Variables-reassigned-before-the-old-one-has-been-used-vcl-kde4-part-tp4044235.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

About coverity 988424 (svdfppt.cxx from filter module)

[julien2412]

Hello,

Scan coverity detected this: 
CID 988424 (#1 of 1): Logically dead code (DEADCODE)dead_error_line:
Execution cannot reach this expression "nExtBuInd + nExtParaNibble <
aStyleTextProp9->size()" inside statement "if (nExtParaNibble && nExtB...". 

Indeed, we have these lines:
   5026 if ( nExtParaPos )
   5027 {
   5028 sal_uInt32 nExtBuInd = nMask & 0x3c00;
   5029 sal_uInt32  nExtParaNibble = 0;
   5030 if ( nExtBuInd )
   5031 nExtBuInd = ( aSet.mnFlags & 0x3c00 ) >> 10;
   5032 if ( nExtBuInd < aStyleTextProp9.size() )
   5033 {
   5034 if ( nExtParaNibble && ( ( nExtBuInd + nExtParaNibble )
< aStyleTextProp9.size() ) )
   5035 nExtBuInd += nExtParaNibble;

(see
http://opengrok.libreoffice.org/xref/core/filter/source/msfilter/svdfppt.cxx#5026)

Any idea what should be done?

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/About-coverity-988424-svdfppt-cxx-from-filter-module-tp4044238.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: cppcheck: Variables reassigned before the old one has been used (vcl/kde4 part)

[julien2412]

Hi Lubos,

But which ones are the useless?
QPalette::WindowText and QPalette::Window
or
QPalette::ButtonText and QPalette::Button

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/cppcheck-Variables-reassigned-before-the-old-one-has-been-used-vcl-kde4-part-tp4044235p4044566.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: cppcheck: Variables reassigned before the old one has been used (vcl/kde4 part)

[julien2412]

All of the sudden my 2 neurons connected :-)

I pushed the patch on master.
See
http://cgit.freedesktop.org/libreoffice/core/commit/?id=91c8b357ee2a27e50da0e99386e53d351e55cfda

Thank you Lubos!

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/cppcheck-Variables-reassigned-before-the-old-one-has-been-used-vcl-kde4-part-tp4044235p4044602.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[SOLVED] Re: cppcheck: Variables reassigned before the old one has been used (vcl/kde4 part)

[julien2412]

grr, forgot to mark this as "solved".



--
View this message in context: 
http://nabble.documentfoundation.org/cppcheck-Variables-reassigned-before-the-old-one-has-been-used-vcl-kde4-part-tp4044235p4044604.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

About coverity 440107 (keyimpl.cxx in registry)

[julien2412]

Hello,

Scan coverity reported this:
dead_error_begin: Execution cannot reach this statement "case 5:"
dead_error_begin: Execution cannot reach this statement "case 6:"
dead_error_begin: Execution cannot reach this statement "case 7:"

See
http://opengrok.libreoffice.org/xref/core/registry/source/keyimpl.cxx#604

Indeed we have this switch:
622 switch (valueType)
623 {
624 case RG_VALUETYPE_NOT_DEFINED:
625 memcpy(value, pBuffer, valueSize);
626 break;
627 case RG_VALUETYPE_LONG:
628 readINT32(pBuffer, *((sal_Int32*)value));
629 break;
630 case RG_VALUETYPE_STRING:
631 readUtf8(pBuffer, (sal_Char*)value, valueSize);
632 break;
633 case RG_VALUETYPE_UNICODE:
634 readString(pBuffer, (sal_Unicode*)value, valueSize);
635 break;
636 case RG_VALUETYPE_BINARY:
637 memcpy(value, pBuffer, valueSize);
638 break;
639 case RG_VALUETYPE_LONGLIST:
640 case RG_VALUETYPE_STRINGLIST:
641 case RG_VALUETYPE_UNICODELIST:
642 memcpy(value, pBuffer, valueSize);
643 break;
644 }

but some lines above:
604 if (valueType > 4)
605 {
606 return REG_INVALID_VALUE;
607 }

I took a look, it's like this since initial import in 2000.
Should if (valueType > 4) be removed or should we clean the >4 cases ?

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/About-coverity-440107-keyimpl-cxx-in-registry-tp4045470.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: About coverity 440107 (keyimpl.cxx in registry)

[julien2412]

Thank you Stephan for your feedback.

If I remove these cases in the switch, I've got this:
/home/julien/compile-libreoffice/libo/registry/source/keyimpl.cxx: In member
function ‘RegError ORegKey::getValue(const rtl::OUString&, RegValue) const’:
/home/julien/compile-libreoffice/libo/registry/source/keyimpl.cxx:622:12:
error: enumeration value ‘RG_VALUETYPE_LONGLIST’ not handled in switch
[-Werror=switch]
/home/julien/compile-libreoffice/libo/registry/source/keyimpl.cxx:622:12:
error: enumeration value ‘RG_VALUETYPE_STRINGLIST’ not handled in switch
[-Werror=switch]
/home/julien/compile-libreoffice/libo/registry/source/keyimpl.cxx:622:12:
error: enumeration value ‘RG_VALUETYPE_UNICODELIST’ not handled in switch
[-Werror=switch]

It seems either we clean up the whole thing or we let as it is. Of course,
there's also disabling warning for a specific part but I dislike doing this
if it's not a strong external constraint (just personal opinion of course
:-)).

In brief, except if we have a go to clean up the whole thing (after all why
not take advantage we're on 4.0?), I'll let as it is.

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/About-coverity-440107-keyimpl-cxx-in-registry-tp4045470p4045542.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH for 3.6] Lacking "/" with .icedove prevents to use Icedove addressbook

[julien2412]

Hello,

Reading https://bugs.freedesktop.org/show_bug.cgi?id=57419, I found there
was a missing "/" at the end of  ".icedove" in
connectivity/source/drivers/mork/MNSFolders.cxx, line 88

It's my fault (see
http://cgit.freedesktop.org/libreoffice/core/commit/?id=8d7e1a6e13008bd7d35896e676796196038f1105).
It worked for me because I had let a link .thunderbird to .icedove.

Here's the straightforward patch:
  0001-Fix-lacking-on-.icedove.patch

  

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/PATCH-for-3-6-Lacking-with-icedove-prevents-to-use-Icedove-addressbook-tp4021928.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

About numbertext

[julien2412]

Hello,

By trying to reproduce an fdo, I got a lot of these on console:
Python exception: : inconsistent use of tabs and spaces in
indentation (__init__.py, line 70), traceback follows
 
/home/julien/compile-libreoffice/libo/solver/unxlngx6/installation/opt/program/uno.py:265
in function _uno_import() [return _g_delegatee( name, *optargs, **kwargs )]
 
/home/julien/compile-libreoffice/libo/solver/unxlngx6/installation/opt/share/extensions/numbertext/reg.uno.py:7
in function createInstance() [import org.Numbertext]
 
/home/julien/compile-libreoffice/libo/solver/unxlngx6/installation/opt/program/unohelper.py:292
in function createInstanceWithContext() [return self.clazz( context )

So I unzipped src/b8cbca7b3363e6ca2d02bc0ba2b63904-numbertext_0.9.4.oxt and
runned pep8 (1.3.3 version) on it. Except "E501 lines too long", I fixed all
the pep8 warnings. I put all the changes files here:
changes.tar.bz2
  

pylint gives warnings too but I don't know really how to fix them.

If it's ok, does it worth it to create a new version of numbertext?

Julien




--
View this message in context: 
http://nabble.documentfoundation.org/About-numbertext-tp4022762.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Build failure on master on mysqlc module

[julien2412]

Hello,

On pc Debian x86-64 with master sources updated today (commit
6858182d246f21c5b06af09d8ff0e6fd04ef26c3)  and following a make clean, I've
got this:
Entering /home/julien/compile-libreoffice/libo/mysqlc/source

Compiling: mysqlc/source/mysqlc_driver.cxx
Compiling: mysqlc/source/mysqlc_services.cxx
Compiling: mysqlc/source/mysqlc_connection.cxx
Compiling: mysqlc/source/mysqlc_resultset.cxx
In file included from
/home/julien/compile-libreoffice/libo/solver/unxlngx6/inc/rtl/string.hxx:32:0,
 from
/home/julien/compile-libreoffice/libo/solver/unxlngx6/inc/rtl/ustring.hxx:31,
 from
/home/julien/compile-libreoffice/libo/solver/unxlngx6/inc/udkapi/com/sun/star/uno/Exception.hdl:9,
 from
/home/julien/compile-libreoffice/libo/solver/unxlngx6/inc/udkapi/com/sun/star/uno/RuntimeException.hdl:6,
 from
/home/julien/compile-libreoffice/libo/solver/unxlngx6/inc/udkapi/com/sun/star/uno/XInterface.hdl:6,
 from
/home/julien/compile-libreoffice/libo/solver/unxlngx6/inc/udkapi/com/sun/star/uno/XInterface.hpp:6,
 from
/home/julien/compile-libreoffice/libo/solver/unxlngx6/inc/cppuhelper/weakref.hxx:22,
 from
/home/julien/compile-libreoffice/libo/solver/unxlngx6/inc/cppuhelper/weak.hxx:24,
 from
/home/julien/compile-libreoffice/libo/mysqlc/source/mysqlc_subcomponent.hxx:23,
 from
/home/julien/compile-libreoffice/libo/mysqlc/source/mysqlc_connection.hxx:23,
 from
/home/julien/compile-libreoffice/libo/mysqlc/source/mysqlc_driver.hxx:30,
 from
/home/julien/compile-libreoffice/libo/mysqlc/source/mysqlc_services.cxx:20:
/home/julien/compile-libreoffice/libo/solver/unxlngx6/inc/rtl/stringutils.hxx:34:27:
fatal error: config_global.h: No such file or directory
compilation terminated.
In file included from
/home/julien/compile-libreoffice/libo/solver/unxlngx6/inc/rtl/string.hxx:32:0,
 from
/home/julien/compile-libreoffice/libo/solver/unxlngx6/inc/rtl/ustring.hxx:31,
 from
/home/julien/compile-libreoffice/libo/solver/unxlngx6/inc/udkapi/com/sun/star/uno/Exception.hdl:9,
 from
/home/julien/compile-libreoffice/libo/solver/unxlngx6/inc/udkapi/com/sun/star/uno/RuntimeException.hdl:6,
 from
/home/julien/compile-libreoffice/libo/solver/unxlngx6/inc/udkapi/com/sun/star/uno/XInterface.hdl:6,
 from
/home/julien/compile-libreoffice/libo/solver/unxlngx6/inc/udkapi/com/sun/star/uno/XInterface.hpp:6,
 from
/home/julien/compile-libreoffice/libo/solver/unxlngx6/inc/cppuhelper/weakref.hxx:22,
 from
/home/julien/compile-libreoffice/libo/solver/unxlngx6/inc/cppuhelper/weak.hxx:24,
 from
/home/julien/compile-libreoffice/libo/mysqlc/source/mysqlc_subcomponent.hxx:23,
 from
/home/julien/compile-libreoffice/libo/mysqlc/source/mysqlc_connection.hxx:23,
 from
/home/julien/compile-libreoffice/libo/mysqlc/source/mysqlc_driver.hxx:30,
 from
/home/julien/compile-libreoffice/libo/mysqlc/source/mysqlc_driver.cxx:26:
/home/julien/compile-libreoffice/libo/solver/unxlngx6/inc/rtl/stringutils.hxx:34:27:
fatal error: config_global.h: No such file or directory
compilation terminated.
In file included from
/home/julien/compile-libreoffice/libo/solver/unxlngx6/inc/rtl/string.hxx:32:0,
 from
/home/julien/compile-libreoffice/libo/solver/unxlngx6/inc/rtl/ustring.hxx:31,
 from
/home/julien/compile-libreoffice/libo/mysqlc/source/mysqlc_propertyids.hxx:26,
 from
/home/julien/compile-libreoffice/libo/mysqlc/source/mysqlc_resultset.cxx:20:
/home/julien/compile-libreoffice/libo/solver/unxlngx6/inc/rtl/stringutils.hxx:34:27:
fatal error: config_global.h: No such file or directory
compilation terminated.
In file included from
/home/julien/compile-libreoffice/libo/solver/unxlngx6/inc/rtl/string.hxx:32:0,
 from
/home/julien/compile-libreoffice/libo/solver/unxlngx6/inc/rtl/ustring.hxx:31,
 from
/home/julien/compile-libreoffice/libo/solver/unxlngx6/inc/udkapi/com/sun/star/uno/Exception.hdl:9,
 from
/home/julien/compile-libreoffice/libo/solver/unxlngx6/inc/udkapi/com/sun/star/uno/RuntimeException.hdl:6,
 from
/home/julien/compile-libreoffice/libo/solver/unxlngx6/inc/udkapi/com/sun/star/uno/XInterface.hdl:6,
 from
/home/julien/compile-libreoffice/libo/solver/unxlngx6/inc/udkapi/com/sun/star/uno/XInterface.hpp:6,
 from
/home/julien/compile-libreoffice/libo/solver/unxlngx6/inc/cppuhelper/weakref.hxx:22,
 from
/home/julien/compile-libreoffice/libo/solver/unxlngx6/inc/cppuhelper/weak.hxx:24,
 from
/home/julien/compile-libreoffice/libo/mysqlc/source/mysqlc_subcomponent.hxx:23,
 from
/home/julien/compile-libreoffice/libo/mysqlc/source/mysqlc_connection.hxx:2

Re: Build failure on master on mysqlc module

[julien2412]

Lubos Lunak wrote
>> Entering /home/julien/compile-libreoffice/libo/mysqlc/source
> ...
>> /home/julien/compile-libreoffice/libo/mysqlc/source/mysqlc_services.cxx:20:
>> /home/julien/compile-libreoffice/libo/solver/unxlngx6/inc/rtl/stringutils.h
>>xx:34:27: fatal error: config_global.h: No such file or directory
>> compilation terminated.
> 
>  The file should be in config/ , created by configure. Compile command
> should 
> have -I$(SRCDIR)/config option.

I must recognize I don't understand why and what to do, even after having a
look to :
- core/config/README
-
'http://cgit.freedesktop.org/libreoffice/core/commit/?id=1aad4689babec28f47b99666b303ab8bfffc3106

So for the moment, I put in comment --enable-ext-mysql-connector in
autogen.lastrun and build is ok.

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/Build-failure-on-master-on-mysqlc-module-tp4023253p4023286.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: intending to join as a developer

[julien2412]

Hello,

Welcome here!
You must know that the main language of LO is C++.
These are used too: C, Python, Java (even assembly).
SCM is Git and Gerrit is used too.

If you want to contribute as a dev, the first thing is to build from sources
by following this:
http://wiki.documentfoundation.org/Development/Native_Build

Then, you may begin with some easy tasks to warm up, see :
http://wiki.documentfoundation.org/Development/Easy_Hacks_by_Difficulty

If you need help, don't hesitate to ask here or on IRC (#libreoffice-dev at
Freenode.net, http://webchat.freenode.net/)

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/intending-to-join-as-a-developer-tp4023306p4023310.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[REVIEW for 4.0] Missing breaks in connectivity/source/drivers/odbcbase/OTools.cxx

[julien2412]

Hello,

Could someone check commit 44b0bf91df1af9920b1c22a2f54bd70c9c44231b for
cherry-picking in 4.0?

--- connectivity/source/drivers/odbcbase/OTools.cxx
---
index a868b0b..290aa61 100644
@@ -682,8 +682,10 @@ SQLSMALLINT OTools::jdbcTypeToOdbc(sal_Int32 jdbcType)
 // ODBC doesn't have any notion of CLOB or BLOB
 case DataType::CLOB:
 odbcType = SQL_LONGVARCHAR;
+break;
 case DataType::BLOB:
 odbcType = SQL_LONGVARBINARY;
+break;
 }
 
 return odbcType;

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/REVIEW-for-4-0-Missing-breaks-in-connectivity-source-drivers-odbcbase-OTools-cxx-tp4023347.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: recent git master branch : crash instead of error popup

[julien2412]

Hi Olivier,

First, you must know that it's the dev mailing list here and not user
mailing list.
Dev mailing list is for discussing about patches, building process of LO,
etc.

About the bug, you didn't quote  info like Java version, platform for
example.
Moreover, try to be a little more precise about "garbage" because I tried to
reproduce this and put something at random, I had no crash.

Finally, a good thing to do is user mailing list and, if confirmed (or no
answer), fill a bug here:
https://www.libreoffice.org/get-help/bug/

Thank you for your feedback.

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/recent-git-master-branch-crash-instead-of-error-popup-tp4023332p4023350.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Question about sc/source/core/data/colorscale.cxx

[julien2412]

Hello,

I noticed these lines in file sc/source/core/data/colorscale.cxx
(because cppcheck report indicates that bNeedUpdate is reassigned before to
be used line 641)

637 void ScDataBarFormat::DataChanged(const ScRange& rRange)
638 {
639 bool bNeedUpdate = false;
640 
641 bNeedUpdate = NeedUpdate(mpFormatData->mpUpperLimit.get());
642 bNeedUpdate &= NeedUpdate(mpFormatData->mpLowerLimit.get());
643 
644 bNeedUpdate &= GetRange().Intersects(rRange);
645 
646 if(bNeedUpdate)
647 {
648 mpDoc->RepaintRange(GetRange());
649 }
650 }

First I wonder if we shouldn't avoid to bitwise and and logical and. But
above all, shouldn't it be logical OR?

So I would rather put:
 if( (NeedUpdate(mpFormatData->mpUpperLimit.get()))
|| (NeedUpdate(mpFormatData->mpLowerLimit.get())) ||
(GetRange().Intersects(rRange)) )
{
mpDoc->RepaintRange(GetRange());
}

What do you think?

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/Question-about-sc-source-core-data-colorscale-cxx-tp4024485.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Question about sc/source/ui/view/cellsh.cxx

[julien2412]

Hello,

In sc/source/ui/view/cellsh.cxx, we have these lines:
150 case FID_FILL_TO_RIGHT: // fill to left / right
151 {
152 bDisable = !bSimpleArea || (nCol1 == 0 && nCol2 ==
0);
153 bDisable = pDoc->HasSelectedBlockMatrixFragment(
154 nCol1, nRow1, nCol1, nRow2, rMark );// first
column
155 }

Either first bDisable is useless or the result of it should be used for the
next line?

What do you think?

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/Question-about-sc-source-ui-view-cellsh-cxx-tp4024486.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Question about vcl/source/window/builder.cxx

[julien2412]

Hello,

Keeping on with cppcheck, I found this on vcl/source/window/builder.cxx
   1892 else if (sKey == "pack-type")
   1893 {
   1894 VclPackType ePackType = (sValue[0] == 'e' ||
sValue[0] == 'e') ? VCL_PACK_END : VCL_PACK_START;
   1895 pCurrent->set_pack_type(ePackType);
   1896 }

Should it be  (sValue[0] == 'e' || sValue[0] == 'E'), just sValue[0] == 'e'
or something else?

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/Question-about-vcl-source-window-builder-cxx-tp4024520.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

About fdo#58026, Localization problem for GoogleDocs extension

[julien2412]

Hello,

I opened fdo#58026 (https://bugs.freedesktop.org/show_bug.cgi?id=58026), so
I'll just quote what I put.

With Google docs extension
2a64b8e6f185a7f6c19d00fb8bb4cf64-gdocs_3.0.1_modified.oxt, and with English
localization, one of the option isn't translated.

In fact, the problem is just here on Addon.xcu:
88 
89   Export to Zoho
90   Eksport do Zoho
91   Export zu Zoho
92   Exportar a Zoho
93   Esporta in Zoho
94   Exportovat do Zoho

Obviously, there's just a typo : "en" instead of "es" line 92.

the oxt is 2a64b8e6f185a7f6c19d00fb8bb4cf64-gdocs_3.0.1_modified.oxt
I found a contact on description.xml but since it's a modified version, I
don't know whom to "ping".

Any idea?

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/About-fdo-58026-Localization-problem-for-GoogleDocs-extension-tp4024946.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice