Matteo Casalin-3 wrote
> ...
> I don't have any comment about your proposal, but just would like to
> add that unless we know for sure that nHeight!=0 at that point, in
> both codes the check should be
> 
> if( nHeight <= 0 )
> 
> in order to solve the division by 0 completely.

You're right of course.

Sorrry for this change which was indeed wrong, I reverted it (see
http://cgit.freedesktop.org/libreoffice/core/commit/?id=ea15c9dc4da75fcd56e6b0dbce473b9e912fa4e2)

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/avoiding-cppunit-zerodiv-correction-tp4110788p4110872.html
Sent from the Dev mailing list archive at Nabble.com.
_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Reply via email to