[Libreoffice-commits] core.git: Changes to 'distro/vector/vtext-6.5'
New branch 'distro/vector/vtext-6.5' available with the following commits: ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: [Libreoffice] [PATCH] Install to the correct directory based on PREFIX
Hi Robert, thanks for the patch. It is committed as http://cgit.freedesktop.org/libreoffice/build/commit/?id=0cf0c0db05295aa1cc1b7728183b9cbc57e37408 Also I have cherry picked it for the libreoffice-3-3 branch. Note that I added back the $OODESTDIR. It is needed when you build RPMs. In this case, we need to install the files into extra prefix, e.g. /var/tmp/XXX to do not affect the system stuff. See also http://rpm5.org/docs/api/buildroot.html The variable is empty during normal installation, so it should not cause any harm. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] 8th week development summary
Hi, this time a brief summary of what happened the 8th week on LibreOffice repos and two living branches: bugfixes-master-week-46.txt lists all commits that reference a proper bug id (from a variety of trackers - #i... referring to the OpenOffice issuezilla, fdo# to freedesktop, rhbz# to RedHat bugzilla etc) in the master branch commit-log-master-week-46.txt lists all relevant commits on the actual source repos in the master branch commit-log-libreoffice-3-3-week-46.txt, bugfixes-libreoffice-3-3-week-46.txt lists the same summary for the libreoffice-3-3 branch. Many thanks to all contributors - you make all the difference! Best Regards, Petr + common: + sb136: #i114155# partially revert fix for i108776 to avoid ABI incompatibility of jvmaccess library [sb] + bootstrap: + Revert "fix smoketest with the improved download tarball (fdo#30837)" [Petr Mladek] + build: + fix n#654039 empty toolbar [Noel Power] + Remove OOo from the Frech translation of the dekstop files (fdo#31531) [Petr Mladek] + calc: + Make VLOOKUP work with an external reference once again. (fdo#31718) [Kohei Yoshida] + No automatic width adjustment of the dropdown popups. (fdo#31710) [Kohei Yoshida] + extensions: + masterfix OOO330: #i114049# Presentation minimizer 1.0.1 does not install on OOO330m15, #i113990# presenter console does not work with multiple screens [obo] + libs-core: + sb132: #i114155# use "en" as additional fallback locale after "en-US" [sb] + sb136: #i115386# prefer en[-US] over empty xml:lang value, to accomodate existing extensions with bad .xcu content [sb] + libs-gui: + Allow the dropdown list of a combo box to be scrollable. (fdo#31710) [Kohei Yoshida] + Resolves: rhbz#654203# crash after unhandled exception [Caolán McNamara] + writer: + Made the "My AutoText" string localizable, #i66304# [Andras Timar] + bootstrap: + Revert "fix smoketest with the improved download tarball (fdo#30837)" [Petr Mladek] + build: + altrnative fix for n#654039 empty toolbar [Noel Power] + remove DataAccess.xcu in PostgreSQL SDBC Driver (i#113494) [Rene Engelhard] + Remove OOo from the Frech translation of the dekstop files (fdo#31531) [Petr Mladek] + filters: + #i112890# LateInitThread thread never deleted [Caolán McNamara] + libs-gui: + Resolves: rhbz#654203# crash after unhandled exception [Caolán McNamara] + writer: + implement in in numbering.xml (bnc#513567) [Luboš Luňák] + use or appropriately (bnc#513579) [Luboš Luňák] + common: + Merge commit 'ooo/OOO330_m15' into libreoffice-3-3 [Jan Holesovsky] + Merge commit 'ooo/OOO330_m16' into libreoffice-3-3 [Rene Engelhard] + sb136: #i114155# partially revert fix for i108776 to avoid ABI incompatibility of jvmaccess library [sb] + Use the new stable libwp* releases as default [Fridrich Štrba] + bootstrap: + Add missing names and descriptions for some language packs [Tor Lillqvist] + CWS-TOOLING: integrate CWS sb136 [obo] + Do not mention date in the downlaod tarball name [Petr Mladek] + fallback to the old install dirname if ooodownloadfilename is not defined [Petr Mladek] + libGLU needs libm so make sure it gets linked [Robert Nagy] + need -lpthread as PTHREAD_LIBS on Linux [Caolán McNamara] + OOO330 [Release Engineering] + Revert "fix smoketest with the improved download tarball (fdo#30837)" [Petr Mladek] + several openbsd changes to find libs and binaries [Robert Nagy] + Use a generic unxgcc.mk [Robert Nagy] + Use the new stable libwp* releases as default [Fridrich Štrba] + build: + Adapt the "unstable" libwp* patches to the new stable libwpd/s/g releses [Fridrich Štrba] + Added "My AutoText" string to po files [Andras Timar] + Added "My AutoText" string to sdf template and to pot [Andras Timar] + Don't use system libwp* now that we require fresh versions of them [Tor Lillqvist] + enable opengl [Robert Nagy] + Estonian (et) translation update [Mihkel Tõnnov] + Finnish (fi) translation update [Harri Pitkänen] + fix a merge conflict separately [Fridrich Strba] + fix a merge conflict separately [Fridrich Štrba] + fix bin/stat-localizations to work again [Rene Engelhard] + fix n#654039 empty toolbar [Noel Power] + fix version in sdbc-postgresql.diff (now 0.7.6b) [Rene Engelhard] + Help bin/install-artwork find the bin/setup file [Tor Lillqvist] + Hungarian (hu) translation update [Andras Timar] + Install to the correct directory based on PREFIX [Robert Nagy] + Japanese (ja) translation update [Takeshi Abe] + lo-set-version: new helper script to increment version in the sources [Petr Mladek] + Make link-as-needed.diff apply again [Tor Lillqvist] + Make ooo86080.unopkg.bodge.diff apply again [Tor Lillqvist] + Make speed-hash-style.diff
[Libreoffice] Release criteria
Hi, we are getting close to the first release candidate and final release. I have created proposal of the release criteria and definition of the blocker bugs at http://wiki.documentfoundation.org/Release_Criteria Feel free to update it or propose improvements. Especially, I am not sure about bugs in localizations. Also please let us know about bugs that you consider as blockers. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Release criteria
Arthur Machlas píše v Pá 26. 11. 2010 v 10:36 -0600: > Not a member of this list, just passing through, but I thought I'd > throw some corrections / suggestions re: criteria > > > Now [N], Suggestion [S], Correction [C] > > [N] "LibreOffice is used by many users every day. Any new release must > not break their day job. Though, every software has bugs." > [S] Remove "Though, every software has bugs." Partly for grammatical > reasons, partly because it doesn't add value to the mission statement, > which is how I read the first two lines. And you say it much better > later on anyway. > > [N] "is public available at least 7 days" > [C] "is publicly available for at least 7 days" > > [N] "You might nominate" > [C] "You may nominate" > > [N] "Also you might add dependency to the meta bug:" > [S] "You should also add a dependency to the meta bug:" > > [N] "Also it does not mean that other bugs" > [S] "This does not mean that other bugs" > > Any questions or comments, please cc me on the reply. I like all the changes. Could you please update the wiki? Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Release criteria
Yi Fan Jiang píše v So 27. 11. 2010 v 19:07 -0700: > Hi Petr, > > The blocker criteria would be quite useful ;-) Thank you! > > For the process to nominate a blocker, is there a specific reason to > report a nomination > twice (1 in mailing list, 2 in bugzilla)? > > > > > You may nominate blocker bugs using the libreoffice mailing list. > Please use the subject: > > Nominating bug as blocker for LibO-X.Y.Z release > > You should also add a dependency to the meta bug: > > * LibO-3.3 - bug #31865 > > > A potential problem of the twice nominating is reporter may forget to > do another process > after finishing one step. e.g. what if he/she only sends a mail and > forget comment on Bugzilla? > Then more documentation effort will be needed to keep 2 sets of > information 'sync'. > > A uniform reporting path might make it more manageable. Can we just > add libreoffice > mailing list to a CC list of the meta bug or something like that. > Since the release version > is included in the Meta bug title, we would not be likely missing new > blocker information > in the mailing list. For the detailed bug list, we just need to check > the dependency fields > by clicking meta bug URL inside the mail. I like the idea about adding libreoffice@lists.freedesktop.org into CC of the meta bug. IMHO, it is worth to have the discussion about blocker bugs on the dev mailing list. Others might help to provide more details if we are in doubts... Thorsten, Kendy, others, what do you think about it? Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] 9th week development summary
Hi,
this time a brief summary of what happened the 9th week on LibreOffice
repos and two living branches:
bugfixes-master-week-47.txt lists all commits that reference a proper
bug id (from a variety of trackers - #i... referring to the OpenOffice
issuezilla, fdo# to freedesktop, rhbz# to RedHat bugzilla etc) in the
master branch
commit-log-master-week-47.txt lists all relevant commits on the actual
source repos in the master branch
commit-log-libreoffice-3-3-week-47.txt,
bugfixes-libreoffice-3-3-week-47.txt lists the same summary for the
libreoffice-3-3 branch.
Many thanks to all contributors - you make all the difference!
Best Regards,
Petr
+ artwork:
+ Revert "nativeb: #i110796# changed document icons for Classic theme"
[Thorsten Behrens]
+ bootstrap:
+ find the internal libpython (fdo#31764) [Petr Mladek]
+ build:
+ layouted zoom dialog was not localized (bnc#595823) [Petr Mladek]
+ reduce height of PDF export and recovery dialogs (bnc#623352) [Petr
Mladek]
+ remove DataAccess.xcu in PostgreSQL SDBC Driver (i#113494) [Rene
Engelhard]
+ components:
+ Resolves: rhbz#656191 Catch bad alloc and convert to ZipIOException
[Caolán McNamara]
+ Resolves: rhbz#657628# divide by zero [Caolán McNamara]
+ show the control geometric propertis correctly (bnc#610921) [Petr Mladek]
+ show the really used default icon theme in options (bnc#603169) [Petr
Mladek]
+ filters:
+ fix for n#648731 imagedata attribute not imported correctly [Noel Power]
+ Missing call to importDocumentProperties() n#655194 [Muthu Subramanian K]
+ tentative fix for fdo#30474# [Noel Power]
+ libs-core:
+ Fix for i#115681 [Cédric Bosdonnat]
+ masterfix OOO330: #i115774# crash in FR version when typing / as first
character [obo]
+ Related: rhbz#650170 don't crash when quickstarter is exited by user
[David Tardon]
+ Resolves: fdo#31494# get ownership right [Caolán McNamara]
+ Resolves: rhbz#610103 exit quickstarter if physically deleted [Caolán
McNamara]
+ rhbz#650170# shutdown quickstarter at end of desktop session [David
Tardon]
+ sb132: #i114155# use "en" as additional fallback locale after "en-US" [sb]
+ sb136: #i115386# prefer en[-US] over empty xml:lang value, to accomodate
existing extensions with bad .xcu content [sb]
+ libs-extern-sys:
+ fixed urllib.urlopen in the internal python (fdo#31466) [Petr Mladek]
+ libs-gui:
+ #i108584# workaround unexpected ATSUBreakLine error result [Herbert Duerr
[hdu]]
+ #i115761# Impress freezes opening the attached odp file(s) [obo]
+ l10n:
+ Updated Bosnian (bs) translation #i115764# [Vedran Ljubović]
+ ure:
+ sb136: #i114155# partially revert fix for i108776 to avoid ABI
incompatibility of jvmaccess library [sb]
+ writer:
+ Fix n#653526: Some section was added after having written the SEPX
[Cédric Bosdonnat]
+ n#652204: Font color selection didn't effect new text [Cédric Bosdonnat]
+ n#652364: Fixed a ww8 column break import problem. [Cédric Bosdonnat]
+ Resolves: rhbz#657541# avoid null ptr. deref. when iterating through
empty itemset [David Tardon]
+ build bits:
+ install branding for the welcome screen in the split build (bnc#653519)
[Petr Mladek]
+ common:
+ tentative fix for fdo#30474# [Noel Power]
+ artwork:
+ Revert "nativeb: #i110796# changed document icons for Classic theme"
[Thorsten Behrens]
+ bootstrap:
+ find the internal libpython (fdo#31764) [Petr Mladek]
+ build:
+ layouted zoom dialog was not localized (bnc#595823) [Petr Mladek]
+ reduce height of PDF export and recovery dialogs (bnc#623352) [Petr
Mladek]
+ remove DataAccess.xcu in PostgreSQL SDBC Driver (i#113494) [Rene
Engelhard]
+ components:
+ Resolves: rhbz#656191 Catch bad alloc and convert to ZipIOException
[Caolán McNamara]
+ Resolves: rhbz#657628# divide by zero [Caolán McNamara]
+ show the control geometric propertis correctly (bnc#610921) [Petr Mladek]
+ show the really used default icon theme in options (bnc#603169) [Petr
Mladek]
+ filters:
+ fix for n#648731 imagedata attribute not imported correctly [Noel Power]
+ Missing call to importDocumentProperties() n#655194 [Muthu Subramanian K]
+ libs-core:
+ Fix for i#115681 [Cédric Bosdonnat]
+ masterfix OOO330: #i115774# crash in FR version when typing / as first
character [obo]
+ Related: rhbz#650170 don't crash when quickstarter is exited by user
[David Tardon]
+ Resolves: fdo#31494# get ownership right [Caolán McNamara]
+ Resolves: rhbz#610103 exit quickstarter if physically deleted [Caolán
McNamara]
+ rhbz#650170# shutdown quickstarter at end of desktop session [David
Tardon]
+ sb132: #i114155# use "en" as additional fallback locale after "en-US" [sb]
+ sb136: #i115386# prefer en[-US] over empty xml:lang value, to accomodate
existing extensions with bad .xcu content [sb
Re: [Libreoffice] PATCH: Try to find the proper berkeley db headers and incs
Hi Robert, Robert Nagy píše v St 01. 12. 2010 v 11:27 +0100: > Hi, > > So this is a modified versio nof patches/dev300/system-db-check.diff > to find the proper berkeley db headers and libs. > I really would like to get this into bootstrap so please test and comment. It looks reasonable and works here. Feel free to commit it. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Make BrOffice branding optional (fdo#31770)
Hi Michael,
could you please review the attached diff before I commit it to the
libreoffice-3-3 branch? I adds your suggested change for
https://bugs.freedesktop.org/show_bug.cgi?id=31770 to make the BrOffice
branding optional.
It works like a charm here.
Best Regards,
Petr
--- unotools/source/config/configmgr.cxx.old 2010-11-30 21:37:52.0 +0100
+++ unotools/source/config/configmgr.cxx 2010-12-02 21:11:38.0 +0100
@@ -402,10 +402,12 @@ Any ConfigManager::GetDirectConfigProper
Any aRet;
::rtl::OUString sBrandName;
+#ifdef ENABLE_BROFFICE
LanguageType nType = MsLangId::getSystemUILanguage();
if ( nType == LANGUAGE_PORTUGUESE_BRAZILIAN )
sBrandName = OUString::createFromAscii("BrOffice");
else
+#endif
sBrandName = BrandName::get();
if ( eProp == PRODUCTNAME && sBrandName.getLength() )
--- unotools/source/config/makefile.mk.old 2010-11-11 16:22:48.0 +0100
+++ unotools/source/config/makefile.mk 2010-12-02 21:04:52.0 +0100
@@ -37,6 +37,9 @@ ENABLE_EXCEPTIONS=TRUE
.INCLUDE : settings.mk
.INCLUDE : $(PRJ)$/util$/makefile.pmk
+.IF "$(ENABLE_BROFFICE)"=="TRUE"
+CDEFS+=-DENABLE_BROFFICE
+.ENDIF
# --- Files -
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] LibreOffice-3.3-rc1 git tag and fixes reviewing
Hi, you have probably already noticed that I created the LIBREOFFICE_3_3_0_1 git tag for LibO-3.3-rc1 release. The builds are still running and should be available in the beginning of the following week. libreoffice-3-3 git branch is still opened for fixes. Just please, send your patches for review to this mailing list before you commit. You might ask a particular person for review via CC or on the irc channel #libreoffice. This more strict process is requested only for the libreoffice-3-3 branch. It has been decided on the steering call to reduce regressions in the RC phase, see http://lists.freedesktop.org/archives/libreoffice/2010-November/003452.html Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] LibreOffice-3.3-rc1 git tag and fixes reviewing
Kohei Yoshida píše v Pá 03. 12. 2010 v 10:51 -0500: > On Fri, 2010-12-03 at 16:36 +0100, Petr Mladek wrote: > > Hi, > > > > you have probably already noticed that I created the LIBREOFFICE_3_3_0_1 > > git tag for LibO-3.3-rc1 release. The builds are still running and > > should be available in the beginning of the following week. > > Is it possible to display the git tag in the About dialog? We often > receive comments from users along the line of "this bug is marked fixed > but I still see this in my version! I'm re-opening this.", and often > it's a bit hard to determine whether the bug is really not fixed, or the > user has an older version not containing the fix. And what they provide > from their About dialog is not straight-forward for many of us. > > If we can attach the git tag we use to build the release build in the > About dialog, it would be much easier to deal with situations like this. The information is there in slightly different form, see the attached screenshot. The version in libreoffice-build- has exactly the same value as the VERSION in the LIBREOFFICE_ tag. It is enough? Best Regards, Petr <>___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] LibreOffice-3.3-rc1 git tag and fixes reviewing
Kohei Yoshida píše v Pá 03. 12. 2010 v 11:34 -0500: > On Fri, 2010-12-03 at 17:25 +0100, Petr Mladek wrote: > > Kohei Yoshida píše v Pá 03. 12. 2010 v 10:51 -0500: > > > On Fri, 2010-12-03 at 16:36 +0100, Petr Mladek wrote: > > > > Hi, > > > > > > > > you have probably already noticed that I created the LIBREOFFICE_3_3_0_1 > > > > git tag for LibO-3.3-rc1 release. The builds are still running and > > > > should be available in the beginning of the following week. > > > > > > Is it possible to display the git tag in the About dialog? We often > > > receive comments from users along the line of "this bug is marked fixed > > > but I still see this in my version! I'm re-opening this.", and often > > > it's a bit hard to determine whether the bug is really not fixed, or the > > > user has an older version not containing the fix. And what they provide > > > from their About dialog is not straight-forward for many of us. > > > > > > If we can attach the git tag we use to build the release build in the > > > About dialog, it would be much easier to deal with situations like this. > > > > The information is there in slightly different form, see the attached > > screenshot. The version in libreoffice-build- has exactly the > > same value as the VERSION in the LIBREOFFICE_ tag. > > Yes, I understand that. But your brain still has to do the mapping > which is an extra mental step. You can think of it as a usability > improvement for hackers. ;-) > > > It is enough? > > I can deal with it, but making it identical with the git tag would make > it much easier. I do not have any strong opinion here. I slightly prefer the current state because I do not like strings written with capitals ;-) Anyway, it is easy to change. You just need to modify the --with-build-version option in distro-configs/Common*.in You might want something like: --with-build-version=\"tag @git...@\" or --with-build-version=\"based on tag @git...@\" Well, in this case, we would need to generate GITTAG value in configure.in. It is currently set only in the build/bin/setup. What others think? ;-) Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] LibreOffice-3.3-rc1 git tag and fixes reviewing
Miklos Vajna píše v Pá 03. 12. 2010 v 17:38 +0100: > On Fri, Dec 03, 2010 at 11:34:13AM -0500, Kohei Yoshida > wrote: > > > It is enough? > > > > I can deal with it, but making it identical with the git tag would make > > it much easier. > > BTW, what is the reason the tag is LIBREOFFICE_3_3_0_1 instead of > libreoffice-3.3.0.1? IIRC cvs did not allow dots in tag names, but that > is not the case with git. Or is there any other reason? Good questuion! We use the cvs naming scheme just from the historical reasons. I would not mind to use the libreoffice-3.3.0.1 variant. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Release criteria
Andrea Pescetti píše v Ne 05. 12. 2010 v 18:39 +0100: > On 26/11/2010 Petr Mladek wrote: > > http://wiki.documentfoundation.org/Release_Criteria > > Feel free to update it or propose improvements. Especially, I am not > > sure about bugs in localizations. > > So a major change with respect to the OpenOffice.org release process > would be that no explicit approval is needed for localized versions. > > This is probably related to the multi-language build model, where you > don't want to wait for 20 or so explicit approvals in order to release > the English version, but still distributing possibly untested software > does not seem very good to me: I did see cases at OpenOffice.org where > only one localized version would not start, or would have blocking > issues. I understand your concerns. We came with the central build because of the many advantages: + translators do not need to fight with technical problems + save space (do not duplicate binaries) + packaging is standardized, compatible, ... I have several ideas how to solve the above problem: + do smoke test of each localization to make sure that it starts at least; we should do it anyway + do more and more frequent bug fix releases with only safe and critical fixes; it is a bit questionable because of resources + allow to later update just a single localization; I am not sure if 3.3 release is technically ready for this; especially, I am not sure how this would work on Windows. Would something of the above be acceptable solution for you? BTW: My dream is to provide a build kit for localizations team. It would be similar to SDK. It would provide scripts and data files. Translators would need to localize the data files (po-files, icons, templates...) and just call a script to produce the installer. > If you need very recent examples, in the OOo 3.3 release cycle at least > two localization-specific stoppers were found and fixed upstream in > OpenOffice.org and thus ported to LibreOffice too: > http://qa.openoffice.org/issues/show_bug.cgi?id=115232 [IT only] > http://qa.openoffice.org/issues/show_bug.cgi?id=115774 [FR only] They were found during the rc phase, so it was in time. The question is how many similar bugs are missed during the rc phase and how many of the missed bugs are real blockers. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] 10th week development summary
Hi, this time a brief summary of what happened the 10th week on LibreOffice repos and two living branches: bugfixes-master-week-48.txt lists all commits that reference a proper bug id (from a variety of trackers - #i... referring to the OpenOffice issuezilla, fdo# to freedesktop, rhbz# to RedHat bugzilla etc) in the master branch commit-log-master-week-48.txt lists all relevant commits on the actual source repos in the master branch commit-log-libreoffice-3-3-week-48.txt, bugfixes-libreoffice-3-3-week-48.txt lists the same summary for the libreoffice-3-3 branch. Many thanks to all contributors - you make all the difference! Best Regards, Petr + common: + fdo#32007# Only register EvolutionLocal when evolution support is enabled [Caolán McNamara] + Stopgap help for the CPU-bound long hang in bug fdo#31716 [Tor Lillqvist] + build: + Add fix for bnc#656566 [Tor Lillqvist] + libs-core: + Backported fix for i#114850 [Mikhail Voytenko] + Further readme polish according to fdo#31956 [Thorsten Behrens] + Partial README update according to fdo#31956 [Thorsten Behrens] + Resolves: rhbz#659947 make this more robust [Caolán McNamara] + libs-gui: + fix invalid read in doubleSequenceToColor, fixes crash in n#654065 [Radek Doulik] + Related: fdo#31243 remove shadowed variable names [Caolán McNamara] + Resolves: fdo#31243 glyph fallback for cairo-canvas [Caolán McNamara] + Resolves: #i115788# URIs must be exported as 7bit ASCII [Caolán McNamara] + use BrOffice in pt_BR locale (fdo#31770) [Petr Mladek] + use BrOffice name only with --enable-broffice (fdo#31770) [Petr Mladek] + l10n: + Updated Bosnian (bs) translation #i115764# [Vedran Ljubović] + writer: + fdo#31190: Use the same method to getthe DBData than the mail merge [Cédric Bosdonnat] + fdo#32039: Missing outline feature in new RTF export filter [Cédric Bosdonnat] + n#636367: Table alignment set to "From Left" when moving the right [Cédric Bosdonnat] + Resolves: rhbz#657718# Crash in SwObjectFormatterTxtFrm::CreateObjFormatter [Caolán McNamara] + common: + fdo#32007# Only register EvolutionLocal when evolution support is enabled [Caolán McNamara] + Import hyperlinks of textboxes/shapes - n#655216 [Muthu Subramanian K] + Import of super/subscript properties of cells - n#655193 [Muthu Subramanian K] + calc: + Fix incorrect merge conflict. This fixes fdo#32002. [Caolán McNamara] + Resolves: rhbz#658304 late-init color config. to avoid crash on recovery [David Tardon] + filters: + Export frame around graphic object into xlsx (bnc#654525) [Katarina Machalkova] + libs-core: + Resolves: rhbz#659947 make this more robust [Caolán McNamara] + libs-gui: + fix invalid read in doubleSequenceToColor, fixes crash in n#654065 [Radek Doulik] + Related: fdo#31243 remove shadowed variable names [Caolán McNamara] + Resolves: fdo#31243 glyph fallback for cairo-canvas [Caolán McNamara] + Resolves: #i115788# URIs must be exported as 7bit ASCII [Caolán McNamara] + use BrOffice in pt_BR locale (fdo#31770) [Petr Mladek] + writer: + autocomplete using the context's case i#22961 [Michael Meeks] + fdo#31190: Use the same method to getthe DBData than the mail merge [Cédric Bosdonnat] + fdo#32039: Missing outline feature in new RTF export filter [Cédric Bosdonnat] + Fix for i#8288: "Replace all" should leave the cursor at original position [Mattias Johnsson] + n#636367: Table alignment set to "From Left" when moving the right [Cédric Bosdonnat] + Resolves: rhbz#657718# Crash in SwObjectFormatterTxtFrm::CreateObjFormatter [Caolán McNamara] + common: + Adds OxygenOffice extras as configurable optional [Kalman Szalai - KAMI] + fdo#32007# Only register EvolutionLocal when evolution support is enabled [Caolán McNamara] + RTF: port last changes from CWS [Miklos Vajna] + Stopgap help for the CPU-bound long hang in bug fdo#31716 [Tor Lillqvist] + Updated artwork for rc [Thorsten Behrens] + Version 3.3.0.1, tag LIBREOFFICE_3_3_0_1 (3.3-rc1) [Petr Mladek] + artwork: + Fixed icons now with png optimizations [Andrew C. E. Dent] + bootstrap: + Add BrOffice artwork / branding support [Michael Meeks] + add PRODUCTNAME_BR for ulf substitution - now an l10n problem [Michael Meeks] + Do not try to break 2 levels if ther is only one loop to break [Robert Nagy] + fix comment of checking the max number of jobs [Robert Nagy] + fix PYTHON_LIBS [Robert Nagy] + fix the list of languages and remove the unused wanted function [Robert Nagy] + get substitution order right for overlapping variables [Michael Meeks] + make NSIS MUI even more verbose [Michael Meeks] + merge a modified version of patches/dev300/system-db-check.diff [Robert Nagy] + Move progress bar (-20,-20) for new artwork [Thorsten Behrens] + Windows Installer package that contains mor
Re: [Libreoffice] 10th week development summary
Florian Effenberger píše v Út 07. 12. 2010 v 16:11 +0100: > Hi, > > Petr Mladek wrote on 2010-12-07 16.09: > > > this time a brief summary of what happened the 10th week on LibreOffice > > repos and two living branches: > > thanks a lot for the summary! It would be cool if we could have those > nice contributor graphs every week -- marketing is keen on it :-) Great idea! Any volunteer to implement some scripting around it? ;-) I added this idea to the related easy task at http://wiki.documentfoundation.org/Development/Easy_Hacks#Weekly_summary_.2F_Release_summary Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Release tag convention
Hi, there is a proposal to use the tag "libreoffice-3.3.0.1" instead of "LIBREOFFICE_3_3_0_1" and mention it in the LibreOffice/About dialog as is. It is more clear and understandable. Would you mind if we do this change for LibO-3.3-rc2? Note that the uppercase- and underscore-naming scheme comes from the CVS days. CVS did not allowed dots in the tag names, ... Other projects use the lower case and dots these days... For more details, read the discussion starting at http://lists.freedesktop.org/archives/libreoffice/2010-December/003957.html Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Release tag convention
Norbert Thiebaud píše v Út 07. 12. 2010 v 11:22 -0600: > On Tue, Dec 7, 2010 at 9:36 AM, Petr Mladek wrote: > > Hi, > > > > there is a proposal to use the tag "libreoffice-3.3.0.1" instead of > > "LIBREOFFICE_3_3_0_1" and mention it in the LibreOffice/About dialog as > > is. It is more clear and understandable. > > > > Would you mind if we do this change for LibO-3.3-rc2? > > If it is going to be user-visible (as in an About Box), why not avoid > abbreviations ? > that is: LibreOffice-3.3-rc2 This whole discussion started with the request to mention the exact git tag string in the about dialog. It helps developers to distinguish what exact sources were used to produce the buggy build. Unfortunately, we have two demands. The abbreviations "alpha", "beta", "rc", and "final" are better understandable for users. They are more intuitive when describing the stability and amount of passed testing. The numbers are needed for packagers because they help installer to decide what package is newer. Note that the package versions are compared alphanumerically, so 3.3rc1 > 3.3final > 3.3 IMHO, users know what they download and install. They usually check the about dialog only when they want to report a bug => I prefer to use the numbers everywhere and use the abbreviation only in the announce mails and maybe for tarballs with packages. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] LibreOffice-3.3-rc1 git tag and fixes reviewing
Thorsten Behrens píše v Pá 03. 12. 2010 v 21:50 +0100: > Petr Mladek wrote: > > libreoffice-3-3 git branch is still opened for fixes. Just please, send > > your patches for review to this mailing list before you commit. You > > might ask a particular person for review via CC or on the irc channel > > #libreoffice. > > > Hi Petr, all, > > it would then be nice if the reviewer (when the fix is ok) could > commit with a proper --author, and a sign-off note (just add -s). > That makes it relatively easy to check for review, without having to > search the mailing list. Yup, that make sense. I have summarized all the ideas at http://wiki.documentfoundation.org/Development#Hack_and_commit_on_a_stable_branch Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Review of fdo# 31770 - help content BrOffice branding
Hi Michael, could you please review the diff at https://bugs.freedesktop.org/attachment.cgi?id=40959 See https://bugs.freedesktop.org/show_bug.cgi?id=31770#c14 for explanation of the changes. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Number of days for testing RC
Hi, Jean has modified http://wiki.documentfoundation.org/Release_Criteria and increased the number of days for reporting blocker bugs from 7 to 10. He says that they need to do the complete WE inside the period, see http://wiki.documentfoundation.org/Talk:Release_Criteria Heh, what is "WE"? :-) OOo has only 5 days, see http://wiki.services.openoffice.org/wiki/Release_criteria#Stopper_issues How is it there with building and approving the national builds? Michael thought that 7 days were too much, see http://lists.freedesktop.org/archives/libreoffice/2010-November/003498.html Jean and Michael already discussed this matter, see http://lists.freedesktop.org/archives/libreoffice/2010-November/003505.html http://lists.freedesktop.org/archives/libreoffice/2010-November/003600.html My opinion is that 10 days might make sense for the first release candidate but it is too much for the next release candidates. Otherwise, we would do only 2 release candidates during one month and the release would be newerending story. Note that we have more strict rules for changes during the rc phase, see http://wiki.documentfoundation.org/Development#Hack_and_commit_on_a_stable_branch Also I think that it does not make sense that every national team would do the whole testing. IMHO, 95% of the functionality is language independent, so most of the testing can be shared and distributed. I propose to go back and use 7 days for rc2. What do you think? Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Release criteria
Hi, ah, I have somehow missed this mail. Sophie Gautier píše v Ne 05. 12. 2010 v 20:49 +0300: > Hi Andrea, all, > On 05/12/2010 20:39, Andrea Pescetti wrote: > > On 26/11/2010 Petr Mladek wrote: > >> http://wiki.documentfoundation.org/Release_Criteria > >> Feel free to update it or propose improvements. Especially, I am not > >> sure about bugs in localizations. > > > > So a major change with respect to the OpenOffice.org release process > > would be that no explicit approval is needed for localized versions. > > Imho, this should still be needed. Manuals tests are currently developed > on the wiki and they should be run on each language for approval of the > build to be elected as stable. > > > This is probably related to the multi-language build model, where you > > don't want to wait for 20 or so explicit approvals in order to release > > the English version, but still distributing possibly untested software > > does not seem very good to me: I did see cases at OpenOffice.org where > > only one localized version would not start, or would have blocking > > issues. > > I agree and this is why the non tested build were left on RC state. We > should not change this or we will miss some quality. Hmm, we want the multilang build because of the reason mentioned in my other reply to this thread. I think that it is not realistic to wait for approval from all the localizations teams. LibO-3.3-RC1 has been available since December 6. RC2 will not be sooner than December 15. So, you should have time to nominate blockers until December 22. So, you should have 18 days for testing. The idea is that the fixes between RCs must be safe and reviewed, so they should not trigger the whole QA process. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Number of days for testing RC
Hi Jean-Baptiste, Jean-Baptiste Faure píše v Pá 10. 12. 2010 v 20:02 +0100: > Hi Petr, all, > > Le 10/12/2010 15:24, Petr Mladek a écrit : > > Hi, > > > > Jean has modified http://wiki.documentfoundation.org/Release_Criteria > > and increased the number of days for reporting blocker bugs from 7 to > > 10. > My first name is Jean-Baptiste :-) Ah, I am sorry, shame on me. > > He says that they need to do the complete WE inside the period, > > see http://wiki.documentfoundation.org/Talk:Release_Criteria > > > > Heh, what is "WE"? :-) > Sorry, it is an acronym for a typical French expression : Week-End ;-) This is why I proposed 7 days instead 5 days. 7 days have the Weekend included by definition :-) > I think we need more time to allow volunteers to do manual tests. They > do these tests during their spare time so often during the week-end. > > OOo has only 5 days, see > > http://wiki.services.openoffice.org/wiki/Release_criteria#Stopper_issues > > How is it there with building and approving the national builds? > Perhaps am I influenced by the big number of RC we have raised for OOo > 3.3.0, but I think that if we take our time to deeply test our release > candidates, we will have better stable version and enjoyed and not > discouraged testers. Hmm, I think that OOo-3.3 release is not a good example: OOo-3.3 development started on 2009-09-21 (branch for OOo-3.2) OOo-3.3 feature freeze was on 2009-06-24 (branch for OOo-3.3, feature freeze) OOo-3.3-rc1 released on 2009-10-18 So, development took 9 months. Initial stabilization took 4 months. RC phase takes nearly 2 months and is still not finished. Note that it was not full 9 months of development because many developers were busy with stabilizing OOo-3.2 and OOo-3.2.1. Of course, it was affected by the acquisition of Sun by Oracle but it is far from the original plan to release minor release every 6 months. The long cycle is discouraging for many volunteers. They want to have their work living and used by users. Also it is much easier to fix bugs shortly after a feature is finished than one year after implementation. There is an idea of more micro bug fix releases. The published minor release should be well usable for 99% of normal users. The micro releases could be done every next month or so. They would include just safe and reviewed bug fixes and should need not full QA. The second or third micro release should be well usable for 99% experienced users. > > Also I think that it does not make sense that every national team would > > do the whole testing. IMHO, 95% of the functionality is language > > independent, so most of the testing can be shared and distributed. > Right. For OOo, NL QA-team do only Release Sanity Test. But the current > test period on OOo 3.3.0 shows that the last blockers have been found by > the Community and these blockers could not be found by automatic or TCM > tests; they have been found by users who have done tests on their > documents they use in the real life. > To do that we need time. I see. Well, I think that even the released OOo version included pretty annoying bugs and some of them would be considered as blockers. Such bugs were usually fixed in the micro release x.y.1. We just need to define the right compromise that would be acceptable for all sides developers, testers, and users. Just to get better picture. How much time would you need to finish all known manual tests? Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Number of days for testing RC
Andrea Pescetti píše v Ne 12. 12. 2010 v 19:30 +0100: > On 10/12/2010 Petr Mladek wrote: > > OOo has only 5 days, see > > http://wiki.services.openoffice.org/wiki/Release_criteria#Stopper_issues > > How is it there with building and approving the national builds? > > As shown in the page you link, it's "5 days including a weekend", so the > constraints proposed by Jean-Baptiste are still respected. My original 7 days included weekend by definition ;-) > > My opinion is that 10 days might make sense for the first release > > candidate but it is too much for the next release candidates. Otherwise, > > we would do only 2 release candidates during one month and the release > > would be newerending story. > > I agree that 2 release candidates a month are too few. But you needn't > reach 8 RCs every time! I mean, OpenOffice.org 3.3 RCs were produced > with a 3-7 days delay between each other and this was wrong and > confusing; a longer time between RCs allows to fix more bugs, provided > that testing continues. So, if a Release Candidates fixes several > stopper bugs, it can make sense to have fewer (and, in this case, you > will hopefully never reach 8 RCs). A question is if new RC need to trigger the full QA. We try to avoid it by reviewing the fixes. > > 95% of the functionality is language > > independent, so most of the testing can be shared and distributed. > > Mostly, indeed. But still there are subtle bugs (fixed in OOo 3.3-RC > Italian: a wrongly translated style name that caused a name clash with > another style and caused bizarre behavior only when that specific style > was used and only in the Italian version) that suggest that, to be safe > from the start, a more thorough testing would be needed. On the other > hand, this would be the kind of bugs you would probably address in > LibreOffice with very frequent bug-fix releases, thus preferring > "on-the-field" QA by all LibreOffice 3.3 users to the preliminary QA by > volunteers. The testing by volunteers is really appreciated. We would not be able to release without it. People would not use LibO if there are bugs in the basic functionality. Just to get idea? How much time would you need to make 99% normal users happy? It means that you need not test any hi-tech features. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Release criteria
Andrea Pescetti píše v So 11. 12. 2010 v 11:45 +0100: > On 06/12/2010 Petr Mladek wrote: > > Andrea Pescetti píše v Ne 05. 12. 2010 v 18:39 +0100: > > > So a major change with respect to the OpenOffice.org release process > > > would be that no explicit approval is needed for localized versions. > > ... I understand your concerns. We came with the central build because of > > the many advantages: > > + translators do not need to fight with technical problems > > + save space (do not duplicate binaries) > > + packaging is standardized, compatible, ... > > Yes, these are clear advantages from the infrastructure point of view. > > > I have several ideas how to solve the above problem: > > + do smoke test of each localization to make sure that it starts > > at least; we should do it anyway > > + do more and more frequent bug fix releases with only safe and > > critical fixes; it is a bit questionable because of resources > > + allow to later update just a single localization > > These are all valid solutions, but they will not help for the quality of > the first (3.3) release, which will be rather important. Sure. I see that LO-3.3 will be a kind of special as well ;-) OOo-3.3-rc8 is delayed. They moved the the final release to January. We are going to create LO-3.3-rc2 tag (most likely tomorrow) and provide newer builds with the Windows help packs, ... I am pretty sure that we will need rc3 to integrate more fixes from OOo-3.3-rc8, ... It means that the LO-3.3 release is going to slip to January as well. It should give you more time for testing... Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Help?
Hi Jerry, Jerry Shi píše v St 15. 12. 2010 v 20:57 -0500: > Alright, thanks for the reply. So, I tried to install the > dependencies, but I ran into some problems. There were requests all > over the place to change the architecture for lots of software from > x86-64 to normal. should I go through with all of these changes, or > did I do something wrong? It sounds strange and should not happen. OOo/LO is buildable on x86_64 with x86_64 packages. What exact command have you run? Could you please provide the list of your repositories? Jsut cut&paste output from the command: zypper lr -d Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] need review for 3-3: better build identification in the about dialog
Hi, could anyone review that attached diff, so we could add it for libreoffice-3-3? It has two effects: + we will show the "tag libreoffice-3.3.0.2" in the about dialog instead of "libreoffice-build-3.3.0.2" + we will use the tag "libreoffice-3.3.0.2" instead of "LIBREOFFICE_3_3_0_2" Both changes were requested, discussed, and approved in the thread http://lists.freedesktop.org/archives/libreoffice/2010-December/004243.html Best Regards, Petr >From 238fe267727fe84eb18c0521ca767a613d0def7e Mon Sep 17 00:00:00 2001 From: Petr Mladek Date: Thu, 16 Dec 2010 14:39:32 +0100 Subject: [PATCH] better build identification in the about dialog mention "tag " in about dialog instead of build version; also use the tag "libreoffice-" instead of the historic "LIBREOFFICE_VERSION" it has been requested and discussed on the libreoffice mailing list --- bin/setup.in |2 +- configure.in |4 distro-configs/CommonLinux.conf.in |2 +- distro-configs/CommonMac.conf.in |2 +- distro-configs/CommonWin32.conf.in |2 +- 5 files changed, 8 insertions(+), 4 deletions(-) diff --git a/bin/setup.in b/bin/setup.in index f6c6ac6..99c2a77 100755 --- a/bin/setup.in +++ b/bin/setup.in @@ -18,7 +18,7 @@ OOO_GIT='@OOO_GIT@' OOO_SOURCEDIRNAME='@OOO_SOURCEDIRNAME@' CLONEDIR='@CLONEDIR@' RAWBUILDDIR='@RAWBUILDDIR@' -GITTAG="ooo/`echo $OOO_SOURCEDIRNAME | tr '[[:lower:]]-' '[[:upper:]]_'`" +GITTAG='@GITTAG@' APPLY_DIR='@APPLY_DIR@' BUILD_NCPUS='@BUILD_NCPUS@' ENABLE_CCACHE='@ENABLE_CCACHE@' diff --git a/configure.in b/configure.in index b6a2e0c..79dbe58 100755 --- a/configure.in +++ b/configure.in @@ -629,6 +629,10 @@ AC_SUBST(OOO_SOURCEVERSION) OOO_SOURCEDIRNAME=libreoffice-$OOO_SOURCEVERSION AC_SUBST(OOO_SOURCEDIRNAME) +# git tag name +GITTAG=$OOO_SOURCEDIRNAME +AC_SUBST(GITTAG) + AC_MSG_CHECKING([for split sources]) if test "$with_split" = "no" ; then SPLIT= diff --git a/distro-configs/CommonLinux.conf.in b/distro-configs/CommonLinux.conf.in index 286b742..0ed4670 100644 --- a/distro-configs/CommonLinux.conf.in +++ b/distro-configs/CommonLinux.conf.in @@ -1,6 +1,6 @@ --disable-epm --with-openldap ---with-build-version=\"libreoffice-build @ooo_buildvers...@\" +--with-build-version=\"tag @git...@\" --without-fonts --with-system-jpeg --with-system-libxml diff --git a/distro-configs/CommonMac.conf.in b/distro-configs/CommonMac.conf.in index a39e3e9..9983178 100644 --- a/distro-configs/CommonMac.conf.in +++ b/distro-configs/CommonMac.conf.in @@ -1,2 +1,2 @@ --disable-gtk ---with-build-version=\"libreoffice-build @ooo_buildvers...@\" +--with-build-version=\"tag @git...@\" diff --git a/distro-configs/CommonWin32.conf.in b/distro-configs/CommonWin32.conf.in index a641993..4edfec8 100644 --- a/distro-configs/CommonWin32.conf.in +++ b/distro-configs/CommonWin32.conf.in @@ -1,2 +1,2 @@ --with-ant-home=$BUILDDIR/$APACHE_ANT ---with-build-version=\"libreoffice-build @ooo_buildvers...@\" +--with-build-version=\"tag @git...@\" -- 1.6.0.2 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Help?
Jerry Shi píše v Pá 17. 12. 2010 v 22:12 -0500: > ...I'm so confused. I tried running zypper si -d lo-unstable, but I > got an error that source package lo-unstable wasn't found "lo-unstable" is alias to the repository name. The sources packages is "libreoffice-bootstrap" > . I have the results of zypper attached. What happened? The output shows that the "lo-unstable" repository is enabled but the refresh is disabled. It might mean that the list of packages is outdated and they do not longer exist on the repository. You might enable the refresh using the call: zypper mr -r "lo-unstable" Then you might try to install build dependencies for the package libreoffice-boostrap: zypper si -d libreoffice-bootstrap Unfortunately, the java dependencies are not perfect. I suggest to explicitely install openJDK-devel using: zypper in java-1_6_0-openjdk-devel Finally, if you did not have any Java SDK installed, you JAVA_HOME variable points to the JRE. The variable is set by the profile /etc/profile.d/alljava.sh. If you want to update the variable in the current shell, you might might source the profile: source /etc/profile.d/alljava.sh Alternatively, you might do the build in a fresh terminal. It should source the profile automatically there. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Number of days for testing RC
Hi Jean, I am sorry for the late repply. I have been busy with LO-3.3-rc2. Jean-Baptiste Faure píše v Čt 16. 12. 2010 v 06:05 +0100: > Le 13/12/2010 15:04, Petr Mladek a écrit : > > This is why I proposed 7 days instead 5 days. 7 days have the Weekend > > included by definition :-) > Not really if the period start just before the WeekEnd. If a new RC is > released on Friday for QA-test, most of the testers will not be able to > start their tests before Monday. Fair enough. We will try to do not release on Friday. Alternatively, would it help if we pre-announce the upcoming rc2 few days before it is available? It might always be delayed because of technical problems. Though, I think that we could predict it pretty well two days before it is published. > > Hmm, I think that OOo-3.3 release is not a good example: > Yes, from RC cycle point of view, it is an example that LibO should not > follow. > The process is not sufficiently clear: Yeah, we are still setting the processes up. > what QA-team must do when a stopper is found and known? The current solution is described at http://wiki.documentfoundation.org/Release_Criteria#Blocker_Bug_Nomination > If a new RC is build immediately, a second > stopper can be fixed only on this new RC so it is not interesting to > continue to test the old RC. It is more true because the new RC can > introduce regression to the old one. You are right that any fix could bring regression. Though, I think that it always makes sense to continue with testing: + there might be more blocker bugs; they are usually independent; it is better to find all blockers as soon as possible + the fix for the stable branches should be tested and reviewed before they are committed; it should reduce the number of regressions to minimum; the question is if we really need to repeat the whole QA for each rc; I think that it should depend on the number and complexity of the fixes; this information should be mentioned in the announce mail + it takes few days to produce new rc (time needed to fix the bug, do some testing, build in Windows, Linux, MAC; upload to mirrors) > So I think we need a very clear QA test process: known dates for RC, I am not sure if we want a regular schedule, e.g. do the rc release every Thursday and every second Thursday. I think that such approach would wok well for alpha/beta builds. In case of release candidates, I think that it is better to do them according to the current state. I mean to release them when all blockers are fixed or when there are more that 2 weeks without release. Note that we plan to upload also daily builds in the future. They might be used to verify fixes even before the official release. > when it is useful to search blockers and when we can stop to search > stoppers until a new RC is released. I think that it makes sense only when the application does not start at all, so that the blocker bug blocks the testing completely. > > There is an idea of more micro bug fix releases. The published minor > > release should be well usable for 99% of normal users. The micro > > releases could be done every next month or so. They would include just > > safe and reviewed bug fixes and should need not full QA. The second or > > third micro release should be well usable for 99% experienced users. > Ok for me. The only condition I see to make the end-users happy, is that > the status of each version released must be very clear for the end-user. > Individual users or small organizations may want use always the last > micro-release while bigger organizations like administrations will have > a longer cycle of update. Yes, we need to make it clear. > >>> Also I think that it does not make sense that every national team would > >>> do the whole testing. IMHO, 95% of the functionality is language > >>> independent, so most of the testing can be shared and distributed. > >> Right. For OOo, NL QA-team do only Release Sanity Test. But the current > >> test period on OOo 3.3.0 shows that the last blockers have been found by > >> the Community and these blockers could not be found by automatic or TCM > >> tests; they have been found by users who have done tests on their > >> documents they use in the real life. > >> To do that we need time. > > I see. Well, I think that even the released OOo version included pretty > > annoying bugs and some of them would be considered as blockers. Such > > bugs were usually fixed in the micro release x.y.1. > > > > We just need to define the right compromise that would be acceptable for > > all sides developers, testers, and users sure > > Just to get better picture. How
Re: [Libreoffice] ixion breakage in sw
Henrik /KaarPoSoft píše v Út 16. 11. 2010 v 12:23 +0100: > Dear all, > > I am trying to build libreoffice 3.2.99.3 > > In sw/util when making libswli.so I get: > > ../unxlngi6.pro/slo/cellfml.o: In function `lcl_ConvertWWFormula(String > const&)': > cellfml.cxx:(.text+0x29c4): undefined reference to > `ixion::formula_lexer::swap_tokens(boost::ptr_vector boost::heap_clone_allocator, _STL::allocator >&)' > cellfml.cxx:(.text+0x2a13): undefined reference to > `ixion::formula_parser::formula_parser(boost::ptr_vector > boost::heap_clone_allocator, _STL::allocator > const&, > boost::ptr_map<_STL::basic_string, > _STL::allocator >, ixion::base_cell, > _STL::less<_STL::basic_string, > _STL::allocator > >, boost::heap_clone_allocator, > _STL::allocator<_STL::pair<_STL::basic_string _STL::char_traits, _STL::allocator > const, void*> > >*, bool)' > > Re-building with VERBOSE=true confirms that the ixion library is > included in the g++ command: -lixion-0.2 > > However: > nm -C solver/330/unxlngi6.pro/lib/libixion-0.2.a | grep > formula_lexer::swap_tokens > Gives: > 0ec4 T > ixion::formula_lexer::swap_tokens(boost::ptr_vector boost::heap_clone_allocator, std::allocator >&) > U > ixion::formula_lexer::swap_tokens(boost::ptr_vector boost::heap_clone_allocator, std::allocator >&) I wonder if it might be related to stlport. I see the same problem on SLED10 where I have the stlport enabled. I do not see it on SLED11 where I compile without stlport. The symbol in libixion-0.2.a has "std::allocator". cellfml.o wants to use _STL::allocator ixion is compiled without STL; cellfml.o is compiled with STL; I have tried to compile ixion with STL but I got many error; hmm, it will need more love. Cedric, Kohei, do you suggest anything? Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Oracle wordbook in LibO
Kálmán „KAMI” Szalai píše v Pá 31. 12. 2010 v 10:17 +0100: > Hi All, > > Patches attached to issue, please review. Ah, we use Novell.dic in our build. It includes just language-independent names of Novell products, so it should not cause any harm to anyone. I attached different patches to the issue. KAMI, could you please review them? > I also found that: > > * We don't provide standard.dic as user dictionary. Is this intentional? It looks fine. It is empty by default. It is automatically created when user add his own words in the spellcheck dialog. > * We provide language dependent *.dic files in binary format, however > standard.dic is a plain text file. Heh, I wonder how the binary dictionaries were created. I guess that it is an older format that comes from the old StarOffice times. I suggest to create any new dictionary in the text format. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] 13th and 14th week development summary
Hi, this time a brief summary of what happened the 13th and 14th week on LibreOffice repos and two living branches: bugfixes-master-week-51-52.txt lists all commits that reference a proper bug id (from a variety of trackers - #i... referring to the OpenOffice issuezilla, fdo# to freedesktop, rhbz# to RedHat bugzilla etc) in the master branch commit-log-master-week-51-52.txt lists all relevant commits on the actual source repos in the master branch commit-log-libreoffice-3-3-week-51-52.txt, bugfixes-libreoffice-3-3-week-51-52.txt lists the same summary for the libreoffice-3-3 branch. Many thanks to all contributors - you make all the difference! Best Regards, Petr + build: + fdo#32380, n#649506: Fixed navigation buttons' patch selection handling [Cédric Bosdonnat] + calc: + Avoid double-paste when pasting text into cell comment. (fdo#32572) [Kohei Yoshida] + Remove bogus check for numerical sheet names. (fdo#32570) [Kohei Yoshida] + extensions: + Enabling l10n of nlpsolver fdo#30839 [Andras Timar] + impress: + Resoves: rhbz#663857 font color missing; C++ FAQ 10.3 doomage (cherry picked from commit 963c6b655032b4e5d0f26555f3c26a129a9efb03) [Caolán McNamara] + libs-core: + Do not block when launching firefox, fdo#32427. [Jan Holesovsky] + Resolves: rhbz#666216 survive missing window (cherry picked from commit e9438320b50e647f6c5bf052148bcd501b7b55d4) [Caolán McNamara] + libs-gui: + If the language is not specified, use the initial language. (fdo#32523) [Kohei Yoshida] + l10n: + F~ormel menu instead of Formel - fdo#32584 [Andras Timar] + writer: + Resolves: rhbz#660342 Undo/Redo crash with postits (cherry picked from commit 1b58066892daa9365d23b39d7439fbbe7d562b13) [Caolán McNamara] + common: + Drop msvc*7*.dll, see fdo#32426 [Tor Lillqvist] + bootstrap: + Drop msvcr71, see fdo#32426 [Tor Lillqvist] + Drop msvc*7*.dll, see fdo#32426 [Tor Lillqvist] + Resolves: fdo#32426 first cut at auto-downloading windows depends [Caolán McNamara] + calc: + Avoid double-paste when pasting text into cell comment. (fdo#32572) [Kohei Yoshida] + Remove bogus check for numerical sheet names. (fdo#32570) [Kohei Yoshida] + extensions: + Enabling l10n of nlpsolver fdo#30839 [Andras Timar] + filters: + #i101360# use xsl:element for element construction [David Tardon] + impress: + Resoves: rhbz#663857 font color missing; C++ FAQ 10.3 doomage (cherry picked from commit 963c6b655032b4e5d0f26555f3c26a129a9efb03) [Caolán McNamara] + libs-core: + Allow tear-off for the Arrowheads dialog, fdo#32676. [Jan Holesovsky] + Do not block when launching firefox, fdo#32427. [Jan Holesovsky] + Rename .uno:UndoAction/Redo to "Undo"/"Redo", fdo#32472. [Jan Holesovsky] + Resolves: rhbz#666216 survive missing window [Caolán McNamara] + Resolves: rhbz#666216 survive missing window (cherry picked from commit e9438320b50e647f6c5bf052148bcd501b7b55d4) [Caolán McNamara] + libs-extern: + Drop msvc*7*.dll, see fdo#32426 [Tor Lillqvist] + libs-gui: + gtk: Use the right padding in the menus, bnc#304620 [Jan Holesovsky] + If the language is not specified, use the initial language. (fdo#32523) [Kohei Yoshida] + Resolves: #i76587# DEFAULT encodings can't be assumed to be system encoding [Caolán McNamara] + l10n: + F~ormel menu instead of Formel - fdo#32584 [Andras Timar] + ure: + Load msvcr71.dll needed by JVM using explicit path, see fdo#32426 [Tor Lillqvist] + writer: + remove non-functional column count limit (part of fdo#30860) [Luboš Luňák] + Resolves: fdo#32633 rearrange title dialog to get translations to fix [Caolán McNamara] + Resolves: #i113655# rhbz#621277 crash with missing DocShell [Caolán McNamara] + Resolves: rhbz#660342 Undo/Redo crash with postits [Caolán McNamara] + Resolves: rhbz#660342 Undo/Redo crash with postits (cherry picked from commit 1b58066892daa9365d23b39d7439fbbe7d562b13) [Caolán McNamara] + work around tables with many columns for msoffice (fdo#30860) [Luboš Luňák] + common: + Remove extensions' filename version during unpack [Kalman Szalai - KAMI] + bootstrap: + Remove version info from extension folder name too. [Kalman Szalai - KAMI] + typo fix in helppack.ulf [Andras Timar] + Update SUN Template Pack extensions' packaing mechanism [Kalman Szalai - KAMI] + build: + Correct credits url to website conventions (again) [Andras Timar] + fdo#32380, n#649506: Fixed navigation buttons' patch selection handling [Cédric Bosdonnat] + Hungarian (hu) translation update [Andras Timar] + po/pot update because of a typo fix in scp2 module [Andras Timar] + remove long obsolete copy of (and broken check for) mysql-connector-cpp.zip [Rene Engelhard] + removing fixes-br.sdf, I merged it into the big localize.sdf [Andras Timar] + Slovenian (sl) translation update [Martin Srebotnjak] + Update patches for UbuntuMaverick and and distro-co
Re: [Libreoffice] Oracle wordbook in LibO
Kálmán „KAMI” Szalai píše v St 05. 01. 2011 v 17:39 +0100: > Hi! > > 2011-01-05 17:01 keltezéssel, Petr Mladek írta: > > Ah, we use Novell.dic in our build. It includes just > > language-independent names of Novell products, so it should not cause > > any harm to anyone. I attached different patches to the issue. KAMI, > > could you please review them? > Can we introduce here some other technical, and distibution related > files here, not just Novell related, words from Ubuntu, Debian, etc. I > think we should have only one extra dic file, or is is a performance > killer thing? Great idea! I would call it technical.dic or so. KAMI, could you please cook up something? Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] Fix passing distro specific branding via configure
Hi, the configure options --with-intro-bitmaps, --with-about-bitmaps did not longer worked. I think that nobody needs more pictures. The attached patches rename the above options to pass only one picture and fix the stuff to work. KAMI, could you sign it off for libreoffice-3-3 branch? Best Regards, Petr >From aeb812f7f576e0eb092434f9191c41ba70d71782 Mon Sep 17 00:00:00 2001 From: Petr Mladek Date: Wed, 5 Jan 2011 19:27:15 +0100 Subject: [PATCH] Fix distro specific about intro hadling I guess that nobody uses more alternative branding pictures. It was implemented for SLED10-GM and it is not longer needed there. So I renamed: --with-intro-bitmaps to --with-intro-bitmap --with-about-bitmaps to --with-about-bitmap and INTRO_BITMAPS to INTRO_BITMAPS ABOUT_BITMAPS to ABOUT_BITMAP Also .png file format is requred instead of .bmp now. --- configure.in | 68 +++-- set_soenv.in |4 +- 2 files changed, 30 insertions(+), 42 deletions(-) diff --git a/configure.in b/configure.in index 266f7e3..d703dde 100644 --- a/configure.in +++ b/configure.in @@ -1091,20 +1091,18 @@ AC_ARG_WITH(dict, Usage: --with-dict=ENGB,ENUS,ITIT ],,) -AC_ARG_WITH(intro-bitmaps, -[ --with-intro-bitmapsPrefer the specified intro bitmaps over the - the default one. Can be more than one (separated by - commas), the order means priority of fallback if the - first does not exist (in the installed tree). +AC_ARG_WITH(intro-bitmap, +[ --with-intro-bitmapPrefer the specified intro bitmap over the + the default one. - Usage: --with-intro-bitmaps=/path/my_ooo_intro.bmp + Usage: --with-intro-bitmap=/path/my_ooo_intro.png ],,) -AC_ARG_WITH(about-bitmaps, -[ --with-about-bitmapsSimilarly to --with-intro-bitmaps, this allows - specification of bitmaps for the About box. +AC_ARG_WITH(about-bitmap, +[ --with-about-bitmapSimilarly to --with-intro-bitmap, this allows + specification of bitmap for the About box. - Usage: --with-about-bitmaps=/path/my_ooo_about.bmp + Usage: --with-about-bitmap=/path/my_ooo_about.png ],,) AC_ARG_WITH(vendor, @@ -7775,43 +7773,33 @@ else fi AC_SUBST(WITH_DICT) -AC_MSG_CHECKING([for additional 'intro' bitmaps]) -INTRO_BITMAPS= -if test -z "$with_intro_bitmaps" -o "$with_intro_bitmaps" = "no" ; then - INTRO_BITMAPS= +AC_MSG_CHECKING([for another 'intro' bitmap]) +INTRO_BITMAP= +if test -z "$with_intro_bitmap" -o "$with_intro_bitmap" = "no" ; then + INTRO_BITMAP= AC_MSG_RESULT([none]) else - for bitmap in `echo $with_intro_bitmaps | tr ',' ' '` ; do - case "$bitmap" in - *.bmp) ;; - *) bitmap= ; AC_MSG_WARN([Intro bitmaps should be .bmp files!]) ;; - esac - if test -n "$bitmap" ; then - INTRO_BITMAPS="$INTRO_BITMAPS $bitmap" - fi - done - AC_MSG_RESULT([$INTRO_BITMAPS]) + case "$with_intro_bitmap" in + *.png) INTRO_BITMAP="$with_intro_bitmap" ;; + *) AC_MSG_WARN([Intro bitmap should be a .png file!]) ;; + esac + AC_MSG_RESULT([$INTRO_BITMAP]) fi -AC_SUBST(INTRO_BITMAPS) +AC_SUBST(INTRO_BITMAP) -AC_MSG_CHECKING([for additional 'about' bitmaps]) -ABOUT_BITMAPS= -if test -z "$with_about_bitmaps" -o "$with_about_bitmaps" = "no" ; then - ABOUT_BITMAPS= +AC_MSG_CHECKING([for another 'about' bitmap]) +ABOUT_BITMAP= +if test -z "$with_about_bitmap" -o "$with_about_bitmap" = "no" ; then + ABOUT_BITMAP= AC_MSG_RESULT([none]) else - for bitmap in `echo $with_about_bitmaps | tr ',' ' '` ; do - case "$bitmap" in - *.bmp) ;; - *) bitmap= ; AC_MSG_WARN([About bitmaps should be .bmp files!]) ;; - esac - if test -n "$bitmap" ; then - ABOUT_BITMAPS="$ABOUT_BITMAPS $bitmap" - fi - done - AC_MSG_RESULT([$ABOUT_BITMAPS]) + case "$with_about_bitmap" in + *.png) ABOUT_BITMAP="$with_about_bitmap" ;; + *) AC_MSG_WARN([About bitmap should be a .png file!]) ;; + esac + AC_MSG_RESULT([$ABOUT_BITMAP]) fi -AC_SUBST(ABOUT_BITMAPS) +AC_SUBST(ABOUT_BITMAP) OOO_VENDOR= AC_MSG_CHECKING([for vendor]) diff --git a/set_soenv.in b/set_soenv.in index 6e51c4f..1c1e97b 100644 --- a/set_soenv.in +++ b/set_soenv.in @@ -1630,8 +1630,8 @@ else } # Languages ToFile( "WITH_LANG", "@WITH_LANG@", "e" ); -ToFile( "INTRO_BITMAPS", "@
[Libreoffice] [PATCH] set RPATH correctly in the internal ICU
Hi,
our build service found broken RPATH in libicudata.so.42.1; it is fixed
by the attached patch
Cedric, could you please sign it off for libreoffice-3-3.
It works well on Linux with bash. I think that it can't be worse on
other systems ;-)
Best Regards,
Petr
>From 1395e5600091d6d768690cb66181c9c3417343e1 Mon Sep 17 00:00:00 2001
From: Petr Mladek
Date: Wed, 5 Jan 2011 20:14:29 +0100
Subject: [PATCH] set RPATH correctly in the internal icu
RPATH must be set to $ORIGIN:$ORIGIN/../ure-link/lib; it was broken
in libicudata.so.42.1 because the $ORIGIN was substituted
the patch escapes '$' with '\' before using in the command 'echo'
---
patches/dev300/apply|2 +
patches/dev300/icu-4.2.1-rpath.diff | 36 +++
2 files changed, 38 insertions(+), 0 deletions(-)
create mode 100644 patches/dev300/icu-4.2.1-rpath.diff
diff --git a/patches/dev300/apply b/patches/dev300/apply
index e9232b1..4085d29 100755
--- a/patches/dev300/apply
+++ b/patches/dev300/apply
@@ -181,6 +181,8 @@ ok-cancel-btn-add-accel.diff, kohei
# Upgraded internal ICU to 4.2.1
icu-4.2.1.diff, cbosdo
+# pass $ORIGIN correctly to RPATH
+icu-4.2.1-rpath.diff. pmladek
[ TemporaryHacks ]
diff --git a/patches/dev300/icu-4.2.1-rpath.diff b/patches/dev300/icu-4.2.1-rpath.diff
new file mode 100644
index 000..02e8bec
--- /dev/null
+++ b/patches/dev300/icu-4.2.1-rpath.diff
@@ -0,0 +1,36 @@
+--- icu/icu4c-4_2_1-src-rpath.patch.old 2011-01-03 17:54:31.0 +0100
icu/icu4c-4_2_1-src-rpath.patch 2011-01-03 17:58:18.0 +0100
+@@ -0,0 +1,21 @@
++--- misc/icu/source/data/pkgdataMakefile.in 2010-12-22 23:44:02.0 +0100
+ misc/build/icu/source/data/pkgdataMakefile.in 2011-01-03 17:52:44.0 +0100
++@@ -15,6 +15,9 @@ include $(top_builddir)/icudefs.mk
++ OUTPUTFILE=icupkg.inc
++ MIDDLE_SO_TARGET=
++
+++# escape $ with \ when passing to echo; needed to preserve $ORIGIN
+++SHLIB.c.shell := $(subst $$,\$$,$(SHLIB.c))
+++
++ all : clean
++ @echo GENCCODE_ASSEMBLY_TYPE=$(GENCCODE_ASSEMBLY) >> $(OUTPUTFILE)
++ @echo SO=$(SO) >> $(OUTPUTFILE)
++@@ -24,7 +27,7 @@ all : clean
++ @echo LIB_EXT_ORDER=$(FINAL_SO_TARGET) >> $(OUTPUTFILE)
++ @echo COMPILE="$(COMPILE.c)" >> $(OUTPUTFILE)
++ @echo LIBFLAGS="-I$(top_srcdir)/common -I$(top_builddir)/common $(SHAREDLIBCPPFLAGS) $(SHAREDLIBCFLAGS)" >> $(OUTPUTFILE)
++- @echo GENLIB="$(SHLIB.c)" >> $(OUTPUTFILE)
+++ @echo GENLIB="$(SHLIB.c.shell)" >> $(OUTPUTFILE)
++ @echo LDICUDTFLAGS=$(LDFLAGSICUDT) >> $(OUTPUTFILE)
++ @echo LD_SONAME=$(LD_SONAME) >> $(OUTPUTFILE)
++ @echo RPATH_FLAGS=$(RPATH_FLAGS) >> $(OUTPUTFILE)
+--- icu/makefile.mk.old 2010-12-22 23:42:29.0 +0100
icu/makefile.mk 2011-01-03 17:55:27.0 +0100
+@@ -47,7 +47,8 @@ TARFILE_MD5=
+ TARFILE_ROOTDIR=icu
+
+ PATCH_FILES=\
+-${TARFILE_NAME}.patch
++${TARFILE_NAME}.patch \
++${TARFILE_NAME}-rpath.patch
+
+ # ADDITIONAL_FILES=
+
--
1.7.3.4
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Oracle wordbook in LibO
Kálmán „KAMI” Szalai píše v Čt 06. 01. 2011 v 15:40 +0100: > > On 01/05/2011 06:28 PM, Petr Mladek wrote: > > Kálmán „KAMI” Szalai píše v St 05. 01. 2011 v 17:39 +0100: > >> Hi! > >> > >> 2011-01-05 17:01 keltezéssel, Petr Mladek írta: > >>> Ah, we use Novell.dic in our build. It includes just > >>> language-independent names of Novell products, so it should not cause > >>> any harm to anyone. I attached different patches to the issue. KAMI, > >>> could you please review them? > >> Can we introduce here some other technical, and distibution related > >> files here, not just Novell related, words from Ubuntu, Debian, etc. I > >> think we should have only one extra dic file, or is is a performance > >> killer thing? > > Great idea! I would call it technical.dic or so. > > > > KAMI, could you please cook up something? > > > > > > Best Regards, > > Petr > > > May we include vendor specific sfuffs from oracle.dic? > http://cgit.freedesktop.org/libreoffice/extras/commit/?h=libreoffice-3-3&id=7fbdfd0a0d2af30af92839ebf8bcf97c465519e8 Looks good to me. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Updates for Lightproof
Kálmán „KAMI” Szalai píše v St 05. 01. 2011 v 20:52 +0100: > Hi Michael, > > Sorry for bugging you but it seems I sent it two times, and David > already pushed in: > Re: [Libreoffice] [PATCH] [PUSHED] Updates for LightProof extension > handling > > It is required If someone packs LightProof because of changed > extension installation in 3.3. Does it mean that LightProof is broken in libreoffice-3-3 branch? If it is true, I would commit it even to the branch. It looks safe enough. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] Fix configure check for BerkleyDB where db_create is macro
Hi, this fixed the problem described in the attached mail. Gökçen, Robert, could you please test it and sign it out for libreoffice-3-3 branch? It works here and it should be more safe than the current solution. Analyze: "db_create" function is defined by macro in some db version. I did a lot of googling and have not found any ultimate solution. Some people try to check all "db_create" variants, e.g. db_create_4002, db_create_4001, see http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/mail-filter/maildrop/files/maildrop-2.5.1-db.patch?view=diff&r1=text&tr1=1.1&r2=text&tr2=1.1&diff_format=s The problem is that there exists too many variants. Gökçen would need db_create_4008, ... I have found only one other variant for "dbopen" that is __db185_open. This symbol has been introduced in db-3.x and seems to be provided by any newer version for compatibility reasons. See also http://lists.debian.org/debian-devel/2001/04/msg01770.html Solution: - LibO requires db >= 4.4. All these version should provide the symbol "__db185_open" for compatibility reasons. Of course, it is better to check for the original symbol "dbopen", so I used "__db185_open" just as fallback. I am not 100% sure that it would work on all archaic systems but it should be better than the current state. Best Regards, Petr --- Begin Message --- Çarşamba 01 Aralık 2010 günü (saat 20:35:22) Petr Mladek şunları yazmıştı: > Hi Robert, > > Robert Nagy píše v St 01. 12. 2010 v 11:27 +0100: > > Hi, > > > > So this is a modified versio nof patches/dev300/system-db-check.diff > > to find the proper berkeley db headers and libs. > > I really would like to get this into bootstrap so please test and > > comment. > > It looks reasonable and works here. Feel free to commit it. > With this patch (in RC2) I can no longer pass configure: checking which db to use... external checking for db-5.1/db.h... no checking for db5.1/db.h... no checking for db-5.0/db.h... no checking for db5.0/db.h... no checking for db-5/db.h... no checking for db5/db.h... no checking for db-4.8/db.h... no checking for db4.8/db.h... no checking for db-4.7/db.h... no checking for db4.7/db.h... no checking for db-4/db.h... no checking for db4/db.h... no checking for db/db.h... no checking db.h usability... yes checking db.h presence... yes checking for db.h... yes checking whether db is at least 4.1... yes checking for db_create in -ldb... no checking for db_create in -ldb-5.1... no checking for db_create in -ldb5.1... no checking for db_create in -ldb-5.0... no checking for db_create in -ldb5.0... no checking for db_create in -ldb-5... no checking for db_create in -ldb5... no checking for db_create in -ldb-4.8... no checking for db_create in -ldb4.8... no checking for db_create in -ldb-4.7... no checking for db_create in -ldb4.7... no checking for db_create in -ldb-4... no checking for db_create in -ldb4... no checking for db_create... no configure: error: db not installed or functional I'm using db4 version 4.8.30, and db4-devel package is installed. I can compile RC1 without any errors. When I try to compile this test file that configure generates: /* confdefs.h */ #define PACKAGE_NAME "" #define PACKAGE_TARNAME "" #define PACKAGE_VERSION "" #define PACKAGE_STRING "" #define PACKAGE_BUGREPORT "" #define PACKAGE_URL ""
Re: [Libreoffice] Oracle wordbook in LibO
Andrea Pescetti píše v Pá 07. 01. 2011 v 02:29 +0100: > On 06/01/2011 Petr Mladek wrote: > > Kálmán „KAMI” Szalai píše v Čt 06. 01. 2011 v 15:40 +0100: > > > May we include vendor specific sfuffs from oracle.dic? > > > http://cgit.freedesktop.org/libreoffice/extras/commit/?h=libreoffice-3-3&id=7fbdfd0a0d2af30af92839ebf8bcf97c465519e8 > > > > Looks good to me. > > I might have lost track of changes due to the multiple patches here and > in https://bugs.freedesktop.org/show_bug.cgi?id=31798, but there are a > few things that make little sense to me: > - This would remove "OpenOffice.org" and everything that used to be in > oracle.dic Great catch. I guess that KAMI have just missed it. It is a language independent product name and it is perfectly fine to have it in the technical.dic. > - ...but it adds the word "MySQL" MySQL looks fine. > - It adds the whole family tree of Ubuntu > - ...but it doesn't add "GNU/Linux" or just "GNU" and "Linux", and it > removes "Linux" instead "GNU" and "Linux" sounds reasonable > - It removes "Oracle" and it adds "Novell", but it ignores all the > companies listed in http://www.documentfoundation.org/supporters/ Oracle is fine as well. > - It removes all the application names: Writer, Calc, Impress... Hmm, I am not sure if these are language independent names. Sophie, what do you think? KAMI, could you please take care of this discussion and add the requested words to git? > Are these choices deliberate? We wanted to remove oracle.dic because it include many generic English words, e.g. Time, Tools, Use, Value, Work. http://cgit.freedesktop.org/libreoffice/extras/commit/?h=libreoffice-3-3&id=7fbdfd0a0d2af30af92839ebf8bcf97c46551 is just the first draft. Such dictionaries are always work in progress. Feel free to suggest list of more missing words. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] install oo* wrappers only with --with-compat-oowrappers configure option
Hi Rene,
you did not want the oo* compat-wrappers for Debian. The attached patch
makes it optional and they are not installed by default.
Could you please review it for the libreoffice-3-3 branch?
Best Regards,
Petr
>From 52657a48a609e9e8ebe53b1740138594f45a2d1a Mon Sep 17 00:00:00 2001
From: Petr Mladek
Date: Fri, 7 Jan 2011 18:09:44 +0100
Subject: [PATCH] install oo* wrappers only with --with-compat-oowrappers configure option
they are not installed by default
---
bin/package-ooo | 14 ++
bin/setup.in|1 +
configure.in| 17 +
3 files changed, 28 insertions(+), 4 deletions(-)
diff --git a/bin/package-ooo b/bin/package-ooo
index 89bff1d..9127848 100755
--- a/bin/package-ooo
+++ b/bin/package-ooo
@@ -82,19 +82,25 @@ mkdir -p $MANDIR/man1
# startup wrappers
for app in calc draw impress math web writer base; do
create_qstart_wrapper "$PREFIX/bin/lo${app}${BINSUFFIX}" "-${app}" || exit 1;
-create_qstart_wrapper "$PREFIX/bin/oo${app}${BINSUFFIX}" "-${app}" || exit 1;
+if test "$COMPAT_OOWRAPPERS" = "YES" ; then
+create_qstart_wrapper "$PREFIX/bin/oo${app}${BINSUFFIX}" "-${app}" || exit 1;
+fi
done
create_qstart_wrapper "$PREFIX/bin/lofromtemplate${BINSUFFIX}" ".uno:NewDoc" || exit 1;
-create_qstart_wrapper "$PREFIX/bin/oofromtemplate${BINSUFFIX}" ".uno:NewDoc" || exit 1;
create_qstart_wrapper "$PREFIX/bin/libreoffice${BINSUFFIX}" "" || exit 1;
-create_qstart_wrapper "$PREFIX/bin/ooffice${BINSUFFIX}" "" || exit 1;
create_unopkg_wrapper "$PREFIX/bin/unopkg${BINSUFFIX}" "" || exit 1;
+if test "$COMPAT_OOWRAPPERS" = "YES" ; then
+create_qstart_wrapper "$PREFIX/bin/oofromtemplate${BINSUFFIX}" ".uno:NewDoc" || exit 1;
+create_qstart_wrapper "$PREFIX/bin/ooffice${BINSUFFIX}" "" || exit 1;
+fi
if test "z$VENDORNAME" = "zNovell" -o "z$VENDORNAME" = "zPLD" \
-o "z$VENDORNAME" = "zDebian" \
-o "z$VENDORNAME" = "zMandriva"; then
for app in calc draw impress math web writer base fromtemplate ; do
echo ".so man1/libreoffice$BINSUFFIX.1" >| $MANDIR/man1/lo${app}$BINSUFFIX.1;
-echo ".so man1/libreoffice$BINSUFFIX.1" >| $MANDIR/man1/oo${app}$BINSUFFIX.1;
+if test "$COMPAT_OOWRAPPERS" = "YES" ; then
+echo ".so man1/libreoffice$BINSUFFIX.1" >| $MANDIR/man1/oo${app}$BINSUFFIX.1;
+fi
done
fi
diff --git a/bin/setup.in b/bin/setup.in
index 99c2a77..f2508a3 100755
--- a/bin/setup.in
+++ b/bin/setup.in
@@ -51,6 +51,7 @@ NLPSOLVER_EXTENSION='@NLPSOLVER_EXTENSION@'
LANGUAGETOOL_EXTENSION='@LANGUAGETOOL_EXTENSION@'
OOOBLOGGER_EXTENSION='@OOOBLOGGER_EXTENSION@'
SUNTEMPLATES_LANG='@SUNTEMPLATES_LANG@'
+COMPAT_OOWRAPPERS='@COMPAT_OOWRAPPERS@'
OOO_BUILDVERSION='@OOO_BUILDVERSION@'
OOO_SOURCEVERSION='@OOO_SOURCEVERSION@'
OOO_STRIP='@OOO_STRIP@'
diff --git a/configure.in b/configure.in
index f1a6a8f..e7cc537 100755
--- a/configure.in
+++ b/configure.in
@@ -419,6 +419,13 @@ AC_ARG_WITH(openclipart,
--with-openclipart=/usr/share/openclipart],
,)
+AC_ARG_WITH(compat_oowrappers,
+[
+ --with-compat-oowrappers
+ Install oo* wrappers in parallel with
+ lo* ones to keep backward compatibility.],
+,)
+
AC_ARG_WITH(piece,
[
--with-pieceBuild only a piece of LibreOffice.
@@ -1120,6 +1127,16 @@ fi
AC_MSG_RESULT([${LIBERATION_FONTS_VER:-as upstream}])
AC_SUBST(LIBERATION_FONTS_VER)
+AC_MSG_CHECKING([whether to install compat oo* wrappers])
+if test "$with_compat_oowrappers" = "yes" ; then
+COMPAT_OOWRAPPERS=YES
+AC_MSG_RESULT(yes)
+else
+COMPAT_OOWRAPPERS=NO
+AC_MSG_RESULT(no)
+fi
+AC_SUBST(COMPAT_OOWRAPPERS)
+
AC_MSG_CHECKING([for GNU patch])
GNUPATCH=patch
if test "z$with_gnu_patch" != "z"; then
--
1.7.3.4
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] Really use BrOffice in the linux desktop files
Hi Michael,
could you please sign off the attached patch?
It is needed to create the linux desktop files with
"Name[pt_BR]=BrOffice 3.3".
I am sorry, I havn't managed to verify your original fix before 3.3-rc2
release. I have lated found that it did not work because of:
+ * dekstop files need "pt_BR" instead of "pt-BR" (undescore vs.
dash)
* "%PRODUCTNAME_BR" was wrongly substituted to
"${PRODUCTNAME} ${PRODUCTVERSION}_BR"; it should be
"${PRODUCTNAME_BR} ${PRODUCTVERSION}"
It works fine with the attached patch.
Best Regards,
Petr
>From 2977c5dda829890fd73462848469de9da56c1759 Mon Sep 17 00:00:00 2001
From: Petr Mladek
Date: Sat, 8 Jan 2011 20:12:41 +0100
Subject: [PATCH] Really set BrOffice in the linux desktop files
* dekstop files need "pt_BR" instead of "pt-BR" (undescore vs. dash)
* "%PRODUCTNAME_BR" was wrongly substitured to
"${PRODUCTNAME} ${PRODUCTVERSION}_BR"; it should be
"${PRODUCTNAME_BR} ${PRODUCTVERSION}"
---
sysui/desktop/menus/base.desktop |2 +-
sysui/desktop/menus/calc.desktop |2 +-
sysui/desktop/menus/draw.desktop |2 +-
sysui/desktop/menus/impress.desktop |2 +-
sysui/desktop/menus/javafilter.desktop |2 +-
sysui/desktop/menus/math.desktop |2 +-
sysui/desktop/menus/printeradmin.desktop |2 +-
sysui/desktop/menus/qstart.desktop |2 +-
sysui/desktop/menus/startcenter.desktop |2 +-
sysui/desktop/menus/writer.desktop |2 +-
sysui/desktop/share/brand.pl |8
sysui/desktop/share/makefile.mk |8
sysui/desktop/share/translate.pl |6 ++
13 files changed, 28 insertions(+), 14 deletions(-)
diff --git a/sysui/desktop/menus/base.desktop b/sysui/desktop/menus/base.desktop
index a195c89..3cb84f8 100644
--- a/sysui/desktop/menus/base.desktop
+++ b/sysui/desktop/menus/base.desktop
@@ -7,7 +7,7 @@ Categories=Office;X-Red-Hat-Base;X-SuSE-Core-Office;X-MandrivaLinux-MoreApplicat
Exec=${UNIXBASISROOTNAME} -base %U
MimeType=application/vnd.oasis.opendocument.database;application/vnd.sun.xml.base;
Name=%PRODUCTNAME Base
-Name[pt-BR]=%PRODUCTNAME_BR Base
+Name[pt_BR]=%PRODUCTNAME_BR Base
GenericName=Database Development
Comment=Manage databases, create queries and reports to track and manage your information by using Base.
InitialPreference=5
diff --git a/sysui/desktop/menus/calc.desktop b/sysui/desktop/menus/calc.desktop
index 522c179..d885589 100644
--- a/sysui/desktop/menus/calc.desktop
+++ b/sysui/desktop/menus/calc.desktop
@@ -7,7 +7,7 @@ Categories=Office;X-Red-Hat-Base;X-SuSE-Core-Office;X-MandrivaLinux-Office-Sprea
Exec=${UNIXBASISROOTNAME} -calc %U
MimeType=application/vnd.oasis.opendocument.spreadsheet;application/vnd.oasis.opendocument.spreadsheet-template;application/vnd.sun.xml.calc;application/vnd.sun.xml.calc.template;application/vnd.stardivision.calc;application/vnd.stardivision.chart;application/msexcel;application/vnd.ms-excel;application/vnd.openxmlformats-officedocument.spreadsheetml.sheet;application/vnd.ms-excel.sheet.macroenabled.12;application/vnd.openxmlformats-officedocument.spreadsheetml.template;application/vnd.ms-excel.template.macroenabled.12;application/vnd.ms-excel.sheet.binary.macroenabled.12;text/csv;application/x-dbf;
Name=%PRODUCTNAME Calc
-Name[pt-BR]=%PRODUCTNAME_BR Calc
+Name[pt_BR]=%PRODUCTNAME_BR Calc
GenericName=Spreadsheet
Comment=Perform calculation, analyze information and manage lists in spreadsheets by using Calc.
InitialPreference=5
diff --git a/sysui/desktop/menus/draw.desktop b/sysui/desktop/menus/draw.desktop
index 3ea1741..21c31b8 100644
--- a/sysui/desktop/menus/draw.desktop
+++ b/sysui/desktop/menus/draw.desktop
@@ -7,7 +7,7 @@ Categories=Office;X-Red-Hat-Base;X-SuSE-Core-Office;X-MandrivaLinux-Office-Drawi
Exec=${UNIXBASISROOTNAME} -draw %U
MimeType=application/vnd.oasis.opendocument.graphics;application/vnd.oasis.opendocument.graphics-template;application/vnd.sun.xml.draw;application/vnd.sun.xml.draw.template;application/vnd.stardivision.draw;
Name=%PRODUCTNAME Draw
-Name[pt-BR]=%PRODUCTNAME_BR Draw
+Name[pt_BR]=%PRODUCTNAME_BR Draw
GenericName=Drawing Program
Comment=Create and edit drawings, flow charts, and logos by using Draw.
InitialPreference=5
diff --git a/sysui/desktop/menus/impress.desktop b/sysui/desktop/menus/impress.desktop
index dc08e25..33a7d90 100644
--- a/sysui/desktop/menus/impress.desktop
+++ b/sysui/desktop/menus/impress.desktop
@@ -7,7 +7,7 @@ Categories=Office;X-Red-Hat-Base;X-SuSE-Core-Office;X-MandrivaLinux-Office-Prese
Exec=${UNIXBASISROOTNAME} -impress %U
MimeType=application/vnd.oasis.opendocument.presentation;application/vnd.oasis.opendocument.presentation-template;application/vnd.sun.xml.impress;application/vnd.sun.xml.impress.template;appl
Re: [Libreoffice] [PATCH] [REWORKED][PUSHED] Standard-color-palette-updates
Kálmán „KAMI” Szalai píše v So 08. 01. 2011 v 15:28 +0100: > Hi All, > > Updated patch, > > Remove LibreOffice colors from standard, and updates libreoffice.soc > with latest colors. I hope it is fine for us. looked fine => pushed Note that the palette name does not include year. Is it OK? Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] [REWORKED][PUSHED] Standard-color-palette-updates
Bernhard Dippold píše v Út 11. 01. 2011 v 00:37 +0100: > Hi Petr, Kami, all, > > Petr Mladek schrieb: > > Kálmán „KAMI” Szalai píše v So 08. 01. 2011 v 15:28 +0100: > >> Hi All, > >> > >> Updated patch, > >> > >> Remove LibreOffice colors from standard, and updates libreoffice.soc > >> with latest colors. I hope it is fine for us. > > > > looked fine => pushed > > > > Note that the palette name does not include year. Is it OK? > > I think Christoph called the palette > "LibreOffice_Initial_Branding_Colors.soc", because they will change > during the next year. > > His next palette would probably be called > "LibreOffice_Community_Branding_Colors.soc". > > My approach was only a bit different: I added the year in order to allow > further changes to the branding colors without the necessity to call the > next branding effort by a different name. Hmm, I see libreoffice.soc in the installed system. > If you think the file name is too long, we can omit "Initial" (because > the year is unique - we should not come up with more than one iteration > on the branding colors during one year). > > "Colors" is superfluous too for a color palette, so my favorite name > would be > > LibreOffice_Branding_2010.soc > > This would allow to create new Branding palettes every now and then > without the problem of visually different documents in different > versions of LibreOffice (when a color of the palette has been updated > in-between). Well, this should not be a problem. The colors are saved using RGB values and not the color name. I have just used "LibreOffice Green 3" in an .odg document, removed libreoffice.soc from the system and user configuration, opened the file again, the color stayed the same, it was just not named. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] development summary: year 2011, week 1
Hi, this time a brief summary of what happened during the 1st week in 2011 on LibreOffice repositories and the living branches. bugfixes---.txt lists all commits that reference a proper bug id from a variety of trackers, i.e. #i... referring to the OpenOffice issuezilla, fdo# to freedesktop, rhbz# to RedHat bugzilla. commit-log---.txt lists all relevant commits on the actual source repositories. Many thanks to all contributors - you make all the difference! Best Regards, Petr + common: + Resolves: fdo#32897 strip out template language tags [Caolán McNamara] + bootstrap: + add de-branded MSI installation artwork, bug#32435 [Christoph Noack] + build: + Updated sdf/pot/po - License Dialog - fdo#32563 [Andras Timar] + calc: + calc64: #i116164# performance of filters with many filtered ranges [Niklas Nebel] + Make more room for Portuguese locale. (fdo#32823) [Kohei Yoshida] + components: + Fixed layout breakage for KDE, X11 and (possibly) Mac. (fdo#32133) [Kohei Yoshida] + impress208: #i115944# fixing large ooxml files [Christian Lippka ORACLE] + Make the Reset help agent button wider for Italian text. (fdo#32133) [Kohei Yoshida] + extensions: + impress208: #164351# patching xpdf to patchlevel 3.02pl5 [Christian Lippka] + extras: + technical.dic: more words from deb#425791 [Rene Engelhard] + filters: + fdo#32600# fix specific core dump on read [Noel Power] + impress208: #164349# small TGAReader improvement [Christian Lippka ORACLE] + ooo33gsl13: #i116085# adjust PageRange handling in writer PDF export [Philipp Lohmann [pl]] + libs-core: + fdo#32840: make unopkg --suppress-license skip license in all cases [Cédric Bosdonnat] + Related: fdo#32840 update help line for unopkg --supress-license [David Tardon] + Show the license information in a separate, localizable dialog; fdo#32563. [Jan Holesovsky] + libs-extern-sys: + fixed a crash - fdo#32850 [Laszlo Nemeth] + impress208: #164350# better xpath handling [Christian Lippka ORACLE] + libs-gui: + Resolves: rhbz#666088 clean up search cache singleton in correct order [Caolán McNamara] + l10n: + Removed mentions of Oracle from translations - fdo#32126 [Andras Timar] + writer: + Resolves: fdo#32633 rearrange title dialog to get translations to fix (cherry picked from commit 049b8e51b06f64fa8b353d65589b55d60ce5b83e) [Caolán McNamara] + Resolves: fdo#32633 stretch title dialog to get translations to fix (cherry picked from commit c75a9e280e3f1282c25d7c1f572cfa4bad3f8ba8) [Caolán McNamara] + We need to move to the next record during mail merge. (fdo#32790) [Kohei Yoshida] + common: + fdo#32869: Added navigation buttons to writer [Maja Djordjevic] + Resolves: fdo#32897 strip out template language tags [Caolán McNamara] + bootstrap: + Resolves: #i113163# drop uninitialized variable warning [Caolán McNamara] + calc: + calc64: #i116164# performance of filters with many filtered ranges [Niklas Nebel] + Make more room for Portuguese locale. (fdo#32823) [Kohei Yoshida] + components: + Fixed layout breakage for KDE, X11 and (possibly) Mac. (fdo#32133) [Kohei Yoshida] + Make the Reset help agent button wider for Italian text. (fdo#32133) [Kohei Yoshida] + filters: + fdo#32600# fix specific core dump on read [Noel Power] + impress: + fix shapes rendering order n#656934 [Radek Doulik] + libs-core: + fdo#32840: make unopkg --suppress-license skip license in all cases [Cédric Bosdonnat] + Related: fdo#32840 update help line for unopkg --supress-license [David Tardon] + Related: rhbz#668057 Only need to know this if pInfo is non-null [Caolán McNamara] + libs-extern-sys: + fixed a crash - fdo#32850 [Laszlo Nemeth] + libs-gui: + Resolves: #i109702# basic editor reads past end of string when line ie just ' [Andreas Bregas] + Resolves: rhbz#666088 clean up search cache singleton in correct order [Caolán McNamara] + writer: + bnc#660816 improve formfield checkbox binary export ( and import ) [Noel Power] + Related: fdo#32463 add cppunit test for SwFileNameFieldType [Caolán McNamara] + Resolves: fdo#32633 stretch title dialog to get translations to fix [Caolán McNamara] + We need to move to the next record during mail merge. (fdo#32790) [Kohei Yoshida] + common: + Croatian (hr) translation update [Robert Sedak] + CWS-TOOLING: integrate CWS impress208 [Kurt Zenker] + CWS-TOOLING: integrate CWS ooo33gsl13 [Kurt Zenker] + Fix distro specific about intro hadling [Petr Mladek] + Merge commit 'ooo/OOO330_m19' into libreoffice-3-3 [Petr Mladek] + New release of Linux Libertine G fonts [Andras Timar] + Resolves: fdo#32897 strip out template language tags [Caolán McNamara] + bootstrap: + add de-branded MSI installation artwork, bug#32435 [Christoph Noack] + Added ast, ca-XV, and id, removed sc (postset.mk) [Andras Timar] + BrOffice brand
[Libreoffice] Created branch libreoffice-3-3-0
Hi all, we want to reduce regressions caused by LibO-3.3.0 fixes to a real minimum. For this purpose, we created the branch "libreoffice-3-3-0" from the tag "libreoffice-3.3.0.3". with the following rules: + any commit has to be reviewed by 3 persons + preferably add only translation fixes + only cherry-pick from the libreoffice-3-3 branch The 'libreoffice-3-3' branch is still active, will be used for the 3.3.1 bugfix release and has the followig rules: + any commit need review by 1 person + only safe fixes are allowed + changes are regularly merged into master The "master' branch is used for 3.4 development and has the rules: + free commit; do your best to do not break build and functionality + any development allowed Now, if you want to switch your clone to the libreoffice-3-3-0 branch, do: git pull -r bin/g pull -r git checkout -b libreoffice-3-3-3 origin/libreoffice-3-3-3 g checkout -b libreoffice-3-3-3 origin/libreoffice-3-3-3 Hopefully it will work for you :-) Most probably, you will also want to do: git config --global push.default tracking When you do git push with this, it will try to push only the branch you are on; ie. libreoffice-3-3-0 when you have switched to it. This will save you some git shouting at you. Happy hacking, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Created branch libreoffice-3-3-0
(sigh, pressed enter too early) Hi all, we want to reduce regressions caused by LibO-3.3.0 fixes to a real minimum. For this purpose, we created the branch "libreoffice-3-3-0" from the tag "libreoffice-3.3.0.3". Please, follow the following rules: + any commit has to be reviewed by 3 persons + preferably add only translation fixes + only cherry-pick from the libreoffice-3-3 branch The 'libreoffice-3-3' branch is still active, will be used for the 3.3.1 bugfix release and has the followig rules: + any commit need review by 1 person + only safe fixes are allowed + changes are regularly merged into master The "master' branch is used for 3.4 development: + free commit; do your best to do not break build and functionality + any development allowed Now, if you want to switch your clone to the libreoffice-3-3-0 branch, do: git pull -r bin/g pull -r git checkout -b libreoffice-3-3-3 origin/libreoffice-3-3-3 g checkout -b libreoffice-3-3-3 origin/libreoffice-3-3-3 Hopefully it will work for you :-) Most probably, you will also want to do: git config --global push.default tracking When you do git push with this, it will try to push only the branch you are on; ie. libreoffice-3-3-0 when you have switched to it. This will save you some git shouting at you. Happy hacking, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [libreoffice-l10n] Created branch libreoffice-3-3-0
Petr Mladek píše v St 12. 01. 2011 v 17:42 +0100: > Now, if you want to switch your clone to the libreoffice-3-3-0 branch, do: > > git pull -r > bin/g pull -r > git checkout -b libreoffice-3-3-3 origin/libreoffice-3-3-3 ^ ^ > g checkout -b libreoffice-3-3-3 origin/libreoffice-3-3-3 ^^ Of course, I wanted to write: git pull -r bin/g pull -r git checkout -b libreoffice-3-3-0 origin/libreoffice-3-3-0 bin/g checkout -b libreoffice-3-3-0 origin/libreoffice-3-3-0 Thanks Rene and KAMI for pointing it out. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Patch review
Kohei Yoshida píše v Čt 13. 01. 2011 v 11:38 -0500: > Hi there, > > The attached patches revert the recent two commits which consist of the > merging of OOo330-m19 changes. > > It fixed i#115906 and i#116164, but the fix for i#116164 unfortunately > was pretty large and invasive, plus it introduced a regression as > reported in i#116439 of OOo bug tracker. > > It is my opinion that, since these fixes don't fit *our* blocker > criteria, plus the change is too large to be in RC, reverting them will > be our best option. > > The master branch already contains these fixes, and we'll work on fixing > any remaining issues in that branch. > > Anyway, review and sign-off appreciated. Looks fine. I checked: + the patches are complete and exact revert of the problematic committs + build succeeded + runtime test confirmed that it fixed i#116439 (was able to reproduce it with the plain rc3 build) Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] Patch review
Petr Mladek píše v Čt 13. 01. 2011 v 19:01 +0100: > Looks fine. I checked: > > + the patches are complete and exact revert of the > problematic committs > + build succeeded > + runtime test confirmed that it fixed i#116439 (was able > to reproduce it with the plain rc3 build) Forgot to say that I pushed it into the libreoffice-3-3 branch. We still needed review by two more people to push it into the libreoffice-3-3-0 branch. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] unopkg crasher on SLED11-SP1 (bnc#655912)
Hi,
could you please review the attached patch for libreoffice-3-3 branch?
It looks like a compiler bug. I see it only on SLED11 with one
particular gcc version. So, the solution is a kind of workaround but
it should be fine in general. See the patch for more details.
Best Regards,
Petr
>From ae47cb905e64ecdcf33bcf26cf8805b3e410a494 Mon Sep 17 00:00:00 2001
From: Petr Mladek
Date: Thu, 13 Jan 2011 21:13:19 +0100
Subject: [PATCH] unopkg crasher on SLED11-SP1 (bnc#655912)
activateExtension call broke memory if dp_misc::getIdentifier and xNewExtension
were called inline; the problem was visible only with gcc-4.3.4 and did not
appear with older or newer gcc versions
valgrind got happy and unopkg stopped crashing after the values were passed via
the extra variables
it looks like a miscompilation; IMHO, it does not make sense to report it
because it does not happen with last gcc version
this code is not critical for the performance, so the workaround with
extra variables is fine; they might even be optimized out by the compiler
---
.../deployment/manager/dp_extensionmanager.cxx | 14 --
1 files changed, 12 insertions(+), 2 deletions(-)
diff --git a/desktop/source/deployment/manager/dp_extensionmanager.cxx b/desktop/source/deployment/manager/dp_extensionmanager.cxx
index c6529ec..56d95a6 100644
--- a/desktop/source/deployment/manager/dp_extensionmanager.cxx
+++ b/desktop/source/deployment/manager/dp_extensionmanager.cxx
@@ -740,9 +740,19 @@ Reference ExtensionManager::addExtension(
if (repository.equals(OUSTR("user")))
bUserDisabled2 = false;
+// FIXME: activateExtension call broke memory if dp_misc::getIdentifier and xNewExtension
+// were called inline; the problem was visible only with gcc-4.3.4 and did not appear
+// with older or newer gcc versions; valgrind got happy and unopkg stopped crashing
+// after the values were passed via the extra variables
+// it looks like a miscompilation; it does not make sense to report it
+// because it does not happen with last gcc version; this code is not critical
+// for the performance, so this workaround is fine
+OUString sNewExtensionIdentifier = dp_misc::getIdentifier(xNewExtension);
+OUString sNewExtensionFileName = xNewExtension->getName();
+
activateExtension(
-dp_misc::getIdentifier(xNewExtension),
-xNewExtension->getName(), bUserDisabled2, false, xAbortChannel,
+sNewExtensionIdentifier, sNewExtensionFileName,
+bUserDisabled2, false, xAbortChannel,
Reference());
}
else
--
1.7.3.4
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW] needed for localize-ooo fix
Thorsten Behrens píše v Pá 14. 01. 2011 v 14:17 +0100: > Hi, > > the extra localizations from LibO are not applied properly at least > on Mac (not yet clear whether the .deb issue has the same root cause > - https://bugs.freedesktop.org//show_bug.cgi?id=33105). > > Reason is a non-working localize-ooo, the first patch ensures bash > is used (and portably found). I need triple approval for this, needs > to go into 3-3-0 > > The second patch avoids a somewhat fragile cut call - that one is > not strictly necessary for 3-3-0, but I'd love to have it in 3-3 Both changes look fine. Of course, we need to use Norbert's variant of the second patch. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH][PUSHED] unopkg crasher on SLED11-SP1 (bnc#655912)
Michael Meeks píše v Pá 14. 01. 2011 v 09:23 +: > Hi Petr, > > On Thu, 2011-01-13 at 21:25 +0100, Petr Mladek wrote: > > could you please review the attached patch for libreoffice-3-3 branch? > > Looks good to me; the method takes OUStrings, so there is no odd type > co-ercion (that I can see) going on. thanks for review; I have got approval also from Noel and Tor, so pushed even to the libreoffice-3-3-0 branch. > > It looks like a compiler bug. I see it only on SLED11 with one > > particular gcc version. So, the solution is a kind of workaround but > > it should be fine in general. See the patch for more details. > > Personally, I don't believe we need such a huge block comment on this > (in master at least): > > // add temporaries to workaround gcc-4.3.4 specific bug Fair enough ;-) I have simplified the comment to // pass the two values via variables to workaround gcc-4.3.4 specific bug (bnc#655912) > would be fine for me - and (after long experience) I trust your > analysis of tangled compiler breakage :-) you have run the 'working' ie. > non gcc-4.3.4 version through valgrind to ensure that the bug isn't > there but hidden for some other reason ? Yup, valgrind havn't seen any problems on openSUSE-11.3. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW] Fixes for i116318 and i116371
Thorsten Behrens píše v Po 17. 01. 2011 v 15:45 +0100: > Hi, > > would you please review attached patches for 3-3-0 - they're > extracted from OOo's calc65 CWS, which'll go into RC10. > > Both are tested & work fine for me - they're safe in a sense that > they'll definitely not make matters worse. ;) Both look fine and work. You might have my vote to include it in 3-3-0 Just a small thing. 0001-Fix-backgrounds-for-polypolygons-in-metafile.patch adds tabs instead of spaces. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Review request: Typo in binfilter/bf_so3/source/ole/socli.cxx
Jan Holesovsky píše v Út 18. 01. 2011 v 10:37 +0100: > Hi Fridrich, > > On 2011-01-18 at 10:22 +0100, Thorsten Behrens wrote: > > > > -::SolarMuexGuard aGuard; > > > +::SolarMutexGuard aGuard; > > > > > Of course, fine by me. > > You have my OK too. Sure, go for it. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] development summary: year 2011, week 2
Hi, this time a brief summary of what happened during the 2nd week in 2011 on LibreOffice repositories and the living branches: + master:hot LO-3.4 development + libreoffice-3-3: fixes for next LO-3.3.x bug fix release + libreoffice-3-3-0: final stabilization for LO-3.3.0 release There are two logs for each branch: + bugfixes---.txt lists all commits that reference a proper bug id from a variety of trackers, i.e. #i... referring to the OpenOffice issuezilla, fdo# to freedesktop, rhbz# to RedHat bugzilla + commit-log---.txt lists all relevant commits on the actual source repositories Many thanks to all contributors - you make all the difference! Best Regards, Petr + common: + Remove pesky on-line registration menu entry. (fdo#33112) [Kohei Yoshida] + Resolves: fdo#32897 strip out template language tags [Caolán McNamara] + base: + fix for fdo#32742# [Noel Power] + Remove the Registration... menu item which we don't want. (fdo#33112) [Kohei Yoshida] + bootstrap: + add de-branded MSI installation artwork, bug#32435 [Christoph Noack] + extras: + technical.dic: more words from deb#425791 [Rene Engelhard] + filters: + fdo#32600# fix specific core dump on read [Noel Power] + libs-core: + fix FMR crasher bug#33099, approved by Fridrich, David & Petr. [Michael Meeks] + Sun Microsystems -> The Document Foundation in desktop file fdo#31191 [Andras Timar] + unopkg crasher on SLED11-SP1 (bnc#655912) [Petr Mladek] + writer: + n#657135: Enhanced fields fixes (key inputs, and 0-length fields import) [Cédric Bosdonnat] + Resolves: fdo#32633 use standard Edit button width of 50 (cherry picked from commit a3c9ea96b2deee09060fae80d673e262b27872bb) [Caolán McNamara] + We need to move to the next record during mail merge. (fdo#32790) [Kohei Yoshida] + common: + Remove pesky on-line registration menu entry. (fdo#33112) [Kohei Yoshida] + Resolves: fdo#32897 strip out template language tags [Caolán McNamara] + base: + fix for fdo#32742# [Noel Power] + i#116187: report left/right page margin setting ignored on Unix 64 bit (cherry picked from commit 51a9333217687ff16df40ea3bd8983faaf5e425a) [Lionel Elie Mamane] + Remove the Registration... menu item which we don't want. (fdo#33112) [Kohei Yoshida] + bootstrap: + add de-branded MSI installation artwork, bug#32435 [Christoph Noack] + build: + Treat MAPI_E_USER_ABORT as success (bnc#660241) [Tor Lillqvist] + extras: + technical.dic: more words from deb#425791 [Rene Engelhard] + filters: + fdo#32600# fix specific core dump on read [Noel Power] + libs-core: + fix FMR crasher bug#33099 [Michael Meeks] + Resolves: fdo#32953 add preferred Malayalam fonts (cherry picked from commit 2f70074be979ca4a58e653a561a45d8d75b52f19) [Caolán McNamara] + Sun Microsystems -> The Document Foundation in desktop file fdo#31191 [Andras Timar] + unopkg crasher on SLED11-SP1 (bnc#655912) [Petr Mladek] + writer: + n#657135: Enhanced fields fixes (key inputs, and 0-length fields import) [Cédric Bosdonnat] + Resolves: fdo#32633 use standard Edit button width of 50 (cherry picked from commit a3c9ea96b2deee09060fae80d673e262b27872bb) [Caolán McNamara] + We need to move to the next record during mail merge. (fdo#32790) [Kohei Yoshida] + base: + fix for fdo#32742# [Noel Power] + i#116187: report left/right page margin setting ignored on Unix 64 bit [Lionel Elie Mamane] + calc: + Get SUMIF to work with external references. (fdo#33002) [Kohei Yoshida] + filters: + fdo#32600# fix specific core dump on read [Noel Power] + fix bullet characters encoding for symbol fonts, n#656934 [Radek Doulik] + fix crash, happened when loading document from n#657892 [Radek Doulik] + fix placeholder styles, n#656934 [Radek Doulik] + rhbz#659394 avoid mangling internal state in case of UNO exception [David Tardon] + impress: + rhbz#668654 avoid division by 0 [David Tardon] + libs-core: + fix FMR crasher bug#33099 [Michael Meeks] + Related: rhbz#668057 Only need to know this if pInfo is non-null [Caolán McNamara] + Resolves: fdo#32953 add preferred Malayalam fonts [Caolán McNamara] + Resolves: rhbz#668057 lock sftp urls too [Caolán McNamara] + Sun Microsystems -> The Document Foundation in desktop file fdo#31191 [Andras Timar] + Treat MAPI_E_USER_ABORT as success (bnc#660241) [Tor Lillqvist] + libs-gui: + Default currency for Estonia should be Euro - fdo#33160 [Andras Timar] + Related: rhbz#668057 recognize sftp urls [Caolán McNamara] + Related: rhbz#668057 Some Support locking files on more than just file [Caolán McNamara] + Related: rhbz#668057 use %% escaped # instead of literal # [Caolán McNamara] + writer: + bnc#660816 improve formfield checkbox binary export ( and import ) [Noel Power] + n#657135
[Libreoffice] [PATH] set bash completion for oo* wrappers when enabled
Hi Rene,
could you please review the attached patch for the libreoffice-3-3
branch?
It produces extra /etc/bash_completion_d/ooffice.sh for the compat
stuff. It was the easiest and most safe solution. It generates exactly
the same .sh files that I got by the previous builds here.
It updates the Debian installation and split build. I was not able to
test the Debian part. I just did my best :-)
Best Regards,
Petr
>From bb67090d8aae3c5fad16189fc30ce72e7bfc27d2 Mon Sep 17 00:00:00 2001
From: Petr Mladek
Date: Wed, 19 Jan 2011 18:51:37 +0100
Subject: [PATCH] install bash completion for oo* wrappers when enabled (bnc#665402)
---
bin/generate-bash-completion| 14 ++
bin/package-ooo |7 +++
bin/piece/file-list-postprocess |8 ++--
3 files changed, 27 insertions(+), 2 deletions(-)
diff --git a/bin/generate-bash-completion b/bin/generate-bash-completion
index 3eb5aea..25ae4e6 100755
--- a/bin/generate-bash-completion
+++ b/bin/generate-bash-completion
@@ -61,6 +61,7 @@ sub usage()
print "Usage: $0 --help\n";
print " $0 [--binsuffix=suffix]\n";
+print "\t\t[--compat-oowrappers]\n";
print "\t\t[--office=wrapper_name]\n";
print "\t\t[--master=wrapper_name]\n";
print "\t\t[--base=wrapper_name]\n";
@@ -78,6 +79,7 @@ sub usage()
print "Options:\n";
print "\t--help\t\tprint this help\n";
print "\t--binsuffix\tdefines a suffix that is added after each wrapper\n";
+print "\t--compat-oowrappers\tset wrapper names to the old default oo* wrapper names\n";
print "The other options allows to redefine the wrapper names.\n";
print "The value \"\" can be used to disable any wrapper.\n\n";
@@ -92,6 +94,18 @@ foreach my $arg (@ARGV) {
if ( $arg =~ /--help/ ) {
usage();
exit 0;
+} elsif ( $arg =~ /--compat-oowrappers/ ) {
+$APPS{'office'} = "ooffice";
+$APPS{'master'} = "";
+$APPS{'base'} = "oobase";
+$APPS{'calc'} = "oocalc";
+$APPS{'draw'} = "oodraw";
+$APPS{'impress'} = "ooimpress";
+$APPS{'math'} = "oomath";
+$APPS{'template'} = "oofromtemplate";
+$APPS{'unopkg'} = "unopkg";
+$APPS{'web'} = "ooweb";
+$APPS{'writer'} = "oowriter";
} elsif ( $arg =~ /--binsuffix=(.*)/ ) {
$binsuffix = "$1";
} elsif ( $arg =~ /--office=(.*)/ ) {
diff --git a/bin/package-ooo b/bin/package-ooo
index 3d6b1a6..5da8c4a 100755
--- a/bin/package-ooo
+++ b/bin/package-ooo
@@ -127,6 +127,9 @@ fi
# create bash completion
mkdir -p $OODESTDIR/etc/bash_completion.d
$TOOLSDIR/bin/generate-bash-completion --binsuffix="$BINSUFFIX" $TOOLSDIR/bin/bash-completion.in $OODESTDIR/etc/bash_completion.d/libreoffice${BINSUFFIX}.sh
+if test "$COMPAT_OOWRAPPERS" = "YES" ; then
+$TOOLSDIR/bin/generate-bash-completion --compat-oowrappers --binsuffix="$BINSUFFIX" $TOOLSDIR/bin/bash-completion.in $OODESTDIR/etc/bash_completion.d/ooffice${BINSUFFIX}.sh
+fi
if test "z$VENDORNAME" != "zRedHat"; then
mkdir -p $MANDIR/man1
@@ -952,6 +955,10 @@ else
mv usr/share/man/man1/libreoffice$BINSUFFIX.1 \
pkg/libreoffice-common/usr/share/man/man1
mkdir -p pkg/libreoffice-common/etc/bash_completion.d
+ if test "$COMPAT_OOWRAPPERS" = "YES" ; then
+ mv etc/bash_completion.d/ooffice$BINSUFFIX.sh \
+ pkg/libreoffice-common/etc/bash_completion.d
+ fi
mv etc/bash_completion.d/libreoffice$BINSUFFIX.sh \
pkg/libreoffice-common/etc/bash_completion.d
mv .$OOINSTBASE/basis$VERSION/program/java-set-classpath \
diff --git a/bin/piece/file-list-postprocess b/bin/piece/file-list-postprocess
index efe0d68..5c02cd0 100755
--- a/bin/piece/file-list-postprocess
+++ b/bin/piece/file-list-postprocess
@@ -24,8 +24,12 @@ fi
# create bash completion
mkdir -p $DESTDIR/etc/bash_completion.d
-$OO_TOOLSDIR/generate-bash-completion --binsuffix="$BINSUFFIX" $OO_TOOLSDIR/bash-completion.in $DESTDIR/etc/bash_completion.d/ooffice${BINSUFFIX}.sh || exit 1;
-echo /etc/bash_completion.d/ooffice${BINSUFFIX}.sh >>files-$piece.txt
+$OO_TOOLSDIR/generate-bash-completion --binsuffix="$BINSUFFIX" $OO_TOOLSDIR/bash-completion.in $DESTDIR/etc/bash_completion.d/libreoffice${BINSUFFIX}.sh || exit 1;
+echo /etc/bash_completion.d/libreoffice${BINSUFFIX}.sh >>files-$piece.txt
+if test "$COMPAT_OOWRAPPERS" == 'YES' ; then
+
Re: [Libreoffice] [PATH] set bash completion for oo* wrappers when enabled
Rene Engelhard píše v St 19. 01. 2011 v 19:19 +0100:
> Hi,
>
> On Wed, Jan 19, 2011 at 07:15:12PM +0100, Petr Mladek wrote:
> > could you please review the attached patch for the libreoffice-3-3
> > branch?
>
> OK for bin/generate-bash-completion obviously ...
>
> > It produces extra /etc/bash_completion_d/ooffice.sh for the compat
> > stuff. It was the easiest and most safe solution. It generates exactly
> > the same .sh files that I got by the previous builds here.
>
> ... but what happens if one has ooffice.sh and libreoffice.sh there? Isn't
> one of them totally redundant? Would it cause problems?
Great catch! It seems that my testing was not sufficient.
Please, find attached 2nd version of the fix. What do you think about
it? ;-)
It uses different name for the generated bash function. It works here
for the oo* and lo* wrappers at the same time now.
Best Regards,
Petr
>From b41209fd91bc8f71e99b34e2c7fec0530aa764d0 Mon Sep 17 00:00:00 2001
From: Petr Mladek
Date: Wed, 19 Jan 2011 18:51:37 +0100
Subject: [PATCH] install bash completion for oo* wrappers when enabled (bnc#665402)
---
bin/bash-completion.in |8
bin/generate-bash-completion| 19 +++
bin/package-ooo |7 +++
bin/piece/file-list-postprocess |8 ++--
4 files changed, 36 insertions(+), 6 deletions(-)
diff --git a/bin/bash-completion.in b/bin/bash-completion.in
index 30f4c9c..77087c5 100644
--- a/bin/bash-completion.in
+++ b/bin/bash-completion.in
@@ -1,4 +1,4 @@
-# Programmable bash_completion file for the main OpenOffice.org applications
+# Programmable bash_completion file for the main office applications
# It is based on /etc/profile.d/complete.bash from SUSE Linux 10.1
_def=; _dir=; _file=; _nosp=
@@ -16,8 +16,8 @@ if complete -o nospace _nullcommand &> /dev/null ; then
fi
complete -r _nullcommand &> /dev/null
-# General OOo expanding shell function
-_ooexp_ ()
+# General expanding shell function
+@OFFICE_SHELL_FUNCTION@ ()
{
# bash `complete' is broken because you can not combine
# -d, -f, and -X pattern without missing directories.
@@ -84,7 +84,7 @@ _ooexp_ ()
}
-complete -d -X '.[^./]*' -F _ooexp_ ${_file} \
+complete -d -X '.[^./]*' -F @OFFICE_SHELL_FUNCTION@ ${_file} \
@BASH_COMPLETION_OOO_APPS@
unset _def _dir _file _nosp _minusdd _minusdf
diff --git a/bin/generate-bash-completion b/bin/generate-bash-completion
index 3eb5aea..dafe413 100755
--- a/bin/generate-bash-completion
+++ b/bin/generate-bash-completion
@@ -55,12 +55,15 @@ my %APPS = (
writer => "lowriter",
);
+my $office_shell_function = "_loexp_";
+
sub usage()
{
print "Script to Generate bash completion for LO wrappers\n\n";
print "Usage: $0 --help\n";
print " $0 [--binsuffix=suffix]\n";
+print "\t\t[--compat-oowrappers]\n";
print "\t\t[--office=wrapper_name]\n";
print "\t\t[--master=wrapper_name]\n";
print "\t\t[--base=wrapper_name]\n";
@@ -78,6 +81,7 @@ sub usage()
print "Options:\n";
print "\t--help\t\tprint this help\n";
print "\t--binsuffix\tdefines a suffix that is added after each wrapper\n";
+print "\t--compat-oowrappers\tset wrapper names to the old default oo* wrapper names\n";
print "The other options allows to redefine the wrapper names.\n";
print "The value \"\" can be used to disable any wrapper.\n\n";
@@ -92,6 +96,19 @@ foreach my $arg (@ARGV) {
if ( $arg =~ /--help/ ) {
usage();
exit 0;
+} elsif ( $arg =~ /--compat-oowrappers/ ) {
+$APPS{'office'} = "ooffice";
+$APPS{'master'} = "";
+$APPS{'base'} = "oobase";
+$APPS{'calc'} = "oocalc";
+$APPS{'draw'} = "oodraw";
+$APPS{'impress'} = "ooimpress";
+$APPS{'math'} = "oomath";
+$APPS{'template'} = "oofromtemplate";
+$APPS{'unopkg'} = "unopkg";
+$APPS{'web'} = "ooweb";
+$APPS{'writer'} = "oowriter";
+$office_shell_function = "_ooexp_";
} elsif ( $arg =~ /--binsuffix=(.*)/ ) {
$binsuffix = "$1";
} elsif ( $arg =~ /--office=(.*)/ ) {
@@ -202,6 +219,8 @@ open (BCOUTFILE, "> $outfilename") || die "Error: can't open $outfilename for wr
while (my $line = ) {
chomp $line;
+$line =~ s/\@OFFICE_SHELL_FUNCTION\@/$office_shell_function/;
+
if ($line =~ m/\@
Re: [Libreoffice] [PATH][PUSHED] set bash completion for oo* wrappers when enabled
Rene Engelhard píše v St 19. 01. 2011 v 23:07 +0100: > On Wed, Jan 19, 2011 at 08:31:02PM +0100, Petr Mladek wrote: > > Please, find attached 2nd version of the fix. What do you think about > > it? ;-) > > > > It uses different name for the generated bash function. It works here > > for the oo* and lo* wrappers at the same time now. > > OK. Thanks for review. I have pushed it to the libreoffice-3-3 branch. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Fix configure check for BerkleyDB where db_create is macro
Hi,
first, I am sorry that I committed the older proposed fix and caused
Bernhard troubles. Unfortunately, the problem went somehow out of my
radar until I saw Bernhard's bug
https://bugs.freedesktop.org/show_bug.cgi?id=33230
Gökçen Eraslan píše v Po 10. 01. 2011 v 10:16 +:
> Perşembe 06 Ocak 2011 günü (saat 20:03:28) Petr Mladek şunları yazmıştı:
> > Hi,
> >
> > this fixed the problem described in the attached mail.
> >
> > Gökçen, Robert, could you please test it and sign it out for
> > libreoffice-3-3 branch?
> >
>
> No, I only have __db185_open_4008 symbol in libdb.so, here is the result:
Could you please try the attached patch?
I would like to get it into the libreoffice-3-3 branch for LO-3.3.1
release. Thus the diff is a bit conservative. The idea is:
+ keep check for "dbopen" and "__db185_open" to keep backward
compatibility with 3.3.0 release
+ add check for "db_create" that seems to work for most people
+ add check for "db_create_4008", "db_create_4007", "db_create_4004" that
should work for db.h using macros; the version numbers 4008, 4007, 4004 come
from the used directory suffixes 4.8, 4.7, 4.4; I have seen these problems
with macros only with the 4.x version
+ do not use AC_CHECK_FUNC; IMHO, it just duplicate the AC_CHECK_LIB and is not
really necessary; I did not want to duplicate the long lists of fallbacks.
It is a bit ugly but it should know in all known cases.
It works here. Also really try the fallback when needed, ...
Best Regards,
Petr
>From 38951e26266ca3d20ca8dec1abb8cc16a6932c29 Mon Sep 17 00:00:00 2001
From: Petr Mladek
Date: Fri, 21 Jan 2011 19:04:00 +0100
Subject: [PATCH] combined check for system BerkleyDB (fdo#33230)
There are BerkleyDB installations that provides neither dbopen
nor __db185_open. Let's use more complex fallback to all
known symbols.
---
configure.in | 12 ++--
1 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/configure.in b/configure.in
index db20f9d..80469cb 100644
--- a/configure.in
+++ b/configure.in
@@ -4312,8 +4312,16 @@ int main(int argc, char **argv) {
], [AC_MSG_RESULT([yes])], [AC_MSG_ERROR([no. you need at least db 4.1])])
DB_LIB=
for dbver in '' -5.1 5.1 -5.0 5.0 -5 5 -4.8 4.8 -4.7 4.7 -4 4; do
-AC_CHECK_LIB(db$dbver, dbopen, [ DB_LIB="db$dbver"; DB_CPPLIB="db_cxx$dbver"; break; ] ,
-AC_CHECK_LIB(db$dbver, __db185_open, [ DB_LIB="db$dbver"; DB_CPPLIB="db_cxx$dbver"; break; ]
+AC_CHECK_LIB(db$dbver, db_create, [ DB_LIB="db$dbver"; DB_CPPLIB="db_cxx$dbver"; break; ] ,
+AC_CHECK_LIB(db$dbver, dbopen, [ DB_LIB="db$dbver"; DB_CPPLIB="db_cxx$dbver"; break; ] ,
+AC_CHECK_LIB(db$dbver, db_create_4008, [ DB_LIB="db$dbver"; DB_CPPLIB="db_cxx$dbver"; break; ] ,
+AC_CHECK_LIB(db$dbver, db_create_4007, [ DB_LIB="db$dbver"; DB_CPPLIB="db_cxx$dbver"; break; ] ,
+AC_CHECK_LIB(db$dbver, db_create_4004, [ DB_LIB="db$dbver"; DB_CPPLIB="db_cxx$dbver"; break; ] ,
+AC_CHECK_LIB(db$dbver, __db185_open, [ DB_LIB="db$dbver"; DB_CPPLIB="db_cxx$dbver"; break; ]
+)
+)
+)
+)
)
)
done
--
1.7.3.4
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH][PUSHED] Re: Oracle wordbook in LibO
Kálmán „KAMI” Szalai píše v So 22. 01. 2011 v 17:30 +0100: > Hi! > > I would like to introduce technical.dic in libreoffice-3-3 branch. If > it is possible also to libreoffice-3-3-0. So please review it and > sign-off if possible. I just added (fdo#31798) into the commit message and pushed. Thanks for all the work on the bug. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] development summary: year 2011, week 3
Hi, this time a brief summary of what happened during the 3nd week in 2011 on LibreOffice repositories and the living branches: + master:hot LO-3.4 development + libreoffice-3-3: fixes for next LO-3.3.x bug fix release + libreoffice-3-3-0: final stabilization for LO-3.3.0 release[*] There are two logs for each branch: + bugfixes---.txt lists all commits that reference a proper bug id from a variety of trackers, i.e. #i... referring to the OpenOffice issuezilla, fdo# to freedesktop, rhbz# to RedHat bugzilla + commit-log---.txt lists all relevant commits on the actual source repositories [*] libreoffice-3-3-0 branch is not longer living because 3.3.0rc4 has been marked as final the next 3.3.1 release will be based on libreoffice-3-3 branch Many thanks to all contributors - you make all the difference! Let's celebrate our first baby, the 3.3.0 release - it would not happen without you! Best Regards, Petr + base: + i#116187: report left/right page margin setting ignored on Unix 64 bit [Lionel Elie Mamane] + libs-core: + calc65: #i116371# fix backgrounds for polypolygons in metafile [Philipp Lohmann [pl]] + Sun Microsystems -> The Document Foundation in desktop file fdo#31191 [Andras Timar] + libs-gui: + calc65: #i116318# Fixed the painting of axial gradients. [Andre Fischer] + do not mix unrelated X11 Visuals (fdo#33108) [Luboš Luňák] + build: + install bash completion for oo* wrappers when enabled (bnc#665402) [Petr Mladek] + calc: + Fixed incorrect page number in page preview mode. (fdo#33155) [Kohei Yoshida] + filters: + fdo#33237# fix ole object import for writer (docx) [Noel Power] + fdo#33237 remove debug line [Noel Power] + libs-core: + calc65: #i116371# fix backgrounds for polypolygons in metafile [Philipp Lohmann [pl]] + Sun Microsystems -> The Document Foundation in desktop file fdo#31191 [Andras Timar] + libs-gui: + calc65: #i116318# Fixed the painting of axial gradients. [Andre Fischer] + cleanup into one patch: do not mix unrelated X11 Visuals (fdo#33108) [Luboš Luňák] + Default currency for Estonia should be Euro - fdo#33160 [Andras Timar] + paint toolbar handle positioned properly (fdo#32558) [Luboš Luňák] + writer: + bnc#660816 improve formfield checkbox binary export ( and import ) [Noel Power] + common: + fix KDE3 library search order (fdo#32797) [Luboš Luňák] + bootstrap: + removed ms, ps, and ur from postset.mk - fdo#33103 [Andras Timar] + calc: + Better cell anchoring. (fdo#33205) [Caolán McNamara] + Fixed incorrect page number in page preview mode. (fdo#33155) [Kohei Yoshida] + filters: + fdo#33237# fix ole object import for writer (docx) [Noel Power] + fdo#33237 remove debug line [Noel Power] + fix default bullet size, n#656934 [Radek Doulik] + set characters encoding for symbol fonts, n#656934 [Radek Doulik] + libs-core: + fix COMMON_OUTDIR/COMMON_OUTPUT typo (fdo#33096) [Luboš Luňák] + Improve the 'Update all links?' message, fdo#32548. [Jan Holesovsky] + readme formatting - fdo#32741 [Andras Timar] + Related: rhbz#668057 use default server-side permissions for copied files [Caolán McNamara] + Sun Microsystems -> The Document Foundation in desktop file fdo#31191 [Andras Timar] + libs-gui: + do not mix unrelated X11 Visuals (fdo#33108) [Luboš Luňák] + paint toolbar handle positioned properly (fdo#32558) [Luboš Luňák] + build bits: + build with libpng 1.5.0 (fdo#33231) [Luboš Luňák] + Related: rhbz#670895 don't halt build if zenity crashes [Caolán McNamara] + common: + Version 3.3.0.4, tag libreoffice-3.3.0.4 (3.3-rc4) [Petr Mladek] + base: + i#116187: report left/right page margin setting ignored on Unix 64 bit [Lionel Elie Mamane] + bootstrap: + Added ca_XV and ast name and description [Andras Timar] + removed language code 'kid' [Andras Timar] + build: + ast and ca_XV name/desc has been added to pot [Andras Timar] + (DebianBaseOnly) openoffice.org-java-common -> libreoffice-java-common [Rene Engelhard] + fix a typo in distro defaults [Fridrich Štrba] + make reportdesign-mention-package-l10n.diff apply again [Rene Engelhard] + Putting relevant configure options into distro config files [Fridrich Štrba] + remove Koshin, because 'kid' is not Koshin in LibreOffice [Andras Timar] + Slovenian (sl) translation update [Martin Srebotnjak] + update Debian-only parts of package-ooo for new lo*/libreoffice* [Rene Engelhard] + Updated translations [Andras Timar] + filters: + Fix a typo SolarMuexGuard -> SolarMutexGuard [Fridrich Štrba] + libs-core: + calc65: #i116371# fix backgrounds for polypolygons in metafile [Philipp Lohmann [pl]] + Sun Microsystems -> The Document Foundation in desktop file fdo#31191 [Andras Timar] + l
Re: [Libreoffice] [PATCH] Accept using a bin/java that is a symlink
Thorsten Behrens píše v St 26. 01. 2011 v 16:20 +0100: > Lionel Elie Mamane wrote: > > I use Debian. A self-compiled libreoffice refuses to use my GNU Java > > (gij), saying the directory does not contain a JRE. The Debian package > > of libreoffice actually autodetects it and happily uses it, but I have > > not easily identified the Debian patch that is responsible for this. > > > Good question - maybe one of the jvmfwk*.diff ones in > > http://cgit.freedesktop.org/libreoffice/build/tree/patches/dev300 > > adds the specific path? Rene/Petr, something that we'd better merge? I would suggest to remove support for gcj at all. We have got many gcj-specific bugs that were pretty hard to fix in the past. I strongly suggest to use OpenJDK if you want a free JRE. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] development summary: year 2011, week 4
Hi, this time a brief summary of what happened during the 4th week in 2011 on LibreOffice repositories and the living branches: + master:hot LO-3.4 development + libreoffice-3-3: fixes for next LO-3.3.x bug fix release[*] There are two logs for each branch: + bugfixes---.txt lists all commits that reference a proper bug id from a variety of trackers, i.e. #i... referring to the OpenOffice issuezilla, fdo# to freedesktop, rhbz# to RedHat bugzilla + commit-log---.txt lists all relevant commits on the actual source repositories [*] the logs for the libreoffice-3-3-0 branch are not attached because they are empty; I am sure that there will be more life this week as the LO-3.3.1 release is getting close Many thanks to all contributors - you make all the difference! Best Regards, Petr + bootstrap + wrong line break with ( (fdo#31271) [Caolán McNamara] + writer + crash in changing header/footer object position (rhbz#673819) [Caolán McNamara] + fdo#33477: Implemented VertOrient on Writer table cell ranges (i#116420) [os] + rTF: escape special characters in style names (partially closes ) (fdo#33478) [Miklos Vajna] + these methods don't change anything and we don't use their results (83806) [Caolán McNamara] + libs-core + related: cancel gtk file-dialog on desktop::terminate (rhbz#672872) [Caolán McNamara] + related: more woes on rpm upgrade vs rpm erase (rhbz#610103) [Caolán McNamara] + help + oOo -> LibO on Getting Support Page (fdo#33249) [Andras Timar] + ure + manipulate also the C runtime's environment (fdo#33355) [Tor Lillqvist] + libs-extern + don't segfault when test is built with debug. STL (rhbz#641350) [David Tardon] + libs-extern-sys + added Occitan spelling dictionary (fdo#33574) [Andras Timar] + added Russian spelling dictionary#i113873# (fdo#33571) [Andras Timar] + added Ukrainian dictionaries#i113874# (fdo#33595) [Andras Timar] + wrong line break with ( (fdo#31271) [Caolán McNamara] + libs-gui + archaic 'Berling Antiqua' claims to also be 'Times New Roman' (fdo#33349) [Caolán McNamara] + fix for # crash when moving through database types (fdo#32561) [Caolán McNamara] + fix scrollbars in themes that have no up/down buttons (fdo#33523) [Caolán McNamara] + fix various gtk+ theme integration annoyances, (fdo#32186) [Lucas Baudin] + related: create a unit test for the line break iterator (fdo#31271) [Caolán McNamara] + related: document one-liner to disable it for testing (fdo#31016) [Caolán McNamara] + try some bandaids to improve Arabic rendering (fdo#31016) [Khaled Hosny] + wrong line break with ( (fdo#31271) [Caolán McNamara] + year of era in long format for zh_TW by default (fdo#33459) [Cédric Bosdonnat] + testing + "Default Formatting" -> "Clear Direct Formatting" [Octavio Alvarez] + add .gitattributes for proper handling of .doc and .sdw files. [Thomas Arnhold] + add new files [Caolán McNamara] + bypass this directory unless SOLAR_JAVA [Tor Lillqvist] + get smoketest working after save as old bin format removed [Caolán McNamara] + include the wntmscx build directories [Tor Lillqvist] + artwork + include the wntmscx build directories [Tor Lillqvist] + removed obsolete starwars images [Andras Timar] + components + added Occitan dictionary [Andras Timar] + added Ukrainian dictionaries [Andras Timar] + bypass if no SOLAR_JAVA [Tor Lillqvist] + cpp cleanliness: check for assignment to self [An Leenders] + cpp cleanliness: redundant assignment to self [Kenneth Venken] + cppcheck: variable never used [Andy Holder] + crash on changing position of drawing object in header [Caolán McNamara] + fix fallout of WIN_ULONG change in pre/postsys.h [Tor Lillqvist] + fix minor ULONG glitch [Tor Lillqvist] + include the wntmscx build directories [Tor Lillqvist] + reg4allmsdoc updated to use the new registry file extension IDs [Jesús Corrius] + remove FS_PRIV_DEBUG directive. [Thomas Arnhold] + remove FUTURE. [Thomas Arnhold] + remove dangerously broken >>= operator [Caolán McNamara] + remove double line spacing and make long virtuals readable. [Thomas Arnhold] + remove some dead code. [Thomas Arnhold] + remove superfluous empty lines at end [Tor Lillqvist] + replace empty equalsAscii() with getLength(). [Thomas Arnhold] + use SetWindowLongPtr [Tor Lillqvist] + waE: gcc 4.6.0 various warnings [Caolán McNamara] + waE: various new gcc 4.6.0 warnings [Caolán McNamara] + filters + add .gitattributes for proper handling of .doc and .sdw files. [Thomas Arnhold] + ccpcheck: unused variable [Andy Holder] + class Sw3Writer in binfilter deleted [Pierre-André Jacquod] + cleanup the code a little [Joseph Powers] + code cleanup [Joseph Powers] + comment removed, fixed whitespace [Kenneth Venke
Re: [Libreoffice] development summary: year 2011, week 4
Petr Mladek píše v Po 31. 01. 2011 v 19:41 +0100: > Hi, > > this time a brief summary of what happened during the 4th week in 2011 > on LibreOffice repositories and the living branches: > > + master:hot LO-3.4 development > + libreoffice-3-3: fixes for next LO-3.3.x bug fix release[*] > > There are two logs for each branch: > > + bugfixes---.txt lists all commits that reference > a proper > bug id from a variety of trackers, i.e. #i... referring to the > OpenOffice > issuezilla, fdo# to freedesktop, rhbz# to RedHat bugzilla > > + commit-log---.txt lists all relevant commits on > the actual > source repositories > > [*] the logs for the libreoffice-3-3-0 branch are not attached because they > are empty; I am sure > that there will be more life this week as the LO-3.3.1 release is getting > close Ah, there were commits in the libreoffice-3-3-0 branch last week. Please, find them attached. I checked libreoffice-3-3-0 branch by mistake on Monday. I am sorry for the confusion. Best Regards, Petr + bootstrap + wrong line break with ( (fdo#31271) [Caolán McNamara] + extras + start using technical.dic instead of oracle.dic (fdo#31798) [Kalman Szalai - KAMI] + libs-core + fix KDE3 library search order (fdo#32797) [Luboš Luňák] + start using technical.dic instead of oracle.dic (fdo#31798) [Kalman Szalai - KAMI] + help + oOo -> LibO on Getting Support page (fdo#33249) [Andras Timar] + ure + manipulate also the C runtime's environment (fdo#33355) [Tor Lillqvist] + l10n + s/OpenOffice/OpenDocument/ in zh-TW desktop UI (fdo#33745) [Andras Timar] + libs-extern-sys + wrong line break with ( (fdo#31271) [Caolán McNamara] + libs-gui + fix KDE3 library search order (fdo#32797) [Luboš Luňák] + fix for (fdo#32561) [Caolán McNamara] + wrong line break with ( (fdo#31271) [Caolán McNamara] + components + fix window focus for langpack installation on Mac fdo# 33056 [Alexander Thurgood] + revert "Initial LibO mimetype icon design" [Thorsten Behrens] + filters + use PYTHON as passed through by set_soenv.in. [Thomas Klausner] + use double instead of float [Fridrich Štrba] + bootstrap + pass thru PYTHON, found by configure. [Thomas Klausner] + upgrade libwpd to 0.9.1 [Fridrich Štrba] + wrong line break with ( (fdo#31271) [Caolán McNamara] + extras + start using technical.dic instead of oracle.dic (fdo#31798) [Kalman Szalai - KAMI] + writer + translations need more space on word count dialog [Andras Timar] + libs-core + fix KDE3 library search order (fdo#32797) [Luboš Luňák] + start using technical.dic instead of oracle.dic (fdo#31798) [Kalman Szalai - KAMI] + help + oOo -> LibO on Getting Support page (fdo#33249) [Andras Timar] + ure + manipulate also the C runtime's environment (fdo#33355) [Tor Lillqvist] + libs-extern + upgrade libwpd to 0.9.1 [Fridrich Štrba] + l10n + s/OpenOffice/OpenDocument/ in zh-TW desktop UI (fdo#33745) [Andras Timar] + calc + remove unused declaration [Jani Monoses] + build + don't repeat oneself [Fridrich Štrba] + fix a typo [Fridrich Štrba] + make ./download work with the git over http too [Fridrich Štrba] + make CC/CXX configurable again (there's a gcc-4.0 incompat on mac) [Thorsten Behrens] + libs-extern-sys + wrong line break with ( (fdo#31271) [Caolán McNamara] + libs-gui + fix KDE3 library search order (fdo#32797) [Luboš Luňák] + fix for (fdo#32561) [Caolán McNamara] + fix wrong collation for Catalan language [Jesús Corrius] + wrong line break with ( (fdo#31271) [Caolán McNamara] ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Review needed - wikihelp always English
Jan Holesovsky píše v Po 07. 02. 2011 v 20:17 +0100: > Hi Petr, > > Jan Holesovsky píše v St 02. 02. 2011 v 09:36 +0100: > > > Can you please review the patch in the following bug, and push to > > libreoffice-3-3? > > > > https://bugs.freedesktop.org/show_bug.cgi?id=33258 > > > > It fixes a 3.3.1 blocker. > > And the attached patch fixes the problem this patch introduced - sorry > for that :-( Can you please check? > > I renamed AppendConfigToken_Impl() to AppendConfigToken(), because it is > used in more .cxx files, so it should be declared in a header, instead > of being extern. It seems that it finally unwinded all the cycles => pushed. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] REVIEW: vector regression ...
Michael Meeks píše v Po 09. 05. 2011 v 21:45 +0100: > I'd like to get this into libreoffice-3-4 - please double check for > this sort of snafu, with OOB indexes now crashing where previously they > returned null :-) > > It fixes half of the testtool startup problem. The change looks fine. It is in the libreoffice-3-4 branch now. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [ANNOUNCE] libreoffice-3.3.99.5 tag created (3.4.0-beta5)
Hi, there have been created the libreoffice-3.3.99.5 tag for 3.4.0-beta5 release. The corresponding official builds will be available by the end of the week. See the attached list of changes against 3.4.0-beta4. You might switch your current 3-4 source tree to it using: ./g fetch --tags ./g checkout -b tag-libreoffice-3.3.99.5 libreoffice-3.3.99.5 IMPORTANT: Remember that commits in the libreoffice-3.4 branch need one approval from now on. Please, ask for review on the libreoffice@lists.freedesktop.org mailing list or irc before pushing. Please, use the prefix [REVIEW] in the mail subject. See also the schedule at http://wiki.documentfoundation.org/ReleasePlan#3.4.0_release and release criteria at http://wiki.documentfoundation.org/Release_Criteria Best Regards, Petr + bootstrap + allow to install LO-3.3 and LO-3.4 in parallel on Linux (fdo#36551) [Petr Mladek] + missing bundled English dictionary extension dict-en (fdo#36926) [Andras Timar] + revert "use $realpath()" (fdo#36927) [Andras Timar] + calc + assume that the range list member may be NULL. (fdo#36849) [Kohei Yoshida] + eliminated the hang due to removal of autofill undo object. (fdo#36051) [Kohei Yoshida] + fixed a crash on datapilot while editing the source range. (fdo#36721) [Kohei Yoshida] + fixed array comparison with external references. (fdo#36933) [Kohei Yoshida] + fixed external references with COUNTIF. (fdo#33137) [Kohei Yoshida] + let's not use invalidated iterators. (fdo#36406) [Kohei Yoshida] + prevent crash during sort. (fdo#36746) [Kohei Yoshida] + remove range names with external references when breaking link. (fdo#34930) [Kohei Yoshida] + set all dynamic controls invisible upon instantiation. (fdo#36789) [Kohei Yoshida] + typing a named range in the position window should jump. (fdo#36848) [Kohei Yoshida] + filters + fix for (fdo#33462) [Marcel HB] + svx-hacky-htmlselect-control-import.diff ( ) (bnc#523191) [Noel Power] + libs-core + do not conflict with /usr/share/mime/packages/libreoffice.xml (fdo#36551) [Petr Mladek] + do not conflict with GNOME MIME icons (fdo#36551) [Petr Mladek] + fix by avoiding -L argument to pagein (fdo#36838) [Michael Meeks] + fix desktop integration for the versioned root dir (fdo#36551) [Petr Mladek] + fix for (fdo#36898) [Noel Power] + make it possible to update the region passed to BeginDrawLayers() (bnc#683550) [Luboš Luňák] + use gb_Deliver_deliver to deliver to OUTDIR (fdo#36727) [Bjoern Michaelsen] + libs-extern-sys + updated German dictionaries (fdo#36879) [Andras Timar] + libs-gui + fix crash with out of bound accelerater vector access (fdo#36802) [Michael Meeks] + translations + translations for added Find bar to Basic IDE (fdo#35706) [Andras Timar] + writer + fix - math crasher on redraw, introduced by Seek difference (fdo#36863) [Michael Meeks] + resolving : Load non blank chars from XML and check it's value. (fdo#36931) [Arnaud Versini] + revert "Right click and clic-drag on a text over background image is weird" (fdo#36496) [Cédric Bosdonnat] + revert ( unintended ) parts commit b9ff593590532eb012a0520b6dcb40f3be51f845 (fdo#34908) [Noel Power] + revert commit 5d8a59f64d9d3931e2c9c1ba98f57cd10e0b01c1, fix (fdo#36340) [Michael Meeks] + update SdrPaintView's region when it changes in writer (bnc#683550) [Luboš Luňák] + bootstrap + add copy and extract for extras and few extensions [Kalman Szalai - KAMI] + add download support to a few extension in bootstrap [Kalman Szalai - KAMI] + additional settings for OxygenOffice product [Kalman Szalai - KAMI] + allow to install LO-3.3 and LO-3.4 in parallel on Linux (fdo#36551) [Petr Mladek] + auto-accept ccache >= 3.1 on Mac [Thorsten Behrens] + bump product version to 3.4.0-beta5, release number to 5 [Petr Mladek] + clean up MacOS distro config from cruft [Thorsten Behrens] + fix ooinstall -l case [Thorsten Behrens] + missing bundled English dictionary extension dict-en (fdo#36926) [Andras Timar] + oxygenOffice progressbar [Kalman Szalai - KAMI] + refine lication of OxygenOffice splash [Kalman Szalai - KAMI] + remove already integrated fonts from extra fonts [Kalman Szalai - KAMI] + remove reference to binned config option. [Thorsten Behrens] + removed --ccache-skip configure option [Thorsten Behrens] + revert "use $realpath()" (fdo#36927) [Andras Timar] + unit test locale now forced by other means [Thorsten Behrens] + use $realpath() [Andras Timar] + use Cwd::realpath to avoid confusion with symlinked dirs [Robert Nagy] + use MKDIRHIER to avoid "File exists" errors (which are ignored, but still) [Tor Lillqvist] + use build id for the release number also for deb packages [Petr Mladek] + calc + add implementation for new uno interface XUnnamedDatabaseRange [Markus Mohrhard]
Re: [Libreoffice] Patch review [PUSHED]: remove g_mediaplayer testcase dependency for JMF.
Yifan Jiang píše v St 11. 05. 2011 v 15:57 +0800: > Hi, > > The testautomation case g_mediaplayer.inc looks never running on purpose > because of lack of JMF. So I removed this dependency and the test seems > working fine. > > Would you have a review? Thanks! Looks fine => pushed, see http://cgit.freedesktop.org/libreoffice/testing/commit/?h=libreoffice-3-4&id=831ec52edfbee9fbf97b892178a5548881143f33 Thanks for the patch. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW][PUSHED] fix for bullets saving to odp and possibly more issues
Radek Doulík píše v Čt 12. 05. 2011 v 15:20 +0200: > Hi, > > please review my patch for fdo#37017. It sets version info so that we > don't hit workarounds for versions <= 3.4.x. I would like to put on 3-4 > branch. It seems to be the right solution as discussed on irc => cherry-picked into libreoffice-3-4 branch. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] REMINDER: Release 3.4.0-rc1 from libreoffice-3-4 branch
Hi, please note that the commit deadline for 3.4.0-rc1 is today. We are going to do the libreoffice-3.4.0.1 tag and libreoffice-3-4-0 branch tomorrow. Commit rules for the new libreoffice-3-4-0 branch: + commits approved by 3 people [*] + only very safe and important fixes + no UI changes Commit rules for libreoffice-3-4 branch after May 16, 2011: + commits approved by one person [*] + only safe bug fixes + no UI changes [*] send mail to the libreoffice@lists.freedesktop.org mailing list; use [REVIEW] in mail subject; put experts into CC if known; attach patch or mention link to the commit in master or another branch Reference: http://wiki.documentfoundation.org/ReleasePlan#3.4.0_release http://wiki.documentfoundation.org/Release_Criteria Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] alternative fix for #36703
Martin Hosken píše v Po 16. 05. 2011 v 23:29 +0700: > Enclosed is a patch which doesn't involve an update to the graphite2 tarball. > This patch fixes bug #36703 for the extreme pressure LinLibertineG puts on > graphite. For more details, see the bug itself. Thanks a lot for backporting the fix for graphite2-0.9.2. I have reviewed and pushed it to the libreoffice-3-4 branch, see http://cgit.freedesktop.org/libreoffice/libs-extern-sys/commit/?h=libreoffice-3-4&id=2b46dd6afee72839d96d0646dbf52cfe3a9a7236 Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [REVIEW] missing desktop icons (fdo#37160)
Hi,
could you please review the attached patch for LO-3.4?
LO-3.4 can be installed in parallel with LO-3.3 on Linux (fdo#36551).
All the system files need to be versioned, including the menu icons.
Everything worked in beta5. Just the icon name in the desktop files was
not versioned. In fact, the icon name in the desktop file was defined
ugly way and was not in sync with the desktop integration packages.
Best Regards,
Petr
>From 275cae7a668f20f0bfbce1e091f7ccc2b52c5b4d Mon Sep 17 00:00:00 2001
From: Petr Mladek
Date: Mon, 16 May 2011 23:04:48 +0200
Subject: [PATCH] find the versioned desktop menu icons (fdo#37160)
---
sysui/desktop/share/makefile.mk |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sysui/desktop/share/makefile.mk b/sysui/desktop/share/makefile.mk
index bc1ef50..6e9ab75 100755
--- a/sysui/desktop/share/makefile.mk
+++ b/sysui/desktop/share/makefile.mk
@@ -150,7 +150,7 @@ $(LAUNCHERFLAGFILE) : $(LAUNCHERDEPN)
@@-$(MKDIRHIER) $(@:db).$(INPATH).$(@:f)
@echo Creating desktop entries for $(@:f) ..
@echo -
-@$(PERL) brand.pl -p '$${{PRODUCTNAME}} $${{PRODUCTVERSION}}' -b '$${{PRODUCTNAME_BR}} $${{PRODUCTVERSION}}' -u $(UNIXWRAPPERNAME) --iconprefix '$${{WITHOUTDOTUNIXPRODUCTNAME}}-' $< $(@:db).$(INPATH).$(@:f)
+@$(PERL) brand.pl -p '$${{PRODUCTNAME}} $${{PRODUCTVERSION}}' -b '$${{PRODUCTNAME_BR}} $${{PRODUCTVERSION}}' -u $(UNIXWRAPPERNAME) --iconprefix "$(ICONPREFIX.libreoffice)-" $< $(@:db).$(INPATH).$(@:f)
@$(PERL) translate.pl -p '$${{PRODUCTNAME}} $${{PRODUCTVERSION}}' -b '$${{PRODUCTNAME_BR}} $${{PRODUCTVERSION}}' -d $(@:db).$(INPATH).$(@:f) --ext "desktop" --key "Name" $(ULFDIR)$/launcher_name.ulf
@$(PERL) translate.pl -p '$${{PRODUCTNAME}} $${{PRODUCTVERSION}}' -b '$${{PRODUCTNAME_BR}} $${{PRODUCTVERSION}}' -d $(@:db).$(INPATH).$(@:f) --ext "desktop" --key "Comment" $(ULFDIR)$/launcher_comment.ulf
@$(PERL) translate.pl -p '$${{PRODUCTNAME}} $${{PRODUCTVERSION}}' -p '$${{PRODUCTNAME_BR}} $${{PRODUCTVERSION}}' -d $(@:db).$(INPATH).$(@:f) --ext "desktop" --key "GenericName" $(ULFDIR)$/launcher_genericname.ulf
--
1.7.4.2
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW][PUSHED] alternative fix for #36703
Michael Meeks píše v Po 16. 05. 2011 v 20:26 +0100: > On Mon, 2011-05-16 at 20:13 +0200, Petr Mladek wrote: > > Thanks a lot for backporting the fix for graphite2-0.9.2. I have > > reviewed and pushed it to the libreoffice-3-4 branch, see > > http://cgit.freedesktop.org/libreoffice/libs-extern-sys/commit/?h=libreoffice-3-4&id=2b46dd6afee72839d96d0646dbf52cfe3a9a7236 > > Looks safe to me, I think we need one more review to get it into > libreoffice-3-4-0 - right ? We actually have not the libreoffice-3-4-0 branch yet. I plan to do it later today and base it on the tag for 3.4.0-rc1. So, one review was enough for this fix. Anyway, thanks for double checking. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW] missing desktop icons (fdo#37160)
Christian Lohmaier píše v Út 17. 05. 2011 v 14:36 +0200: > Hi *, > > On Tue, May 17, 2011 at 5:27 AM, Yifan Jiang wrote: > > On Mon, May 16, 2011 at 09:17:07PM +0200, Petr Mladek wrote: > >> > >> LO-3.4 can be installed in parallel with LO-3.3 on Linux (fdo#36551). > > > > If this is a new feature, shall we release note it to spread the word? :) > > Thanks! > > > > http://wiki.documentfoundation.org/ReleaseNotes/3.4 Good point. I have updated the page. > It should be added, but not because of the "new feature", but rather > because of the limitations it has: > As both share the same user-configuration-directory, a user cannot run > them both at the same time. When one version is running already, > trying to start the other will just hand over control to the already > running one. So to use the other version you have to quit LO first. This is by purpose. People would complain about loosing the user setting otherwise. Of course, it might bring some problems but let's see. Note that the same situation was when you updated and downgraded between LO-3.3.x and LO-3.4.0-betaX. Both versions used the same user configuration. Just the turnaround was not that easy. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [ANNOUNCE] libreoffice-3.4.0.1 tag created (3.4.0-rc1)
Hi, there have been created the libreoffice-3.4.0.1 tag for 3.4.0-rc1 release. The corresponding official builds will be available by the end of the week. See the attached list of changes against 3.4.0-beta5. You might switch your current 3-4 source tree to it using: ./g fetch --tags ./g checkout -b tag-libreoffice-3.4.0.1 libreoffice-3.4.0.1 IMPORTANT: We are going to create libreoffice-3-4-0 branch for the final fine tuning of the 3.4.0 release. All commits will need 3 reviewers. The libreoffice-3-4 will be still active and used for LO-3.4.1 bugfix release. Please, read the separate announce for more details. See also the schedule at http://wiki.documentfoundation.org/ReleasePlan#3.4.0_release and release criteria at http://wiki.documentfoundation.org/Release_Criteria Best Regards, Petr + artwork + update toolbar mimetype icons (fdo#33229) [Thorsten Behrens] + bootstrap + don't ship rebaseoo.exe and rebasegui.exe, (fdo#36679) [Tor Lillqvist] + enable nlpsolver also for Mac (fdo#37180) [Thorsten Behrens] + fix ENABLE_QUICKSTART_LIBPNG handling (fdo#36497) [Michael Meeks] + components + complete revert for native334 #. (#163388) [Thorstem Behrens] + removed en-US duplicate dicts in langpacks. (fdo#36907, fdo#34910, fdo#36926) [Thorsten Behrens] + filters + avoid deleting before a use (bnc#693200) [Luboš Luňák] + do not manually free parser context (fdo#35668) [Bjoern Michaelsen] + promote the default chart8 filter as the preferred filter. (fdo#36339) [Kohei Yoshida] + libs-core + find the versioned desktop menu icons (fdo#37160) [Petr Mladek] + fix ENABLE_QUICKSTART_LIBPNG handling (fdo#36497) [Michael Meeks] + fix for (fdo#37103, fdo#36684) [Noel Power] + fix password dialog layout problem (fdo#36951) [Andras Timar] + fixed JS and BeanShell script providers classpath (fdo#36915, fdo#36916) [Noel Power] + wikihelp: Fix linking to pages, . (fdo#35671) [Jan Holesovsky] + libs-extern-sys + fix graphite2-0.9.2 particulary for LinLibertineG (fdo#36510, fdo#36752) [Martin Hosken] + libs-gui + fix crash in WMF import. (fdo#36991) [Jan Holesovsky] + fix for corrupt date formats of cells (fdo#36673) [Katarina Machalkova] + writer + assign to iterator the return value of insert(), fixes (fdo#36957) [Tor Lillqvist] + draw background before borders or borders may be hidden (fdo#36826) [Cédric Bosdonnat] + fix crash when deleting TOX (fdo#36524, i#117863) [Oliver-Rainer Wittmann] + fix crash when printing comments, . (fdo#37045) [Noel Power] + fixed remaining SwSectionFrm after deleting TOX (fdo#36524) [Cédric Bosdonnat] + fixed the ugly undo hack in SwInputWindow (fdo#37277) [Cédric Bosdonnat] + fixed update of table formulas, missing extraction of pNewVal (fdo#36667) [Cédric Bosdonnat] + revert "write also properties of a text node itself" (fdo#35805) [Cédric Bosdonnat] + sw34bf06 - correct RTF page margin export (i#117711) [Oliver-Rainer Wittmann] + sw34bf06: - refine condition for non-resizable objects (i#117189) [Oliver-Rainer Wittmann] + sw34bf06: SwFEShell::GetSectionWidth(): correct for-loop conditions (i#117863) [Oliver-Rainer Wittmann] + sw34bf06: SwUndoInserts::RedoImpl: do not use SwUndRng (i#117867) [Michael Stahl] + sw34bf06: problem exporting section breaks in tables (i#104384) [Henning Brinkmann] + sw34bf06: rtf: ignore invalid tokens following field result (i#117947) [Michael Stahl] + sw34bf06: try to reduce collateral damage from fix (i#117825, i#104949) [Michael Stahl] + use anti-aliasing in metafiles when anchored "as char" (fdo#33781) [Roland Baudin] + common + version 3.4.0.1, tag libreoffice-3.4.0.1 (3.4.0-rc1) [Petr Mladek] + artwork + update toolbar mimetype icons (fdo#33229) [Thorsten Behrens] + bootstrap + aC_SUBST also OOOBLOGGER_EXTENSION_PACK as set_soenv.in uses it [Tor Lillqvist] + add OxygenOffice related settings [Kalman Szalai - KAMI] + build nlpsolver for Win32 and Linux release builds [Fridrich Štrba] + bump product version to 3.4.0-rc1, release number to 11 [Petr Mladek] + change the version info so that we are not identified at runtime as 3.0.x [Radek Doulik] + don't ship rebaseoo.exe and rebasegui.exe, (fdo#36679) [Tor Lillqvist] + enable binfilter explicitely for windows [Fridrich Štrba] + enable extensions and bundle them in Windows build by default [Fridrich Štrba] + enable nlpsolver also for Mac (fdo#37180) [Thorsten Behrens] + fix ENABLE_QUICKSTART_LIBPNG handling (fdo#36497) [Michael Meeks] + fix Ligthproof extension integration [Kalman Szalai - KAMI] + fix Numbertext extension's download filename [Kalman Szalai - KAMI] + fix SUN Template extension configure, download, handling [Kalman Szalai - KAMI] + fix oooblogger extension download mechanism [Kalman Szalai - KAMI] + fix space and tab jam in my last commit [Kalman Szala
[Libreoffice] [ANNOUNCE] Branch libreoffice-3-4-0 created
Hi all, there have been created the libreoffice-3-4-0 branch. It will be used for fine tuning of the 3.4.0 release. It is based on the the tag libreoffice-3.4.0.1 for 3.4.0-rc1 release. The following rules apply: + any commit has to be reviewed by 3 people + preferably commit only translation fixes, or blocker fixes + only cherry-pick from the libreoffice-3-4 branch The 'libreoffice-3-4' branch is still active, will be used for the next bugfix release (3.4.1), and has the following rules: + any commit needs review by 1 person + only safe fixes are allowed + changes are regularly merged into master The 'master' branch is used for 3.5 development and has the rules: + free commit; do your best to do not break build and functionality + any development allowed For further information about the roadmap, please check http://wiki.documentfoundation.org/ReleasePlan Now, if you want to switch your clone to the libreoffice-3-4-0 branch, please do: ./g pull -r ./g checkout -b libreoffice-3-4-0 origin/libreoffice-3-4-0 Hopefully it will work for you :-) Most probably, you will also want to do (if you haven't done it yet): git config --global push.default tracking When you do git push with this, git will push only the branch you are on; ie. libreoffice-3-4-0 when you have switched to it. This will save you some git shouting at you. Happy hacking, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] development summary: year 2011, week 19
Hi, this time a brief summary of what happened during the 19th week in 2011 on LibreOffice repositories and the living branches: + master:LO-3.5 development + libreoffice-3-4: fixes for LO-3.4.0 release[*] + libreoffice-3-3: fixes for LO-3.3.3 bug fix release [*] the branch libreoffice-3-4-0 has been created on May 17, 2011; the branch libreoffice-3-4 is going to be used for LO-3.4.1 bugfix release There are two logs for each branch: + bugfixes--week--.txt lists all commits that reference a proper bug id from a variety of trackers, i.e. #i... referring to the OpenOffice issuezilla, fdo# to freedesktop, rhbz# to RedHat bugzilla + commit-log--week--.txt lists all relevant commits on the actual source repositories Many thanks to all contributors - you make all the difference! Best Regards, Petr nothing this week + bootstrap + don't ship rebaseoo.exe and rebasegui.exe, (fdo#36679) [Tor Lillqvist] + missing bundled English dictionary extension dict-en (fdo#36926) [Andras Timar] + calc + fixed array comparison with external references. (fdo#36933) [Kohei Yoshida] + filters + avoid deleting before a use (bnc#693200) [Luboš Luňák] + libs-core + fix for (fdo#37103) [Noel Power] + fixed JS and BeanShell script providers classpath (fdo#36915, fdo#36916) [Noel Power] + make it possible to update the region passed to BeginDrawLayers() (bnc#683550) [Luboš Luňák] + libs-gui + fix crash with out of bound accelerater vector access (fdo#36802) [Michael Meeks] + fix for corrupt date formats of cells (fdo#36673) [Katarina Machalkova] + translations + translations for added Find bar to Basic IDE (fdo#35706) [Andras Timar] + writer + assign to iterator the return value of insert(), fixes (fdo#36957) [Tor Lillqvist] + draw background before borders or borders may be hidden (fdo#36826) [Cédric Bosdonnat] + fix crash when deleting TOX (fdo#36524, i#117863) [Oliver-Rainer Wittmann] + fix crash when printing comments, . (fdo#37045) [Noel Power] + fixed remaining SwSectionFrm after deleting TOX (fdo#36524) [Cédric Bosdonnat] + fixed update of table formulas, missing extraction of pNewVal (fdo#36667) [Cédric Bosdonnat] + resolving : Load non blank chars from XML and check it's value. (fdo#36931) [Arnaud Versini] + revert "write also properties of a text node itself" (fdo#35805) [Cédric Bosdonnat] + revert ( unintended ) parts commit b9ff593590532eb012a0520b6dcb40f3be51f845 (fdo#34908) [Noel Power] + revert commit 5d8a59f64d9d3931e2c9c1ba98f57cd10e0b01c1, fix (fdo#36340) [Michael Meeks] + sw34bf06: - refine condition for non-resizable objects (i#117189) [Oliver-Rainer Wittmann] + sw34bf06: SwFEShell::GetSectionWidth(): correct for-loop conditions (i#117863) [Oliver-Rainer Wittmann] + sw34bf06: SwUndoInserts::RedoImpl: do not use SwUndRng (i#117867) [Michael Stahl] + sw34bf06: problem exporting section breaks in tables (i#104384) [Henning Brinkmann] + sw34bf06: rtf: ignore invalid tokens following field result (i#117947) [Michael Stahl] + sw34bf06: try to reduce collateral damage from fix (i#117825, i#104949) [Michael Stahl] + update SdrPaintView's region when it changes in writer (bnc#683550) [Luboš Luňák] + bootstrap + don't ship rebaseoo.exe and rebasegui.exe, (fdo#36679) [Tor Lillqvist] + enable extern scripting for offical LO builds (fdo#33355) [Petr Mladek] + fix building of the 64-bit Windows Explorer extension, (fdo#36950) [Tor Lillqvist] + calc + fixed array comparison with external references. (fdo#36933) [Kohei Yoshida] + filters + avoid deleting before a use (bnc#693200) [Luboš Luňák] + change 2007 XML to 2007/2010 XML in UI strings (fdo#36735) [Andras Timar] + change 97/XP/2000 to 97/XP/2000/2003 (fdo#36734) [Andras Timar] + do not manually free parser context (fdo#35668) [Bjoern Michaelsen] + set correct page number when exporting selected pages (rhbz#702635) [David Tardon] + libs-core + fix for (fdo#37103, fdo#36684) [Noel Power] + make it possible to update the region passed to BeginDrawLayers() (bnc#683550) [Luboš Luňák] + make these entries localizable (fdo#36274) [Andras Timar] + libs-gui + fix crash with out of bound accelerater vector access (fdo#36802) [Michael Meeks] + writer + fixed update of table formulas, missing extraction of pNewVal (fdo#36667) [Cédric Bosdonnat] + resolving : Load non blank chars from XML and check it's value. (fdo#36931) [Arnaud Versini] + revert "write also properties of a text node itself" (fdo#35805) [Cédric Bosdonnat] + revert ( unintended ) parts commit b9ff593590532eb012a0520b6dcb40f3be51f845 (fdo#34908) [Noel Power] + revert commit 5d8a59f64d9d3931e2c9c1ba98f57cd10e0b01c1, fix (fdo#36340) [Michael Meeks] + update SdrPaintView's region when it changes
Re: [Libreoffice] [PATCH] [PUSHED] Fix out of bounds access in ScTableConditionalFormat
Kohei Yoshida píše v St 18. 05. 2011 v 00:02 -0400: > On Tue, 2011-05-17 at 23:21 -0430, Rafael Dominguez wrote: > > Fix accessing vector out of its boundaries preventing possible crash, > > this is for 3.4 branch and master. > > Looks good. Pushed to master, and to -3-4 branch with my sign-off. +1 Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW][PUSHED-3-4] fdo#37433 German hyph dictionary failure
Andras Timar píše v Po 23. 05. 2011 v 11:50 +0200: > Hi, > > Fix for https://bugs.freedesktop.org/show_bug.cgi?id=37433 > German hyphenation is broken with the bundled German (de-DE) > dictionary, version 2011-05-05 Great. It really helped. Signed off and pushed into the libreoffice-3-4 branch, see http://cgit.freedesktop.org/libreoffice/libs-extern-sys/commit/?h=libreoffice-3-4&id=e2563845701786f733dc3b55fe7eb078999f3850 We need 2 more reviews for the libreoffice-3-4-0 branch. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] REMINDER: Release 3.4.0-rc2 from libreoffice-3-4-0 branch
Hi, please note that the commit deadline for 3.4.0-rc2 is today. We are going to do the libreoffice-3.4.0.2 tag in the libreoffice-3-4-0 branch tomorrow. If no blocker is found, rc2 will be marked as final. Commit rules for the new libreoffice-3-4-0 branch: + commits approved by 3 people [*] + only very safe and important fixes + no UI changes Commit rules for libreoffice-3-4 branch for further 3.4.x bug fix releases: + commits approved by one person [*] + only safe bug fixes + no UI changes [*] send mail to the libreoffice@lists.freedesktop.org mailing list; use [REVIEW] in mail subject; put experts into CC if known; attach patch or mention link to the commit in master or another branch Reference: http://wiki.documentfoundation.org/ReleasePlan#3.4.0_release http://wiki.documentfoundation.org/Release_Criteria Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] Updated galaxy mimetype toolbar icons
Thorsten Behrens píše v Po 23. 05. 2011 v 12:56 +0200: > > Michael Meeks wrote: > > > These files changed size from 32x32 to 26x26 in this - that is what you > > > wanted ? > > > > > Yes. > > > Pushed to 3-4 - two more reviews for -3-4-0 please. Looks good => +1 Best Regards, Petr Mladek ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW] fix for fdo#37370
Michael Meeks píše v Út 24. 05. 2011 v 11:36 +0100: > On Tue, 2011-05-24 at 10:42 +0100, Noel Power wrote: > > Please review this fix > > https://bugs.freedesktop.org/attachment.cgi?id=47096 for > > https://bugs.freedesktop.org/show_bug.cgi?id=37370.It would have been > > great to get this into rc2 ( unfortunately I wasn't quick enough ) as > > this is an extremely annoying bug and makes identifying problems with > > basic code very difficult > > Looks odd to me - this was not necessary in the past (at least > comparing with -3-3 and so on) - I suspect there is a deeper and more > interesting problem we're just band-aiding. > > Still - looks harmless, so I've committed to the -3-4 branch for you. +1 Looks fine to me. We need one more review to get it into the libreoffice-3-4-0 branch for 3.4.0-rc2. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW][PUSHED-3-4-0] fix for fdo#37370
Petr Mladek píše v Út 24. 05. 2011 v 13:30 +0200: > Michael Meeks píše v Út 24. 05. 2011 v 11:36 +0100: > > On Tue, 2011-05-24 at 10:42 +0100, Noel Power wrote: > > > Please review this fix > > > https://bugs.freedesktop.org/attachment.cgi?id=47096 for > > > https://bugs.freedesktop.org/show_bug.cgi?id=37370.It would have been > > > great to get this into rc2 ( unfortunately I wasn't quick enough ) as > > > this is an extremely annoying bug and makes identifying problems with > > > basic code very difficult > > > > Looks odd to me - this was not necessary in the past (at least > > comparing with -3-3 and so on) - I suspect there is a deeper and more > > interesting problem we're just band-aiding. > > > > Still - looks harmless, so I've committed to the -3-4 branch for you. > > +1 Looks fine to me. > > We need one more review to get it into the libreoffice-3-4-0 branch for > 3.4.0-rc2. Got one more approval from Tor on irc => pushed into libreoffice-3-4-0 branch. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED-3-4-0] Updated galaxy mimetype toolbar icons
Petr Mladek píše v Út 24. 05. 2011 v 12:46 +0200: > Thorsten Behrens píše v Po 23. 05. 2011 v 12:56 +0200: > > > Michael Meeks wrote: > > > > These files changed size from 32x32 to 26x26 in this - that is > > > > what you > > > > wanted ? > > > > > > > Yes. > > > > > Pushed to 3-4 - two more reviews for -3-4-0 please. > > Looks good => +1 Got approval also from Fridrich => pushed into libreoffice-3-4-0 branch. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW] fix for fdo#37390
Cedric Bosdonnat píše v Po 23. 05. 2011 v 21:47 +0200: > Hi all, > > On Mon, 2011-05-23 at 14:06 +0200, Cedric Bosdonnat wrote: > > Don't apply that one... I had remorse all the week-end for all the > > non-conforming documents that may loose that property. I'll hack a > > better patch to still read the old property. > > Here is an augmented patch handling the old attribute in import and > exporting the valid one. > > Could anyone review and push it to 3.4 and 3.4.0? Looks fine => pushed into libreoffice-3-4 branch, see http://cgit.freedesktop.org/libreoffice/libs-core/commit/?h=libreoffice-3-4&id=97c995a22c1602679a3e386f994a20b23d07f429 We need two more reviews for 3-4-0 branch. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW] Fix for fdo#37387
Andras Timar píše v Ne 22. 05. 2011 v 07:46 +0200: > I pushed your patch to 3-4. I looks better on the few locales I tested. > We need two more reviews for 3-4-0 for > http://cgit.freedesktop.org/libreoffice/writer/commit/?h=libreoffice-3-4&id=335cc3bb837a671b3d6644bf9b4bc13a116102da > and > http://cgit.freedesktop.org/libreoffice/writer/commit/?h=libreoffice-3-4&id=27875f65e2c1953fbf636af32556833c44849f53 +1 I have just tested both changes. They look fine to me. We need one more review for the 3-4-0 branch. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [Review] Patch for fdo#37323
Kohei Yoshida píše v Pá 20. 05. 2011 v 11:52 -0400: > On Fri, 2011-05-20 at 11:33 -0400, Kohei Yoshida wrote: > > > The patch looks good. You have my review & pushed to the -3-4 branch. > > I forgot to say it would be nice to push this to the 3-4-0 branch as > well. It needs two more sign-off's. Looks fine. Got one more approval from Michael Meek on irc => pushed into libreoffice-3-4-0 branch. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [Review][PUSHED-3-4-0] Patch for fdo#37323
Kohei Yoshida píše v Pá 20. 05. 2011 v 11:52 -0400: > On Fri, 2011-05-20 at 11:33 -0400, Kohei Yoshida wrote: > > > The patch looks good. You have my review & pushed to the -3-4 branch. > > I forgot to say it would be nice to push this to the 3-4-0 branch as > well. It needs two more sign-off's. Looks fine. Got one more approval from Michael Meek on irc => pushed into libreoffice-3-4-0 branch. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW][PUSHED-3-4-0] fdo#37001Update license text
Andras Timar píše v Ne 22. 05. 2011 v 21:24 +0200: > Hi, > > There is an updated, more accurate, more complete and better formatted > license document attached to > https://bugs.freedesktop.org/show_bug.cgi?id=37001. See details in the > bug, especially Comment 8. > > I would like to update license documents in 3-4 and 3-4-0, please approve. Got approval by me, Michael Meeks and Sophie => pushed into libreoffice-3-4 and 3-4-0 branches. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW] Fix crash when importing doc from fdo#36239
Cedric Bosdonnat píše v Čt 19. 05. 2011 v 14:51 +0200: > Hi Michael, > > On Thu, 2011-05-19 at 12:21 +0100, Michael Meeks wrote: > > Hi Cedric, > > > > On Thu, 2011-05-19 at 12:44 +0200, Cedric Bosdonnat wrote: > > > could you please review / push this patch to 3.4 and 3.4.0? It's a > > > simple fix that would save quite some crashes. > > > > Looks fine to me - of course I'd prefer: > > > > -xub_StrLen nEndPos = rEnd == rStart ? rEnd.nContent.GetIndex() : > > rEnd.nContent.GetIndex() - 1; > > +xub_StrLen nEndPos = MAX (0, rEnd.nContent.GetIndex() - 1); > > > > which looks like it might do the same thing ? ;-) > > no, it doesn't do the same... as xub_StrLen is sal_uInt32 or sal_uInt16. > If rEnd.nContent.GetIndex() is 0, then we would still have that big > value (the max of sal_uInt32 or sal_uInt16) when doing > rEnd.nContent.GetIndex() - 1 The patch looked fine => got 3 approvals => pushed into both libreoffice-3-4 and 3-4-0 branches. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW][PUSHED-3-4-0] Fix crash when importing doc from fdo#36239
Cedric Bosdonnat píše v Čt 19. 05. 2011 v 14:51 +0200: > Hi Michael, > > On Thu, 2011-05-19 at 12:21 +0100, Michael Meeks wrote: > > Hi Cedric, > > > > On Thu, 2011-05-19 at 12:44 +0200, Cedric Bosdonnat wrote: > > > could you please review / push this patch to 3.4 and 3.4.0? It's a > > > simple fix that would save quite some crashes. > > > > Looks fine to me - of course I'd prefer: > > > > -xub_StrLen nEndPos = rEnd == rStart ? rEnd.nContent.GetIndex() : > > rEnd.nContent.GetIndex() - 1; > > +xub_StrLen nEndPos = MAX (0, rEnd.nContent.GetIndex() - 1); > > > > which looks like it might do the same thing ? ;-) > > no, it doesn't do the same... as xub_StrLen is sal_uInt32 or sal_uInt16. > If rEnd.nContent.GetIndex() is 0, then we would still have that big > value (the max of sal_uInt32 or sal_uInt16) when doing > rEnd.nContent.GetIndex() - 1 The patch looked fine => got 3 approvals => pushed into both libreoffice-3-4 and 3-4-0 branches. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [ANNOUNCE] libreoffice-3.4.0.2 tag created (3.4.0-rc2)
Hi, there have been created the libreoffice-3.4.0.2 tag for 3.4.0-rc2 release. The corresponding official builds will be available by the end of the week. See the attached list of changes against 3.4.0-rc1. You might switch your current 3-4 source tree to it using: ./g fetch --tags ./g checkout -b tag-libreoffice-3.4.0.2 libreoffice-3.4.0.2 See also the schedule at http://wiki.documentfoundation.org/ReleasePlan#3.4.0_release and release criteria at http://wiki.documentfoundation.org/Release_Criteria Best Regards, Petr + artwork + fix wrong-sized toolbar mimetype icons. (fdo#33229) [Thorsten Behrens] + calc + fix a layout problem in Export text (CSV) dialog (fdo#37418) [Andras Timar] + fix for (binary import crash) (fdo#37322) [Katarina Machalkova] + fix for Correct autofilter import from ODS. (fdo#37323) [Markus Mohrhard] + fix for crash when copy/paste table from writer to calc (fdo#37429) [Markus Mohrhard] + sign number must be either 1 or -1, never 0. (fdo#37326) [Regina Henschel] + components + polish branding - fix langpack mac installer icon (fdo#33229) [Thorsten Behrens] + libs-core + - updated license information (fdo#37001) [Andras Timar] + don't assume you'll always find a match. (fdo#37252) [Kohei Yoshida] + fixed crash when reading malformed fieldmark tags in ODT (fdo#34997) [Cédric Bosdonnat] + initialize resource manager to get verbose basic errors (fdo#37370) [Noel Power] + make style:layout-grid-snap-to-characters fit to ODF spec. (fdo#37390) [Cédric Bosdonnat] + sanity checks that fix crash (fdo#36495) [Tor Lillqvist] + libs-extern-sys + remove added license header that caused parse error (fdo#37433) [Andras Timar] + libs-gui + don't broadcast setting changes during painting of button. (fdo#36690) [Kohei Yoshida] + fix a bug about presssed button state (fdo#36613) [Lucas Baudin] + fixed the prefix recognition in URLs... that list is sorted. (fdo#36615) [Cédric Bosdonnat] + testing + make toolkit.UnoScrollBarControl not fail headless (fdo#37325) [Bjoern Michaelsen] + writer + compatibility option for old size of small caps (bnc#691473) [Luboš Luňák] + fix crash reading some documents with fields (fdo#36329) [Cédric Bosdonnat] + fix for (fdo#36552) [Noel Power] + reorganized columns dialog to show text direction correctly (fdo#37387) [Cédric Bosdonnat] + common + branch libreoffice-3-4-0 [Petr Mladek] + version 3.4.0.2, tag libreoffice-3.4.0.2 (3.4.0-rc2) [Petr Mladek] + artwork + fix wrong-sized toolbar mimetype icons. (fdo#33229) [Thorsten Behrens] + bootstrap + always request an unversioned lib from gcc in gccinstlib.pl [Bjoern Michaelsen] + bump product version to 3.4.0-rc2, release number to 12 [Petr Mladek] + calc + fix a layout problem in Export text (CSV) dialog (fdo#37418) [Andras Timar] + fix for (binary import crash) (fdo#37322) [Katarina Machalkova] + fix for Correct autofilter import from ODS. (fdo#37323) [Markus Mohrhard] + fix for crash when copy/paste table from writer to calc (fdo#37429) [Markus Mohrhard] + fix index out of bounds in ScTableConditionalFormat. [Rafael Dominguez] + sign number must be either 1 or -1, never 0. (fdo#37326) [Regina Henschel] + update sheet local db data when sheets are inserted/deleted [Markus Mohrhard] + components + 3rd update to Mac dmg background. [Thorsten Behrens] + polish branding - fix langpack mac installer icon (fdo#33229) [Thorsten Behrens] + extensions + removed GNUism in makefile [Thorsten Behrens] + filters + don't de-reference null pointer - fix crash with certain PPTX files [Michael Meeks] + fix config for pptx filter - thanks to Bubli [Radek Doulik] + make export to .pptx 2010 work again [Katarina Machalkova] + impress + added sdfilt.component for pptx export [Radek Doulik] + fix sdfilt component generation [Radek Doulik] + libs-core + - updated license information (fdo#37001) [Andras Timar] + do not include bsh.jar when building with system bsh [David Tardon] + don't assume you'll always find a match. (fdo#37252) [Kohei Yoshida] + fixed crash when reading malformed fieldmark tags in ODT (fdo#34997) [Cédric Bosdonnat] + initialize resource manager to get verbose basic errors (fdo#37370) [Noel Power] + make style:layout-grid-snap-to-characters fit to ODF spec. (fdo#37390) [Cédric Bosdonnat] + sanity checks that fix crash (fdo#36495) [Tor Lillqvist] + libs-extern-sys + remove added license header that caused parse error (fdo#37433) [Andras Timar] + libs-gui + don't broadcast setting changes during painting of button. (fdo#36690) [Kohei Yoshida] + fix a bug about presssed button state (fdo#36613) [Lucas Baudin] + fixed the prefix recognition in URLs... that list is sorted. (fdo#36615) [Cédric Bosdonnat] + postprocess + add sdfilt component [Radek Doulik] + testing + make t
[Libreoffice] REMINDER: Release 3.3.3-rc1 from libreoffice-3-3 branch
Hi, please note that the commit deadline for 3.3.3-rc1 is the following Monday, May 30, 2011. Also note that the branch libreoffice-3-3-3 will be created the day after and only commits with 3 reviewers will be allowed for that branch. Commit rules for libreoffice-3-3 branch for 3.3.3 bug fix and further releases: + commits approved by one person [*] + only safe bug fixes + no UI changes [*] send mail to the libreoffice@lists.freedesktop.org mailing list; use [REVIEW] in mail subject; put experts into CC if known; attach patch or mention link to the commit in master or another branch Reference: http://wiki.documentfoundation.org/ReleasePlan#3.3.3_release http://wiki.documentfoundation.org/Release_Criteria Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] development summary: year 2011, week 21
salContentBroker::...::XContentProviderManager (fdo#35727) [Bjoern Michaelsen]
+ replace "seagull" icons to LibreOffice icons (fdo#37617) [Andras Timar]
+ libs-extern-sys
+ update: Brazilian portuguese spelling dictionary & hyphenation (fdo#37671) [Andras Timar]
+ libs-gui
+ reenable toolkit.AccessibleStatusBarItem as it appears stable (fdo#35690) [Bjoern Michaelsen]
+ use natural string sorter as default svtools string sorter (fdo#36940) [Caolán McNamara]
+ writer
+ avoid crash in getRowSpan (rhbz#707317) [Caolán McNamara]
+ cross-References-Tab now displays the items correctly. (fdo#34872) [Rob Snelders]
+ fix sw.SwXViewSettings::com::sun::star::text::ViewSettings (fdo#35661) [Bjoern Michaelsen]
+ reenable sw.DocumentSettings::com::sun::star::text::PrintSettings (fdo#35660) [Bjoern Michaelsen]
+ reenable sw.SwXPrintSettings::com::sun::star::text::PrintSettings (fdo#35662) [Bjoern Michaelsen]
+ revert a7c0b2ce51d0a412fbf8f7ba758c032606eb86bc (fdo#35660) [Bjoern Michaelsen]
+ rework of fix for (fdo#35826) [Noel Power]
+ temp ole docshell on dtor deletes SwDoc on 0 refcount (fdo#35937) [Caolán McNamara]
+ build
+ l10n: I forgot that Serbians did not use Pootle [Andras Timar]
+ l10n: updated fallback-to-en-US.sdf file [Andras Timar]
+ l10n: updated translations from Pootle [Andras Timar]
+ extensions
+ l10n: add br, et, and tr to NLPSolver + fixes to fr and nb [Andras Timar]
+ extras
+ replace StarOffice icons to LibreOffice icons in Web Wizard (fdo#33229) [Andras Timar]
+ l10n
+ l10n: bn translation fixes and updates [Andras Timar]
+ l10n: br translation fixes and updates [Andras Timar]
+ l10n: da translation fixes and updates [Andras Timar]
+ l10n: et translation fixes and updates [Andras Timar]
+ l10n: fr translation fixes and updates [Andras Timar]
+ l10n: is translation fixes and updates [Andras Timar]
+ l10n: lt translation fixes and updates [Andras Timar]
+ l10n: nb translation fixes and updates [Andras Timar]
+ l10n: pt-BR translation fixes and updates [Andras Timar]
+ l10n: te translation fixes and updates [Andras Timar]
+ l10n: tr translation fixes and updates [Andras Timar]
+ l10n: zh-TW translation fixes and updates [Andras Timar]
+ libs-core
+ - updated license information (fdo#37001) [Andras Timar]
+ replace "seagull" icons to LibreOffice icons (fdo#37617) [Andras Timar]
+ common:
+ version 3.4.0.2, tag libreoffice-3.4.0.2 (3.4.0-rc2) [Petr Mladek]
+ artwork
+ fix wrong-sized toolbar mimetype icons. (fdo#33229) [Thorsten Behrens]
+ bootstrap
+ always request an unversioned lib from gcc in gccinstlib.pl [Bjoern Michaelsen]
+ bump product version to 3.4.0-rc2, release number to 12 [Petr Mladek]
+ lo-commit-stat: add --log-dir option [Petr Mladek]
+ lo-pack-sources: do not pack fetched stuff into the source tarball [Petr Mladek]
+ calc
+ don't cache the array size but query it dynamically. (fdo#37520) [Kohei Yoshida]
+ fix a layout problem in Export text (CSV) dialog (fdo#37418) [Andras Timar]
+ fix for Correct autofilter import from ODS. (fdo#37323) [Markus Mohrhard]
+ fix for crash when copy/paste table from writer to calc (fdo#37429) [Markus Mohrhard]
+ update sheet local db data when sheets are inserted/deleted [Markus Mohrhard]
+ components
+ 3rd update to Mac dmg background. [Thorsten Behrens]
+ polish branding - fix langpack mac installer icon (fdo#33229) [Thorsten Behrens]
+ extensions
+ removed GNUism in makefile [Thorsten Behrens]
+ libs-core
+ - updated license information (fdo#37001) [Andras Timar]
+ do not include bsh.jar when building with system bsh [David Tardon]
+ initialize resource manager to get verbose basic errors (fdo#37370) [Noel Power]
+ make style:layout-grid-snap-to-characters fit to ODF spec. (fdo#37390) [Cédric Bosdonnat]
+ libs-extern-sys
+ remove added license header that caused parse error (fdo#37433) [Andras Timar]
+ translations
+ update translations from Pootle for LibO 3.4 rc 2 [Andras Timar]
+ writer
+ fix crash reading some documents with fields (fdo#36329) [Cédric Bosdonnat]
+ give more room to style listbox [Jean-Baptiste Faure]
+ reorganized columns dialog to show text direction correctly (fdo#37387) [Cédric Bosdonnat]
+ artwork
+ fix wrong-sized toolbar mimetype icons. (fdo#33229) [Thorsten Behrens]
+ bootstrap
+ always request an unversioned lib from gcc in gccinstlib.pl [Bjoern Michaelsen]
+ don't forget en-US when dev-installing ALL languages [Andras Timar]
+ fix ant home [Robert Nagy]
+ handle --with-lang=ALL case [Andras Timar]
+ lo-commit-stat: add --log-dir option [Petr Mladek]
+ lo-pack-sources: do not pack fetched stuff into the source tarball [Petr Mladek]
+ use $GNUMAKE to print the build instructions [Robert Nagy]
+ calc
+ don't cache the array size but query it dy
Re: [Libreoffice] [REVIEW][PUSHED-3-4] fdo#35345: more Calc (auto)filter evilness
Kohei Yoshida píše v Út 24. 05. 2011 v 13:05 -0400: > On Tue, 2011-05-24 at 17:50 +0200, Markus Mohrhard wrote: > > Hello Katarina, > > > > the idea is good, but I think we should move this code to > > ScDocument::GetFilterDBAtTable because I'm not quite sure if there are > > not some cases where there is a sheet local db data but no > > dbcollection. I personally would prefer that but I'm fine with this > > patch too. > > You have a second. Nice work! > > We need one more sign-off in order to get this piece included in the > -3-4-0 branch. Just for record. Kohei pushed this into the libreoffice-3-4 branch. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW][PUSHED-3-4] Fix for fdo#37356
Markus Mohrhard píše v Čt 26. 05. 2011 v 21:58 +0200: > You've my sign-off. I'll push it to 3-4. I see it there => updating subject to safe others time. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [Review][PUSHED3-4] set all borders correctly in SvxRTFParser::ReadBorderAttr instead of only one
Cedric Bosdonnat píše v Pá 27. 05. 2011 v 16:03 +0200: > Hello Markus, > > On Fri, 2011-05-27 at 14:02 +0200, Markus Mohrhard wrote: > > yes there might still be some problems, I only tried to fix that > > during pasting to calc all borders are drawn. I'm not familiar with > > the RTF spec and the old code(before Cedric refactored it) was really > > ugly and even used some gotos. > > > > This quick patch was more or less a result of > > https://bugs.freedesktop.org/show_bug.cgi?id=37429 as I noticed that > > borders were totally screwed up. If I can help in any way just mail me > > and I have a look at it. > > I pushed your patch Updated subject to safe others time. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [ANNOUNCE] libreoffice-3.3.3.1 tag created (3.3.3-rc1)
Hi,
there have been created the libreoffice-3.3.3.1 tag for 3.3.3-rc1 release.
The corresponding official builds will be available by the end of the week.
See the attached list of changes against 3.3.2-final.
You might switch your current 3-3 source tree to it using:
./g fetch --tags
./g checkout -b tag-libreoffice-3.3.3.1 libreoffice-3.3.3.1
See also the schedule at
http://wiki.documentfoundation.org/ReleasePlan#3.3_release
and release criteria at http://wiki.documentfoundation.org/Release_Criteria
Best Regards,
Petr
+ build
+ fix for (fdo#34908) [Noel Power]
+ fixed regression of copy-paste of Writer table formulas (bnc#675961) [Cédric Bosdonnat]
+ no need to overwrite "upstream" icons any more, (bnc#685515) [Tor Lillqvist]
+ calc
+ fix seg faults on sheet deletion. (bnc#680272) [Kohei Yoshida]
+ libreoffice Calc's PRODUCT function doesn't calculate correctly. (lp#775608) [Bjoern Michaelsen]
+ extras
+ replace StarOffice icons to LibreOffice icons in Web Wizard (fdo#33229) [Andras Timar]
+ impress
+ add sanity check before dereference, (bnc#694119) [Tor Lillqvist]
+ fix crash in Impress after printing (fdo#33947) [Caolán McNamara]
+ libs-core
+ - updated license information (fdo#37001) [Andras Timar]
+ don't pass potentially bogus file: URIs to libxml2 (fdo#33970, i#109096) [Tor Lillqvist]
+ replace "seagull" icons to LibreOffice icons (fdo#37617) [Andras Timar]
+ use full path for kdefilepicker helper binary (bnc#31109) [Luboš Luňák]
+ libs-extern
+ crash in es thesaurus (rhbz#675806) [Caolán McNamara]
+ libs-extern-sys
+ l10n: update de_CH and de_AT dictionaries (fdo#33751) [Andras Timar]
+ libs-gui
+ fix for 3.3.2 blocker - change the type of nDrawerHeight to long (fdo#34718) [Radek Doulik]
+ ure
+ fix for allow dot net clients to bootstrap libreoffice (fdo#35108) [Noel Power]
+ writer
+ fix the positions of imported fields to avoid crashes (bnc#663622) [Cédric Bosdonnat]
+ freeze/hang on mailmerge to attached pdf (fdo#32553) [Caolán McNamara]
+ related: /nsure correct odt mimetype and pdf export filter (fdo#31792, fdo#32553) [Caolán McNamara]
+ bootstrap
+ bump product version to 3.3.3-rc1, release number to 301 [Petr Mladek]
+ remove already integrated Lin* fonts. [Kalman Szalai - KAMI]
+ build
+ avoid build error if no --with-poor-help-localizations [Tor Lillqvist]
+ changes of OxygenOffice branding [Kalman Szalai - KAMI]
+ delete fallback strings which were translated between rc1 and rc2 [Andras Timar]
+ filter out poor help localizations from help pack installers [Tor Lillqvist]
+ fix download for all 3.3.x source release [Gökçen Eraslan]
+ fix for (fdo#34908) [Noel Power]
+ fix piece-offuh.diff to apply [Petr Mladek]
+ fixed regression of copy-paste of Writer table formulas (bnc#675961) [Cédric Bosdonnat]
+ l10n: I forgot that Serbians did not use Pootle [Andras Timar]
+ l10n: update translations from Pootle [Andras Timar]
+ l10n: updated fallback-to-en-US.sdf file [Andras Timar]
+ l10n: updated translations from Pootle [Andras Timar]
+ lo-commit-stat: add --log-dir option [Petr Mladek]
+ lo-commit-stat: print summary into log a file [Petr Mladek]
+ make win32-prebuilt-writingaids-zip.diff apply again [Tor Lillqvist]
+ merge: 079d173 d081ece [Petr Mladek]
+ no need to overwrite "upstream" icons any more, (bnc#685515) [Tor Lillqvist]
+ remove a hacky patch. The right fix should be in git now. [Kohei Yoshida]
+ removed the patches against helpcontent2. [Kohei Yoshida]
+ revert "Remove a hacky patch. The right fix should be in git now." [Kohei Yoshida]
+ revert "Removed the patches against helpcontent2." [Kohei Yoshida]
+ win32 packaging for release as patch [Fridrich Štrba]
+ calc
+ disabled auto-complete in Calc filter dialog - fix for bug 34898. [Tibby Lickle]
+ fix seg faults on sheet deletion. (bnc#680272) [Kohei Yoshida]
+ libreoffice Calc's PRODUCT function doesn't calculate correctly. (lp#775608) [Bjoern Michaelsen]
+ extensions
+ l10n: add br, et, and tr to NLPSolver + fixes to fr and nb [Andras Timar]
+ extras
+ replace StarOffice icons to LibreOffice icons in Web Wizard (fdo#33229) [Andras Timar]
+ filters
+ avoid possibility of accessing out of range ObjTimes [Caolán McNamara]
+ help
+ copy the scripts to generate wikihelp from master. [Jan Holesovsky]
+ impress
+ add sanity check before dereference, (bnc#694119) [Tor Lillqvist]
+ fix crash in Impress after printing (fdo#33947) [Caolán McNamara]
+ l10n
+ l10n: bn translation fixes and updates [Andras Timar]
+ l10n: br translation fixes and updates [Andras Timar]
+ l10n: da translation fixes and updates [Andras Timar]
+ l10n: et translation fixes and updates [Andras Timar]
+ l10n: fr translation fixes and updates [Andras Timar]
[Libreoffice] [ANNOUNCE] Branch libreoffice-3-3-3 created
Hi all, there have been created the libreoffice-3-3-3 branch. It will be used for fine tuning of the 3.3.3 bugfix release. It is based on the the tag libreoffice-3.3.3.1 for 3.3.3-rc1 release. The following rules apply: + preferably just translation or blocker fixes + only cherry-picking from libreoffice-3-3 branch + 2 additional reviews needed; 2nd reviewer pushes + no regular merges back to anything The 'libreoffice-3-3' branch is still active, will be used for the next bugfix release (3.3.4). Please read more at http://wiki.documentfoundation.org/ReleasePlan http://wiki.documentfoundation.org/Development/Branches Now, if you want to switch your clone to the libreoffice-3-3-3 branch, please do: git pull -r bin/g pull -r git checkout -b libreoffice-3-3-3 origin/libreoffice-3-3-3 bin/g checkout -b libreoffice-3-3-3 origin/libreoffice-3-3-3 Hopefully it will work for you :-) Most probably, you will also want to do (if you haven't done it yet): git config --global push.default tracking When you do git push with this, git will push only the branch you are on; ie. libreoffice-3-3-3 when you have switched to it. This will save you some git shouting at you. Happy hacking, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW] menu packages for OxygenOffice
Kálmán „KAMI” Szalai píše v St 25. 05. 2011 v 07:05 +0200: > Hi Developers, > > Last time Fridrich has reverted a patch because it caused problem. It > seems I forget to attach all required patches. > > Can you revert this: > http://cgit.freedesktop.org/libreoffice/bootstrap/commit/?h=libreoffice-3-4&id=77eb7f58d973eeb397dac0702646fc811894851c > > And also please apply the patch that I attached? > > I would like to get it to libreoffice-3-4, so I need 1 approval. Done. See http://cgit.freedesktop.org/libreoffice/bootstrap/commit/?h=libreoffice-3-4&id=8935d31fcdcde28d489af4392f7385433b634674 http://cgit.freedesktop.org/libreoffice/libs-core/commit/?h=libreoffice-3-4&id=633c56f36228cdab56cd08e44cc3e029eb742346 Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
