Cedric Bosdonnat píše v Čt 19. 05. 2011 v 14:51 +0200: > Hi Michael, > > On Thu, 2011-05-19 at 12:21 +0100, Michael Meeks wrote: > > Hi Cedric, > > > > On Thu, 2011-05-19 at 12:44 +0200, Cedric Bosdonnat wrote: > > > could you please review / push this patch to 3.4 and 3.4.0? It's a > > > simple fix that would save quite some crashes. > > > > Looks fine to me - of course I'd prefer: > > > > - xub_StrLen nEndPos = rEnd == rStart ? rEnd.nContent.GetIndex() : > > rEnd.nContent.GetIndex() - 1; > > + xub_StrLen nEndPos = MAX (0, rEnd.nContent.GetIndex() - 1); > > > > which looks like it might do the same thing ? ;-) > > no, it doesn't do the same... as xub_StrLen is sal_uInt32 or sal_uInt16. > If rEnd.nContent.GetIndex() is 0, then we would still have that big > value (the max of sal_uInt32 or sal_uInt16) when doing > rEnd.nContent.GetIndex() - 1
The patch looked fine => got 3 approvals => pushed into both libreoffice-3-4 and 3-4-0 branches. Best Regards, Petr _______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
