Review Request 119631: Baloo: Introduce org.kde.baloo component.

2014-08-06 Thread Antonis Tsiapaliokas 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119631/
---

Review request for Baloo.


Repository: baloo


Description
---

This component exports some of the basic API of the Baloo::Query into to QML.

At the moment it supports only the Baloo::Query::setType and 
Baloo::Query::setLimit,
with the following syntax.

BalooModel {
query {
type: "File/Image"
limit: 10
}
}


Diffs
-

  src/imports/baloodatamodel.cpp PRE-CREATION 
  src/imports/balooplugin.h PRE-CREATION 
  src/imports/balooplugin.cpp PRE-CREATION 
  src/imports/qmldir PRE-CREATION 
  src/CMakeLists.txt 810f6dc 
  src/imports/CMakeLists.txt PRE-CREATION 
  src/imports/baloodatamodel.h PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/119631/diff/


Testing
---


Thanks,

Antonis Tsiapaliokas


>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 119631: Baloo: Introduce org.kde.baloo component.

2014-08-06 Thread Vishesh Handa 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119631/#review63907
---



src/CMakeLists.txt


Could you please change the directory name to QML? It's a lot more 
descriptive than "import"



src/imports/CMakeLists.txt


These first 5 lines aren't required. You can add the additional 
dependencies to the root CMakeLists.txt.

Why do we need KDeclarative?



src/imports/CMakeLists.txt


This is not required.



src/imports/CMakeLists.txt


ditto



src/imports/CMakeLists.txt


I could be wrong, but I don't think you're using QtQuick of 
KF5::Declarative.



src/imports/baloodatamodel.h


This constructor is not really required. It's not a copy constructor since 
it has an extra "QObject* parent"

Plus, since we do not have a d pointer, the default copy constructor will 
work for us.



src/imports/baloodatamodel.h


The operator = and operator == are not required.



src/imports/baloodatamodel.h


How about you just use Baloo::Result, instead of creating a BalooEntry 
class?



src/imports/baloodatamodel.h


What is this function used for?



src/imports/baloodatamodel.h


The IconRole is not requried, we can use the decoration role.



src/imports/baloodatamodel.h


The TextRole is not required. We can use the Qt::DisplayRole.



src/imports/baloodatamodel.cpp


#include "query.h"



src/imports/baloodatamodel.cpp


Why 25?



src/imports/baloodatamodel.cpp


You take the query, but you do not take ownership of the parent, so it will 
never be deleted.

Maybe you can explicitly delete it in the destructor?



src/imports/balooplugin.cpp


Oh. I see you do use KDeclarative, but it's not really required as we do 
not have any strings that need to be translated.

Perhaps you could remove this?



src/imports/balooplugin.cpp


Not really required. Automoc will take care of it.


- Vishesh Handa


On Aug. 6, 2014, 8:32 a.m., Antonis Tsiapaliokas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119631/
> ---
> 
> (Updated Aug. 6, 2014, 8:32 a.m.)
> 
> 
> Review request for Baloo.
> 
> 
> Repository: baloo
> 
> 
> Description
> ---
> 
> This component exports some of the basic API of the Baloo::Query into to QML.
> 
> At the moment it supports only the Baloo::Query::setType and 
> Baloo::Query::setLimit,
> with the following syntax.
> 
> BalooModel {
> query {
> type: "File/Image"
> limit: 10
> }
> }
> 
> 
> Diffs
> -
> 
>   src/imports/baloodatamodel.cpp PRE-CREATION 
>   src/imports/balooplugin.h PRE-CREATION 
>   src/imports/balooplugin.cpp PRE-CREATION 
>   src/imports/qmldir PRE-CREATION 
>   src/CMakeLists.txt 810f6dc 
>   src/imports/CMakeLists.txt PRE-CREATION 
>   src/imports/baloodatamodel.h PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/119631/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Antonis Tsiapaliokas
> 
>


>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 119631: Baloo: Introduce org.kde.baloo component.

2014-08-06 Thread Antonis Tsiapaliokas 


> On Aug. 6, 2014, 11:04 a.m., Vishesh Handa wrote:
> > src/imports/CMakeLists.txt, line 11
> > 
> >
> > This is not required.

No it is required, otherwise we cannot link our engine.


- Antonis


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119631/#review63907
---


On Aug. 6, 2014, 8:32 a.m., Antonis Tsiapaliokas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119631/
> ---
> 
> (Updated Aug. 6, 2014, 8:32 a.m.)
> 
> 
> Review request for Baloo.
> 
> 
> Repository: baloo
> 
> 
> Description
> ---
> 
> This component exports some of the basic API of the Baloo::Query into to QML.
> 
> At the moment it supports only the Baloo::Query::setType and 
> Baloo::Query::setLimit,
> with the following syntax.
> 
> BalooModel {
> query {
> type: "File/Image"
> limit: 10
> }
> }
> 
> 
> Diffs
> -
> 
>   src/imports/baloodatamodel.cpp PRE-CREATION 
>   src/imports/balooplugin.h PRE-CREATION 
>   src/imports/balooplugin.cpp PRE-CREATION 
>   src/imports/qmldir PRE-CREATION 
>   src/CMakeLists.txt 810f6dc 
>   src/imports/CMakeLists.txt PRE-CREATION 
>   src/imports/baloodatamodel.h PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/119631/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Antonis Tsiapaliokas
> 
>


>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 119631: Baloo: Introduce org.kde.baloo component.

2014-08-06 Thread Antonis Tsiapaliokas 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119631/
---

(Updated Aug. 6, 2014, 12:02 p.m.)


Review request for Baloo.


Changes
---

I have fix the issues which they have been pointed out.


Repository: baloo


Description
---

This component exports some of the basic API of the Baloo::Query into to QML.

At the moment it supports only the Baloo::Query::setType and 
Baloo::Query::setLimit,
with the following syntax.

BalooModel {
query {
type: "File/Image"
limit: 10
}
}


Diffs (updated)
-

  CMakeLists.txt abb494a 
  src/CMakeLists.txt 810f6dc 
  src/qml/CMakeLists.txt PRE-CREATION 
  src/qml/baloodatamodel.h PRE-CREATION 
  src/qml/baloodatamodel.cpp PRE-CREATION 
  src/qml/balooplugin.h PRE-CREATION 
  src/qml/balooplugin.cpp PRE-CREATION 
  src/qml/qmldir PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/119631/diff/


Testing
---


Thanks,

Antonis Tsiapaliokas


>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 119631: Baloo: Introduce org.kde.baloo component.

2014-08-06 Thread Vishesh Handa 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119631/#review63918
---


Looks good otherwise!


CMakeLists.txt


I meant that this line can be combined with the previous one.

find_package(Qt5 REQUIRED NO_MODULE COMPONENTS Widgets Dbus Test Sql Quick)



src/qml/CMakeLists.txt


Minor nitpick. This isn't required.



src/qml/baloodatamodel.cpp


I'm not sure if we need these 2 role names. They are typically defined by 
default.

The correct way to implement this function would be -

QHash roles = QAbstractListModel::roleNames();
roles[IdRole] = "id";
roles[UrlRole] = "url";

reuturn roles;


- Vishesh Handa


On Aug. 6, 2014, 12:02 p.m., Antonis Tsiapaliokas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119631/
> ---
> 
> (Updated Aug. 6, 2014, 12:02 p.m.)
> 
> 
> Review request for Baloo.
> 
> 
> Repository: baloo
> 
> 
> Description
> ---
> 
> This component exports some of the basic API of the Baloo::Query into to QML.
> 
> At the moment it supports only the Baloo::Query::setType and 
> Baloo::Query::setLimit,
> with the following syntax.
> 
> BalooModel {
> query {
> type: "File/Image"
> limit: 10
> }
> }
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt abb494a 
>   src/CMakeLists.txt 810f6dc 
>   src/qml/CMakeLists.txt PRE-CREATION 
>   src/qml/baloodatamodel.h PRE-CREATION 
>   src/qml/baloodatamodel.cpp PRE-CREATION 
>   src/qml/balooplugin.h PRE-CREATION 
>   src/qml/balooplugin.cpp PRE-CREATION 
>   src/qml/qmldir PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/119631/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Antonis Tsiapaliokas
> 
>


>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 118438: Add an option to only build baloo's libraries

2014-08-06 Thread Heiko Becker 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118438/
---

(Updated Aug. 6, 2014, 2:31 p.m.)


Status
--

This change has been marked as submitted.


Review request for Baloo.


Repository: baloo


Description
---

The intention behind this review request is to make it easier to turn baloo 
into a framework and make it coinstallable with its KDE4 counterpart in a 
second review request.

That being said I'm not exactly sure this is the way you guys want to go, but 
I'd be willing to update my review request accordingly if you have other plans 
to make it coinstallable.


Diffs
-

  CMakeLists.txt abb494ae32ef27e0ca65da341f5d9a0b37f51645 
  src/CMakeLists.txt 810f6dcd97b5f3ff64962709efbfffec7fa9a257 
  src/file/CMakeLists.txt 7d384c51662a0b381e6fc861e8565c6da4af8525 

Diff: https://git.reviewboard.kde.org/r/118438/diff/


Testing
---

cmake -DBALOO_LIBRARIES_ONLY:BOOL=TRUE ..
make
make install

I've also built the frameworks branch of milou against it (needed a few 
modifications).


Thanks,

Heiko Becker


>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 119631: Baloo: Introduce org.kde.baloo component.

2014-08-06 Thread Antonis Tsiapaliokas 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119631/
---

(Updated Aug. 6, 2014, 2:51 p.m.)


Review request for Baloo.


Repository: baloo


Description
---

This component exports some of the basic API of the Baloo::Query into to QML.

At the moment it supports only the Baloo::Query::setType and 
Baloo::Query::setLimit,
with the following syntax.

BalooModel {
query {
type: "File/Image"
limit: 10
}
}


Diffs (updated)
-

  src/qml/qmldir PRE-CREATION 
  CMakeLists.txt abb494a 
  src/CMakeLists.txt 810f6dc 
  src/qml/CMakeLists.txt PRE-CREATION 
  src/qml/baloodatamodel.h PRE-CREATION 
  src/qml/baloodatamodel.cpp PRE-CREATION 
  src/qml/balooplugin.h PRE-CREATION 
  src/qml/balooplugin.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/119631/diff/


Testing
---


Thanks,

Antonis Tsiapaliokas


>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 119631: Baloo: Introduce org.kde.baloo component.

2014-08-06 Thread Vishesh Handa 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119631/#review63924
---

Ship it!


Once you've made the changes feel free to ship it.


src/qml/baloodatamodel.cpp


If you feel like removing this line and the next it would be nice. Your 
choice.



src/qml/baloodatamodel.cpp


I just realized that we're still leaking memory as the old m_query is just 
being ignored.

Please call `delete m_query` before this line.


- Vishesh Handa


On Aug. 6, 2014, 2:51 p.m., Antonis Tsiapaliokas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119631/
> ---
> 
> (Updated Aug. 6, 2014, 2:51 p.m.)
> 
> 
> Review request for Baloo.
> 
> 
> Repository: baloo
> 
> 
> Description
> ---
> 
> This component exports some of the basic API of the Baloo::Query into to QML.
> 
> At the moment it supports only the Baloo::Query::setType and 
> Baloo::Query::setLimit,
> with the following syntax.
> 
> BalooModel {
> query {
> type: "File/Image"
> limit: 10
> }
> }
> 
> 
> Diffs
> -
> 
>   src/qml/qmldir PRE-CREATION 
>   CMakeLists.txt abb494a 
>   src/CMakeLists.txt 810f6dc 
>   src/qml/CMakeLists.txt PRE-CREATION 
>   src/qml/baloodatamodel.h PRE-CREATION 
>   src/qml/baloodatamodel.cpp PRE-CREATION 
>   src/qml/balooplugin.h PRE-CREATION 
>   src/qml/balooplugin.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/119631/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Antonis Tsiapaliokas
> 
>


>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 119631: Baloo: Introduce org.kde.baloo component.

2014-08-06 Thread Antonis Tsiapaliokas 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119631/
---

(Updated Aug. 6, 2014, 4:37 p.m.)


Status
--

This change has been marked as submitted.


Review request for Baloo.


Repository: baloo


Description
---

This component exports some of the basic API of the Baloo::Query into to QML.

At the moment it supports only the Baloo::Query::setType and 
Baloo::Query::setLimit,
with the following syntax.

BalooModel {
query {
type: "File/Image"
limit: 10
}
}


Diffs
-

  src/qml/qmldir PRE-CREATION 
  CMakeLists.txt abb494a 
  src/CMakeLists.txt 810f6dc 
  src/qml/CMakeLists.txt PRE-CREATION 
  src/qml/baloodatamodel.h PRE-CREATION 
  src/qml/baloodatamodel.cpp PRE-CREATION 
  src/qml/balooplugin.h PRE-CREATION 
  src/qml/balooplugin.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/119631/diff/


Testing
---


Thanks,

Antonis Tsiapaliokas


>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 119631: Baloo: Introduce org.kde.baloo component.

2014-08-06 Thread Hrvoje Senjan 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119631/#review63938
---


looks like this went into wrong branch? i.e. frameworks instead of master

- Hrvoje Senjan


On Aug. 6, 2014, 6:37 p.m., Antonis Tsiapaliokas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119631/
> ---
> 
> (Updated Aug. 6, 2014, 6:37 p.m.)
> 
> 
> Review request for Baloo.
> 
> 
> Repository: baloo
> 
> 
> Description
> ---
> 
> This component exports some of the basic API of the Baloo::Query into to QML.
> 
> At the moment it supports only the Baloo::Query::setType and 
> Baloo::Query::setLimit,
> with the following syntax.
> 
> BalooModel {
> query {
> type: "File/Image"
> limit: 10
> }
> }
> 
> 
> Diffs
> -
> 
>   src/qml/qmldir PRE-CREATION 
>   CMakeLists.txt abb494a 
>   src/CMakeLists.txt 810f6dc 
>   src/qml/CMakeLists.txt PRE-CREATION 
>   src/qml/baloodatamodel.h PRE-CREATION 
>   src/qml/baloodatamodel.cpp PRE-CREATION 
>   src/qml/balooplugin.h PRE-CREATION 
>   src/qml/balooplugin.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/119631/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Antonis Tsiapaliokas
> 
>


>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

[ANNOUNCE] CMake 3.0.1 Released

2014-08-06 Thread Robert Maynard 
We are pleased to announce that CMake 3.0.1 is now available for download.

The change log page for this bug-fix only release is here:
  http://public.kitware.com/Bug/roadmap_page.php?version_id=123
Please use the latest release from our download page:
  http://cmake.org/cmake/resources/software.html

Thanks for your support!

-
Changes in 3.0.1 since 3.0.0:

Adam Strzelecki (1):
  Ninja: Remove CMake includes from explicit depends (#14972)

Bob E (1):
  KWSys SystemInformation: No SA_RESTART on QNX

Brad King (10):
  cmake: Fix read-after-free while checking command-line arguments
  Fortran: Add support for GNU >= 4.9 compressed modules (#14975)
  bootstrap: Clarify name of configured source directory
  bootstrap: Fix "make test" and "make package" targets (#14989)
  UseSWIG: Fix check for noproxy flag (#14990)
  CMakeExpandImportedTargets: Do not read property on non-target (#15008)
  MSVC: Fix linking of DLLs on WinCE (#15013)
  Xcode: Fix static library creation for Xcode 6 (#15038)
  Check*CompilerFlag: Avoid ';' in common pattern (#15048)
  CMake 3.0.1

Chuck Atkins (1):
  cmcurl: Fix a build failure with the Cray compiler on Linux (#15026)

Mathieu MARACHE (1):
  FindQt4: Add nativewifi and qtga plugins

Stephen Kelly (1):
  QNX: Add missing flags for configurations and artifact creation.

Tim Blechmann (1):
  OS X: Install CFBundles as complete directories

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 119631: Baloo: Introduce org.kde.baloo component.

2014-08-06 Thread Vishesh Handa 


> On Aug. 6, 2014, 4:48 p.m., Hrvoje Senjan wrote:
> > looks like this went into wrong branch? i.e. frameworks instead of master

Yup.

Antonis please push this to the master branch. I've deleted the frameworks 
branch.


- Vishesh


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119631/#review63938
---


On Aug. 6, 2014, 4:37 p.m., Antonis Tsiapaliokas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119631/
> ---
> 
> (Updated Aug. 6, 2014, 4:37 p.m.)
> 
> 
> Review request for Baloo.
> 
> 
> Repository: baloo
> 
> 
> Description
> ---
> 
> This component exports some of the basic API of the Baloo::Query into to QML.
> 
> At the moment it supports only the Baloo::Query::setType and 
> Baloo::Query::setLimit,
> with the following syntax.
> 
> BalooModel {
> query {
> type: "File/Image"
> limit: 10
> }
> }
> 
> 
> Diffs
> -
> 
>   src/qml/qmldir PRE-CREATION 
>   CMakeLists.txt abb494a 
>   src/CMakeLists.txt 810f6dc 
>   src/qml/CMakeLists.txt PRE-CREATION 
>   src/qml/baloodatamodel.h PRE-CREATION 
>   src/qml/baloodatamodel.cpp PRE-CREATION 
>   src/qml/balooplugin.h PRE-CREATION 
>   src/qml/balooplugin.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/119631/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Antonis Tsiapaliokas
> 
>


>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<