Re: [PR] SOLR-17669: Reduce Memory Consumption by 80-90% when using Dynamic fields (DocumentObjectBinder) [solr]
ds-manzinger commented on PR #3179: URL: https://github.com/apache/solr/pull/3179#issuecomment-2661052895 Yes, it is only in SolrJ. Our Company used that feature quite many years (I think since Solr 4). If there is a case, where a * in the middle of the name is possible, we can add the Pattern.matcher as fallback. What would you suggest? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17671 Replication and Backup use an unwrapped Directory. [solr]
bruno-roustant commented on code in PR #3185: URL: https://github.com/apache/solr/pull/3185#discussion_r1957163042 ## solr/core/src/java/org/apache/solr/handler/IncrementalShardBackup.java: ## @@ -145,21 +145,22 @@ protected IncrementalShardSnapshotResponse backup(final IndexCommit indexCommit) details.startTime = Instant.now().toString(); Collection files = indexCommit.getFileNames(); +DirectoryFactory directoryFactory = solrCore.getDirectoryFactory(); Directory dir = -solrCore -.getDirectoryFactory() -.get( -solrCore.getIndexDir(), -DirectoryFactory.DirContext.DEFAULT, -solrCore.getSolrConfig().indexConfig.lockType); +directoryFactory.get( +solrCore.getIndexDir(), +DirectoryFactory.DirContext.DEFAULT, Review Comment: In theversion 2 of the PR, I separated the DirContext (what the directory is) and DirUseContext (what the directory will be used for). I put replication and backup in DirUseContext, so they cannot be passed to DirectoryFactory.get(). ## solr/core/src/java/org/apache/solr/handler/IncrementalShardBackup.java: ## @@ -145,21 +145,22 @@ protected IncrementalShardSnapshotResponse backup(final IndexCommit indexCommit) details.startTime = Instant.now().toString(); Collection files = indexCommit.getFileNames(); +DirectoryFactory directoryFactory = solrCore.getDirectoryFactory(); Directory dir = -solrCore -.getDirectoryFactory() -.get( -solrCore.getIndexDir(), -DirectoryFactory.DirContext.DEFAULT, -solrCore.getSolrConfig().indexConfig.lockType); +directoryFactory.get( +solrCore.getIndexDir(), +DirectoryFactory.DirContext.DEFAULT, Review Comment: In the version 2 of the PR, I separated the DirContext (what the directory is) and DirUseContext (what the directory will be used for). I put replication and backup in DirUseContext, so they cannot be passed to DirectoryFactory.get(). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Updated] (SOLR-17674) Update SolrCLI to reflect cloud mode is default
[ https://issues.apache.org/jira/browse/SOLR-17674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SOLR-17674: -- Labels: pull-request-available (was: ) > Update SolrCLI to reflect cloud mode is default > --- > > Key: SOLR-17674 > URL: https://issues.apache.org/jira/browse/SOLR-17674 > Project: Solr > Issue Type: Sub-task > Components: cli >Affects Versions: main (10.0) >Reporter: Eric Pugh >Priority: Minor > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17609: Remove HDFS module [solr]
epugh commented on code in PR #2923: URL: https://github.com/apache/solr/pull/2923#discussion_r1957226637 ## solr/modules/hdfs/src/java/org/apache/solr/hdfs/store/blockcache/package-info.java: ## Review Comment: @dsmiley I am ambivalent about this, especially when we say "hopefully".. However it doesn't appear to drag a bunch of dependencies along and in the interest of getting this PR to done and commited happy to go along with your request. So, I'm going to move `o.a.s.hdfs.store.blockcache` to solr-core as `o.a.s.blockcache`, plus the tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17618: Add unit tests for org.apache.solr.util.TimeOut [solr]
epugh commented on PR #3026: URL: https://github.com/apache/solr/pull/3026#issuecomment-2661194114 @sandbergja I don't want to lose this great work, can you sync it up and then let's merge it! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Updated] (SOLR-16465) Start the migration of the Admin UI to React
[ https://issues.apache.org/jira/browse/SOLR-16465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SOLR-16465: -- Labels: pull-request-available (was: ) > Start the migration of the Admin UI to React > > > Key: SOLR-16465 > URL: https://issues.apache.org/jira/browse/SOLR-16465 > Project: Solr > Issue Type: Wish > Components: Admin UI >Reporter: Jeb Nix >Priority: Major > Labels: pull-request-available > Time Spent: 1h > Remaining Estimate: 0h > > I suggest using > [ngUpgrade|https://angular.io/guide/upgrade#upgrading-with-ngupgrade] to > start a linear migration process to Angular from Angular JS. ngUpgrade will > reach the end of life at the end of 2023, so we will only get a year of using > it seamlessly, but this seems to me like the last resort regarding a linear > migration of the Admin UI codebase. The need for this is of course to migrate > the current Admin UI project to newer technology, instead of writing it all > from the start (or implementing the same stuff once more in YASA). -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-16465: Replace Login w/ React App [solr]
epugh commented on PR #1479: URL: https://github.com/apache/solr/pull/1479#issuecomment-2661195095 We've got an active effort going on with the new Kotlin based "Solr UI", so going to close this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-16465: Replace Login w/ React App [solr]
epugh closed pull request #1479: SOLR-16465: Replace Login w/ React App URL: https://github.com/apache/solr/pull/1479 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Update enabling-ssl.adoc - fix minor typo in example [solr]
epugh commented on PR #3175: URL: https://github.com/apache/solr/pull/3175#issuecomment-2661128777 thank you for the fix! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Update enabling-ssl.adoc - fix minor typo in example [solr]
epugh merged PR #3175: URL: https://github.com/apache/solr/pull/3175 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] adding a script on how to calculated the encoded password format with… [solr]
epugh commented on PR #3162: URL: https://github.com/apache/solr/pull/3162#issuecomment-2661134311 @elangelo thanks for this... However, I am wondering if we need to go a bit furthur... @janhoy you often have good ideas on if something is the right way... I am wondering, do we need to tweak out bin/solr auth command to basically do what this script does? Have a cross platform no custom coding option? Thoughts from either of you (or anyone else?) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[PR] SOLR-17668: Add in cluster command to tool help. [solr]
epugh opened a new pull request, #3189: URL: https://github.com/apache/solr/pull/3189 https://issues.apache.org/jira/browse/SOLR-17668 # Description Add the cluster command to tool help output, and rearrange lines a bit to format nicer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Updated] (SOLR-17668) bin/solr cluster command missing from bin/solr -h
[ https://issues.apache.org/jira/browse/SOLR-17668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SOLR-17668: -- Labels: pull-request-available (was: ) > bin/solr cluster command missing from bin/solr -h > - > > Key: SOLR-17668 > URL: https://issues.apache.org/jira/browse/SOLR-17668 > Project: Solr > Issue Type: Bug > Components: cli >Affects Versions: main (10.0), 9.8 >Reporter: Eric Pugh >Assignee: Eric Pugh >Priority: Minor > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > After looking at [https://github.com/apache/solr/pull/3175/files] discovered > the bin/solr -h misses the "cluster" command. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Created] (SOLR-17674) Update SolrCLI to reflect cloud mode is default
Eric Pugh created SOLR-17674: Summary: Update SolrCLI to reflect cloud mode is default Key: SOLR-17674 URL: https://issues.apache.org/jira/browse/SOLR-17674 Project: Solr Issue Type: Sub-task Components: cli Affects Versions: main (10.0) Reporter: Eric Pugh -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-15546: ShortestPathStream to handle ids with colons. [solr]
epugh commented on PR #236: URL: https://github.com/apache/solr/pull/236#issuecomment-2661120724 I've tried to take a stab at this, and honestly I think I made this one worse.I think this is going to be one of those "someday if I need this, or a smarter person comes along with a fix, let's look at it again" issue.. Thoughts on adding a warning to the docs to the effect the id's can't have colons instead? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Payload Score Parser: expand documentation's pointing to Lucene javadocs [solr]
epugh commented on PR #2693: URL: https://github.com/apache/solr/pull/2693#issuecomment-2661120911 @cpoerschke if I can get a LGTM, I'll move forward with merging this! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[PR] Update and align UI module dependencies [solr]
malliaridis opened a new pull request, #3187: URL: https://github.com/apache/solr/pull/3187 # Description Some dependencies of the UI module are not properly aligned, others have useful updates that can be applied. # Solution This PR does 3 things related to the UI module dependencies: - Update dependencies of the UI module, including Kotlin (to 2.1.10) - Align dependency versions by including the platform module in commonMain - Use CIO engine (new in Ktor 3.1.0) in `wasmJs` (so all supported targets now) I've updated the dependencies together because some of them are related or had only patch updates. - Closes #3167 - Closes #3174 - Closes #3178 # Tests _No tests have been altered._ # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [ ] I have created a Jira issue and added the issue ID to my pull request title. - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation) - [x] I have developed this patch against the `main` branch. - [ ] I have run `./gradlew check`. - [ ] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17671 Replication and Backup use an unwrapped Directory. [solr]
bruno-roustant commented on code in PR #3185:
URL: https://github.com/apache/solr/pull/3185#discussion_r1957082788
##
solr/core/src/java/org/apache/solr/core/DirectoryFactory.java:
##
@@ -55,10 +55,16 @@ public abstract class DirectoryFactory implements
NamedListInitializedPlugin, Cl
// Absolute.
protected Path dataHomePath;
- // hint about what the directory contains - default is index directory
+ /** Hint about what the directory contains or what the directory will be
used for. */
public enum DirContext {
+/** Default is index directory. */
DEFAULT,
-META_DATA
+/** Directory containing metadata. */
+META_DATA,
+/** Directory used to copy raw files during replication. */
+REPLICATE,
+/** Directory used to copy raw files during backup. */
+BACKUP,
Review Comment:
Actually this very same question was discussed when I introduced
DelegatingBackupRepository. During backup, two different checksums are verified:
- The Lucene format checksum, to verify the file to backup is not corrupted.
This checksum can only be verified cleartext, so for encryption this means it
is verified by the EncryptionDirectory after decrypting.
- The file transfer checksum, to verify the bytes are identical at the
beginning and at the end of the copy. This checksum is verified by
IncrementalShardBackup, and can be verified on either raw or filtered bytes.
Currently it is on filtered bytes.
I specifically asked if we could skip the Lucene checksum verification in
the case of encryption. But since we want to ensure we do not backup a
corrupted file (which could replace an older valid one), then we have to check
the cleartext bytes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Exclude Kotlin multiplatform tests on -x test [solr]
malliaridis commented on PR #3184: URL: https://github.com/apache/solr/pull/3184#issuecomment-2660860918 @HoustonPutman thanks for the links, very insightful. > We'd have to make those lines, and the other two for desktop and browser, configurable. Not sure what you mean by configurable here. The only alternative to this workaround I could think of is to replace `check -x test` with a custom task for selectively running only the checks we want. But since `gradlew check -x test` is frequently used by devs, it would have some larger impact. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Exclude Kotlin multiplatform tests on -x test [solr]
dsmiley commented on PR #3184: URL: https://github.com/apache/solr/pull/3184#issuecomment-2660938071 Ideally we submit an issue to get JetBrains to fix this and they do it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17671 Replication and Backup use an unwrapped Directory. [solr]
dsmiley commented on code in PR #3185:
URL: https://github.com/apache/solr/pull/3185#discussion_r1957129435
##
solr/core/src/java/org/apache/solr/handler/admin/api/ReplicationAPIBase.java:
##
@@ -246,6 +242,21 @@ protected FileListResponse getFileList(long generation,
ReplicationHandler repli
return filesResponse;
}
+ private Directory getDirectory() throws IOException {
+return solrCore
+.getDirectoryFactory()
+.get(
+solrCore.getNewIndexDir(),
+DirectoryFactory.DirContext.DEFAULT,
Review Comment:
And here; wouldn't we use REPLICATION?
##
solr/core/src/java/org/apache/solr/core/DirectoryFactory.java:
##
@@ -55,10 +55,16 @@ public abstract class DirectoryFactory implements
NamedListInitializedPlugin, Cl
// Absolute.
protected Path dataHomePath;
- // hint about what the directory contains - default is index directory
+ /** Hint about what the directory contains or what the directory will be
used for. */
public enum DirContext {
+/** Default is index directory. */
DEFAULT,
-META_DATA
+/** Directory containing metadata. */
+META_DATA,
+/** Directory used to copy raw files during replication. */
+REPLICATE,
+/** Directory used to copy raw files during backup. */
+BACKUP,
Review Comment:
Okay. I see changing the Lucene checksum to be of the raw bytes appears
impossible because that checksum is not the responsibility of the Directory (if
it was we could tweak it). Instead, most Lucene coded stuff writes it via
CodecUtil.writeFooter
##
solr/core/src/java/org/apache/solr/handler/IncrementalShardBackup.java:
##
@@ -145,21 +145,22 @@ protected IncrementalShardSnapshotResponse backup(final
IndexCommit indexCommit)
details.startTime = Instant.now().toString();
Collection files = indexCommit.getFileNames();
+DirectoryFactory directoryFactory = solrCore.getDirectoryFactory();
Directory dir =
-solrCore
-.getDirectoryFactory()
-.get(
-solrCore.getIndexDir(),
-DirectoryFactory.DirContext.DEFAULT,
-solrCore.getSolrConfig().indexConfig.lockType);
+directoryFactory.get(
+solrCore.getIndexDir(),
+DirectoryFactory.DirContext.DEFAULT,
Review Comment:
Wouldn't we use BACKUP even if we're not sure if the DirectoryFactory is
going to do something based on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17671 Replication and Backup use an unwrapped Directory. [solr]
bruno-roustant commented on PR #3185: URL: https://github.com/apache/solr/pull/3185#issuecomment-2660928987 This new commit makes the PR work. I added DirectoryFactory.unwrapFor(Directory, DirUseContext) method, with a context to potentially differentiate replication and backup. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17671 Replication and Backup use an unwrapped Directory. [solr]
dsmiley commented on PR #3185: URL: https://github.com/apache/solr/pull/3185#issuecomment-2661224062 (A) seems kinda hard due to various entanglements that seem to assume one cache entry per path or other complexities I see there. At least (B) would actually only need to wrap dirs that are not DEFAULT. Also, the word "unwrap" pre-supposes an implementation detail that the callers should ideally not be exposed to and isn't necessarily accurate. Maybe it'll wrap not unwrap or do both or something new; who knows. Solr code using this should just give this DirContext hint as to what the dir will be used for. That's how it is now, albeit we see a bug and the use-cases (DirContext) listed are insufficient. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17609: Remove HDFS module [solr]
dsmiley commented on code in PR #2923: URL: https://github.com/apache/solr/pull/2923#discussion_r1957236372 ## solr/modules/hdfs/src/java/org/apache/solr/hdfs/store/blockcache/package-info.java: ## Review Comment: Thanks. Interestingly the package it used to live in was org.apache.solr.store.blockcache but that "store" package doesn't have anything else nowadays so I guess blockcache at a kind of top level of Solr packages is fine. The ideal home for this is actually Lucene but I wouldn't want to donate something until it's used. Well it has been used and still is via Solr 9. Hmm. @markrmiller would you be interested in donating it given your hard work on it? I propose updating the javadocs for the package to be what I said above "A generic ". You wrote "A blockcache implementation" and that's self-referential so not helpful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17669: Reduce Memory Consumption by 80-90% when using Dynamic fields (DocumentObjectBinder) [solr]
dsmiley commented on PR #3179: URL: https://github.com/apache/solr/pull/3179#issuecomment-2661233098 Yes Pattern is fine (as it was). I hope this is tested, but I suppose maybe it isn't if tests pass without the middle wildcard. Can you please add a test? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17671 Replication and Backup use an unwrapped Directory. [solr]
bruno-roustant commented on PR #3185: URL: https://github.com/apache/solr/pull/3185#issuecomment-2661020011 As I see it, the need to unwrap is based on what the caller will use the Directory for. So Im' not sure putting a lot of logic in CachingDirectory in the best solution. Maybe the option B you propose is ok, or we could simply change the ReplicationAPIBase to always unwrap since it copies without Lucene checksum. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Payload Score Parser: expand documentation's pointing to Lucene javadocs [solr]
epugh commented on PR #2693: URL: https://github.com/apache/solr/pull/2693#issuecomment-2661091811 I think I figured out how to add the Lucene `queries` module to the local Javadocs. I had to manually edit the lockfiles... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17618: Add unit tests for org.apache.solr.util.TimeOut [solr]
epugh closed pull request #3026: SOLR-17618: Add unit tests for org.apache.solr.util.TimeOut URL: https://github.com/apache/solr/pull/3026 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17618: Add unit tests for org.apache.solr.util.TimeOut [solr]
sandbergja commented on PR #3026: URL: https://github.com/apache/solr/pull/3026#issuecomment-2661201387 Thanks, @epugh (and everyone else who helped me with this)! It looks like #3173 added tests that exercise all the methods exercised in this PR, so I don't think this PR adds much value. I'm tempted to close this one, and find something else to work on instead. :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17618: Add unit tests for org.apache.solr.util.TimeOut [solr]
epugh commented on PR #3026: URL: https://github.com/apache/solr/pull/3026#issuecomment-2661202254 Sure... I'll close it then, however I would love to see more commits. Speak up if you are looking for ideas.. especially on the d...@solr.apache.org mailing list. Or in Slack. Or any where ;-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
