Re: [PR] SOLR-14985 Address perf issues to switch CloudSolrClient to HttpCluste… [solr]
luiseterc commented on PR #2571: URL: https://github.com/apache/solr/pull/2571#issuecomment-2306678676 Thanks @janhoy We'll do that -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[I] [Regression] security.json is not uploaded during the first initialization of SolrCloud [solr-operator]
erwanval opened a new issue, #720: URL: https://github.com/apache/solr-operator/issues/720 This is a regression caused by [#660](https://github.com/apache/solr-operator/pull/660). During the first initialization of SolrCloud, the security.json doesn't exists in Zookeeper, which cause an exception during the ```setup-zk``` initContainer [zkcli.sh command](https://github.com/apache/solr-operator/blob/main/controllers/util/solr_security_util.go#L241) With the change introduced in above PR, when there is an error, it now completely skip the upload. Then the SolR just starts with no security.json at all. It seems an empty one is created during the main container initialization, so upon manual restart, ```setup-zk``` run as expected and the real security.json is uploaded. I'm not sure how to solve this while retaining the reason why this change has been introduced in the first place. Maybe the ```zkcli.sh``` could return a different error code depending on the kind of exception it encounters (missing security.json, or everything else)? ```setup-zk``` logs during first init: ERROR: KeeperErrorCode = NoNode for /solr/solr Creating ZooKeeper path /solr/solr on ZooKeeper at zookeeper.solr.svc:2181 INFO - 2024-08-23 08:25:26.748; org.apache.solr.common.cloud.ConnectionManager; Waiting for client to connect to ZooKeeper INFO - 2024-08-23 08:25:26.786; org.apache.solr.common.cloud.ConnectionManager; zkClient has connected INFO - 2024-08-23 08:25:26.786; org.apache.solr.common.cloud.ConnectionManager; Client is connected to ZooKeeper Exception in thread "main" org.apache.zookeeper.KeeperException$NoNodeException: KeeperErrorCode = NoNode for /security.json at org.apache.zookeeper.KeeperException.create(KeeperException.java:118) at org.apache.zookeeper.KeeperException.create(KeeperException.java:54) at org.apache.zookeeper.ZooKeeper.getData(ZooKeeper.java:2358) at org.apache.solr.common.cloud.SolrZkClient.lambda$getData$6(SolrZkClient.java:349) at org.apache.solr.common.cloud.ZkCmdExecutor.retryOperation(ZkCmdExecutor.java:79) at org.apache.solr.common.cloud.SolrZkClient.getData(SolrZkClient.java:349) at org.apache.solr.cloud.ZkCLI.main(ZkCLI.java:328) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17400: remove deprecated snapshot related code [solr]
epugh merged PR #2659: URL: https://github.com/apache/solr/pull/2659 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Resolved] (SOLR-17400) Remove deprecated snapshotscli.sh from main
[ https://issues.apache.org/jira/browse/SOLR-17400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh resolved SOLR-17400. -- Resolution: Fixed > Remove deprecated snapshotscli.sh from main > --- > > Key: SOLR-17400 > URL: https://issues.apache.org/jira/browse/SOLR-17400 > Project: Solr > Issue Type: Sub-task > Components: cli >Affects Versions: main (10.0) >Reporter: Eric Pugh >Assignee: Eric Pugh >Priority: Minor > Labels: pull-request-available > Fix For: main (10.0) > > Time Spent: 0.5h > Remaining Estimate: 0h > > Post SOLR-17180 being completed, remove deprecated code from 10.x -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-17400) Remove deprecated snapshotscli.sh from main
[ https://issues.apache.org/jira/browse/SOLR-17400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876240#comment-17876240 ] ASF subversion and git services commented on SOLR-17400: Commit 46f1bdf208e12f17a9787c0b49e593c3310d08c8 in solr's branch refs/heads/main from Eric Pugh [ https://gitbox.apache.org/repos/asf?p=solr.git;h=46f1bdf208e ] SOLR-17400: remove deprecated snapshot related code (#2659) bin/solr snapshot-* covers core snapshot commands and modules/hdfs/bin/prepare-snapshot-export.sh is the Solr on HDFS specific script. > Remove deprecated snapshotscli.sh from main > --- > > Key: SOLR-17400 > URL: https://issues.apache.org/jira/browse/SOLR-17400 > Project: Solr > Issue Type: Sub-task > Components: cli >Affects Versions: main (10.0) >Reporter: Eric Pugh >Assignee: Eric Pugh >Priority: Minor > Labels: pull-request-available > Fix For: main (10.0) > > Time Spent: 0.5h > Remaining Estimate: 0h > > Post SOLR-17180 being completed, remove deprecated code from 10.x -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Review SolrJ code for typos [solr]
epugh commented on code in PR #2656:
URL: https://github.com/apache/solr/pull/2656#discussion_r1728881870
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrClientBase.java:
##
@@ -121,7 +121,7 @@ protected ResponseParser responseParser(SolrRequest
solrRequest) {
return solrRequest.getResponseParser() == null ? this.parser :
solrRequest.getResponseParser();
}
- protected ModifiableSolrParams initalizeSolrParams(
+ protected ModifiableSolrParams initializeSolrParams(
Review Comment:
okay, in looking I see how you did it...! All makes sense.. We need a
plan for removing deprecated code in `main` anyway, there is so much of it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Review SolrJ code for typos [solr]
epugh merged PR #2656: URL: https://github.com/apache/solr/pull/2656 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17406: Introduce Version Catalogs [solr]
dweiss commented on PR #2646: URL: https://github.com/apache/solr/pull/2646#issuecomment-2306992445 I would keep any upgrades from infrastructure changes separate. You can then diff/ compare the final artifacts and see what's changed before doing any updates. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Review Solr Streaming code for typos [solr]
epugh commented on code in PR #2657:
URL: https://github.com/apache/solr/pull/2657#discussion_r1728897327
##
solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/eval/Matrix.java:
##
@@ -61,8 +61,8 @@ public List getRowLabels() {
return rowLabels;
}
- public void setRowLabels(List rowLables) {
-this.rowLabels = rowLables;
+ public void setRowLabels(List rowLabels) {
Review Comment:
this one is okay because we only change the parameter name, not the method
signature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Review Solr Streaming code for typos [solr]
epugh commented on PR #2657: URL: https://github.com/apache/solr/pull/2657#issuecomment-2307002076 This is ready for review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] [Branch_9x] Bump up gradle analyze dependency to 1.10.0 [solr]
iamsanjay merged PR #2660: URL: https://github.com/apache/solr/pull/2660 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-17321) Bump minimum required Java version to 21
[ https://issues.apache.org/jira/browse/SOLR-17321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876259#comment-17876259 ] ASF subversion and git services commented on SOLR-17321: Commit fed2f146220284c712c0a61d05dc9c1db48d641c in solr's branch refs/heads/branch_9x from Sanjay Dutt [ https://gitbox.apache.org/repos/asf?p=solr.git;h=fed2f146220 ] [Branch_9x] Bump up gradle analyze dependency to 1.10.0 (#2660) * Upgrades the ca.cutterslade.analyze version to 1.10.0 to facilitate the ongoing Java upgrade (SOLR-17321) (cherry picked from commit 3deb0a44402625fff140876b14b67f781c49adb0) > Bump minimum required Java version to 21 > > > Key: SOLR-17321 > URL: https://issues.apache.org/jira/browse/SOLR-17321 > Project: Solr > Issue Type: Task > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Sanjay Dutt >Priority: Major > Labels: pull-request-available > Time Spent: 10h 40m > Remaining Estimate: 0h > > We are upgrading the minimum Java version for Solr main branch to 21. > However, at the same, It has been suggested to be not so aggressive with > SolrJ (and thus solr-api, a dependency) Java version – setting it to 17. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17399: Replace the use of the deprecated java.util.Locale ctor [solr]
iamsanjay merged PR #2633: URL: https://github.com/apache/solr/pull/2633 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-17399) Replace the use of the deprecated java.util.Locale constructor with Locale Builder API
[
https://issues.apache.org/jira/browse/SOLR-17399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876268#comment-17876268
]
ASF subversion and git services commented on SOLR-17399:
Commit ca2487601723c9391ef763fe77e2f06107ff46cf in solr's branch
refs/heads/main from Sanjay Dutt
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=ca248760172 ]
SOLR-17399: Replace the use of the deprecated java.util.Locale constructor with
Locale Builder API (#2633)
> Replace the use of the deprecated java.util.Locale constructor with Locale
> Builder API
> --
>
> Key: SOLR-17399
> URL: https://issues.apache.org/jira/browse/SOLR-17399
> Project: Solr
> Issue Type: Task
> Security Level: Public(Default Security Level. Issues are Public)
>Affects Versions: 9.8
>Reporter: Sanjay Dutt
>Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Replace the usage of {{Locale}} constructors with the {{Locale.Builder}} API,
> as we are upgrading to Java 21 where {{Locale}} constructors are deprecated
> starting from JDK 19. This change is motivated by the discussion in
> [https://github.com/apache/lucene/pull/12761]
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17406: Introduce Version Catalogs [solr]
malliaridis commented on PR #2646: URL: https://github.com/apache/solr/pull/2646#issuecomment-2307147732 Yeah I agree. I already started the process of splitting the PR into two, one for infra and one for the dependency updates. I am facing a few version differences with non-conflicting dependencies that belong to the same group (e.g. grpc dependencies). I may have to introduce new BOMs if available to properly sync the versions across all artifacts of the same group. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17399: Replace the use of the deprecated java.util.Locale ctor [solr]
iamsanjay commented on PR #2633: URL: https://github.com/apache/solr/pull/2633#issuecomment-2307158372 I was preparing it for backporting and before merge it to 9.x, ran the check on crave. One test case failed! ``` ERROR: The following test(s) have failed: - org.apache.solr.client.solrj.impl.ClusterStateProviderTest.testGetClusterState (:solr:solrj) Test history: https://ge.apache.org/scans/tests?search.rootProjectNames=solr-root&tests.container=org.apache.solr.client.solrj.impl.ClusterStateProviderTest&tests.test=testGetClusterState http://fucit.org/solr-jenkins-reports/history-trend-of-recent-failures.html#series/org.apache.solr.client.solrj.impl.ClusterStateProviderTest.testGetClusterState Test output: /tmp/src/solr/solr/solrj/build/test-results/test/outputs/OUTPUT-org.apache.solr.client.solrj.impl.ClusterStateProviderTest.txt Reproduce with: ./gradlew :solr:solrj:test --tests "org.apache.solr.client.solrj.impl.ClusterStateProviderTest.testGetClusterState" -Ptests.jvms=96 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:+UseParallelGC -XX:ActiveProcessorCount=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=33F6364CB7D4507A -Ptests.timeoutSuite=60! -Ptests.file.encoding=ISO-8859-1 ``` Now I am not able to find failure for this particular test case, however the class started failing recently, 18th Aug, as can be seen in the test history as well. https://github.com/user-attachments/assets/54797660-44a8-45b2-8a2b-512e782e447f";> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17399: Replace the use of the deprecated java.util.Locale ctor [solr]
iamsanjay commented on PR #2633: URL: https://github.com/apache/solr/pull/2633#issuecomment-2307199250 git bisect points to 7af8b82db2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17381: Make CLUSTERSTATUS configurable [solr]
iamsanjay commented on PR #2599: URL: https://github.com/apache/solr/pull/2599#issuecomment-2307201061 git bisect points to this commit! ``` ERROR: The following test(s) have failed: - org.apache.solr.client.solrj.impl.ClusterStateProviderTest.testGetClusterState (:solr:solrj) Test history: https://ge.apache.org/scans/tests?search.rootProjectNames=solr-root&tests.container=org.apache.solr.client.solrj.impl.ClusterStateProviderTest&tests.test=testGetClusterState http://fucit.org/solr-jenkins-reports/history-trend-of-recent-failures.html#series/org.apache.solr.client.solrj.impl.ClusterStateProviderTest.testGetClusterState Test output: /tmp/src/solr/solr/solrj/build/test-results/test/outputs/OUTPUT-org.apache.solr.client.solrj.impl.ClusterStateProviderTest.txt Reproduce with: ./gradlew :solr:solrj:test --tests "org.apache.solr.client.solrj.impl.ClusterStateProviderTest.testGetClusterState" -Ptests.jvms=96 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:+UseParallelGC -XX:ActiveProcessorCount=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=33F6364CB7D4507A -Ptests.timeoutSuite=60! -Ptests.file.encoding=ISO-8859-1 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-17399) Replace the use of the deprecated java.util.Locale constructor with Locale Builder API
[
https://issues.apache.org/jira/browse/SOLR-17399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876278#comment-17876278
]
ASF subversion and git services commented on SOLR-17399:
Commit 475bded5acb22649c37784051d4f21a54cc07905 in solr's branch
refs/heads/branch_9x from Sanjay Dutt
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=475bded5acb ]
SOLR-17399: Replace the use of the deprecated java.util.Locale constructor with
Locale Builder API (#2633)
(cherry picked from commit ca2487601723c9391ef763fe77e2f06107ff46cf)
> Replace the use of the deprecated java.util.Locale constructor with Locale
> Builder API
> --
>
> Key: SOLR-17399
> URL: https://issues.apache.org/jira/browse/SOLR-17399
> Project: Solr
> Issue Type: Task
> Security Level: Public(Default Security Level. Issues are Public)
>Affects Versions: 9.8
>Reporter: Sanjay Dutt
>Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Replace the usage of {{Locale}} constructors with the {{Locale.Builder}} API,
> as we are upgrading to Java 21 where {{Locale}} constructors are deprecated
> starting from JDK 19. This change is motivated by the discussion in
> [https://github.com/apache/lucene/pull/12761]
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17399: Replace the use of the deprecated java.util.Locale ctor [solr]
iamsanjay commented on PR #2633: URL: https://github.com/apache/solr/pull/2633#issuecomment-2307216717 Backported to 9.x! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Created] (SOLR-17421) With overseer node role enabled, overseer may be stopped without giving-up leadership
Pierre Salagnac created SOLR-17421:
--
Summary: With overseer node role enabled, overseer may be stopped
without giving-up leadership
Key: SOLR-17421
URL: https://issues.apache.org/jira/browse/SOLR-17421
Project: Solr
Issue Type: Bug
Security Level: Public (Default Security Level. Issues are Public)
Affects Versions: 9.6, 8.11
Reporter: Pierre Salagnac
Overseer may retain the leadership status while the thread pool that is
supposed to consume the collection state mutator queue was already shut down.
Occurrences of this but are probably not frequent. But when it happens, it has
a huge impact. The overseer cluster state updater is stuck and all collection
admin requests are very likely to fail. Because of the stuck overseer, all the
enqueued operations (collection creation, deletion...) fail and remain in the
collection API queue.
h2. Root cause
Root cause is the {{QUIT}} command does not cancel overseer election if any
error happens while shutting down the state updater thread pool.
{code:java}
level: ERROR
logger: org.apache.solr.cloud.Overseer
message: Overseer could not process the current clusterstate state update
message, skipping the message: {
"operation":"quit",
"id":"72073405485023239-_solr-n_000948"}
node_name: :8983_solr
threadId: 281272
threadName: OverseerStateUpdate-72073405485023239-_solr-n_000948
thrown: java.lang.RuntimeException: Timeout waiting for pool
org.apache.solr.common.util.ExecutorUtil$MDCAwareThreadPoolExecutor@2c1da18d[Shutting
down, pool size = 1, active threads = 1, queued tasks = 0, completed tasks =
0] to shutdown.
at
org.apache.solr.common.util.ExecutorUtil.awaitTermination(ExecutorUtil.java:142)
at
org.apache.solr.common.util.ExecutorUtil.awaitTermination(ExecutorUtil.java:129)
at
org.apache.solr.common.util.ExecutorUtil.shutdownAndAwaitTermination(ExecutorUtil.java:112)
at
org.apache.solr.cloud.OverseerTaskProcessor.close(OverseerTaskProcessor.java:431)
at
org.apache.solr.cloud.Overseer$ClusterStateUpdater.processMessage(Overseer.java:601)
at
org.apache.solr.cloud.Overseer$ClusterStateUpdater.processQueueItem(Overseer.java:450)
at org.apache.solr.cloud.Overseer$ClusterStateUpdater.run(Overseer.java:377)
at java.base/java.lang.Thread.run(Thread.java:1583)
{code}
h2. Proximate cause
It seems to me long running operations in the collection API could trigger the
bug more frequently. Because of a long running operation, we get an exception
when shutting down the thread pool. This has a 60 seconds timeout.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17321: Bump minimum required Java version to 21 [solr]
iamsanjay closed pull request #2497: SOLR-17321: Bump minimum required Java version to 21 URL: https://github.com/apache/solr/pull/2497 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Review Solr Streaming code for typos [solr]
cpoerschke commented on code in PR #2657:
URL: https://github.com/apache/solr/pull/2657#discussion_r1729208565
##
solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/eval/NotNullEvaluator.java:
##
@@ -45,7 +45,7 @@ public Object doWork(Object... values) throws IOException {
}
if (values[0] instanceof String) {
- // Check to see if the this tuple had a null value for that string.
+ // Check to see if this tuple had a null value for that string.
Review Comment:
```suggestion
// Check to see if this tuple had a null value for that string.
```
##
solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/eval/OutliersEvaluator.java:
##
@@ -97,13 +97,13 @@ public Object doWork(Object... values) throws IOException {
double cumProb = d.cumulativeProbability(n.intValue());
if (low >= 0 && cumProb <= low) {
t.put("lowOutlierValue_d", n);
- t.put("cumulativeProbablity_d", cumProb);
+ t.put("cumulativeProbability_d", cumProb);
Review Comment:
Wondering if this is "user facing" i.e. change in input or output 'contract'
of the evaluator?
##
solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/stream/BiJoinStream.java:
##
@@ -28,8 +28,8 @@
import org.apache.solr.client.solrj.io.stream.expr.StreamFactory;
/**
- * Joins leftStream with rightStream based on a Equalitor. Both streams must
be sorted by the fields
- * being joined on. Resulting stream is sorted by the equalitor.
+ * Joins leftStream with rightStream based on an Equalitor. Both streams must
be sorted by the
Review Comment:
```suggestion
* Joins leftStream with rightStream based on an {@link StreamEqualitor}.
Both streams must be sorted by the
```
##
solr/solrj-streaming/src/test/org/apache/solr/client/solrj/io/stream/StreamingTest.java:
##
@@ -1348,7 +1348,7 @@ private void checkReturnValsForEmpty(String[] fields)
throws IOException {
}
}
- // Goes away after after LUCENE-7548
+ // Goes away after LUCENE-7548
Review Comment:
```suggestion
// Goes away after LUCENE-7548 a.k.a.
https://github.com/apache/lucene/issues/8599
```
##
solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/stream/CartesianProductStream.java:
##
@@ -277,7 +277,8 @@ private Deque generateTupleList(Tuple original)
throws IOException {
private boolean iterate(
List evaluators, int[] indexes, Map
evaluatedValues) {
-// this assumes evaluators and indexes are the same length, which is ok
cause we created it so
+// this assumes evaluators and indexes are the same length, which is ok
because we created it,
+// so
// we know it is
Review Comment:
```suggestion
// so we know it is
```
##
solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/stream/MergeStream.java:
##
@@ -224,7 +224,7 @@ public Tuple read() throws IOException {
// If all EOF then min will be null, else min is the current minimum
if (null == minimum) {
- // return EOF, doesn't matter which cause we're done
+ // return EOF, doesn't matter which because we're done
Review Comment:
not sure if this comment actually contradicts the code? maybe leave as-is or
remove.
##
solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/stream/HashJoinStream.java:
##
@@ -55,7 +55,7 @@ public class HashJoinStream extends TupleStream implements
Expressible {
protected Tuple workingFullTuple = null;
protected String workingFullHash = null;
- protected int workngHashSetIdx = 0;
+ protected int workingHashSetIdx = 0;
Review Comment:
observation: deriving classes referencing the class member will get build
failure (or weirdness if deploying X.Y custom jar with X.Y+1 base jar)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-7871) Platform independent config file instead of solr.in.sh and solr.in.cmd
[
https://issues.apache.org/jira/browse/SOLR-7871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876316#comment-17876316
]
Jan Høydahl commented on SOLR-7871:
---
Lots of stuff happened since last activity on this JIRA.
What this issue was really about is establishing a new environment config file
to replace solr.in.sh and solr.in.cmd.
I no longer think it is a good idea to supply an auto migration mechanism, gets
too complex.
Perhaps there is not enough demand for this 9 year old feature suggestion. I
won't pick it up anytime soon.
> Platform independent config file instead of solr.in.sh and solr.in.cmd
> --
>
> Key: SOLR-7871
> URL: https://issues.apache.org/jira/browse/SOLR-7871
> Project: Solr
> Issue Type: Improvement
> Components: scripts and tools
>Affects Versions: 5.2.1
>Reporter: Jan Høydahl
>Priority: Major
> Labels: bin/solr
> Attachments: SOLR-7871.patch, SOLR-7871.patch, SOLR-7871.patch,
> SOLR-7871.patch, SOLR-7871.patch, SOLR-7871.patch, SOLR-7871.patch,
> SOLR-7871.patch, SOLR-7871.patch, SOLR-7871.patch, SOLR-7871.patch,
> SOLR-7871.patch, SOLR-7871.patch, SOLR-7871.patch, SOLR-7871.patch
>
>
> Spinoff from SOLR-7043
> The config files {{solr.in.sh}} and {{solr.in.cmd}} are currently executable
> batch files, but all they do is to set environment variables for the start
> scripts on the format {{key=value}}
> Suggest to instead have one central platform independent config file e.g.
> {{bin/solr.yml}} or {{bin/solrstart.properties}} which is parsed by
> {{SolrCLI.java}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Review Solr Streaming code for typos [solr]
epugh commented on code in PR #2657:
URL: https://github.com/apache/solr/pull/2657#discussion_r1729254232
##
solr/solrj-streaming/src/test/org/apache/solr/client/solrj/io/stream/StreamingTest.java:
##
@@ -1348,7 +1348,7 @@ private void checkReturnValsForEmpty(String[] fields)
throws IOException {
}
}
- // Goes away after after LUCENE-7548
+ // Goes away after LUCENE-7548
Review Comment:
interesting... I wonder.. Do we have a lot of `LUCENE-` references?
I wonder if we should have a new ticket to fix ALL of them? I could also see
us replacing it with just the url?
```
// Goes away after https://github.com/apache/lucene/issues/8599
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Review Solr Streaming code for typos [solr]
epugh commented on code in PR #2657:
URL: https://github.com/apache/solr/pull/2657#discussion_r1729255006
##
solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/stream/MergeStream.java:
##
@@ -224,7 +224,7 @@ public Tuple read() throws IOException {
// If all EOF then min will be null, else min is the current minimum
if (null == minimum) {
- // return EOF, doesn't matter which cause we're done
+ // return EOF, doesn't matter which because we're done
Review Comment:
humm... if we aren't sure what the comment means, then no one else with,
and I can see removing it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Review Solr Streaming code for typos [solr]
epugh commented on code in PR #2657:
URL: https://github.com/apache/solr/pull/2657#discussion_r1729256408
##
solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/stream/HashJoinStream.java:
##
@@ -55,7 +55,7 @@ public class HashJoinStream extends TupleStream implements
Expressible {
protected Tuple workingFullTuple = null;
protected String workingFullHash = null;
- protected int workngHashSetIdx = 0;
+ protected int workingHashSetIdx = 0;
Review Comment:
this would be a good thing right? that way they know to fix their bug
right! I don't really want to spend a ton of effort on this deprecation for
some code that I don't know has many users or has a logical easy way to emit
deprecations etc...Unless we just deprecate in the java code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Review Solr Streaming code for typos [solr]
epugh commented on code in PR #2657:
URL: https://github.com/apache/solr/pull/2657#discussion_r1729257930
##
solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/eval/OutliersEvaluator.java:
##
@@ -97,13 +97,13 @@ public Object doWork(Object... values) throws IOException {
double cumProb = d.cumulativeProbability(n.intValue());
if (low >= 0 && cumProb <= low) {
t.put("lowOutlierValue_d", n);
- t.put("cumulativeProbablity_d", cumProb);
+ t.put("cumulativeProbability_d", cumProb);
Review Comment:
I was kind of hoping that since I fixed it in hte unit test, that it would
be okay. I will says, this code, i don't know how to deprecate it and fix it
in a "smooth" manner...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
[PR] remove use of deprecated SolrIndexSearcher.search variant [solr]
cpoerschke opened a new pull request, #2662: URL: https://github.com/apache/solr/pull/2662 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Refactor: QueryResult: don't provide to SolrIndexSearcher [solr]
cpoerschke commented on code in PR #2524:
URL: https://github.com/apache/solr/pull/2524#discussion_r1729272808
##
solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java:
##
@@ -716,6 +716,12 @@ public boolean regenerateItem(
}
}
+ /** Primary entrypoint for searching, using a {@link QueryCommand}. */
+ public QueryResult search(QueryCommand cmd) throws IOException {
+return search(new QueryResult(), cmd);
+ }
+
+ @Deprecated
Review Comment:
#2662 to remove use of this API variant
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] remove use of deprecated SolrIndexSearcher.search variant [solr]
cpoerschke commented on PR #2662: URL: https://github.com/apache/solr/pull/2662#issuecomment-2307492804 https://github.com/apache/solr/actions/runs/10529517119/job/29177462369?pr=2662 CI failure seems unrelated ``` ./gradlew :solr:core:test --tests "org.apache.solr.cloud.api.collections.LocalFSCloudIncrementalBackupTest.testSkipConfigset" -Ptests.jvms=96 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:+UseParallelGC -XX:ActiveProcessorCount=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=92C1489090FDEECD -Ptests.timeoutSuite=60! -Ptests.file.encoding=US-ASCII ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] remove use of deprecated SolrIndexSearcher.search variant [solr]
epugh commented on PR #2662: URL: https://github.com/apache/solr/pull/2662#issuecomment-2307495270 Will we be able to remove the deprecated `QueryResult search(QueryResult qr, QueryCommand cmd)` method in `main`? Do we every label something Deprecated but don't mean to remove it for a long period of time? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[PR] SOLR-17421: Make sure overseer drops leadership after QUIT failure [solr]
psalagnac opened a new pull request, #2663: URL: https://github.com/apache/solr/pull/2663 https://issues.apache.org/jira/browse/SOLR-17421 # Description Overseer might be stop after a failure of the `QUIT` operation if we don't give up on leadership (see Jira). At least, this happens if we get a timeout error when closing the thread pool for cluster state updater (there might be other scenarios). # Solution Catch the exception to make sure we don't stop with a half finished `QUIT` command. # Tests Unfortunately, I can't easily reproduce with a test. # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation) - [x] I have developed this patch against the `main` branch. - [x] I have run `./gradlew check`. - [ ] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[PR] support Lucene's (proposed) HNSW search seeding feature [solr]
cpoerschke opened a new pull request, #2664: URL: https://github.com/apache/solr/pull/2664 See https://github.com/apache/lucene/issues/13634 issue and @seanmacavaney's https://github.com/apache/lucene/pull/13635 draft for context. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Updated] (SOLR-17421) With overseer node role enabled, overseer may be stopped without giving-up leadership
[
https://issues.apache.org/jira/browse/SOLR-17421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated SOLR-17421:
--
Labels: pull-request-available (was: )
> With overseer node role enabled, overseer may be stopped without giving-up
> leadership
> -
>
> Key: SOLR-17421
> URL: https://issues.apache.org/jira/browse/SOLR-17421
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
>Affects Versions: 8.11, 9.6
>Reporter: Pierre Salagnac
>Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Overseer may retain the leadership status while the thread pool that is
> supposed to consume the collection state mutator queue was already shut down.
> Occurrences of this but are probably not frequent. But when it happens, it
> has a huge impact. The overseer cluster state updater is stuck and all
> collection admin requests are very likely to fail. Because of the stuck
> overseer, all the enqueued operations (collection creation, deletion...) fail
> and remain in the collection API queue.
> h2. Root cause
> Root cause is the {{QUIT}} command does not cancel overseer election if any
> error happens while shutting down the state updater thread pool.
> {code:java}
> level: ERROR
> logger: org.apache.solr.cloud.Overseer
> message: Overseer could not process the current clusterstate state
> update message, skipping the message: {
> "operation":"quit",
> "id":"72073405485023239-_solr-n_000948"}
> node_name: :8983_solr
> threadId: 281272
> threadName:
> OverseerStateUpdate-72073405485023239-_solr-n_000948
> thrown: java.lang.RuntimeException: Timeout waiting for pool
> org.apache.solr.common.util.ExecutorUtil$MDCAwareThreadPoolExecutor@2c1da18d[Shutting
> down, pool size = 1, active threads = 1, queued tasks = 0, completed tasks =
> 0] to shutdown.
> at
> org.apache.solr.common.util.ExecutorUtil.awaitTermination(ExecutorUtil.java:142)
> at
> org.apache.solr.common.util.ExecutorUtil.awaitTermination(ExecutorUtil.java:129)
> at
> org.apache.solr.common.util.ExecutorUtil.shutdownAndAwaitTermination(ExecutorUtil.java:112)
> at
> org.apache.solr.cloud.OverseerTaskProcessor.close(OverseerTaskProcessor.java:431)
> at
> org.apache.solr.cloud.Overseer$ClusterStateUpdater.processMessage(Overseer.java:601)
> at
> org.apache.solr.cloud.Overseer$ClusterStateUpdater.processQueueItem(Overseer.java:450)
> at org.apache.solr.cloud.Overseer$ClusterStateUpdater.run(Overseer.java:377)
> at java.base/java.lang.Thread.run(Thread.java:1583)
> {code}
> h2. Proximate cause
> It seems to me long running operations in the collection API could trigger
> the bug more frequently. Because of a long running operation, we get an
> exception when shutting down the thread pool. This has a 60 seconds timeout.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Migrate from Gradle Enterprise Gradle Plugin to Develocity Gradle Plugin [solr]
dsmiley commented on PR #2642: URL: https://github.com/apache/solr/pull/2642#issuecomment-2307566750 Thanks Clay; I'll merge this tonight/tomorrow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-12429) ZK upconfig throws confusing error when it encounters a symlink
[
https://issues.apache.org/jira/browse/SOLR-12429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876347#comment-17876347
]
David Smiley commented on SOLR-12429:
-
Why block symlinks; shouldn't they be supported?
> ZK upconfig throws confusing error when it encounters a symlink
> ---
>
> Key: SOLR-12429
> URL: https://issues.apache.org/jira/browse/SOLR-12429
> Project: Solr
> Issue Type: Bug
> Components: SolrCLI
>Affects Versions: 7.3.1
>Reporter: Shawn Heisey
>Assignee: Eric Pugh
>Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> If a configset being uploaded to ZK contains a symlink pointing at a
> directory, an error is thrown, but it doesn't explain the real problem. The
> upconfig should detect symlinks and throw an error indicating that they
> aren't supported. If we can detect any other type of file that upconfig
> can't use (sockets, device files, etc), the error message should be relevant.
> {noformat}
> Exception in thread "main" java.io.IOException: File
> '/var/solr/mbs/artist/conf/common' exists but is a directory
> at org.apache.commons.io.FileUtils.openInputStream(FileUtils.java:286)
> at
> org.apache.commons.io.FileUtils.readFileToByteArray(FileUtils.java:1815)
> at
> org.apache.solr.common.cloud.SolrZkClient.makePath(SolrZkClient.java:391)
> at
> org.apache.solr.common.cloud.ZkMaintenanceUtils$1.visitFile(ZkMaintenanceUtils.java:305)
> at
> org.apache.solr.common.cloud.ZkMaintenanceUtils$1.visitFile(ZkMaintenanceUtils.java:291)
> at java.nio.file.Files.walkFileTree(Files.java:2670)
> at java.nio.file.Files.walkFileTree(Files.java:2742)
> at
> org.apache.solr.common.cloud.ZkMaintenanceUtils.uploadToZK(ZkMaintenanceUtils.java:291)
> at
> org.apache.solr.common.cloud.SolrZkClient.uploadToZK(SolrZkClient.java:793)
> at
> org.apache.solr.common.cloud.ZkConfigManager.uploadConfigDir(ZkConfigManager.java:78)
> at org.apache.solr.cloud.ZkCLI.main(ZkCLI.java:236)
> {noformat}
> I have not tested whether a symlink pointing at a file works, but I think
> that an error should be thrown for ANY symlink.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] remove deprecated (DocValues,Norms)FieldExistsQuery use [solr]
dsmiley commented on code in PR #2632:
URL: https://github.com/apache/solr/pull/2632#discussion_r1729408777
##
solr/core/src/java/org/apache/solr/search/facet/MissingAgg.java:
##
@@ -45,7 +45,7 @@ public SlotAcc createSlotAcc(FacetContext fcontext, long
numDocs, int numSlots)
if (sf.multiValued() || sf.getType().multiValuedFieldCache()) {
Query query = null;
if (sf.hasDocValues()) {
- query = new DocValuesFieldExistsQuery(sf.getName());
+ query = new FieldExistsQuery(sf.getName());
} else {
query = sf.getType().getRangeQuery(null, sf, null, null, false,
false);
}
Review Comment:
I suspect this code pre-dated FieldType.getExistenceQuery -- just call that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-12429: Prevent symbolic links from being uploaded as part of a configset [solr]
epugh commented on code in PR #2651:
URL: https://github.com/apache/solr/pull/2651#discussion_r1729415225
##
solr/core/src/java/org/apache/solr/util/FileTypeMagicUtil.java:
##
@@ -60,6 +60,14 @@ public static void assertConfigSetFolderLegal(Path confPath)
throws IOException
new SimpleFileVisitor<>() {
@Override
public FileVisitResult visitFile(Path file, BasicFileAttributes
attrs) {
+if (Files.isSymbolicLink(file)) {
Review Comment:
So, right now symbolic links don't work, they blow up with a cryptic error.
This PR replaces the cryptic error with a nicer error! I think your
suggestion is interesting, and if we wanted to support symbolic link lookup,
that sounds like a nice addition to do in a seperate PR that removes the
limitation. Does that sound reasonable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-12429: Prevent symbolic links from being uploaded as part of a configset [solr]
epugh commented on code in PR #2651:
URL: https://github.com/apache/solr/pull/2651#discussion_r1729415225
##
solr/core/src/java/org/apache/solr/util/FileTypeMagicUtil.java:
##
@@ -60,6 +60,14 @@ public static void assertConfigSetFolderLegal(Path confPath)
throws IOException
new SimpleFileVisitor<>() {
@Override
public FileVisitResult visitFile(Path file, BasicFileAttributes
attrs) {
+if (Files.isSymbolicLink(file)) {
Review Comment:
So, right now symbolic links don't work, they blow up with a cryptic error.
This PR 's goal is to replace the cryptic error with a nicer error! I think
your suggestion is interesting, and if we wanted to support symbolic link
lookup, that sounds like a nice addition to do in a separate PR that removes
the limitation. It isn't an immediate itch for me to scratch however. Does
that sound reasonable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17180: Deprecate snapshotscli.sh in favour of bin/solr sub commands. [solr]
malliaridis commented on PR #2381: URL: https://github.com/apache/solr/pull/2381#issuecomment-2307848943 Great job adding documentation on this one. That's a very useful addition to the referene guide. 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17180: Deprecate snapshotscli.sh in favour of bin/solr sub commands. [solr]
epugh commented on PR #2381: URL: https://github.com/apache/solr/pull/2381#issuecomment-2307851372 > Great job adding documentation on this one. That's a very useful addition to the referene guide. 👍 I appreciate it! I did it partly because you called it out! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17180: Deprecate snapshotscli.sh in favour of bin/solr sub commands. [solr]
epugh commented on PR #2381: URL: https://github.com/apache/solr/pull/2381#issuecomment-2307852130 I would love a bot that would jsut delete code that wasn't documented ;-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-12429) ZK upconfig throws confusing error when it encounters a symlink
[
https://issues.apache.org/jira/browse/SOLR-12429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876374#comment-17876374
]
Eric Pugh commented on SOLR-12429:
--
Gus asked the same question on the PR... Right now they just blow up with a
cryptic error, so I wanted a nice error.
I think it could be a nice feature, but i didn't want to get into the logic of
supporting it, and writing all the unit tests etc... I think if someone wants
to add it, it would be a great feature, but supporting that isnt' the intent of
this ticket...
> ZK upconfig throws confusing error when it encounters a symlink
> ---
>
> Key: SOLR-12429
> URL: https://issues.apache.org/jira/browse/SOLR-12429
> Project: Solr
> Issue Type: Bug
> Components: SolrCLI
>Affects Versions: 7.3.1
>Reporter: Shawn Heisey
>Assignee: Eric Pugh
>Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> If a configset being uploaded to ZK contains a symlink pointing at a
> directory, an error is thrown, but it doesn't explain the real problem. The
> upconfig should detect symlinks and throw an error indicating that they
> aren't supported. If we can detect any other type of file that upconfig
> can't use (sockets, device files, etc), the error message should be relevant.
> {noformat}
> Exception in thread "main" java.io.IOException: File
> '/var/solr/mbs/artist/conf/common' exists but is a directory
> at org.apache.commons.io.FileUtils.openInputStream(FileUtils.java:286)
> at
> org.apache.commons.io.FileUtils.readFileToByteArray(FileUtils.java:1815)
> at
> org.apache.solr.common.cloud.SolrZkClient.makePath(SolrZkClient.java:391)
> at
> org.apache.solr.common.cloud.ZkMaintenanceUtils$1.visitFile(ZkMaintenanceUtils.java:305)
> at
> org.apache.solr.common.cloud.ZkMaintenanceUtils$1.visitFile(ZkMaintenanceUtils.java:291)
> at java.nio.file.Files.walkFileTree(Files.java:2670)
> at java.nio.file.Files.walkFileTree(Files.java:2742)
> at
> org.apache.solr.common.cloud.ZkMaintenanceUtils.uploadToZK(ZkMaintenanceUtils.java:291)
> at
> org.apache.solr.common.cloud.SolrZkClient.uploadToZK(SolrZkClient.java:793)
> at
> org.apache.solr.common.cloud.ZkConfigManager.uploadConfigDir(ZkConfigManager.java:78)
> at org.apache.solr.cloud.ZkCLI.main(ZkCLI.java:236)
> {noformat}
> I have not tested whether a symlink pointing at a file works, but I think
> that an error should be thrown for ANY symlink.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
