[PATCH] net/mlx5: fix RSS hash for non-RSS CQE zipping

[Alexander Kozyrev]

Take the RSS hash value for the title packet for
flow tag and packet header CQE zipping formats.

Fixes: 54c2d46b16 ("net/mlx5: support flow tag and packet header miniCQEs")
Cc: sta...@dpdk.org

Signed-off-by: Alexander Kozyrev 
---
 drivers/net/mlx5/mlx5_rxtx_vec_altivec.h | 9 +
 drivers/net/mlx5/mlx5_rxtx_vec_neon.h| 9 +
 drivers/net/mlx5/mlx5_rxtx_vec_sse.h | 9 +
 3 files changed, 15 insertions(+), 12 deletions(-)

diff --git a/drivers/net/mlx5/mlx5_rxtx_vec_altivec.h 
b/drivers/net/mlx5/mlx5_rxtx_vec_altivec.h
index 240987d03d..18452cc047 100644
--- a/drivers/net/mlx5/mlx5_rxtx_vec_altivec.h
+++ b/drivers/net/mlx5/mlx5_rxtx_vec_altivec.h
@@ -452,6 +452,7 @@ rxq_cq_decompress_v(struct mlx5_rxq_data *rxq, volatile 
struct mlx5_cqe *cq,
(uint32_t)t_pkt->ol_flags,
(uint32_t)t_pkt->ol_flags,
(uint32_t)t_pkt->ol_flags};
+   const uint32_t hash_rss = t_pkt->hash.rss;
 
ol_flags_mask = (__vector unsigned char)
vec_or((__vector unsigned long)ol_flags_mask,
@@ -470,10 +471,10 @@ rxq_cq_decompress_v(struct mlx5_rxq_data *rxq, volatile 
struct mlx5_cqe *cq,
((__vector unsigned int)ol_flags)[2];
elts[pos + 3]->ol_flags =
((__vector unsigned int)ol_flags)[3];
-   elts[pos]->hash.rss = 0;
-   elts[pos + 1]->hash.rss = 0;
-   elts[pos + 2]->hash.rss = 0;
-   elts[pos + 3]->hash.rss = 0;
+   elts[pos]->hash.rss = hash_rss;
+   elts[pos + 1]->hash.rss = hash_rss;
+   elts[pos + 2]->hash.rss = hash_rss;
+   elts[pos + 3]->hash.rss = hash_rss;
}
if (rxq->dynf_meta) {
int32_t offs = rxq->flow_meta_offset;
diff --git a/drivers/net/mlx5/mlx5_rxtx_vec_neon.h 
b/drivers/net/mlx5/mlx5_rxtx_vec_neon.h
index dc1d30753d..653a10867d 100644
--- a/drivers/net/mlx5/mlx5_rxtx_vec_neon.h
+++ b/drivers/net/mlx5/mlx5_rxtx_vec_neon.h
@@ -330,6 +330,7 @@ rxq_cq_decompress_v(struct mlx5_rxq_data *rxq, volatile 
struct mlx5_cqe *cq,
vdupq_n_u32(RTE_MBUF_F_RX_RSS_HASH);
const uint32x4_t rearm_flags =
vdupq_n_u32((uint32_t)t_pkt->ol_flags);
+   const uint32_t hash_rss = t_pkt->hash.rss;
 
ol_flags_mask = vorrq_u32(ol_flags_mask, hash_flags);
ol_flags = vorrq_u32(ol_flags,
@@ -338,10 +339,10 @@ rxq_cq_decompress_v(struct mlx5_rxq_data *rxq, volatile 
struct mlx5_cqe *cq,
elts[pos + 1]->ol_flags = vgetq_lane_u32(ol_flags, 2);
elts[pos + 2]->ol_flags = vgetq_lane_u32(ol_flags, 1);
elts[pos + 3]->ol_flags = vgetq_lane_u32(ol_flags, 0);
-   elts[pos]->hash.rss = 0;
-   elts[pos + 1]->hash.rss = 0;
-   elts[pos + 2]->hash.rss = 0;
-   elts[pos + 3]->hash.rss = 0;
+   elts[pos]->hash.rss = hash_rss;
+   elts[pos + 1]->hash.rss = hash_rss;
+   elts[pos + 2]->hash.rss = hash_rss;
+   elts[pos + 3]->hash.rss = hash_rss;
}
if (rxq->dynf_meta) {
int32_t offs = rxq->flow_meta_offset;
diff --git a/drivers/net/mlx5/mlx5_rxtx_vec_sse.h 
b/drivers/net/mlx5/mlx5_rxtx_vec_sse.h
index 81a177fce7..fd47677db1 100644
--- a/drivers/net/mlx5/mlx5_rxtx_vec_sse.h
+++ b/drivers/net/mlx5/mlx5_rxtx_vec_sse.h
@@ -314,6 +314,7 @@ rxq_cq_decompress_v(struct mlx5_rxq_data *rxq, volatile 
struct mlx5_cqe *cq,
_mm_set1_epi32(RTE_MBUF_F_RX_RSS_HASH);
const __m128i rearm_flags =
_mm_set1_epi32((uint32_t)t_pkt->ol_flags);
+   const uint32_t hash_rss = t_pkt->hash.rss;
 
ol_flags_mask = _mm_or_si128(ol_flags_mask, hash_flags);
ol_flags = _mm_or_si128(ol_flags,
@@ -326,10 +327,10 @@ rxq_cq_decompress_v(struct mlx5_rxq_data *rxq, volatile 
struct mlx5_cqe *cq,
_mm_extract_epi32(ol_flags, 2);
elts[pos + 3]->ol_flags =
_mm_extract_epi32(ol_flags, 3);
-   elts[pos]->hash.rss = 0;
-   elts[pos + 1]->hash.rss = 0;
-   elts[pos + 2]->hash.rss = 0;
-   elts[pos + 3]->hash.rss = 0;
+   elts[pos]->hash.rss = hash_rss;
+   elts[pos + 1]->hash.rss = hash_rss;
+   elts[pos + 2]->hash.rss

r8169 throughput

[Howard Wang]

Dear Thomas,

As you expected, I have attached the throughput under this release.
My testing was conducted using pktgen 24.10.3. I just set the size 
and then start all. The test results are as follows:

size/throughputrtl8125brtl8126
641709 MBit/s  3080 MBit/s
128   2272 MBit/s  4265 MBit/s
256   2500 MBit/s  4982 MBit/s
512   2500 MBit/s  5000 MBit/s
1024  2500 MBit/s  5000 MBit/s  
1280  2500 MBit/s  5000 MBit/s
1518  2500 MBit/s  5000 MBit/s

Best regards,
Howard Wang

Re: r8169 throughput

[Thomas Monjalon]

21/11/2024 10:32, Howard Wang:
> Dear Thomas,
> 
> As you expected, I have attached the throughput under this release.
> My testing was conducted using pktgen 24.10.3. I just set the size 
> and then start all. The test results are as follows:
> 
> size/throughputrtl8125brtl8126
> 641709 MBit/s  3080 MBit/s
> 128   2272 MBit/s  4265 MBit/s
> 256   2500 MBit/s  4982 MBit/s
> 512   2500 MBit/s  5000 MBit/s
> 1024  2500 MBit/s  5000 MBit/s  
> 1280  2500 MBit/s  5000 MBit/s
> 1518  2500 MBit/s  5000 MBit/s

Interesting, thank you.

Do you plan to support more devices?

RE: [PATCH] net/mlx5: fix RSS hash for non-RSS CQE zipping

[Dariusz Sosnowski]

> -Original Message-
> From: Alexander Kozyrev 
> Sent: Thursday, November 21, 2024 14:32
> To: dev@dpdk.org
> Cc: sta...@dpdk.org; Raslan Darawsheh ; Slava Ovsiienko
> ; Matan Azrad ; Dariusz
> Sosnowski ; Bing Zhao ;
> Suanming Mou 
> Subject: [PATCH] net/mlx5: fix RSS hash for non-RSS CQE zipping
> 
> Take the RSS hash value for the title packet for flow tag and packet header 
> CQE
> zipping formats.
> 
> Fixes: 54c2d46b16 ("net/mlx5: support flow tag and packet header miniCQEs")
> Cc: sta...@dpdk.org
> 
> Signed-off-by: Alexander Kozyrev 

Acked-by: Dariusz Sosnowski 

Best regards,
Dariusz Sosnowski

Re: [PATCH] mailmap: fix sorting

[Thomas Monjalon]

06/07/2023 01:45, Stephen Hemminger:
> The mailmap file is supposed to be in sorted order,
> but several entries are in the wrong place.

Sorting a space may be done in various ways.
We tried in the past to have a good sort
handling both spaces and accents, but we failed to automate it.
So we are doing our best manually.

In other words, I don't approve this patch
if there is no good automatic sort with it.

> -Abdullah Ömer Yamaç 
>  Abdullah Sevincer 
> +Abdullah Ömer Yamaç 

"O" should be before "S"
This is an example of bad handling of accents in the automatic sort.

Re: [PATCH v5 1/2] dts: add csum HW offload to testpmd shell

[Patrick Robb]

Reviewed-by: Patrick Robb 

Re: [PATCH] net/i40e: fix read register return status check

[Bruce Richardson]

On Tue, Nov 19, 2024 at 11:52:38AM +, Bruce Richardson wrote:
> On Fri, Nov 15, 2024 at 07:14:25PM +, Vladimir Medvedkin wrote:
> > 'i40e_get_outer_vlan()' does not check 'i40e_aq_debug_read_register()'
> > return value. This patch fixes this issue.
> 
> I think a little more detail on the scope of the changes could be good
> here. It fixes the issue by allowing the function to return error, or zero
> on success rather than the value read. This change then causes some rework
> in the calling code to handle the error code and to change the form of the
> function call.
> 
> > 
> > Coverity issue: 445518
> > 
> > Fixes: 86eb05d6350b ("net/i40e: add flow validate function")
> > Cc: beilei.x...@intel.com
> > Cc: sta...@dpdk.org
> > 
> > Signed-off-by: Vladimir Medvedkin 
> 
> Fix below looks good, some minor comments.
> 
> Acked-by: Bruce Richardson 
> 

Patch applied to dpdk-next-net-intel with commit log additions and the two
minor comments on the code fixed on apply.

Thanks,
/Bruce

Re: [PATCH v12 18/21] build: enable vla warnings on Windows built code

[fengchengwen]

Acked-by: Chengwen Feng 

On 2024/11/22 5:41, Andre Muezerie wrote:
> From: Tyler Retzlaff 
> 
> MSVC does not support optional C11 VLAs. When building for Windows
> enable -Wvla so that mingw and clang also fail if a VLA is used.
> 
> Signed-off-by: Tyler Retzlaff 
> Acked-by: Bruce Richardson 
> ---
>  config/meson.build | 4 
>  1 file changed, 4 insertions(+)
> 
> diff --git a/config/meson.build b/config/meson.build
> index 6aaad6d8a4..ebca19b4e5 100644
> --- a/config/meson.build
> +++ b/config/meson.build
> @@ -342,6 +342,10 @@ if cc.get_id() == 'intel'
>  warning_flags += '-diag-disable=@0@'.format(i)
>  endforeach
>  endif
> +# no VLAs in code built on Windows
> +if is_windows
> +warning_flags += '-Wvla'
> +endif
>  foreach arg: warning_flags
>  if cc.has_argument(arg)
>  add_project_arguments(arg, language: 'c')

Re: [PATCH v4 8/9] app/test-pmd: remove redundant condition

[fengchengwen]

Acked-by: Chengwen Feng 

On 2024/11/22 2:23, Stephen Hemminger wrote:
> The loop over policy actions will always exit when it sees
> the flow end action, so the next check is redundant.
> 
> Link: https://pvs-studio.com/en/blog/posts/cpp/1179/
> 
> Fixes: f29fa2c59b85 ("app/testpmd: support policy actions per color")
> Cc: haif...@nvidia.com
> Signed-off-by: Stephen Hemminger 
> Acked-by: Bruce Richardson 
> Acked-by: Ajit Khaparde 
> ---
>  app/test-pmd/config.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
> index 28d45568ac..4e7fb69183 100644
> --- a/app/test-pmd/config.c
> +++ b/app/test-pmd/config.c
> @@ -2288,7 +2288,7 @@ port_meter_policy_add(portid_t port_id, uint32_t 
> policy_id,
>   for (act_n = 0, start = act;
>   act->type != RTE_FLOW_ACTION_TYPE_END; act++)
>   act_n++;
> - if (act_n && act->type == RTE_FLOW_ACTION_TYPE_END)
> + if (act_n > 0)
>   policy.actions[i] = start;
>   else
>   policy.actions[i] = NULL;
> @@ -7338,4 +7338,3 @@ show_mcast_macs(portid_t port_id)
>   printf("  %s\n", buf);
>   }
>  }
> -

[PATCH v4 3/9] app/test: fix paren typo

[Stephen Hemminger]

The parenthesis were in the wrong place so that comparison
took precedence over assignment in handling IPv6 extension
headers.  Break up the loop condition to avoid the problem.

Link: https://pvs-studio.com/en/blog/posts/cpp/1179/

Fixes: 15ccc647526e ("test/security: test inline reassembly with multi-segment")
Cc: ndabilpu...@marvell.com
Cc: sta...@dpdk.org

Signed-off-by: Stephen Hemminger 
Acked-by: Bruce Richardson 
---
 app/test/test_security_inline_proto_vectors.h | 8 +---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/app/test/test_security_inline_proto_vectors.h 
b/app/test/test_security_inline_proto_vectors.h
index b3d724bac6..86dfa54777 100644
--- a/app/test/test_security_inline_proto_vectors.h
+++ b/app/test/test_security_inline_proto_vectors.h
@@ -519,10 +519,12 @@ test_vector_payload_populate(struct 
ip_reassembly_test_packet *pkt,
if (extra_data_sum) {
proto = hdr->proto;
p += sizeof(struct rte_ipv6_hdr);
-   while (proto != IPPROTO_FRAGMENT &&
-  (proto = rte_ipv6_get_next_ext(p, proto, 
&ext_len) >= 0))
+   while (proto != IPPROTO_FRAGMENT) {
+   proto = rte_ipv6_get_next_ext(p, proto, 
&ext_len);
+   if (proto < 0)
+   break;
p += ext_len;
-
+   }
/* Found fragment header, update the frag 
offset */
if (proto == IPPROTO_FRAGMENT) {
frag_ext = (struct 
rte_ipv6_fragment_ext *)p;
-- 
2.45.2

[PATCH v11 08/21] gro: fix overwrite unprocessed packets

[Andre Muezerie]

From: Konstantin Ananyev 

gro_vxlan_tcp4_tbl_timeout_flush() is called without taking into account
that first entries in pkts[] can be already occupied by
un-processed packets.

Fixes: 74080d7dcf31 ("gro: support IPv6 for TCP")
Cc: sta...@dpdk.org

Signed-off-by: Konstantin Ananyev 
Acked-by: Ferruh Yigit 
---
 lib/gro/rte_gro.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/gro/rte_gro.c b/lib/gro/rte_gro.c
index d824eebd93..db86117609 100644
--- a/lib/gro/rte_gro.c
+++ b/lib/gro/rte_gro.c
@@ -327,7 +327,7 @@ rte_gro_reassemble_burst(struct rte_mbuf **pkts,
/* Flush all packets from the tables */
if (do_vxlan_tcp_gro) {
i += gro_vxlan_tcp4_tbl_timeout_flush(&vxlan_tcp_tbl,
-   0, pkts, nb_pkts);
+   0, &pkts[i], nb_pkts - i);
}
 
if (do_vxlan_udp_gro) {
-- 
2.47.0.vfs.0.3

[PATCH v11 01/21] eal: include header required for alloca

[Andre Muezerie]

From: Tyler Retzlaff 

Include alloca.h for Linux and malloc.h for Windows to get declaration
of alloca().

Signed-off-by: Tyler Retzlaff 
---
 lib/eal/freebsd/include/rte_os.h | 1 +
 lib/eal/linux/include/rte_os.h   | 1 +
 lib/eal/windows/include/rte_os.h | 1 +
 3 files changed, 3 insertions(+)

diff --git a/lib/eal/freebsd/include/rte_os.h b/lib/eal/freebsd/include/rte_os.h
index 62e70dc15b..94b9275beb 100644
--- a/lib/eal/freebsd/include/rte_os.h
+++ b/lib/eal/freebsd/include/rte_os.h
@@ -11,6 +11,7 @@
  */
 
 #include 
+#include /* Declares alloca() */
 #include 
 
 /* These macros are compatible with system's sys/queue.h. */
diff --git a/lib/eal/linux/include/rte_os.h b/lib/eal/linux/include/rte_os.h
index 35c07c70cb..20eff0409a 100644
--- a/lib/eal/linux/include/rte_os.h
+++ b/lib/eal/linux/include/rte_os.h
@@ -10,6 +10,7 @@
  * which is not supported natively or named differently in Linux.
  */
 
+#include 
 #include 
 #include 
 
diff --git a/lib/eal/windows/include/rte_os.h b/lib/eal/windows/include/rte_os.h
index 9d69467aaa..d09adeb3b4 100644
--- a/lib/eal/windows/include/rte_os.h
+++ b/lib/eal/windows/include/rte_os.h
@@ -13,6 +13,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include 
 
-- 
2.47.0.vfs.0.3

[PATCH v11 04/21] ethdev: remove use of VLAs for Windows built code

[Andre Muezerie]

From: Konstantin Ananyev 

1) ./lib/ethdev/rte_ethdev.c:3244:16
: warning: ISO C90 forbids variable length array ‘xstats_names’
2) ./lib/ethdev/rte_ethdev.c:3345:17
: warning: ISO C90 forbids variable length array ‘ids_copy’
3) ./lib/ethdev/rte_ethdev.c:3538:16
: warning: ISO C90 forbids variable length array ‘xstats’
4) ./lib/ethdev/rte_ethdev.c:3554:17
: warning: ISO C90 forbids variable length array ‘ids_copy’

For 1) and 3) - just replaced VLA with arrays allocated from heap.
As I understand xstats extraction belongs to control-path, so extra
calloc/free is hopefully acceptable.
Also ethdev xstats already doing that within
rte_eth_xstats_get_id_by_name().
For 2) and 4) changed the code to use fixed size array and call
appropriate devops function several times, if needed.

Signed-off-by: Konstantin Ananyev 
---
 lib/ethdev/rte_ethdev.c | 183 +---
 1 file changed, 113 insertions(+), 70 deletions(-)

diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c
index 6413c54e3b..09cc4764c3 100644
--- a/lib/ethdev/rte_ethdev.c
+++ b/lib/ethdev/rte_ethdev.c
@@ -36,6 +36,8 @@
 #include "ethdev_trace.h"
 #include "sff_telemetry.h"
 
+#define ETH_XSTATS_ITER_NUM0x100
+
 struct rte_eth_dev rte_eth_devices[RTE_MAX_ETHPORTS];
 
 /* public fast-path API */
@@ -3308,7 +3310,8 @@ int
 rte_eth_xstats_get_id_by_name(uint16_t port_id, const char *xstat_name,
uint64_t *id)
 {
-   int cnt_xstats, idx_xstat;
+   int cnt_xstats, idx_xstat, rc;
+   struct rte_eth_xstat_name *xstats_names;
 
RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
 
@@ -3334,26 +3337,33 @@ rte_eth_xstats_get_id_by_name(uint16_t port_id, const 
char *xstat_name,
}
 
/* Get id-name lookup table */
-   struct rte_eth_xstat_name xstats_names[cnt_xstats];
+   xstats_names = calloc(cnt_xstats, sizeof(xstats_names[0]));
+   if (xstats_names == NULL) {
+   RTE_ETHDEV_LOG_LINE(ERR, "Can't allocate memory");
+   return -ENOMEM;
+   }
 
if (cnt_xstats != rte_eth_xstats_get_names_by_id(
port_id, xstats_names, cnt_xstats, NULL)) {
RTE_ETHDEV_LOG_LINE(ERR, "Cannot get xstats lookup");
+   free(xstats_names);
return -1;
}
 
+   rc = -EINVAL;
for (idx_xstat = 0; idx_xstat < cnt_xstats; idx_xstat++) {
if (!strcmp(xstats_names[idx_xstat].name, xstat_name)) {
*id = idx_xstat;
 
rte_eth_trace_xstats_get_id_by_name(port_id,
xstat_name, *id);
-
-   return 0;
+   rc = 0;
+   break;
};
}
 
-   return -EINVAL;
+   free(xstats_names);
+   return rc;
 }
 
 /* retrieve basic stats names */
@@ -3399,6 +3409,38 @@ eth_basic_stats_get_names(struct rte_eth_dev *dev,
return cnt_used_entries;
 }
 
+static int
+eth_xstats_get_by_name_by_id(struct rte_eth_dev *dev, const uint64_t *ids,
+   struct rte_eth_xstat_name *xstats_names, uint32_t size,
+   uint32_t basic_count)
+{
+   int32_t rc;
+   uint32_t i, k, m, n;
+   uint64_t ids_copy[ETH_XSTATS_ITER_NUM];
+
+   m = 0;
+   for (n = 0; n != size; n += k) {
+
+   k = RTE_MIN(size - n, RTE_DIM(ids_copy));
+
+   /*
+* Convert ids to xstats ids that PMD knows.
+* ids known by user are basic + extended stats.
+*/
+   for (i = 0; i < k; i++)
+   ids_copy[i] = ids[n + i] - basic_count;
+
+   rc = (*dev->dev_ops->xstats_get_names_by_id)(dev, ids_copy,
+   xstats_names + m, k);
+   if (rc < 0)
+   return rc;
+   m += rc;
+   }
+
+   return m;
+}
+
+
 /* retrieve ethdev extended statistics names */
 int
 rte_eth_xstats_get_names_by_id(uint16_t port_id,
@@ -3406,9 +3448,8 @@ rte_eth_xstats_get_names_by_id(uint16_t port_id,
uint64_t *ids)
 {
struct rte_eth_xstat_name *xstats_names_copy;
-   unsigned int no_basic_stat_requested = 1;
-   unsigned int no_ext_stat_requested = 1;
unsigned int expected_entries;
+   unsigned int nb_basic_stats;
unsigned int basic_count;
struct rte_eth_dev *dev;
unsigned int i;
@@ -3434,27 +3475,18 @@ rte_eth_xstats_get_names_by_id(uint16_t port_id,
if (ids && !xstats_names)
return -EINVAL;
 
-   if (ids && dev->dev_ops->xstats_get_names_by_id != NULL && size > 0) {
-   uint64_t ids_copy[size];
-
-   for (i = 0; i < size; i++) {
-   if (ids[i] < basic_count) {
-   no_basic_stat_requested = 0;
-   break;
-   }
-
-

[PATCH v11 07/21] rcu: remove use of VLAs for Windows built code

[Andre Muezerie]

From: Konstantin Ananyev 

1) ./lib/rcu/rte_rcu_qsbr.c:359:9
: warning: ISO C90 forbids variable length array ‘data’ [-Wvla]
2) ./lib/rcu/rte_rcu_qsbr.c:422:9
: warning: ISO C90 forbids variable length array ‘data’ [-Wvla]

In both cases we allocate VLA for one element from RCU deferred queue.
Right now, size of element in RCU queue is not limited by API.
The approach is to introduce some reasonable limitation on RCU DQ
element size.
Choose 128B for now.
With that in place we can replace both VLA occurencies with fixed size
array.

Note that such change need to be treated as API change.
So can be applied only at 24.11.

Signed-off-by: Konstantin Ananyev 
---
 lib/rcu/rte_rcu_qsbr.c | 7 ---
 lib/rcu/rte_rcu_qsbr.h | 5 +
 2 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/lib/rcu/rte_rcu_qsbr.c b/lib/rcu/rte_rcu_qsbr.c
index dbf31501a6..fe68d16326 100644
--- a/lib/rcu/rte_rcu_qsbr.c
+++ b/lib/rcu/rte_rcu_qsbr.c
@@ -245,7 +245,8 @@ rte_rcu_qsbr_dq_create(const struct 
rte_rcu_qsbr_dq_parameters *params)
if (params == NULL || params->free_fn == NULL ||
params->v == NULL || params->name == NULL ||
params->size == 0 || params->esize == 0 ||
-   (params->esize % 4 != 0)) {
+   (params->esize % 4 != 0) ||
+   params->esize > RTE_QSBR_ESIZE_MAX) {
RCU_LOG(ERR, "Invalid input parameter");
rte_errno = EINVAL;
 
@@ -323,7 +324,7 @@ int rte_rcu_qsbr_dq_enqueue(struct rte_rcu_qsbr_dq *dq, 
void *e)
return 1;
}
 
-   char data[dq->esize];
+   char data[RTE_QSBR_ESIZE_MAX + __RTE_QSBR_TOKEN_SIZE];
dq_elem = (__rte_rcu_qsbr_dq_elem_t *)data;
/* Start the grace period */
dq_elem->token = rte_rcu_qsbr_start(dq->v);
@@ -386,7 +387,7 @@ rte_rcu_qsbr_dq_reclaim(struct rte_rcu_qsbr_dq *dq, 
unsigned int n,
 
cnt = 0;
 
-   char data[dq->esize];
+   char data[RTE_QSBR_ESIZE_MAX + __RTE_QSBR_TOKEN_SIZE];
/* Check reader threads quiescent state and reclaim resources */
while (cnt < n &&
rte_ring_dequeue_bulk_elem_start(dq->r, &data,
diff --git a/lib/rcu/rte_rcu_qsbr.h b/lib/rcu/rte_rcu_qsbr.h
index 550fadf56a..abcbd78914 100644
--- a/lib/rcu/rte_rcu_qsbr.h
+++ b/lib/rcu/rte_rcu_qsbr.h
@@ -86,6 +86,11 @@ struct __rte_cache_aligned rte_rcu_qsbr_cnt {
 #define __RTE_QSBR_CNT_MAX ((uint64_t)~0)
 #define __RTE_QSBR_TOKEN_SIZE sizeof(uint64_t)
 
+/**
+ * Max allowable size (in bytes) of each element in the defer queue
+ */
+#define RTE_QSBR_ESIZE_MAX (2 * RTE_CACHE_LINE_MIN_SIZE)
+
 /* RTE Quiescent State variable structure.
  * This structure has two elements that vary in size based on the
  * 'max_threads' parameter.
-- 
2.47.0.vfs.0.3

[PATCH v11 09/21] gro: remove use of VLAs

[Andre Muezerie]

From: Konstantin Ananyev 

../lib/gro/rte_gro.c:182:34: warning:
variable length array used [-Wvla]
../lib/gro/rte_gro.c:363:34: warning:
variable length array used [-Wvla]

In both cases the pattern is the same: we use unprocess_pkts[nb_pkts] to
collect un-used by GRO packets, and then copy them to the start of
input/output pkts[] array.
In both cases, we can safely copy pkts[i] into already
processed entry at the same array, i.e. into pkts[unprocess_num].
Such change eliminates need of temporary VLA: unprocess_pkts[nb_pkts].

Signed-off-by: Konstantin Ananyev 
Acked-by: Ferruh Yigit 
---
 lib/gro/rte_gro.c | 40 ++--
 1 file changed, 14 insertions(+), 26 deletions(-)

diff --git a/lib/gro/rte_gro.c b/lib/gro/rte_gro.c
index db86117609..6d5aadf32a 100644
--- a/lib/gro/rte_gro.c
+++ b/lib/gro/rte_gro.c
@@ -179,7 +179,6 @@ rte_gro_reassemble_burst(struct rte_mbuf **pkts,
struct gro_vxlan_udp4_item vxlan_udp_items[RTE_GRO_MAX_BURST_ITEM_NUM]
= {{{0}} };
 
-   struct rte_mbuf *unprocess_pkts[nb_pkts];
uint32_t item_num;
int32_t ret;
uint16_t i, unprocess_num = 0, nb_after_gro = nb_pkts;
@@ -275,7 +274,7 @@ rte_gro_reassemble_burst(struct rte_mbuf **pkts,
/* Merge successfully */
nb_after_gro--;
else if (ret < 0)
-   unprocess_pkts[unprocess_num++] = pkts[i];
+   pkts[unprocess_num++] = pkts[i];
} else if (IS_IPV4_VXLAN_UDP4_PKT(pkts[i]->packet_type) &&
do_vxlan_udp_gro) {
ret = gro_vxlan_udp4_reassemble(pkts[i],
@@ -284,7 +283,7 @@ rte_gro_reassemble_burst(struct rte_mbuf **pkts,
/* Merge successfully */
nb_after_gro--;
else if (ret < 0)
-   unprocess_pkts[unprocess_num++] = pkts[i];
+   pkts[unprocess_num++] = pkts[i];
} else if (IS_IPV4_TCP_PKT(pkts[i]->packet_type) &&
do_tcp4_gro) {
ret = gro_tcp4_reassemble(pkts[i], &tcp_tbl, 0);
@@ -292,7 +291,7 @@ rte_gro_reassemble_burst(struct rte_mbuf **pkts,
/* merge successfully */
nb_after_gro--;
else if (ret < 0)
-   unprocess_pkts[unprocess_num++] = pkts[i];
+   pkts[unprocess_num++] = pkts[i];
} else if (IS_IPV4_UDP_PKT(pkts[i]->packet_type) &&
do_udp4_gro) {
ret = gro_udp4_reassemble(pkts[i], &udp_tbl, 0);
@@ -300,7 +299,7 @@ rte_gro_reassemble_burst(struct rte_mbuf **pkts,
/* merge successfully */
nb_after_gro--;
else if (ret < 0)
-   unprocess_pkts[unprocess_num++] = pkts[i];
+   pkts[unprocess_num++] = pkts[i];
} else if (IS_IPV6_TCP_PKT(pkts[i]->packet_type) &&
do_tcp6_gro) {
ret = gro_tcp6_reassemble(pkts[i], &tcp6_tbl, 0);
@@ -308,21 +307,15 @@ rte_gro_reassemble_burst(struct rte_mbuf **pkts,
/* merge successfully */
nb_after_gro--;
else if (ret < 0)
-   unprocess_pkts[unprocess_num++] = pkts[i];
+   pkts[unprocess_num++] = pkts[i];
} else
-   unprocess_pkts[unprocess_num++] = pkts[i];
+   pkts[unprocess_num++] = pkts[i];
}
 
if ((nb_after_gro < nb_pkts)
 || (unprocess_num < nb_pkts)) {
-   i = 0;
-   /* Copy unprocessed packets */
-   if (unprocess_num > 0) {
-   memcpy(&pkts[i], unprocess_pkts,
-   sizeof(struct rte_mbuf *) *
-   unprocess_num);
-   i = unprocess_num;
-   }
+
+   i = unprocess_num;
 
/* Flush all packets from the tables */
if (do_vxlan_tcp_gro) {
@@ -360,7 +353,6 @@ rte_gro_reassemble(struct rte_mbuf **pkts,
uint16_t nb_pkts,
void *ctx)
 {
-   struct rte_mbuf *unprocess_pkts[nb_pkts];
struct gro_ctx *gro_ctx = ctx;
void *tcp_tbl, *udp_tbl, *vxlan_tcp_tbl, *vxlan_udp_tbl, *tcp6_tbl;
uint64_t current_time;
@@ -396,33 +388,29 @@ rte_gro_reassemble(struct rte_mbuf **pkts,
do_vxlan_tcp_gro) {
if (gro_vxlan_tcp4_reassemble(pkts[i], vxlan_tcp_tbl,
 

[PATCH v11 14/21] common/idpf: remove use of VLAs for Windows built code

[Andre Muezerie]

From: Tyler Retzlaff 

MSVC does not support VLAs, replace VLAs with standard C arrays
or alloca(). alloca() is available for all toolchain/platform
combinations officially supported by DPDK.

Signed-off-by: Tyler Retzlaff 
Acked-by: Bruce Richardson 
---
 drivers/common/idpf/idpf_common_rxtx.c| 2 +-
 drivers/common/idpf/idpf_common_rxtx_avx512.c | 6 --
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/common/idpf/idpf_common_rxtx.c 
b/drivers/common/idpf/idpf_common_rxtx.c
index a04e54ce26..e04ab40fa2 100644
--- a/drivers/common/idpf/idpf_common_rxtx.c
+++ b/drivers/common/idpf/idpf_common_rxtx.c
@@ -569,7 +569,7 @@ idpf_split_rx_bufq_refill(struct idpf_rx_queue *rx_bufq)
uint16_t nb_refill = rx_bufq->rx_free_thresh;
uint16_t nb_desc = rx_bufq->nb_rx_desc;
uint16_t next_avail = rx_bufq->rx_tail;
-   struct rte_mbuf *nmb[rx_bufq->rx_free_thresh];
+   struct rte_mbuf **nmb = alloca(sizeof(struct rte_mbuf *) * 
rx_bufq->rx_free_thresh);
uint64_t dma_addr;
uint16_t delta;
int i;
diff --git a/drivers/common/idpf/idpf_common_rxtx_avx512.c 
b/drivers/common/idpf/idpf_common_rxtx_avx512.c
index b8450b03ae..63e10c542f 100644
--- a/drivers/common/idpf/idpf_common_rxtx_avx512.c
+++ b/drivers/common/idpf/idpf_common_rxtx_avx512.c
@@ -1002,7 +1002,8 @@ idpf_tx_singleq_free_bufs_avx512(struct idpf_tx_queue 
*txq)
uint32_t n;
uint32_t i;
int nb_free = 0;
-   struct rte_mbuf *m, *free[txq->rs_thresh];
+   struct rte_mbuf *m;
+   struct rte_mbuf **free = alloca(sizeof(struct rte_mbuf *) * 
txq->rs_thresh);
 
/* check DD bits on threshold descriptor */
if ((txq->tx_ring[txq->next_dd].qw1 &
@@ -1326,7 +1327,8 @@ idpf_tx_splitq_free_bufs_avx512(struct idpf_tx_queue *txq)
uint32_t n;
uint32_t i;
int nb_free = 0;
-   struct rte_mbuf *m, *free[txq->rs_thresh];
+   struct rte_mbuf *m;
+   struct rte_mbuf **free = alloca(sizeof(struct rte_mbuf *) * 
txq->rs_thresh);
 
n = txq->rs_thresh;
 
-- 
2.47.0.vfs.0.3

[PATCH v11 06/21] hash/thash: remove use of VLAs for Windows built

[Andre Muezerie]

From: Konstantin Ananyev 

1) ./lib/hash/rte_thash.c:774:9
: warning: ISO C90 forbids variable length array ‘tmp_tuple’

The tuple can exceed sizeof(union rte_thash_tuple), for example if any tunneling
header is used in the RSS hash calculation.

The longest RSS hash key currently supported is 52 bytes. Technically, the
longest tuple with such a key should be (52 - sizeof(uint32_t)), so this
can be used as a size of the tmp_tuple array.

Signed-off-by: Konstantin Ananyev 
---
 lib/hash/rte_thash.c | 2 +-
 lib/hash/rte_thash.h | 7 +++
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/lib/hash/rte_thash.c b/lib/hash/rte_thash.c
index 336c228e64..fa78787143 100644
--- a/lib/hash/rte_thash.c
+++ b/lib/hash/rte_thash.c
@@ -761,7 +761,7 @@ rte_thash_adjust_tuple(struct rte_thash_ctx *ctx,
uint32_t desired_value, unsigned int attempts,
rte_thash_check_tuple_t fn, void *userdata)
 {
-   uint32_t tmp_tuple[tuple_len / sizeof(uint32_t)];
+   uint32_t tmp_tuple[RTE_THASH_TUPLE_LEN_MAX];
unsigned int i, j, ret = 0;
uint32_t hash, adj_bits;
const uint8_t *hash_key;
diff --git a/lib/hash/rte_thash.h b/lib/hash/rte_thash.h
index c0af5968df..04f9f1875c 100644
--- a/lib/hash/rte_thash.h
+++ b/lib/hash/rte_thash.h
@@ -121,6 +121,13 @@ __rte_internal
 uint32_t
 thash_get_rand_poly(uint32_t poly_degree);
 
+/**
+ * Longest RSS hash key currently supported
+ */
+#define RTE_THASH_KEY_LEN_MAX  52
+
+#define RTE_THASH_TUPLE_LEN_MAX (RTE_THASH_KEY_LEN_MAX - sizeof(uint32_t))
+
 /**
  * Prepare special converted key to use with rte_softrss_be()
  * @param orig
-- 
2.47.0.vfs.0.3

[PATCH v11 12/21] app/testpmd: remove use of VLAs for Windows built

[Andre Muezerie]

From: Tyler Retzlaff 

MSVC does not support VLAs, replace VLAs with standard C arrays
or alloca(). alloca() is available for all toolchain/platform
combinations officially supported by DPDK.

Signed-off-by: Tyler Retzlaff 
---
 app/test-pmd/cmdline.c  |  2 +-
 app/test-pmd/cmdline_flow.c | 15 ++-
 app/test-pmd/config.c   | 16 +---
 3 files changed, 20 insertions(+), 13 deletions(-)

diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index 7e0666e9f6..2897e44c34 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -13274,7 +13274,7 @@ cmd_set_port_ptypes_parsed(
return;
}
 
-   uint32_t ptypes[ret];
+   uint32_t *ptypes = alloca(sizeof(uint32_t) * ret);
 
ret = rte_eth_dev_set_ptypes(port_id, ptype_mask, ptypes, ret);
if (ret < 0) {
diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
index 1e4f2ebc55..fb0c4f838d 100644
--- a/app/test-pmd/cmdline_flow.c
+++ b/app/test-pmd/cmdline_flow.c
@@ -11707,8 +11707,7 @@ parse_hex(struct context *ctx, const struct token 
*token,
char tmp[16]; /* Ought to be enough. */
int ret;
unsigned int hexlen = len;
-   unsigned int length = 256;
-   uint8_t hex_tmp[length];
+   uint8_t hex_tmp[256];
 
/* Arguments are expected. */
if (!arg_data)
@@ -11735,7 +11734,7 @@ parse_hex(struct context *ctx, const struct token 
*token,
str += 2;
hexlen -= 2;
}
-   if (hexlen > length)
+   if (hexlen > RTE_DIM(hex_tmp))
goto error;
ret = parse_hex_string(str, hex_tmp, &hexlen);
if (ret < 0)
@@ -11868,10 +11867,13 @@ parse_ipv4_addr(struct context *ctx, const struct 
token *token,
void *buf, unsigned int size)
 {
const struct arg *arg = pop_args(ctx);
-   char str2[len + 1];
+   char str2[INET_ADDRSTRLEN];
struct in_addr tmp;
int ret;
 
+   /* Length is longer than the max length an IPv4 address can have. */
+   if (len >= INET_ADDRSTRLEN)
+   return -1;
/* Argument is expected. */
if (!arg)
return -1;
@@ -11914,11 +11916,14 @@ parse_ipv6_addr(struct context *ctx, const struct 
token *token,
void *buf, unsigned int size)
 {
const struct arg *arg = pop_args(ctx);
-   char str2[len + 1];
+   char str2[INET6_ADDRSTRLEN];
struct rte_ipv6_addr tmp;
int ret;
 
(void)token;
+   /* Length is longer than the max length an IPv6 address can have. */
+   if (len >= INET6_ADDRSTRLEN)
+   return -1;
/* Argument is expected. */
if (!arg)
return -1;
diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index 28d45568ac..8117026c73 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -1802,7 +1802,8 @@ port_flow_configure(portid_t port_id,
 {
struct rte_port *port;
struct rte_flow_error error;
-   const struct rte_flow_queue_attr *attr_list[nb_queue];
+   const struct rte_flow_queue_attr **attr_list =
+   alloca(sizeof(struct rte_flow_queue_attr *) * nb_queue);
int std_queue;
 
if (port_id_is_invalid(port_id, ENABLED_WARN) ||
@@ -2616,10 +2617,10 @@ port_flow_template_table_create(portid_t port_id, 
uint32_t id,
int ret;
uint32_t i;
struct rte_flow_error error;
-   struct rte_flow_pattern_template
-   *flow_pattern_templates[nb_pattern_templates];
-   struct rte_flow_actions_template
-   *flow_actions_templates[nb_actions_templates];
+   struct rte_flow_pattern_template **flow_pattern_templates =
+   alloca(sizeof(struct rte_flow_pattern_template *) * 
nb_pattern_templates);
+   struct rte_flow_actions_template **flow_actions_templates =
+   alloca(sizeof(struct rte_flow_actions_template *) * 
nb_actions_templates);
 
if (port_id_is_invalid(port_id, ENABLED_WARN) ||
port_id == (portid_t)RTE_PORT_ALL)
@@ -5551,7 +5552,7 @@ parse_port_list(const char *list, unsigned int *values, 
unsigned int maxsize)
char *end = NULL;
int min, max;
int value, i;
-   unsigned int marked[maxsize];
+   unsigned int *marked = alloca(sizeof(unsigned int) * maxsize);
 
if (list == NULL || values == NULL)
return 0;
@@ -7292,7 +7293,8 @@ show_macs(portid_t port_id)
if (eth_dev_info_get_print_err(port_id, &dev_info))
return;
 
-   struct rte_ether_addr addr[dev_info.max_mac_addrs];
+   struct rte_ether_addr *addr =
+   alloca(sizeof(struct rte_ether_addr) * dev_info.max_mac_addrs);
rc = rte_eth_macaddrs_get(port_id, addr, dev_info.max_mac_addrs);
if (rc < 0)
return;
-- 
2.47.0.vfs.0.3

[PATCH v11 19/21] test: remove use of VLAs for Windows built code in bitset tests

[Andre Muezerie]

1) MSVC does not support VLAs. Use standard fixed C arrays of
maximum size required instead.

2) ../usr/lib/gcc/x86_64-redhat-linux/13/include/emmintrin.h:742:8:
error: array subscript 9 is outside array bounds of 'uint64_t[16]'
{aka 'long unsigned int[16]'} [-Werror=array-bounds=]
   3695 742 | *__P = __B;

Compile with -Wno-array-bounds to avoid false positives when
using gcc version 11 or newer (gcc compiler bug/limitation).

Signed-off-by: Andre Muezerie 
---
 app/test/test_bitset.c  | 69 -
 app/test/test_lcore_var_perf.c  |  2 +-
 app/test/test_reassembly_perf.c |  4 +-
 3 files changed, 46 insertions(+), 29 deletions(-)

diff --git a/app/test/test_bitset.c b/app/test/test_bitset.c
index 50b8bf0da4..45460204c1 100644
--- a/app/test/test_bitset.c
+++ b/app/test/test_bitset.c
@@ -99,11 +99,13 @@ typedef void clear_fun(uint64_t *bitset, size_t bit_num);
 typedef void assign_fun(uint64_t *bitset, size_t bit_num, bool value);
 typedef void flip_fun(uint64_t *bitset, size_t bit_num);
 
+#define RAND_SET_MAX_SIZE 1000
+
 static int
 test_set_clear_size(test_fun test_fun, set_fun set_fun, clear_fun clear_fun, 
size_t size)
 {
size_t i;
-   bool reference[size];
+   bool reference[RAND_SET_MAX_SIZE];
uint64_t *bitset;
 
rand_bool_ary(reference, size);
@@ -131,8 +133,7 @@ test_set_clear_size(test_fun test_fun, set_fun set_fun, 
clear_fun clear_fun, siz
return TEST_SUCCESS;
 }
 
-#define RAND_ITERATIONS (1)
-#define RAND_SET_MAX_SIZE (1000)
+#define RAND_ITERATIONS 1
 
 static int
 test_set_clear_fun(test_fun test_fun, set_fun set_fun, clear_fun clear_fun)
@@ -168,10 +169,20 @@ test_flip_size(test_fun test_fun, assign_fun assign_fun, 
flip_fun flip_fun, size
rand_bitset(bitset, size);
 
for (i = 0; i < size; i++) {
-   RTE_BITSET_DECLARE(reference, size);
+   RTE_BITSET_DECLARE(reference, RAND_SET_MAX_SIZE);
+
+#if defined(RTE_TOOLCHAIN_GCC) && (GCC_VERSION >= 11)
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Warray-bounds"
+#endif
 
+   /* gcc is giving false positives here when code is optimized */
rte_bitset_copy(reference, bitset, size);
 
+#if defined(RTE_TOOLCHAIN_GCC) && (GCC_VERSION >= 11)
+#pragma GCC diagnostic pop
+#endif
+
bool value = test_fun(bitset, i);
 
flip_fun(bitset, i);
@@ -282,13 +293,13 @@ find_clear(const bool *ary, size_t num_bools, size_t 
start, size_t len)
return find(ary, num_bools, start, len, false);
 }
 
-#define FFS_ITERATIONS (100)
+#define FFS_ITERATIONS 100
 
 static int
 test_find_size(size_t size, bool set)
 {
uint64_t *bitset;
-   bool reference[size];
+   bool reference[RAND_SET_MAX_SIZE];
size_t i;
 
bitset = alloc_bitset(size);
@@ -388,8 +399,8 @@ record_match(ssize_t match_idx, size_t size, int *calls)
 static int
 test_foreach_size(ssize_t size, bool may_wrap, bool set)
 {
-   bool reference[size];
-   int calls[size];
+   bool reference[RAND_SET_MAX_SIZE];
+   int calls[RAND_SET_MAX_SIZE];
uint64_t *bitset;
ssize_t i;
ssize_t start_bit;
@@ -633,17 +644,19 @@ test_define(void)
 typedef void bitset_op(uint64_t *dst, const uint64_t *a, const uint64_t *b, 
size_t bit_num);
 typedef bool bool_op(bool a, bool b);
 
+#define LOGIC_MAX_SET_SIZE 200
+
 static int
 test_logic_op(bitset_op bitset_op, bool_op bool_op)
 {
-   const size_t size = 1 + rte_rand_max(200);
-   RTE_BITSET_DECLARE(bitset_a, size);
-   RTE_BITSET_DECLARE(bitset_b, size);
-   RTE_BITSET_DECLARE(bitset_d, size);
+   const size_t size = 1 + rte_rand_max(LOGIC_MAX_SET_SIZE);
+   RTE_BITSET_DECLARE(bitset_a, LOGIC_MAX_SET_SIZE);
+   RTE_BITSET_DECLARE(bitset_b, LOGIC_MAX_SET_SIZE);
+   RTE_BITSET_DECLARE(bitset_d, LOGIC_MAX_SET_SIZE);
 
-   bool ary_a[size];
-   bool ary_b[size];
-   bool ary_d[size];
+   bool ary_a[LOGIC_MAX_SET_SIZE];
+   bool ary_b[LOGIC_MAX_SET_SIZE];
+   bool ary_d[LOGIC_MAX_SET_SIZE];
 
rand_bool_ary(ary_a, size);
rand_bool_ary(ary_b, size);
@@ -708,14 +721,14 @@ test_complement(void)
for (i = 0; i < RAND_ITERATIONS; i++) {
const size_t size = 1 + rte_rand_max(RAND_SET_MAX_SIZE - 1);
 
-   RTE_BITSET_DECLARE(src, size);
+   RTE_BITSET_DECLARE(src, RAND_SET_MAX_SIZE);
 
rand_bitset(src, size);
 
bool bit_idx = rte_rand_max(size);
bool bit_value = rte_bitset_test(src, bit_idx);
 
-   RTE_BITSET_DECLARE(dst, size);
+   RTE_BITSET_DECLARE(dst, RAND_SET_MAX_SIZE);
 
rte_bitset_complement(dst, src, size);
 
@@ -726,6 +739,8 @@ test_complement(void)
return TEST_SUCCESS;
 }
 
+#define SHIFT_SET_MAX_SIZE 500
+
 static int
 test_shift(bool right)
 {
@@ -734,12 +749,12 @@ test_shift(bool rig

[PATCH v11 15/21] net/i40e: remove use of VLAs for Windows built code

[Andre Muezerie]

From: Tyler Retzlaff 

MSVC does not support VLAs, replace VLAs with standard C arrays
or alloca(). alloca() is available for all toolchain/platform
combinations officially supported by DPDK.

Signed-off-by: Tyler Retzlaff 
Reviewed-by: Bruce Richardson 
---
 drivers/net/i40e/i40e_testpmd.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/net/i40e/i40e_testpmd.c b/drivers/net/i40e/i40e_testpmd.c
index b6ef5d6e42..21f596297b 100644
--- a/drivers/net/i40e/i40e_testpmd.c
+++ b/drivers/net/i40e/i40e_testpmd.c
@@ -2168,8 +2168,7 @@ cmd_ptype_mapping_get_parsed(void *parsed_result,
 {
struct cmd_ptype_mapping_get_result *res = parsed_result;
int ret = -ENOTSUP;
-   int max_ptype_num = 256;
-   struct rte_pmd_i40e_ptype_mapping mapping[max_ptype_num];
+   struct rte_pmd_i40e_ptype_mapping mapping[256];
uint16_t count;
int i;
 
@@ -2178,7 +2177,7 @@ cmd_ptype_mapping_get_parsed(void *parsed_result,
 
ret = rte_pmd_i40e_ptype_mapping_get(res->port_id,
mapping,
-   max_ptype_num,
+   RTE_DIM(mapping),
&count,
res->valid_only);
switch (ret) {
-- 
2.47.0.vfs.0.3

[PATCH v11 11/21] net/ice: remove use of VLAs

[Andre Muezerie]

From: Konstantin Ananyev 

../drivers/net/ice/ice_rxtx.c:1871:29: warning:
variable length array used [-Wvla]

Here VLA is used as a temp array for mbufs that will be used as a split
RX data buffers.
As at any given time only one thread can do RX from particular queue,
at rx_queue_setup() we can allocate extra space for that array, and then
safely use it at RX fast-path.

Signed-off-by: Konstantin Ananyev 
Acked-by: Anatoly Burakov 
---
 drivers/net/ice/ice_rxtx.c | 18 --
 drivers/net/ice/ice_rxtx.h |  2 ++
 2 files changed, 14 insertions(+), 6 deletions(-)

diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c
index 0c7106c7e0..578453ec89 100644
--- a/drivers/net/ice/ice_rxtx.c
+++ b/drivers/net/ice/ice_rxtx.c
@@ -1186,7 +1186,7 @@ ice_rx_queue_setup(struct rte_eth_dev *dev,
struct ice_vsi *vsi = pf->main_vsi;
struct ice_rx_queue *rxq;
const struct rte_memzone *rz;
-   uint32_t ring_size;
+   uint32_t ring_size, tlen;
uint16_t len;
int use_def_burst_func = 1;
uint64_t offloads;
@@ -1294,9 +1294,14 @@ ice_rx_queue_setup(struct rte_eth_dev *dev,
/* always reserve more for bulk alloc */
len = (uint16_t)(nb_desc + ICE_RX_MAX_BURST);
 
+   /* allocate extra entries for SW split buffer */
+   tlen = ((rxq->offloads & RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT) != 0) ?
+   rxq->rx_free_thresh : 0;
+   tlen += len;
+
/* Allocate the software ring. */
rxq->sw_ring = rte_zmalloc_socket(NULL,
- sizeof(struct ice_rx_entry) * len,
+ sizeof(struct ice_rx_entry) * tlen,
  RTE_CACHE_LINE_SIZE,
  socket_id);
if (!rxq->sw_ring) {
@@ -1305,6 +1310,8 @@ ice_rx_queue_setup(struct rte_eth_dev *dev,
return -ENOMEM;
}
 
+   rxq->sw_split_buf = (tlen == len) ? NULL : rxq->sw_ring + len;
+
ice_reset_rx_queue(rxq);
rxq->q_set = true;
dev->data->rx_queues[queue_idx] = rxq;
@@ -1883,7 +1890,6 @@ ice_rx_alloc_bufs(struct ice_rx_queue *rxq)
uint64_t dma_addr;
int diag, diag_pay;
uint64_t pay_addr;
-   struct rte_mbuf *mbufs_pay[rxq->rx_free_thresh];
 
/* Allocate buffers in bulk */
alloc_idx = (uint16_t)(rxq->rx_free_trigger -
@@ -1898,7 +1904,7 @@ ice_rx_alloc_bufs(struct ice_rx_queue *rxq)
 
if (rxq->offloads & RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT) {
diag_pay = rte_mempool_get_bulk(rxq->rxseg[1].mp,
-   (void *)mbufs_pay, rxq->rx_free_thresh);
+   (void *)rxq->sw_split_buf, rxq->rx_free_thresh);
if (unlikely(diag_pay != 0)) {
PMD_RX_LOG(ERR, "Failed to get payload mbufs in bulk");
return -ENOMEM;
@@ -1923,8 +1929,8 @@ ice_rx_alloc_bufs(struct ice_rx_queue *rxq)
rxdp[i].read.hdr_addr = 0;
rxdp[i].read.pkt_addr = dma_addr;
} else {
-   mb->next = mbufs_pay[i];
-   pay_addr = 
rte_cpu_to_le_64(rte_mbuf_data_iova_default(mbufs_pay[i]));
+   mb->next = rxq->sw_split_buf[i].mbuf;
+   pay_addr = 
rte_cpu_to_le_64(rte_mbuf_data_iova_default(mb->next));
rxdp[i].read.hdr_addr = dma_addr;
rxdp[i].read.pkt_addr = pay_addr;
}
diff --git a/drivers/net/ice/ice_rxtx.h b/drivers/net/ice/ice_rxtx.h
index 45f25b3609..20ee325c2b 100644
--- a/drivers/net/ice/ice_rxtx.h
+++ b/drivers/net/ice/ice_rxtx.h
@@ -139,6 +139,8 @@ struct ice_rx_queue {
uint32_t hw_time_high; /* high 32 bits of timestamp */
uint32_t hw_time_low; /* low 32 bits of timestamp */
uint64_t hw_time_update; /* SW time of HW record updating */
+   struct ice_rx_entry *sw_split_buf;
+   /* address of temp buffer for RX split mbufs */
struct rte_eth_rxseg_split rxseg[ICE_RX_MAX_NSEG];
uint32_t rxseg_nb;
bool ts_enable; /* if rxq timestamp is enabled */
-- 
2.47.0.vfs.0.3

[PATCH v11 21/21] hash: remove use of VLAs by using standard arrays

[Andre Muezerie]

MSVC does not support VLAs, replace VLAs with standard C arrays.

Signed-off-by: Andre Muezerie 
---
 lib/hash/rte_thash_gf2_poly_math.c | 9 -
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/lib/hash/rte_thash_gf2_poly_math.c 
b/lib/hash/rte_thash_gf2_poly_math.c
index 1c62974e71..825da4382f 100644
--- a/lib/hash/rte_thash_gf2_poly_math.c
+++ b/lib/hash/rte_thash_gf2_poly_math.c
@@ -8,6 +8,7 @@
 #include 
 #include 
 
+#define MAX_POLY_DEGREE 32
 #define MAX_TOEPLITZ_KEY_LENGTH 64
 RTE_LOG_REGISTER_SUFFIX(thash_poly_logtype, thash_poly, INFO);
 #define RTE_LOGTYPE_HASH thash_poly_logtype
@@ -149,7 +150,7 @@ gf2_pow(uint32_t a, uint32_t pow, uint32_t r, int degree)
 static uint32_t
 __thash_get_rand_poly(int poly_degree)
 {
-   uint32_t roots[poly_degree];
+   uint32_t roots[MAX_POLY_DEGREE];
uint32_t rnd;
uint32_t ret_poly = 0;
int i, j;
@@ -194,9 +195,7 @@ __thash_get_rand_poly(int poly_degree)
 * Get coefficients of the polynomial for
 * (x - roots[0])(x - roots[1])...(x - roots[n])
 */
-   uint32_t poly_coefficients[poly_degree + 1];
-   for (i = 0; i <= poly_degree; i++)
-   poly_coefficients[i] = 0;
+   uint32_t poly_coefficients[MAX_POLY_DEGREE + 1] = {0};
 
poly_coefficients[0] = 1; /* highest degree term coefficient in the end 
*/
for (i = 0; i < (int)poly_degree; i++) {
@@ -247,7 +246,7 @@ thash_get_rand_poly(uint32_t poly_degree)
 {
uint32_t ret_poly;
 
-   if (poly_degree > 32) {
+   if (poly_degree > MAX_POLY_DEGREE) {
HASH_LOG(ERR, "Wrong polynomial degree %d, must be in range [1, 
32]", poly_degree);
return 0;
}
-- 
2.47.0.vfs.0.3

[PATCH v11 10/21] net/ixgbe: remove use of VLAs

[Andre Muezerie]

From: Konstantin Ananyev 

1) ../drivers/net/ixgbe/ixgbe_ethdev.c:3556:46: warning:
variable length array used [-Wvla]
2) ../drivers/net/ixgbe/ixgbe_ethdev.c:3739:23: warning:
variable length array used [-Wvla]
3) ../drivers/net/ixgbe/ixgbe_rxtx_vec_common.h:17:24: warning:
variable length array used [-Wvla]

For first two cases: in fact ixgbe_xstats_calc_num() always returns
constant value, so it should be safe to replace that function invocation
just with a macro that performs same calculations.

For case #3: reassemble_packets() is invoked only by
ixgbe_recv_scattered_burst_vec().
And in turn, ixgbe_recv_scattered_burst_vec() operates only on fixed
max amount of packets per call: RTE_IXGBE_MAX_RX_BURST.
So, it should be safe to replace VLA with fixed size array.

Signed-off-by: Konstantin Ananyev 
Acked-by: Anatoly Burakov 
---
 drivers/net/ixgbe/ixgbe_ethdev.c  | 21 +
 drivers/net/ixgbe/ixgbe_rxtx_vec_common.h |  4 +++-
 2 files changed, 16 insertions(+), 9 deletions(-)

diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index eb431889c3..cdeab563c5 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -3435,11 +3435,16 @@ ixgbe_dev_stats_reset(struct rte_eth_dev *dev)
 }
 
 /* This function calculates the number of xstats based on the current config */
+
+#define IXGBE_XSTATS_CALC_NUM  \
+   (IXGBE_NB_HW_STATS + IXGBE_NB_MACSEC_STATS + \
+   (IXGBE_NB_RXQ_PRIO_STATS * IXGBE_NB_RXQ_PRIO_VALUES) + \
+   (IXGBE_NB_TXQ_PRIO_STATS * IXGBE_NB_TXQ_PRIO_VALUES))
+
 static unsigned
-ixgbe_xstats_calc_num(void) {
-   return IXGBE_NB_HW_STATS + IXGBE_NB_MACSEC_STATS +
-   (IXGBE_NB_RXQ_PRIO_STATS * IXGBE_NB_RXQ_PRIO_VALUES) +
-   (IXGBE_NB_TXQ_PRIO_STATS * IXGBE_NB_TXQ_PRIO_VALUES);
+ixgbe_xstats_calc_num(void)
+{
+   return IXGBE_XSTATS_CALC_NUM;
 }
 
 static int ixgbe_dev_xstats_get_names(__rte_unused struct rte_eth_dev *dev,
@@ -3555,8 +3560,8 @@ static int ixgbe_dev_xstats_get_names_by_id(
}
 
uint16_t i;
-   uint16_t size = ixgbe_xstats_calc_num();
-   struct rte_eth_xstat_name xstats_names_copy[size];
+   struct rte_eth_xstat_name xstats_names_copy[IXGBE_XSTATS_CALC_NUM];
+   const uint16_t size = RTE_DIM(xstats_names_copy);
 
ixgbe_dev_xstats_get_names_by_id(dev, NULL, xstats_names_copy,
size);
@@ -3738,8 +3743,8 @@ ixgbe_dev_xstats_get_by_id(struct rte_eth_dev *dev, const 
uint64_t *ids,
}
 
uint16_t i;
-   uint16_t size = ixgbe_xstats_calc_num();
-   uint64_t values_copy[size];
+   uint64_t values_copy[IXGBE_XSTATS_CALC_NUM];
+   const uint16_t size = RTE_DIM(values_copy);
 
ixgbe_dev_xstats_get_by_id(dev, NULL, values_copy, size);
 
diff --git a/drivers/net/ixgbe/ixgbe_rxtx_vec_common.h 
b/drivers/net/ixgbe/ixgbe_rxtx_vec_common.h
index a4d9ec9b08..c1cf0a581a 100644
--- a/drivers/net/ixgbe/ixgbe_rxtx_vec_common.h
+++ b/drivers/net/ixgbe/ixgbe_rxtx_vec_common.h
@@ -14,11 +14,13 @@ static inline uint16_t
 reassemble_packets(struct ixgbe_rx_queue *rxq, struct rte_mbuf **rx_bufs,
   uint16_t nb_bufs, uint8_t *split_flags)
 {
-   struct rte_mbuf *pkts[nb_bufs]; /*finished pkts*/
+   struct rte_mbuf *pkts[RTE_IXGBE_MAX_RX_BURST]; /*finished pkts*/
struct rte_mbuf *start = rxq->pkt_first_seg;
struct rte_mbuf *end =  rxq->pkt_last_seg;
unsigned int pkt_idx, buf_idx;
 
+   RTE_ASSERT(nb_bufs <= RTE_DIM(pkts));
+
for (buf_idx = 0, pkt_idx = 0; buf_idx < nb_bufs; buf_idx++) {
if (end != NULL) {
/* processing a split packet */
-- 
2.47.0.vfs.0.3

[PATCH v11 16/21] common/mlx5: remove use of VLAs for Windows built code

[Andre Muezerie]

From: Tyler Retzlaff 

MSVC does not support VLAs, replace VLAs with standard C arrays
or alloca(). alloca() is available for all toolchain/platform
combinations officially supported by DPDK.

Signed-off-by: Tyler Retzlaff 
---
 drivers/common/mlx5/mlx5_common.h| 4 ++--
 drivers/common/mlx5/mlx5_devx_cmds.c | 7 +++
 2 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/drivers/common/mlx5/mlx5_common.h 
b/drivers/common/mlx5/mlx5_common.h
index 1abd1e8239..f29f06a86e 100644
--- a/drivers/common/mlx5/mlx5_common.h
+++ b/drivers/common/mlx5/mlx5_common.h
@@ -125,10 +125,10 @@ mlx5_fp_debug_enabled(void)
 /* Allocate a buffer on the stack and fill it with a printf format string. */
 #define MKSTR(name, ...) \
int mkstr_size_##name = snprintf(NULL, 0, "" __VA_ARGS__); \
-   char name[mkstr_size_##name + 1]; \
+   char *name = alloca(mkstr_size_##name + 1); \
\
memset(name, 0, mkstr_size_##name + 1); \
-   snprintf(name, sizeof(name), "" __VA_ARGS__)
+   snprintf(name, mkstr_size_##name + 1, "" __VA_ARGS__)
 
 enum {
PCI_VENDOR_ID_MELLANOX = 0x15b3,
diff --git a/drivers/common/mlx5/mlx5_devx_cmds.c 
b/drivers/common/mlx5/mlx5_devx_cmds.c
index a75f011750..804ee67cd6 100644
--- a/drivers/common/mlx5/mlx5_devx_cmds.c
+++ b/drivers/common/mlx5/mlx5_devx_cmds.c
@@ -284,10 +284,9 @@ mlx5_devx_cmd_flow_counter_query(struct mlx5_devx_obj *dcs,
 void *cmd_comp,
 uint64_t async_id)
 {
-   int out_len = MLX5_ST_SZ_BYTES(query_flow_counter_out) +
-   MLX5_ST_SZ_BYTES(traffic_counter);
-   uint32_t out[out_len];
+   uint32_t out[MLX5_ST_SZ_BYTES(query_flow_counter_out) + 
MLX5_ST_SZ_BYTES(traffic_counter)];
uint32_t in[MLX5_ST_SZ_DW(query_flow_counter_in)] = {0};
+   const int out_len = RTE_DIM(out);
void *stats;
int rc;
 
@@ -346,7 +345,7 @@ mlx5_devx_cmd_mkey_create(void *ctx,
int klm_num = attr->klm_num;
int in_size_dw = MLX5_ST_SZ_DW(create_mkey_in) +
 (klm_num ? RTE_ALIGN(klm_num, 4) : 0) * MLX5_ST_SZ_DW(klm);
-   uint32_t in[in_size_dw];
+   uint32_t *in = alloca(sizeof(uint32_t) * in_size_dw);
uint32_t out[MLX5_ST_SZ_DW(create_mkey_out)] = {0};
void *mkc;
struct mlx5_devx_obj *mkey = mlx5_malloc(MLX5_MEM_ZERO, sizeof(*mkey),
-- 
2.47.0.vfs.0.3

Re: [PATCH v10 01/21] eal: include header required for alloca

[Andre Muezerie]

On Wed, Nov 20, 2024 at 09:12:15AM -0800, Stephen Hemminger wrote:
> On Tue, 19 Nov 2024 19:13:01 -0800
> Andre Muezerie  wrote:
> 
> > From: Tyler Retzlaff 
> > 
> > Include alloca.h for Linux and malloc.h for Windows to get declaration
> > of alloca().
> > 
> > Signed-off-by: Tyler Retzlaff 
> > ---
> >  lib/eal/linux/include/rte_os.h   | 1 +
> >  lib/eal/windows/include/rte_os.h | 1 +
> >  2 files changed, 2 insertions(+)
> 
> What about FreeBSD?
>   https://man.freebsd.org/cgi/man.cgi?alloca
> 
> Looks like to be pedantic stdlib.h should be included there.

Indeed. I'll include it.
Is FreeBSD tested when a patch is submitted? I did not see it in the list
of OSes/distros tested. I'm asking because it's always possible to break
something inadvertently if not tested.

Regards,
Andre

[PATCH v4 7/9] test/eal: fix core check in c flag test

[Stephen Hemminger]

The expression for checking which lcore is enabled for 0-7
was wrong (missing case for 6).

Link: https://pvs-studio.com/en/blog/posts/cpp/1179/

Fixes: b0209034f2bb ("test/eal: check number of cores before running subtests")
Cc: msant...@redhat.com
Cc: sta...@dpdk.org

Signed-off-by: Stephen Hemminger 
Acked-by: Bruce Richardson 
---
 app/test/test_eal_flags.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/app/test/test_eal_flags.c b/app/test/test_eal_flags.c
index d37d6b8627..e32f83d3c8 100644
--- a/app/test/test_eal_flags.c
+++ b/app/test/test_eal_flags.c
@@ -677,8 +677,8 @@ test_missing_c_flag(void)
 
if (rte_lcore_is_enabled(0) && rte_lcore_is_enabled(1) &&
rte_lcore_is_enabled(2) && rte_lcore_is_enabled(3) &&
-   rte_lcore_is_enabled(3) && rte_lcore_is_enabled(5) &&
-   rte_lcore_is_enabled(4) && rte_lcore_is_enabled(7) &&
+   rte_lcore_is_enabled(4) && rte_lcore_is_enabled(5) &&
+   rte_lcore_is_enabled(6) && rte_lcore_is_enabled(7) &&
launch_proc(argv29) != 0) {
printf("Error - "
   "process did not run ok with valid corelist value\n");
-- 
2.45.2

[PATCH v11 00/21] remove use of VLAs for Windows

[Andre Muezerie]

As per guidance technical board meeting 2024/04/17. This series
removes the use of VLAs from code built for Windows for all 3
toolchains. If there are additional opportunities to convert VLAs
to regular C arrays please provide the details for incorporation
into the series.

MSVC does not support VLAs, replace VLAs with standard C arrays
or alloca(). alloca() is available for all toolchain/platform
combinations officially supported by DPDK.

v11:
  * add include stdlib.h for alloca() declaration on FreeBSD
  * zero-initialize array without code loop
  * increase maximum tuple length

v10:
 * add ifdef to scope gcc's diagnostic error down to gcc only

v9:
 * fix sender's email address
 * fix gcc's diagnostic error string to make clang happy

v8:
 * rebase
 * reduce scope for disabling error "-Warray-bounds=" to only
   the place that needs it
 * remove parentesis around numbers from defines in test_bitset.c

v7:
 * remove use of VLA from new file which sneaked in during review

v6:
 * remove use of VLA from new test code added recently
 * fix title for patch 08/20

v5:
 * add patches for net/ice, net/ixgbe and gro
   from Konstantin Ananyev from
https://patchwork.dpdk.org/project/dpdk/list/?series=31972&archive=both&state=*
 * address debug_autotest ASan failure
 * address array-bound error in bitset_autotest with gcc-13

v4:
 * rebase and adapt for changes made in main since v3 was sent
 * use fixed maximum array size instead of VLA when doable

v3:
 * address checkpatch/check git log warnings (minor typos)

v2:
 * replace patches for ethdev, hash, rcu and include new
   patches for eal from Konstantin Ananyev
   from https://patchwork.dpdk.org/project/dpdk/list/?series=31781

Andre Muezerie (3):
  test: remove use of VLAs for Windows built code in bitset tests
  app/testpmd: remove use of VLAs for Windows built code in
shared_rxq_fwd
  hash: remove use of VLAs by using standard arrays

Konstantin Ananyev (10):
  eal/linux: remove use of VLAs
  eal/common: remove use of VLAs
  ethdev: remove use of VLAs for Windows built code
  hash: remove use of VLAs for Windows built code
  hash/thash: remove use of VLAs for Windows built
  rcu: remove use of VLAs for Windows built code
  gro: fix overwrite unprocessed packets
  gro: remove use of VLAs
  net/ixgbe: remove use of VLAs
  net/ice: remove use of VLAs

Tyler Retzlaff (8):
  eal: include header required for alloca
  app/testpmd: remove use of VLAs for Windows built
  test: remove use of VLAs for Windows built code
  common/idpf: remove use of VLAs for Windows built code
  net/i40e: remove use of VLAs for Windows built code
  common/mlx5: remove use of VLAs for Windows built code
  net/mlx5: remove use of VLAs for Windows built code
  build: enable vla warnings on Windows built code

 app/test-pmd/cmdline.c|   2 +-
 app/test-pmd/cmdline_flow.c   |  15 +-
 app/test-pmd/config.c |  16 +-
 app/test-pmd/shared_rxq_fwd.c |   2 +-
 app/test/test.c   |   2 +-
 app/test/test_bitset.c|  69 ---
 app/test/test_cmdline_string.c|   2 +-
 app/test/test_cryptodev.c |  34 ++--
 app/test/test_cryptodev_blockcipher.c |   4 +-
 app/test/test_cryptodev_crosscheck.c  |   2 +-
 app/test/test_dmadev.c|   9 +-
 app/test/test_hash.c  |  14 +-
 app/test/test_lcore_var_perf.c|   2 +-
 app/test/test_mempool.c   |  25 +--
 app/test/test_reassembly_perf.c   |   4 +-
 app/test/test_reorder.c   |  48 ++---
 app/test/test_service_cores.c |   9 +-
 app/test/test_thash.c |   7 +-
 config/meson.build|   4 +
 drivers/common/idpf/idpf_common_rxtx.c|   2 +-
 drivers/common/idpf/idpf_common_rxtx_avx512.c |   6 +-
 drivers/common/mlx5/mlx5_common.h |   4 +-
 drivers/common/mlx5/mlx5_devx_cmds.c  |   7 +-
 drivers/net/i40e/i40e_testpmd.c   |   5 +-
 drivers/net/ice/ice_rxtx.c|  18 +-
 drivers/net/ice/ice_rxtx.h|   2 +
 drivers/net/ixgbe/ixgbe_ethdev.c  |  21 +-
 drivers/net/ixgbe/ixgbe_rxtx_vec_common.h |   4 +-
 drivers/net/mlx5/mlx5.c   |   5 +-
 drivers/net/mlx5/mlx5_flow.c  |   6 +-
 lib/eal/common/eal_common_proc.c  |   5 +-
 lib/eal/freebsd/include/rte_os.h  |   1 +
 lib/eal/linux/eal_interrupts.c|  32 ++-
 lib/eal/linux/include/rte_os.h|   1 +
 lib/eal/windows/include/rte_os.h  |   1 +
 lib/ethdev/rte_ethdev.c   | 183 +++---
 lib/gro/rte_gro.c |  42 ++--
 lib/hash/rte_cuckoo_hash.c|   4 +-
 lib/hash/rte_thash.c  |   2 +-
 lib/ha

[PATCH v11 02/21] eal/linux: remove use of VLAs

[Andre Muezerie]

From: Konstantin Ananyev 

1) ./lib/eal/linux/eal_interrupts.c:1073:16
: warning: ISO C90 forbids variable length array ‘events’

MSVC does not support VLAs. Use alloca() to allocate the memory on
the stack.

2) ./lib/eal/linux/eal_interrupts.c:1319:16
: warning: ISO C90 forbids variable length array ‘evs’

make eal_epoll_wait() use a fixed size array and use it though multiple
iterations to process up to @maxevents events.
Note that technically it is not one to one replacement, as here we might
reduce number of events returned by first call to epoll_wait(..., timeout);

Signed-off-by: Konstantin Ananyev 
---
 lib/eal/linux/eal_interrupts.c | 32 +++-
 1 file changed, 27 insertions(+), 5 deletions(-)

diff --git a/lib/eal/linux/eal_interrupts.c b/lib/eal/linux/eal_interrupts.c
index 6436f796eb..23039964fc 100644
--- a/lib/eal/linux/eal_interrupts.c
+++ b/lib/eal/linux/eal_interrupts.c
@@ -34,6 +34,8 @@
 #define EAL_INTR_EPOLL_WAIT_FOREVER (-1)
 #define NB_OTHER_INTR   1
 
+#define MAX_ITER_EVNUM RTE_EVENT_ETH_INTR_RING_SIZE
+
 static RTE_DEFINE_PER_LCORE(int, _epfd) = -1; /**< epoll fd per thread */
 
 /**
@@ -1070,7 +1072,7 @@ eal_intr_process_interrupts(struct epoll_event *events, 
int nfds)
 static void
 eal_intr_handle_interrupts(int pfd, unsigned totalfds)
 {
-   struct epoll_event events[totalfds];
+   struct epoll_event *events = alloca(sizeof(struct epoll_event) * 
totalfds);
int nfds = 0;
 
for(;;) {
@@ -1316,8 +1318,9 @@ static int
 eal_epoll_wait(int epfd, struct rte_epoll_event *events,
   int maxevents, int timeout, bool interruptible)
 {
-   struct epoll_event evs[maxevents];
int rc;
+   uint32_t i, k, n, num;
+   struct epoll_event evs[MAX_ITER_EVNUM];
 
if (!events) {
EAL_LOG(ERR, "rte_epoll_event can't be NULL");
@@ -1328,12 +1331,31 @@ eal_epoll_wait(int epfd, struct rte_epoll_event *events,
if (epfd == RTE_EPOLL_PER_THREAD)
epfd = rte_intr_tls_epfd();
 
+   num = maxevents;
+   n = RTE_MIN(RTE_DIM(evs), num);
+
+   /* Process events in chunks of MAX_ITER_EVNUM */
+
while (1) {
-   rc = epoll_wait(epfd, evs, maxevents, timeout);
+   rc = epoll_wait(epfd, evs, n, timeout);
if (likely(rc > 0)) {
+
/* epoll_wait has at least one fd ready to read */
-   rc = eal_epoll_process_event(evs, rc, events);
-   break;
+   for (i = 0, k = 0; rc > 0;) {
+   k += rc;
+   rc = eal_epoll_process_event(evs, rc,
+   events + i);
+   i += rc;
+
+   /*
+* try to read more events that are already
+* available (up to maxevents in total).
+*/
+   n = RTE_MIN(RTE_DIM(evs), num - k);
+   rc = (n == 0) ? 0 : epoll_wait(epfd, evs, n, 0);
+   }
+   return i;
+
} else if (rc < 0) {
if (errno == EINTR) {
if (interruptible)
-- 
2.47.0.vfs.0.3

[PATCH v11 20/21] app/testpmd: remove use of VLAs for Windows built code in shared_rxq_fwd

[Andre Muezerie]

MSVC does not support VLAs, replace VLAs with standard C arrays
or alloca(). alloca() is available for all toolchain/platform
combinations officially supported by DPDK.

Signed-off-by: Andre Muezerie 
---
 app/test-pmd/shared_rxq_fwd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/test-pmd/shared_rxq_fwd.c b/app/test-pmd/shared_rxq_fwd.c
index 623d62da88..b85830b90e 100644
--- a/app/test-pmd/shared_rxq_fwd.c
+++ b/app/test-pmd/shared_rxq_fwd.c
@@ -92,7 +92,7 @@ forward_shared_rxq(struct fwd_stream *fs, uint16_t nb_rx,
 static bool
 shared_rxq_fwd(struct fwd_stream *fs)
 {
-   struct rte_mbuf *pkts_burst[nb_pkt_per_burst];
+   struct rte_mbuf *pkts_burst[MAX_PKT_BURST];
uint16_t nb_rx;
 
nb_rx = common_fwd_stream_receive(fs, pkts_burst, nb_pkt_per_burst);
-- 
2.47.0.vfs.0.3

Re: [PATCH v4 9/9] app/test-pmd: avoid potential outside of array reference

[fengchengwen]

Acked-by: Chengwen Feng 

On 2024/11/22 2:23, Stephen Hemminger wrote:
> The order of comparison is wrong, and potentially allows
> referencing past the array.
> 
> Link: https://pvs-studio.com/en/blog/posts/cpp/1179/
> 
> Fixes: 3e3edab530a1 ("ethdev: add flow quota")
> Cc: getel...@nvidia.com
> Cc: sta...@dpdk.org
> 
> Signed-off-by: Stephen Hemminger 
> Acked-by: Bruce Richardson 
> ---
>  app/test-pmd/cmdline_flow.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
> index 1e4f2ebc55..9e4fc2d95d 100644
> --- a/app/test-pmd/cmdline_flow.c
> +++ b/app/test-pmd/cmdline_flow.c
> @@ -12892,7 +12892,7 @@ comp_names_to_index(struct context *ctx, const struct 
> token *token,
>   RTE_SET_USED(token);
>   if (!buf)
>   return names_size;
> - if (names[ent] && ent < names_size)
> + if (ent < names_size && names[ent] != NULL)
>   return rte_strscpy(buf, names[ent], size);
>   return -1;
>  

Re: [PATCH v4 1/9] app/test: do not duplicate loop variable

[fengchengwen]

Acked-by: Chengwen Feng 

On 2024/11/22 2:23, Stephen Hemminger wrote:
> Do not use same variable for outer and inner loop in bonding test.
> Since the loop is just freeing the resulting burst use bulk free.
> 
> Link: https://pvs-studio.com/en/blog/posts/cpp/1179/
> 
> Fixes: 92073ef961ee ("bond: unit tests")
> Cc: declan.dohe...@intel.com
> Cc: sta...@dpdk.org
> 
> Signed-off-by: Stephen Hemminger 
> Acked-by: Bruce Richardson 
> ---
>  app/test/test_link_bonding.c | 7 +--
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/app/test/test_link_bonding.c b/app/test/test_link_bonding.c
> index 4d54706c21..805613d7dd 100644
> --- a/app/test/test_link_bonding.c
> +++ b/app/test/test_link_bonding.c
> @@ -2288,12 +2288,7 @@ test_activebackup_rx_burst(void)
>   }
>  
>   /* free mbufs */
> - for (i = 0; i < MAX_PKT_BURST; i++) {
> - if (rx_pkt_burst[i] != NULL) {
> - rte_pktmbuf_free(rx_pkt_burst[i]);
> - rx_pkt_burst[i] = NULL;
> - }
> - }
> + rte_pktmbuf_free_bulk(rx_pkt_burst, burst_size);
>  
>   /* reset bonding device stats */
>   rte_eth_stats_reset(test_params->bonding_port_id);

答复: r8169 throughput

[王颢]

Dear Thomas,

Sure, r8169pmd will support more network cards, such as the 1G NICs (rtl8168 
series).

Best Wishes,
Howard Wang

-邮件原件-
发件人: Thomas Monjalon  
发送时间: 2024年11月21日 18:33
收件人: 王颢 
抄送: dev@dpdk.org; pro_nic_d...@realtek.com; Stephen Hemminger 
; ferruh.yi...@amd.com
主题: Re: r8169 throughput


External mail.



21/11/2024 10:32, Howard Wang:
> Dear Thomas,
>
> As you expected, I have attached the throughput under this release.
> My testing was conducted using pktgen 24.10.3. I just set the size and 
> then start all. The test results are as follows:
>
> size/throughputrtl8125brtl8126
> 641709 MBit/s  3080 MBit/s
> 128   2272 MBit/s  4265 MBit/s
> 256   2500 MBit/s  4982 MBit/s
> 512   2500 MBit/s  5000 MBit/s
> 1024  2500 MBit/s  5000 MBit/s
> 1280  2500 MBit/s  5000 MBit/s
> 1518  2500 MBit/s  5000 MBit/s

Interesting, thank you.

Do you plan to support more devices?

[PATCH v2] doc: reword glossary

[Nandini Persad]

I added additional reference links and definitions to many
of the terms in the glossary. Please feel free to provide
feedback to ensure my definitions suit the proper context
in the DPDK community.

Signed-off-by: Nandini Persad 
---
 doc/guides/prog_guide/glossary.rst | 101 ++---
 1 file changed, 78 insertions(+), 23 deletions(-)

diff --git a/doc/guides/prog_guide/glossary.rst 
b/doc/guides/prog_guide/glossary.rst
index 8d6349701e..9f85e46437 100644
--- a/doc/guides/prog_guide/glossary.rst
+++ b/doc/guides/prog_guide/glossary.rst
@@ -6,70 +6,92 @@ Glossary
 
 
 ACL
-   Access Control List
+   An access control list (ACL) is a set of rules that define who can access a 
resource and what actions they can perform.
+   `ACL Link 
`_
 
 API
Application Programming Interface
 
 ASLR
Linux* kernel Address-Space Layout Randomization
+   A computer security technique that protects against buffer overflow attacks 
by randomizing the location of executables in memory in Linux.
+   `ASLR Link 
`_
 
 BSD
-   Berkeley Software Distribution
+   Berkeley Software Distribution is a Unix-like operating system.
 
 Clr
Clear
 
 CIDR
Classless Inter-Domain Routing
+   A method of assigning IP address that improves data routing efficiency on 
the internet and is used in IPv4 and IPv6.
+   `RFC Link `_
 
 Control Plane
-   The control plane is concerned with the routing of packets and with
-   providing a start or end point.
+   A Control Plane is a key concept in networking that refers to the part of a 
network system
+   responsible for managing and making decisions about where and how data 
packets are forwarded within a network.
 
 Core
-   A core may include several lcores or threads if the processor supports
-   hyperthreading.
+   A core may include several lcores or threads if the processor supports 
simultaneous multithreading (SMT).
+   `Simultaneous Multithreading 
`_
 
 Core Components
-   A set of libraries provided by the DPDK, including eal, ring, mempool,
-   mbuf, timers, and so on.
+   A set of libraries provided by DPDK which are used by nearly all 
applications and
+   upon which other DPDK libraries and drivers depend. For example, eal, ring, 
mempool and mbuf.
 
 CPU
Central Processing Unit
 
 CRC
Cyclic Redundancy Check
+   An algorithm that detects errors in data transmission and storage.
 
 Data Plane
-   In contrast to the control plane, the data plane in a network architecture
-   are the layers involved when forwarding packets.  These layers must be
-   highly optimized to achieve good performance.
+   In contrast to the control plane, which is responsible for setting up and 
managing data connections,
+   the data plane in a network architecture includes the layers involved when 
processing and forwarding
+   data packets between communicating endpoints. These layers must be highly 
optimized to achieve good performance.
 
 DIMM
Dual In-line Memory Module
+   A module containing one or several Random Access Memory (RAM) or Dynamic 
RAM (DRAM) chips on a printed
+   circuit board that connect it directly to the computer motherboard.
 
 Doxygen
A documentation generator used in the DPDK to generate the API reference.
+   `Doxygen Link `_
 
 DPDK
Data Plane Development Kit
 
 DRAM
Dynamic Random Access Memory
+   A type of random access memory (RAM) that is used in computers to 
temporarily store information.
+   `Link `_
 
 EAL
-   The Environment Abstraction Layer (EAL) provides a generic interface that
-   hides the environment specifics from the applications and libraries.  The
-   services expected from the EAL are: development kit loading and launching,
-   core affinity/ assignment procedures, system memory allocation/description,
-   PCI bus access, inter-partition communication.
+   The Environment Abstraction Layer (EAL) is a DPDK core library that 
provides a generic interface
+   that hides the environment specifics from the applications and libraries. 
The services expected
+   from the EAL are: development kit loading and launching, core affinity/ 
assignment procedures, system
+   memory allocation/description, PCI bus access, inter-partition 
communication.
+   `Link 
`_
+
+EAL Thread
+   An EAL thread is typically a thread that runs packet processing tasks. 
These threads are often
+   pinned to logical cores (lcores), which helps to ensure that packet 
processing task

Re: [PATCH v12 13/21] test: remove use of VLAs for Windows built code

[fengchengwen]

Acked-by: Chengwen Feng 

On 2024/11/22 5:41, Andre Muezerie wrote:
> From: Tyler Retzlaff 
> 
> MSVC does not support VLAs, replace VLAs with standard C arrays
> or alloca(). alloca() is available for all toolchain/platform
> combinations officially supported by DPDK.
> 
> Signed-off-by: Tyler Retzlaff 

Re: [PATCH v12 04/21] ethdev: remove use of VLAs for Windows built code

[fengchengwen]

On 2024/11/22 5:41, Andre Muezerie wrote:
> From: Konstantin Ananyev 
> 
> 1) ./lib/ethdev/rte_ethdev.c:3244:16
> : warning: ISO C90 forbids variable length array ‘xstats_names’
> 2) ./lib/ethdev/rte_ethdev.c:3345:17
> : warning: ISO C90 forbids variable length array ‘ids_copy’
> 3) ./lib/ethdev/rte_ethdev.c:3538:16
> : warning: ISO C90 forbids variable length array ‘xstats’
> 4) ./lib/ethdev/rte_ethdev.c:3554:17
> : warning: ISO C90 forbids variable length array ‘ids_copy’
> 
> For 1) and 3) - just replaced VLA with arrays allocated from heap.
> As I understand xstats extraction belongs to control-path, so extra
> calloc/free is hopefully acceptable.
> Also ethdev xstats already doing that within
> rte_eth_xstats_get_id_by_name().
> For 2) and 4) changed the code to use fixed size array and call
> appropriate devops function several times, if needed.

It will invoke PMD ops multi-times, I'm not sure whether all drivers
impl correctly.

And it also belong control-path, so suggest use the call/free as 1&3 case.

Re: [PATCH v12 05/21] hash: remove use of VLAs for Windows built code

[fengchengwen]

Acked-by: Chengwen Feng 

On 2024/11/22 5:41, Andre Muezerie wrote:
> From: Konstantin Ananyev 
> 
> 1) ./lib/hash/rte_cuckoo_hash.c:2362:9
> : warning: ISO C90 forbids variable length array ‘positions’
> 2) ../lib/hash/rte_cuckoo_hash.c:2478:9
> : warning: ISO C90 forbids variable length array ‘positions’
> 
> Both rte_hash_lookup_bulk_data() and
> rte_hash_lookup_with_hash_bulk_data() expect
> @num_keys <= RTE_HASH_LOOKUP_BULK_MAX.
> So, for both cases it should be safe to replace VLA with fixed size
> array.
> 
> Signed-off-by: Konstantin Ananyev 
> Reviewed-by: Bruce Richardson 
> Acked-by: Vladimir Medvedkin 
> ---
>  lib/hash/rte_cuckoo_hash.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/hash/rte_cuckoo_hash.c b/lib/hash/rte_cuckoo_hash.c
> index 9575e8aa0c..fc93182efe 100644
> --- a/lib/hash/rte_cuckoo_hash.c
> +++ b/lib/hash/rte_cuckoo_hash.c
> @@ -2418,7 +2418,7 @@ rte_hash_lookup_bulk_data(const struct rte_hash *h, 
> const void **keys,
>   (num_keys > RTE_HASH_LOOKUP_BULK_MAX) ||
>   (hit_mask == NULL)), -EINVAL);
>  
> - int32_t positions[num_keys];
> + int32_t positions[RTE_HASH_LOOKUP_BULK_MAX];
>  
>   __rte_hash_lookup_bulk(h, keys, num_keys, positions, hit_mask, data);
>  
> @@ -2534,7 +2534,7 @@ rte_hash_lookup_with_hash_bulk_data(const struct 
> rte_hash *h,
>   (num_keys > RTE_HASH_LOOKUP_BULK_MAX) ||
>   (hit_mask == NULL)), -EINVAL);
>  
> - int32_t positions[num_keys];
> + int32_t positions[RTE_HASH_LOOKUP_BULK_MAX];
>  
>   __rte_hash_lookup_with_hash_bulk(h, keys, sig, num_keys,
>   positions, hit_mask, data);

Re: [PATCH v4 3/9] app/test: fix paren typo

[fengchengwen]

Acked-by: Chengwen Feng 

On 2024/11/22 2:23, Stephen Hemminger wrote:
> The parenthesis were in the wrong place so that comparison
> took precedence over assignment in handling IPv6 extension
> headers.  Break up the loop condition to avoid the problem.
> 
> Link: https://pvs-studio.com/en/blog/posts/cpp/1179/
> 
> Fixes: 15ccc647526e ("test/security: test inline reassembly with 
> multi-segment")
> Cc: ndabilpu...@marvell.com
> Cc: sta...@dpdk.org
> 
> Signed-off-by: Stephen Hemminger 
> Acked-by: Bruce Richardson 
> ---
>  app/test/test_security_inline_proto_vectors.h | 8 +---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/app/test/test_security_inline_proto_vectors.h 
> b/app/test/test_security_inline_proto_vectors.h
> index b3d724bac6..86dfa54777 100644
> --- a/app/test/test_security_inline_proto_vectors.h
> +++ b/app/test/test_security_inline_proto_vectors.h
> @@ -519,10 +519,12 @@ test_vector_payload_populate(struct 
> ip_reassembly_test_packet *pkt,
>   if (extra_data_sum) {
>   proto = hdr->proto;
>   p += sizeof(struct rte_ipv6_hdr);
> - while (proto != IPPROTO_FRAGMENT &&
> -(proto = rte_ipv6_get_next_ext(p, proto, 
> &ext_len) >= 0))
> + while (proto != IPPROTO_FRAGMENT) {
> + proto = rte_ipv6_get_next_ext(p, proto, 
> &ext_len);
> + if (proto < 0)
> + break;
>   p += ext_len;
> -
> + }
>   /* Found fragment header, update the frag 
> offset */
>   if (proto == IPPROTO_FRAGMENT) {
>   frag_ext = (struct 
> rte_ipv6_fragment_ext *)p;

Re: [PATCH v4 2/9] app/test: fix typo in address compare

[fengchengwen]

Acked-by: Chengwen Feng 

On 2024/11/22 2:23, Stephen Hemminger wrote:
> The first argument of 'memcmp' function was equal to the second argument.
> Therefore ASSERT would always be true.
> 
> Link: https://pvs-studio.com/en/blog/posts/cpp/1179/
> 
> Fixes: 92073ef961ee ("bond: unit tests")
> Cc: declan.dohe...@intel.com
> Cc: sta...@dpdk.org
> 
> Signed-off-by: Stephen Hemminger 
> ---
>  app/test/test_link_bonding.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/app/test/test_link_bonding.c b/app/test/test_link_bonding.c
> index 805613d7dd..b752a5ecbf 100644
> --- a/app/test/test_link_bonding.c
> +++ b/app/test/test_link_bonding.c
> @@ -792,7 +792,7 @@ test_set_primary_member(void)
>   &read_mac_addr),
>   "Failed to get mac address (port %d)",
>   test_params->bonding_port_id);
> - TEST_ASSERT_SUCCESS(memcmp(&read_mac_addr, &read_mac_addr,
> + TEST_ASSERT_SUCCESS(memcmp(expected_mac_addr, &read_mac_addr,
>   sizeof(read_mac_addr)),
>   "bonding port mac address not set to that of 
> primary port\n");
>  

Re: [PATCH v12 06/21] hash/thash: remove use of VLAs for Windows built

[fengchengwen]

On 2024/11/22 5:41, Andre Muezerie wrote:
> From: Konstantin Ananyev 
> 
> 1) ./lib/hash/rte_thash.c:774:9
> : warning: ISO C90 forbids variable length array ‘tmp_tuple’
> 
> The tuple can exceed sizeof(union rte_thash_tuple), for example if any
> tunneling header is used in the RSS hash calculation.
> 
> The longest RSS hash key currently supported is 52 bytes. Technically, the
> longest tuple with such a key should be (52 - sizeof(uint32_t)), so this
> can be used as a size of the tmp_tuple array.
> 
> Signed-off-by: Konstantin Ananyev 
> ---
>  lib/hash/rte_thash.c | 2 +-
>  lib/hash/rte_thash.h | 7 +++
>  2 files changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/lib/hash/rte_thash.c b/lib/hash/rte_thash.c
> index 336c228e64..fa78787143 100644
> --- a/lib/hash/rte_thash.c
> +++ b/lib/hash/rte_thash.c
> @@ -761,7 +761,7 @@ rte_thash_adjust_tuple(struct rte_thash_ctx *ctx,
>   uint32_t desired_value, unsigned int attempts,
>   rte_thash_check_tuple_t fn, void *userdata)
>  {

This API support parameter check, how about add tuple_len > 
RTE_THASH_TUPLE_LEN_MAX ?

> - uint32_t tmp_tuple[tuple_len / sizeof(uint32_t)];
> + uint32_t tmp_tuple[RTE_THASH_TUPLE_LEN_MAX];
>   unsigned int i, j, ret = 0;
>   uint32_t hash, adj_bits;
>   const uint8_t *hash_key;
> diff --git a/lib/hash/rte_thash.h b/lib/hash/rte_thash.h
> index c0af5968df..04f9f1875c 100644
> --- a/lib/hash/rte_thash.h
> +++ b/lib/hash/rte_thash.h
> @@ -121,6 +121,13 @@ __rte_internal
>  uint32_t
>  thash_get_rand_poly(uint32_t poly_degree);
>  
> +/**
> + * Longest RSS hash key currently supported
> + */
> +#define RTE_THASH_KEY_LEN_MAX52
> +
> +#define RTE_THASH_TUPLE_LEN_MAX (RTE_THASH_KEY_LEN_MAX - sizeof(uint32_t))
> +
>  /**
>   * Prepare special converted key to use with rte_softrss_be()
>   * @param orig

Re: [PATCH v12 20/21] app/testpmd: remove use of VLAs for Windows built code in shared_rxq_fwd

[fengchengwen]

Acked-by: Chengwen Feng 

On 2024/11/22 5:41, Andre Muezerie wrote:
> MSVC does not support VLAs, replace VLAs with standard C arrays
> or alloca(). alloca() is available for all toolchain/platform
> combinations officially supported by DPDK.
> 
> Signed-off-by: Andre Muezerie 
> ---
>  app/test-pmd/shared_rxq_fwd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/app/test-pmd/shared_rxq_fwd.c b/app/test-pmd/shared_rxq_fwd.c
> index 623d62da88..b85830b90e 100644
> --- a/app/test-pmd/shared_rxq_fwd.c
> +++ b/app/test-pmd/shared_rxq_fwd.c
> @@ -92,7 +92,7 @@ forward_shared_rxq(struct fwd_stream *fs, uint16_t nb_rx,
>  static bool
>  shared_rxq_fwd(struct fwd_stream *fs)
>  {
> - struct rte_mbuf *pkts_burst[nb_pkt_per_burst];
> + struct rte_mbuf *pkts_burst[MAX_PKT_BURST];
>   uint16_t nb_rx;
>  
>   nb_rx = common_fwd_stream_receive(fs, pkts_burst, nb_pkt_per_burst);

[PATCH] doc: reword glossary

[Nandini Persad]

I added additional reference links and definitions to many
of the terms in the glossary. Please feel free to provide
feedback to ensure my definitions suit the proper context
in the DPDK community.

Signed-off-by: Nandini Persad 
---
 doc/guides/prog_guide/glossary.rst | 107 ++---
 1 file changed, 81 insertions(+), 26 deletions(-)

diff --git a/doc/guides/prog_guide/glossary.rst 
b/doc/guides/prog_guide/glossary.rst
index 8d6349701e..fc79e9656f 100644
--- a/doc/guides/prog_guide/glossary.rst
+++ b/doc/guides/prog_guide/glossary.rst
@@ -6,70 +6,92 @@ Glossary
 
 
 ACL
-   Access Control List
+   An access control list (ACL) is a set of rules that define who can access a 
resource and what actions they can perform. 
+   `ACL Link 
`_
 
 API
Application Programming Interface
 
 ASLR
Linux* kernel Address-Space Layout Randomization
+   A computer security technique that protects against buffer overflow attacks 
by randomizing the location of executables in memory in Linux. 
+   `ASLR Link 
`_
 
 BSD
-   Berkeley Software Distribution
+   Berkeley Software Distribution is a Unix-like operating system.
 
 Clr
Clear
 
 CIDR
Classless Inter-Domain Routing
+   A method of assigning IP address that improves data routing efficiency on 
the internet and is used in IPv4 and IPv6.
+   `RFC Link `_
 
 Control Plane
-   The control plane is concerned with the routing of packets and with
-   providing a start or end point.
+   A Control Plane is a key concept in networking that refers to the part of a 
network system
+   responsible for managing and making decisions about where and how data 
packets are forwarded within a network.
 
 Core
-   A core may include several lcores or threads if the processor supports
-   hyperthreading.
+   A core may include several lcores or threads if the processor supports 
simultaneous multithreading (SMT).
+   `Simultaneous Multithreading 
`_
 
 Core Components
-   A set of libraries provided by the DPDK, including eal, ring, mempool,
-   mbuf, timers, and so on.
+   A set of libraries provided by DPDK which are used by nearly all 
applications and
+   upon which other DPDK libraries and drivers depend. For example, eal, ring, 
mempool and mbuf.
 
 CPU
Central Processing Unit
 
 CRC
Cyclic Redundancy Check
+   An algorithm that detects errors in data transmission and storage.
 
 Data Plane
-   In contrast to the control plane, the data plane in a network architecture
-   are the layers involved when forwarding packets.  These layers must be
-   highly optimized to achieve good performance.
+   In contrast to the control plane, which is responsible for setting up and 
managing data connections,
+   the data plane in a network architecture includes the layers involved when 
processing and forwarding
+   data packets between communicating endpoints. These layers must be highly 
optimized to achieve good performance.
 
 DIMM
Dual In-line Memory Module
-
+   A module containing one or several Random Access Memory (RAM) or Dynamic 
RAM (DRAM) chips on a printed
+   circuit board that connect it directly to the computer motherboard.
+   
 Doxygen
A documentation generator used in the DPDK to generate the API reference.
+   `Doxygen Link `_
 
 DPDK
Data Plane Development Kit
 
 DRAM
Dynamic Random Access Memory
+   A type of random access memory (RAM) that is used in computers to 
temporarily store information.
+   `Link `_
 
 EAL
-   The Environment Abstraction Layer (EAL) provides a generic interface that
-   hides the environment specifics from the applications and libraries.  The
-   services expected from the EAL are: development kit loading and launching,
-   core affinity/ assignment procedures, system memory allocation/description,
-   PCI bus access, inter-partition communication.
-
+   The Environment Abstraction Layer (EAL) is a DPDK core library that 
provides a generic interface
+   that hides the environment specifics from the applications and libraries. 
The services expected
+   from the EAL are: development kit loading and launching, core affinity/ 
assignment procedures, system
+   memory allocation/description, PCI bus access, inter-partition 
communication.
+   `Link 
`_
+
+EAL Thread
+   An EAL thread is typically a thread that runs packet processing tasks. 
These threads are often
+   pinned to logical cores (lcores), which helps to ensure that packet 
proces

[PATCH v12 01/21] eal: include header required for alloca

[Andre Muezerie]

From: Tyler Retzlaff 

Include alloca.h for Linux and malloc.h for Windows to get declaration
of alloca().

Signed-off-by: Tyler Retzlaff 
---
 lib/eal/freebsd/include/rte_os.h | 1 +
 lib/eal/linux/include/rte_os.h   | 1 +
 lib/eal/windows/include/rte_os.h | 1 +
 3 files changed, 3 insertions(+)

diff --git a/lib/eal/freebsd/include/rte_os.h b/lib/eal/freebsd/include/rte_os.h
index 62e70dc15b..94b9275beb 100644
--- a/lib/eal/freebsd/include/rte_os.h
+++ b/lib/eal/freebsd/include/rte_os.h
@@ -11,6 +11,7 @@
  */
 
 #include 
+#include /* Declares alloca() */
 #include 
 
 /* These macros are compatible with system's sys/queue.h. */
diff --git a/lib/eal/linux/include/rte_os.h b/lib/eal/linux/include/rte_os.h
index 35c07c70cb..20eff0409a 100644
--- a/lib/eal/linux/include/rte_os.h
+++ b/lib/eal/linux/include/rte_os.h
@@ -10,6 +10,7 @@
  * which is not supported natively or named differently in Linux.
  */
 
+#include 
 #include 
 #include 
 
diff --git a/lib/eal/windows/include/rte_os.h b/lib/eal/windows/include/rte_os.h
index 9d69467aaa..d09adeb3b4 100644
--- a/lib/eal/windows/include/rte_os.h
+++ b/lib/eal/windows/include/rte_os.h
@@ -13,6 +13,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include 
 
-- 
2.47.0.vfs.0.3

[PATCH v11 05/21] hash: remove use of VLAs for Windows built code

[Andre Muezerie]

From: Konstantin Ananyev 

1) ./lib/hash/rte_cuckoo_hash.c:2362:9
: warning: ISO C90 forbids variable length array ‘positions’
2) ../lib/hash/rte_cuckoo_hash.c:2478:9
: warning: ISO C90 forbids variable length array ‘positions’

Both rte_hash_lookup_bulk_data() and
rte_hash_lookup_with_hash_bulk_data() expect
@num_keys <= RTE_HASH_LOOKUP_BULK_MAX.
So, for both cases it should be safe to replace VLA with fixed size
array.

Signed-off-by: Konstantin Ananyev 
Reviewed-by: Bruce Richardson 
Acked-by: Vladimir Medvedkin 
---
 lib/hash/rte_cuckoo_hash.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/hash/rte_cuckoo_hash.c b/lib/hash/rte_cuckoo_hash.c
index 9575e8aa0c..fc93182efe 100644
--- a/lib/hash/rte_cuckoo_hash.c
+++ b/lib/hash/rte_cuckoo_hash.c
@@ -2418,7 +2418,7 @@ rte_hash_lookup_bulk_data(const struct rte_hash *h, const 
void **keys,
(num_keys > RTE_HASH_LOOKUP_BULK_MAX) ||
(hit_mask == NULL)), -EINVAL);
 
-   int32_t positions[num_keys];
+   int32_t positions[RTE_HASH_LOOKUP_BULK_MAX];
 
__rte_hash_lookup_bulk(h, keys, num_keys, positions, hit_mask, data);
 
@@ -2534,7 +2534,7 @@ rte_hash_lookup_with_hash_bulk_data(const struct rte_hash 
*h,
(num_keys > RTE_HASH_LOOKUP_BULK_MAX) ||
(hit_mask == NULL)), -EINVAL);
 
-   int32_t positions[num_keys];
+   int32_t positions[RTE_HASH_LOOKUP_BULK_MAX];
 
__rte_hash_lookup_with_hash_bulk(h, keys, sig, num_keys,
positions, hit_mask, data);
-- 
2.47.0.vfs.0.3

Re: [PATCH v10 06/21] hash/thash: remove use of VLAs for Windows built

[Andre Muezerie]

On Wed, Nov 20, 2024 at 10:40:07AM +, Medvedkin, Vladimir wrote:
> Hi Andre,
> 
> On 20/11/2024 03:13, Andre Muezerie wrote:
> >From: Konstantin Ananyev
> >
> >1) ./lib/hash/rte_thash.c:774:9
> > : warning: ISO C90 forbids variable length array ‘tmp_tuple’
> >
> > From my understanding, tuple size here should never exceed
> >sizeof(union rte_thash_tuple), so it should be safe to replace VLA with
> >fixed size array.
> 
> The tuple can exceed this size, for example if you use any tunneling
> header in RSS hash calculation.
> 
> HereIsuggestusingasa limitthe sizeof
> thelongestRSShashkeycurrentlysupported,whichis52bytes. Technically,
> the longest tuple with such a key should be (52 - sizeof(uint32_t)),
> so you can use this as a size of the tmp_tuple array
> 

Thanks, I'll update the code accordingly.

Andre

> >
> >Signed-off-by: Konstantin Ananyev
> >---
> >  lib/hash/rte_thash.c | 2 +-
> >  lib/hash/rte_thash.h | 8 
> >  2 files changed, 9 insertions(+), 1 deletion(-)
> >
> >diff --git a/lib/hash/rte_thash.c b/lib/hash/rte_thash.c
> >index 336c228e64..842e3ad85d 100644
> >--- a/lib/hash/rte_thash.c
> >+++ b/lib/hash/rte_thash.c
> >@@ -761,7 +761,7 @@ rte_thash_adjust_tuple(struct rte_thash_ctx *ctx,
> > uint32_t desired_value, unsigned int attempts,
> > rte_thash_check_tuple_t fn, void *userdata)
> >  {
> >-uint32_t tmp_tuple[tuple_len / sizeof(uint32_t)];
> >+uint32_t tmp_tuple[RTE_THASH_MAX_L4_LEN];
> > unsigned int i, j, ret = 0;
> > uint32_t hash, adj_bits;
> > const uint8_t *hash_key;
> >diff --git a/lib/hash/rte_thash.h b/lib/hash/rte_thash.h
> >index c0af5968df..427246ad2e 100644
> >--- a/lib/hash/rte_thash.h
> >+++ b/lib/hash/rte_thash.h
> >@@ -121,6 +121,14 @@ __rte_internal
> >  uint32_t
> >  thash_get_rand_poly(uint32_t poly_degree);
> >+/**
> >+ * maximum length in dwords of input tuple to
> >+ * calculate hash of ipv(4|6) header +
> >+ * transport header
> >+ */
> >+#define RTE_THASH_MAX_L4_LEN\
> >+((sizeof(union rte_thash_tuple)) / sizeof(uint32_t))
> >+
> >  /**
> >   * Prepare special converted key to use with rte_softrss_be()
> >   * @param orig
> 
> -- 
> Regards,
> Vladimir

[RFC] crypto/virtio: add vhost-vdpa backend

[Gowrishankar Muthukrishnan]

Hi,
We are adding support for vDPA user backend for virtio-crypto PMD in DPDK. We 
have come up with functional changes which is similar to the support available 
in net:

commit 6b901437056eed3ed7c9932c333ba24ac5be116f

net/virtio: introduce vhost-vDPA backend
vhost-vDPA is a new virtio backend type introduced by vDPA kernel
framework, which provides abstraction to the vDPA devices and
exposes an unified control interface through a char dev.

Our current development reuses some code from net/virtio/virtio_user/, and we 
realize that we could keep a few things in common between net and crypto, such 
as:

-> vhost_vdpa.c (and its header file) from net/virtio/virtio_user/:
   Except for VHOST_VDPA_GET_DEVICE_ID and enabling queue pairs, 
virtio_user_backend_ops can be reused.
-> virtio_user_dev.c (and its header file) from net/virtio/virtio_user/:
   virtio_user_dev_init and its capabilities differ.
-> virtio_cvq.c (and its header file) from net/virtio/:
   There is a difference in the usage of the first and last descriptors for the 
virtio header and status (net vs. crypto).

We need to standardize these codes to ensure they work universally. Therefore, 
we propose creating a driver/common/virtio/ directory to house them. This 
approach will help address common issues and extend Virtio functionalities 
shared between crypto and net. For example, the crypto PMD can benefit from 
packed ring support. We welcome your valuable feedback and any suggestions.

Thanks,
Gowrishankar
-- 
2.37.1

[PATCH v12 00/21] remove use of VLAs for Windows

[Andre Muezerie]

As per guidance technical board meeting 2024/04/17. This series
removes the use of VLAs from code built for Windows for all 3
toolchains. If there are additional opportunities to convert VLAs
to regular C arrays please provide the details for incorporation
into the series.

MSVC does not support VLAs, replace VLAs with standard C arrays
or alloca(). alloca() is available for all toolchain/platform
combinations officially supported by DPDK.

v12:
  * update commit message for patch 06/21 to avoid warning

v11:
  * add include stdlib.h for alloca() declaration on FreeBSD
  * zero-initialize array without code loop
  * increase maximum tuple length

v10:
 * add ifdef to scope gcc's diagnostic error down to gcc only

v9:
 * fix sender's email address
 * fix gcc's diagnostic error string to make clang happy

v8:
 * rebase
 * reduce scope for disabling error "-Warray-bounds=" to only
   the place that needs it
 * remove parentesis around numbers from defines in test_bitset.c

v7:
 * remove use of VLA from new file which sneaked in during review

v6:
 * remove use of VLA from new test code added recently
 * fix title for patch 08/20

v5:
 * add patches for net/ice, net/ixgbe and gro
   from Konstantin Ananyev from
https://patchwork.dpdk.org/project/dpdk/list/?series=31972&archive=both&state=*
 * address debug_autotest ASan failure
 * address array-bound error in bitset_autotest with gcc-13

v4:
 * rebase and adapt for changes made in main since v3 was sent
 * use fixed maximum array size instead of VLA when doable

v3:
 * address checkpatch/check git log warnings (minor typos)

v2:
 * replace patches for ethdev, hash, rcu and include new
   patches for eal from Konstantin Ananyev
   from https://patchwork.dpdk.org/project/dpdk/list/?series=31781

Andre Muezerie (3):
  test: remove use of VLAs for Windows built code in bitset tests
  app/testpmd: remove use of VLAs for Windows built code in
shared_rxq_fwd
  hash: remove use of VLAs by using standard arrays

Konstantin Ananyev (10):
  eal/linux: remove use of VLAs
  eal/common: remove use of VLAs
  ethdev: remove use of VLAs for Windows built code
  hash: remove use of VLAs for Windows built code
  hash/thash: remove use of VLAs for Windows built
  rcu: remove use of VLAs for Windows built code
  gro: fix overwrite unprocessed packets
  gro: remove use of VLAs
  net/ixgbe: remove use of VLAs
  net/ice: remove use of VLAs

Tyler Retzlaff (8):
  eal: include header required for alloca
  app/testpmd: remove use of VLAs for Windows built
  test: remove use of VLAs for Windows built code
  common/idpf: remove use of VLAs for Windows built code
  net/i40e: remove use of VLAs for Windows built code
  common/mlx5: remove use of VLAs for Windows built code
  net/mlx5: remove use of VLAs for Windows built code
  build: enable vla warnings on Windows built code

 app/test-pmd/cmdline.c|   2 +-
 app/test-pmd/cmdline_flow.c   |  15 +-
 app/test-pmd/config.c |  16 +-
 app/test-pmd/shared_rxq_fwd.c |   2 +-
 app/test/test.c   |   2 +-
 app/test/test_bitset.c|  69 ---
 app/test/test_cmdline_string.c|   2 +-
 app/test/test_cryptodev.c |  34 ++--
 app/test/test_cryptodev_blockcipher.c |   4 +-
 app/test/test_cryptodev_crosscheck.c  |   2 +-
 app/test/test_dmadev.c|   9 +-
 app/test/test_hash.c  |  14 +-
 app/test/test_lcore_var_perf.c|   2 +-
 app/test/test_mempool.c   |  25 +--
 app/test/test_reassembly_perf.c   |   4 +-
 app/test/test_reorder.c   |  48 ++---
 app/test/test_service_cores.c |   9 +-
 app/test/test_thash.c |   7 +-
 config/meson.build|   4 +
 drivers/common/idpf/idpf_common_rxtx.c|   2 +-
 drivers/common/idpf/idpf_common_rxtx_avx512.c |   6 +-
 drivers/common/mlx5/mlx5_common.h |   4 +-
 drivers/common/mlx5/mlx5_devx_cmds.c  |   7 +-
 drivers/net/i40e/i40e_testpmd.c   |   5 +-
 drivers/net/ice/ice_rxtx.c|  18 +-
 drivers/net/ice/ice_rxtx.h|   2 +
 drivers/net/ixgbe/ixgbe_ethdev.c  |  21 +-
 drivers/net/ixgbe/ixgbe_rxtx_vec_common.h |   4 +-
 drivers/net/mlx5/mlx5.c   |   5 +-
 drivers/net/mlx5/mlx5_flow.c  |   6 +-
 lib/eal/common/eal_common_proc.c  |   5 +-
 lib/eal/freebsd/include/rte_os.h  |   1 +
 lib/eal/linux/eal_interrupts.c|  32 ++-
 lib/eal/linux/include/rte_os.h|   1 +
 lib/eal/windows/include/rte_os.h  |   1 +
 lib/ethdev/rte_ethdev.c   | 183 +++---
 lib/gro/rte_gro.c |  42 ++--
 lib/hash/rte_cuckoo_hash.c|   4 +

[PATCH v12 13/21] test: remove use of VLAs for Windows built code

[Andre Muezerie]

From: Tyler Retzlaff 

MSVC does not support VLAs, replace VLAs with standard C arrays
or alloca(). alloca() is available for all toolchain/platform
combinations officially supported by DPDK.

Signed-off-by: Tyler Retzlaff 
---
 app/test/test.c   |  2 +-
 app/test/test_cmdline_string.c|  2 +-
 app/test/test_cryptodev.c | 34 +--
 app/test/test_cryptodev_blockcipher.c |  4 +--
 app/test/test_cryptodev_crosscheck.c  |  2 +-
 app/test/test_dmadev.c|  9 +++--
 app/test/test_hash.c  | 14 
 app/test/test_mempool.c   | 25 +++---
 app/test/test_reorder.c   | 48 +++
 app/test/test_service_cores.c |  9 +++--
 app/test/test_thash.c |  7 ++--
 11 files changed, 82 insertions(+), 74 deletions(-)

diff --git a/app/test/test.c b/app/test/test.c
index 680351f6a3..fd653cbbfd 100644
--- a/app/test/test.c
+++ b/app/test/test.c
@@ -105,7 +105,7 @@ int
 main(int argc, char **argv)
 {
struct cmdline *cl;
-   char *tests[argc]; /* store an array of tests to run */
+   char **tests = alloca(sizeof(char *) * argc); /* store an array of 
tests to run */
int test_count = 0;
int i;
char *extra_args;
diff --git a/app/test/test_cmdline_string.c b/app/test/test_cmdline_string.c
index 97516c9400..e1cf86020f 100644
--- a/app/test/test_cmdline_string.c
+++ b/app/test/test_cmdline_string.c
@@ -40,7 +40,7 @@ struct string_elt_str string_elt_strs[] = {
 #if (CMDLINE_TEST_BUFSIZE < STR_TOKEN_SIZE) \
 || (CMDLINE_TEST_BUFSIZE < STR_MULTI_TOKEN_SIZE)
 #undef CMDLINE_TEST_BUFSIZE
-#define CMDLINE_TEST_BUFSIZE RTE_MAX(STR_TOKEN_SIZE, STR_MULTI_TOKEN_SIZE)
+#define CMDLINE_TEST_BUFSIZE RTE_MAX_T(STR_TOKEN_SIZE, STR_MULTI_TOKEN_SIZE, 
size_t)
 #endif
 
 struct string_nb_str {
diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c
index c647baeee1..9fdbfe5150 100644
--- a/app/test/test_cryptodev.c
+++ b/app/test/test_cryptodev.c
@@ -2886,7 +2886,7 @@ create_wireless_algo_hash_session(uint8_t dev_id,
enum rte_crypto_auth_operation op,
enum rte_crypto_auth_algorithm algo)
 {
-   uint8_t hash_key[key_len];
+   uint8_t *hash_key = alloca(key_len);
 
struct crypto_testsuite_params *ts_params = &testsuite_params;
struct crypto_unittest_params *ut_params = &unittest_params;
@@ -2922,7 +2922,7 @@ create_wireless_algo_cipher_session(uint8_t dev_id,
const uint8_t *key, const uint8_t key_len,
uint8_t iv_len)
 {
-   uint8_t cipher_key[key_len];
+   uint8_t *cipher_key = alloca(key_len);
struct crypto_testsuite_params *ts_params = &testsuite_params;
struct crypto_unittest_params *ut_params = &unittest_params;
 
@@ -3074,7 +3074,7 @@ create_wireless_cipher_auth_session(uint8_t dev_id,
const struct wireless_test_data *tdata)
 {
const uint8_t key_len = tdata->key.len;
-   uint8_t cipher_auth_key[key_len];
+   uint8_t *cipher_auth_key = alloca(key_len);
 
struct crypto_testsuite_params *ts_params = &testsuite_params;
struct crypto_unittest_params *ut_params = &unittest_params;
@@ -9078,7 +9078,7 @@ create_aead_session(uint8_t dev_id, enum 
rte_crypto_aead_algorithm algo,
const uint16_t aad_len, const uint8_t auth_len,
uint8_t iv_len)
 {
-   uint8_t aead_key[key_len];
+   uint8_t *aead_key = alloca(key_len);
 
struct crypto_testsuite_params *ts_params = &testsuite_params;
struct crypto_unittest_params *ut_params = &unittest_params;
@@ -12992,7 +12992,7 @@ test_cryptodev_error_recover_helper(uint8_t dev_id, 
const void *test_data, bool
struct crypto_testsuite_params *ts_params = &testsuite_params;
struct crypto_unittest_params *ut_params = &unittest_params;
const struct blockcipher_test_data *tdata = test_data;
-   uint8_t cipher_key[tdata->cipher_key.len];
+   uint8_t *cipher_key = alloca(tdata->cipher_key.len);
struct rte_crypto_sym_op *sym_op = NULL;
struct rte_crypto_op *op = NULL;
char *dst;
@@ -13346,7 +13346,7 @@ static int
 test_AES_GCM_auth_encryption_fail_aad_corrupt(void)
 {
struct aead_test_data tdata;
-   uint8_t aad[gcm_test_case_7.aad.len];
+   uint8_t *aad = alloca(gcm_test_case_7.aad.len);
int res;
 
RTE_LOG(INFO, USER1, "This is a negative test, errors are expected\n");
@@ -13735,7 +13735,7 @@ static int
 test_AES_GCM_auth_decryption_fail_aad_corrupt(void)
 {
struct aead_test_data tdata;
-   uint8_t aad[gcm_test_case_7.aad.len];
+   uint8_t *aad = alloca(gcm_test_case_7.aad.len);
int res;
 
memcpy(&tdata, &gcm_test_case_7, sizeof(struct aead_test_data));
@@ -13987,7 +13987,7 @@ test_authenticated_encryption_sessionless(
int retval;
uint8_t *ciphertext, *auth_tag;
uint16_t pla

[PATCH v12 07/21] rcu: remove use of VLAs for Windows built code

[Andre Muezerie]

From: Konstantin Ananyev 

1) ./lib/rcu/rte_rcu_qsbr.c:359:9
: warning: ISO C90 forbids variable length array ‘data’ [-Wvla]
2) ./lib/rcu/rte_rcu_qsbr.c:422:9
: warning: ISO C90 forbids variable length array ‘data’ [-Wvla]

In both cases we allocate VLA for one element from RCU deferred queue.
Right now, size of element in RCU queue is not limited by API.
The approach is to introduce some reasonable limitation on RCU DQ
element size.
Choose 128B for now.
With that in place we can replace both VLA occurencies with fixed size
array.

Note that such change need to be treated as API change.
So can be applied only at 24.11.

Signed-off-by: Konstantin Ananyev 
---
 lib/rcu/rte_rcu_qsbr.c | 7 ---
 lib/rcu/rte_rcu_qsbr.h | 5 +
 2 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/lib/rcu/rte_rcu_qsbr.c b/lib/rcu/rte_rcu_qsbr.c
index dbf31501a6..fe68d16326 100644
--- a/lib/rcu/rte_rcu_qsbr.c
+++ b/lib/rcu/rte_rcu_qsbr.c
@@ -245,7 +245,8 @@ rte_rcu_qsbr_dq_create(const struct 
rte_rcu_qsbr_dq_parameters *params)
if (params == NULL || params->free_fn == NULL ||
params->v == NULL || params->name == NULL ||
params->size == 0 || params->esize == 0 ||
-   (params->esize % 4 != 0)) {
+   (params->esize % 4 != 0) ||
+   params->esize > RTE_QSBR_ESIZE_MAX) {
RCU_LOG(ERR, "Invalid input parameter");
rte_errno = EINVAL;
 
@@ -323,7 +324,7 @@ int rte_rcu_qsbr_dq_enqueue(struct rte_rcu_qsbr_dq *dq, 
void *e)
return 1;
}
 
-   char data[dq->esize];
+   char data[RTE_QSBR_ESIZE_MAX + __RTE_QSBR_TOKEN_SIZE];
dq_elem = (__rte_rcu_qsbr_dq_elem_t *)data;
/* Start the grace period */
dq_elem->token = rte_rcu_qsbr_start(dq->v);
@@ -386,7 +387,7 @@ rte_rcu_qsbr_dq_reclaim(struct rte_rcu_qsbr_dq *dq, 
unsigned int n,
 
cnt = 0;
 
-   char data[dq->esize];
+   char data[RTE_QSBR_ESIZE_MAX + __RTE_QSBR_TOKEN_SIZE];
/* Check reader threads quiescent state and reclaim resources */
while (cnt < n &&
rte_ring_dequeue_bulk_elem_start(dq->r, &data,
diff --git a/lib/rcu/rte_rcu_qsbr.h b/lib/rcu/rte_rcu_qsbr.h
index 550fadf56a..abcbd78914 100644
--- a/lib/rcu/rte_rcu_qsbr.h
+++ b/lib/rcu/rte_rcu_qsbr.h
@@ -86,6 +86,11 @@ struct __rte_cache_aligned rte_rcu_qsbr_cnt {
 #define __RTE_QSBR_CNT_MAX ((uint64_t)~0)
 #define __RTE_QSBR_TOKEN_SIZE sizeof(uint64_t)
 
+/**
+ * Max allowable size (in bytes) of each element in the defer queue
+ */
+#define RTE_QSBR_ESIZE_MAX (2 * RTE_CACHE_LINE_MIN_SIZE)
+
 /* RTE Quiescent State variable structure.
  * This structure has two elements that vary in size based on the
  * 'max_threads' parameter.
-- 
2.47.0.vfs.0.3

[PATCH v12 05/21] hash: remove use of VLAs for Windows built code

[Andre Muezerie]

From: Konstantin Ananyev 

1) ./lib/hash/rte_cuckoo_hash.c:2362:9
: warning: ISO C90 forbids variable length array ‘positions’
2) ../lib/hash/rte_cuckoo_hash.c:2478:9
: warning: ISO C90 forbids variable length array ‘positions’

Both rte_hash_lookup_bulk_data() and
rte_hash_lookup_with_hash_bulk_data() expect
@num_keys <= RTE_HASH_LOOKUP_BULK_MAX.
So, for both cases it should be safe to replace VLA with fixed size
array.

Signed-off-by: Konstantin Ananyev 
Reviewed-by: Bruce Richardson 
Acked-by: Vladimir Medvedkin 
---
 lib/hash/rte_cuckoo_hash.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/hash/rte_cuckoo_hash.c b/lib/hash/rte_cuckoo_hash.c
index 9575e8aa0c..fc93182efe 100644
--- a/lib/hash/rte_cuckoo_hash.c
+++ b/lib/hash/rte_cuckoo_hash.c
@@ -2418,7 +2418,7 @@ rte_hash_lookup_bulk_data(const struct rte_hash *h, const 
void **keys,
(num_keys > RTE_HASH_LOOKUP_BULK_MAX) ||
(hit_mask == NULL)), -EINVAL);
 
-   int32_t positions[num_keys];
+   int32_t positions[RTE_HASH_LOOKUP_BULK_MAX];
 
__rte_hash_lookup_bulk(h, keys, num_keys, positions, hit_mask, data);
 
@@ -2534,7 +2534,7 @@ rte_hash_lookup_with_hash_bulk_data(const struct rte_hash 
*h,
(num_keys > RTE_HASH_LOOKUP_BULK_MAX) ||
(hit_mask == NULL)), -EINVAL);
 
-   int32_t positions[num_keys];
+   int32_t positions[RTE_HASH_LOOKUP_BULK_MAX];
 
__rte_hash_lookup_with_hash_bulk(h, keys, sig, num_keys,
positions, hit_mask, data);
-- 
2.47.0.vfs.0.3

[PATCH v12 08/21] gro: fix overwrite unprocessed packets

[Andre Muezerie]

From: Konstantin Ananyev 

gro_vxlan_tcp4_tbl_timeout_flush() is called without taking into account
that first entries in pkts[] can be already occupied by
un-processed packets.

Fixes: 74080d7dcf31 ("gro: support IPv6 for TCP")
Cc: sta...@dpdk.org

Signed-off-by: Konstantin Ananyev 
Acked-by: Ferruh Yigit 
---
 lib/gro/rte_gro.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/gro/rte_gro.c b/lib/gro/rte_gro.c
index d824eebd93..db86117609 100644
--- a/lib/gro/rte_gro.c
+++ b/lib/gro/rte_gro.c
@@ -327,7 +327,7 @@ rte_gro_reassemble_burst(struct rte_mbuf **pkts,
/* Flush all packets from the tables */
if (do_vxlan_tcp_gro) {
i += gro_vxlan_tcp4_tbl_timeout_flush(&vxlan_tcp_tbl,
-   0, pkts, nb_pkts);
+   0, &pkts[i], nb_pkts - i);
}
 
if (do_vxlan_udp_gro) {
-- 
2.47.0.vfs.0.3

[PATCH v12 06/21] hash/thash: remove use of VLAs for Windows built

[Andre Muezerie]

From: Konstantin Ananyev 

1) ./lib/hash/rte_thash.c:774:9
: warning: ISO C90 forbids variable length array ‘tmp_tuple’

The tuple can exceed sizeof(union rte_thash_tuple), for example if any
tunneling header is used in the RSS hash calculation.

The longest RSS hash key currently supported is 52 bytes. Technically, the
longest tuple with such a key should be (52 - sizeof(uint32_t)), so this
can be used as a size of the tmp_tuple array.

Signed-off-by: Konstantin Ananyev 
---
 lib/hash/rte_thash.c | 2 +-
 lib/hash/rte_thash.h | 7 +++
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/lib/hash/rte_thash.c b/lib/hash/rte_thash.c
index 336c228e64..fa78787143 100644
--- a/lib/hash/rte_thash.c
+++ b/lib/hash/rte_thash.c
@@ -761,7 +761,7 @@ rte_thash_adjust_tuple(struct rte_thash_ctx *ctx,
uint32_t desired_value, unsigned int attempts,
rte_thash_check_tuple_t fn, void *userdata)
 {
-   uint32_t tmp_tuple[tuple_len / sizeof(uint32_t)];
+   uint32_t tmp_tuple[RTE_THASH_TUPLE_LEN_MAX];
unsigned int i, j, ret = 0;
uint32_t hash, adj_bits;
const uint8_t *hash_key;
diff --git a/lib/hash/rte_thash.h b/lib/hash/rte_thash.h
index c0af5968df..04f9f1875c 100644
--- a/lib/hash/rte_thash.h
+++ b/lib/hash/rte_thash.h
@@ -121,6 +121,13 @@ __rte_internal
 uint32_t
 thash_get_rand_poly(uint32_t poly_degree);
 
+/**
+ * Longest RSS hash key currently supported
+ */
+#define RTE_THASH_KEY_LEN_MAX  52
+
+#define RTE_THASH_TUPLE_LEN_MAX (RTE_THASH_KEY_LEN_MAX - sizeof(uint32_t))
+
 /**
  * Prepare special converted key to use with rte_softrss_be()
  * @param orig
-- 
2.47.0.vfs.0.3

[PATCH v12 14/21] common/idpf: remove use of VLAs for Windows built code

[Andre Muezerie]

From: Tyler Retzlaff 

MSVC does not support VLAs, replace VLAs with standard C arrays
or alloca(). alloca() is available for all toolchain/platform
combinations officially supported by DPDK.

Signed-off-by: Tyler Retzlaff 
Acked-by: Bruce Richardson 
---
 drivers/common/idpf/idpf_common_rxtx.c| 2 +-
 drivers/common/idpf/idpf_common_rxtx_avx512.c | 6 --
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/common/idpf/idpf_common_rxtx.c 
b/drivers/common/idpf/idpf_common_rxtx.c
index a04e54ce26..e04ab40fa2 100644
--- a/drivers/common/idpf/idpf_common_rxtx.c
+++ b/drivers/common/idpf/idpf_common_rxtx.c
@@ -569,7 +569,7 @@ idpf_split_rx_bufq_refill(struct idpf_rx_queue *rx_bufq)
uint16_t nb_refill = rx_bufq->rx_free_thresh;
uint16_t nb_desc = rx_bufq->nb_rx_desc;
uint16_t next_avail = rx_bufq->rx_tail;
-   struct rte_mbuf *nmb[rx_bufq->rx_free_thresh];
+   struct rte_mbuf **nmb = alloca(sizeof(struct rte_mbuf *) * 
rx_bufq->rx_free_thresh);
uint64_t dma_addr;
uint16_t delta;
int i;
diff --git a/drivers/common/idpf/idpf_common_rxtx_avx512.c 
b/drivers/common/idpf/idpf_common_rxtx_avx512.c
index b8450b03ae..63e10c542f 100644
--- a/drivers/common/idpf/idpf_common_rxtx_avx512.c
+++ b/drivers/common/idpf/idpf_common_rxtx_avx512.c
@@ -1002,7 +1002,8 @@ idpf_tx_singleq_free_bufs_avx512(struct idpf_tx_queue 
*txq)
uint32_t n;
uint32_t i;
int nb_free = 0;
-   struct rte_mbuf *m, *free[txq->rs_thresh];
+   struct rte_mbuf *m;
+   struct rte_mbuf **free = alloca(sizeof(struct rte_mbuf *) * 
txq->rs_thresh);
 
/* check DD bits on threshold descriptor */
if ((txq->tx_ring[txq->next_dd].qw1 &
@@ -1326,7 +1327,8 @@ idpf_tx_splitq_free_bufs_avx512(struct idpf_tx_queue *txq)
uint32_t n;
uint32_t i;
int nb_free = 0;
-   struct rte_mbuf *m, *free[txq->rs_thresh];
+   struct rte_mbuf *m;
+   struct rte_mbuf **free = alloca(sizeof(struct rte_mbuf *) * 
txq->rs_thresh);
 
n = txq->rs_thresh;
 
-- 
2.47.0.vfs.0.3

[PATCH v12 15/21] net/i40e: remove use of VLAs for Windows built code

[Andre Muezerie]

From: Tyler Retzlaff 

MSVC does not support VLAs, replace VLAs with standard C arrays
or alloca(). alloca() is available for all toolchain/platform
combinations officially supported by DPDK.

Signed-off-by: Tyler Retzlaff 
Reviewed-by: Bruce Richardson 
---
 drivers/net/i40e/i40e_testpmd.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/net/i40e/i40e_testpmd.c b/drivers/net/i40e/i40e_testpmd.c
index b6ef5d6e42..21f596297b 100644
--- a/drivers/net/i40e/i40e_testpmd.c
+++ b/drivers/net/i40e/i40e_testpmd.c
@@ -2168,8 +2168,7 @@ cmd_ptype_mapping_get_parsed(void *parsed_result,
 {
struct cmd_ptype_mapping_get_result *res = parsed_result;
int ret = -ENOTSUP;
-   int max_ptype_num = 256;
-   struct rte_pmd_i40e_ptype_mapping mapping[max_ptype_num];
+   struct rte_pmd_i40e_ptype_mapping mapping[256];
uint16_t count;
int i;
 
@@ -2178,7 +2177,7 @@ cmd_ptype_mapping_get_parsed(void *parsed_result,
 
ret = rte_pmd_i40e_ptype_mapping_get(res->port_id,
mapping,
-   max_ptype_num,
+   RTE_DIM(mapping),
&count,
res->valid_only);
switch (ret) {
-- 
2.47.0.vfs.0.3

[PATCH v12 12/21] app/testpmd: remove use of VLAs for Windows built

[Andre Muezerie]

From: Tyler Retzlaff 

MSVC does not support VLAs, replace VLAs with standard C arrays
or alloca(). alloca() is available for all toolchain/platform
combinations officially supported by DPDK.

Signed-off-by: Tyler Retzlaff 
---
 app/test-pmd/cmdline.c  |  2 +-
 app/test-pmd/cmdline_flow.c | 15 ++-
 app/test-pmd/config.c   | 16 +---
 3 files changed, 20 insertions(+), 13 deletions(-)

diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index 7e0666e9f6..2897e44c34 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -13274,7 +13274,7 @@ cmd_set_port_ptypes_parsed(
return;
}
 
-   uint32_t ptypes[ret];
+   uint32_t *ptypes = alloca(sizeof(uint32_t) * ret);
 
ret = rte_eth_dev_set_ptypes(port_id, ptype_mask, ptypes, ret);
if (ret < 0) {
diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
index 1e4f2ebc55..fb0c4f838d 100644
--- a/app/test-pmd/cmdline_flow.c
+++ b/app/test-pmd/cmdline_flow.c
@@ -11707,8 +11707,7 @@ parse_hex(struct context *ctx, const struct token 
*token,
char tmp[16]; /* Ought to be enough. */
int ret;
unsigned int hexlen = len;
-   unsigned int length = 256;
-   uint8_t hex_tmp[length];
+   uint8_t hex_tmp[256];
 
/* Arguments are expected. */
if (!arg_data)
@@ -11735,7 +11734,7 @@ parse_hex(struct context *ctx, const struct token 
*token,
str += 2;
hexlen -= 2;
}
-   if (hexlen > length)
+   if (hexlen > RTE_DIM(hex_tmp))
goto error;
ret = parse_hex_string(str, hex_tmp, &hexlen);
if (ret < 0)
@@ -11868,10 +11867,13 @@ parse_ipv4_addr(struct context *ctx, const struct 
token *token,
void *buf, unsigned int size)
 {
const struct arg *arg = pop_args(ctx);
-   char str2[len + 1];
+   char str2[INET_ADDRSTRLEN];
struct in_addr tmp;
int ret;
 
+   /* Length is longer than the max length an IPv4 address can have. */
+   if (len >= INET_ADDRSTRLEN)
+   return -1;
/* Argument is expected. */
if (!arg)
return -1;
@@ -11914,11 +11916,14 @@ parse_ipv6_addr(struct context *ctx, const struct 
token *token,
void *buf, unsigned int size)
 {
const struct arg *arg = pop_args(ctx);
-   char str2[len + 1];
+   char str2[INET6_ADDRSTRLEN];
struct rte_ipv6_addr tmp;
int ret;
 
(void)token;
+   /* Length is longer than the max length an IPv6 address can have. */
+   if (len >= INET6_ADDRSTRLEN)
+   return -1;
/* Argument is expected. */
if (!arg)
return -1;
diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index 28d45568ac..8117026c73 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -1802,7 +1802,8 @@ port_flow_configure(portid_t port_id,
 {
struct rte_port *port;
struct rte_flow_error error;
-   const struct rte_flow_queue_attr *attr_list[nb_queue];
+   const struct rte_flow_queue_attr **attr_list =
+   alloca(sizeof(struct rte_flow_queue_attr *) * nb_queue);
int std_queue;
 
if (port_id_is_invalid(port_id, ENABLED_WARN) ||
@@ -2616,10 +2617,10 @@ port_flow_template_table_create(portid_t port_id, 
uint32_t id,
int ret;
uint32_t i;
struct rte_flow_error error;
-   struct rte_flow_pattern_template
-   *flow_pattern_templates[nb_pattern_templates];
-   struct rte_flow_actions_template
-   *flow_actions_templates[nb_actions_templates];
+   struct rte_flow_pattern_template **flow_pattern_templates =
+   alloca(sizeof(struct rte_flow_pattern_template *) * 
nb_pattern_templates);
+   struct rte_flow_actions_template **flow_actions_templates =
+   alloca(sizeof(struct rte_flow_actions_template *) * 
nb_actions_templates);
 
if (port_id_is_invalid(port_id, ENABLED_WARN) ||
port_id == (portid_t)RTE_PORT_ALL)
@@ -5551,7 +5552,7 @@ parse_port_list(const char *list, unsigned int *values, 
unsigned int maxsize)
char *end = NULL;
int min, max;
int value, i;
-   unsigned int marked[maxsize];
+   unsigned int *marked = alloca(sizeof(unsigned int) * maxsize);
 
if (list == NULL || values == NULL)
return 0;
@@ -7292,7 +7293,8 @@ show_macs(portid_t port_id)
if (eth_dev_info_get_print_err(port_id, &dev_info))
return;
 
-   struct rte_ether_addr addr[dev_info.max_mac_addrs];
+   struct rte_ether_addr *addr =
+   alloca(sizeof(struct rte_ether_addr) * dev_info.max_mac_addrs);
rc = rte_eth_macaddrs_get(port_id, addr, dev_info.max_mac_addrs);
if (rc < 0)
return;
-- 
2.47.0.vfs.0.3

[PATCH v12 20/21] app/testpmd: remove use of VLAs for Windows built code in shared_rxq_fwd

[Andre Muezerie]

MSVC does not support VLAs, replace VLAs with standard C arrays
or alloca(). alloca() is available for all toolchain/platform
combinations officially supported by DPDK.

Signed-off-by: Andre Muezerie 
---
 app/test-pmd/shared_rxq_fwd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/test-pmd/shared_rxq_fwd.c b/app/test-pmd/shared_rxq_fwd.c
index 623d62da88..b85830b90e 100644
--- a/app/test-pmd/shared_rxq_fwd.c
+++ b/app/test-pmd/shared_rxq_fwd.c
@@ -92,7 +92,7 @@ forward_shared_rxq(struct fwd_stream *fs, uint16_t nb_rx,
 static bool
 shared_rxq_fwd(struct fwd_stream *fs)
 {
-   struct rte_mbuf *pkts_burst[nb_pkt_per_burst];
+   struct rte_mbuf *pkts_burst[MAX_PKT_BURST];
uint16_t nb_rx;
 
nb_rx = common_fwd_stream_receive(fs, pkts_burst, nb_pkt_per_burst);
-- 
2.47.0.vfs.0.3

[PATCH v12 19/21] test: remove use of VLAs for Windows built code in bitset tests

[Andre Muezerie]

1) MSVC does not support VLAs. Use standard fixed C arrays of
maximum size required instead.

2) ../usr/lib/gcc/x86_64-redhat-linux/13/include/emmintrin.h:742:8:
error: array subscript 9 is outside array bounds of 'uint64_t[16]'
{aka 'long unsigned int[16]'} [-Werror=array-bounds=]
   3695 742 | *__P = __B;

Compile with -Wno-array-bounds to avoid false positives when
using gcc version 11 or newer (gcc compiler bug/limitation).

Signed-off-by: Andre Muezerie 
---
 app/test/test_bitset.c  | 69 -
 app/test/test_lcore_var_perf.c  |  2 +-
 app/test/test_reassembly_perf.c |  4 +-
 3 files changed, 46 insertions(+), 29 deletions(-)

diff --git a/app/test/test_bitset.c b/app/test/test_bitset.c
index 50b8bf0da4..45460204c1 100644
--- a/app/test/test_bitset.c
+++ b/app/test/test_bitset.c
@@ -99,11 +99,13 @@ typedef void clear_fun(uint64_t *bitset, size_t bit_num);
 typedef void assign_fun(uint64_t *bitset, size_t bit_num, bool value);
 typedef void flip_fun(uint64_t *bitset, size_t bit_num);
 
+#define RAND_SET_MAX_SIZE 1000
+
 static int
 test_set_clear_size(test_fun test_fun, set_fun set_fun, clear_fun clear_fun, 
size_t size)
 {
size_t i;
-   bool reference[size];
+   bool reference[RAND_SET_MAX_SIZE];
uint64_t *bitset;
 
rand_bool_ary(reference, size);
@@ -131,8 +133,7 @@ test_set_clear_size(test_fun test_fun, set_fun set_fun, 
clear_fun clear_fun, siz
return TEST_SUCCESS;
 }
 
-#define RAND_ITERATIONS (1)
-#define RAND_SET_MAX_SIZE (1000)
+#define RAND_ITERATIONS 1
 
 static int
 test_set_clear_fun(test_fun test_fun, set_fun set_fun, clear_fun clear_fun)
@@ -168,10 +169,20 @@ test_flip_size(test_fun test_fun, assign_fun assign_fun, 
flip_fun flip_fun, size
rand_bitset(bitset, size);
 
for (i = 0; i < size; i++) {
-   RTE_BITSET_DECLARE(reference, size);
+   RTE_BITSET_DECLARE(reference, RAND_SET_MAX_SIZE);
+
+#if defined(RTE_TOOLCHAIN_GCC) && (GCC_VERSION >= 11)
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Warray-bounds"
+#endif
 
+   /* gcc is giving false positives here when code is optimized */
rte_bitset_copy(reference, bitset, size);
 
+#if defined(RTE_TOOLCHAIN_GCC) && (GCC_VERSION >= 11)
+#pragma GCC diagnostic pop
+#endif
+
bool value = test_fun(bitset, i);
 
flip_fun(bitset, i);
@@ -282,13 +293,13 @@ find_clear(const bool *ary, size_t num_bools, size_t 
start, size_t len)
return find(ary, num_bools, start, len, false);
 }
 
-#define FFS_ITERATIONS (100)
+#define FFS_ITERATIONS 100
 
 static int
 test_find_size(size_t size, bool set)
 {
uint64_t *bitset;
-   bool reference[size];
+   bool reference[RAND_SET_MAX_SIZE];
size_t i;
 
bitset = alloc_bitset(size);
@@ -388,8 +399,8 @@ record_match(ssize_t match_idx, size_t size, int *calls)
 static int
 test_foreach_size(ssize_t size, bool may_wrap, bool set)
 {
-   bool reference[size];
-   int calls[size];
+   bool reference[RAND_SET_MAX_SIZE];
+   int calls[RAND_SET_MAX_SIZE];
uint64_t *bitset;
ssize_t i;
ssize_t start_bit;
@@ -633,17 +644,19 @@ test_define(void)
 typedef void bitset_op(uint64_t *dst, const uint64_t *a, const uint64_t *b, 
size_t bit_num);
 typedef bool bool_op(bool a, bool b);
 
+#define LOGIC_MAX_SET_SIZE 200
+
 static int
 test_logic_op(bitset_op bitset_op, bool_op bool_op)
 {
-   const size_t size = 1 + rte_rand_max(200);
-   RTE_BITSET_DECLARE(bitset_a, size);
-   RTE_BITSET_DECLARE(bitset_b, size);
-   RTE_BITSET_DECLARE(bitset_d, size);
+   const size_t size = 1 + rte_rand_max(LOGIC_MAX_SET_SIZE);
+   RTE_BITSET_DECLARE(bitset_a, LOGIC_MAX_SET_SIZE);
+   RTE_BITSET_DECLARE(bitset_b, LOGIC_MAX_SET_SIZE);
+   RTE_BITSET_DECLARE(bitset_d, LOGIC_MAX_SET_SIZE);
 
-   bool ary_a[size];
-   bool ary_b[size];
-   bool ary_d[size];
+   bool ary_a[LOGIC_MAX_SET_SIZE];
+   bool ary_b[LOGIC_MAX_SET_SIZE];
+   bool ary_d[LOGIC_MAX_SET_SIZE];
 
rand_bool_ary(ary_a, size);
rand_bool_ary(ary_b, size);
@@ -708,14 +721,14 @@ test_complement(void)
for (i = 0; i < RAND_ITERATIONS; i++) {
const size_t size = 1 + rte_rand_max(RAND_SET_MAX_SIZE - 1);
 
-   RTE_BITSET_DECLARE(src, size);
+   RTE_BITSET_DECLARE(src, RAND_SET_MAX_SIZE);
 
rand_bitset(src, size);
 
bool bit_idx = rte_rand_max(size);
bool bit_value = rte_bitset_test(src, bit_idx);
 
-   RTE_BITSET_DECLARE(dst, size);
+   RTE_BITSET_DECLARE(dst, RAND_SET_MAX_SIZE);
 
rte_bitset_complement(dst, src, size);
 
@@ -726,6 +739,8 @@ test_complement(void)
return TEST_SUCCESS;
 }
 
+#define SHIFT_SET_MAX_SIZE 500
+
 static int
 test_shift(bool right)
 {
@@ -734,12 +749,12 @@ test_shift(bool rig

[PATCH v12 16/21] common/mlx5: remove use of VLAs for Windows built code

[Andre Muezerie]

From: Tyler Retzlaff 

MSVC does not support VLAs, replace VLAs with standard C arrays
or alloca(). alloca() is available for all toolchain/platform
combinations officially supported by DPDK.

Signed-off-by: Tyler Retzlaff 
---
 drivers/common/mlx5/mlx5_common.h| 4 ++--
 drivers/common/mlx5/mlx5_devx_cmds.c | 7 +++
 2 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/drivers/common/mlx5/mlx5_common.h 
b/drivers/common/mlx5/mlx5_common.h
index 1abd1e8239..f29f06a86e 100644
--- a/drivers/common/mlx5/mlx5_common.h
+++ b/drivers/common/mlx5/mlx5_common.h
@@ -125,10 +125,10 @@ mlx5_fp_debug_enabled(void)
 /* Allocate a buffer on the stack and fill it with a printf format string. */
 #define MKSTR(name, ...) \
int mkstr_size_##name = snprintf(NULL, 0, "" __VA_ARGS__); \
-   char name[mkstr_size_##name + 1]; \
+   char *name = alloca(mkstr_size_##name + 1); \
\
memset(name, 0, mkstr_size_##name + 1); \
-   snprintf(name, sizeof(name), "" __VA_ARGS__)
+   snprintf(name, mkstr_size_##name + 1, "" __VA_ARGS__)
 
 enum {
PCI_VENDOR_ID_MELLANOX = 0x15b3,
diff --git a/drivers/common/mlx5/mlx5_devx_cmds.c 
b/drivers/common/mlx5/mlx5_devx_cmds.c
index a75f011750..804ee67cd6 100644
--- a/drivers/common/mlx5/mlx5_devx_cmds.c
+++ b/drivers/common/mlx5/mlx5_devx_cmds.c
@@ -284,10 +284,9 @@ mlx5_devx_cmd_flow_counter_query(struct mlx5_devx_obj *dcs,
 void *cmd_comp,
 uint64_t async_id)
 {
-   int out_len = MLX5_ST_SZ_BYTES(query_flow_counter_out) +
-   MLX5_ST_SZ_BYTES(traffic_counter);
-   uint32_t out[out_len];
+   uint32_t out[MLX5_ST_SZ_BYTES(query_flow_counter_out) + 
MLX5_ST_SZ_BYTES(traffic_counter)];
uint32_t in[MLX5_ST_SZ_DW(query_flow_counter_in)] = {0};
+   const int out_len = RTE_DIM(out);
void *stats;
int rc;
 
@@ -346,7 +345,7 @@ mlx5_devx_cmd_mkey_create(void *ctx,
int klm_num = attr->klm_num;
int in_size_dw = MLX5_ST_SZ_DW(create_mkey_in) +
 (klm_num ? RTE_ALIGN(klm_num, 4) : 0) * MLX5_ST_SZ_DW(klm);
-   uint32_t in[in_size_dw];
+   uint32_t *in = alloca(sizeof(uint32_t) * in_size_dw);
uint32_t out[MLX5_ST_SZ_DW(create_mkey_out)] = {0};
void *mkc;
struct mlx5_devx_obj *mkey = mlx5_malloc(MLX5_MEM_ZERO, sizeof(*mkey),
-- 
2.47.0.vfs.0.3

[PATCH v12 17/21] net/mlx5: remove use of VLAs for Windows built code

[Andre Muezerie]

From: Tyler Retzlaff 

MSVC does not support VLAs, replace VLAs with standard C arrays
or alloca(). alloca() is available for all toolchain/platform
combinations officially supported by DPDK.

Signed-off-by: Tyler Retzlaff 
---
 drivers/net/mlx5/mlx5.c  | 5 ++---
 drivers/net/mlx5/mlx5_flow.c | 6 +++---
 2 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c
index 6e4473e2f4..979e54686b 100644
--- a/drivers/net/mlx5/mlx5.c
+++ b/drivers/net/mlx5/mlx5.c
@@ -1598,14 +1598,13 @@ void
 mlx5_rt_timestamp_config(struct mlx5_dev_ctx_shared *sh,
 struct mlx5_hca_attr *hca_attr)
 {
-   uint32_t dw_cnt = MLX5_ST_SZ_DW(register_mtutc);
-   uint32_t reg[dw_cnt];
+   uint32_t reg[MLX5_ST_SZ_DW(register_mtutc)];
int ret = ENOTSUP;
 
if (hca_attr->access_register_user)
ret = mlx5_devx_cmd_register_read(sh->cdev->ctx,
  MLX5_REGISTER_ID_MTUTC, 0,
- reg, dw_cnt);
+ reg, RTE_DIM(reg));
if (!ret) {
uint32_t ts_mode;
 
diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index 16ddd05448..37b5402447 100644
--- a/drivers/net/mlx5/mlx5_flow.c
+++ b/drivers/net/mlx5/mlx5_flow.c
@@ -1479,8 +1479,8 @@ mlx5_flow_item_acceptable(const struct rte_eth_dev *dev,
  "mask/last without a spec is not"
  " supported");
if (item->spec && item->last && !range_accepted) {
-   uint8_t spec[size];
-   uint8_t last[size];
+   uint8_t *spec = alloca(size);
+   uint8_t *last = alloca(size);
unsigned int i;
int ret;
 
@@ -8477,7 +8477,7 @@ mlx5_ctrl_flow_vlan(struct rte_eth_dev *dev,
.type = RTE_FLOW_ITEM_TYPE_END,
},
};
-   uint16_t queue[priv->reta_idx_n];
+   uint16_t *queue = alloca(sizeof(uint16_t) * priv->reta_idx_n);
struct rte_flow_action_rss action_rss = {
.func = RTE_ETH_HASH_FUNCTION_DEFAULT,
.level = 0,
-- 
2.47.0.vfs.0.3

[PATCH v12 18/21] build: enable vla warnings on Windows built code

[Andre Muezerie]

From: Tyler Retzlaff 

MSVC does not support optional C11 VLAs. When building for Windows
enable -Wvla so that mingw and clang also fail if a VLA is used.

Signed-off-by: Tyler Retzlaff 
Acked-by: Bruce Richardson 
---
 config/meson.build | 4 
 1 file changed, 4 insertions(+)

diff --git a/config/meson.build b/config/meson.build
index 6aaad6d8a4..ebca19b4e5 100644
--- a/config/meson.build
+++ b/config/meson.build
@@ -342,6 +342,10 @@ if cc.get_id() == 'intel'
 warning_flags += '-diag-disable=@0@'.format(i)
 endforeach
 endif
+# no VLAs in code built on Windows
+if is_windows
+warning_flags += '-Wvla'
+endif
 foreach arg: warning_flags
 if cc.has_argument(arg)
 add_project_arguments(arg, language: 'c')
-- 
2.47.0.vfs.0.3

[PATCH v12 03/21] eal/common: remove use of VLAs

[Andre Muezerie]

From: Konstantin Ananyev 

1) ../lib/eal/common/eal_common_proc.c:695:15
: warning: variable length array used

As msg->num_fds should not exceed RTE_MP_MAX_FD_NUM, replaced
it with fixed size array.

Signed-off-by: Konstantin Ananyev 
Acked-by: Stephen Hemminger 
---
 lib/eal/common/eal_common_proc.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/lib/eal/common/eal_common_proc.c b/lib/eal/common/eal_common_proc.c
index d24093937c..201973c5db 100644
--- a/lib/eal/common/eal_common_proc.c
+++ b/lib/eal/common/eal_common_proc.c
@@ -692,7 +692,8 @@ send_msg(const char *dst_path, struct rte_mp_msg *msg, int 
type)
struct sockaddr_un dst;
struct mp_msg_internal m;
int fd_size = msg->num_fds * sizeof(int);
-   char control[CMSG_SPACE(fd_size)];
+   const int32_t control_sz = CMSG_SPACE(fd_size);
+   char control[CMSG_SPACE(sizeof(msg->fds))];
 
m.type = type;
memcpy(&m.msg, msg, sizeof(*msg));
@@ -712,7 +713,7 @@ send_msg(const char *dst_path, struct rte_mp_msg *msg, int 
type)
msgh.msg_iov = &iov;
msgh.msg_iovlen = 1;
msgh.msg_control = control;
-   msgh.msg_controllen = sizeof(control);
+   msgh.msg_controllen = control_sz;
 
cmsg = CMSG_FIRSTHDR(&msgh);
cmsg->cmsg_len = CMSG_LEN(fd_size);
-- 
2.47.0.vfs.0.3

[PATCH v12 04/21] ethdev: remove use of VLAs for Windows built code

[Andre Muezerie]

From: Konstantin Ananyev 

1) ./lib/ethdev/rte_ethdev.c:3244:16
: warning: ISO C90 forbids variable length array ‘xstats_names’
2) ./lib/ethdev/rte_ethdev.c:3345:17
: warning: ISO C90 forbids variable length array ‘ids_copy’
3) ./lib/ethdev/rte_ethdev.c:3538:16
: warning: ISO C90 forbids variable length array ‘xstats’
4) ./lib/ethdev/rte_ethdev.c:3554:17
: warning: ISO C90 forbids variable length array ‘ids_copy’

For 1) and 3) - just replaced VLA with arrays allocated from heap.
As I understand xstats extraction belongs to control-path, so extra
calloc/free is hopefully acceptable.
Also ethdev xstats already doing that within
rte_eth_xstats_get_id_by_name().
For 2) and 4) changed the code to use fixed size array and call
appropriate devops function several times, if needed.

Signed-off-by: Konstantin Ananyev 
---
 lib/ethdev/rte_ethdev.c | 183 +---
 1 file changed, 113 insertions(+), 70 deletions(-)

diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c
index 6413c54e3b..09cc4764c3 100644
--- a/lib/ethdev/rte_ethdev.c
+++ b/lib/ethdev/rte_ethdev.c
@@ -36,6 +36,8 @@
 #include "ethdev_trace.h"
 #include "sff_telemetry.h"
 
+#define ETH_XSTATS_ITER_NUM0x100
+
 struct rte_eth_dev rte_eth_devices[RTE_MAX_ETHPORTS];
 
 /* public fast-path API */
@@ -3308,7 +3310,8 @@ int
 rte_eth_xstats_get_id_by_name(uint16_t port_id, const char *xstat_name,
uint64_t *id)
 {
-   int cnt_xstats, idx_xstat;
+   int cnt_xstats, idx_xstat, rc;
+   struct rte_eth_xstat_name *xstats_names;
 
RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
 
@@ -3334,26 +3337,33 @@ rte_eth_xstats_get_id_by_name(uint16_t port_id, const 
char *xstat_name,
}
 
/* Get id-name lookup table */
-   struct rte_eth_xstat_name xstats_names[cnt_xstats];
+   xstats_names = calloc(cnt_xstats, sizeof(xstats_names[0]));
+   if (xstats_names == NULL) {
+   RTE_ETHDEV_LOG_LINE(ERR, "Can't allocate memory");
+   return -ENOMEM;
+   }
 
if (cnt_xstats != rte_eth_xstats_get_names_by_id(
port_id, xstats_names, cnt_xstats, NULL)) {
RTE_ETHDEV_LOG_LINE(ERR, "Cannot get xstats lookup");
+   free(xstats_names);
return -1;
}
 
+   rc = -EINVAL;
for (idx_xstat = 0; idx_xstat < cnt_xstats; idx_xstat++) {
if (!strcmp(xstats_names[idx_xstat].name, xstat_name)) {
*id = idx_xstat;
 
rte_eth_trace_xstats_get_id_by_name(port_id,
xstat_name, *id);
-
-   return 0;
+   rc = 0;
+   break;
};
}
 
-   return -EINVAL;
+   free(xstats_names);
+   return rc;
 }
 
 /* retrieve basic stats names */
@@ -3399,6 +3409,38 @@ eth_basic_stats_get_names(struct rte_eth_dev *dev,
return cnt_used_entries;
 }
 
+static int
+eth_xstats_get_by_name_by_id(struct rte_eth_dev *dev, const uint64_t *ids,
+   struct rte_eth_xstat_name *xstats_names, uint32_t size,
+   uint32_t basic_count)
+{
+   int32_t rc;
+   uint32_t i, k, m, n;
+   uint64_t ids_copy[ETH_XSTATS_ITER_NUM];
+
+   m = 0;
+   for (n = 0; n != size; n += k) {
+
+   k = RTE_MIN(size - n, RTE_DIM(ids_copy));
+
+   /*
+* Convert ids to xstats ids that PMD knows.
+* ids known by user are basic + extended stats.
+*/
+   for (i = 0; i < k; i++)
+   ids_copy[i] = ids[n + i] - basic_count;
+
+   rc = (*dev->dev_ops->xstats_get_names_by_id)(dev, ids_copy,
+   xstats_names + m, k);
+   if (rc < 0)
+   return rc;
+   m += rc;
+   }
+
+   return m;
+}
+
+
 /* retrieve ethdev extended statistics names */
 int
 rte_eth_xstats_get_names_by_id(uint16_t port_id,
@@ -3406,9 +3448,8 @@ rte_eth_xstats_get_names_by_id(uint16_t port_id,
uint64_t *ids)
 {
struct rte_eth_xstat_name *xstats_names_copy;
-   unsigned int no_basic_stat_requested = 1;
-   unsigned int no_ext_stat_requested = 1;
unsigned int expected_entries;
+   unsigned int nb_basic_stats;
unsigned int basic_count;
struct rte_eth_dev *dev;
unsigned int i;
@@ -3434,27 +3475,18 @@ rte_eth_xstats_get_names_by_id(uint16_t port_id,
if (ids && !xstats_names)
return -EINVAL;
 
-   if (ids && dev->dev_ops->xstats_get_names_by_id != NULL && size > 0) {
-   uint64_t ids_copy[size];
-
-   for (i = 0; i < size; i++) {
-   if (ids[i] < basic_count) {
-   no_basic_stat_requested = 0;
-   break;
-   }
-
-

[PATCH v12 21/21] hash: remove use of VLAs by using standard arrays

[Andre Muezerie]

MSVC does not support VLAs, replace VLAs with standard C arrays.

Signed-off-by: Andre Muezerie 
---
 lib/hash/rte_thash_gf2_poly_math.c | 9 -
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/lib/hash/rte_thash_gf2_poly_math.c 
b/lib/hash/rte_thash_gf2_poly_math.c
index 1c62974e71..825da4382f 100644
--- a/lib/hash/rte_thash_gf2_poly_math.c
+++ b/lib/hash/rte_thash_gf2_poly_math.c
@@ -8,6 +8,7 @@
 #include 
 #include 
 
+#define MAX_POLY_DEGREE 32
 #define MAX_TOEPLITZ_KEY_LENGTH 64
 RTE_LOG_REGISTER_SUFFIX(thash_poly_logtype, thash_poly, INFO);
 #define RTE_LOGTYPE_HASH thash_poly_logtype
@@ -149,7 +150,7 @@ gf2_pow(uint32_t a, uint32_t pow, uint32_t r, int degree)
 static uint32_t
 __thash_get_rand_poly(int poly_degree)
 {
-   uint32_t roots[poly_degree];
+   uint32_t roots[MAX_POLY_DEGREE];
uint32_t rnd;
uint32_t ret_poly = 0;
int i, j;
@@ -194,9 +195,7 @@ __thash_get_rand_poly(int poly_degree)
 * Get coefficients of the polynomial for
 * (x - roots[0])(x - roots[1])...(x - roots[n])
 */
-   uint32_t poly_coefficients[poly_degree + 1];
-   for (i = 0; i <= poly_degree; i++)
-   poly_coefficients[i] = 0;
+   uint32_t poly_coefficients[MAX_POLY_DEGREE + 1] = {0};
 
poly_coefficients[0] = 1; /* highest degree term coefficient in the end 
*/
for (i = 0; i < (int)poly_degree; i++) {
@@ -247,7 +246,7 @@ thash_get_rand_poly(uint32_t poly_degree)
 {
uint32_t ret_poly;
 
-   if (poly_degree > 32) {
+   if (poly_degree > MAX_POLY_DEGREE) {
HASH_LOG(ERR, "Wrong polynomial degree %d, must be in range [1, 
32]", poly_degree);
return 0;
}
-- 
2.47.0.vfs.0.3

[PATCH v12 09/21] gro: remove use of VLAs

[Andre Muezerie]

From: Konstantin Ananyev 

../lib/gro/rte_gro.c:182:34: warning:
variable length array used [-Wvla]
../lib/gro/rte_gro.c:363:34: warning:
variable length array used [-Wvla]

In both cases the pattern is the same: we use unprocess_pkts[nb_pkts] to
collect un-used by GRO packets, and then copy them to the start of
input/output pkts[] array.
In both cases, we can safely copy pkts[i] into already
processed entry at the same array, i.e. into pkts[unprocess_num].
Such change eliminates need of temporary VLA: unprocess_pkts[nb_pkts].

Signed-off-by: Konstantin Ananyev 
Acked-by: Ferruh Yigit 
---
 lib/gro/rte_gro.c | 40 ++--
 1 file changed, 14 insertions(+), 26 deletions(-)

diff --git a/lib/gro/rte_gro.c b/lib/gro/rte_gro.c
index db86117609..6d5aadf32a 100644
--- a/lib/gro/rte_gro.c
+++ b/lib/gro/rte_gro.c
@@ -179,7 +179,6 @@ rte_gro_reassemble_burst(struct rte_mbuf **pkts,
struct gro_vxlan_udp4_item vxlan_udp_items[RTE_GRO_MAX_BURST_ITEM_NUM]
= {{{0}} };
 
-   struct rte_mbuf *unprocess_pkts[nb_pkts];
uint32_t item_num;
int32_t ret;
uint16_t i, unprocess_num = 0, nb_after_gro = nb_pkts;
@@ -275,7 +274,7 @@ rte_gro_reassemble_burst(struct rte_mbuf **pkts,
/* Merge successfully */
nb_after_gro--;
else if (ret < 0)
-   unprocess_pkts[unprocess_num++] = pkts[i];
+   pkts[unprocess_num++] = pkts[i];
} else if (IS_IPV4_VXLAN_UDP4_PKT(pkts[i]->packet_type) &&
do_vxlan_udp_gro) {
ret = gro_vxlan_udp4_reassemble(pkts[i],
@@ -284,7 +283,7 @@ rte_gro_reassemble_burst(struct rte_mbuf **pkts,
/* Merge successfully */
nb_after_gro--;
else if (ret < 0)
-   unprocess_pkts[unprocess_num++] = pkts[i];
+   pkts[unprocess_num++] = pkts[i];
} else if (IS_IPV4_TCP_PKT(pkts[i]->packet_type) &&
do_tcp4_gro) {
ret = gro_tcp4_reassemble(pkts[i], &tcp_tbl, 0);
@@ -292,7 +291,7 @@ rte_gro_reassemble_burst(struct rte_mbuf **pkts,
/* merge successfully */
nb_after_gro--;
else if (ret < 0)
-   unprocess_pkts[unprocess_num++] = pkts[i];
+   pkts[unprocess_num++] = pkts[i];
} else if (IS_IPV4_UDP_PKT(pkts[i]->packet_type) &&
do_udp4_gro) {
ret = gro_udp4_reassemble(pkts[i], &udp_tbl, 0);
@@ -300,7 +299,7 @@ rte_gro_reassemble_burst(struct rte_mbuf **pkts,
/* merge successfully */
nb_after_gro--;
else if (ret < 0)
-   unprocess_pkts[unprocess_num++] = pkts[i];
+   pkts[unprocess_num++] = pkts[i];
} else if (IS_IPV6_TCP_PKT(pkts[i]->packet_type) &&
do_tcp6_gro) {
ret = gro_tcp6_reassemble(pkts[i], &tcp6_tbl, 0);
@@ -308,21 +307,15 @@ rte_gro_reassemble_burst(struct rte_mbuf **pkts,
/* merge successfully */
nb_after_gro--;
else if (ret < 0)
-   unprocess_pkts[unprocess_num++] = pkts[i];
+   pkts[unprocess_num++] = pkts[i];
} else
-   unprocess_pkts[unprocess_num++] = pkts[i];
+   pkts[unprocess_num++] = pkts[i];
}
 
if ((nb_after_gro < nb_pkts)
 || (unprocess_num < nb_pkts)) {
-   i = 0;
-   /* Copy unprocessed packets */
-   if (unprocess_num > 0) {
-   memcpy(&pkts[i], unprocess_pkts,
-   sizeof(struct rte_mbuf *) *
-   unprocess_num);
-   i = unprocess_num;
-   }
+
+   i = unprocess_num;
 
/* Flush all packets from the tables */
if (do_vxlan_tcp_gro) {
@@ -360,7 +353,6 @@ rte_gro_reassemble(struct rte_mbuf **pkts,
uint16_t nb_pkts,
void *ctx)
 {
-   struct rte_mbuf *unprocess_pkts[nb_pkts];
struct gro_ctx *gro_ctx = ctx;
void *tcp_tbl, *udp_tbl, *vxlan_tcp_tbl, *vxlan_udp_tbl, *tcp6_tbl;
uint64_t current_time;
@@ -396,33 +388,29 @@ rte_gro_reassemble(struct rte_mbuf **pkts,
do_vxlan_tcp_gro) {
if (gro_vxlan_tcp4_reassemble(pkts[i], vxlan_tcp_tbl,
 

[PATCH v12 10/21] net/ixgbe: remove use of VLAs

[Andre Muezerie]

From: Konstantin Ananyev 

1) ../drivers/net/ixgbe/ixgbe_ethdev.c:3556:46: warning:
variable length array used [-Wvla]
2) ../drivers/net/ixgbe/ixgbe_ethdev.c:3739:23: warning:
variable length array used [-Wvla]
3) ../drivers/net/ixgbe/ixgbe_rxtx_vec_common.h:17:24: warning:
variable length array used [-Wvla]

For first two cases: in fact ixgbe_xstats_calc_num() always returns
constant value, so it should be safe to replace that function invocation
just with a macro that performs same calculations.

For case #3: reassemble_packets() is invoked only by
ixgbe_recv_scattered_burst_vec().
And in turn, ixgbe_recv_scattered_burst_vec() operates only on fixed
max amount of packets per call: RTE_IXGBE_MAX_RX_BURST.
So, it should be safe to replace VLA with fixed size array.

Signed-off-by: Konstantin Ananyev 
Acked-by: Anatoly Burakov 
---
 drivers/net/ixgbe/ixgbe_ethdev.c  | 21 +
 drivers/net/ixgbe/ixgbe_rxtx_vec_common.h |  4 +++-
 2 files changed, 16 insertions(+), 9 deletions(-)

diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index eb431889c3..cdeab563c5 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -3435,11 +3435,16 @@ ixgbe_dev_stats_reset(struct rte_eth_dev *dev)
 }
 
 /* This function calculates the number of xstats based on the current config */
+
+#define IXGBE_XSTATS_CALC_NUM  \
+   (IXGBE_NB_HW_STATS + IXGBE_NB_MACSEC_STATS + \
+   (IXGBE_NB_RXQ_PRIO_STATS * IXGBE_NB_RXQ_PRIO_VALUES) + \
+   (IXGBE_NB_TXQ_PRIO_STATS * IXGBE_NB_TXQ_PRIO_VALUES))
+
 static unsigned
-ixgbe_xstats_calc_num(void) {
-   return IXGBE_NB_HW_STATS + IXGBE_NB_MACSEC_STATS +
-   (IXGBE_NB_RXQ_PRIO_STATS * IXGBE_NB_RXQ_PRIO_VALUES) +
-   (IXGBE_NB_TXQ_PRIO_STATS * IXGBE_NB_TXQ_PRIO_VALUES);
+ixgbe_xstats_calc_num(void)
+{
+   return IXGBE_XSTATS_CALC_NUM;
 }
 
 static int ixgbe_dev_xstats_get_names(__rte_unused struct rte_eth_dev *dev,
@@ -3555,8 +3560,8 @@ static int ixgbe_dev_xstats_get_names_by_id(
}
 
uint16_t i;
-   uint16_t size = ixgbe_xstats_calc_num();
-   struct rte_eth_xstat_name xstats_names_copy[size];
+   struct rte_eth_xstat_name xstats_names_copy[IXGBE_XSTATS_CALC_NUM];
+   const uint16_t size = RTE_DIM(xstats_names_copy);
 
ixgbe_dev_xstats_get_names_by_id(dev, NULL, xstats_names_copy,
size);
@@ -3738,8 +3743,8 @@ ixgbe_dev_xstats_get_by_id(struct rte_eth_dev *dev, const 
uint64_t *ids,
}
 
uint16_t i;
-   uint16_t size = ixgbe_xstats_calc_num();
-   uint64_t values_copy[size];
+   uint64_t values_copy[IXGBE_XSTATS_CALC_NUM];
+   const uint16_t size = RTE_DIM(values_copy);
 
ixgbe_dev_xstats_get_by_id(dev, NULL, values_copy, size);
 
diff --git a/drivers/net/ixgbe/ixgbe_rxtx_vec_common.h 
b/drivers/net/ixgbe/ixgbe_rxtx_vec_common.h
index a4d9ec9b08..c1cf0a581a 100644
--- a/drivers/net/ixgbe/ixgbe_rxtx_vec_common.h
+++ b/drivers/net/ixgbe/ixgbe_rxtx_vec_common.h
@@ -14,11 +14,13 @@ static inline uint16_t
 reassemble_packets(struct ixgbe_rx_queue *rxq, struct rte_mbuf **rx_bufs,
   uint16_t nb_bufs, uint8_t *split_flags)
 {
-   struct rte_mbuf *pkts[nb_bufs]; /*finished pkts*/
+   struct rte_mbuf *pkts[RTE_IXGBE_MAX_RX_BURST]; /*finished pkts*/
struct rte_mbuf *start = rxq->pkt_first_seg;
struct rte_mbuf *end =  rxq->pkt_last_seg;
unsigned int pkt_idx, buf_idx;
 
+   RTE_ASSERT(nb_bufs <= RTE_DIM(pkts));
+
for (buf_idx = 0, pkt_idx = 0; buf_idx < nb_bufs; buf_idx++) {
if (end != NULL) {
/* processing a split packet */
-- 
2.47.0.vfs.0.3

Re: [PATCH v10 21/21] hash: remove use of VLAs by using standard arrays

[Andre Muezerie]

On Wed, Nov 20, 2024 at 10:51:26AM +, Medvedkin, Vladimir wrote:
> Hi Andre,
> 
> On 20/11/2024 03:13, Andre Muezerie wrote:
> >MSVC does not support VLAs, replace VLAs with standard C arrays.
> >
> >Signed-off-by: Andre Muezerie
> >---
> >  lib/hash/rte_thash_gf2_poly_math.c | 7 ---
> >  1 file changed, 4 insertions(+), 3 deletions(-)
> >
> >diff --git a/lib/hash/rte_thash_gf2_poly_math.c 
> >b/lib/hash/rte_thash_gf2_poly_math.c
> >index 1c62974e71..cf7c7d396c 100644
> >--- a/lib/hash/rte_thash_gf2_poly_math.c
> >+++ b/lib/hash/rte_thash_gf2_poly_math.c
> >@@ -8,6 +8,7 @@
> >  #include 
> >  #include 
> >+#define MAX_POLY_DEGREE 32
> >  #define MAX_TOEPLITZ_KEY_LENGTH 64
> >  RTE_LOG_REGISTER_SUFFIX(thash_poly_logtype, thash_poly, INFO);
> >  #define RTE_LOGTYPE_HASH thash_poly_logtype
> >@@ -149,7 +150,7 @@ gf2_pow(uint32_t a, uint32_t pow, uint32_t r, int degree)
> >  static uint32_t
> >  __thash_get_rand_poly(int poly_degree)
> >  {
> >-uint32_t roots[poly_degree];
> >+uint32_t roots[MAX_POLY_DEGREE];
> > uint32_t rnd;
> > uint32_t ret_poly = 0;
> > int i, j;
> >@@ -194,7 +195,7 @@ __thash_get_rand_poly(int poly_degree)
> >  * Get coefficients of the polynomial for
> >  * (x - roots[0])(x - roots[1])...(x - roots[n])
> >  */
> >-uint32_t poly_coefficients[poly_degree + 1];
> >+uint32_t poly_coefficients[MAX_POLY_DEGREE + 1];
> > for (i = 0; i <= poly_degree; i++)
> > poly_coefficients[i] = 0;
> Since poly_coefficients is not a VLA anymore you can initializeit
> with zeros and get rid of the loop

Good observation. I'll update this.

Regards,
Andre

> >@@ -247,7 +248,7 @@ thash_get_rand_poly(uint32_t poly_degree)
> >  {
> > uint32_t ret_poly;
> >-if (poly_degree > 32) {
> >+if (poly_degree > MAX_POLY_DEGREE) {
> > HASH_LOG(ERR, "Wrong polynomial degree %d, must be in range [1, 
> > 32]", poly_degree);
> > return 0;
> > }
> 
> -- 
> Regards,
> Vladimir

Re: [PATCH v5 01/16] eal: provide pack start macro for MSVC

[Andre Muezerie]

On Thu, Nov 21, 2024 at 09:51:36PM +0100, Thomas Monjalon wrote:
> 21/11/2024 20:39, Andre Muezerie:
> > On Tue, Nov 19, 2024 at 09:32:07AM +0100, Morten Brørup wrote:
> > > > From: Andre Muezerie [mailto:andre...@linux.microsoft.com]
> > > > Sent: Tuesday, 19 November 2024 05.35
> > > > 
> > > > From: Tyler Retzlaff 
> > > > 
> > > > MSVC struct packing is not compatible with GCC. Provide a macro that
> > > > can be used to push existing pack value and sets packing to 1-byte.
> > > > The existing __rte_packed macro is then used to restore the pack value
> > > > prior to the push.
> > > > 
> > > > Instead of providing macros exclusively for MSVC and for GCC the
> > > > existing macro is deliberately utilized to trigger a warning if no
> > > > existing packing has been pushed allowing easy identification of
> > > > locations where the __rte_msvc_pack is missing.
> > > > 
> > > > Signed-off-by: Tyler Retzlaff 
> > > > ---
> > > >  lib/eal/include/rte_common.h | 4 +++-
> > > >  1 file changed, 3 insertions(+), 1 deletion(-)
> > > > 
> > > > diff --git a/lib/eal/include/rte_common.h
> > > > b/lib/eal/include/rte_common.h
> > > > index 4d299f2b36..409890863e 100644
> > > > --- a/lib/eal/include/rte_common.h
> > > > +++ b/lib/eal/include/rte_common.h
> > > > @@ -103,8 +103,10 @@ typedef uint16_t unaligned_uint16_t;
> > > >   * Force a structure to be packed
> > > >   */
> > > >  #ifdef RTE_TOOLCHAIN_MSVC
> > > > -#define __rte_packed
> > > > +#define __rte_msvc_pack __pragma(pack(push, 1))
> > > > +#define __rte_packed __pragma(pack(pop))
> > > >  #else
> > > > +#define __rte_msvc_pack
> > > >  #define __rte_packed __attribute__((__packed__))
> > > >  #endif
> > > > 
> > > > --
> > > > 2.47.0.vfs.0.3
> > > 
> > > Before proceeding with this, can we please discuss the alternative, 
> > > proposed here:
> > > https://inbox.dpdk.org/dev/cajfav8ystgibbe+nkt9mc30r0+zp64_kgurhozqd90rd2hx...@mail.gmail.com/
> > > 
> > > The definition of the packing macro in OVS, for reference:
> > > https://github.com/openvswitch/ovs/blob/main/include/openvswitch/compiler.h#L209
> > > 
> > > The current solution requires __rte_packed to be placed at the end of a 
> > > structure, although __attribute__((packed)) is normally allowed at the 
> > > beginning (between the "struct" tag and the name of the structure), which 
> > > introduces a high risk of contributors placing it "incorrectly", thus 
> > > causing errors.
> > > 
> > > I have a strong preference for an __RTE_PACKED(decl) variant.
> > > 
> > > Here's a third alternative:
> > > #ifdef RTE_TOOLCHAIN_MSVC
> > > #define __rte_msvc_pack_begin __pragma(pack(push, 1))
> > > #define __rte_msvc_pack_end   __pragma(pack(pop))
> > > #else
> > > #define __rte_msvc_pack_begin
> > > #define __rte_msvc_pack_end
> > > #endif
> > > 
> > > The third alternative is also problematic, e.g. if a contributor forgets 
> > > the _end after the structure declaration, or adds another structure 
> > > declaration before the _end.
> > > 
> > > -Morten
> > 
> > I looked at the suggestions made and I liked the one having a __RTE_PACKED 
> > macro
> > the most.
> > 
> > Advantages:
> > - Can be placed in front of the struct, or even in the middle. Good for 
> > readability.
> > - Does not require a different macro to be placed at the end of the 
> > structure as was
> >   proposed in V5 series.
> > - Works well in 99% of the cases.
> > 
> > Problems can arise when compiler directives are present in the struct, as 
> > they
> > become arguments for __RTE_PACKED macro. This is not portable.
> > I've seen two situations in the DPDK code:
> > 
> > 1) #defines mentioned in the struct. In this situation we can just move the
> >#define out of the struct.
> > 
> > 2) #if/#ifdef/#elif mentioned in the struct.
> > This is a somewhat common pattern in structs where fields change based on
> > endianness.
> > Example:
> > 
> > /**
> >  * IPv4 Header
> >  */
> > struct __rte_aligned(2) rte_ipv4_hdr {
> > __extension__
> > union {
> > uint8_t version_ihl;/**< version and header length */
> > struct {
> > #if RTE_BYTE_ORDER == RTE_LITTLE_ENDIAN
> > uint8_t ihl:4; /**< header length */
> > uint8_t version:4; /**< version */
> > #elif RTE_BYTE_ORDER == RTE_BIG_ENDIAN
> > uint8_t version:4; /**< version */
> > uint8_t ihl:4; /**< header length */
> > #endif
> > };
> > };
> > uint8_t  type_of_service;   /**< type of service */
> > rte_be16_t total_length;/**< length of packet */
> > ...
> > } __rte_packed;
> > 
> > One way to solve this is to move the #if to the outside. But that involves
> > defining the struct twice (once for each endianness). It's less than
> > ideal because common parts would be duplicated. I'm not sure how popular
> > this would be.
> > It's not so common though (about 1% of the structs?). I think it's an
> > acceptable trade-off to get portabl

Re: [PATCH v9 18/21] build: enable vla warnings on Windows built code

[Andre Muezerie]

On Wed, Nov 20, 2024 at 09:20:29AM -0800, Stephen Hemminger wrote:
> On Tue, 19 Nov 2024 17:54:43 -0800
> Andre Muezerie  wrote:
> 
> > From: Tyler Retzlaff 
> > 
> > MSVC does not support optional C11 VLAs. When building for Windows
> > enable -Wvla so that mingw and clang also fail if a VLA is used.
> > 
> > Signed-off-by: Tyler Retzlaff 
> > ---
> 
> It would be good to catch VLA's in new code even if not on Windows.
> Some parts like testpmd and eal should have it enabled

That sounds like a good idea for further improvement. I would like
to keep that out of scope for this series though, so that other work
can be unblocked, if that is OK.

Regards,
Andre

[PATCH v11 18/21] build: enable vla warnings on Windows built code

[Andre Muezerie]

From: Tyler Retzlaff 

MSVC does not support optional C11 VLAs. When building for Windows
enable -Wvla so that mingw and clang also fail if a VLA is used.

Signed-off-by: Tyler Retzlaff 
Acked-by: Bruce Richardson 
---
 config/meson.build | 4 
 1 file changed, 4 insertions(+)

diff --git a/config/meson.build b/config/meson.build
index 6aaad6d8a4..ebca19b4e5 100644
--- a/config/meson.build
+++ b/config/meson.build
@@ -342,6 +342,10 @@ if cc.get_id() == 'intel'
 warning_flags += '-diag-disable=@0@'.format(i)
 endforeach
 endif
+# no VLAs in code built on Windows
+if is_windows
+warning_flags += '-Wvla'
+endif
 foreach arg: warning_flags
 if cc.has_argument(arg)
 add_project_arguments(arg, language: 'c')
-- 
2.47.0.vfs.0.3

[PATCH v11 17/21] net/mlx5: remove use of VLAs for Windows built code

[Andre Muezerie]

From: Tyler Retzlaff 

MSVC does not support VLAs, replace VLAs with standard C arrays
or alloca(). alloca() is available for all toolchain/platform
combinations officially supported by DPDK.

Signed-off-by: Tyler Retzlaff 
---
 drivers/net/mlx5/mlx5.c  | 5 ++---
 drivers/net/mlx5/mlx5_flow.c | 6 +++---
 2 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c
index 6e4473e2f4..979e54686b 100644
--- a/drivers/net/mlx5/mlx5.c
+++ b/drivers/net/mlx5/mlx5.c
@@ -1598,14 +1598,13 @@ void
 mlx5_rt_timestamp_config(struct mlx5_dev_ctx_shared *sh,
 struct mlx5_hca_attr *hca_attr)
 {
-   uint32_t dw_cnt = MLX5_ST_SZ_DW(register_mtutc);
-   uint32_t reg[dw_cnt];
+   uint32_t reg[MLX5_ST_SZ_DW(register_mtutc)];
int ret = ENOTSUP;
 
if (hca_attr->access_register_user)
ret = mlx5_devx_cmd_register_read(sh->cdev->ctx,
  MLX5_REGISTER_ID_MTUTC, 0,
- reg, dw_cnt);
+ reg, RTE_DIM(reg));
if (!ret) {
uint32_t ts_mode;
 
diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index 16ddd05448..37b5402447 100644
--- a/drivers/net/mlx5/mlx5_flow.c
+++ b/drivers/net/mlx5/mlx5_flow.c
@@ -1479,8 +1479,8 @@ mlx5_flow_item_acceptable(const struct rte_eth_dev *dev,
  "mask/last without a spec is not"
  " supported");
if (item->spec && item->last && !range_accepted) {
-   uint8_t spec[size];
-   uint8_t last[size];
+   uint8_t *spec = alloca(size);
+   uint8_t *last = alloca(size);
unsigned int i;
int ret;
 
@@ -8477,7 +8477,7 @@ mlx5_ctrl_flow_vlan(struct rte_eth_dev *dev,
.type = RTE_FLOW_ITEM_TYPE_END,
},
};
-   uint16_t queue[priv->reta_idx_n];
+   uint16_t *queue = alloca(sizeof(uint16_t) * priv->reta_idx_n);
struct rte_flow_action_rss action_rss = {
.func = RTE_ETH_HASH_FUNCTION_DEFAULT,
.level = 0,
-- 
2.47.0.vfs.0.3

[PATCH v11 13/21] test: remove use of VLAs for Windows built code

[Andre Muezerie]

From: Tyler Retzlaff 

MSVC does not support VLAs, replace VLAs with standard C arrays
or alloca(). alloca() is available for all toolchain/platform
combinations officially supported by DPDK.

Signed-off-by: Tyler Retzlaff 
---
 app/test/test.c   |  2 +-
 app/test/test_cmdline_string.c|  2 +-
 app/test/test_cryptodev.c | 34 +--
 app/test/test_cryptodev_blockcipher.c |  4 +--
 app/test/test_cryptodev_crosscheck.c  |  2 +-
 app/test/test_dmadev.c|  9 +++--
 app/test/test_hash.c  | 14 
 app/test/test_mempool.c   | 25 +++---
 app/test/test_reorder.c   | 48 +++
 app/test/test_service_cores.c |  9 +++--
 app/test/test_thash.c |  7 ++--
 11 files changed, 82 insertions(+), 74 deletions(-)

diff --git a/app/test/test.c b/app/test/test.c
index 680351f6a3..fd653cbbfd 100644
--- a/app/test/test.c
+++ b/app/test/test.c
@@ -105,7 +105,7 @@ int
 main(int argc, char **argv)
 {
struct cmdline *cl;
-   char *tests[argc]; /* store an array of tests to run */
+   char **tests = alloca(sizeof(char *) * argc); /* store an array of 
tests to run */
int test_count = 0;
int i;
char *extra_args;
diff --git a/app/test/test_cmdline_string.c b/app/test/test_cmdline_string.c
index 97516c9400..e1cf86020f 100644
--- a/app/test/test_cmdline_string.c
+++ b/app/test/test_cmdline_string.c
@@ -40,7 +40,7 @@ struct string_elt_str string_elt_strs[] = {
 #if (CMDLINE_TEST_BUFSIZE < STR_TOKEN_SIZE) \
 || (CMDLINE_TEST_BUFSIZE < STR_MULTI_TOKEN_SIZE)
 #undef CMDLINE_TEST_BUFSIZE
-#define CMDLINE_TEST_BUFSIZE RTE_MAX(STR_TOKEN_SIZE, STR_MULTI_TOKEN_SIZE)
+#define CMDLINE_TEST_BUFSIZE RTE_MAX_T(STR_TOKEN_SIZE, STR_MULTI_TOKEN_SIZE, 
size_t)
 #endif
 
 struct string_nb_str {
diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c
index c647baeee1..9fdbfe5150 100644
--- a/app/test/test_cryptodev.c
+++ b/app/test/test_cryptodev.c
@@ -2886,7 +2886,7 @@ create_wireless_algo_hash_session(uint8_t dev_id,
enum rte_crypto_auth_operation op,
enum rte_crypto_auth_algorithm algo)
 {
-   uint8_t hash_key[key_len];
+   uint8_t *hash_key = alloca(key_len);
 
struct crypto_testsuite_params *ts_params = &testsuite_params;
struct crypto_unittest_params *ut_params = &unittest_params;
@@ -2922,7 +2922,7 @@ create_wireless_algo_cipher_session(uint8_t dev_id,
const uint8_t *key, const uint8_t key_len,
uint8_t iv_len)
 {
-   uint8_t cipher_key[key_len];
+   uint8_t *cipher_key = alloca(key_len);
struct crypto_testsuite_params *ts_params = &testsuite_params;
struct crypto_unittest_params *ut_params = &unittest_params;
 
@@ -3074,7 +3074,7 @@ create_wireless_cipher_auth_session(uint8_t dev_id,
const struct wireless_test_data *tdata)
 {
const uint8_t key_len = tdata->key.len;
-   uint8_t cipher_auth_key[key_len];
+   uint8_t *cipher_auth_key = alloca(key_len);
 
struct crypto_testsuite_params *ts_params = &testsuite_params;
struct crypto_unittest_params *ut_params = &unittest_params;
@@ -9078,7 +9078,7 @@ create_aead_session(uint8_t dev_id, enum 
rte_crypto_aead_algorithm algo,
const uint16_t aad_len, const uint8_t auth_len,
uint8_t iv_len)
 {
-   uint8_t aead_key[key_len];
+   uint8_t *aead_key = alloca(key_len);
 
struct crypto_testsuite_params *ts_params = &testsuite_params;
struct crypto_unittest_params *ut_params = &unittest_params;
@@ -12992,7 +12992,7 @@ test_cryptodev_error_recover_helper(uint8_t dev_id, 
const void *test_data, bool
struct crypto_testsuite_params *ts_params = &testsuite_params;
struct crypto_unittest_params *ut_params = &unittest_params;
const struct blockcipher_test_data *tdata = test_data;
-   uint8_t cipher_key[tdata->cipher_key.len];
+   uint8_t *cipher_key = alloca(tdata->cipher_key.len);
struct rte_crypto_sym_op *sym_op = NULL;
struct rte_crypto_op *op = NULL;
char *dst;
@@ -13346,7 +13346,7 @@ static int
 test_AES_GCM_auth_encryption_fail_aad_corrupt(void)
 {
struct aead_test_data tdata;
-   uint8_t aad[gcm_test_case_7.aad.len];
+   uint8_t *aad = alloca(gcm_test_case_7.aad.len);
int res;
 
RTE_LOG(INFO, USER1, "This is a negative test, errors are expected\n");
@@ -13735,7 +13735,7 @@ static int
 test_AES_GCM_auth_decryption_fail_aad_corrupt(void)
 {
struct aead_test_data tdata;
-   uint8_t aad[gcm_test_case_7.aad.len];
+   uint8_t *aad = alloca(gcm_test_case_7.aad.len);
int res;
 
memcpy(&tdata, &gcm_test_case_7, sizeof(struct aead_test_data));
@@ -13987,7 +13987,7 @@ test_authenticated_encryption_sessionless(
int retval;
uint8_t *ciphertext, *auth_tag;
uint16_t pla

Re: [PATCH v5 01/16] eal: provide pack start macro for MSVC

[Andre Muezerie]

On Tue, Nov 19, 2024 at 09:32:07AM +0100, Morten Brørup wrote:
> > From: Andre Muezerie [mailto:andre...@linux.microsoft.com]
> > Sent: Tuesday, 19 November 2024 05.35
> > 
> > From: Tyler Retzlaff 
> > 
> > MSVC struct packing is not compatible with GCC. Provide a macro that
> > can be used to push existing pack value and sets packing to 1-byte.
> > The existing __rte_packed macro is then used to restore the pack value
> > prior to the push.
> > 
> > Instead of providing macros exclusively for MSVC and for GCC the
> > existing macro is deliberately utilized to trigger a warning if no
> > existing packing has been pushed allowing easy identification of
> > locations where the __rte_msvc_pack is missing.
> > 
> > Signed-off-by: Tyler Retzlaff 
> > ---
> >  lib/eal/include/rte_common.h | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/lib/eal/include/rte_common.h
> > b/lib/eal/include/rte_common.h
> > index 4d299f2b36..409890863e 100644
> > --- a/lib/eal/include/rte_common.h
> > +++ b/lib/eal/include/rte_common.h
> > @@ -103,8 +103,10 @@ typedef uint16_t unaligned_uint16_t;
> >   * Force a structure to be packed
> >   */
> >  #ifdef RTE_TOOLCHAIN_MSVC
> > -#define __rte_packed
> > +#define __rte_msvc_pack __pragma(pack(push, 1))
> > +#define __rte_packed __pragma(pack(pop))
> >  #else
> > +#define __rte_msvc_pack
> >  #define __rte_packed __attribute__((__packed__))
> >  #endif
> > 
> > --
> > 2.47.0.vfs.0.3
> 
> Before proceeding with this, can we please discuss the alternative, proposed 
> here:
> https://inbox.dpdk.org/dev/cajfav8ystgibbe+nkt9mc30r0+zp64_kgurhozqd90rd2hx...@mail.gmail.com/
> 
> The definition of the packing macro in OVS, for reference:
> https://github.com/openvswitch/ovs/blob/main/include/openvswitch/compiler.h#L209
> 
> The current solution requires __rte_packed to be placed at the end of a 
> structure, although __attribute__((packed)) is normally allowed at the 
> beginning (between the "struct" tag and the name of the structure), which 
> introduces a high risk of contributors placing it "incorrectly", thus causing 
> errors.
> 
> I have a strong preference for an __RTE_PACKED(decl) variant.
> 
> Here's a third alternative:
> #ifdef RTE_TOOLCHAIN_MSVC
> #define __rte_msvc_pack_begin __pragma(pack(push, 1))
> #define __rte_msvc_pack_end   __pragma(pack(pop))
> #else
> #define __rte_msvc_pack_begin
> #define __rte_msvc_pack_end
> #endif
> 
> The third alternative is also problematic, e.g. if a contributor forgets the 
> _end after the structure declaration, or adds another structure declaration 
> before the _end.
> 
> -Morten

I looked at the suggestions made and I liked the one having a __RTE_PACKED macro
the most.

Advantages:
- Can be placed in front of the struct, or even in the middle. Good for 
readability.
- Does not require a different macro to be placed at the end of the structure 
as was
  proposed in V5 series.
- Works well in 99% of the cases.

Problems can arise when compiler directives are present in the struct, as they
become arguments for __RTE_PACKED macro. This is not portable.
I've seen two situations in the DPDK code:

1) #defines mentioned in the struct. In this situation we can just move the
   #define out of the struct.

2) #if/#ifdef/#elif mentioned in the struct.
This is a somewhat common pattern in structs where fields change based on
endianness.
Example:

/**
 * IPv4 Header
 */
struct __rte_aligned(2) rte_ipv4_hdr {
__extension__
union {
uint8_t version_ihl;/**< version and header length */
struct {
#if RTE_BYTE_ORDER == RTE_LITTLE_ENDIAN
uint8_t ihl:4; /**< header length */
uint8_t version:4; /**< version */
#elif RTE_BYTE_ORDER == RTE_BIG_ENDIAN
uint8_t version:4; /**< version */
uint8_t ihl:4; /**< header length */
#endif
};
};
uint8_t  type_of_service;   /**< type of service */
rte_be16_t total_length;/**< length of packet */
...
} __rte_packed;

One way to solve this is to move the #if to the outside. But that involves
defining the struct twice (once for each endianness). It's less than
ideal because common parts would be duplicated. I'm not sure how popular
this would be.
It's not so common though (about 1% of the structs?). I think it's an
acceptable trade-off to get portable code, but I would like to hear your
thoughts.

Result after moving #if to the outside of the struct:

#if RTE_BYTE_ORDER == RTE_LITTLE_ENDIAN
__RTE_PACKED(
struct __rte_aligned(2) rte_ipv4_hdr {
__extension__
union {
uint8_t version_ihl;/**< version and header length */
struct {
uint8_t ihl:4; /**< header length */
uint8_t version:4; /**< version */
};
};
uint8_t  type_of_service;   /**< type of service */

[PATCH v11 03/21] eal/common: remove use of VLAs

[Andre Muezerie]

From: Konstantin Ananyev 

1) ../lib/eal/common/eal_common_proc.c:695:15
: warning: variable length array used

As msg->num_fds should not exceed RTE_MP_MAX_FD_NUM, replaced
it with fixed size array.

Signed-off-by: Konstantin Ananyev 
Acked-by: Stephen Hemminger 
---
 lib/eal/common/eal_common_proc.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/lib/eal/common/eal_common_proc.c b/lib/eal/common/eal_common_proc.c
index d24093937c..201973c5db 100644
--- a/lib/eal/common/eal_common_proc.c
+++ b/lib/eal/common/eal_common_proc.c
@@ -692,7 +692,8 @@ send_msg(const char *dst_path, struct rte_mp_msg *msg, int 
type)
struct sockaddr_un dst;
struct mp_msg_internal m;
int fd_size = msg->num_fds * sizeof(int);
-   char control[CMSG_SPACE(fd_size)];
+   const int32_t control_sz = CMSG_SPACE(fd_size);
+   char control[CMSG_SPACE(sizeof(msg->fds))];
 
m.type = type;
memcpy(&m.msg, msg, sizeof(*msg));
@@ -712,7 +713,7 @@ send_msg(const char *dst_path, struct rte_mp_msg *msg, int 
type)
msgh.msg_iov = &iov;
msgh.msg_iovlen = 1;
msgh.msg_control = control;
-   msgh.msg_controllen = sizeof(control);
+   msgh.msg_controllen = control_sz;
 
cmsg = CMSG_FIRSTHDR(&msgh);
cmsg->cmsg_len = CMSG_LEN(fd_size);
-- 
2.47.0.vfs.0.3

[PATCH v12 11/21] net/ice: remove use of VLAs

[Andre Muezerie]

From: Konstantin Ananyev 

../drivers/net/ice/ice_rxtx.c:1871:29: warning:
variable length array used [-Wvla]

Here VLA is used as a temp array for mbufs that will be used as a split
RX data buffers.
As at any given time only one thread can do RX from particular queue,
at rx_queue_setup() we can allocate extra space for that array, and then
safely use it at RX fast-path.

Signed-off-by: Konstantin Ananyev 
Acked-by: Anatoly Burakov 
---
 drivers/net/ice/ice_rxtx.c | 18 --
 drivers/net/ice/ice_rxtx.h |  2 ++
 2 files changed, 14 insertions(+), 6 deletions(-)

diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c
index 0c7106c7e0..578453ec89 100644
--- a/drivers/net/ice/ice_rxtx.c
+++ b/drivers/net/ice/ice_rxtx.c
@@ -1186,7 +1186,7 @@ ice_rx_queue_setup(struct rte_eth_dev *dev,
struct ice_vsi *vsi = pf->main_vsi;
struct ice_rx_queue *rxq;
const struct rte_memzone *rz;
-   uint32_t ring_size;
+   uint32_t ring_size, tlen;
uint16_t len;
int use_def_burst_func = 1;
uint64_t offloads;
@@ -1294,9 +1294,14 @@ ice_rx_queue_setup(struct rte_eth_dev *dev,
/* always reserve more for bulk alloc */
len = (uint16_t)(nb_desc + ICE_RX_MAX_BURST);
 
+   /* allocate extra entries for SW split buffer */
+   tlen = ((rxq->offloads & RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT) != 0) ?
+   rxq->rx_free_thresh : 0;
+   tlen += len;
+
/* Allocate the software ring. */
rxq->sw_ring = rte_zmalloc_socket(NULL,
- sizeof(struct ice_rx_entry) * len,
+ sizeof(struct ice_rx_entry) * tlen,
  RTE_CACHE_LINE_SIZE,
  socket_id);
if (!rxq->sw_ring) {
@@ -1305,6 +1310,8 @@ ice_rx_queue_setup(struct rte_eth_dev *dev,
return -ENOMEM;
}
 
+   rxq->sw_split_buf = (tlen == len) ? NULL : rxq->sw_ring + len;
+
ice_reset_rx_queue(rxq);
rxq->q_set = true;
dev->data->rx_queues[queue_idx] = rxq;
@@ -1883,7 +1890,6 @@ ice_rx_alloc_bufs(struct ice_rx_queue *rxq)
uint64_t dma_addr;
int diag, diag_pay;
uint64_t pay_addr;
-   struct rte_mbuf *mbufs_pay[rxq->rx_free_thresh];
 
/* Allocate buffers in bulk */
alloc_idx = (uint16_t)(rxq->rx_free_trigger -
@@ -1898,7 +1904,7 @@ ice_rx_alloc_bufs(struct ice_rx_queue *rxq)
 
if (rxq->offloads & RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT) {
diag_pay = rte_mempool_get_bulk(rxq->rxseg[1].mp,
-   (void *)mbufs_pay, rxq->rx_free_thresh);
+   (void *)rxq->sw_split_buf, rxq->rx_free_thresh);
if (unlikely(diag_pay != 0)) {
PMD_RX_LOG(ERR, "Failed to get payload mbufs in bulk");
return -ENOMEM;
@@ -1923,8 +1929,8 @@ ice_rx_alloc_bufs(struct ice_rx_queue *rxq)
rxdp[i].read.hdr_addr = 0;
rxdp[i].read.pkt_addr = dma_addr;
} else {
-   mb->next = mbufs_pay[i];
-   pay_addr = 
rte_cpu_to_le_64(rte_mbuf_data_iova_default(mbufs_pay[i]));
+   mb->next = rxq->sw_split_buf[i].mbuf;
+   pay_addr = 
rte_cpu_to_le_64(rte_mbuf_data_iova_default(mb->next));
rxdp[i].read.hdr_addr = dma_addr;
rxdp[i].read.pkt_addr = pay_addr;
}
diff --git a/drivers/net/ice/ice_rxtx.h b/drivers/net/ice/ice_rxtx.h
index 45f25b3609..20ee325c2b 100644
--- a/drivers/net/ice/ice_rxtx.h
+++ b/drivers/net/ice/ice_rxtx.h
@@ -139,6 +139,8 @@ struct ice_rx_queue {
uint32_t hw_time_high; /* high 32 bits of timestamp */
uint32_t hw_time_low; /* low 32 bits of timestamp */
uint64_t hw_time_update; /* SW time of HW record updating */
+   struct ice_rx_entry *sw_split_buf;
+   /* address of temp buffer for RX split mbufs */
struct rte_eth_rxseg_split rxseg[ICE_RX_MAX_NSEG];
uint32_t rxseg_nb;
bool ts_enable; /* if rxq timestamp is enabled */
-- 
2.47.0.vfs.0.3

[PATCH v12 02/21] eal/linux: remove use of VLAs

[Andre Muezerie]

From: Konstantin Ananyev 

1) ./lib/eal/linux/eal_interrupts.c:1073:16
: warning: ISO C90 forbids variable length array ‘events’

MSVC does not support VLAs. Use alloca() to allocate the memory on
the stack.

2) ./lib/eal/linux/eal_interrupts.c:1319:16
: warning: ISO C90 forbids variable length array ‘evs’

make eal_epoll_wait() use a fixed size array and use it though multiple
iterations to process up to @maxevents events.
Note that technically it is not one to one replacement, as here we might
reduce number of events returned by first call to epoll_wait(..., timeout);

Signed-off-by: Konstantin Ananyev 
---
 lib/eal/linux/eal_interrupts.c | 32 +++-
 1 file changed, 27 insertions(+), 5 deletions(-)

diff --git a/lib/eal/linux/eal_interrupts.c b/lib/eal/linux/eal_interrupts.c
index 6436f796eb..23039964fc 100644
--- a/lib/eal/linux/eal_interrupts.c
+++ b/lib/eal/linux/eal_interrupts.c
@@ -34,6 +34,8 @@
 #define EAL_INTR_EPOLL_WAIT_FOREVER (-1)
 #define NB_OTHER_INTR   1
 
+#define MAX_ITER_EVNUM RTE_EVENT_ETH_INTR_RING_SIZE
+
 static RTE_DEFINE_PER_LCORE(int, _epfd) = -1; /**< epoll fd per thread */
 
 /**
@@ -1070,7 +1072,7 @@ eal_intr_process_interrupts(struct epoll_event *events, 
int nfds)
 static void
 eal_intr_handle_interrupts(int pfd, unsigned totalfds)
 {
-   struct epoll_event events[totalfds];
+   struct epoll_event *events = alloca(sizeof(struct epoll_event) * 
totalfds);
int nfds = 0;
 
for(;;) {
@@ -1316,8 +1318,9 @@ static int
 eal_epoll_wait(int epfd, struct rte_epoll_event *events,
   int maxevents, int timeout, bool interruptible)
 {
-   struct epoll_event evs[maxevents];
int rc;
+   uint32_t i, k, n, num;
+   struct epoll_event evs[MAX_ITER_EVNUM];
 
if (!events) {
EAL_LOG(ERR, "rte_epoll_event can't be NULL");
@@ -1328,12 +1331,31 @@ eal_epoll_wait(int epfd, struct rte_epoll_event *events,
if (epfd == RTE_EPOLL_PER_THREAD)
epfd = rte_intr_tls_epfd();
 
+   num = maxevents;
+   n = RTE_MIN(RTE_DIM(evs), num);
+
+   /* Process events in chunks of MAX_ITER_EVNUM */
+
while (1) {
-   rc = epoll_wait(epfd, evs, maxevents, timeout);
+   rc = epoll_wait(epfd, evs, n, timeout);
if (likely(rc > 0)) {
+
/* epoll_wait has at least one fd ready to read */
-   rc = eal_epoll_process_event(evs, rc, events);
-   break;
+   for (i = 0, k = 0; rc > 0;) {
+   k += rc;
+   rc = eal_epoll_process_event(evs, rc,
+   events + i);
+   i += rc;
+
+   /*
+* try to read more events that are already
+* available (up to maxevents in total).
+*/
+   n = RTE_MIN(RTE_DIM(evs), num - k);
+   rc = (n == 0) ? 0 : epoll_wait(epfd, evs, n, 0);
+   }
+   return i;
+
} else if (rc < 0) {
if (errno == EINTR) {
if (interruptible)
-- 
2.47.0.vfs.0.3

[PATCH v4 2/9] app/test: fix typo in address compare

[Stephen Hemminger]

The first argument of 'memcmp' function was equal to the second argument.
Therefore ASSERT would always be true.

Link: https://pvs-studio.com/en/blog/posts/cpp/1179/

Fixes: 92073ef961ee ("bond: unit tests")
Cc: declan.dohe...@intel.com
Cc: sta...@dpdk.org

Signed-off-by: Stephen Hemminger 
---
 app/test/test_link_bonding.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/test/test_link_bonding.c b/app/test/test_link_bonding.c
index 805613d7dd..b752a5ecbf 100644
--- a/app/test/test_link_bonding.c
+++ b/app/test/test_link_bonding.c
@@ -792,7 +792,7 @@ test_set_primary_member(void)
&read_mac_addr),
"Failed to get mac address (port %d)",
test_params->bonding_port_id);
-   TEST_ASSERT_SUCCESS(memcmp(&read_mac_addr, &read_mac_addr,
+   TEST_ASSERT_SUCCESS(memcmp(expected_mac_addr, &read_mac_addr,
sizeof(read_mac_addr)),
"bonding port mac address not set to that of 
primary port\n");
 
-- 
2.45.2

[PATCH v4 4/9] app/test: avoid duplicate initialization

[Stephen Hemminger]

The event_dev_config initialization had duplicate assignments
to the same element. Change to use structure initialization
so that compiler will catch this type of bug.

Link: https://pvs-studio.com/en/blog/posts/cpp/1179/

Fixes: f8f9d233ea0e ("test/eventdev: add unit tests")
Cc: jerin.ja...@caviumnetworks.com

Signed-off-by: Stephen Hemminger 
Acked-by: Bruce Richardson 
Acked-by: Abhinandan Gujjar 
---
 app/test/test_event_crypto_adapter.c | 24 ++--
 1 file changed, 10 insertions(+), 14 deletions(-)

diff --git a/app/test/test_event_crypto_adapter.c 
b/app/test/test_event_crypto_adapter.c
index 9d38a66bfa..ab24e30a97 100644
--- a/app/test/test_event_crypto_adapter.c
+++ b/app/test/test_event_crypto_adapter.c
@@ -1154,21 +1154,17 @@ configure_cryptodev(void)
 
 static inline void
 evdev_set_conf_values(struct rte_event_dev_config *dev_conf,
-   struct rte_event_dev_info *info)
+ const struct rte_event_dev_info *info)
 {
-   memset(dev_conf, 0, sizeof(struct rte_event_dev_config));
-   dev_conf->dequeue_timeout_ns = info->min_dequeue_timeout_ns;
-   dev_conf->nb_event_ports = NB_TEST_PORTS;
-   dev_conf->nb_event_queues = NB_TEST_QUEUES;
-   dev_conf->nb_event_queue_flows = info->max_event_queue_flows;
-   dev_conf->nb_event_port_dequeue_depth =
-   info->max_event_port_dequeue_depth;
-   dev_conf->nb_event_port_enqueue_depth =
-   info->max_event_port_enqueue_depth;
-   dev_conf->nb_event_port_enqueue_depth =
-   info->max_event_port_enqueue_depth;
-   dev_conf->nb_events_limit =
-   info->max_num_events;
+   *dev_conf = (struct rte_event_dev_config) {
+   .dequeue_timeout_ns = info->min_dequeue_timeout_ns,
+   .nb_event_ports = NB_TEST_PORTS,
+   .nb_event_queues = NB_TEST_QUEUES,
+   .nb_event_queue_flows = info->max_event_queue_flows,
+   .nb_event_port_dequeue_depth = 
info->max_event_port_dequeue_depth,
+   .nb_event_port_enqueue_depth = 
info->max_event_port_enqueue_depth,
+   .nb_events_limit = info->max_num_events,
+   };
 }
 
 static int
-- 
2.45.2

[PATCH v4 5/9] app/test: fix TLS zero length record

[Stephen Hemminger]

The code was duplicating the same condition three times?
Reading the commit message, the intention was:

Add unit tests to verify the zero len TLS records. Zero len packets are
allowed when content type is app data while zero packet length with
other content type (such as handshake) would result in an error.

Link: https://pvs-studio.com/en/blog/posts/cpp/1179/

Fixes: 79a58624369a ("test/security: verify zero length TLS records")
Cc: vvelum...@marvell.com
Cc: sta...@dpdk.org

Signed-off-by: Stephen Hemminger 
---
 app/test/test_cryptodev.c | 5 +
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c
index c647baeee1..a33ef574cc 100644
--- a/app/test/test_cryptodev.c
+++ b/app/test/test_cryptodev.c
@@ -12253,10 +12253,7 @@ test_tls_record_proto_all(const struct 
tls_record_test_flags *flags)
if (flags->skip_sess_destroy && sec_session_outb == NULL)
sec_session_outb = ut_params->sec_session;
 
-   if (flags->zero_len &&
-   ((flags->content_type == 
TLS_RECORD_TEST_CONTENT_TYPE_HANDSHAKE) ||
-   (flags->content_type == 
TLS_RECORD_TEST_CONTENT_TYPE_HANDSHAKE) ||
-   (flags->content_type == 
TLS_RECORD_TEST_CONTENT_TYPE_HANDSHAKE))) {
+   if (flags->zero_len && flags->content_type != 
TLS_RECORD_TEST_CONTENT_TYPE_APP) {
if (ret == TEST_SUCCESS)
return TEST_FAILED;
goto skip_decrypt;
-- 
2.45.2

[PATCH v4 1/9] app/test: do not duplicate loop variable

[Stephen Hemminger]

Do not use same variable for outer and inner loop in bonding test.
Since the loop is just freeing the resulting burst use bulk free.

Link: https://pvs-studio.com/en/blog/posts/cpp/1179/

Fixes: 92073ef961ee ("bond: unit tests")
Cc: declan.dohe...@intel.com
Cc: sta...@dpdk.org

Signed-off-by: Stephen Hemminger 
Acked-by: Bruce Richardson 
---
 app/test/test_link_bonding.c | 7 +--
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/app/test/test_link_bonding.c b/app/test/test_link_bonding.c
index 4d54706c21..805613d7dd 100644
--- a/app/test/test_link_bonding.c
+++ b/app/test/test_link_bonding.c
@@ -2288,12 +2288,7 @@ test_activebackup_rx_burst(void)
}
 
/* free mbufs */
-   for (i = 0; i < MAX_PKT_BURST; i++) {
-   if (rx_pkt_burst[i] != NULL) {
-   rte_pktmbuf_free(rx_pkt_burst[i]);
-   rx_pkt_burst[i] = NULL;
-   }
-   }
+   rte_pktmbuf_free_bulk(rx_pkt_burst, burst_size);
 
/* reset bonding device stats */
rte_eth_stats_reset(test_params->bonding_port_id);
-- 
2.45.2

[PATCH v4 6/9] app/test: fix operator precedence bug

[Stephen Hemminger]

The test loop was much shorter than desired because when
MAX_NUM is defined with out paren's the divide operator /
takes precedence over shift.

But when MAX_NUM is fixed, some tests take too long
and have to be modified to avoid running over full N^2
space of 1<<20.

Note: this is a very old bug, goes back to 2013.

Link: https://pvs-studio.com/en/blog/posts/cpp/1179/

Fixes: 1fb8b07ee511 ("app: add some tests")
Cc: sta...@dpdk.org

Signed-off-by: Stephen Hemminger 
Acked-by: Bruce Richardson 
---
 app/test/test_common.c | 31 +--
 1 file changed, 17 insertions(+), 14 deletions(-)

diff --git a/app/test/test_common.c b/app/test/test_common.c
index 21eb2285e1..6dbd7fc9a9 100644
--- a/app/test/test_common.c
+++ b/app/test/test_common.c
@@ -9,11 +9,12 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 
 #include "test.h"
 
-#define MAX_NUM 1 << 20
+#define MAX_NUM (1 << 20)
 
 #define FAIL(x)\
{printf(x "() test failed!\n");\
@@ -218,19 +219,21 @@ test_align(void)
}
}
 
-   for (p = 1; p <= MAX_NUM / 2; p++) {
-   for (i = 1; i <= MAX_NUM / 2; i++) {
-   val = RTE_ALIGN_MUL_CEIL(i, p);
-   if (val % p != 0 || val < i)
-   FAIL_ALIGN("RTE_ALIGN_MUL_CEIL", i, p);
-   val = RTE_ALIGN_MUL_FLOOR(i, p);
-   if (val % p != 0 || val > i)
-   FAIL_ALIGN("RTE_ALIGN_MUL_FLOOR", i, p);
-   val = RTE_ALIGN_MUL_NEAR(i, p);
-   if (val % p != 0 || ((val != RTE_ALIGN_MUL_CEIL(i, p))
-   & (val != RTE_ALIGN_MUL_FLOOR(i, p
-   FAIL_ALIGN("RTE_ALIGN_MUL_NEAR", i, p);
-   }
+   /* testing the whole space of 2^20^2 takes too long. */
+   for (j = 1; j <= MAX_NUM ; j++) {
+   i = rte_rand_max(MAX_NUM - 1) + 1;
+   p = rte_rand_max(MAX_NUM - 1) + 1;
+
+   val = RTE_ALIGN_MUL_CEIL(i, p);
+   if (val % p != 0 || val < i)
+   FAIL_ALIGN("RTE_ALIGN_MUL_CEIL", i, p);
+   val = RTE_ALIGN_MUL_FLOOR(i, p);
+   if (val % p != 0 || val > i)
+   FAIL_ALIGN("RTE_ALIGN_MUL_FLOOR", i, p);
+   val = RTE_ALIGN_MUL_NEAR(i, p);
+   if (val % p != 0 || ((val != RTE_ALIGN_MUL_CEIL(i, p))
+& (val != RTE_ALIGN_MUL_FLOOR(i, p
+   FAIL_ALIGN("RTE_ALIGN_MUL_NEAR", i, p);
}
 
return 0;
-- 
2.45.2

[PATCH v4 0/9] Bug fixes for standalone tests

[Stephen Hemminger]

Recent blog post from PVS studio referenced lots bugs found by
their analyzer against DPDK. This set addresses the ones in
the test suite.

v4 - rebase and drop code that was already fixed (removed)

Stephen Hemminger (9):
  app/test: do not duplicate loop variable
  app/test: fix typo in address compare
  app/test: fix paren typo
  app/test: avoid duplicate initialization
  app/test: fix TLS zero length record
  app/test: fix operator precedence bug
  test/eal: fix core check in c flag test
  app/test-pmd: remove redundant condition
  app/test-pmd: avoid potential outside of array reference

 app/test-pmd/cmdline_flow.c   |  2 +-
 app/test-pmd/config.c |  3 +-
 app/test/test_common.c| 31 ++-
 app/test/test_cryptodev.c |  5 +--
 app/test/test_eal_flags.c |  4 +--
 app/test/test_event_crypto_adapter.c  | 24 ++
 app/test/test_link_bonding.c  |  9 ++
 app/test/test_security_inline_proto_vectors.h |  8 +++--
 8 files changed, 39 insertions(+), 47 deletions(-)

-- 
2.45.2

[PATCH v4 9/9] app/test-pmd: avoid potential outside of array reference

[Stephen Hemminger]

The order of comparison is wrong, and potentially allows
referencing past the array.

Link: https://pvs-studio.com/en/blog/posts/cpp/1179/

Fixes: 3e3edab530a1 ("ethdev: add flow quota")
Cc: getel...@nvidia.com
Cc: sta...@dpdk.org

Signed-off-by: Stephen Hemminger 
Acked-by: Bruce Richardson 
---
 app/test-pmd/cmdline_flow.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
index 1e4f2ebc55..9e4fc2d95d 100644
--- a/app/test-pmd/cmdline_flow.c
+++ b/app/test-pmd/cmdline_flow.c
@@ -12892,7 +12892,7 @@ comp_names_to_index(struct context *ctx, const struct 
token *token,
RTE_SET_USED(token);
if (!buf)
return names_size;
-   if (names[ent] && ent < names_size)
+   if (ent < names_size && names[ent] != NULL)
return rte_strscpy(buf, names[ent], size);
return -1;
 
-- 
2.45.2

[PATCH v4 8/9] app/test-pmd: remove redundant condition

[Stephen Hemminger]

The loop over policy actions will always exit when it sees
the flow end action, so the next check is redundant.

Link: https://pvs-studio.com/en/blog/posts/cpp/1179/

Fixes: f29fa2c59b85 ("app/testpmd: support policy actions per color")
Cc: haif...@nvidia.com
Signed-off-by: Stephen Hemminger 
Acked-by: Bruce Richardson 
Acked-by: Ajit Khaparde 
---
 app/test-pmd/config.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index 28d45568ac..4e7fb69183 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -2288,7 +2288,7 @@ port_meter_policy_add(portid_t port_id, uint32_t 
policy_id,
for (act_n = 0, start = act;
act->type != RTE_FLOW_ACTION_TYPE_END; act++)
act_n++;
-   if (act_n && act->type == RTE_FLOW_ACTION_TYPE_END)
+   if (act_n > 0)
policy.actions[i] = start;
else
policy.actions[i] = NULL;
@@ -7338,4 +7338,3 @@ show_mcast_macs(portid_t port_id)
printf("  %s\n", buf);
}
 }
-
-- 
2.45.2

Re: [PATCH v5 01/16] eal: provide pack start macro for MSVC

[Thomas Monjalon]

21/11/2024 20:39, Andre Muezerie:
> On Tue, Nov 19, 2024 at 09:32:07AM +0100, Morten Brørup wrote:
> > > From: Andre Muezerie [mailto:andre...@linux.microsoft.com]
> > > Sent: Tuesday, 19 November 2024 05.35
> > > 
> > > From: Tyler Retzlaff 
> > > 
> > > MSVC struct packing is not compatible with GCC. Provide a macro that
> > > can be used to push existing pack value and sets packing to 1-byte.
> > > The existing __rte_packed macro is then used to restore the pack value
> > > prior to the push.
> > > 
> > > Instead of providing macros exclusively for MSVC and for GCC the
> > > existing macro is deliberately utilized to trigger a warning if no
> > > existing packing has been pushed allowing easy identification of
> > > locations where the __rte_msvc_pack is missing.
> > > 
> > > Signed-off-by: Tyler Retzlaff 
> > > ---
> > >  lib/eal/include/rte_common.h | 4 +++-
> > >  1 file changed, 3 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/lib/eal/include/rte_common.h
> > > b/lib/eal/include/rte_common.h
> > > index 4d299f2b36..409890863e 100644
> > > --- a/lib/eal/include/rte_common.h
> > > +++ b/lib/eal/include/rte_common.h
> > > @@ -103,8 +103,10 @@ typedef uint16_t unaligned_uint16_t;
> > >   * Force a structure to be packed
> > >   */
> > >  #ifdef RTE_TOOLCHAIN_MSVC
> > > -#define __rte_packed
> > > +#define __rte_msvc_pack __pragma(pack(push, 1))
> > > +#define __rte_packed __pragma(pack(pop))
> > >  #else
> > > +#define __rte_msvc_pack
> > >  #define __rte_packed __attribute__((__packed__))
> > >  #endif
> > > 
> > > --
> > > 2.47.0.vfs.0.3
> > 
> > Before proceeding with this, can we please discuss the alternative, 
> > proposed here:
> > https://inbox.dpdk.org/dev/cajfav8ystgibbe+nkt9mc30r0+zp64_kgurhozqd90rd2hx...@mail.gmail.com/
> > 
> > The definition of the packing macro in OVS, for reference:
> > https://github.com/openvswitch/ovs/blob/main/include/openvswitch/compiler.h#L209
> > 
> > The current solution requires __rte_packed to be placed at the end of a 
> > structure, although __attribute__((packed)) is normally allowed at the 
> > beginning (between the "struct" tag and the name of the structure), which 
> > introduces a high risk of contributors placing it "incorrectly", thus 
> > causing errors.
> > 
> > I have a strong preference for an __RTE_PACKED(decl) variant.
> > 
> > Here's a third alternative:
> > #ifdef RTE_TOOLCHAIN_MSVC
> > #define __rte_msvc_pack_begin __pragma(pack(push, 1))
> > #define __rte_msvc_pack_end   __pragma(pack(pop))
> > #else
> > #define __rte_msvc_pack_begin
> > #define __rte_msvc_pack_end
> > #endif
> > 
> > The third alternative is also problematic, e.g. if a contributor forgets 
> > the _end after the structure declaration, or adds another structure 
> > declaration before the _end.
> > 
> > -Morten
> 
> I looked at the suggestions made and I liked the one having a __RTE_PACKED 
> macro
> the most.
> 
> Advantages:
> - Can be placed in front of the struct, or even in the middle. Good for 
> readability.
> - Does not require a different macro to be placed at the end of the structure 
> as was
>   proposed in V5 series.
> - Works well in 99% of the cases.
> 
> Problems can arise when compiler directives are present in the struct, as they
> become arguments for __RTE_PACKED macro. This is not portable.
> I've seen two situations in the DPDK code:
> 
> 1) #defines mentioned in the struct. In this situation we can just move the
>#define out of the struct.
> 
> 2) #if/#ifdef/#elif mentioned in the struct.
> This is a somewhat common pattern in structs where fields change based on
> endianness.
> Example:
> 
> /**
>  * IPv4 Header
>  */
> struct __rte_aligned(2) rte_ipv4_hdr {
>   __extension__
>   union {
>   uint8_t version_ihl;/**< version and header length */
>   struct {
> #if RTE_BYTE_ORDER == RTE_LITTLE_ENDIAN
>   uint8_t ihl:4; /**< header length */
>   uint8_t version:4; /**< version */
> #elif RTE_BYTE_ORDER == RTE_BIG_ENDIAN
>   uint8_t version:4; /**< version */
>   uint8_t ihl:4; /**< header length */
> #endif
>   };
>   };
>   uint8_t  type_of_service;   /**< type of service */
>   rte_be16_t total_length;/**< length of packet */
> ...
> } __rte_packed;
> 
> One way to solve this is to move the #if to the outside. But that involves
> defining the struct twice (once for each endianness). It's less than
> ideal because common parts would be duplicated. I'm not sure how popular
> this would be.
> It's not so common though (about 1% of the structs?). I think it's an
> acceptable trade-off to get portable code, but I would like to hear your
> thoughts.

This code would be portable if Microsoft would align with other compilers.

Also I'm not sure we really need __rte_packed for most network protocols.