about RTL8168 PMD on ARM SoC

[王星]

Hi DPDK,

I am a pmd driver developer from Realtek NIC department,
when I was porting r8168pmd already verified on x86 to an ARM64 SoC Unisoc: 
UIS8650
I found that after NIC Rx init (in general, Rx ring and buffers should have 
been prepared for NIC to DMA read),
the NIC status reg showed RDU (Rx Descriptor Unavailable), which means NIC 
cannot read the proper desc content,

later I sended some packets to NIC hold by testpmd rx_only mode, HW internal Rx 
packet counter can grow to some value, then stuck, 8168pmd Rx debug print 
reported it received less packets than that value, and the print showed up even 
some minutes later!

I doubt the phenomenon is caused by improper HW-based IO coherency support on 
this ARM SoC,
I have read the ARM SoC support list on DPDK website, to name it: NV Bluefield, 
NXP DPAA, Marvell Octeon TX …

Does DPDK (or UIO/VFIO driver or hugetlb driver) need special HW IO cache 
coherency support on ARM platform, say, ACE and Device side MMU etc?
Should the SoC provide specialized UIO/VFIO driver or hugetlb driver and/or 
specific DPDK lib to support such user mode DMA?
Will you please give suggestions, thanks a lot!

BRs

Register for DPDK Userspace (Sept. 6-8)

[Jill Lovato]

Hello DPDK Community!

This is a friendly reminder to please register to join us September 6-8 for
the 2022 DPDK Userspace event! We are meeting face-to-face in Arcachon,
France, and will also provide a virtual option for those unable to travel.

Please check out the agenda to see the fantastic line-up if sessions this
year:
https://events.linuxfoundation.org/dpdk-userspace-summit/program/schedule/


Virtual registration is free, so sign up today to join us and invite your
peers and colleagues!

*Click here to register:*
https://events.linuxfoundation.org/dpdk-userspace-summit/register/


Let us know if there are any questions, and we look forward to seeing you
in a few weeks.

-- 
*Jill Lovato*
Marketing Communications Director
Networking & Edge
The Linux Foundation
jlov...@linuxfoundation.org
Phone: +1.503.703.8268

[PATCH] net/pcap: reduce time for stopping device

[Yiding Zhou]

The pcap file will be synchronized to the disk when stopping the device.
It takes a long time if the file is large that would cause the
'detach sync request' timeout when the device is closed under multi-process
scenario.

This commit fixes the issue by performing synchronization in Tx path

Fixes: 4c173302c307 ("pcap: add new driver")
Cc: sta...@dpdk.org

Signed-off-by: Yiding Zhou 
---
 drivers/net/pcap/pcap_ethdev.c | 18 --
 1 file changed, 16 insertions(+), 2 deletions(-)

diff --git a/drivers/net/pcap/pcap_ethdev.c b/drivers/net/pcap/pcap_ethdev.c
index ec29fd6bc5..52eafa5674 100644
--- a/drivers/net/pcap/pcap_ethdev.c
+++ b/drivers/net/pcap/pcap_ethdev.c
@@ -3,7 +3,7 @@
  * Copyright(c) 2014 6WIND S.A.
  * All rights reserved.
  */
-
+#include 
 #include 
 
 #include 
@@ -38,6 +38,8 @@
 
 #define RTE_PMD_PCAP_MAX_QUEUES 16
 
+#define ETH_PCAP_SYNC_THRESHOLD 0x2000
+
 static char errbuf[PCAP_ERRBUF_SIZE];
 static struct timespec start_time;
 static uint64_t start_cycles;
@@ -47,6 +49,8 @@ static uint8_t iface_idx;
 static uint64_t timestamp_rx_dynflag;
 static int timestamp_dynfield_offset = -1;
 
+RTE_DEFINE_PER_LCORE(uint64_t, _pcap_cached_bytes);
+
 struct queue_stat {
volatile unsigned long pkts;
volatile unsigned long bytes;
@@ -144,6 +148,16 @@ static struct rte_eth_link pmd_link = {
 
 RTE_LOG_REGISTER_DEFAULT(eth_pcap_logtype, NOTICE);
 
+static inline void
+pcap_dumper_data_sync(pcap_dumper_t *dumper, uint32_t bytes)
+{
+   RTE_PER_LCORE(_pcap_cached_bytes) += bytes;
+   if (unlikely(RTE_PER_LCORE(_pcap_cached_bytes) > 
ETH_PCAP_SYNC_THRESHOLD)) {
+   if (!fdatasync(fileno(pcap_dump_file(dumper
+   RTE_PER_LCORE(_pcap_cached_bytes) = 0;
+   }
+}
+
 static struct queue_missed_stat*
 queue_missed_stat_update(struct rte_eth_dev *dev, unsigned int qid)
 {
@@ -421,7 +435,7 @@ eth_pcap_tx_dumper(void *queue, struct rte_mbuf **bufs, 
uint16_t nb_pkts)
 * process stops and to make sure the pcap file is actually written,
 * we flush the pcap dumper within each burst.
 */
-   pcap_dump_flush(dumper);
+   pcap_dumper_data_sync(dumper, tx_bytes);
dumper_q->tx_stat.pkts += num_tx;
dumper_q->tx_stat.bytes += tx_bytes;
dumper_q->tx_stat.err_pkts += nb_pkts - num_tx;
-- 
2.34.1

RE: [PATCH 1/2] net/i40e: compilation fix for GCC-12

[Morten Brørup]

> From: Amit Prakash Shukla [mailto:amitpraka...@marvell.com]
> Sent: Wednesday, 24 August 2022 16.04
> 
> GCC 12 raises the following warning:
> 
> meson --werror --buildtype=debugoptimized
>   --cross-file config/x86/cross-mingw -Dexamples=helloworld build
> ninja -C build
> 
> In function 'i40e_hash_get_pattern_type',
> inlined from 'i40e_hash_get_pattern_pctypes' at
> ../drivers/net/i40e/i40e_hash.c:520:8,
> inlined from 'i40e_hash_parse_pattern_act' at
> ../drivers/net/i40e/i40e_hash.c:1147:9,
> inlined from 'i40e_hash_parse' at
> ../drivers/net/i40e/i40e_hash.c:1181:9:
> ../drivers/net/i40e/i40e_hash.c:389:47:
>   error: array subscript 53 is above array
>   bounds of 'const uint64_t[53]'
>   {aka 'const long long unsigned int[53]'} [-Werror=array-bounds]
>   389 | item_hdr = pattern_item_header[last_item_type];
>   |~~~^~~~
> ../drivers/net/i40e/i40e_hash.c: In function 'i40e_hash_parse':
> ../drivers/net/i40e/i40e_hash.c:182:23: note: while referencing
> 'pattern_item_header'
>   182 | static const uint64_t pattern_item_header[] = {
>   |   ^~~
> cc1: all warnings being treated as errors
> 
> Fixes: ef4c16fd9148 (net/i40e: refactor RSS flow)
> Cc: sta...@dpdk.org
> 
> Signed-off-by: Amit Prakash Shukla 
> ---
> v2:
> - Removed "examples/ipsec-secgw" patch from this series and posted it
> as
> seperate patch.
> 
>  drivers/net/i40e/i40e_hash.c | 6 --
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/i40e/i40e_hash.c
> b/drivers/net/i40e/i40e_hash.c
> index 8962e9d97a..a1ff85fceb 100644
> --- a/drivers/net/i40e/i40e_hash.c
> +++ b/drivers/net/i40e/i40e_hash.c
> @@ -384,8 +384,10 @@ i40e_hash_get_pattern_type(const struct
> rte_flow_item pattern[],
>   }
> 
>   prev_item_type = last_item_type;
> - assert(last_item_type < (enum rte_flow_item_type)
> - RTE_DIM(pattern_item_header));
> + if (last_item_type >= (enum rte_flow_item_type)
> + RTE_DIM(pattern_item_header))

Does this compile with the correct static branch prediction? If not, please add 
unlikely() to error checks like this.

> + goto not_sup;
> +
>   item_hdr = pattern_item_header[last_item_type];
>   assert(item_hdr);
> 
> --
> 2.25.1
> 

RE: [PATCH v2 0/3] Add lcore poll busyness telemetry

[Morten Brørup]

> From: Kevin Laatz [mailto:kevin.la...@intel.com]
> Sent: Wednesday, 24 August 2022 18.25
> 
> Currently, there is no way to measure lcore busyness in a passive way,
> without any modifications to the application. This patchset adds a new
> EAL
> API that will be able to passively track core busyness. As part of the
> set,
> new telemetry endpoints are added to read the generate metrics.
> 
> Anatoly Burakov (2):
>   eal: add lcore poll busyness telemetry
>   eal: add cpuset lcore telemetry entries
> 
> Kevin Laatz (1):
>   doc: add howto guide for lcore poll busyness
> 

At first glance, reading the commit messages, I thought you had ignored the 
feedback.
However, I see that V2 adds "poll" in front of "busyness".

It's just missing in many locations in the code, e.g. in 
eal_common_lcore_telemetry.c, the telemetry command is still registered as 
"/eal/lcore/busyness".

I recommend that you search for "business" in the files, and add "poll" where 
it is missing.

Perhaps one of your testers can do it for you... I know from experience that it 
can be difficult spotting details like this in your own code, whereas many test 
people are good at this stuff. There's even a company here in Denmark offering 
autistics as testers - they are absolutely brilliant at tasks like this!

-Morten

[PATCH v1] net/ice/base: backport FDIR support to 20.11

[Steve Yang]

Add new protocol ID IPV6_NETX_PROTO support for FDIR and RSS,
and always include proto or next header for l3 only RSS case.

The feature depends on the specific ICE DDP packet.

Signed-off-by: Steve Yang 
---
 drivers/net/ice/base/ice_flow.c  | 6 +-
 drivers/net/ice/base/ice_flow.h  | 6 --
 drivers/net/ice/base/ice_protocol_type.h | 1 +
 3 files changed, 10 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ice/base/ice_flow.c b/drivers/net/ice/base/ice_flow.c
index c75f58659c..39acd35093 100644
--- a/drivers/net/ice/base/ice_flow.c
+++ b/drivers/net/ice/base/ice_flow.c
@@ -1100,7 +1100,7 @@ ice_flow_xtract_fld(struct ice_hw *hw, struct 
ice_flow_prof_params *params,
break;
case ICE_FLOW_FIELD_IDX_IPV6_TTL:
case ICE_FLOW_FIELD_IDX_IPV6_PROT:
-   prot_id = seg == 0 ? ICE_PROT_IPV6_OF_OR_S : ICE_PROT_IPV6_IL;
+   prot_id = seg == 0 ? ICE_PROT_IPV6_NEXT_PROTO : 
ICE_PROT_IPV6_IL;
 
/* TTL and PROT share the same extraction seq. entry.
 * Each is considered a sibling to the other in terms of sharing
@@ -1207,6 +1207,10 @@ ice_flow_xtract_fld(struct ice_hw *hw, struct 
ice_flow_prof_params *params,
flds[fld].xtrct.idx = params->es_cnt;
flds[fld].xtrct.mask = ice_flds_info[fld].mask;
 
+   if (prot_id == ICE_PROT_IPV6_NEXT_PROTO) {
+   flds[fld].xtrct.off = 0;
+   flds[fld].xtrct.disp = 0;
+   }
/* Adjust the next field-entry index after accommodating the number of
 * entries this field consumes
 */
diff --git a/drivers/net/ice/base/ice_flow.h b/drivers/net/ice/base/ice_flow.h
index 2a9ae66454..6c8644db1c 100644
--- a/drivers/net/ice/base/ice_flow.h
+++ b/drivers/net/ice/base/ice_flow.h
@@ -22,10 +22,12 @@
 BIT_ULL(ICE_FLOW_FIELD_IDX_ETH_SA))
 #define ICE_FLOW_HASH_IPV4 \
(BIT_ULL(ICE_FLOW_FIELD_IDX_IPV4_SA) | \
-BIT_ULL(ICE_FLOW_FIELD_IDX_IPV4_DA))
+BIT_ULL(ICE_FLOW_FIELD_IDX_IPV4_DA) | \
+BIT_ULL(ICE_FLOW_FIELD_IDX_IPV4_PROT))
 #define ICE_FLOW_HASH_IPV6 \
(BIT_ULL(ICE_FLOW_FIELD_IDX_IPV6_SA) | \
-BIT_ULL(ICE_FLOW_FIELD_IDX_IPV6_DA))
+BIT_ULL(ICE_FLOW_FIELD_IDX_IPV6_DA) | \
+BIT_ULL(ICE_FLOW_FIELD_IDX_IPV6_PROT))
 #define ICE_FLOW_HASH_IPV6_PRE32   \
(BIT_ULL(ICE_FLOW_FIELD_IDX_IPV6_PRE32_SA) | \
 BIT_ULL(ICE_FLOW_FIELD_IDX_IPV6_PRE32_DA))
diff --git a/drivers/net/ice/base/ice_protocol_type.h 
b/drivers/net/ice/base/ice_protocol_type.h
index 8e0557b212..4935938f76 100644
--- a/drivers/net/ice/base/ice_protocol_type.h
+++ b/drivers/net/ice/base/ice_protocol_type.h
@@ -138,6 +138,7 @@ enum ice_prot_id {
ICE_PROT_IPV4_IL= 33,
ICE_PROT_IPV6_OF_OR_S   = 40,
ICE_PROT_IPV6_IL= 41,
+   ICE_PROT_IPV6_NEXT_PROTO = 43,
ICE_PROT_IPV6_FRAG  = 47,
ICE_PROT_TCP_IL = 49,
ICE_PROT_UDP_OF = 52,
-- 
2.25.1

RE: [PATCH] security: remove get_userdata function pointer

[Akhil Goyal]

> Subject: [PATCH] security: remove get_userdata function pointer
> 
> Removes get_userdata function pointer as it is being unused
> and make fast accessing method that uses dynamic field to get
> userdata as default for optimizing security path.
> 
> Signed-off-by: Srujana Challa 
Acked-by: Akhil Goyal 

RE: [PATCH] examples/ipsec-secgw: compilation fix for GCC-12

[Akhil Goyal]

> Subject: [PATCH] examples/ipsec-secgw: compilation fix for GCC-12
> 
> Typecasting uint32_t array to uint16_t and accessing it as max array
> size(at time of declaration of uint32_t array) causes gcc-12 to
> throw an error.
> 
> GCC 12 raises the following warning:
> 
> In function 'send_multi_pkts',
> inlined from 'route6_pkts_neon' at
> ../examples/ipsec-secgw/ipsec_lpm_neon.h:170:2,
> inlined from 'ipsec_poll_mode_wrkr_inl_pr' at
> ../examples/ipsec-secgw/ipsec_worker.c:1257:4:
> ../examples/ipsec-secgw/ipsec_neon.h:261:21: error: 'dst_port' may be used
> uninitialized [-Werror=maybe-uninitialized]
>   261 | dlp = dst_port[i - 1];
>   | ^
> In file included from ../examples/ipsec-secgw/ipsec_worker.c:16:
> ../examples/ipsec-secgw/ipsec_worker.c: In function
> 'ipsec_poll_mode_wrkr_inl_pr':
> ../examples/ipsec-secgw/ipsec_lpm_neon.h:118:17:
>   note: 'dst_port' declared here
>   118 | int32_t dst_port[MAX_PKT_BURST];
>   | ^~~~
> 
> Fixes: ce23f7ceec6b ("examples/ipsec-secgw: add support of NEON with poll
> mode")
> Fixes: dcbf9ad5fdf4 ("examples/ipsec-secgw: move fast path helper functions")
> Cc: sta...@dpdk.org
> 
> Signed-off-by: Amit Prakash Shukla 
> Change-Id: I083405d2c083cb1228e1a0126240937675a44cd9
Change-id need to be removed. Will remove while applying.

Acked-by: Akhil Goyal 

> ---

RE: [PATCH 1/2] examples/ipsec-secgw: use Tx cksum offload conditionally

[Akhil Goyal]

> Subject: [PATCH 1/2] examples/ipsec-secgw: use Tx cksum offload conditionally
> 
> Use Tx checksum offload only when all the ports have it enabled as
> the qconf for a particular lcore stores ipv4_offloads for all the
> Tx ports and each lcore can Tx to any port.
> 
> Fixes: 03128be4cd4d ("examples/ipsec-secgw: allow disabling some Rx/Tx
> offloads")
> Cc: konstantin.anan...@intel.com
> 
> Signed-off-by: Nithin Dabilpuram 
Acked-by: Akhil Goyal 

RE: [PATCH 2/2] examples/ipsec-secgw: fix issue with IP hdr manipulation

[Akhil Goyal]

> Subject: [PATCH 2/2] examples/ipsec-secgw: fix issue with IP hdr manipulation
Title should be 
examples/ipsec-secgw: fix IP header manipulation

Will fix while applying.

> 
> Fix issue with ip header pointer computation to pick the right offset.
> 
> Fixes: 6eb3ba03995c ("examples/ipsec-secgw: support poll mode NEON LPM
> lookup")
> Cc: rbhans...@marvell.com
> 
> Signed-off-by: Nithin Dabilpuram 
Acked-by: Akhil Goyal 

RE: [PATCH] test/crypto: add AES-CCM test vectors

[Akhil Goyal]

> Subject: [PATCH] test/crypto: add AES-CCM test vectors
> 
> From: Archana Muniganti 
> 
> Added ESP tunnel mode known vectors for AES-CCM along with
> combined mode support.
> 
> Signed-off-by: Archana Muniganti 
Acked-by: Akhil Goyal 

RE: dpdk-22.07

[Michael Lekar]

Hello Stephen,

We see the same issue with stable 21.11 version of dpdk.

Regards,
Michael

From: Stephen Hemminger 
Sent: Wednesday, August 24, 2022 5:28 PM
To: Michael Lekar 
Cc: dev 
Subject: Re: dpdk-22.07

Please choose a stable version 22.11 soon, or 21.11.  bugs in 22.07 will not be 
fixed

On Tue, Aug 23, 2022, 11:38 PM Michael Lekar 
mailto:michae...@radware.com>> wrote:
Hi All,

My name is Michaele and I work in Radware Ltd . Currently we use 17.11.3 
version of dpdk in our product.  Now we want to evaluate 22.07 version of dpdk. 
 We want to build statically linkage dpdk-test application and run it on our 
device. We use 7.5 version of gcc. By default, dpdk-test uses shared library, 
and we don’t find how to configure meson for build these test application 
static. We will be very applicate for any help with issue.


[ulp-ng]# ldd dpdk-test
./dpdk-test: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.16' not found 
(required by ./dpdk-test)
./dpdk-test: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.17' not found 
(required by ./dpdk-test)
./dpdk-test: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.27' not found 
(required by ./dpdk-test)
./dpdk-test: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.25' not found 
(required by ./dpdk-test)
linux-vdso.so.1 =>  (0x77ffd000)
libm.so.6 => /lib/x86_64-linux-gnu/libm.so.6 (0x77cfd000)
libdl.so.2 => /lib/x86_64-linux-gnu/libdl.so.2 (0x77af9000)
libnuma.so.1 => /usr/lib/libnuma.so.1 (0x778ed000)
libpcap.so.1 => /usr/lib/libpcap.so.1 (0x776ac000)
libatomic.so.1 => /usr/lib/libatomic.so.1 (0x774a4000)
libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 
(0x77286000)
libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x76ec9000)
/lib64/ld-linux-x86-64.so.2 (0x4000)
[ulp-ng]#

Regards,
Michael

Re: [RFC v3 00/26] Bus and device cleanup for 22.11

[David Marchand]

Hello,

On Fri, Aug 5, 2022 at 1:19 AM Harris, James R  wrote:
> Can we keep rte_pci_register(), or a new variation of it that keeps the
> rte_pci_driver structure hidden?  Hiding rte_pci_register() would mean
> SPDK can no longer work with a packaged DPDK.  Or the DPDK packages
> would need to set enable_driver_sdk which I suspect is not the intent.

What do you think if SPDK maintains a copy of the internal headers?

The internal API are not supposed to change that often, but we (DPDK)
won't guarantee it.
This would still put some maintenance burden on SPDK but I think it is
a good compromise.

I did a PoC this morning and put patches in my forked repo:
https://github.com/david-marchand/spdk/commits/master


-- 
David Marchand

Re: [PATCH] net/pcap: reduce time for stopping device

[Ferruh Yigit]

On 8/25/2022 8:20 AM, Yiding Zhou wrote:

The pcap file will be synchronized to the disk when stopping the device.
It takes a long time if the file is large that would cause the
'detach sync request' timeout when the device is closed under multi-process
scenario.

This commit fixes the issue by performing synchronization in Tx path

Fixes: 4c173302c307 ("pcap: add new driver")
Cc: sta...@dpdk.org

Signed-off-by: Yiding Zhou 
---
  drivers/net/pcap/pcap_ethdev.c | 18 --
  1 file changed, 16 insertions(+), 2 deletions(-)

diff --git a/drivers/net/pcap/pcap_ethdev.c b/drivers/net/pcap/pcap_ethdev.c
index ec29fd6bc5..52eafa5674 100644
--- a/drivers/net/pcap/pcap_ethdev.c
+++ b/drivers/net/pcap/pcap_ethdev.c
@@ -3,7 +3,7 @@
   * Copyright(c) 2014 6WIND S.A.
   * All rights reserved.
   */
-
+#include 
  #include 
  
  #include 

@@ -38,6 +38,8 @@
  
  #define RTE_PMD_PCAP_MAX_QUEUES 16
  
+#define ETH_PCAP_SYNC_THRESHOLD 0x2000

+
  static char errbuf[PCAP_ERRBUF_SIZE];
  static struct timespec start_time;
  static uint64_t start_cycles;
@@ -47,6 +49,8 @@ static uint8_t iface_idx;
  static uint64_t timestamp_rx_dynflag;
  static int timestamp_dynfield_offset = -1;
  
+RTE_DEFINE_PER_LCORE(uint64_t, _pcap_cached_bytes);

+
  struct queue_stat {
volatile unsigned long pkts;
volatile unsigned long bytes;
@@ -144,6 +148,16 @@ static struct rte_eth_link pmd_link = {
  
  RTE_LOG_REGISTER_DEFAULT(eth_pcap_logtype, NOTICE);
  
+static inline void

+pcap_dumper_data_sync(pcap_dumper_t *dumper, uint32_t bytes)
+{
+   RTE_PER_LCORE(_pcap_cached_bytes) += bytes;
+   if (unlikely(RTE_PER_LCORE(_pcap_cached_bytes) > 
ETH_PCAP_SYNC_THRESHOLD)) {
+   if (!fdatasync(fileno(pcap_dump_file(dumper
+   RTE_PER_LCORE(_pcap_cached_bytes) = 0;
+   }
+}
+
  static struct queue_missed_stat*
  queue_missed_stat_update(struct rte_eth_dev *dev, unsigned int qid)
  {
@@ -421,7 +435,7 @@ eth_pcap_tx_dumper(void *queue, struct rte_mbuf **bufs, 
uint16_t nb_pkts)
 * process stops and to make sure the pcap file is actually written,
 * we flush the pcap dumper within each burst.
 */
-   pcap_dump_flush(dumper);
+   pcap_dumper_data_sync(dumper, tx_bytes);


'pcap_dump_flush()' should be doing the same thing, to write buffer to 
file, isn't it working?


Can you check the return value of the 'pcap_dump_flush()' API, I wonder 
if it keeps failing, for some reason?



dumper_q->tx_stat.pkts += num_tx;
dumper_q->tx_stat.bytes += tx_bytes;
dumper_q->tx_stat.err_pkts += nb_pkts - num_tx;

Re: [PATCH v3 3/3] net/ixgbe: move bypass init in a testpmd command

[Ferruh Yigit]

On 7/21/2022 9:05 AM, David Marchand wrote:

Introduce a new command and remove the last part of specific port init
from testpmd.

Signed-off-by: David Marchand


Since there is no objection, I will proceed with this set, it was 
intended for previous release anyway.


In this release we will have time to address any possible issue.

Re: [PATCH v2 0/3] Add lcore poll busyness telemetry

[Kevin Laatz]

On 25/08/2022 08:47, Morten Brørup wrote:

From: Kevin Laatz [mailto:kevin.la...@intel.com]
Sent: Wednesday, 24 August 2022 18.25

Currently, there is no way to measure lcore busyness in a passive way,
without any modifications to the application. This patchset adds a new
EAL
API that will be able to passively track core busyness. As part of the
set,
new telemetry endpoints are added to read the generate metrics.

Anatoly Burakov (2):
   eal: add lcore poll busyness telemetry
   eal: add cpuset lcore telemetry entries

Kevin Laatz (1):
   doc: add howto guide for lcore poll busyness


At first glance, reading the commit messages, I thought you had ignored the 
feedback.
However, I see that V2 adds "poll" in front of "busyness".


I'll make changes to the message to clarify this a bit better.


It's just missing in many locations in the code, e.g. in eal_common_lcore_telemetry.c, 
the telemetry command is still registered as "/eal/lcore/busyness".

Seems some builds are failing in the CI so I'll send a v3 with fixes 
shortly - I'll do another sweep before sending to make sure there are no 
omissions.


-Kevin

RE: [PATCH] net/pcap: reduce time for stopping device

[Zhou, YidingX]

> -Original Message-
> From: Ferruh Yigit 
> Sent: Thursday, August 25, 2022 6:09 PM
> To: Zhou, YidingX ; dev@dpdk.org
> Cc: Zhang, Qi Z ; sta...@dpdk.org
> Subject: Re: [PATCH] net/pcap: reduce time for stopping device
> 
> On 8/25/2022 8:20 AM, Yiding Zhou wrote:
> > The pcap file will be synchronized to the disk when stopping the device.
> > It takes a long time if the file is large that would cause the 'detach
> > sync request' timeout when the device is closed under multi-process
> > scenario.
> >
> > This commit fixes the issue by performing synchronization in Tx path
> >
> > Fixes: 4c173302c307 ("pcap: add new driver")
> > Cc: sta...@dpdk.org
> >
> > Signed-off-by: Yiding Zhou 
> > ---
> >   drivers/net/pcap/pcap_ethdev.c | 18 --
> >   1 file changed, 16 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/net/pcap/pcap_ethdev.c
> > b/drivers/net/pcap/pcap_ethdev.c index ec29fd6bc5..52eafa5674 100644
> > --- a/drivers/net/pcap/pcap_ethdev.c
> > +++ b/drivers/net/pcap/pcap_ethdev.c
> > @@ -3,7 +3,7 @@
> >* Copyright(c) 2014 6WIND S.A.
> >* All rights reserved.
> >*/
> > -
> > +#include 
> >   #include 
> >
> >   #include 
> > @@ -38,6 +38,8 @@
> >
> >   #define RTE_PMD_PCAP_MAX_QUEUES 16
> >
> > +#define ETH_PCAP_SYNC_THRESHOLD 0x2000
> > +
> >   static char errbuf[PCAP_ERRBUF_SIZE];
> >   static struct timespec start_time;
> >   static uint64_t start_cycles;
> > @@ -47,6 +49,8 @@ static uint8_t iface_idx;
> >   static uint64_t timestamp_rx_dynflag;
> >   static int timestamp_dynfield_offset = -1;
> >
> > +RTE_DEFINE_PER_LCORE(uint64_t, _pcap_cached_bytes);
> > +
> >   struct queue_stat {
> > volatile unsigned long pkts;
> > volatile unsigned long bytes;
> > @@ -144,6 +148,16 @@ static struct rte_eth_link pmd_link = {
> >
> >   RTE_LOG_REGISTER_DEFAULT(eth_pcap_logtype, NOTICE);
> >
> > +static inline void
> > +pcap_dumper_data_sync(pcap_dumper_t *dumper, uint32_t bytes) {
> > +   RTE_PER_LCORE(_pcap_cached_bytes) += bytes;
> > +   if (unlikely(RTE_PER_LCORE(_pcap_cached_bytes) >
> ETH_PCAP_SYNC_THRESHOLD)) {
> > +   if (!fdatasync(fileno(pcap_dump_file(dumper
> > +   RTE_PER_LCORE(_pcap_cached_bytes) = 0;
> > +   }
> > +}
> > +
> >   static struct queue_missed_stat*
> >   queue_missed_stat_update(struct rte_eth_dev *dev, unsigned int qid)
> >   {
> > @@ -421,7 +435,7 @@ eth_pcap_tx_dumper(void *queue, struct rte_mbuf
> **bufs, uint16_t nb_pkts)
> >  * process stops and to make sure the pcap file is actually written,
> >  * we flush the pcap dumper within each burst.
> >  */
> > -   pcap_dump_flush(dumper);
> > +   pcap_dumper_data_sync(dumper, tx_bytes);
> 
> 'pcap_dump_flush()' should be doing the same thing, to write buffer to file,
> isn't it working?
> 
> Can you check the return value of the 'pcap_dump_flush()' API, I wonder if it
> keeps failing, for some reason?
> 

'pcap_dump_flush()' returns 0 each time without error, it calls 'fflush()' to 
flush userspace buffers to kernel buffers, not disk. 'fdatasync()' to ensure 
data is written to disk.

> > dumper_q->tx_stat.pkts += num_tx;
> > dumper_q->tx_stat.bytes += tx_bytes;
> > dumper_q->tx_stat.err_pkts += nb_pkts - num_tx;

Re: [PATCH v3 1/3] app/testpmd: restore ixgbe bypass commands

[Ferruh Yigit]

On 7/21/2022 9:05 AM, David Marchand wrote:

Since the switch to meson, ixgbe bypass commands were ineffective as the
RTE_LIBRTE_IXGBE_BYPASS build flag was not set, even though the
net/ixgbe driver had this feature compiled in.

Fixes: 16ade738fd0d ("app/testpmd: build with meson")
Cc: sta...@dpdk.org

Signed-off-by: David Marchand 


For series,
Acked-by: Ferruh Yigit 


Series applied to dpdk-next-net/main, thanks.

Re: [PATCH] net/pcap: reduce time for stopping device

[Ferruh Yigit]

On 8/25/2022 12:17 PM, Zhou, YidingX wrote:




-Original Message-
From: Ferruh Yigit 
Sent: Thursday, August 25, 2022 6:09 PM
To: Zhou, YidingX ; dev@dpdk.org
Cc: Zhang, Qi Z ; sta...@dpdk.org
Subject: Re: [PATCH] net/pcap: reduce time for stopping device

On 8/25/2022 8:20 AM, Yiding Zhou wrote:

The pcap file will be synchronized to the disk when stopping the device.
It takes a long time if the file is large that would cause the 'detach
sync request' timeout when the device is closed under multi-process
scenario.

This commit fixes the issue by performing synchronization in Tx path

Fixes: 4c173302c307 ("pcap: add new driver")
Cc: sta...@dpdk.org

Signed-off-by: Yiding Zhou 
---
   drivers/net/pcap/pcap_ethdev.c | 18 --
   1 file changed, 16 insertions(+), 2 deletions(-)

diff --git a/drivers/net/pcap/pcap_ethdev.c
b/drivers/net/pcap/pcap_ethdev.c index ec29fd6bc5..52eafa5674 100644
--- a/drivers/net/pcap/pcap_ethdev.c
+++ b/drivers/net/pcap/pcap_ethdev.c
@@ -3,7 +3,7 @@
* Copyright(c) 2014 6WIND S.A.
* All rights reserved.
*/
-
+#include 
   #include 

   #include 
@@ -38,6 +38,8 @@

   #define RTE_PMD_PCAP_MAX_QUEUES 16

+#define ETH_PCAP_SYNC_THRESHOLD 0x2000
+


I guess this is 512MB, can you please comment this.
Is there any specific reason to select this value, or is it arbitrary?



   static char errbuf[PCAP_ERRBUF_SIZE];
   static struct timespec start_time;
   static uint64_t start_cycles;
@@ -47,6 +49,8 @@ static uint8_t iface_idx;
   static uint64_t timestamp_rx_dynflag;
   static int timestamp_dynfield_offset = -1;

+RTE_DEFINE_PER_LCORE(uint64_t, _pcap_cached_bytes);
+
   struct queue_stat {
volatile unsigned long pkts;
volatile unsigned long bytes;
@@ -144,6 +148,16 @@ static struct rte_eth_link pmd_link = {

   RTE_LOG_REGISTER_DEFAULT(eth_pcap_logtype, NOTICE);

+static inline void
+pcap_dumper_data_sync(pcap_dumper_t *dumper, uint32_t bytes) {


'pcap_' is the namespace for the libpcap, can you select another prefix, 
like 'eth_pcap_' as many driver functions does.



+   RTE_PER_LCORE(_pcap_cached_bytes) += bytes;
+   if (unlikely(RTE_PER_LCORE(_pcap_cached_bytes) >

ETH_PCAP_SYNC_THRESHOLD)) {

+   if (!fdatasync(fileno(pcap_dump_file(dumper
+   RTE_PER_LCORE(_pcap_cached_bytes) = 0;
+   }
+}
+


pcap supports multiple queue, and each queue creates a new pcap dumper 
and single core/thread can be used for this multiple dumpers. In that 
case I think above per lcore variable logic doesn't work.


And instead of having a global value, what do you think to add a 
variable to 'struct pcap_tx_queue' for this purpose?



   static struct queue_missed_stat*
   queue_missed_stat_update(struct rte_eth_dev *dev, unsigned int qid)
   {
@@ -421,7 +435,7 @@ eth_pcap_tx_dumper(void *queue, struct rte_mbuf

**bufs, uint16_t nb_pkts)

 * process stops and to make sure the pcap file is actually written,
 * we flush the pcap dumper within each burst.
 */
-   pcap_dump_flush(dumper);
+   pcap_dumper_data_sync(dumper, tx_bytes);


'pcap_dump_flush()' should be doing the same thing, to write buffer to file,
isn't it working?

Can you check the return value of the 'pcap_dump_flush()' API, I wonder if it
keeps failing, for some reason?



'pcap_dump_flush()' returns 0 each time without error, it calls 'fflush()' to 
flush userspace buffers to kernel buffers, not disk. 'fdatasync()' to ensure 
data is written to disk.



'pcap_dump_flush()' API documentation says "flushes the output buffer to 
the ``savefile,''", but as you said it uses 'fflush()' internally, so 
there is a chance that data is not written to the disk.


In this case, won't need to keep both, first flush and later 
fsync/fdatasync?


Do you observe any performance difference after change, since now 
writing to actual disk on datapath?



dumper_q->tx_stat.pkts += num_tx;
dumper_q->tx_stat.bytes += tx_bytes;
dumper_q->tx_stat.err_pkts += nb_pkts - num_tx;

Re: [PATCH v1] vhost: fix build

[zhoumin]

Hi David,

Thanks for your kind reply.


On Wed, Aug 24, 2022 at 22:09, David Marchand wrote:

On Mon, Aug 22, 2022 at 9:42 AM Min Zhou  wrote:

This patch fixes the following build failure seen on CentOS 8
with gcc 12.1 because of uninitialized struct variable:

   [..]
../lib/vhost/virtio_net.c:1159:18: warning: 'buf_vec[0].buf_addr' may be used 
uninitialized [-Wmaybe-uninitialized]
1159 | buf_addr = buf_vec[vec_idx].buf_addr;
  | ~^~~
   [..]

I don't like setting the whole variable to 0 just to silence a
warning, like pushing something under the rug.
This is all the more suspicious as there is other code in this file
that does almost the same.

I'm sorry. I did see the same code at eight places in this file. They
are all similar to the following:

    struct buf_vector buf_vec[BUF_VECTOR_MAX];

    [...]
    fill_vec_buf_{split, packed}(.., buf_vec, ..)

    [...]
    mbuf_to_desc(.., buf_vec, ..) or desc_to_mbuf(.., buf_vec, ..)

At these eight places, the array variable `buf_vec` is not explicitly
initialized. Actually, all these `buf_vec` arraies are initialized by
sub-function calls under various conditions.

When I saw the GCC warning at line 1838, I decided to initialize the
`buf_vec` array by calling memset() at all eight places. But when I
just did that for line 1838, the GCC warning was disappeared. I'm not
familiar with vhost, so this made me puzzled and I tried to minimize
the amount of code modification.

I wondered if the uninitialized case at line 1838 is such evident to
GCC that it can be easily found and the other seven uninitialized cases
are hidden by more complicated sub-function call routines which made
GCC more cautious to warn. I am not sure either, but that's what I am
guessing.

Now I think I'm wrong. I sorted out the sub-function calls related to the
`buf_vec` array for all these eight places as follows. **Assignment**
means assigning values to member of the `buf_vec` array. **Using**
means using values from the `buf_vec` array.

1. virtio_dev_rx_split // line 1330
   |__ reserve_avail_buf_split
   |    |__ fill_vec_buf_split
   |    |__ map_one_desc // assign values to buf_vec[vec_id]
   |__ mbuf_to_desc // use values from buf_vec[vec_id]

2. virtio_dev_rx_single_packed // line 1498
   |__ vhost_enqueue_single_packed
    |__ fill_vec_buf_packed
    |    |__ fill_vec_buf_packed_indirect
    |    |    |__ map_one_desc // assignment
    |    |__ map_one_desc // assignment
    |__ mbuf_to_desc // using

3. virtio_dev_rx_async_submit_split // line 1670
   |__ reserve_avail_buf_split
   |    |__ fill_vec_buf_split
   |    |__ map_one_desc // assignment
   |__ mbuf_to_desc // using

4. virtio_dev_rx_async_packed // line 1834
   |__ vhost_enqueue_async_pakced
    |__ fill_vec_buf_packed
    |    |__ fill_vec_buf_packed_indirect
    |    |    |__ map_one_desc // assignment
    |    |__ map_one_desc // assignment
    |__ mbuf_to_desc // **using, but gcc emits warning**

5. virtio_dev_tx_split // line 2878
   |__ fill_vec_buf_split
   |    |__ map_one_desc // assignment
   |__ desc_to_mbuf // using

6. vhost_dequeue_single_packed // line 3105
   |__ fill_vec_buf_packed
   |    |__ fill_vec_buf_packed_indirect
   |    |    |__ map_one_desc // assignment
   |    |__ map_one_desc // assignment
   |__ desc_to_mbuf // using

7. virtio_dev_tx_async_split // line 3397
   |__ fill_vec_buf_split
   |    |__ map_one_desc // assignment
   |__ desc_to_mbuf // using

8. virtio_dev_tx_async_single_packed // line 3571
   |__ fill_vec_buf_packed
   |    |__ fill_vec_buf_packed_indirect
   |    |    |__ map_one_desc // assignment
   |    |__ map_one_desc // assignment
   |__ desc_to_mbuf // using

However, I cannot guess the warning rules of GCC from the above calling
relationships. These eight groups of calling relationships seem to follow
the same pattern and are not significantly different. It's difficult for
me to find the real reasons behind the GCC warning.


I had seen a similar warning during 22.07 when cross compiling but did
not investigate much.
The patch that I had written at the time was:

diff --git a/lib/vhost/virtio_net.c b/lib/vhost/virtio_net.c
index 35fa4670fd..9446e33aa7 100644
--- a/lib/vhost/virtio_net.c
+++ b/lib/vhost/virtio_net.c
@@ -1153,7 +1153,7 @@ mbuf_to_desc(struct virtio_net *dev, struct
vhost_virtqueue *vq,
 struct virtio_net_hdr_mrg_rxbuf tmp_hdr, *hdr = NULL;
 struct vhost_async *async = vq->async;

-   if (unlikely(m == NULL))
+   if (unlikely(m == NULL || nr_vec == 0))
 return -1;

 buf_addr = buf_vec[vec_idx].buf_addr;


Could you see if this fixes your issue?

If it is the case, it may be worth better understanding what bothers
the compiler in the current code.



I have verified that the solution you proposed here is effective. It can
eliminate the GCC warning. But I don't know what this change means for
the compiler.

DPDK Release Status Meeting 2022-08-25

[Mcnamara, John]

Release status meeting minutes 2022-08-25
=

Agenda:
* Release Dates
* Subtrees
* Roadmaps
* LTS
* Defects
* Opens

Participants:
* ARM
* Canonical [No]
* Debian/Microsoft [No]
* Intel
* Marvell
* Nvidia
* Red Hat
* Xilinx/AMD


Release Dates
-

The following are the proposed current dates for 22.11:

* V1 deadline: 24 August   2022 (previously 14 August)
* RC1:  3 October  2022
* RC2: 23 October  2022
* RC3: 31 October  2022
* Release: 16 November 2022

Subtrees


* next-net
  * New drivers in this release
* Microsoft Azure Network Adapter (MANA) PMD
  * There are several RDMA implementation now.
  * Should we have RDMA bus driver?
* Google Virtual Ethernet (GVE)
* idpf (Infrastructure Data Path Function) PMD
* net/qdma PMD
  * Work on removing deprecated flow API/code - needs acks from Intel
* 
https://lore.kernel.org/all/20220812191827.3187441-1-ivan.ma...@oktetlabs.ru/
  * Flow director clean-up also needs a lot of code change from Intel
* https://patches.dpdk.org/project/dpdk/list/?series=24187


* next-net-intel
  * Some patches merged and awaiting pull

* next-net-mlx
  * No update

* next-net-brcm
  * No update

* next-net-mrvl
  * 30-40 patches in this release

* next-eventdev
  * Probably 30-40 patches in this release

* next-virtio
  * Around 30 patches in queue
  * Several vhost patches

* next-crypto
  * 150+ patches
  * Some reviewed and will be applied
  * Patches for BBDev - needs review
  * Adding crypto security and sessions rework
  * Additional FIPs validation patches in this release

* main
  * V1 deadline was Wednesday August 24th
  * New arch type: LoongArch
  * Proposed RC1 date (3 October) clashes with a national holiday
in PRC (October 1st - ~October 7th). We may need to push RC1
to October 10th, but that is late, so this needs some
consideration/discussion.


Other
-

* DPDK Summit: https://events.linuxfoundation.org/dpdk-userspace-summit/
  * Event Dates: Tuesday, September 6 - Thursday, September 8, 2022
  * Schedule: 
https://events.linuxfoundation.org/dpdk-userspace-summit/program/schedule/


LTS
---

Waiting for test results. Aiming for August 29th for all 3 LTSs.

* 21.11.2
  * Back porting in progress

* 20.11.6
  * Back porting in progress

* 19.11.13
  * Back porting in progress



* Distros
  * v20.11 in Debian 11
  * Ubuntu 22.04 contains 21.11

Defects
---

* Bugzilla links, 'Bugs',  added for hosted projects
  * https://www.dpdk.org/hosted-projects/


Opens
-

* None


DPDK Release Status Meetings


The DPDK Release Status Meeting is intended for DPDK Committers to discuss the
status of the master tree and sub-trees, and for project managers to track
progress or milestone dates.

The meeting occurs on every Thursday at 9:30 UTC. on https://meet.jit.si/DPDK

If you wish to attend just send an email to "John McNamara 
john.mcnam...@intel.com" for the invite.

RE: [RFC 1/2] vhost: add ingress API for port mirroring datapath

[Jiang, Cheng1]

Hi,

> -Original Message-
> From: Morten Brørup 
> Sent: Thursday, August 18, 2022 4:17 PM
> To: Jiang, Cheng1 ; Stephen Hemminger
> 
> Cc: maxime.coque...@redhat.com; Xia, Chenbo ;
> dev@dpdk.org; Hu, Jiayu ; Ding, Xuan
> ; Ma, WenwuX ; Wang,
> YuanX ; Yang, YvonneX 
> Subject: RE: [RFC 1/2] vhost: add ingress API for port mirroring datapath
> 
> > From: Jiang, Cheng1 [mailto:cheng1.ji...@intel.com]
> > Sent: Thursday, 18 August 2022 08.58
> >
> > Hi,
> >
> > > -Original Message-
> > > From: Stephen Hemminger 
> > > Sent: Sunday, August 14, 2022 10:58 PM
> > >
> > > On Sun, 14 Aug 2022 12:49:19 +
> > > Cheng Jiang  wrote:
> > >
> > > > From: Wenwu Ma 
> > > >
> > > > Similar to the port mirroring function on the switch or router,
> > this
> > > > patch also implements an ingress function on the Vhost lib. When
> > data
> > > > is sent to a front-end, it will also send the data to its mirror
> > > > front-end.
> > > >
> > > > Signed-off-by: Cheng Jiang 
> > > > Signed-off-by: Wenwu Ma 
> > >
> > > We already have rte_flow, packet capture, and rx/tx callbacks.
> > > This seems like re-invention.
> >
> > Sorry that I didn't make it clear in the v1 commit message. This port
> > mirror function is based on async vhost which is accelerated by DMA
> > device. Compared with other mirror implements: 1. It's targeted for
> > vhost. 2. The performance is really good. Its use scenario is to let
> > one front-end(mirror-VM) monitor the traffic of another front-end(VM).
> > It's different from the things you mentioned above. So, IMO I don't
> > think it's re-invention.
> >
> > Thanks,
> > Cheng
> 
> Thank you for elaborating the use case.
> 
> In other words: This is a performance optimization for a specific use case.
> 
> This raises two questions:
> 
> 1. Please convince us that this is a common use case?

Using VM to monitor the other VM's traffic is a common use case. This is 
commonly used in an intrusion detection system, passive probe or real user 
monitoring technology.

> 2. What is the performance compared to implementing it at the application
> level?
> 

This API is introduced mainly to enable DMA acceleration in vhost port mirror 
scenario. And leverage DMA's strong performance.

> 
> Overall, I totally agree with Stephen:
> 
> Port Mirroring was removed from ethdev with the 21.11 release [1] for the
> reasons mentioned by Stephen. Please don't try to reintroduce it.
> 
> If the application needs to mirror all (or some) packets, why not just let the
> application do it?
> 
> Furthermore, the application might need to mirror the packets to a physical
> port, and perhaps encapsulate it for remote packet capture. Sampling could
> also be required. Here's a prediction for you: More features will creep into 
> to
> this API over time, and it will end up like the ethdev mirroring API being
> removed because the alternatives are better and more versatile.

First of all, These are Vhost lib APIs based on async vhost which is 
accelerated by DMA device.
And they are provided for Vhost PMD or other Vhost applications. So, I am not 
sure whether these APIs are similar to ethdev mirroring APIs which are removed.

As far as I understand, RTE_FLOW is used for ethdev. I'm not sure there are 
conflicts between mirror API in Vhost and RTE_FLOW, since vhost/virtio is a 
virtual protocol.

We will consider your suggestion carefully again.
Thank you very much.
Cheng

> 
> [1]: https://doc.dpdk.org/guides/rel_notes/release_21_11.html#removed-
> items

Re: [PATCH v5 1/7] bbdev: allow operation type enum for growth

[Maxime Coquelin]

Hi Nicolas,

On 7/7/22 01:28, Nicolas Chautru wrote:

Updating the enum for rte_bbdev_op_type
to allow to keep ABI compatible for enum insertion
while adding padded maximum value for array need.
Removing RTE_BBDEV_OP_TYPE_COUNT and instead exposing
RTE_BBDEV_OP_TYPE_PADDED_MAX.

Signed-off-by: Nicolas Chautru 
---
  app/test-bbdev/test_bbdev.c  | 2 +-
  app/test-bbdev/test_bbdev_perf.c | 4 ++--
  examples/bbdev_app/main.c| 2 +-
  lib/bbdev/rte_bbdev.c| 8 +---
  lib/bbdev/rte_bbdev_op.h | 2 +-
  5 files changed, 10 insertions(+), 8 deletions(-)



Acked-by: Maxime Coquelin 

Thanks,
Maxime

Re: [PATCH v5 1/7] eal/loongarch: support LoongArch architecture

[David Marchand]

This is only a first pass.

On Wed, Aug 24, 2022 at 10:31 AM Min Zhou  wrote:
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 32ffdd1a61..f00b82b5ce 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -311,6 +311,12 @@ F: config/riscv/
>  F: doc/guides/linux_gsg/cross_build_dpdk_for_riscv.rst
>  F: lib/eal/riscv/
>
> +LoongArch
> +M: Min Zhou 
> +F: config/loongarch/
> +F: doc/guides/linux_gsg/cross_build_dpdk_for_loongarch.rst
> +F: lib/eal/loongarch/
> +

I tried to put entries in MAINTAINERS in a pseudo alphabetical order
(ignoring the vendor name).
We currently have: ARM, Power, RISC-V, X86.

As a consequence, the block for LoongArch should be moved between ARM,
and Power arches.


>  Intel x86
>  M: Bruce Richardson 
>  M: Konstantin Ananyev 

[snip]

> diff --git a/config/loongarch/meson.build b/config/loongarch/meson.build
> new file mode 100644
> index 00..e052fbad7f
> --- /dev/null
> +++ b/config/loongarch/meson.build
> @@ -0,0 +1,43 @@
> +# SPDX-License-Identifier: BSD-3-Clause
> +# Copyright(c) 2022 Loongson Technology Corporation Limited
> +
> +if not dpdk_conf.get('RTE_ARCH_64')
> +error('Only 64-bit compiles are supported for this platform type')
> +endif
> +dpdk_conf.set('RTE_ARCH', 'loongarch')
> +dpdk_conf.set('RTE_ARCH_LOONGARCH', 1)
> +dpdk_conf.set('RTE_ARCH_NO_VECTOR', 1)

?
RTE_ARCH_NO_VECTOR is not used anywhere, please remove.


> +
> +machine_args_generic = [
> +['default', ['-march=loongarch64']],
> +]
> +
> +flags_generic = [
> +['RTE_MACHINE', '"loongarch64"'],
> +['RTE_MAX_LCORE', 64],
> +['RTE_MAX_NUMA_NODES', 16],
> +['RTE_CACHE_LINE_SIZE', 64]]
> +
> +impl_generic = ['Generic loongarch', flags_generic, machine_args_generic]
> +
> +machine = []
> +machine_args = []
> +
> +machine = impl_generic
> +impl_pn = 'default'
> +
> +message('Implementer : ' + machine[0])
> +foreach flag: machine[1]
> +if flag.length() > 0
> +dpdk_conf.set(flag[0], flag[1])
> +endif
> +endforeach
> +
> +foreach marg: machine[2]
> +if marg[0] == impl_pn
> +foreach f: marg[1]
> +   machine_args += f
> +endforeach
> +endif
> +endforeach
> +message(machine_args)

[snip]

> diff --git a/doc/guides/linux_gsg/index.rst b/doc/guides/linux_gsg/index.rst
> index 747552c385..c34966b241 100644
> --- a/doc/guides/linux_gsg/index.rst
> +++ b/doc/guides/linux_gsg/index.rst
> @@ -15,6 +15,7 @@ Getting Started Guide for Linux
>  build_dpdk
>  cross_build_dpdk_for_arm64
>  cross_build_dpdk_for_riscv
> +cross_build_dpdk_for_loongarch

In alphabetical order please.


>  linux_drivers
>  build_sample_apps
>  linux_eal_parameters
> diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst
> index 7f6cb914a5..8afa7ef7fd 100644
> --- a/doc/guides/nics/features.rst
> +++ b/doc/guides/nics/features.rst
> @@ -848,6 +848,12 @@ rv64
>  Support 64-bit RISC-V architecture.
>
>
> +LoongArch64
> +---
> +
> +Support 64-bit LoongArch architecture.
> +
> +

Idem.


>  x86-32
>  --
>
> diff --git a/doc/guides/nics/features/default.ini 
> b/doc/guides/nics/features/default.ini
> index d1db0c256a..8bbc4600bd 100644
> --- a/doc/guides/nics/features/default.ini
> +++ b/doc/guides/nics/features/default.ini
> @@ -73,6 +73,7 @@ ARMv7=
>  ARMv8=
>  Power8   =
>  rv64 =
> +LoongArch64  =

Idem.


>  x86-32   =
>  x86-64   =
>  Usage doc=
> diff --git a/doc/guides/rel_notes/release_22_11.rst 
> b/doc/guides/rel_notes/release_22_11.rst
> index 8c021cf050..126160d683 100644
> --- a/doc/guides/rel_notes/release_22_11.rst
> +++ b/doc/guides/rel_notes/release_22_11.rst
> @@ -55,6 +55,12 @@ New Features
>   Also, make sure to start the actual text at the margin.
>   ===
>
> +* **Added initial LoongArch architecture support.**
> +
> +  Added EAL implementation for LoongArch architecture. The initial devices
> +  the porting was tested on included Loongson 3A5000, Loongson 3C5000 and
> +  Loongson 3C5000L. In theory this implementation should work with any target
> +  based on ``LoongArch`` ISA.

Sections in the release notes are separated with two empty lines.

>
>  Removed Items
>  -

[snip]

> diff --git a/lib/eal/loongarch/include/meson.build 
> b/lib/eal/loongarch/include/meson.build
> new file mode 100644
> index 00..d5699c5373
> --- /dev/null
> +++ b/lib/eal/loongarch/include/meson.build
> @@ -0,0 +1,21 @@
> +# SPDX-License-Identifier: BSD-3-Clause
> +# Copyright(c) 2022 Loongson Technology Corporation Limited
> +
> +arch_headers = files(
> +   'rte_atomic.h',
> +   'rte_byteorder.h',
> +   'rte_cpuflags.h',
> +   'rte_cycles.h',
> +   'rte_io.h',
> +   'rte_mcslock.h',
> +   'rte_memcpy.h',
> +   'rte_pause.h',
> +   'rte_pflock.h',
> +   'rte_power_intrinsics.h',
> +   'rte_prefetch.h',
> +

Re: [PATCH v5 1/7] eal/loongarch: support LoongArch architecture

[David Marchand]

On Thu, Aug 25, 2022 at 3:56 PM David Marchand
 wrote:
>
> This is only a first pass.

Additionnally, please run ./devtools/check-meson.py.
I see tabulations where we expect spaces.


-- 
David Marchand

Re: [PATCH v4 2/7] bbdev: add device status info

[Maxime Coquelin]

On 7/6/22 23:16, Chautru, Nicolas wrote:

+};
+
   /** Device statistics. */
   struct rte_bbdev_stats {
uint64_t enqueued_count;  /**< Count of all operations enqueued */
@@ -285,12 +300,14 @@ struct rte_bbdev_driver_info {
/** Set if device supports per-queue interrupts */
bool queue_intr_supported;
/** Minimum alignment of buffers, in bytes */
-   uint16_t min_alignment;
-   /** HARQ memory available in kB */
+   /** Device Status */
+   enum rte_bbdev_device_status device_status;

New elements should be added to the end to improve backward compatibility.

Same comment in different patch. I would like to know if there is a real 
recommendation from DPDK on this. I have heard opposite view as well.
In that very case we are breaking the ABI in that new serie for 22.11 (sizes 
and offsets are changing).



Since we are breaking ABI anyways, I don't find it unreasonable to take
the opportunity to improve packing the struct.

Maxime

Re: [PATCH v1] vhost: fix build

[David Marchand]

Hello,

On Thu, Aug 25, 2022 at 2:37 PM zhoumin  wrote:
> >
> > I had seen a similar warning during 22.07 when cross compiling but did
> > not investigate much.
> > The patch that I had written at the time was:
> >
> > diff --git a/lib/vhost/virtio_net.c b/lib/vhost/virtio_net.c
> > index 35fa4670fd..9446e33aa7 100644
> > --- a/lib/vhost/virtio_net.c
> > +++ b/lib/vhost/virtio_net.c
> > @@ -1153,7 +1153,7 @@ mbuf_to_desc(struct virtio_net *dev, struct
> > vhost_virtqueue *vq,
> >  struct virtio_net_hdr_mrg_rxbuf tmp_hdr, *hdr = NULL;
> >  struct vhost_async *async = vq->async;
> >
> > -   if (unlikely(m == NULL))
> > +   if (unlikely(m == NULL || nr_vec == 0))
> >  return -1;
> >
> >  buf_addr = buf_vec[vec_idx].buf_addr;
> >
> >
> > Could you see if this fixes your issue?
> >
> > If it is the case, it may be worth better understanding what bothers
> > the compiler in the current code.
> >
> >
> I have verified that the solution you proposed here is effective. It can
> eliminate the GCC warning. But I don't know what this change means for
> the compiler.
>
>  From the programmer's point of view, we can know the binding relationship
> between the `nr_vec` variable and the `buf_vec` array. we can use
> "nr_vec == 0" to determine the validity of the `buf_vec[0]`. But, I'm not
> sure if the compiler knows about it. I cannot explain from the GCC's point
> of view why this modification can eliminate the warning.
>
> However, in terms of correctness, this modification is very reasonable
> because
> the `buf_vec[0]` would be invalid if the `nr_vec` variable equals to
> zero. In
> this case, the function should return.
>
> In addition, we can see that the `buf_vec` array are also used in function
> desc_to_mbuf() from the above calling relationships. Do you think it is
> necessary to add a similar check to this function? like this:

Maxime, Chenbo, can you have a look?
Thanks!

>
> diff --git a/lib/vhost/virtio_net.c b/lib/vhost/virtio_net.c
> index 9446e33aa7..99233f1759 100644
> --- a/lib/vhost/virtio_net.c
> +++ b/lib/vhost/virtio_net.c
> @@ -2673,6 +2673,9 @@ desc_to_mbuf(struct virtio_net *dev, struct
> vhost_virtqueue *vq,
>  struct vhost_async *async = vq->async;
>  struct async_inflight_info *pkts_info;
>
> +   if (unlikely(nr_vec == 0))
> +   return -1;
> +
>  buf_addr = buf_vec[vec_idx].buf_addr;
>  buf_iova = buf_vec[vec_idx].buf_iova;
>  buf_len = buf_vec[vec_idx].buf_len;
>
> I expect this compilation warning can be resolved. Because LoongArch
> cross-compile tools must be based on GCC 12.1 and this compilation warning
> will cause LoongArch CI job to fail.

Agreed.


-- 
David Marchand

Re: [PATCH v11] sched: enable CMAN at runtime

[Thomas Monjalon]

> > Added changes to enable CMAN (RED or PIE) at init from profile configuration
> > file.
> > 
> > By default CMAN code is enable but not in use, when there is no RED or PIE
> > profile configured.
> > 
> > Signed-off-by: Marcin Danilewicz 
> 
> Acked-by: Jasvinder Singh 

Applied, thanks.

Re: [PATCH v5 2/7] bbdev: add device status info

[Maxime Coquelin]

On 7/7/22 01:28, Nicolas Chautru wrote:

Added device status information, so that the PMD can
expose information related to the underlying accelerator device status.
Minor order change in structure to fit into padding hole.

Signed-off-by: Nicolas Chautru 
---
  drivers/baseband/acc100/rte_acc100_pmd.c   |  1 +
  drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c |  1 +
  drivers/baseband/fpga_lte_fec/fpga_lte_fec.c   |  1 +
  drivers/baseband/la12xx/bbdev_la12xx.c |  1 +
  drivers/baseband/null/bbdev_null.c |  1 +
  drivers/baseband/turbo_sw/bbdev_turbo_software.c   |  1 +
  lib/bbdev/rte_bbdev.c  | 22 ++
  lib/bbdev/rte_bbdev.h  | 35 --
  lib/bbdev/version.map  |  6 
  9 files changed, 67 insertions(+), 2 deletions(-)

diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c 
b/drivers/baseband/acc100/rte_acc100_pmd.c
index de7e4bc..17ba798 100644
--- a/drivers/baseband/acc100/rte_acc100_pmd.c
+++ b/drivers/baseband/acc100/rte_acc100_pmd.c
@@ -1060,6 +1060,7 @@
  
  	/* Read and save the populated config from ACC100 registers */

fetch_acc100_config(dev);
+   dev_info->device_status = RTE_BBDEV_DEV_NOT_SUPPORTED;
  
  	/* This isn't ideal because it reports the maximum number of queues but

 * does not provide info on how many can be uplink/downlink or different
diff --git a/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c 
b/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c
index 82ae6ba..57b12af 100644
--- a/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c
+++ b/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c
@@ -369,6 +369,7 @@
dev_info->capabilities = bbdev_capabilities;
dev_info->cpu_flag_reqs = NULL;
dev_info->data_endianness = RTE_LITTLE_ENDIAN;
+   dev_info->device_status = RTE_BBDEV_DEV_NOT_SUPPORTED;
  
  	/* Calculates number of queues assigned to device */

dev_info->max_num_queues = 0;
diff --git a/drivers/baseband/fpga_lte_fec/fpga_lte_fec.c 
b/drivers/baseband/fpga_lte_fec/fpga_lte_fec.c
index 21d3529..2a330c4 100644
--- a/drivers/baseband/fpga_lte_fec/fpga_lte_fec.c
+++ b/drivers/baseband/fpga_lte_fec/fpga_lte_fec.c
@@ -645,6 +645,7 @@ struct __rte_cache_aligned fpga_queue {
dev_info->capabilities = bbdev_capabilities;
dev_info->cpu_flag_reqs = NULL;
dev_info->data_endianness = RTE_LITTLE_ENDIAN;
+   dev_info->device_status = RTE_BBDEV_DEV_NOT_SUPPORTED;
  
  	/* Calculates number of queues assigned to device */

dev_info->max_num_queues = 0;
diff --git a/drivers/baseband/la12xx/bbdev_la12xx.c 
b/drivers/baseband/la12xx/bbdev_la12xx.c
index 4d1bd16..c1f88c6 100644
--- a/drivers/baseband/la12xx/bbdev_la12xx.c
+++ b/drivers/baseband/la12xx/bbdev_la12xx.c
@@ -100,6 +100,7 @@ struct bbdev_la12xx_params {
dev_info->capabilities = bbdev_capabilities;
dev_info->cpu_flag_reqs = NULL;
dev_info->min_alignment = 64;
+   dev_info->device_status = RTE_BBDEV_DEV_NOT_SUPPORTED;
  
  	rte_bbdev_log_debug("got device info from %u", dev->data->dev_id);

  }
diff --git a/drivers/baseband/null/bbdev_null.c 
b/drivers/baseband/null/bbdev_null.c
index 248e129..94a1976 100644
--- a/drivers/baseband/null/bbdev_null.c
+++ b/drivers/baseband/null/bbdev_null.c
@@ -82,6 +82,7 @@ struct bbdev_queue {
 * here for code completeness.
 */
dev_info->data_endianness = RTE_LITTLE_ENDIAN;
+   dev_info->device_status = RTE_BBDEV_DEV_NOT_SUPPORTED;
  
  	rte_bbdev_log_debug("got device info from %u", dev->data->dev_id);

  }
diff --git a/drivers/baseband/turbo_sw/bbdev_turbo_software.c 
b/drivers/baseband/turbo_sw/bbdev_turbo_software.c
index af7bc41..dbc5524 100644
--- a/drivers/baseband/turbo_sw/bbdev_turbo_software.c
+++ b/drivers/baseband/turbo_sw/bbdev_turbo_software.c
@@ -254,6 +254,7 @@ struct turbo_sw_queue {
dev_info->min_alignment = 64;
dev_info->harq_buffer_size = 0;
dev_info->data_endianness = RTE_LITTLE_ENDIAN;
+   dev_info->device_status = RTE_BBDEV_DEV_NOT_SUPPORTED;
  
  	rte_bbdev_log_debug("got device info from %u\n", dev->data->dev_id);

  }
diff --git a/lib/bbdev/rte_bbdev.c b/lib/bbdev/rte_bbdev.c
index 4da8047..38630a2 100644
--- a/lib/bbdev/rte_bbdev.c
+++ b/lib/bbdev/rte_bbdev.c
@@ -1133,3 +1133,25 @@ struct rte_mempool *
rte_bbdev_log(ERR, "Invalid operation type");
return NULL;
  }
+
+const char *
+rte_bbdev_device_status_str(enum rte_bbdev_device_status status)
+{
+   static const char * const dev_sta_string[] = {
+   "RTE_BBDEV_DEV_NOSTATUS",
+   "RTE_BBDEV_DEV_NOT_SUPPORTED",
+   "RTE_BBDEV_DEV_RESET",
+   "RTE_BBDEV_DEV_CONFIGURED",
+   "RTE_BBDEV_DEV_ACTIVE",
+   "RTE_BBDEV_DEV_FATAL_ERR",
+   "RTE_BBDEV_DEV_RESTART_REQ",
+   "RTE_BBDEV_DEV_REC

[PATCH v2 0/5] add remaining SGL support to AESNI_MB

[Ciara Power]

Currently, the intel-ipsec-mb library only supports SGL for
GCM and ChaCha20-Poly1305 algorithms through the JOB API.

To add SGL support for other algorithms, a workaround approach is
added in the AESNI_MB PMD. SGL feature flags can now be added to
the PMD.

This patchset also includes a fix for SGL wireless operations,
and sessionless cleanup.

Some additional Snow3G SGL and AES tests are also added for
various SGL input/output combinations that were not
previously being tested.

v2:
  - Added documentation changes.
  - Added fix for sessionless cleanup.
  - Modified blockcipher tests to support various SGL types.
  - Added more SGL AES tests.
  - Small fixes.

Ciara Power (5):
  test/crypto: fix wireless auth digest segment
  crypto/ipsec_mb: fix sessionless cleanup
  crypto/ipsec_mb: add remaining SGL support
  test/crypto: add OOP snow3g SGL tests
  test/crypto: add remaining blockcipher SGL tests

 app/test/test_cryptodev.c   |  56 +++-
 app/test/test_cryptodev_aes_test_vectors.h  | 345 +---
 app/test/test_cryptodev_blockcipher.c   |  50 +--
 app/test/test_cryptodev_blockcipher.h   |   2 +
 app/test/test_cryptodev_hash_test_vectors.h |   8 +-
 doc/guides/cryptodevs/aesni_mb.rst  |   1 -
 doc/guides/cryptodevs/features/aesni_mb.ini |   4 +
 doc/guides/rel_notes/release_22_11.rst  |   4 +
 drivers/crypto/ipsec_mb/pmd_aesni_mb.c  | 195 ---
 drivers/crypto/ipsec_mb/pmd_chacha_poly.c   |   4 -
 drivers/crypto/ipsec_mb/pmd_kasumi.c|   5 -
 drivers/crypto/ipsec_mb/pmd_snow3g.c|   4 -
 drivers/crypto/ipsec_mb/pmd_zuc.c   |   4 -
 13 files changed, 548 insertions(+), 134 deletions(-)

-- 
2.25.1

[PATCH v2 1/5] test/crypto: fix wireless auth digest segment

[Ciara Power]

The segment size for some tests was too small to hold the auth digest.
This caused issues when using op->sym->auth.digest.data for comparisons
in AESNI_MB PMD after a subsequent patch enables SGL.

For example, if segment size is 2, and digest size is 4, then 4 bytes
are read from op->sym->auth.digest.data, which overflows into the memory
after the segment, rather than using the second segment that contains
the remaining half of the digest.

Fixes: 11c5485bb276 ("test/crypto: add scatter-gather tests for IP and OOP")

Signed-off-by: Ciara Power 
---
 app/test/test_cryptodev.c | 8 
 1 file changed, 8 insertions(+)

diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c
index 69a0301de0..e6925b6531 100644
--- a/app/test/test_cryptodev.c
+++ b/app/test/test_cryptodev.c
@@ -3040,6 +3040,14 @@ create_wireless_algo_auth_cipher_operation(
remaining_off -= rte_pktmbuf_data_len(sgl_buf);
sgl_buf = sgl_buf->next;
}
+
+   /* The last segment should be large enough to hold full digest 
*/
+   if (sgl_buf->data_len < auth_tag_len) {
+   rte_pktmbuf_free(sgl_buf->next);
+   sgl_buf->next = NULL;
+   rte_pktmbuf_append(sgl_buf, auth_tag_len - 
sgl_buf->data_len);
+   }
+
sym_op->auth.digest.data = rte_pktmbuf_mtod_offset(sgl_buf,
uint8_t *, remaining_off);
sym_op->auth.digest.phys_addr = rte_pktmbuf_iova_offset(sgl_buf,
-- 
2.25.1

[PATCH v2 2/5] crypto/ipsec_mb: fix sessionless cleanup

[Ciara Power]

Currently, for a sessionless op, the session created is reset before
being put back into the mempool. This causes issues as the object isn't
correctly released into the mempool.

Fixes: c68d7aa354f6 ("crypto/aesni_mb: use architecture independent macros")
Fixes: b3bbd9e5f265 ("cryptodev: support device independent sessions")
Fixes: f16662885472 ("crypto/ipsec_mb: add chacha_poly PMD")
Cc: roy.fan.zh...@intel.com
Cc: slawomirx.mrozow...@intel.com
Cc: kai...@intel.com

Signed-off-by: Ciara Power 
---
 drivers/crypto/ipsec_mb/pmd_aesni_mb.c| 4 
 drivers/crypto/ipsec_mb/pmd_chacha_poly.c | 4 
 drivers/crypto/ipsec_mb/pmd_kasumi.c  | 5 -
 drivers/crypto/ipsec_mb/pmd_snow3g.c  | 4 
 drivers/crypto/ipsec_mb/pmd_zuc.c | 4 
 5 files changed, 21 deletions(-)

diff --git a/drivers/crypto/ipsec_mb/pmd_aesni_mb.c 
b/drivers/crypto/ipsec_mb/pmd_aesni_mb.c
index 6d5d3ce8eb..944fce0261 100644
--- a/drivers/crypto/ipsec_mb/pmd_aesni_mb.c
+++ b/drivers/crypto/ipsec_mb/pmd_aesni_mb.c
@@ -1770,10 +1770,6 @@ post_process_mb_job(struct ipsec_mb_qp *qp, IMB_JOB *job)
 
/* Free session if a session-less crypto op */
if (op->sess_type == RTE_CRYPTO_OP_SESSIONLESS) {
-   memset(sess, 0, sizeof(struct aesni_mb_session));
-   memset(op->sym->session, 0,
-   rte_cryptodev_sym_get_existing_header_session_size(
-   op->sym->session));
rte_mempool_put(qp->sess_mp_priv, sess);
rte_mempool_put(qp->sess_mp, op->sym->session);
op->sym->session = NULL;
diff --git a/drivers/crypto/ipsec_mb/pmd_chacha_poly.c 
b/drivers/crypto/ipsec_mb/pmd_chacha_poly.c
index d953d6e5f5..31397b6395 100644
--- a/drivers/crypto/ipsec_mb/pmd_chacha_poly.c
+++ b/drivers/crypto/ipsec_mb/pmd_chacha_poly.c
@@ -289,10 +289,6 @@ handle_completed_chacha20_poly1305_crypto_op(struct 
ipsec_mb_qp *qp,
 
/* Free session if a session-less crypto op */
if (op->sess_type == RTE_CRYPTO_OP_SESSIONLESS) {
-   memset(sess, 0, sizeof(struct chacha20_poly1305_session));
-   memset(op->sym->session, 0,
-   rte_cryptodev_sym_get_existing_header_session_size(
-   op->sym->session));
rte_mempool_put(qp->sess_mp_priv, sess);
rte_mempool_put(qp->sess_mp, op->sym->session);
op->sym->session = NULL;
diff --git a/drivers/crypto/ipsec_mb/pmd_kasumi.c 
b/drivers/crypto/ipsec_mb/pmd_kasumi.c
index c9d4f9d0ae..de37e012bd 100644
--- a/drivers/crypto/ipsec_mb/pmd_kasumi.c
+++ b/drivers/crypto/ipsec_mb/pmd_kasumi.c
@@ -230,11 +230,6 @@ process_ops(struct rte_crypto_op **ops, struct 
kasumi_session *session,
ops[i]->status = RTE_CRYPTO_OP_STATUS_SUCCESS;
/* Free session if a session-less crypto op. */
if (ops[i]->sess_type == RTE_CRYPTO_OP_SESSIONLESS) {
-   memset(session, 0, sizeof(struct kasumi_session));
-   memset(
-   ops[i]->sym->session, 0,
-   rte_cryptodev_sym_get_existing_header_session_size(
-   ops[i]->sym->session));
rte_mempool_put(qp->sess_mp_priv, session);
rte_mempool_put(qp->sess_mp, ops[i]->sym->session);
ops[i]->sym->session = NULL;
diff --git a/drivers/crypto/ipsec_mb/pmd_snow3g.c 
b/drivers/crypto/ipsec_mb/pmd_snow3g.c
index 9a85f46721..1634c54fb7 100644
--- a/drivers/crypto/ipsec_mb/pmd_snow3g.c
+++ b/drivers/crypto/ipsec_mb/pmd_snow3g.c
@@ -361,10 +361,6 @@ process_ops(struct rte_crypto_op **ops, struct 
snow3g_session *session,
ops[i]->status = RTE_CRYPTO_OP_STATUS_SUCCESS;
/* Free session if a session-less crypto op. */
if (ops[i]->sess_type == RTE_CRYPTO_OP_SESSIONLESS) {
-   memset(session, 0, sizeof(struct snow3g_session));
-   memset(ops[i]->sym->session, 0,
-   rte_cryptodev_sym_get_existing_header_session_size(
-   ops[i]->sym->session));
rte_mempool_put(qp->sess_mp_priv, session);
rte_mempool_put(qp->sess_mp, ops[i]->sym->session);
ops[i]->sym->session = NULL;
diff --git a/drivers/crypto/ipsec_mb/pmd_zuc.c 
b/drivers/crypto/ipsec_mb/pmd_zuc.c
index e36c7092d6..564ca3457c 100644
--- a/drivers/crypto/ipsec_mb/pmd_zuc.c
+++ b/drivers/crypto/ipsec_mb/pmd_zuc.c
@@ -238,10 +238,6 @@ process_ops(struct rte_crypto_op **ops, enum 
ipsec_mb_operation op_type,
ops[i]->status = RTE_CRYPTO_OP_STATUS_SUCCESS;
/* Free session if a session-less crypto op. */
if (ops[i]->sess_type == RTE_CRYPTO_OP_SESSIONLESS) {
-   memset(sessions[i], 0, sizeof

[PATCH v2 3/5] crypto/ipsec_mb: add remaining SGL support

[Ciara Power]

The intel-ipsec-mb library supports SGL for GCM and ChaChaPoly
algorithms using the JOB API.
This support was added to AESNI_MB PMD previously, but the SGL feature
flags could not be added due to no SGL support for other algorithms.

This patch adds a workaround SGL approach for other algorithms
using the JOB API. The segmented input buffers are copied into a
linear buffer, which is passed as a single job to intel-ipsec-mb.
The job is processed, and on return, the linear buffer is split into the
original destination segments.

Existing AESNI_MB testcases are passing with these feature flags added.

Signed-off-by: Ciara Power 

---
v2:
  - Small improvements when copying segments to linear buffer.
  - Added documentation changes.
---
 doc/guides/cryptodevs/aesni_mb.rst  |   1 -
 doc/guides/cryptodevs/features/aesni_mb.ini |   4 +
 doc/guides/rel_notes/release_22_11.rst  |   4 +
 drivers/crypto/ipsec_mb/pmd_aesni_mb.c  | 191 
 4 files changed, 166 insertions(+), 34 deletions(-)

diff --git a/doc/guides/cryptodevs/aesni_mb.rst 
b/doc/guides/cryptodevs/aesni_mb.rst
index 07222ee117..59c134556f 100644
--- a/doc/guides/cryptodevs/aesni_mb.rst
+++ b/doc/guides/cryptodevs/aesni_mb.rst
@@ -72,7 +72,6 @@ Protocol offloads:
 Limitations
 ---
 
-* Chained mbufs are not supported.
 * Out-of-place is not supported for combined Crypto-CRC DOCSIS security
   protocol.
 * RTE_CRYPTO_CIPHER_DES_DOCSISBPI is not supported for combined Crypto-CRC
diff --git a/doc/guides/cryptodevs/features/aesni_mb.ini 
b/doc/guides/cryptodevs/features/aesni_mb.ini
index 3c648a391e..e4e965c35a 100644
--- a/doc/guides/cryptodevs/features/aesni_mb.ini
+++ b/doc/guides/cryptodevs/features/aesni_mb.ini
@@ -12,6 +12,10 @@ CPU AVX= Y
 CPU AVX2   = Y
 CPU AVX512 = Y
 CPU AESNI  = Y
+In Place SGL   = Y
+OOP SGL In SGL Out = Y
+OOP SGL In LB  Out = Y
+OOP LB  In SGL Out = Y
 OOP LB  In LB  Out = Y
 CPU crypto = Y
 Symmetric sessionless  = Y
diff --git a/doc/guides/rel_notes/release_22_11.rst 
b/doc/guides/rel_notes/release_22_11.rst
index 8c021cf050..6416f0a4e1 100644
--- a/doc/guides/rel_notes/release_22_11.rst
+++ b/doc/guides/rel_notes/release_22_11.rst
@@ -55,6 +55,10 @@ New Features
  Also, make sure to start the actual text at the margin.
  ===
 
+* **Added SGL support to AESNI_MB PMD.**
+
+  Added support for SGL to AESNI_MB PMD. Support for inplace,
+  OOP SGL in SGL out, OOP LB in SGL out, and OOP SGL in LB out added.
 
 Removed Items
 -
diff --git a/drivers/crypto/ipsec_mb/pmd_aesni_mb.c 
b/drivers/crypto/ipsec_mb/pmd_aesni_mb.c
index 944fce0261..800a9ae72c 100644
--- a/drivers/crypto/ipsec_mb/pmd_aesni_mb.c
+++ b/drivers/crypto/ipsec_mb/pmd_aesni_mb.c
@@ -937,7 +937,7 @@ static inline uint64_t
 auth_start_offset(struct rte_crypto_op *op, struct aesni_mb_session *session,
uint32_t oop, const uint32_t auth_offset,
const uint32_t cipher_offset, const uint32_t auth_length,
-   const uint32_t cipher_length)
+   const uint32_t cipher_length, uint8_t lb_sgl)
 {
struct rte_mbuf *m_src, *m_dst;
uint8_t *p_src, *p_dst;
@@ -945,7 +945,7 @@ auth_start_offset(struct rte_crypto_op *op, struct 
aesni_mb_session *session,
uint32_t cipher_end, auth_end;
 
/* Only cipher then hash needs special calculation. */
-   if (!oop || session->chain_order != IMB_ORDER_CIPHER_HASH)
+   if (!oop || session->chain_order != IMB_ORDER_CIPHER_HASH || lb_sgl)
return auth_offset;
 
m_src = op->sym->m_src;
@@ -1159,6 +1159,74 @@ handle_aead_sgl_job(IMB_JOB *job, IMB_MGR *mb_mgr,
return 0;
 }
 
+static int
+handle_sgl_linear(IMB_JOB *job, struct rte_crypto_op *op, uint32_t dst_offset,
+   struct aesni_mb_session *session)
+{
+   uint64_t cipher_len, auth_len;
+   uint8_t *src, *linear_buf = NULL;
+   int total_len;
+   int lb_offset = 0;
+   struct rte_mbuf *src_seg;
+   uint16_t src_len;
+
+   if (job->cipher_mode == IMB_CIPHER_SNOW3G_UEA2_BITLEN ||
+   job->cipher_mode == IMB_CIPHER_KASUMI_UEA1_BITLEN)
+   cipher_len = (job->msg_len_to_cipher_in_bits >> 3) +
+   (job->cipher_start_src_offset_in_bits >> 3);
+   else
+   cipher_len = job->msg_len_to_cipher_in_bytes +
+   job->cipher_start_src_offset_in_bytes;
+
+   if (job->hash_alg == IMB_AUTH_SNOW3G_UIA2_BITLEN ||
+   job->hash_alg == IMB_AUTH_ZUC_EIA3_BITLEN)
+   auth_len = (job->msg_len_to_hash_in_bits >> 3) +
+   job->hash_start_src_offset_in_bytes;
+   else if (job->hash_alg == IMB_AUTH_AES_GMAC)
+   auth_len = job->u.GCM.aad_len_in_bytes;
+   else
+   auth_le

[PATCH v2 4/5] test/crypto: add OOP snow3g SGL tests

[Ciara Power]

More tests are added to test variations of OOP SGL for snow3g.
This includes LB_IN_SGL_OUT and SGL_IN_LB_OUT.

Signed-off-by: Ciara Power 
---
 app/test/test_cryptodev.c | 48 +++
 1 file changed, 39 insertions(+), 9 deletions(-)

diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c
index e6925b6531..83860d1853 100644
--- a/app/test/test_cryptodev.c
+++ b/app/test/test_cryptodev.c
@@ -4347,7 +4347,8 @@ test_snow3g_encryption_oop(const struct snow3g_test_data 
*tdata)
 }
 
 static int
-test_snow3g_encryption_oop_sgl(const struct snow3g_test_data *tdata)
+test_snow3g_encryption_oop_sgl(const struct snow3g_test_data *tdata,
+   uint8_t sgl_in, uint8_t sgl_out)
 {
struct crypto_testsuite_params *ts_params = &testsuite_params;
struct crypto_unittest_params *ut_params = &unittest_params;
@@ -4378,9 +4379,12 @@ test_snow3g_encryption_oop_sgl(const struct 
snow3g_test_data *tdata)
 
uint64_t feat_flags = dev_info.feature_flags;
 
-   if (!(feat_flags & RTE_CRYPTODEV_FF_OOP_SGL_IN_SGL_OUT)) {
-   printf("Device doesn't support out-of-place scatter-gather "
-   "in both input and output mbufs. "
+   if (((sgl_in && sgl_out) && !(feat_flags & 
RTE_CRYPTODEV_FF_OOP_SGL_IN_SGL_OUT))
+   || ((!sgl_in && sgl_out) &&
+   !(feat_flags & RTE_CRYPTODEV_FF_OOP_LB_IN_SGL_OUT))
+   || ((sgl_in && !sgl_out) &&
+   !(feat_flags & RTE_CRYPTODEV_FF_OOP_SGL_IN_LB_OUT))) {
+   printf("Device doesn't support out-of-place scatter gather 
type. "
"Test Skipped.\n");
return TEST_SKIPPED;
}
@@ -4405,10 +4409,21 @@ test_snow3g_encryption_oop_sgl(const struct 
snow3g_test_data *tdata)
/* the algorithms block size */
plaintext_pad_len = RTE_ALIGN_CEIL(plaintext_len, 16);
 
-   ut_params->ibuf = create_segmented_mbuf(ts_params->mbuf_pool,
-   plaintext_pad_len, 10, 0);
-   ut_params->obuf = create_segmented_mbuf(ts_params->mbuf_pool,
-   plaintext_pad_len, 3, 0);
+   if (sgl_in)
+   ut_params->ibuf = create_segmented_mbuf(ts_params->mbuf_pool,
+   plaintext_pad_len, 10, 0);
+   else {
+   ut_params->ibuf = rte_pktmbuf_alloc(ts_params->mbuf_pool);
+   rte_pktmbuf_append(ut_params->ibuf, plaintext_pad_len);
+   }
+
+   if (sgl_out)
+   ut_params->obuf = create_segmented_mbuf(ts_params->mbuf_pool,
+   plaintext_pad_len, 3, 0);
+   else {
+   ut_params->obuf = rte_pktmbuf_alloc(ts_params->mbuf_pool);
+   rte_pktmbuf_append(ut_params->obuf, plaintext_pad_len);
+   }
 
TEST_ASSERT_NOT_NULL(ut_params->ibuf,
"Failed to allocate input buffer in mempool");
@@ -6762,9 +6777,20 @@ test_snow3g_encryption_test_case_1_oop(void)
 static int
 test_snow3g_encryption_test_case_1_oop_sgl(void)
 {
-   return test_snow3g_encryption_oop_sgl(&snow3g_test_case_1);
+   return test_snow3g_encryption_oop_sgl(&snow3g_test_case_1, 1, 1);
+}
+
+static int
+test_snow3g_encryption_test_case_1_oop_lb_in_sgl_out(void)
+{
+   return test_snow3g_encryption_oop_sgl(&snow3g_test_case_1, 0, 1);
 }
 
+static int
+test_snow3g_encryption_test_case_1_oop_sgl_in_lb_out(void)
+{
+   return test_snow3g_encryption_oop_sgl(&snow3g_test_case_1, 1, 0);
+}
 
 static int
 test_snow3g_encryption_test_case_1_offset_oop(void)
@@ -15985,6 +16011,10 @@ static struct unit_test_suite 
cryptodev_snow3g_testsuite  = {
test_snow3g_encryption_test_case_1_oop),
TEST_CASE_ST(ut_setup, ut_teardown,
test_snow3g_encryption_test_case_1_oop_sgl),
+   TEST_CASE_ST(ut_setup, ut_teardown,
+   test_snow3g_encryption_test_case_1_oop_lb_in_sgl_out),
+   TEST_CASE_ST(ut_setup, ut_teardown,
+   test_snow3g_encryption_test_case_1_oop_sgl_in_lb_out),
TEST_CASE_ST(ut_setup, ut_teardown,
test_snow3g_encryption_test_case_1_offset_oop),
TEST_CASE_ST(ut_setup, ut_teardown,
-- 
2.25.1

[PATCH v2 5/5] test/crypto: add remaining blockcipher SGL tests

[Ciara Power]

The current blockcipher test function only has support for two types of
SGL test, INPLACE or OOP_SGL_IN_LB_OUT. These types are hardcoded into
the function, with the number of segments always set to 3.

To ensure all SGL types are tested, blockcipher test vectors now have
fields to specify SGL type, and the number of segments.
If these fields are missing, the previous defaults are used,
either INPLACE or OOP_SGL_IN_LB_OUT, with 3 segments.

Some AES and Hash vectors are modified to use these new fields, and new
AES tests are added to test the SGL types that were not previously
being tested.

Signed-off-by: Ciara Power 
---
 app/test/test_cryptodev_aes_test_vectors.h  | 345 +---
 app/test/test_cryptodev_blockcipher.c   |  50 +--
 app/test/test_cryptodev_blockcipher.h   |   2 +
 app/test/test_cryptodev_hash_test_vectors.h |   8 +-
 4 files changed, 335 insertions(+), 70 deletions(-)

diff --git a/app/test/test_cryptodev_aes_test_vectors.h 
b/app/test/test_cryptodev_aes_test_vectors.h
index a797af1b00..2c1875d3d9 100644
--- a/app/test/test_cryptodev_aes_test_vectors.h
+++ b/app/test/test_cryptodev_aes_test_vectors.h
@@ -4163,12 +4163,44 @@ static const struct blockcipher_test_case 
aes_chain_test_cases[] = {
},
{
.test_descr = "AES-192-CTR XCBC Decryption Digest Verify "
-   "Scatter Gather",
+   "Scatter Gather (Inplace)",
+   .test_data = &aes_test_data_2,
+   .op_mask = BLOCKCIPHER_TEST_OP_AUTH_VERIFY_DEC,
+   .feature_mask = BLOCKCIPHER_TEST_FEATURE_SG,
+   .sgl_flag = RTE_CRYPTODEV_FF_IN_PLACE_SGL,
+   .sgl_segs = 3
+   },
+   {
+   .test_descr = "AES-192-CTR XCBC Decryption Digest Verify "
+   "Scatter Gather OOP (SGL in SGL out)",
+   .test_data = &aes_test_data_2,
+   .op_mask = BLOCKCIPHER_TEST_OP_AUTH_VERIFY_DEC,
+   .feature_mask = BLOCKCIPHER_TEST_FEATURE_SG |
+   BLOCKCIPHER_TEST_FEATURE_OOP,
+   .sgl_flag = RTE_CRYPTODEV_FF_OOP_SGL_IN_SGL_OUT,
+   .sgl_segs = 3
+   },
+   {
+   .test_descr = "AES-192-CTR XCBC Decryption Digest Verify "
+   "Scatter Gather OOP (LB in SGL out)",
.test_data = &aes_test_data_2,
.op_mask = BLOCKCIPHER_TEST_OP_AUTH_VERIFY_DEC,
.feature_mask = BLOCKCIPHER_TEST_FEATURE_SG |
BLOCKCIPHER_TEST_FEATURE_OOP,
+   .sgl_flag = RTE_CRYPTODEV_FF_OOP_LB_IN_SGL_OUT,
+   .sgl_segs = 3
},
+   {
+   .test_descr = "AES-192-CTR XCBC Decryption Digest Verify "
+   "Scatter Gather OOP (SGL in LB out)",
+   .test_data = &aes_test_data_2,
+   .op_mask = BLOCKCIPHER_TEST_OP_AUTH_VERIFY_DEC,
+   .feature_mask = BLOCKCIPHER_TEST_FEATURE_SG |
+   BLOCKCIPHER_TEST_FEATURE_OOP,
+   .sgl_flag = RTE_CRYPTODEV_FF_OOP_SGL_IN_LB_OUT,
+   .sgl_segs = 3
+   },
+
{
.test_descr = "AES-256-CTR HMAC-SHA1 Encryption Digest",
.test_data = &aes_test_data_3,
@@ -4193,11 +4225,52 @@ static const struct blockcipher_test_case 
aes_chain_test_cases[] = {
},
{
.test_descr = "AES-128-CBC HMAC-SHA1 Encryption Digest "
-   "Scatter Gather",
+   "Scatter Gather (Inplace)",
+   .test_data = &aes_test_data_4,
+   .op_mask = BLOCKCIPHER_TEST_OP_ENC_AUTH_GEN,
+   .feature_mask = BLOCKCIPHER_TEST_FEATURE_SG,
+   .sgl_flag = RTE_CRYPTODEV_FF_IN_PLACE_SGL,
+   .sgl_segs = 3
+   },
+   {
+   .test_descr = "AES-128-CBC HMAC-SHA1 Encryption Digest "
+   "Scatter Gather OOP (SGL in SGL out)",
+   .test_data = &aes_test_data_4,
+   .op_mask = BLOCKCIPHER_TEST_OP_ENC_AUTH_GEN,
+   .feature_mask = BLOCKCIPHER_TEST_FEATURE_SG |
+   BLOCKCIPHER_TEST_FEATURE_OOP,
+   .sgl_flag = RTE_CRYPTODEV_FF_OOP_SGL_IN_SGL_OUT,
+   .sgl_segs = 3
+   },
+   {
+   .test_descr = "AES-128-CBC HMAC-SHA1 Encryption Digest "
+   "Scatter Gather OOP 16 segs (SGL in SGL out)",
+   .test_data = &aes_test_data_4,
+   .op_mask = BLOCKCIPHER_TEST_OP_ENC_AUTH_GEN,
+   .feature_mask = BLOCKCIPHER_TEST_FEATURE_SG |
+   BLOCKCIPHER_TEST_FEATURE_OOP,
+   .sgl_flag = RTE_CRYPTODEV_FF_OOP_SGL_IN_SGL_OUT,
+   .sgl_segs = 16
+   },
+   {
+   .test_descr = "AES-128-CBC HMAC-SHA1 Encryption Digest "
+   "Scatter Gather OO

RE: about RTL8168 PMD on ARM SoC

[Honnappa Nagarahalli]

Hello,
   I cannot find many details of the SoC on the internet. Does it 
use coherent IO? Depending on that, different barriers might be needed. Other 
than this, I would not think it needs anything special.

If you could send an RFC to the DPDK mailing list, I am happy to review and 
provide any feedback.

Thanks,
Honnappa


From: 王星 
Sent: Wednesday, August 24, 2022 9:53 PM
To: dev@dpdk.org
Cc: 陈立 ; 王颢 
Subject: about RTL8168 PMD on ARM SoC

Hi DPDK,

I am a pmd driver developer from Realtek NIC department,
when I was porting r8168pmd already verified on x86 to an ARM64 SoC Unisoc: 
UIS8650
I found that after NIC Rx init (in general, Rx ring and buffers should have 
been prepared for NIC to DMA read),
the NIC status reg showed RDU (Rx Descriptor Unavailable), which means NIC 
cannot read the proper desc content,

later I sended some packets to NIC hold by testpmd rx_only mode, HW internal Rx 
packet counter can grow to some value, then stuck, 8168pmd Rx debug print 
reported it received less packets than that value, and the print showed up even 
some minutes later!

I doubt the phenomenon is caused by improper HW-based IO coherency support on 
this ARM SoC,
I have read the ARM SoC support list on DPDK website, to name it: NV Bluefield, 
NXP DPAA, Marvell Octeon TX …

Does DPDK (or UIO/VFIO driver or hugetlb driver) need special HW IO cache 
coherency support on ARM platform, say, ACE and Device side MMU etc?
Should the SoC provide specialized UIO/VFIO driver or hugetlb driver and/or 
specific DPDK lib to support such user mode DMA?
Will you please give suggestions, thanks a lot!

BRs

Re: [PATCH] power: add unpriv. read of turbo % for pstate

[Hunt, David]

Hi Markus,

On 24/08/2022 20:28, Markus Theil wrote:

If DPDK applications should be used with a minimal set of privileges,
using the msr kernel module on linux should not be necessary.

Since at least kernel 4.4 the rdmsr call to obtain the last non-turbo
boost frequency can be left out, if the sysfs interface is used.
Also RHEL 7 with recent kernel updates should include the sysfs interface
for this (I only looked this up for CentOS 7).

Signed-off-by: Markus Theil 
---
  lib/power/power_pstate_cpufreq.c | 69 ++--
  1 file changed, 40 insertions(+), 29 deletions(-)

diff --git a/lib/power/power_pstate_cpufreq.c b/lib/power/power_pstate_cpufreq.c
index 78c9197695..c3d66a8f68 100644
--- a/lib/power/power_pstate_cpufreq.c
+++ b/lib/power/power_pstate_cpufreq.c
@@ -35,15 +35,9 @@
"/sys/devices/system/cpu/cpu%u/cpufreq/cpuinfo_min_freq"
  #define POWER_SYSFILE_BASE_FREQ  \
"/sys/devices/system/cpu/cpu%u/cpufreq/base_frequency"
+#define POWER_SYSFILE_TURBO_PCT  \
+   "/sys/devices/system/cpu/intel_pstate/turbo_pct"
  #define POWER_PSTATE_DRIVER "intel_pstate"
-#define POWER_MSR_PATH  "/dev/cpu/%u/msr"
-
-/*
- * MSR related
- */
-#define PLATFORM_INFO 0x0CE
-#define NON_TURBO_MASK0xFF00
-#define NON_TURBO_OFFSET  0x8
  
  
  enum power_state {

@@ -74,37 +68,33 @@ struct pstate_power_info {
  static struct pstate_power_info lcore_power_info[RTE_MAX_LCORE];
  
  /**

- * It is to read the specific MSR.
+ * It is to read the turbo mode percentage from sysfs
   */
-
  static int32_t
-power_rdmsr(int msr, uint64_t *val, unsigned int lcore_id)
+power_read_turbo_pct(uint64_t *outVal)
  {
int fd, ret;
-   char fullpath[PATH_MAX];
+   char val[4] = {0};
  
-	snprintf(fullpath, sizeof(fullpath), POWER_MSR_PATH, lcore_id);

-
-   fd = open(fullpath, O_RDONLY);
+   fd = open(POWER_SYSFILE_TURBO_PCT, O_RDONLY);
  
  	if (fd < 0) {

-   RTE_LOG(ERR, POWER, "Error opening '%s': %s\n", fullpath,
+   RTE_LOG(ERR, POWER, "Error opening '%s': %s\n", 
POWER_SYSFILE_TURBO_PCT,
 strerror(errno));
return fd;
}
  
-	ret = pread(fd, val, sizeof(uint64_t), msr);

+   ret = read(fd, val, sizeof(val));
  
  	if (ret < 0) {

-   RTE_LOG(ERR, POWER, "Error reading '%s': %s\n", fullpath,
+   RTE_LOG(ERR, POWER, "Error reading '%s': %s\n", 
POWER_SYSFILE_TURBO_PCT,
 strerror(errno));
goto out;
}
  
-	POWER_DEBUG_TRACE("MSR Path %s, offset 0x%X for lcore %u\n",

-   fullpath, msr, lcore_id);
+   *outVal = (uint64_t) atol(val);
  


I'd recommend replacing atol with strtol, it's a safer implementation. 
It's more commonly found in DPDK code than atol.




-   POWER_DEBUG_TRACE("Ret value %d, content is 0x%"PRIx64"\n", ret, *val);
+   POWER_DEBUG_TRACE("power turbo pct: %"PRIu64"\n", *outVal);
  
  out:	close(fd);

return ret;
@@ -116,8 +106,9 @@ out:close(fd);
  static int
  power_init_for_setting_freq(struct pstate_power_info *pi)
  {
-   FILE *f_base = NULL, *f_base_max = NULL, *f_min = NULL, *f_max = NULL;
-   uint32_t base_ratio, base_max_ratio;
+   FILE *f_base = NULL, *f_base_min = NULL, *f_base_max = NULL,
+*f_min = NULL, *f_max = NULL;
+   uint32_t base_ratio, base_min_ratio, base_max_ratio;
uint64_t max_non_turbo;
int ret;
  
@@ -130,6 +121,14 @@ power_init_for_setting_freq(struct pstate_power_info *pi)

goto err;
}
  
+	open_core_sysfs_file(&f_base_min, "r", POWER_SYSFILE_BASE_MIN_FREQ,

+   pi->lcore_id);
+   if (f_base_min == NULL) {
+   RTE_LOG(ERR, POWER, "failed to open %s\n",
+   POWER_SYSFILE_BASE_MIN_FREQ);
+   goto err;
+   }
+
open_core_sysfs_file(&f_min, "rw+", POWER_SYSFILE_MIN_FREQ,
pi->lcore_id);
if (f_min == NULL) {
@@ -158,6 +157,14 @@ power_init_for_setting_freq(struct pstate_power_info *pi)
goto err;
}
  
+	/* read base min ratio */

+   ret = read_core_sysfs_u32(f_base_min, &base_min_ratio);
+   if (ret < 0) {
+   RTE_LOG(ERR, POWER, "Failed to read %s\n",
+   POWER_SYSFILE_BASE_MIN_FREQ);
+   goto err;
+   }
+
/* base ratio may not exist */
if (f_base != NULL) {
ret = read_core_sysfs_u32(f_base, &base_ratio);
@@ -170,20 +177,22 @@ power_init_for_setting_freq(struct pstate_power_info *pi)
base_ratio = 0;
}
  
-	/* Add MSR read to detect turbo status */

-   if (power_rdmsr(PLATFORM_INFO, &max_non_turbo, pi->lcore_id) < 0)
-   goto err;
-   /* no errors after this point */
-
/* convert ratios to bins */
base_max_ratio /= BUS_FREQ;
+   base_

Re: [PATCH v5 3/7] bbdev: add device info on queue topology

[Maxime Coquelin]

On 7/7/22 01:28, Nicolas Chautru wrote:

Adding more options in the API to expose the number
of queues exposed and related priority.

Signed-off-by: Nicolas Chautru 
---
  lib/bbdev/rte_bbdev.h | 4 
  1 file changed, 4 insertions(+)

diff --git a/lib/bbdev/rte_bbdev.h b/lib/bbdev/rte_bbdev.h
index 9b1ffa4..ac941d6 100644
--- a/lib/bbdev/rte_bbdev.h
+++ b/lib/bbdev/rte_bbdev.h
@@ -289,6 +289,10 @@ struct rte_bbdev_driver_info {
  
  	/** Maximum number of queues supported by the device */

unsigned int max_num_queues;
+   /** Maximum number of queues supported per operation type */
+   unsigned int num_queues[RTE_BBDEV_OP_TYPE_PADDED_MAX];
+   /** Priority level supported per operation type */
+   unsigned int queue_priority[RTE_BBDEV_OP_TYPE_PADDED_MAX];
/** Queue size limit (queue size must also be power of 2) */
uint32_t queue_size_lim;
/** Set if device off-loads operation to hardware  */


Acked-by: Maxime Coquelin 

Thanks,
Maxime

[PATCH v3 0/3] Add lcore poll busyness telemetry

[Kevin Laatz]

Currently, there is no way to measure lcore polling busyness in a passive
way, without any modifications to the application. This patchset adds a new
EAL API that will be able to passively track core polling busyness. As part
of the set, new telemetry endpoints are added to read the generate metrics.

---
v3:
  * Fix missing renaming to poll busyness
  * Fix clang compilation
  * Fix arm compilation

v2:
  * Use rte_get_tsc_hz() to adjust the telemetry period
  * Rename to reflect polling busyness vs general busyness
  * Fix segfault when calling telemetry timestamp from an unregistered
non-EAL thread.
  * Minor cleanup

Anatoly Burakov (2):
  eal: add lcore poll busyness telemetry
  eal: add cpuset lcore telemetry entries

Kevin Laatz (1):
  doc: add howto guide for lcore poll busyness

 config/meson.build  |   1 +
 config/rte_config.h |   1 +
 doc/guides/howto/lcore_busyness.rst |  79 +
 lib/bbdev/rte_bbdev.h   |  17 +-
 lib/compressdev/rte_compressdev.c   |   2 +
 lib/cryptodev/rte_cryptodev.h   |   2 +
 lib/distributor/rte_distributor.c   |  21 +-
 lib/distributor/rte_distributor_single.c|  14 +-
 lib/dmadev/rte_dmadev.h |  15 +-
 lib/eal/common/eal_common_lcore_telemetry.c | 340 
 lib/eal/common/meson.build  |   1 +
 lib/eal/include/rte_lcore.h |  80 +
 lib/eal/meson.build |   3 +
 lib/eal/version.map |   7 +
 lib/ethdev/rte_ethdev.h |   2 +
 lib/eventdev/rte_eventdev.h |  10 +-
 lib/rawdev/rte_rawdev.c |   6 +-
 lib/regexdev/rte_regexdev.h |   5 +-
 lib/ring/rte_ring_elem_pvt.h|   1 +
 meson_options.txt   |   2 +
 20 files changed, 585 insertions(+), 24 deletions(-)
 create mode 100644 doc/guides/howto/lcore_busyness.rst
 create mode 100644 lib/eal/common/eal_common_lcore_telemetry.c

-- 
2.31.1

[PATCH v3 1/3] eal: add lcore poll busyness telemetry

[Kevin Laatz]

From: Anatoly Burakov 

Currently, there is no way to measure lcore poll busyness in a passive way,
without any modifications to the application. This patch adds a new EAL API
that will be able to passively track core polling busyness.

The poll busyness is calculated by relying on the fact that most DPDK API's
will poll for packets. Empty polls can be counted as "idle", while
non-empty polls can be counted as busy. To measure lcore poll busyness, we
simply call the telemetry timestamping function with the number of polls a
particular code section has processed, and count the number of cycles we've
spent processing empty bursts. The more empty bursts we encounter, the less
cycles we spend in "busy" state, and the less core poll busyness will be
reported.

In order for all of the above to work without modifications to the
application, the library code needs to be instrumented with calls to the
lcore telemetry busyness timestamping function. The following parts of DPDK
are instrumented with lcore telemetry calls:

- All major driver API's:
  - ethdev
  - cryptodev
  - compressdev
  - regexdev
  - bbdev
  - rawdev
  - eventdev
  - dmadev
- Some additional libraries:
  - ring
  - distributor

To avoid performance impact from having lcore telemetry support, a global
variable is exported by EAL, and a call to timestamping function is wrapped
into a macro, so that whenever telemetry is disabled, it only takes one
additional branch and no function calls are performed. It is also possible
to disable it at compile time by commenting out RTE_LCORE_BUSYNESS from
build config.

This patch also adds a telemetry endpoint to report lcore poll busyness, as
well as telemetry endpoints to enable/disable lcore telemetry. A
documentation entry has been added to the howto guides to explain the usage
of the new telemetry endpoints and API.

Signed-off-by: Kevin Laatz 
Signed-off-by: Conor Walsh 
Signed-off-by: David Hunt 
Signed-off-by: Anatoly Burakov 

---
v3:
  * Fix missed renaming to poll busyness
  * Fix clang compilation
  * Fix arm compilation

v2:
  * Use rte_get_tsc_hz() to adjust the telemetry period
  * Rename to reflect polling busyness vs general busyness
  * Fix segfault when calling telemetry timestamp from an unregistered
non-EAL thread.
  * Minor cleanup
---
 config/meson.build  |   1 +
 config/rte_config.h |   1 +
 lib/bbdev/rte_bbdev.h   |  17 +-
 lib/compressdev/rte_compressdev.c   |   2 +
 lib/cryptodev/rte_cryptodev.h   |   2 +
 lib/distributor/rte_distributor.c   |  21 +-
 lib/distributor/rte_distributor_single.c|  14 +-
 lib/dmadev/rte_dmadev.h |  15 +-
 lib/eal/common/eal_common_lcore_telemetry.c | 293 
 lib/eal/common/meson.build  |   1 +
 lib/eal/include/rte_lcore.h |  80 ++
 lib/eal/meson.build |   3 +
 lib/eal/version.map |   7 +
 lib/ethdev/rte_ethdev.h |   2 +
 lib/eventdev/rte_eventdev.h |  10 +-
 lib/rawdev/rte_rawdev.c |   6 +-
 lib/regexdev/rte_regexdev.h |   5 +-
 lib/ring/rte_ring_elem_pvt.h|   1 +
 meson_options.txt   |   2 +
 19 files changed, 459 insertions(+), 24 deletions(-)
 create mode 100644 lib/eal/common/eal_common_lcore_telemetry.c

diff --git a/config/meson.build b/config/meson.build
index 7f7b6c92fd..d5954a059c 100644
--- a/config/meson.build
+++ b/config/meson.build
@@ -297,6 +297,7 @@ endforeach
 dpdk_conf.set('RTE_MAX_ETHPORTS', get_option('max_ethports'))
 dpdk_conf.set('RTE_LIBEAL_USE_HPET', get_option('use_hpet'))
 dpdk_conf.set('RTE_ENABLE_TRACE_FP', get_option('enable_trace_fp'))
+dpdk_conf.set('RTE_LCORE_POLL_BUSYNESS', 
get_option('enable_lcore_poll_busyness'))
 # values which have defaults which may be overridden
 dpdk_conf.set('RTE_MAX_VFIO_GROUPS', 64)
 dpdk_conf.set('RTE_DRIVER_MEMPOOL_BUCKET_SIZE_KB', 64)
diff --git a/config/rte_config.h b/config/rte_config.h
index 46549cb062..498702c9c7 100644
--- a/config/rte_config.h
+++ b/config/rte_config.h
@@ -39,6 +39,7 @@
 #define RTE_LOG_DP_LEVEL RTE_LOG_INFO
 #define RTE_BACKTRACE 1
 #define RTE_MAX_VFIO_CONTAINERS 64
+#define RTE_LCORE_POLL_BUSYNESS_PERIOD_MS 2
 
 /* bsd module defines */
 #define RTE_CONTIGMEM_MAX_NUM_BUFS 64
diff --git a/lib/bbdev/rte_bbdev.h b/lib/bbdev/rte_bbdev.h
index b88c88167e..d6ed176cce 100644
--- a/lib/bbdev/rte_bbdev.h
+++ b/lib/bbdev/rte_bbdev.h
@@ -28,6 +28,7 @@ extern "C" {
 #include 
 
 #include 
+#include 
 
 #include "rte_bbdev_op.h"
 
@@ -599,7 +600,9 @@ rte_bbdev_dequeue_enc_ops(uint16_t dev_id, uint16_t 
queue_id,
 {
struct rte_bbdev *dev = &rte_bbdev_devices[dev_id];
struct rte_bbdev_queue_data *q_data = &dev->data->queues[queue_id];
-   return dev->dequeue_enc_ops(q_data, ops, num_ops);
+   const uint16_t nb_ops = dev->dequ

[PATCH v3 2/3] eal: add cpuset lcore telemetry entries

[Kevin Laatz]

From: Anatoly Burakov 

Expose per-lcore cpuset information to telemetry.

Signed-off-by: Anatoly Burakov 
---
 lib/eal/common/eal_common_lcore_telemetry.c | 47 +
 1 file changed, 47 insertions(+)

diff --git a/lib/eal/common/eal_common_lcore_telemetry.c 
b/lib/eal/common/eal_common_lcore_telemetry.c
index bba0afc26d..09c3beb0f7 100644
--- a/lib/eal/common/eal_common_lcore_telemetry.c
+++ b/lib/eal/common/eal_common_lcore_telemetry.c
@@ -19,6 +19,8 @@ int __rte_lcore_telemetry_enabled;
 
 #ifdef RTE_LCORE_POLL_BUSYNESS
 
+#include "eal_private.h"
+
 struct lcore_telemetry {
int poll_busyness;
/**< Calculated poll busyness (gets set/returned by the API) */
@@ -254,6 +256,48 @@ lcore_handle_poll_busyness(const char *cmd __rte_unused,
return 0;
 }
 
+static int
+lcore_handle_cpuset(const char *cmd __rte_unused,
+   const char *params __rte_unused,
+   struct rte_tel_data *d)
+{
+   char corenum[64];
+   int i;
+
+   rte_tel_data_start_dict(d);
+
+   RTE_LCORE_FOREACH(i) {
+   const struct lcore_config *cfg = &lcore_config[i];
+   const rte_cpuset_t *cpuset = &cfg->cpuset;
+   struct rte_tel_data *ld;
+   unsigned int cpu;
+
+   if (!rte_lcore_is_enabled(i))
+   continue;
+
+   /* create an array of integers */
+   ld = rte_tel_data_alloc();
+   if (ld == NULL)
+   return -ENOMEM;
+   rte_tel_data_start_array(ld, RTE_TEL_INT_VAL);
+
+   /* add cpu ID's from cpuset to the array */
+   for (cpu = 0; cpu < CPU_SETSIZE; cpu++) {
+   if (!CPU_ISSET(cpu, cpuset))
+   continue;
+   rte_tel_data_add_array_int(ld, cpu);
+   }
+
+   /* add array to the per-lcore container */
+   snprintf(corenum, sizeof(corenum), "%d", i);
+
+   /* tell telemetry library to free this array automatically */
+   rte_tel_data_add_dict_container(d, corenum, ld, 0);
+   }
+
+   return 0;
+}
+
 RTE_INIT(lcore_init_telemetry)
 {
__rte_lcore_telemetry_enabled = true;
@@ -268,6 +312,9 @@ RTE_INIT(lcore_init_telemetry)
 
rte_telemetry_register_cmd("/eal/lcore/poll_busyness_disable", 
lcore_poll_busyness_disable,
   "disable lcore poll busyness measurement");
+
+   rte_telemetry_register_cmd("/eal/lcore/cpuset", lcore_handle_cpuset,
+  "list physical core affinity for each 
lcore");
 }
 
 #else
-- 
2.31.1

[PATCH v3 3/3] doc: add howto guide for lcore poll busyness

[Kevin Laatz]

Add a new section to the howto guides for using the new lcore poll
busyness telemetry endpoints and describe general usage.

Signed-off-by: Kevin Laatz 

---
v3: update naming to poll busyness
---
 doc/guides/howto/lcore_busyness.rst | 79 +
 1 file changed, 79 insertions(+)
 create mode 100644 doc/guides/howto/lcore_busyness.rst

diff --git a/doc/guides/howto/lcore_busyness.rst 
b/doc/guides/howto/lcore_busyness.rst
new file mode 100644
index 00..ab8dd631c7
--- /dev/null
+++ b/doc/guides/howto/lcore_busyness.rst
@@ -0,0 +1,79 @@
+..  SPDX-License-Identifier: BSD-3-Clause
+Copyright(c) 2022 Intel Corporation.
+
+Lcore Poll Busyness Telemetry
+
+
+The lcore poll busyness telemetry provides a built-in, generic method of 
gathering
+lcore utilization metrics for running applications. These metrics are exposed
+via a new telemetry endpoint.
+
+Since most DPDK APIs poll for packets, the poll busyness is calculated based on
+APIs receiving packets. Empty polls are considered as idle, while non-empty 
polls
+are considered busy. Using the amount of cycles spent processing empty polls, 
the
+busyness can be calculated and recorded.
+
+Application Specified Busyness
+--
+
+Improved accuracy of the reported busyness may need more contextual awareness
+from the application. For example, a pipelined application may make a number of
+calls to rx_burst before processing packets. Any processing done on this 'bulk'
+would need to be marked as "busy" cycles, not just the last received burst. 
This
+type of awareness is only available within the application.
+
+Applications can be modified to incorporate the extra contextual awareness in
+order to improve the reported busyness by marking areas of code as "busy" or
+"idle" appropriately. This can be done by inserting the timestamping macro::
+
+RTE_LCORE_TELEMETRY_TIMESTAMP(0)/* to mark section as idle */
+RTE_LCORE_TELEMETRY_TIMESTAMP(32)   /* where 32 is nb_pkts to mark section 
as busy (non-zero is busy) */
+
+All cycles since the last state change will be counted towards the current 
state's
+counter.
+
+Consuming the Telemetry
+---
+
+The telemetry gathered for lcore poll busyness can be read from the 
`telemetry.py`
+script via the new `/eal/lcore/poll_busyness` endpoint::
+
+$ ./usertools/dpdk-telemetry.py
+--> /eal/lcore/poll_busyness
+{"/eal/lcore/poll_busyness": {"12": -1, "13": 85, "14": 84}}
+
+* Cores not collecting poll busyness will report "-1". E.g. control cores or 
inactive cores.
+* All enabled cores will report their poll busyness in the range 0-100.
+
+Disabling Lcore Poll Busyness Telemetry
+--
+
+Some applications may not want lcore poll busyness telemetry to be tracked, for
+example performance critical applications or applications that are already 
being
+monitored by other tools gathering similar or more application specific 
information.
+
+For those applications, there are two ways in which this telemetry can be 
disabled.
+
+At compile time
+^^^
+
+Support can be disabled at compile time via the meson option. It is enabled by
+default.::
+
+$ meson configure -Denable_lcore_poll_busyness=false
+
+At run time
+^^^
+
+Support can also be disabled during runtime. This comes at the cost of an
+additional branch, however no additional function calls are performed.
+
+To disable support at runtime, a call can be made to the
+`/eal/lcore/poll_busyness_disable` endpoint::
+
+$ ./usertools/dpdk-telemetry.py
+--> /eal/lcore/poll_busyness_disable
+{"/eal/lcore/poll_busyness_disable": {"poll_busyness_enabled": 0}}
+
+It can be re-enabled at run time with the `/eal/lcore/poll_busyness_enable`
+endpoint.
-- 
2.31.1

[PATCH v2 0/4] eal: small rte_common.h fixes and cleanup

[Dmitry Kozlyuk]

v2:
* Extend and tidy up the macro unit test (Morten).
* Remove unneeded includes from rte_common.h (Morten, Bruce).

Dmitry Kozlyuk (4):
  eal: fix pointer arithmetic with an expression argument
  eal: deduplicate roundup code
  eal: uninline rte_str_to_size
  eal: remove unneeded includes from a public header

 app/test-bbdev/test_bbdev_vector.c|  1 +
 .../cperf_test_vector_parsing.c   |  1 +
 app/test-eventdev/parser.h|  1 +
 app/test-pmd/bpf_cmd.c|  2 +
 app/test-pmd/cmdline.c|  1 +
 app/test-pmd/cmdline_tm.c |  2 +
 app/test-pmd/config.c |  1 +
 app/test/test.h   |  2 +
 app/test/test_common.c| 58 +--
 drivers/bus/vdev/vdev_params.c|  1 +
 drivers/common/cnxk/cnxk_telemetry_nix.c  |  1 +
 drivers/common/cnxk/cnxk_telemetry_npa.c  |  1 +
 drivers/crypto/scheduler/scheduler_pmd.c  |  2 +
 drivers/net/cnxk/cnxk_ethdev_sec_telemetry.c  |  2 +
 drivers/net/i40e/i40e_ethdev.c|  1 +
 drivers/net/iavf/iavf_ethdev.c|  1 +
 drivers/net/ice/ice_ethdev.c  |  1 +
 drivers/net/softnic/parser.h  |  1 +
 lib/dmadev/rte_dmadev.c   |  1 +
 lib/eal/common/eal_common_debug.c |  2 +
 lib/eal/common/eal_common_string_fns.c| 36 +++-
 lib/eal/include/generic/rte_rwlock.h  |  2 +
 lib/eal/include/rte_common.h  | 41 ++---
 lib/eal/linux/eal.c   |  1 +
 lib/eal/linux/eal_vfio_mp_sync.c  |  1 +
 lib/eal/unix/eal_unix_timer.c |  1 +
 lib/eal/version.map   |  1 +
 lib/eal/windows/rte_thread.c  |  2 +
 lib/ethdev/sff_telemetry.c|  1 +
 lib/eventdev/rte_event_eth_rx_adapter.c   |  1 +
 lib/eventdev/rte_event_timer_adapter.c|  1 +
 lib/meter/rte_meter.c |  1 +
 lib/pci/rte_pci.c |  1 +
 lib/pipeline/rte_swx_ctl.c|  1 +
 lib/sched/rte_pie.c   |  1 +
 lib/security/rte_security.c   |  2 +
 lib/telemetry/telemetry_data.c|  3 +
 lib/telemetry/telemetry_legacy.c  |  1 +
 38 files changed, 126 insertions(+), 55 deletions(-)

-- 
2.33.1

[PATCH v2 1/4] eal: fix pointer arithmetic with an expression argument

[Dmitry Kozlyuk]

RTE_PTR_SUB(ptr, x) and RTE_PTR_ALIGN_FLOOR() worked incorrectly
if "ptr" was an expression:

uint32_t arr[3];

RTE_PTR_SUB(arr + 1, sizeof(arr[0]));
// expected: (uint32_t *)((uintptr_t)(arr + 1) - 4) == arr
// actual:   (uint32_t *)((uintptr_t) arr + 1  - 4) != arr

RTE_PTR_ALIGN_FLOOR(arr + 2, sizeof(arr[0]));
// expected: RTE_ALIGN_FLOOR((uintptr_t)(arr + 2), 4) == &arr[2]
// actual:   RTE_ALIGN_FLOOR((uintptr_t) arr + 2,  4) == &arr[0]

Fix the macros and extend the relevant unit test.
Convert uses of a custom test failure macro to RTE_TEST_ASSERT*().

Fixes: af75078fece3 ("first public release")
Cc: sta...@dpdk.org

Signed-off-by: Dmitry Kozlyuk 
Reviewed-by: Morten Brørup 
Acked-by: Bruce Richardson 
Acked-by: Chengwen Feng 
---
 app/test/test_common.c   | 58 +---
 lib/eal/include/rte_common.h |  4 +--
 2 files changed, 42 insertions(+), 20 deletions(-)

diff --git a/app/test/test_common.c b/app/test/test_common.c
index ef177cecb1..f89e1eb7ee 100644
--- a/app/test/test_common.c
+++ b/app/test/test_common.c
@@ -25,31 +25,53 @@ test_macros(int __rte_unused unused_parm)
 #define SMALLER 0x1000U
 #define BIGGER 0x2000U
 #define PTR_DIFF BIGGER - SMALLER
-#define FAIL_MACRO(x)\
-   {printf(#x "() test failed!\n");\
-   return -1;}
 
uintptr_t unused = 0;
unsigned int smaller = SMALLER, bigger  = BIGGER;
+   uint32_t arr[3];
 
RTE_SET_USED(unused);
 
RTE_SWAP(smaller, bigger);
-   if (smaller != BIGGER && bigger != SMALLER)
-   FAIL_MACRO(RTE_SWAP);
-   if ((uintptr_t)RTE_PTR_ADD(SMALLER, PTR_DIFF) != BIGGER)
-   FAIL_MACRO(RTE_PTR_ADD);
-   if ((uintptr_t)RTE_PTR_SUB(BIGGER, PTR_DIFF) != SMALLER)
-   FAIL_MACRO(RTE_PTR_SUB);
-   if (RTE_PTR_DIFF(BIGGER, SMALLER) != PTR_DIFF)
-   FAIL_MACRO(RTE_PTR_DIFF);
-   if (RTE_MAX(SMALLER, BIGGER) != BIGGER)
-   FAIL_MACRO(RTE_MAX);
-   if (RTE_MIN(SMALLER, BIGGER) != SMALLER)
-   FAIL_MACRO(RTE_MIN);
-
-   if (strncmp(RTE_STR(test), "test", sizeof("test")))
-   FAIL_MACRO(RTE_STR);
+   RTE_TEST_ASSERT(smaller == BIGGER && bigger == SMALLER,
+   "RTE_SWAP");
+   RTE_TEST_ASSERT_EQUAL((uintptr_t)RTE_PTR_ADD(SMALLER, PTR_DIFF), BIGGER,
+   "RTE_PTR_ADD");
+   RTE_TEST_ASSERT_EQUAL((uintptr_t)RTE_PTR_SUB(BIGGER, PTR_DIFF), SMALLER,
+   "RTE_PTR_SUB");
+   RTE_TEST_ASSERT_EQUAL(RTE_PTR_DIFF(BIGGER, SMALLER), PTR_DIFF,
+   "RTE_PTR_DIFF");
+   RTE_TEST_ASSERT_EQUAL(RTE_MAX(SMALLER, BIGGER), BIGGER,
+   "RTE_MAX");
+   RTE_TEST_ASSERT_EQUAL(RTE_MIN(SMALLER, BIGGER), SMALLER,
+   "RTE_MIN");
+
+   RTE_TEST_ASSERT_EQUAL(RTE_PTR_ADD(arr + 1, sizeof(arr[0])), &arr[2],
+   "RTE_PTR_ADD(expr, x)");
+   RTE_TEST_ASSERT_EQUAL(RTE_PTR_SUB(arr + 1, sizeof(arr[0])), &arr[0],
+   "RTE_PTR_SUB(expr, x)");
+   RTE_TEST_ASSERT_EQUAL(RTE_PTR_ALIGN_FLOOR(arr + 2, 4), &arr[2],
+   "RTE_PTR_ALIGN_FLOOR(expr, x)");
+   RTE_TEST_ASSERT_EQUAL(RTE_PTR_ALIGN_CEIL(arr + 2, 4), &arr[2],
+   "RTE_PTR_ALIGN_CEIL(expr, x)");
+   RTE_TEST_ASSERT_EQUAL(RTE_PTR_ALIGN(arr + 2, 4), &arr[2],
+   "RTE_PTR_ALIGN(expr, x)");
+
+   RTE_TEST_ASSERT_EQUAL(
+   RTE_PTR_ALIGN_FLOOR(RTE_PTR_ADD(&arr[1], 1), 4), &arr[1],
+   "RTE_PTR_ALIGN_FLOOR(x < y/2, y)");
+   RTE_TEST_ASSERT_EQUAL(
+   RTE_PTR_ALIGN_FLOOR(RTE_PTR_ADD(&arr[1], 3), 4), &arr[1],
+   "RTE_PTR_ALIGN_FLOOR(x > y/2, y)");
+   RTE_TEST_ASSERT_EQUAL(
+   RTE_PTR_ALIGN_CEIL(RTE_PTR_ADD(&arr[1], 3), 4), &arr[2],
+   "RTE_PTR_ALIGN_CEIL(x < y/2, y)");
+   RTE_TEST_ASSERT_EQUAL(
+   RTE_PTR_ALIGN_CEIL(RTE_PTR_ADD(&arr[1], 1), 4), &arr[2],
+   "RTE_PTR_ALIGN_CEIL(x > y/2, y)");
+
+   RTE_TEST_ASSERT(strncmp(RTE_STR(test), "test", sizeof("test")) == 0,
+   "RTE_STR");
 
return 0;
 }
diff --git a/lib/eal/include/rte_common.h b/lib/eal/include/rte_common.h
index a96cc2a138..d517e9f75f 100644
--- a/lib/eal/include/rte_common.h
+++ b/lib/eal/include/rte_common.h
@@ -295,7 +295,7 @@ static void __attribute__((destructor(RTE_PRIO(prio)), 
used)) func(void)
 /**
  * subtract a byte-value offset from a pointer
  */
-#define RTE_PTR_SUB(ptr, x) ((void*)((uintptr_t)ptr - (x)))
+#define RTE_PTR_SUB(ptr, x) ((void *)((uintptr_t)(ptr) - (x)))
 
 /**
  * get the difference between two pointer values, i.e. how far apart
@@ -320,7 +320,7 @@ static void __attribute__((destructor(RTE_PRIO(prio)), 
used)) func(void)
  * must be a power-of-two value.
  */
 #define RTE_PTR_ALIGN_FLOOR(ptr, align) \
-   ((typeof(ptr))RTE_ALIGN_FLOOR((uintptr_t)ptr, align))
+   ((typeof(ptr))RTE_ALIGN_FLOOR((uintptr_t)(ptr), align))
 
 /**
  * Macro to align a value t

[PATCH v2 2/4] eal: deduplicate roundup code

[Dmitry Kozlyuk]

RTE_CACHE_LINE_ROUNDUP() implementation repeated RTE_ALIGN_MUL_CEIL().
In other places RTE_CACHE_LINE_SIZE is assumed to be a power-of-2,
so define RTE_CACHE_LINE_ROUNDUP() using RTE_ALIGN_CEIL().

Signed-off-by: Dmitry Kozlyuk 
Reviewed-by: Morten Brørup 
Acked-by: Bruce Richardson 
Acked-by: Chengwen Feng 
---
 lib/eal/include/rte_common.h | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/lib/eal/include/rte_common.h b/lib/eal/include/rte_common.h
index d517e9f75f..b6bac6 100644
--- a/lib/eal/include/rte_common.h
+++ b/lib/eal/include/rte_common.h
@@ -425,9 +425,7 @@ rte_is_aligned(void *ptr, unsigned align)
 #define RTE_CACHE_LINE_MASK (RTE_CACHE_LINE_SIZE-1)
 
 /** Return the first cache-aligned value greater or equal to size. */
-#define RTE_CACHE_LINE_ROUNDUP(size) \
-   (RTE_CACHE_LINE_SIZE * ((size + RTE_CACHE_LINE_SIZE - 1) / \
-   RTE_CACHE_LINE_SIZE))
+#define RTE_CACHE_LINE_ROUNDUP(size) RTE_ALIGN_CEIL(size, RTE_CACHE_LINE_SIZE)
 
 /** Cache line size in terms of log2 */
 #if RTE_CACHE_LINE_SIZE == 64
-- 
2.33.1

[PATCH v2 3/4] eal: uninline rte_str_to_size

[Dmitry Kozlyuk]

There is no reason for rte_str_to_size() to be inline.
Move the implementation out of .
Export it as a stable ABI because it always has been public.

Signed-off-by: Dmitry Kozlyuk 
Acked-by: Morten Brørup 
Acked-by: Bruce Richardson 
Acked-by: Chengwen Feng 
---
 lib/eal/common/eal_common_string_fns.c | 32 ++
 lib/eal/include/rte_common.h   | 30 ++--
 lib/eal/version.map|  1 +
 3 files changed, 35 insertions(+), 28 deletions(-)

diff --git a/lib/eal/common/eal_common_string_fns.c 
b/lib/eal/common/eal_common_string_fns.c
index 0236ae4023..5fc4ee71dc 100644
--- a/lib/eal/common/eal_common_string_fns.c
+++ b/lib/eal/common/eal_common_string_fns.c
@@ -64,3 +64,35 @@ rte_strscpy(char *dst, const char *src, size_t dsize)
rte_errno = E2BIG;
return -rte_errno;
 }
+
+uint64_t
+rte_str_to_size(const char *str)
+{
+   char *endptr;
+   unsigned long long size;
+
+   while (isspace((int)*str))
+   str++;
+   if (*str == '-')
+   return 0;
+
+   errno = 0;
+   size = strtoull(str, &endptr, 0);
+   if (errno)
+   return 0;
+
+   if (*endptr == ' ')
+   endptr++; /* allow 1 space gap */
+
+   switch (*endptr) {
+   case 'G': case 'g':
+   size *= 1024; /* fall-through */
+   case 'M': case 'm':
+   size *= 1024; /* fall-through */
+   case 'K': case 'k':
+   size *= 1024; /* fall-through */
+   default:
+   break;
+   }
+   return size;
+}
diff --git a/lib/eal/include/rte_common.h b/lib/eal/include/rte_common.h
index b6bac6..86c50c55e0 100644
--- a/lib/eal/include/rte_common.h
+++ b/lib/eal/include/rte_common.h
@@ -873,34 +873,8 @@ rte_log2_u64(uint64_t v)
  * @return
  * Number.
  */
-static inline uint64_t
-rte_str_to_size(const char *str)
-{
-   char *endptr;
-   unsigned long long size;
-
-   while (isspace((int)*str))
-   str++;
-   if (*str == '-')
-   return 0;
-
-   errno = 0;
-   size = strtoull(str, &endptr, 0);
-   if (errno)
-   return 0;
-
-   if (*endptr == ' ')
-   endptr++; /* allow 1 space gap */
-
-   switch (*endptr){
-   case 'G': case 'g': size *= 1024; /* fall-through */
-   case 'M': case 'm': size *= 1024; /* fall-through */
-   case 'K': case 'k': size *= 1024; /* fall-through */
-   default:
-   break;
-   }
-   return size;
-}
+uint64_t
+rte_str_to_size(const char *str);
 
 /**
  * Function to terminate the application immediately, printing an error
diff --git a/lib/eal/version.map b/lib/eal/version.map
index 1f293e768b..773b0902c0 100644
--- a/lib/eal/version.map
+++ b/lib/eal/version.map
@@ -261,6 +261,7 @@ DPDK_23 {
rte_socket_id;
rte_socket_id_by_idx;
rte_srand;
+   rte_str_to_size;
rte_strerror;
rte_strscpy;
rte_strsplit;
-- 
2.33.1

[PATCH v2 4/4] eal: remove unneeded includes from a public header

[Dmitry Kozlyuk]

Do not include , , and  from ,
because they are not used by this file directly.
Include the needed headers directly from the files that need them.

Signed-off-by: Dmitry Kozlyuk 
---
Done as a separate commit to keep EAL change clean.

 app/test-bbdev/test_bbdev_vector.c   | 1 +
 app/test-crypto-perf/cperf_test_vector_parsing.c | 1 +
 app/test-eventdev/parser.h   | 1 +
 app/test-pmd/bpf_cmd.c   | 2 ++
 app/test-pmd/cmdline.c   | 1 +
 app/test-pmd/cmdline_tm.c| 2 ++
 app/test-pmd/config.c| 1 +
 app/test/test.h  | 2 ++
 drivers/bus/vdev/vdev_params.c   | 1 +
 drivers/common/cnxk/cnxk_telemetry_nix.c | 1 +
 drivers/common/cnxk/cnxk_telemetry_npa.c | 1 +
 drivers/crypto/scheduler/scheduler_pmd.c | 2 ++
 drivers/net/cnxk/cnxk_ethdev_sec_telemetry.c | 2 ++
 drivers/net/i40e/i40e_ethdev.c   | 1 +
 drivers/net/iavf/iavf_ethdev.c   | 1 +
 drivers/net/ice/ice_ethdev.c | 1 +
 drivers/net/softnic/parser.h | 1 +
 lib/dmadev/rte_dmadev.c  | 1 +
 lib/eal/common/eal_common_debug.c| 2 ++
 lib/eal/common/eal_common_string_fns.c   | 4 +++-
 lib/eal/include/generic/rte_rwlock.h | 2 ++
 lib/eal/include/rte_common.h | 3 ---
 lib/eal/linux/eal.c  | 1 +
 lib/eal/linux/eal_vfio_mp_sync.c | 1 +
 lib/eal/unix/eal_unix_timer.c| 1 +
 lib/eal/windows/rte_thread.c | 2 ++
 lib/ethdev/sff_telemetry.c   | 1 +
 lib/eventdev/rte_event_eth_rx_adapter.c  | 1 +
 lib/eventdev/rte_event_timer_adapter.c   | 1 +
 lib/meter/rte_meter.c| 1 +
 lib/pci/rte_pci.c| 1 +
 lib/pipeline/rte_swx_ctl.c   | 1 +
 lib/sched/rte_pie.c  | 1 +
 lib/security/rte_security.c  | 2 ++
 lib/telemetry/telemetry_data.c   | 3 +++
 lib/telemetry/telemetry_legacy.c | 1 +
 36 files changed, 48 insertions(+), 4 deletions(-)

diff --git a/app/test-bbdev/test_bbdev_vector.c 
b/app/test-bbdev/test_bbdev_vector.c
index f020836f88..5018397c46 100644
--- a/app/test-bbdev/test_bbdev_vector.c
+++ b/app/test-bbdev/test_bbdev_vector.c
@@ -5,6 +5,7 @@
 #ifdef RTE_EXEC_ENV_FREEBSD
#define _WITH_GETLINE
 #endif
+#include 
 #include 
 #include 
 #include 
diff --git a/app/test-crypto-perf/cperf_test_vector_parsing.c 
b/app/test-crypto-perf/cperf_test_vector_parsing.c
index 87f3a90055..2c9087b5f9 100644
--- a/app/test-crypto-perf/cperf_test_vector_parsing.c
+++ b/app/test-crypto-perf/cperf_test_vector_parsing.c
@@ -4,6 +4,7 @@
 #ifdef RTE_EXEC_ENV_FREEBSD
#define _WITH_GETLINE
 #endif
+#include 
 #include 
 
 #include 
diff --git a/app/test-eventdev/parser.h b/app/test-eventdev/parser.h
index 696b40a3e2..954371b5b8 100644
--- a/app/test-eventdev/parser.h
+++ b/app/test-eventdev/parser.h
@@ -5,6 +5,7 @@
 #ifndef __INCLUDE_PARSER_H__
 #define __INCLUDE_PARSER_H__
 
+#include 
 #include 
 
 #define PARSE_DELIMITER" \f\n\r\t\v"
diff --git a/app/test-pmd/bpf_cmd.c b/app/test-pmd/bpf_cmd.c
index 648e0e9294..46f6b7d6d2 100644
--- a/app/test-pmd/bpf_cmd.c
+++ b/app/test-pmd/bpf_cmd.c
@@ -2,7 +2,9 @@
  * Copyright(c) 2018 Intel Corporation
  */
 
+#include 
 #include 
+
 #include 
 #include 
 #include 
diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index b4fe9dfb17..07566c7a77 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -3,6 +3,7 @@
  * Copyright(c) 2014 6WIND S.A.
  */
 
+#include 
 #include 
 #include 
 #include 
diff --git a/app/test-pmd/cmdline_tm.c b/app/test-pmd/cmdline_tm.c
index fb56a234c5..1bc6c00998 100644
--- a/app/test-pmd/cmdline_tm.c
+++ b/app/test-pmd/cmdline_tm.c
@@ -2,6 +2,8 @@
  * Copyright(c) 2017 Intel Corporation
  */
 
+#include 
+
 #include 
 #include 
 #include 
diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index a2939867c4..86054455d2 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -3,6 +3,7 @@
  * Copyright 2013-2014 6WIND S.A.
  */
 
+#include 
 #include 
 #include 
 #include 
diff --git a/app/test/test.h b/app/test/test.h
index 7115edf469..85f57efbc6 100644
--- a/app/test/test.h
+++ b/app/test/test.h
@@ -5,7 +5,9 @@
 #ifndef _TEST_H_
 #define _TEST_H_
 
+#include 
 #include 
+#include 
 #include 
 
 #include 
diff --git a/drivers/bus/vdev/vdev_params.c b/drivers/bus/vdev/vdev_params.c
index 3969faf16d..3d6f63344a 100644
--- a/drivers/bus/vdev/vdev_params.c
+++ b/drivers/bus/vdev/vdev_params.c
@@ -2,6 +2,7 @@
  * Copyright 2018 Gaëtan Rivet
  */
 
+#include 
 #include 
 
 #include 
diff --git a/drivers/common/cnxk/cnxk_telemetry_nix.

Re: 答复: [dpdk-dev] [PATCH] net/bonding: fix array overflow in Rx burst

[Ferruh Yigit]

On 7/20/2022 2:28 AM, humin (Q) wrote:


-邮件原件-
发件人: wangyunjian 
发送时间: 2022年7月18日 21:09
收件人: dev@dpdk.org
抄送: ch...@att.com; humin (Q) ; Huangshaozhang 
; jilei (F) ; wangyunjian 
; sta...@dpdk.org
主题: [dpdk-dev] [PATCH] net/bonding: fix array overflow in Rx burst

In bond_ethdev_rx_burst() function, we check the validity of the 'active_slave' 
as this code:
if (++active_slave == slave_count)
active_slave = 0;
However, the value of 'active_slave' maybe equal to 'slave_count', when a slave 
is down. This is wrong and it can cause buffer overflow.
This patch fixes the issue by using '>=' instead of '=='.

Fixes: e1110e977648 ("net/bonding: fix Rx slave fairness")
Cc: sta...@dpdk.org

Signed-off-by: Lei Ji 
Signed-off-by: Yunjian Wang 

>
> Acked-by: Min Hu (Connor) 
>

Applied to dpdk-next-net/main, thanks.

Re: 答复: [dpdk-dev] [PATCH] net/bonding: fix double get slave link status

[Ferruh Yigit]

On 7/20/2022 7:39 AM, humin (Q) wrote:


-邮件原件-
发件人: wangyunjian 
发送时间: 2022年7月13日 19:11
收件人: dev@dpdk.org
抄送: ch...@att.com; humin (Q) ; Huangshaozhang 
; wangyunjian ; sta...@dpdk.org
主题: [dpdk-dev] [PATCH] net/bonding: fix double get slave link status

When link status polling mode is using, the slave link status is queried twice, 
which may be inconsistent. To fix this, we can keep the lastest queried link 
state.

Fixes: a45b288ef21a ("bond: support link status polling")
Cc: sta...@dpdk.org

Signed-off-by: Yunjian Wang 

>
> Acked-by: Min Hu (Connor) 
>

Applied to dpdk-next-net/main, thanks.

[PATCH v2] power: add unpriv. read of turbo % for pstate

[Markus Theil]

If DPDK applications should be used with a minimal set of privileges,
using the msr kernel module on linux should not be necessary.

Since at least kernel 4.4 the rdmsr call to obtain the last non-turbo
boost frequency can be left out, if the sysfs interface is used.
Also RHEL 7 with recent kernel updates should include the sysfs interface
for this (I only looked this up for CentOS 7).

Tested-by: David Hunt 
Acked-by: David Hunt 
Signed-off-by: Markus Theil 
---
v2: atol -> strol (as suggested by David Hunt), close newly introduced fd

 lib/power/power_pstate_cpufreq.c | 79 
 1 file changed, 50 insertions(+), 29 deletions(-)

diff --git a/lib/power/power_pstate_cpufreq.c b/lib/power/power_pstate_cpufreq.c
index 78c9197695..49ddb2eefd 100644
--- a/lib/power/power_pstate_cpufreq.c
+++ b/lib/power/power_pstate_cpufreq.c
@@ -3,6 +3,7 @@
  */
 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -35,15 +36,9 @@
"/sys/devices/system/cpu/cpu%u/cpufreq/cpuinfo_min_freq"
 #define POWER_SYSFILE_BASE_FREQ  \
"/sys/devices/system/cpu/cpu%u/cpufreq/base_frequency"
+#define POWER_SYSFILE_TURBO_PCT  \
+   "/sys/devices/system/cpu/intel_pstate/turbo_pct"
 #define POWER_PSTATE_DRIVER "intel_pstate"
-#define POWER_MSR_PATH  "/dev/cpu/%u/msr"
-
-/*
- * MSR related
- */
-#define PLATFORM_INFO 0x0CE
-#define NON_TURBO_MASK0xFF00
-#define NON_TURBO_OFFSET  0x8
 
 
 enum power_state {
@@ -74,37 +69,41 @@ struct pstate_power_info {
 static struct pstate_power_info lcore_power_info[RTE_MAX_LCORE];
 
 /**
- * It is to read the specific MSR.
+ * It is to read the turbo mode percentage from sysfs
  */
-
 static int32_t
-power_rdmsr(int msr, uint64_t *val, unsigned int lcore_id)
+power_read_turbo_pct(uint64_t *outVal)
 {
int fd, ret;
-   char fullpath[PATH_MAX];
+   char val[4] = {0};
+   char *endptr;
 
-   snprintf(fullpath, sizeof(fullpath), POWER_MSR_PATH, lcore_id);
-
-   fd = open(fullpath, O_RDONLY);
+   fd = open(POWER_SYSFILE_TURBO_PCT, O_RDONLY);
 
if (fd < 0) {
-   RTE_LOG(ERR, POWER, "Error opening '%s': %s\n", fullpath,
+   RTE_LOG(ERR, POWER, "Error opening '%s': %s\n", 
POWER_SYSFILE_TURBO_PCT,
 strerror(errno));
return fd;
}
 
-   ret = pread(fd, val, sizeof(uint64_t), msr);
+   ret = read(fd, val, sizeof(val));
 
if (ret < 0) {
-   RTE_LOG(ERR, POWER, "Error reading '%s': %s\n", fullpath,
+   RTE_LOG(ERR, POWER, "Error reading '%s': %s\n", 
POWER_SYSFILE_TURBO_PCT,
 strerror(errno));
goto out;
}
 
-   POWER_DEBUG_TRACE("MSR Path %s, offset 0x%X for lcore %u\n",
-   fullpath, msr, lcore_id);
+   errno = 0;
+   *outVal = (uint64_t) strtol(val, &endptr, 10);
+   if (*endptr != 0 || errno != 0) {
+   RTE_LOG(ERR, POWER, "Error converting str to digits, read from 
%s: %s\n",
+POWER_SYSFILE_TURBO_PCT, strerror(errno));
+   ret = -1;
+   goto out;
+   }
 
-   POWER_DEBUG_TRACE("Ret value %d, content is 0x%"PRIx64"\n", ret, *val);
+   POWER_DEBUG_TRACE("power turbo pct: %"PRIu64"\n", *outVal);
 
 out:   close(fd);
return ret;
@@ -116,8 +115,9 @@ out:close(fd);
 static int
 power_init_for_setting_freq(struct pstate_power_info *pi)
 {
-   FILE *f_base = NULL, *f_base_max = NULL, *f_min = NULL, *f_max = NULL;
-   uint32_t base_ratio, base_max_ratio;
+   FILE *f_base = NULL, *f_base_min = NULL, *f_base_max = NULL,
+*f_min = NULL, *f_max = NULL;
+   uint32_t base_ratio, base_min_ratio, base_max_ratio;
uint64_t max_non_turbo;
int ret;
 
@@ -130,6 +130,14 @@ power_init_for_setting_freq(struct pstate_power_info *pi)
goto err;
}
 
+   open_core_sysfs_file(&f_base_min, "r", POWER_SYSFILE_BASE_MIN_FREQ,
+   pi->lcore_id);
+   if (f_base_min == NULL) {
+   RTE_LOG(ERR, POWER, "failed to open %s\n",
+   POWER_SYSFILE_BASE_MIN_FREQ);
+   goto err;
+   }
+
open_core_sysfs_file(&f_min, "rw+", POWER_SYSFILE_MIN_FREQ,
pi->lcore_id);
if (f_min == NULL) {
@@ -158,6 +166,14 @@ power_init_for_setting_freq(struct pstate_power_info *pi)
goto err;
}
 
+   /* read base min ratio */
+   ret = read_core_sysfs_u32(f_base_min, &base_min_ratio);
+   if (ret < 0) {
+   RTE_LOG(ERR, POWER, "Failed to read %s\n",
+   POWER_SYSFILE_BASE_MIN_FREQ);
+   goto err;
+   }
+
/* base ratio may not exist */
if (f_base != NULL) {
ret = read_core_sysfs_u32(f_base, &base_ratio);
@@ -170,20 +186,22 @@ power_init_for_setting_freq(st

RE: [PATCH v5 2/7] bbdev: add device status info

[Chautru, Nicolas]

Thanks Maxime,

> -Original Message-
> From: Maxime Coquelin 
> Sent: Thursday, August 25, 2022 7:19 AM
> To: Chautru, Nicolas ; dev@dpdk.org;
> tho...@monjalon.net; gak...@marvell.com; hemant.agra...@nxp.com
> Cc: t...@redhat.com; m...@ashroe.eu; Richardson, Bruce
> ; david.march...@redhat.com;
> step...@networkplumber.org
> Subject: Re: [PATCH v5 2/7] bbdev: add device status info
> 
> 
> 
> On 7/7/22 01:28, Nicolas Chautru wrote:
> > Added device status information, so that the PMD can expose
> > information related to the underlying accelerator device status.
> > Minor order change in structure to fit into padding hole.
> >
> > Signed-off-by: Nicolas Chautru 
> > ---
> >   drivers/baseband/acc100/rte_acc100_pmd.c   |  1 +
> >   drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c |  1 +
> >   drivers/baseband/fpga_lte_fec/fpga_lte_fec.c   |  1 +
> >   drivers/baseband/la12xx/bbdev_la12xx.c |  1 +
> >   drivers/baseband/null/bbdev_null.c |  1 +
> >   drivers/baseband/turbo_sw/bbdev_turbo_software.c   |  1 +
> >   lib/bbdev/rte_bbdev.c  | 22 ++
> >   lib/bbdev/rte_bbdev.h  | 35 
> > --
> >   lib/bbdev/version.map  |  6 
> >   9 files changed, 67 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c
> > b/drivers/baseband/acc100/rte_acc100_pmd.c
> > index de7e4bc..17ba798 100644
> > --- a/drivers/baseband/acc100/rte_acc100_pmd.c
> > +++ b/drivers/baseband/acc100/rte_acc100_pmd.c
> > @@ -1060,6 +1060,7 @@
> >
> > /* Read and save the populated config from ACC100 registers */
> > fetch_acc100_config(dev);
> > +   dev_info->device_status = RTE_BBDEV_DEV_NOT_SUPPORTED;
> >
> > /* This isn't ideal because it reports the maximum number of queues
> but
> >  * does not provide info on how many can be uplink/downlink or
> > different diff --git
> > a/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c
> > b/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c
> > index 82ae6ba..57b12af 100644
> > --- a/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c
> > +++ b/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c
> > @@ -369,6 +369,7 @@
> > dev_info->capabilities = bbdev_capabilities;
> > dev_info->cpu_flag_reqs = NULL;
> > dev_info->data_endianness = RTE_LITTLE_ENDIAN;
> > +   dev_info->device_status = RTE_BBDEV_DEV_NOT_SUPPORTED;
> >
> > /* Calculates number of queues assigned to device */
> > dev_info->max_num_queues = 0;
> > diff --git a/drivers/baseband/fpga_lte_fec/fpga_lte_fec.c
> > b/drivers/baseband/fpga_lte_fec/fpga_lte_fec.c
> > index 21d3529..2a330c4 100644
> > --- a/drivers/baseband/fpga_lte_fec/fpga_lte_fec.c
> > +++ b/drivers/baseband/fpga_lte_fec/fpga_lte_fec.c
> > @@ -645,6 +645,7 @@ struct __rte_cache_aligned fpga_queue {
> > dev_info->capabilities = bbdev_capabilities;
> > dev_info->cpu_flag_reqs = NULL;
> > dev_info->data_endianness = RTE_LITTLE_ENDIAN;
> > +   dev_info->device_status = RTE_BBDEV_DEV_NOT_SUPPORTED;
> >
> > /* Calculates number of queues assigned to device */
> > dev_info->max_num_queues = 0;
> > diff --git a/drivers/baseband/la12xx/bbdev_la12xx.c
> > b/drivers/baseband/la12xx/bbdev_la12xx.c
> > index 4d1bd16..c1f88c6 100644
> > --- a/drivers/baseband/la12xx/bbdev_la12xx.c
> > +++ b/drivers/baseband/la12xx/bbdev_la12xx.c
> > @@ -100,6 +100,7 @@ struct bbdev_la12xx_params {
> > dev_info->capabilities = bbdev_capabilities;
> > dev_info->cpu_flag_reqs = NULL;
> > dev_info->min_alignment = 64;
> > +   dev_info->device_status = RTE_BBDEV_DEV_NOT_SUPPORTED;
> >
> > rte_bbdev_log_debug("got device info from %u", dev->data-
> >dev_id);
> >   }
> > diff --git a/drivers/baseband/null/bbdev_null.c
> > b/drivers/baseband/null/bbdev_null.c
> > index 248e129..94a1976 100644
> > --- a/drivers/baseband/null/bbdev_null.c
> > +++ b/drivers/baseband/null/bbdev_null.c
> > @@ -82,6 +82,7 @@ struct bbdev_queue {
> >  * here for code completeness.
> >  */
> > dev_info->data_endianness = RTE_LITTLE_ENDIAN;
> > +   dev_info->device_status = RTE_BBDEV_DEV_NOT_SUPPORTED;
> >
> > rte_bbdev_log_debug("got device info from %u", dev->data-
> >dev_id);
> >   }
> > diff --git a/drivers/baseband/turbo_sw/bbdev_turbo_software.c
> > b/drivers/baseband/turbo_sw/bbdev_turbo_software.c
> > index af7bc41..dbc5524 100644
> > --- a/drivers/baseband/turbo_sw/bbdev_turbo_software.c
> > +++ b/drivers/baseband/turbo_sw/bbdev_turbo_software.c
> > @@ -254,6 +254,7 @@ struct turbo_sw_queue {
> > dev_info->min_alignment = 64;
> > dev_info->harq_buffer_size = 0;
> > dev_info->data_endianness = RTE_LITTLE_ENDIAN;
> > +   dev_info->device_status = RTE_BBDEV_DEV_NOT_SUPPORTED;
> >
> > rte_bbdev_log_debug("got device info from %u\n", dev->data-
> >dev_id);
> >   }
> > diff --git a/lib/bbdev/rte_bbdev.c b/lib/bbdev/rte_bbdev.c index
> 

[PATCH v6 0/7] bbdev changes for 22.11

[Nicolas Chautru]

v6: added one comment in commit 2/7 suggested by Maxime.
v5: update base on review from Tom Rix. Number of typos reported and resolved,
removed the commit related to rw_lock for now, added a commit for
code clean up from review, resolved one rebase issue between 2 commits, used 
size of array for some bound check implementation. Thanks. 
v4: update to the last 2 commits to include function to print the queue status 
and a fix to the rte_lock within the wrong structure
v3: update to device status info to also use padded size for the related array.
Adding also 2 additionals commits to allow the API struc to expose more 
information related to queues corner cases/warning as well as an optional rw 
lock.
Hemant, Maxime, this is planned for DPDK 21.11 but would like review/ack early 
is possible to get this applied earlier and due to time off this summer.
Thanks
Nic

Nicolas Chautru (7):
  bbdev: allow operation type enum for growth
  bbdev: add device status info
  bbdev: add device info on queue topology
  drivers/baseband: update PMDs to expose queue per operation
  bbdev: add new operation for FFT processing
  bbdev: add queue related warning and status information
  bbdev: remove unnecessary if-check

 app/test-bbdev/test_bbdev.c|   2 +-
 app/test-bbdev/test_bbdev_perf.c   |   6 +-
 doc/guides/prog_guide/bbdev.rst| 130 +
 drivers/baseband/acc100/rte_acc100_pmd.c   |  30 ++--
 drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c |   9 ++
 drivers/baseband/fpga_lte_fec/fpga_lte_fec.c   |   9 ++
 drivers/baseband/la12xx/bbdev_la12xx.c |  10 +-
 drivers/baseband/null/bbdev_null.c |   1 +
 drivers/baseband/turbo_sw/bbdev_turbo_software.c   |  12 ++
 examples/bbdev_app/main.c  |   2 +-
 lib/bbdev/rte_bbdev.c  |  57 +++-
 lib/bbdev/rte_bbdev.h  | 149 +++-
 lib/bbdev/rte_bbdev_op.h   | 156 -
 lib/bbdev/version.map  |  12 ++
 14 files changed, 556 insertions(+), 29 deletions(-)

-- 
1.8.3.1

[PATCH v6 2/7] bbdev: add device status info

[Nicolas Chautru]

Added device status information, so that the PMD can
expose information related to the underlying accelerator device status.
Minor order change in structure to fit into padding hole.

Signed-off-by: Nicolas Chautru 
---
 drivers/baseband/acc100/rte_acc100_pmd.c   |  1 +
 drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c |  1 +
 drivers/baseband/fpga_lte_fec/fpga_lte_fec.c   |  1 +
 drivers/baseband/la12xx/bbdev_la12xx.c |  1 +
 drivers/baseband/null/bbdev_null.c |  1 +
 drivers/baseband/turbo_sw/bbdev_turbo_software.c   |  1 +
 lib/bbdev/rte_bbdev.c  | 22 ++
 lib/bbdev/rte_bbdev.h  | 35 --
 lib/bbdev/version.map  |  7 +
 9 files changed, 68 insertions(+), 2 deletions(-)

diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c 
b/drivers/baseband/acc100/rte_acc100_pmd.c
index de7e4bc..17ba798 100644
--- a/drivers/baseband/acc100/rte_acc100_pmd.c
+++ b/drivers/baseband/acc100/rte_acc100_pmd.c
@@ -1060,6 +1060,7 @@
 
/* Read and save the populated config from ACC100 registers */
fetch_acc100_config(dev);
+   dev_info->device_status = RTE_BBDEV_DEV_NOT_SUPPORTED;
 
/* This isn't ideal because it reports the maximum number of queues but
 * does not provide info on how many can be uplink/downlink or different
diff --git a/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c 
b/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c
index 82ae6ba..57b12af 100644
--- a/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c
+++ b/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c
@@ -369,6 +369,7 @@
dev_info->capabilities = bbdev_capabilities;
dev_info->cpu_flag_reqs = NULL;
dev_info->data_endianness = RTE_LITTLE_ENDIAN;
+   dev_info->device_status = RTE_BBDEV_DEV_NOT_SUPPORTED;
 
/* Calculates number of queues assigned to device */
dev_info->max_num_queues = 0;
diff --git a/drivers/baseband/fpga_lte_fec/fpga_lte_fec.c 
b/drivers/baseband/fpga_lte_fec/fpga_lte_fec.c
index 21d3529..2a330c4 100644
--- a/drivers/baseband/fpga_lte_fec/fpga_lte_fec.c
+++ b/drivers/baseband/fpga_lte_fec/fpga_lte_fec.c
@@ -645,6 +645,7 @@ struct __rte_cache_aligned fpga_queue {
dev_info->capabilities = bbdev_capabilities;
dev_info->cpu_flag_reqs = NULL;
dev_info->data_endianness = RTE_LITTLE_ENDIAN;
+   dev_info->device_status = RTE_BBDEV_DEV_NOT_SUPPORTED;
 
/* Calculates number of queues assigned to device */
dev_info->max_num_queues = 0;
diff --git a/drivers/baseband/la12xx/bbdev_la12xx.c 
b/drivers/baseband/la12xx/bbdev_la12xx.c
index 4d1bd16..c1f88c6 100644
--- a/drivers/baseband/la12xx/bbdev_la12xx.c
+++ b/drivers/baseband/la12xx/bbdev_la12xx.c
@@ -100,6 +100,7 @@ struct bbdev_la12xx_params {
dev_info->capabilities = bbdev_capabilities;
dev_info->cpu_flag_reqs = NULL;
dev_info->min_alignment = 64;
+   dev_info->device_status = RTE_BBDEV_DEV_NOT_SUPPORTED;
 
rte_bbdev_log_debug("got device info from %u", dev->data->dev_id);
 }
diff --git a/drivers/baseband/null/bbdev_null.c 
b/drivers/baseband/null/bbdev_null.c
index 248e129..94a1976 100644
--- a/drivers/baseband/null/bbdev_null.c
+++ b/drivers/baseband/null/bbdev_null.c
@@ -82,6 +82,7 @@ struct bbdev_queue {
 * here for code completeness.
 */
dev_info->data_endianness = RTE_LITTLE_ENDIAN;
+   dev_info->device_status = RTE_BBDEV_DEV_NOT_SUPPORTED;
 
rte_bbdev_log_debug("got device info from %u", dev->data->dev_id);
 }
diff --git a/drivers/baseband/turbo_sw/bbdev_turbo_software.c 
b/drivers/baseband/turbo_sw/bbdev_turbo_software.c
index af7bc41..dbc5524 100644
--- a/drivers/baseband/turbo_sw/bbdev_turbo_software.c
+++ b/drivers/baseband/turbo_sw/bbdev_turbo_software.c
@@ -254,6 +254,7 @@ struct turbo_sw_queue {
dev_info->min_alignment = 64;
dev_info->harq_buffer_size = 0;
dev_info->data_endianness = RTE_LITTLE_ENDIAN;
+   dev_info->device_status = RTE_BBDEV_DEV_NOT_SUPPORTED;
 
rte_bbdev_log_debug("got device info from %u\n", dev->data->dev_id);
 }
diff --git a/lib/bbdev/rte_bbdev.c b/lib/bbdev/rte_bbdev.c
index 4da8047..38630a2 100644
--- a/lib/bbdev/rte_bbdev.c
+++ b/lib/bbdev/rte_bbdev.c
@@ -1133,3 +1133,25 @@ struct rte_mempool *
rte_bbdev_log(ERR, "Invalid operation type");
return NULL;
 }
+
+const char *
+rte_bbdev_device_status_str(enum rte_bbdev_device_status status)
+{
+   static const char * const dev_sta_string[] = {
+   "RTE_BBDEV_DEV_NOSTATUS",
+   "RTE_BBDEV_DEV_NOT_SUPPORTED",
+   "RTE_BBDEV_DEV_RESET",
+   "RTE_BBDEV_DEV_CONFIGURED",
+   "RTE_BBDEV_DEV_ACTIVE",
+   "RTE_BBDEV_DEV_FATAL_ERR",
+   "RTE_BBDEV_DEV_RESTART_REQ",
+   "RTE_BBDEV_DEV_RECONFIG_REQ",
+   "RTE_BBDE

[PATCH v6 1/7] bbdev: allow operation type enum for growth

[Nicolas Chautru]

Updating the enum for rte_bbdev_op_type
to allow to keep ABI compatible for enum insertion
while adding padded maximum value for array need.
Removing RTE_BBDEV_OP_TYPE_COUNT and instead exposing
RTE_BBDEV_OP_TYPE_PADDED_MAX.

Signed-off-by: Nicolas Chautru 
Acked-by: Maxime Coquelin 
---
 app/test-bbdev/test_bbdev.c  | 2 +-
 app/test-bbdev/test_bbdev_perf.c | 4 ++--
 examples/bbdev_app/main.c| 2 +-
 lib/bbdev/rte_bbdev.c| 8 +---
 lib/bbdev/rte_bbdev_op.h | 2 +-
 5 files changed, 10 insertions(+), 8 deletions(-)

diff --git a/app/test-bbdev/test_bbdev.c b/app/test-bbdev/test_bbdev.c
index ac06d73..1063f6e 100644
--- a/app/test-bbdev/test_bbdev.c
+++ b/app/test-bbdev/test_bbdev.c
@@ -521,7 +521,7 @@ struct bbdev_testsuite_params {
rte_mempool_free(mp);
 
TEST_ASSERT((mp = rte_bbdev_op_pool_create("Test_INV",
-   RTE_BBDEV_OP_TYPE_COUNT, size, cache_size, 0)) == NULL,
+   RTE_BBDEV_OP_TYPE_PADDED_MAX, size, cache_size, 0)) == 
NULL,
"Failed test for rte_bbdev_op_pool_create: "
"returned value is not NULL for invalid type");
 
diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c
index fad3b1e..1abda2d 100644
--- a/app/test-bbdev/test_bbdev_perf.c
+++ b/app/test-bbdev/test_bbdev_perf.c
@@ -2428,13 +2428,13 @@ typedef int (test_case_function)(struct active_device 
*ad,
 
/* Find capabilities */
const struct rte_bbdev_op_cap *cap = info.drv.capabilities;
-   for (i = 0; i < RTE_BBDEV_OP_TYPE_COUNT; i++) {
+   do {
if (cap->type == test_vector.op_type) {
capabilities = cap;
break;
}
cap++;
-   }
+   } while (cap->type != RTE_BBDEV_OP_NONE);
TEST_ASSERT_NOT_NULL(capabilities,
"Couldn't find capabilities");
 
diff --git a/examples/bbdev_app/main.c b/examples/bbdev_app/main.c
index fc7e8b8..ef0ba76 100644
--- a/examples/bbdev_app/main.c
+++ b/examples/bbdev_app/main.c
@@ -1041,7 +1041,7 @@ uint16_t bbdev_parse_number(const char *mask)
void *sigret;
struct app_config_params app_params = def_app_config;
struct rte_mempool *ethdev_mbuf_mempool, *bbdev_mbuf_mempool;
-   struct rte_mempool *bbdev_op_pools[RTE_BBDEV_OP_TYPE_COUNT];
+   struct rte_mempool *bbdev_op_pools[RTE_BBDEV_OP_TYPE_PADDED_MAX];
struct lcore_conf lcore_conf[RTE_MAX_LCORE] = { {0} };
struct lcore_statistics lcore_stats[RTE_MAX_LCORE] = { {0} };
struct stats_lcore_params stats_lcore;
diff --git a/lib/bbdev/rte_bbdev.c b/lib/bbdev/rte_bbdev.c
index aaee7b7..4da8047 100644
--- a/lib/bbdev/rte_bbdev.c
+++ b/lib/bbdev/rte_bbdev.c
@@ -23,6 +23,8 @@
 
 #define DEV_NAME "BBDEV"
 
+/* Number of supported operation types */
+#define BBDEV_OP_TYPE_COUNT 5
 
 /* BBDev library logging ID */
 RTE_LOG_REGISTER_DEFAULT(bbdev_logtype, NOTICE);
@@ -890,10 +892,10 @@ struct rte_mempool *
return NULL;
}
 
-   if (type >= RTE_BBDEV_OP_TYPE_COUNT) {
+   if (type >= BBDEV_OP_TYPE_COUNT) {
rte_bbdev_log(ERR,
"Invalid op type (%u), should be less than %u",
-   type, RTE_BBDEV_OP_TYPE_COUNT);
+   type, BBDEV_OP_TYPE_COUNT);
return NULL;
}
 
@@ -1125,7 +1127,7 @@ struct rte_mempool *
"RTE_BBDEV_OP_LDPC_ENC",
};
 
-   if (op_type < RTE_BBDEV_OP_TYPE_COUNT)
+   if (op_type < BBDEV_OP_TYPE_COUNT)
return op_types[op_type];
 
rte_bbdev_log(ERR, "Invalid operation type");
diff --git a/lib/bbdev/rte_bbdev_op.h b/lib/bbdev/rte_bbdev_op.h
index 6d56133..cd82418 100644
--- a/lib/bbdev/rte_bbdev_op.h
+++ b/lib/bbdev/rte_bbdev_op.h
@@ -748,7 +748,7 @@ enum rte_bbdev_op_type {
RTE_BBDEV_OP_TURBO_ENC,  /**< Turbo encode */
RTE_BBDEV_OP_LDPC_DEC,  /**< LDPC decode */
RTE_BBDEV_OP_LDPC_ENC,  /**< LDPC encode */
-   RTE_BBDEV_OP_TYPE_COUNT,  /**< Count of different op types */
+   RTE_BBDEV_OP_TYPE_PADDED_MAX = 8,  /**< Maximum op type number 
including padding */
 };
 
 /** Bit indexes of possible errors reported through status field */
-- 
1.8.3.1

[PATCH v6 3/7] bbdev: add device info on queue topology

[Nicolas Chautru]

Adding more options in the API to expose the number
of queues exposed and related priority.

Signed-off-by: Nicolas Chautru 
Acked-by: Maxime Coquelin 
---
 lib/bbdev/rte_bbdev.h | 4 
 1 file changed, 4 insertions(+)

diff --git a/lib/bbdev/rte_bbdev.h b/lib/bbdev/rte_bbdev.h
index 9b1ffa4..ac941d6 100644
--- a/lib/bbdev/rte_bbdev.h
+++ b/lib/bbdev/rte_bbdev.h
@@ -289,6 +289,10 @@ struct rte_bbdev_driver_info {
 
/** Maximum number of queues supported by the device */
unsigned int max_num_queues;
+   /** Maximum number of queues supported per operation type */
+   unsigned int num_queues[RTE_BBDEV_OP_TYPE_PADDED_MAX];
+   /** Priority level supported per operation type */
+   unsigned int queue_priority[RTE_BBDEV_OP_TYPE_PADDED_MAX];
/** Queue size limit (queue size must also be power of 2) */
uint32_t queue_size_lim;
/** Set if device off-loads operation to hardware  */
-- 
1.8.3.1

[PATCH v6 5/7] bbdev: add new operation for FFT processing

[Nicolas Chautru]

Extension of bbdev operation to support FFT based operations.

Signed-off-by: Nicolas Chautru 
Acked-by: Hemant Agrawal 
---
 doc/guides/prog_guide/bbdev.rst | 130 +++
 lib/bbdev/rte_bbdev.c   |  10 ++-
 lib/bbdev/rte_bbdev.h   |  76 
 lib/bbdev/rte_bbdev_op.h| 149 
 lib/bbdev/version.map   |   4 ++
 5 files changed, 368 insertions(+), 1 deletion(-)

diff --git a/doc/guides/prog_guide/bbdev.rst b/doc/guides/prog_guide/bbdev.rst
index 70fa01a..150161b 100644
--- a/doc/guides/prog_guide/bbdev.rst
+++ b/doc/guides/prog_guide/bbdev.rst
@@ -1118,6 +1118,136 @@ Figure :numref:`figure_turbo_tb_decode` above
 showing the Turbo decoding of CBs using BBDEV interface in TB-mode
 is also valid for LDPC decode.
 
+BBDEV FFT Operation
+
+
+This operation allows to run a combination of DFT and/or IDFT and/or 
time-domain windowing.
+These can be used in a modular fashion (using bypass modes) or as a processing 
pipeline
+which can be used for FFT-based baseband signal processing.
+In more details it allows :
+- to process the data first through an IDFT of adjustable size and padding;
+- to perform the windowing as a programmable cyclic shift offset of the data 
followed by a
+pointwise multiplication by a time domain window;
+- to process the related data through a DFT of adjustable size and depadding 
for each such cyclic
+shift output.
+
+A flexible number of Rx antennas are being processed in parallel with the same 
configuration.
+The API allows more generally for flexibility in what the PMD may support 
(cabability flags) and
+flexibility to adjust some of the parameters of the processing.
+
+The operation/capability flags that can be set for each FFT operation are 
given below.
+
+  **NOTE:** The actual operation flags that may be used with a specific
+  BBDEV PMD are dependent on the driver capabilities as reported via
+  ``rte_bbdev_info_get()``, and may be a subset of those below.
+
+++
+|Description of FFT capability flags |
+++
+|RTE_BBDEV_FFT_WINDOWING |
+| Set to enable/support windowing in time domain |
+++
+|RTE_BBDEV_FFT_CS_ADJUSTMENT |
+| Set to enable/support  the cyclic shift time offset adjustment |
+++
+|RTE_BBDEV_FFT_DFT_BYPASS|
+| Set to bypass the DFT and use directly the IDFT as an option   |
+++
+|RTE_BBDEV_FFT_IDFT_BYPASS   |
+| Set to bypass the IDFT and use directly the DFT as an option   |
+++
+|RTE_BBDEV_FFT_WINDOWING_BYPASS  |
+| Set to bypass the time domain windowing  as an option  |
+++
+|RTE_BBDEV_FFT_POWER_MEAS|
+| Set to provide an optional power measurement of the DFT output |
+++
+|RTE_BBDEV_FFT_FP16_INPUT|
+| Set if the input data shall use FP16 format instead of INT16   |
+++
+|RTE_BBDEV_FFT_FP16_OUTPUT   |
+| Set if the output data shall use FP16 format instead of INT16  |
+++
+
+The structure passed for each FFT operation is given below,
+with the operation flags forming a bitmask in the ``op_flags`` field.
+
+.. code-block:: c
+
+struct rte_bbdev_op_fft {
+struct rte_bbdev_op_data base_input;
+struct rte_bbdev_op_data base_output;
+struct rte_bbdev_op_data power_meas_output;
+uint32_t op_flags;
+uint16_t input_sequence_size;
+uint16_t input_leading_padding;
+uint16_t output_sequence_size;
+uint16_t output_leading_depadding;
+uint8_t window_index[RTE_BBDEV_MAX_CS_2];
+uint16_t cs_bitmap;
+uint8_t num_antennas_log2;
+uint8_t idft_log2;
+uint8_t dft_log2;
+int8_t cs_time_adjustment;
+int8_t idft_shift;
+int8_t dft_shift;
+uint16_t ncs_reciprocal;
+uint16_t power_shift;
+uint16_t fp16_exp_adjust;
+};
+
+The FFT parameters are set out in the table below.
+
++-+-

[PATCH v6 6/7] bbdev: add queue related warning and status information

[Nicolas Chautru]

This allows to expose more information with regards to any
queue related failure and warning which cannot be supported
in existing API.

Signed-off-by: Nicolas Chautru 
---
 app/test-bbdev/test_bbdev_perf.c |  2 ++
 lib/bbdev/rte_bbdev.c| 19 +++
 lib/bbdev/rte_bbdev.h| 34 ++
 lib/bbdev/version.map|  1 +
 4 files changed, 56 insertions(+)

diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c
index 1abda2d..653b21f 100644
--- a/app/test-bbdev/test_bbdev_perf.c
+++ b/app/test-bbdev/test_bbdev_perf.c
@@ -4360,6 +4360,8 @@ typedef int (test_case_function)(struct active_device *ad,
stats->dequeued_count = q_stats->dequeued_count;
stats->enqueue_err_count = q_stats->enqueue_err_count;
stats->dequeue_err_count = q_stats->dequeue_err_count;
+   stats->enqueue_warning_count = q_stats->enqueue_warning_count;
+   stats->dequeue_warning_count = q_stats->dequeue_warning_count;
stats->acc_offload_cycles = q_stats->acc_offload_cycles;
 
return 0;
diff --git a/lib/bbdev/rte_bbdev.c b/lib/bbdev/rte_bbdev.c
index 9d65ba8..bdd7c2f 100644
--- a/lib/bbdev/rte_bbdev.c
+++ b/lib/bbdev/rte_bbdev.c
@@ -721,6 +721,8 @@ struct rte_bbdev *
stats->dequeued_count += q_stats->dequeued_count;
stats->enqueue_err_count += q_stats->enqueue_err_count;
stats->dequeue_err_count += q_stats->dequeue_err_count;
+   stats->enqueue_warn_count += q_stats->enqueue_warn_count;
+   stats->dequeue_warn_count += q_stats->dequeue_warn_count;
}
rte_bbdev_log_debug("Got stats on %u", dev->data->dev_id);
 }
@@ -1163,3 +1165,20 @@ struct rte_mempool *
rte_bbdev_log(ERR, "Invalid device status");
return NULL;
 }
+
+const char *
+rte_bbdev_enqueue_status_str(enum rte_bbdev_enqueue_status status)
+{
+   static const char * const enq_sta_string[] = {
+   "RTE_BBDEV_ENQ_STATUS_NONE",
+   "RTE_BBDEV_ENQ_STATUS_QUEUE_FULL",
+   "RTE_BBDEV_ENQ_STATUS_RING_FULL",
+   "RTE_BBDEV_ENQ_STATUS_INVALID_OP",
+   };
+
+   if (status < sizeof(enq_sta_string) / sizeof(char *))
+   return enq_sta_string[status];
+
+   rte_bbdev_log(ERR, "Invalid enqueue status");
+   return NULL;
+}
diff --git a/lib/bbdev/rte_bbdev.h b/lib/bbdev/rte_bbdev.h
index ed528b8..b7ecf94 100644
--- a/lib/bbdev/rte_bbdev.h
+++ b/lib/bbdev/rte_bbdev.h
@@ -224,6 +224,19 @@ struct rte_bbdev_queue_conf {
 rte_bbdev_queue_stop(uint16_t dev_id, uint16_t queue_id);
 
 /**
+ * Flags indicate the reason why a previous enqueue may not have
+ * consumed all requested operations
+ * In case of multiple reasons the latter superdes a previous one
+ */
+enum rte_bbdev_enqueue_status {
+   RTE_BBDEV_ENQ_STATUS_NONE, /**< Nothing to report */
+   RTE_BBDEV_ENQ_STATUS_QUEUE_FULL,   /**< Not enough room in queue */
+   RTE_BBDEV_ENQ_STATUS_RING_FULL,/**< Not enough room in ring */
+   RTE_BBDEV_ENQ_STATUS_INVALID_OP,   /**< Operation was rejected as 
invalid */
+   RTE_BBDEV_ENQ_STATUS_PADDED_MAX = 6,   /**< Maximum enq status number 
including padding */
+};
+
+/**
  * Flags indicate the status of the device
  */
 enum rte_bbdev_device_status {
@@ -246,6 +259,12 @@ struct rte_bbdev_stats {
uint64_t enqueue_err_count;
/** Total error count on operations dequeued */
uint64_t dequeue_err_count;
+   /** Total warning count on operations enqueued */
+   uint64_t enqueue_warn_count;
+   /** Total warning count on operations dequeued */
+   uint64_t dequeue_warn_count;
+   /** Total enqueue status count based on rte_bbdev_enqueue_status enum */
+   uint64_t enqueue_status_count[RTE_BBDEV_ENQ_STATUS_PADDED_MAX];
/** CPU cycles consumed by the (HW/SW) accelerator device to offload
 *  the enqueue request to its internal queues.
 *  - For a HW device this is the cycles consumed in MMIO write
@@ -386,6 +405,7 @@ struct rte_bbdev_queue_data {
void *queue_private;  /**< Driver-specific per-queue data */
struct rte_bbdev_queue_conf conf;  /**< Current configuration */
struct rte_bbdev_stats queue_stats;  /**< Queue statistics */
+   enum rte_bbdev_enqueue_status enqueue_status; /**< Enqueue status when 
op is rejected */
bool started;  /**< Queue state */
 };
 
@@ -938,6 +958,20 @@ typedef void (*rte_bbdev_cb_fn)(uint16_t dev_id,
 const char*
 rte_bbdev_device_status_str(enum rte_bbdev_device_status status);
 
+/**
+ * Converts queue status from enum to string
+ *
+ * @param status
+ *   Queue status as enum
+ *
+ * @returns
+ *  Queue status as string or NULL if op_type is invalid
+ *
+ */
+__rte_experimental
+const char*
+rte_bbdev_enqueue_status_str(enum rte_bbdev_enqueue_status status);
+
 #ifdef __cplusplus
 }
 #endif
diff --git a/lib/bbdev/

[PATCH v6 4/7] drivers/baseband: update PMDs to expose queue per operation

[Nicolas Chautru]

Add support in existing bbdev PMDs for the explicit number of queue
and priority for each operation type configured on the device.

Signed-off-by: Nicolas Chautru 
---
 drivers/baseband/acc100/rte_acc100_pmd.c   | 29 +-
 drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c |  8 ++
 drivers/baseband/fpga_lte_fec/fpga_lte_fec.c   |  8 ++
 drivers/baseband/la12xx/bbdev_la12xx.c |  7 ++
 drivers/baseband/turbo_sw/bbdev_turbo_software.c   | 11 
 5 files changed, 51 insertions(+), 12 deletions(-)

diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c 
b/drivers/baseband/acc100/rte_acc100_pmd.c
index 17ba798..f967e3f 100644
--- a/drivers/baseband/acc100/rte_acc100_pmd.c
+++ b/drivers/baseband/acc100/rte_acc100_pmd.c
@@ -966,6 +966,7 @@
struct rte_bbdev_driver_info *dev_info)
 {
struct acc100_device *d = dev->data->dev_private;
+   int i;
 
static const struct rte_bbdev_op_cap bbdev_capabilities[] = {
{
@@ -1062,19 +1063,23 @@
fetch_acc100_config(dev);
dev_info->device_status = RTE_BBDEV_DEV_NOT_SUPPORTED;
 
-   /* This isn't ideal because it reports the maximum number of queues but
-* does not provide info on how many can be uplink/downlink or different
-* priorities
-*/
-   dev_info->max_num_queues =
-   d->acc100_conf.q_dl_5g.num_aqs_per_groups *
-   d->acc100_conf.q_dl_5g.num_qgroups +
-   d->acc100_conf.q_ul_5g.num_aqs_per_groups *
-   d->acc100_conf.q_ul_5g.num_qgroups +
-   d->acc100_conf.q_dl_4g.num_aqs_per_groups *
-   d->acc100_conf.q_dl_4g.num_qgroups +
-   d->acc100_conf.q_ul_4g.num_aqs_per_groups *
+   /* Expose number of queues */
+   dev_info->num_queues[RTE_BBDEV_OP_NONE] = 0;
+   dev_info->num_queues[RTE_BBDEV_OP_TURBO_DEC] = 
d->acc100_conf.q_ul_4g.num_aqs_per_groups *
d->acc100_conf.q_ul_4g.num_qgroups;
+   dev_info->num_queues[RTE_BBDEV_OP_TURBO_ENC] = 
d->acc100_conf.q_dl_4g.num_aqs_per_groups *
+   d->acc100_conf.q_dl_4g.num_qgroups;
+   dev_info->num_queues[RTE_BBDEV_OP_LDPC_DEC] = 
d->acc100_conf.q_ul_5g.num_aqs_per_groups *
+   d->acc100_conf.q_ul_5g.num_qgroups;
+   dev_info->num_queues[RTE_BBDEV_OP_LDPC_ENC] = 
d->acc100_conf.q_dl_5g.num_aqs_per_groups *
+   d->acc100_conf.q_dl_5g.num_qgroups;
+   dev_info->queue_priority[RTE_BBDEV_OP_TURBO_DEC] = 
d->acc100_conf.q_ul_4g.num_qgroups;
+   dev_info->queue_priority[RTE_BBDEV_OP_TURBO_ENC] = 
d->acc100_conf.q_dl_4g.num_qgroups;
+   dev_info->queue_priority[RTE_BBDEV_OP_LDPC_DEC] = 
d->acc100_conf.q_ul_5g.num_qgroups;
+   dev_info->queue_priority[RTE_BBDEV_OP_LDPC_ENC] = 
d->acc100_conf.q_dl_5g.num_qgroups;
+   dev_info->max_num_queues = 0;
+   for (i = RTE_BBDEV_OP_TURBO_DEC; i <= RTE_BBDEV_OP_LDPC_ENC; i++)
+   dev_info->max_num_queues += dev_info->num_queues[i];
dev_info->queue_size_lim = ACC100_MAX_QUEUE_DEPTH;
dev_info->hardware_accelerated = true;
dev_info->max_dl_queue_priority =
diff --git a/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c 
b/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c
index 57b12af..b4982af 100644
--- a/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c
+++ b/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c
@@ -379,6 +379,14 @@
if (hw_q_id != FPGA_INVALID_HW_QUEUE_ID)
dev_info->max_num_queues++;
}
+   /* Expose number of queue per operation type */
+   dev_info->num_queues[RTE_BBDEV_OP_NONE] = 0;
+   dev_info->num_queues[RTE_BBDEV_OP_TURBO_DEC] = 0;
+   dev_info->num_queues[RTE_BBDEV_OP_TURBO_ENC] = 0;
+   dev_info->num_queues[RTE_BBDEV_OP_LDPC_DEC] = dev_info->max_num_queues 
/ 2;
+   dev_info->num_queues[RTE_BBDEV_OP_LDPC_ENC] = dev_info->max_num_queues 
/ 2;
+   dev_info->queue_priority[RTE_BBDEV_OP_LDPC_DEC] = 1;
+   dev_info->queue_priority[RTE_BBDEV_OP_LDPC_ENC] = 1;
 }
 
 /**
diff --git a/drivers/baseband/fpga_lte_fec/fpga_lte_fec.c 
b/drivers/baseband/fpga_lte_fec/fpga_lte_fec.c
index 2a330c4..dc7f479 100644
--- a/drivers/baseband/fpga_lte_fec/fpga_lte_fec.c
+++ b/drivers/baseband/fpga_lte_fec/fpga_lte_fec.c
@@ -655,6 +655,14 @@ struct __rte_cache_aligned fpga_queue {
if (hw_q_id != FPGA_INVALID_HW_QUEUE_ID)
dev_info->max_num_queues++;
}
+   /* Expose number of queue per operation type */
+   dev_info->num_queues[RTE_BBDEV_OP_NONE] = 0;
+   dev_info->num_queues[RTE_BBDEV_OP_TURBO_DEC] = dev_info->max_num_queues 
/ 2;
+   dev_info->num_queues[RTE_BBDEV_OP_TURBO_ENC] = dev_info->max_num_queues 
/ 2;
+   dev_info->num_queues[RTE_BBDEV_OP_LDPC_DEC] = 0;
+   dev_info->num_queues[RTE_BBDEV_OP_L

[PATCH v6 7/7] bbdev: remove unnecessary if-check

[Nicolas Chautru]

Code clean up due to if-check not required

Signed-off-by: Nicolas Chautru 
---
 lib/bbdev/rte_bbdev_op.h | 15 ---
 1 file changed, 4 insertions(+), 11 deletions(-)

diff --git a/lib/bbdev/rte_bbdev_op.h b/lib/bbdev/rte_bbdev_op.h
index afa1a71..386eed8 100644
--- a/lib/bbdev/rte_bbdev_op.h
+++ b/lib/bbdev/rte_bbdev_op.h
@@ -970,10 +970,8 @@ struct rte_mempool *
 
/* Get elements */
ret = rte_mempool_get_bulk(mempool, (void **)ops, num_ops);
-   if (unlikely(ret < 0))
-   return ret;
 
-   return 0;
+   return ret;
 }
 
 /**
@@ -1006,10 +1004,8 @@ struct rte_mempool *
 
/* Get elements */
ret = rte_mempool_get_bulk(mempool, (void **)ops, num_ops);
-   if (unlikely(ret < 0))
-   return ret;
 
-   return 0;
+   return ret;
 }
 
 /**
@@ -1035,17 +1031,14 @@ struct rte_mempool *
int ret;
 
/* Check type */
-   priv = (struct rte_bbdev_op_pool_private *)
-   rte_mempool_get_priv(mempool);
+   priv = (struct rte_bbdev_op_pool_private *) 
rte_mempool_get_priv(mempool);
if (unlikely(priv->type != RTE_BBDEV_OP_FFT))
return -EINVAL;
 
/* Get elements */
ret = rte_mempool_get_bulk(mempool, (void **)ops, num_ops);
-   if (unlikely(ret < 0))
-   return ret;
 
-   return 0;
+   return ret;
 }
 
 /**
-- 
1.8.3.1

[PATCH v3 0/4] eal: small rte_common.h fixes and cleanup

[Dmitry Kozlyuk]

v3: Fix build (CI).

v2:
* Extend and tidy up the macro unit test (Morten).
* Remove unneeded includes from rte_common.h (Morten, Bruce).

Dmitry Kozlyuk (4):
  eal: fix pointer arithmetic with an expression argument
  eal: deduplicate roundup code
  eal: uninline rte_str_to_size
  eal: remove unneeded includes from a public header

 app/test-bbdev/test_bbdev_vector.c|  1 +
 .../cperf_test_vector_parsing.c   |  1 +
 app/test-eventdev/parser.h|  1 +
 app/test-pmd/bpf_cmd.c|  2 +
 app/test-pmd/cmdline.c|  1 +
 app/test-pmd/cmdline_tm.c |  2 +
 app/test-pmd/config.c |  1 +
 app/test/test.h   |  2 +
 app/test/test_common.c| 58 +--
 drivers/bus/vdev/vdev_params.c|  1 +
 drivers/common/cnxk/cnxk_telemetry_nix.c  |  1 +
 drivers/common/cnxk/cnxk_telemetry_npa.c  |  1 +
 drivers/crypto/scheduler/scheduler_pmd.c  |  2 +
 drivers/net/cnxk/cnxk_ethdev_sec_telemetry.c  |  2 +
 drivers/net/i40e/i40e_ethdev.c|  1 +
 drivers/net/iavf/iavf_ethdev.c|  1 +
 drivers/net/ice/ice_ethdev.c  |  1 +
 drivers/net/softnic/parser.h  |  1 +
 examples/eventdev_pipeline/main.c |  1 +
 examples/fips_validation/fips_validation.c|  1 +
 examples/ip_pipeline/parser.h |  1 +
 examples/ipsec-secgw/parser.h |  1 +
 examples/l3fwd-power/perf_core.c  |  1 +
 examples/pipeline/cli.c   |  1 +
 examples/vhost/main.c |  1 +
 lib/dmadev/rte_dmadev.c   |  1 +
 lib/eal/common/eal_common_debug.c |  2 +
 lib/eal/common/eal_common_string_fns.c| 36 +++-
 lib/eal/freebsd/eal.c |  1 +
 lib/eal/include/generic/rte_rwlock.h  |  2 +
 lib/eal/include/rte_common.h  | 41 ++---
 lib/eal/linux/eal.c   |  1 +
 lib/eal/linux/eal_vfio_mp_sync.c  |  1 +
 lib/eal/unix/eal_unix_timer.c |  1 +
 lib/eal/version.map   |  1 +
 lib/eal/windows/rte_thread.c  |  2 +
 lib/ethdev/sff_telemetry.c|  1 +
 lib/eventdev/rte_event_eth_rx_adapter.c   |  1 +
 lib/eventdev/rte_event_timer_adapter.c|  1 +
 lib/meter/rte_meter.c |  1 +
 lib/pci/rte_pci.c |  1 +
 lib/pipeline/rte_swx_ctl.c|  1 +
 lib/sched/rte_pie.c   |  1 +
 lib/security/rte_security.c   |  2 +
 lib/telemetry/telemetry.c |  1 +
 lib/telemetry/telemetry_data.c|  3 +
 lib/telemetry/telemetry_legacy.c  |  2 +
 47 files changed, 136 insertions(+), 55 deletions(-)

-- 
2.33.1

[PATCH v3 1/4] eal: fix pointer arithmetic with an expression argument

[Dmitry Kozlyuk]

RTE_PTR_SUB(ptr, x) and RTE_PTR_ALIGN_FLOOR() worked incorrectly
if "ptr" was an expression:

uint32_t arr[3];

RTE_PTR_SUB(arr + 1, sizeof(arr[0]));
// expected: (uint32_t *)((uintptr_t)(arr + 1) - 4) == arr
// actual:   (uint32_t *)((uintptr_t) arr + 1  - 4) != arr

RTE_PTR_ALIGN_FLOOR(arr + 2, sizeof(arr[0]));
// expected: RTE_ALIGN_FLOOR((uintptr_t)(arr + 2), 4) == &arr[2]
// actual:   RTE_ALIGN_FLOOR((uintptr_t) arr + 2,  4) == &arr[0]

Fix the macros and extend the relevant unit test.
Convert uses of a custom test failure macro to RTE_TEST_ASSERT*().

Fixes: af75078fece3 ("first public release")
Cc: sta...@dpdk.org

Signed-off-by: Dmitry Kozlyuk 
Reviewed-by: Morten Brørup 
Acked-by: Bruce Richardson 
Acked-by: Chengwen Feng 
---
 app/test/test_common.c   | 58 +---
 lib/eal/include/rte_common.h |  4 +--
 2 files changed, 42 insertions(+), 20 deletions(-)

diff --git a/app/test/test_common.c b/app/test/test_common.c
index ef177cecb1..f89e1eb7ee 100644
--- a/app/test/test_common.c
+++ b/app/test/test_common.c
@@ -25,31 +25,53 @@ test_macros(int __rte_unused unused_parm)
 #define SMALLER 0x1000U
 #define BIGGER 0x2000U
 #define PTR_DIFF BIGGER - SMALLER
-#define FAIL_MACRO(x)\
-   {printf(#x "() test failed!\n");\
-   return -1;}
 
uintptr_t unused = 0;
unsigned int smaller = SMALLER, bigger  = BIGGER;
+   uint32_t arr[3];
 
RTE_SET_USED(unused);
 
RTE_SWAP(smaller, bigger);
-   if (smaller != BIGGER && bigger != SMALLER)
-   FAIL_MACRO(RTE_SWAP);
-   if ((uintptr_t)RTE_PTR_ADD(SMALLER, PTR_DIFF) != BIGGER)
-   FAIL_MACRO(RTE_PTR_ADD);
-   if ((uintptr_t)RTE_PTR_SUB(BIGGER, PTR_DIFF) != SMALLER)
-   FAIL_MACRO(RTE_PTR_SUB);
-   if (RTE_PTR_DIFF(BIGGER, SMALLER) != PTR_DIFF)
-   FAIL_MACRO(RTE_PTR_DIFF);
-   if (RTE_MAX(SMALLER, BIGGER) != BIGGER)
-   FAIL_MACRO(RTE_MAX);
-   if (RTE_MIN(SMALLER, BIGGER) != SMALLER)
-   FAIL_MACRO(RTE_MIN);
-
-   if (strncmp(RTE_STR(test), "test", sizeof("test")))
-   FAIL_MACRO(RTE_STR);
+   RTE_TEST_ASSERT(smaller == BIGGER && bigger == SMALLER,
+   "RTE_SWAP");
+   RTE_TEST_ASSERT_EQUAL((uintptr_t)RTE_PTR_ADD(SMALLER, PTR_DIFF), BIGGER,
+   "RTE_PTR_ADD");
+   RTE_TEST_ASSERT_EQUAL((uintptr_t)RTE_PTR_SUB(BIGGER, PTR_DIFF), SMALLER,
+   "RTE_PTR_SUB");
+   RTE_TEST_ASSERT_EQUAL(RTE_PTR_DIFF(BIGGER, SMALLER), PTR_DIFF,
+   "RTE_PTR_DIFF");
+   RTE_TEST_ASSERT_EQUAL(RTE_MAX(SMALLER, BIGGER), BIGGER,
+   "RTE_MAX");
+   RTE_TEST_ASSERT_EQUAL(RTE_MIN(SMALLER, BIGGER), SMALLER,
+   "RTE_MIN");
+
+   RTE_TEST_ASSERT_EQUAL(RTE_PTR_ADD(arr + 1, sizeof(arr[0])), &arr[2],
+   "RTE_PTR_ADD(expr, x)");
+   RTE_TEST_ASSERT_EQUAL(RTE_PTR_SUB(arr + 1, sizeof(arr[0])), &arr[0],
+   "RTE_PTR_SUB(expr, x)");
+   RTE_TEST_ASSERT_EQUAL(RTE_PTR_ALIGN_FLOOR(arr + 2, 4), &arr[2],
+   "RTE_PTR_ALIGN_FLOOR(expr, x)");
+   RTE_TEST_ASSERT_EQUAL(RTE_PTR_ALIGN_CEIL(arr + 2, 4), &arr[2],
+   "RTE_PTR_ALIGN_CEIL(expr, x)");
+   RTE_TEST_ASSERT_EQUAL(RTE_PTR_ALIGN(arr + 2, 4), &arr[2],
+   "RTE_PTR_ALIGN(expr, x)");
+
+   RTE_TEST_ASSERT_EQUAL(
+   RTE_PTR_ALIGN_FLOOR(RTE_PTR_ADD(&arr[1], 1), 4), &arr[1],
+   "RTE_PTR_ALIGN_FLOOR(x < y/2, y)");
+   RTE_TEST_ASSERT_EQUAL(
+   RTE_PTR_ALIGN_FLOOR(RTE_PTR_ADD(&arr[1], 3), 4), &arr[1],
+   "RTE_PTR_ALIGN_FLOOR(x > y/2, y)");
+   RTE_TEST_ASSERT_EQUAL(
+   RTE_PTR_ALIGN_CEIL(RTE_PTR_ADD(&arr[1], 3), 4), &arr[2],
+   "RTE_PTR_ALIGN_CEIL(x < y/2, y)");
+   RTE_TEST_ASSERT_EQUAL(
+   RTE_PTR_ALIGN_CEIL(RTE_PTR_ADD(&arr[1], 1), 4), &arr[2],
+   "RTE_PTR_ALIGN_CEIL(x > y/2, y)");
+
+   RTE_TEST_ASSERT(strncmp(RTE_STR(test), "test", sizeof("test")) == 0,
+   "RTE_STR");
 
return 0;
 }
diff --git a/lib/eal/include/rte_common.h b/lib/eal/include/rte_common.h
index a96cc2a138..d517e9f75f 100644
--- a/lib/eal/include/rte_common.h
+++ b/lib/eal/include/rte_common.h
@@ -295,7 +295,7 @@ static void __attribute__((destructor(RTE_PRIO(prio)), 
used)) func(void)
 /**
  * subtract a byte-value offset from a pointer
  */
-#define RTE_PTR_SUB(ptr, x) ((void*)((uintptr_t)ptr - (x)))
+#define RTE_PTR_SUB(ptr, x) ((void *)((uintptr_t)(ptr) - (x)))
 
 /**
  * get the difference between two pointer values, i.e. how far apart
@@ -320,7 +320,7 @@ static void __attribute__((destructor(RTE_PRIO(prio)), 
used)) func(void)
  * must be a power-of-two value.
  */
 #define RTE_PTR_ALIGN_FLOOR(ptr, align) \
-   ((typeof(ptr))RTE_ALIGN_FLOOR((uintptr_t)ptr, align))
+   ((typeof(ptr))RTE_ALIGN_FLOOR((uintptr_t)(ptr), align))
 
 /**
  * Macro to align a value t

[PATCH v3 2/4] eal: deduplicate roundup code

[Dmitry Kozlyuk]

RTE_CACHE_LINE_ROUNDUP() implementation repeated RTE_ALIGN_MUL_CEIL().
In other places RTE_CACHE_LINE_SIZE is assumed to be a power-of-2,
so define RTE_CACHE_LINE_ROUNDUP() using RTE_ALIGN_CEIL().

Signed-off-by: Dmitry Kozlyuk 
Reviewed-by: Morten Brørup 
Acked-by: Bruce Richardson 
Acked-by: Chengwen Feng 
---
 lib/eal/include/rte_common.h | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/lib/eal/include/rte_common.h b/lib/eal/include/rte_common.h
index d517e9f75f..b6bac6 100644
--- a/lib/eal/include/rte_common.h
+++ b/lib/eal/include/rte_common.h
@@ -425,9 +425,7 @@ rte_is_aligned(void *ptr, unsigned align)
 #define RTE_CACHE_LINE_MASK (RTE_CACHE_LINE_SIZE-1)
 
 /** Return the first cache-aligned value greater or equal to size. */
-#define RTE_CACHE_LINE_ROUNDUP(size) \
-   (RTE_CACHE_LINE_SIZE * ((size + RTE_CACHE_LINE_SIZE - 1) / \
-   RTE_CACHE_LINE_SIZE))
+#define RTE_CACHE_LINE_ROUNDUP(size) RTE_ALIGN_CEIL(size, RTE_CACHE_LINE_SIZE)
 
 /** Cache line size in terms of log2 */
 #if RTE_CACHE_LINE_SIZE == 64
-- 
2.33.1

[PATCH v3 3/4] eal: uninline rte_str_to_size

[Dmitry Kozlyuk]

There is no reason for rte_str_to_size() to be inline.
Move the implementation out of .
Export it as a stable ABI because it always has been public.

Signed-off-by: Dmitry Kozlyuk 
Acked-by: Morten Brørup 
Acked-by: Bruce Richardson 
Acked-by: Chengwen Feng 
---
 lib/eal/common/eal_common_string_fns.c | 32 ++
 lib/eal/include/rte_common.h   | 30 ++--
 lib/eal/version.map|  1 +
 3 files changed, 35 insertions(+), 28 deletions(-)

diff --git a/lib/eal/common/eal_common_string_fns.c 
b/lib/eal/common/eal_common_string_fns.c
index 0236ae4023..5fc4ee71dc 100644
--- a/lib/eal/common/eal_common_string_fns.c
+++ b/lib/eal/common/eal_common_string_fns.c
@@ -64,3 +64,35 @@ rte_strscpy(char *dst, const char *src, size_t dsize)
rte_errno = E2BIG;
return -rte_errno;
 }
+
+uint64_t
+rte_str_to_size(const char *str)
+{
+   char *endptr;
+   unsigned long long size;
+
+   while (isspace((int)*str))
+   str++;
+   if (*str == '-')
+   return 0;
+
+   errno = 0;
+   size = strtoull(str, &endptr, 0);
+   if (errno)
+   return 0;
+
+   if (*endptr == ' ')
+   endptr++; /* allow 1 space gap */
+
+   switch (*endptr) {
+   case 'G': case 'g':
+   size *= 1024; /* fall-through */
+   case 'M': case 'm':
+   size *= 1024; /* fall-through */
+   case 'K': case 'k':
+   size *= 1024; /* fall-through */
+   default:
+   break;
+   }
+   return size;
+}
diff --git a/lib/eal/include/rte_common.h b/lib/eal/include/rte_common.h
index b6bac6..86c50c55e0 100644
--- a/lib/eal/include/rte_common.h
+++ b/lib/eal/include/rte_common.h
@@ -873,34 +873,8 @@ rte_log2_u64(uint64_t v)
  * @return
  * Number.
  */
-static inline uint64_t
-rte_str_to_size(const char *str)
-{
-   char *endptr;
-   unsigned long long size;
-
-   while (isspace((int)*str))
-   str++;
-   if (*str == '-')
-   return 0;
-
-   errno = 0;
-   size = strtoull(str, &endptr, 0);
-   if (errno)
-   return 0;
-
-   if (*endptr == ' ')
-   endptr++; /* allow 1 space gap */
-
-   switch (*endptr){
-   case 'G': case 'g': size *= 1024; /* fall-through */
-   case 'M': case 'm': size *= 1024; /* fall-through */
-   case 'K': case 'k': size *= 1024; /* fall-through */
-   default:
-   break;
-   }
-   return size;
-}
+uint64_t
+rte_str_to_size(const char *str);
 
 /**
  * Function to terminate the application immediately, printing an error
diff --git a/lib/eal/version.map b/lib/eal/version.map
index 1f293e768b..773b0902c0 100644
--- a/lib/eal/version.map
+++ b/lib/eal/version.map
@@ -261,6 +261,7 @@ DPDK_23 {
rte_socket_id;
rte_socket_id_by_idx;
rte_srand;
+   rte_str_to_size;
rte_strerror;
rte_strscpy;
rte_strsplit;
-- 
2.33.1

[PATCH v3 4/4] eal: remove unneeded includes from a public header

[Dmitry Kozlyuk]

Do not include , , and  from ,
because they are not used by this file directly.
Include the needed headers directly from the files that need them.

Signed-off-by: Dmitry Kozlyuk 
---
 app/test-bbdev/test_bbdev_vector.c   | 1 +
 app/test-crypto-perf/cperf_test_vector_parsing.c | 1 +
 app/test-eventdev/parser.h   | 1 +
 app/test-pmd/bpf_cmd.c   | 2 ++
 app/test-pmd/cmdline.c   | 1 +
 app/test-pmd/cmdline_tm.c| 2 ++
 app/test-pmd/config.c| 1 +
 app/test/test.h  | 2 ++
 drivers/bus/vdev/vdev_params.c   | 1 +
 drivers/common/cnxk/cnxk_telemetry_nix.c | 1 +
 drivers/common/cnxk/cnxk_telemetry_npa.c | 1 +
 drivers/crypto/scheduler/scheduler_pmd.c | 2 ++
 drivers/net/cnxk/cnxk_ethdev_sec_telemetry.c | 2 ++
 drivers/net/i40e/i40e_ethdev.c   | 1 +
 drivers/net/iavf/iavf_ethdev.c   | 1 +
 drivers/net/ice/ice_ethdev.c | 1 +
 drivers/net/softnic/parser.h | 1 +
 examples/eventdev_pipeline/main.c| 1 +
 examples/fips_validation/fips_validation.c   | 1 +
 examples/ip_pipeline/parser.h| 1 +
 examples/ipsec-secgw/parser.h| 1 +
 examples/l3fwd-power/perf_core.c | 1 +
 examples/pipeline/cli.c  | 1 +
 examples/vhost/main.c| 1 +
 lib/dmadev/rte_dmadev.c  | 1 +
 lib/eal/common/eal_common_debug.c| 2 ++
 lib/eal/common/eal_common_string_fns.c   | 4 +++-
 lib/eal/freebsd/eal.c| 1 +
 lib/eal/include/generic/rte_rwlock.h | 2 ++
 lib/eal/include/rte_common.h | 3 ---
 lib/eal/linux/eal.c  | 1 +
 lib/eal/linux/eal_vfio_mp_sync.c | 1 +
 lib/eal/unix/eal_unix_timer.c| 1 +
 lib/eal/windows/rte_thread.c | 2 ++
 lib/ethdev/sff_telemetry.c   | 1 +
 lib/eventdev/rte_event_eth_rx_adapter.c  | 1 +
 lib/eventdev/rte_event_timer_adapter.c   | 1 +
 lib/meter/rte_meter.c| 1 +
 lib/pci/rte_pci.c| 1 +
 lib/pipeline/rte_swx_ctl.c   | 1 +
 lib/sched/rte_pie.c  | 1 +
 lib/security/rte_security.c  | 2 ++
 lib/telemetry/telemetry.c| 1 +
 lib/telemetry/telemetry_data.c   | 3 +++
 lib/telemetry/telemetry_legacy.c | 2 ++
 45 files changed, 58 insertions(+), 4 deletions(-)

diff --git a/app/test-bbdev/test_bbdev_vector.c 
b/app/test-bbdev/test_bbdev_vector.c
index f020836f88..5018397c46 100644
--- a/app/test-bbdev/test_bbdev_vector.c
+++ b/app/test-bbdev/test_bbdev_vector.c
@@ -5,6 +5,7 @@
 #ifdef RTE_EXEC_ENV_FREEBSD
#define _WITH_GETLINE
 #endif
+#include 
 #include 
 #include 
 #include 
diff --git a/app/test-crypto-perf/cperf_test_vector_parsing.c 
b/app/test-crypto-perf/cperf_test_vector_parsing.c
index 87f3a90055..2c9087b5f9 100644
--- a/app/test-crypto-perf/cperf_test_vector_parsing.c
+++ b/app/test-crypto-perf/cperf_test_vector_parsing.c
@@ -4,6 +4,7 @@
 #ifdef RTE_EXEC_ENV_FREEBSD
#define _WITH_GETLINE
 #endif
+#include 
 #include 
 
 #include 
diff --git a/app/test-eventdev/parser.h b/app/test-eventdev/parser.h
index 696b40a3e2..954371b5b8 100644
--- a/app/test-eventdev/parser.h
+++ b/app/test-eventdev/parser.h
@@ -5,6 +5,7 @@
 #ifndef __INCLUDE_PARSER_H__
 #define __INCLUDE_PARSER_H__
 
+#include 
 #include 
 
 #define PARSE_DELIMITER" \f\n\r\t\v"
diff --git a/app/test-pmd/bpf_cmd.c b/app/test-pmd/bpf_cmd.c
index 648e0e9294..46f6b7d6d2 100644
--- a/app/test-pmd/bpf_cmd.c
+++ b/app/test-pmd/bpf_cmd.c
@@ -2,7 +2,9 @@
  * Copyright(c) 2018 Intel Corporation
  */
 
+#include 
 #include 
+
 #include 
 #include 
 #include 
diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index b4fe9dfb17..07566c7a77 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -3,6 +3,7 @@
  * Copyright(c) 2014 6WIND S.A.
  */
 
+#include 
 #include 
 #include 
 #include 
diff --git a/app/test-pmd/cmdline_tm.c b/app/test-pmd/cmdline_tm.c
index fb56a234c5..1bc6c00998 100644
--- a/app/test-pmd/cmdline_tm.c
+++ b/app/test-pmd/cmdline_tm.c
@@ -2,6 +2,8 @@
  * Copyright(c) 2017 Intel Corporation
  */
 
+#include 
+
 #include 
 #include 
 #include 
diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index a2939867c4..86054455d2 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -3,6 +3,7 @@
  * Copyright 2013-2014 6WIND S.A.
  */
 
+#include 
 #include 
 #include 
 #include 
diff --git a/app/test/test.h b/app/test/test.h
index 7115edf469..85f57efbc6 100644
--- a/app/test/test.h
+++ b/app/

[PATCH v4] net/ice: refactor proto_ext to remove global variable

[Kevin Liu]

The ice has the feature to extract protocol fields into flex descriptor
by programming per queue. However, the dynamic field for proto_ext are
allocated by PMD, it is the responsibility of application to reserved
the field, before start DPDK.

Application with parse the offset and proto_ext name to PMD with devargs.
Remove related private API in 'rte_pmd_ice.h' and 'rte_pmd_ice.h' file.

Signed-off-by: Kevin Liu 

---
v2: Delete doc content related to 'rte_pmd_ice.h'.
---
v3: Delete doc content related to 'rte_pmd_ice.h'.
---
v4: refine code and change the check mode of dynamic field.
---
 doc/api/doxy-api-index.md |   1 -
 doc/api/doxy-api.conf.in  |   1 -
 doc/guides/nics/ice.rst   |  33 ++--
 drivers/net/ice/ice_ddp_package.c |   1 -
 drivers/net/ice/ice_ethdev.c  | 113 ++
 drivers/net/ice/ice_ethdev.h  |   7 +
 drivers/net/ice/ice_rxtx.c|  45 ++
 drivers/net/ice/ice_rxtx.h|   1 +
 drivers/net/ice/ice_testpmd.c |   2 +-
 drivers/net/ice/meson.build   |   2 -
 drivers/net/ice/rte_pmd_ice.h | 247 --
 drivers/net/ice/version.map   |   7 -
 12 files changed, 122 insertions(+), 338 deletions(-)
 delete mode 100644 drivers/net/ice/rte_pmd_ice.h

diff --git a/doc/api/doxy-api-index.md b/doc/api/doxy-api-index.md
index 186a258be4..e578800cea 100644
--- a/doc/api/doxy-api-index.md
+++ b/doc/api/doxy-api-index.md
@@ -44,7 +44,6 @@ The public API headers are grouped by topics:
   [KNI](@ref rte_kni.h),
   [ixgbe](@ref rte_pmd_ixgbe.h),
   [i40e](@ref rte_pmd_i40e.h),
-  [ice](@ref rte_pmd_ice.h),
   [iavf](@ref rte_pmd_iavf.h),
   [ioat](@ref rte_ioat_rawdev.h),
   [bnxt](@ref rte_pmd_bnxt.h),
diff --git a/doc/api/doxy-api.conf.in b/doc/api/doxy-api.conf.in
index 608494a7c0..6fab7436d7 100644
--- a/doc/api/doxy-api.conf.in
+++ b/doc/api/doxy-api.conf.in
@@ -18,7 +18,6 @@ INPUT   = @TOPDIR@/doc/api/doxy-api-index.md \
   @TOPDIR@/drivers/net/dpaa2 \
   @TOPDIR@/drivers/net/i40e \
   @TOPDIR@/drivers/net/iavf \
-  @TOPDIR@/drivers/net/ice \
   @TOPDIR@/drivers/net/ixgbe \
   @TOPDIR@/drivers/net/mlx5 \
   @TOPDIR@/drivers/net/softnic \
diff --git a/doc/guides/nics/ice.rst b/doc/guides/nics/ice.rst
index 6b903b9bbc..432c6fd7ed 100644
--- a/doc/guides/nics/ice.rst
+++ b/doc/guides/nics/ice.rst
@@ -110,29 +110,43 @@ Runtime Config Options
 
   The argument format is::
 
-  -a 18:00.0,proto_xtr=[...]
-  -a 18:00.0,proto_xtr=
+  
18:00.0,proto_xtr=[...],field_offs=, \
+  field_name=
+  18:00.0,proto_xtr=,field_offs=,field_name=
 
   Queues are grouped by ``(`` and ``)`` within the group. The ``-`` character
   is used as a range separator and ``,`` is used as a single number separator.
   The grouping ``()`` can be omitted for single element group. If no queues are
   specified, PMD will use this protocol extraction type for all queues.
+  ``field_offs`` is the offset of mbuf dynamic field for protocol extraction 
data.
+  ``field_name`` is the name of mbuf dynamic field for protocol extraction 
data.
+  ``field_offs`` and ``field_name`` will be checked whether it is valid. If it 
is invalid
+  the value needs to be reconfigured.
 
   Protocol is : ``vlan, ipv4, ipv6, ipv6_flow, tcp, ip_offset``.
 
   .. code-block:: console
 
-dpdk-testpmd -a 18:00.0,proto_xtr='[(1,2-3,8-9):tcp,10-13:vlan]'
+dpdk-testpmd -c 0xff -- -i
+port stop 0
+port detach 0
+port attach 
18:00.0,proto_xtr='[(1,2-3,8-9):tcp,10-13:vlan]',field_offs=92,field_name=pmd_dyn
 
   This setting means queues 1, 2-3, 8-9 are TCP extraction, queues 10-13 are
-  VLAN extraction, other queues run with no protocol extraction.
+  VLAN extraction, other queues run with no protocol extraction. The offset of 
mbuf
+  dynamic field is 92 for all queues with protocol extraction.
 
   .. code-block:: console
 
-dpdk-testpmd -a 
18:00.0,proto_xtr=vlan,proto_xtr='[(1,2-3,8-9):tcp,10-23:ipv6]'
+dpdk-testpmd -c 0xff -- -i
+port stop 0
+port detach 0
+port attach 
18:00.0,proto_xtr=vlan,proto_xtr='[(1,2-3,8-9):tcp,10-23:ipv6]', \
+field_offs=92,field_name=pmd_dyn
 
   This setting means queues 1, 2-3, 8-9 are TCP extraction, queues 10-23 are
-  IPv6 extraction, other queues use the default VLAN extraction.
+  IPv6 extraction, other queues use the default VLAN extraction. The offset of 
mbuf
+  dynamic field is 92 for all queues with protocol extraction.
 
   The extraction metadata is copied into the registered dynamic mbuf field, and
   the related dynamic mbuf flags is set.
@@ -211,13 +225,6 @@ Runtime Config Options
 
   IPHDR2 - Outer/Single IPv6 Header offset.
 
-  Use ``rte_net_ice_dynf_proto_xtr_metadata_get`` to access the protocol
-  extraction metadata, and use ``RTE_PKT_RX_DYNF_PROTO_XTR_*`` to get the
-  metadata 

RE: [PATCH 2/2] test/member: add functional and perf tests for sketch

[Rong, Leyi]

Hi Suanming,

The issues you've mentioned will be fixed in v2, thanks!

> -Original Message-
> From: Suanming Mou 
> Sent: Thursday, August 11, 2022 10:33 AM
> To: Rong, Leyi ; Wang, Yipeng1
> ; zaoxing...@gmail.com; Gobriel, Sameh
> 
> Cc: dev@dpdk.org
> Subject: RE: [PATCH 2/2] test/member: add functional and perf tests for sketch
> 
> Hi,
> 
> > -Original Message-
> > From: Leyi Rong 
> > Sent: Wednesday, August 10, 2022 3:45 PM
> > To: yipeng1.w...@intel.com; zaoxing...@gmail.com;
> > sameh.gobr...@intel.com
> > Cc: dev@dpdk.org; Leyi Rong 
> > Subject: [PATCH 2/2] test/member: add functional and perf tests for
> > sketch
> >
> > This patch adds functional and performance tests for sketch mode of
> > membership library.
> >
> > Signed-off-by: Yipeng Wang 
> > Signed-off-by: Leyi Rong 
> > ---
> >  app/test/test_member.c  | 258 
> >  app/test/test_member_perf.c | 153 -
> >  2 files changed, 407 insertions(+), 4 deletions(-)
> >
> > diff --git a/app/test/test_member.c b/app/test/test_member.c index
> > 26a712439f..abe59bb9f8 100644
> > --- a/app/test/test_member.c
> > +++ b/app/test/test_member.c
> > @@ -4,6 +4,7 @@
> >
> >  /* This test is for membership library's simple feature test */
> >
> > +#include 
> >  #include "test.h"
> >
> >  #include 
> > @@ -28,6 +29,7 @@ test_member(void)
> >  struct rte_member_setsum *setsum_ht;
> >  struct rte_member_setsum *setsum_cache;  struct rte_member_setsum
> > *setsum_vbf;
> > +struct rte_member_setsum *setsum_sketch;
> >
> >  /* 5-tuple key type */
> >  struct flow_key {
> > @@ -108,6 +110,21 @@ static struct rte_member_parameters params = {
> > .socket_id = 0  /* NUMA Socket ID for
> > memory. */
> >  };
> >
> > +/* for sketch definitions */
> > +#define TOP_K 10
> > +#define HH_PKT_SIZE 16
> > +#define SKETCH_ERROR_RATE 0.05
> > +#define SKETCH_SAMPLE_RATE 0.001
> > +#define PRINT_OUT_COUNT 20
> > +
> > +#define SKETCH_LARGEST_KEY_SIZE 100 #define SKETCH_TOTAL_KEY
> 500
> > +#define NUM_OF_KEY(key) {\
> > +   (unsigned int)ceil(SKETCH_LARGEST_KEY_SIZE / (key + 1)) \ }
> > +
> > +void *heavy_hitters[TOP_K];
> > +
> >  /*
> >   * Sequence of operations for find existing setsummary
> >   *
> > @@ -684,6 +701,243 @@ perform_free(void)
> > rte_member_free(setsum_vbf);
> >  }
> >
> > +static void
> > +print_out_sketch_results(uint64_t *count_result, member_set_t *heavy_set,
> > +uint32_t print_num, bool count_byte) {
> > +   uint32_t i;
> > +
> > +   for (i = 0; i < print_num; i++) {
> > +   if (count_byte)
> > +   printf("key %2u, count %8lu, real count %8u, "
> > +   "heavy_set %u, deviation rate [%.04f]\n",
> > +   i, count_result[i],
> > +   (unsigned int)ceil(SKETCH_LARGEST_KEY_SIZE /
> > (i + 1)) *
> > +   HH_PKT_SIZE,
> > +   heavy_set[i],
> > +   fabs((float)count_result[i] -
> > (float)NUM_OF_KEY(i) * HH_PKT_SIZE) /
> > +   ((float)NUM_OF_KEY(i) * HH_PKT_SIZE));
> > +   else
> > +   printf("key %2u, count %8lu, real count %8u, "
> > +   "heavy_set %u, deviation rate [%.04f]\n",
> > +   i, count_result[i],
> > +   (unsigned int)ceil(SKETCH_LARGEST_KEY_SIZE /
> > (i + 1)),
> > +   heavy_set[i],
> > +   fabs((float)count_result[i] -
> > (float)NUM_OF_KEY(i)) /
> > +   (float)NUM_OF_KEY(i));
> > +   }
> > +}
> > +
> > +static int
> > +sketch_test(uint32_t *keys, uint32_t total_pkt, int count_byte, int
> > +reset_test) {
> > +   uint32_t i;
> > +   uint64_t result_count[SKETCH_TOTAL_KEY];
> > +   member_set_t heavy_set[SKETCH_TOTAL_KEY];
> > +   uint64_t count[TOP_K];
> > +   int ret;
> > +   int hh_cnt;
> > +
> > +   setsum_sketch = rte_member_create(¶ms);
> > +   if (setsum_sketch == NULL) {
> > +   printf("Creation of setsums fail\n");
> > +   return -1;
> > +   }
> > +
> > +   for (i = 0; i < total_pkt; i++) {
> > +   if (count_byte)
> > +   ret = rte_member_add_byte_count(setsum_sketch,
> > &keys[i], HH_PKT_SIZE);
> > +   else
> > +   ret = rte_member_add(setsum_sketch, &keys[i], 1);
> > +
> > +   if (ret < 0) {
> > +   printf("rte_member_add Failed! Error [%d]\n", ret);
> 
> I'm afraid rte_member_free(setsum_sketch) is missing here.
> Same code below with "return -1;" should be checked.
> 
> > +
> > +   return -1;
> > +   }
> > +   }
> > +
> > +   for (i = 0; i < SKETCH_TOTAL_KEY; i++) {
> > +   uint32_t tmp_key = i;
> > +
> > +   rte_member_query_count(setsum_sketch, (void *)&tmp_key,
> > &result_count[i]);
> > +   rte_member_lookup(setsum

RE: [PATCH v4] net/ice: refactor proto_ext to remove global variable

[Ling, Jin]

Tested-by: Jin Ling 

-Original Message-
From: Kevin Liu  
Sent: 2022年8月26日 18:15
To: dev@dpdk.org
Cc: Yang, Qiming ; Zhang, Qi Z ; 
Yang, SteveX ; Liu, KevinX 
Subject: [PATCH v4] net/ice: refactor proto_ext to remove global variable

The ice has the feature to extract protocol fields into flex descriptor by 
programming per queue. However, the dynamic field for proto_ext are allocated 
by PMD, it is the responsibility of application to reserved the field, before 
start DPDK.

Application with parse the offset and proto_ext name to PMD with devargs.
Remove related private API in 'rte_pmd_ice.h' and 'rte_pmd_ice.h' file.

Signed-off-by: Kevin Liu 

---
v2: Delete doc content related to 'rte_pmd_ice.h'.
---
v3: Delete doc content related to 'rte_pmd_ice.h'.
---
v4: refine code and change the check mode of dynamic field.
---
 doc/api/doxy-api-index.md |   1 -
 doc/api/doxy-api.conf.in  |   1 -
 doc/guides/nics/ice.rst   |  33 ++--
 drivers/net/ice/ice_ddp_package.c |   1 -
 drivers/net/ice/ice_ethdev.c  | 113 ++
 drivers/net/ice/ice_ethdev.h  |   7 +
 drivers/net/ice/ice_rxtx.c|  45 ++
 drivers/net/ice/ice_rxtx.h|   1 +
 drivers/net/ice/ice_testpmd.c |   2 +-
 drivers/net/ice/meson.build   |   2 -
 drivers/net/ice/rte_pmd_ice.h | 247 --
 drivers/net/ice/version.map   |   7 -
 12 files changed, 122 insertions(+), 338 deletions(-)  delete mode 100644 
drivers/net/ice/rte_pmd_ice.h

diff --git a/doc/api/doxy-api-index.md b/doc/api/doxy-api-index.md index 
186a258be4..e578800cea 100644
--- a/doc/api/doxy-api-index.md
+++ b/doc/api/doxy-api-index.md
@@ -44,7 +44,6 @@ The public API headers are grouped by topics:
   [KNI](@ref rte_kni.h),
   [ixgbe](@ref rte_pmd_ixgbe.h),
   [i40e](@ref rte_pmd_i40e.h),
-  [ice](@ref rte_pmd_ice.h),
   [iavf](@ref rte_pmd_iavf.h),
   [ioat](@ref rte_ioat_rawdev.h),
   [bnxt](@ref rte_pmd_bnxt.h),
diff --git a/doc/api/doxy-api.conf.in b/doc/api/doxy-api.conf.in index 
608494a7c0..6fab7436d7 100644
--- a/doc/api/doxy-api.conf.in
+++ b/doc/api/doxy-api.conf.in
@@ -18,7 +18,6 @@ INPUT   = @TOPDIR@/doc/api/doxy-api-index.md \
   @TOPDIR@/drivers/net/dpaa2 \
   @TOPDIR@/drivers/net/i40e \
   @TOPDIR@/drivers/net/iavf \
-  @TOPDIR@/drivers/net/ice \
   @TOPDIR@/drivers/net/ixgbe \
   @TOPDIR@/drivers/net/mlx5 \
   @TOPDIR@/drivers/net/softnic \ diff --git 
a/doc/guides/nics/ice.rst b/doc/guides/nics/ice.rst index 
6b903b9bbc..432c6fd7ed 100644
--- a/doc/guides/nics/ice.rst
+++ b/doc/guides/nics/ice.rst
@@ -110,29 +110,43 @@ Runtime Config Options
 
   The argument format is::
 
-  -a 18:00.0,proto_xtr=[...]
-  -a 18:00.0,proto_xtr=
+  
18:00.0,proto_xtr=[...],field_offs=, \
+  field_name=
+  
+ 18:00.0,proto_xtr=,field_offs=,field_name=
 
   Queues are grouped by ``(`` and ``)`` within the group. The ``-`` character
   is used as a range separator and ``,`` is used as a single number separator.
   The grouping ``()`` can be omitted for single element group. If no queues are
   specified, PMD will use this protocol extraction type for all queues.
+  ``field_offs`` is the offset of mbuf dynamic field for protocol extraction 
data.
+  ``field_name`` is the name of mbuf dynamic field for protocol extraction 
data.
+  ``field_offs`` and ``field_name`` will be checked whether it is 
+ valid. If it is invalid  the value needs to be reconfigured.
 
   Protocol is : ``vlan, ipv4, ipv6, ipv6_flow, tcp, ip_offset``.
 
   .. code-block:: console
 
-dpdk-testpmd -a 18:00.0,proto_xtr='[(1,2-3,8-9):tcp,10-13:vlan]'
+dpdk-testpmd -c 0xff -- -i
+port stop 0
+port detach 0
+port attach 
+ 18:00.0,proto_xtr='[(1,2-3,8-9):tcp,10-13:vlan]',field_offs=92,field_n
+ ame=pmd_dyn
 
   This setting means queues 1, 2-3, 8-9 are TCP extraction, queues 10-13 are
-  VLAN extraction, other queues run with no protocol extraction.
+  VLAN extraction, other queues run with no protocol extraction. The 
+ offset of mbuf  dynamic field is 92 for all queues with protocol extraction.
 
   .. code-block:: console
 
-dpdk-testpmd -a 
18:00.0,proto_xtr=vlan,proto_xtr='[(1,2-3,8-9):tcp,10-23:ipv6]'
+dpdk-testpmd -c 0xff -- -i
+port stop 0
+port detach 0
+port attach 
18:00.0,proto_xtr=vlan,proto_xtr='[(1,2-3,8-9):tcp,10-23:ipv6]', \
+field_offs=92,field_name=pmd_dyn
 
   This setting means queues 1, 2-3, 8-9 are TCP extraction, queues 10-23 are
-  IPv6 extraction, other queues use the default VLAN extraction.
+  IPv6 extraction, other queues use the default VLAN extraction. The 
+ offset of mbuf  dynamic field is 92 for all queues with protocol extraction.
 
   The extraction metadata is copied into the registered dynamic mbuf field, and
   the related dynamic mbuf flags is

RE: [PATCH 1/2] member: implement NitroSketch mode

[Rong, Leyi]

> -Original Message-
> From: Ferruh Yigit 
> Sent: Tuesday, August 16, 2022 4:59 PM
> To: Rong, Leyi ; Wang, Yipeng1
> ; zaoxing...@gmail.com; Gobriel, Sameh
> 
> Cc: dev@dpdk.org
> Subject: Re: [PATCH 1/2] member: implement NitroSketch mode
> 
> On 8/10/2022 8:45 AM, Leyi Rong wrote:
> > Sketching algorithm provide high-fidelity approximate measurements and
> > appears as a promising alternative to traditional approches such as
> > packet sampling.
> >
> > NitroSketch [1] is a software sketching framework that optimizes
> > performance, provides accuracy guarantees, and supports a variety of
> > sketches.
> >
> > This commit adds a new data structure called sketch into membership
> > library. This new data structure is an efficient way to profile the
> > traffic for heavy hitters. Also use min-heap structure to maintain the
> > top-k flow keys.
> >
> > [1] Zaoxing Liu, Ran Ben-Basat, Gil Einziger, Yaron Kassner, Vladimir
> > Braverman, Roy Friedman, Vyas Sekar, "NitroSketch: Robust and General
> > Sketch-based Monitoring in Software Switches", in ACM SIGCOMM 2019.
> 
> Hi Leyi,
> 
> If there will be a new version, can you please put the link of the paper to 
> the
> commit log, for reference.

Hi Ferruh,

Sure! Will attach the link in v2. Thanks!

[PATCH v3] vhost: support CPU copy for small packets

[Wenwu Ma]

Offloading small packets to DMA degrades throughput 10%~20%,
and this is because DMA offloading is not free and DMA is not
good at processing small packets. In addition, control plane
packets are usually small, and assign those packets to DMA will
significantly increase latency, which may cause timeout like
TCP handshake packets. Therefore, this patch use CPU to perform
small copies in vhost.

Signed-off-by: Wenwu Ma 
---
v3:
* compare threshold with entire packet length
v2:
* fix CI build error
---
 lib/vhost/vhost.h  |  7 ++--
 lib/vhost/virtio_net.c | 72 --
 2 files changed, 61 insertions(+), 18 deletions(-)

diff --git a/lib/vhost/vhost.h b/lib/vhost/vhost.h
index 40fac3b7c6..8a7d90f737 100644
--- a/lib/vhost/vhost.h
+++ b/lib/vhost/vhost.h
@@ -142,8 +142,10 @@ struct virtqueue_stats {
  * iovec
  */
 struct vhost_iovec {
-   void *src_addr;
-   void *dst_addr;
+   void *src_iov_addr;
+   void *dst_iov_addr;
+   void *src_virt_addr;
+   void *dst_virt_addr;
size_t len;
 };
 
@@ -155,6 +157,7 @@ struct vhost_iov_iter {
struct vhost_iovec *iov;
/** number of iovec in this iterator */
unsigned long nr_segs;
+   unsigned long nr_len;
 };
 
 struct async_dma_vchan_info {
diff --git a/lib/vhost/virtio_net.c b/lib/vhost/virtio_net.c
index 35fa4670fd..2b18c908fd 100644
--- a/lib/vhost/virtio_net.c
+++ b/lib/vhost/virtio_net.c
@@ -26,6 +26,8 @@
 
 #define MAX_BATCH_LEN 256
 
+#define CPU_COPY_THRESHOLD_LEN 256
+
 static __rte_always_inline uint16_t
 async_poll_dequeue_completed(struct virtio_net *dev, struct vhost_virtqueue 
*vq,
struct rte_mbuf **pkts, uint16_t count, int16_t dma_id,
@@ -119,8 +121,8 @@ vhost_async_dma_transfer_one(struct virtio_net *dev, struct 
vhost_virtqueue *vq,
return -1;
 
for (i = 0; i < nr_segs; i++) {
-   copy_idx = rte_dma_copy(dma_id, vchan_id, 
(rte_iova_t)iov[i].src_addr,
-   (rte_iova_t)iov[i].dst_addr, iov[i].len, 
RTE_DMA_OP_FLAG_LLC);
+   copy_idx = rte_dma_copy(dma_id, vchan_id, 
(rte_iova_t)iov[i].src_iov_addr,
+   (rte_iova_t)iov[i].dst_iov_addr, iov[i].len, 
RTE_DMA_OP_FLAG_LLC);
/**
 * Since all memory is pinned and DMA vChannel
 * ring has enough space, failure should be a
@@ -149,6 +151,21 @@ vhost_async_dma_transfer_one(struct virtio_net *dev, 
struct vhost_virtqueue *vq,
return nr_segs;
 }
 
+static __rte_always_inline int64_t
+vhost_async_cpu_transfer_one(struct vhost_virtqueue *vq, uint16_t flag_idx,
+   struct vhost_iov_iter *pkt)
+{
+   struct vhost_iovec *iov = pkt->iov;
+   uint32_t nr_segs = pkt->nr_segs;
+
+   for (uint16_t i = 0; i < nr_segs; i++)
+   rte_memcpy(iov[i].dst_virt_addr, iov[i].src_virt_addr, 
iov[i].len);
+
+   vq->async->pkts_cmpl_flag[flag_idx] = true;
+
+   return 0;
+}
+
 static __rte_always_inline uint16_t
 vhost_async_dma_transfer(struct virtio_net *dev, struct vhost_virtqueue *vq,
int16_t dma_id, uint16_t vchan_id, uint16_t head_idx,
@@ -161,8 +178,13 @@ vhost_async_dma_transfer(struct virtio_net *dev, struct 
vhost_virtqueue *vq,
rte_spinlock_lock(&dma_info->dma_lock);
 
for (pkt_idx = 0; pkt_idx < nr_pkts; pkt_idx++) {
-   ret = vhost_async_dma_transfer_one(dev, vq, dma_id, vchan_id, 
head_idx,
-   &pkts[pkt_idx]);
+   if (pkts[pkt_idx].nr_len > CPU_COPY_THRESHOLD_LEN) {
+   ret = vhost_async_dma_transfer_one(dev, vq, dma_id, 
vchan_id, head_idx,
+   &pkts[pkt_idx]);
+   } else {
+   ret = vhost_async_cpu_transfer_one(vq, head_idx, 
&pkts[pkt_idx]);
+   }
+
if (unlikely(ret < 0))
break;
 
@@ -1002,13 +1024,14 @@ async_iter_initialize(struct virtio_net *dev, struct 
vhost_async *async)
iter = async->iov_iter + async->iter_idx;
iter->iov = async->iovec + async->iovec_idx;
iter->nr_segs = 0;
+   iter->nr_len = 0;
 
return 0;
 }
 
 static __rte_always_inline int
 async_iter_add_iovec(struct virtio_net *dev, struct vhost_async *async,
-   void *src, void *dst, size_t len)
+   void *src_iova, void *dst_iova, void *src_addr, void *dst_addr, 
size_t len)
 {
struct vhost_iov_iter *iter;
struct vhost_iovec *iovec;
@@ -1027,8 +1050,10 @@ async_iter_add_iovec(struct virtio_net *dev, struct 
vhost_async *async,
iter = async->iov_iter + async->iter_idx;
iovec = async->iovec + async->iovec_idx;
 
-   iovec->src_addr = src;
-   iovec->dst_addr = dst;
+   iovec->src_iov_addr = src_iova;
+   iovec->dst_iov_addr = dst_iova;
+   iovec->src_virt_addr = src_addr;
+   iovec->dst_virt_addr = dst_addr;
  

[PATCH] net/nfp: improve readability NFP HWINFO header

[Chaoyong He]

From: James Hershaw 

Prepend `0x` to the NFP HWINFO header value that is printed to improve
the readability of the printed statement.

Signed-off-by: James Hershaw 
Reviewed-by: Chaoyong He 
Reviewed-by: Niklas Söderlund 
---
 drivers/net/nfp/nfpcore/nfp_hwinfo.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/nfp/nfpcore/nfp_hwinfo.c 
b/drivers/net/nfp/nfpcore/nfp_hwinfo.c
index c0516bf..9f848bd 100644
--- a/drivers/net/nfp/nfpcore/nfp_hwinfo.c
+++ b/drivers/net/nfp/nfpcore/nfp_hwinfo.c
@@ -108,7 +108,7 @@
goto exit_free;
 
header = (void *)db;
-   printf("NFP HWINFO header: %08x\n", *(uint32_t *)header);
+   printf("NFP HWINFO header: %#08x\n", *(uint32_t *)header);
if (nfp_hwinfo_is_updating(header))
goto exit_free;
 
-- 
1.8.3.1

[PATCH] net/nfp: support Corigine PCIe ID for the nfp PMD

[Chaoyong He]

From: James Hershaw 

Previously the nfp driver as supported NFP chips with the Netronome PCIe
ID. This patch extends the PMD to also support NFP chips with the
Corigine PCIe vendor ID (0x1da8), which at this point are assumed to be
otherwise identical from a software perspective.

Signed-off-by: James Hershaw 
Reviewed-by: Niklas Söderlund 
---
 drivers/net/nfp/nfp_common.h|  2 ++
 drivers/net/nfp/nfp_ethdev.c| 12 
 drivers/net/nfp/nfp_ethdev_vf.c |  8 
 3 files changed, 22 insertions(+)

diff --git a/drivers/net/nfp/nfp_common.h b/drivers/net/nfp/nfp_common.h
index 6d917e4..6ceb7e9 100644
--- a/drivers/net/nfp/nfp_common.h
+++ b/drivers/net/nfp/nfp_common.h
@@ -16,6 +16,8 @@
 
 #define NFP_NET_PMD_VERSION "0.1"
 #define PCI_VENDOR_ID_NETRONOME 0x19ee
+#define PCI_VENDOR_ID_CORIGINE  0x1da8
+
 #define PCI_DEVICE_ID_NFP3800_PF_NIC0x3800
 #define PCI_DEVICE_ID_NFP3800_VF_NIC0x3803
 #define PCI_DEVICE_ID_NFP4000_PF_NIC0x4000
diff --git a/drivers/net/nfp/nfp_ethdev.c b/drivers/net/nfp/nfp_ethdev.c
index 5cdd34e..3ab82d3 100644
--- a/drivers/net/nfp/nfp_ethdev.c
+++ b/drivers/net/nfp/nfp_ethdev.c
@@ -1071,6 +1071,18 @@
   PCI_DEVICE_ID_NFP6000_PF_NIC)
},
{
+   RTE_PCI_DEVICE(PCI_VENDOR_ID_CORIGINE,
+  PCI_DEVICE_ID_NFP3800_PF_NIC)
+   },
+   {
+   RTE_PCI_DEVICE(PCI_VENDOR_ID_CORIGINE,
+  PCI_DEVICE_ID_NFP4000_PF_NIC)
+   },
+   {
+   RTE_PCI_DEVICE(PCI_VENDOR_ID_CORIGINE,
+  PCI_DEVICE_ID_NFP6000_PF_NIC)
+   },
+   {
.vendor_id = 0,
},
 };
diff --git a/drivers/net/nfp/nfp_ethdev_vf.c b/drivers/net/nfp/nfp_ethdev_vf.c
index d304d78..affea9d 100644
--- a/drivers/net/nfp/nfp_ethdev_vf.c
+++ b/drivers/net/nfp/nfp_ethdev_vf.c
@@ -505,6 +505,14 @@
   PCI_DEVICE_ID_NFP6000_VF_NIC)
},
{
+   RTE_PCI_DEVICE(PCI_VENDOR_ID_CORIGINE,
+  PCI_DEVICE_ID_NFP3800_VF_NIC)
+   },
+   {
+   RTE_PCI_DEVICE(PCI_VENDOR_ID_CORIGINE,
+  PCI_DEVICE_ID_NFP6000_VF_NIC)
+   },
+   {
.vendor_id = 0,
},
 };
-- 
1.8.3.1

[PATCH 0/2] upgrade the log system of nfp PMD

[Chaoyong He]

This patch series do some upgrade of the log system of nfp PMD:
Use DPDK debug macro to control the nfp Rx/Tx log.
Add the support of nfp cpp log macro.

Long Wu (2):
  net/nfp: add support for nfp cpp log print
  net/nfp: use dpdk debug macro to control nfp Rx/Tx log print

 drivers/net/nfp/nfp_common.c | 1 +
 drivers/net/nfp/nfp_logs.h   | 9 ++---
 2 files changed, 7 insertions(+), 3 deletions(-)

-- 
1.8.3.1

[PATCH 1/2] net/nfp: add support for nfp cpp log print

[Chaoyong He]

From: Long Wu 

Nfp cpp log print is not available before. Add support for cpp
print log and set its initial priority to "NOTICE".

Signed-off-by: Long Wu 
Reviewed-by: Chaoyong He 
Reviewed-by: Niklas Söderlund 
---
 drivers/net/nfp/nfp_common.c | 1 +
 drivers/net/nfp/nfp_logs.h   | 5 -
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/net/nfp/nfp_common.c b/drivers/net/nfp/nfp_common.c
index 0e55f0c..fd46c84 100644
--- a/drivers/net/nfp/nfp_common.c
+++ b/drivers/net/nfp/nfp_common.c
@@ -1372,6 +1372,7 @@
 
 RTE_LOG_REGISTER_SUFFIX(nfp_logtype_init, init, NOTICE);
 RTE_LOG_REGISTER_SUFFIX(nfp_logtype_driver, driver, NOTICE);
+RTE_LOG_REGISTER_SUFFIX(nfp_logtype_cpp, cpp, NOTICE);
 /*
  * Local variables:
  * c-file-style: "Linux"
diff --git a/drivers/net/nfp/nfp_logs.h b/drivers/net/nfp/nfp_logs.h
index cc49a15..e22df70 100644
--- a/drivers/net/nfp/nfp_logs.h
+++ b/drivers/net/nfp/nfp_logs.h
@@ -30,7 +30,10 @@
 #define ASSERT(x) do { } while (0)
 #endif
 
-#define PMD_CPP_LOG(level, fmt, args...) do { } while (0)
+extern int nfp_logtype_cpp;
+#define PMD_CPP_LOG(level, fmt, args...) \
+   rte_log(RTE_LOG_ ## level, nfp_logtype_cpp, \
+   "%s(): " fmt "\n", __func__, ## args)
 
 extern int nfp_logtype_driver;
 #define PMD_DRV_LOG(level, fmt, args...) \
-- 
1.8.3.1

[PATCH 2/2] net/nfp: use dpdk debug macro to control nfp Rx/Tx log print

[Chaoyong He]

From: Long Wu 

Nfp log print was controlled by nfp's own macro before. This
commit changes to use dpdk debug rx/tx macro to control it.

Signed-off-by: Long Wu 
Reviewed-by: Chaoyong He 
Reviewed-by: Niklas Söderlund 
---
 drivers/net/nfp/nfp_logs.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/nfp/nfp_logs.h b/drivers/net/nfp/nfp_logs.h
index e22df70..5da384e 100644
--- a/drivers/net/nfp/nfp_logs.h
+++ b/drivers/net/nfp/nfp_logs.h
@@ -14,14 +14,14 @@
"%s(): " fmt "\n", __func__, ## args)
 #define PMD_INIT_FUNC_TRACE() PMD_INIT_LOG(DEBUG, " >>")
 
-#ifdef RTE_LIBRTE_NFP_NET_DEBUG_RX
+#ifdef RTE_ETHDEV_DEBUG_RX
 #define PMD_RX_LOG(level, fmt, args...) \
RTE_LOG(level, PMD, "%s() rx: " fmt "\n", __func__, ## args)
 #else
 #define PMD_RX_LOG(level, fmt, args...) do { } while (0)
 #endif
 
-#ifdef RTE_LIBRTE_NFP_NET_DEBUG_TX
+#ifdef RTE_ETHDEV_DEBUG_TX
 #define PMD_TX_LOG(level, fmt, args...) \
RTE_LOG(level, PMD, "%s() tx: " fmt "\n", __func__, ## args)
 #define ASSERT(x) if (!(x)) rte_panic("NFP_NET: x")
-- 
1.8.3.1