There is no reason for rte_str_to_size() to be inline.
Move the implementation out of <rte_common.h>.
Export it as a stable ABI because it always has been public.

Signed-off-by: Dmitry Kozlyuk <dmitry.kozl...@gmail.com>
Acked-by: Morten Brørup <m...@smartsharesystems.com>
Acked-by: Bruce Richardson <bruce.richard...@intel.com>
Acked-by: Chengwen Feng <fengcheng...@huawei.com>
---
 lib/eal/common/eal_common_string_fns.c | 32 ++++++++++++++++++++++++++
 lib/eal/include/rte_common.h           | 30 ++----------------------
 lib/eal/version.map                    |  1 +
 3 files changed, 35 insertions(+), 28 deletions(-)

diff --git a/lib/eal/common/eal_common_string_fns.c 
b/lib/eal/common/eal_common_string_fns.c
index 0236ae4023..5fc4ee71dc 100644
--- a/lib/eal/common/eal_common_string_fns.c
+++ b/lib/eal/common/eal_common_string_fns.c
@@ -64,3 +64,35 @@ rte_strscpy(char *dst, const char *src, size_t dsize)
        rte_errno = E2BIG;
        return -rte_errno;
 }
+
+uint64_t
+rte_str_to_size(const char *str)
+{
+       char *endptr;
+       unsigned long long size;
+
+       while (isspace((int)*str))
+               str++;
+       if (*str == '-')
+               return 0;
+
+       errno = 0;
+       size = strtoull(str, &endptr, 0);
+       if (errno)
+               return 0;
+
+       if (*endptr == ' ')
+               endptr++; /* allow 1 space gap */
+
+       switch (*endptr) {
+       case 'G': case 'g':
+               size *= 1024; /* fall-through */
+       case 'M': case 'm':
+               size *= 1024; /* fall-through */
+       case 'K': case 'k':
+               size *= 1024; /* fall-through */
+       default:
+               break;
+       }
+       return size;
+}
diff --git a/lib/eal/include/rte_common.h b/lib/eal/include/rte_common.h
index b65555bac6..86c50c55e0 100644
--- a/lib/eal/include/rte_common.h
+++ b/lib/eal/include/rte_common.h
@@ -873,34 +873,8 @@ rte_log2_u64(uint64_t v)
  * @return
  *     Number.
  */
-static inline uint64_t
-rte_str_to_size(const char *str)
-{
-       char *endptr;
-       unsigned long long size;
-
-       while (isspace((int)*str))
-               str++;
-       if (*str == '-')
-               return 0;
-
-       errno = 0;
-       size = strtoull(str, &endptr, 0);
-       if (errno)
-               return 0;
-
-       if (*endptr == ' ')
-               endptr++; /* allow 1 space gap */
-
-       switch (*endptr){
-       case 'G': case 'g': size *= 1024; /* fall-through */
-       case 'M': case 'm': size *= 1024; /* fall-through */
-       case 'K': case 'k': size *= 1024; /* fall-through */
-       default:
-               break;
-       }
-       return size;
-}
+uint64_t
+rte_str_to_size(const char *str);
 
 /**
  * Function to terminate the application immediately, printing an error
diff --git a/lib/eal/version.map b/lib/eal/version.map
index 1f293e768b..773b0902c0 100644
--- a/lib/eal/version.map
+++ b/lib/eal/version.map
@@ -261,6 +261,7 @@ DPDK_23 {
        rte_socket_id;
        rte_socket_id_by_idx;
        rte_srand;
+       rte_str_to_size;
        rte_strerror;
        rte_strscpy;
        rte_strsplit;
-- 
2.33.1

Reply via email to