Re: 答复: [dpdk-dev] [PATCH] net/bonding: fix array overflow in Rx burst

[Ferruh Yigit]

On 7/20/2022 2:28 AM, humin (Q) wrote:

-----邮件原件-----
发件人: wangyunjian <wangyunj...@huawei.com>
发送时间: 2022年7月18日 21:09
收件人: dev@dpdk.org
抄送: ch...@att.com; humin (Q) <humi...@huawei.com>; Huangshaozhang 
<huangshaozh...@huawei.com>; jilei (F) <jil...@huawei.com>; wangyunjian 
<wangyunj...@huawei.com>; sta...@dpdk.org
主题: [dpdk-dev] [PATCH] net/bonding: fix array overflow in Rx burst

In bond_ethdev_rx_burst() function, we check the validity of the 'active_slave' 
as this code:
if (++active_slave == slave_count)
        active_slave = 0;
However, the value of 'active_slave' maybe equal to 'slave_count', when a slave 
is down. This is wrong and it can cause buffer overflow.
This patch fixes the issue by using '>=' instead of '=='.

Fixes: e1110e977648 ("net/bonding: fix Rx slave fairness")
Cc: sta...@dpdk.org

Signed-off-by: Lei Ji <jil...@huawei.com>
Signed-off-by: Yunjian Wang <wangyunj...@huawei.com>

>
> Acked-by: Min Hu (Connor) <humi...@huawei.com>
>

Applied to dpdk-next-net/main, thanks.