> From: Kevin Laatz [mailto:kevin.la...@intel.com] > Sent: Wednesday, 24 August 2022 18.25 > > Currently, there is no way to measure lcore busyness in a passive way, > without any modifications to the application. This patchset adds a new > EAL > API that will be able to passively track core busyness. As part of the > set, > new telemetry endpoints are added to read the generate metrics. > > Anatoly Burakov (2): > eal: add lcore poll busyness telemetry > eal: add cpuset lcore telemetry entries > > Kevin Laatz (1): > doc: add howto guide for lcore poll busyness >
At first glance, reading the commit messages, I thought you had ignored the feedback. However, I see that V2 adds "poll" in front of "busyness". It's just missing in many locations in the code, e.g. in eal_common_lcore_telemetry.c, the telemetry command is still registered as "/eal/lcore/busyness". I recommend that you search for "business" in the files, and add "poll" where it is missing. Perhaps one of your testers can do it for you... I know from experience that it can be difficult spotting details like this in your own code, whereas many test people are good at this stuff. There's even a company here in Denmark offering autistics as testers - they are absolutely brilliant at tasks like this! -Morten
