[dpdk-dev] [PATCH] net/mlx5: fix tci mask filter

[Nelio Laranjeiro]

In mlx5_traffic_enable() the TCI mask for the VLAN is wrong causing the
sub flow engine to reject the rule.

Fixes: 272733b5ebfd ("net/mlx5: use flow to enable unicast traffic")
Cc: sta...@dpdk.org

Signed-off-by: Nelio Laranjeiro 
---
 drivers/net/mlx5/mlx5_trigger.c | 10 --
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/drivers/net/mlx5/mlx5_trigger.c b/drivers/net/mlx5/mlx5_trigger.c
index 4d2078bbd..d02a626ae 100644
--- a/drivers/net/mlx5/mlx5_trigger.c
+++ b/drivers/net/mlx5/mlx5_trigger.c
@@ -300,9 +300,8 @@ mlx5_traffic_enable(struct rte_eth_dev *dev)
struct rte_flow_item_vlan vlan_spec = {
.tci = rte_cpu_to_be_16(vlan),
};
-   struct rte_flow_item_vlan vlan_mask = {
-   .tci = 0x,
-   };
+   struct rte_flow_item_vlan vlan_mask =
+   rte_flow_item_vlan_mask;
 
ret = mlx5_ctrl_flow_vlan(dev, &bcast, &bcast,
  &vlan_spec, &vlan_mask);
@@ -339,9 +338,8 @@ mlx5_traffic_enable(struct rte_eth_dev *dev)
struct rte_flow_item_vlan vlan_spec = {
.tci = rte_cpu_to_be_16(vlan),
};
-   struct rte_flow_item_vlan vlan_mask = {
-   .tci = 0x,
-   };
+   struct rte_flow_item_vlan vlan_mask =
+   rte_flow_item_vlan_mask;
 
ret = mlx5_ctrl_flow_vlan(dev, &unicast,
  &unicast_mask,
-- 
2.18.0

Re: [dpdk-dev] [PATCH] crypto/virtio: fix memory leak

[Zhoujian (jay)]

> -Original Message-
> From: Pablo de Lara [mailto:pablo.de.lara.gua...@intel.com]
> Sent: Thursday, July 19, 2018 5:06 PM
> To: Zhoujian (jay) 
> Cc: dev@dpdk.org; Pablo de Lara ;
> sta...@dpdk.org
> Subject: [PATCH] crypto/virtio: fix memory leak
> 
> Put session private data back to mempool when clearing a crypto session,
> which is expected to be done in the PMD.
> 
> Fixes: b7fa78c7d3b0 ("crypto/virtio: support session related ops")
> Cc: sta...@dpdk.org
> 
> Signed-off-by: Pablo de Lara 

Reviewed-by: Jay Zhou 

Re: [dpdk-dev] Patch compilation failure

[De Lara Guarch, Pablo]

Hi Qiaobin,

> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Fu, Qiaobin
> Sent: Saturday, July 21, 2018 7:58 PM
> To: dev@dpdk.org
> Cc: Fu, Qiaobin 
> Subject: [dpdk-dev] Patch compilation failure
> 
> Dear DPDK developers,
> 
> When I submitted a DPDK patch (http://patchwork.dpdk.org/patch/43090/),
> however, there is a compilation issue (http://mails.dpdk.org/archives/test-
> report/2018-July/060307.html).
> 
> When I tried to compile it in our local machine using the Target: 
> x86_64-native-
> linuxapp-gcc-shared, it shows that
> 
> make[1]: *** No rule to make target ‘~/dpdk/config/defconfig_x86_64-native-
> linuxapp-gcc-shared’
> 
> I checked the latest DPDK code, and it indeed doesn’t include the above target
> rule. I did some research online, however, I didn’t figure this out. Could you
> please help this?

You should use target "x86_64-native-linuxapp-gcc", enabling 
CONFIG_RTE_BUILD_SHARED_LIB in the config file.

Pablo

> 
> Thanks,
> Qiaobin

Re: [dpdk-dev] [PATCH] net/mlx5: fix compilation issues on old kernels

[Shahaf Shuler]

Sunday, July 15, 2018 8:32 PM, Mordechay Haimovsky:
> Subject: [PATCH] net/mlx5: fix compilation issues on old kernels
> 
> This commit fixes compilation errors due to missing definitions found when
> compiling mlx5 PMD from DPDK 17.11-LTS on Ubuntu 12.4 with kernel 3.15.
> 
> Fixes: 75ef62a94301 ("net/mlx5: fix link speed capability information")
> Fixes: 5bfc9fc112dd ("net/mlx5: use static assert for compile-time sanity
> checks")
> Cc: sta...@dpdk.org
> 
> Signed-off-by: Moti Haimovsky 

Acked-by: Shahaf Shuler 

Applied to next-net-mlx, thanks.

> ---
>  drivers/net/mlx5/Makefile  | 45
> ++
>  drivers/net/mlx5/mlx5_defs.h   |  5 +
>  drivers/net/mlx5/mlx5_ethdev.c | 26 
>  3 files changed, 76 insertions(+)
> 
> diff --git a/drivers/net/mlx5/Makefile b/drivers/net/mlx5/Makefile index
> d86c6bb..156c130 100644
> --- a/drivers/net/mlx5/Makefile
> +++ b/drivers/net/mlx5/Makefile
> @@ -197,6 +197,51 @@ mlx5_autoconf.h.new: $(RTE_SDK)/buildtools/auto-
> config-h.sh
>   linux/if_link.h \
>   enum IFLA_PHYS_PORT_NAME \
>   $(AUTOCONF_OUTPUT)
> + $Q sh -- '$<' '$@' \
> + HAVE_SUPPORTED_4baseKR4_Full \
> + /usr/include/linux/ethtool.h \
> + define SUPPORTED_4baseKR4_Full \
> + $(AUTOCONF_OUTPUT)
> + $Q sh -- '$<' '$@' \
> + HAVE_SUPPORTED_4baseCR4_Full \
> + /usr/include/linux/ethtool.h \
> + define SUPPORTED_4baseCR4_Full \
> + $(AUTOCONF_OUTPUT)
> + $Q sh -- '$<' '$@' \
> + HAVE_SUPPORTED_4baseSR4_Full \
> + /usr/include/linux/ethtool.h \
> + define SUPPORTED_4baseSR4_Full \
> + $(AUTOCONF_OUTPUT)
> + $Q sh -- '$<' '$@' \
> + HAVE_SUPPORTED_4baseLR4_Full \
> + /usr/include/linux/ethtool.h \
> + define SUPPORTED_4baseLR4_Full \
> + $(AUTOCONF_OUTPUT)
> + $Q sh -- '$<' '$@' \
> + HAVE_SUPPORTED_56000baseKR4_Full \
> + /usr/include/linux/ethtool.h \
> + define SUPPORTED_56000baseKR4_Full \
> + $(AUTOCONF_OUTPUT)
> + $Q sh -- '$<' '$@' \
> + HAVE_SUPPORTED_56000baseCR4_Full \
> + /usr/include/linux/ethtool.h \
> + define SUPPORTED_56000baseCR4_Full \
> + $(AUTOCONF_OUTPUT)
> + $Q sh -- '$<' '$@' \
> + HAVE_SUPPORTED_56000baseSR4_Full \
> + /usr/include/linux/ethtool.h \
> + define SUPPORTED_56000baseSR4_Full \
> + $(AUTOCONF_OUTPUT)
> + $Q sh -- '$<' '$@' \
> + HAVE_SUPPORTED_56000baseLR4_Full \
> + /usr/include/linux/ethtool.h \
> + define SUPPORTED_56000baseLR4_Full \
> + $(AUTOCONF_OUTPUT)
> + $Q sh -- '$<' '$@' \
> + HAVE_STATIC_ASSERT \
> + /usr/include/assert.h \
> + define static_assert \
> + $(AUTOCONF_OUTPUT)
> 
>  # Create mlx5_autoconf.h or update it in case it differs from the new one.
> 
> diff --git a/drivers/net/mlx5/mlx5_defs.h b/drivers/net/mlx5/mlx5_defs.h
> index f6ec415..439cc15 100644
> --- a/drivers/net/mlx5/mlx5_defs.h
> +++ b/drivers/net/mlx5/mlx5_defs.h
> @@ -128,4 +128,9 @@
>  /* Cache size of mempool for Multi-Packet RQ. */  #define
> MLX5_MPRQ_MP_CACHE_SZ 32
> 
> +/* Definition of static_assert found in /usr/include/assert.h */
> +#ifndef HAVE_STATIC_ASSERT #define static_assert _Static_assert #endif
> +
>  #endif /* RTE_PMD_MLX5_DEFS_H_ */
> diff --git a/drivers/net/mlx5/mlx5_ethdev.c
> b/drivers/net/mlx5/mlx5_ethdev.c index 6e44d5f..4b2231f 100644
> --- a/drivers/net/mlx5/mlx5_ethdev.c
> +++ b/drivers/net/mlx5/mlx5_ethdev.c
> @@ -42,6 +42,32 @@
>  #include "mlx5_rxtx.h"
>  #include "mlx5_utils.h"
> 
> +/* Supported speed values found in /usr/include/linux/ethtool.h */
> +#ifndef HAVE_SUPPORTED_4baseKR4_Full #define
> +SUPPORTED_4baseKR4_Full (1 << 23) #endif #ifndef
> +HAVE_SUPPORTED_4baseCR4_Full #define
> SUPPORTED_4baseCR4_Full (1
> +<< 24) #endif #ifndef HAVE_SUPPORTED_4baseSR4_Full #define
> +SUPPORTED_4baseSR4_Full (1 << 25) #endif #ifndef
> +HAVE_SUPPORTED_4baseLR4_Full #define
> SUPPORTED_4baseLR4_Full (1
> +<< 26) #endif #ifndef HAVE_SUPPORTED_56000baseKR4_Full #define
> +SUPPORTED_56000baseKR4_Full (1 << 27) #endif #ifndef
> +HAVE_SUPPORTED_56000baseCR4_Full #define
> SUPPORTED_56000baseCR4_Full (1
> +<< 28) #endif #ifndef HAVE_SUPPORTED_56000baseSR4_Full #define
> +SUPPORTED_56000baseSR4_Full (1 << 29) #endif #ifndef
> +HAVE_SUPPORTED_56000baseLR4_Full #define
> SUPPORTED_56000baseLR4_Full (1
> +<< 30) #endif
> +
>  /* Add defines in case the running kernel is not the same as user headers. */
> #ifndef ETHTOOL_GLINKSETTINGS  struct ethtool_link_settings {
> --
> 1.8.3.1

Re: [dpdk-dev] [PATCH] crypto/aesni_mb: call buffer manager allocation

[De Lara Guarch, Pablo]

> -Original Message-
> From: De Lara Guarch, Pablo
> Sent: Tuesday, July 3, 2018 6:58 AM
> To: Doherty, Declan 
> Cc: dev@dpdk.org; De Lara Guarch, Pablo 
> Subject: [PATCH] crypto/aesni_mb: call buffer manager allocation
> 
> Instead of having a static field for the buffer manager MB_MGR in the queue
> pair structure, use the provided API that allocates memory for it and store a
> pointer to it.
> 
> Signed-off-by: Pablo de Lara 

Applied to dpdk-next-crypto.

Pablo

Re: [dpdk-dev] [PATCH] crypto/aesni_gcm: support IPsec Multi-buffer lib v0.50

[De Lara Guarch, Pablo]

> -Original Message-
> From: De Lara Guarch, Pablo
> Sent: Tuesday, July 3, 2018 9:22 AM
> To: Doherty, Declan 
> Cc: dev@dpdk.org; De Lara Guarch, Pablo 
> Subject: [PATCH] crypto/aesni_gcm: support IPsec Multi-buffer lib v0.50
> 
> Adds support for the v0.50 of the IPsec Multi-buffer lib.
> The library now exposes its version, with the idea of maintaining backwards
> compatibility in the future, avoiding breaking the compilation of the PMD 
> every
> time there is a new version available.
> 
> Signed-off-by: Pablo de Lara 

Applied to dpdk-next-crypto.

Pablo

Re: [dpdk-dev] [PATCH] crypto/aesni_mb: support IPsec Multi-buffer lib v0.50

[De Lara Guarch, Pablo]

> -Original Message-
> From: De Lara Guarch, Pablo
> Sent: Tuesday, July 3, 2018 9:23 AM
> To: Doherty, Declan 
> Cc: dev@dpdk.org; De Lara Guarch, Pablo 
> Subject: [PATCH] crypto/aesni_mb: support IPsec Multi-buffer lib v0.50
> 
> Adds support for the v0.50 of the IPsec Multi-buffer lib.
> The library now exposes its version, with the idea of maintaining backwards
> compatibility in the future, avoiding breaking the compilation of the PMD 
> every
> time there is a new version available.
> 
> Signed-off-by: Pablo de Lara 

Applied to dpdk-next-crypto.

Pablo

Re: [dpdk-dev] Patch compilation failure

[Burakov, Anatoly]

On 23-Jul-18 8:57 AM, De Lara Guarch, Pablo wrote:

Hi Qiaobin,


-Original Message-
From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Fu, Qiaobin
Sent: Saturday, July 21, 2018 7:58 PM
To: dev@dpdk.org
Cc: Fu, Qiaobin 
Subject: [dpdk-dev] Patch compilation failure

Dear DPDK developers,

When I submitted a DPDK patch (http://patchwork.dpdk.org/patch/43090/),
however, there is a compilation issue (http://mails.dpdk.org/archives/test-
report/2018-July/060307.html).

When I tried to compile it in our local machine using the Target: x86_64-native-
linuxapp-gcc-shared, it shows that

make[1]: *** No rule to make target ‘~/dpdk/config/defconfig_x86_64-native-
linuxapp-gcc-shared’

I checked the latest DPDK code, and it indeed doesn’t include the above target
rule. I did some research online, however, I didn’t figure this out. Could you
please help this?


You should use target "x86_64-native-linuxapp-gcc", enabling
CONFIG_RTE_BUILD_SHARED_LIB in the config file.


Should this information be something we include in the CI email?



Pablo



Thanks,
Qiaobin



--
Thanks,
Anatoly

Re: [dpdk-dev] [PATCH v1] crypto/aesni_mb: support 3DES

[De Lara Guarch, Pablo]

> -Original Message-
> From: Kovacevic, Marko
> Sent: Friday, June 8, 2018 10:10 AM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo ; Jain, Deepak K
> ; Kovacevic, Marko 
> Subject: [PATCH v1] crypto/aesni_mb: support 3DES
> 
> From: Marko Kovacevic 
> 
> Added support for 3DES cipher algorithm which will support 8, 16 and 24 byte
> keys, which also has been added in the v0.50 of the IPSec Multi-buffer lib.
> 
> Signed-off-by: Marko Kovacevic 

Acked-by: Pablo de Lara 

Re: [dpdk-dev] [PATCH v1] crypto/openssl: add support for 8 byte 3DES

[De Lara Guarch, Pablo]

> -Original Message-
> From: Kovacevic, Marko
> Sent: Tuesday, June 12, 2018 11:39 AM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo ; Jain, Deepak K
> ; Kovacevic, Marko ;
> Marko
> Subject: [PATCH v1] crypto/openssl: add support for 8 byte 3DES
> 
> Added extra case to support 8 byte key size for 3DES CBC. Also changed
> capabilities to reflect the change.
> 
> Signed-off-by: Marko, Kovacevic 

Acked-by: Pablo de Lara 

Re: [dpdk-dev] [PATCH v3] crypto/qat: add support for 8 byte 3DES

[De Lara Guarch, Pablo]

> -Original Message-
> From: Trahe, Fiona
> Sent: Friday, July 20, 2018 7:49 PM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo ; Trahe, Fiona
> ; Kovacevic, Marko 
> Subject: [PATCH v3] crypto/qat: add support for 8 byte 3DES
> 
> Added extra case to support 8 byte key size for 3DES CBC. Also changed
> capabilities to reflect the change.
> 
> Signed-off-by: Marko Kovacevic 
> Signed-off-by: Fiona Trahe 

Acked-by: Pablo de Lara 

Re: [dpdk-dev] [PATCH v1] crypto/openssl: add support for 8 byte 3DES

[De Lara Guarch, Pablo]

> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of De Lara Guarch, Pablo
> Sent: Monday, July 23, 2018 9:50 AM
> To: Kovacevic, Marko ; dev@dpdk.org
> Cc: Jain, Deepak K ; Kovacevic, Marko
> 
> Subject: Re: [dpdk-dev] [PATCH v1] crypto/openssl: add support for 8 byte 3DES
> 
> 
> 
> > -Original Message-
> > From: Kovacevic, Marko
> > Sent: Tuesday, June 12, 2018 11:39 AM
> > To: dev@dpdk.org
> > Cc: De Lara Guarch, Pablo ; Jain,
> > Deepak K ; Kovacevic, Marko
> > ; Marko
> > Subject: [PATCH v1] crypto/openssl: add support for 8 byte 3DES
> >
> > Added extra case to support 8 byte key size for 3DES CBC. Also changed
> > capabilities to reflect the change.
> >
> > Signed-off-by: Marko, Kovacevic 
> 
> Acked-by: Pablo de Lara 

Applied to dpdk-next-crypto.
Thanks,

Pablo

Re: [dpdk-dev] [PATCH v1] crypto/aesni_mb: support 3DES

[De Lara Guarch, Pablo]

> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of De Lara Guarch, Pablo
> Sent: Monday, July 23, 2018 9:49 AM
> To: Kovacevic, Marko ; dev@dpdk.org
> Cc: Jain, Deepak K 
> Subject: Re: [dpdk-dev] [PATCH v1] crypto/aesni_mb: support 3DES
> 
> 
> 
> > -Original Message-
> > From: Kovacevic, Marko
> > Sent: Friday, June 8, 2018 10:10 AM
> > To: dev@dpdk.org
> > Cc: De Lara Guarch, Pablo ; Jain,
> > Deepak K ; Kovacevic, Marko
> > 
> > Subject: [PATCH v1] crypto/aesni_mb: support 3DES
> >
> > From: Marko Kovacevic 
> >
> > Added support for 3DES cipher algorithm which will support 8, 16 and
> > 24 byte keys, which also has been added in the v0.50 of the IPSec 
> > Multi-buffer
> lib.
> >
> > Signed-off-by: Marko Kovacevic 
> 
> Acked-by: Pablo de Lara 

Applied to dpdk-next-crypto.
Thanks,

Pablo

Re: [dpdk-dev] [PATCH v3] crypto/qat: add support for 8 byte 3DES

[De Lara Guarch, Pablo]

> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of De Lara Guarch, Pablo
> Sent: Monday, July 23, 2018 9:55 AM
> To: Trahe, Fiona ; dev@dpdk.org
> Cc: Kovacevic, Marko 
> Subject: Re: [dpdk-dev] [PATCH v3] crypto/qat: add support for 8 byte 3DES
> 
> 
> 
> > -Original Message-
> > From: Trahe, Fiona
> > Sent: Friday, July 20, 2018 7:49 PM
> > To: dev@dpdk.org
> > Cc: De Lara Guarch, Pablo ; Trahe,
> > Fiona ; Kovacevic, Marko
> > 
> > Subject: [PATCH v3] crypto/qat: add support for 8 byte 3DES
> >
> > Added extra case to support 8 byte key size for 3DES CBC. Also changed
> > capabilities to reflect the change.
> >
> > Signed-off-by: Marko Kovacevic 
> > Signed-off-by: Fiona Trahe 
> 
> Acked-by: Pablo de Lara 

Applied to dpdk-next-crypto.
Thanks,

Pablo

Re: [dpdk-dev] [PATCH] crypto/virtio: fix memory leak

[De Lara Guarch, Pablo]

> -Original Message-
> From: Zhoujian (jay) [mailto:jianjay.z...@huawei.com]
> Sent: Monday, July 23, 2018 8:45 AM
> To: De Lara Guarch, Pablo 
> Cc: dev@dpdk.org; sta...@dpdk.org; wangxin (U)
> 
> Subject: RE: [PATCH] crypto/virtio: fix memory leak
> 
> > -Original Message-
> > From: Pablo de Lara [mailto:pablo.de.lara.gua...@intel.com]
> > Sent: Thursday, July 19, 2018 5:06 PM
> > To: Zhoujian (jay) 
> > Cc: dev@dpdk.org; Pablo de Lara ;
> > sta...@dpdk.org
> > Subject: [PATCH] crypto/virtio: fix memory leak
> >
> > Put session private data back to mempool when clearing a crypto
> > session, which is expected to be done in the PMD.
> >
> > Fixes: b7fa78c7d3b0 ("crypto/virtio: support session related ops")
> > Cc: sta...@dpdk.org
> >
> > Signed-off-by: Pablo de Lara 
> 
> Reviewed-by: Jay Zhou 

Applied to dpdk-next-crypto.

Pablo

Re: [dpdk-dev] commit 0ad778b39 (app/testpmd: rework softnic forward mode) compromises testpmd CLI

[Singh, Jasvinder]

Hi Moti,

I didn't know about Ctrl+D option to quit testpmd  as I  always used  "quit" on 
cli. Since Ctrl+D was working before this commit, I will send fix soon to cover 
this case.

Thanks,
Jasvinder

From: Mordechay Haimovsky [mailto:mo...@mellanox.com]
Sent: Sunday, July 22, 2018 5:04 PM
To: Singh, Jasvinder ; Pattan, Reshma 
; Dumitrescu, Cristian 
Cc: dev@dpdk.org
Subject: commit 0ad778b39 (app/testpmd: rework softnic forward mode) 
compromises testpmd CLI

Hi,
When starting testpmd after applying the above patch and pressing CTRL+D in the 
command prompts, testpmd exits abnormally
Whit the following message :
PANIC in prompt():
CLI poll error (-1)
And a dump trace is displayed.

Issue is traced to the following section in your commit:
-   cmdline_interact(testpmd_cl);
-   cmdline_stdin_exit(testpmd_cl);
+
+   for (;;) {
+   status = cmdline_poll(testpmd_cl);
+   if (status < 0)
+   rte_panic("CLI poll error (%" PRId32 ")\n", status);
+   else if (status == RDLINE_EXITED) {
+   cmdline_stdin_exit(testpmd_cl);
+   rte_exit(0, "\n");
+   }

Which did not take into consideration the case of user pressing CTRL+D on an 
empty command line which returns -1 from cmdline_poll.

Please advise on a fix.

Thanks
Moti H.

[dpdk-dev] [PATCH] app/testpmd: fix testpmd exit using ctrl+d

[Jasvinder Singh]

Fix testpmd app exit by pressing ctrl+d, End-of-Transmission character (EOT)
on the empty command line.
 
Fixes: 0ad778b398c6 ("app/testpmd: rework softnic forward mode")

Reported-by: Mordechay Haimovsky 
Signed-off-by: Jasvinder Singh 
---
 app/test-pmd/cmdline.c   | 10 ++
 lib/librte_cmdline/cmdline.c |  2 +-
 2 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index 5885289..edaf0e6 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -17581,12 +17581,14 @@ prompt(void)
 
for (;;) {
status = cmdline_poll(testpmd_cl);
-   if (status < 0)
-   rte_panic("CLI poll error (%" PRId32 ")\n", status);
-   else if (status == RDLINE_EXITED) {
+   if (status == RDLINE_EXITED || status == RDLINE_RES_EOF) {
+   if (status == RDLINE_RES_EOF)
+   pmd_test_exit();
+
cmdline_stdin_exit(testpmd_cl);
rte_exit(0, "\n");
-   }
+   } else if (status < 0)
+   rte_panic("CLI poll error (%" PRId32 ")\n", status);
 
 #if defined RTE_LIBRTE_PMD_SOFTNIC
 
diff --git a/lib/librte_cmdline/cmdline.c b/lib/librte_cmdline/cmdline.c
index 591b78b..47b0f6a 100644
--- a/lib/librte_cmdline/cmdline.c
+++ b/lib/librte_cmdline/cmdline.c
@@ -187,7 +187,7 @@ cmdline_in(struct cmdline *cl, const char *buf, int size)
rdline_newline(&cl->rdl, cl->prompt);
}
else if (ret == RDLINE_RES_EOF)
-   return -1;
+   return RDLINE_RES_EOF;
else if (ret == RDLINE_RES_EXITED)
return -1;
}
-- 
2.9.3

[dpdk-dev] [PATCH] doc: fix incorrect create bonding command in testpmd

[Shreyansh Jain]

Fixes: e76d7a768ce0 ("doc: fix syntax in testpmd user guide")
Cc: john.mcnam...@intel.com
Cc: sta...@dpdk.org

Signed-off-by: Shreyansh Jain 
---
Note: Though the git blame suggest e76d7a768c as the last modification
  for fixes, this actually existed when testpmd doc was added.

 doc/guides/testpmd_app_ug/testpmd_funcs.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst 
b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
index 1d6bdf9b3..16af95035 100644
--- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
+++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
@@ -1993,7 +1993,7 @@ Create a new bonding device::
 
 For example, to create a bonded device in mode 1 on socket 0::
 
-   testpmd> create bonded 1 0
+   testpmd> create bonded device 1 0
created new bonded device (port X)
 
 add bonding slave
-- 
2.17.1

Re: [dpdk-dev] [PATCH] app/crypto-perf: compile with O3

[De Lara Guarch, Pablo]

> -Original Message-
> From: De Lara Guarch, Pablo
> Sent: Monday, June 25, 2018 1:53 PM
> To: Doherty, Declan 
> Cc: dev@dpdk.org; De Lara Guarch, Pablo 
> Subject: [PATCH] app/crypto-perf: compile with O3
> 
> The crypto performance application was not being compiled with -O3, which
> means that the performance shown may not be optimal.
> 
> Signed-off-by: Pablo de Lara 

Applied to dpdk-next-crypto.

Pablo

Re: [dpdk-dev] [PATCH] examples/vhost_crypto: add multi-core support

[De Lara Guarch, Pablo]

Hi Jay/Maxime,

> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org]
> Sent: Friday, June 22, 2018 1:36 PM
> To: dev@dpdk.org
> Cc: maxime.coque...@redhat.com
> Subject: [dpdk-dev] [PATCH] examples/vhost_crypto: add multi-core support
> 
> Originally vhost_crypto sample application only supports single core. This 
> patch
> adds the multi-core support with more flexible options.
> 
> Signed-off-by: Fan Zhang 

Could you review this patch, please?

Thanks,
Pablo

Re: [dpdk-dev] [PATCH] ethdev: move sanity checks to non-debug paths

[Aaron Conole]

Matan Azrad  writes:

> Hi Aaron
>
> From: Aaron Conole
>> These checks would have prevented a reported crash in the field.  If a user
>> builds without ETHDEV_DEBUG, it should make their application more stable,
>> not less.
>> 
>> Many of these functions immediately dereference arrays based on the passed
>> in values, so the sanity checks are quite important.
>> 
>
> These functions are datapath functions.
> Do you really want to add more 3 checks + calculations per each burst call?
> Did you check the performance impact?
> I think that performance numbers must be added for the discussion of this 
> patch.

I'll dig up performance numbers - but performance doesn't mean anything
if the application isn't running any longer due to crash.

>> The logs are left as DEBUG only.
>> 
>> Cc: Marcelo Leitner 
>> Signed-off-by: Aaron Conole 
>> ---
>>  lib/librte_ethdev/rte_ethdev.h | 29 +
>>  1 file changed, 13 insertions(+), 16 deletions(-)
>> 
>> diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h
>> index f5f593b31..bfd6a3406 100644
>> --- a/lib/librte_ethdev/rte_ethdev.h
>> +++ b/lib/librte_ethdev/rte_ethdev.h
>> @@ -3805,15 +3805,16 @@ rte_eth_rx_burst(uint16_t port_id, uint16_t
>> queue_id,
>>  struct rte_eth_dev *dev = &rte_eth_devices[port_id];
>>  uint16_t nb_rx;
>> 
>> -#ifdef RTE_LIBRTE_ETHDEV_DEBUG
>>  RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, 0);
>>  RTE_FUNC_PTR_OR_ERR_RET(*dev->rx_pkt_burst, 0);
>> 
>>  if (queue_id >= dev->data->nb_rx_queues) {
>> +#ifdef RTE_LIBRTE_ETHDEV_DEBUG
>>  RTE_ETHDEV_LOG(ERR, "Invalid RX queue_id=%u\n",
>> queue_id);
>> +#endif
>>  return 0;
>>  }
>> -#endif
>> +
>>  nb_rx = (*dev->rx_pkt_burst)(dev->data->rx_queues[queue_id],
>>   rx_pkts, nb_pkts);
>> 
>> @@ -3928,14 +3929,12 @@ rte_eth_rx_descriptor_status(uint16_t port_id,
>> uint16_t queue_id,
>>  struct rte_eth_dev *dev;
>>  void *rxq;
>> 
>> -#ifdef RTE_LIBRTE_ETHDEV_DEBUG
>>  RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV); -#endif
>>  dev = &rte_eth_devices[port_id];
>> -#ifdef RTE_LIBRTE_ETHDEV_DEBUG
>> +
>>  if (queue_id >= dev->data->nb_rx_queues)
>>  return -ENODEV;
>> -#endif
>> +
>>  RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->rx_descriptor_status, -
>> ENOTSUP);
>>  rxq = dev->data->rx_queues[queue_id];
>> 
>> @@ -3985,14 +3984,12 @@ static inline int
>> rte_eth_tx_descriptor_status(uint16_t port_id,
>>  struct rte_eth_dev *dev;
>>  void *txq;
>> 
>> -#ifdef RTE_LIBRTE_ETHDEV_DEBUG
>>  RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV); -#endif
>>  dev = &rte_eth_devices[port_id];
>> -#ifdef RTE_LIBRTE_ETHDEV_DEBUG
>> +
>>  if (queue_id >= dev->data->nb_tx_queues)
>>  return -ENODEV;
>> -#endif
>> +
>>  RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->tx_descriptor_status, -
>> ENOTSUP);
>>  txq = dev->data->tx_queues[queue_id];
>> 
>> @@ -4071,15 +4068,15 @@ rte_eth_tx_burst(uint16_t port_id, uint16_t
>> queue_id,  {
>>  struct rte_eth_dev *dev = &rte_eth_devices[port_id];
>> 
>> -#ifdef RTE_LIBRTE_ETHDEV_DEBUG
>>  RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, 0);
>>  RTE_FUNC_PTR_OR_ERR_RET(*dev->tx_pkt_burst, 0);
>> 
>>  if (queue_id >= dev->data->nb_tx_queues) {
>> +#ifdef RTE_LIBRTE_ETHDEV_DEBUG
>>  RTE_ETHDEV_LOG(ERR, "Invalid TX queue_id=%u\n",
>> queue_id);
>> +#endif
>>  return 0;
>>  }
>> -#endif
>> 
>>  #ifdef RTE_ETHDEV_RXTX_CALLBACKS
>>  struct rte_eth_rxtx_callback *cb = dev->pre_tx_burst_cbs[queue_id];
>> @@ -4160,23 +4157,23 @@ rte_eth_tx_prepare(uint16_t port_id, uint16_t
>> queue_id,  {
>>  struct rte_eth_dev *dev;
>> 
>> -#ifdef RTE_LIBRTE_ETHDEV_DEBUG
>>  if (!rte_eth_dev_is_valid_port(port_id)) {
>> +#ifdef RTE_LIBRTE_ETHDEV_DEBUG
>>  RTE_ETHDEV_LOG(ERR, "Invalid TX port_id=%u\n", port_id);
>> +#endif
>>  rte_errno = -EINVAL;
>>  return 0;
>>  }
>> -#endif
>> 
>>  dev = &rte_eth_devices[port_id];
>> 
>> -#ifdef RTE_LIBRTE_ETHDEV_DEBUG
>>  if (queue_id >= dev->data->nb_tx_queues) {
>> +#ifdef RTE_LIBRTE_ETHDEV_DEBUG
>>  RTE_ETHDEV_LOG(ERR, "Invalid TX queue_id=%u\n",
>> queue_id);
>> +#endif
>>  rte_errno = -EINVAL;
>>  return 0;
>>  }
>> -#endif
>> 
>>  if (!dev->tx_pkt_prepare)
>>  return nb_pkts;
>> --
>> 2.14.3

[dpdk-dev] [PATCH] doc: fix mlx5 dependencies

[Adrien Mazarguil]

The new dependency of mlx5 to libmnl must be reflected in documentation.

Fixes: 4d5cce06231a ("net/mlx5: lay groundwork for switch offloads")

Signed-off-by: Adrien Mazarguil 
---
 doc/guides/nics/mlx5.rst | 19 +++
 1 file changed, 19 insertions(+)

diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst
index ebf233649..4d692fa81 100644
--- a/doc/guides/nics/mlx5.rst
+++ b/doc/guides/nics/mlx5.rst
@@ -448,6 +448,12 @@ DPDK and must be installed separately:
   This library basically implements send/receive calls to the hardware
   queues.
 
+- **libmnl**
+
+  Minimalistic Netlink library mainly relied on to manage E-Switch flow
+  rules (i.e. those with the "transfer" attribute and typically involving
+  port representors).
+
 - **Kernel modules**
 
   They provide the kernel-side Verbs API and low level device drivers that
@@ -526,6 +532,19 @@ required from that distribution.
this DPDK release was developed and tested against is strongly
recommended. Please check the `prerequisites`_.
 
+Libmnl
+^^
+
+Minimal version for libmnl is **1.0.3**.
+
+As a dependency of the **iproute2** suite, this library is often installed
+by default. It is otherwise readily available through standard system
+packages.
+
+Its development headers must be installed in order to compile this PMD.
+These packages are usually named **libmnl-dev** or **libmnl-devel**
+depending on the Linux distribution.
+
 Supported NICs
 --
 
-- 
2.11.0

Re: [dpdk-dev] [PATCH] ethdev: move sanity checks to non-debug paths

[Matan Azrad]

Hi Aaron
From: Aaron Conole
> Sent: Monday, July 23, 2018 2:52 PM
> To: Matan Azrad 
> Cc: dev@dpdk.org; Ferruh Yigit ; Marcelo Leitner
> ; Shahaf Shuler ; Ori Kam
> ; Thomas Monjalon 
> Subject: Re: [dpdk-dev] [PATCH] ethdev: move sanity checks to non-debug paths
> 
> Matan Azrad  writes:
> 
> > Hi Aaron
> >
> > From: Aaron Conole
> >> These checks would have prevented a reported crash in the field.  If
> >> a user builds without ETHDEV_DEBUG, it should make their application
> >> more stable, not less.
> >>
> >> Many of these functions immediately dereference arrays based on the
> >> passed in values, so the sanity checks are quite important.
> >>
> >
> > These functions are datapath functions.
> > Do you really want to add more 3 checks + calculations per each burst call?
> > Did you check the performance impact?
> > I think that performance numbers must be added for the discussion of this
> patch.
> 
> I'll dig up performance numbers - but performance doesn't mean anything if
> the application isn't running any longer due to crash.

Yes, I understand your point, but think about that, if we are going to defend 
each user mistake it will cost a lot.
For example in Tx path, Adding checks for each mbuf pointer and mbuf data 
validity will be very expensive.

I think the best way is to check the common user mistakes in DEBUG mode to help 
for application debugging and that's it.

> >> The logs are left as DEBUG only.
> >>
> >> Cc: Marcelo Leitner 
> >> Signed-off-by: Aaron Conole 
> >> ---
> >>  lib/librte_ethdev/rte_ethdev.h | 29 +
> >>  1 file changed, 13 insertions(+), 16 deletions(-)
> >>
> >> diff --git a/lib/librte_ethdev/rte_ethdev.h
> >> b/lib/librte_ethdev/rte_ethdev.h index f5f593b31..bfd6a3406 100644
> >> --- a/lib/librte_ethdev/rte_ethdev.h
> >> +++ b/lib/librte_ethdev/rte_ethdev.h
> >> @@ -3805,15 +3805,16 @@ rte_eth_rx_burst(uint16_t port_id, uint16_t
> >> queue_id,
> >>struct rte_eth_dev *dev = &rte_eth_devices[port_id];
> >>uint16_t nb_rx;
> >>
> >> -#ifdef RTE_LIBRTE_ETHDEV_DEBUG
> >>RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, 0);
> >>RTE_FUNC_PTR_OR_ERR_RET(*dev->rx_pkt_burst, 0);
> >>
> >>if (queue_id >= dev->data->nb_rx_queues) {
> >> +#ifdef RTE_LIBRTE_ETHDEV_DEBUG
> >>RTE_ETHDEV_LOG(ERR, "Invalid RX queue_id=%u\n",
> queue_id);
> >> +#endif
> >>return 0;
> >>}
> >> -#endif
> >> +
> >>nb_rx = (*dev->rx_pkt_burst)(dev->data->rx_queues[queue_id],
> >> rx_pkts, nb_pkts);
> >>
> >> @@ -3928,14 +3929,12 @@ rte_eth_rx_descriptor_status(uint16_t
> >> port_id, uint16_t queue_id,
> >>struct rte_eth_dev *dev;
> >>void *rxq;
> >>
> >> -#ifdef RTE_LIBRTE_ETHDEV_DEBUG
> >>RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV); -#endif
> >>dev = &rte_eth_devices[port_id];
> >> -#ifdef RTE_LIBRTE_ETHDEV_DEBUG
> >> +
> >>if (queue_id >= dev->data->nb_rx_queues)
> >>return -ENODEV;
> >> -#endif
> >> +
> >>RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->rx_descriptor_status, -
> >> ENOTSUP);
> >>rxq = dev->data->rx_queues[queue_id];
> >>
> >> @@ -3985,14 +3984,12 @@ static inline int
> >> rte_eth_tx_descriptor_status(uint16_t port_id,
> >>struct rte_eth_dev *dev;
> >>void *txq;
> >>
> >> -#ifdef RTE_LIBRTE_ETHDEV_DEBUG
> >>RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV); -#endif
> >>dev = &rte_eth_devices[port_id];
> >> -#ifdef RTE_LIBRTE_ETHDEV_DEBUG
> >> +
> >>if (queue_id >= dev->data->nb_tx_queues)
> >>return -ENODEV;
> >> -#endif
> >> +
> >>RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->tx_descriptor_status, -
> >> ENOTSUP);
> >>txq = dev->data->tx_queues[queue_id];
> >>
> >> @@ -4071,15 +4068,15 @@ rte_eth_tx_burst(uint16_t port_id, uint16_t
> >> queue_id,  {
> >>struct rte_eth_dev *dev = &rte_eth_devices[port_id];
> >>
> >> -#ifdef RTE_LIBRTE_ETHDEV_DEBUG
> >>RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, 0);
> >>RTE_FUNC_PTR_OR_ERR_RET(*dev->tx_pkt_burst, 0);
> >>
> >>if (queue_id >= dev->data->nb_tx_queues) {
> >> +#ifdef RTE_LIBRTE_ETHDEV_DEBUG
> >>RTE_ETHDEV_LOG(ERR, "Invalid TX queue_id=%u\n",
> queue_id);
> >> +#endif
> >>return 0;
> >>}
> >> -#endif
> >>
> >>  #ifdef RTE_ETHDEV_RXTX_CALLBACKS
> >>struct rte_eth_rxtx_callback *cb = dev->pre_tx_burst_cbs[queue_id];
> >> @@ -4160,23 +4157,23 @@ rte_eth_tx_prepare(uint16_t port_id, uint16_t
> >> queue_id,  {
> >>struct rte_eth_dev *dev;
> >>
> >> -#ifdef RTE_LIBRTE_ETHDEV_DEBUG
> >>if (!rte_eth_dev_is_valid_port(port_id)) {
> >> +#ifdef RTE_LIBRTE_ETHDEV_DEBUG
> >>RTE_ETHDEV_LOG(ERR, "Invalid TX port_id=%u\n", port_id);
> >> +#endif
> >>rte_errno = -EINVAL;
> >>return 0;
> >>}
> >> -#endif
> >>
> >>dev = &rte_eth_devices[port_id];
> >>
> >> -#ifdef RTE_LIBRTE_ETHDEV_DEBUG
> >>if (queue_id >= dev->data->nb_tx_queues) {
> >> +#ifdef RTE_LIBRTE_ETHDEV_DEBUG
> >>RTE_ETHDEV

Re: [dpdk-dev] [PATCH v4 1/3] crypto/openssl: add rsa and mod asym op

[De Lara Guarch, Pablo]

Hi Shally,

> -Original Message-
> From: Shally Verma [mailto:shally.ve...@caviumnetworks.com]
> Sent: Thursday, July 12, 2018 3:09 PM
> To: De Lara Guarch, Pablo 
> Cc: dev@dpdk.org; pathr...@caviumnetworks.com;
> nmur...@caviumnetworks.com; Sunila Sahu
> ; Ashish Gupta
> 
> Subject: [PATCH v4 1/3] crypto/openssl: add rsa and mod asym op
> 
> From: Sunila Sahu 
> 
> - Add compat.h to make pmd compatible to openssl-1.1.0 and
>   backward version
> - Add rsa sign/verify/encrypt/decrypt and modular operation
>   support
> 
> Signed-off-by: Sunila Sahu 
> Signed-off-by: Shally Verma 
> Signed-off-by: Ashish Gupta 

...

> --- a/drivers/crypto/openssl/rte_openssl_pmd.c
> +++ b/drivers/crypto/openssl/rte_openssl_pmd.c

...

> + case RTE_CRYPTO_ASYM_OP_VERIFY:
> + ret = RSA_public_decrypt(op->rsa.sign.length,
> + op->rsa.sign.data,
> + op->rsa.sign.data,
> + rsa,
> + pad);
> +
> + OPENSSL_LOG(DEBUG,
> + "Length of public_decrypt %d "
> + "length of message %zd\n",
> + ret, op->rsa.message.length);
> +
> + if (memcmp(op->rsa.sign.data, op->rsa.message.data,
> + op->rsa.message.length)) {
> + OPENSSL_LOG(ERR,
> + "RSA sign Verification failed");
> + return -1;
> + }

There is a compilation issue here (missing "break"?):

drivers/crypto/openssl/rte_openssl_pmd.c:1905:6: error:
this statement may fall through [-Werror=implicit-fallthrough=]
   if (memcmp(op->rsa.sign.data, op->rsa.message.data,
  ^


> + default:
> + /* allow ops with invalid args to be pushed to
> +  * completion queue
> +  */
> + cop->status = RTE_CRYPTO_OP_STATUS_INVALID_ARGS;
> + break;
> + }

Re: [dpdk-dev] [PATCH] sched: add 64-bit counter retrieval API

[Alan Robertson]

Looks good to me.

Alan.

On Wed, Jul 18, 2018 at 3:51 PM,   wrote:
> From: Alan Dewar 
>
> Add new APIs to retrieve counters in 64-bit wide fields.
>
> Signed-off-by: Alan Dewar 
> ---
>  lib/librte_sched/rte_sched.c   | 72 
>  lib/librte_sched/rte_sched.h   | 76 
> ++
>  lib/librte_sched/rte_sched_version.map |  2 +
>  3 files changed, 150 insertions(+)
>
> diff --git a/lib/librte_sched/rte_sched.c b/lib/librte_sched/rte_sched.c
> index 9269e5c..4396366 100644
> --- a/lib/librte_sched/rte_sched.c
> +++ b/lib/librte_sched/rte_sched.c
> @@ -1070,6 +1070,43 @@ rte_sched_subport_read_stats(struct rte_sched_port 
> *port,
> return 0;
>  }
>
> +int __rte_experimental
> +rte_sched_subport_read_stats64(struct rte_sched_port *port,
> +  uint32_t subport_id,
> +  struct rte_sched_subport_stats64 *stats64,
> +  uint32_t *tc_ov)
> +{
> +   struct rte_sched_subport *s;
> +   uint32_t tc;
> +
> +   /* Check user parameters */
> +   if (port == NULL || subport_id >= port->n_subports_per_port ||
> +   stats64 == NULL || tc_ov == NULL)
> +   return -1;
> +
> +   s = port->subport + subport_id;
> +
> +   /* Copy subport stats and clear */
> +   for (tc = 0; tc < RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE; tc++) {
> +   stats64->n_pkts_tc[tc] = s->stats.n_pkts_tc[tc];
> +   stats64->n_pkts_tc_dropped[tc] =
> +   s->stats.n_pkts_tc_dropped[tc];
> +   stats64->n_bytes_tc[tc] = s->stats.n_bytes_tc[tc];
> +   stats64->n_bytes_tc_dropped[tc] =
> +   s->stats.n_bytes_tc_dropped[tc];
> +#ifdef RTE_SCHED_RED
> +   stats64->n_pkts_red_dropped[tc] =
> +   s->stats.n_pkts_red_dropped[tc];
> +#endif
> +   }
> +   memset(&s->stats, 0, sizeof(struct rte_sched_subport_stats));
> +
> +   /* Subport TC oversubscription status */
> +   *tc_ov = s->tc_ov;
> +
> +   return 0;
> +}
> +
>  int
>  rte_sched_queue_read_stats(struct rte_sched_port *port,
> uint32_t queue_id,
> @@ -1099,6 +1136,41 @@ rte_sched_queue_read_stats(struct rte_sched_port *port,
> return 0;
>  }
>
> +int __rte_experimental
> +rte_sched_queue_read_stats64(struct rte_sched_port *port,
> +   uint32_t queue_id,
> +   struct rte_sched_queue_stats64 *stats64,
> +   uint16_t *qlen)
> +{
> +   struct rte_sched_queue *q;
> +   struct rte_sched_queue_extra *qe;
> +
> +   /* Check user parameters */
> +   if ((port == NULL) ||
> +   (queue_id >= rte_sched_port_queues_per_port(port)) ||
> +   (stats64 == NULL) ||
> +   (qlen == NULL)) {
> +   return -1;
> +   }
> +   q = port->queue + queue_id;
> +   qe = port->queue_extra + queue_id;
> +
> +   /* Copy queue stats and clear */
> +   stats64->n_pkts = qe->stats.n_pkts;
> +   stats64->n_pkts_dropped = qe->stats.n_pkts_dropped;
> +   stats64->n_bytes = qe->stats.n_bytes;
> +   stats64->n_bytes_dropped = qe->stats.n_bytes_dropped;
> +#ifdef RTE_SCHED_RED
> +   stats64->n_pkts_red_dropped = qe->stats.n_pkts_red_dropped;
> +#endif
> +   memset(&qe->stats, 0, sizeof(struct rte_sched_queue_stats));
> +
> +   /* Queue length */
> +   *qlen = q->qw - q->qr;
> +
> +   return 0;
> +}
> +
>  static inline uint32_t
>  rte_sched_port_qindex(struct rte_sched_port *port, uint32_t subport, 
> uint32_t pipe, uint32_t traffic_class, uint32_t queue)
>  {
> diff --git a/lib/librte_sched/rte_sched.h b/lib/librte_sched/rte_sched.h
> index 84fa896..f37a4d6 100644
> --- a/lib/librte_sched/rte_sched.h
> +++ b/lib/librte_sched/rte_sched.h
> @@ -141,6 +141,25 @@ struct rte_sched_subport_stats {
>  #endif
>  };
>
> +struct rte_sched_subport_stats64 {
> +   /* Packets */
> +   uint64_t n_pkts_tc[RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE];
> +   /**< Number of packets successfully written */
> +   uint64_t n_pkts_tc_dropped[RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE];
> +   /**< Number of packets dropped */
> +
> +   /* Bytes */
> +   uint64_t n_bytes_tc[RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE];
> +   /**< Number of bytes successfully written for each traffic class */
> +   uint64_t n_bytes_tc_dropped[RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE];
> +   /**< Number of bytes dropped for each traffic class */
> +
> +#ifdef RTE_SCHED_RED
> +   uint64_t n_pkts_red_dropped[RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE];
> +   /**< Number of packets dropped by red */
> +#endif
> +};
> +
>  /*
>   * Pipe configuration parameters. The period and credits_per_period
>   * parameters are measured in bytes, with one byte meaning the time
> @@ -182,6 +201,19 @@ struct rte_sched_queue_stats {
> uint32_t n_bytes_dropped;/**< Bytes dropped */
>  };
>
> +struct rte_sched_queue

Re: [dpdk-dev] [PATCH v3 4/5] compress/zlib: support burst enqueue/dequeue

[De Lara Guarch, Pablo]

> -Original Message-
> From: Shally Verma [mailto:shally.ve...@caviumnetworks.com]
> Sent: Saturday, July 21, 2018 7:18 PM
> To: De Lara Guarch, Pablo 
> Cc: dev@dpdk.org; pathr...@caviumnetworks.com;
> mcha...@caviumnetworks.com; ashish.gu...@caviumnetworks.com;
> sunila.s...@caviumnetworks.com; Sunila Sahu 
> Subject: [PATCH v3 4/5] compress/zlib: support burst enqueue/dequeue
> 
> From: Sunila Sahu 
> 
> Signed-off-by: Sunila Sahu 
> Signed-off-by: Shally Verma 
> Signed-off-by: Ashish Gupta 
> ---
>  drivers/compress/zlib/zlib_pmd.c | 254

...

> +def_end:
> + /* Update op stats */
> + switch (op->status) {
> + case RTE_COMP_OP_STATUS_SUCCESS:
> + op->consumed += strm->total_in;

Compilation issue here:

drivers/compress/zlib/zlib_pmd.c:94:16: error: this statement may fall through 
[-Werror=implicit-fallthrough=]
   op->consumed += strm->total_in;
   ~^

I think you are missing a "/* Fall-through */" comment here.

Thanks,
Pablo

> + case RTE_COMP_OP_STATUS_OUT_OF_SPACE_TERMINATED:
> + op->produced += strm->total_out;
> + break;

Re: [dpdk-dev] [PATCH v3 4/5] compress/zlib: support burst enqueue/dequeue

[Verma, Shally]

Hi Pablo

>-Original Message-
>From: De Lara Guarch, Pablo 
>Sent: 23 July 2018 18:07
>To: Verma, Shally 
>Cc: dev@dpdk.org; Athreya, Narayana Prasad 
>; Challa, Mahipal
>; Gupta, Ashish ; Sahu, 
>Sunila ; Sahu, Sunila
>
>Subject: RE: [PATCH v3 4/5] compress/zlib: support burst enqueue/dequeue
>
>External Email
>
>> -Original Message-
>> From: Shally Verma [mailto:shally.ve...@caviumnetworks.com]
>> Sent: Saturday, July 21, 2018 7:18 PM
>> To: De Lara Guarch, Pablo 
>> Cc: dev@dpdk.org; pathr...@caviumnetworks.com;
>> mcha...@caviumnetworks.com; ashish.gu...@caviumnetworks.com;
>> sunila.s...@caviumnetworks.com; Sunila Sahu 
>> Subject: [PATCH v3 4/5] compress/zlib: support burst enqueue/dequeue
>>
>> From: Sunila Sahu 
>>
>> Signed-off-by: Sunila Sahu 
>> Signed-off-by: Shally Verma 
>> Signed-off-by: Ashish Gupta 
>> ---
>>  drivers/compress/zlib/zlib_pmd.c | 254
>
>...
>
>> +def_end:
>> + /* Update op stats */
>> + switch (op->status) {
>> + case RTE_COMP_OP_STATUS_SUCCESS:
>> + op->consumed += strm->total_in;
>
>Compilation issue here:
>
>drivers/compress/zlib/zlib_pmd.c:94:16: error: this statement may fall through 
>[-Werror=implicit-fallthrough=]
>   op->consumed += strm->total_in;
>   ~^
>
>I think you are missing a "/* Fall-through */" comment here.
OK. I will send next patch immediately with this fix. But which compiler 
version you following, since this isn't seen during our build (which we did on 
multiple platforms) so want to understand what is the environment we need to 
have to avoid such regressions.

Thanks
Shally

>
>Thanks,
>Pablo
>
>> + case RTE_COMP_OP_STATUS_OUT_OF_SPACE_TERMINATED:
>> + op->produced += strm->total_out;
>> + break;

Re: [dpdk-dev] [PATCH v3 4/5] compress/zlib: support burst enqueue/dequeue

[De Lara Guarch, Pablo]

> -Original Message-
> From: Verma, Shally [mailto:shally.ve...@cavium.com]
> Sent: Monday, July 23, 2018 1:53 PM
> To: De Lara Guarch, Pablo 
> Cc: dev@dpdk.org; Athreya, Narayana Prasad
> ; Challa, Mahipal
> ; Gupta, Ashish ;
> Sahu, Sunila ; Sahu, Sunila
> 
> Subject: RE: [PATCH v3 4/5] compress/zlib: support burst enqueue/dequeue
> 
> Hi Pablo
> 
> >-Original Message-
> >From: De Lara Guarch, Pablo 
> >Sent: 23 July 2018 18:07
> >To: Verma, Shally 
> >Cc: dev@dpdk.org; Athreya, Narayana Prasad
> >; Challa, Mahipal
> >; Gupta, Ashish ;
> >Sahu, Sunila ; Sahu, Sunila
> >
> >Subject: RE: [PATCH v3 4/5] compress/zlib: support burst
> >enqueue/dequeue
> >
> >External Email
> >
> >> -Original Message-
> >> From: Shally Verma [mailto:shally.ve...@caviumnetworks.com]
> >> Sent: Saturday, July 21, 2018 7:18 PM
> >> To: De Lara Guarch, Pablo 
> >> Cc: dev@dpdk.org; pathr...@caviumnetworks.com;
> >> mcha...@caviumnetworks.com; ashish.gu...@caviumnetworks.com;
> >> sunila.s...@caviumnetworks.com; Sunila Sahu
> >> 
> >> Subject: [PATCH v3 4/5] compress/zlib: support burst enqueue/dequeue
> >>
> >> From: Sunila Sahu 
> >>
> >> Signed-off-by: Sunila Sahu 
> >> Signed-off-by: Shally Verma 
> >> Signed-off-by: Ashish Gupta 
> >> ---
> >>  drivers/compress/zlib/zlib_pmd.c | 254
> >
> >...
> >
> >> +def_end:
> >> + /* Update op stats */
> >> + switch (op->status) {
> >> + case RTE_COMP_OP_STATUS_SUCCESS:
> >> + op->consumed += strm->total_in;
> >
> >Compilation issue here:
> >
> >drivers/compress/zlib/zlib_pmd.c:94:16: error: this statement may fall 
> >through
> [-Werror=implicit-fallthrough=]
> >   op->consumed += strm->total_in;
> >   ~^
> >
> >I think you are missing a "/* Fall-through */" comment here.
> OK. I will send next patch immediately with this fix. But which compiler 
> version
> you following, since this isn't seen during our build (which we did on 
> multiple
> platforms) so want to understand what is the environment we need to have to
> avoid such regressions.

I see this with gcc 7.2.1 (on Fedora 27).

Pablo

> 
> Thanks
> Shally
> 
> >
> >Thanks,
> >Pablo
> >
> >> + case RTE_COMP_OP_STATUS_OUT_OF_SPACE_TERMINATED:
> >> + op->produced += strm->total_out;
> >> + break;

[dpdk-dev] [PATCH v2 1/2] common/qat: add sgl header

[Fiona Trahe]

This patch refactors the sgl struct so it includes a flexible
array of flat buffers as sym and compress PMDs can have
different size sgls.

Signed-off-by: Tomasz Jozwiak 
Signed-off-by: Fiona Trahe 
---
v2 changes:
 - changed max_segs from int32_t to uint16_t to match max allowed by mbuf
 - declared loop index outside for statement to work for all compilers

 drivers/common/qat/qat_common.c | 57 +++--
 drivers/common/qat/qat_common.h | 23 +
 drivers/crypto/qat/qat_sym.c| 12 +
 drivers/crypto/qat/qat_sym.h| 14 --
 4 files changed, 75 insertions(+), 31 deletions(-)

diff --git a/drivers/common/qat/qat_common.c b/drivers/common/qat/qat_common.c
index c206d3b..81a99c1 100644
--- a/drivers/common/qat/qat_common.c
+++ b/drivers/common/qat/qat_common.c
@@ -8,40 +8,53 @@
 
 int
 qat_sgl_fill_array(struct rte_mbuf *buf, uint64_t buf_start,
-   struct qat_sgl *list, uint32_t data_len)
+   void *list_in, uint32_t data_len,
+   const uint16_t max_segs)
 {
int nr = 1;
-
-   uint32_t buf_len = rte_pktmbuf_iova(buf) -
-   buf_start + rte_pktmbuf_data_len(buf);
+   struct qat_sgl *list = (struct qat_sgl *)list_in;
+   /* buf_start allows the first buffer to start at an address before or
+* after the mbuf data start. It's used to either optimally align the
+* dma to 64 or to start dma from an offset.
+*/
+   uint32_t buf_len;
+   uint32_t first_buf_len = rte_pktmbuf_data_len(buf) +
+   (rte_pktmbuf_mtophys(buf) - buf_start);
+#if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG
+   uint8_t *virt_addr[max_segs];
+   virt_addr[0] = rte_pktmbuf_mtod(buf, uint8_t*) +
+   (rte_pktmbuf_mtophys(buf) - buf_start);
+#endif
 
list->buffers[0].addr = buf_start;
list->buffers[0].resrvd = 0;
-   list->buffers[0].len = buf_len;
+   list->buffers[0].len = first_buf_len;
 
-   if (data_len <= buf_len) {
+   if (data_len <= first_buf_len) {
list->num_bufs = nr;
list->buffers[0].len = data_len;
-   return 0;
+   goto sgl_end;
}
 
buf = buf->next;
+   buf_len = first_buf_len;
while (buf) {
-   if (unlikely(nr == QAT_SGL_MAX_NUMBER)) {
-   QAT_LOG(ERR,
-   "QAT PMD exceeded size of QAT SGL entry(%u)",
-   QAT_SGL_MAX_NUMBER);
+   if (unlikely(nr == max_segs)) {
+   QAT_DP_LOG(ERR, "Exceeded max segments in QAT SGL (%u)",
+   max_segs);
return -EINVAL;
}
 
list->buffers[nr].len = rte_pktmbuf_data_len(buf);
list->buffers[nr].resrvd = 0;
-   list->buffers[nr].addr = rte_pktmbuf_iova(buf);
-
+   list->buffers[nr].addr = rte_pktmbuf_mtophys(buf);
+#if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG
+   virt_addr[nr] = rte_pktmbuf_mtod(buf, uint8_t*);
+#endif
buf_len += list->buffers[nr].len;
buf = buf->next;
 
-   if (buf_len > data_len) {
+   if (buf_len >= data_len) {
list->buffers[nr].len -=
buf_len - data_len;
buf = NULL;
@@ -50,6 +63,22 @@ qat_sgl_fill_array(struct rte_mbuf *buf, uint64_t buf_start,
}
list->num_bufs = nr;
 
+sgl_end:
+#if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG
+   {
+   uint16_t i;
+   QAT_DP_LOG(INFO, "SGL with %d buffers:", list->num_bufs);
+   for (i = 0; i < list->num_bufs; i++) {
+   QAT_DP_LOG(INFO,
+   "QAT SGL buf %d, len = %d, iova = 0x%012lx",
+   i, list->buffers[i].len,
+   list->buffers[i].addr);
+   QAT_DP_HEXDUMP_LOG(DEBUG, "qat SGL",
+   virt_addr[i], list->buffers[i].len);
+   }
+   }
+#endif
+
return 0;
 }
 
diff --git a/drivers/common/qat/qat_common.h b/drivers/common/qat/qat_common.h
index db85d54..b26aa26 100644
--- a/drivers/common/qat/qat_common.h
+++ b/drivers/common/qat/qat_common.h
@@ -10,11 +10,6 @@
 
 /**< Intel(R) QAT device name for PCI registration */
 #define QAT_PCI_NAME   qat
-/*
- * Maximum number of SGL entries
- */
-#define QAT_SGL_MAX_NUMBER 16
-
 #define QAT_64_BTYE_ALIGN_MASK (~0x3f)
 
 /* Intel(R) QuickAssist Technology device generation is enumerated
@@ -31,6 +26,7 @@ enum qat_service_type {
QAT_SERVICE_COMPRESSION,
QAT_SERVICE_INVALID
 };
+
 #define QAT_MAX_SERVICES   (QAT_SERVICE_INVALID)
 
 /**< Common struct for scatter-gather list operations */
@@ -40,11 +36,17 @@ struct qat_flat_buf {
uint64_t ad

[dpdk-dev] [PATCH v2 2/2] compression/qat: add sgl feature

[Fiona Trahe]

This patch adds sgl feature to QAT compression PMD

Signed-off-by: Tomasz Jozwiak 
Signed-off-by: Fiona Trahe 
---
v2 : no change - just resubmit with the changed 1/2 patch 

 config/common_base   |  1 +
 config/rte_config.h  |  1 +
 doc/guides/compressdevs/features/qat.ini |  3 +++
 doc/guides/compressdevs/qat_comp.rst |  2 --
 drivers/compress/qat/qat_comp.c  | 41 
 drivers/compress/qat/qat_comp.h  |  9 +++
 drivers/compress/qat/qat_comp_pmd.c  | 25 ++-
 7 files changed, 75 insertions(+), 7 deletions(-)

diff --git a/config/common_base b/config/common_base
index a061c21..6d82b91 100644
--- a/config/common_base
+++ b/config/common_base
@@ -499,6 +499,7 @@ CONFIG_RTE_LIBRTE_PMD_QAT_SYM=n
 # Max. number of QuickAssist devices, which can be detected and attached
 #
 CONFIG_RTE_PMD_QAT_MAX_PCI_DEVICES=48
+CONFIG_RTE_PMD_QAT_COMP_SGL_MAX_SEGMENTS=16
 
 #
 # Compile PMD for virtio crypto devices
diff --git a/config/rte_config.h b/config/rte_config.h
index 28f04b4..a8e4797 100644
--- a/config/rte_config.h
+++ b/config/rte_config.h
@@ -89,6 +89,7 @@
 /* QuickAssist device */
 /* Max. number of QuickAssist devices which can be attached */
 #define RTE_PMD_QAT_MAX_PCI_DEVICES 48
+#define RTE_PMD_QAT_COMP_SGL_MAX_SEGMENTS 16
 
 /* virtio crypto defines */
 #define RTE_MAX_VIRTIO_CRYPTO 32
diff --git a/doc/guides/compressdevs/features/qat.ini 
b/doc/guides/compressdevs/features/qat.ini
index 12bfb21..5cd4524 100644
--- a/doc/guides/compressdevs/features/qat.ini
+++ b/doc/guides/compressdevs/features/qat.ini
@@ -5,6 +5,9 @@
 ;
 [Features]
 HW Accelerated  = Y
+OOP SGL In SGL Out  = Y
+OOP SGL In LB  Out  = Y
+OOP LB  In SGL Out  = Y
 Deflate = Y
 Adler32 = Y
 Crc32   = Y
diff --git a/doc/guides/compressdevs/qat_comp.rst 
b/doc/guides/compressdevs/qat_comp.rst
index 167f816..8b1270b 100644
--- a/doc/guides/compressdevs/qat_comp.rst
+++ b/doc/guides/compressdevs/qat_comp.rst
@@ -35,8 +35,6 @@ Checksum generation:
 Limitations
 ---
 
-* Chained mbufs are not yet supported, therefore max data size which can be 
passed to the PMD in a single mbuf is 64K - 1. If data is larger than this it 
will need to be split up and sent as multiple operations.
-
 * Compressdev level 0, no compression, is not supported.
 
 * Dynamic Huffman encoding is not yet supported.
diff --git a/drivers/compress/qat/qat_comp.c b/drivers/compress/qat/qat_comp.c
index e8019eb..cbf7614 100644
--- a/drivers/compress/qat/qat_comp.c
+++ b/drivers/compress/qat/qat_comp.c
@@ -21,10 +21,12 @@
 
 int
 qat_comp_build_request(void *in_op, uint8_t *out_msg,
-  void *op_cookie __rte_unused,
+  void *op_cookie,
   enum qat_device_gen qat_dev_gen __rte_unused)
 {
struct rte_comp_op *op = in_op;
+   struct qat_comp_op_cookie *cookie =
+   (struct qat_comp_op_cookie *)op_cookie;
struct qat_comp_xform *qat_xform = op->private_xform;
const uint8_t *tmpl = (uint8_t *)&qat_xform->qat_comp_req_tmpl;
struct icp_qat_fw_comp_req *comp_req =
@@ -44,12 +46,43 @@ qat_comp_build_request(void *in_op, uint8_t *out_msg,
comp_req->comp_pars.comp_len = op->src.length;
comp_req->comp_pars.out_buffer_sz = rte_pktmbuf_pkt_len(op->m_dst);
 
-   /* sgl */
if (op->m_src->next != NULL || op->m_dst->next != NULL) {
-   QAT_DP_LOG(ERR, "QAT PMD doesn't support scatter gather");
-   return -EINVAL;
+   /* sgl */
+   int ret = 0;
+
+   ICP_QAT_FW_COMN_PTR_TYPE_SET(comp_req->comn_hdr.comn_req_flags,
+   QAT_COMN_PTR_TYPE_SGL);
+   ret = qat_sgl_fill_array(op->m_src,
+   rte_pktmbuf_mtophys_offset(op->m_src,
+   op->src.offset),
+   &cookie->qat_sgl_src,
+   op->src.length,
+   RTE_PMD_QAT_COMP_SGL_MAX_SEGMENTS);
+   if (ret) {
+   QAT_DP_LOG(ERR, "QAT PMD Cannot fill sgl array");
+   return ret;
+   }
+
+   ret = qat_sgl_fill_array(op->m_dst,
+   rte_pktmbuf_mtophys_offset(op->m_dst,
+   op->dst.offset),
+   &cookie->qat_sgl_dst,
+   comp_req->comp_pars.out_buffer_sz,
+   RTE_PMD_QAT_COMP_SGL_MAX_SEGMENTS);
+   if (ret) {
+   QAT_DP_LOG(ERR, "QAT PMD Cannot fill sgl array");
+   return ret;
+   }
+
+   comp_req->comn_mid.src_data_addr =
+   cookie->qat_sgl_src_phys_addr;
+   comp_req->

[dpdk-dev] [PATCH v2 1/2] crypto/scheduler: add mode param parsing

[Fan Zhang]

This patch adds the mode parameter parsing to scheduler PMD.

Signed-off-by: Fan Zhang 
---
 doc/guides/cryptodevs/scheduler.rst  |  5 +
 drivers/crypto/scheduler/scheduler_pmd.c | 22 ++
 2 files changed, 27 insertions(+)

diff --git a/doc/guides/cryptodevs/scheduler.rst 
b/doc/guides/cryptodevs/scheduler.rst
index d67894d55..4d7f5b152 100644
--- a/doc/guides/cryptodevs/scheduler.rst
+++ b/doc/guides/cryptodevs/scheduler.rst
@@ -71,6 +71,11 @@ two calls:
   mode parameter values are specified in the "Cryptodev Scheduler Modes
   Overview" section.
 
+* mode_param: Specify the mode-specific parameter. Some scheduling modes
+  may be initialized with specific parameters other than the default ones,
+  such as the **threshold** packet size of **packet-size-distr** mode. This
+  parameter fulfills the purpose.
+
 * ordering: Specify the status of the crypto operations ordering feature.
   The value of this parameter can be "enable" or "disable". This feature
   is disabled by default.
diff --git a/drivers/crypto/scheduler/scheduler_pmd.c 
b/drivers/crypto/scheduler/scheduler_pmd.c
index 6c5c01d63..ac9185e65 100644
--- a/drivers/crypto/scheduler/scheduler_pmd.c
+++ b/drivers/crypto/scheduler/scheduler_pmd.c
@@ -9,6 +9,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include "rte_cryptodev_scheduler.h"
 #include "scheduler_pmd_private.h"
@@ -19,6 +20,7 @@ struct scheduler_init_params {
struct rte_cryptodev_pmd_init_params def_p;
uint32_t nb_slaves;
enum rte_cryptodev_scheduler_mode mode;
+   char mode_param_str[RTE_CRYPTODEV_SCHEDULER_NAME_MAX_LEN];
uint32_t enable_ordering;
uint16_t wc_pool[RTE_MAX_LCORE];
uint16_t nb_wc;
@@ -29,6 +31,7 @@ struct scheduler_init_params {
 #define RTE_CRYPTODEV_VDEV_NAME("name")
 #define RTE_CRYPTODEV_VDEV_SLAVE   ("slave")
 #define RTE_CRYPTODEV_VDEV_MODE("mode")
+#define RTE_CRYPTODEV_VDEV_MODE_PARAM  ("mode_param")
 #define RTE_CRYPTODEV_VDEV_ORDERING("ordering")
 #define RTE_CRYPTODEV_VDEV_MAX_NB_QP_ARG   ("max_nb_queue_pairs")
 #define RTE_CRYPTODEV_VDEV_SOCKET_ID   ("socket_id")
@@ -39,6 +42,7 @@ const char *scheduler_valid_params[] = {
RTE_CRYPTODEV_VDEV_NAME,
RTE_CRYPTODEV_VDEV_SLAVE,
RTE_CRYPTODEV_VDEV_MODE,
+   RTE_CRYPTODEV_VDEV_MODE_PARAM,
RTE_CRYPTODEV_VDEV_ORDERING,
RTE_CRYPTODEV_VDEV_MAX_NB_QP_ARG,
RTE_CRYPTODEV_VDEV_SOCKET_ID,
@@ -346,6 +350,7 @@ parse_mode_arg(const char *key __rte_unused,
if (strcmp(value, scheduler_mode_map[i].name) == 0) {
param->mode = (enum rte_cryptodev_scheduler_mode)
scheduler_mode_map[i].val;
+
break;
}
}
@@ -359,6 +364,18 @@ parse_mode_arg(const char *key __rte_unused,
 }
 
 static int
+parse_mode_param_arg(const char *key __rte_unused,
+   const char *value, void *extra_args)
+{
+   struct scheduler_init_params *param = extra_args;
+
+   strlcpy(param->mode_param_str, value,
+   RTE_CRYPTODEV_SCHEDULER_NAME_MAX_LEN);
+
+   return 0;
+}
+
+static int
 parse_ordering_arg(const char *key __rte_unused,
const char *value, void *extra_args)
 {
@@ -438,6 +455,11 @@ scheduler_parse_init_params(struct scheduler_init_params 
*params,
if (ret < 0)
goto free_kvlist;
 
+   ret = rte_kvargs_process(kvlist, RTE_CRYPTODEV_VDEV_MODE_PARAM,
+   &parse_mode_param_arg, params);
+   if (ret < 0)
+   goto free_kvlist;
+
ret = rte_kvargs_process(kvlist, RTE_CRYPTODEV_VDEV_ORDERING,
&parse_ordering_arg, params);
if (ret < 0)
-- 
2.13.6

[dpdk-dev] [PATCH v2 0/2] crypto/scheduler: add mode specific parameter support

[Fan Zhang]

This patch adds scheduler PMD mode specific parameter support. The  
packet-size-distr mode now support custom threshold during initialization.

v2:
- Rebased to master (thanks to Pablo)
- Fixed documentation

Fan Zhang (2):
  crypto/scheduler: add mode param parsing
  crypto/scheduler: add packet-size-distr mode param parse

 doc/guides/cryptodevs/scheduler.rst| 12 +++-
 drivers/crypto/scheduler/rte_cryptodev_scheduler.h |  1 +
 drivers/crypto/scheduler/scheduler_pmd.c   | 75 ++
 3 files changed, 87 insertions(+), 1 deletion(-)

-- 
2.13.6

[dpdk-dev] [PATCH v2 2/2] crypto/scheduler: add packet-size-distr mode param parse

[Fan Zhang]

This patch adds packet-size-distr mode specific parameter parser
to support different threshold packet size value other than default
128 bytes.

Signed-off-by: Fan Zhang 
---
 doc/guides/cryptodevs/scheduler.rst|  7 ++-
 drivers/crypto/scheduler/rte_cryptodev_scheduler.h |  1 +
 drivers/crypto/scheduler/scheduler_pmd.c   | 53 ++
 3 files changed, 60 insertions(+), 1 deletion(-)

diff --git a/doc/guides/cryptodevs/scheduler.rst 
b/doc/guides/cryptodevs/scheduler.rst
index 4d7f5b152..a754a27e6 100644
--- a/doc/guides/cryptodevs/scheduler.rst
+++ b/doc/guides/cryptodevs/scheduler.rst
@@ -137,7 +137,12 @@ operation:
**option_type** must be **CDEV_SCHED_OPTION_THRESHOLD** and **option** 
should
point to a rte_cryptodev_scheduler_threshold_option structure filled with
appropriate threshold value. Please NOTE this threshold has be a power-of-2
-   unsigned integer.
+   unsigned integer. It is possible to use **mode_param** initialization
+   parameter to achieve the same purpose. For example:
+
+   ... --vdev 
"crypto_scheduler,mode=packet-size-distr,mode_param=threshold:512" ...
+
+   The above parameter will overwrite the threshold value to 512.
 
 *   **CDEV_SCHED_MODE_FAILOVER:**
 
diff --git a/drivers/crypto/scheduler/rte_cryptodev_scheduler.h 
b/drivers/crypto/scheduler/rte_cryptodev_scheduler.h
index 1c164da7c..3faea4099 100644
--- a/drivers/crypto/scheduler/rte_cryptodev_scheduler.h
+++ b/drivers/crypto/scheduler/rte_cryptodev_scheduler.h
@@ -76,6 +76,7 @@ enum rte_cryptodev_schedule_option_type {
 /**
  * Threshold option structure
  */
+#define RTE_CRYPTODEV_SCHEDULER_PARAM_THRES"threshold"
 struct rte_cryptodev_scheduler_threshold_option {
uint32_t threshold; /**< Threshold for packet-size mode */
 };
diff --git a/drivers/crypto/scheduler/scheduler_pmd.c 
b/drivers/crypto/scheduler/scheduler_pmd.c
index ac9185e65..a9221a946 100644
--- a/drivers/crypto/scheduler/scheduler_pmd.c
+++ b/drivers/crypto/scheduler/scheduler_pmd.c
@@ -71,6 +71,8 @@ const struct scheduler_parse_map scheduler_ordering_map[] = {
{"disable", 0}
 };
 
+#define CDEV_SCHED_MODE_PARAM_SEP_CHAR ':'
+
 static int
 cryptodev_scheduler_create(const char *name,
struct rte_vdev_device *vdev,
@@ -110,6 +112,15 @@ cryptodev_scheduler_create(const char *name,
 
if (init_params->mode > CDEV_SCHED_MODE_USERDEFINED &&
init_params->mode < CDEV_SCHED_MODE_COUNT) {
+   union {
+   struct rte_cryptodev_scheduler_threshold_option
+   threshold_option;
+   } option;
+   enum rte_cryptodev_schedule_option_type option_type;
+   char param_name[RTE_CRYPTODEV_SCHEDULER_NAME_MAX_LEN] = {0};
+   char param_val[RTE_CRYPTODEV_SCHEDULER_NAME_MAX_LEN] = {0};
+   char *s, *end;
+
ret = rte_cryptodev_scheduler_mode_set(dev->data->dev_id,
init_params->mode);
if (ret < 0) {
@@ -125,6 +136,48 @@ cryptodev_scheduler_create(const char *name,
scheduler_mode_map[i].name);
break;
}
+
+   if (strlen(init_params->mode_param_str) > 0) {
+   s = strchr(init_params->mode_param_str,
+   CDEV_SCHED_MODE_PARAM_SEP_CHAR);
+   if (s == NULL) {
+   CR_SCHED_LOG(ERR, "Invalid mode param");
+   return -EINVAL;
+   }
+
+   strlcpy(param_name, init_params->mode_param_str,
+   s - init_params->mode_param_str + 1);
+   s++;
+   strlcpy(param_val, s,
+   RTE_CRYPTODEV_SCHEDULER_NAME_MAX_LEN);
+
+   switch (init_params->mode) {
+   case CDEV_SCHED_MODE_PKT_SIZE_DISTR:
+   if (strcmp(param_name,
+   RTE_CRYPTODEV_SCHEDULER_PARAM_THRES)
+   != 0) {
+   CR_SCHED_LOG(ERR, "Invalid mode param");
+   return -EINVAL;
+   }
+   option_type = CDEV_SCHED_OPTION_THRESHOLD;
+
+   option.threshold_option.threshold =
+   strtoul(param_val, &end, 0);
+   break;
+   default:
+   CR_SCHED_LOG(ERR, "Invalid mode param");
+   return -EINVAL;
+   }
+
+   if (sched_ctx->ops.option_set(dev, option_type,
+   

[dpdk-dev] rte_mbuf library likely()/unlikely()

[Morten Brørup]

Hi Olivier,

 

I noticed that __rte_pktmbuf_read() could do with an unlikely(), so I went 
through the entire library. Here are my suggested modifications.

 

 

diff -bu rte_mbuf.c.orig rte_mbuf.c

--- rte_mbuf.c.orig 2018-07-23 15:13:22.0 +0200

+++ rte_mbuf.c  2018-07-23 15:32:53.0 +0200

@@ -173,19 +173,19 @@

{

unsigned int nb_segs, pkt_len;

 

-   if (m == NULL)

+   if (unlikely(m == NULL))

rte_panic("mbuf is NULL\n");

 

/* generic checks */

-   if (m->pool == NULL)

+   if (unlikely(m->pool == NULL))

rte_panic("bad mbuf pool\n");

-   if (m->buf_iova == 0)

+   if (unlikely(m->buf_iova == 0))

rte_panic("bad IO addr\n");

-   if (m->buf_addr == NULL)

+   if (unlikely(m->buf_addr == NULL))

rte_panic("bad virt addr\n");

 

uint16_t cnt = rte_mbuf_refcnt_read(m);

-   if ((cnt == 0) || (cnt == UINT16_MAX))

+   if (unlikely((cnt == 0) || (cnt == UINT16_MAX)))

rte_panic("bad ref cnt\n");

 

/* nothing to check for sub-segments */

@@ -193,7 +193,7 @@

return;

 

/* data_len is supposed to be not more than pkt_len */

-   if (m->data_len > m->pkt_len)

+   if (unlikely(m->data_len > m->pkt_len))

rte_panic("bad data_len\n");

 

nb_segs = m->nb_segs;

@@ -204,9 +204,9 @@

pkt_len -= m->data_len;

} while ((m = m->next) != NULL);

 

-   if (nb_segs)

+   if (unlikely(nb_segs))

rte_panic("bad nb_segs\n");

-   if (pkt_len)

+   if (unlikely(pkt_len))

rte_panic("bad pkt_len\n");

}

 

@@ -249,7 +249,7 @@

const struct rte_mbuf *seg = m;

uint32_t buf_off = 0, copy_len;

 

-   if (off + len > rte_pktmbuf_pkt_len(m))

+   if (unlikely(off + len > rte_pktmbuf_pkt_len(m)))

return NULL;

 

while (off >= rte_pktmbuf_data_len(seg)) {

@@ -257,7 +257,7 @@

seg = seg->next;

}

 

-   if (off + len <= rte_pktmbuf_data_len(seg))

+   if (likely(off + len <= rte_pktmbuf_data_len(seg)))

return rte_pktmbuf_mtod_offset(seg, char *, off);

 

/* rare case: header is split among several segments */

@@ -344,7 +344,7 @@

unsigned int i;

int ret;

 

-   if (buflen == 0)

+   if (unlikely(buflen == 0))

return -1;

 

buf[0] = '\0';

@@ -355,9 +355,9 @@

if (name == NULL)

name = rx_flags[i].default_name;

ret = snprintf(buf, buflen, "%s ", name);

-   if (ret < 0)

+   if (unlikely(ret < 0))

return -1;

-   if ((size_t)ret >= buflen)

+   if (unlikely((size_t)ret >= buflen))

return -1;

buf += ret;

buflen -= ret;

@@ -440,7 +440,7 @@

unsigned int i;

int ret;

 

-   if (buflen == 0)

+   if (unlikely(buflen == 0))

return -1;

 

buf[0] = '\0';

@@ -451,9 +451,9 @@

if (name == NULL)

name = tx_flags[i].default_name;

ret = snprintf(buf, buflen, "%s ", name);

-   if (ret < 0)

+   if (unlikely(ret < 0))

return -1;

-   if ((size_t)ret >= buflen)

+   if (unlikely((size_t)ret >= buflen))

return -1;

buf += ret;

buflen -= ret;

 

 

diff -bu rte_mbuf.h.orig rte_mbuf.h

--- rte_mbuf.h.orig 2018-07-23 15:13:26.0 +0200

+++ rte_mbuf.h  2018-07-23 15:24:25.0 +0200

@@ -1007,7 +1007,7 @@

{

struct rte_mbuf *m;

 

-   if (rte_mempool_get(mp, (void **)&m) < 0)

+   if (unlikely(rte_mempool_get(mp, (void **)&m) < 0))

return NULL;

MBUF_RAW_ALLOC_CHECK(m);

return m;

@@ -1268,7 +1268,7 @@

static inline struct rte_mbuf *rte_pktmbuf_alloc(struct rte_mempool *mp)

{

struct rte_mbuf *m;

-   if ((m = rte_mbuf_raw_alloc(mp)) != NULL)

+   if (likely((m = rte_mbuf_raw_alloc(mp)) != NULL))

rte_pktmbuf_reset(m);

return m;

}

@@ -1696,7 +1696,7 @@

{

struct rte_mbuf *m_next;

 

-   if (m != NULL)

+   if (likely(m != NULL))

__rte_mbuf_sanity_check(m, 1);

 

while (m != NULL) {

@@ -2099,7 +2099,7 @@

struct rte_mbuf *cur_tail;

 

/* Check for number-of-segments-overflow */

-   if (head->nb_segs + tail->nb_segs > RTE_MBUF_MAX_NB_SEGS)

+   if (unlikely(head->nb_segs + tail->nb_segs > RTE_MBUF_MAX_NB_SEGS))

return -EOVERFLOW;

 

/* Chain 'tail' onto the old tail */

@@ -2147,28 +2147,28 @@

  m->outer_l3_len;

 

  

Re: [dpdk-dev] [PATCH] ethdev: move sanity checks to non-debug paths

[Ananyev, Konstantin]

> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Matan Azrad
> Sent: Monday, July 23, 2018 1:14 PM
> To: Aaron Conole 
> Cc: dev@dpdk.org; Yigit, Ferruh ; Marcelo Leitner 
> ; Shahaf Shuler
> ; Ori Kam ; Thomas Monjalon 
> 
> Subject: Re: [dpdk-dev] [PATCH] ethdev: move sanity checks to non-debug paths
> 
> 
> Hi Aaron
> From: Aaron Conole
> > Sent: Monday, July 23, 2018 2:52 PM
> > To: Matan Azrad 
> > Cc: dev@dpdk.org; Ferruh Yigit ; Marcelo Leitner
> > ; Shahaf Shuler ; Ori Kam
> > ; Thomas Monjalon 
> > Subject: Re: [dpdk-dev] [PATCH] ethdev: move sanity checks to non-debug 
> > paths
> >
> > Matan Azrad  writes:
> >
> > > Hi Aaron
> > >
> > > From: Aaron Conole
> > >> These checks would have prevented a reported crash in the field.  If
> > >> a user builds without ETHDEV_DEBUG, it should make their application
> > >> more stable, not less.
> > >>
> > >> Many of these functions immediately dereference arrays based on the
> > >> passed in values, so the sanity checks are quite important.
> > >>
> > >
> > > These functions are datapath functions.
> > > Do you really want to add more 3 checks + calculations per each burst 
> > > call?
> > > Did you check the performance impact?
> > > I think that performance numbers must be added for the discussion of this
> > patch.
> >
> > I'll dig up performance numbers - but performance doesn't mean anything if
> > the application isn't running any longer due to crash.
> 
> Yes, I understand your point, but think about that, if we are going to defend 
> each user mistake it will cost a lot.
> For example in Tx path, Adding checks for each mbuf pointer and mbuf data 
> validity will be very expensive.
> 
> I think the best way is to check the common user mistakes in DEBUG mode to 
> help for application debugging and that's it.

+1
The problem is that user provided an invalid input parameters.
Adding just extra checks inside data-path functions wouldn't solve it.
Konstantin

> 
> > >> The logs are left as DEBUG only.
> > >>
> > >> Cc: Marcelo Leitner 
> > >> Signed-off-by: Aaron Conole 
> > >> ---
> > >>  lib/librte_ethdev/rte_ethdev.h | 29 +
> > >>  1 file changed, 13 insertions(+), 16 deletions(-)
> > >>
> > >> diff --git a/lib/librte_ethdev/rte_ethdev.h
> > >> b/lib/librte_ethdev/rte_ethdev.h index f5f593b31..bfd6a3406 100644
> > >> --- a/lib/librte_ethdev/rte_ethdev.h
> > >> +++ b/lib/librte_ethdev/rte_ethdev.h
> > >> @@ -3805,15 +3805,16 @@ rte_eth_rx_burst(uint16_t port_id, uint16_t
> > >> queue_id,
> > >>  struct rte_eth_dev *dev = &rte_eth_devices[port_id];
> > >>  uint16_t nb_rx;
> > >>
> > >> -#ifdef RTE_LIBRTE_ETHDEV_DEBUG
> > >>  RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, 0);
> > >>  RTE_FUNC_PTR_OR_ERR_RET(*dev->rx_pkt_burst, 0);
> > >>
> > >>  if (queue_id >= dev->data->nb_rx_queues) {
> > >> +#ifdef RTE_LIBRTE_ETHDEV_DEBUG
> > >>  RTE_ETHDEV_LOG(ERR, "Invalid RX queue_id=%u\n",
> > queue_id);
> > >> +#endif
> > >>  return 0;
> > >>  }
> > >> -#endif
> > >> +
> > >>  nb_rx = (*dev->rx_pkt_burst)(dev->data->rx_queues[queue_id],
> > >>   rx_pkts, nb_pkts);
> > >>
> > >> @@ -3928,14 +3929,12 @@ rte_eth_rx_descriptor_status(uint16_t
> > >> port_id, uint16_t queue_id,
> > >>  struct rte_eth_dev *dev;
> > >>  void *rxq;
> > >>
> > >> -#ifdef RTE_LIBRTE_ETHDEV_DEBUG
> > >>  RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV); -#endif
> > >>  dev = &rte_eth_devices[port_id];
> > >> -#ifdef RTE_LIBRTE_ETHDEV_DEBUG
> > >> +
> > >>  if (queue_id >= dev->data->nb_rx_queues)
> > >>  return -ENODEV;
> > >> -#endif
> > >> +
> > >>  RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->rx_descriptor_status, -
> > >> ENOTSUP);
> > >>  rxq = dev->data->rx_queues[queue_id];
> > >>
> > >> @@ -3985,14 +3984,12 @@ static inline int
> > >> rte_eth_tx_descriptor_status(uint16_t port_id,
> > >>  struct rte_eth_dev *dev;
> > >>  void *txq;
> > >>
> > >> -#ifdef RTE_LIBRTE_ETHDEV_DEBUG
> > >>  RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV); -#endif
> > >>  dev = &rte_eth_devices[port_id];
> > >> -#ifdef RTE_LIBRTE_ETHDEV_DEBUG
> > >> +
> > >>  if (queue_id >= dev->data->nb_tx_queues)
> > >>  return -ENODEV;
> > >> -#endif
> > >> +
> > >>  RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->tx_descriptor_status, -
> > >> ENOTSUP);
> > >>  txq = dev->data->tx_queues[queue_id];
> > >>
> > >> @@ -4071,15 +4068,15 @@ rte_eth_tx_burst(uint16_t port_id, uint16_t
> > >> queue_id,  {
> > >>  struct rte_eth_dev *dev = &rte_eth_devices[port_id];
> > >>
> > >> -#ifdef RTE_LIBRTE_ETHDEV_DEBUG
> > >>  RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, 0);
> > >>  RTE_FUNC_PTR_OR_ERR_RET(*dev->tx_pkt_burst, 0);
> > >>
> > >>  if (queue_id >= dev->data->nb_tx_queues) {
> > >> 

[dpdk-dev] [PATCH v5 0/3]crypto/openssl: support asymmetric crypto

[Shally Verma]

This patch series add asymmetric crypto support in openssl pmd

changes in v5:
- fix -Wimplicit-fallthrough compilation error with
  gcc-7+ toolchain

changes in v4:
- add openssl 1.1.0h support in openssl PMD for asym operations.
- A compat.h added for PMD compatibility with both 1.0.2 and 1.1.0
- update openssl document with asymmetric feature support 

For further history refer https://patches.dpdk.org/patch/40079/

Ashish Gupta (1):
  doc: add asym feature list

Sunila Sahu (2):
  crypto/openssl: add rsa and mod asym op
  crypto/openssl: add dh and dsa asym op

 doc/guides/cryptodevs/features/openssl.ini   |  11 +
 doc/guides/cryptodevs/openssl.rst|   1 +
 drivers/crypto/openssl/compat.h  | 108 +
 drivers/crypto/openssl/rte_openssl_pmd.c | 468 +++-
 drivers/crypto/openssl/rte_openssl_pmd_ops.c | 528 ++-
 drivers/crypto/openssl/rte_openssl_pmd_private.h |  28 ++
 6 files changed, 1132 insertions(+), 12 deletions(-)
 create mode 100644 drivers/crypto/openssl/compat.h

-- 
2.9.5

[dpdk-dev] [PATCH v5 1/3] crypto/openssl: add rsa and mod asym op

[Shally Verma]

From: Sunila Sahu 

- Add compat.h to make pmd compatible to openssl-1.1.0 and
  backward version
- Add rsa sign/verify/encrypt/decrypt and modular operation
  support

Signed-off-by: Sunila Sahu 
Signed-off-by: Shally Verma 
Signed-off-by: Ashish Gupta 
---
 drivers/crypto/openssl/compat.h  |  40 +++
 drivers/crypto/openssl/rte_openssl_pmd.c | 231 +++-
 drivers/crypto/openssl/rte_openssl_pmd_ops.c | 336 ++-
 drivers/crypto/openssl/rte_openssl_pmd_private.h |  19 ++
 4 files changed, 614 insertions(+), 12 deletions(-)

diff --git a/drivers/crypto/openssl/compat.h b/drivers/crypto/openssl/compat.h
new file mode 100644
index 000..8ece808
--- /dev/null
+++ b/drivers/crypto/openssl/compat.h
@@ -0,0 +1,40 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2018 Cavium Networks
+ */
+
+#ifndef __RTA_COMPAT_H__
+#define __RTA_COMPAT_H__
+
+#if (OPENSSL_VERSION_NUMBER < 0x1010L)
+
+#define set_rsa_params(rsa, p, q, ret) \
+   do {rsa->p = p; rsa->q = q; ret = 0; } while (0)
+
+#define set_rsa_crt_params(rsa, dmp1, dmq1, iqmp, ret) \
+   do { \
+   rsa->dmp1 = dmp1; \
+   rsa->dmq1 = dmq1; \
+   rsa->iqmp = iqmp; \
+   ret = 0; \
+   } while (0)
+
+#define set_rsa_keys(rsa, n, e, d, ret) \
+   do { \
+   rsa->n = n; rsa->e = e; rsa->d = d; ret = 0; \
+   } while (0)
+
+#else
+
+#define set_rsa_params(rsa, p, q, ret) \
+   (ret = !RSA_set0_factors(rsa, p, q))
+
+#define set_rsa_crt_params(rsa, dmp1, dmq1, iqmp, ret) \
+   (ret = !RSA_set0_crt_params(rsa, dmp1, dmq1, iqmp))
+
+/* n, e must be non-null, d can be NULL */
+#define set_rsa_keys(rsa, n, e, d, ret) \
+   (ret = !RSA_set0_key(rsa, n, e, d))
+
+#endif /* version < 1010 */
+
+#endif /* __RTA_COMPAT_H__ */
diff --git a/drivers/crypto/openssl/rte_openssl_pmd.c 
b/drivers/crypto/openssl/rte_openssl_pmd.c
index 96b0fd2..9d18e67 100644
--- a/drivers/crypto/openssl/rte_openssl_pmd.c
+++ b/drivers/crypto/openssl/rte_openssl_pmd.c
@@ -14,6 +14,7 @@
 #include 
 
 #include "rte_openssl_pmd_private.h"
+#include "compat.h"
 
 #define DES_BLOCK_SIZE 8
 
@@ -730,19 +731,36 @@ openssl_reset_session(struct openssl_session *sess)
 }
 
 /** Provide session for operation */
-static struct openssl_session *
+static void *
 get_session(struct openssl_qp *qp, struct rte_crypto_op *op)
 {
struct openssl_session *sess = NULL;
+   struct openssl_asym_session *asym_sess = NULL;
 
if (op->sess_type == RTE_CRYPTO_OP_WITH_SESSION) {
-   /* get existing session */
-   if (likely(op->sym->session != NULL))
-   sess = (struct openssl_session *)
-   get_sym_session_private_data(
-   op->sym->session,
-   cryptodev_driver_id);
+   if (op->type == RTE_CRYPTO_OP_TYPE_SYMMETRIC) {
+   /* get existing session */
+   if (likely(op->sym->session != NULL))
+   sess = (struct openssl_session *)
+   get_sym_session_private_data(
+   op->sym->session,
+   cryptodev_driver_id);
+   } else {
+   if (likely(op->asym->session != NULL))
+   asym_sess = (struct openssl_asym_session *)
+   get_asym_session_private_data(
+   op->asym->session,
+   cryptodev_driver_id);
+   if (asym_sess == NULL)
+   op->status =
+   RTE_CRYPTO_OP_STATUS_INVALID_SESSION;
+   return asym_sess;
+   }
} else {
+   /* sessionless asymmetric not supported */
+   if (op->type == RTE_CRYPTO_OP_TYPE_ASYMMETRIC)
+   return NULL;
+
/* provide internal session */
void *_sess = NULL;
void *_sess_private_data = NULL;
@@ -1528,6 +1546,193 @@ process_openssl_auth_op(struct openssl_qp *qp, struct 
rte_crypto_op *op,
op->status = RTE_CRYPTO_OP_STATUS_ERROR;
 }
 
+/* process modinv operation */
+static int process_openssl_modinv_op(struct rte_crypto_op *cop,
+   struct openssl_asym_session *sess)
+{
+   struct rte_crypto_asym_op *op = cop->asym;
+   BIGNUM *base = BN_CTX_get(sess->u.m.ctx);
+   BIGNUM *res = BN_CTX_get(sess->u.m.ctx);
+
+   if (unlikely(base == NULL || res == NULL)) {
+   if (base)
+   BN_free(base);
+   if (res)
+   BN_free(res);
+   cop->status = RTE_CRYPTO_OP_S

[dpdk-dev] [PATCH v5 2/3] crypto/openssl: add dh and dsa asym op

[Shally Verma]

From: Sunila Sahu 

- Add dh key generation and shared compute
- Add dsa sign and verify operation

Signed-off-by: Sunila Sahu 
Signed-off-by: Shally Verma 
Signed-off-by: Ashish Gupta 
---
 drivers/crypto/openssl/compat.h  |  68 +++
 drivers/crypto/openssl/rte_openssl_pmd.c | 237 +++
 drivers/crypto/openssl/rte_openssl_pmd_ops.c | 194 ++-
 drivers/crypto/openssl/rte_openssl_pmd_private.h |   9 +
 4 files changed, 507 insertions(+), 1 deletion(-)

diff --git a/drivers/crypto/openssl/compat.h b/drivers/crypto/openssl/compat.h
index 8ece808..45f9a33 100644
--- a/drivers/crypto/openssl/compat.h
+++ b/drivers/crypto/openssl/compat.h
@@ -23,6 +23,41 @@
rsa->n = n; rsa->e = e; rsa->d = d; ret = 0; \
} while (0)
 
+#define set_dh_params(dh, p, g, ret) \
+   do { \
+   dh->p = p; \
+   dh->q = NULL; \
+   dh->g = g; \
+   ret = 0; \
+   } while (0)
+
+#define set_dh_priv_key(dh, priv_key, ret) \
+   do { dh->priv_key = priv_key; ret = 0; } while (0)
+
+#define set_dsa_params(dsa, p, q, g, ret) \
+   do { dsa->p = p; dsa->q = q; dsa->g = g; ret = 0; } while (0)
+
+#define get_dh_pub_key(dh, pub_key) \
+   (pub_key = dh->pub_key)
+
+#define get_dh_priv_key(dh, priv_key) \
+   (priv_key = dh->priv_key)
+
+#define set_dsa_sign(sign, r, s) \
+   do { sign->r = r; sign->s = s; } while (0)
+
+#define get_dsa_sign(sign, r, s) \
+   do { r = sign->r; s = sign->s; } while (0)
+
+#define set_dsa_keys(dsa, pub, priv, ret) \
+   do { dsa->pub_key = pub; dsa->priv_key = priv; ret = 0; } while (0)
+
+#define set_dsa_pub_key(dsa, pub_key) \
+   (dsa->pub_key = pub_key)
+
+#define get_dsa_priv_key(dsa, priv_key) \
+   (priv_key = dsa->priv_key)
+
 #else
 
 #define set_rsa_params(rsa, p, q, ret) \
@@ -35,6 +70,39 @@
 #define set_rsa_keys(rsa, n, e, d, ret) \
(ret = !RSA_set0_key(rsa, n, e, d))
 
+#define set_dh_params(dh, p, g, ret) \
+   (ret = !DH_set0_pqg(dh, p, NULL, g))
+
+#define set_dh_priv_key(dh, priv_key, ret) \
+   (ret = !DH_set0_key(dh, NULL, priv_key))
+
+#define get_dh_pub_key(dh, pub_key) \
+   (DH_get0_key(dh_key, &pub_key, NULL))
+
+#define get_dh_priv_key(dh, priv_key) \
+   (DH_get0_key(dh_key, NULL, &priv_key))
+
+#define set_dsa_params(dsa, p, q, g, ret) \
+   (ret = !DSA_set0_pqg(dsa, p, q, g))
+
+#define set_dsa_priv_key(dsa, priv_key) \
+   (DSA_set0_key(dsa, NULL, priv_key))
+
+#define set_dsa_sign(sign, r, s) \
+   (DSA_SIG_set0(sign, r, s))
+
+#define get_dsa_sign(sign, r, s) \
+   (DSA_SIG_get0(sign, &r, &s))
+
+#define set_dsa_keys(dsa, pub, priv, ret) \
+   (ret = !DSA_set0_key(dsa, pub, priv))
+
+#define set_dsa_pub_key(dsa, pub_key) \
+   (DSA_set0_key(dsa, pub_key, NULL))
+
+#define get_dsa_priv_key(dsa, priv_key) \
+   (DSA_get0_key(dsa, NULL, &priv_key))
+
 #endif /* version < 1010 */
 
 #endif /* __RTA_COMPAT_H__ */
diff --git a/drivers/crypto/openssl/rte_openssl_pmd.c 
b/drivers/crypto/openssl/rte_openssl_pmd.c
index 9d18e67..dd095a8 100644
--- a/drivers/crypto/openssl/rte_openssl_pmd.c
+++ b/drivers/crypto/openssl/rte_openssl_pmd.c
@@ -1546,6 +1546,230 @@ process_openssl_auth_op(struct openssl_qp *qp, struct 
rte_crypto_op *op,
op->status = RTE_CRYPTO_OP_STATUS_ERROR;
 }
 
+/* process dsa sign operation */
+static int
+process_openssl_dsa_sign_op(struct rte_crypto_op *cop,
+   struct openssl_asym_session *sess)
+{
+   struct rte_crypto_dsa_op_param *op = &cop->asym->dsa;
+   DSA *dsa = sess->u.s.dsa;
+   DSA_SIG *sign = NULL;
+
+   sign = DSA_do_sign(op->message.data,
+   op->message.length,
+   dsa);
+
+   if (sign == NULL) {
+   OPENSSL_LOG(ERR, "%s:%d\n", __func__, __LINE__);
+   cop->status = RTE_CRYPTO_OP_STATUS_ERROR;
+   } else {
+   const BIGNUM *r = NULL, *s = NULL;
+   get_dsa_sign(sign, r, s);
+
+   op->r.length = BN_bn2bin(r, op->r.data);
+   op->s.length = BN_bn2bin(s, op->s.data);
+   cop->status = RTE_CRYPTO_OP_STATUS_SUCCESS;
+   }
+
+   DSA_SIG_free(sign);
+
+   return 0;
+}
+
+/* process dsa verify operation */
+static int
+process_openssl_dsa_verify_op(struct rte_crypto_op *cop,
+   struct openssl_asym_session *sess)
+{
+   struct rte_crypto_dsa_op_param *op = &cop->asym->dsa;
+   DSA *dsa = sess->u.s.dsa;
+   int ret;
+   DSA_SIG *sign = DSA_SIG_new();
+   BIGNUM *r = NULL, *s = NULL;
+   BIGNUM *pub_key = NULL;
+
+   if (sign == NULL) {
+   OPENSSL_LOG(ERR, " %s:%d\n", __func__, __LINE__);
+   cop->status = RTE_CRYPTO_OP_STATUS_NOT_PROCESSED;
+   return -1;
+   }
+
+   r = BN_bin2bn(op->r.data,
+   op->r.length,
+   r);
+   s =

[dpdk-dev] [PATCH v5 3/3] doc: add asym feature list

[Shally Verma]

From: Ashish Gupta 

Signed-off-by: Sunila Sahu 
Signed-off-by: Shally Verma 
Signed-off-by: Ashish Gupta 
---
 doc/guides/cryptodevs/features/openssl.ini | 11 +++
 doc/guides/cryptodevs/openssl.rst  |  1 +
 2 files changed, 12 insertions(+)

diff --git a/doc/guides/cryptodevs/features/openssl.ini 
b/doc/guides/cryptodevs/features/openssl.ini
index 626ec1b..b9c0bdc 100644
--- a/doc/guides/cryptodevs/features/openssl.ini
+++ b/doc/guides/cryptodevs/features/openssl.ini
@@ -8,6 +8,7 @@ Symmetric crypto   = Y
 Sym operation chaining = Y
 OOP SGL In LB  Out = Y
 OOP LB  In LB  Out = Y
+Asymmetric crypto  = Y
 
 ;
 ; Supported crypto algorithms of the 'openssl' crypto driver.
@@ -50,3 +51,13 @@ AES GCM (256) = Y
 AES CCM (128) = Y
 AES CCM (192) = Y
 AES CCM (256) = Y
+
+;
+; Supported Asymmetric algorithms of the 'openssl' crypto driver.
+;
+[Asymmetric]
+RSA = Y
+DSA = Y
+Modular Exponentiation = Y
+Modular Inversion = Y
+Diffie-hellman = Y
diff --git a/doc/guides/cryptodevs/openssl.rst 
b/doc/guides/cryptodevs/openssl.rst
index 427fc80..bdc30f6 100644
--- a/doc/guides/cryptodevs/openssl.rst
+++ b/doc/guides/cryptodevs/openssl.rst
@@ -80,6 +80,7 @@ crypto processing.
 
 Test name is cryptodev_openssl_autotest.
 For performance test cryptodev_openssl_perftest can be used.
+For asymmetric crypto operations testing, run cryptodev_openssl_asym_autotest.
 
 To verify real traffic l2fwd-crypto example can be used with this command:
 
-- 
2.9.5

[dpdk-dev] [PATCH v4 1/5] compress/zlib: add ZLIB PMD

[Shally Verma]

From: Ashish Gupta 

Add initial PMD setup routines in compressdev
framework. ZLIB PMD appears as virtual compression
device. User would need to install zlib prior to
enabling this PMD.

Signed-off-by: Sunila Sahu 
Signed-off-by: Shally Verma 
Signed-off-by: Ashish Gupta 
---
 MAINTAINERS|  3 +
 config/common_base |  5 ++
 drivers/compress/Makefile  |  1 +
 drivers/compress/meson.build   |  2 +-
 drivers/compress/zlib/Makefile | 28 +
 drivers/compress/zlib/meson.build  | 14 +
 drivers/compress/zlib/rte_pmd_zlib_version.map |  3 +
 drivers/compress/zlib/zlib_pmd.c   | 78 ++
 drivers/compress/zlib/zlib_pmd_private.h   | 32 +++
 mk/rte.app.mk  |  2 +
 10 files changed, 167 insertions(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 7b2414d..ca27c6f 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -872,6 +872,9 @@ M: Fiona Trahe 
 F: drivers/compress/qat/
 F: drivers/common/qat/
 
+ZLIB
+M: Sunila Sahu 
+F: drivers/compress/zlib/
 
 Eventdev Drivers
 
diff --git a/config/common_base b/config/common_base
index a061c21..d9b238c 100644
--- a/config/common_base
+++ b/config/common_base
@@ -582,6 +582,11 @@ CONFIG_RTE_COMPRESSDEV_TEST=n
 CONFIG_RTE_LIBRTE_PMD_ISAL=n
 
 #
+# Compile PMD for ZLIB compression device
+#
+CONFIG_RTE_LIBRTE_PMD_ZLIB=n
+
+#
 # Compile generic event device library
 #
 CONFIG_RTE_LIBRTE_EVENTDEV=y
diff --git a/drivers/compress/Makefile b/drivers/compress/Makefile
index 592497f..1f159a5 100644
--- a/drivers/compress/Makefile
+++ b/drivers/compress/Makefile
@@ -4,5 +4,6 @@
 include $(RTE_SDK)/mk/rte.vars.mk
 
 DIRS-$(CONFIG_RTE_LIBRTE_PMD_ISAL) += isal
+DIRS-$(CONFIG_RTE_LIBRTE_PMD_ZLIB) += zlib
 
 include $(RTE_SDK)/mk/rte.subdir.mk
diff --git a/drivers/compress/meson.build b/drivers/compress/meson.build
index 2352ad5..d2ca8fc 100644
--- a/drivers/compress/meson.build
+++ b/drivers/compress/meson.build
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2018 Intel Corporation
 
-drivers = ['isal', 'qat']
+drivers = ['isal', 'qat', 'zlib']
 
 std_deps = ['compressdev'] # compressdev pulls in all other needed deps
 config_flag_fmt = 'RTE_LIBRTE_@0@_PMD'
diff --git a/drivers/compress/zlib/Makefile b/drivers/compress/zlib/Makefile
new file mode 100644
index 000..bd322c9
--- /dev/null
+++ b/drivers/compress/zlib/Makefile
@@ -0,0 +1,28 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2018 Cavium Networks
+
+include $(RTE_SDK)/mk/rte.vars.mk
+
+# library name
+LIB = librte_pmd_zlib.a
+
+# build flags
+CFLAGS += -O3
+CFLAGS += $(WERROR_FLAGS)
+CFLAGS += -DALLOW_EXPERIMENTAL_API
+
+# library version
+LIBABIVER := 1
+
+# versioning export map
+EXPORT_MAP := rte_pmd_zlib_version.map
+
+# external library dependencies
+LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring -lz
+LDLIBS += -lrte_compressdev
+LDLIBS += -lrte_bus_vdev
+
+# library source files
+SRCS-$(CONFIG_RTE_LIBRTE_PMD_ZLIB) += zlib_pmd.c
+
+include $(RTE_SDK)/mk/rte.lib.mk
diff --git a/drivers/compress/zlib/meson.build 
b/drivers/compress/zlib/meson.build
new file mode 100644
index 000..3f0a77b
--- /dev/null
+++ b/drivers/compress/zlib/meson.build
@@ -0,0 +1,14 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2018 Cavium Networks
+
+dep = dependency('zlib', required: false)
+if not dep.found()
+   build = false
+endif
+
+deps += 'bus_vdev'
+sources = files('zlib_pmd.c')
+ext_deps += dep
+pkgconfig_extra_libs += '-lz'
+
+allow_experimental_apis = true
diff --git a/drivers/compress/zlib/rte_pmd_zlib_version.map 
b/drivers/compress/zlib/rte_pmd_zlib_version.map
new file mode 100644
index 000..ad6e191
--- /dev/null
+++ b/drivers/compress/zlib/rte_pmd_zlib_version.map
@@ -0,0 +1,3 @@
+DPDK_18.08 {
+   local: *;
+};
diff --git a/drivers/compress/zlib/zlib_pmd.c b/drivers/compress/zlib/zlib_pmd.c
new file mode 100644
index 000..39d3628
--- /dev/null
+++ b/drivers/compress/zlib/zlib_pmd.c
@@ -0,0 +1,78 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2018 Cavium Networks
+ */
+
+#include 
+#include 
+
+#include "zlib_pmd_private.h"
+
+static int
+zlib_create(const char *name,
+   struct rte_vdev_device *vdev,
+   struct rte_compressdev_pmd_init_params *init_params)
+{
+   struct rte_compressdev *dev;
+
+   dev = rte_compressdev_pmd_create(name, &vdev->device,
+   sizeof(struct zlib_private), init_params);
+   if (dev == NULL) {
+   ZLIB_PMD_ERR("driver %s: create failed", init_params->name);
+   return -ENODEV;
+   }
+
+   return 0;
+}
+
+static int
+zlib_probe(struct rte_vdev_device *vdev)
+{
+   struct rte_compressdev_pmd_init_params init_params = {
+   "",
+   rte_socket_id()
+   };
+   const cha

[dpdk-dev] [PATCH v4 0/5] compress: add ZLIB compression PMD

[Shally Verma]

This patch series add software zlib library (http://zlib.net/)
based compression PMD in DPDK compress drivers.

Application must need to install zlib prior to enabling
this PMD to avail compression/decompression services.
Currently driver only tested for deflate, stateless
compression and decompression.

Changes in v4:
- fixed -Wimplcit-fallthrough compilation error
 with gcc-7+ toolchain

Changes in v3:
- added comp_feature_flags to compressdev_capabilities
- removed stream_create as stateful not supported
- changed compression strategy to DEFAULT_STRATEGY
- Simplified core processing logic
- fix doc build error
- other v2 feedbacks

TBDs
- No change to current qp enqueue_err stats update.
- PMD increment enqd_err stats, if it fails to push op
  into completion queue. This logic to be revisited based on
  further discussion

Changes in v2:
- removed unused variables
- corrected capability to reflect current support
- add lookup for internally maintained mempool during device_configure
- optimized core compression/decompression logic in enq/deq APIs
- updated documentation with correct feature support

v1 includes:
- build changes to build zlib PMD
- zlib PMD implementation
- zlib PMD documentation
- meson build support

This patchset is dependent upon compressdev API.

Ashish Gupta (2):
  compress/zlib: add ZLIB PMD
  compress/zlib: add device PMD ops

Shally Verma (1):
  doc: add ZLIB PMD guide

Sunila Sahu (2):
  compress/zlib: create private xform
  compress/zlib: support burst enqueue/dequeue

 MAINTAINERS|   5 +
 config/common_base |   5 +
 doc/guides/compressdevs/features/zlib.ini  |  11 +
 doc/guides/compressdevs/index.rst  |   1 +
 doc/guides/compressdevs/zlib.rst   |  69 
 drivers/compress/Makefile  |   1 +
 drivers/compress/meson.build   |   2 +-
 drivers/compress/zlib/Makefile |  29 ++
 drivers/compress/zlib/meson.build  |  14 +
 drivers/compress/zlib/rte_pmd_zlib_version.map |   3 +
 drivers/compress/zlib/zlib_pmd.c   | 427 +
 drivers/compress/zlib/zlib_pmd_ops.c   | 308 ++
 drivers/compress/zlib/zlib_pmd_private.h   |  71 
 mk/rte.app.mk  |   2 +
 14 files changed, 947 insertions(+), 1 deletion(-)
 create mode 100644 doc/guides/compressdevs/features/zlib.ini
 create mode 100644 doc/guides/compressdevs/zlib.rst
 create mode 100644 drivers/compress/zlib/Makefile
 create mode 100644 drivers/compress/zlib/meson.build
 create mode 100644 drivers/compress/zlib/rte_pmd_zlib_version.map
 create mode 100644 drivers/compress/zlib/zlib_pmd.c
 create mode 100644 drivers/compress/zlib/zlib_pmd_ops.c
 create mode 100644 drivers/compress/zlib/zlib_pmd_private.h

-- 
2.9.5

[dpdk-dev] [PATCH v4 2/5] compress/zlib: add device PMD ops

[Shally Verma]

From: Ashish Gupta 

Implement device configure and queue pair
setup PMD ops

Signed-off-by: Sunila Sahu 
Signed-off-by: Shally Verma 
Signed-off-by: Ashish Gupta 
---
 drivers/compress/zlib/Makefile   |   1 +
 drivers/compress/zlib/meson.build|   2 +-
 drivers/compress/zlib/zlib_pmd.c |   2 +
 drivers/compress/zlib/zlib_pmd_ops.c | 238 +++
 drivers/compress/zlib/zlib_pmd_private.h |  35 +
 5 files changed, 277 insertions(+), 1 deletion(-)

diff --git a/drivers/compress/zlib/Makefile b/drivers/compress/zlib/Makefile
index bd322c9..5cf8de6 100644
--- a/drivers/compress/zlib/Makefile
+++ b/drivers/compress/zlib/Makefile
@@ -24,5 +24,6 @@ LDLIBS += -lrte_bus_vdev
 
 # library source files
 SRCS-$(CONFIG_RTE_LIBRTE_PMD_ZLIB) += zlib_pmd.c
+SRCS-$(CONFIG_RTE_LIBRTE_PMD_ZLIB) += zlib_pmd_ops.c
 
 include $(RTE_SDK)/mk/rte.lib.mk
diff --git a/drivers/compress/zlib/meson.build 
b/drivers/compress/zlib/meson.build
index 3f0a77b..7748de2 100644
--- a/drivers/compress/zlib/meson.build
+++ b/drivers/compress/zlib/meson.build
@@ -7,7 +7,7 @@ if not dep.found()
 endif
 
 deps += 'bus_vdev'
-sources = files('zlib_pmd.c')
+sources = files('zlib_pmd.c', 'zlib_pmd_ops.c')
 ext_deps += dep
 pkgconfig_extra_libs += '-lz'
 
diff --git a/drivers/compress/zlib/zlib_pmd.c b/drivers/compress/zlib/zlib_pmd.c
index 39d3628..9363808 100644
--- a/drivers/compress/zlib/zlib_pmd.c
+++ b/drivers/compress/zlib/zlib_pmd.c
@@ -21,6 +21,8 @@ zlib_create(const char *name,
return -ENODEV;
}
 
+   dev->dev_ops = rte_zlib_pmd_ops;
+
return 0;
 }
 
diff --git a/drivers/compress/zlib/zlib_pmd_ops.c 
b/drivers/compress/zlib/zlib_pmd_ops.c
new file mode 100644
index 000..645c5b1
--- /dev/null
+++ b/drivers/compress/zlib/zlib_pmd_ops.c
@@ -0,0 +1,238 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2018 Cavium Networks
+ */
+
+#include 
+
+#include 
+#include 
+
+#include "zlib_pmd_private.h"
+
+static const struct rte_compressdev_capabilities zlib_pmd_capabilities[] = {
+   {   /* Deflate */
+   .algo = RTE_COMP_ALGO_DEFLATE,
+   .comp_feature_flags = (RTE_COMP_FF_NONCOMPRESSED_BLOCKS |
+   RTE_COMP_FF_HUFFMAN_FIXED |
+   RTE_COMP_FF_HUFFMAN_DYNAMIC |
+   RTE_COMP_FF_OOP_SGL_IN_SGL_OUT),
+   .window_size = {
+   .min = 8,
+   .max = 15,
+   .increment = 1
+   },
+   },
+
+   RTE_COMP_END_OF_CAPABILITIES_LIST()
+
+};
+
+/** Configure device */
+static int
+zlib_pmd_config(struct rte_compressdev *dev,
+   struct rte_compressdev_config *config)
+{
+   struct rte_mempool *mp;
+   char mp_name[RTE_MEMPOOL_NAMESIZE];
+   struct zlib_private *internals = dev->data->dev_private;
+
+   snprintf(mp_name, RTE_MEMPOOL_NAMESIZE,
+   "stream_mp_%u", dev->data->dev_id);
+   mp = internals->mp;
+   if (mp == NULL) {
+   mp = rte_mempool_create(mp_name,
+   config->max_nb_priv_xforms +
+   config->max_nb_streams,
+   sizeof(struct zlib_priv_xform),
+   0, 0, NULL, NULL, NULL,
+   NULL, config->socket_id,
+   0);
+   if (mp == NULL) {
+   ZLIB_PMD_ERR("Cannot create private xform pool on "
+   "socket %d\n", config->socket_id);
+   return -ENOMEM;
+   }
+   internals->mp = mp;
+   }
+   return 0;
+}
+
+/** Start device */
+static int
+zlib_pmd_start(__rte_unused struct rte_compressdev *dev)
+{
+   return 0;
+}
+
+/** Stop device */
+static void
+zlib_pmd_stop(__rte_unused struct rte_compressdev *dev)
+{
+}
+
+/** Close device */
+static int
+zlib_pmd_close(struct rte_compressdev *dev)
+{
+   struct zlib_private *internals = dev->data->dev_private;
+   rte_mempool_free(internals->mp);
+   internals->mp = NULL;
+   return 0;
+}
+
+/** Get device statistics */
+static void
+zlib_pmd_stats_get(struct rte_compressdev *dev,
+   struct rte_compressdev_stats *stats)
+{
+   int qp_id;
+
+   for (qp_id = 0; qp_id < dev->data->nb_queue_pairs; qp_id++) {
+   struct zlib_qp *qp = dev->data->queue_pairs[qp_id];
+
+   stats->enqueued_count += qp->qp_stats.enqueued_count;
+   stats->dequeued_count += qp->qp_stats.dequeued_count;
+
+   stats->enqueue_err_count += qp->qp_stats.enqueue_err_count;
+   stats->dequeue_err_count += qp->qp_stats.dequeue_err_count;
+   }
+}
+
+/** Reset device statistics */
+static void
+zlib_pmd_stats_reset(struct rte_compressdev *dev)
+{
+   int qp_id;
+
+   for (qp_id = 0; qp_i

[dpdk-dev] [PATCH v4 3/5] compress/zlib: create private xform

[Shally Verma]

From: Sunila Sahu 

Create non-shareable private xform for stateless
operation processing

Signed-off-by: Sunila Sahu 
Signed-off-by: Shally Verma 
Signed-off-by: Ashish Gupta 
---
 drivers/compress/zlib/zlib_pmd.c | 94 
 drivers/compress/zlib/zlib_pmd_ops.c | 74 -
 drivers/compress/zlib/zlib_pmd_private.h |  4 ++
 3 files changed, 170 insertions(+), 2 deletions(-)

diff --git a/drivers/compress/zlib/zlib_pmd.c b/drivers/compress/zlib/zlib_pmd.c
index 9363808..47bc73d 100644
--- a/drivers/compress/zlib/zlib_pmd.c
+++ b/drivers/compress/zlib/zlib_pmd.c
@@ -7,6 +7,100 @@
 
 #include "zlib_pmd_private.h"
 
+/** Parse comp xform and set private xform/stream parameters */
+int
+zlib_set_stream_parameters(const struct rte_comp_xform *xform,
+   struct zlib_stream *stream)
+{
+   int strategy, level, wbits;
+   z_stream *strm = &stream->strm;
+
+   /* allocate deflate state */
+   strm->zalloc = Z_NULL;
+   strm->zfree = Z_NULL;
+   strm->opaque = Z_NULL;
+
+   switch (xform->type) {
+   case RTE_COMP_COMPRESS:
+   /** Compression window bits */
+   switch (xform->compress.algo) {
+   case RTE_COMP_ALGO_DEFLATE:
+   wbits = -(xform->compress.window_size);
+   break;
+   default:
+   ZLIB_PMD_ERR("Compression algorithm not supported\n");
+   return -1;
+   }
+   /** Compression Level */
+   switch (xform->compress.level) {
+   case RTE_COMP_LEVEL_PMD_DEFAULT:
+   level = Z_DEFAULT_COMPRESSION;
+   break;
+   case RTE_COMP_LEVEL_NONE:
+   level = Z_NO_COMPRESSION;
+   break;
+   case RTE_COMP_LEVEL_MIN:
+   level = Z_BEST_SPEED;
+   break;
+   case RTE_COMP_LEVEL_MAX:
+   level = Z_BEST_COMPRESSION;
+   break;
+   default:
+   level = xform->compress.level;
+   if (level < RTE_COMP_LEVEL_MIN ||
+   level > RTE_COMP_LEVEL_MAX) {
+   ZLIB_PMD_ERR("Compression level %d "
+   "not supported\n",
+   level);
+   return -1;
+   }
+   break;
+   }
+   /** Compression strategy */
+   switch (xform->compress.deflate.huffman) {
+   case RTE_COMP_HUFFMAN_DEFAULT:
+   strategy = Z_DEFAULT_STRATEGY;
+   break;
+   case RTE_COMP_HUFFMAN_FIXED:
+   strategy = Z_FIXED;
+   break;
+   case RTE_COMP_HUFFMAN_DYNAMIC:
+   strategy = Z_DEFAULT_STRATEGY;
+   break;
+   default:
+   ZLIB_PMD_ERR("Compression strategy not supported\n");
+   return -1;
+   }
+   if (deflateInit2(strm, level,
+   Z_DEFLATED, wbits,
+   DEF_MEM_LEVEL, strategy) != Z_OK) {
+   ZLIB_PMD_ERR("Deflate init failed\n");
+   return -1;
+   }
+   break;
+
+   case RTE_COMP_DECOMPRESS:
+   /** window bits */
+   switch (xform->decompress.algo) {
+   case RTE_COMP_ALGO_DEFLATE:
+   wbits = -(xform->decompress.window_size);
+   break;
+   default:
+   ZLIB_PMD_ERR("Compression algorithm not supported\n");
+   return -1;
+   }
+
+   if (inflateInit2(strm, wbits) != Z_OK) {
+   ZLIB_PMD_ERR("Inflate init failed\n");
+   return -1;
+   }
+   break;
+   default:
+   return -1;
+   }
+   return 0;
+}
+
 static int
 zlib_create(const char *name,
struct rte_vdev_device *vdev,
diff --git a/drivers/compress/zlib/zlib_pmd_ops.c 
b/drivers/compress/zlib/zlib_pmd_ops.c
index 645c5b1..2fb6a85 100644
--- a/drivers/compress/zlib/zlib_pmd_ops.c
+++ b/drivers/compress/zlib/zlib_pmd_ops.c
@@ -214,6 +214,76 @@ zlib_pmd_qp_setup(struct rte_compressdev *dev, uint16_t 
qp_id,
return -1;
 }
 
+/** Configure stream */
+static int
+zlib_pmd_stream_create(struct rte_compressdev *dev,
+   const struct rte_comp_xform *xform,
+   void **zstream)
+{
+   int ret = 0;
+   struct zlib_stream *stream;
+   struct zlib_private *internals = dev->data->dev_private;
+
+   

[dpdk-dev] [PATCH v4 4/5] compress/zlib: support burst enqueue/dequeue

[Shally Verma]

From: Sunila Sahu 

Signed-off-by: Sunila Sahu 
Signed-off-by: Shally Verma 
Signed-off-by: Ashish Gupta 
---
 drivers/compress/zlib/zlib_pmd.c | 255 ++-
 1 file changed, 254 insertions(+), 1 deletion(-)

diff --git a/drivers/compress/zlib/zlib_pmd.c b/drivers/compress/zlib/zlib_pmd.c
index 47bc73d..dc1e230 100644
--- a/drivers/compress/zlib/zlib_pmd.c
+++ b/drivers/compress/zlib/zlib_pmd.c
@@ -7,7 +7,214 @@
 
 #include "zlib_pmd_private.h"
 
-/** Parse comp xform and set private xform/stream parameters */
+/** Compute next mbuf in the list, assign data buffer and length,
+ *  returns 0 if mbuf is NULL
+ */
+#define COMPUTE_BUF(mbuf, data, len)   \
+   ((mbuf = mbuf->next) ?  \
+   (data = rte_pktmbuf_mtod(mbuf, uint8_t *)), \
+   (len = rte_pktmbuf_data_len(mbuf)) : 0)
+
+static void
+process_zlib_deflate(struct rte_comp_op *op, z_stream *strm)
+{
+   int ret, flush, fin_flush;
+   struct rte_mbuf *mbuf_src = op->m_src;
+   struct rte_mbuf *mbuf_dst = op->m_dst;
+
+   switch (op->flush_flag) {
+   case RTE_COMP_FLUSH_FULL:
+   case RTE_COMP_FLUSH_FINAL:
+   fin_flush = Z_FINISH;
+   break;
+   default:
+   op->status = RTE_COMP_OP_STATUS_INVALID_ARGS;
+   ZLIB_PMD_ERR("Invalid flush value\n");
+   }
+
+   if (unlikely(!strm)) {
+   op->status = RTE_COMP_OP_STATUS_INVALID_ARGS;
+   ZLIB_PMD_ERR("Invalid z_stream\n");
+   return;
+   }
+   /* Update z_stream with the inputs provided by application */
+   strm->next_in = rte_pktmbuf_mtod_offset(mbuf_src, uint8_t *,
+   op->src.offset);
+
+   strm->avail_in = rte_pktmbuf_data_len(mbuf_src) - op->src.offset;
+
+   strm->next_out = rte_pktmbuf_mtod_offset(mbuf_dst, uint8_t *,
+   op->dst.offset);
+
+   strm->avail_out = rte_pktmbuf_data_len(mbuf_dst) - op->dst.offset;
+
+   /* Set flush value to NO_FLUSH unless it is last mbuf */
+   flush = Z_NO_FLUSH;
+   /* Initialize status to SUCCESS */
+   op->status = RTE_COMP_OP_STATUS_SUCCESS;
+
+   do {
+   /* Set flush value to Z_FINISH for last block */
+   if ((op->src.length - strm->total_in) <= strm->avail_in) {
+   strm->avail_in = (op->src.length - strm->total_in);
+   flush = fin_flush;
+   }
+   do {
+   ret = deflate(strm, flush);
+   if (unlikely(ret == Z_STREAM_ERROR)) {
+   /* error return, do not process further */
+   op->status =  RTE_COMP_OP_STATUS_ERROR;
+   goto def_end;
+   }
+   /* Break if Z_STREAM_END is encountered */
+   if (ret == Z_STREAM_END)
+   goto def_end;
+
+   /* Keep looping until input mbuf is consumed.
+* Exit if destination mbuf gets exhausted.
+*/
+   } while ((strm->avail_out == 0) &&
+   COMPUTE_BUF(mbuf_dst, strm->next_out, strm->avail_out));
+
+   if (!strm->avail_out) {
+   /* there is no space for compressed output */
+   op->status = RTE_COMP_OP_STATUS_OUT_OF_SPACE_TERMINATED;
+   break;
+   }
+
+   /* Update source buffer to next mbuf
+* Exit if input buffers are fully consumed
+*/
+   } while (COMPUTE_BUF(mbuf_src, strm->next_in, strm->avail_in));
+
+def_end:
+   /* Update op stats */
+   switch (op->status) {
+   case RTE_COMP_OP_STATUS_SUCCESS:
+   op->consumed += strm->total_in;
+   /* Fall-through */
+   case RTE_COMP_OP_STATUS_OUT_OF_SPACE_TERMINATED:
+   op->produced += strm->total_out;
+   break;
+   default:
+   ZLIB_PMD_ERR("stats not updated for status:%d\n",
+   op->status);
+   }
+
+   deflateReset(strm);
+}
+
+static void
+process_zlib_inflate(struct rte_comp_op *op, z_stream *strm)
+{
+   int ret, flush;
+   struct rte_mbuf *mbuf_src = op->m_src;
+   struct rte_mbuf *mbuf_dst = op->m_dst;
+
+   if (unlikely(!strm)) {
+   op->status = RTE_COMP_OP_STATUS_INVALID_ARGS;
+   ZLIB_PMD_ERR("Invalid z_stream\n");
+   return;
+   }
+   strm->next_in = rte_pktmbuf_mtod_offset(mbuf_src, uint8_t *,
+   op->src.offset);
+
+   strm->avail_in = rte_pktmbuf_data_len(mbuf_src) - op->src.offset;
+
+   strm->next_out = rte_pktmbuf_mtod_offset(mbuf_dst, uint8_t *,
+   op->dst.offset);
+
+   strm->avail_out = rte_pktmbuf_data_len(mbuf_dst) - op->dst.offset;
+
+   /** Ignoring flush value provi

[dpdk-dev] [PATCH v4 5/5] doc: add ZLIB PMD guide

[Shally Verma]

Add zlib pmd feature support and user guide with
build and run instructions

Signed-off-by: Sunila Sahu 
Signed-off-by: Shally Verma 
Signed-off-by: Ashish Gupta 
---
 MAINTAINERS   |  2 +
 doc/guides/compressdevs/features/zlib.ini | 11 +
 doc/guides/compressdevs/index.rst |  1 +
 doc/guides/compressdevs/zlib.rst  | 69 +++
 4 files changed, 83 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index ca27c6f..7e3c450 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -875,6 +875,8 @@ F: drivers/common/qat/
 ZLIB
 M: Sunila Sahu 
 F: drivers/compress/zlib/
+F: doc/guides/compressdevs/zlib.rst
+F: doc/guides/compressdevs/features/zlib.ini
 
 Eventdev Drivers
 
diff --git a/doc/guides/compressdevs/features/zlib.ini 
b/doc/guides/compressdevs/features/zlib.ini
new file mode 100644
index 000..c794643
--- /dev/null
+++ b/doc/guides/compressdevs/features/zlib.ini
@@ -0,0 +1,11 @@
+;
+; Refer to default.ini for the full list of available PMD features.
+;
+; Supported features of 'ZLIB' compression driver.
+;
+[Features]
+Pass-through   = Y
+Deflate= Y
+Fixed  = Y
+Dynamic= Y
+OOP SGL In SGL Out  = Y
diff --git a/doc/guides/compressdevs/index.rst 
b/doc/guides/compressdevs/index.rst
index 4228768..6ba6641 100644
--- a/doc/guides/compressdevs/index.rst
+++ b/doc/guides/compressdevs/index.rst
@@ -12,3 +12,4 @@ Compression Device Drivers
 overview
 isal
 qat_comp
+zlib
diff --git a/doc/guides/compressdevs/zlib.rst b/doc/guides/compressdevs/zlib.rst
new file mode 100644
index 000..c020792
--- /dev/null
+++ b/doc/guides/compressdevs/zlib.rst
@@ -0,0 +1,69 @@
+..  SPDX-License-Identifier: BSD-3-Clause
+Copyright(c) 2018 Cavium Networks.
+
+ZLIB Compression Poll Mode Driver
+==
+
+The ZLIB PMD (**librte_pmd_zlib**) provides poll mode compression &
+decompression driver based on SW zlib library,
+
+Features
+
+
+ZLIB PMD has support for:
+
+Compression/Decompression algorithm:
+
+* DEFLATE
+
+Huffman code type:
+
+* FIXED
+* DYNAMIC
+
+Window size support:
+
+* Min - 256 bytes
+* Max - 32K
+
+Limitations
+---
+
+* Stateful  not supported.
+
+Installation
+
+
+* To build DPDK with ZLIB library, the user is required to download the 
``libz`` library.
+* Use following command for installation.
+
+* For Fedora users::
+ sudo yum install zlib-devel
+* For Ubuntu users::
+ sudo apt-get install zlib1g-dev
+
+* Once downloaded, the user needs to build the library.
+
+* To build from sources
+  download zlib sources from http://zlib.net/ and do following before building 
DPDK::
+
+make
+sudo make install
+
+Initialization
+--
+
+In order to enable this virtual compression PMD, user must:
+
+* Set ``CONFIG_RTE_LIBRTE_PMD_ZLIB=y`` in config/common_base.
+
+To use the PMD in an application, user must:
+
+* Call ``rte_vdev_init("compress_zlib")`` within the application.
+
+* Use ``--vdev="compress_zlib"`` in the EAL options, which will call 
``rte_vdev_init()`` internally.
+
+The following parameter (optional) can be provided in the previous two calls:
+
+* ``socket_id:`` Specify the socket where the memory for the device is going 
to be allocated
+  (by default, socket_id will be the socket where the core that is creating 
the PMD is running on).
-- 
2.9.5

Re: [dpdk-dev] [PATCH v5 1/3] crypto/openssl: add rsa and mod asym op

[Stephen Hemminger]

On Mon, 23 Jul 2018 20:16:03 +0530
Shally Verma  wrote:

> +#define set_rsa_params(rsa, p, q, ret) \
> + do {rsa->p = p; rsa->q = q; ret = 0; } while (0)
> +
> +#define set_rsa_crt_params(rsa, dmp1, dmq1, iqmp, ret) \
> + do { \
> + rsa->dmp1 = dmp1; \
> + rsa->dmq1 = dmq1; \
> + rsa->iqmp = iqmp; \
> + ret = 0; \
> + } while (0)
> +
> +#define set_rsa_keys(rsa, n, e, d, ret) \
> + do { \
> + rsa->n = n; rsa->e = e; rsa->d = d; ret = 0; \
> + } while (0)
> +
> +#else
> +
> +#define set_rsa_params(rsa, p, q, ret) \
> + (ret = !RSA_set0_factors(rsa, p, q))
> +
> +#define set_rsa_crt_params(rsa, dmp1, dmq1, iqmp, ret) \
> + (ret = !RSA_set0_crt_params(rsa, dmp1, dmq1, iqmp))
> +
> +/* n, e must be non-null, d can be NULL */
> +#define set_rsa_keys(rsa, n, e, d, ret) \
> + (ret = !RSA_set0_key(rsa, n, e, d))
> +
> +#endif /* version < 1010 */
> +
> +#endif /* __RTA_COMPAT_H__ */

Please use inline functions instead of macros.
The crypto code seems to favor macros?

Macro's have no type checking and are not faster anyway.

Re: [dpdk-dev] [PATCH] sched: add 64-bit counter retrieval API

[Stephen Hemminger]

On Wed, 18 Jul 2018 15:51:39 +0100
alangordonde...@gmail.com wrote:

> From: Alan Dewar 
> 
> Add new APIs to retrieve counters in 64-bit wide fields.
> 
> Signed-off-by: Alan Dewar 

Do you want to consider 64 bit counter roll over on 32 bit platform?
The problem is that incrementing an 64 bit value is not atomic on
32 bit cpu. The carry operation can race with reading.

The kernel has special case code to do restartable sequence for
accessing 64 bit counter on 32 bit CPU. These functions become
nop's on 64bit.

Re: [dpdk-dev] [PATCH v3 4/5] compress/zlib: support burst enqueue/dequeue

[Stephen Hemminger]

On Sat, 21 Jul 2018 23:47:48 +0530
Shally Verma  wrote:

> -/** Parse comp xform and set private xform/stream parameters */
> +/** Compute next mbuf in the list, assign data buffer and length,
> + *  returns 0 if mbuf is NULL
> + */
> +#define COMPUTE_BUF(mbuf, data, len) \
> + ((mbuf = mbuf->next) ?  \
> + (data = rte_pktmbuf_mtod(mbuf, uint8_t *)), \
> + (len = rte_pktmbuf_data_len(mbuf)) : 0)
> +

Could this be an inline not a macro?

Re: [dpdk-dev] [PATCH v5 1/3] crypto/openssl: add rsa and mod asym op

[Verma, Shally]

>-Original Message-
>From: Stephen Hemminger 
>Sent: 23 July 2018 22:20
>To: Verma, Shally 
>Cc: pablo.de.lara.gua...@intel.com; dev@dpdk.org; Athreya, Narayana Prasad 
>; Murthy,
>Nidadavolu ; Sahu, Sunila 
>; Gupta, Ashish
>
>Subject: Re: [dpdk-dev] [PATCH v5 1/3] crypto/openssl: add rsa and mod asym op
>
>External Email
>
>On Mon, 23 Jul 2018 20:16:03 +0530
>Shally Verma  wrote:
>
>> +#define set_rsa_params(rsa, p, q, ret) \
>> + do {rsa->p = p; rsa->q = q; ret = 0; } while (0)
>> +
>> +#define set_rsa_crt_params(rsa, dmp1, dmq1, iqmp, ret) \
>> + do { \
>> + rsa->dmp1 = dmp1; \
>> + rsa->dmq1 = dmq1; \
>> + rsa->iqmp = iqmp; \
>> + ret = 0; \
>> + } while (0)
>> +
>> +#define set_rsa_keys(rsa, n, e, d, ret) \
>> + do { \
>> + rsa->n = n; rsa->e = e; rsa->d = d; ret = 0; \
>> + } while (0)
>> +
>> +#else
>> +
>> +#define set_rsa_params(rsa, p, q, ret) \
>> + (ret = !RSA_set0_factors(rsa, p, q))
>> +
>> +#define set_rsa_crt_params(rsa, dmp1, dmq1, iqmp, ret) \
>> + (ret = !RSA_set0_crt_params(rsa, dmp1, dmq1, iqmp))
>> +
>> +/* n, e must be non-null, d can be NULL */
>> +#define set_rsa_keys(rsa, n, e, d, ret) \
>> + (ret = !RSA_set0_key(rsa, n, e, d))
>> +
>> +#endif /* version < 1010 */
>> +
>> +#endif /* __RTA_COMPAT_H__ */
>
>Please use inline functions instead of macros.
>The crypto code seems to favor macros?
>
Since amount of code is very miniscule under each, so keeping as macro looked 
reasonable however, what goes in favour of inline than macros?

Thanks for feedback.
Shally

>Macro's have no type checking and are not faster anyway.

Re: [dpdk-dev] [PATCH v3 4/5] compress/zlib: support burst enqueue/dequeue

[Verma, Shally]

>-Original Message-
>From: Stephen Hemminger 
>Sent: 23 July 2018 22:24
>To: Verma, Shally 
>Cc: pablo.de.lara.gua...@intel.com; dev@dpdk.org; Athreya, Narayana Prasad 
>; Challa,
>Mahipal ; Gupta, Ashish ; 
>Sahu, Sunila ;
>Sahu, Sunila 
>Subject: Re: [dpdk-dev] [PATCH v3 4/5] compress/zlib: support burst 
>enqueue/dequeue
>
>External Email
>
>On Sat, 21 Jul 2018 23:47:48 +0530
>Shally Verma  wrote:
>
>> -/** Parse comp xform and set private xform/stream parameters */
>> +/** Compute next mbuf in the list, assign data buffer and length,
>> + *  returns 0 if mbuf is NULL
>> + */
>> +#define COMPUTE_BUF(mbuf, data, len) \
>> + ((mbuf = mbuf->next) ?  \
>> + (data = rte_pktmbuf_mtod(mbuf, uint8_t *)), \
>> + (len = rte_pktmbuf_data_len(mbuf)) : 0)
>> +
>
>Could this be an inline not a macro?
[Shally] Again what goes in favour of inline here? Just curious to know if DPDK 
has any preferred guidelines regarding this?

Thanks
Shally 

Re: [dpdk-dev] [PATCH v3 4/5] compress/zlib: support burst enqueue/dequeue

[Stephen Hemminger]

On Mon, 23 Jul 2018 17:14:26 +
"Verma, Shally"  wrote:

> >-Original Message-
> >From: Stephen Hemminger 
> >Sent: 23 July 2018 22:24
> >To: Verma, Shally 
> >Cc: pablo.de.lara.gua...@intel.com; dev@dpdk.org; Athreya, Narayana Prasad 
> >; Challa,
> >Mahipal ; Gupta, Ashish 
> >; Sahu, Sunila ;
> >Sahu, Sunila 
> >Subject: Re: [dpdk-dev] [PATCH v3 4/5] compress/zlib: support burst 
> >enqueue/dequeue
> >
> >External Email
> >
> >On Sat, 21 Jul 2018 23:47:48 +0530
> >Shally Verma  wrote:
> >  
> >> -/** Parse comp xform and set private xform/stream parameters */
> >> +/** Compute next mbuf in the list, assign data buffer and length,
> >> + *  returns 0 if mbuf is NULL
> >> + */
> >> +#define COMPUTE_BUF(mbuf, data, len) \
> >> + ((mbuf = mbuf->next) ?  \
> >> + (data = rte_pktmbuf_mtod(mbuf, uint8_t *)), \
> >> + (len = rte_pktmbuf_data_len(mbuf)) : 0)
> >> +  
> >
> >Could this be an inline not a macro?  
> [Shally] Again what goes in favour of inline here? Just curious to know if 
> DPDK has any preferred guidelines regarding this?
> 
> Thanks
> Shally 


Macros have no type checking and are harder to debug.
They should only be used when doing generic code (ie template like).

Re: [dpdk-dev] rte_mbuf library likely()/unlikely()

[Stephen Hemminger]

On Mon, 23 Jul 2018 15:53:42 +0200
Morten Brørup  wrote:

> Hi Olivier,
> 
>  
> 
> I noticed that __rte_pktmbuf_read() could do with an unlikely(), so I went 
> through the entire library. Here are my suggested modifications.
> 
>  
> 
>  
> 
> diff -bu rte_mbuf.c.orig rte_mbuf.c
> 
> --- rte_mbuf.c.orig 2018-07-23 15:13:22.0 +0200
> 
> +++ rte_mbuf.c  2018-07-23 15:32:53.0 +0200
> 
> @@ -173,19 +173,19 @@
> 
> {
> 
> unsigned int nb_segs, pkt_len;
> 
>  
> 
> -   if (m == NULL)
> 
> +   if (unlikely(m == NULL))
> 
> rte_panic("mbuf is NULL\n");
> 
>  

Adding is unlikely is not necessary since rte_panic is marked with cold 
attribute
which has the same effect.

Re: [dpdk-dev] rte_mbuf library likely()/unlikely()

[Honnappa Nagarahalli]

Do you see any performance improvements with these changes?

-Original Message-
From: dev  On Behalf Of Morten Brørup
Sent: Monday, July 23, 2018 8:54 AM
To: Olivier Matz 
Cc: dev@dpdk.org
Subject: [dpdk-dev] rte_mbuf library likely()/unlikely()

Hi Olivier,



I noticed that __rte_pktmbuf_read() could do with an unlikely(), so I went 
through the entire library. Here are my suggested modifications.





diff -bu rte_mbuf.c.orig rte_mbuf.c

--- rte_mbuf.c.orig 2018-07-23 15:13:22.0 +0200

+++ rte_mbuf.c  2018-07-23 15:32:53.0 +0200

@@ -173,19 +173,19 @@

{

unsigned int nb_segs, pkt_len;



-   if (m == NULL)

+   if (unlikely(m == NULL))

rte_panic("mbuf is NULL\n");



/* generic checks */

-   if (m->pool == NULL)

+   if (unlikely(m->pool == NULL))

rte_panic("bad mbuf pool\n");

-   if (m->buf_iova == 0)

+   if (unlikely(m->buf_iova == 0))

rte_panic("bad IO addr\n");

-   if (m->buf_addr == NULL)

+   if (unlikely(m->buf_addr == NULL))

rte_panic("bad virt addr\n");



uint16_t cnt = rte_mbuf_refcnt_read(m);

-   if ((cnt == 0) || (cnt == UINT16_MAX))

+   if (unlikely((cnt == 0) || (cnt == UINT16_MAX)))

rte_panic("bad ref cnt\n");



/* nothing to check for sub-segments */

@@ -193,7 +193,7 @@

return;



/* data_len is supposed to be not more than pkt_len */

-   if (m->data_len > m->pkt_len)

+   if (unlikely(m->data_len > m->pkt_len))

rte_panic("bad data_len\n");



nb_segs = m->nb_segs;

@@ -204,9 +204,9 @@

pkt_len -= m->data_len;

} while ((m = m->next) != NULL);



-   if (nb_segs)

+   if (unlikely(nb_segs))

rte_panic("bad nb_segs\n");

-   if (pkt_len)

+   if (unlikely(pkt_len))

rte_panic("bad pkt_len\n");

}



@@ -249,7 +249,7 @@

const struct rte_mbuf *seg = m;

uint32_t buf_off = 0, copy_len;



-   if (off + len > rte_pktmbuf_pkt_len(m))

+   if (unlikely(off + len > rte_pktmbuf_pkt_len(m)))

return NULL;



while (off >= rte_pktmbuf_data_len(seg)) {

@@ -257,7 +257,7 @@

seg = seg->next;

}



-   if (off + len <= rte_pktmbuf_data_len(seg))

+   if (likely(off + len <= rte_pktmbuf_data_len(seg)))

return rte_pktmbuf_mtod_offset(seg, char *, off);



/* rare case: header is split among several segments */

@@ -344,7 +344,7 @@

unsigned int i;

int ret;



-   if (buflen == 0)

+   if (unlikely(buflen == 0))

return -1;



buf[0] = '\0';

@@ -355,9 +355,9 @@

if (name == NULL)

name = rx_flags[i].default_name;

ret = snprintf(buf, buflen, "%s ", name);

-   if (ret < 0)

+   if (unlikely(ret < 0))

return -1;

-   if ((size_t)ret >= buflen)

+   if (unlikely((size_t)ret >= buflen))

return -1;

buf += ret;

buflen -= ret;

@@ -440,7 +440,7 @@

unsigned int i;

int ret;



-   if (buflen == 0)

+   if (unlikely(buflen == 0))

return -1;



buf[0] = '\0';

@@ -451,9 +451,9 @@

if (name == NULL)

name = tx_flags[i].default_name;

ret = snprintf(buf, buflen, "%s ", name);

-   if (ret < 0)

+   if (unlikely(ret < 0))

return -1;

-   if ((size_t)ret >= buflen)

+   if (unlikely((size_t)ret >= buflen))

return -1;

buf += ret;

buflen -= ret;





diff -bu rte_mbuf.h.orig rte_mbuf.h

--- rte_mbuf.h.orig 2018-07-23 15:13:26.0 +0200

+++ rte_mbuf.h  2018-07-23 15:24:25.0 +0200

@@ -1007,7 +1007,7 @@

{

struct rte_mbuf *m;



-   if (rte_mempool_get(mp, (void **)&m) < 0)

+   if (unlikely(rte_mempool_get(mp, (void **)&m) < 0))

return NULL;

MBUF_RAW_ALLOC_CHECK(m);

return m;

@@ -1268,7 +1268,7 @@

static inline struct rte_mbuf *rte_pktmbuf_alloc(struct rte_mempool *mp)

{

struct rte_mbuf *m;

-   if ((m = rte_mbuf_raw_alloc(mp)) != NULL)

+   if (likely((m = rte_mbuf_raw_alloc(mp)) != NULL))

rte_pktmbuf_reset(m);

return m;

}

@@ -1696,7 +1696,7 @@

{

struct rte_mbuf *m_next;



-   if (m != NULL)

+   if (likely(m != NULL))

__rte_mbuf_sanity_check(m, 1);



while (m != NULL) {

@@ -2099,7 +2099,7 @@

struct rte_mbuf *cur_tail;



/* Check for number-of-segments-overflow */

-   if (head->nb_segs + tail->nb_segs > RTE_MBUF_MAX_NB_SEGS)

+   if (unlike

Re: [dpdk-dev] [PATCH v4 5/5] doc: add ZLIB PMD guide

[De Lara Guarch, Pablo]

> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Shally Verma
> Sent: Monday, July 23, 2018 3:51 PM
> To: De Lara Guarch, Pablo 
> Cc: dev@dpdk.org; pathr...@caviumnetworks.com;
> mcha...@caviumnetworks.com; Sunila Sahu
> ; Ashish Gupta
> 
> Subject: [dpdk-dev] [PATCH v4 5/5] doc: add ZLIB PMD guide
> 
> Add zlib pmd feature support and user guide with build and run instructions
> 
> Signed-off-by: Sunila Sahu 
> Signed-off-by: Shally Verma 
> Signed-off-by: Ashish Gupta 
> ---
>  MAINTAINERS   |  2 +
>  doc/guides/compressdevs/features/zlib.ini | 11 +
>  doc/guides/compressdevs/index.rst |  1 +
>  doc/guides/compressdevs/zlib.rst  | 69
> +++
>  4 files changed, 83 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index ca27c6f..7e3c450 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -875,6 +875,8 @@ F: drivers/common/qat/  ZLIB
>  M: Sunila Sahu 
>  F: drivers/compress/zlib/
> +F: doc/guides/compressdevs/zlib.rst
> +F: doc/guides/compressdevs/features/zlib.ini
> 
>  Eventdev Drivers
>  
> diff --git a/doc/guides/compressdevs/features/zlib.ini
> b/doc/guides/compressdevs/features/zlib.ini
> new file mode 100644
> index 000..c794643
> --- /dev/null
> +++ b/doc/guides/compressdevs/features/zlib.ini
> @@ -0,0 +1,11 @@
> +;
> +; Refer to default.ini for the full list of available PMD features.
> +;
> +; Supported features of 'ZLIB' compression driver.
> +;
> +[Features]
> +Pass-through   = Y
> +Deflate= Y
> +Fixed  = Y
> +Dynamic= Y
> +OOP SGL In SGL Out  = Y

I assume that you support also "OOP SGL In LB Out" and "OOP LB In SGL Out", 
right?

[dpdk-dev] [PATCH] net/mlx5: fix assert for Tx completion queue count

[Yongseok Koh]

There should be at least one Tx CQE remained if Tx WQ and txq->elts[] have
available slots to send a packet because the size of Tx CQ is exactly
calculated from the size of other resources. As it is guaranteed, it is
checked by an assertion.

max_elts is checked after the assertion for Tx CQ. If no slot is available
in txq->elts[], the assertion would be wrong.

Fixes: 2eefbec531c7 ("net/mlx5: add missing sanity checks for Tx completion 
queue")
Fixes: 6ce84bd88919 ("net/mlx5: add enhanced multi-packet send for ConnectX-5")
Cc: sta...@dpdk.org

Signed-off-by: Yongseok Koh 
Acked-by: Xueming Li 
---
 drivers/net/mlx5/mlx5_rxtx.c  | 28 
 drivers/net/mlx5/mlx5_rxtx_vec_neon.h | 14 --
 drivers/net/mlx5/mlx5_rxtx_vec_sse.h  | 14 --
 3 files changed, 16 insertions(+), 40 deletions(-)

diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c
index 52a1074a8..2d14f8a6e 100644
--- a/drivers/net/mlx5/mlx5_rxtx.c
+++ b/drivers/net/mlx5/mlx5_rxtx.c
@@ -504,8 +504,6 @@ mlx5_tx_burst(void *dpdk_txq, struct rte_mbuf **pkts, 
uint16_t pkts_n)
/* Start processing. */
mlx5_tx_complete(txq);
max_elts = (elts_n - (elts_head - txq->elts_tail));
-   /* A CQE slot must always be available. */
-   assert((1u << txq->cqe_n) - (txq->cq_pi - txq->cq_ci));
max_wqe = (1u << txq->wqe_n) - (txq->wqe_ci - txq->wqe_pi);
if (unlikely(!max_wqe))
return 0;
@@ -817,14 +815,13 @@ mlx5_tx_burst(void *dpdk_txq, struct rte_mbuf **pkts, 
uint16_t pkts_n)
/* Check whether completion threshold has been reached. */
comp = txq->elts_comp + i + j + k;
if (comp >= MLX5_TX_COMP_THRESH) {
+   /* A CQE slot must always be available. */
+   assert((1u << txq->cqe_n) - (txq->cq_pi++ - txq->cq_ci));
/* Request completion on last WQE. */
last_wqe->ctrl2 = rte_cpu_to_be_32(8);
/* Save elts_head in unused "immediate" field of WQE. */
last_wqe->ctrl3 = txq->elts_head;
txq->elts_comp = 0;
-#ifndef NDEBUG
-   ++txq->cq_pi;
-#endif
} else {
txq->elts_comp = comp;
}
@@ -943,8 +940,6 @@ mlx5_tx_burst_mpw(void *dpdk_txq, struct rte_mbuf **pkts, 
uint16_t pkts_n)
/* Start processing. */
mlx5_tx_complete(txq);
max_elts = (elts_n - (elts_head - txq->elts_tail));
-   /* A CQE slot must always be available. */
-   assert((1u << txq->cqe_n) - (txq->cq_pi - txq->cq_ci));
max_wqe = (1u << txq->wqe_n) - (txq->wqe_ci - txq->wqe_pi);
if (unlikely(!max_wqe))
return 0;
@@ -1033,14 +1028,13 @@ mlx5_tx_burst_mpw(void *dpdk_txq, struct rte_mbuf 
**pkts, uint16_t pkts_n)
if (comp >= MLX5_TX_COMP_THRESH) {
volatile struct mlx5_wqe *wqe = mpw.wqe;
 
+   /* A CQE slot must always be available. */
+   assert((1u << txq->cqe_n) - (txq->cq_pi++ - txq->cq_ci));
/* Request completion on last WQE. */
wqe->ctrl[2] = rte_cpu_to_be_32(8);
/* Save elts_head in unused "immediate" field of WQE. */
wqe->ctrl[3] = elts_head;
txq->elts_comp = 0;
-#ifndef NDEBUG
-   ++txq->cq_pi;
-#endif
} else {
txq->elts_comp = comp;
}
@@ -1172,8 +1166,6 @@ mlx5_tx_burst_mpw_inline(void *dpdk_txq, struct rte_mbuf 
**pkts,
/* Start processing. */
mlx5_tx_complete(txq);
max_elts = (elts_n - (elts_head - txq->elts_tail));
-   /* A CQE slot must always be available. */
-   assert((1u << txq->cqe_n) - (txq->cq_pi - txq->cq_ci));
do {
struct rte_mbuf *buf = *(pkts++);
uintptr_t addr;
@@ -1330,14 +1322,13 @@ mlx5_tx_burst_mpw_inline(void *dpdk_txq, struct 
rte_mbuf **pkts,
if (comp >= MLX5_TX_COMP_THRESH) {
volatile struct mlx5_wqe *wqe = mpw.wqe;
 
+   /* A CQE slot must always be available. */
+   assert((1u << txq->cqe_n) - (txq->cq_pi++ - txq->cq_ci));
/* Request completion on last WQE. */
wqe->ctrl[2] = rte_cpu_to_be_32(8);
/* Save elts_head in unused "immediate" field of WQE. */
wqe->ctrl[3] = elts_head;
txq->elts_comp = 0;
-#ifndef NDEBUG
-   ++txq->cq_pi;
-#endif
} else {
txq->elts_comp = comp;
}
@@ -1461,8 +1452,6 @@ txq_burst_empw(struct mlx5_txq_data *txq, struct rte_mbuf 
**pkts,
/* Start processing. */
mlx5_tx_complete(txq);
max_elts = (elts_n - (elts_head - txq->elts_tail));
-   /* A CQE slot must always be available. */
-   assert((1u << txq->cqe_n) - (txq->cq_pi - txq->cq_ci));
max_wqe = (1u << txq->wqe_n) - (txq->wqe_ci - txq->wqe_pi);
if (unlikely(!max_wqe))
return 0;

Re: [dpdk-dev] [PATCH v4 5/5] doc: add ZLIB PMD guide

[Verma, Shally]

>-Original Message-
>From: De Lara Guarch, Pablo 
>Sent: 23 July 2018 23:28
>To: Verma, Shally 
>Cc: dev@dpdk.org; Athreya, Narayana Prasad 
>; Challa, Mahipal
>; Sahu, Sunila ; Gupta, 
>Ashish 
>Subject: RE: [dpdk-dev] [PATCH v4 5/5] doc: add ZLIB PMD guide
>
>External Email
>
>> -Original Message-
>> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Shally Verma
>> Sent: Monday, July 23, 2018 3:51 PM
>> To: De Lara Guarch, Pablo 
>> Cc: dev@dpdk.org; pathr...@caviumnetworks.com;
>> mcha...@caviumnetworks.com; Sunila Sahu
>> ; Ashish Gupta
>> 
>> Subject: [dpdk-dev] [PATCH v4 5/5] doc: add ZLIB PMD guide
>>
>> Add zlib pmd feature support and user guide with build and run instructions
>>
>> Signed-off-by: Sunila Sahu 
>> Signed-off-by: Shally Verma 
>> Signed-off-by: Ashish Gupta 
>> ---
>>  MAINTAINERS   |  2 +
>>  doc/guides/compressdevs/features/zlib.ini | 11 +
>>  doc/guides/compressdevs/index.rst |  1 +
>>  doc/guides/compressdevs/zlib.rst  | 69
>> +++
>>  4 files changed, 83 insertions(+)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index ca27c6f..7e3c450 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -875,6 +875,8 @@ F: drivers/common/qat/  ZLIB
>>  M: Sunila Sahu 
>>  F: drivers/compress/zlib/
>> +F: doc/guides/compressdevs/zlib.rst
>> +F: doc/guides/compressdevs/features/zlib.ini
>>
>>  Eventdev Drivers
>>  
>> diff --git a/doc/guides/compressdevs/features/zlib.ini
>> b/doc/guides/compressdevs/features/zlib.ini
>> new file mode 100644
>> index 000..c794643
>> --- /dev/null
>> +++ b/doc/guides/compressdevs/features/zlib.ini
>> @@ -0,0 +1,11 @@
>> +;
>> +; Refer to default.ini for the full list of available PMD features.
>> +;
>> +; Supported features of 'ZLIB' compression driver.
>> +;
>> +[Features]
>> +Pass-through   = Y
>> +Deflate= Y
>> +Fixed  = Y
>> +Dynamic= Y
>> +OOP SGL In SGL Out  = Y
>
>I assume that you support also "OOP SGL In LB Out" and "OOP LB In SGL Out", 
>right?
yes, but untested thus not claiming.

Thanks
Shally

[dpdk-dev] [PATCH v3] compress/isal: add chained mbuf support

[Daly, Lee]

This patch adds chained mbuf support for input or output buffers
during compression/decompression operations.

Signed-off-by: Lee Daly 
---
 doc/guides/compressdevs/features/isal.ini |  17 +-
 doc/guides/compressdevs/isal.rst  |   2 -
 drivers/compress/isal/isal_compress_pmd.c | 397 --
 drivers/compress/isal/isal_compress_pmd_ops.c |   5 +-
 4 files changed, 323 insertions(+), 98 deletions(-)

diff --git a/doc/guides/compressdevs/features/isal.ini 
b/doc/guides/compressdevs/features/isal.ini
index 7183d10..919cf70 100644
--- a/doc/guides/compressdevs/features/isal.ini
+++ b/doc/guides/compressdevs/features/isal.ini
@@ -4,10 +4,13 @@
 ; Supported features of 'ISA-L' compression driver.
 ;
 [Features]
-CPU SSE= Y
-CPU AVX= Y
-CPU AVX2   = Y
-CPU AVX512 = Y
-Deflate= Y
-Fixed  = Y
-Dynamic= Y
+CPU SSE= Y
+CPU AVX= Y
+CPU AVX2   = Y
+CPU AVX512 = Y
+OOP SGL In SGL Out = Y
+OOP SGL In LB  Out = Y
+OOP LB  In SGL Out = Y
+Deflate= Y
+Fixed  = Y
+Dynamic= Y
diff --git a/doc/guides/compressdevs/isal.rst b/doc/guides/compressdevs/isal.rst
index 276ff06..3bc3022 100644
--- a/doc/guides/compressdevs/isal.rst
+++ b/doc/guides/compressdevs/isal.rst
@@ -78,8 +78,6 @@ As a result the level mappings from the API to the PMD are 
shown below.
 Limitations
 ---
 
-* Chained mbufs will not be supported until a future release, meaning max data 
size being passed to PMD through a single mbuf is 64K - 1. If data is larger 
than this it will need to be split up and sent as multiple operations.
-
 * Compressdev level 0, no compression, is not supported.
 
 * Checksums will not be supported until future release.
diff --git a/drivers/compress/isal/isal_compress_pmd.c 
b/drivers/compress/isal/isal_compress_pmd.c
index 5966cc3..a776019 100644
--- a/drivers/compress/isal/isal_compress_pmd.c
+++ b/drivers/compress/isal/isal_compress_pmd.c
@@ -188,6 +188,206 @@ isal_comp_set_priv_xform_parameters(struct 
isal_priv_xform *priv_xform,
return 0;
 }
 
+/* Compression using chained mbufs for input/output data */
+static int
+chained_mbuf_compression(struct rte_comp_op *op, struct isal_comp_qp *qp)
+{
+   int ret;
+   uint32_t remaining_offset;
+   uint32_t remaining_data = op->src.length;
+   struct rte_mbuf *src = op->m_src;
+   struct rte_mbuf *dst = op->m_dst;
+
+   /* check for offset passing multiple segments
+* and point compression stream to input/output buffer
+*/
+   if (op->src.offset > src->data_len) {
+   remaining_offset = op->src.offset;
+   while (remaining_offset > src->data_len) {
+   remaining_offset -= src->data_len;
+   src = src->next;
+   }
+
+
+   qp->stream->avail_in = src->data_len - remaining_offset;
+   qp->stream->next_in = rte_pktmbuf_mtod_offset(src, uint8_t *,
+   (op->src.offset % src->data_len));
+   } else {
+   qp->stream->avail_in = src->data_len - op->src.offset;
+   qp->stream->next_in = rte_pktmbuf_mtod_offset(src, uint8_t *,
+   op->src.offset);
+   }
+
+   if (op->dst.offset > dst->data_len) {
+   remaining_offset = op->dst.offset;
+   while (remaining_offset > dst->data_len) {
+   remaining_offset -= dst->data_len;
+   dst = dst->next;
+   }
+
+   qp->stream->avail_out = dst->data_len - remaining_offset;
+   qp->stream->next_out = rte_pktmbuf_mtod_offset(dst, uint8_t *,
+   (op->dst.offset % dst->data_len));
+   } else {
+   qp->stream->avail_out = dst->data_len - op->dst.offset;
+   qp->stream->next_out = rte_pktmbuf_mtod_offset(dst, uint8_t *,
+   op->dst.offset);
+   }
+
+   if (unlikely(!qp->stream->next_in || !qp->stream->next_out)) {
+   ISAL_PMD_LOG(ERR, "Invalid source or destination buffer\n");
+   op->status = RTE_COMP_OP_STATUS_INVALID_ARGS;
+   return -1;
+   }
+
+   while (qp->stream->internal_state.state != ZSTATE_END) {
+   /* Last segment of data */
+   if (remaining_data <= src->data_len)
+   qp->stream->end_of_stream = 1;
+
+   /* Execute compression operation */
+   ret = isal_deflate(qp->stream);
+
+   remaining_data = op->src.length - qp->stream->total_in;
+
+   if (ret != COMP_OK) {
+   ISAL_PMD_LOG(ERR, "Compression operation failed\n");
+   op->status = RTE_COMP_OP_STATUS_ERROR;
+   return ret;
+   }
+
+   if (qp->stream->avail_in == 0 &&
+  

Re: [dpdk-dev] [PATCH v2 1/2] common/qat: add sgl header

[De Lara Guarch, Pablo]

> -Original Message-
> From: Trahe, Fiona
> Sent: Monday, July 23, 2018 2:06 PM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo ; Trahe, Fiona
> ; Jozwiak, TomaszX 
> Subject: [PATCH v2 1/2] common/qat: add sgl header
> 
> This patch refactors the sgl struct so it includes a flexible array of flat 
> buffers as
> sym and compress PMDs can have different size sgls.
> 
> Signed-off-by: Tomasz Jozwiak 
> Signed-off-by: Fiona Trahe 

Applied to dpdk-next-crypto.
Thanks,

Pablo

[dpdk-dev] [PATCH] net/mlx5: fix possible endless loop when clearing flow flags

[Yongseok Koh]

If one of (*priv->rxqs)[] is null, the for loop can iterate infinitely as
idx can't be increased.

Fixes: cd24d526395e ("net/mlx5: add mark/flag flow action")
Cc: Nelio Laranjeiro 

Signed-off-by: Yongseok Koh 
---
 drivers/net/mlx5/mlx5_flow.c | 8 +++-
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index 32854198b..c156f01eb 100644
--- a/drivers/net/mlx5/mlx5_flow.c
+++ b/drivers/net/mlx5/mlx5_flow.c
@@ -2762,22 +2762,20 @@ mlx5_flow_rxq_flags_clear(struct rte_eth_dev *dev)
 {
struct priv *priv = dev->data->dev_private;
unsigned int i;
-   unsigned int idx;
 
-   for (idx = 0, i = 0; idx != priv->rxqs_n; ++i) {
+   for (i = 0; i != priv->rxqs_n; ++i) {
struct mlx5_rxq_ctrl *rxq_ctrl;
unsigned int j;
 
-   if (!(*priv->rxqs)[idx])
+   if (!(*priv->rxqs)[i])
continue;
-   rxq_ctrl = container_of((*priv->rxqs)[idx],
+   rxq_ctrl = container_of((*priv->rxqs)[i],
struct mlx5_rxq_ctrl, rxq);
rxq_ctrl->flow_mark_n = 0;
rxq_ctrl->rxq.mark = 0;
for (j = 0; j != MLX5_FLOW_TUNNEL; ++j)
rxq_ctrl->flow_tunnels_n[j] = 0;
rxq_ctrl->rxq.tunnel = 0;
-   ++idx;
}
 }
 
-- 
2.11.0

Re: [dpdk-dev] rte_mbuf library likely()/unlikely()

[Morten Brørup]

> -Original Message-
> From: Stephen Hemminger [mailto:step...@networkplumber.org]
> Sent: Monday, July 23, 2018 7:38 PM
> To: Morten Brørup
> Cc: Olivier Matz; dev@dpdk.org
> Subject: Re: [dpdk-dev] rte_mbuf library likely()/unlikely()
> 
> On Mon, 23 Jul 2018 15:53:42 +0200
> Morten Brørup  wrote:
> 
> > Hi Olivier,
> >
> >
> >
> > I noticed that __rte_pktmbuf_read() could do with an unlikely(), so I
> went through the entire library. Here are my suggested modifications.
> >
> >
> >
> >
> >
> > diff -bu rte_mbuf.c.orig rte_mbuf.c
> >
> > --- rte_mbuf.c.orig 2018-07-23 15:13:22.0 +0200
> >
> > +++ rte_mbuf.c  2018-07-23 15:32:53.0 +0200
> >
> > @@ -173,19 +173,19 @@
> >
> > {
> >
> > unsigned int nb_segs, pkt_len;
> >
> >
> >
> > -   if (m == NULL)
> >
> > +   if (unlikely(m == NULL))
> >
> > rte_panic("mbuf is NULL\n");
> >
> >
> 
> Adding is unlikely is not necessary since rte_panic is marked with cold
> attribute
> which has the same effect.

I was not aware of this. Although it is not visible from the source code files 
using rte_panic(), it probably means we shouldn't as so much as I thought. 
Here's an updated patch for rte_mbuf.c, where it is relevant. The other two 
suggested patches are unaffected.

diff -bu rte_mbuf.c.orig rte_mbuf.c
--- rte_mbuf.c.orig 2018-07-23 15:13:22.0 +0200
+++ rte_mbuf.c  2018-07-23 20:52:35.0 +0200
@@ -249,7 +249,7 @@
const struct rte_mbuf *seg = m;
uint32_t buf_off = 0, copy_len;

-   if (off + len > rte_pktmbuf_pkt_len(m))
+   if (unlikely(off + len > rte_pktmbuf_pkt_len(m)))
return NULL;

while (off >= rte_pktmbuf_data_len(seg)) {
@@ -257,7 +257,7 @@
seg = seg->next;
}

-   if (off + len <= rte_pktmbuf_data_len(seg))
+   if (likely(off + len <= rte_pktmbuf_data_len(seg)))
return rte_pktmbuf_mtod_offset(seg, char *, off);

/* rare case: header is split among several segments */
@@ -344,7 +344,7 @@
unsigned int i;
int ret;

-   if (buflen == 0)
+   if (unlikely(buflen == 0))
return -1;

buf[0] = '\0';
@@ -355,9 +355,9 @@
if (name == NULL)
name = rx_flags[i].default_name;
ret = snprintf(buf, buflen, "%s ", name);
-   if (ret < 0)
+   if (unlikely(ret < 0))
return -1;
-   if ((size_t)ret >= buflen)
+   if (unlikely((size_t)ret >= buflen))
return -1;
buf += ret;
buflen -= ret;
@@ -440,7 +440,7 @@
unsigned int i;
int ret;

-   if (buflen == 0)
+   if (unlikely(buflen == 0))
return -1;

buf[0] = '\0';
@@ -451,9 +451,9 @@
if (name == NULL)
name = tx_flags[i].default_name;
ret = snprintf(buf, buflen, "%s ", name);
-   if (ret < 0)
+   if (unlikely(ret < 0))
return -1;
-   if ((size_t)ret >= buflen)
+   if (unlikely((size_t)ret >= buflen))
return -1;
buf += ret;
buflen -= ret;


Med venlig hilsen / kind regards
- Morten Brørup

Re: [dpdk-dev] rte_mbuf library likely()/unlikely()

[Morten Brørup]

I haven't performance tested, but they are compiler branch prediction hints 
pointing out the most likely execution path, so I expect them to have a 
positive effect.

E.g. the first comparison in __rte_pktmbuf_read() is very unlikely to be true - 
it would mean that the application is trying to read data beyond the packet.

Please also refer to:
https://cellperformance.beyond3d.com/articles/2006/04/branch-patterns-using-gcc.html


> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Honnappa Nagarahalli
> Sent: Monday, July 23, 2018 7:52 PM
> To: Morten Brørup; Olivier Matz
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] rte_mbuf library likely()/unlikely()
> 
> Do you see any performance improvements with these changes?
> 
> -Original Message-
> From: dev  On Behalf Of Morten Brørup
> Sent: Monday, July 23, 2018 8:54 AM
> To: Olivier Matz 
> Cc: dev@dpdk.org
> Subject: [dpdk-dev] rte_mbuf library likely()/unlikely()
> 
> Hi Olivier,
> 
> 
> 
> I noticed that __rte_pktmbuf_read() could do with an unlikely(), so I went
> through the entire library. Here are my suggested modifications.
> 

Re: [dpdk-dev] rte_mbuf library likely()/unlikely()

[Stephen Hemminger]

On Mon, 23 Jul 2018 20:59:29 +0200
Morten Brørup  wrote:

> > -Original Message-
> > From: Stephen Hemminger [mailto:step...@networkplumber.org]
> > Sent: Monday, July 23, 2018 7:38 PM
> > To: Morten Brørup
> > Cc: Olivier Matz; dev@dpdk.org
> > Subject: Re: [dpdk-dev] rte_mbuf library likely()/unlikely()
> > 
> > On Mon, 23 Jul 2018 15:53:42 +0200
> > Morten Brørup  wrote:
> >   
> > > Hi Olivier,
> > >
> > >
> > >
> > > I noticed that __rte_pktmbuf_read() could do with an unlikely(), so I  
> > went through the entire library. Here are my suggested modifications.  
> > >
> > >
> > >
> > >
> > >
> > > diff -bu rte_mbuf.c.orig rte_mbuf.c
> > >
> > > --- rte_mbuf.c.orig 2018-07-23 15:13:22.0 +0200
> > >
> > > +++ rte_mbuf.c  2018-07-23 15:32:53.0 +0200
> > >
> > > @@ -173,19 +173,19 @@
> > >
> > > {
> > >
> > > unsigned int nb_segs, pkt_len;
> > >
> > >
> > >
> > > -   if (m == NULL)
> > >
> > > +   if (unlikely(m == NULL))
> > >
> > > rte_panic("mbuf is NULL\n");
> > >
> > >  
> > 
> > Adding is unlikely is not necessary since rte_panic is marked with cold
> > attribute
> > which has the same effect.  
> 
> I was not aware of this. Although it is not visible from the source code 
> files using rte_panic(), it probably means we shouldn't as so much as I 
> thought. Here's an updated patch for rte_mbuf.c, where it is relevant. The 
> other two suggested patches are unaffected.
> 
> diff -bu rte_mbuf.c.orig rte_mbuf.c
> --- rte_mbuf.c.orig 2018-07-23 15:13:22.0 +0200
> +++ rte_mbuf.c  2018-07-23 20:52:35.0 +0200
> @@ -249,7 +249,7 @@
> const struct rte_mbuf *seg = m;
> uint32_t buf_off = 0, copy_len;
> 
> -   if (off + len > rte_pktmbuf_pkt_len(m))
> +   if (unlikely(off + len > rte_pktmbuf_pkt_len(m)))
> return NULL;
> 
> while (off >= rte_pktmbuf_data_len(seg)) {
> @@ -257,7 +257,7 @@
> seg = seg->next;
> }
> 
> -   if (off + len <= rte_pktmbuf_data_len(seg))
> +   if (likely(off + len <= rte_pktmbuf_data_len(seg)))
> return rte_pktmbuf_mtod_offset(seg, char *, off);
> 
> /* rare case: header is split among several segments */
> @@ -344,7 +344,7 @@
> unsigned int i;
> int ret;
> 
> -   if (buflen == 0)
> +   if (unlikely(buflen == 0))
> return -1;
> 
> buf[0] = '\0';
> @@ -355,9 +355,9 @@
> if (name == NULL)
> name = rx_flags[i].default_name;
> ret = snprintf(buf, buflen, "%s ", name);
> -   if (ret < 0)
> +   if (unlikely(ret < 0))
> return -1;
> -   if ((size_t)ret >= buflen)
> +   if (unlikely((size_t)ret >= buflen))
> return -1;
> buf += ret;
> buflen -= ret;
> @@ -440,7 +440,7 @@
> unsigned int i;
> int ret;
> 
> -   if (buflen == 0)
> +   if (unlikely(buflen == 0))
> return -1;
> 
> buf[0] = '\0';
> @@ -451,9 +451,9 @@
> if (name == NULL)
> name = tx_flags[i].default_name;
> ret = snprintf(buf, buflen, "%s ", name);
> -   if (ret < 0)
> +   if (unlikely(ret < 0))
> return -1;
> -   if ((size_t)ret >= buflen)
> +   if (unlikely((size_t)ret >= buflen))
> return -1;
> buf += ret;
> buflen -= ret;
> 
> 
> Med venlig hilsen / kind regards
> - Morten Brørup

Yes, this makes sense.

Please format patch with signed-off-by and submit according to
the contributing guidelines Creating Patches section.

https://doc.dpdk.org/guides/contributing/patches.html

Re: [dpdk-dev] [PATCH] ethdev: move sanity checks to non-debug paths

[Andrew Rybchenko]

On 23.07.2018 17:19, Ananyev, Konstantin wrote:

-Original Message-
From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Matan Azrad
Sent: Monday, July 23, 2018 1:14 PM
To: Aaron Conole 
Cc: dev@dpdk.org; Yigit, Ferruh ; Marcelo Leitner 
; Shahaf Shuler
; Ori Kam ; Thomas Monjalon 

Subject: Re: [dpdk-dev] [PATCH] ethdev: move sanity checks to non-debug paths


Hi Aaron
From: Aaron Conole

Sent: Monday, July 23, 2018 2:52 PM
To: Matan Azrad 
Cc: dev@dpdk.org; Ferruh Yigit ; Marcelo Leitner
; Shahaf Shuler ; Ori Kam
; Thomas Monjalon 
Subject: Re: [dpdk-dev] [PATCH] ethdev: move sanity checks to non-debug paths

Matan Azrad  writes:


Hi Aaron

From: Aaron Conole

These checks would have prevented a reported crash in the field.  If
a user builds without ETHDEV_DEBUG, it should make their application
more stable, not less.

Many of these functions immediately dereference arrays based on the
passed in values, so the sanity checks are quite important.


These functions are datapath functions.
Do you really want to add more 3 checks + calculations per each burst call?
Did you check the performance impact?
I think that performance numbers must be added for the discussion of this

patch.

I'll dig up performance numbers - but performance doesn't mean anything if
the application isn't running any longer due to crash.

Yes, I understand your point, but think about that, if we are going to defend 
each user mistake it will cost a lot.
For example in Tx path, Adding checks for each mbuf pointer and mbuf data 
validity will be very expensive.

I think the best way is to check the common user mistakes in DEBUG mode to help 
for application debugging and that's it.

+1
The problem is that user provided an invalid input parameters.
Adding just extra checks inside data-path functions wouldn't solve it.
Konstantin


+1, I agree with Matan and Konstantin
So, NACK


The logs are left as DEBUG only.

Cc: Marcelo Leitner 
Signed-off-by: Aaron Conole 
---
  lib/librte_ethdev/rte_ethdev.h | 29 +
  1 file changed, 13 insertions(+), 16 deletions(-)

diff --git a/lib/librte_ethdev/rte_ethdev.h
b/lib/librte_ethdev/rte_ethdev.h index f5f593b31..bfd6a3406 100644
--- a/lib/librte_ethdev/rte_ethdev.h
+++ b/lib/librte_ethdev/rte_ethdev.h
@@ -3805,15 +3805,16 @@ rte_eth_rx_burst(uint16_t port_id, uint16_t
queue_id,
struct rte_eth_dev *dev = &rte_eth_devices[port_id];
uint16_t nb_rx;

-#ifdef RTE_LIBRTE_ETHDEV_DEBUG
RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, 0);
RTE_FUNC_PTR_OR_ERR_RET(*dev->rx_pkt_burst, 0);

if (queue_id >= dev->data->nb_rx_queues) {
+#ifdef RTE_LIBRTE_ETHDEV_DEBUG
RTE_ETHDEV_LOG(ERR, "Invalid RX queue_id=%u\n",

queue_id);

+#endif
return 0;
}
-#endif
+
nb_rx = (*dev->rx_pkt_burst)(dev->data->rx_queues[queue_id],
 rx_pkts, nb_pkts);

@@ -3928,14 +3929,12 @@ rte_eth_rx_descriptor_status(uint16_t
port_id, uint16_t queue_id,
struct rte_eth_dev *dev;
void *rxq;

-#ifdef RTE_LIBRTE_ETHDEV_DEBUG
RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV); -#endif
dev = &rte_eth_devices[port_id];
-#ifdef RTE_LIBRTE_ETHDEV_DEBUG
+
if (queue_id >= dev->data->nb_rx_queues)
return -ENODEV;
-#endif
+
RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->rx_descriptor_status, -
ENOTSUP);
rxq = dev->data->rx_queues[queue_id];

@@ -3985,14 +3984,12 @@ static inline int
rte_eth_tx_descriptor_status(uint16_t port_id,
struct rte_eth_dev *dev;
void *txq;

-#ifdef RTE_LIBRTE_ETHDEV_DEBUG
RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV); -#endif
dev = &rte_eth_devices[port_id];
-#ifdef RTE_LIBRTE_ETHDEV_DEBUG
+
if (queue_id >= dev->data->nb_tx_queues)
return -ENODEV;
-#endif
+
RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->tx_descriptor_status, -
ENOTSUP);
txq = dev->data->tx_queues[queue_id];

@@ -4071,15 +4068,15 @@ rte_eth_tx_burst(uint16_t port_id, uint16_t
queue_id,  {
struct rte_eth_dev *dev = &rte_eth_devices[port_id];

-#ifdef RTE_LIBRTE_ETHDEV_DEBUG
RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, 0);
RTE_FUNC_PTR_OR_ERR_RET(*dev->tx_pkt_burst, 0);

if (queue_id >= dev->data->nb_tx_queues) {
+#ifdef RTE_LIBRTE_ETHDEV_DEBUG
RTE_ETHDEV_LOG(ERR, "Invalid TX queue_id=%u\n",

queue_id);

+#endif
return 0;
}
-#endif

  #ifdef RTE_ETHDEV_RXTX_CALLBACKS
struct rte_eth_rxtx_callback *cb = dev->pre_tx_burst_cbs[queue_id];
@@ -4160,23 +4157,23 @@ rte_eth_tx_prepare(uint16_t port_id, uint16_t
queue_id,  {
struct rte_eth_dev *dev;

-#ifdef RTE_LIBRTE_ETHDEV_DEBUG
if (!rte_eth_dev_is_valid_port(port_id)) {
+#ifdef RTE_LIBRTE_ETHDEV_DEBUG
RTE_ETHDEV_LOG(ERR, "Invalid TX port_id=%u\n", port_id);
+#endif
rte_errno = -EINVAL;
return 0;
}
-#en

Re: [dpdk-dev] [PATCH v3] examples/flow_filtering: add rte_fdir_conf initialization

[Ferruh Yigit]

On 7/22/2018 11:39 AM, Rosen Xu wrote:
> Rte_fdir_conf of rte_eth_conf should be initialized before
> port initialization. It is a workaround solution when working
> with Intel I40e.
> 
> Fixes: 4a3ef59a10c8 ("examples/flow_filtering: add simple demo of flow API")
> Cc: sta...@dpdk.org
> 
> Signed-off-by: Rosen Xu 
> Acked-by: Ori Kam 

Reviewed-by: Ferruh Yigit 

Re: [dpdk-dev] Bypass support in the i40e PMD driver

[Ferruh Yigit]

On 7/20/2018 7:39 PM, EJ Raymond wrote:
> Hi,
> 
> I'm currently working with the PE310G4BPI71 Bypass card from Silicom, Inc.,
> This board is based on the i40E chip (Intel X710 - Fortville). In DPDK,
> this card makes use of the i40e PMD driver, and I've noticed that bypass
> configuration is only supported in the IXGBE PMD driver today. Can anyone
> say if there'll be support for configuring the various bypass modes and
> watchdog timer in the librte_pmd_i40e driver in the future?

cc'ed i40e maintainers.

> 
> Thanks,
> EJ
> 

Re: [dpdk-dev] [dpdk-stable] [PATCH] doc: fix incorrect create bonding command in testpmd

[Ferruh Yigit]

On 7/23/2018 12:27 PM, Shreyansh Jain wrote:
> Fixes: e76d7a768ce0 ("doc: fix syntax in testpmd user guide")
> Cc: john.mcnam...@intel.com
> Cc: sta...@dpdk.org
> 
> Signed-off-by: Shreyansh Jain 
> ---
> Note: Though the git blame suggest e76d7a768c as the last modification
>   for fixes, this actually existed when testpmd doc was added.

You are right, I think fixes should be initial commit:
Fixes: ac718398f477 ("doc: testpmd application user guide")

Reviewed-by: Ferruh Yigit 

[dpdk-dev] [PATCH] net/mlx5: fix queue rollback when starting device

[Yongseok Koh]

mlx5_rxq_start() and mlx5_rxq_stop() must be strictly paired because
internal reference counter is increased or decreased inside. Also,
mlx5_rxq_get() must be paired with mlx5_rxq_release().

Fixes: 7d6bf6b866b8 ("net/mlx5: add Multi-Packet Rx support")
Fixes: a1366b1a2be3 ("net/mlx5: add reference counter on DPDK Rx queues")
Fixes: 6e78005a9b30 ("net/mlx5: add reference counter on DPDK Tx queues")
Cc: sta...@dpdk.org

Signed-off-by: Yongseok Koh 
---
 drivers/net/mlx5/mlx5_trigger.c | 33 -
 1 file changed, 20 insertions(+), 13 deletions(-)

diff --git a/drivers/net/mlx5/mlx5_trigger.c b/drivers/net/mlx5/mlx5_trigger.c
index 4d2078bbd..ef499d898 100644
--- a/drivers/net/mlx5/mlx5_trigger.c
+++ b/drivers/net/mlx5/mlx5_trigger.c
@@ -46,7 +46,6 @@ mlx5_txq_start(struct rte_eth_dev *dev)
unsigned int i;
int ret;
 
-   /* Add memory regions to Tx queues. */
for (i = 0; i != priv->txqs_n; ++i) {
struct mlx5_txq_ctrl *txq_ctrl = mlx5_txq_get(dev, i);
 
@@ -60,12 +59,17 @@ mlx5_txq_start(struct rte_eth_dev *dev)
}
}
ret = mlx5_tx_uar_remap(dev, priv->ctx->cmd_fd);
-   if (ret)
+   if (ret) {
+   /* Adjust index for rollback. */
+   i = priv->txqs_n - 1;
goto error;
+   }
return 0;
 error:
ret = rte_errno; /* Save rte_errno before cleanup. */
-   mlx5_txq_stop(dev);
+   do {
+   mlx5_txq_release(dev, i);
+   } while (i-- != 0);
rte_errno = ret; /* Restore rte_errno. */
return -rte_errno;
 }
@@ -103,8 +107,10 @@ mlx5_rxq_start(struct rte_eth_dev *dev)
int ret = 0;
 
/* Allocate/reuse/resize mempool for Multi-Packet RQ. */
-   if (mlx5_mprq_alloc_mp(dev))
-   goto error;
+   if (mlx5_mprq_alloc_mp(dev)) {
+   /* Should not release Rx queues but return immediately. */
+   return -rte_errno;
+   }
for (i = 0; i != priv->rxqs_n; ++i) {
struct mlx5_rxq_ctrl *rxq_ctrl = mlx5_rxq_get(dev, i);
struct rte_mempool *mp;
@@ -130,7 +136,9 @@ mlx5_rxq_start(struct rte_eth_dev *dev)
return 0;
 error:
ret = rte_errno; /* Save rte_errno before cleanup. */
-   mlx5_rxq_stop(dev);
+   do {
+   mlx5_rxq_release(dev, i);
+   } while (i-- != 0);
rte_errno = ret; /* Restore rte_errno. */
return -rte_errno;
 }
@@ -152,21 +160,21 @@ mlx5_dev_start(struct rte_eth_dev *dev)
struct priv *priv = dev->data->dev_private;
int ret;
 
-   dev->data->dev_started = 1;
-   DRV_LOG(DEBUG, "port %u allocating and configuring hash Rx queues",
-   dev->data->port_id);
+   DRV_LOG(DEBUG, "port %u starting device", dev->data->port_id);
ret = mlx5_txq_start(dev);
if (ret) {
DRV_LOG(ERR, "port %u Tx queue allocation failed: %s",
dev->data->port_id, strerror(rte_errno));
-   goto error;
+   return -rte_errno;
}
ret = mlx5_rxq_start(dev);
if (ret) {
DRV_LOG(ERR, "port %u Rx queue allocation failed: %s",
dev->data->port_id, strerror(rte_errno));
-   goto error;
+   mlx5_txq_stop(dev);
+   return -rte_errno;
}
+   dev->data->dev_started = 1;
ret = mlx5_rx_intr_vec_enable(dev);
if (ret) {
DRV_LOG(ERR, "port %u Rx interrupt vector creation failed",
@@ -221,8 +229,7 @@ mlx5_dev_stop(struct rte_eth_dev *dev)
dev->tx_pkt_burst = removed_tx_burst;
rte_wmb();
usleep(1000 * priv->rxqs_n);
-   DRV_LOG(DEBUG, "port %u cleaning up and destroying hash Rx queues",
-   dev->data->port_id);
+   DRV_LOG(DEBUG, "port %u stopping device", dev->data->port_id);
mlx5_flow_stop(dev, &priv->flows);
mlx5_traffic_disable(dev);
mlx5_rx_intr_vec_disable(dev);
-- 
2.11.0

Re: [dpdk-dev] [PATCH v3] compress/isal: add chained mbuf support

[De Lara Guarch, Pablo]

Hi Lee,

> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Daly, Lee
> Sent: Monday, July 23, 2018 7:02 PM
> To: De Lara Guarch, Pablo 
> Cc: dev@dpdk.org; Daly, Lee 
> Subject: [dpdk-dev] [PATCH v3] compress/isal: add chained mbuf support
> 
> This patch adds chained mbuf support for input or output buffers during
> compression/decompression operations.
> 
> Signed-off-by: Lee Daly 
> ---
>  doc/guides/compressdevs/features/isal.ini |  17 +-
>  doc/guides/compressdevs/isal.rst  |   2 -
>  drivers/compress/isal/isal_compress_pmd.c | 397 ---
> ---

...

> +++ b/drivers/compress/isal/isal_compress_pmd.c
> @@ -188,6 +188,206 @@ isal_comp_set_priv_xform_parameters(struct
> isal_priv_xform *priv_xform,
>   return 0;
>  }
> 
> +/* Compression using chained mbufs for input/output data */ static int
> +chained_mbuf_compression(struct rte_comp_op *op, struct isal_comp_qp
> +*qp) {
> + int ret;
> + uint32_t remaining_offset;
> + uint32_t remaining_data = op->src.length;
> + struct rte_mbuf *src = op->m_src;
> + struct rte_mbuf *dst = op->m_dst;
> +
> + /* check for offset passing multiple segments
> +  * and point compression stream to input/output buffer
> +  */
> + if (op->src.offset > src->data_len) {

Check also for equal here (offset >= data_len).
In that case, you need to get the next segment and start from byte 0 there.

> + remaining_offset = op->src.offset;
> + while (remaining_offset > src->data_len) {

Same here, check for equal too.
> + remaining_offset -= src->data_len;
> + src = src->next;
> + }
> +
> +
> + qp->stream->avail_in = src->data_len - remaining_offset;

I think we need to check for minimum value between "data_len - 
remaining_offset" and src.length.

> + qp->stream->next_in = rte_pktmbuf_mtod_offset(src, uint8_t *,
> + (op->src.offset % src->data_len));

Use remaining_offset here.

> + } else {
> + qp->stream->avail_in = src->data_len - op->src.offset;

Same thing here, about the minimum value with src.length.
Actually, I think you can remove the if and just keep the code under if (remove 
the code under else).
It should work for both cases, and you save one extra condition.

> + qp->stream->next_in = rte_pktmbuf_mtod_offset(src, uint8_t *,
> + op->src.offset);
> + }
> +
> + if (op->dst.offset > dst->data_len) {
> + remaining_offset = op->dst.offset;
> + while (remaining_offset > dst->data_len) {
> + remaining_offset -= dst->data_len;
> + dst = dst->next;
> + }
> +
> + qp->stream->avail_out = dst->data_len - remaining_offset;
> + qp->stream->next_out = rte_pktmbuf_mtod_offset(dst, uint8_t
> *,
> + (op->dst.offset % dst->data_len));
> + } else {
> + qp->stream->avail_out = dst->data_len - op->dst.offset;
> + qp->stream->next_out = rte_pktmbuf_mtod_offset(dst, uint8_t
> *,
> + op->dst.offset);
> + }

Same comments apply for the destination buffer (except for the src.length ones).

> +
> + if (unlikely(!qp->stream->next_in || !qp->stream->next_out)) {
> + ISAL_PMD_LOG(ERR, "Invalid source or destination buffer\n");
> + op->status = RTE_COMP_OP_STATUS_INVALID_ARGS;
> + return -1;
> + }
> +

...

> +int chained_mbuf_decompression(struct rte_comp_op *op, struct
> +isal_comp_qp *qp) {
> + int ret;
> + uint32_t consumed_data, remaining_offset;
> + uint32_t remaining_data = op->src.length;
> + struct rte_mbuf *src = op->m_src;
> + struct rte_mbuf *dst = op->m_dst;
> +
> + /* check for offset passing multiple segments
> +  * and point decompression state to input/output buffer
> +  */
> + if (op->src.offset > src->data_len) {
> + remaining_offset = op->src.offset;
> + while (remaining_offset > src->data_len) {
> + remaining_offset -= src->data_len;
> + src = src->next;
> + }
> +
> + qp->state->avail_in = src->data_len - remaining_offset;
> + qp->state->next_in = rte_pktmbuf_mtod_offset(src,
> + uint8_t *, (op->src.offset % src->data_len));
> + } else {
> + qp->state->avail_in = src->data_len - op->src.offset;
> + qp->state->next_in = rte_pktmbuf_mtod_offset(src, uint8_t *,
> + op->src.offset);
> + }
> + if (op->dst.offset > dst->data_len) {
> + remaining_offset = op->dst.offset;
> + while (remaining_offset > dst->data_len) {
> + remaining_offset -= dst->data_len;
> + dst = dst->next;
> +

Re: [dpdk-dev] [PATCH v4 5/5] doc: add ZLIB PMD guide

[De Lara Guarch, Pablo]

Hi Shally,

> -Original Message-
> From: Verma, Shally [mailto:shally.ve...@cavium.com]
> Sent: Monday, July 23, 2018 7:00 PM
> To: De Lara Guarch, Pablo 
> Cc: dev@dpdk.org; Athreya, Narayana Prasad
> ; Challa, Mahipal
> ; Sahu, Sunila ;
> Gupta, Ashish 
> Subject: RE: [dpdk-dev] [PATCH v4 5/5] doc: add ZLIB PMD guide
> 
> 
> 
> >-Original Message-
> >From: De Lara Guarch, Pablo 
> >Sent: 23 July 2018 23:28
> >To: Verma, Shally 
> >Cc: dev@dpdk.org; Athreya, Narayana Prasad
> >; Challa, Mahipal
> >; Sahu, Sunila ;
> >Gupta, Ashish 
> >Subject: RE: [dpdk-dev] [PATCH v4 5/5] doc: add ZLIB PMD guide
> >
> >External Email
> >
> >> -Original Message-
> >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Shally Verma
> >> Sent: Monday, July 23, 2018 3:51 PM
> >> To: De Lara Guarch, Pablo 
> >> Cc: dev@dpdk.org; pathr...@caviumnetworks.com;
> >> mcha...@caviumnetworks.com; Sunila Sahu
> >> ; Ashish Gupta
> >> 
> >> Subject: [dpdk-dev] [PATCH v4 5/5] doc: add ZLIB PMD guide
> >>
> >> Add zlib pmd feature support and user guide with build and run
> >> instructions
> >>
> >> Signed-off-by: Sunila Sahu 
> >> Signed-off-by: Shally Verma 
> >> Signed-off-by: Ashish Gupta 
> >> ---
> >>  MAINTAINERS   |  2 +
> >>  doc/guides/compressdevs/features/zlib.ini | 11 +
> >>  doc/guides/compressdevs/index.rst |  1 +
> >>  doc/guides/compressdevs/zlib.rst  | 69
> >> +++
> >>  4 files changed, 83 insertions(+)
> >>
> >> diff --git a/MAINTAINERS b/MAINTAINERS index ca27c6f..7e3c450 100644
> >> --- a/MAINTAINERS
> >> +++ b/MAINTAINERS
> >> @@ -875,6 +875,8 @@ F: drivers/common/qat/  ZLIB
> >>  M: Sunila Sahu 
> >>  F: drivers/compress/zlib/
> >> +F: doc/guides/compressdevs/zlib.rst
> >> +F: doc/guides/compressdevs/features/zlib.ini
> >>
> >>  Eventdev Drivers
> >>  
> >> diff --git a/doc/guides/compressdevs/features/zlib.ini
> >> b/doc/guides/compressdevs/features/zlib.ini
> >> new file mode 100644
> >> index 000..c794643
> >> --- /dev/null
> >> +++ b/doc/guides/compressdevs/features/zlib.ini
> >> @@ -0,0 +1,11 @@
> >> +;
> >> +; Refer to default.ini for the full list of available PMD features.
> >> +;
> >> +; Supported features of 'ZLIB' compression driver.
> >> +;
> >> +[Features]
> >> +Pass-through   = Y
> >> +Deflate= Y
> >> +Fixed  = Y
> >> +Dynamic= Y
> >> +OOP SGL In SGL Out  = Y
> >
> >I assume that you support also "OOP SGL In LB Out" and "OOP LB In SGL Out",
> right?
> yes, but untested thus not claiming.

Right, but knowing that a Linear buffer is basically an SGL with just one 
segment,
I think it is safe to say that you support these two other cases.
The only reason why we have them is in case, you only support one of them, but 
you don't support SGL in SGL Out).

I won't have time to extend the test for those combinations in this release, I 
hope I can do that in the next one,
but as said, I think it is safe to claim that this PMD supports all the cases.

> 
> Thanks
> Shally

[dpdk-dev] [pull-request] next-net 18.08 RC2

[Ferruh Yigit]

The following changes since commit 711f43ba568acadf6cbccb9f8a29abf0fb3baa25:

  examples/vm_power: make branch ratio configurable (2018-07-21 00:00:43 +0200)

are available in the Git repository at:

  http://dpdk.org/git/next/dpdk-next-net 

for you to fetch changes up to 2056d7a3d0de0548b0926231ed59fc072d387713:

  net/mlx5: fix compilation issues on old kernels (2018-07-23 23:07:16 +0100)


Adrien Mazarguil (6):
  net/mlx5: lay groundwork for switch offloads
  net/mlx5: add framework for switch flow rules
  net/mlx5: add fate actions to switch flow rules
  net/mlx5: add L2-L4 pattern items to switch flow rules
  net/mlx5: add VLAN item and actions to switch flow rules
  net/mlx5: add port ID pattern item to switch flow rules

Andrew Rybchenko (5):
  net/sfc: move Rx checksum offload check to device level
  net/sfc: fix Rx queue offloads reporting in queue info
  net/sfc: prepare to support Rx datapath without checksum
  net/sfc: fix assert in set multicast address list
  net/sfc: handle unknown L3 packet class in EF10 event parser

Beilei Xing (3):
  net/i40e: fix PPPoL2TP packet type parser issue
  net/i40e: fix packet type parser error
  net/i40e: fix fail to set TPID with AQ command

Ferruh Yigit (3):
  net/i40e: remove redundant queue id checks
  net/fm10k: remove redundant queue id checks
  net/ixgbe: remove redundant queue id checks

Gage Eads (2):
  net/tap: set queue started and stopped
  net/pcap: set queue started and stopped

Hyong Youb Kim (2):
  doc: update the enic guide and features
  net/enic: pick the right Rx handler after changing MTU

Igor Romanov (2):
  net/sfc: fix filter exceptions logic
  net/sfc: fallback to filter with zero vid

Jasvinder Singh (2):
  ethdev: improve description for port name API
  net/softnic: fix memory illegal access

Jerin Jacob (1):
  ethdev: fix queue mapping documentation

Kiran Kumar (1):
  net/thunderx: avoid sq door bell writes on zero packets

Moti Haimovsky (1):
  net/mlx5: fix compilation issues on old kernels

Nelio Laranjeiro (2):
  app/testpmd: add VXLAN encap/decap support
  app/testpmd: add NVGRE encap/decap support

Pavan Nikhilesh (1):
  net/thunderx: enable Rx checksum offload

Qi Zhang (1):
  net/ixgbe: fix missing NULL point check

Radu Nicolau (1):
  net/bonding: fix invalid port id

Rahul Lakkireddy (2):
  net/cxgbe: update release notes for flow API support
  net/cxgbe: fix init failure due to new flash parts

Rakesh Kudurumalla (1):
  net/thunderx: add support for Rx VLAN offload

Rasesh Mody (1):
  net/qede: move SPDX tags to source files

Shaopeng He (1):
  net/i40e: fix Tx queue setup after stop queue

Tiwei Bie (1):
  vhost: fix buffer length calculation

Wei Zhao (1):
  net/i40e: fix FDIR check programming status error

Xiaoyun Li (2):
  net/i40e: fix link speed issue
  app/testpmd: fix little perf drop

 app/test-pmd/cmdline.c|  345 +++
 app/test-pmd/cmdline_flow.c   |  274 ++
 app/test-pmd/testpmd.c|   58 +-
 app/test-pmd/testpmd.h|   32 +
 doc/guides/nics/cxgbe.rst |2 +-
 doc/guides/nics/enic.rst  |   76 +-
 doc/guides/nics/features/enic.ini |3 +
 doc/guides/rel_notes/release_18_08.rst|5 +-
 doc/guides/testpmd_app_ug/testpmd_funcs.rst   |  107 +++
 drivers/net/bonding/rte_eth_bond_pmd.c|2 +-
 drivers/net/cxgbe/base/t4_hw.c|   97 +-
 drivers/net/enic/enic_main.c  |   25 +-
 drivers/net/fm10k/fm10k_ethdev.c  |  119 ++-
 drivers/net/i40e/i40e_ethdev.c|   77 +-
 drivers/net/i40e/i40e_ethdev_vf.c |  107 +--
 drivers/net/i40e/i40e_fdir.c  |2 +
 drivers/net/i40e/i40e_rxtx.c  |  129 ++-
 drivers/net/i40e/rte_pmd_i40e.c   |1 +
 drivers/net/ixgbe/ixgbe_pf.c  |6 +-
 drivers/net/ixgbe/ixgbe_rxtx.c|  139 ++-
 drivers/net/mlx5/Makefile |  187 
 drivers/net/mlx5/mlx5.c   |   32 +
 drivers/net/mlx5/mlx5.h   |   28 +
 drivers/net/mlx5/mlx5_defs.h  |5 +
 drivers/net/mlx5/mlx5_ethdev.c|   26 +
 drivers/net/mlx5/mlx5_flow.c  |  111 +++
 drivers/net/mlx5/mlx5_nl_flow.c   | 1247 +
 drivers/net/pcap/rte_eth_pcap.c   |   49 +
 drivers/net/qede/LICENSE.qede_pmd |3 -
 drivers/net/qede/Makefile |3 +-
 drivers/net/qede/base/bcm_osal.c  |4 +-
 drivers/net/qede/base/bcm_osal.h  |4 +-
 drivers/net/qede/base/common_hsi.h|4 +-
 drivers/net/qede/base/e

Re: [dpdk-dev] [PATCH v2 1/6] net/mlx5: lay groundwork for switch offloads

[Ferruh Yigit]

On 7/13/2018 10:40 AM, Adrien Mazarguil wrote:
> With mlx5, unlike normal flow rules implemented through Verbs for traffic
> emitted and received by the application, those targeting different logical
> ports of the device (VF representors for instance) are offloaded at the
> switch level and must be configured through Netlink (TC interface).
> 
> This patch adds preliminary support to manage such flow rules through the
> flow API (rte_flow).
> 
> Instead of rewriting tons of Netlink helpers and as previously suggested by
> Stephen [1], this patch introduces a new dependency to libmnl [2]
> (LGPL-2.1) when compiling mlx5.
> 
> [1] https://mails.dpdk.org/archives/dev/2018-March/092676.html
> [2] https://netfilter.org/projects/libmnl/

Just to highlight this new PMD level dependency to libmnl.

tap pmd also uses netlink and vdev_netvsc also does nl communication, perhaps we
can discuss unifying netlink usage around this new library.

> 
> Signed-off-by: Adrien Mazarguil 
> Acked-by: Nelio Laranjeiro 
> Cc: Yongseok Koh 
> --
> v2 changes:
> 
> - Added NETLINK_CAP_ACK definition if missing from the host system. This
>   parameter is also not mandatory anymore and won't prevent creation of
>   NL sockets when not supported.
> - Modified mlx5_nl_flow_nl_ack() and mlx5_nl_flow_init() to consume the
>   least amount of stack space based on message size, instead of the fixed
>   MNL_SOCKET_BUFFER_SIZE which is quite large.

<...>

Re: [dpdk-dev] [PATCH v4 1/5] compress/zlib: add ZLIB PMD

[De Lara Guarch, Pablo]

> -Original Message-
> From: Shally Verma [mailto:shally.ve...@caviumnetworks.com]
> Sent: Monday, July 23, 2018 3:51 PM
> To: De Lara Guarch, Pablo 
> Cc: dev@dpdk.org; pathr...@caviumnetworks.com;
> mcha...@caviumnetworks.com; Ashish Gupta
> ; Sunila Sahu
> 
> Subject: [PATCH v4 1/5] compress/zlib: add ZLIB PMD
> 
> From: Ashish Gupta 
> 
> Add initial PMD setup routines in compressdev framework. ZLIB PMD appears as
> virtual compression device. User would need to install zlib prior to enabling 
> this
> PMD.
> 
> Signed-off-by: Sunila Sahu 
> Signed-off-by: Shally Verma 
> Signed-off-by: Ashish Gupta 

...

> +++ b/drivers/compress/zlib/zlib_pmd.c

...

> +static int
> +zlib_probe(struct rte_vdev_device *vdev) {
> + struct rte_compressdev_pmd_init_params init_params = {
> + "",
> + rte_socket_id()
> + };
> + const char *name;
> + const char *input_args;
> +
> + name = rte_vdev_device_name(vdev);
> +
> + if (name == NULL)
> + return -EINVAL;
> + input_args = rte_vdev_device_args(vdev);
> + rte_compressdev_pmd_parse_input_args(&init_params, input_args);

Need to check the return value of this function.

Re: [dpdk-dev] [PATCH v4 2/5] compress/zlib: add device PMD ops

[De Lara Guarch, Pablo]

> -Original Message-
> From: Shally Verma [mailto:shally.ve...@caviumnetworks.com]
> Sent: Monday, July 23, 2018 3:51 PM
> To: De Lara Guarch, Pablo 
> Cc: dev@dpdk.org; pathr...@caviumnetworks.com;
> mcha...@caviumnetworks.com; Ashish Gupta
> ; Sunila Sahu
> 
> Subject: [PATCH v4 2/5] compress/zlib: add device PMD ops
> 
> From: Ashish Gupta 
> 
> Implement device configure and queue pair setup PMD ops
> 
> Signed-off-by: Sunila Sahu 
> Signed-off-by: Shally Verma 
> Signed-off-by: Ashish Gupta 

...

> --- /dev/null
> +++ b/drivers/compress/zlib/zlib_pmd_ops.c
> @@ -0,0 +1,238 @@
> +/* SPDX-License-Identifier: BSD-3-Clause
> + * Copyright(c) 2018 Cavium Networks
> + */
> +
> +#include 
> +
> +#include 
> +#include 
> +
> +#include "zlib_pmd_private.h"
> +
> +static const struct rte_compressdev_capabilities zlib_pmd_capabilities[] = {
> + {   /* Deflate */
> + .algo = RTE_COMP_ALGO_DEFLATE,
> + .comp_feature_flags =
> (RTE_COMP_FF_NONCOMPRESSED_BLOCKS |
> + RTE_COMP_FF_HUFFMAN_FIXED |
> + RTE_COMP_FF_HUFFMAN_DYNAMIC |
> +
>   RTE_COMP_FF_OOP_SGL_IN_SGL_OUT),

As said in the document patch, I think you should add the other two SGL cases 
here.

Re: [dpdk-dev] [PATCH v4 4/5] compress/zlib: support burst enqueue/dequeue

[De Lara Guarch, Pablo]

> -Original Message-
> From: Shally Verma [mailto:shally.ve...@caviumnetworks.com]
> Sent: Monday, July 23, 2018 3:51 PM
> To: De Lara Guarch, Pablo 
> Cc: dev@dpdk.org; pathr...@caviumnetworks.com;
> mcha...@caviumnetworks.com; Sunila Sahu ;
> Sunila Sahu ; Ashish Gupta
> 
> Subject: [PATCH v4 4/5] compress/zlib: support burst enqueue/dequeue
> 
> From: Sunila Sahu 
> 
> Signed-off-by: Sunila Sahu 
> Signed-off-by: Shally Verma 
> Signed-off-by: Ashish Gupta 
> ---
>  drivers/compress/zlib/zlib_pmd.c | 255
> ++-
>  1 file changed, 254 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/compress/zlib/zlib_pmd.c 
> b/drivers/compress/zlib/zlib_pmd.c
> index 47bc73d..dc1e230 100644
> --- a/drivers/compress/zlib/zlib_pmd.c
> +++ b/drivers/compress/zlib/zlib_pmd.c
> @@ -7,7 +7,214 @@
> 
>  #include "zlib_pmd_private.h"
> 
> -/** Parse comp xform and set private xform/stream parameters */
> +/** Compute next mbuf in the list, assign data buffer and length,
> + *  returns 0 if mbuf is NULL
> + */
> +#define COMPUTE_BUF(mbuf, data, len) \
> + ((mbuf = mbuf->next) ?  \
> + (data = rte_pktmbuf_mtod(mbuf, uint8_t *)), \
> + (len = rte_pktmbuf_data_len(mbuf)) : 0)
> +
> +static void
> +process_zlib_deflate(struct rte_comp_op *op, z_stream *strm) {

...

> + /* Update z_stream with the inputs provided by application */
> + strm->next_in = rte_pktmbuf_mtod_offset(mbuf_src, uint8_t *,
> + op->src.offset);

This is assuming that src buffer is a linear buffer or that offset won't be 
large enough to cross boundaries between segments.
If an SGL is passed and offset is bigger than the first segment, next_in should 
point at a different segment, with the remaining part of the offset in that 
segment
(look at ISA-L SGL patch: http://patches.dpdk.org/patch/43283/). Same applies 
to avail_in, next_out and avail_out.

> +
> + strm->avail_in = rte_pktmbuf_data_len(mbuf_src) - op->src.offset;
> +
> + strm->next_out = rte_pktmbuf_mtod_offset(mbuf_dst, uint8_t *,
> + op->dst.offset);
> +
> + strm->avail_out = rte_pktmbuf_data_len(mbuf_dst) - op->dst.offset;
> +

...

> + strm->next_in = rte_pktmbuf_mtod_offset(mbuf_src, uint8_t *,
> + op->src.offset);
> +
> + strm->avail_in = rte_pktmbuf_data_len(mbuf_src) - op->src.offset;
> +
> + strm->next_out = rte_pktmbuf_mtod_offset(mbuf_dst, uint8_t *,
> + op->dst.offset);
> +
> + strm->avail_out = rte_pktmbuf_data_len(mbuf_dst) - op->dst.offset;

Same comments as above (compression).

...

> +static inline int
> +process_zlib_op(struct zlib_qp *qp, struct rte_comp_op *op) {
> + struct zlib_stream *stream;
> + struct zlib_priv_xform *private_xform;
> +
> + if ((op->op_type == RTE_COMP_OP_STATEFUL) ||
> + (op->src.offset > rte_pktmbuf_data_len(op->m_src)) ||
> + (op->dst.offset > rte_pktmbuf_data_len(op->m_dst))) {

Since m_src and m_dst could be SGLs, pkt_len should be checked, instead of 
data_len (which would be only for single segment).
Also, you should check the length too, in case of source buffers (src.offset + 
src.length > m_src->pkt_len).

Lastly, the two lines after the first if line should have double indentation to 
distinguish clearly against the body of the if.
If line is too long, consider storing the length of the buffers in variables.


> + op->status = RTE_COMP_OP_STATUS_INVALID_ARGS;
> + ZLIB_PMD_ERR("Invalid source or destination buffers or "
> +  "invalid Operation requested\n");

Re: [dpdk-dev] [PATCH] net/mlx5: fix tci mask filter

[Yongseok Koh]

> On Jul 23, 2018, at 12:18 AM, Nelio Laranjeiro  
> wrote:
> 
> In mlx5_traffic_enable() the TCI mask for the VLAN is wrong causing the
> sub flow engine to reject the rule.
> 
> Fixes: 272733b5ebfd ("net/mlx5: use flow to enable unicast traffic")
> Cc: sta...@dpdk.org
> 
> Signed-off-by: Nelio Laranjeiro 
> ---
Acked-by: Yongseok Koh 
 
Thanks

Re: [dpdk-dev] rte_mbuf library likely()/unlikely()

[Wiles, Keith]

> On Jul 23, 2018, at 2:09 PM, Morten Brørup  wrote:
> 
> I haven't performance tested, but they are compiler branch prediction hints 
> pointing out the most likely execution path, so I expect them to have a 
> positive effect.

We really need to make sure this provides any performance improvement and that 
means it needs to be tested on a number of systems. Can you please do some 
performance testing or see if we can get the guys doing DPDK performance 
testing to first give this a try? This area is very sensitive to tweaking.

> 
> E.g. the first comparison in __rte_pktmbuf_read() is very unlikely to be true 
> - it would mean that the application is trying to read data beyond the packet.
> 
> Please also refer to:
> https://cellperformance.beyond3d.com/articles/2006/04/branch-patterns-using-gcc.html
> 
> 
>> -Original Message-
>> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Honnappa Nagarahalli
>> Sent: Monday, July 23, 2018 7:52 PM
>> To: Morten Brørup; Olivier Matz
>> Cc: dev@dpdk.org
>> Subject: Re: [dpdk-dev] rte_mbuf library likely()/unlikely()
>> 
>> Do you see any performance improvements with these changes?
>> 
>> -Original Message-
>> From: dev  On Behalf Of Morten Brørup
>> Sent: Monday, July 23, 2018 8:54 AM
>> To: Olivier Matz 
>> Cc: dev@dpdk.org
>> Subject: [dpdk-dev] rte_mbuf library likely()/unlikely()
>> 
>> Hi Olivier,
>> 
>> 
>> 
>> I noticed that __rte_pktmbuf_read() could do with an unlikely(), so I went
>> through the entire library. Here are my suggested modifications.
>> 

Regards,
Keith

Re: [dpdk-dev] [PATCH v3 4/6] compress/octeontx: add ops enq deq apis

[De Lara Guarch, Pablo]

Hi Ashish,


> -Original Message-
> From: Ashish Gupta [mailto:ashish.gu...@caviumnetworks.com]
> Sent: Friday, July 20, 2018 8:05 PM
> To: De Lara Guarch, Pablo 
> Cc: dev@dpdk.org; narayanaprasad.athr...@cavium.com;
> mahipal.cha...@cavium.com; Ashish Gupta
> ; Shally Verma
> ; Sunila Sahu
> 
> Subject: [PATCH v3 4/6] compress/octeontx: add ops enq deq apis
> 
> Add enqueue/dequeue APIs to perform compression/decompression operations
> 
> Signed-off-by: Ashish Gupta 
> Signed-off-by: Shally Verma 
> Signed-off-by: Sunila Sahu 
> ---
>  drivers/compress/octeontx/otx_zip.c |  49 +
>  drivers/compress/octeontx/otx_zip.h | 169
> 
>  drivers/compress/octeontx/otx_zip_pmd.c | 119 ++
>  3 files changed, 337 insertions(+)
> 

...

>  int
>  zipvf_create(struct rte_compressdev *compressdev)  { diff --git
> a/drivers/compress/octeontx/otx_zip.h b/drivers/compress/octeontx/otx_zip.h
> index 3fcd86a86..73a99e624 100644
> --- a/drivers/compress/octeontx/otx_zip.h
> +++ b/drivers/compress/octeontx/otx_zip.h

...

> +
> +static inline int
> +zipvf_prepare_in_buf(struct zip_stream *zstrm, struct rte_comp_op *op)
> +{
> + uint32_t offset, inlen;
> + union zip_zptr_s *sg_list = NULL;
> + struct rte_mbuf *m_src;
> + union zip_inst_s *inst = zstrm->inst;
> + rte_iova_t iova;
> +
> + inlen = op->src.length;
> + offset = op->src.offset;
> + m_src = op->m_src;
> +
> + if (m_src->nb_segs == 1) {
> + /* Prepare direct input data pointer */
> + inst->s.dg = 0;
> + inst->s.inp_ptr_addr.s.addr =
> + rte_pktmbuf_iova_offset(m_src, offset);
> + inst->s.inp_ptr_ctl.s.length = inlen;
> + return 0;
> + }
> +
> + ZIP_PMD_INFO("Input packet is segmented\n");
> +
> + /* Packet is segmented, create gather buffer */

Looks like you actually support SGL, even though you are not setting that in 
the capabilities.
Now that the SGL tests are available, you should check if the PMD passes the 
tests
and update the capabilities accordingly.

Also, you should take into account if offset is big enough to cross boundaries
between segments (so first segment to be compressed/decompressed is not the 
first segment of the SGL).
Look at the comments that I made in the ZLIB PMD (partly based on comments left 
in the ISAL PMD),
since they should apply to this case too.

> + inst->s.dg = 1;
> + iova = rte_mempool_virt2iova(zstrm->bufs[IN_DATA_BUF]);
> + if (iova & 0xF) {
> + /* Align it to 16 Byte address */
> + iova = ZIP_ALIGN_ROUNDUP(iova, ZIP_SGPTR_ALIGN);
> + }
> +
> 

Re: [dpdk-dev] [PATCH] doc: fix mlx5 dependencies

[Yongseok Koh]

> On Jul 23, 2018, at 4:50 AM, Adrien Mazarguil  
> wrote:
> 
> The new dependency of mlx5 to libmnl must be reflected in documentation.
> 
> Fixes: 4d5cce06231a ("net/mlx5: lay groundwork for switch offloads")
> 
> Signed-off-by: Adrien Mazarguil 
> ---
Acked-by: Yongseok Koh 
 
Thanks

Re: [dpdk-dev] [PATCH v2 1/6] net/mlx5: lay groundwork for switch offloads

[Stephen Hemminger]

On Mon, 23 Jul 2018 22:40:47 +0100
Ferruh Yigit  wrote:

> On 7/13/2018 10:40 AM, Adrien Mazarguil wrote:
> > With mlx5, unlike normal flow rules implemented through Verbs for traffic
> > emitted and received by the application, those targeting different logical
> > ports of the device (VF representors for instance) are offloaded at the
> > switch level and must be configured through Netlink (TC interface).
> > 
> > This patch adds preliminary support to manage such flow rules through the
> > flow API (rte_flow).
> > 
> > Instead of rewriting tons of Netlink helpers and as previously suggested by
> > Stephen [1], this patch introduces a new dependency to libmnl [2]
> > (LGPL-2.1) when compiling mlx5.
> > 
> > [1] https://mails.dpdk.org/archives/dev/2018-March/092676.html
> > [2] https://netfilter.org/projects/libmnl/  
> 
> Just to highlight this new PMD level dependency to libmnl.
> 
> tap pmd also uses netlink and vdev_netvsc also does nl communication, perhaps 
> we
> can discuss unifying netlink usage around this new library.
> 
> > 
> > Signed-off-by: Adrien Mazarguil 
> > Acked-by: Nelio Laranjeiro 
> > Cc: Yongseok Koh 
> > --
> > v2 changes:
> > 
> > - Added NETLINK_CAP_ACK definition if missing from the host system. This
> >   parameter is also not mandatory anymore and won't prevent creation of
> >   NL sockets when not supported.
> > - Modified mlx5_nl_flow_nl_ack() and mlx5_nl_flow_init() to consume the
> >   least amount of stack space based on message size, instead of the fixed
> >   MNL_SOCKET_BUFFER_SIZE which is quite large.  
> 
> <...>
> 

I am concerned that this won't work on FreeBSD and it will end up
farther behind.

[dpdk-dev] [PATCH] net/ixgbe: remove hardcoded CRC STRIP config from ixgbe

[Wei Zhao]

There is CRC related ifdefs for ixgbe:
CONFIG_RTE_LIBRTE_IXGBE_PF_DISABLE_STRIP_CRC=n
It is used in VF drivers ixgbevf_dev_configure() functions.
VF cannot change the CRC strip behavior and based on what PF
configured it needs to response proper to user
ixgbevf_dev_configure() request. Right now what PF set is
defined by above config options but this method is too static.

Signed-off-by: Wei Zhao 
Signed-off-by: Wenzhuo Lu 
---
 app/test-pmd/parameters.c|  6 ++
 app/test-pmd/testpmd.c   |  2 ++
 app/test-pmd/testpmd.h   |  1 +
 drivers/net/ixgbe/ixgbe_ethdev.c | 20 ++--
 lib/librte_ethdev/rte_ethdev.h   |  1 +
 5 files changed, 20 insertions(+), 10 deletions(-)

diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c
index 962fad7..b981b0f 100644
--- a/app/test-pmd/parameters.c
+++ b/app/test-pmd/parameters.c
@@ -188,6 +188,7 @@ usage(char* progname)
printf("  --tx-offloads=0x: hexadecimal bitmask of TX queue 
offloads\n");
printf("  --hot-plug: enable hot plug for device.\n");
printf("  --vxlan-gpe-port=N: UPD port of tunnel VXLAN-GPE\n");
+   printf("  --pf-crc-keep: disable pf CRC strip function for device\n");
printf("  --mlockall: lock all memory\n");
printf("  --no-mlockall: do not lock all memory\n");
 }
@@ -623,6 +624,7 @@ launch_args_parse(int argc, char** argv)
{ "tx-offloads",1, 0, 0 },
{ "hot-plug",   0, 0, 0 },
{ "vxlan-gpe-port", 1, 0, 0 },
+   { "pf-crc-keep",0, 0, 0 },
{ "mlockall",   0, 0, 0 },
{ "no-mlockall",0, 0, 0 },
{ 0, 0, 0, 0 },
@@ -1131,6 +1133,9 @@ launch_args_parse(int argc, char** argv)
rte_exit(EXIT_FAILURE,
 "vxlan-gpe-port must be >= 
0\n");
}
+   if (!strcmp(lgopts[opt_idx].name, "pf-crc-keep")) {
+   rx_offloads_disable |= DEV_RX_OFFLOAD_CRC_STRIP;
+   }
if (!strcmp(lgopts[opt_idx].name, "print-event"))
if (parse_event_printing_config(optarg, 1)) {
rte_exit(EXIT_FAILURE,
@@ -1163,4 +1168,5 @@ launch_args_parse(int argc, char** argv)
/* Set offload configuration from command line parameters. */
rx_mode.offloads = rx_offloads;
tx_mode.offloads = tx_offloads;
+   rx_mode.offloads_disable = rx_offloads_disable;
 }
diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index d3ce92f..c94328a 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -287,6 +287,8 @@ uint8_t rmv_interrupt = 1; /* enabled by default */
 
 uint8_t hot_plug = 0; /**< hotplug disabled by default. */
 
+uint64_t rx_offloads_disable = 0;  /**< rx offload enabled by default. */
+
 /*
  * Display or mask ether events
  * Default to all events except VF_MBOX
diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h
index 4fc30a8..d9734d3 100644
--- a/app/test-pmd/testpmd.h
+++ b/app/test-pmd/testpmd.h
@@ -313,6 +313,7 @@ extern uint32_t event_print_mask;
 /**< set by "--print-event " and "--mask-event  parameters */
 extern uint8_t hot_plug; /**< enable by "--hot-plug" parameter */
 extern int do_mlockall; /**< set by "--mlockall" or "--no-mlockall" parameter 
*/
+extern uint64_t rx_offloads_disable;
 
 #ifdef RTE_LIBRTE_IXGBE_BYPASS
 extern uint32_t bypass_timeout; /**< Store the NIC bypass watchdog timeout */
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index 26b1927..25c1187 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -5007,17 +5007,17 @@ ixgbevf_dev_configure(struct rte_eth_dev *dev)
 * VF has no ability to enable/disable HW CRC
 * Keep the persistent behavior the same as Host PF
 */
-#ifndef RTE_LIBRTE_IXGBE_PF_DISABLE_STRIP_CRC
-   if (rte_eth_dev_must_keep_crc(conf->rxmode.offloads)) {
-   PMD_INIT_LOG(NOTICE, "VF can't disable HW CRC Strip");
-   conf->rxmode.offloads |= DEV_RX_OFFLOAD_CRC_STRIP;
-   }
-#else
-   if (!rte_eth_dev_must_keep_crc(conf->rxmode.offloads)) {
-   PMD_INIT_LOG(NOTICE, "VF can't enable HW CRC Strip");
-   conf->rxmode.offloads &= ~DEV_RX_OFFLOAD_CRC_STRIP;
+   if (conf->rxmode.offloads_disable & DEV_RX_OFFLOAD_CRC_STRIP) {
+   if (rte_eth_dev_must_keep_crc(conf->rxmode.offloads)) {
+   PMD_INIT_LOG(NOTICE, "VF can't disable HW CRC Strip");
+   conf->rxmode.offloads |= DEV_RX_OFFLOAD_CRC_STRIP;
+   }
+   } else {
+   if (!rte_eth_dev_must_keep_crc(conf->rxmode.offloads)) {
+   PMD_INIT

[dpdk-dev] [PATCH] app/testpmd: fix commands to config some offload

[Wei Dai]

Without this patch, testpmd command to config Rx offload keep_crc
would fail and report "Bad argument".
This patch aslo fix the command to config the Tx offload mbuf_fast_free.

Fixes: 70815c9ecadd ("ethdev: add new offload flag to keep CRC")
Fixes: c73a9071877a ("app/testpmd: add commands to test new offload API")
Cc: sta...@dpdk.org

Signed-off-by: Wei Dai 
---
 app/test-pmd/cmdline.c | 16 
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index 5885289..a0ed3a0 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -16665,7 +16665,7 @@ struct cmd_config_per_port_rx_offload_result {
 offload, "vlan_strip#ipv4_cksum#udp_cksum#tcp_cksum#tcp_lro#"
   "qinq_strip#outer_ipv4_cksum#macsec_strip#"
   "header_split#vlan_filter#vlan_extend#jumbo_frame#"
-  "crc_strip#scatter#timestamp#security");
+  "crc_strip#scatter#timestamp#security#keep_crc");
 cmdline_parse_token_string_t cmd_config_per_port_rx_offload_result_on_off =
TOKEN_STRING_INITIALIZER
(struct cmd_config_per_port_rx_offload_result,
@@ -16744,7 +16744,7 @@ struct cmd_config_per_port_rx_offload_result {
.help_str = "port config  rx_offload vlan_strip|ipv4_cksum|"
"udp_cksum|tcp_cksum|tcp_lro|qinq_strip|outer_ipv4_cksum|"
"macsec_strip|header_split|vlan_filter|vlan_extend|"
-   "jumbo_frame|crc_strip|scatter|timestamp|security "
+   "jumbo_frame|crc_strip|scatter|timestamp|security|keep_crc "
"on|off",
.tokens = {
(void *)&cmd_config_per_port_rx_offload_result_port,
@@ -16794,7 +16794,7 @@ struct cmd_config_per_queue_rx_offload_result {
 offload, "vlan_strip#ipv4_cksum#udp_cksum#tcp_cksum#tcp_lro#"
   "qinq_strip#outer_ipv4_cksum#macsec_strip#"
   "header_split#vlan_filter#vlan_extend#jumbo_frame#"
-  "crc_strip#scatter#timestamp#security");
+  "crc_strip#scatter#timestamp#security#keep_crc");
 cmdline_parse_token_string_t cmd_config_per_queue_rx_offload_result_on_off =
TOKEN_STRING_INITIALIZER
(struct cmd_config_per_queue_rx_offload_result,
@@ -16846,7 +16846,7 @@ struct cmd_config_per_queue_rx_offload_result {
"vlan_strip|ipv4_cksum|"
"udp_cksum|tcp_cksum|tcp_lro|qinq_strip|outer_ipv4_cksum|"
"macsec_strip|header_split|vlan_filter|vlan_extend|"
-   "jumbo_frame|crc_strip|scatter|timestamp|security "
+   "jumbo_frame|crc_strip|scatter|timestamp|security|keep_crc "
"on|off",
.tokens = {
(void *)&cmd_config_per_queue_rx_offload_result_port,
@@ -17063,7 +17063,7 @@ struct cmd_config_per_port_tx_offload_result {
  "sctp_cksum#tcp_tso#udp_tso#outer_ipv4_cksum#"
  "qinq_insert#vxlan_tnl_tso#gre_tnl_tso#"
  "ipip_tnl_tso#geneve_tnl_tso#macsec_insert#"
- "mt_lockfree#multi_segs#fast_free#security");
+ "mt_lockfree#multi_segs#mbuf_fast_free#security");
 cmdline_parse_token_string_t cmd_config_per_port_tx_offload_result_on_off =
TOKEN_STRING_INITIALIZER
(struct cmd_config_per_port_tx_offload_result,
@@ -17144,7 +17144,7 @@ struct cmd_config_per_port_tx_offload_result {
"sctp_cksum|tcp_tso|udp_tso|outer_ipv4_cksum|"
"qinq_insert|vxlan_tnl_tso|gre_tnl_tso|"
"ipip_tnl_tso|geneve_tnl_tso|macsec_insert|"
-   "mt_lockfree|multi_segs|fast_free|security "
+   "mt_lockfree|multi_segs|mbuf_fast_free|security "
"on|off",
.tokens = {
(void *)&cmd_config_per_port_tx_offload_result_port,
@@ -17195,7 +17195,7 @@ struct cmd_config_per_queue_tx_offload_result {
  "sctp_cksum#tcp_tso#udp_tso#outer_ipv4_cksum#"
  "qinq_insert#vxlan_tnl_tso#gre_tnl_tso#"
  "ipip_tnl_tso#geneve_tnl_tso#macsec_insert#"
- "mt_lockfree#multi_segs#fast_free#security");
+ "mt_lockfree#multi_segs#mbuf_fast_free#security");
 cmdline_parse_token_string_t cmd_config_per_queue_tx_offload_result_on_off =
TOKEN_STRING_INITIALIZER
(struct cmd_config_per_queue_tx_offload_result,
@@ -17248,7 +17248,7 @@ struct cmd_config_per_queue_tx_offload_result {
"sctp_cksum|tcp_tso|udp_tso|outer_ipv4_cksum|"
"qinq_insert|vxlan_tnl_tso|gre_tnl_tso|"
"ipip_tnl_tso|geneve_tnl_tso|macsec_insert|"
-   "mt_lockfree|multi_segs|fast_

Re: [dpdk-dev] [PATCH v2 1/6] net/mlx5: lay groundwork for switch offloads

[Shahaf Shuler]

Stephen,

Tuesday, July 24, 2018 3:51 AM, Stephen Hemminger:
> Subject: Re: [dpdk-dev] [PATCH v2 1/6] net/mlx5: lay groundwork for switch
> offloads
> 
> On Mon, 23 Jul 2018 22:40:47 +0100
> Ferruh Yigit  wrote:
> >
> > Just to highlight this new PMD level dependency to libmnl.
> >
> > tap pmd also uses netlink and vdev_netvsc also does nl communication,
> > perhaps we can discuss unifying netlink usage around this new library.
> >
> >
> 
> I am concerned that this won't work on FreeBSD and it will end up farther
> behind.

Can you elaborate? What is the reason it will not work?
 

[dpdk-dev] [PATCH] net/tap: add probe finish call for tun secondary

[Vipin Varghese]

Invoke rte_eth_dev_probing_finish for rte_pmd_tun_probe.

Signed-off-by: Vipin Varghese 
---
 drivers/net/tap/rte_eth_tap.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index 4493507..8c0c5d6 100644
--- a/drivers/net/tap/rte_eth_tap.c
+++ b/drivers/net/tap/rte_eth_tap.c
@@ -1879,6 +1879,7 @@ rte_pmd_tun_probe(struct rte_vdev_device *dev)
return -1;
}
eth_dev->dev_ops = &ops;
+   rte_eth_dev_probing_finish(eth_dev);
return 0;
}
 
-- 
2.7.4

Re: [dpdk-dev] [PATCH] doc: add tested NICs in i40e guide

[Xing, Beilei]

> -Original Message-
> From: Li, Xiaoyun
> Sent: Monday, July 23, 2018 2:34 PM
> To: Mcnamara, John ; Xing, Beilei
> ; Zhang, Qi Z 
> Cc: dev@dpdk.org; Li, Xiaoyun 
> Subject: [PATCH] doc: add tested NICs in i40e guide
> 
> Add suggested kernel driver and firmware version for i40e PMD.
> 
> Signed-off-by: Xiaoyun Li 
> ---
>  doc/guides/nics/i40e.rst | 29 +
>  1 file changed, 29 insertions(+)
> 
> diff --git a/doc/guides/nics/i40e.rst b/doc/guides/nics/i40e.rst index
> d5b02c9..d377d92 100644
> --- a/doc/guides/nics/i40e.rst
> +++ b/doc/guides/nics/i40e.rst
> @@ -58,6 +58,35 @@ Prerequisites
>  - Upgrade the NVM/FW version following the `Intel® Ethernet NVM Update
> Tool Quick Usage Guide for Linux
> ssl.intel.com/content/www/us/en/embedded/products/networking/nvm-
> update-tool-quick-linux-usage-guide.html>`_ and `Intel® Ethernet NVM
> Update Tool: Quick Usage Guide for EFI
>  ing/nvm-update-tool-quick-efi-usage-guide.html>`_ if needed.
> 
> +Tested NICs

The guide is only for i40e, so we'd better change the title, how about 
recommended matching list?
Also the patch title also needs to be changed.

> +---
> +
> +It is highly recommended to upgrade the i40e kernel driver and firmware
> +to avoid the compatibility issues with i40e PMD. Here is the suggested
> +matching list which has been tested and verified.
> +
> +   +--+---+--+
> +   | DPDK version | Kernel driver version | Firmware version |
> +   +==+===+==+
> +   |18.05 | 2.4.6 |   6.01   |
> +   +--+---+--+
> +   |18.02 | 2.4.3 |   6.01   |
> +   +--+---+--+
> +   |17.11 | 2.1.26|   6.01   |
> +   +--+---+--+
> +   |17.08 | 2.0.19|   6.01   |
> +   +--+---+--+
> +   |17.05 | 1.5.23|   5.05   |
> +   +--+---+--+
> +   |17.02 | 1.5.23|   5.05   |
> +   +--+---+--+
> +   |16.11 | 1.5.23|   5.05   |
> +   +--+---+--+
> +   |16.07 | 1.4.25|   5.04   |
> +   +--+---+--+
> +   |16.04 | 1.4.25|   5.02   |
> +   +--+---+--+
> +
>  Pre-Installation Configuration
>  --
> 
> --
> 2.7.4

Re: [dpdk-dev] [PATCH v4 5/5] doc: add ZLIB PMD guide

[Verma, Shally]

>-Original Message-
>From: De Lara Guarch, Pablo 
>Sent: 24 July 2018 02:49
>To: Verma, Shally 
>Cc: dev@dpdk.org; Athreya, Narayana Prasad 
>; Challa, Mahipal
>; Sahu, Sunila ; Gupta, 
>Ashish 
>Subject: RE: [dpdk-dev] [PATCH v4 5/5] doc: add ZLIB PMD guide
>
>External Email
>
>Hi Shally,
>
>> -Original Message-
>> From: Verma, Shally [mailto:shally.ve...@cavium.com]
>> Sent: Monday, July 23, 2018 7:00 PM
>> To: De Lara Guarch, Pablo 
>> Cc: dev@dpdk.org; Athreya, Narayana Prasad
>> ; Challa, Mahipal
>> ; Sahu, Sunila ;
>> Gupta, Ashish 
>> Subject: RE: [dpdk-dev] [PATCH v4 5/5] doc: add ZLIB PMD guide
>>
>>
>>
>> >-Original Message-
>> >From: De Lara Guarch, Pablo 
>> >Sent: 23 July 2018 23:28
>> >To: Verma, Shally 
>> >Cc: dev@dpdk.org; Athreya, Narayana Prasad
>> >; Challa, Mahipal
>> >; Sahu, Sunila ;
>> >Gupta, Ashish 
>> >Subject: RE: [dpdk-dev] [PATCH v4 5/5] doc: add ZLIB PMD guide
>> >
>> >External Email
>> >
>> >> -Original Message-
>> >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Shally Verma
>> >> Sent: Monday, July 23, 2018 3:51 PM
>> >> To: De Lara Guarch, Pablo 
>> >> Cc: dev@dpdk.org; pathr...@caviumnetworks.com;
>> >> mcha...@caviumnetworks.com; Sunila Sahu
>> >> ; Ashish Gupta
>> >> 
>> >> Subject: [dpdk-dev] [PATCH v4 5/5] doc: add ZLIB PMD guide
>> >>
>> >> Add zlib pmd feature support and user guide with build and run
>> >> instructions
>> >>
>> >> Signed-off-by: Sunila Sahu 
>> >> Signed-off-by: Shally Verma 
>> >> Signed-off-by: Ashish Gupta 
>> >> ---
>> >>  MAINTAINERS   |  2 +
>> >>  doc/guides/compressdevs/features/zlib.ini | 11 +
>> >>  doc/guides/compressdevs/index.rst |  1 +
>> >>  doc/guides/compressdevs/zlib.rst  | 69
>> >> +++
>> >>  4 files changed, 83 insertions(+)
>> >>
>> >> diff --git a/MAINTAINERS b/MAINTAINERS index ca27c6f..7e3c450 100644
>> >> --- a/MAINTAINERS
>> >> +++ b/MAINTAINERS
>> >> @@ -875,6 +875,8 @@ F: drivers/common/qat/  ZLIB
>> >>  M: Sunila Sahu 
>> >>  F: drivers/compress/zlib/
>> >> +F: doc/guides/compressdevs/zlib.rst
>> >> +F: doc/guides/compressdevs/features/zlib.ini
>> >>
>> >>  Eventdev Drivers
>> >>  
>> >> diff --git a/doc/guides/compressdevs/features/zlib.ini
>> >> b/doc/guides/compressdevs/features/zlib.ini
>> >> new file mode 100644
>> >> index 000..c794643
>> >> --- /dev/null
>> >> +++ b/doc/guides/compressdevs/features/zlib.ini
>> >> @@ -0,0 +1,11 @@
>> >> +;
>> >> +; Refer to default.ini for the full list of available PMD features.
>> >> +;
>> >> +; Supported features of 'ZLIB' compression driver.
>> >> +;
>> >> +[Features]
>> >> +Pass-through   = Y
>> >> +Deflate= Y
>> >> +Fixed  = Y
>> >> +Dynamic= Y
>> >> +OOP SGL In SGL Out  = Y
>> >
>> >I assume that you support also "OOP SGL In LB Out" and "OOP LB In SGL Out",
>> right?
>> yes, but untested thus not claiming.
>
>Right, but knowing that a Linear buffer is basically an SGL with just one 
>segment,
>I think it is safe to say that you support these two other cases.
>The only reason why we have them is in case, you only support one of them, but 
>you don't support SGL in SGL Out).
>
>I won't have time to extend the test for those combinations in this release, I 
>hope I can do that in the next one,
>but as said, I think it is safe to claim that this PMD supports all the cases.
Agree. However I would still wait to test them before claiming support.

Thanks
Shally
>
>>
>> Thanks
>> Shally

Re: [dpdk-dev] [PATCH] net/mlx5: fix possible endless loop when clearing flow flags

[Ori Kam]

> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Yongseok Koh
> Sent: Monday, July 23, 2018 9:28 PM
> To: Shahaf Shuler 
> Cc: dev@dpdk.org; Yongseok Koh ; Nélio Laranjeiro
> 
> Subject: [dpdk-dev] [PATCH] net/mlx5: fix possible endless loop when
> clearing flow flags
> 
> If one of (*priv->rxqs)[] is null, the for loop can iterate infinitely as
> idx can't be increased.
> 
> Fixes: cd24d526395e ("net/mlx5: add mark/flag flow action")
> Cc: Nelio Laranjeiro 
> 
> Signed-off-by: Yongseok Koh 
> ---
>  drivers/net/mlx5/mlx5_flow.c | 8 +++-
>  1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
> index 32854198b..c156f01eb 100644
> --- a/drivers/net/mlx5/mlx5_flow.c
> +++ b/drivers/net/mlx5/mlx5_flow.c
> @@ -2762,22 +2762,20 @@ mlx5_flow_rxq_flags_clear(struct rte_eth_dev
> *dev)
>  {
>   struct priv *priv = dev->data->dev_private;
>   unsigned int i;
> - unsigned int idx;
> 
> - for (idx = 0, i = 0; idx != priv->rxqs_n; ++i) {
> + for (i = 0; i != priv->rxqs_n; ++i) {
>   struct mlx5_rxq_ctrl *rxq_ctrl;
>   unsigned int j;
> 
> - if (!(*priv->rxqs)[idx])
> + if (!(*priv->rxqs)[i])
>   continue;
> - rxq_ctrl = container_of((*priv->rxqs)[idx],
> + rxq_ctrl = container_of((*priv->rxqs)[i],
>   struct mlx5_rxq_ctrl, rxq);
>   rxq_ctrl->flow_mark_n = 0;
>   rxq_ctrl->rxq.mark = 0;
>   for (j = 0; j != MLX5_FLOW_TUNNEL; ++j)
>   rxq_ctrl->flow_tunnels_n[j] = 0;
>   rxq_ctrl->rxq.tunnel = 0;
> - ++idx;
>   }
>  }
> 

Acked-by: Ori Kam 

> --
> 2.11.0

Re: [dpdk-dev] Bypass support in the i40e PMD driver

[Xing, Beilei]

> -Original Message-
> From: Yigit, Ferruh
> Sent: Tuesday, July 24, 2018 4:42 AM
> To: EJ Raymond ; dev@dpdk.org
> Cc: Xing, Beilei ; Zhang, Qi Z ;
> Zhang, Helin 
> Subject: Re: [dpdk-dev] Bypass support in the i40e PMD driver
> 
> On 7/20/2018 7:39 PM, EJ Raymond wrote:
> > Hi,
> >
> > I'm currently working with the PE310G4BPI71 Bypass card from Silicom,
> > Inc., This board is based on the i40E chip (Intel X710 - Fortville).
> > In DPDK, this card makes use of the i40e PMD driver, and I've noticed
> > that bypass configuration is only supported in the IXGBE PMD driver
> > today. Can anyone say if there'll be support for configuring the
> > various bypass modes and watchdog timer in the librte_pmd_i40e driver in
> the future?
> 
> cc'ed i40e maintainers.
> 

Sorry I didn't hear anything about i40e bypass related currently.

> >
> > Thanks,
> > EJ
> >

Re: [dpdk-dev] [PATCH] net/mlx5: fix tci mask filter

[Ori Kam]

> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Nelio Laranjeiro
> Sent: Monday, July 23, 2018 10:19 AM
> To: dev@dpdk.org; Yongseok Koh ; Shahaf Shuler
> 
> Cc: sta...@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/mlx5: fix tci mask filter
> 
> In mlx5_traffic_enable() the TCI mask for the VLAN is wrong causing the
> sub flow engine to reject the rule.
> 
> Fixes: 272733b5ebfd ("net/mlx5: use flow to enable unicast traffic")
> Cc: sta...@dpdk.org
> 
> Signed-off-by: Nelio Laranjeiro 
> ---
>  drivers/net/mlx5/mlx5_trigger.c | 10 --
>  1 file changed, 4 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/net/mlx5/mlx5_trigger.c
> b/drivers/net/mlx5/mlx5_trigger.c
> index 4d2078bbd..d02a626ae 100644
> --- a/drivers/net/mlx5/mlx5_trigger.c
> +++ b/drivers/net/mlx5/mlx5_trigger.c
> @@ -300,9 +300,8 @@ mlx5_traffic_enable(struct rte_eth_dev *dev)
>   struct rte_flow_item_vlan vlan_spec = {
>   .tci = rte_cpu_to_be_16(vlan),
>   };
> - struct rte_flow_item_vlan vlan_mask = {
> - .tci = 0x,
> - };
> + struct rte_flow_item_vlan vlan_mask =
> + rte_flow_item_vlan_mask;
> 
>   ret = mlx5_ctrl_flow_vlan(dev, &bcast, &bcast,
> &vlan_spec, &vlan_mask);
> @@ -339,9 +338,8 @@ mlx5_traffic_enable(struct rte_eth_dev *dev)
>   struct rte_flow_item_vlan vlan_spec = {
>   .tci = rte_cpu_to_be_16(vlan),
>   };
> - struct rte_flow_item_vlan vlan_mask = {
> - .tci = 0x,
> - };
> + struct rte_flow_item_vlan vlan_mask =
> + rte_flow_item_vlan_mask;
> 
>   ret = mlx5_ctrl_flow_vlan(dev, &unicast,
> &unicast_mask,
> --

Acked-by: Ori Kam 

Thanks,
> 2.18.0

Re: [dpdk-dev] [PATCH] doc: add tested NICs in i40e guide

[Li, Xiaoyun]

> -Original Message-
> From: Xing, Beilei
> Sent: Tuesday, July 24, 2018 13:27
> To: Li, Xiaoyun ; Mcnamara, John
> ; Zhang, Qi Z 
> Cc: dev@dpdk.org
> Subject: RE: [PATCH] doc: add tested NICs in i40e guide
> 
> 
> 
> > -Original Message-
> > From: Li, Xiaoyun
> > Sent: Monday, July 23, 2018 2:34 PM
> > To: Mcnamara, John ; Xing, Beilei
> > ; Zhang, Qi Z 
> > Cc: dev@dpdk.org; Li, Xiaoyun 
> > Subject: [PATCH] doc: add tested NICs in i40e guide
> >
> > Add suggested kernel driver and firmware version for i40e PMD.
> >
> > Signed-off-by: Xiaoyun Li 
> > ---
> >  doc/guides/nics/i40e.rst | 29 +
> >  1 file changed, 29 insertions(+)
> >
> > diff --git a/doc/guides/nics/i40e.rst b/doc/guides/nics/i40e.rst index
> > d5b02c9..d377d92 100644
> > --- a/doc/guides/nics/i40e.rst
> > +++ b/doc/guides/nics/i40e.rst
> > @@ -58,6 +58,35 @@ Prerequisites
> >  - Upgrade the NVM/FW version following the `Intel® Ethernet NVM
> > Update Tool Quick Usage Guide for Linux
> > > ssl.intel.com/content/www/us/en/embedded/products/networking/nvm-
> > update-tool-quick-linux-usage-guide.html>`_ and `Intel® Ethernet NVM
> > Update Tool: Quick Usage Guide for EFI
> >
>  > ing/nvm-update-tool-quick-efi-usage-guide.html>`_ if needed.
> >
> > +Tested NICs
> 
> The guide is only for i40e, so we'd better change the title, how about
> recommended matching list?
> Also the patch title also needs to be changed.

OK. Will send v2 later. Thanks!

> 
> > +---
> > +
> > +It is highly recommended to upgrade the i40e kernel driver and
> > +firmware to avoid the compatibility issues with i40e PMD. Here is the
> > +suggested matching list which has been tested and verified.
> > +
> > +   +--+---+--+
> > +   | DPDK version | Kernel driver version | Firmware version |
> > +   +==+===+==+
> > +   |18.05 | 2.4.6 |   6.01   |
> > +   +--+---+--+
> > +   |18.02 | 2.4.3 |   6.01   |
> > +   +--+---+--+
> > +   |17.11 | 2.1.26|   6.01   |
> > +   +--+---+--+
> > +   |17.08 | 2.0.19|   6.01   |
> > +   +--+---+--+
> > +   |17.05 | 1.5.23|   5.05   |
> > +   +--+---+--+
> > +   |17.02 | 1.5.23|   5.05   |
> > +   +--+---+--+
> > +   |16.11 | 1.5.23|   5.05   |
> > +   +--+---+--+
> > +   |16.07 | 1.4.25|   5.04   |
> > +   +--+---+--+
> > +   |16.04 | 1.4.25|   5.02   |
> > +   +--+---+--+
> > +
> >  Pre-Installation Configuration
> >  --
> >
> > --
> > 2.7.4

[dpdk-dev] [PATCH] net/mlx5: fix route Netlink message overflow

[Nelio Laranjeiro]

Route Netlink message socket is wrongly initialised by registering to
the route link group.  This causes the socket to receive all link
message related to routes whereas the PMD do not expect to receive such
information.  In some situation it ends by filling the socket at a point
that any new message cannot be exchanged.
As the PMD is not expected to process such broadcast messages, the
parameter in the nl_group in the function is also remove.

Fixes: ccdcba53a3f4 ("net/mlx5: use Netlink to add/remove MAC addresses")
Cc: sta...@dpdk.org

Signed-off-by: Zijie Pan 
Signed-off-by: Nelio Laranjeiro 
Acked-by: Adrien Mazarguil 
---
 drivers/net/mlx5/mlx5.c| 8 
 drivers/net/mlx5/mlx5.h| 2 +-
 drivers/net/mlx5/mlx5_nl.c | 5 +
 3 files changed, 6 insertions(+), 9 deletions(-)

diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c
index c62a52fd5..612392a20 100644
--- a/drivers/net/mlx5/mlx5.c
+++ b/drivers/net/mlx5/mlx5.c
@@ -946,8 +946,8 @@ mlx5_dev_spawn(struct rte_device *dpdk_dev,
rte_spinlock_init(&priv->uar_lock[i]);
 #endif
/* Some internal functions rely on Netlink sockets, open them now. */
-   priv->nl_socket_rdma = mlx5_nl_init(0, NETLINK_RDMA);
-   priv->nl_socket_route = mlx5_nl_init(RTMGRP_LINK, NETLINK_ROUTE);
+   priv->nl_socket_rdma = mlx5_nl_init(NETLINK_RDMA);
+   priv->nl_socket_route = mlx5_nl_init(NETLINK_ROUTE);
priv->nl_sn = 0;
priv->representor = !!switch_info->representor;
priv->domain_id = RTE_ETH_DEV_SWITCH_DOMAIN_ID_INVALID;
@@ -1286,8 +1286,8 @@ mlx5_pci_probe(struct rte_pci_driver *pci_drv 
__rte_unused,
ibv_match[n] = NULL;
 
struct mlx5_dev_spawn_data list[n];
-   int nl_route = n ? mlx5_nl_init(0, NETLINK_ROUTE) : -1;
-   int nl_rdma = n ? mlx5_nl_init(0, NETLINK_RDMA) : -1;
+   int nl_route = n ? mlx5_nl_init(NETLINK_ROUTE) : -1;
+   int nl_rdma = n ? mlx5_nl_init(NETLINK_RDMA) : -1;
unsigned int i;
unsigned int u;
 
diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h
index 896158aed..65a45a34a 100644
--- a/drivers/net/mlx5/mlx5.h
+++ b/drivers/net/mlx5/mlx5.h
@@ -372,7 +372,7 @@ int mlx5_socket_connect(struct rte_eth_dev *priv);
 
 /* mlx5_nl.c */
 
-int mlx5_nl_init(uint32_t nlgroups, int protocol);
+int mlx5_nl_init(int protocol);
 int mlx5_nl_mac_addr_add(struct rte_eth_dev *dev, struct ether_addr *mac,
 uint32_t index);
 int mlx5_nl_mac_addr_remove(struct rte_eth_dev *dev, struct ether_addr *mac,
diff --git a/drivers/net/mlx5/mlx5_nl.c b/drivers/net/mlx5/mlx5_nl.c
index 008cd2c31..0cc26f9f1 100644
--- a/drivers/net/mlx5/mlx5_nl.c
+++ b/drivers/net/mlx5/mlx5_nl.c
@@ -89,8 +89,6 @@ struct mlx5_nl_ifindex_data {
 /**
  * Opens a Netlink socket.
  *
- * @param nl_groups
- *   Netlink group value (e.g. RTMGRP_LINK).
  * @param protocol
  *   Netlink protocol (e.g. NETLINK_ROUTE, NETLINK_RDMA).
  *
@@ -99,14 +97,13 @@ struct mlx5_nl_ifindex_data {
  *   rte_errno is set.
  */
 int
-mlx5_nl_init(uint32_t nl_groups, int protocol)
+mlx5_nl_init(int protocol)
 {
int fd;
int sndbuf_size = MLX5_SEND_BUF_SIZE;
int rcvbuf_size = MLX5_RECV_BUF_SIZE;
struct sockaddr_nl local = {
.nl_family = AF_NETLINK,
-   .nl_groups = nl_groups,
};
int ret;
 
-- 
2.18.0

[dpdk-dev] [PATCH v2] doc: add recommended matching list in i40e guide

[Xiaoyun Li]

Add suggested kernel driver and firmware version for i40e PMD.

Signed-off-by: Xiaoyun Li 
---
 doc/guides/nics/i40e.rst | 29 +
 1 file changed, 29 insertions(+)

---
v2:
* Polish the title and section name

diff --git a/doc/guides/nics/i40e.rst b/doc/guides/nics/i40e.rst
index d5b02c9..b8c1c1d 100644
--- a/doc/guides/nics/i40e.rst
+++ b/doc/guides/nics/i40e.rst
@@ -58,6 +58,35 @@ Prerequisites
 - Upgrade the NVM/FW version following the `Intel® Ethernet NVM Update Tool 
Quick Usage Guide for Linux
   
`_
 and `Intel® Ethernet NVM Update Tool: Quick Usage Guide for EFI 
`_
 if needed.
 
+Recommended Matching List
+-
+
+It is highly recommended to upgrade the i40e kernel driver and firmware to
+avoid the compatibility issues with i40e PMD. Here is the suggested matching
+list which has been tested and verified.
+
+   +--+---+--+
+   | DPDK version | Kernel driver version | Firmware version |
+   +==+===+==+
+   |18.05 | 2.4.6 |   6.01   |
+   +--+---+--+
+   |18.02 | 2.4.3 |   6.01   |
+   +--+---+--+
+   |17.11 | 2.1.26|   6.01   |
+   +--+---+--+
+   |17.08 | 2.0.19|   6.01   |
+   +--+---+--+
+   |17.05 | 1.5.23|   5.05   |
+   +--+---+--+
+   |17.02 | 1.5.23|   5.05   |
+   +--+---+--+
+   |16.11 | 1.5.23|   5.05   |
+   +--+---+--+
+   |16.07 | 1.4.25|   5.04   |
+   +--+---+--+
+   |16.04 | 1.4.25|   5.02   |
+   +--+---+--+
+
 Pre-Installation Configuration
 --
 
-- 
2.7.4

Re: [dpdk-dev] [PATCH] net/mlx5: fix possible endless loop when clearing flow flags

[Nélio Laranjeiro]

On Mon, Jul 23, 2018 at 11:27:44AM -0700, Yongseok Koh wrote:
> If one of (*priv->rxqs)[] is null, the for loop can iterate infinitely as
> idx can't be increased.
> 
> Fixes: cd24d526395e ("net/mlx5: add mark/flag flow action")
> Cc: Nelio Laranjeiro 
> 
> Signed-off-by: Yongseok Koh 
> ---
>  drivers/net/mlx5/mlx5_flow.c | 8 +++-
>  1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
> index 32854198b..c156f01eb 100644
> --- a/drivers/net/mlx5/mlx5_flow.c
> +++ b/drivers/net/mlx5/mlx5_flow.c
> @@ -2762,22 +2762,20 @@ mlx5_flow_rxq_flags_clear(struct rte_eth_dev *dev)
>  {
>   struct priv *priv = dev->data->dev_private;
>   unsigned int i;
> - unsigned int idx;
>  
> - for (idx = 0, i = 0; idx != priv->rxqs_n; ++i) {
> + for (i = 0; i != priv->rxqs_n; ++i) {
>   struct mlx5_rxq_ctrl *rxq_ctrl;
>   unsigned int j;
>  
> - if (!(*priv->rxqs)[idx])
> + if (!(*priv->rxqs)[i])
>   continue;
> - rxq_ctrl = container_of((*priv->rxqs)[idx],
> + rxq_ctrl = container_of((*priv->rxqs)[i],
>   struct mlx5_rxq_ctrl, rxq);
>   rxq_ctrl->flow_mark_n = 0;
>   rxq_ctrl->rxq.mark = 0;
>   for (j = 0; j != MLX5_FLOW_TUNNEL; ++j)
>   rxq_ctrl->flow_tunnels_n[j] = 0;
>   rxq_ctrl->rxq.tunnel = 0;
> - ++idx;
>   }
>  }
>  
> -- 
> 2.11.0
 
This patch is wrong, (*priv->rxqs)[i] may un-initialised by the
application, the number of queues says how are in used, it does not mean
they are contiguous in the rxqs arrays and this due to the DPDK API
which configure the number of queues with rte_eth_dev_configure()
whereas queues are instantiated with rte_eth_rx_queue_setup() which
takes an position in the array as parameter.

Indeed this code is wrong, idx should always increase whereas i should
only increase if the (*priv->rxqs)[idx] is non null.

-- 
Nélio Laranjeiro
6WIND