Re: [dpdk-dev] [PATCH v3 4/5] compress/zlib: support burst enqueue/dequeue

[De Lara Guarch, Pablo]

> -----Original Message-----
> From: Shally Verma [mailto:shally.ve...@caviumnetworks.com]
> Sent: Saturday, July 21, 2018 7:18 PM
> To: De Lara Guarch, Pablo <pablo.de.lara.gua...@intel.com>
> Cc: dev@dpdk.org; pathr...@caviumnetworks.com;
> mcha...@caviumnetworks.com; ashish.gu...@caviumnetworks.com;
> sunila.s...@caviumnetworks.com; Sunila Sahu <ss...@caviumnetworks.com>
> Subject: [PATCH v3 4/5] compress/zlib: support burst enqueue/dequeue
> 
> From: Sunila Sahu <ss...@caviumnetworks.com>
> 
> Signed-off-by: Sunila Sahu <sunila.s...@caviumnetworks.com>
> Signed-off-by: Shally Verma <shally.ve...@caviumnetworks.com>
> Signed-off-by: Ashish Gupta <ashish.gu...@caviumnetworks.com>
> ---
>  drivers/compress/zlib/zlib_pmd.c | 254

...

> +def_end:
> +     /* Update op stats */
> +     switch (op->status) {
> +     case RTE_COMP_OP_STATUS_SUCCESS:
> +             op->consumed += strm->total_in;

Compilation issue here:

drivers/compress/zlib/zlib_pmd.c:94:16: error: this statement may fall through 
[-Werror=implicit-fallthrough=]
   op->consumed += strm->total_in;
   ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~

I think you are missing a "/* Fall-through */" comment here.

Thanks,
Pablo

> +     case RTE_COMP_OP_STATUS_OUT_OF_SPACE_TERMINATED:
> +             op->produced += strm->total_out;
> +             break;