> -----Original Message-----
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Nelio Laranjeiro
> Sent: Monday, July 23, 2018 10:19 AM
> To: dev@dpdk.org; Yongseok Koh <ys...@mellanox.com>; Shahaf Shuler
> <shah...@mellanox.com>
> Cc: sta...@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/mlx5: fix tci mask filter
>
> In mlx5_traffic_enable() the TCI mask for the VLAN is wrong causing the
> sub flow engine to reject the rule.
>
> Fixes: 272733b5ebfd ("net/mlx5: use flow to enable unicast traffic")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Nelio Laranjeiro <nelio.laranje...@6wind.com>
> ---
> drivers/net/mlx5/mlx5_trigger.c | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/net/mlx5/mlx5_trigger.c
> b/drivers/net/mlx5/mlx5_trigger.c
> index 4d2078bbd..d02a626ae 100644
> --- a/drivers/net/mlx5/mlx5_trigger.c
> +++ b/drivers/net/mlx5/mlx5_trigger.c
> @@ -300,9 +300,8 @@ mlx5_traffic_enable(struct rte_eth_dev *dev)
> struct rte_flow_item_vlan vlan_spec = {
> .tci = rte_cpu_to_be_16(vlan),
> };
> - struct rte_flow_item_vlan vlan_mask = {
> - .tci = 0xffff,
> - };
> + struct rte_flow_item_vlan vlan_mask =
> + rte_flow_item_vlan_mask;
>
> ret = mlx5_ctrl_flow_vlan(dev, &bcast, &bcast,
> &vlan_spec, &vlan_mask);
> @@ -339,9 +338,8 @@ mlx5_traffic_enable(struct rte_eth_dev *dev)
> struct rte_flow_item_vlan vlan_spec = {
> .tci = rte_cpu_to_be_16(vlan),
> };
> - struct rte_flow_item_vlan vlan_mask = {
> - .tci = 0xffff,
> - };
> + struct rte_flow_item_vlan vlan_mask =
> + rte_flow_item_vlan_mask;
>
> ret = mlx5_ctrl_flow_vlan(dev, &unicast,
> &unicast_mask,
> --
Acked-by: Ori Kam <or...@mellanox.com>
Thanks,
> 2.18.0
