Re: [dpdk-dev] [PATCH] examples/ip_fragmentation: fix check of packet type

[Ananyev, Konstantin]

Hi Wei,

> 
> Hi, Konstantin
> I see your point.
> I think your method can work.
> But I think your method is a bit complex. As you method need to add more 
> codes.
> Anyway this is a simple bug.
> How do you think now ?

I still think it is better for all apps to handle this issue in a uniform way.
Again in that case for NICs that do support PTYPE offloads the performance 
should be unaffected.
Konstantin

> 
> > -Original Message-
> > From: Ananyev, Konstantin
> > Sent: Friday, March 10, 2017 8:21 PM
> > To: Dai, Wei ; dev@dpdk.org
> > Cc: sta...@dpdk.org
> > Subject: RE: [PATCH] examples/ip_fragmentation: fix check of packet type
> >
> > Hi Wei,
> >
> > > -Original Message-
> > > From: Dai, Wei
> > > Sent: Friday, March 10, 2017 3:28 AM
> > > To: dev@dpdk.org; Ananyev, Konstantin 
> > > Cc: Dai, Wei ; sta...@dpdk.org
> > > Subject: [PATCH] examples/ip_fragmentation: fix check of packet type
> > >
> > > The packet_type in mbuf is not correctly filled by ixgbe 82599 NIC.
> > > To use the ether_type in ethernet header to check packet type is more
> > > reliaber.
> > >
> > > Fixes: 3c0184cc0c60 ("examples: replace some offload flags with packet
> > > type")
> > > Fixes: ab351fe1c95c ("mbuf: remove packet type from offload flags")
> > >
> > > Cc: sta...@dpdk.org
> > >
> > > Reported-by: Fangfang Wei 
> > > Signed-off-by: Wei Dai 
> > > Tested-by: Fagnfang Wei 
> > > ---
> > >  examples/ip_fragmentation/main.c | 10 ++
> > >  1 file changed, 6 insertions(+), 4 deletions(-)
> > >
> > > diff --git a/examples/ip_fragmentation/main.c
> > > b/examples/ip_fragmentation/main.c
> > > index e1e32c6..8612984 100644
> > > --- a/examples/ip_fragmentation/main.c
> > > +++ b/examples/ip_fragmentation/main.c
> > > @@ -268,6 +268,7 @@ l3fwd_simple_forward(struct rte_mbuf *m, struct
> > lcore_queue_conf *qconf,
> > >   uint32_t i, len, next_hop_ipv4;
> > >   uint8_t next_hop_ipv6, port_out, ipv6;
> > >   int32_t len2;
> > > + struct ether_hdr *eth_hdr;
> > >
> > >   ipv6 = 0;
> > >   rxq = &qconf->rx_queue_list[queueid]; @@ -276,13 +277,14 @@
> > > l3fwd_simple_forward(struct rte_mbuf *m, struct lcore_queue_conf *qconf,
> > >   port_out = port_in;
> > >
> > >   /* Remove the Ethernet header and trailer from the input packet */
> > > + eth_hdr = rte_pktmbuf_mtod(m, struct ether_hdr *);
> > >   rte_pktmbuf_adj(m, (uint16_t)sizeof(struct ether_hdr));
> > >
> > >   /* Build transmission burst */
> > >   len = qconf->tx_mbufs[port_out].len;
> > >
> > >   /* if this is an IPv4 packet */
> > > - if (RTE_ETH_IS_IPV4_HDR(m->packet_type)) {
> > > + if (eth_hdr->ether_type == rte_cpu_to_be_16(ETHER_TYPE_IPv4)) {
> > >   struct ipv4_hdr *ip_hdr;
> > >   uint32_t ip_dst;
> > >   /* Read the lookup key (i.e. ip_dst) from the input packet */ @@
> > > -316,7 +318,7 @@ l3fwd_simple_forward(struct rte_mbuf *m, struct
> > lcore_queue_conf *qconf,
> > >   if (unlikely (len2 < 0))
> > >   return;
> > >   }
> > > - } else if (RTE_ETH_IS_IPV6_HDR(m->packet_type)) {
> > > + } else if (eth_hdr->ether_type == rte_be_to_cpu_16(ETHER_TYPE_IPv6))
> > > +{
> > >   /* if this is an IPv6 packet */
> > >   struct ipv6_hdr *ip_hdr;
> > >
> > > @@ -363,8 +365,8 @@ l3fwd_simple_forward(struct rte_mbuf *m, struct
> > lcore_queue_conf *qconf,
> > >   void *d_addr_bytes;
> > >
> > >   m = qconf->tx_mbufs[port_out].m_table[i];
> > > - struct ether_hdr *eth_hdr = (struct ether_hdr *)
> > > - rte_pktmbuf_prepend(m, (uint16_t)sizeof(struct 
> > > ether_hdr));
> > > + eth_hdr = (struct ether_hdr *)rte_pktmbuf_prepend(m,
> > > + (uint16_t)sizeof(struct ether_hdr));
> > >   if (eth_hdr == NULL) {
> > >   rte_panic("No headroom in mbuf.\n");
> > >   }
> >
> > Thanks for the fix.
> > Would it be more convenient to do what l3fwd does:
> > Check what ptype capabilities are provided by HW, if no ptype support 
> > detected,
> > then install an RX callback?
> > Konstantin
> >
> > > --
> > > 2.7.4

[dpdk-dev] [PATCH] net/virtio-user: fix overflow

[Wenfeng Liu]

This commit fixes an array overflow when number of queues is higher than 8.

Fixes: 37a7eb2ae816 ("net/virtio-user: add device emulation layer")

Signed-off-by: Wenfeng Liu 
---
 drivers/net/virtio/virtio_pci.h  | 3 ++-
 drivers/net/virtio/virtio_user/virtio_user_dev.c | 2 +-
 drivers/net/virtio/virtio_user/virtio_user_dev.h | 6 +++---
 drivers/net/virtio/virtio_user_ethdev.c  | 7 +++
 4 files changed, 13 insertions(+), 5 deletions(-)

diff --git a/drivers/net/virtio/virtio_pci.h b/drivers/net/virtio/virtio_pci.h
index 59e45c4..bd940b4 100644
--- a/drivers/net/virtio/virtio_pci.h
+++ b/drivers/net/virtio/virtio_pci.h
@@ -160,7 +160,8 @@
 /*
  * Maximum number of virtqueues per device.
  */
-#define VIRTIO_MAX_VIRTQUEUES 8
+#define VIRTIO_MAX_VIRTQUEUE_PAIRS 8
+#define VIRTIO_MAX_VIRTQUEUES VIRTIO_MAX_VIRTQUEUE_PAIRS * 2 + 1
 
 /* Common configuration */
 #define VIRTIO_PCI_CAP_COMMON_CFG  1
diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c 
b/drivers/net/virtio/virtio_user/virtio_user_dev.c
index e7fd65f..5b81676 100644
--- a/drivers/net/virtio/virtio_user/virtio_user_dev.c
+++ b/drivers/net/virtio/virtio_user/virtio_user_dev.c
@@ -234,7 +234,7 @@ int virtio_user_stop_device(struct virtio_user_dev *dev)
uint32_t i, q;
 
dev->vhostfd = -1;
-   for (i = 0; i < VIRTIO_MAX_VIRTQUEUES * 2 + 1; ++i) {
+   for (i = 0; i < VIRTIO_MAX_VIRTQUEUES; ++i) {
dev->kickfds[i] = -1;
dev->callfds[i] = -1;
}
diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.h 
b/drivers/net/virtio/virtio_user/virtio_user_dev.h
index 6ecb91e..ba80d05 100644
--- a/drivers/net/virtio/virtio_user/virtio_user_dev.h
+++ b/drivers/net/virtio/virtio_user/virtio_user_dev.h
@@ -49,8 +49,8 @@ struct virtio_user_dev {
int *tapfds;
 
/* for both vhost_user and vhost_kernel */
-   int callfds[VIRTIO_MAX_VIRTQUEUES * 2 + 1];
-   int kickfds[VIRTIO_MAX_VIRTQUEUES * 2 + 1];
+   int callfds[VIRTIO_MAX_VIRTQUEUES];
+   int kickfds[VIRTIO_MAX_VIRTQUEUES];
int mac_specified;
uint32_tmax_queue_pairs;
uint32_tqueue_pairs;
@@ -62,7 +62,7 @@ struct virtio_user_dev {
uint8_t status;
uint8_t mac_addr[ETHER_ADDR_LEN];
charpath[PATH_MAX];
-   struct vringvrings[VIRTIO_MAX_VIRTQUEUES * 2 + 1];
+   struct vringvrings[VIRTIO_MAX_VIRTQUEUES];
struct virtio_user_backend_ops *ops;
 };
 
diff --git a/drivers/net/virtio/virtio_user_ethdev.c 
b/drivers/net/virtio/virtio_user_ethdev.c
index 16d1526..d476a2d 100644
--- a/drivers/net/virtio/virtio_user_ethdev.c
+++ b/drivers/net/virtio/virtio_user_ethdev.c
@@ -433,6 +433,13 @@
goto end;
}
 
+   if (queues > VIRTIO_MAX_VIRTQUEUE_PAIRS) {
+   PMD_INIT_LOG(ERR, "arg %s %u exceeds the limit %u",
+   VIRTIO_USER_ARG_QUEUES_NUM, queues,
+   VIRTIO_MAX_VIRTQUEUE_PAIRS);
+   goto end;
+   }
+
eth_dev = virtio_user_eth_dev_alloc(name);
if (!eth_dev) {
PMD_INIT_LOG(ERR, "virtio_user fails to alloc device");
-- 
1.8.3.1

Re: [dpdk-dev] [PATCH] examples/ip_fragmentation: fix check of packet type

[Dai, Wei]

> -Original Message-
> From: Ananyev, Konstantin
> Sent: Monday, March 13, 2017 3:02 PM
> To: Dai, Wei ; dev@dpdk.org
> Cc: sta...@dpdk.org
> Subject: RE: [PATCH] examples/ip_fragmentation: fix check of packet type
> 
> Hi Wei,
> 
> >
> > Hi, Konstantin
> > I see your point.
> > I think your method can work.
> > But I think your method is a bit complex. As you method need to add more
> codes.
> > Anyway this is a simple bug.
> > How do you think now ?
> 
> I still think it is better for all apps to handle this issue in a uniform way.
> Again in that case for NICs that do support PTYPE offloads the performance
> should be unaffected.
> Konstantin
> 

I have just had a quick look through the l3fwd and didn't find any codes to 
check what ptypes capabilities ae provided by stuff below DPDK PMD & its base 
driver.
L3fwd only check an input argument "--parse-ptype" to enable ptype check 
implemented in
a Rx callback function.
In this l3fwd rx callback function,  it has done the same thing as my code.
Anyway, I'd like to provide a v2 patch to deal with this issue in a uniform way.

Thanks & Best Regards
-Wei

[dpdk-dev] [PATCH v2] net/thunderx: check data offset alignment requirement

[Jerin Jacob]

nicvf HW expects the DMA address of the packet data to be
aligned with cache line size.

Packet data offset is a function of struct mbuf size,
mbuf private size and headroom. mbuf private size can
be changed from the application in pool creation, this
check detects HW alignment requirement constraint in pmd
start function.

Signed-off-by: Jerin Jacob 
Acked-by: Hemant Agrawal 
---
v2:
Add pool name in error log(Hemant)
---
 drivers/net/thunderx/nicvf_ethdev.c | 14 +++---
 1 file changed, 11 insertions(+), 3 deletions(-)

diff --git a/drivers/net/thunderx/nicvf_ethdev.c 
b/drivers/net/thunderx/nicvf_ethdev.c
index fa1cb32..5f34237 100644
--- a/drivers/net/thunderx/nicvf_ethdev.c
+++ b/drivers/net/thunderx/nicvf_ethdev.c
@@ -1409,7 +1409,7 @@ static int
 nicvf_vf_start(struct rte_eth_dev *dev, struct nicvf *nic, uint32_t rbdrsz)
 {
int ret;
-   uint16_t qidx;
+   uint16_t qidx, data_off;
uint32_t total_rxq_desc, nb_rbdr_desc, exp_buffs;
uint64_t mbuf_phys_off = 0;
struct nicvf_rxq *rxq;
@@ -1450,10 +1450,18 @@ nicvf_vf_start(struct rte_eth_dev *dev, struct nicvf 
*nic, uint32_t rbdrsz)
 nic->vf_id, qidx, rxq->pool->name);
return -ENOMEM;
}
-   rxq->mbuf_phys_off -= nicvf_mbuff_meta_length(mbuf);
-   rxq->mbuf_phys_off -= RTE_PKTMBUF_HEADROOM;
+   data_off = nicvf_mbuff_meta_length(mbuf);
+   data_off += RTE_PKTMBUF_HEADROOM;
rte_pktmbuf_free(mbuf);
 
+   if (data_off % RTE_CACHE_LINE_SIZE) {
+   PMD_INIT_LOG(ERR, "%s: unaligned data_off=%d delta=%d",
+   rxq->pool->name, data_off,
+   data_off % RTE_CACHE_LINE_SIZE);
+   return -EINVAL;
+   }
+   rxq->mbuf_phys_off -= data_off;
+
if (mbuf_phys_off == 0)
mbuf_phys_off = rxq->mbuf_phys_off;
if (mbuf_phys_off != rxq->mbuf_phys_off) {
-- 
2.5.5

Re: [dpdk-dev] [PATCH 3/3] eal: remove references to execinfo.h for musl

[Dai, Wei]

> -Original Message-
> From: jblu...@gmail.com [mailto:jblu...@gmail.com] On Behalf Of Jan Blunck
> Sent: Friday, March 10, 2017 10:50 PM
> To: Thomas Monjalon 
> Cc: Dai, Wei ; dev ; Mcnamara, John
> ; david.march...@intel.com
> Subject: Re: [dpdk-dev] [PATCH 3/3] eal: remove references to execinfo.h for
> musl
> 
> On Fri, Mar 10, 2017 at 1:40 PM, Thomas Monjalon
>  wrote:
> > 2017-03-10 19:58, Wei Dai:
> >> @@ -47,6 +50,7 @@
> >>  /* dump the stack of the calling core */  void rte_dump_stack(void)
> >> {
> >> +#ifndef RTE_LIBC_MUSL
> >>   void *func[BACKTRACE_SIZE];
> >>   char **symb = NULL;
> >>   int size;
> >> @@ -64,6 +68,7 @@ void rte_dump_stack(void)
> >>   }
> >>
> >>   free(symb);
> >> +#endif
> >>  }
> >
> > There are probably other libc implementations not supporting this feature.
> > Instead of calling it "RTE_LIBC_MUSL", it should something like
> > "ENABLE_BACKTRACE".
> > Then you can add a musl section in the Linux quick start guide.
> 
> Also I would improve the code readability by removing the preprocessor junk
> from it by moving the rte_dump_stack() function into eal_backtrace.c and make
> that conditionally compile based on CONFIG_ENABLE_BACKTRACE.

I'd like to change CONFIG_RTE_LIBC_MUSL  to  CONFIG_RTE_EAL_ENABLE_BACKTRACE and
Will send a v2 patch soon.
Anyway, you also still can move rte_dump_stack() to another file when my change 
is accepted.

Re: [dpdk-dev] [PATCH v4 01/17] eventdev: increase size of enq deq conf variables

[Jerin Jacob]

On Fri, Mar 10, 2017 at 07:43:16PM +, Harry van Haaren wrote:
> Large port enqueue sizes were not supported as the value
> it was stored in was a uint8_t. Using uint8_ts to save
> space in config apis makes no sense - increasing the 3
> instances of uint8_t enqueue / dequeue depths to more
> appropriate values (based on the context around them).
> 
> Signed-off-by: Harry van Haaren 
> Acked-by: Jerin Jacob 


Applied to dpdk-next-eventdev/master. Thanks.

> ---
>  lib/librte_eventdev/rte_eventdev.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/lib/librte_eventdev/rte_eventdev.h 
> b/lib/librte_eventdev/rte_eventdev.h
> index e2fdf72..4876353 100644
> --- a/lib/librte_eventdev/rte_eventdev.h
> +++ b/lib/librte_eventdev/rte_eventdev.h
> @@ -426,7 +426,7 @@ struct rte_event_dev_config {
>* This value cannot exceed the *max_event_queue_flows* which previously
>* provided in rte_event_dev_info_get()
>*/
> - uint8_t nb_event_port_dequeue_depth;
> + uint32_t nb_event_port_dequeue_depth;
>   /**< Maximum number of events can be dequeued at a time from an
>* event port by this device.
>* This value cannot exceed the *max_event_port_dequeue_depth*
> @@ -637,12 +637,12 @@ struct rte_event_port_conf {
>* which was previously supplied to rte_event_dev_configure().
>* This should be set to '-1' for *open system*.
>*/
> - uint8_t dequeue_depth;
> + uint16_t dequeue_depth;
>   /**< Configure number of bulk dequeues for this event port.
>* This value cannot exceed the *nb_event_port_dequeue_depth*
>* which previously supplied to rte_event_dev_configure()
>*/
> - uint8_t enqueue_depth;
> + uint16_t enqueue_depth;
>   /**< Configure number of bulk enqueues for this event port.
>* This value cannot exceed the *nb_event_port_enqueue_depth*
>* which previously supplied to rte_event_dev_configure()
> -- 
> 2.7.4
> 

Re: [dpdk-dev] [PATCH] eventdev: improve API docs for timeout ticks

[Jerin Jacob]

On Wed, Mar 08, 2017 at 10:35:34AM +, Harry van Haaren wrote:
> Improve the documentation of the return values of the
> rte_event_dequeue_timeout_ticks() function, adding a
> -ENOTSUP value for eventdevs that do not support waiting.
> 
> Signed-off-by: Harry van Haaren 
> Acked-by: Jerin Jacob 

Applied to dpdk-next-eventdev/master. Thanks.

> 
> ---
> 
> Discussion and previous Acked from:
> http://dpdk.org/ml/archives/dev/2017-March/059419.html
> ---
>  lib/librte_eventdev/rte_eventdev.h | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/lib/librte_eventdev/rte_eventdev.h 
> b/lib/librte_eventdev/rte_eventdev.h
> index 7073987..bb216b4 100644
> --- a/lib/librte_eventdev/rte_eventdev.h
> +++ b/lib/librte_eventdev/rte_eventdev.h
> @@ -1158,7 +1158,9 @@ rte_event_enqueue_burst(uint8_t dev_id, uint8_t port_id,
>   *
>   * @return
>   *  - 0 on success.
> - *  - <0 on failure.
> + *  - -ENOTSUP if the device doesn't support timeouts
> + *  - -EINVAL if *dev_id* is invalid or *timeout_ticks* is NULL
> + *  - other values < 0 on failure.
>   *
>   * @see rte_event_dequeue_burst(), RTE_EVENT_DEV_CFG_PER_DEQUEUE_TIMEOUT
>   * @see rte_event_dev_configure()
> -- 
> 2.7.4
> 

Re: [dpdk-dev] [PATCH v2] eventdev: event device to contain rte device holder

[Jerin Jacob]

On Fri, Mar 03, 2017 at 09:03:02PM +0530, Nipun Gupta wrote:
> rte_device is a generic device which is available to the applications
> and EAL. This patch replaces rte_pci_device in 'struct rte_eventdev'
> and in 'struct rte_event_dev_info' with common rte_device.
> 
> Signed-off-by: Nipun Gupta 
> Acked-by: Shreyansh Jain 

Applied to dpdk-next-eventdev/master. Thanks.

> ---
>  drivers/event/skeleton/skeleton_eventdev.c | 2 +-
>  lib/librte_eventdev/rte_eventdev.c | 6 +++---
>  lib/librte_eventdev/rte_eventdev.h | 6 +++---
>  3 files changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/event/skeleton/skeleton_eventdev.c 
> b/drivers/event/skeleton/skeleton_eventdev.c
> index dee0faf..770dce3 100644
> --- a/drivers/event/skeleton/skeleton_eventdev.c
> +++ b/drivers/event/skeleton/skeleton_eventdev.c
> @@ -383,7 +383,7 @@
>   if (rte_eal_process_type() != RTE_PROC_PRIMARY)
>   return 0;
>  
> - pci_dev = eventdev->pci_dev;
> + pci_dev = RTE_DEV_TO_PCI(eventdev->dev);
>  
>   skel->reg_base = (uintptr_t)pci_dev->mem_resource[0].addr;
>   if (!skel->reg_base) {
> diff --git a/lib/librte_eventdev/rte_eventdev.c 
> b/lib/librte_eventdev/rte_eventdev.c
> index 68bfc3b..b8be5da 100644
> --- a/lib/librte_eventdev/rte_eventdev.c
> +++ b/lib/librte_eventdev/rte_eventdev.c
> @@ -125,7 +125,7 @@
>  
>   dev_info->dequeue_timeout_ns = dev->data->dev_conf.dequeue_timeout_ns;
>  
> - dev_info->pci_dev = dev->pci_dev;
> + dev_info->dev = dev->dev;
>   if (dev->driver)
>   dev_info->driver_name = dev->driver->pci_drv.driver.name;
>   return 0;
> @@ -1196,7 +1196,7 @@ struct rte_eventdev *
>   "device data");
>   }
>  
> - eventdev->pci_dev = pci_dev;
> + eventdev->dev = &pci_dev->device;
>   eventdev->driver = eventdrv;
>  
>   /* Invoke PMD device initialization function */
> @@ -1250,7 +1250,7 @@ struct rte_eventdev *
>   /* Free event device */
>   rte_event_pmd_release(eventdev);
>  
> - eventdev->pci_dev = NULL;
> + eventdev->dev = NULL;
>   eventdev->driver = NULL;
>  
>   return 0;
> diff --git a/lib/librte_eventdev/rte_eventdev.h 
> b/lib/librte_eventdev/rte_eventdev.h
> index 7073987..6140078 100644
> --- a/lib/librte_eventdev/rte_eventdev.h
> +++ b/lib/librte_eventdev/rte_eventdev.h
> @@ -330,7 +330,7 @@
>   */
>  struct rte_event_dev_info {
>   const char *driver_name;/**< Event driver name */
> - struct rte_pci_device *pci_dev; /**< PCI information */
> + struct rte_device *dev; /**< Device information */
>   uint32_t min_dequeue_timeout_ns;
>   /**< Minimum supported global dequeue timeout(ns) by this device */
>   uint32_t max_dequeue_timeout_ns;
> @@ -1059,8 +1059,8 @@ struct rte_eventdev {
>   /**< Pointer to device data */
>   const struct rte_eventdev_ops *dev_ops;
>   /**< Functions exported by PMD */
> - struct rte_pci_device *pci_dev;
> - /**< PCI info. supplied by probing */
> + struct rte_device *dev;
> + /**< Device info. supplied by probing */
>   const struct rte_eventdev_driver *driver;
>   /**< Driver for this device */
>  
> -- 
> 1.9.1
> 

Re: [dpdk-dev] [PATCH v3] eventdev: fix links map initialization for SW PMD

[Jerin Jacob]

On Tue, Mar 07, 2017 at 10:25:00AM -0600, Gage Eads wrote:
> This patch initializes the links_map array entries to
> EVENT_QUEUE_SERVICE_PRIORITY_INVALID, as expected by
> rte_event_port_links_get(). This is necessary for the sw eventdev PMD,
> which does not initialize links_map when rte_event_port_setup() calls
> rte_event_port_unlink().
> 
> Fixes: e36bf651b3ca2 ("eventdev: implement the northbound APIs")
> 
> Signed-off-by: Gage Eads 
> Acked-by: Jerin Jacob 

Applied to dpdk-next-eventdev/master after fixing check-git-log.sh warning
http://dpdk.org/ml/archives/test-report/2017-March/013029.html

Thanks.

> ---
> v2: Refined commit message's description of patch
> v3: Fixed check-git-log.sh errors, added Jerin's Acked-by
> 
>  lib/librte_eventdev/rte_eventdev.c | 17 -
>  1 file changed, 12 insertions(+), 5 deletions(-)
> 
> diff --git a/lib/librte_eventdev/rte_eventdev.c 
> b/lib/librte_eventdev/rte_eventdev.c
> index 68bfc3b..b8cd92b 100644
> --- a/lib/librte_eventdev/rte_eventdev.c
> +++ b/lib/librte_eventdev/rte_eventdev.c
> @@ -190,6 +190,8 @@ rte_event_dev_queue_config(struct rte_eventdev *dev, 
> uint8_t nb_queues)
>   return 0;
>  }
>  
> +#define EVENT_QUEUE_SERVICE_PRIORITY_INVALID (0xdead)
> +
>  static inline int
>  rte_event_dev_port_config(struct rte_eventdev *dev, uint8_t nb_ports)
>  {
> @@ -251,6 +253,9 @@ rte_event_dev_port_config(struct rte_eventdev *dev, 
> uint8_t nb_ports)
>   "nb_ports %u", nb_ports);
>   return -(ENOMEM);
>   }
> + for (i = 0; i < nb_ports * RTE_EVENT_MAX_QUEUES_PER_DEV; i++)
> + dev->data->links_map[i] =
> + EVENT_QUEUE_SERVICE_PRIORITY_INVALID;
>   } else if (dev->data->ports != NULL && nb_ports != 0) {/* re-config */
>   RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->port_release, -ENOTSUP);
>  
> @@ -305,6 +310,10 @@ rte_event_dev_port_config(struct rte_eventdev *dev, 
> uint8_t nb_ports)
>  
>   if (nb_ports > old_nb_ports) {
>   uint8_t new_ps = nb_ports - old_nb_ports;
> + unsigned int old_links_map_end =
> + old_nb_ports * RTE_EVENT_MAX_QUEUES_PER_DEV;
> + unsigned int links_map_end =
> + nb_ports * RTE_EVENT_MAX_QUEUES_PER_DEV;
>  
>   memset(ports + old_nb_ports, 0,
>   sizeof(ports[0]) * new_ps);
> @@ -312,9 +321,9 @@ rte_event_dev_port_config(struct rte_eventdev *dev, 
> uint8_t nb_ports)
>   sizeof(ports_dequeue_depth[0]) * new_ps);
>   memset(ports_enqueue_depth + old_nb_ports, 0,
>   sizeof(ports_enqueue_depth[0]) * new_ps);
> - memset(links_map +
> - (old_nb_ports * RTE_EVENT_MAX_QUEUES_PER_DEV),
> - 0, sizeof(ports_enqueue_depth[0]) * new_ps);
> + for (i = old_links_map_end; i < links_map_end; i++)
> + links_map[i] =
> + EVENT_QUEUE_SERVICE_PRIORITY_INVALID;
>   }
>  
>   dev->data->ports = ports;
> @@ -815,8 +824,6 @@ rte_event_port_link(uint8_t dev_id, uint8_t port_id,
>   return diag;
>  }
>  
> -#define EVENT_QUEUE_SERVICE_PRIORITY_INVALID (0xdead)
> -
>  int
>  rte_event_port_unlink(uint8_t dev_id, uint8_t port_id,
> uint8_t queues[], uint16_t nb_unlinks)
> -- 
> 2.7.4
> 

Re: [dpdk-dev] [PATCH v3 1/2] librte_net: add crc compute APIs

[Singh, Jasvinder]

Hi Konstantin,

> -Original Message-
> From: Ananyev, Konstantin
> Sent: Monday, March 13, 2017 3:06 AM
> To: Singh, Jasvinder ; dev@dpdk.org
> Cc: Doherty, Declan ; De Lara Guarch, Pablo
> 
> Subject: RE: [dpdk-dev] [PATCH v3 1/2] librte_net: add crc compute APIs
> 
> Hi Jasvinder,
> 
> >
> > APIs for selecting the architecure specific implementation and
> > computing the crc (16-bit and 32-bit CRCs) are added. For CRCs
> > calculation, scalar as well as x86 intrinsic(sse4.2) versions are 
> > implemented.
> >
> > The scalar version is based on generic Look-Up Table(LUT) algorithm,
> > while x86 intrinsic version uses carry-less multiplication for fast
> > CRC computation.
> >
> > Signed-off-by: Jasvinder Singh 
> > ---
> >  lib/librte_net/Makefile|   3 +
> >  lib/librte_net/rte_net_crc.c   | 205 ++
> >  lib/librte_net/rte_net_crc.h   | 104 +++
> >  lib/librte_net/rte_net_crc_sse.h   | 351
> +
> >  lib/librte_net/rte_net_version.map |   8 +
> >  5 files changed, 671 insertions(+)
> >  create mode 100644 lib/librte_net/rte_net_crc.c  create mode 100644
> > lib/librte_net/rte_net_crc.h  create mode 100644
> > lib/librte_net/rte_net_crc_sse.h
> >
> > +
> > +/**
> > + * CRC compute API
> > + *
> > + * @param mbuf
> > + *  Pointer to the packet mbuf for crc computation
> > + * @param data_offset
> > + *  Offset to the data in the mbuf
> > + * @param data_len
> > + *  length of the data to compute the crc on
> > + * @param type
> > + *  crc type
> > + *
> > + * @return
> > + *  computed crc value
> > + */
> > +uint32_t
> > +rte_net_crc_calc(struct rte_mbuf *mbuf,
> > +   uint32_t data_offset,
> > +   uint32_t data_len,
> > +   enum rte_net_crc_type type);
> 
> 
> I think it will probably be convenient to have this API not dependent on
> mbuf, something like:
> 
> uint32_t rte_net_crc_calc(const void *buf, uint32_t data_len, enum
> rte_net_crc_type type);
> 
> And if we like to have an extra function that would do similar thing for mbuf,
> that's fine too, but I suppose such function would have to handle multi-
> segment case too.
> Konstantin

I will change the api as you suggested. Thanks.

[dpdk-dev] [PATCH v2 1/3] examples/performance-thread: remove reference to execinfo.h

[Wei Dai]

There is no function to refer any part of execinfo.h, so remove the
reference to it. And there is no this file in musl. So need to
remove it to support musl.

The musl is an alternative LIBC to GLIBC and provides the
standard C/POSIX library and extensions.
The musl can be got from http://www.musl-libc.org

Signed-off-by: Wei Dai 
---
 examples/performance-thread/common/lthread_tls.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/examples/performance-thread/common/lthread_tls.c 
b/examples/performance-thread/common/lthread_tls.c
index 6876f83..47505f2 100644
--- a/examples/performance-thread/common/lthread_tls.c
+++ b/examples/performance-thread/common/lthread_tls.c
@@ -42,7 +42,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 
 #include 
-- 
2.7.4

[dpdk-dev] [PATCH v2 0/3] add a macro to enable support of backtrace

[Wei Dai]

Some LIBC implementation like musl doesn't support backtrace( )
and backtrace_symbols declared in execinfo.h.
Currently some DPDK customers fail to build PDDK with musl.
In order to build DPDK with musl, there is a need to
reomve references toexecinfo.h.

Add a configuration parameter in config/common_linuxapp which equals to y 
by default. It also generate a macro named as RTE_EAL_ENABLE_BACKTRACE when 
this configuration paramter equals to y or no above macro when it is n.

---
changes:
v2 -- change configuration parameter name


Wei Dai (3):
  examples/performance-thread: remove reference to execinfo.h
  config: add a marco to enable backtrace or not
  eal: remove references to execinfo.h for musl

 config/common_linuxapp   | 1 +
 examples/performance-thread/common/lthread_tls.c | 1 -
 lib/librte_eal/linuxapp/eal/eal_debug.c  | 4 
 3 files changed, 5 insertions(+), 1 deletion(-)

-- 
2.7.4

[dpdk-dev] [PATCH v2 2/3] config: add a marco to enable backtrace or not

[Wei Dai]

When building DPDK with musl, there is need not to generate
the MACRO named RTE_EAL_ENABLE_BACKTRACE in rte_config.h to
remove some references to execinfo.h which is not supported
by musl now.
This also applies to some other LIBC implementation which
doesn't support backtrace( ) and backtrace_symbols( ).

Got more details about musl from http://www.musl-libc.org .

Signed-off-by: Wei Dai 
---
 config/common_linuxapp | 1 +
 1 file changed, 1 insertion(+)

diff --git a/config/common_linuxapp b/config/common_linuxapp
index 00ebaac..16e0064 100644
--- a/config/common_linuxapp
+++ b/config/common_linuxapp
@@ -37,6 +37,7 @@ CONFIG_RTE_EXEC_ENV_LINUXAPP=y
 
 CONFIG_RTE_EAL_IGB_UIO=y
 CONFIG_RTE_EAL_VFIO=y
+CONFIG_RTE_EAL_ENABLE_BACKTRACE=y
 CONFIG_RTE_KNI_KMOD=y
 CONFIG_RTE_LIBRTE_KNI=y
 CONFIG_RTE_LIBRTE_VHOST=y
-- 
2.7.4

[dpdk-dev] [PATCH v2 3/3] eal: remove references to execinfo.h for musl

[Wei Dai]

execinfo.h is not supported by musl now.
need to remove references to execinfo.h to
build DPDK with musl.

musl is an implementation of the userspace portion
of the standard library functionality described in
the ISO C and POSIX standards, plus common extensions.

Get more details about musl from
http://www.musl-libc.org

This also aplies to some other LIBC implementation which
doesn't support backtrace( ) and backtrace_symbols( ).

Signed-off-by: Wei Dai 
---
 lib/librte_eal/linuxapp/eal/eal_debug.c | 4 
 1 file changed, 4 insertions(+)

diff --git a/lib/librte_eal/linuxapp/eal/eal_debug.c 
b/lib/librte_eal/linuxapp/eal/eal_debug.c
index 5fbc17c..3a9aee9 100644
--- a/lib/librte_eal/linuxapp/eal/eal_debug.c
+++ b/lib/librte_eal/linuxapp/eal/eal_debug.c
@@ -31,7 +31,9 @@
  *   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
+#ifdef RTE_EAL_ENABLE_BACKTRACE
 #include 
+#endif
 #include 
 #include 
 #include 
@@ -47,6 +49,7 @@
 /* dump the stack of the calling core */
 void rte_dump_stack(void)
 {
+#ifdef RTE_EAL_ENABLE_BACKTRACE
void *func[BACKTRACE_SIZE];
char **symb = NULL;
int size;
@@ -64,6 +67,7 @@ void rte_dump_stack(void)
}
 
free(symb);
+#endif
 }
 
 /* not implemented in this environment */
-- 
2.7.4

[dpdk-dev] [PATCH] net/pcap: fix use-after-free

[Johan Samuelsson]

Signed-off-by: Johan Samuelsson 
---
 drivers/net/pcap/rte_eth_pcap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/pcap/rte_eth_pcap.c b/drivers/net/pcap/rte_eth_pcap.c
index 7f0b650..075e3be 100644
--- a/drivers/net/pcap/rte_eth_pcap.c
+++ b/drivers/net/pcap/rte_eth_pcap.c
@@ -293,9 +293,9 @@ eth_pcap_tx_dumper(void *queue, struct rte_mbuf **bufs, 
uint16_t nb_pkts)
}
}
 
-   rte_pktmbuf_free(mbuf);
num_tx++;
tx_bytes += mbuf->pkt_len;
+   rte_pktmbuf_free(mbuf);
}
 
/*
-- 
2.9.3

[dpdk-dev] [PATCH] net/virtio-user: fix tapfds close issue

[Wenfeng Liu]

The valid tap file descriptor range should be equal or greater
than zero instead of non-zero

Fixes: e3b434818bbb ("net/virtio-user: support kernel vhost")

Signed-off-by: Wenfeng Liu 
---
 drivers/net/virtio/virtio_user/vhost_kernel.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/virtio/virtio_user/vhost_kernel.c 
b/drivers/net/virtio/virtio_user/vhost_kernel.c
index 05aa6c6..68d28b1 100644
--- a/drivers/net/virtio/virtio_user/vhost_kernel.c
+++ b/drivers/net/virtio/virtio_user/vhost_kernel.c
@@ -365,7 +365,7 @@ struct vhost_memory_kernel {
vhostfd = dev->vhostfds[pair_idx];
 
if (!enable) {
-   if (dev->tapfds[pair_idx]) {
+   if (dev->tapfds[pair_idx] >= 0) {
close(dev->tapfds[pair_idx]);
dev->tapfds[pair_idx] = -1;
}
-- 
1.8.3.1

Re: [dpdk-dev] [PATCH v9 09/18] lib: add symbol versioning to distributor

[Hunt, David]

-Original Message-
From: Richardson, Bruce 
Sent: Friday, 10 March, 2017 4:22 PM
To: Hunt, David 
Cc: dev@dpdk.org
Subject: Re: [PATCH v9 09/18] lib: add symbol versioning to distributor

On Mon, Mar 06, 2017 at 09:10:24AM +, David Hunt wrote:
> Also bumped up the ABI version number in the Makefile
> 
> Signed-off-by: David Hunt 
> ---
>  lib/librte_distributor/Makefile|  2 +-
>  lib/librte_distributor/rte_distributor.c   | 57 +++---
>  lib/librte_distributor/rte_distributor_v1705.h | 89 
> ++

A file named rte_distributor_v1705.h was added in patch 4, then deleted in 
patch 7, and now added again here. Seems a lot of churn.

/Bruce

[dpdk-dev] [PATCH v2] app/testpmd: add default MAC set cmd

[Pascal Mazon]

Signed-off-by: Pascal Mazon 
---
 app/test-pmd/cmdline.c  | 12 +---
 doc/guides/testpmd_app_ug/testpmd_funcs.rst |  7 +++
 2 files changed, 16 insertions(+), 3 deletions(-)

diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index 43fc6366f279..4bbefa43966e 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -405,6 +405,9 @@ static void cmd_help_long_parsed(void *parsed_result,
"mac_addr remove (port_id) (XX:XX:XX:XX:XX:XX)\n"
"Remove a MAC address from port_id.\n\n"
 
+   "mac_addr set (port_id) (XX:XX:XX:XX:XX:XX)\n"
+   "Set the default MAC address for port_id.\n\n"
+
"mac_addr add port (port_id) vf (vf_id) (mac_address)\n"
"Add a MAC address for a VF on the port.\n\n"
 
@@ -6356,6 +6359,9 @@ static void cmd_mac_addr_parsed(void *parsed_result,
 
if (strcmp(res->what, "add") == 0)
ret = rte_eth_dev_mac_addr_add(res->port_num, &res->address, 0);
+   else if (strcmp(res->what, "set") == 0)
+   ret = rte_eth_dev_default_mac_addr_set(res->port_num,
+  &res->address);
else
ret = rte_eth_dev_mac_addr_remove(res->port_num, &res->address);
 
@@ -6370,7 +6376,7 @@ cmdline_parse_token_string_t cmd_mac_addr_cmd =
"mac_addr");
 cmdline_parse_token_string_t cmd_mac_addr_what =
TOKEN_STRING_INITIALIZER(struct cmd_mac_addr_result, what,
-   "add#remove");
+   "add#remove#set");
 cmdline_parse_token_num_t cmd_mac_addr_portnum =
TOKEN_NUM_INITIALIZER(struct cmd_mac_addr_result, port_num, 
UINT8);
 cmdline_parse_token_etheraddr_t cmd_mac_addr_addr =
@@ -6379,8 +6385,8 @@ cmdline_parse_token_etheraddr_t cmd_mac_addr_addr =
 cmdline_parse_inst_t cmd_mac_addr = {
.f = cmd_mac_addr_parsed,
.data = (void *)0,
-   .help_str = "mac_addr add|remove  : "
-   "Add/Remove MAC address on port_id",
+   .help_str = "mac_addr add|remove|set  : "
+   "Add/Remove/Set MAC address on port_id",
.tokens = {
(void *)&cmd_mac_addr_cmd,
(void *)&cmd_mac_addr_what,
diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst 
b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
index 64ed0285e471..bdc6a14df240 100644
--- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
+++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
@@ -837,6 +837,13 @@ Add an alternative MAC address for a VF to a port::
 
testpmd> mac_add add port (port_id) vf (vf_id) (XX:XX:XX:XX:XX:XX)
 
+mac_addr set
+
+
+Set the default MAC address for a port::
+
+   testpmd> mac_addr set (port_id) (XX:XX:XX:XX:XX:XX)
+
 mac_addr set (for VF)
 ~
 
-- 
2.8.0.rc0

Re: [dpdk-dev] [PATCH v9 09/18] lib: add symbol versioning to distributor

[Hunt, David]

On 10/3/2017 4:22 PM, Bruce Richardson wrote:

On Mon, Mar 06, 2017 at 09:10:24AM +, David Hunt wrote:

Also bumped up the ABI version number in the Makefile

Signed-off-by: David Hunt 
---
  lib/librte_distributor/Makefile|  2 +-
  lib/librte_distributor/rte_distributor.c   | 57 +++---
  lib/librte_distributor/rte_distributor_v1705.h | 89 ++

A file named rte_distributor_v1705.h was added in patch 4, then deleted
in patch 7, and now added again here. Seems a lot of churn.

/Bruce



The first introduction of this file is what will become the public 
header. For successful compilation,
this cannot be called rte_distributor.h until the symbol versioning 
patch, at which stage I will
rename the file, and introduce the symbol versioned header at the same 
time. In the next patch
I'll rename this version of the files as rte_distributor_public.h to 
make this clearer.


Regards,
Dave.

Re: [dpdk-dev] [PATCH v9 09/18] lib: add symbol versioning to distributor

[Van Haaren, Harry]

> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Hunt, David
> Subject: Re: [dpdk-dev] [PATCH v9 09/18] lib: add symbol versioning to 
> distributor
> 
> On 10/3/2017 4:22 PM, Bruce Richardson wrote:
> > On Mon, Mar 06, 2017 at 09:10:24AM +, David Hunt wrote:
> >> Also bumped up the ABI version number in the Makefile
> >>
> >> Signed-off-by: David Hunt 
> >> ---
> >>   lib/librte_distributor/Makefile|  2 +-
> >>   lib/librte_distributor/rte_distributor.c   | 57 +++---
> >>   lib/librte_distributor/rte_distributor_v1705.h | 89 
> >> ++
> > A file named rte_distributor_v1705.h was added in patch 4, then deleted
> > in patch 7, and now added again here. Seems a lot of churn.
> >
> > /Bruce
> >
> 
> The first introduction of this file is what will become the public
> header. For successful compilation,
> this cannot be called rte_distributor.h until the symbol versioning
> patch, at which stage I will
> rename the file, and introduce the symbol versioned header at the same
> time. In the next patch
> I'll rename this version of the files as rte_distributor_public.h to
> make this clearer.


Suggestion to use rte_distributor_next.h instead of public?
Public doesn't indicate if its old or new, while next would make that clearer 
IMO :)

Re: [dpdk-dev] [PATCH v9 09/18] lib: add symbol versioning to distributor

[Hunt, David]

On 13/3/2017 11:01 AM, Van Haaren, Harry wrote:

From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Hunt, David
Subject: Re: [dpdk-dev] [PATCH v9 09/18] lib: add symbol versioning to 
distributor

On 10/3/2017 4:22 PM, Bruce Richardson wrote:

On Mon, Mar 06, 2017 at 09:10:24AM +, David Hunt wrote:

Also bumped up the ABI version number in the Makefile

Signed-off-by: David Hunt 
---
   lib/librte_distributor/Makefile|  2 +-
   lib/librte_distributor/rte_distributor.c   | 57 +++---
   lib/librte_distributor/rte_distributor_v1705.h | 89 
++

A file named rte_distributor_v1705.h was added in patch 4, then deleted
in patch 7, and now added again here. Seems a lot of churn.

/Bruce


The first introduction of this file is what will become the public
header. For successful compilation,
this cannot be called rte_distributor.h until the symbol versioning
patch, at which stage I will
rename the file, and introduce the symbol versioned header at the same
time. In the next patch
I'll rename this version of the files as rte_distributor_public.h to
make this clearer.


Suggestion to use rte_distributor_next.h instead of public?
Public doesn't indicate if its old or new, while next would make that clearer 
IMO :)


Good call, will use "_next". Its clearer.
Thanks,
Dave.

[dpdk-dev] [PATCH] net/vmxnet3: fix broken debug build

[Andrew Rybchenko]

Fixes: 4dd452523000 ("net/vmxnet3: add receive data ring support")

Signed-off-by: Andrew Rybchenko 
---
 drivers/net/vmxnet3/vmxnet3_ethdev.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c 
b/drivers/net/vmxnet3/vmxnet3_ethdev.c
index 01da7e3..ae3efaa 100644
--- a/drivers/net/vmxnet3/vmxnet3_ethdev.c
+++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c
@@ -347,8 +347,8 @@ eth_vmxnet3_dev_init(struct rte_eth_dev *eth_dev)
 
hw->rxdata_desc_size = VMXNET3_VERSION_GE_3(hw) ?
VMXNET3_DEF_RXDATA_DESC_SIZE : 0;
-   RTE_ASSERT((hw->rx_data_desc_size & ~VMXNET3_RXDATA_DESC_SIZE_MASK) ==
-  hw->rx_data_desc_size);
+   RTE_ASSERT((hw->rxdata_desc_size & ~VMXNET3_RXDATA_DESC_SIZE_MASK) ==
+  hw->rxdata_desc_size);
 
return 0;
 }
-- 
2.9.3

Re: [dpdk-dev] [PATCH 04/13] net/sfc: factor out libefx-based Rx datapath

[Andrew Rybchenko]

On 03/05/2017 12:05 AM, Ferruh Yigit wrote:

On 3/2/2017 7:07 AM, Andrew Rybchenko wrote:

Split control and datapath to make datapath substitutable and
possibly reusable with alternative control path.

Does it make sense to document how alternative control path can be used?


Possibility to use alternative control path is just a raw idea right now 
without
real implementation. Yes, the split is done taking the possibility into 
account,
but it is just a design. So, I think right now it is sufficient just 
mention it.



libefx-based Rx datapath is bound to libefx control path, but
other datapaths should be possible to use with alternative
control path(s).

Signed-off-by: Andrew Rybchenko 

<...>

[dpdk-dev] [PATCH v3] devtools: add tags and cscope index file generation support

[Jerin Jacob]

This script generates cscope, gtags, and tags index files based on
EAL environment(architecture and OS(linux/bsd)).

If EAL environment(config) is not specified, the script generates tag
files based on available source code.

Usage: build-tags.sh [-h] [-v] tags|cscope|gtags|etags [config]

example usage:
./devtools/build-tags.sh cscope
./devtools/build-tags.sh tags x86_64-native-linuxapp-gcc
./devtools/build-tags.sh gtags arm64-armv8a-linuxapp-gcc

Signed-off-by: Jerin Jacob 
Reviewed-by: Yuanhan Liu 
Reviewed-by: Ferruh Yigit 
---

v3:
- Added etags target for Emacs(John)
- EAL environment(config) is optional now(Thomas)
- Changed bash shebang to /bin/sh (Thomas)
- getopts based -v and -h option (Thomas)
- used $() instead of backquotes (Thomas)
- Removed "make" based frontend to the script to make it inline with
other devtools scripts in DPDK (Jerin)

v2:
- Moved tag.sh to devtools from scripts
- Rebased to master
---
 .gitignore |   9 ++
 devtools/build-tags.sh | 269 +
 2 files changed, 278 insertions(+)
 create mode 100755 devtools/build-tags.sh

diff --git a/.gitignore b/.gitignore
index a722abe..7eade38 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1 +1,10 @@
 doc/guides/nics/overview_table.txt
+cscope.out.po
+cscope.out.in
+cscope.out
+cscope.files
+GTAGS
+GPATH
+GRTAGS
+tags
+TAGS
diff --git a/devtools/build-tags.sh b/devtools/build-tags.sh
new file mode 100755
index 000..d4a8a98
--- /dev/null
+++ b/devtools/build-tags.sh
@@ -0,0 +1,269 @@
+#!/bin/sh -e
+# Generate tags or gtags or cscope or etags files
+#
+#   BSD LICENSE
+#
+#   Copyright 2017 Cavium Networks
+#
+#   Redistribution and use in source and binary forms, with or without
+#   modification, are permitted provided that the following conditions
+#   are met:
+#
+# * Redistributions of source code must retain the above copyright
+#   notice, this list of conditions and the following disclaimer.
+# * Redistributions in binary form must reproduce the above copyright
+#   notice, this list of conditions and the following disclaimer in
+#   the documentation and/or other materials provided with the
+#   distribution.
+# * Neither the name of Cavium networks nor the names of its
+#   contributors may be used to endorse or promote products derived
+#   from this software without specific prior written permission.
+#
+#   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+#   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+#   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+#   A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+#   OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+#   SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+#   LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+#   DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+#   THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+#   (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+#   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+verbose=false
+linuxapp=false
+bsdapp=false
+x86_64=false
+arm=false
+arm64=false
+ia_32=false
+ppc_64=false
+
+print_usage()
+{
+   echo "Usage: $(basename $0) [-h] [-v] tags|cscope|gtags|etags [config]"
+   echo "Valid configs are:"
+   make showconfigs | sed 's,^,\t,'
+}
+
+while getopts hv ARG ; do
+   case $ARG in
+   v ) verbose=true ;;
+   h ) print_usage; exit 0 ;;
+   ? ) print_usage; exit 1 ;;
+   esac
+done
+shift $(($OPTIND - 1))
+
+#ignore version control files
+ignore="( -name .svn -o -name CVS -o -name .hg -o -name .git ) -prune -o"
+
+source_dirs="app buildtools drivers examples lib"
+
+skip_bsd="( -name bsdapp ) -prune -o"
+skip_linux="( -name linuxapp ) -prune -o"
+skip_arch="( -name arch ) -prune -o"
+skip_sse="( -name *_sse*.[chS] ) -prune -o"
+skip_avx="( -name *_avx*.[chS] ) -prune -o"
+skip_neon="( -name *_neon*.[chS] ) -prune -o"
+skip_altivec="( -name *_altivec*.[chS] ) -prune -o"
+skip_arm64="( -name *arm64*.[chS] ) -prune -o"
+skip_x86="( -name *x86*.[chS] ) -prune -o"
+skip_32b_files="( -name *_32.h ) -prune -o"
+skip_64b_files="( -name *_64.h ) -prune -o"
+
+skiplist="$skip_bsd $skip_linux $skip_arch $skip_sse $skip_avx \
+$skip_neon $skip_altivec $skip_x86 $skip_arm64"
+
+find_sources()
+{
+   find $1 $ignore $3 -name $2 -not -type l -print
+}
+
+common_sources()
+{
+   find_sources "$source_dirs" '*.[chS]' "$skiplist"
+}
+
+linuxapp_sources()
+{
+   find_sources "lib/librte_eal/linuxapp" '*.[chS]'
+}
+
+bsdapp_sources()
+{
+   find_sources "lib/librte_eal/bsdapp" '*.[chS]'
+}
+
+arm_common()
+{
+   find_sources "lib/librte_eal/common/arch/arm" '*.[chS]'
+   find_sources "$source_dirs" '*neon*.[chS]'
+}
+
+arm_sour

Re: [dpdk-dev] i40e SR-IOV with Linux PF

[Thomas Monjalon]

+Cc dev@dpdk.org

2017-03-13 15:29, Thomas Monjalon:
> Hi i40e developers,
> 
> Referring to the VFD discussion, I thought basic behaviours were the
> same regardless of the PF driver:
> http://dpdk.org/ml/archives/dev/2016-December/053056.html
> "
> > In the meanwhile, we have some test models ongoing to validate
> > combination of Linux and DPDK drivers for VF and PF.
> > We'll fully support below 4 cases going forward.
> > 1. DPDK PF + DPDK VF 
> > 2. DPDK PF + Linux VF
> > 3. Linux PF + DPDK VF 
> > 4. Linux PF + Linux VF (it's not our scope)
> [...]
> > Linux PF + DPDK VF has been tested with 1.0 API long time ago.
> > There is some test activities ongoing.
> "
> 
> I think the Linux PF case is important and deserves more consideration.
> When looking at the code, specifically i40evf_vlan_offload_set() and
> i40evf_vlan_pvid_set(), I read this:
> "
> /* Linux pf host doesn't support vlan offload yet */
> if (vf->version_major == I40E_DPDK_VERSION_MAJOR) {
> "
> 
> Is there some work in progress on Linux side to get the same behaviour
> as with a DPDK PF?
> 
> At least, it must be documented in
>   doc/guides/nics/features/i40e_vf.ini
> and marked as partially supported (P instead of Y) in
>   doc/guides/nics/i40e.rst

Re: [dpdk-dev] [PATCH] net/vmxnet3: fix broken debug build

[Shrikrishna Khare]

On Mon, 13 Mar 2017, Andrew Rybchenko wrote:

> Fixes: 4dd452523000 ("net/vmxnet3: add receive data ring support")
> 
> Signed-off-by: Andrew Rybchenko 

Thank you for catching and fixing this.

Acked-by: Shrikrishna Khare 

> ---
>  drivers/net/vmxnet3/vmxnet3_ethdev.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c 
> b/drivers/net/vmxnet3/vmxnet3_ethdev.c
> index 01da7e3..ae3efaa 100644
> --- a/drivers/net/vmxnet3/vmxnet3_ethdev.c
> +++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c
> @@ -347,8 +347,8 @@ eth_vmxnet3_dev_init(struct rte_eth_dev *eth_dev)
>  
>   hw->rxdata_desc_size = VMXNET3_VERSION_GE_3(hw) ?
>   VMXNET3_DEF_RXDATA_DESC_SIZE : 0;
> - RTE_ASSERT((hw->rx_data_desc_size & ~VMXNET3_RXDATA_DESC_SIZE_MASK) ==
> -hw->rx_data_desc_size);
> + RTE_ASSERT((hw->rxdata_desc_size & ~VMXNET3_RXDATA_DESC_SIZE_MASK) ==
> +hw->rxdata_desc_size);
>  
>   return 0;
>  }
> -- 
> 2.9.3
> 
> 

Re: [dpdk-dev] [PATCH v4 02/10] eal: probe new virtual bus after other bus devices

[Thomas Monjalon]

2017-03-06 11:56, Jan Blunck:
> @@ -86,9 +86,14 @@ int
>  rte_bus_probe(void)
>  {
>   int ret;
> - struct rte_bus *bus;
> + struct rte_bus *bus, *vbus = NULL;
>  
>   TAILQ_FOREACH(bus, &rte_bus_list, next) {
> + if (!strcmp(bus->name, "virtual")) {
> + vbus = bus;
> + continue;
> + }

Why this special handling?

[...]
> + if (vbus) {
> + ret = vbus->probe();
> + if (ret) {
> + RTE_LOG(ERR, EAL, "Bus (%s) probe failed.\n",
> + vbus->name);
> + return ret;
> + }
> + }

We should not have any special code in this function.

Re: [dpdk-dev] [PATCH v4 03/10] eal: move virtual device probing into a bus

[Thomas Monjalon]

2017-03-06 11:56, Jan Blunck:
> +static int
> +vdev_scan(void)
> +{
> + /* for virtual devices we don't need to scan anything */
> + return 0;
> +}

The vdev_scan could save the devargs.
The vdev args are the equivalent of PCI BDF.

Re: [dpdk-dev] [PATCH v4 09/10] eal: make virtual bus use rte_vdev_device

[Thomas Monjalon]

2017-03-06 11:56, Jan Blunck:
> This allows the virtual bus to be rescanned and probed by tracking the
> creation of rte_vdev_device.
> 
> Signed-off-by: Jan Blunck 
> Tested-by: Ferruh Yigit 
> Acked-by: Shreyansh Jain 

There are a lot of strcmp in this patch.
Maybe it should be abstracted in a "match" function.
It would allow bringing new vdev rules in future.

Re: [dpdk-dev] [PATCH v4 00/10] Rework vdev probing to use rte_bus infrastructure

[Thomas Monjalon]

2017-03-06 11:56, Jan Blunck:
> Jan Blunck (10):
>   eal: probe legacy PCI devices before other bus devices
>   eal: probe new virtual bus after other bus devices
>   eal: move virtual device probing into a bus
>   eal: remove unused rte_eal_dev_init()
>   eal: Refactor vdev driver probe/remove
>   eal: add struct rte_vdev_device
>   eal: add virtual device name helper function
>   eal: add virtual device arguments helper function
>   eal: make virtual bus use rte_vdev_device
>   eal: make virtual driver probe and remove take rte_vdev_device
> 
>  drivers/crypto/null/null_crypto_pmd.c   |  18 +-
>  drivers/net/af_packet/rte_eth_af_packet.c   |  11 +-
>  drivers/net/bonding/rte_eth_bond_pmd.c  |  13 +-
>  drivers/net/mpipe/mpipe_tilegx.c|  10 +-
>  drivers/net/null/rte_eth_null.c |  13 +-
>  drivers/net/pcap/rte_eth_pcap.c |  12 +-
>  drivers/net/ring/rte_eth_ring.c |   9 +-
>  drivers/net/tap/rte_eth_tap.c   |  10 +-
>  drivers/net/vhost/rte_eth_vhost.c   |  10 +-
>  drivers/net/virtio/virtio_user_ethdev.c |  18 +-
>  drivers/net/xenvirt/rte_eth_xenvirt.c   |   9 +-
>  lib/librte_eal/bsdapp/eal/eal.c |   9 +-
>  lib/librte_eal/bsdapp/eal/rte_eal_version.map   |   1 -
>  lib/librte_eal/common/eal_common_bus.c  |  16 +-
>  lib/librte_eal/common/eal_common_dev.c  |  28 ---
>  lib/librte_eal/common/eal_common_vdev.c | 245 
> +---
>  lib/librte_eal/common/include/rte_dev.h |   5 -
>  lib/librte_eal/common/include/rte_vdev.h|  26 ++-
>  lib/librte_eal/linuxapp/eal/eal.c   |   9 +-
>  lib/librte_eal/linuxapp/eal/rte_eal_version.map |   1 -
>  20 files changed, 341 insertions(+), 132 deletions(-)

When it will be merged, it would be nice to move the vdev bus files
to drivers/bus/vdev/.

[dpdk-dev] [PATCH v4 00/17] Wind River Systems AVP PMD

[Allain Legacy]

This patch series submits an initial version of the AVP PMD from Wind River
Systems.  The series includes shared header files, driver implementation,
and changes to documentation files in support of this new driver.  The AVP
driver is a shared memory based device.  It is intended to be used as a PMD
within a virtual machine running on a Wind River virtualization platform.
See: http://www.windriver.com/products/titanium-cloud/

It enables optimized packet throughput without requiring any packet
processing in qemu. This allowed us to provide our customers with a
significant performance increase for both DPDK and non-DPDK applications
in the VM.   Since our AVP implementation supports VM live-migration it
is viewed as a better alternative to PCI passthrough or PCI SRIOV since
neither of those support VM live-migration without manual intervention
or significant performance penalties.

Since the initial implementation of AVP devices, vhost-user has become part
of the qemu offering with a significant performance increase over the
original virtio implementation.  However, vhost-user still does not achieve
the level of performance that the AVP device can provide to our customers
for DPDK based guests.

A number of our customers have requested that we upstream the driver to
dpdk.org.

v2:
* Fixed coding style violations that slipped in accidentally because of an
  out of date checkpatch.pl from an older kernel.

v3:
* Updated 17.05 release notes to add a section for this new PMD
* Added additional info to the AVP nic guide document to clarify the
  benefit of using AVP over virtio.
* Fixed spelling error in debug log missed by local checkpatch.pl version
* Split the transmit patch to separate the stats functions as they
  accidentally got squashed in the last patchset.
* Fixed debug log strings so that they exceed 80 characters rather than
  span multiple lines.
* Renamed RTE_AVP_* defines that were in avp_ethdev.h to be AVP_* instead
* Replaced usage of RTE_WRITE32 and RTE_READ32 with rte_write32_relaxed
  and rte_read32_relaxed.
* Declared rte_pci_id table as const

v4:
* Split our interrupt handlers to a separate patch and moved to the end
  of the series.
* Removed memset() from stats_get API
* Removed usage of RTE_AVP_ALIGNMENT
* Removed unnecessary parentheses in rte_avp_common.h
* Removed unneeded "goto unlock" where there are no statements in between
  the goto and the end of the function.
* Re-tested with pktgen and found that rte_eth_tx_burst() is being called
  with 0 packets even before starting traffic which resulted in
  incrementing oerrors; fixed in transmit patch.

Allain Legacy (17):
  config: added attributes for the AVP PMD
  net/avp: added public header files
  maintainers: claim responsibility for AVP PMD
  net/avp: added PMD version map file
  net/avp: added log macros
  drivers/net: added driver makefiles
  net/avp: driver registration
  net/avp: device initialization
  net/avp: device configuration
  net/avp: queue setup and release
  net/avp: packet receive functions
  net/avp: packet transmit functions
  net/avp: device statistics operations
  net/avp: device promiscuous functions
  net/avp: device start and stop operations
  net/avp: migration interrupt handling
  doc: added information related to the AVP PMD

 MAINTAINERS |6 +
 config/common_base  |   10 +
 config/common_linuxapp  |1 +
 doc/guides/nics/avp.rst |   99 ++
 doc/guides/nics/features/avp.ini|   17 +
 doc/guides/nics/index.rst   |1 +
 drivers/net/Makefile|1 +
 drivers/net/avp/Makefile|   61 +
 drivers/net/avp/avp_ethdev.c| 2371 +++
 drivers/net/avp/avp_logs.h  |   59 +
 drivers/net/avp/rte_avp_common.h|  427 ++
 drivers/net/avp/rte_avp_fifo.h  |  157 ++
 drivers/net/avp/rte_pmd_avp_version.map |4 +
 mk/rte.app.mk   |1 +
 14 files changed, 3215 insertions(+)
 create mode 100644 doc/guides/nics/avp.rst
 create mode 100644 doc/guides/nics/features/avp.ini
 create mode 100644 drivers/net/avp/Makefile
 create mode 100644 drivers/net/avp/avp_ethdev.c
 create mode 100644 drivers/net/avp/avp_logs.h
 create mode 100644 drivers/net/avp/rte_avp_common.h
 create mode 100644 drivers/net/avp/rte_avp_fifo.h
 create mode 100644 drivers/net/avp/rte_pmd_avp_version.map

-- 
1.8.3.1

[dpdk-dev] [PATCH v4 03/17] maintainers: claim responsibility for AVP PMD

[Allain Legacy]

Updating the maintainers file to claim the AVP PMD driver on behalf of Wind
River Systems, Inc.

Signed-off-by: Allain Legacy 
Signed-off-by: Matt Peters 
---
 MAINTAINERS | 5 +
 1 file changed, 5 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 5030c1c..fef23a0 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -423,6 +423,11 @@ Null Networking PMD
 M: Tetsuya Mukawa 
 F: drivers/net/null/
 
+Wind River AVP PMD
+M: Allain Legacy 
+M: Matt Peters 
+F: drivers/net/avp
+
 
 Crypto Drivers
 --
-- 
1.8.3.1

[dpdk-dev] [PATCH v4 02/17] net/avp: public header files

[Allain Legacy]

Adds public/exported header files for the AVP PMD.  The AVP device is a
shared memory based device.  The structures and constants that define the
method of operation of the device must be visible by both the PMD and the
host DPDK application.  They must not change without proper version
controls and updates to both the hypervisor DPDK application and the PMD.

The hypervisor DPDK application is a Wind River Systems proprietary
virtual switch.

Signed-off-by: Allain Legacy 
Signed-off-by: Matt Peters 
---
 drivers/net/avp/rte_avp_common.h | 416 +++
 drivers/net/avp/rte_avp_fifo.h   | 157 +++
 2 files changed, 573 insertions(+)
 create mode 100644 drivers/net/avp/rte_avp_common.h
 create mode 100644 drivers/net/avp/rte_avp_fifo.h

diff --git a/drivers/net/avp/rte_avp_common.h b/drivers/net/avp/rte_avp_common.h
new file mode 100644
index 000..3c12252
--- /dev/null
+++ b/drivers/net/avp/rte_avp_common.h
@@ -0,0 +1,416 @@
+/*-
+ *   This file is provided under a dual BSD/LGPLv2 license.  When using or
+ *   redistributing this file, you may do so under either license.
+ *
+ *   GNU LESSER GENERAL PUBLIC LICENSE
+ *
+ *   Copyright(c) 2010-2013 Intel Corporation. All rights reserved.
+ *   Copyright(c) 2014-2015 Wind River Systems, Inc. All rights reserved.
+ *
+ *   This program is free software; you can redistribute it and/or modify
+ *   it under the terms of version 2.1 of the GNU Lesser General Public License
+ *   as published by the Free Software Foundation.
+ *
+ *   This program is distributed in the hope that it will be useful, but
+ *   WITHOUT ANY WARRANTY; without even the implied warranty of
+ *   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ *   Lesser General Public License for more details.
+ *
+ *   Contact Information:
+ *   Wind River Systems, Inc.
+ *
+ *
+ *   BSD LICENSE
+ *
+ *   Copyright(c) 2010-2013 Intel Corporation. All rights reserved.
+ *   Copyright(c) 2014-2016 Wind River Systems, Inc. All rights reserved.
+ *   All rights reserved.
+ *
+ *   Redistribution and use in source and binary forms, with or without
+ *   modification, are permitted provided that the following conditions
+ *   are met:
+ *
+ *   * Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ *   * Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in
+ * the documentation and/or other materials provided with the
+ * distribution.
+ *   * Neither the name of Intel Corporation nor the names of its
+ * contributors may be used to endorse or promote products derived
+ * from this software without specific prior written permission.
+ *
+ *THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ *"AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ *LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ *A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ *OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ *SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ *LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ *DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ *THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ *(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ *OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ *
+ */
+
+#ifndef _RTE_AVP_COMMON_H_
+#define _RTE_AVP_COMMON_H_
+
+#ifdef __KERNEL__
+#include 
+#endif
+
+/**
+ * AVP name is part of network device name.
+ */
+#define RTE_AVP_NAMESIZE 32
+
+/**
+ * AVP alias is a user-defined value used for lookups from secondary
+ * processes.  Typically, this is a UUID.
+ */
+#define RTE_AVP_ALIASSIZE 128
+
+/*
+ * Request id.
+ */
+enum rte_avp_req_id {
+   RTE_AVP_REQ_UNKNOWN = 0,
+   RTE_AVP_REQ_CHANGE_MTU,
+   RTE_AVP_REQ_CFG_NETWORK_IF,
+   RTE_AVP_REQ_CFG_DEVICE,
+   RTE_AVP_REQ_SHUTDOWN_DEVICE,
+   RTE_AVP_REQ_MAX,
+};
+
+/**@{ AVP device driver types */
+#define RTE_AVP_DRIVER_TYPE_UNKNOWN 0
+#define RTE_AVP_DRIVER_TYPE_DPDK 1
+#define RTE_AVP_DRIVER_TYPE_KERNEL 2
+#define RTE_AVP_DRIVER_TYPE_QEMU 3
+/**@} */
+
+/**@{ AVP device operational modes */
+#define RTE_AVP_MODE_HOST 0 /**< AVP interface created in host */
+#define RTE_AVP_MODE_GUEST 1 /**< AVP interface created for export to guest */
+#define RTE_AVP_MODE_TRACE 2 /**< AVP interface created for packet tracing */
+/**@} */
+
+/*
+ * Structure for AVP queue configuration query request/result
+ */
+struct rte_avp_device_config {
+   uint64_t device_id; /**< Unique system identifier */
+   uint32_t driver_type; /**< Device Driver type */
+   uint32_t driver_version; /**< Devic

[dpdk-dev] [PATCH v4 01/17] config: adds attributes for the AVP PMD

[Allain Legacy]

Updates the common base configuration file to include a top level config
attribute for the AVP PMD.

Signed-off-by: Allain Legacy 
Signed-off-by: Matt Peters 
---
 config/common_base | 5 +
 1 file changed, 5 insertions(+)

diff --git a/config/common_base b/config/common_base
index aeee13e..912bc68 100644
--- a/config/common_base
+++ b/config/common_base
@@ -348,6 +348,11 @@ CONFIG_RTE_LIBRTE_QEDE_FW=""
 CONFIG_RTE_LIBRTE_PMD_AF_PACKET=n
 
 #
+# Compile WRS accelerated virtual port (AVP) guest PMD driver
+#
+CONFIG_RTE_LIBRTE_AVP_PMD=n
+
+#
 # Compile the TAP PMD
 # It is enabled by default for Linux only.
 #
-- 
1.8.3.1

[dpdk-dev] [PATCH v4 05/17] net/avp: debug log macros

[Allain Legacy]

Adds a header file with log macros for the AVP PMD

Signed-off-by: Allain Legacy 
Signed-off-by: Matt Peters 
---
 config/common_base |  4 
 drivers/net/avp/avp_logs.h | 59 ++
 2 files changed, 63 insertions(+)
 create mode 100644 drivers/net/avp/avp_logs.h

diff --git a/config/common_base b/config/common_base
index 912bc68..fe8363d 100644
--- a/config/common_base
+++ b/config/common_base
@@ -351,6 +351,10 @@ CONFIG_RTE_LIBRTE_PMD_AF_PACKET=n
 # Compile WRS accelerated virtual port (AVP) guest PMD driver
 #
 CONFIG_RTE_LIBRTE_AVP_PMD=n
+CONFIG_RTE_LIBRTE_AVP_DEBUG_RX=n
+CONFIG_RTE_LIBRTE_AVP_DEBUG_TX=n
+CONFIG_RTE_LIBRTE_AVP_DEBUG_DRIVER=y
+CONFIG_RTE_LIBRTE_AVP_DEBUG_BUFFERS=n
 
 #
 # Compile the TAP PMD
diff --git a/drivers/net/avp/avp_logs.h b/drivers/net/avp/avp_logs.h
new file mode 100644
index 000..252cab7
--- /dev/null
+++ b/drivers/net/avp/avp_logs.h
@@ -0,0 +1,59 @@
+/*
+ * BSD LICENSE
+ *
+ * Copyright (c) 2013-2015, Wind River Systems, Inc.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are met:
+ *
+ * 1) Redistributions of source code must retain the above copyright notice,
+ * this list of conditions and the following disclaimer.
+ *
+ * 2) Redistributions in binary form must reproduce the above copyright notice,
+ * this list of conditions and the following disclaimer in the documentation
+ * and/or other materials provided with the distribution.
+ *
+ * 3) Neither the name of Wind River Systems nor the names of its contributors
+ * may be used to endorse or promote products derived from this software
+ * without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
+ * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE
+ * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+ * POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#ifndef _AVP_LOGS_H_
+#define _AVP_LOGS_H_
+
+#include 
+
+#ifdef RTE_LIBRTE_AVP_DEBUG_RX
+#define PMD_RX_LOG(level, fmt, args...) \
+   RTE_LOG(level, PMD, "%s() rx: " fmt, __func__, ## args)
+#else
+#define PMD_RX_LOG(level, fmt, args...) do { } while (0)
+#endif
+
+#ifdef RTE_LIBRTE_AVP_DEBUG_TX
+#define PMD_TX_LOG(level, fmt, args...) \
+   RTE_LOG(level, PMD, "%s() tx: " fmt, __func__, ## args)
+#else
+#define PMD_TX_LOG(level, fmt, args...) do { } while (0)
+#endif
+
+#ifdef RTE_LIBRTE_AVP_DEBUG_DRIVER
+#define PMD_DRV_LOG(level, fmt, args...) \
+   RTE_LOG(level, PMD, "%s(): " fmt, __func__, ## args)
+#else
+#define PMD_DRV_LOG(level, fmt, args...) do { } while (0)
+#endif
+
+#endif /* _AVP_LOGS_H_ */
-- 
1.8.3.1

[dpdk-dev] [PATCH v4 04/17] net/avp: add PMD version map file

[Allain Legacy]

Adds a default ABI version file for the AVP PMD.

Signed-off-by: Allain Legacy 
Signed-off-by: Matt Peters 
---
 drivers/net/avp/rte_pmd_avp_version.map | 4 
 1 file changed, 4 insertions(+)
 create mode 100644 drivers/net/avp/rte_pmd_avp_version.map

diff --git a/drivers/net/avp/rte_pmd_avp_version.map 
b/drivers/net/avp/rte_pmd_avp_version.map
new file mode 100644
index 000..af8f3f4
--- /dev/null
+++ b/drivers/net/avp/rte_pmd_avp_version.map
@@ -0,0 +1,4 @@
+DPDK_17.05 {
+
+local: *;
+};
-- 
1.8.3.1

[dpdk-dev] [PATCH v4 06/17] drivers/net: adds driver makefiles for AVP PMD

[Allain Legacy]

Adds a default Makefile to the driver directory but does not include any
source files.

Signed-off-by: Allain Legacy 
Signed-off-by: Matt Peters 
---
 drivers/net/Makefile |  1 +
 drivers/net/avp/Makefile | 52 
 2 files changed, 53 insertions(+)
 create mode 100644 drivers/net/avp/Makefile

diff --git a/drivers/net/Makefile b/drivers/net/Makefile
index 40fc333..592383e 100644
--- a/drivers/net/Makefile
+++ b/drivers/net/Makefile
@@ -32,6 +32,7 @@
 include $(RTE_SDK)/mk/rte.vars.mk
 
 DIRS-$(CONFIG_RTE_LIBRTE_PMD_AF_PACKET) += af_packet
+DIRS-$(CONFIG_RTE_LIBRTE_AVP_PMD) += avp
 DIRS-$(CONFIG_RTE_LIBRTE_BNX2X_PMD) += bnx2x
 DIRS-$(CONFIG_RTE_LIBRTE_PMD_BOND) += bonding
 DIRS-$(CONFIG_RTE_LIBRTE_CXGBE_PMD) += cxgbe
diff --git a/drivers/net/avp/Makefile b/drivers/net/avp/Makefile
new file mode 100644
index 000..68a0fa5
--- /dev/null
+++ b/drivers/net/avp/Makefile
@@ -0,0 +1,52 @@
+#   BSD LICENSE
+#
+#   Copyright(c) 2013-2017, Wind River Systems, Inc. All rights reserved.
+#   All rights reserved.
+#
+#   Redistribution and use in source and binary forms, with or without
+#   modification, are permitted provided that the following conditions
+#   are met:
+#
+# * Redistributions of source code must retain the above copyright
+#   notice, this list of conditions and the following disclaimer.
+# * Redistributions in binary form must reproduce the above copyright
+#   notice, this list of conditions and the following disclaimer in
+#   the documentation and/or other materials provided with the
+#   distribution.
+# * Neither the name of Wind River Systems nor the names of its
+#   contributors may be used to endorse or promote products derived
+#   from this software without specific prior written permission.
+#
+#   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+#   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+#   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+#   A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+#   OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+#   SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+#   LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+#   DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+#   THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+#   (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+#   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+
+include $(RTE_SDK)/mk/rte.vars.mk
+
+#
+# library name
+#
+LIB = librte_pmd_avp.a
+
+CFLAGS += -O3
+CFLAGS += $(WERROR_FLAGS) -I$(SRCDIR)
+
+EXPORT_MAP := rte_pmd_avp_version.map
+
+LIBABIVER := 1
+
+# install public header files to enable compilation of the hypervisor level
+# dpdk application
+SYMLINK-$(CONFIG_RTE_LIBRTE_AVP_PMD)-include += rte_avp_common.h
+SYMLINK-$(CONFIG_RTE_LIBRTE_AVP_PMD)-include += rte_avp_fifo.h
+
+include $(RTE_SDK)/mk/rte.lib.mk
-- 
1.8.3.1

[dpdk-dev] [PATCH v4 07/17] net/avp: driver registration

[Allain Legacy]

Adds the initial framework for registering the driver against the support
PCI device identifiers.

Signed-off-by: Allain Legacy 
Signed-off-by: Matt Peters 
---
 config/common_linuxapp   |   1 +
 config/defconfig_i686-native-linuxapp-gcc|   5 +
 config/defconfig_i686-native-linuxapp-icc|   5 +
 config/defconfig_x86_x32-native-linuxapp-gcc |   5 +
 drivers/net/avp/Makefile |   8 +
 drivers/net/avp/avp_ethdev.c | 227 +++
 mk/rte.app.mk|   1 +
 7 files changed, 252 insertions(+)
 create mode 100644 drivers/net/avp/avp_ethdev.c

diff --git a/config/common_linuxapp b/config/common_linuxapp
index 00ebaac..8690a00 100644
--- a/config/common_linuxapp
+++ b/config/common_linuxapp
@@ -43,6 +43,7 @@ CONFIG_RTE_LIBRTE_VHOST=y
 CONFIG_RTE_LIBRTE_PMD_VHOST=y
 CONFIG_RTE_LIBRTE_PMD_AF_PACKET=y
 CONFIG_RTE_LIBRTE_PMD_TAP=y
+CONFIG_RTE_LIBRTE_AVP_PMD=y
 CONFIG_RTE_LIBRTE_NFP_PMD=y
 CONFIG_RTE_LIBRTE_POWER=y
 CONFIG_RTE_VIRTIO_USER=y
diff --git a/config/defconfig_i686-native-linuxapp-gcc 
b/config/defconfig_i686-native-linuxapp-gcc
index 745c401..9847bdb 100644
--- a/config/defconfig_i686-native-linuxapp-gcc
+++ b/config/defconfig_i686-native-linuxapp-gcc
@@ -75,3 +75,8 @@ CONFIG_RTE_LIBRTE_PMD_KASUMI=n
 # ZUC PMD is not supported on 32-bit
 #
 CONFIG_RTE_LIBRTE_PMD_ZUC=n
+
+#
+# AVP PMD is not supported on 32-bit
+#
+CONFIG_RTE_LIBRTE_AVP_PMD=n
diff --git a/config/defconfig_i686-native-linuxapp-icc 
b/config/defconfig_i686-native-linuxapp-icc
index 50a3008..269e88e 100644
--- a/config/defconfig_i686-native-linuxapp-icc
+++ b/config/defconfig_i686-native-linuxapp-icc
@@ -75,3 +75,8 @@ CONFIG_RTE_LIBRTE_PMD_KASUMI=n
 # ZUC PMD is not supported on 32-bit
 #
 CONFIG_RTE_LIBRTE_PMD_ZUC=n
+
+#
+# AVP PMD is not supported on 32-bit
+#
+CONFIG_RTE_LIBRTE_AVP_PMD=n
diff --git a/config/defconfig_x86_x32-native-linuxapp-gcc 
b/config/defconfig_x86_x32-native-linuxapp-gcc
index 3e55c5c..19573cb 100644
--- a/config/defconfig_x86_x32-native-linuxapp-gcc
+++ b/config/defconfig_x86_x32-native-linuxapp-gcc
@@ -50,3 +50,8 @@ CONFIG_RTE_LIBRTE_KNI=n
 # Solarflare PMD is not supported on 32-bit
 #
 CONFIG_RTE_LIBRTE_SFC_EFX_PMD=n
+
+#
+# AVP PMD is not supported on 32-bit
+#
+CONFIG_RTE_LIBRTE_AVP_PMD=n
diff --git a/drivers/net/avp/Makefile b/drivers/net/avp/Makefile
index 68a0fa5..9cf0449 100644
--- a/drivers/net/avp/Makefile
+++ b/drivers/net/avp/Makefile
@@ -49,4 +49,12 @@ LIBABIVER := 1
 SYMLINK-$(CONFIG_RTE_LIBRTE_AVP_PMD)-include += rte_avp_common.h
 SYMLINK-$(CONFIG_RTE_LIBRTE_AVP_PMD)-include += rte_avp_fifo.h
 
+#
+# all source files are stored in SRCS-y
+#
+SRCS-$(CONFIG_RTE_LIBRTE_AVP_PMD) += avp_ethdev.c
+
+# this lib depends upon:
+DEPDIRS-$(CONFIG_RTE_LIBRTE_AVP_PMD) += lib/librte_eal lib/librte_ether
+
 include $(RTE_SDK)/mk/rte.lib.mk
diff --git a/drivers/net/avp/avp_ethdev.c b/drivers/net/avp/avp_ethdev.c
new file mode 100644
index 000..ab710ea
--- /dev/null
+++ b/drivers/net/avp/avp_ethdev.c
@@ -0,0 +1,227 @@
+/*
+ *   BSD LICENSE
+ *
+ * Copyright (c) 2013-2016, Wind River Systems, Inc.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are met:
+ *
+ * 1) Redistributions of source code must retain the above copyright notice,
+ * this list of conditions and the following disclaimer.
+ *
+ * 2) Redistributions in binary form must reproduce the above copyright notice,
+ * this list of conditions and the following disclaimer in the documentation
+ * and/or other materials provided with the distribution.
+ *
+ * 3) Neither the name of Wind River Systems nor the names of its contributors
+ * may be used to endorse or promote products derived from this software
+ * without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
+ * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE
+ * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+ * POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+
+#include "rte_avp_common.h"
+#include "rte_avp_fifo.h"
+
+#include "avp_logs.h"
+

[dpdk-dev] [PATCH v4 08/17] net/avp: device initialization

[Allain Legacy]

Adds support for initialization newly probed AVP PCI devices.  Initial
queue translations are setup in preparation for device configuration.

Signed-off-by: Allain Legacy 
Signed-off-by: Matt Peters 
---
 drivers/net/avp/avp_ethdev.c | 299 +++
 1 file changed, 299 insertions(+)

diff --git a/drivers/net/avp/avp_ethdev.c b/drivers/net/avp/avp_ethdev.c
index ab710ea..a7d270f 100644
--- a/drivers/net/avp/avp_ethdev.c
+++ b/drivers/net/avp/avp_ethdev.c
@@ -52,6 +52,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include "rte_avp_common.h"
 #include "rte_avp_fifo.h"
@@ -59,6 +60,8 @@
 #include "avp_logs.h"
 
 
+static int avp_dev_create(struct rte_pci_device *pci_dev,
+ struct rte_eth_dev *eth_dev);
 
 static int eth_avp_dev_init(struct rte_eth_dev *eth_dev);
 static int eth_avp_dev_uninit(struct rte_eth_dev *eth_dev);
@@ -102,6 +105,15 @@
 };
 
 
+/**@{ AVP device flags */
+#define AVP_F_PROMISC (1 << 1)
+#define AVP_F_CONFIGURED (1 << 2)
+#define AVP_F_LINKUP (1 << 3)
+/**@} */
+
+/* Ethernet device validation marker */
+#define AVP_ETHDEV_MAGIC 0x92972862
+
 /*
  * Defines the AVP device attributes which are attached to an RTE ethernet
  * device
@@ -146,11 +158,282 @@ struct avp_adapter {
struct avp_dev avp;
 } __rte_cache_aligned;
 
+
+/* 32-bit MMIO register write */
+#define AVP_WRITE32(_value, _addr) rte_write32_relaxed((_value), (_addr))
+
+/* 32-bit MMIO register read */
+#define AVP_READ32(_addr) rte_read32_relaxed((_addr))
+
 /* Macro to cast the ethernet device private data to a AVP object */
 #define AVP_DEV_PRIVATE_TO_HW(adapter) \
(&((struct avp_adapter *)adapter)->avp)
 
 /*
+ * Defines the structure of a AVP device queue for the purpose of handling the
+ * receive and transmit burst callback functions
+ */
+struct avp_queue {
+   struct rte_eth_dev_data *dev_data;
+   /**< Backpointer to ethernet device data */
+   struct avp_dev *avp; /**< Backpointer to AVP device */
+   uint16_t queue_id;
+   /**< Queue identifier used for indexing current queue */
+   uint16_t queue_base;
+   /**< Base queue identifier for queue servicing */
+   uint16_t queue_limit;
+   /**< Maximum queue identifier for queue servicing */
+
+   uint64_t packets;
+   uint64_t bytes;
+   uint64_t errors;
+};
+
+/* translate from host physical address to guest virtual address */
+static void *
+avp_dev_translate_address(struct rte_eth_dev *eth_dev,
+ phys_addr_t host_phys_addr)
+{
+   struct rte_pci_device *pci_dev = AVP_DEV_TO_PCI(eth_dev);
+   struct rte_mem_resource *resource;
+   struct rte_avp_memmap_info *info;
+   struct rte_avp_memmap *map;
+   off_t offset;
+   void *addr;
+   unsigned int i;
+
+   addr = pci_dev->mem_resource[RTE_AVP_PCI_MEMORY_BAR].addr;
+   resource = &pci_dev->mem_resource[RTE_AVP_PCI_MEMMAP_BAR];
+   info = (struct rte_avp_memmap_info *)resource->addr;
+
+   offset = 0;
+   for (i = 0; i < info->nb_maps; i++) {
+   /* search all segments looking for a matching address */
+   map = &info->maps[i];
+
+   if ((host_phys_addr >= map->phys_addr) &&
+   (host_phys_addr < (map->phys_addr + map->length))) {
+   /* address is within this segment */
+   offset += (host_phys_addr - map->phys_addr);
+   addr = RTE_PTR_ADD(addr, offset);
+
+   PMD_DRV_LOG(DEBUG, "Translating host physical 0x%" 
PRIx64 " to guest virtual 0x%p\n",
+   host_phys_addr, addr);
+
+   return addr;
+   }
+   offset += map->length;
+   }
+
+   return NULL;
+}
+
+/* verify that the incoming device version is compatible with our version */
+static int
+avp_dev_version_check(uint32_t version)
+{
+   uint32_t driver = RTE_AVP_STRIP_MINOR_VERSION(AVP_DPDK_DRIVER_VERSION);
+   uint32_t device = RTE_AVP_STRIP_MINOR_VERSION(version);
+
+   if (device <= driver) {
+   /* the host driver version is less than or equal to ours */
+   return 0;
+   }
+
+   return 1;
+}
+
+/* verify that memory regions have expected version and validation markers */
+static int
+avp_dev_check_regions(struct rte_eth_dev *eth_dev)
+{
+   struct rte_pci_device *pci_dev = AVP_DEV_TO_PCI(eth_dev);
+   struct rte_avp_memmap_info *memmap;
+   struct rte_avp_device_info *info;
+   struct rte_mem_resource *resource;
+   unsigned int i;
+
+   /* Dump resource info for debug */
+   for (i = 0; i < PCI_MAX_RESOURCE; i++) {
+   resource = &pci_dev->mem_resource[i];
+   if ((resource->phys_addr == 0) || (resource->len == 0))
+   continue;
+
+   PMD_DRV_LOG(DEBUG, "resource[%u]: phys=0x%" PRIx64 " len=%" 
PRIu64 " addr=%p\n",
+

[dpdk-dev] [PATCH v4 09/17] net/avp: device configuration

[Allain Legacy]

Adds support for "dev_configure" operations to allow an application to
configure the device.

Signed-off-by: Allain Legacy 
Signed-off-by: Matt Peters 
---
 drivers/net/avp/avp_ethdev.c | 240 +++
 1 file changed, 240 insertions(+)

diff --git a/drivers/net/avp/avp_ethdev.c b/drivers/net/avp/avp_ethdev.c
index a7d270f..bb6ccdf 100644
--- a/drivers/net/avp/avp_ethdev.c
+++ b/drivers/net/avp/avp_ethdev.c
@@ -66,6 +66,12 @@ static int avp_dev_create(struct rte_pci_device *pci_dev,
 static int eth_avp_dev_init(struct rte_eth_dev *eth_dev);
 static int eth_avp_dev_uninit(struct rte_eth_dev *eth_dev);
 
+static int avp_dev_configure(struct rte_eth_dev *dev);
+static void avp_dev_info_get(struct rte_eth_dev *dev,
+struct rte_eth_dev_info *dev_info);
+static void avp_vlan_offload_set(struct rte_eth_dev *dev, int mask);
+static int avp_dev_link_update(struct rte_eth_dev *dev,
+  __rte_unused int wait_to_complete);
 
 #define AVP_DEV_TO_PCI(eth_dev) RTE_DEV_TO_PCI((eth_dev)->device)
 
@@ -104,6 +110,15 @@ static int avp_dev_create(struct rte_pci_device *pci_dev,
},
 };
 
+/*
+ * dev_ops for avp, bare necessities for basic operation
+ */
+static const struct eth_dev_ops avp_eth_dev_ops = {
+   .dev_configure   = avp_dev_configure,
+   .dev_infos_get   = avp_dev_info_get,
+   .vlan_offload_set= avp_vlan_offload_set,
+   .link_update = avp_dev_link_update,
+};
 
 /**@{ AVP device flags */
 #define AVP_F_PROMISC (1 << 1)
@@ -189,6 +204,91 @@ struct avp_queue {
uint64_t errors;
 };
 
+/* send a request and wait for a response
+ *
+ * @warning must be called while holding the avp->lock spinlock.
+ */
+static int
+avp_dev_process_request(struct avp_dev *avp, struct rte_avp_request *request)
+{
+   unsigned int retry = AVP_MAX_REQUEST_RETRY;
+   void *resp_addr = NULL;
+   unsigned int count;
+   int ret;
+
+   PMD_DRV_LOG(DEBUG, "Sending request %u to host\n", request->req_id);
+
+   request->result = -ENOTSUP;
+
+   /* Discard any stale responses before starting a new request */
+   while (avp_fifo_get(avp->resp_q, (void **)&resp_addr, 1))
+   PMD_DRV_LOG(DEBUG, "Discarding stale response\n");
+
+   rte_memcpy(avp->sync_addr, request, sizeof(*request));
+   count = avp_fifo_put(avp->req_q, &avp->host_sync_addr, 1);
+   if (count < 1) {
+   PMD_DRV_LOG(ERR, "Cannot send request %u to host\n",
+   request->req_id);
+   ret = -EBUSY;
+   goto done;
+   }
+
+   while (retry--) {
+   /* wait for a response */
+   usleep(AVP_REQUEST_DELAY_USECS);
+
+   count = avp_fifo_count(avp->resp_q);
+   if (count >= 1) {
+   /* response received */
+   break;
+   }
+
+   if ((count < 1) && (retry == 0)) {
+   PMD_DRV_LOG(ERR, "Timeout while waiting for a response 
for %u\n",
+   request->req_id);
+   ret = -ETIME;
+   goto done;
+   }
+   }
+
+   /* retrieve the response */
+   count = avp_fifo_get(avp->resp_q, (void **)&resp_addr, 1);
+   if ((count != 1) || (resp_addr != avp->host_sync_addr)) {
+   PMD_DRV_LOG(ERR, "Invalid response from host, count=%u resp=%p 
host_sync_addr=%p\n",
+   count, resp_addr, avp->host_sync_addr);
+   ret = -ENODATA;
+   goto done;
+   }
+
+   /* copy to user buffer */
+   rte_memcpy(request, avp->sync_addr, sizeof(*request));
+   ret = 0;
+
+   PMD_DRV_LOG(DEBUG, "Result %d received for request %u\n",
+   request->result, request->req_id);
+
+done:
+   return ret;
+}
+
+static int
+avp_dev_ctrl_set_config(struct rte_eth_dev *eth_dev,
+   struct rte_avp_device_config *config)
+{
+   struct avp_dev *avp = AVP_DEV_PRIVATE_TO_HW(eth_dev->data->dev_private);
+   struct rte_avp_request request;
+   int ret;
+
+   /* setup a configure request */
+   memset(&request, 0, sizeof(request));
+   request.req_id = RTE_AVP_REQ_CFG_DEVICE;
+   memcpy(&request.config, config, sizeof(request.config));
+
+   ret = avp_dev_process_request(avp, &request);
+
+   return ret == 0 ? request.result : ret;
+}
+
 /* translate from host physical address to guest virtual address */
 static void *
 avp_dev_translate_address(struct rte_eth_dev *eth_dev,
@@ -304,6 +404,38 @@ struct avp_queue {
return 0;
 }
 
+static void
+_avp_set_queue_counts(struct rte_eth_dev *eth_dev)
+{
+   struct rte_pci_device *pci_dev = AVP_DEV_TO_PCI(eth_dev);
+   struct avp_dev *avp = AVP_DEV_PRIVATE_TO_HW(eth_dev->data->dev_private);
+   struct rte_avp_device_info *host_info;
+   void *addr;

[dpdk-dev] [PATCH v4 12/17] net/avp: packet transmit functions

[Allain Legacy]

Adds support for packet transmit functions so that an application can send
packets to the host application via an AVP device queue.  Both the simple
and scattered functions are supported.

Signed-off-by: Allain Legacy 
Signed-off-by: Matt Peters 
---
 drivers/net/avp/avp_ethdev.c | 335 +++
 1 file changed, 335 insertions(+)

diff --git a/drivers/net/avp/avp_ethdev.c b/drivers/net/avp/avp_ethdev.c
index 65ae858..78018f5 100644
--- a/drivers/net/avp/avp_ethdev.c
+++ b/drivers/net/avp/avp_ethdev.c
@@ -92,12 +92,24 @@ static uint16_t avp_recv_scattered_pkts(void *rx_queue,
 static uint16_t avp_recv_pkts(void *rx_queue,
  struct rte_mbuf **rx_pkts,
  uint16_t nb_pkts);
+
+static uint16_t avp_xmit_scattered_pkts(void *tx_queue,
+   struct rte_mbuf **tx_pkts,
+   uint16_t nb_pkts);
+
+static uint16_t avp_xmit_pkts(void *tx_queue,
+ struct rte_mbuf **tx_pkts,
+ uint16_t nb_pkts);
+
 static void avp_dev_rx_queue_release(void *rxq);
 static void avp_dev_tx_queue_release(void *txq);
+
+
 #define AVP_DEV_TO_PCI(eth_dev) RTE_DEV_TO_PCI((eth_dev)->device)
 
 
 #define AVP_MAX_RX_BURST 64
+#define AVP_MAX_TX_BURST 64
 #define AVP_MAX_MAC_ADDRS 1
 #define AVP_MIN_RX_BUFSIZE ETHER_MIN_LEN
 
@@ -651,6 +663,7 @@ struct avp_queue {
pci_dev = AVP_DEV_TO_PCI(eth_dev);
eth_dev->dev_ops = &avp_eth_dev_ops;
eth_dev->rx_pkt_burst = &avp_recv_pkts;
+   eth_dev->tx_pkt_burst = &avp_xmit_pkts;
 
if (rte_eal_process_type() != RTE_PROC_PRIMARY) {
/*
@@ -662,6 +675,7 @@ struct avp_queue {
if (eth_dev->data->scattered_rx) {
PMD_DRV_LOG(NOTICE, "AVP device configured for chained 
mbufs\n");
eth_dev->rx_pkt_burst = avp_recv_scattered_pkts;
+   eth_dev->tx_pkt_burst = avp_xmit_scattered_pkts;
}
return 0;
}
@@ -793,6 +807,7 @@ struct avp_queue {
PMD_DRV_LOG(NOTICE, "AVP device configured for chained 
mbufs\n");
eth_dev->data->scattered_rx = 1;
eth_dev->rx_pkt_burst = avp_recv_scattered_pkts;
+   eth_dev->tx_pkt_burst = avp_xmit_scattered_pkts;
}
}
 
@@ -1255,6 +1270,326 @@ struct avp_queue {
return count;
 }
 
+/*
+ * Copy a chained mbuf to a set of host buffers.  This function assumes that
+ * there are sufficient destination buffers to contain the entire source
+ * packet.
+ */
+static inline uint16_t
+avp_dev_copy_to_buffers(struct avp_dev *avp,
+   struct rte_mbuf *mbuf,
+   struct rte_avp_desc **buffers,
+   unsigned int count)
+{
+   struct rte_avp_desc *previous_buf = NULL;
+   struct rte_avp_desc *first_buf = NULL;
+   struct rte_avp_desc *pkt_buf;
+   struct rte_avp_desc *buf;
+   size_t total_length;
+   struct rte_mbuf *m;
+   size_t copy_length;
+   size_t src_offset;
+   char *pkt_data;
+   unsigned int i;
+
+   __rte_mbuf_sanity_check(mbuf, 1);
+
+   m = mbuf;
+   src_offset = 0;
+   total_length = rte_pktmbuf_pkt_len(m);
+   for (i = 0; (i < count) && (m != NULL); i++) {
+   /* fill each destination buffer */
+   buf = buffers[i];
+
+   if (i < count - 1) {
+   /* prefetch next entry while processing this one */
+   pkt_buf = avp_dev_translate_buffer(avp, buffers[i + 1]);
+   rte_prefetch0(pkt_buf);
+   }
+
+   /* Adjust pointers for guest addressing */
+   pkt_buf = avp_dev_translate_buffer(avp, buf);
+   pkt_data = avp_dev_translate_buffer(avp, pkt_buf->data);
+
+   /* setup the buffer chain */
+   if (previous_buf != NULL)
+   previous_buf->next = buf;
+   else
+   first_buf = pkt_buf;
+
+   previous_buf = pkt_buf;
+
+   do {
+   /*
+* copy as many source mbuf segments as will fit in the
+* destination buffer.
+*/
+   copy_length = RTE_MIN((avp->host_mbuf_size -
+  pkt_buf->data_len),
+ (rte_pktmbuf_data_len(m) -
+  src_offset));
+   rte_memcpy(RTE_PTR_ADD(pkt_data, pkt_buf->data_len),
+  RTE_PTR_ADD(rte_pktmbuf_mtod(m, void *),
+  src_offset),
+  copy_length);
+   pkt_

[dpdk-dev] [PATCH v4 11/17] net/avp: packet receive functions

[Allain Legacy]

Adds function required for receiving packets from the host application via
AVP device queues.  Both the simple and scattered functions are supported.

Signed-off-by: Allain Legacy 
Signed-off-by: Matt Peters 
---
 drivers/net/avp/Makefile |   1 +
 drivers/net/avp/avp_ethdev.c | 451 +++
 2 files changed, 452 insertions(+)

diff --git a/drivers/net/avp/Makefile b/drivers/net/avp/Makefile
index 9cf0449..3013cd1 100644
--- a/drivers/net/avp/Makefile
+++ b/drivers/net/avp/Makefile
@@ -56,5 +56,6 @@ SRCS-$(CONFIG_RTE_LIBRTE_AVP_PMD) += avp_ethdev.c
 
 # this lib depends upon:
 DEPDIRS-$(CONFIG_RTE_LIBRTE_AVP_PMD) += lib/librte_eal lib/librte_ether
+DEPDIRS-$(CONFIG_RTE_LIBRTE_AVP_PMD) += lib/librte_mempool lib/librte_mbuf
 
 include $(RTE_SDK)/mk/rte.lib.mk
diff --git a/drivers/net/avp/avp_ethdev.c b/drivers/net/avp/avp_ethdev.c
index ad24217..65ae858 100644
--- a/drivers/net/avp/avp_ethdev.c
+++ b/drivers/net/avp/avp_ethdev.c
@@ -85,11 +85,19 @@ static int avp_dev_tx_queue_setup(struct rte_eth_dev *dev,
  unsigned int socket_id,
  const struct rte_eth_txconf *tx_conf);
 
+static uint16_t avp_recv_scattered_pkts(void *rx_queue,
+   struct rte_mbuf **rx_pkts,
+   uint16_t nb_pkts);
+
+static uint16_t avp_recv_pkts(void *rx_queue,
+ struct rte_mbuf **rx_pkts,
+ uint16_t nb_pkts);
 static void avp_dev_rx_queue_release(void *rxq);
 static void avp_dev_tx_queue_release(void *txq);
 #define AVP_DEV_TO_PCI(eth_dev) RTE_DEV_TO_PCI((eth_dev)->device)
 
 
+#define AVP_MAX_RX_BURST 64
 #define AVP_MAX_MAC_ADDRS 1
 #define AVP_MIN_RX_BUFSIZE ETHER_MIN_LEN
 
@@ -307,6 +315,15 @@ struct avp_queue {
return ret == 0 ? request.result : ret;
 }
 
+/* translate from host mbuf virtual address to guest virtual address */
+static inline void *
+avp_dev_translate_buffer(struct avp_dev *avp, void *host_mbuf_address)
+{
+   return RTE_PTR_ADD(RTE_PTR_SUB(host_mbuf_address,
+  (uintptr_t)avp->host_mbuf_addr),
+  (uintptr_t)avp->mbuf_addr);
+}
+
 /* translate from host physical address to guest virtual address */
 static void *
 avp_dev_translate_address(struct rte_eth_dev *eth_dev,
@@ -633,6 +650,7 @@ struct avp_queue {
 
pci_dev = AVP_DEV_TO_PCI(eth_dev);
eth_dev->dev_ops = &avp_eth_dev_ops;
+   eth_dev->rx_pkt_burst = &avp_recv_pkts;
 
if (rte_eal_process_type() != RTE_PROC_PRIMARY) {
/*
@@ -641,6 +659,10 @@ struct avp_queue {
 * be mapped to the same virtual address so all pointers should
 * be valid.
 */
+   if (eth_dev->data->scattered_rx) {
+   PMD_DRV_LOG(NOTICE, "AVP device configured for chained 
mbufs\n");
+   eth_dev->rx_pkt_burst = avp_recv_scattered_pkts;
+   }
return 0;
}
 
@@ -709,6 +731,38 @@ struct avp_queue {
 
 
 static int
+avp_dev_enable_scattered(struct rte_eth_dev *eth_dev,
+struct avp_dev *avp)
+{
+   unsigned int max_rx_pkt_len;
+
+   max_rx_pkt_len = eth_dev->data->dev_conf.rxmode.max_rx_pkt_len;
+
+   if ((max_rx_pkt_len > avp->guest_mbuf_size) ||
+   (max_rx_pkt_len > avp->host_mbuf_size)) {
+   /*
+* If the guest MTU is greater than either the host or guest
+* buffers then chained mbufs have to be enabled in the TX
+* direction.  It is assumed that the application will not need
+* to send packets larger than their max_rx_pkt_len (MRU).
+*/
+   return 1;
+   }
+
+   if ((avp->max_rx_pkt_len > avp->guest_mbuf_size) ||
+   (avp->max_rx_pkt_len > avp->host_mbuf_size)) {
+   /*
+* If the host MRU is greater than its own mbuf size or the
+* guest mbuf size then chained mbufs have to be enabled in the
+* RX direction.
+*/
+   return 1;
+   }
+
+   return 0;
+}
+
+static int
 avp_dev_rx_queue_setup(struct rte_eth_dev *eth_dev,
   uint16_t rx_queue_id,
   uint16_t nb_rx_desc,
@@ -734,6 +788,14 @@ struct avp_queue {
avp->guest_mbuf_size = (uint16_t)(mbp_priv->mbuf_data_room_size);
avp->guest_mbuf_size -= RTE_PKTMBUF_HEADROOM;
 
+   if (avp_dev_enable_scattered(eth_dev, avp)) {
+   if (!eth_dev->data->scattered_rx) {
+   PMD_DRV_LOG(NOTICE, "AVP device configured for chained 
mbufs\n");
+   eth_dev->data->scattered_rx = 1;
+   eth_dev->rx_pkt_burst = avp_recv_scattered_pkts;
+   }
+   }
+
PMD_DRV_LOG(DEBUG, "AVP max_rx_pkt_len=(%u,%u

[dpdk-dev] [PATCH v4 10/17] net/avp: queue setup and release

[Allain Legacy]

Adds queue management operations so that an appliation can setup and
release the transmit and receive queues.

Signed-off-by: Allain Legacy 
Signed-off-by: Matt Peters 
---
 drivers/net/avp/avp_ethdev.c | 180 ++-
 1 file changed, 179 insertions(+), 1 deletion(-)

diff --git a/drivers/net/avp/avp_ethdev.c b/drivers/net/avp/avp_ethdev.c
index bb6ccdf..ad24217 100644
--- a/drivers/net/avp/avp_ethdev.c
+++ b/drivers/net/avp/avp_ethdev.c
@@ -72,7 +72,21 @@ static void avp_dev_info_get(struct rte_eth_dev *dev,
 static void avp_vlan_offload_set(struct rte_eth_dev *dev, int mask);
 static int avp_dev_link_update(struct rte_eth_dev *dev,
   __rte_unused int wait_to_complete);
-
+static int avp_dev_rx_queue_setup(struct rte_eth_dev *dev,
+ uint16_t rx_queue_id,
+ uint16_t nb_rx_desc,
+ unsigned int socket_id,
+ const struct rte_eth_rxconf *rx_conf,
+ struct rte_mempool *pool);
+
+static int avp_dev_tx_queue_setup(struct rte_eth_dev *dev,
+ uint16_t tx_queue_id,
+ uint16_t nb_tx_desc,
+ unsigned int socket_id,
+ const struct rte_eth_txconf *tx_conf);
+
+static void avp_dev_rx_queue_release(void *rxq);
+static void avp_dev_tx_queue_release(void *txq);
 #define AVP_DEV_TO_PCI(eth_dev) RTE_DEV_TO_PCI((eth_dev)->device)
 
 
@@ -118,6 +132,10 @@ static int avp_dev_link_update(struct rte_eth_dev *dev,
.dev_infos_get   = avp_dev_info_get,
.vlan_offload_set= avp_vlan_offload_set,
.link_update = avp_dev_link_update,
+   .rx_queue_setup  = avp_dev_rx_queue_setup,
+   .rx_queue_release= avp_dev_rx_queue_release,
+   .tx_queue_setup  = avp_dev_tx_queue_setup,
+   .tx_queue_release= avp_dev_tx_queue_release,
 };
 
 /**@{ AVP device flags */
@@ -405,6 +423,42 @@ struct avp_queue {
 }
 
 static void
+_avp_set_rx_queue_mappings(struct rte_eth_dev *eth_dev, uint16_t rx_queue_id)
+{
+   struct avp_dev *avp =
+   AVP_DEV_PRIVATE_TO_HW(eth_dev->data->dev_private);
+   struct avp_queue *rxq;
+   uint16_t queue_count;
+   uint16_t remainder;
+
+   rxq = (struct avp_queue *)eth_dev->data->rx_queues[rx_queue_id];
+
+   /*
+* Must map all AVP fifos as evenly as possible between the configured
+* device queues.  Each device queue will service a subset of the AVP
+* fifos. If there is an odd number of device queues the first set of
+* device queues will get the extra AVP fifos.
+*/
+   queue_count = avp->num_rx_queues / eth_dev->data->nb_rx_queues;
+   remainder = avp->num_rx_queues % eth_dev->data->nb_rx_queues;
+   if (rx_queue_id < remainder) {
+   /* these queues must service one extra FIFO */
+   rxq->queue_base = rx_queue_id * (queue_count + 1);
+   rxq->queue_limit = rxq->queue_base + (queue_count + 1) - 1;
+   } else {
+   /* these queues service the regular number of FIFO */
+   rxq->queue_base = ((remainder * (queue_count + 1)) +
+  ((rx_queue_id - remainder) * queue_count));
+   rxq->queue_limit = rxq->queue_base + queue_count - 1;
+   }
+
+   PMD_DRV_LOG(DEBUG, "rxq %u at %p base %u limit %u\n",
+   rx_queue_id, rxq, rxq->queue_base, rxq->queue_limit);
+
+   rxq->queue_id = rxq->queue_base;
+}
+
+static void
 _avp_set_queue_counts(struct rte_eth_dev *eth_dev)
 {
struct rte_pci_device *pci_dev = AVP_DEV_TO_PCI(eth_dev);
@@ -655,6 +709,130 @@ struct avp_queue {
 
 
 static int
+avp_dev_rx_queue_setup(struct rte_eth_dev *eth_dev,
+  uint16_t rx_queue_id,
+  uint16_t nb_rx_desc,
+  unsigned int socket_id,
+  const struct rte_eth_rxconf *rx_conf,
+  struct rte_mempool *pool)
+{
+   struct avp_dev *avp = AVP_DEV_PRIVATE_TO_HW(eth_dev->data->dev_private);
+   struct rte_pktmbuf_pool_private *mbp_priv;
+   struct avp_queue *rxq;
+
+   if (rx_queue_id >= eth_dev->data->nb_rx_queues) {
+   PMD_DRV_LOG(ERR, "RX queue id is out of range: rx_queue_id=%u, 
nb_rx_queues=%u\n",
+   rx_queue_id, eth_dev->data->nb_rx_queues);
+   return -EINVAL;
+   }
+
+   /* Save mbuf pool pointer */
+   avp->pool = pool;
+
+   /* Save the local mbuf size */
+   mbp_priv = rte_mempool_get_priv(pool);
+   avp->guest_mbuf_size = (uint16_t)(mbp_priv->mbuf_data_room_size);
+   avp->guest_mbuf_size -= RTE_PKTMBUF_HEADROOM;
+
+   PMD_DRV_LOG(DEBUG, "AVP max_rx_pkt_len=(%u,%u) mbuf_size=(%u,%u)\n",
+   avp->max_rx_p

[dpdk-dev] [PATCH v4 13/17] net/avp: device statistics operations

[Allain Legacy]

Adds device functions to query and reset statistics.

Signed-off-by: Allain Legacy 
---
 drivers/net/avp/avp_ethdev.c | 67 
 1 file changed, 67 insertions(+)

diff --git a/drivers/net/avp/avp_ethdev.c b/drivers/net/avp/avp_ethdev.c
index 78018f5..c5039e2 100644
--- a/drivers/net/avp/avp_ethdev.c
+++ b/drivers/net/avp/avp_ethdev.c
@@ -104,6 +104,10 @@ static uint16_t avp_xmit_pkts(void *tx_queue,
 static void avp_dev_rx_queue_release(void *rxq);
 static void avp_dev_tx_queue_release(void *txq);
 
+static void avp_dev_stats_get(struct rte_eth_dev *dev,
+ struct rte_eth_stats *stats);
+static void avp_dev_stats_reset(struct rte_eth_dev *dev);
+
 
 #define AVP_DEV_TO_PCI(eth_dev) RTE_DEV_TO_PCI((eth_dev)->device)
 
@@ -151,6 +155,8 @@ static uint16_t avp_xmit_pkts(void *tx_queue,
.dev_configure   = avp_dev_configure,
.dev_infos_get   = avp_dev_info_get,
.vlan_offload_set= avp_vlan_offload_set,
+   .stats_get   = avp_dev_stats_get,
+   .stats_reset = avp_dev_stats_reset,
.link_update = avp_dev_link_update,
.rx_queue_setup  = avp_dev_rx_queue_setup,
.rx_queue_release= avp_dev_rx_queue_release,
@@ -1725,6 +1731,67 @@ struct avp_queue {
}
 }
 
+static void
+avp_dev_stats_get(struct rte_eth_dev *eth_dev, struct rte_eth_stats *stats)
+{
+   struct avp_dev *avp = AVP_DEV_PRIVATE_TO_HW(eth_dev->data->dev_private);
+   unsigned int i;
+
+   for (i = 0; i < avp->num_rx_queues; i++) {
+   struct avp_queue *rxq = avp->dev_data->rx_queues[i];
+
+   if (rxq) {
+   stats->ipackets += rxq->packets;
+   stats->ibytes += rxq->bytes;
+   stats->ierrors += rxq->errors;
+
+   stats->q_ipackets[i] += rxq->packets;
+   stats->q_ibytes[i] += rxq->bytes;
+   stats->q_errors[i] += rxq->errors;
+   }
+   }
+
+   for (i = 0; i < avp->num_tx_queues; i++) {
+   struct avp_queue *txq = avp->dev_data->tx_queues[i];
+
+   if (txq) {
+   stats->opackets += txq->packets;
+   stats->obytes += txq->bytes;
+   stats->oerrors += txq->errors;
+
+   stats->q_opackets[i] += txq->packets;
+   stats->q_obytes[i] += txq->bytes;
+   stats->q_errors[i] += txq->errors;
+   }
+   }
+}
+
+static void
+avp_dev_stats_reset(struct rte_eth_dev *eth_dev)
+{
+   struct avp_dev *avp = AVP_DEV_PRIVATE_TO_HW(eth_dev->data->dev_private);
+   unsigned int i;
+
+   for (i = 0; i < avp->num_rx_queues; i++) {
+   struct avp_queue *rxq = avp->dev_data->rx_queues[i];
+
+   if (rxq) {
+   rxq->bytes = 0;
+   rxq->packets = 0;
+   rxq->errors = 0;
+   }
+   }
+
+   for (i = 0; i < avp->num_tx_queues; i++) {
+   struct avp_queue *txq = avp->dev_data->tx_queues[i];
+
+   if (txq) {
+   txq->bytes = 0;
+   txq->packets = 0;
+   txq->errors = 0;
+   }
+   }
+}
 
 RTE_PMD_REGISTER_PCI(rte_avp, rte_avp_pmd.pci_drv);
 RTE_PMD_REGISTER_PCI_TABLE(rte_avp, pci_id_avp_map);
-- 
1.8.3.1

[dpdk-dev] [PATCH v4 15/17] net/avp: device start and stop operations

[Allain Legacy]

Adds support for device start and stop functions.  This allows an
application to control the administrative state of an AVP device.  Stopping
the device will notify the host application to stop sending packets on that
device's receive queues.

Signed-off-by: Allain Legacy 
Signed-off-by: Matt Peters 
---
 drivers/net/avp/avp_ethdev.c | 102 +++
 1 file changed, 102 insertions(+)

diff --git a/drivers/net/avp/avp_ethdev.c b/drivers/net/avp/avp_ethdev.c
index 8883742..d37e137 100644
--- a/drivers/net/avp/avp_ethdev.c
+++ b/drivers/net/avp/avp_ethdev.c
@@ -67,6 +67,9 @@ static int avp_dev_create(struct rte_pci_device *pci_dev,
 static int eth_avp_dev_uninit(struct rte_eth_dev *eth_dev);
 
 static int avp_dev_configure(struct rte_eth_dev *dev);
+static int avp_dev_start(struct rte_eth_dev *dev);
+static void avp_dev_stop(struct rte_eth_dev *dev);
+static void avp_dev_close(struct rte_eth_dev *dev);
 static void avp_dev_info_get(struct rte_eth_dev *dev,
 struct rte_eth_dev_info *dev_info);
 static void avp_vlan_offload_set(struct rte_eth_dev *dev, int mask);
@@ -156,6 +159,9 @@ static void avp_dev_stats_get(struct rte_eth_dev *dev,
  */
 static const struct eth_dev_ops avp_eth_dev_ops = {
.dev_configure   = avp_dev_configure,
+   .dev_start   = avp_dev_start,
+   .dev_stop= avp_dev_stop,
+   .dev_close   = avp_dev_close,
.dev_infos_get   = avp_dev_info_get,
.vlan_offload_set= avp_vlan_offload_set,
.stats_get   = avp_dev_stats_get,
@@ -321,6 +327,23 @@ struct avp_queue {
 }
 
 static int
+avp_dev_ctrl_set_link_state(struct rte_eth_dev *eth_dev, unsigned int state)
+{
+   struct avp_dev *avp = AVP_DEV_PRIVATE_TO_HW(eth_dev->data->dev_private);
+   struct rte_avp_request request;
+   int ret;
+
+   /* setup a link state change request */
+   memset(&request, 0, sizeof(request));
+   request.req_id = RTE_AVP_REQ_CFG_NETWORK_IF;
+   request.if_up = state;
+
+   ret = avp_dev_process_request(avp, &request);
+
+   return ret == 0 ? request.result : ret;
+}
+
+static int
 avp_dev_ctrl_set_config(struct rte_eth_dev *eth_dev,
struct rte_avp_device_config *config)
 {
@@ -338,6 +361,22 @@ struct avp_queue {
return ret == 0 ? request.result : ret;
 }
 
+static int
+avp_dev_ctrl_shutdown(struct rte_eth_dev *eth_dev)
+{
+   struct avp_dev *avp = AVP_DEV_PRIVATE_TO_HW(eth_dev->data->dev_private);
+   struct rte_avp_request request;
+   int ret;
+
+   /* setup a shutdown request */
+   memset(&request, 0, sizeof(request));
+   request.req_id = RTE_AVP_REQ_SHUTDOWN_DEVICE;
+
+   ret = avp_dev_process_request(avp, &request);
+
+   return ret == 0 ? request.result : ret;
+}
+
 /* translate from host mbuf virtual address to guest virtual address */
 static inline void *
 avp_dev_translate_buffer(struct avp_dev *avp, void *host_mbuf_address)
@@ -1674,6 +1713,69 @@ struct avp_queue {
return ret;
 }
 
+static int
+avp_dev_start(struct rte_eth_dev *eth_dev)
+{
+   struct avp_dev *avp = AVP_DEV_PRIVATE_TO_HW(eth_dev->data->dev_private);
+   int ret;
+
+   /* disable features that we do not support */
+   eth_dev->data->dev_conf.rxmode.hw_ip_checksum = 0;
+   eth_dev->data->dev_conf.rxmode.hw_vlan_filter = 0;
+   eth_dev->data->dev_conf.rxmode.hw_vlan_extend = 0;
+   eth_dev->data->dev_conf.rxmode.hw_strip_crc = 0;
+
+   /* update link state */
+   ret = avp_dev_ctrl_set_link_state(eth_dev, 1);
+   if (ret < 0) {
+   PMD_DRV_LOG(ERR, "Link state change failed by host, ret=%d\n",
+   ret);
+   goto unlock;
+   }
+
+   /* remember current link state */
+   avp->flags |= AVP_F_LINKUP;
+
+   ret = 0;
+
+unlock:
+   return ret;
+}
+
+static void
+avp_dev_stop(struct rte_eth_dev *eth_dev)
+{
+   struct avp_dev *avp = AVP_DEV_PRIVATE_TO_HW(eth_dev->data->dev_private);
+   int ret;
+
+   avp->flags &= ~AVP_F_LINKUP;
+
+   /* update link state */
+   ret = avp_dev_ctrl_set_link_state(eth_dev, 0);
+   if (ret < 0) {
+   PMD_DRV_LOG(ERR, "Link state change failed by host, ret=%d\n",
+   ret);
+   }
+}
+
+static void
+avp_dev_close(struct rte_eth_dev *eth_dev)
+{
+   struct avp_dev *avp = AVP_DEV_PRIVATE_TO_HW(eth_dev->data->dev_private);
+   int ret;
+
+   /* remember current link state */
+   avp->flags &= ~AVP_F_LINKUP;
+   avp->flags &= ~AVP_F_CONFIGURED;
+
+   /* update device state */
+   ret = avp_dev_ctrl_shutdown(eth_dev);
+   if (ret < 0) {
+   PMD_DRV_LOG(ERR, "Device shutdown failed by host, ret=%d\n",
+   ret);
+   /* continue */
+   }
+}
 
 static int
 avp_dev_link_update(struct rte_eth_dev *eth_dev,
-- 
1.8.3.1

[dpdk-dev] [PATCH v4 14/17] net/avp: device promiscuous functions

[Allain Legacy]

Adds support for setting and clearing promiscuous mode on an AVP device.
When enabled the _mac_filter function will allow packets destined to any
MAC address to be processed by the receive functions.

Signed-off-by: Allain Legacy 
Signed-off-by: Matt Peters 
---
 drivers/net/avp/avp_ethdev.c | 28 
 1 file changed, 28 insertions(+)

diff --git a/drivers/net/avp/avp_ethdev.c b/drivers/net/avp/avp_ethdev.c
index c5039e2..8883742 100644
--- a/drivers/net/avp/avp_ethdev.c
+++ b/drivers/net/avp/avp_ethdev.c
@@ -72,6 +72,9 @@ static void avp_dev_info_get(struct rte_eth_dev *dev,
 static void avp_vlan_offload_set(struct rte_eth_dev *dev, int mask);
 static int avp_dev_link_update(struct rte_eth_dev *dev,
   __rte_unused int wait_to_complete);
+static void avp_dev_promiscuous_enable(struct rte_eth_dev *dev);
+static void avp_dev_promiscuous_disable(struct rte_eth_dev *dev);
+
 static int avp_dev_rx_queue_setup(struct rte_eth_dev *dev,
  uint16_t rx_queue_id,
  uint16_t nb_rx_desc,
@@ -158,6 +161,8 @@ static void avp_dev_stats_get(struct rte_eth_dev *dev,
.stats_get   = avp_dev_stats_get,
.stats_reset = avp_dev_stats_reset,
.link_update = avp_dev_link_update,
+   .promiscuous_enable  = avp_dev_promiscuous_enable,
+   .promiscuous_disable = avp_dev_promiscuous_disable,
.rx_queue_setup  = avp_dev_rx_queue_setup,
.rx_queue_release= avp_dev_rx_queue_release,
.tx_queue_setup  = avp_dev_tx_queue_setup,
@@ -1684,6 +1689,29 @@ struct avp_queue {
return -1;
 }
 
+static void
+avp_dev_promiscuous_enable(struct rte_eth_dev *eth_dev)
+{
+   struct avp_dev *avp = AVP_DEV_PRIVATE_TO_HW(eth_dev->data->dev_private);
+
+   if ((avp->flags & AVP_F_PROMISC) == 0) {
+   avp->flags |= AVP_F_PROMISC;
+   PMD_DRV_LOG(DEBUG, "Promiscuous mode enabled on %u\n",
+   eth_dev->data->port_id);
+   }
+}
+
+static void
+avp_dev_promiscuous_disable(struct rte_eth_dev *eth_dev)
+{
+   struct avp_dev *avp = AVP_DEV_PRIVATE_TO_HW(eth_dev->data->dev_private);
+
+   if ((avp->flags & AVP_F_PROMISC) != 0) {
+   avp->flags &= ~AVP_F_PROMISC;
+   PMD_DRV_LOG(DEBUG, "Promiscuous mode disabled on %u\n",
+   eth_dev->data->port_id);
+   }
+}
 
 static void
 avp_dev_info_get(struct rte_eth_dev *eth_dev,
-- 
1.8.3.1

[dpdk-dev] [PATCH v4 16/17] net/avp: migration interrupt handling

[Allain Legacy]

This commit introduces changes required to support VM live-migration.  This
is done by registering and responding to interrupts coming from the host to
signal that the memory is about to be made invalid and replaced with a new
memory zone on the destination compute node.

Enabling and disabling of the interrupts are maintained outside of the
start/stop functions because they must be enabled for the lifetime of the
device.  This is so that host interrupts are serviced and acked even in
cases where the app may have stopped the device.

Signed-off-by: Allain Legacy 
Signed-off-by: Matt Peters 
---
 drivers/net/avp/avp_ethdev.c | 370 +++
 1 file changed, 370 insertions(+)

diff --git a/drivers/net/avp/avp_ethdev.c b/drivers/net/avp/avp_ethdev.c
index d37e137..1c598cb 100644
--- a/drivers/net/avp/avp_ethdev.c
+++ b/drivers/net/avp/avp_ethdev.c
@@ -48,6 +48,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -179,6 +180,7 @@ static void avp_dev_stats_get(struct rte_eth_dev *dev,
 #define AVP_F_PROMISC (1 << 1)
 #define AVP_F_CONFIGURED (1 << 2)
 #define AVP_F_LINKUP (1 << 3)
+#define AVP_F_DETACHED (1 << 4)
 /**@} */
 
 /* Ethernet device validation marker */
@@ -214,6 +216,9 @@ struct avp_dev {
struct rte_avp_fifo *free_q[RTE_AVP_MAX_QUEUES];
/**< To be freed mbufs queue */
 
+   /* mutual exclusion over the 'flag' and 'resp_q/req_q' fields */
+   rte_spinlock_t lock;
+
/* For request & response */
struct rte_avp_fifo *req_q; /**< Request queue */
struct rte_avp_fifo *resp_q; /**< Response queue */
@@ -501,6 +506,46 @@ struct avp_queue {
return 0;
 }
 
+static int
+avp_dev_detach(struct rte_eth_dev *eth_dev)
+{
+   struct avp_dev *avp = AVP_DEV_PRIVATE_TO_HW(eth_dev->data->dev_private);
+   int ret;
+
+   PMD_DRV_LOG(NOTICE, "Detaching port %u from AVP device 0x%" PRIx64 "\n",
+   eth_dev->data->port_id, avp->device_id);
+
+   rte_spinlock_lock(&avp->lock);
+
+   if (avp->flags & AVP_F_DETACHED) {
+   PMD_DRV_LOG(NOTICE, "port %u already detached\n",
+   eth_dev->data->port_id);
+   ret = 0;
+   goto unlock;
+   }
+
+   /* shutdown the device first so the host stops sending us packets. */
+   ret = avp_dev_ctrl_shutdown(eth_dev);
+   if (ret < 0) {
+   PMD_DRV_LOG(ERR, "Failed to send/recv shutdown to host, 
ret=%d\n",
+   ret);
+   avp->flags &= ~AVP_F_DETACHED;
+   goto unlock;
+   }
+
+   avp->flags |= AVP_F_DETACHED;
+   rte_wmb();
+
+   /* wait for queues to acknowledge the presence of the detach flag */
+   rte_delay_ms(1);
+
+   ret = 0;
+
+unlock:
+   rte_spinlock_unlock(&avp->lock);
+   return ret;
+}
+
 static void
 _avp_set_rx_queue_mappings(struct rte_eth_dev *eth_dev, uint16_t rx_queue_id)
 {
@@ -569,6 +614,240 @@ struct avp_queue {
avp->num_tx_queues, avp->num_rx_queues);
 }
 
+static int
+avp_dev_attach(struct rte_eth_dev *eth_dev)
+{
+   struct avp_dev *avp = AVP_DEV_PRIVATE_TO_HW(eth_dev->data->dev_private);
+   struct rte_avp_device_config config;
+   unsigned int i;
+   int ret;
+
+   PMD_DRV_LOG(NOTICE, "Attaching port %u to AVP device 0x%" PRIx64 "\n",
+   eth_dev->data->port_id, avp->device_id);
+
+   rte_spinlock_lock(&avp->lock);
+
+   if (!(avp->flags & AVP_F_DETACHED)) {
+   PMD_DRV_LOG(NOTICE, "port %u already attached\n",
+   eth_dev->data->port_id);
+   ret = 0;
+   goto unlock;
+   }
+
+   /*
+* make sure that the detached flag is set prior to reconfiguring the
+* queues.
+*/
+   avp->flags |= AVP_F_DETACHED;
+   rte_wmb();
+
+   /*
+* re-run the device create utility which will parse the new host info
+* and setup the AVP device queue pointers.
+*/
+   ret = avp_dev_create(AVP_DEV_TO_PCI(eth_dev), eth_dev);
+   if (ret < 0) {
+   PMD_DRV_LOG(ERR, "Failed to re-create AVP device, ret=%d\n",
+   ret);
+   goto unlock;
+   }
+
+   if (avp->flags & AVP_F_CONFIGURED) {
+   /*
+* Update the receive queue mapping to handle cases where the
+* source and destination hosts have different queue
+* requirements.  As long as the DETACHED flag is asserted the
+* queue table should not be referenced so it should be safe to
+* update it.
+*/
+   _avp_set_queue_counts(eth_dev);
+   for (i = 0; i < eth_dev->data->nb_rx_queues; i++)
+   _avp_set_rx_queue_mappings(eth_dev, i);
+
+   /*
+* Update the host with our config details so that it knows t

[dpdk-dev] [PATCH v4 17/17] doc: adds information related to the AVP PMD

[Allain Legacy]

Updates the documentation and feature lists for the AVP PMD device.

Signed-off-by: Allain Legacy 
Signed-off-by: Matt Peters 
Acked-by: John McNamara 
---
 MAINTAINERS|   1 +
 doc/guides/nics/avp.rst| 112 +
 doc/guides/nics/features/avp.ini   |  17 +
 doc/guides/nics/index.rst  |   1 +
 doc/guides/rel_notes/release_17_05.rst |   5 ++
 5 files changed, 136 insertions(+)
 create mode 100644 doc/guides/nics/avp.rst
 create mode 100644 doc/guides/nics/features/avp.ini

diff --git a/MAINTAINERS b/MAINTAINERS
index fef23a0..4a14945 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -427,6 +427,7 @@ Wind River AVP PMD
 M: Allain Legacy 
 M: Matt Peters 
 F: drivers/net/avp
+F: doc/guides/nics/avp.rst
 
 
 Crypto Drivers
diff --git a/doc/guides/nics/avp.rst b/doc/guides/nics/avp.rst
new file mode 100644
index 000..af6d04d
--- /dev/null
+++ b/doc/guides/nics/avp.rst
@@ -0,0 +1,112 @@
+..  BSD LICENSE
+Copyright(c) 2017 Wind River Systems, Inc. rights reserved.
+All rights reserved.
+
+Redistribution and use in source and binary forms, with or without
+modification, are permitted provided that the following conditions
+are met:
+
+* Redistributions of source code must retain the above copyright
+notice, this list of conditions and the following disclaimer.
+* Redistributions in binary form must reproduce the above copyright
+notice, this list of conditions and the following disclaimer in
+the documentation and/or other materials provided with the
+distribution.
+* Neither the name of Intel Corporation nor the names of its
+contributors may be used to endorse or promote products derived
+from this software without specific prior written permission.
+
+THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+"AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+AVP Poll Mode Driver
+=
+
+The Accelerated Virtual Port (AVP) device is a shared memory based device
+available on the `virtualization platforms 
`_
+from Wind River Systems.  It is based on an earlier implementation of the DPDK
+KNI device and made available to VM instances via a mechanism based on an early
+implementation of qemu-kvm ivshmem.
+
+It enables optimized packet throughput without requiring any packet processing
+in qemu. This provides our customers with a significant performance increase
+for DPDK applications in the VM.  Since our AVP implementation supports VM
+live-migration it is viewed as a better alternative to PCI passthrough or PCI
+SRIOV since neither of those support VM live-migration without manual
+intervention or significant performance penalties.
+
+Since the initial implementation of AVP devices, vhost-user has become
+part of the qemu offering with a significant performance increase over
+the original virtio implementation.  However, vhost-user still does
+not achieve the level of performance that the AVP device can provide
+to our customers for DPDK based VM instances.
+
+The driver binds to PCI devices that are exported by the hypervisor DPDK
+application via the ivshmem-like mechanism.  The definition of the device
+structure and configuration options are defined in rte_avp_common.h and
+rte_avp_fifo.h.  These two header files are made available as part of the PMD
+implementation in order to share the device definitions between the guest
+implementation (i.e., the PMD) and the host implementation (i.e., the
+hypervisor DPDK vswitch application).
+
+
+Features and Limitations of the AVP PMD
+---
+
+The AVP PMD driver provides the following functionality.
+
+*   Receive and transmit of both simple and chained mbuf packets,
+
+*   Chained mbufs may include up to 5 chained segments,
+
+*   Up to 8 receive and transmit queues per device,
+
+*   Only a single MAC address is supported,
+
+*   The MAC address cannot be modified,
+
+*   The maximum receive packet length is 9238 bytes,
+
+*   VLAN header stripping and inserting,
+
+*   Promiscuous mode
+
+*   VM live-migration
+
+*   PCI hotplug insertion and removal
+
+
+Prerequisites
+-
+
+

Re: [dpdk-dev] [PATCH v3 16/16] doc: adds information related to the AVP PMD

[Legacy, Allain]

Vincent,
Perhaps you can help me understand why the performance or functionality of AVP 
vs. Virtio is relevant to the decision of accepting this driver.   There are 
many drivers in the DPDK; most of which provide the same functionality at 
comparable performance rates.  AVP is just another such driver.   The fact that 
it is virtual rather than physical, in my opinion, should not influence the 
decision of accepting this driver.   On the other hand, code quality/complexity 
or lack of a maintainer are reasonable reasons for rejecting.If our driver 
is accepted we are committed to maintaining it and testing changes as required 
by any driver framework changes which may impact all drivers.

Along the same lines, I do not understand why upstreaming AVP in to the Linux 
kernel or qemu/kvm should be a prerequisite for inclusion in the DPDK.   
Continuing my analogy from above, the AVP device is a commercial offering tied 
to the Wind River Systems Titanium product line.   It enables virtualized DPDK 
applications and increases DPDK adoption.   Similarly to how a driver from 
company XYX is tied to a commercial NIC that must be purchased by a customer, 
our AVP device is available to operators that choose to leverage our Titanium 
product to implement their Cloud solutions.It is not our intention to 
upstream the qemu/kvm or host vswitch portion of the AVP device.   Our qemu/kvm 
extensions are GPL so they are available to our customers if they desire to 
rebuild qemu/kvm with their own proprietary extensions

Our AVP device was implemented in 2013 in response to the challenge of lower 
than required performance of qemu/virtio in both user space and DPDK 
applications in the VM.   Rather than making complex changes to qemu/virtio and 
continuously have to forward prop those as we upgraded to newer versions of 
qemu we decided to decouple ourselves from that code base.   We developed the 
AVP device based on an evolution of KNI+ivshmem by enhancing both with features 
that would meet the needs of our customers; better performance, multi-queue 
support, live-migration support, hot-plug support.As I said in my earlier 
response, since 2013, qemu/virtio has seen improved performance with the 
introduction of vhost-user.   The performance of vhost-user still has not yet 
achieved performance levels equal to our AVP PMD.   

I acknowledge that the AVP driver could exist as an out-of-tree driver loaded 
as a shared library at runtime.  In fact, 2 years ago we released our driver 
source on github for this very reason.  We provide instructions and support for 
building the AVP PMD as a shared library.   Some customers have adopted this 
method while many insist on an in-tree driver for several reasons.   

Most importantly, they want to eliminate the burden of needing to build and 
support an additional package into their product.   An in-tree driver would 
eliminate the need for a separate build/packaging process.   Also, they want an 
option that allows them to be able to develop directly on the bleeding edge of 
DPDK rather than waiting on us to update our out-of-tree driver based on stable 
releases of the DPDK.   In this regard, an in-tree driver would allow our 
customers to work directly on the latest DPDK. 

An in-tree driver provides obvious benefits to our customers, but keep in mind 
that this also provides a benefit to the DPDK.  If a customer must develop on a 
stable release because they must use an out-of-tree driver then they are less 
likely to contribute fixes/enhancements/testing upstream.  I know this first 
hand because I work with software from different sources on a daily basis and 
it is a significant burden to have to reproduce/test fixes on master when you 
build/ship on an older stable release.   Accepting this driver would increase 
the potential pool of developers available for contributions and reviews.

Again, we are committed to contributing to the DPDK community by supporting our 
driver and upstreaming other fixes/enhancements we develop along the way.   We 
feel that if the DPDK is limited to only a single virtual driver of any type 
then choice and innovation is also limited.   In the end if more variety and 
innovation increases DPDK adoption then this is a win for DPDK and everyone 
that is involved in the project.

Regards,
Allain

Allain Legacy, Software Developer
direct 613.270.2279  fax 613.492.7870 skype allain.legacy
 



> -Original Message-
> From: Vincent JARDIN [mailto:vincent.jar...@6wind.com]
> Sent: Friday, March 03, 2017 11:22 AM
> To: Legacy, Allain; YIGIT, FERRUH
> Cc: Jolliffe, Ian; jerin.ja...@caviumnetworks.com;
> step...@networkplumber.org; thomas.monja...@6wind.com;
> dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v3 16/16] doc: adds information related to
> the AVP PMD
> 
> Le 02/03/2017 à 01:20, Allain Legacy a écrit :
> > +Since the initial implementation of AVP devices, vhost-user has become
> > +part of the qemu offering with a signific

Re: [dpdk-dev] [PATCH] examples/ip_fragmentation: fix check of packet type

[Ananyev, Konstantin]

> > Hi Wei,
> >
> > >
> > > Hi, Konstantin
> > > I see your point.
> > > I think your method can work.
> > > But I think your method is a bit complex. As you method need to add more
> > codes.
> > > Anyway this is a simple bug.
> > > How do you think now ?
> >
> > I still think it is better for all apps to handle this issue in a uniform 
> > way.
> > Again in that case for NICs that do support PTYPE offloads the performance
> > should be unaffected.
> > Konstantin
> >
> 
> I have just had a quick look through the l3fwd and didn't find any codes to
> check what ptypes capabilities ae provided by stuff below DPDK PMD & its base 
> driver.
> L3fwd only check an input argument "--parse-ptype" to enable ptype check 
> implemented in
> a Rx callback function.

As an example for lpm:
http://dpdk.org/browse/dpdk/tree/examples/l3fwd/l3fwd_lpm.c#n279
Konstantin


> In this l3fwd rx callback function,  it has done the same thing as my code.
> Anyway, I'd like to provide a v2 patch to deal with this issue in a uniform 
> way.
> 
> Thanks & Best Regards
> -Wei

[dpdk-dev] [PATCH] net/vmxnet3: fix queue size changes

[Charles (Chas) Williams]

If the user reconfigures the queues size, then the previosly allocated
memzone may potentially be too small.  Instead, always free the old
memzone and allocate a new one.

Fixes: dfaff37fc46d ("vmxnet3: import new vmxnet3 poll mode driver 
implementation")

Signed-off-by: Chas Williams 
---
 drivers/net/vmxnet3/vmxnet3_rxtx.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/vmxnet3/vmxnet3_rxtx.c 
b/drivers/net/vmxnet3/vmxnet3_rxtx.c
index 6649c3f..104e040 100644
--- a/drivers/net/vmxnet3/vmxnet3_rxtx.c
+++ b/drivers/net/vmxnet3/vmxnet3_rxtx.c
@@ -893,8 +893,8 @@ vmxnet3_recv_pkts(void *rx_queue, struct rte_mbuf 
**rx_pkts, uint16_t nb_pkts)
 
 /*
  * Create memzone for device rings. malloc can't be used as the physical 
address is
- * needed. If the memzone is already created, then this function returns a ptr
- * to the old one.
+ * needed. If the memzone already exists, we free it since it may have been 
created
+ * with a different size.
  */
 static const struct rte_memzone *
 ring_dma_zone_reserve(struct rte_eth_dev *dev, const char *ring_name,
@@ -909,7 +909,7 @@ ring_dma_zone_reserve(struct rte_eth_dev *dev, const char 
*ring_name,
 
mz = rte_memzone_lookup(z_name);
if (mz)
-   return mz;
+   rte_memzone_free(mz);
 
return rte_memzone_reserve_aligned(z_name, ring_size,
   socket_id, 0, VMXNET3_RING_BA_ALIGN);
-- 
2.1.4

Re: [dpdk-dev] [PATCH] examples/ip_fragmentation: fix check of packet type

[Dai, Wei]

> -Original Message-
> From: Ananyev, Konstantin
> Sent: Tuesday, March 14, 2017 6:13 AM
> To: Dai, Wei ; dev@dpdk.org
> Cc: sta...@dpdk.org
> Subject: RE: [PATCH] examples/ip_fragmentation: fix check of packet type
> 
> 
> 
> > > Hi Wei,
> > >
> > > >
> > > > Hi, Konstantin
> > > > I see your point.
> > > > I think your method can work.
> > > > But I think your method is a bit complex. As you method need to
> > > > add more
> > > codes.
> > > > Anyway this is a simple bug.
> > > > How do you think now ?
> > >
> > > I still think it is better for all apps to handle this issue in a uniform 
> > > way.
> > > Again in that case for NICs that do support PTYPE offloads the
> > > performance should be unaffected.
> > > Konstantin
> > >
> >
> > I have just had a quick look through the l3fwd and didn't find any
> > codes to check what ptypes capabilities ae provided by stuff below DPDK
> PMD & its base driver.
> > L3fwd only check an input argument "--parse-ptype" to enable ptype
> > check implemented in a Rx callback function.
> 
> As an example for lpm:
> http://dpdk.org/browse/dpdk/tree/examples/l3fwd/l3fwd_lpm.c#n279
> Konstantin

Thanks for your guide.
I will use rte_eth_dev_get_supported_ptypes( ) in my v2 patch.

> 
> 
> > In this l3fwd rx callback function,  it has done the same thing as my code.
> > Anyway, I'd like to provide a v2 patch to deal with this issue in a uniform 
> > way.
> >
> > Thanks & Best Regards
> > -Wei

Re: [dpdk-dev] i40e SR-IOV with Linux PF

[Wu, Jingjing]

> -Original Message-
> From: Thomas Monjalon [mailto:thomas.monja...@6wind.com]
> Sent: Monday, March 13, 2017 7:35 AM
> To: Zhang, Helin ; Wu, Jingjing
> ; Chen, Jing D 
> Cc: Yigit, Ferruh ; vincent.jar...@6wind.com;
> dev@dpdk.org
> Subject: Re: i40e SR-IOV with Linux PF
> 
> +Cc dev@dpdk.org
> 
> 2017-03-13 15:29, Thomas Monjalon:
> > Hi i40e developers,
> >
> > Referring to the VFD discussion, I thought basic behaviours were the
> > same regardless of the PF driver:
> > http://dpdk.org/ml/archives/dev/2016-December/053056.html
> > "
> > > In the meanwhile, we have some test models ongoing to validate
> > > combination of Linux and DPDK drivers for VF and PF.
> > > We'll fully support below 4 cases going forward.
> > > 1. DPDK PF + DPDK VF
> > > 2. DPDK PF + Linux VF
> > > 3. Linux PF + DPDK VF
> > > 4. Linux PF + Linux VF (it's not our scope)
> > [...]
> > > Linux PF + DPDK VF has been tested with 1.0 API long time ago.
> > > There is some test activities ongoing.
> > "
> >
> > I think the Linux PF case is important and deserves more consideration.
> > When looking at the code, specifically i40evf_vlan_offload_set() and
> > i40evf_vlan_pvid_set(), I read this:
> > "
> > /* Linux pf host doesn't support vlan offload yet */
> > if (vf->version_major == I40E_DPDK_VERSION_MAJOR) { "
> >
> > Is there some work in progress on Linux side to get the same behaviour
> > as with a DPDK PF?
> >

As I know, VFD features are marked with an "EXPERIMENTAL" tag.
And we are working on the extendable interface (feature based) with
PF kernel driver. 

Re: [dpdk-dev] [PATCH] vhost: add back support for concurrent enqueue

[Yuanhan Liu]

On Thu, Mar 09, 2017 at 02:46:27PM +0100, Thomas Monjalon wrote:
> 2016-08-23 15:42, Rich Lane:
> > On Mon, Aug 22, 2016 at 7:16 AM, Yuanhan Liu 
> > wrote:
> > > On Thu, Aug 18, 2016 at 11:27:06AM -0700, Rich Lane wrote:
> > > > I could also add back concurrent enqueue support for mergeable RX, but I
> > > > was hoping to avoid that since the mergeable codepath is already complex
> > > > and wouldn't be used in high performance deployments.
> > >
> > > Another note is that, you might also have noticed, Zhihong made a patch
> > > set [0] to optimize the enqueue code path (mainly on mergeable path). It
> > > basically does a rewrite from scatch, which removes the desc buf
> > > reservation,
> > > meaning it would be harder to do concurrent enqueue support based on that.
> > >
> > > [0]: Aug 19 Zhihong Wang(  68) ├─>[PATCH v3 0/5] vhost: optimize
> > > enqueue
> > 
> > Yes, I'd noticed that these patches would conflict. Once the vhost-cuse
> > removal and
> > Zhihong's patches have merged I'll send a new version.
> 
> What is the status of this feature?

Rich left bigswitch for a while, and seems no one is working on that
anymore. I think we could just close it.

--yliu

Re: [dpdk-dev] [PATCH] net/virtio-user: fix tapfds close issue

[Yuanhan Liu]

On Mon, Mar 13, 2017 at 09:33:21AM +, Wenfeng Liu wrote:
> The valid tap file descriptor range should be equal or greater
> than zero instead of non-zero
> 
> Fixes: e3b434818bbb ("net/virtio-user: support kernel vhost")
> 

Cc: sta...@dpdk.org

Applied to dpdk-next-virtio. Thanks.

--yliu

> Signed-off-by: Wenfeng Liu 
> ---

Re: [dpdk-dev] [PATCHv8 19/46] pool/dpaa2: add DPAA2 hardware offloaded mempool

[Hemant Agrawal]

On 3/9/2017 11:27 AM, Hemant Agrawal wrote:

On 3/8/2017 9:09 PM, Thomas Monjalon wrote:

2017-03-08 18:22, Hemant Agrawal:

On Fri, 3 Mar 2017 18:16:36 +0530, Hemant Agrawal
 wrote:
I think the current mempool handlers should be moved first in a
separate patch.


Yes it should have been done earlier.


Are you seeing any benefit by making it a separate patch series?


A separate patchset for moving mempool handlers will be easy to review
and accept.
If integrated in this series, it is kind of hidden and prevent the
visibility and review it deserves.
By the way the mempool move should be directly committed in the main
repository, while this series targets next-net.



hw mempool has dependency on mc-bus. So, we will break it into *5* series,

1. mc-bus - which can go on main repo - Rebased over main repo
2. dpaa2-pool - it can also go on main rep (depends on mc-bus) - Rebased
over 'main repo + 1'.
3. dpaa2-pmd - this depends on mc-bus and dpaa2-pool
  A. mc-bus -another series rebased over net-next
  B. dpaa2-pool - another series rebased over 'net-next + A'
  C. the pmd itself rebased over 'net-next + A + B'

Are you sure, you will like us to do the above and flood the mailing
list :)

I think, this will make the review difficult.

Bruce, Ferruh, Olivier - does the above help you? If so, we can do it.


Any views, we can rebase our next version accordingly.
we are looking forward to get it merged in 17.05.



My preference is to keep it as it is. It can be applied on 'net-next' or
'main' as a whole. But I am open for suggestions.





it will be difficult and tricky for us. The dpaa2_pool has a dependency
on mc bus patches. dpaa2_pmd has dependency on dpaa2_pool and mc buses.


You will just have to rebase this series on top of the new one.

Re: [dpdk-dev] [PATCH] net/virtio-user: fix overflow

[Yuanhan Liu]

On Mon, Mar 13, 2017 at 03:09:15PM +, Wenfeng Liu wrote:
> This commit fixes an array overflow when number of queues is higher than 8.

Firstly, this commit log could be a bit more informative, to something
like:

virtio-user limits the qeueue number to 8 but provides no limit
check against the queue number input from user. If a bigger queue
number (> 8) is given, there is an overflow issue. Doing a sanity
check could avoid it.

> 
> Fixes: 37a7eb2ae816 ("net/virtio-user: add device emulation layer")
> 
> Signed-off-by: Wenfeng Liu 
> ---
>  drivers/net/virtio/virtio_pci.h  | 3 ++-
>  drivers/net/virtio/virtio_user/virtio_user_dev.c | 2 +-
>  drivers/net/virtio/virtio_user/virtio_user_dev.h | 6 +++---
>  drivers/net/virtio/virtio_user_ethdev.c  | 7 +++
>  4 files changed, 13 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/net/virtio/virtio_pci.h b/drivers/net/virtio/virtio_pci.h
> index 59e45c4..bd940b4 100644
> --- a/drivers/net/virtio/virtio_pci.h
> +++ b/drivers/net/virtio/virtio_pci.h
> @@ -160,7 +160,8 @@
>  /*
>   * Maximum number of virtqueues per device.
>   */
> -#define VIRTIO_MAX_VIRTQUEUES 8
> +#define VIRTIO_MAX_VIRTQUEUE_PAIRS 8
> +#define VIRTIO_MAX_VIRTQUEUES VIRTIO_MAX_VIRTQUEUE_PAIRS * 2 + 1
>  
>  /* Common configuration */
>  #define VIRTIO_PCI_CAP_COMMON_CFG1
> diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c 
> b/drivers/net/virtio/virtio_user/virtio_user_dev.c
> index e7fd65f..5b81676 100644
> --- a/drivers/net/virtio/virtio_user/virtio_user_dev.c
> +++ b/drivers/net/virtio/virtio_user/virtio_user_dev.c
> @@ -234,7 +234,7 @@ int virtio_user_stop_device(struct virtio_user_dev *dev)
>   uint32_t i, q;
>  
>   dev->vhostfd = -1;
> - for (i = 0; i < VIRTIO_MAX_VIRTQUEUES * 2 + 1; ++i) {
> + for (i = 0; i < VIRTIO_MAX_VIRTQUEUES; ++i) {

Right, we don't need setup callfd and kickfd for the ctrl-queue.

>   dev->kickfds[i] = -1;
>   dev->callfds[i] = -1;
>   }
> diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.h 
> b/drivers/net/virtio/virtio_user/virtio_user_dev.h
> index 6ecb91e..ba80d05 100644
> --- a/drivers/net/virtio/virtio_user/virtio_user_dev.h
> +++ b/drivers/net/virtio/virtio_user/virtio_user_dev.h
> @@ -49,8 +49,8 @@ struct virtio_user_dev {
>   int *tapfds;
>  
>   /* for both vhost_user and vhost_kernel */
> - int callfds[VIRTIO_MAX_VIRTQUEUES * 2 + 1];
> - int kickfds[VIRTIO_MAX_VIRTQUEUES * 2 + 1];
> + int callfds[VIRTIO_MAX_VIRTQUEUES];
> + int kickfds[VIRTIO_MAX_VIRTQUEUES];
>   int mac_specified;
>   uint32_tmax_queue_pairs;
>   uint32_tqueue_pairs;
> @@ -62,7 +62,7 @@ struct virtio_user_dev {
>   uint8_t status;
>   uint8_t mac_addr[ETHER_ADDR_LEN];
>   charpath[PATH_MAX];
> - struct vringvrings[VIRTIO_MAX_VIRTQUEUES * 2 + 1];
> + struct vringvrings[VIRTIO_MAX_VIRTQUEUES];

Have you actually tested your patch? You are removing the vring for
ctrl-queue, which is wrong to me.

>   struct virtio_user_backend_ops *ops;
>  };
>  
> diff --git a/drivers/net/virtio/virtio_user_ethdev.c 
> b/drivers/net/virtio/virtio_user_ethdev.c
> index 16d1526..d476a2d 100644
> --- a/drivers/net/virtio/virtio_user_ethdev.c
> +++ b/drivers/net/virtio/virtio_user_ethdev.c
> @@ -433,6 +433,13 @@
>   goto end;
>   }
>  
> + if (queues > VIRTIO_MAX_VIRTQUEUE_PAIRS) {
> + PMD_INIT_LOG(ERR, "arg %s %u exceeds the limit %u",
> + VIRTIO_USER_ARG_QUEUES_NUM, queues,
> + VIRTIO_MAX_VIRTQUEUE_PAIRS);
> + goto end;
> + }

Yes, we need this check. So, to me, you were actually doing two things
in this patch:

- check the queue number, to avoid overflow
- remove the callfds and kickfds for ctrl-queue.

That said, please do them in two patches.

Thanks.

--yliu
> +
>   eth_dev = virtio_user_eth_dev_alloc(name);
>   if (!eth_dev) {
>   PMD_INIT_LOG(ERR, "virtio_user fails to alloc device");
> -- 
> 1.8.3.1

Re: [dpdk-dev] [PATCH 3/3] net/i40e: implement device reset on port

[Zhao1, Wei]

Hi，Ferruh

> -Original Message-
> From: Yigit, Ferruh
> Sent: Wednesday, March 8, 2017 7:21 PM
> To: Zhao1, Wei ; dev@dpdk.org
> Cc: Lu, Wenzhuo 
> Subject: Re: [dpdk-dev] [PATCH 3/3] net/i40e: implement device reset on
> port
> 
> On 3/3/2017 4:56 AM, Wei Zhao wrote:
> > Implement the device reset function on vf port.
> > This restart function will detach device then attach device,
> > reconfigure dev, re-setup the Rx/Tx queues.
> >
> > Signed-off-by: Wei Zhao 
> > Signed-off-by: Wenzhuo Lu 
> 
> <...>
> 
> > +static int i40evf_dev_uninit(struct rte_eth_dev *eth_dev); static int
> > +i40evf_dev_init(struct rte_eth_dev *eth_dev); static void
> > +i40evf_dev_close(struct rte_eth_dev *dev); static int
> > +i40evf_dev_start(struct rte_eth_dev *dev); static int
> > +i40evf_dev_configure(struct rte_eth_dev *dev); static int
> > +i40evf_handle_vf_reset(struct rte_eth_dev *dev);
> 
> Some of them already seems declared, please avoid unnecessary or
> duplicate declarations.

Ok, I will delete useless function declaration in V2 patch.

> 
> > +
> >
> >  /* Default hash key buffer for RSS */  static uint32_t
> > rss_key_default[I40E_VFQF_HKEY_MAX_INDEX + 1]; @@ -230,6 +237,7
> @@
> > static const struct eth_dev_ops i40evf_eth_dev_ops = {
> > .rss_hash_conf_get= i40evf_dev_rss_hash_conf_get,
> > .mtu_set  = i40evf_dev_mtu_set,
> > .mac_addr_set = i40evf_set_default_mac_addr,
> > +   .dev_reset= i40evf_handle_vf_reset,
> >  };
> >
> >  /*
> > @@ -885,10 +893,13 @@ i40evf_add_mac_addr(struct rte_eth_dev *dev,
> > args.out_buffer = vf->aq_resp;
> > args.out_size = I40E_AQ_BUF_SZ;
> > err = i40evf_execute_vf_cmd(dev, &args);
> > -   if (err)
> > +   if (err) {
> > PMD_DRV_LOG(ERR, "fail to execute command "
> > "OP_ADD_ETHER_ADDRESS");
> > -
> > +   goto DONE;
> 
> Please prefer lowercase labels,
> also this is error exit, I would prefer other name than "done"

Ok, I will delete useless function declaration in V2 patch.

> 
> > +   }
> > +   vf->vsi.mac_num++;
> > +DONE:
> > return;
> >  }
> >
> 
> <...>
> 
> > +static int
> > +i40evf_handle_vf_reset(struct rte_eth_dev *dev) {
> > +   struct i40e_adapter *adapter =
> > +   I40E_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);
> > +
> > +   if (!dev->data->dev_started)
> > +   return 0;
> > +
> > +   adapter->reset_number = 1;
> > +   i40e_vf_reset_dev(dev);
> 
> What happens if user called this function for PF ?

This is an illegal operation, so I will may be add an check of whether it is vf 
 port,
if not , a return command to avoid  illegal operation.

> 
> > +   adapter->reset_number = 0;
> > +
> > +   return 0;
> > +}
> > +
> 
> <...>