> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Hunt, David > Subject: Re: [dpdk-dev] [PATCH v9 09/18] lib: add symbol versioning to > distributor > > On 10/3/2017 4:22 PM, Bruce Richardson wrote: > > On Mon, Mar 06, 2017 at 09:10:24AM +0000, David Hunt wrote: > >> Also bumped up the ABI version number in the Makefile > >> > >> Signed-off-by: David Hunt <david.h...@intel.com> > >> --- > >> lib/librte_distributor/Makefile | 2 +- > >> lib/librte_distributor/rte_distributor.c | 57 +++++++++++--- > >> lib/librte_distributor/rte_distributor_v1705.h | 89 > >> ++++++++++++++++++++++ > > A file named rte_distributor_v1705.h was added in patch 4, then deleted > > in patch 7, and now added again here. Seems a lot of churn. > > > > /Bruce > > > > The first introduction of this file is what will become the public > header. For successful compilation, > this cannot be called rte_distributor.h until the symbol versioning > patch, at which stage I will > rename the file, and introduce the symbol versioned header at the same > time. In the next patch > I'll rename this version of the files as rte_distributor_public.h to > make this clearer.
Suggestion to use rte_distributor_next.h instead of public? Public doesn't indicate if its old or new, while next would make that clearer IMO :)
