Re: Review Request 14335: CLOUDSTACK-4262: Fix TestVPCNetworkGc.test_01_wait_network_gc

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14335/#review26924
---


Commit 808b96070e17976f8ae7424b437713f329be7ac4 in branch refs/heads/4.2 from 
Girish Shilamkar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=808b960 ]

CLOUDSTACK-4262: Fix TestVPCNetworkGc.test_01_wait_network_gc

As per the test plan, after waiting for network gc
LB rules should be cleared. Added that check instead of router
being in stopped state.

Signed-off-by: venkataswamybabu budumuru 
(cherry picked from commit abdb84bb05abc9f2bd102bca1c1b34865f34d771)


- ASF Subversion and Git Services


On Oct. 7, 2013, 4:54 a.m., Girish Shilamkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14335/
> ---
> 
> (Updated Oct. 7, 2013, 4:54 a.m.)
> 
> 
> Review request for cloudstack, Harikrishna Patnala and venkata swamy babu  
> budumuru.
> 
> 
> Bugs: CLOUDSTACK-4262
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> As per the test plan, after waiting for network gc
> LB rules should be cleared. Added that check instead of router
> being in stopped state.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_vpc_network.py 970a625 
> 
> Diff: https://reviews.apache.org/r/14335/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Girish Shilamkar
> 
>

Re: Steps in building DEB packages for 4.2.0

[Prasanna Santhanam]

On Fri, Oct 11, 2013 at 09:59:52AM +0800, Indra Pramana wrote:
> Dear all,
> 
> I am reading the documentation on the steps in building DEB packages for
> CloudStack 4.2.0:
> 
> http://cloudstack.apache.org/docs/en-US/Apache_CloudStack/4.2.0/html/Installation_Guide/sect-source-builddebs.html
> 
> and compare it with the steps on the earlier version (e.g. 4.1.1):
> 
> http://cloudstack.apache.org/docs/en-US/Apache_CloudStack/4.1.1/html/Installation_Guide/sect-source-builddebs.html
> 
> I noticed that there's one command missing:
> 
> ===
> mvn clean install -P developer,systemvm
> ===
> 
> Can I confirm that the above step is no longer required for 4.2.0 and we
> can go ahead to build the package using the command: "dpkg-buildpackage -uc
> -us"?

Yes, dpkg-buildpackage will take care of the mvn bits as well for you.
It is not required. BTW, the list of debs generated also differs in
4.2 and that's now been corrected. So don't be alarmed if you see
different set of debs.

> 
> Looking forward to your reply, thank you.
> 
> Cheers.

-- 
Prasanna.,


Powered by BigRock.com

Re: bvt failure since on master

[Daan Hoogland]

The build (m/f)ails when the retrieval step doesn't work as well and
sure a lot of little other things besides the actual build. so you
really need to deep dive if the cause is not clear at first glance.

On Fri, Oct 11, 2013 at 8:08 AM, Laszlo Hornyak
 wrote:
> From jenkins.buildacloud.org I am getting notification on
> build-docs-niciranvp-master, also getting lots of emails from
> build.apache.org for master build.
> I would be absolutely interested anyway, but I do not see what is broken in
> the build.
>
>
> On Fri, Oct 11, 2013 at 6:21 AM, Prasanna Santhanam  wrote:
>
>> Can you tell me what job is doing that? I'm not sure which one is
>> emailing people. We shouldn't be emailing anything from
>> jenkins.buildacloud to individuals unless they ask to be.
>>
>> On Thu, Oct 10, 2013 at 07:00:27PM +0200, Laszlo Hornyak wrote:
>> > Hi,
>> >
>> > I am receiving tons of emails from jenkins about broken builds, but my
>> > local build is ok and no tests failing, Is this some environment issue?
>> >
>> >
>> >
>> >
>> > On Thu, Oct 10, 2013 at 5:51 PM, Prasanna Santhanam 
>> wrote:
>> >
>> > > Hi All - Looks like the server won't come up on master
>> > > (CLOUDSTACK-4848). It started happening since last night. Is this
>> > > something anyone else is seeing? I'm hitting it regularly on the test
>> > > environment. The DatabaseUpgradeChecker is complaining about a
>> > > duplicate column `size` in an upgrade script.
>> > >
>> > >
>> > >
>> > > --
>> > > Prasanna.,
>> > >
>> > > 
>> > > Powered by BigRock.com
>> > >
>> > >
>> >
>> >
>> > --
>> >
>> > EOF
>>
>> --
>> Prasanna.,
>>
>> 
>> Powered by BigRock.com
>>
>>
>
>
> --
>
> EOF

Re: Review Request 13701: Automation Tests for HA Proxy Stickiness

[Girish Shilamkar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13701/
---

(Updated Oct. 11, 2013, 7:23 a.m.)


Review request for cloudstack, suresh sadhu and Prasanna Santhanam.


Repository: cloudstack-git


Description
---

Automation Tests for HA Proxy Stickiness


Diffs (updated)
-

  test/integration/component/test_haproxy.py PRE-CREATION 

Diff: https://reviews.apache.org/r/13701/diff/


Testing (updated)
---

est_01_create_sticky_policy_default_values (test_haproxy.TestHAProxyStickyness)
Test Configure stickiness policies with default values ... ok
test_02_create_sticky_policy_custom_values (test_haproxy.TestHAProxyStickyness)
Test Configure stickiness policies with custom values ... ok
test_03_supported_policies_by_network (test_haproxy.TestHAProxyStickyness)
Test listnetworks response to check supported stickiness policies ... ok
test_04_delete_lb_rule (test_haproxy.TestHAProxyStickyness)
Test LB rule before/after stickiness policy creation ... ok
test_05_error_alerts_after_create (test_haproxy.TestHAProxyStickyness)
Test error/alerts after creating stickiness policy ... ok
test_06_release_ip (test_haproxy.TestHAProxyStickyness)
Test release public IP with stickiness policy ... ok
test_07_delete_account (test_haproxy.TestHAProxyStickyness)
Test Delete account  and check the router and its rules ... ok
test_08_create_policy_router_stopped (test_haproxy.TestHAProxyStickyness)
Test verify create stickiness policy when router is stopped state ... ok
test_09_create_policy_router_destroy (test_haproxy.TestHAProxyStickyness)
Test check the stickiness policy rules after destroying router ... ok
test_10_create_policy_enable_disable_vpn (test_haproxy.TestHAProxyStickyness)
Test enable/disable the VPN after applying sticky policy rules ... ok
test_11_invalid_params (test_haproxy.TestHAProxyStickyness)
Test verfify functionality syncronous and asyncronous validations ... ok

--
Ran 11 tests in 2154.059s

OK


Thanks,

Girish Shilamkar

Re: Review Request 14199: Adding missing test cases: Snapshots Improvement

[Gaurav Aradhye]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14199/
---

(Updated Oct. 11, 2013, 1:36 p.m.)


Review request for cloudstack and Prasanna Santhanam.


Changes
---

Review changes.


Repository: cloudstack-git


Description
---

Adding 5 missing test cases.
Change in asyncJobMgr.py >> the method "make_request" in cloudstackConnection 
does not exist now. Replaced it by "marvin_request". Checked running async jobs 
with this change. Works correctly.


Diffs (updated)
-

  test/integration/component/test_snapshots_improvement.py PRE-CREATION 
  tools/marvin/marvin/asyncJobMgr.py 25818a6 

Diff: https://reviews.apache.org/r/14199/diff/


Testing (updated)
---

Tested locally on KVM Advanced setup.

test_01_concurrent_snapshots_live_migrate 
(test_snapshots_improvement.TestCreateSnapshot)
Test perform concurrent snapshots and migrate the vm from one host ... ok
test_02_stop_vm_concurrent_snapshots 
(test_snapshots_improvement.TestCreateSnapshot)
Test stop running VM while performing concurrent snapshot on volume ... ok
test_03_concurrent_snapshots_create_template 
(test_snapshots_improvement.TestCreateSnapshot)
Test while parent concurrent snapshot job in progress,create ... ok
test_04_concurrent_snapshots_create_volume 
(test_snapshots_improvement.TestCreateSnapshot)
Test while parent concurrent snapshot job in progress,create volume ... ok
test_01_snapshot_on_rootVolume 
(test_snapshots_improvement.TestSnapshotOnRootVolume)
Test create VM with default cent os template and create snapshot ... ok

--
Ran 5 tests in 1420.575s

OK


Thanks,

Gaurav Aradhye

Re: Review Request 14199: Adding missing test cases: Snapshots Improvement

[Gaurav Aradhye]

> On Oct. 7, 2013, 10:48 p.m., Nitin Mehta wrote:
> >
> 
> Nitin Mehta wrote:
> It would be great if you could show logs of a sample run. Please also let 
> me know if all the 5 cases are tested as well

Log Added.


> On Oct. 7, 2013, 10:48 p.m., Nitin Mehta wrote:
> > test/integration/component/test_snapshots_improvement.py, line 628
> > 
> >
> > step 6 is happening before step 5

Changed the code so that both the steps now happen asynchronously.


- Gaurav


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14199/#review26715
---


On Sept. 18, 2013, 4:55 p.m., Gaurav Aradhye wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14199/
> ---
> 
> (Updated Sept. 18, 2013, 4:55 p.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Adding 5 missing test cases.
> Change in asyncJobMgr.py >> the method "make_request" in cloudstackConnection 
> does not exist now. Replaced it by "marvin_request". Checked running async 
> jobs with this change. Works correctly.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_snapshots_improvement.py PRE-CREATION 
>   tools/marvin/marvin/asyncJobMgr.py 25818a6 
> 
> Diff: https://reviews.apache.org/r/14199/diff/
> 
> 
> Testing
> ---
> 
> Tested locally.
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>

Why Secondarystroage resourcelimit contains volumes

[sx chen]

Hi,all:
In 4.2,We can limit the secondarystorage usage for a user or a domain.
But when I refer to source code ,I find

public long calculateSecondaryStorageForAccount(long accountId) {
long totalVolumesSize =
_volumeDao.secondaryStorageUsedForAccount(accountId);
long totalSnapshotsSize =
_snapshotDao.secondaryStorageUsedForAccount(accountId);
long totalTemplatesSize = 0;

SearchCriteria sc = templateSizeSearch.create();
sc.setParameters("downloadState", Status.DOWNLOADED);
sc.setParameters("destroyed", false);
sc.setJoinParameters("templates", "accountId", accountId);
List templates = _vmTemplateStoreDao.customSearch(sc,
null);
if (templates != null) {
totalTemplatesSize = templates.get(0).sum;
}

return totalVolumesSize + totalSnapshotsSize + totalTemplatesSize;
}

Templates and snapshots are certainly belong to secondarystorage,
The volumes which sql is :
select sum(size) from volumes where account_id=? and path is null and
removed is null and state not in ("ALLOCATED").

So my question is why volumes is counted as secondarystorage?

Re: Review Request 14557: CLOUDSTACK-4747: Rename testcase name to use lesser characters

[Girish Shilamkar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14557/
---

(Updated Oct. 11, 2013, 8:31 a.m.)


Review request for cloudstack, Sowmya Krishnan and SrikanteswaraRao Talluri.


Changes
---

Added Talluri 


Repository: cloudstack-git


Description
---

Renamed testcase name and also initialised _cleanup so that
it does not break on non-NS Cloudstack setup.


Diffs
-

  test/integration/component/test_netscaler_nw_off.py 3139257 

Diff: https://reviews.apache.org/r/14557/diff/


Testing
---


Thanks,

Girish Shilamkar

Cloudstack collab Hackathons

[Hugo Trippaers]

Hey Guys,

The CloudStack collaboration conference is right around the corner. The first 
day of the conference will be dedicated to workshops and a hackathon.

I'm curious which developers are planning to attend the hackthon and what 
subjects you are interested in. In Santa Clara we had a short list of some 
subjects to discuss and some tables and discussions were already prepared in 
advance. In the upcoming conference we can do the same, so if you have a 
discussion or project idea that you want to work on at the hackthon let us know 
with a reply in this thread.

I'm also curious if there are any aspiring developers that would like to have a 
sort of introduction into cloudstack development during the hackathon.

If you have any other ideas, just shout.

Cheers,

Hugo

Re: Cloudstack collab Hackathons

[Daan Hoogland]

https://cwiki.apache.org/confluence/display/CLOUDSTACK/CCC+Europe
contains a provisionary list. You can add there if you have wiki
access or ask in this thread as Hugo suggests.

On Fri, Oct 11, 2013 at 10:43 AM, Hugo Trippaers  wrote:
> Hey Guys,
>
> The CloudStack collaboration conference is right around the corner. The first 
> day of the conference will be dedicated to workshops and a hackathon.
>
> I'm curious which developers are planning to attend the hackthon and what 
> subjects you are interested in. In Santa Clara we had a short list of some 
> subjects to discuss and some tables and discussions were already prepared in 
> advance. In the upcoming conference we can do the same, so if you have a 
> discussion or project idea that you want to work on at the hackthon let us 
> know with a reply in this thread.
>
> I'm also curious if there are any aspiring developers that would like to have 
> a sort of introduction into cloudstack development during the hackathon.
>
> If you have any other ideas, just shout.
>
> Cheers,
>
> Hugo

Re: [PROPOSAL] Dynamic Compute Offering

[Bharat Kumar]

Hi All, 

Added the Function spec at 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Dynamic+Compute+Offering+FS
please go thorough this and give me your comments.

-Bharat.


On Sep 30, 2013, at 12:34 PM, Bharat Kumar  wrote:

> Hi All,
> 
> Currently in cloudstack we need to associate every vm with a service offering 
> and also we cannot specify the size of the root disk when using templates 
> i.e. we
> cannot specify different size of root disks while using the same template.
> 
> 
> I would like to propose a feature to allow VM creation without the need to 
> choose the fixed amount of compute mentioned in the pre created service 
> offerings. 
> Also allow users to specify the size of the root disk while using templates. 
> 
> users can specify their own compute requirements at the time of VM creation, 
> if they do not want to use fixed values in the pre created service offerings. 
> This is similar to the custom disk offering.
> 
> This will Allow
> 1.)  Admins to create service offerings by marking cpu, memory and root disk 
> as  dynamic parameters. 
> 2.)  users to use this dynamic service offering to specify the  memory, cpu 
> and root disk at the time of VM creation or upgrade.
> 3.)  Metering of these dynamically assigned resources for usage details. 
> 
> I have created a feature bug  for this.
> https://issues.apache.org/jira/browse/CLOUDSTACK-4738
> 
> Regards,
> Bharat. 
> 
> 
> 
> 
> 
> 

RE: Autoscaling

[Sowmya Krishnan]

Answer inline...

> -Original Message-
> From: Nguyen Anh Tu [mailto:ng.t...@gmail.com]
> Sent: Friday, October 11, 2013 12:14 PM
> To: dev@cloudstack.apache.org
> Subject: Re: Autoscaling
> 
> Dear Rajesh,
> 
> Apologize for delay in response.
> 
> You mean the netscaler api's used to create the autoscale functionality?
> >
> 
> Yes. And I just found a document about Netscaler config:
> http://support.citrix.com/proddocs/topic/ns-system-10-map/ns-autoscale-
> automatic-scaling-in-cloudplatform-env-wrapper-con.html
> more info from:
> http://support.citrix.com/servlet/KbServlet/download/30564-102-684000/NS-
> CommandReference-Guide.pdf
> 
> Also looking through Netscaler plugin implementation into ACS, I can 
> understand
> the operation.
> 
> Btw, I'm confusing about this points:
> 
> - When user change templateID in a AutoScale group, don't Netscaler call ACS 
> to
> destroy old VMs? Then, there are two type of VMs in that group: one with old
> template and one with new template. Is it right?
> 
When user changes template, Netscaler doesn't destroy VMs created with older 
template. VMs of both templates will co-exist in the autoscale group. 
Subsequent VMs that get created will use the new template. As long as the Scale 
down policy is not met, VMs won't be destroyed.

> Thanks,
> --
> 
> N.g.U.y.e.N.A.n.H.t.U

Re: [DISCUSS] Leaky abstractions [was review requests 13238, 13896, 14320]

[Daan Hoogland]

Having thought about the more generic issue with 'leaky abstractions'
a little more I would like to add the reverse of my scenario to the
discussion.

all implementers of a flutch have a feature Y so we implement an
option in our interface. Now the one of them (or a new kid on the
block) solves the problem that this option is for in a totally
different way. Their solution slowly becomes commonplace but only
slowly and one of the big players, producer of implementation a,
doesn't go for this solution. How do we migrate from generic option to
a key/value pair that only the provider/element/guru for an a
understands?

regards,
Daan

On Sat, Oct 5, 2013 at 11:28 AM, Daan Hoogland  wrote:
> H Chiradeep,
>
> I am hesitating to keep on about my case of httpClose as this is about the
> more general subject you gave this thread, so please take my referals to it
> as examples.
>
> so it is in a sense keepAlive (formerly known as ! httpClose) we are talking
> about. Then there is a matter of how to implement it as I understand you
> have objections to the part where it is in the networkoffering. Let's take
> that back to the review thread, alright?
>
> Remains the question of the new feature X that will be common good in next
> generations. How art we dealing with that?
>
> And in this case maybe X is default for most but !X is default for
> implementation c. To that I'd say implement the options as and take the
> default from the largest group of implementations. In httpClose you could
> think of default is to keepAlive. I didn't do this to remain backwards
> compatible. If that is not a problem I think the engineers at Schuberg
> Philis can live with a change of hardcoded settings. I don't like that,
> hence my implementation.
>
> regards,
> Daan
>
>
> On Sat, Oct 5, 2013 at 12:56 AM, Chiradeep Vittal
>  wrote:
>>
>> I've checked the Netscaler and HAProxy docs, this appears to be artifact
>> of the HAProxy implementation (inability to support keep-alive).
>> For a cloud operator that chooses Netscaler or F5 for load balancing, this
>> won't make any sense.
>>
>> On 10/3/13 12:55 PM, "Daan Hoogland"  wrote:
>>
>> >On Thu, Oct 3, 2013 at 9:02 PM, Chip Childers
>> >wrote:
>> >
>> >> a model for extensions like that makes perfect sense.
>> >
>> >
>> >
>> >This model sound fine indeed. It makes no sense for httpClose however.
>> >
>> >Here's my concern:
>> >So when an early adapter is implemented and the rest of the market comes
>> >to
>> >their senses, how do we migrate without running into migration/upgrade
>> >problems?
>> >httpClose is a flag controlling connection pooling. I probably choose the
>> >wrong name. It is something that any implementation will support or
>> > should
>> >have supported already. Am I going to implement it as a key/value now to
>> >later implemented as I have done anyway? I don't like this idea.
>> >
>> >Don't get me wrong the pattern described by you guys is fine in some
>> >situations. I don't think it is applicable to this feature.
>> >
>> >regards,
>> >Daan
>>
>

RE: Autoscaling

[Nguyen Anh Tu]

Got it. Thanks Sowmya.

Sent from my GT-N7000
On Oct 11, 2013 4:51 PM, "Sowmya Krishnan" 
wrote:

> Answer inline...
>
> > -Original Message-
> > From: Nguyen Anh Tu [mailto:ng.t...@gmail.com]
> > Sent: Friday, October 11, 2013 12:14 PM
> > To: dev@cloudstack.apache.org
> > Subject: Re: Autoscaling
> >
> > Dear Rajesh,
> >
> > Apologize for delay in response.
> >
> > You mean the netscaler api's used to create the autoscale functionality?
> > >
> >
> > Yes. And I just found a document about Netscaler config:
> > http://support.citrix.com/proddocs/topic/ns-system-10-map/ns-autoscale-
> > automatic-scaling-in-cloudplatform-env-wrapper-con.html
> > more info from:
> >
> http://support.citrix.com/servlet/KbServlet/download/30564-102-684000/NS-
> > CommandReference-Guide.pdf
> >
> > Also looking through Netscaler plugin implementation into ACS, I can
> understand
> > the operation.
> >
> > Btw, I'm confusing about this points:
> >
> > - When user change templateID in a AutoScale group, don't Netscaler call
> ACS to
> > destroy old VMs? Then, there are two type of VMs in that group: one with
> old
> > template and one with new template. Is it right?
> >
> When user changes template, Netscaler doesn't destroy VMs created with
> older template. VMs of both templates will co-exist in the autoscale group.
> Subsequent VMs that get created will use the new template. As long as the
> Scale down policy is not met, VMs won't be destroyed.
>
> > Thanks,
> > --
> >
> > N.g.U.y.e.N.A.n.H.t.U
>

Review Request 14591: Fixng the issue of wrong netmask value is allowed in public traffic wizard while creating a zone

[Damodar Reddy Talakanti]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14591/
---

Review request for cloudstack, Abhinandan Prateek, Jayapal Reddy, and Murali 
Reddy.


Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-4811


Repository: cloudstack-git


Description
---

The UI Wizard was allowing Invalid CIDR in public traffic page while creating a 
zone and back end was also not checking the correctness of the CIDR before 
creating a zone.


Diffs
-

  server/src/com/cloud/configuration/ConfigurationManagerImpl.java b09b8ca 
  utils/pom.xml f4ac12b 
  utils/src/com/cloud/utils/net/NetUtils.java 05b485b 

Diff: https://reviews.apache.org/r/14591/diff/


Testing
---

Testing is done through UI
For Example : Given wrong NetMask value 255.255.25.0 which is wrong net mask 
value
  Given Gateway as 10.147.30.1 and  NetMask as 255.255.255.192 and 
public IP Range as 10.147.30.150-10.147.30.159..which is a wrong ip range for 
the given gateway and net mask values.


Thanks,

Damodar Reddy Talakanti

Re: Review Request 14591: Fixng the issue of wrong netmask value is allowed in public traffic wizard while creating a zone

[Jayapal Reddy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14591/#review26926
---



server/src/com/cloud/configuration/ConfigurationManagerImpl.java


Please remove white spaces



utils/src/com/cloud/utils/net/NetUtils.java


Please remove white spaces


- Jayapal Reddy


On Oct. 11, 2013, 10:07 a.m., Damodar Reddy Talakanti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14591/
> ---
> 
> (Updated Oct. 11, 2013, 10:07 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek, Jayapal Reddy, and Murali 
> Reddy.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-4811
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> The UI Wizard was allowing Invalid CIDR in public traffic page while creating 
> a zone and back end was also not checking the correctness of the CIDR before 
> creating a zone.
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/configuration/ConfigurationManagerImpl.java b09b8ca 
>   utils/pom.xml f4ac12b 
>   utils/src/com/cloud/utils/net/NetUtils.java 05b485b 
> 
> Diff: https://reviews.apache.org/r/14591/diff/
> 
> 
> Testing
> ---
> 
> Testing is done through UI
> For Example : Given wrong NetMask value 255.255.25.0 which is wrong net mask 
> value
>   Given Gateway as 10.147.30.1 and  NetMask as 255.255.255.192 
> and public IP Range as 10.147.30.150-10.147.30.159..which is a wrong ip range 
> for the given gateway and net mask values.
> 
> 
> Thanks,
> 
> Damodar Reddy Talakanti
> 
>

Re: Review Request 13701: Automation Tests for HA Proxy Stickiness

[suresh sadhu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13701/#review26927
---

Ship it!


patch looks ok

- suresh sadhu


On Oct. 11, 2013, 7:23 a.m., Girish Shilamkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13701/
> ---
> 
> (Updated Oct. 11, 2013, 7:23 a.m.)
> 
> 
> Review request for cloudstack, suresh sadhu and Prasanna Santhanam.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Automation Tests for HA Proxy Stickiness
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_haproxy.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/13701/diff/
> 
> 
> Testing
> ---
> 
> est_01_create_sticky_policy_default_values 
> (test_haproxy.TestHAProxyStickyness)
> Test Configure stickiness policies with default values ... ok
> test_02_create_sticky_policy_custom_values 
> (test_haproxy.TestHAProxyStickyness)
> Test Configure stickiness policies with custom values ... ok
> test_03_supported_policies_by_network (test_haproxy.TestHAProxyStickyness)
> Test listnetworks response to check supported stickiness policies ... ok
> test_04_delete_lb_rule (test_haproxy.TestHAProxyStickyness)
> Test LB rule before/after stickiness policy creation ... ok
> test_05_error_alerts_after_create (test_haproxy.TestHAProxyStickyness)
> Test error/alerts after creating stickiness policy ... ok
> test_06_release_ip (test_haproxy.TestHAProxyStickyness)
> Test release public IP with stickiness policy ... ok
> test_07_delete_account (test_haproxy.TestHAProxyStickyness)
> Test Delete account  and check the router and its rules ... ok
> test_08_create_policy_router_stopped (test_haproxy.TestHAProxyStickyness)
> Test verify create stickiness policy when router is stopped state ... ok
> test_09_create_policy_router_destroy (test_haproxy.TestHAProxyStickyness)
> Test check the stickiness policy rules after destroying router ... ok
> test_10_create_policy_enable_disable_vpn (test_haproxy.TestHAProxyStickyness)
> Test enable/disable the VPN after applying sticky policy rules ... ok
> test_11_invalid_params (test_haproxy.TestHAProxyStickyness)
> Test verfify functionality syncronous and asyncronous validations ... ok
> 
> --
> Ran 11 tests in 2154.059s
> 
> OK
> 
> 
> Thanks,
> 
> Girish Shilamkar
> 
>

Re: marvin create network offering incomplete?

[Daan Hoogland]

H Prasanna,

I didn't get around to it and forgot about this.

   def createNiciraNetworkOffering(self, conn) :
  cno = createNetworkOffering.createNetworkOfferingCmd()
  cno.name = "NiciraNvpL2NoLB_" + str(random.randrange(1, 400, 1))
  cno.displaytext = "offering with Nicira NVP L2 without Lb"
  cno.traffictype = "GUEST"
  cno.specifyvlan = False
  cno.specifyipranges = False
  cno.availability = "Optional"
  cno.conservemode = False
  cno.guestiptype = "Isolated"
  cno.supportedservices = [ "UserData", "PortForwarding",
"Dhcp", "Vpn", "Dns", "SourceNat",
"Connectivity", "StaticNat", "Firewall" ]
  cno.serviceproviderlist = [ { "service": "UserData", "provider":
"VirtualRouter"},
  { "service": "PortForwarding",
"provider": "VirtualRouter"},
  { "service": "Dhcp", "provider":
"VirtualRouter"},
  { "service": "Vpn", "provider":
"VirtualRouter"},
  { "service": "Dns", "provider":
"VirtualRouter"},
  { "service": "SourceNat",
"provider": "VirtualRouter"},
  { "service": "StaticNat",
"provider": "VirtualRouter"},
  { "service": "Firewall", "provider":
"VirtualRouter"},
  { "service": "Connectivity",
"provider": "NiciraNVP"} ]
  cno.servicecapabilitylist = [ { "service": "SourceNat",
"capabilitytype": "SupportedSourceNatTypes", "capabilityvalue":
"peraccount" } ]
  cno.tags = [ "nicira-based" ]
  cno.maxconnections = 29
  cno.httpcloseenabled = False
  #cno.networkrate
  #cno.serviceofferingid

  resp = conn.marvin_request(cno)

  #
  # Enabled the network offering
  #
  uno = updateNetworkOffering.updateNetworkOfferingCmd()
  uno.id = resp.networkoffering.id
  uno.state = "Enabled"
  resp = conn.marvin_request(uno)
  return resp.networkoffering.id

I simplified the example in the bvt I want created. The point is that
I have two guest networks. One with vlan implementation and one nicira
based. I think that in the translation from the json like dictonary to
an actual api call something goes wrong.
As it seems the conserve mode is not translated either.

will keep you posted,
Daan

On Tue, Oct 8, 2013 at 6:52 PM, Daan Hoogland  wrote:
> I've used marvin without the testdata construct fine. never the ui. I'll
> lookup the code once back at desk. Next afternoon
> Thanks Prassana (formerly known as Prussia, almost called Praag by the
> spellchecker )
>
> mobile biligual spell checker used
>
> Op 8 okt. 2013 16:01 schreef "Prasanna Santhanam" :
>
>> On Tue, Oct 08, 2013 at 03:27:10PM +0200, Daan Hoogland wrote:
>> > H,
>> >
>> > I am building an integration test with marvin and the following data:
>> >
>> > "network_offering": {
>> > "name": 'Test Network offering',
>> > "displaytext": 'Test Network offering',
>> > "guestiptype": 'Isolated',
>> > "supportedservices": 'Connectivity',
>> > "traffictype": 'GUEST',
>> > "availability": 'Optional',
>> > "specifyvlan": False,
>> > "specifyipranges": False,
>> > "serviceproviderlist": {
>> > "Connectivity": "NiciraNVP"
>> > },
>> > "conservemode": False,
>> > "tags": [ "nicira-based" ]
>> > },
>>
>> This looks fine.
>>
>> > "network": {
>> > "name": "Test Network",
>> > "displaytext": "Test Network",
>> > "tags": "nicira-based"
>> > },
>> >  in the code I put:
>> > self.network_offering = NetworkOffering.create(
>> > self.apiclient,
>> > self.testdata["network_offering"]
>> > )
>> > # Enable Network offering
>> > self.network_offering.update(self.apiclient, state='Enabled')
>> > self.testdata["network"]["zoneid"] = self.zone.id
>> > self.testdata["network"]["networkoffering"] =
>> > self.network_offering.id
>> > self.network = Network.create(
>> > self.apiclient,
>> > self.testdata["network"]
>> > )
>> > The network doesn't get created:
>> >  431, errorText:More than one physical networks exist in zone id=1 and
>> > no
>> > tags are specified in order to make a choice
>> >
>> > When inspecting indeed the tags are not set on the offering and neither
>> > is
>> > conservemode.
>>
>> Is that a resource-tag for the network offering? What is the API
>> request that is going to the management server from marvin? How does
>> it compare against what you sent through via the UI?
>>
>> >
>> > Am I hunting a bug ar did I misconfigure my test?
>>
>> I'm n

[ASF4.2.1] Milestones

[Abhinandan Prateek]

After looking at various other releases and the volume of important tickets the 
4.2.1 GA should happen on 15 Nov. Following are the important milestones:

25th October: Code complete, all the fixes should be in by this date to make it 
to maintenance release. As of now all Blockers and Criticals marked for 4.2.1 
are under consideration. Any other ticket that is critical enough to be 
included should be conveyed to me so that I can have it included in 4.2.1.

7th November: Release Candidate

14th November: GA

Please, comment if they are inline with the expectations. We will be freezing 
these milestones by 15 October.

-abhi

Release Wiki: 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Cloudstack+4.2.1+Maintenance+Release

Re: Review Request 14591: Fixng the issue of wrong netmask value is allowed in public traffic wizard while creating a zone

[Damodar Reddy Talakanti]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14591/
---

(Updated Oct. 11, 2013, 10:48 a.m.)


Review request for cloudstack, Abhinandan Prateek, Jayapal Reddy, and Murali 
Reddy.


Changes
---

Remvoed the extra spaces in new line


Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-4811


Repository: cloudstack-git


Description
---

The UI Wizard was allowing Invalid CIDR in public traffic page while creating a 
zone and back end was also not checking the correctness of the CIDR before 
creating a zone.


Diffs (updated)
-

  server/src/com/cloud/configuration/ConfigurationManagerImpl.java b09b8ca 
  utils/pom.xml f4ac12b 
  utils/src/com/cloud/utils/net/NetUtils.java 05b485b 

Diff: https://reviews.apache.org/r/14591/diff/


Testing
---

Testing is done through UI
For Example : Given wrong NetMask value 255.255.25.0 which is wrong net mask 
value
  Given Gateway as 10.147.30.1 and  NetMask as 255.255.255.192 and 
public IP Range as 10.147.30.150-10.147.30.159..which is a wrong ip range for 
the given gateway and net mask values.


Thanks,

Damodar Reddy Talakanti

Re: Review Request 14591: Fixng the issue of wrong netmask value is allowed in public traffic wizard while creating a zone

[Damodar Reddy Talakanti]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14591/
---

(Updated Oct. 11, 2013, 10:53 a.m.)


Review request for cloudstack, Abhinandan Prateek, Jayapal Reddy, and Murali 
Reddy.


Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-4811


Repository: cloudstack-git


Description
---

The UI Wizard was allowing Invalid CIDR in public traffic page while creating a 
zone and back end was also not checking the correctness of the CIDR before 
creating a zone.


Diffs (updated)
-

  server/src/com/cloud/configuration/ConfigurationManagerImpl.java b09b8ca 
  utils/pom.xml f4ac12b 
  utils/src/com/cloud/utils/net/NetUtils.java 05b485b 

Diff: https://reviews.apache.org/r/14591/diff/


Testing
---

Testing is done through UI
For Example : Given wrong NetMask value 255.255.25.0 which is wrong net mask 
value
  Given Gateway as 10.147.30.1 and  NetMask as 255.255.255.192 and 
public IP Range as 10.147.30.150-10.147.30.159..which is a wrong ip range for 
the given gateway and net mask values.


Thanks,

Damodar Reddy Talakanti

Error creating bean in master branch

[Nguyen Anh Tu]

Hi guys,

I'm trying to add a new table to DB in master branch. I added the new bean
to applicationContext.xml as below:

  
  

  **

  
  
  

Build success. However, exception is generated when running:

ERROR [o.s.w.c.ContextLoader] (main:null) Context initialization failed
org.springframework.beans.factory.BeanCreationException: Error creating
bean with name 'autoScaleVmGroupVmMapDaoImpl' defined in class path
resource [applicationContext.xml]: BeanPostProcessor before instantiation
of bean failed; nested exception is
net.sf.cglib.core.CodeGenerationException:
java.lang.ArrayIndexOutOfBoundsException-->-1
at
org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:452)
at
org.springframework.beans.factory.support.AbstractBeanFactory$1.getObject(AbstractBeanFactory.java:294)

Thanks for help,

-- 

N.g.U.y.e.N.A.n.H.t.U

Re: Review Request 14320: add boolean option keepAliveEnabled to the network offering for use in haproxy conf

[daan Hoogland]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14320/
---

(Updated Oct. 11, 2013, 11:23 a.m.)


Review request for cloudstack, Chiradeep Vittal and Wei Zhou.


Changes
---

summary and description changed


Summary (updated)
-

add boolean option keepAliveEnabled to the network offering for use in haproxy 
conf


Bugs: CLOUDSTACK-4328


Repository: cloudstack-git


Description (updated)
---

add boolean option keepAliveEnabled to the network offering for use in haproxy 
conf. It should have no consequence for any of the supported hardware 
loadbalncers.


Diffs
-

  api/src/com/cloud/offering/NetworkOffering.java 6c5573e 
  api/src/org/apache/cloudstack/api/ApiConstants.java f85784b 
  
api/src/org/apache/cloudstack/api/command/admin/network/CreateNetworkOfferingCmd.java
 bdad904 
  
api/src/org/apache/cloudstack/api/command/admin/network/UpdateNetworkOfferingCmd.java
 c9c4c8a 
  core/src/com/cloud/agent/api/routing/LoadBalancerConfigCommand.java ee29290 
  core/src/com/cloud/network/HAProxyConfigurator.java 2309125 
  core/test/com/cloud/network/HAProxyConfiguratorTest.java PRE-CREATION 
  engine/components-api/src/com/cloud/configuration/ConfigurationManager.java 
5e1b9b5 
  
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
 3c4b1ed 
  engine/schema/src/com/cloud/offerings/NetworkOfferingVO.java eefdc94 
  
plugins/network-elements/elastic-loadbalancer/src/com/cloud/network/lb/ElasticLoadBalancerManagerImpl.java
 3f8fc5c 
  
plugins/network-elements/internal-loadbalancer/src/org/apache/cloudstack/network/lb/InternalLoadBalancerVMManagerImpl.java
 5da6e02 
  server/src/com/cloud/configuration/ConfigurationManagerImpl.java 4fda3b1 
  server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 
5ea7560 
  server/test/com/cloud/vpc/MockConfigurationManagerImpl.java c9a0480 
  
server/test/org/apache/cloudstack/networkoffering/CreateNetworkOfferingTest.java
 1f1fb75 
  setup/db/db/schema-420to430.sql a765189 

Diff: https://reviews.apache.org/r/14320/diff/


Testing
---

created unit test.
instantiated a network with some loadbalancer rule based on a netoffer with the 
option to true/false and maxconnections to a non default value -> checked 
haproxy.cfg on the router


Thanks,

daan Hoogland

review of keepalive

[Daan Hoogland]

H Chriradeep,

Can you have a look at https://reviews.apache.org/r/14320/

I'm looking to commit it next week

regards,
Daan

Review Request 14593: CLOUDSTACK-1833: AUtomation - Adding scale virtual machine test cases

[Gaurav Aradhye]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14593/
---

Review request for cloudstack, Nitin Mehta and SrikanteswaraRao Talluri.


Repository: cloudstack-git


Description
---

Some of the basic P1 test cases for scaling up CPU and RAM for running VMs.
More tests to be added on top of this - in progress.

DDT library needed to run the test case.
It can be installed with pip install ddt command.


Diffs
-

  test/integration/component/test_scale_vm.py PRE-CREATION 
  tools/marvin/marvin/integration/lib/base.py 0d52224 
  tools/marvin/marvin/integration/lib/common.py 164ef20 

Diff: https://reviews.apache.org/r/14593/diff/


Testing
---

Tested on XenServer. Not attaching logs because different test cases were run 
at different time, not all at once.
All test cases running on XenServer, if at all needed, will add log after 
running them once again.


Thanks,

Gaurav Aradhye

Review Request 14595: Adding https support to marvin

[Santhosh Edukulla]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14595/
---

Review request for cloudstack.


Bugs: 4832


Repository: cloudstack-git


Description
---

adding support to marvin for https. We will allow user to specify whether to 
usehttps or not using three params


useHttps, certCAPath, certPath - the params are self explanatory


Diffs
-

  setup/dev/advanced.cfg 4a48399 
  tools/marvin/marvin/cloudstackConnection.py 686c533 
  tools/marvin/marvin/cloudstackTestClient.py 36f7f8d 
  tools/marvin/marvin/configGenerator.py a966ae0 
  tools/marvin/marvin/deployDataCenter.py beed8c8 

Diff: https://reviews.apache.org/r/14595/diff/


Testing
---


Thanks,

Santhosh Edukulla

Re: Review Request 14595: Adding https support to marvin

[Santhosh Edukulla]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14595/
---

(Updated Oct. 11, 2013, 12:51 p.m.)


Review request for cloudstack, daan Hoogland and Prasanna Santhanam.


Changes
---

adding Dahn and Prasanna


Bugs: 4832


Repository: cloudstack-git


Description
---

adding support to marvin for https. We will allow user to specify whether to 
usehttps or not using three params


useHttps, certCAPath, certPath - the params are self explanatory


Diffs
-

  setup/dev/advanced.cfg 4a48399 
  tools/marvin/marvin/cloudstackConnection.py 686c533 
  tools/marvin/marvin/cloudstackTestClient.py 36f7f8d 
  tools/marvin/marvin/configGenerator.py a966ae0 
  tools/marvin/marvin/deployDataCenter.py beed8c8 

Diff: https://reviews.apache.org/r/14595/diff/


Testing (updated)
---

Tested against http. Setting up https environment for testing. Will appreciate 
a test if anyone has https enabled on their setup


Thanks,

Santhosh Edukulla

Re: [New Feature FS] SSL Offload Support for Cloudstack

[Murali Reddy]

On 09/10/13 8:08 PM, "Syed Ahmed"  wrote:

>Thanks Murali for your response.
>
>> - any reason why you choose assignTo/RemoveFrom load balancer rule API's
>
>I thought this made more sense than create/updateLoadbalancerRule as
>we would have to call update to delete a cert which I find somewhat
>confusing. Also this is semantically similar to attaching instances as
>in you have a separate entity which is being bound to different LBs.

We will be just overloading the assignTo/RemoveFrom load balancer rule
API's for associate/dis-associte certificate with load balancer rule. IMO,
its better we introduce new api's say
registerCertifcateToLoadbalancer/deregisterCertifcateToLoadbalancer than
force fit existing API's for associate/dis-associate certificates.

>
>> - to me SSL termination is value added service from providers
>>perspective,
>> So only if network offering permits, SSL termination can be used.
>
>Got it. This seems the logical way. Good point.

On second thought may be an CloudStack usage event on assigning
certificate seems good enough to me.

>
>Would it be a good Idea to add protocol to the createLoadBalancer API.
>I think this makes sense in the long run as currently I cannot create
>a HTTP loadbalncer for port 8080 from cloudstack.

Yes, its good we introduce protocol in the API, and make it optional
parameter. Currently CloudStack marks protocol as TCP by default and load
balancer implementation layer corresponding to HAProxy, F5, NetScaler we
are inferring protocol from the ports. So on upgrade just ensure we don't
break backward compatibility of the existing load balancer rules.

Re: Cloudstack collab Hackathons

[Mike Tutkowski]

I plan on attending the hackathon.

I expect to be participating in the automated testing discussion since I'd
like to develop tests for the SolidFire plug-in I built and continue to
enhance (and see how I can leverage a SAN in my lab for these tests and
still have the tests kicked off in response to certain check-ins, etc.).


On Fri, Oct 11, 2013 at 2:46 AM, Daan Hoogland wrote:

> https://cwiki.apache.org/confluence/display/CLOUDSTACK/CCC+Europe
> contains a provisionary list. You can add there if you have wiki
> access or ask in this thread as Hugo suggests.
>
> On Fri, Oct 11, 2013 at 10:43 AM, Hugo Trippaers 
> wrote:
> > Hey Guys,
> >
> > The CloudStack collaboration conference is right around the corner. The
> first day of the conference will be dedicated to workshops and a hackathon.
> >
> > I'm curious which developers are planning to attend the hackthon and
> what subjects you are interested in. In Santa Clara we had a short list of
> some subjects to discuss and some tables and discussions were already
> prepared in advance. In the upcoming conference we can do the same, so if
> you have a discussion or project idea that you want to work on at the
> hackthon let us know with a reply in this thread.
> >
> > I'm also curious if there are any aspiring developers that would like to
> have a sort of introduction into cloudstack development during the
> hackathon.
> >
> > If you have any other ideas, just shout.
> >
> > Cheers,
> >
> > Hugo
>



-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloud
*™*

KVM systemvm not getting IP

[Francois Gaudreault]

Anyone faced an issue where the KVM system VM doesn't set IPs on the 
network interfaces? In fact there is no interfaces definitions in 
/etc/network/interfaces.


I am using CS 4.2. I re-installed my host to use Ubuntu 13.04 (I have 
the same behavior on CentOS 6).


--
Francois Gaudreault
Architecte de Solution Cloud | Cloud Solutions Architect
fgaudrea...@cloudops.com
514-629-6775
- - -
CloudOps
420 rue Guy
Montréal QC  H3J 1S6
www.cloudops.com
@CloudOps_

Review Request 14589: fix volume creation failure bug

[Yoshikazu Nojima]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14589/
---

Review request for cloudstack.


Repository: cloudstack-git


Description
---

This patch fixes volume creation failure bug.
The bug happens when I try to create a volume. It throws the error 'volume size 
, but the maximum size allowed is 0 Gb.' when I attempt to create a new 
volume.

I add and moved few code to load custom.diskoffering.size.min, 
custom.diskoffering.size.max, and storage.max.volume.size to make volume 
creation feature work properly.


Diffs
-

  server/src/com/cloud/storage/VolumeApiServiceImpl.java faff10f 

Diff: https://reviews.apache.org/r/14589/diff/


Testing
---

add and attach a new volume from CloudStack GUI.


Thanks,

Yoshikazu Nojima

Re: [New Feature FS] SSL Offload Support for Cloudstack

[Syed Ahmed]

Thanks for your valuable feedback Murali. Here are my comments.


IMO,
its better we introduce new api's say
registerCertifcateToLoadbalancer/deregisterCertifcateToLoadbalancer than
force fit existing API's for associate/dis-associate certificates.


Personally, I was going to do it this way. But I am not sure how good 
of an idea it is to add a new api just for this feature as I can see 
assignToLoadbalancer is semantically similar. But if everyone agrees I 
have no problem with it.



On second thought may be an CloudStack usage event on assigning
certificate seems good enough to me.


So what I got from your earlier post was that when adding a  network 
offering the provider can choose to enable SSL Termination or not as it 
is a value added service. I was thinking of adding "SSL termination" 
under supportedservices for the  createNetworkOffering API call. And 
when someone calls the API to assign a cert to LB we can check if this 
network offering has SSL termination enabled. Does this make sense?


Also when you say usage event, what does this imply? I am sorry I am 
not familiar with that term. Can you please elaborate.


Thanks
-Syed

On Fri 11 Oct 2013 09:03:45 AM EDT, Murali Reddy wrote:

On 09/10/13 8:08 PM, "Syed Ahmed"  wrote:


Thanks Murali for your response.


- any reason why you choose assignTo/RemoveFrom load balancer rule API's


I thought this made more sense than create/updateLoadbalancerRule as
we would have to call update to delete a cert which I find somewhat
confusing. Also this is semantically similar to attaching instances as
in you have a separate entity which is being bound to different LBs.


We will be just overloading the assignTo/RemoveFrom load balancer rule
API's for associate/dis-associte certificate with load balancer rule.




- to me SSL termination is value added service from providers
perspective,
So only if network offering permits, SSL termination can be used.


Got it. This seems the logical way. Good point.


On second thought may be an CloudStack usage event on assigning
certificate seems good enough to me.



Would it be a good Idea to add protocol to the createLoadBalancer API.
I think this makes sense in the long run as currently I cannot create
a HTTP loadbalncer for port 8080 from cloudstack.


Yes, its good we introduce protocol in the API, and make it optional
parameter. Currently CloudStack marks protocol as TCP by default and load
balancer implementation layer corresponding to HAProxy, F5, NetScaler we
are inferring protocol from the ports. So on upgrade just ensure we don't
break backward compatibility of the existing load balancer rules.

RE: KVM systemvm not getting IP

[Rajesh Battala]

Hi Francois, 
Are you using the new systemvm template. 
System vm's ip's info (boot args) are passed via socket in 4.2. Please check 
whether you are using new or old systemvm template. 

Thanks
Rajesh Battala

-Original Message-
From: Francois Gaudreault [mailto:fgaudrea...@cloudops.com] 
Sent: Friday, October 11, 2013 8:30 PM
To: dev@cloudstack.apache.org
Subject: KVM systemvm not getting IP

Anyone faced an issue where the KVM system VM doesn't set IPs on the network 
interfaces? In fact there is no interfaces definitions in 
/etc/network/interfaces.

I am using CS 4.2. I re-installed my host to use Ubuntu 13.04 (I have the same 
behavior on CentOS 6).

--
Francois Gaudreault
Architecte de Solution Cloud | Cloud Solutions Architect 
fgaudrea...@cloudops.com
514-629-6775
- - -
CloudOps
420 rue Guy
Montréal QC  H3J 1S6
www.cloudops.com
@CloudOps_

Re: KVM systemvm not getting IP

[Francois Gaudreault]

Hmm... How do I know if I am using the old or new :P

I downloaded this one:
http://download.cloud.com/templates/acton/acton-systemvm-02062012.qcow2.bz2

FG

On 10/11/2013, 12:12 PM, Rajesh Battala wrote:

Hi Francois,
Are you using the new systemvm template.
System vm's ip's info (boot args) are passed via socket in 4.2. Please check 
whether you are using new or old systemvm template.

Thanks
Rajesh Battala

-Original Message-
From: Francois Gaudreault [mailto:fgaudrea...@cloudops.com]
Sent: Friday, October 11, 2013 8:30 PM
To: dev@cloudstack.apache.org
Subject: KVM systemvm not getting IP

Anyone faced an issue where the KVM system VM doesn't set IPs on the network 
interfaces? In fact there is no interfaces definitions in 
/etc/network/interfaces.

I am using CS 4.2. I re-installed my host to use Ubuntu 13.04 (I have the same 
behavior on CentOS 6).

--
Francois Gaudreault
Architecte de Solution Cloud | Cloud Solutions Architect 
fgaudrea...@cloudops.com
514-629-6775
- - -
CloudOps
420 rue Guy
Montréal QC  H3J 1S6
www.cloudops.com
@CloudOps_






--
Francois Gaudreault
Architecte de Solution Cloud | Cloud Solutions Architect
fgaudrea...@cloudops.com
514-629-6775
- - -
CloudOps
420 rue Guy
Montréal QC  H3J 1S6
www.cloudops.com
@CloudOps_

Re: KVM systemvm not getting IP

[Kelcey Jamison Damage]

That is the old template and won't work with 4.2 

You can follow one of the methods in 
http://cloud.kelceydamage.com/cloudfire/blog/2013/10/08/conquering-the-cloudstack-4-2-dragon-kvm/
 if you wish to recover your cloud, or you can simply use the updated template 
link posted and start over again. 

Thanks. 

-Kelcey 

- Original Message -

From: "Francois Gaudreault"  
To: dev@cloudstack.apache.org 
Sent: Friday, October 11, 2013 9:17:43 AM 
Subject: Re: KVM systemvm not getting IP 

Hmm... How do I know if I am using the old or new :P 

I downloaded this one: 
http://download.cloud.com/templates/acton/acton-systemvm-02062012.qcow2.bz2 

FG 

On 10/11/2013, 12:12 PM, Rajesh Battala wrote: 
> Hi Francois, 
> Are you using the new systemvm template. 
> System vm's ip's info (boot args) are passed via socket in 4.2. Please check 
> whether you are using new or old systemvm template. 
> 
> Thanks 
> Rajesh Battala 
> 
> -Original Message- 
> From: Francois Gaudreault [mailto:fgaudrea...@cloudops.com] 
> Sent: Friday, October 11, 2013 8:30 PM 
> To: dev@cloudstack.apache.org 
> Subject: KVM systemvm not getting IP 
> 
> Anyone faced an issue where the KVM system VM doesn't set IPs on the network 
> interfaces? In fact there is no interfaces definitions in 
> /etc/network/interfaces. 
> 
> I am using CS 4.2. I re-installed my host to use Ubuntu 13.04 (I have the 
> same behavior on CentOS 6). 
> 
> -- 
> Francois Gaudreault 
> Architecte de Solution Cloud | Cloud Solutions Architect 
> fgaudrea...@cloudops.com 
> 514-629-6775 
> - - - 
> CloudOps 
> 420 rue Guy 
> Montréal QC H3J 1S6 
> www.cloudops.com 
> @CloudOps_ 
> 
> 
> 


-- 
Francois Gaudreault 
Architecte de Solution Cloud | Cloud Solutions Architect 
fgaudrea...@cloudops.com 
514-629-6775 
- - - 
CloudOps 
420 rue Guy 
Montréal QC H3J 1S6 
www.cloudops.com 
@CloudOps_ 

Re: [PROPOSAL] Revert to VM disk Snapshot

[SuichII, Christopher]

I'm going to bring the conversation back to this thread since it got somewhat 
branched out.

One hurdle in implementing this is that it has been brought to my attention 
that we do not want all snapshots to be revertible. For example, I believe it 
is not XenServer best practices to simply revert a snapshot (in fact, there is 
no API for it). Instead, XenServer says you should delete the existing volume, 
then create a new volume from the snapshot in its place if you really want to 
revert. However, the general best practice is to create a new volume and attach 
it to the VM instead of reverting.

So, this means we need some system of determining whether a snapshot can be 
reverted in order to show/hide the snapshot accordingly in the UI. If we don't, 
then the revert action will always be there, but it will fail unless the 
snapshot is actually managed by a storage provider who provides reverting 
functionality. Originally I thought about including some information about 
whether each volume supports reverting when querying for volumes. However, I 
now realize that this should really be done at the snapshot level because the 
volume could migrate around primary storage, leaving snapshots that have been 
created by different primary storages. Because of this, I think we should 
introduce a new interface to PrimaryDataStoreDrivers, 'canRevert(Snapshot)' to 
go along with the exiting 'revertSnapshot(Snapshot)' which would be used when 
querying for snapshots to determine whether a snapshot can actually be reverted.

I see two options with this approach:
1) Always collect this information when querying for snapshots (like I 
described above)
2) Only load this information when listing actions for a snapshot.

I prefer (1) since (2) requires a new API to be exposed and (2) only solves 
this problem if the end user is using the default CS UI, otherwise providers 
creating their own UI would have to query the canRevert API in their own UI.

Any thoughts or objections to approach #1?

-Chris
-- 
Chris Suich
chris.su...@netapp.com
NetApp Software Engineer
Data Center Platforms – Cloud Solutions
Citrix, Cisco & Red Hat

On Oct 4, 2013, at 6:35 AM, benoit lair  wrote:

> This would be very great !!
> 
> 
> 2013/10/3 Daan Hoogland 
> 
>> go go go
>> 
>> 
>> On Wed, Oct 2, 2013 at 5:07 PM, David Ortiz  wrote:
>> 
>>> This sounds like a great idea.
>>> 
 From: chiradeep.vit...@citrix.com
 To: dev@cloudstack.apache.org
 Subject: Re: [PROPOSAL] Revert to VM disk Snapshot
 Date: Mon, 30 Sep 2013 21:53:35 +
 
 +1.
 
 On 9/30/13 2:31 PM, "SuichII, Christopher" 
>>> wrote:
 
> The storage subsystem API currently has an interface for
>> takeSnapshot()
> and an associated externally facing API for takeSnapshot. There is
>> also
>>> a
> method on the primary data store interface for revertSnapshot().
>>> However,
> this method is unused. We would like this storage subsystem interface
> method be hooked up to an externally facing API so that we can provide
> true VM disk backup and recovery.
> 
> I will work on formalizing a full functional spec but wanted to get
>> this
> up for discussion ASAP.
> 
> I have created a JIRA ticket:
> https://issues.apache.org/jira/browse/CLOUDSTACK-4771
> 
> Thanks,
> Chris
> --
> Chris Suich
> chris.su...@netapp.com
> NetApp Software Engineer
> Data Center Platforms ­ Cloud Solutions
> Citrix, Cisco & Red Hat
> 
 
>>> 
>>> 
>> 

Re: Review Request 14549: Rename net.juniper.contrail to org.apache.cloudstack.network.contrail

[Pedro Marques]

> On Oct. 9, 2013, 2:49 p.m., Murali Reddy wrote:
> > - Is there a reason why no new isolation type was not added for 'contrail 
> > controller'. For other overlay technologies (STT, GRE, VXLAN) that 
> > CloudStack support there is an isolation type and corresponding Guru that 
> > handles isolation type. 
> > 
> > - There is a 'EventBus' on to which all events generated by CloudStack gets 
> > published. Right approach would be to plug-in to subscribe to interested 
> > events from event bus. But the current implementation of EventBus expects 
> > external AMQP server, so it may not be ideal. EventInterceptor approach 
> > implemented in the plug-in works fine to get the notification. But enabling 
> > it by default in ApplicationContext does not seem right thing to do. 
> > 
> > - If you can add some more details in to the FS on deployment model it will 
> > give more perspective to reviewers
> > 
> > + is the VRouter mentioned in the FS is a appliance provisioned by 
> > CloudStack for each guest network by servicemanager? Or its a logical 
> > router on the dataplane that does the forwarding?
> > + is BGP/MPLS required on the IP fabric and the Hypervisors
> >

Murali,
We didn't add a new isolation type to avoid changing the CloudStack code. The 
current define describes the encapsulation technology. Contrail can use several 
encapsulation technologies: MPLS/GRE, MPLS/UDP, MPLS over VXLAN header. I can 
add one if you find it helpful... from a technology perspective contrail focus 
on the control plane solution rather than the encapsulation.

The event bus doesn't look like an attractive approach. If the ActionEvent 
listeners will cause a problem we can periodically poll from the plugin.

The "VRouter" is a linux kernel module running on each Host. BGP/MPLS is a 
control plane technology. The fabric is required to be able to transport IP 
packets between Hosts... No other assumption is made; no need for VLANs or MPLS 
on the fabric.


- Pedro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14549/#review26819
---


On Oct. 8, 2013, 11:58 p.m., Pedro Marques wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14549/
> ---
> 
> (Updated Oct. 8, 2013, 11:58 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Rename net.juniper.contrail to org.apache.cloudstack.network.contrail.
> 
> 
> Diffs
> -
> 
>   client/tomcatconf/applicationContext.xml.in 0ab2515 
>   client/tomcatconf/componentContext.xml.in 157ad5a 
>   
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/api/command/CreateServiceInstanceCmd.java
>  92f5eeb 
>   
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/api/response/ServiceInstanceResponse.java
>  1b7a7d8 
>   
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ContrailElement.java
>  885a60f 
>   
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ContrailElementImpl.java
>  3a38020 
>   
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ContrailGuru.java
>  c655b0b 
>   
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ContrailManager.java
>  5195793 
>   
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ContrailManagerImpl.java
>  8a3ca1b 
>   
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/DBSyncGeneric.java
>  d169b37 
>   
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/EventUtils.java
>  acd1bed 
>   
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ManagementNetworkGuru.java
>  bad2502 
>   
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ModelDatabase.java
>  f9e7c24 
>   
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ServerDBSync.java
>  4c8c2e9 
>   
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ServerDBSyncImpl.java
>  06daf12 
>   
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ServerEventHandler.java
>  6f0ecf2 
>   
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ServerEventHandlerImpl.java
>  aa4e9d5 
>   
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ServiceManager.java
>  f3884fb 
>   
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ServiceManagerImpl.java
>  b90792c 
>   
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ServiceVirtualMach

Re: Why Secondarystroage resourcelimit contains volumes

[Nitin Mehta]

One of the use case where volume is on secondary storage is for the
uploaded volumes. 
Until they are attached to the vm they reside on secondary storage and
hence should be counted for secondary storage usage.

On 11/10/13 1:15 AM, "sx chen"  wrote:

>Hi,all:
>In 4.2,We can limit the secondarystorage usage for a user or a domain.
>But when I refer to source code ,I find
>
>public long calculateSecondaryStorageForAccount(long accountId) {
>long totalVolumesSize =
>_volumeDao.secondaryStorageUsedForAccount(accountId);
>long totalSnapshotsSize =
>_snapshotDao.secondaryStorageUsedForAccount(accountId);
>long totalTemplatesSize = 0;
>
>SearchCriteria sc = templateSizeSearch.create();
>sc.setParameters("downloadState", Status.DOWNLOADED);
>sc.setParameters("destroyed", false);
>sc.setJoinParameters("templates", "accountId", accountId);
>List templates = _vmTemplateStoreDao.customSearch(sc,
>null);
>if (templates != null) {
>totalTemplatesSize = templates.get(0).sum;
>}
>
>return totalVolumesSize + totalSnapshotsSize + totalTemplatesSize;
>}
>
>Templates and snapshots are certainly belong to secondarystorage,
>The volumes which sql is :
>select sum(size) from volumes where account_id=? and path is null and
>removed is null and state not in ("ALLOCATED").
>
>So my question is why volumes is counted as secondarystorage?

RE: High CPU utilization on KVM hosts while doing RBD snapshot - was Re: snapshot caused host disconnected

[Edison Su]

> -Original Message-
> From: Indra Pramana [mailto:in...@sg.or.id]
> Sent: Wednesday, October 09, 2013 11:07 PM
> To: dev@cloudstack.apache.org; us...@cloudstack.apache.org
> Subject: Re: High CPU utilization on KVM hosts while doing RBD snapshot -
> was Re: snapshot caused host disconnected
> 
> Dear all,
> 
> I and my colleague tried to scrutinize the source code and found the script
> which is performing the copying of the snapshot from primary storage to
> secondary storage on this file:
> 
> ./plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/KVMSto
> rageProcessor.java
> 
> Specifically under this function:
> 
> @Override
> public Answer backupSnapshot(CopyCommand cmd) {
> 
> ===
> File snapDir = new File(snapshotDestPath);
> s_logger.debug("Attempting to create " +
> snapDir.getAbsolutePath() + " recursively");
> FileUtils.forceMkdir(snapDir);
> 
> File snapFile = new File(snapshotDestPath + "/" + 
> snapshotName);
> s_logger.debug("Backing up RBD snapshot to " +
> snapFile.getAbsolutePath());
> BufferedOutputStream bos = new BufferedOutputStream(new
> FileOutputStream(snapFile));
> int chunkSize = 4194304;
> long offset = 0;
> while(true) {
> byte[] buf = new byte[chunkSize];
> 
> int bytes = image.read(offset, buf, chunkSize);
> if (bytes <= 0) {
> break;
> }
> bos.write(buf, 0, bytes);
> offset += bytes;
> }
> s_logger.debug("Completed backing up RBD snapshot " +
> snapshotName + " to  " + snapFile.getAbsolutePath() + ". Bytes written: " +
> offset);
> bos.close();
> ===
> 
> (1) Is it safe to comment out the above lines and recompile/reinstall, to
> prevent CloudStack from copying the snapshots from the RBD primary
> storage to the secondary storage?
> 
> (2) What would be the impact to CloudStack operations if we leave the
> snapshots on primary storage without copying them to secondary storage?
> Are we still able to do restoration from the snapshots kept in the primary
> storage?

Yes, it's doable, but need to write a SnapshotStrategy in mgt server. The 
current SnapshotStrategy will always backup snapshot into secondary after 
taking snapshot.
You can write a new SnapshotStrategy, just take snapshot without backup to 
secondary storage.
After the commit: 180cfa19e87b909cb1c8a738359e31a6111b11c5 checked into master, 
you will get a lot of freedom to manipulate snapshot.

> 
> Looking forward to your reply, thank you.
> 
> Cheers.
> 
> 
> 
> On Wed, Oct 9, 2013 at 2:36 PM, Indra Pramana  wrote:
> 
> > Hi Wido and all,
> >
> > Good day to you, and thank you for your e-mail reply.
> >
> > Yes, from the agent logs I can see that the RBD snapshot was created.
> > However, it seems that CPU utilisation goes up drastically during the
> > copying over of the snapshot from primary storage to the secondary
> storage.
> >
> > ===
> > 2013-10-08 00:01:58,765 DEBUG [cloud.agent.Agent]
> > (agentRequest-Handler-5:null) Request:Seq 34-898172006:  { Cmd , MgmtId:
> > 161342671900, via: 34, Ver: v1, Flags: 100011,
> >
> [{"org.apache.cloudstack.storage.command.CreateObjectCommand":{"data"
> :{"org.apache.cloudstack.storage.to.SnapshotObjectTO":{"volume":{"uuid":"
> 0c4f8e41-dfd8-4fc2-a22e-
> 1a79738560a1","volumeType":"DATADISK","dataStore":{"org.apache.cloudst
> ack.storage.to.PrimaryDataStoreTO":{"uuid":"d433809b-01ea-3947-ba0f-
> 48077244e4d6","id":214,"poolType":"RBD","host":"
> > ceph-mon.simplercloud.com
> > ","path":"simplercloud-sg-01","port":6789}},"name":"DATA-
> 2051","size":64424509440,"path":"fc5dfa05-2431-4b42-804b-
> b2fb72e219d0","volumeId":2289,"vmName":"i-195-2051-
> VM","accountId":195,"format":"RAW","id":2289,"hypervisorType":"KVM"},"
> parentSnapshotPath":"simplercloud-sg-01/fc5dfa05-2431-4b42-804b-
> b2fb72e219d0/61042668-23ab-4f63-8a21-
> ce5a24f9c883","dataStore":{"org.apache.cloudstack.storage.to.PrimaryDataS
> toreTO":{"uuid":"d433809b-01ea-3947-ba0f-
> 48077244e4d6","id":214,"poolType":"RBD","host":"
> > ceph-mon.simplercloud.com","path":"simplercloud-sg-01","port":6789}},"
> > vmName":"i-195-2051-VM","name":"test-snapshot-and-ip-1_DATA-
> 2051_20131
> > 007160158","hypervisorType":"KVM","id":22}},"wait":0}}]
> > }
> > 2013-10-08 00:01:58,765 DEBUG [cloud.agent.Agent]
> > (agentRequest-Handler-5:null) Processing command:
> > org.apache.cloudstack.storage.command.CreateObjectCommand
> > 2013-10-08 00:02:08,071 DEBUG [cloud.agent.Agent]
> > (agentRequest-Handler-1:null) Request:Seq 34-898172007:  { Cmd , MgmtId:
> > 161342671900, via: 34, Ver: v1, Flags: 100011,
> >
> [{"org.apache.cloudstack.storage.command.CreateObjectCommand":{"data"
> :{"org.apache

Re: Global setting "host" is not set to MS IP anymore on master

[Min Chen]

I am also using marvin to deploy my local environment. Do you need to
restart MS after adding this globalConfig section in our .cfg file? If so,
developer may be able to workaround this. But this issue still needs to be
addressed for people not using marvin framework to setup environment, then
they have to always remember a manual update host step before starting any
ssvm.

Thanks
-min

On 10/10/13 9:31 PM, "Prasanna Santhanam"  wrote:

>So, why does setting the 'host' to your IP not work? I do that for the
>test environment on master as part of deployment via marvin. It's only
>a small change in the marvin-config.
>
>On https://github.com/vogxn/cloud-autodeploy.git
>
>commit 8fe580e82fe4ab6dd8e124bf226c5941e72a4204
>Author: Prasanna Santhanam 
>Date:   Fri Oct 4 13:53:55 2013 +0530
>
>host value in global config defaults to localhost
>Signed-off-by: Prasanna Santhanam 
>
>diff --git a/kvm.cfg b/kvm.cfg
>index 43b45de..0e23db0 100644
>--- a/kvm.cfg
>+++ b/kvm.cfg
>@@ -152,6 +152,10 @@
> ], 
> "globalConfig": [
> {
>+"name": "host",
>+"value": "cloudstack-centos63"
>+}, 
>+{
> "name": "network.gc.wait",
> "value": "60"
> }, 
>
>
>On Thu, Oct 10, 2013 at 11:25:15PM +, Prachi Damle wrote:
>> I see it on Windows too.
>> 
>> -Original Message-
>> From: Alena Prokharchyk [mailto:alena.prokharc...@citrix.com]
>> Sent: Thursday, October 10, 2013 4:20 PM
>> To: dev@cloudstack.apache.org; Min Chen
>> Subject: Re: Global setting "host" is not set to MS IP anymore on master
>> Importance: High
>> 
>> I'm facing the same problem on master (OS X v10.8.4 if the platform
>> matters)
>> 
>> On 10/10/13 3:22 PM, "Min Chen"  wrote:
>> 
>> >Hmm? I think that it may be related to new ConfigDepot framework to
>> >support dynamic config value without restarting MS.
>> >
>> >-min
>> >
>> >
>> >
>> >On 10/10/13 3:00 PM, "Nitin Mehta"  wrote:
>> >
>> >>If my memory serves me right this was fixed in 4.2. Maybe the fixer
>> >>forgot to port it to master ?
>> >>
>> >>On 10/10/13 2:46 PM, "Min Chen"  wrote:
>> >>
>> >>>Hi there,
>> >>>
>> >>>Not sure if others experience the same issue. In 4.2, when MS
>>starts, 
>> >>>it will discover the IP address of MS and automatically set global
>> >>>setting "host" to that IP address. Now it seems broken on master, MS
>> >>>started but "host" is still set to "localhost", which caused my
>> >>>system vm cannot ping back MS and thus no agent status cannot be
>> >>>found for system vm, thus this message on my console "INFO
>> >>>[o.a.c.s.e.DefaultEndPointSelector] (StatsCollector-3:null) No
>> >>>running ssvm is found, so command will be sent to LocalHostEndPoint".
>> >>>Anybody has any idea on this?
>> >>>
>> >>>Thanks
>> >>>-min
>> >>
>> >
>> >
>> 
>
>-- 
>Prasanna.,
>
>
>Powered by BigRock.com
>

RE: UI accounts wizard broken

[Brian Federle]

No worries, I must have missed the original discussion.

Probably an easier way would be to add support for passing a closure to the 
createForm: and/or add: action block, so you can conditionally check context 
and return the appropriate form. We can modify the account form to use this in 
the future, but for now as long as the dialog works then it is OK, I was able 
to hack around the styling issues.

Generally, I'm thinking writing in a custom widget should only be for if a 
special layout or visual flow is needed -- i.e., like a dashboard or wizard 
with a unique layout, so moving forward if the standard process needs more 
checks or conditionals, we can first see if the UI toolkit can be expanded 
easily to support it.

I'll file a bug for the password confirm not working...

Thanks,
Brian

From: Ian Duffy [i...@ianduffy.ie]
Sent: Thursday, October 10, 2013 7:23 PM
To: Jessica Wang; Abhinandan Prateek; Pranav Saxena
Cc: Brian Federle; dev@cloudstack.apache.org; Animesh Chaturvedi; Sonny Chhen
Subject: Re: UI accounts wizard broken

Hi Brian,

> I noticed that the 'add account' dialog was changed substantially, and 
> converted to a custom UI widget. Additionally, the password
> confirm field validation is broken, so I am unable to add a new account

The change was made in order to allow the wizard to change to include
a list of users grabbed from LDAP when LDAP is enabled. This was done
in order to aid ease of user provisioning.

The change was discussed some time ago on the mailing list:
Switch dialog actions based on result from API call. -
http://markmail.org/thread/ebtm2iqzvz3sm3ne
UI Query: Create Form - http://markmail.org/thread/kcngmhlgxeukvscb

Based on the replies from Jessica and Pranav the only way to go about
implementing this was via the custom widget.

> This doesn't seem to really need something custom from the looks of it

Is there a way we can use createForm and still implement the custom
dialog ( http://ianduffy.ie/cloudstack/screen1.png ) when Ldap is
enabled?

Very sorry about this! Wasn't aware such issue was present.

Thanks,
Ian

On 10 October 2013 21:03, Jessica Wang  wrote:
> +1
>
> -Original Message-
> From: Brian Federle
> Sent: Thursday, October 10, 2013 12:55 PM
> To: dev@cloudstack.apache.org
> Cc: Animesh Chaturvedi; Jessica Wang; Sonny Chhen
> Subject: RE: UI accounts wizard broken
>
> Also, I am referring to this commit. I do not remember any active UI 
> comitters including myself receiving a review request for this...
>
> commit eaa41433715ba1a1137ad9f346ea8569e31e4560
> Author: Ian Duffy 
> Date:   Thu Jul 25 10:24:13 2013 +0100
>
> Merge LDAPPlugin
>
> Signed-off-by: Abhinandan Prateek 
>
> -Original Message-
> From: Brian Federle [mailto:brian.fede...@citrix.com]
> Sent: Thursday, October 10, 2013 12:46 PM
> To: dev@cloudstack.apache.org
> Cc: Animesh Chaturvedi; Jessica Wang; Sonny Chhen
> Subject: UI accounts wizard broken
>
> After reviewing the UI on the latest master, I noticed that the 'add account' 
> dialog was changed substantially, and converted to a custom UI widget. 
> Additionally, the password confirm field validation is broken, so I am unable 
> to add a new account.
>
> Can I know the reason this was converted to a custom widget, instead of using 
> the standard createForm? This doesn't seem to really need something custom 
> from the looks of it. I am mainly concerned since it is causing validation 
> bugs as well as some display glitches, which could be avoided by using the 
> standard widget toolkit.
>
> Thanks,
> Brian

Re: KVM systemvm not getting IP

[Francois Gaudreault]

Thanks Kelcey.

My VMs are starting now, but then qemu sends a sigkill and the VM 
shutdown by itself after 40sec or so. Anyone experienced that? I guess 
this is something to bring to the libvirt mailing list :S


Francois

On 10/11/2013, 12:38 PM, Kelcey Jamison Damage wrote:

That is the old template and won't work with 4.2

You can follow one of the methods in 
http://cloud.kelceydamage.com/cloudfire/blog/2013/10/08/conquering-the-cloudstack-4-2-dragon-kvm/ 
if you wish to recover your cloud, or you can simply use the updated 
template link posted and start over again.


Thanks.

-Kelcey


*From: *"Francois Gaudreault" 
*To: *dev@cloudstack.apache.org
*Sent: *Friday, October 11, 2013 9:17:43 AM
*Subject: *Re: KVM systemvm not getting IP

Hmm... How do I know if I am using the old or new :P

I downloaded this one:
http://download.cloud.com/templates/acton/acton-systemvm-02062012.qcow2.bz2

FG

On 10/11/2013, 12:12 PM, Rajesh Battala wrote:
> Hi Francois,
> Are you using the new systemvm template.
> System vm's ip's info (boot args) are passed via socket in 4.2. 
Please check whether you are using new or old systemvm template.

>
> Thanks
> Rajesh Battala
>
> -Original Message-
> From: Francois Gaudreault [mailto:fgaudrea...@cloudops.com]
> Sent: Friday, October 11, 2013 8:30 PM
> To: dev@cloudstack.apache.org
> Subject: KVM systemvm not getting IP
>
> Anyone faced an issue where the KVM system VM doesn't set IPs on the 
network interfaces? In fact there is no interfaces definitions in 
/etc/network/interfaces.

>
> I am using CS 4.2. I re-installed my host to use Ubuntu 13.04 (I 
have the same behavior on CentOS 6).

>
> --
> Francois Gaudreault
> Architecte de Solution Cloud | Cloud Solutions Architect 
fgaudrea...@cloudops.com

> 514-629-6775
> - - -
> CloudOps
> 420 rue Guy
> Montréal QC  H3J 1S6
> www.cloudops.com
> @CloudOps_
>
>
>


--
Francois Gaudreault
Architecte de Solution Cloud | Cloud Solutions Architect
fgaudrea...@cloudops.com
514-629-6775
- - -
CloudOps
420 rue Guy
Montréal QC  H3J 1S6
www.cloudops.com
@CloudOps_





--
Francois Gaudreault
Architecte de Solution Cloud | Cloud Solutions Architect
fgaudrea...@cloudops.com
514-629-6775
- - -
CloudOps
420 rue Guy
Montréal QC  H3J 1S6
www.cloudops.com
@CloudOps_

Re: [PROPOSAL] Revert to VM disk Snapshot

[Mike Tutkowski]

I agree that (1) is the better way to go here.


On Fri, Oct 11, 2013 at 10:50 AM, SuichII, Christopher <
chris.su...@netapp.com> wrote:

> I'm going to bring the conversation back to this thread since it got
> somewhat branched out.
>
> One hurdle in implementing this is that it has been brought to my
> attention that we do not want all snapshots to be revertible. For example,
> I believe it is not XenServer best practices to simply revert a snapshot
> (in fact, there is no API for it). Instead, XenServer says you should
> delete the existing volume, then create a new volume from the snapshot in
> its place if you really want to revert. However, the general best practice
> is to create a new volume and attach it to the VM instead of reverting.
>
> So, this means we need some system of determining whether a snapshot can
> be reverted in order to show/hide the snapshot accordingly in the UI. If we
> don't, then the revert action will always be there, but it will fail unless
> the snapshot is actually managed by a storage provider who provides
> reverting functionality. Originally I thought about including some
> information about whether each volume supports reverting when querying for
> volumes. However, I now realize that this should really be done at the
> snapshot level because the volume could migrate around primary storage,
> leaving snapshots that have been created by different primary storages.
> Because of this, I think we should introduce a new interface to
> PrimaryDataStoreDrivers, 'canRevert(Snapshot)' to go along with the exiting
> 'revertSnapshot(Snapshot)' which would be used when querying for snapshots
> to determine whether a snapshot can actually be reverted.
>
> I see two options with this approach:
> 1) Always collect this information when querying for snapshots (like I
> described above)
> 2) Only load this information when listing actions for a snapshot.
>
> I prefer (1) since (2) requires a new API to be exposed and (2) only
> solves this problem if the end user is using the default CS UI, otherwise
> providers creating their own UI would have to query the canRevert API in
> their own UI.
>
> Any thoughts or objections to approach #1?
>
> -Chris
> --
> Chris Suich
> chris.su...@netapp.com
> NetApp Software Engineer
> Data Center Platforms – Cloud Solutions
> Citrix, Cisco & Red Hat
>
> On Oct 4, 2013, at 6:35 AM, benoit lair  wrote:
>
> > This would be very great !!
> >
> >
> > 2013/10/3 Daan Hoogland 
> >
> >> go go go
> >>
> >>
> >> On Wed, Oct 2, 2013 at 5:07 PM, David Ortiz 
> wrote:
> >>
> >>> This sounds like a great idea.
> >>>
>  From: chiradeep.vit...@citrix.com
>  To: dev@cloudstack.apache.org
>  Subject: Re: [PROPOSAL] Revert to VM disk Snapshot
>  Date: Mon, 30 Sep 2013 21:53:35 +
> 
>  +1.
> 
>  On 9/30/13 2:31 PM, "SuichII, Christopher" 
> >>> wrote:
> 
> > The storage subsystem API currently has an interface for
> >> takeSnapshot()
> > and an associated externally facing API for takeSnapshot. There is
> >> also
> >>> a
> > method on the primary data store interface for revertSnapshot().
> >>> However,
> > this method is unused. We would like this storage subsystem interface
> > method be hooked up to an externally facing API so that we can
> provide
> > true VM disk backup and recovery.
> >
> > I will work on formalizing a full functional spec but wanted to get
> >> this
> > up for discussion ASAP.
> >
> > I have created a JIRA ticket:
> > https://issues.apache.org/jira/browse/CLOUDSTACK-4771
> >
> > Thanks,
> > Chris
> > --
> > Chris Suich
> > chris.su...@netapp.com
> > NetApp Software Engineer
> > Data Center Platforms ­ Cloud Solutions
> > Citrix, Cisco & Red Hat
> >
> 
> >>>
> >>>
> >>
>
>


-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloud
*™*

Re: Global setting "host" is not set to MS IP anymore on master

[Mike Tutkowski]

Yeah, I tend to set up my CS environment manually.

The first thing I do when I log in via the GUI is change the host,
secstorage, and cidr Global Settings and then re-start the management
server.

It would be great if this were not required, of course.


On Fri, Oct 11, 2013 at 11:14 AM, Min Chen  wrote:

> I am also using marvin to deploy my local environment. Do you need to
> restart MS after adding this globalConfig section in our .cfg file? If so,
> developer may be able to workaround this. But this issue still needs to be
> addressed for people not using marvin framework to setup environment, then
> they have to always remember a manual update host step before starting any
> ssvm.
>
> Thanks
> -min
>
> On 10/10/13 9:31 PM, "Prasanna Santhanam"  wrote:
>
> >So, why does setting the 'host' to your IP not work? I do that for the
> >test environment on master as part of deployment via marvin. It's only
> >a small change in the marvin-config.
> >
> >On https://github.com/vogxn/cloud-autodeploy.git
> >
> >commit 8fe580e82fe4ab6dd8e124bf226c5941e72a4204
> >Author: Prasanna Santhanam 
> >Date:   Fri Oct 4 13:53:55 2013 +0530
> >
> >host value in global config defaults to localhost
> >Signed-off-by: Prasanna Santhanam 
> >
> >diff --git a/kvm.cfg b/kvm.cfg
> >index 43b45de..0e23db0 100644
> >--- a/kvm.cfg
> >+++ b/kvm.cfg
> >@@ -152,6 +152,10 @@
> > ],
> > "globalConfig": [
> > {
> >+"name": "host",
> >+"value": "cloudstack-centos63"
> >+},
> >+{
> > "name": "network.gc.wait",
> > "value": "60"
> > },
> >
> >
> >On Thu, Oct 10, 2013 at 11:25:15PM +, Prachi Damle wrote:
> >> I see it on Windows too.
> >>
> >> -Original Message-
> >> From: Alena Prokharchyk [mailto:alena.prokharc...@citrix.com]
> >> Sent: Thursday, October 10, 2013 4:20 PM
> >> To: dev@cloudstack.apache.org; Min Chen
> >> Subject: Re: Global setting "host" is not set to MS IP anymore on master
> >> Importance: High
> >>
> >> I'm facing the same problem on master (OS X v10.8.4 if the platform
> >> matters)
> >>
> >> On 10/10/13 3:22 PM, "Min Chen"  wrote:
> >>
> >> >Hmm? I think that it may be related to new ConfigDepot framework to
> >> >support dynamic config value without restarting MS.
> >> >
> >> >-min
> >> >
> >> >
> >> >
> >> >On 10/10/13 3:00 PM, "Nitin Mehta"  wrote:
> >> >
> >> >>If my memory serves me right this was fixed in 4.2. Maybe the fixer
> >> >>forgot to port it to master ?
> >> >>
> >> >>On 10/10/13 2:46 PM, "Min Chen"  wrote:
> >> >>
> >> >>>Hi there,
> >> >>>
> >> >>>Not sure if others experience the same issue. In 4.2, when MS
> >>starts,
> >> >>>it will discover the IP address of MS and automatically set global
> >> >>>setting "host" to that IP address. Now it seems broken on master, MS
> >> >>>started but "host" is still set to "localhost", which caused my
> >> >>>system vm cannot ping back MS and thus no agent status cannot be
> >> >>>found for system vm, thus this message on my console "INFO
> >> >>>[o.a.c.s.e.DefaultEndPointSelector] (StatsCollector-3:null) No
> >> >>>running ssvm is found, so command will be sent to LocalHostEndPoint".
> >> >>>Anybody has any idea on this?
> >> >>>
> >> >>>Thanks
> >> >>>-min
> >> >>
> >> >
> >> >
> >>
> >
> >--
> >Prasanna.,
> >
> >
> >Powered by BigRock.com
> >
>
>


-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloud
*™*

Re: Review Request 14381: KVM: add connect/disconnect capabilities to StorageAdaptors so that external storage services can attach/detach devices on-demand

[Mike Tutkowski]

Hey Marcus,

What do you think about me running the following to get the device size for
my PhysicalDisk instances?

"blockdev --getsize64 /dev/disk/by-path/ip-" + host + "-iscsi-" + iqn +
"-lun-0

That should work on whatever platforms the KVM agent runs (mainly Ubuntu
and CentOS), right?

Thanks


On Thu, Oct 10, 2013 at 7:56 PM, Mike Tutkowski <
mike.tutkow...@solidfire.com> wrote:

> I made a bunch of updates, Marcus:
>
>
> https://github.com/mike-tutkowski/incubator-cloudstack/commit/c13442eaa228a5ae37d3b13f6c98636de158a908
>
>
> On Thu, Oct 10, 2013 at 4:40 PM, Mike Tutkowski <
> mike.tutkow...@solidfire.com> wrote:
>
>> Hey Marcus,
>>
>> I haven't had a chance to test this yet, but I thought you might be
>> interested in the merge of your work with mine.
>>
>> I've also replaced the direct CHAP parameters with a Map
>> (which currently only stores the CHAP credentials, but could be used for
>> more in the future).
>>
>> I still have a bit of work to do around the getPhysicalDisk method, but
>> this should give you a good idea of where we're at:
>>
>>
>> https://github.com/mike-tutkowski/incubator-cloudstack/commit/30433a20d1707ea1870024e80732bcfdbd64f69a
>>
>> Talk to you later
>>
>>
>> On Wed, Oct 9, 2013 at 3:52 PM, Mike Tutkowski <
>> mike.tutkow...@solidfire.com> wrote:
>>
>>> I've got the code all merged, by the way.
>>>
>>> I should be able to start in on testing soon (tonight or tomorrow).
>>>
>>>
>>> On Wed, Oct 9, 2013 at 3:51 PM, Mike Tutkowski <
>>> mike.tutkow...@solidfire.com> wrote:
>>>
 Will do...I'll remove it (there is similar code in two methods).


 On Wed, Oct 9, 2013 at 3:49 PM, Marcus Sorensen wrote:

> Yeah, that looks like leftovers from refactoring our 4.1 code into 4.2
> and making it something more generic. It looks like it could be removed.
>
>
> On Wed, Oct 9, 2013 at 3:40 PM, Mike Tutkowski <
> mike.tutkow...@solidfire.com> wrote:
>
>> Hey Marcus,
>>
>> I'm merging your changes into mine.
>>
>> It looks like I can remove your call to getPhysicalDisk (below) (and
>> the associated KVMPhysicalDisk variable, as well).
>>
>> I assume you would never want to produce any side effects in your
>> getPhysicalDisk implementation, right? Seems like that would be 
>> unintuitive.
>>
>> public boolean connectPhysicalDisksViaVmSpec(VirtualMachineTO
>> vmSpec) {
>>
>> boolean result = false;
>>
>>
>> final String vmName = vmSpec.getName();
>>
>>
>> List disks = Arrays.asList(vmSpec.getDisks());
>>
>>
>> for (DiskTO disk : disks) {
>>
>> KVMPhysicalDisk physicalDisk = null;
>>
>> KVMStoragePool pool = null;
>>
>>
>> if (disk.getType() != Volume.Type.ISO) {
>>
>> VolumeObjectTO vol = (VolumeObjectTO) disk.getData();
>>
>> PrimaryDataStoreTO store = (PrimaryDataStoreTO)
>> vol.getDataStore();
>>
>>
>> pool = getStoragePool(store.getPoolType(),
>> store.getUuid());
>>
>> physicalDisk = pool.getPhysicalDisk(vol.getPath());
>>
>>
>> StorageAdaptor adaptor =
>> getStorageAdaptor(pool.getType());
>>
>>
>> result = adaptor.connectPhysicalDisk(vol.getPath(),
>> pool);
>>
>>
>> if (! result) {
>>
>> s_logger.error("Failed to connect disks via vm
>> spec for vm:" + vmName + " volume:" + vol.toString());
>>
>>
>> return result;
>>
>> }
>>
>> }
>>
>> }
>>
>>
>> return result;
>>
>> }
>>
>>
>> On Wed, Oct 9, 2013 at 12:01 AM, Mike Tutkowski <
>> mike.tutkow...@solidfire.com> wrote:
>>
>>> Excellent...that template worked like a charm.
>>>
>>> Thanks!
>>>
>>>
>>> On Tue, Oct 8, 2013 at 11:50 PM, Mike Tutkowski <
>>> mike.tutkow...@solidfire.com> wrote:
>>>
 Perfect

 Almost done downloading...I'll give it a try in a moment.


 On Tue, Oct 8, 2013 at 11:47 PM, Marcus Sorensen <
 shadow...@gmail.com> wrote:

> Not password enabled, root password is just 'password'. I mainly
> just use it for devcloud-kvm testing.
>  On Oct 8, 2013 11:45 PM, "Mike Tutkowski" <
> mike.tutkow...@solidfire.com> wrote:
>
>> Great - thanks!
>>
>>
>> On Tue, Oct 8, 2013 at 11:38 PM, Marcus Sorensen <
>> shadow...@gmail.com> wrote:
>>
>>> Use my tiny centos image. I'm not sure what's up with that
>>> crufty old default centos template.
>>>
>>> Register this qcow2 template:
>>> http://marcus.mlsorens

Review Request 14603: fixed Rules

[Laszlo Hornyak]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14603/
---

Review request for cloudstack.


Repository: cloudstack-git


Description
---

the implementation was broken, fixed for those who actually want to read the 
output


Diffs
-

  engine/api/src/org/apache/cloudstack/engine/Rules.java b700fa5 

Diff: https://reviews.apache.org/r/14603/diff/


Testing
---


Thanks,

Laszlo Hornyak

Review Request 14604: Removing coded documentation

[Laszlo Hornyak]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14604/
---

Review request for cloudstack.


Repository: cloudstack-git


Description
---

This is the output of the program, the developer documentation may be a better 
place

-

When developing against the CloudStack Orchestration Platform, you must 
following the following rules:
API Rule: Always be prepared to handle RuntimeExceptions.

When writing APIs, you must follow these rules:
API Rule: You may think you're the greatest developer in the world but every 
change to the API must be reviewed and approved.
API Rule: Every API must have unit tests written against it.  And not it's unit 
tests
API Rule:

-


Diffs
-

  engine/api/src/org/apache/cloudstack/engine/Rules.java b700fa5 

Diff: https://reviews.apache.org/r/14604/diff/


Testing
---

yes


Thanks,

Laszlo Hornyak

Re: Review Request 14381: KVM: add connect/disconnect capabilities to StorageAdaptors so that external storage services can attach/detach devices on-demand

[Marcus Sorensen]

Yes, blockdev is a part of the util-linux package, and all but a minimal
install should have it. To be safe, we could add 'util-linux' to the deb
requires and 'util-linux-ng' to the rpm requires for the agents. Something
like:

diff --git a/debian/control b/debian/control
index 46dd505..72a0fb1 100644
--- a/debian/control
+++ b/debian/control
@@ -22,7 +22,7 @@ Description: CloudStack server library

 Package: cloudstack-agent
 Architecture: all
-Depends: openjdk-6-jre | openjdk-7-jre, cloudstack-common (=
${source:Version}), lsb-base (>= 3.2), libcommons-daemon-java, libjna-java,
openssh-client, libvirt0, sysvinit-utils, qemu-kvm, libvirt-bin
+Depends: openjdk-6-jre | openjdk-7-jre, cloudstack-common (=
${source:Version}), lsb-base (>= 3.2), libcommons-daemon-java, libjna-java,
openssh-client, libvirt0, sysvinit-utils, qemu-kvm, libvirt-bin
 Conflicts: cloud-agent, cloud-agent-libs, cloud-agent-deps,
cloud-agent-scripts
 Description: CloudStack agent
  The CloudStack agent is in charge of managing shared computing resources
in
diff --git a/packaging/centos63/cloud.spec b/packaging/centos63/cloud.spec
index 5f8a2a5..07127a4 100644
--- a/packaging/centos63/cloud.spec
+++ b/packaging/centos63/cloud.spec
@@ -81,6 +81,7 @@ Requires: mkisofs
 Requires: MySQL-python
 Requires: python-paramiko
 Requires: ipmitool
+Requires: util-linux-ng
 Requires: %{name}-common = %{_ver}
 Requires: %{name}-awsapi = %{_ver}
 Obsoletes: cloud-client < 4.1.0

If you wanted to be indepedent of that, you could use sysfs in a roundabout
way:

marcus@marcus-bsdesk:~/code$ ls -l
/dev/disk/by-path/pci-\:00\:1f.2-scsi-0\:0\:0\:0
lrwxrwxrwx 1 root root 9 Oct  7 09:25
/dev/disk/by-path/pci-:00:1f.2-scsi-0:0:0:0 -> ../../sdc

we are pointing to /dev/sdc

marcus@marcus-bsdesk:~/code$ cat /sys/block/sdc/size
5860533168
*size in sectors*

marcus@marcus-bsdesk:~/code$ cat /sys/block/sdc/queue/hw_sector_size
512

5860533168 * 512 = 3000592982016

compared to:
marcus@marcus-bsdesk:~/code$ sudo blockdev --getsize64 /dev/sdc
3000592982016








On Fri, Oct 11, 2013 at 12:36 PM, Mike Tutkowski <
mike.tutkow...@solidfire.com> wrote:

> Hey Marcus,
>
> What do you think about me running the following to get the device size
> for my PhysicalDisk instances?
>
> "blockdev --getsize64 /dev/disk/by-path/ip-" + host + "-iscsi-" + iqn +
> "-lun-0
>
> That should work on whatever platforms the KVM agent runs (mainly Ubuntu
> and CentOS), right?
>
> Thanks
>
>
> On Thu, Oct 10, 2013 at 7:56 PM, Mike Tutkowski <
> mike.tutkow...@solidfire.com> wrote:
>
>> I made a bunch of updates, Marcus:
>>
>>
>> https://github.com/mike-tutkowski/incubator-cloudstack/commit/c13442eaa228a5ae37d3b13f6c98636de158a908
>>
>>
>> On Thu, Oct 10, 2013 at 4:40 PM, Mike Tutkowski <
>> mike.tutkow...@solidfire.com> wrote:
>>
>>> Hey Marcus,
>>>
>>> I haven't had a chance to test this yet, but I thought you might be
>>> interested in the merge of your work with mine.
>>>
>>> I've also replaced the direct CHAP parameters with a Map
>>> (which currently only stores the CHAP credentials, but could be used for
>>> more in the future).
>>>
>>> I still have a bit of work to do around the getPhysicalDisk method, but
>>> this should give you a good idea of where we're at:
>>>
>>>
>>> https://github.com/mike-tutkowski/incubator-cloudstack/commit/30433a20d1707ea1870024e80732bcfdbd64f69a
>>>
>>> Talk to you later
>>>
>>>
>>> On Wed, Oct 9, 2013 at 3:52 PM, Mike Tutkowski <
>>> mike.tutkow...@solidfire.com> wrote:
>>>
 I've got the code all merged, by the way.

 I should be able to start in on testing soon (tonight or tomorrow).


 On Wed, Oct 9, 2013 at 3:51 PM, Mike Tutkowski <
 mike.tutkow...@solidfire.com> wrote:

> Will do...I'll remove it (there is similar code in two methods).
>
>
> On Wed, Oct 9, 2013 at 3:49 PM, Marcus Sorensen 
> wrote:
>
>> Yeah, that looks like leftovers from refactoring our 4.1 code into
>> 4.2 and making it something more generic. It looks like it could be 
>> removed.
>>
>>
>> On Wed, Oct 9, 2013 at 3:40 PM, Mike Tutkowski <
>> mike.tutkow...@solidfire.com> wrote:
>>
>>> Hey Marcus,
>>>
>>> I'm merging your changes into mine.
>>>
>>> It looks like I can remove your call to getPhysicalDisk (below) (and
>>> the associated KVMPhysicalDisk variable, as well).
>>>
>>> I assume you would never want to produce any side effects in your
>>> getPhysicalDisk implementation, right? Seems like that would be 
>>> unintuitive.
>>>
>>> public boolean connectPhysicalDisksViaVmSpec(VirtualMachineTO
>>> vmSpec) {
>>>
>>> boolean result = false;
>>>
>>>
>>> final String vmName = vmSpec.getName();
>>>
>>>
>>> List disks = Arrays.asList(vmSpec.getDisks());
>>>
>>>
>>> for (DiskTO disk : disks) {
>>>
>>> KVMPhysicalDisk physicalDisk = null;
>

Re: Review Request 14381: KVM: add connect/disconnect capabilities to StorageAdaptors so that external storage services can attach/detach devices on-demand

[Marcus Sorensen]

Oops, that patch got cut off:

diff --git a/debian/control b/debian/control
index 46dd505..72a0fb1 100644
--- a/debian/control
+++ b/debian/control
@@ -22,7 +22,7 @@ Description: CloudStack server library

 Package: cloudstack-agent
 Architecture: all
-Depends: openjdk-6-jre | openjdk-7-jre, cloudstack-common (=
${source:Version}), lsb-base (>= 3.2), libcommons-daemon-java, libjna-java,
openssh-client, libvirt0, sysvinit-utils, qemu-kvm, libvirt-bin,
uuid-runtime, rsync, grep, iproute, perl-base, perl-modules, ebtables,
vlan, wget, jsvc, ipset
+Depends: openjdk-6-jre | openjdk-7-jre, cloudstack-common (=
${source:Version}), lsb-base (>= 3.2), libcommons-daemon-java, libjna-java,
openssh-client, libvirt0, sysvinit-utils, qemu-kvm, libvirt-bin,
uuid-runtime, rsync, grep, iproute, perl-base, perl-modules, ebtables,
vlan, wget, jsvc, ipset, util-linux
 Conflicts: cloud-agent, cloud-agent-libs, cloud-agent-deps,
cloud-agent-scripts
 Description: CloudStack agent
  The CloudStack agent is in charge of managing shared computing resources
in
diff --git a/packaging/centos63/cloud.spec b/packaging/centos63/cloud.spec
index 5f8a2a5..07127a4 100644
--- a/packaging/centos63/cloud.spec
+++ b/packaging/centos63/cloud.spec
@@ -81,6 +81,7 @@ Requires: mkisofs
 Requires: MySQL-python
 Requires: python-paramiko
 Requires: ipmitool
+Requires: util-linux-ng
 Requires: %{name}-common = %{_ver}
 Requires: %{name}-awsapi = %{_ver}
 Obsoletes: cloud-client < 4.1.0


On Fri, Oct 11, 2013 at 1:02 PM, Marcus Sorensen wrote:

> Yes, blockdev is a part of the util-linux package, and all but a minimal
> install should have it. To be safe, we could add 'util-linux' to the deb
> requires and 'util-linux-ng' to the rpm requires for the agents. Something
> like:
>
> diff --git a/debian/control b/debian/control
> index 46dd505..72a0fb1 100644
> --- a/debian/control
> +++ b/debian/control
> @@ -22,7 +22,7 @@ Description: CloudStack server library
>
>  Package: cloudstack-agent
>  Architecture: all
> -Depends: openjdk-6-jre | openjdk-7-jre, cloudstack-common (=
> ${source:Version}), lsb-base (>= 3.2), libcommons-daemon-java, libjna-java,
> openssh-client, libvirt0, sysvinit-utils, qemu-kvm, libvirt-bin
> +Depends: openjdk-6-jre | openjdk-7-jre, cloudstack-common (=
> ${source:Version}), lsb-base (>= 3.2), libcommons-daemon-java, libjna-java,
> openssh-client, libvirt0, sysvinit-utils, qemu-kvm, libvirt-bin
>  Conflicts: cloud-agent, cloud-agent-libs, cloud-agent-deps,
> cloud-agent-scripts
>  Description: CloudStack agent
>   The CloudStack agent is in charge of managing shared computing resources
> in
> diff --git a/packaging/centos63/cloud.spec b/packaging/centos63/cloud.spec
> index 5f8a2a5..07127a4 100644
> --- a/packaging/centos63/cloud.spec
> +++ b/packaging/centos63/cloud.spec
> @@ -81,6 +81,7 @@ Requires: mkisofs
>  Requires: MySQL-python
>  Requires: python-paramiko
>  Requires: ipmitool
> +Requires: util-linux-ng
>  Requires: %{name}-common = %{_ver}
>  Requires: %{name}-awsapi = %{_ver}
>  Obsoletes: cloud-client < 4.1.0
>
> If you wanted to be indepedent of that, you could use sysfs in a
> roundabout way:
>
> marcus@marcus-bsdesk:~/code$ ls -l
> /dev/disk/by-path/pci-\:00\:1f.2-scsi-0\:0\:0\:0
> lrwxrwxrwx 1 root root 9 Oct  7 09:25
> /dev/disk/by-path/pci-:00:1f.2-scsi-0:0:0:0 -> ../../sdc
>
> we are pointing to /dev/sdc
>
> marcus@marcus-bsdesk:~/code$ cat /sys/block/sdc/size
> 5860533168
> *size in sectors*
>
> marcus@marcus-bsdesk:~/code$ cat /sys/block/sdc/queue/hw_sector_size
> 512
>
> 5860533168 * 512 = 3000592982016
>
> compared to:
> marcus@marcus-bsdesk:~/code$ sudo blockdev --getsize64 /dev/sdc
> 3000592982016
>
>
>
>
>
>
>
>
> On Fri, Oct 11, 2013 at 12:36 PM, Mike Tutkowski <
> mike.tutkow...@solidfire.com> wrote:
>
>> Hey Marcus,
>>
>> What do you think about me running the following to get the device size
>> for my PhysicalDisk instances?
>>
>> "blockdev --getsize64 /dev/disk/by-path/ip-" + host + "-iscsi-" + iqn +
>> "-lun-0
>>
>> That should work on whatever platforms the KVM agent runs (mainly Ubuntu
>> and CentOS), right?
>>
>> Thanks
>>
>>
>> On Thu, Oct 10, 2013 at 7:56 PM, Mike Tutkowski <
>> mike.tutkow...@solidfire.com> wrote:
>>
>>> I made a bunch of updates, Marcus:
>>>
>>>
>>> https://github.com/mike-tutkowski/incubator-cloudstack/commit/c13442eaa228a5ae37d3b13f6c98636de158a908
>>>
>>>
>>> On Thu, Oct 10, 2013 at 4:40 PM, Mike Tutkowski <
>>> mike.tutkow...@solidfire.com> wrote:
>>>
 Hey Marcus,

 I haven't had a chance to test this yet, but I thought you might be
 interested in the merge of your work with mine.

 I've also replaced the direct CHAP parameters with a Map>>> String> (which currently only stores the CHAP credentials, but could be
 used for more in the future).

 I still have a bit of work to do around the getPhysicalDisk method, but
 this should give you a good idea of where we're at:


 https://github.com/mike-tutkowski/incubator-c

Re: Review Request 14381: KVM: add connect/disconnect capabilities to StorageAdaptors so that external storage services can attach/detach devices on-demand

[Mike Tutkowski]

We will also require iscsiadm to be present, which I believe is part of the
open-iscsi package on Ubuntu, so I guess what's another couple
dependencies. :)


On Fri, Oct 11, 2013 at 1:03 PM, Marcus Sorensen wrote:

> Oops, that patch got cut off:
>
>
> diff --git a/debian/control b/debian/control
> index 46dd505..72a0fb1 100644
> --- a/debian/control
> +++ b/debian/control
> @@ -22,7 +22,7 @@ Description: CloudStack server library
>
>  Package: cloudstack-agent
>  Architecture: all
> -Depends: openjdk-6-jre | openjdk-7-jre, cloudstack-common (=
> ${source:Version}), lsb-base (>= 3.2), libcommons-daemon-java, libjna-java,
> openssh-client, libvirt0, sysvinit-utils, qemu-kvm, libvirt-bin,
> uuid-runtime, rsync, grep, iproute, perl-base, perl-modules, ebtables,
> vlan, wget, jsvc, ipset
> +Depends: openjdk-6-jre | openjdk-7-jre, cloudstack-common (=
> ${source:Version}), lsb-base (>= 3.2), libcommons-daemon-java, libjna-java,
> openssh-client, libvirt0, sysvinit-utils, qemu-kvm, libvirt-bin,
> uuid-runtime, rsync, grep, iproute, perl-base, perl-modules, ebtables,
> vlan, wget, jsvc, ipset, util-linux
>  Conflicts: cloud-agent, cloud-agent-libs, cloud-agent-deps,
> cloud-agent-scripts
>  Description: CloudStack agent
>   The CloudStack agent is in charge of managing shared computing resources
> in
> diff --git a/packaging/centos63/cloud.spec b/packaging/centos63/cloud.spec
> index 5f8a2a5..07127a4 100644
> --- a/packaging/centos63/cloud.spec
> +++ b/packaging/centos63/cloud.spec
> @@ -81,6 +81,7 @@ Requires: mkisofs
>  Requires: MySQL-python
>  Requires: python-paramiko
>  Requires: ipmitool
> +Requires: util-linux-ng
>  Requires: %{name}-common = %{_ver}
>  Requires: %{name}-awsapi = %{_ver}
>  Obsoletes: cloud-client < 4.1.0
>
>
> On Fri, Oct 11, 2013 at 1:02 PM, Marcus Sorensen wrote:
>
>> Yes, blockdev is a part of the util-linux package, and all but a minimal
>> install should have it. To be safe, we could add 'util-linux' to the deb
>> requires and 'util-linux-ng' to the rpm requires for the agents. Something
>> like:
>>
>> diff --git a/debian/control b/debian/control
>> index 46dd505..72a0fb1 100644
>> --- a/debian/control
>> +++ b/debian/control
>> @@ -22,7 +22,7 @@ Description: CloudStack server library
>>
>>  Package: cloudstack-agent
>>  Architecture: all
>> -Depends: openjdk-6-jre | openjdk-7-jre, cloudstack-common (=
>> ${source:Version}), lsb-base (>= 3.2), libcommons-daemon-java, libjna-java,
>> openssh-client, libvirt0, sysvinit-utils, qemu-kvm, libvirt-bin
>> +Depends: openjdk-6-jre | openjdk-7-jre, cloudstack-common (=
>> ${source:Version}), lsb-base (>= 3.2), libcommons-daemon-java, libjna-java,
>> openssh-client, libvirt0, sysvinit-utils, qemu-kvm, libvirt-bin
>>  Conflicts: cloud-agent, cloud-agent-libs, cloud-agent-deps,
>> cloud-agent-scripts
>>  Description: CloudStack agent
>>   The CloudStack agent is in charge of managing shared computing
>> resources in
>> diff --git a/packaging/centos63/cloud.spec b/packaging/centos63/cloud.spec
>> index 5f8a2a5..07127a4 100644
>> --- a/packaging/centos63/cloud.spec
>> +++ b/packaging/centos63/cloud.spec
>> @@ -81,6 +81,7 @@ Requires: mkisofs
>>  Requires: MySQL-python
>>  Requires: python-paramiko
>>  Requires: ipmitool
>> +Requires: util-linux-ng
>>  Requires: %{name}-common = %{_ver}
>>  Requires: %{name}-awsapi = %{_ver}
>>  Obsoletes: cloud-client < 4.1.0
>>
>> If you wanted to be indepedent of that, you could use sysfs in a
>> roundabout way:
>>
>> marcus@marcus-bsdesk:~/code$ ls -l
>> /dev/disk/by-path/pci-\:00\:1f.2-scsi-0\:0\:0\:0
>> lrwxrwxrwx 1 root root 9 Oct  7 09:25
>> /dev/disk/by-path/pci-:00:1f.2-scsi-0:0:0:0 -> ../../sdc
>>
>> we are pointing to /dev/sdc
>>
>> marcus@marcus-bsdesk:~/code$ cat /sys/block/sdc/size
>> 5860533168
>> *size in sectors*
>>
>> marcus@marcus-bsdesk:~/code$ cat /sys/block/sdc/queue/hw_sector_size
>> 512
>>
>> 5860533168 * 512 = 3000592982016
>>
>> compared to:
>> marcus@marcus-bsdesk:~/code$ sudo blockdev --getsize64 /dev/sdc
>> 3000592982016
>>
>>
>>
>>
>>
>>
>>
>>
>> On Fri, Oct 11, 2013 at 12:36 PM, Mike Tutkowski <
>> mike.tutkow...@solidfire.com> wrote:
>>
>>> Hey Marcus,
>>>
>>> What do you think about me running the following to get the device size
>>> for my PhysicalDisk instances?
>>>
>>> "blockdev --getsize64 /dev/disk/by-path/ip-" + host + "-iscsi-" + iqn +
>>> "-lun-0
>>>
>>> That should work on whatever platforms the KVM agent runs (mainly Ubuntu
>>> and CentOS), right?
>>>
>>> Thanks
>>>
>>>
>>> On Thu, Oct 10, 2013 at 7:56 PM, Mike Tutkowski <
>>> mike.tutkow...@solidfire.com> wrote:
>>>
 I made a bunch of updates, Marcus:


 https://github.com/mike-tutkowski/incubator-cloudstack/commit/c13442eaa228a5ae37d3b13f6c98636de158a908


 On Thu, Oct 10, 2013 at 4:40 PM, Mike Tutkowski <
 mike.tutkow...@solidfire.com> wrote:

> Hey Marcus,
>
> I haven't had a chance to test this yet, but I thought you might be
> interested in the merge of you

Review Request 14605: Fill the creationMonitors based on priority

[Laszlo Hornyak]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14605/
---

Review request for cloudstack and Darren Shepherd.


Repository: cloudstack-git


Description
---

If not priotity, append to the end of the list.


Diffs
-

  engine/orchestration/src/com/cloud/agent/manager/AgentManagerImpl.java 
4202015 

Diff: https://reviews.apache.org/r/14605/diff/


Testing
---

not really, just guessing this is how it was meant (please review)


Thanks,

Laszlo Hornyak

Review Request 14609: Added Categorized Sorting of SnapshotStrategy and DataMotionStrategy

[Chris Suich]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14609/
---

Review request for cloudstack, Darren Shepherd and edison su.


Repository: cloudstack-git


Description
---

I have added a sorting system for SnapshotStrategies and DataMotionStrategies 
to ensure that plugin strategies are asked to handle operations before 
hypervisors and the default strategies.


Diffs
-

  
engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/DataMotionStrategy.java
 6deb6c1 
  
engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/SnapshotStrategy.java
 47e595b 
  
engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/StrategyPriority.java
 PRE-CREATION 
  
engine/api/test/org/apache/cloudstack/engine/subsystem/api/storage/StrategyPriorityTest.java
 PRE-CREATION 
  
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/AncientDataMotionStrategy.java
 fb6962a 
  
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/DataMotionServiceImpl.java
 9f0f531 
  
engine/storage/integration-test/test/org/apache/cloudstack/storage/test/MockStorageMotionStrategy.java
 6c0bd55 
  
engine/storage/integration-test/test/org/apache/cloudstack/storage/test/SnapshotTest.java
 f1eed3a 
  
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/XenserverSnapshotStrategy.java
 aae4cde 
  
plugins/hypervisors/simulator/src/org/apache/cloudstack/storage/motion/SimulatorDataMotionStrategy.java
 05b3e6b 
  
plugins/hypervisors/vmware/src/org/apache/cloudstack/storage/motion/VmwareStorageMotionStrategy.java
 bdba61b 
  
plugins/hypervisors/vmware/test/org/apache/cloudstack/storage/motion/VmwareStorageMotionStrategyTest.java
 b3ea5d5 
  
plugins/hypervisors/xen/src/org/apache/cloudstack/storage/motion/XenServerStorageMotionStrategy.java
 c796b69 
  server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java 0b53cfd 

Diff: https://reviews.apache.org/r/14609/diff/


Testing
---

I have added appropriate tests for the new code and updated appropriate tests 
to handle the new sorting. However, the existing storage tests cannot even be 
run. I am working on finding a way to get those tests to work again (a huge 
spring dependency issue is causing the problem).


Thanks,

Chris Suich

RE: Global setting "host" is not set to MS IP anymore on master

[Soheil Eizadi]

Since I synced my code with 4.3 Master, the Host and Management Network is 
getting properly for me. The storage network is empty.
-Soheil

From: Mike Tutkowski [mike.tutkow...@solidfire.com]
Sent: Friday, October 11, 2013 11:23 AM
To: dev@cloudstack.apache.org
Cc: Prasanna Santhanam
Subject: Re: Global setting "host" is not set to MS IP anymore on master

Yeah, I tend to set up my CS environment manually.

The first thing I do when I log in via the GUI is change the host,
secstorage, and cidr Global Settings and then re-start the management
server.

It would be great if this were not required, of course.


On Fri, Oct 11, 2013 at 11:14 AM, Min Chen  wrote:

> I am also using marvin to deploy my local environment. Do you need to
> restart MS after adding this globalConfig section in our .cfg file? If so,
> developer may be able to workaround this. But this issue still needs to be
> addressed for people not using marvin framework to setup environment, then
> they have to always remember a manual update host step before starting any
> ssvm.
>
> Thanks
> -min
>
> On 10/10/13 9:31 PM, "Prasanna Santhanam"  wrote:
>
> >So, why does setting the 'host' to your IP not work? I do that for the
> >test environment on master as part of deployment via marvin. It's only
> >a small change in the marvin-config.
> >
> >On https://github.com/vogxn/cloud-autodeploy.git
> >
> >commit 8fe580e82fe4ab6dd8e124bf226c5941e72a4204
> >Author: Prasanna Santhanam 
> >Date:   Fri Oct 4 13:53:55 2013 +0530
> >
> >host value in global config defaults to localhost
> >Signed-off-by: Prasanna Santhanam 
> >
> >diff --git a/kvm.cfg b/kvm.cfg
> >index 43b45de..0e23db0 100644
> >--- a/kvm.cfg
> >+++ b/kvm.cfg
> >@@ -152,6 +152,10 @@
> > ],
> > "globalConfig": [
> > {
> >+"name": "host",
> >+"value": "cloudstack-centos63"
> >+},
> >+{
> > "name": "network.gc.wait",
> > "value": "60"
> > },
> >
> >
> >On Thu, Oct 10, 2013 at 11:25:15PM +, Prachi Damle wrote:
> >> I see it on Windows too.
> >>
> >> -Original Message-
> >> From: Alena Prokharchyk [mailto:alena.prokharc...@citrix.com]
> >> Sent: Thursday, October 10, 2013 4:20 PM
> >> To: dev@cloudstack.apache.org; Min Chen
> >> Subject: Re: Global setting "host" is not set to MS IP anymore on master
> >> Importance: High
> >>
> >> I'm facing the same problem on master (OS X v10.8.4 if the platform
> >> matters)
> >>
> >> On 10/10/13 3:22 PM, "Min Chen"  wrote:
> >>
> >> >Hmm? I think that it may be related to new ConfigDepot framework to
> >> >support dynamic config value without restarting MS.
> >> >
> >> >-min
> >> >
> >> >
> >> >
> >> >On 10/10/13 3:00 PM, "Nitin Mehta"  wrote:
> >> >
> >> >>If my memory serves me right this was fixed in 4.2. Maybe the fixer
> >> >>forgot to port it to master ?
> >> >>
> >> >>On 10/10/13 2:46 PM, "Min Chen"  wrote:
> >> >>
> >> >>>Hi there,
> >> >>>
> >> >>>Not sure if others experience the same issue. In 4.2, when MS
> >>starts,
> >> >>>it will discover the IP address of MS and automatically set global
> >> >>>setting "host" to that IP address. Now it seems broken on master, MS
> >> >>>started but "host" is still set to "localhost", which caused my
> >> >>>system vm cannot ping back MS and thus no agent status cannot be
> >> >>>found for system vm, thus this message on my console "INFO
> >> >>>[o.a.c.s.e.DefaultEndPointSelector] (StatsCollector-3:null) No
> >> >>>running ssvm is found, so command will be sent to LocalHostEndPoint".
> >> >>>Anybody has any idea on this?
> >> >>>
> >> >>>Thanks
> >> >>>-min
> >> >>
> >> >
> >> >
> >>
> >
> >--
> >Prasanna.,
> >
> >
> >Powered by BigRock.com
> >
>
>


--
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloud
*™*

Re: Review Request 14577: Remove Setters from *JoinVO Classes

[SuichII, Christopher]

Just bumping this. It should be a fairly simple review.

--
Chris Suich
chris.su...@netapp.com
NetApp Software Engineer
Data Center Platforms – Cloud Solutions
Citrix, Cisco & Red Hat

On Oct 10, 2013, at 1:04 PM, Chris Suich 
mailto:chris.su...@netapp.com>> wrote:

This is an automatically generated e-mail. To reply, visit: 
https://reviews.apache.org/r/14577/

Review request for cloudstack.
By Chris Suich.
Repository: cloudstack-git
Description

Removed setters from all *JoinVO classes as they represent MySQL views which 
are not editable.

The one exception to this was that I left setPassword(String) in UserVmJoinVO. 
This is because the view does not actually have the user's password, but it is 
a field in UseVmJoinVO, so it must be set manually, not auto-populated from the 
DB.


Testing

There were no compile errors after the deletions, so there shouldn't be any 
issues.

However, I did do a clean build and played around with the UI while watching 
vmops.log to make sure there were no errors being thrown over this.


Diffs

  *   server/src/com/cloud/api/query/vo/AccountJoinVO.java (fbcc934)
  *   server/src/com/cloud/api/query/vo/AffinityGroupJoinVO.java (ae63a8a)
  *   server/src/com/cloud/api/query/vo/AsyncJobJoinVO.java (c45be1c)
  *   server/src/com/cloud/api/query/vo/BaseViewVO.java (6b1ddd6)
  *   server/src/com/cloud/api/query/vo/DataCenterJoinVO.java (c6a80e7)
  *   server/src/com/cloud/api/query/vo/DiskOfferingJoinVO.java (58e8370)
  *   server/src/com/cloud/api/query/vo/DomainRouterJoinVO.java (bfe4486)
  *   server/src/com/cloud/api/query/vo/EventJoinVO.java (12d7e5a)
  *   server/src/com/cloud/api/query/vo/HostJoinVO.java (cf3cfdc)
  *   server/src/com/cloud/api/query/vo/ImageStoreJoinVO.java (ac161af)
  *   server/src/com/cloud/api/query/vo/InstanceGroupJoinVO.java (3fb4309)
  *   server/src/com/cloud/api/query/vo/ProjectAccountJoinVO.java (1a8818a)
  *   server/src/com/cloud/api/query/vo/ProjectInvitationJoinVO.java (f6e6760)
  *   server/src/com/cloud/api/query/vo/ProjectJoinVO.java (3885fa0)
  *   server/src/com/cloud/api/query/vo/ResourceTagJoinVO.java (9ce9555)
  *   server/src/com/cloud/api/query/vo/SecurityGroupJoinVO.java (258b613)
  *   server/src/com/cloud/api/query/vo/ServiceOfferingJoinVO.java (05ff5f3)
  *   server/src/com/cloud/api/query/vo/StoragePoolJoinVO.java (d98bb3b)
  *   server/src/com/cloud/api/query/vo/TemplateJoinVO.java (bb1cfed)
  *   server/src/com/cloud/api/query/vo/UserAccountJoinVO.java (c44027b)
  *   server/src/com/cloud/api/query/vo/UserVmJoinVO.java (745db56)
  *   server/src/com/cloud/api/query/vo/VolumeJoinVO.java (9fe9fd1)

View Diff

Re: Review Request 13806: CLOUDSTACK-4407: Use extractTemplate API to get hypervisor specific template information

[Chandan Purushothama]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13806/#review26941
---


test_stopped_vm.py tries to clean up ISOs that are already deleted as part of 
Account Deletion. Do not add iso object to the cleanup list. 

The other two test scripts "test_accounts.py" and "test_blocker_bugs.py" have 
been executed against a KVM deployment and tested. 

- Chandan Purushothama


On Sept. 12, 2013, 9:47 a.m., Girish Shilamkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13806/
> ---
> 
> (Updated Sept. 12, 2013, 9:47 a.m.)
> 
> 
> Review request for cloudstack, venkata swamy babu  budumuru, SrikanteswaraRao 
> Talluri, and Prasanna Santhanam.
> 
> 
> Bugs: CLOUDSTACK-4407
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Template url, hypervisor and format were defined in Service class to be 
> Xenserver specific
> and therefore registering a new template failed on Vmware and KVM.
> Fixed this to get hypervisor specific info for registering new template.
> 
> TODO: Update other tests to use the new function get_builtin_template_info
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_accounts.py 1af408e 
>   test/integration/component/test_blocker_bugs.py 2cdc270 
>   test/integration/component/test_stopped_vm.py 41eeb46 
> 
> Diff: https://reviews.apache.org/r/13806/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Girish Shilamkar
> 
>

[ACS43] [DISCUSS] Release management tasks up for grabs

[Animesh Chaturvedi]

Folks 

As per the thread [1] release management for CloudStack is complex and runs 
into many tasks and it is hard for one person to do it all.

While I am taking the overall release management for 4.3 release there are 
several areas where we need volunteers:


I have put down my thoughts please review and refine as appropriate. 

# Review board management#

- Context: We are lagging severely behind on the reviews of the patches 
submitted and have around 100 pending reviews
- Task Duties:
   * Periodically check on review board [2] for pending reviews
   * If reviewers are not called out for the patch direct the submitter to our 
component maintainers page [3] and help identify the appropriate reviewer
   * Follow up with submitter if they have not responded to review comments in 
5 days
   * Follow up with reviewers if they have not attended to reviews where they 
are called out
   * Reminders can be sent out by either replying to review emails or adding 
comments in review board for the patches
   * Check if a reviewer is overloaded with many pending reviews and call out 
in mailing list that another reviewer to help out is needed
   * Remind the submitter if the BugId, targeted branch is missing
   * Remind the submitter to close out the review when the patch has been 
accepted and submitted in the appropriate branch
   * Close out the review if it submitter for some reason is not able to close 
it out (Administrator privilege is needed) 
   * More details are mentioned in Review board guidelines [4]
- We probably need two volunteers one for code contribution and one for test 
patches contribution 


# Documentation management#

During ACS 4.2 several folks raised questions on insufficient or incorrect 
documentation, this is an area where we need multiple volunteers to come 
forward and help fix documentation


# Jira issues management #

As per thread [5] as community now we have agreed to assign issues. There are 
few things that need to be done to keep the number of unassigned issues  to a 
manageable number:

1. Refine our component list
2. Make the primary maintainers the owners of the components in JIRA, so that 
new issues for the components go to the primary maintainers first instead of 
being unassigned. 
3. Check with INFRA if a workflow can be setup where if an assigned issue is 
not change to InProgres in a week it goes back to un-assigned or to primary 
maintainer of the component (whichever the community prefers)

Workflow:
1. The primary maintainers can redistribute the issues to other community 
members
2. If the assignee can fix the issue promptly they should change the status to 
"In Progress" indicating that issue is being worked on
3. If for whatever reason the assignee is not able to fix the issue they should 
either un-assign or ask someone else to pick up the issue.

Bug triage:
The more hands we can get for bug triage the better it would be so if you want 
to help out please step up.



# Release announcement preparation #

When we are ready to release there are several activities that need to be done 
and we need help.
* Preparing release statement
* Preparing press plan
* Building docs
* Publishing docs to the site



I am sure I may have omitted few important activities feel free to add them to 
the list


[1] http://markmail.org/thread/gkrq2inc2bkupner
[2] https://reviews.apache.org/dashboard/
[3] 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Current+Maintainers+Per+Component
[4] 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Review+Board+Guidelines  

[5] http://markmail.org/thread/vtwod332xqwdmll7


Thanks
Animesh
Committer Apache CloudStack
anim...@apache.org  

Re: Back end volume names in KVM

[Marcus Sorensen]

Done. Tested root/data disks for CLVM, local, NFS.

On Wed, Oct 9, 2013 at 11:32 PM, Marcus Sorensen  wrote:
> Yeah, existing volumes have a path thats already set in stone. It would only
> concern new volumes.
>
> It could cause problems down the line if people get used to them matching
> and decide to use uuid and path interchangeably. They're not by default
> identical though since the path usually contains the directory and
> filename/uuid (at least for qcow2, I think LVM just has the logical volume
> uuid as path).
>
> On Oct 9, 2013 11:21 PM, "Prasanna Santhanam"  wrote:
>>
>> +1 - happens in lots of places in our code where a random-uuid
>> associates with a physical resource's uuid.
>>
>> Will this will happen only for new volumes? Old volumes can still be
>> listed and found using the old method? I'm specifically concerned
>> about upgraded systems.
>>
>> On Wed, Oct 09, 2013 at 11:05:48PM -0600, Mike Tutkowski wrote:
>> > Yeah, I'm not really clear how the snapshot strategy works if you have
>> > multiple vendors that implement that interface either.
>> >
>> >
>> > On Wed, Oct 9, 2013 at 9:57 PM, Marcus Sorensen 
>> > wrote:
>> >
>> > > Does anyone have any reservations about changing the volume identifier
>> > > in
>> > > KVM's volume creation command to be the uuid of the volume? Currently
>> > > for
>> > > new volumes it generates a random uuid and passes that back to be
>> > > stored in
>> > > the database. From an admin perspective, the only way to link a volume
>> > > on
>> > > the back end (be it a qcow2 image or an LVM volume) to one as reported
>> > > is
>> > > to look in the DB and see what this 'secondary uuid' is and look for
>> > > THAT
>> > > as the filename/image name on the back end. It would simply remove a
>> > > layer
>> > > of translating uuid to another hidden uuid to get file/volume name.
>> > >
>> > > It shouldn't disrupt or change current volumes, just new ones.
>> > >
>> > > The only caveat I can think of so far is if we wanted multiple
>> > > files/images
>> > > on the back end to map to one volume, but I don't see that as a
>> > > blocker
>> > > since it would probably have lots of other implications to the
>> > > tracking
>> > > volume objects.
>> > >
>> >
>> >
>> >
>> > --
>> > *Mike Tutkowski*
>> > *Senior CloudStack Developer, SolidFire Inc.*
>> > e: mike.tutkow...@solidfire.com
>> > o: 303.746.7302
>> > Advancing the way the world uses the
>> > cloud
>> > *?*
>>
>> --
>> Prasanna.,
>>
>> 
>> Powered by BigRock.com
>>
>

[DISCUSS] Add upgrade path from 4.2.1 to 4.3.0 in Master branch

[Min Chen]

Hi there,

Based on my understanding, 4.2.1 is scheduled to come before 4.3.0 release. If 
this is true, should we add an upgrade path from 4.2.1 to 4.3.0 in Master? This 
will help us to cherry-pick some commits done in 4.2.1 branch that involves 
schema changes to master. Any objections on this? If not, what will be the 
recommended way to cherry-pick those commits to Master? Merging schema change 
into schema-420to430.sql?

Thanks
-min

RE: [DISCUSS] Add upgrade path from 4.2.1 to 4.3.0 in Master branch

[Animesh Chaturvedi]

> -Original Message-
> From: Min Chen [mailto:min.c...@citrix.com]
> Sent: Friday, October 11, 2013 4:51 PM
> To: dev@cloudstack.apache.org
> Subject: [DISCUSS] Add upgrade path from 4.2.1 to 4.3.0 in Master branch
> 
> Hi there,
> 
> Based on my understanding, 4.2.1 is scheduled to come before 4.3.0
> release. 
[Animesh>] Yes based on Abhi's proposal
If this is true, should we add an upgrade path from 4.2.1 to
> 4.3.0 in Master? 
[Animesh>] Should we wait until we cut 4.3 from master. I will publish the 
schedule for 4.3 soon

This will help us to cherry-pick some commits done in
> 4.2.1 branch that involves schema changes to master. Any objections on
> this? If not, what will be the recommended way to cherry-pick those
> commits to Master? Merging schema change into schema-420to430.sql?
> 
> Thanks
> -min

Patches in reviewboard that were updated over two months ago

[Animesh Chaturvedi]

Folks

Following 27 patches were last updated over 2 months ago

| Review ID | Summary   
 |#Reviews | Submitter| 
People|
| 11861 | double slash fix for windows based nfs servers [CLOUDSTACK-2968]  
 |   2 | dahn | 
jburwell  |
| 12198 | Package switch from com.cloud.network to org.apache.network 
partly solving CLOUDSTACK -212 |   5 | dharmesh 
| ke4qqq sebgoa |
| 13376 | Fix QuickCloud secondary storage service ListTemplateCommand and 
ListVolumeCommand |   1 | dlafferty| 
chiradeep devdeep |
| 11052 | Fix a logging issue in my previsous hypervisor template code. 
 |   1 | fangw| 
edison kelveny|
| 12143 | Template created from snapshot: the vmdk path needs to be 
modified to accomodate the changed snapshot UUID format. |   0 | fangw  
  | edison|
| 11327 | CLOUDSTACK-1194: fix that isolation method does not show in 
Firefox|   3 | kawai
| pranavs   |
|  8294 | Store NetworkServiceProvider connectivity service configuration 
in database.   |   1 | kawai|   
|
| 13402 | Manually assign an IP address for advanced Network in the client  
 |   2 | markerking   | 
markerking|
| 12185 | Remove dependency on backport-util.concurrent, and just use built 
in classes   |   4 | mebigfatguy  | 
  |
| 12192 | set the field 'state' rather than the unread parameter 'state', 
if the parameter is null   |   2 | mebigfatguy  |   
|
| 11479 | SolidFire storage plug-in and enhancements to the storage 
framework and GUI|   6 | mtutkowski 
  | edison jburwell   |
| 12098 | Add PCI Passthrough to CloudStack on KVM Hypervisor   
 |   2 | pawitp   | 
  |
| 10411 | Typos fixed   
 |   2 | pborreli | jzb 
sebgoa|
| 12943 | Replaced virsh() by python-libvirt functions  
 |   3 | RPDiep   | 
widodh|
| 12660 | Replaced multiple grep/awk/head commands by one awk   
 |   2 | RPDiep   | 
widodh|
| 12646 | Truncated trailing/double spaces. 
 |   1 | RPDiep   | 
widodh|
| 12679 | CLOUDSTACK-904: Changed multiple vcpus to one vcpu with multiple 
sockets   |   1 | RPDiep   | 
widodh|
| 12659 | Removed unused script scripts/storage/qcow2/cleanupmyvms.sh   
 |   0 | RPDiep   | 
widodh|
| 12752 | Async commands can inject the job id  
 |   1 | ryandietrich | 
mlsorensen|
| 13020 | CLOUDSTACK-3252 An instance deployed using explicit or implicit 
dedication doesn't generate a usage even   |   2 | Saksham  | 
devdeep kishan|
| 12883 | DNS value in Zone is not getting set in the Network created for 
the Zone   |   3 | seizadi  |   
|
| 10776 | CLOUDSTACK-2191: Added the following to tests to qualify 
"Optional Public IP" changes happend in EIP enabled Zone  |   4 | swamy 
   |   |
| 11462 | add zone wide primary storage tests   
 |   1 | talluri  | 
Sateesh tsp   |
| 13482 | Fix test_snapshots script to choose the right device name while 
mounting and other minor script issues |   1 | talluri  | 
tsp   |
| 11526 | Added a test related to db changes for storage xenmotion  
 |   1 | talluri  | tsp 
  |
| 12126 | Better VM Sync mechanism  
 |   2 | topcloud | 
  |
| 13010 | rb-jenkins-integration test patch 
  

Re: [ACS43] [DISCUSS] Release management tasks up for grabs

[Travis Graham]

Animesh,

I'm volunteering to help out with the docs. I've put a hold on fixing things 
until there's a Review Board in place for cloudstack-docs to make it easier to 
submit patches.

Travis

On Oct 11, 2013, at 7:01 PM, Animesh Chaturvedi  
wrote:

> Folks 
> 
> As per the thread [1] release management for CloudStack is complex and runs 
> into many tasks and it is hard for one person to do it all.
> 
> While I am taking the overall release management for 4.3 release there are 
> several areas where we need volunteers:
> 
> 
> I have put down my thoughts please review and refine as appropriate. 
> 
> # Review board management#
> 
> - Context: We are lagging severely behind on the reviews of the patches 
> submitted and have around 100 pending reviews
> - Task Duties:
>   * Periodically check on review board [2] for pending reviews
>   * If reviewers are not called out for the patch direct the submitter to our 
> component maintainers page [3] and help identify the appropriate reviewer
>   * Follow up with submitter if they have not responded to review comments in 
> 5 days
>   * Follow up with reviewers if they have not attended to reviews where they 
> are called out
>   * Reminders can be sent out by either replying to review emails or adding 
> comments in review board for the patches
>   * Check if a reviewer is overloaded with many pending reviews and call out 
> in mailing list that another reviewer to help out is needed
>   * Remind the submitter if the BugId, targeted branch is missing
>   * Remind the submitter to close out the review when the patch has been 
> accepted and submitted in the appropriate branch
>   * Close out the review if it submitter for some reason is not able to close 
> it out (Administrator privilege is needed) 
>   * More details are mentioned in Review board guidelines [4]
> - We probably need two volunteers one for code contribution and one for test 
> patches contribution 
> 
> 
> # Documentation management#
> 
> During ACS 4.2 several folks raised questions on insufficient or incorrect 
> documentation, this is an area where we need multiple volunteers to come 
> forward and help fix documentation
> 
> 
> # Jira issues management #
> 
> As per thread [5] as community now we have agreed to assign issues. There are 
> few things that need to be done to keep the number of unassigned issues  to a 
> manageable number:
> 
> 1. Refine our component list
> 2. Make the primary maintainers the owners of the components in JIRA, so that 
> new issues for the components go to the primary maintainers first instead of 
> being unassigned. 
> 3. Check with INFRA if a workflow can be setup where if an assigned issue is 
> not change to InProgres in a week it goes back to un-assigned or to primary 
> maintainer of the component (whichever the community prefers)
> 
> Workflow:
> 1. The primary maintainers can redistribute the issues to other community 
> members
> 2. If the assignee can fix the issue promptly they should change the status 
> to "In Progress" indicating that issue is being worked on
> 3. If for whatever reason the assignee is not able to fix the issue they 
> should either un-assign or ask someone else to pick up the issue.
> 
> Bug triage:
> The more hands we can get for bug triage the better it would be so if you 
> want to help out please step up.
> 
> 
> 
> # Release announcement preparation #
> 
> When we are ready to release there are several activities that need to be 
> done and we need help.
> * Preparing release statement
> * Preparing press plan
> * Building docs
> * Publishing docs to the site
> 
> 
> 
> I am sure I may have omitted few important activities feel free to add them 
> to the list
> 
> 
> [1] http://markmail.org/thread/gkrq2inc2bkupner
> [2] https://reviews.apache.org/dashboard/
> [3] 
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Current+Maintainers+Per+Component
> [4] 
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Review+Board+Guidelines
> 
> [5] http://markmail.org/thread/vtwod332xqwdmll7
> 
> 
> Thanks
> Animesh
> Committer Apache CloudStack
> anim...@apache.org
> 

RE: [ACS43] [DISCUSS] Release management tasks up for grabs

[Animesh Chaturvedi]

Travis thanks for your help, really appreciate the offer. Looking forward to 
working closely with you.



> -Original Message-
> From: Travis Graham [mailto:tgra...@tgraham.us]
> Sent: Friday, October 11, 2013 5:34 PM
> To: dev@cloudstack.apache.org
> Subject: Re: [ACS43] [DISCUSS] Release management tasks up for grabs
> 
> Animesh,
> 
> I'm volunteering to help out with the docs. I've put a hold on fixing
> things until there's a Review Board in place for cloudstack-docs to make
> it easier to submit patches.
> 
> Travis
> 
> On Oct 11, 2013, at 7:01 PM, Animesh Chaturvedi
>  wrote:
> 
> > Folks
> >
> > As per the thread [1] release management for CloudStack is complex and
> runs into many tasks and it is hard for one person to do it all.
> >
> > While I am taking the overall release management for 4.3 release there
> are several areas where we need volunteers:
> >
> >
> > I have put down my thoughts please review and refine as appropriate.
> >
> > # Review board management#
> >
> > - Context: We are lagging severely behind on the reviews of the
> > patches submitted and have around 100 pending reviews
> > - Task Duties:
> >   * Periodically check on review board [2] for pending reviews
> >   * If reviewers are not called out for the patch direct the submitter
> to our component maintainers page [3] and help identify the appropriate
> reviewer
> >   * Follow up with submitter if they have not responded to review
> comments in 5 days
> >   * Follow up with reviewers if they have not attended to reviews
> where they are called out
> >   * Reminders can be sent out by either replying to review emails or
> adding comments in review board for the patches
> >   * Check if a reviewer is overloaded with many pending reviews and
> call out in mailing list that another reviewer to help out is needed
> >   * Remind the submitter if the BugId, targeted branch is missing
> >   * Remind the submitter to close out the review when the patch has
> been accepted and submitted in the appropriate branch
> >   * Close out the review if it submitter for some reason is not able
> to close it out (Administrator privilege is needed)
> >   * More details are mentioned in Review board guidelines [4]
> > - We probably need two volunteers one for code contribution and one
> > for test patches contribution
> >
> >
> > # Documentation management#
> >
> > During ACS 4.2 several folks raised questions on insufficient or
> > incorrect documentation, this is an area where we need multiple
> > volunteers to come forward and help fix documentation
> >
> >
> > # Jira issues management #
> >
> > As per thread [5] as community now we have agreed to assign issues.
> There are few things that need to be done to keep the number of
> unassigned issues  to a manageable number:
> >
> > 1. Refine our component list
> > 2. Make the primary maintainers the owners of the components in JIRA,
> so that new issues for the components go to the primary maintainers
> first instead of being unassigned.
> > 3. Check with INFRA if a workflow can be setup where if an assigned
> > issue is not change to InProgres in a week it goes back to un-assigned
> > or to primary maintainer of the component (whichever the community
> > prefers)
> >
> > Workflow:
> > 1. The primary maintainers can redistribute the issues to other
> > community members 2. If the assignee can fix the issue promptly they
> > should change the status to "In Progress" indicating that issue is
> being worked on 3. If for whatever reason the assignee is not able to
> fix the issue they should either un-assign or ask someone else to pick
> up the issue.
> >
> > Bug triage:
> > The more hands we can get for bug triage the better it would be so if
> you want to help out please step up.
> >
> >
> >
> > # Release announcement preparation #
> >
> > When we are ready to release there are several activities that need to
> be done and we need help.
> > * Preparing release statement
> > * Preparing press plan
> > * Building docs
> > * Publishing docs to the site
> >
> >
> >
> > I am sure I may have omitted few important activities feel free to add
> > them to the list
> >
> >
> > [1] http://markmail.org/thread/gkrq2inc2bkupner
> > [2] https://reviews.apache.org/dashboard/
> > [3]
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Current+Maintaine
> rs+Per+Component
> > [4]
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Review+Board+Guid
> elines
> > [5] http://markmail.org/thread/vtwod332xqwdmll7
> >
> >
> > Thanks
> > Animesh
> > Committer Apache CloudStack
> > anim...@apache.org
> >

Re: [DISCUSS] Add upgrade path from 4.2.1 to 4.3.0 in Master branch

[Min Chen]

Then what should we do to cherry-pick some commits from 4.2.1 to master?
No cherry-pick until 4.3 is cut?

Thanks
-min

On 10/11/13 5:25 PM, "Animesh Chaturvedi" 
wrote:

>> -Original Message-
>> From: Min Chen [mailto:min.c...@citrix.com]
>> Sent: Friday, October 11, 2013 4:51 PM
>> To: dev@cloudstack.apache.org
>> Subject: [DISCUSS] Add upgrade path from 4.2.1 to 4.3.0 in Master branch
>> 
>> Hi there,
>> 
>> Based on my understanding, 4.2.1 is scheduled to come before 4.3.0
>> release. 
>[Animesh>] Yes based on Abhi's proposal
>If this is true, should we add an upgrade path from 4.2.1 to
>> 4.3.0 in Master?
>[Animesh>] Should we wait until we cut 4.3 from master. I will publish
>the schedule for 4.3 soon
>
>This will help us to cherry-pick some commits done in
>> 4.2.1 branch that involves schema changes to master. Any objections on
>> this? If not, what will be the recommended way to cherry-pick those
>> commits to Master? Merging schema change into schema-420to430.sql?
>> 
>> Thanks
>> -min
>

[ACS43] Proposed schedule

[Animesh Chaturvedi]

Folks

I would like to propose the following schedule for 4.3. Please note that I have 
pushed it out by 1 week for multiple reasons 
1) Until end of September our focus was on 4.2 and master needs to be 
stabilized before feature freeze
2) The original RC was scheduled closer to Christmas and it seemed impractical 
because of holidays  so I moved it out to January 10th giving us some extra 
time for RC preparation

I would like to also propose that we target 1/31 as our GA date. 

4.3 is expected to be a much smaller release compared to 4.2 and the focus is 
to reduce our technical debt. We have  600+ unresolved issues out of which 400 
are unassigned


=
 4.3 detailed schedule proposal:
 


 2013-11-08
   Feature Freeze
   All new feature need to have been merged into master by this date.
   Release branch will be cut on this date.
   Jenkins updated to include new release branch builds.
 
 2013-11-09 through 2013-12-06
   Testing/Bug Fixes (testing against jenkins artifacts)
   Documentation Finalization
 
 2013-12-06
   Docs Freeze (except release notes and translations)
   Release Branch moves to limited updates only (only commits allowed  in would 
be release blockers fixes, translation updates, etc...)
 
 2013-12-07 through 2014-01-10
   Translation Development and Integration (should be ongoing, but  focused 
effort)
   Final regression testing / bug fixes / doc fixes
 
 2013-01-10
   4.3.0-RC1 is created, and project level VOTE is called

 2013-01-31
   4.3.0 is released

RE: [DISCUSS] Add upgrade path from 4.2.1 to 4.3.0 in Master branch

[Animesh Chaturvedi]

Well I take it back, I think it is easier to add the path now in master

> -Original Message-
> From: Min Chen [mailto:min.c...@citrix.com]
> Sent: Friday, October 11, 2013 6:05 PM
> To: dev@cloudstack.apache.org
> Subject: Re: [DISCUSS] Add upgrade path from 4.2.1 to 4.3.0 in Master
> branch
> 
> Then what should we do to cherry-pick some commits from 4.2.1 to master?
> No cherry-pick until 4.3 is cut?
> 
> Thanks
> -min
> 
> On 10/11/13 5:25 PM, "Animesh Chaturvedi"
> 
> wrote:
> 
> >> -Original Message-
> >> From: Min Chen [mailto:min.c...@citrix.com]
> >> Sent: Friday, October 11, 2013 4:51 PM
> >> To: dev@cloudstack.apache.org
> >> Subject: [DISCUSS] Add upgrade path from 4.2.1 to 4.3.0 in Master
> >> branch
> >>
> >> Hi there,
> >>
> >> Based on my understanding, 4.2.1 is scheduled to come before 4.3.0
> >> release.
> >[Animesh>] Yes based on Abhi's proposal If this is true, should we add
> >an upgrade path from 4.2.1 to
> >> 4.3.0 in Master?
> >[Animesh>] Should we wait until we cut 4.3 from master. I will publish
> >the schedule for 4.3 soon
> >
> >This will help us to cherry-pick some commits done in
> >> 4.2.1 branch that involves schema changes to master. Any objections
> >> on this? If not, what will be the recommended way to cherry-pick
> >> those commits to Master? Merging schema change into schema-
> 420to430.sql?
> >>
> >> Thanks
> >> -min
> >

Re: Why Secondarystroage resourcelimit contains volumes

[sx chen]

Thanks,Nitin
For Upload volume It's OK.
Then I have another question;
If I destroy a vm,the root disk will be romoved too,but data disk is still
on the primary storage,
and state is not "Allocated",So these volumes will be counted as
secondarystorage and they
are actually in the primary storage?


2013/10/12 Nitin Mehta 

> One of the use case where volume is on secondary storage is for the
> uploaded volumes.
> Until they are attached to the vm they reside on secondary storage and
> hence should be counted for secondary storage usage.
>
> On 11/10/13 1:15 AM, "sx chen"  wrote:
>
> >Hi,all:
> >In 4.2,We can limit the secondarystorage usage for a user or a domain.
> >But when I refer to source code ,I find
> >
> >public long calculateSecondaryStorageForAccount(long accountId) {
> >long totalVolumesSize =
> >_volumeDao.secondaryStorageUsedForAccount(accountId);
> >long totalSnapshotsSize =
> >_snapshotDao.secondaryStorageUsedForAccount(accountId);
> >long totalTemplatesSize = 0;
> >
> >SearchCriteria sc = templateSizeSearch.create();
> >sc.setParameters("downloadState", Status.DOWNLOADED);
> >sc.setParameters("destroyed", false);
> >sc.setJoinParameters("templates", "accountId", accountId);
> >List templates = _vmTemplateStoreDao.customSearch(sc,
> >null);
> >if (templates != null) {
> >totalTemplatesSize = templates.get(0).sum;
> >}
> >
> >return totalVolumesSize + totalSnapshotsSize + totalTemplatesSize;
> >}
> >
> >Templates and snapshots are certainly belong to secondarystorage,
> >The volumes which sql is :
> >select sum(size) from volumes where account_id=? and path is null and
> >removed is null and state not in ("ALLOCATED").
> >
> >So my question is why volumes is counted as secondarystorage?
>
>

RE: KVM systemvm not getting IP

[Rajesh Battala]

Acton template won't work. In 4.2 there is a new template. You can check it by 
checking the release version of it. 
4.2  systemvm is generated from debian wheezy.

Thanks
Rajesh Battala

-Original Message-
From: Francois Gaudreault [mailto:fgaudrea...@cloudops.com] 
Sent: Friday, October 11, 2013 9:48 PM
To: dev@cloudstack.apache.org
Subject: Re: KVM systemvm not getting IP

Hmm... How do I know if I am using the old or new :P

I downloaded this one:
http://download.cloud.com/templates/acton/acton-systemvm-02062012.qcow2.bz2

FG

On 10/11/2013, 12:12 PM, Rajesh Battala wrote:
> Hi Francois,
> Are you using the new systemvm template.
> System vm's ip's info (boot args) are passed via socket in 4.2. Please check 
> whether you are using new or old systemvm template.
>
> Thanks
> Rajesh Battala
>
> -Original Message-
> From: Francois Gaudreault [mailto:fgaudrea...@cloudops.com]
> Sent: Friday, October 11, 2013 8:30 PM
> To: dev@cloudstack.apache.org
> Subject: KVM systemvm not getting IP
>
> Anyone faced an issue where the KVM system VM doesn't set IPs on the network 
> interfaces? In fact there is no interfaces definitions in 
> /etc/network/interfaces.
>
> I am using CS 4.2. I re-installed my host to use Ubuntu 13.04 (I have the 
> same behavior on CentOS 6).
>
> --
> Francois Gaudreault
> Architecte de Solution Cloud | Cloud Solutions Architect 
> fgaudrea...@cloudops.com
> 514-629-6775
> - - -
> CloudOps
> 420 rue Guy
> Montréal QC  H3J 1S6
> www.cloudops.com
> @CloudOps_
>
>
>


--
Francois Gaudreault
Architecte de Solution Cloud | Cloud Solutions Architect 
fgaudrea...@cloudops.com
514-629-6775
- - -
CloudOps
420 rue Guy
Montréal QC  H3J 1S6
www.cloudops.com
@CloudOps_

Re: KVM systemvm not getting IP

[Marcus Sorensen]

Look at the qemu log for that specific vm. Are these still system VMS or
user VMS?
On Oct 11, 2013 11:26 AM, "Francois Gaudreault" 
wrote:

> Thanks Kelcey.
>
> My VMs are starting now, but then qemu sends a sigkill and the VM shutdown
> by itself after 40sec or so. Anyone experienced that? I guess this is
> something to bring to the libvirt mailing list :S
>
> Francois
>
> On 10/11/2013, 12:38 PM, Kelcey Jamison Damage wrote:
>
>> That is the old template and won't work with 4.2
>>
>> You can follow one of the methods in http://cloud.kelceydamage.com/**
>> cloudfire/blog/2013/10/08/**conquering-the-cloudstack-4-2-**dragon-kvm/if
>>  you wish to recover your cloud, or you can simply use the updated
>> template link posted and start over again.
>>
>> Thanks.
>>
>> -Kelcey
>>
>> --**--**
>> 
>> *From: *"Francois Gaudreault" 
>> *To: *dev@cloudstack.apache.org
>> *Sent: *Friday, October 11, 2013 9:17:43 AM
>> *Subject: *Re: KVM systemvm not getting IP
>>
>> Hmm... How do I know if I am using the old or new :P
>>
>> I downloaded this one:
>> http://download.cloud.com/**templates/acton/acton-**
>> systemvm-02062012.qcow2.bz2
>>
>> FG
>>
>> On 10/11/2013, 12:12 PM, Rajesh Battala wrote:
>> > Hi Francois,
>> > Are you using the new systemvm template.
>> > System vm's ip's info (boot args) are passed via socket in 4.2. Please
>> check whether you are using new or old systemvm template.
>> >
>> > Thanks
>> > Rajesh Battala
>> >
>> > -Original Message-
>> > From: Francois Gaudreault 
>> > [mailto:fgaudreault@cloudops.**com
>> ]
>> > Sent: Friday, October 11, 2013 8:30 PM
>> > To: dev@cloudstack.apache.org
>> > Subject: KVM systemvm not getting IP
>> >
>> > Anyone faced an issue where the KVM system VM doesn't set IPs on the
>> network interfaces? In fact there is no interfaces definitions in
>> /etc/network/interfaces.
>> >
>> > I am using CS 4.2. I re-installed my host to use Ubuntu 13.04 (I have
>> the same behavior on CentOS 6).
>> >
>> > --
>> > Francois Gaudreault
>> > Architecte de Solution Cloud | Cloud Solutions Architect
>> fgaudrea...@cloudops.com
>> > 514-629-6775
>> > - - -
>> > CloudOps
>> > 420 rue Guy
>> > Montréal QC  H3J 1S6
>> > www.cloudops.com
>> > @CloudOps_
>> >
>> >
>> >
>>
>>
>> --
>> Francois Gaudreault
>> Architecte de Solution Cloud | Cloud Solutions Architect
>> fgaudrea...@cloudops.com
>> 514-629-6775
>> - - -
>> CloudOps
>> 420 rue Guy
>> Montréal QC  H3J 1S6
>> www.cloudops.com
>> @CloudOps_
>>
>>
>>
>
> --
> Francois Gaudreault
> Architecte de Solution Cloud | Cloud Solutions Architect
> fgaudrea...@cloudops.com
> 514-629-6775
> - - -
> CloudOps
> 420 rue Guy
> Montréal QC  H3J 1S6
> www.cloudops.com
> @CloudOps_
>
>