----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14199/ -----------------------------------------------------------
(Updated Oct. 11, 2013, 1:36 p.m.) Review request for cloudstack and Prasanna Santhanam. Changes ------- Review changes. Repository: cloudstack-git Description ------- Adding 5 missing test cases. Change in asyncJobMgr.py >> the method "make_request" in cloudstackConnection does not exist now. Replaced it by "marvin_request". Checked running async jobs with this change. Works correctly. Diffs (updated) ----- test/integration/component/test_snapshots_improvement.py PRE-CREATION tools/marvin/marvin/asyncJobMgr.py 25818a6 Diff: https://reviews.apache.org/r/14199/diff/ Testing (updated) ------- Tested locally on KVM Advanced setup. test_01_concurrent_snapshots_live_migrate (test_snapshots_improvement.TestCreateSnapshot) Test perform concurrent snapshots and migrate the vm from one host ... ok test_02_stop_vm_concurrent_snapshots (test_snapshots_improvement.TestCreateSnapshot) Test stop running VM while performing concurrent snapshot on volume ... ok test_03_concurrent_snapshots_create_template (test_snapshots_improvement.TestCreateSnapshot) Test while parent concurrent snapshot job in progress,create ... ok test_04_concurrent_snapshots_create_volume (test_snapshots_improvement.TestCreateSnapshot) Test while parent concurrent snapshot job in progress,create volume ... ok test_01_snapshot_on_rootVolume (test_snapshots_improvement.TestSnapshotOnRootVolume) Test create VM with default cent os template and create snapshot ... ok ---------------------------------------------------------------------- Ran 5 tests in 1420.575s OK Thanks, Gaurav Aradhye
