----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14320/ -----------------------------------------------------------
(Updated Oct. 11, 2013, 11:23 a.m.) Review request for cloudstack, Chiradeep Vittal and Wei Zhou. Changes ------- summary and description changed Summary (updated) ----------------- add boolean option keepAliveEnabled to the network offering for use in haproxy conf Bugs: CLOUDSTACK-4328 Repository: cloudstack-git Description (updated) ------- add boolean option keepAliveEnabled to the network offering for use in haproxy conf. It should have no consequence for any of the supported hardware loadbalncers. Diffs ----- api/src/com/cloud/offering/NetworkOffering.java 6c5573e api/src/org/apache/cloudstack/api/ApiConstants.java f85784b api/src/org/apache/cloudstack/api/command/admin/network/CreateNetworkOfferingCmd.java bdad904 api/src/org/apache/cloudstack/api/command/admin/network/UpdateNetworkOfferingCmd.java c9c4c8a core/src/com/cloud/agent/api/routing/LoadBalancerConfigCommand.java ee29290 core/src/com/cloud/network/HAProxyConfigurator.java 2309125 core/test/com/cloud/network/HAProxyConfiguratorTest.java PRE-CREATION engine/components-api/src/com/cloud/configuration/ConfigurationManager.java 5e1b9b5 engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java 3c4b1ed engine/schema/src/com/cloud/offerings/NetworkOfferingVO.java eefdc94 plugins/network-elements/elastic-loadbalancer/src/com/cloud/network/lb/ElasticLoadBalancerManagerImpl.java 3f8fc5c plugins/network-elements/internal-loadbalancer/src/org/apache/cloudstack/network/lb/InternalLoadBalancerVMManagerImpl.java 5da6e02 server/src/com/cloud/configuration/ConfigurationManagerImpl.java 4fda3b1 server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 5ea7560 server/test/com/cloud/vpc/MockConfigurationManagerImpl.java c9a0480 server/test/org/apache/cloudstack/networkoffering/CreateNetworkOfferingTest.java 1f1fb75 setup/db/db/schema-420to430.sql a765189 Diff: https://reviews.apache.org/r/14320/diff/ Testing ------- created unit test. instantiated a network with some loadbalancer rule based on a netoffer with the option to true/false and maxconnections to a non default value -> checked haproxy.cfg on the router Thanks, daan Hoogland
