[GitHub] [cloudstack] blueorangutan commented on issue #3680: [WIP: DO NOT MERGE] CloudStack Kubernetes Service
blueorangutan commented on issue #3680: [WIP: DO NOT MERGE] CloudStack Kubernetes Service URL: https://github.com/apache/cloudstack/pull/3680#issuecomment-594383860 Packaging result: ✖centos6 ✔centos7 ✔debian. JID-995 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3925: Add cache mode param properly
DaanHoogland commented on a change in pull request #3925: Add cache mode param properly URL: https://github.com/apache/cloudstack/pull/3925#discussion_r387507603 ## File path: test/integration/smoke/test_service_offerings.py ## @@ -129,6 +129,110 @@ def test_01_create_service_offering(self): "Check name in createServiceOffering" ) return + +@attr( +tags=[ +"advanced", +"advancedns", +"smoke", +"basic", +"eip", +"sg"], +required_hardware="false") +def test_02_create_service_offering_with_cache_mode_type(self): Review comment: again, why not add as test_03 and test_04? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3925: Add cache mode param properly
DaanHoogland commented on a change in pull request #3925: Add cache mode param
properly
URL: https://github.com/apache/cloudstack/pull/3925#discussion_r387500896
##
File path:
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java
##
@@ -2936,6 +2948,11 @@ public DiskOffering createDiskOffering(final
CreateDiskOfferingCmd cmd) {
throw new InvalidParameterValueException("Disksize is not allowed
for a customized disk offering");
}
+// check if valid cache_mode parameter
+if(cmd.getCacheMode() != null &&
!Enums.getIfPresent(DiskOffering.DiskCacheMode.class,
cmd.getCacheMode().toUpperCase()).isPresent()){
+throw new InvalidParameterValueException("Please specify a valid
cache mode parameter");
+}
+
Review comment:
can you put this in its own method.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3925: Add cache mode param properly
DaanHoogland commented on a change in pull request #3925: Add cache mode param
properly
URL: https://github.com/apache/cloudstack/pull/3925#discussion_r387498637
##
File path:
api/src/main/java/org/apache/cloudstack/api/response/ServiceOfferingResponse.java
##
@@ -192,6 +192,10 @@
@Param(description = "is true if the offering is customized", since =
"4.3.0")
private Boolean isCustomized;
+@SerializedName("cacheMode")
+@Param(description = "the cache mode to use for this disk offering. none,
writeback or writethrough", since = "4.4")
Review comment:
"since" on the return @Param as attribute but not on the request @Parameter
in the API. Probably C&P as i don't think you are planning this for the 4.4
branch! please adjust and expand (or remove)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3925: Add cache mode param properly
DaanHoogland commented on a change in pull request #3925: Add cache mode param properly URL: https://github.com/apache/cloudstack/pull/3925#discussion_r387507238 ## File path: test/integration/smoke/test_disk_offerings.py ## @@ -90,9 +90,81 @@ def test_01_create_disk_offering(self): ) return +@attr(tags=["advanced", "basic", "eip", "sg", "advancedns", "smoke"], required_hardware="false") +def test_02_create_disk_offering_with_cache_mode_type(self): Review comment: Why this renumbering/renaming? It can break statistic analysis of test breakage or comparison. Why not add them to the end with new numbers? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3910: Jdk11 auto select on upgrade
blueorangutan commented on issue #3910: Jdk11 auto select on upgrade URL: https://github.com/apache/cloudstack/pull/3910#issuecomment-594389041 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3910: Jdk11 auto select on upgrade
rhtyd commented on issue #3910: Jdk11 auto select on upgrade URL: https://github.com/apache/cloudstack/pull/3910#issuecomment-594388867 @DaanHoogland it's the java/jre team that removed stuff in java11 for example. We cannot run jdk8 built mgmt server against jre-11; we expect it should work but it doesnot. Besides, per the LTS schedule jdk11 is the latest lts, other java releases 12,13,14 are fast releases not and we shouldn't use them in production. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3910: Jdk11 auto select on upgrade
rhtyd commented on issue #3910: Jdk11 auto select on upgrade URL: https://github.com/apache/cloudstack/pull/3910#issuecomment-594388963 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3927: ui: fix merge issue that causes VR duplicates
DaanHoogland commented on a change in pull request #3927: ui: fix merge issue
that causes VR duplicates
URL: https://github.com/apache/cloudstack/pull/3927#discussion_r387512908
##
File path: ui/scripts/system.js
##
@@ -9996,7 +9996,7 @@
}
$.ajax({
-url:
createURL("listRouters&listAll=true&page=" + args.page + "&pagesize=" +
pageSize + array1.join("") + "&projectid=-1"),
+url:
createURL("listRouters&page=" + args.page + "&pagesize=" + pageSize +
array1.join("") + "&projectid=-1"),
Review comment:
```
listall | If set to false, list only resources belonging to the command's
caller; if set to true - list resources that the caller is authorized to see.
Default value is false
```
so if the admin calls this and a router would not belong to them... I'll
test some scenarios
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland edited a comment on issue #3031: VMware basic zone VR fails to start and get private IP
DaanHoogland edited a comment on issue #3031: VMware basic zone VR fails to start and get private IP URL: https://github.com/apache/cloudstack/issues/3031#issuecomment-593933513 reinstalled a 4.11.3; systemvm come up but the console proxy does shows consoles for neither cpvm nor ssvm. registering a template works. (ssvm works, as it is confirmed present on the backend storage) router is started on compute backend but never changes status to started in ACS Same symptoms in 4.9.3.1; ip 0.0.0.0 is send for eth1. Double checked 4.9 kvm. This works fine. 4.8 issue already there. 4.5 vmware basic zone works. xen not tested at all so far. xen and kvm tested in version 4.6: both work. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland edited a comment on issue #3031: VMware basic zone VR fails to start and get private IP
DaanHoogland edited a comment on issue #3031: VMware basic zone VR fails to start and get private IP URL: https://github.com/apache/cloudstack/issues/3031#issuecomment-593933513 reinstalled a 4.11.3; systemvm come up but the console proxy does shows consoles for neither cpvm nor ssvm. registering a template works. (ssvm works, as it is confirmed present on the backend storage) router is started on compute backend but never changes status to started in ACS Same symptoms in 4.9.3.1; ip 0.0.0.0 is send for eth1. Double checked 4.9 kvm. This works fine. 4.8 issue already there. 4.5 vmware basic zone works. ~~xen not tested at all so far.~~ xen and kvm tested in version 4.6: both work. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3928: maven: update dependencies
rhtyd commented on issue #3928: maven: update dependencies URL: https://github.com/apache/cloudstack/pull/3928#issuecomment-594413087 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3928: maven: update dependencies
blueorangutan commented on issue #3928: maven: update dependencies URL: https://github.com/apache/cloudstack/pull/3928#issuecomment-594413250 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd opened a new pull request #3928: maven: update dependencies
rhtyd opened a new pull request #3928: maven: update dependencies URL: https://github.com/apache/cloudstack/pull/3928 Updates few maven dependencies ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [x] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3927: ui: fix merge issue that causes VR duplicates
rhtyd commented on issue #3927: ui: fix merge issue that causes VR duplicates URL: https://github.com/apache/cloudstack/pull/3927#issuecomment-594414776 @DaanHoogland please merge once you've tested and are satisfied This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] wido commented on issue #3925: Add cache mode param properly
wido commented on issue #3925: Add cache mode param properly URL: https://github.com/apache/cloudstack/pull/3925#issuecomment-594420255 @GabrielBrascher Can you take a look at this? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack-primate] branch master updated: package: bump antd to v1.4.12
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-primate.git
The following commit(s) were added to refs/heads/master by this push:
new 2628b64 package: bump antd to v1.4.12
2628b64 is described below
commit 2628b64f7d2fffba9586d8522241906dba6ed5af
Author: Rohit Yadav
AuthorDate: Wed Mar 4 15:15:59 2020 +0530
package: bump antd to v1.4.12
Signed-off-by: Rohit Yadav
---
package-lock.json | 6 +++---
package.json | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/package-lock.json b/package-lock.json
index 2f63c6e..0baa417 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -5659,9 +5659,9 @@
"dev": true
},
"ant-design-vue": {
- "version": "1.4.11",
- "resolved":
"https://registry.npmjs.org/ant-design-vue/-/ant-design-vue-1.4.11.tgz";,
- "integrity":
"sha512-XwddZpasH8WuWSxvDHakSZSuKAMi1KVbLP49nWpYxCpAk/MiSTsMZvsmxA6BaSoRwSTJ57Y6WJJZ6fOJSR/nxg==",
+ "version": "1.4.12",
+ "resolved":
"https://registry.npmjs.org/ant-design-vue/-/ant-design-vue-1.4.12.tgz";,
+ "integrity":
"sha512-m+hWKF208DN8XX4s4BHCnh+XlUhJy8FUs13a9+jtZCoiQB2zpZdafJeu1LEcFaFlK7fxXfp61fWJJJm0S6ek0g==",
"requires": {
"@ant-design/icons": "^2.1.1",
"@ant-design/icons-vue": "^2.0.0",
diff --git a/package.json b/package.json
index 2826f0d..61ac969 100644
--- a/package.json
+++ b/package.json
@@ -38,7 +38,7 @@
"@fortawesome/free-regular-svg-icons": "^5.12.1",
"@fortawesome/free-solid-svg-icons": "^5.12.1",
"@fortawesome/vue-fontawesome": "^0.1.9",
-"ant-design-vue": "~1.4.11",
+"ant-design-vue": "~1.4.12",
"axios": "^0.19.2",
"core-js": "^3.6.4",
"enquire.js": "^2.1.6",
[GitHub] [cloudstack] DaanHoogland commented on issue #3927: ui: fix merge issue that causes VR duplicates
DaanHoogland commented on issue #3927: ui: fix merge issue that causes VR duplicates URL: https://github.com/apache/cloudstack/pull/3927#issuecomment-594423821 tested with isolated vpc and shared as user and admin This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland merged pull request #3927: ui: fix merge issue that causes VR duplicates
DaanHoogland merged pull request #3927: ui: fix merge issue that causes VR duplicates URL: https://github.com/apache/cloudstack/pull/3927 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland closed issue #3926: VRs listed twice in GUI
DaanHoogland closed issue #3926: VRs listed twice in GUI URL: https://github.com/apache/cloudstack/issues/3926 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch master updated (318924d -> 8597f37)
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 318924d CloudStack Backup & Recovery Framework (#3553) add 8597f37 ui: fix merge issue that causes VR duplicates (#3927) No new revisions were added by this update. Summary of changes: ui/scripts/system.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
[GitHub] [cloudstack] blueorangutan commented on issue #3928: maven: update dependencies
blueorangutan commented on issue #3928: maven: update dependencies URL: https://github.com/apache/cloudstack/pull/3928#issuecomment-594425517 Packaging result: ✖centos6 ✔centos7 ✔debian. JID-996 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack-primate] branch master updated (2628b64 -> 1c1e707)
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-primate.git.
from 2628b64 package: bump antd to v1.4.12
add 1c1e707 storage: resize volume form (#171)
No new revisions were added by this update.
Summary of changes:
src/config/section/storage.js | 3 +-
src/views/storage/CreateVolume.vue | 3 +-
.../storage/{CreateVolume.vue => ResizeVolume.vue} | 116 -
3 files changed, 49 insertions(+), 73 deletions(-)
copy src/views/storage/{CreateVolume.vue => ResizeVolume.vue} (58%)
[GitHub] [cloudstack] rhtyd commented on issue #3928: maven: update dependencies
rhtyd commented on issue #3928: maven: update dependencies URL: https://github.com/apache/cloudstack/pull/3928#issuecomment-594491752 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3928: maven: update dependencies
blueorangutan commented on issue #3928: maven: update dependencies URL: https://github.com/apache/cloudstack/pull/3928#issuecomment-594491844 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] ustcweizhou opened a new pull request #3929: server: fix vm migration failed if iso is attached
ustcweizhou opened a new pull request #3929: server: fix vm migration failed if iso is attached URL: https://github.com/apache/cloudstack/pull/3929 ## Description If vm has attached ISO, the migration fails with error message "org.libvirt.LibvirtException: Cannot access storage file /mnt/b33e5a1d-e4ea-3465-b6ac-c98dc8ff8af0/207-2-cc5fd717-2d57-3bb3-bcf6-2c930268db6c.iso" This issue happens after #2983 is merged. ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [X] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## Screenshots (if appropriate): ## How Has This Been Tested? create vm register ISO attach ISO to vm migrate vm all work fine. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] ustcweizhou commented on issue #3929: server: fix vm migration failed if iso is attached
ustcweizhou commented on issue #3929: server: fix vm migration failed if iso is attached URL: https://github.com/apache/cloudstack/pull/3929#issuecomment-594506161 @nvazquez could you please review/test it ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] nvazquez opened a new pull request #3930: Remove unused guest OS mapping class from Vmware code
nvazquez opened a new pull request #3930: Remove unused guest OS mapping class from Vmware code URL: https://github.com/apache/cloudstack/pull/3930 ## Description Remove unused class for guest OS - Vmware mappings. Mappings are checked from DB (guest_os_hypervisor table) ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [x] Cleanup (Code refactoring and cleanup, that may add test cases) ## Screenshots (if appropriate): ## How Has This Been Tested? Class is not referenced elsewhere This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] nvazquez commented on issue #3930: Remove unused guest OS mapping class from Vmware code
nvazquez commented on issue #3930: Remove unused guest OS mapping class from Vmware code URL: https://github.com/apache/cloudstack/pull/3930#issuecomment-594508968 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3930: Remove unused guest OS mapping class from Vmware code
blueorangutan commented on issue #3930: Remove unused guest OS mapping class from Vmware code URL: https://github.com/apache/cloudstack/pull/3930#issuecomment-594509431 @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3930: Remove unused guest OS mapping class from Vmware code
blueorangutan commented on issue #3930: Remove unused guest OS mapping class from Vmware code URL: https://github.com/apache/cloudstack/pull/3930#issuecomment-594522801 Packaging result: ✖centos6 ✔centos7 ✔debian. JID-997 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3930: Remove unused guest OS mapping class from Vmware code
blueorangutan commented on issue #3930: Remove unused guest OS mapping class from Vmware code URL: https://github.com/apache/cloudstack/pull/3930#issuecomment-594544356 @andrijapanicsb I understand these words: "help", "hello", "thanks", "package", "test" Test command usage: test [mgmt os] [hypervisor] [additional tests] Mgmt OS options: ['centos6', 'centos7', 'ubuntu'] Hypervisor options: ['kvm-centos6', 'kvm-centos7', 'kvm-ubuntu', 'xenserver-71', 'xenserver-65sp1', 'xenserver-62sp1', 'vmware-67u3', 'vmware-65u2', 'vmware-60u2', 'vmware-55u3', 'vmware-51u1', 'vmware-50u1'] Additional tests: list of space separated tests with paths relative to the `test/integration` directory, for example: component/test_acl_listvm.py component/test_volumes.py Note: when additional tests are passed, you need to specify mgmt server os and hypervisor or use the `matrix` command. Blessed contributors for kicking Trillian test jobs: ['rhtyd', 'nvazquez', 'PaulAngus', 'borisstoyanov', 'DaanHoogland', 'shwstppr', 'andrijapanicsb', 'Spaceman1984', 'Pearl1594', 'davidjumani', 'harikrishna-patnala'] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3930: Remove unused guest OS mapping class from Vmware code
andrijapanicsb commented on issue #3930: Remove unused guest OS mapping class from Vmware code URL: https://github.com/apache/cloudstack/pull/3930#issuecomment-594544223 @blueorangutan help This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3930: Remove unused guest OS mapping class from Vmware code
blueorangutan commented on issue #3930: Remove unused guest OS mapping class from Vmware code URL: https://github.com/apache/cloudstack/pull/3930#issuecomment-594544935 @andrijapanicsb unsupported parameters provided. Supported mgmt server os are: `centos6, centos7, ubuntu`. Supported hypervisors are: `kvm-centos6, kvm-centos7, kvm-ubuntu, xenserver-71, xenserver-65sp1, xenserver-62sp1, vmware-67u3, vmware-65u2, vmware-60u2, vmware-55u3, vmware-51u1, vmware-50u1` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3930: Remove unused guest OS mapping class from Vmware code
andrijapanicsb commented on issue #3930: Remove unused guest OS mapping class from Vmware code URL: https://github.com/apache/cloudstack/pull/3930#issuecomment-594544748 @blueorangutan test centos7 + vmware-67u3 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3902: vrouter: Save PlaceHolder nic for VR if network does not have source nat
blueorangutan commented on issue #3902: vrouter: Save PlaceHolder nic for VR if network does not have source nat URL: https://github.com/apache/cloudstack/pull/3902#issuecomment-594546288 Trillian test result (tid-1182) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 24557 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3902-t1182-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Smoke tests completed. 75 look OK, 2 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_02_vpc_privategw_static_routes | `Failure` | 176.19 | test_privategw_acl.py test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 172.05 | test_privategw_acl.py test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 200.19 | test_vpc_redundant.py test_02_redundant_VPC_default_routes | `Failure` | 198.98 | test_vpc_redundant.py test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 125.37 | test_vpc_redundant.py test_04_rvpc_network_garbage_collector_nics | `Failure` | 85.93 | test_vpc_redundant.py test_05_rvpc_multi_tiers | `Failure` | 169.31 | test_vpc_redundant.py test_05_rvpc_multi_tiers | `Error` | 195.32 | test_vpc_redundant.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan removed a comment on issue #3930: Remove unused guest OS mapping class from Vmware code
blueorangutan removed a comment on issue #3930: Remove unused guest OS mapping class from Vmware code URL: https://github.com/apache/cloudstack/pull/3930#issuecomment-594544356 @andrijapanicsb I understand these words: "help", "hello", "thanks", "package", "test" Test command usage: test [mgmt os] [hypervisor] [additional tests] Mgmt OS options: ['centos6', 'centos7', 'ubuntu'] Hypervisor options: ['kvm-centos6', 'kvm-centos7', 'kvm-ubuntu', 'xenserver-71', 'xenserver-65sp1', 'xenserver-62sp1', 'vmware-67u3', 'vmware-65u2', 'vmware-60u2', 'vmware-55u3', 'vmware-51u1', 'vmware-50u1'] Additional tests: list of space separated tests with paths relative to the `test/integration` directory, for example: component/test_acl_listvm.py component/test_volumes.py Note: when additional tests are passed, you need to specify mgmt server os and hypervisor or use the `matrix` command. Blessed contributors for kicking Trillian test jobs: ['rhtyd', 'nvazquez', 'PaulAngus', 'borisstoyanov', 'DaanHoogland', 'shwstppr', 'andrijapanicsb', 'Spaceman1984', 'Pearl1594', 'davidjumani', 'harikrishna-patnala'] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3930: Remove unused guest OS mapping class from Vmware code
andrijapanicsb commented on issue #3930: Remove unused guest OS mapping class from Vmware code URL: https://github.com/apache/cloudstack/pull/3930#issuecomment-594546409 @blueorangutan test centos7 vmware-67u3 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan removed a comment on issue #3930: Remove unused guest OS mapping class from Vmware code
blueorangutan removed a comment on issue #3930: Remove unused guest OS mapping class from Vmware code URL: https://github.com/apache/cloudstack/pull/3930#issuecomment-594544935 @andrijapanicsb unsupported parameters provided. Supported mgmt server os are: `centos6, centos7, ubuntu`. Supported hypervisors are: `kvm-centos6, kvm-centos7, kvm-ubuntu, xenserver-71, xenserver-65sp1, xenserver-62sp1, vmware-67u3, vmware-65u2, vmware-60u2, vmware-55u3, vmware-51u1, vmware-50u1` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3930: Remove unused guest OS mapping class from Vmware code
blueorangutan commented on issue #3930: Remove unused guest OS mapping class from Vmware code URL: https://github.com/apache/cloudstack/pull/3930#issuecomment-594546665 @andrijapanicsb a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] andrijapanicsb removed a comment on issue #3930: Remove unused guest OS mapping class from Vmware code
andrijapanicsb removed a comment on issue #3930: Remove unused guest OS mapping class from Vmware code URL: https://github.com/apache/cloudstack/pull/3930#issuecomment-594544748 @blueorangutan test centos7 + vmware-67u3 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3929: server: fix vm migration failed if iso is attached
blueorangutan commented on issue #3929: server: fix vm migration failed if iso is attached URL: https://github.com/apache/cloudstack/pull/3929#issuecomment-594547702 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3929: server: fix vm migration failed if iso is attached
rhtyd commented on issue #3929: server: fix vm migration failed if iso is attached URL: https://github.com/apache/cloudstack/pull/3929#issuecomment-594547609 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] borisstoyanov opened a new issue #3931: VRs are being displayed twice
borisstoyanov opened a new issue #3931: VRs are being displayed twice URL: https://github.com/apache/cloudstack/issues/3931 # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ UI ~~~ # CLOUDSTACK VERSION ~~~ 4.14 ~~~ # CONFIGURATION   # SUMMARY VRs are being displayed 2 times This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] borisstoyanov commented on issue #3931: VRs are being displayed twice
borisstoyanov commented on issue #3931: VRs are being displayed twice URL: https://github.com/apache/cloudstack/issues/3931#issuecomment-594556557 It'll be good if we can get this in 4.14 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] GabrielBrascher opened a new pull request #3932: Prevent overflow and null pointer on StatsCollector.java
GabrielBrascher opened a new pull request #3932: Prevent overflow and null pointer on StatsCollector.java URL: https://github.com/apache/cloudstack/pull/3932 ## Description Did a quick check and found some code issues that can result in overflow or null pointer exceptions. Additionally, I took the liberty to do a couple of code enhancements. ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [X] Bug fix (non-breaking change which fixes an issue) - [X] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3929: server: fix vm migration failed if iso is attached
blueorangutan commented on issue #3929: server: fix vm migration failed if iso is attached URL: https://github.com/apache/cloudstack/pull/3929#issuecomment-594559801 Packaging result: ✖centos6 ✔centos7 ✔debian. JID-998 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3931: VRs are being displayed twice
rhtyd commented on issue #3931: VRs are being displayed twice URL: https://github.com/apache/cloudstack/issues/3931#issuecomment-594566269 Can test against latest master @borisstoyanov, a fix was merged today cc @DaanHoogland @andrijapanicsb This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] borisstoyanov commented on issue #3931: VRs are being displayed twice
borisstoyanov commented on issue #3931: VRs are being displayed twice URL: https://github.com/apache/cloudstack/issues/3931#issuecomment-594567223 nice This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland closed issue #3931: VRs are being displayed twice
DaanHoogland closed issue #3931: VRs are being displayed twice URL: https://github.com/apache/cloudstack/issues/3931 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3931: VRs are being displayed twice
DaanHoogland commented on issue #3931: VRs are being displayed twice URL: https://github.com/apache/cloudstack/issues/3931#issuecomment-594567464 #3927 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #3932: Prevent overflow and null pointer on StatsCollector.java
GabrielBrascher commented on a change in pull request #3932: Prevent overflow
and null pointer on StatsCollector.java
URL: https://github.com/apache/cloudstack/pull/3932#discussion_r387706608
##
File path: server/src/main/java/com/cloud/server/StatsCollector.java
##
@@ -1209,7 +1212,7 @@ private String getAutoscaleAction(HashMap
avgCounter, long groupId
for (AutoScaleVmGroupPolicyMapVO asVmgPmap : listMap) {
AutoScalePolicyVO policyVO =
_asPolicyDao.findById(asVmgPmap.getPolicyId());
if (policyVO != null) {
-Integer quitetime = policyVO.getQuietTime();
Review comment:
The variable 'quitetime' is only assigned values of primitive type and is
never 'null', but it is declared with the boxed type 'Integer'.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #3932: Prevent overflow and null pointer on StatsCollector.java
GabrielBrascher commented on a change in pull request #3932: Prevent overflow and null pointer on StatsCollector.java URL: https://github.com/apache/cloudstack/pull/3932#discussion_r387720059 ## File path: server/src/main/java/com/cloud/server/StatsCollector.java ## @@ -1533,7 +1536,7 @@ protected void writeBatches(InfluxDB influxDbConnection, String dbName, List
[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #3932: Prevent overflow and null pointer on StatsCollector.java
GabrielBrascher commented on a change in pull request #3932: Prevent overflow
and null pointer on StatsCollector.java
URL: https://github.com/apache/cloudstack/pull/3932#discussion_r387705945
##
File path: server/src/main/java/com/cloud/server/StatsCollector.java
##
@@ -454,8 +456,9 @@ protected void init(Map configs) {
s_logger.warn("Usage stats job aggregation range is to small,
using the minimum value of " + UsageUtils.USAGE_AGGREGATION_RANGE_MIN);
_usageAggregationRange = UsageUtils.USAGE_AGGREGATION_RANGE_MIN;
}
-_diskStatsUpdateExecutor.scheduleAtFixedRate(new
VmDiskStatsUpdaterTask(), (endDate - System.currentTimeMillis()),
(_usageAggregationRange * 60 * 1000),
Review comment:
Potential overflow in 2 Values before it is converted to long by use in an
invocation context.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] nvazquez commented on issue #3828: [KVM] Direct download agnostic of the storage provider
nvazquez commented on issue #3828: [KVM] Direct download agnostic of the storage provider URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-594582539 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3828: [KVM] Direct download agnostic of the storage provider
blueorangutan commented on issue #3828: [KVM] Direct download agnostic of the storage provider URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-594583438 @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] nvazquez commented on issue #3929: server: fix vm migration failed if iso is attached
nvazquez commented on issue #3929: server: fix vm migration failed if iso is attached URL: https://github.com/apache/cloudstack/pull/3929#issuecomment-594595307 Hi @ustcweizhou, I've also provided a fix within this PR: #3828, specifically this commit: https://github.com/apache/cloudstack/pull/3828/commits/2102864e8a57ae39a71d4839928923e43554bdff prepareIso will select the ISO from primary or secondary storage depending if the template is direct download or not This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] nvazquez edited a comment on issue #3929: server: fix vm migration failed if iso is attached
nvazquez edited a comment on issue #3929: server: fix vm migration failed if iso is attached URL: https://github.com/apache/cloudstack/pull/3929#issuecomment-594595307 Hi @ustcweizhou, I've also provided a fix within this PR: #3828, specifically this commit: https://github.com/apache/cloudstack/pull/3828/commits/2102864e8a57ae39a71d4839928923e43554bdff prepareIso() will select the ISO from primary or secondary storage depending if the template is direct download or not This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3828: [KVM] Direct download agnostic of the storage provider
blueorangutan commented on issue #3828: [KVM] Direct download agnostic of the storage provider URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-594605346 Packaging result: ✖centos6 ✔centos7 ✔debian. JID-999 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] radu-todirica commented on issue #3925: Add cache mode param properly
radu-todirica commented on issue #3925: Add cache mode param properly URL: https://github.com/apache/cloudstack/pull/3925#issuecomment-594624679 Did the changes. @DaanHoogland please take a look. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3932: Prevent overflow and null pointer on StatsCollector.java
blueorangutan commented on issue #3932: Prevent overflow and null pointer on StatsCollector.java URL: https://github.com/apache/cloudstack/pull/3932#issuecomment-594624627 @GabrielBrascher a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] GabrielBrascher commented on issue #3932: Prevent overflow and null pointer on StatsCollector.java
GabrielBrascher commented on issue #3932: Prevent overflow and null pointer on StatsCollector.java URL: https://github.com/apache/cloudstack/pull/3932#issuecomment-594624173 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3924: Fixed error on data volumes lager than 2.14TB when creating instances on VMware
blueorangutan commented on issue #3924: Fixed error on data volumes lager than 2.14TB when creating instances on VMware URL: https://github.com/apache/cloudstack/pull/3924#issuecomment-594631447 Trillian test result (tid-1181) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7 Total time taken: 31627 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3924-t1181-vmware-67u3.zip Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py Smoke tests completed. 75 look OK, 2 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_02_vpc_privategw_static_routes | `Failure` | 254.03 | test_privategw_acl.py test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 261.98 | test_privategw_acl.py test_04_rvpc_privategw_static_routes | `Failure` | 392.62 | test_privategw_acl.py test_05_stop_ssvm | `Failure` | 41.41 | test_ssvm.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3828: [KVM] Direct download agnostic of the storage provider
blueorangutan commented on issue #3828: [KVM] Direct download agnostic of the storage provider URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-594636282 Trillian test result (tid-1183) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 30769 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3828-t1183-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py Intermittent failure detected: /marvin/tests/smoke/test_loadbalance.py Smoke tests completed. 81 look OK, 0 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] weizhouapache commented on issue #3929: server: fix vm migration failed if iso is attached
weizhouapache commented on issue #3929: server: fix vm migration failed if iso is attached URL: https://github.com/apache/cloudstack/pull/3929#issuecomment-594636554 > Hi @ustcweizhou, I've also provided a fix within this PR: #3828, specifically this commit: [2102864](https://github.com/apache/cloudstack/commit/2102864e8a57ae39a71d4839928923e43554bdff) > > prepareIso() will select the ISO from primary or secondary storage depending if the template is direct download or not @nvazquez it looks better. can you create a separated pull request for it ? we need to fix the issue asap. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3932: Prevent overflow and null pointer on StatsCollector.java
blueorangutan commented on issue #3932: Prevent overflow and null pointer on StatsCollector.java URL: https://github.com/apache/cloudstack/pull/3932#issuecomment-594642192 Packaging result: ✖centos6 ✔centos7 ✔debian. JID-1000 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland opened a new pull request #3933: Ip manager refactor
DaanHoogland opened a new pull request #3933: Ip manager refactor URL: https://github.com/apache/cloudstack/pull/3933 ## Description A refactor of ipAddressManagerImpl for investigating failures with test_nic and retrieval of ip addresses in our cloud ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [x] Cleanup (Code refactoring and cleanup, that may add test cases) ## Screenshots (if appropriate): ## How Has This Been Tested? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3933: Ip manager refactor
DaanHoogland commented on issue #3933: Ip manager refactor URL: https://github.com/apache/cloudstack/pull/3933#issuecomment-594648083 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3933: Ip manager refactor
blueorangutan commented on issue #3933: Ip manager refactor URL: https://github.com/apache/cloudstack/pull/3933#issuecomment-594648319 @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3925: Add cache mode param properly
DaanHoogland commented on a change in pull request #3925: Add cache mode param properly URL: https://github.com/apache/cloudstack/pull/3925#discussion_r387803550 ## File path: api/src/main/java/org/apache/cloudstack/api/command/admin/offering/CreateDiskOfferingCmd.java ## @@ -144,6 +144,9 @@ description = "Hypervisor snapshot reserve space as a percent of a volume (for managed storage using Xen or VMware)") private Integer hypervisorSnapshotReserve; +@Parameter(name = ApiConstants.CACHE_MODE, type = CommandType.STRING, required = false, description = "the cache mode to use for this disk offering. none, writeback or writethrough") Review comment: @radu-todirica why no since attribute here? no biggy, just wondering if you forgot. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3933: Ip manager refactor
blueorangutan commented on issue #3933: Ip manager refactor URL: https://github.com/apache/cloudstack/pull/3933#issuecomment-594662631 Packaging result: ✖centos6 ✔centos7 ✔debian. JID-1001 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] dpassante opened a new issue #3934: Zones are returned in a random order
dpassante opened a new issue #3934: Zones are returned in a random order URL: https://github.com/apache/cloudstack/issues/3934 # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ API ~~~ # CLOUDSTACK VERSION ~~~ 4.13.0.0 ~~~ # CONFIGURATION N/A # OS / ENVIRONMENT N/A # SUMMARY `listZones` returns the zones in a "random" order when it has not been explicitly defined with the new sort key feature. This impacts the correct functioning of the Ansible Cloudstack modules which use the first zone if no zone parameter is given. # STEPS TO REPRODUCE Keep zones unsorted: ~~~ mysql> select id, name, sort_key from data_center; +++--+ | id | name | sort_key | +++--+ | 1 | Sandbox-simulator-basic|0 | | 2 | Sandbox-simulator-advanced |0 | +++--+ 2 rows in set (0.00 sec) ~~~ And use a playbook in which the `zone` param is not given. Several calls to `listZones` also do the trick. # EXPECTED RESULTS A list of zones sorted by SQL ID when no sort key are configured to avoid breaking some existing Ansible deployments. Ensure that a sort key is automatically incremented for new zones and existing zones in the case of a Cloudstack upgrade could also be a nice feature. # ACTUAL RESULTS ~~~ $ for in in `seq 1 1 10`; do cs listZones |grep -m1 name; done "name": "Sandbox-simulator-basic", "name": "Sandbox-simulator-basic", "name": "Sandbox-simulator-basic", "name": "Sandbox-simulator-basic", "name": "Sandbox-simulator-basic", "name": "Sandbox-simulator-basic", "name": "Sandbox-simulator-advanced", "name": "Sandbox-simulator-advanced", "name": "Sandbox-simulator-advanced", "name": "Sandbox-simulator-advanced", ~~~ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3925: Add cache mode param properly
DaanHoogland commented on a change in pull request #3925: Add cache mode param
properly
URL: https://github.com/apache/cloudstack/pull/3925#discussion_r387804255
##
File path:
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java
##
@@ -2318,6 +2319,11 @@ public ServiceOffering createServiceOffering(final
CreateServiceOfferingCmd cmd)
}
}
+// check if valid cache_mode parameter
+if(isCacheModeInvalid(cmd.getCacheMode())){
+throw new InvalidParameterValueException("Please specify a valid
cache mode parameter");
+}
+
Review comment:
I think it is better to call the method `validateCachMode(String cacheMode)`
and include this code as it is duplicated below in lines 2951 - 2955:
```java
void validateCachMode(String cacheMode){
if( cacheMode != null &&
!Enums.getIfPresent(DiskOffering.DiskCacheMode.class,
cacheMode.toUpperCase()).isPresent() {
throw new InvalidParameterValueException("Please specify a valid
cache mode parameter");
}
}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3925: Add cache mode param properly
DaanHoogland commented on a change in pull request #3925: Add cache mode param
properly
URL: https://github.com/apache/cloudstack/pull/3925#discussion_r387804507
##
File path:
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java
##
@@ -2936,6 +2948,11 @@ public DiskOffering createDiskOffering(final
CreateDiskOfferingCmd cmd) {
throw new InvalidParameterValueException("Disksize is not allowed
for a customized disk offering");
}
+// check if valid cache_mode parameter
+if(isCacheModeInvalid(cmd.getCacheMode())){
+throw new InvalidParameterValueException("Please specify a valid
cache mode parameter");
+}
+
Review comment:
duplicate of 2322 - 2326
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3933: Ip manager refactor
DaanHoogland commented on issue #3933: Ip manager refactor URL: https://github.com/apache/cloudstack/pull/3933#issuecomment-594672411 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3933: Ip manager refactor
blueorangutan commented on issue #3933: Ip manager refactor URL: https://github.com/apache/cloudstack/pull/3933#issuecomment-594673130 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3910: Jdk11 auto select on upgrade
blueorangutan commented on issue #3910: Jdk11 auto select on upgrade URL: https://github.com/apache/cloudstack/pull/3910#issuecomment-594699687 Trillian test result (tid-1184) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 31968 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3910-t1184-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_pvlan.py Smoke tests completed. 80 look OK, 1 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_create_pvlan_network | `Error` | 0.03 | test_pvlan.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #3925: Add cache mode param properly
GabrielBrascher commented on a change in pull request #3925: Add cache mode
param properly
URL: https://github.com/apache/cloudstack/pull/3925#discussion_r387845753
##
File path:
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java
##
@@ -2936,6 +2948,11 @@ public DiskOffering createDiskOffering(final
CreateDiskOfferingCmd cmd) {
throw new InvalidParameterValueException("Disksize is not allowed
for a customized disk offering");
}
+// check if valid cache_mode parameter
+if(isCacheModeInvalid(cmd.getCacheMode())){
+throw new InvalidParameterValueException("Please specify a valid
cache mode parameter");
Review comment:
Can you please add more information on the log? Example:
`String.format("Invalid cache mode (%s), specify a valid cache mode parameter",
cmd.getCacheMode())`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #3925: Add cache mode param properly
GabrielBrascher commented on a change in pull request #3925: Add cache mode param properly URL: https://github.com/apache/cloudstack/pull/3925#discussion_r387778031 ## File path: api/src/main/java/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java ## @@ -178,6 +178,13 @@ since = "4.4") private Integer hypervisorSnapshotReserve; +@Parameter(name = ApiConstants.CACHE_MODE, +type = CommandType.STRING, +required = false, +description = "the cache mode to use for this disk offering. none, writeback or writethrough", +since = "4.13") Review comment: `since = "4.14"` if merged in time for 4.14 releasing This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #3925: Add cache mode param properly
GabrielBrascher commented on a change in pull request #3925: Add cache mode
param properly
URL: https://github.com/apache/cloudstack/pull/3925#discussion_r387778991
##
File path:
api/src/main/java/org/apache/cloudstack/api/response/ServiceOfferingResponse.java
##
@@ -192,6 +192,10 @@
@Param(description = "is true if the offering is customized", since =
"4.3.0")
private Boolean isCustomized;
+@SerializedName("cacheMode")
+@Param(description = "the cache mode to use for this disk offering. none,
writeback or writethrough", since = "4.13.0")
Review comment:
Change to `4.14`?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #3925: Add cache mode param properly
GabrielBrascher commented on a change in pull request #3925: Add cache mode param properly URL: https://github.com/apache/cloudstack/pull/3925#discussion_r387864023 ## File path: api/src/main/java/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java ## @@ -178,6 +178,13 @@ since = "4.4") private Integer hypervisorSnapshotReserve; +@Parameter(name = ApiConstants.CACHE_MODE, +type = CommandType.STRING, +required = false, +description = "the cache mode to use for this disk offering. none, writeback or writethrough", +since = "4.13") Review comment: @DaanHoogland this "since" should be 4.14, right? Is it going to be merged into branch 4.13 instead master? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #3925: Add cache mode param properly
GabrielBrascher commented on a change in pull request #3925: Add cache mode param properly URL: https://github.com/apache/cloudstack/pull/3925#discussion_r387864023 ## File path: api/src/main/java/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java ## @@ -178,6 +178,13 @@ since = "4.4") private Integer hypervisorSnapshotReserve; +@Parameter(name = ApiConstants.CACHE_MODE, +type = CommandType.STRING, +required = false, +description = "the cache mode to use for this disk offering. none, writeback or writethrough", +since = "4.13") Review comment: @DaanHoogland this "since" should be 4.14, right? Is it going to be merged into branch 4.13 instead of master? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3928: maven: update dependencies
blueorangutan commented on issue #3928: maven: update dependencies URL: https://github.com/apache/cloudstack/pull/3928#issuecomment-594825398 Trillian test result (tid-1186) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 28258 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3928-t1186-kvm-centos7.zip Smoke tests completed. 81 look OK, 0 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3930: Remove unused guest OS mapping class from Vmware code
blueorangutan commented on issue #3930: Remove unused guest OS mapping class from Vmware code URL: https://github.com/apache/cloudstack/pull/3930#issuecomment-594907843 Trillian test result (tid-1187) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7 Total time taken: 29478 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3930-t1187-vmware-67u3.zip Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py Smoke tests completed. 78 look OK, 0 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #3911: kvm: fix/optimize propogating configs
GabrielBrascher commented on a change in pull request #3911: kvm: fix/optimize
propogating configs
URL: https://github.com/apache/cloudstack/pull/3911#discussion_r388063139
##
File path:
core/src/main/java/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java
##
@@ -319,9 +319,12 @@ private Answer execute(GetDomRVersionCmd cmd) {
}
public boolean configureHostParams(final Map params) {
-if (_params.get("router.aggregation.command.each.timeout") == null) {
+if (_params.get("router.aggregation.command.each.timeout") != null) {
String value =
(String)params.get("router.aggregation.command.each.timeout");
-_eachTimeout =
Duration.standardSeconds(NumbersUtil.parseInt(value, 10));
+_eachTimeout =
Duration.standardSeconds(NumbersUtil.parseLong(value, 600));
Review comment:
I am +1 on externalizing 600 into a constant.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] nvazquez opened a new pull request #3935: Fix VM with ISO attached migration issue
nvazquez opened a new pull request #3935: Fix VM with ISO attached migration issue URL: https://github.com/apache/cloudstack/pull/3935 ## Description As previously described by PR #3929: If vm has attached ISO, the migration fails with error message "org.libvirt.LibvirtException: Cannot access storage file /mnt/b33e5a1d-e4ea-3465-b6ac-c98dc8ff8af0/207-2-cc5fd717-2d57-3bb3-bcf6-2c930268db6c.iso" ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [x] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## Screenshots (if appropriate): ## How Has This Been Tested? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] nvazquez commented on issue #3935: Fix VM with ISO attached migration issue
nvazquez commented on issue #3935: Fix VM with ISO attached migration issue URL: https://github.com/apache/cloudstack/pull/3935#issuecomment-595028519 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3935: Fix VM with ISO attached migration issue
blueorangutan commented on issue #3935: Fix VM with ISO attached migration issue URL: https://github.com/apache/cloudstack/pull/3935#issuecomment-595028638 @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] nvazquez commented on issue #3929: server: fix vm migration failed if iso is attached
nvazquez commented on issue #3929: server: fix vm migration failed if iso is attached URL: https://github.com/apache/cloudstack/pull/3929#issuecomment-595028893 Sure @ustcweizhou please see #3935 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3935: Fix VM with ISO attached migration issue
blueorangutan commented on issue #3935: Fix VM with ISO attached migration issue URL: https://github.com/apache/cloudstack/pull/3935#issuecomment-595034603 Packaging result: ✖centos6 ✔centos7 ✔debian. JID-1002 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3935: Fix VM with ISO attached migration issue
rhtyd commented on issue #3935: Fix VM with ISO attached migration issue URL: https://github.com/apache/cloudstack/pull/3935#issuecomment-595054920 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3935: Fix VM with ISO attached migration issue
blueorangutan commented on issue #3935: Fix VM with ISO attached migration issue URL: https://github.com/apache/cloudstack/pull/3935#issuecomment-595055200 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3933: Ip manager refactor
rhtyd commented on issue #3933: Ip manager refactor URL: https://github.com/apache/cloudstack/pull/3933#issuecomment-595055272 @DaanHoogland trillian maintenance downtime, will rekick @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3933: Ip manager refactor
blueorangutan commented on issue #3933: Ip manager refactor URL: https://github.com/apache/cloudstack/pull/3933#issuecomment-595055488 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3932: Prevent overflow and null pointer on StatsCollector.java
blueorangutan commented on issue #3932: Prevent overflow and null pointer on StatsCollector.java URL: https://github.com/apache/cloudstack/pull/3932#issuecomment-595055783 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3932: Prevent overflow and null pointer on StatsCollector.java
rhtyd commented on issue #3932: Prevent overflow and null pointer on StatsCollector.java URL: https://github.com/apache/cloudstack/pull/3932#issuecomment-595055726 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd merged pull request #3930: Remove unused guest OS mapping class from Vmware code
rhtyd merged pull request #3930: Remove unused guest OS mapping class from Vmware code URL: https://github.com/apache/cloudstack/pull/3930 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch master updated: vmware: remove unused guest OS mapping class (#3930)
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/master by this push:
new 6b29e1c vmware: remove unused guest OS mapping class (#3930)
6b29e1c is described below
commit 6b29e1c5d058fbcb65bcf9569a510fe3b6bb2f8d
Author: Rohit Yadav
AuthorDate: Thu Mar 5 12:14:00 2020 +0530
vmware: remove unused guest OS mapping class (#3930)
Remove unused class for guest OS - Vmware mappings. Mappings are checked
from DB (guest_os_hypervisor table)
---
.../vmware/util/VmwareGuestOsMapper.java | 203 -
1 file changed, 203 deletions(-)
diff --git
a/vmware-base/src/main/java/com/cloud/hypervisor/vmware/util/VmwareGuestOsMapper.java
b/vmware-base/src/main/java/com/cloud/hypervisor/vmware/util/VmwareGuestOsMapper.java
deleted file mode 100644
index b50620e..000
---
a/vmware-base/src/main/java/com/cloud/hypervisor/vmware/util/VmwareGuestOsMapper.java
+++ /dev/null
@@ -1,203 +0,0 @@
-// Licensed to the Apache Software Foundation (ASF) under one
-// or more contributor license agreements. See the NOTICE file
-// distributed with this work for additional information
-// regarding copyright ownership. The ASF licenses this file
-// to you under the Apache License, Version 2.0 (the
-// "License"); you may not use this file except in compliance
-// with the License. You may obtain a copy of the License at
-//
-// http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing,
-// software distributed under the License is distributed on an
-// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-// KIND, either express or implied. See the License for the
-// specific language governing permissions and limitations
-// under the License.
-package com.cloud.hypervisor.vmware.util;
-
-import java.util.HashMap;
-import java.util.Map;
-
-import com.vmware.vim25.VirtualMachineGuestOsIdentifier;
-
-public class VmwareGuestOsMapper {
-private static Map s_mapper = new
HashMap();
-static {
-s_mapper.put("DOS", VirtualMachineGuestOsIdentifier.DOS_GUEST);
-s_mapper.put("OS/2", VirtualMachineGuestOsIdentifier.OS_2_GUEST);
-
-s_mapper.put("Windows 3.1",
VirtualMachineGuestOsIdentifier.WIN_31_GUEST);
-s_mapper.put("Windows 95",
VirtualMachineGuestOsIdentifier.WIN_95_GUEST);
-s_mapper.put("Windows 98",
VirtualMachineGuestOsIdentifier.WIN_98_GUEST);
-s_mapper.put("Windows NT 4",
VirtualMachineGuestOsIdentifier.WIN_NT_GUEST);
-s_mapper.put("Windows XP (32-bit)",
VirtualMachineGuestOsIdentifier.WIN_XP_PRO_GUEST);
-s_mapper.put("Windows XP (64-bit)",
VirtualMachineGuestOsIdentifier.WIN_XP_PRO_64_GUEST);
-s_mapper.put("Windows XP SP2 (32-bit)",
VirtualMachineGuestOsIdentifier.WIN_XP_PRO_GUEST);
-s_mapper.put("Windows XP SP3 (32-bit)",
VirtualMachineGuestOsIdentifier.WIN_XP_PRO_GUEST);
-s_mapper.put("Windows Vista (32-bit)",
VirtualMachineGuestOsIdentifier.WIN_VISTA_GUEST);
-s_mapper.put("Windows Vista (64-bit)",
VirtualMachineGuestOsIdentifier.WIN_VISTA_64_GUEST);
-s_mapper.put("Windows 7 (32-bit)",
VirtualMachineGuestOsIdentifier.WINDOWS_7_GUEST);
-s_mapper.put("Windows 7 (64-bit)",
VirtualMachineGuestOsIdentifier.WINDOWS_7_64_GUEST);
-
-s_mapper.put("Windows 2000 Professional",
VirtualMachineGuestOsIdentifier.WIN_2000_PRO_GUEST);
-s_mapper.put("Windows 2000 Server",
VirtualMachineGuestOsIdentifier.WIN_2000_SERV_GUEST);
-s_mapper.put("Windows 2000 Server SP4 (32-bit)",
VirtualMachineGuestOsIdentifier.WIN_2000_SERV_GUEST);
-s_mapper.put("Windows 2000 Advanced Server",
VirtualMachineGuestOsIdentifier.WIN_2000_ADV_SERV_GUEST);
-
-s_mapper.put("Windows Server 2003 Enterprise Edition(32-bit)",
VirtualMachineGuestOsIdentifier.WIN_NET_ENTERPRISE_GUEST);
-s_mapper.put("Windows Server 2003 Enterprise Edition(64-bit)",
VirtualMachineGuestOsIdentifier.WIN_NET_ENTERPRISE_64_GUEST);
-s_mapper.put("Windows Server 2008 R2 (64-bit)",
VirtualMachineGuestOsIdentifier.WIN_LONGHORN_64_GUEST);
-s_mapper.put("Windows Server 2003 DataCenter Edition(32-bit)",
VirtualMachineGuestOsIdentifier.WIN_NET_DATACENTER_GUEST);
-s_mapper.put("Windows Server 2003 DataCenter Edition(64-bit)",
VirtualMachineGuestOsIdentifier.WIN_NET_DATACENTER_64_GUEST);
-s_mapper.put("Windows Server 2003 Standard Edition(32-bit)",
VirtualMachineGuestOsIdentifier.WIN_NET_STANDARD_GUEST);
-s_mapper.put("Windows Server 2003 Standard Edition(64-bit)",
VirtualMachineGuestOsIdentifier.WIN_NET_STANDARD_64_GUEST);
-s_mapper.put("Windows Server 2003 Web Edition",
VirtualMachineGuestOsIdentifier.WIN_NET_WEB_GUEST);
-s_mapper.put("Microsoft Small Bussiness Server 2003",
VirtualMachineGues
[GitHub] [cloudstack] rhtyd commented on issue #3929: server: fix vm migration failed if iso is attached
rhtyd commented on issue #3929: server: fix vm migration failed if iso is attached URL: https://github.com/apache/cloudstack/pull/3929#issuecomment-595056656 @ustcweizhou @nvazquez can you advice which one of the PRs to keep, this or Nicolas's #3935 ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3924: Fixed error on data volumes lager than 2.14TB when creating instances on VMware
blueorangutan commented on issue #3924: Fixed error on data volumes lager than 2.14TB when creating instances on VMware URL: https://github.com/apache/cloudstack/pull/3924#issuecomment-595056968 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
