GabrielBrascher commented on a change in pull request #3925: Add cache mode
param properly
URL: https://github.com/apache/cloudstack/pull/3925#discussion_r387864023
##########
File path:
api/src/main/java/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java
##########
@@ -178,6 +178,13 @@
since = "4.4")
private Integer hypervisorSnapshotReserve;
+ @Parameter(name = ApiConstants.CACHE_MODE,
+ type = CommandType.STRING,
+ required = false,
+ description = "the cache mode to use for this disk offering. none,
writeback or writethrough",
+ since = "4.13")
Review comment:
@DaanHoogland this "since" should be 4.14, right? Is it going to be merged
into branch 4.13 instead master?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
