labath wrote:
I agree with everything except for the last part. The current parser already
threats `[]` [very
specially](https://github.com/llvm/llvm-project/blob/89ca3e72ca03efbbfb5ae9b1c71d81f2d1753521/lldb/source/Target/StackFrame.cpp#L781).
I think it has to do that so it can treat pointer
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
This is a followup to #122440, which changed function-relative
calculations to use the function entry point rather than the lowest address of
the function (but missed this usage). Like in #116777, the logic is
https://github.com/labath created
https://github.com/llvm/llvm-project/pull/124931
This is a followup to #122440, which changed function-relative calculations to
use the function entry point rather than the lowest address of the function
(but missed this usage). Like in #116777, the logic is c
Author: David Spickett
Date: 2025-01-29T09:56:41Z
New Revision: 9ea64dd8781328d831d7c69a586f0c84dece1c11
URL:
https://github.com/llvm/llvm-project/commit/9ea64dd8781328d831d7c69a586f0c84dece1c11
DIFF:
https://github.com/llvm/llvm-project/commit/9ea64dd8781328d831d7c69a586f0c84dece1c11.diff
LOG
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/124735
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -5028,48 +5021,128 @@ int main(int argc, char *argv[]) {
#endif
// Initialize LLDB first before we do anything.
- lldb::SBDebugger::Initialize();
+ lldb::SBError error = lldb::SBDebugger::InitializeWithErrorHandling();
+ if (error.Fail()) {
+llvm::errs() << "Failed
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/124735
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: David Spickett
Date: 2025-01-29T09:59:34Z
New Revision: db567eaca07133a374991153635a119d9eec066b
URL:
https://github.com/llvm/llvm-project/commit/db567eaca07133a374991153635a119d9eec066b
DIFF:
https://github.com/llvm/llvm-project/commit/db567eaca07133a374991153635a119d9eec066b.diff
LOG
@@ -5058,72 +5053,148 @@ int main(int argc, char *argv[]) {
auto terminate_debugger =
llvm::make_scope_exit([] { lldb::SBDebugger::Terminate(); });
- StreamDescriptor input;
- StreamDescriptor output;
- std::FILE *redirectOut = nullptr;
- std::FILE *redirectErr = n
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/124735
>From 08c47efd81fba63f252467bf7af48549ba4b62d5 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Tue, 28 Jan 2025 10:58:34 +
Subject: [PATCH] [lldb] Make Python >= 3.8 required for LLDB 21
As decide
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/124735
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath wrote:
ping
https://github.com/llvm/llvm-project/pull/123206
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath created
https://github.com/llvm/llvm-project/pull/124938
The original code resulted in a misfire in the symtab vs. debug info
deduplication code, which caused us to return the same function twice when
searching via a regex (for functions whose entry point is also not
https://github.com/kper updated https://github.com/llvm/llvm-project/pull/124475
>From 096eb85718d70721cec1e539cfa4b05a96475c7a Mon Sep 17 00:00:00 2001
From: Kevin Per
Date: Sun, 26 Jan 2025 17:34:17 +
Subject: [PATCH 1/6] lldb: Extended if conditions to support alias names for
registers
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/124682
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Brad Smith
Date: 2025-01-29T03:21:45-05:00
New Revision: 9326633abd0e59fc77072488ee8cded4fe83c8a1
URL:
https://github.com/llvm/llvm-project/commit/9326633abd0e59fc77072488ee8cded4fe83c8a1
DIFF:
https://github.com/llvm/llvm-project/commit/9326633abd0e59fc77072488ee8cded4fe83c8a1.diff
LO
https://github.com/brad0 closed https://github.com/llvm/llvm-project/pull/124682
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -5058,72 +5053,148 @@ int main(int argc, char *argv[]) {
auto terminate_debugger =
llvm::make_scope_exit([] { lldb::SBDebugger::Terminate(); });
- StreamDescriptor input;
- StreamDescriptor output;
- std::FILE *redirectOut = nullptr;
- std::FILE *redirectErr = n
@@ -5058,72 +5053,148 @@ int main(int argc, char *argv[]) {
auto terminate_debugger =
llvm::make_scope_exit([] { lldb::SBDebugger::Terminate(); });
- StreamDescriptor input;
- StreamDescriptor output;
- std::FILE *redirectOut = nullptr;
- std::FILE *redirectErr = n
@@ -5058,72 +5053,148 @@ int main(int argc, char *argv[]) {
auto terminate_debugger =
llvm::make_scope_exit([] { lldb::SBDebugger::Terminate(); });
- StreamDescriptor input;
- StreamDescriptor output;
- std::FILE *redirectOut = nullptr;
- std::FILE *redirectErr = n
@@ -1167,21 +1168,61 @@ def __init__(
if log_file:
adaptor_env["LLDBDAP_LOG"] = log_file
+args = [executable]
+
+if connection is not None:
+args.append("--connection")
+args.append(connection)
@@ -4952,6 +4930,28 @@ static int DuplicateFileDescriptor(int fd) {
#endif
}
+static llvm::Expected>
+parseConnection(llvm::StringRef conn) {
+ if (conn.contains("://")) {
labath wrote:
It looks like this could use `lldb/Utility/URIParser.h`
https://github.
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/116392
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath commented:
I think this looks pretty good now. Just a couple of questions from my side.
https://github.com/llvm/llvm-project/pull/116392
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/
omjavaid wrote:
> ### Known Issues (Just for documentation):
> 1.
I have updates the PR description the "Known Issues (Just for documentation):"
part will be skipped in the final patch description.
https://github.com/llvm/llvm-project/pull/108072
___
https://github.com/omjavaid edited
https://github.com/llvm/llvm-project/pull/108072
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/105594
>From 56ca564185bdceea25162a1ce3b1e8c8fa2641e2 Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Fri, 19 Jul 2024 17:26:13 -0700
Subject: [PATCH 1/8] [lldb] Change lldb's breakpoint handling behavior
(#96
https://github.com/matthewbastien created
https://github.com/llvm/llvm-project/pull/124986
The published VSIX for the LLDB DAP extension contains a bunch of unnecessary
files:
```
❯ tar tf llvm-vs-code-extensions.lldb-dap-0.2.8.vsix
extension.vsixmanifest
[Content_Types].xml
extension/.github/
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
@@ -110,8 +110,8 @@
NativeRegisterContextWindows::CreateHostNativeRegisterContextWindows(
NativeRegisterContextWindows_x86_64::NativeRegisterContextWindows_x86_64(
const ArchSpec &target_arch, NativeThreadProtocol &native_thread)
-: NativeRegisterContextWindows(native
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/105594
>From 56ca564185bdceea25162a1ce3b1e8c8fa2641e2 Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Fri, 19 Jul 2024 17:26:13 -0700
Subject: [PATCH 1/7] [lldb] Change lldb's breakpoint handling behavior
(#96
@@ -0,0 +1,189 @@
+//===-- DILLexer.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/labath closed
https://github.com/llvm/llvm-project/pull/123206
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Pavel Labath
Date: 2025-01-30T08:24:40+01:00
New Revision: 3cf56b5f04cdec567cfab3975ac7b531422c1e2c
URL:
https://github.com/llvm/llvm-project/commit/3cf56b5f04cdec567cfab3975ac7b531422c1e2c
DIFF:
https://github.com/llvm/llvm-project/commit/3cf56b5f04cdec567cfab3975ac7b531422c1e2c.diff
labath wrote:
I tend to ignore those because people have very different definitions of NFC,
but yeah, I guess this would fit most definitions.
https://github.com/llvm/llvm-project/pull/123206
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
labath wrote:
There isn't a good reason for using GetAddressRange, and removing it is what
I'm trying to do. But rather than trying to do it all at once, I'm doing it in
pieces as some of the changes (particularly those that need to iterate over a
set of ranges) are not trivial. This way I can
https://github.com/matthewbastien edited
https://github.com/llvm/llvm-project/pull/124986
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/matthewbastien edited
https://github.com/llvm/llvm-project/pull/124986
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
rocallahan wrote:
@DavidSpickett can you apply that change to your branch since this is your PR
now?
@labath does this pass on x86-via-Rosetta Mac? Should we retry merging with
this change?
Thanks!
https://github.com/llvm/llvm-project/pull/123945
_
https://github.com/omjavaid updated
https://github.com/llvm/llvm-project/pull/108072
>From 82ee1429a0fcf67aa36bf6ca7debb5518211d16c Mon Sep 17 00:00:00 2001
From: Muhammad Omair Javaid
Date: Tue, 10 Sep 2024 18:03:29 +0500
Subject: [PATCH 1/7] WoA hardware breakpoint/watchpoint support
---
..
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/125006
Xcode uses a pseudoterminal for the debugger console.
- The upside of this apporach is that it means that it can rely on LLDB's
IOHandlers for multiline and script input.
- The downside of this approach
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
Xcode uses a pseudoterminal for the debugger console.
- The upside of this apporach is that it means that it can rely on LLDB's
IOHandlers for multiline and script input.
- The downside of this ap
JDevlieghere wrote:
I recommend reviewing the last commit and ignoring the two NFC commits, which I
will land separately anyway.
https://github.com/llvm/llvm-project/pull/125006
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.
@@ -5058,72 +5053,148 @@ int main(int argc, char *argv[]) {
auto terminate_debugger =
llvm::make_scope_exit([] { lldb::SBDebugger::Terminate(); });
- StreamDescriptor input;
- StreamDescriptor output;
- std::FILE *redirectOut = nullptr;
- std::FILE *redirectErr = n
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/125006
>From fdac9c0292cef848b880904cf84b2c0083065005 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Tue, 28 Jan 2025 15:43:31 -0800
Subject: [PATCH 1/4] [lldb] Fix CommandInterpreter formatting (NFC)
---
JDevlieghere wrote:
> If this result printing callback was also passed the command string (which it
> has from just above where the callback is called) then this would also be an
> easy way to do logging of command execution. That's not needed for your
> current purpose, but would add another
https://github.com/matthewbastien edited
https://github.com/llvm/llvm-project/pull/124986
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jimingham wrote:
This looks fine, but more generally, is there any good reason to ever use
Function::GetAddressRange? Shouldn't that just be removed and all the
instances replaced with either GetAddress or get the ranges and iterate over
them looking for whatever they wanted?
https://github.
@@ -575,6 +575,10 @@ Changes to LLDB
24 int main() {
Likely cause: f->b->d accessed 0x4
```
+* LLDB now supports hardware watchpoints for AArch64 Windows targets. Windows
+ does not provide API to query the number of supported hardware watchpoints.
+ Therefore curr
@@ -1187,6 +1187,7 @@ class EntityResultVariable : public Materializer::Entity {
private:
CompilerType m_type;
+ /// If this result entity can (and should) track the value on inferior
memory.
jimingham wrote:
on -> in?
https://github.com/llvm/llvm-projec
jimingham wrote:
Other than that tiny quibble, these are accurate and helpful comments.
https://github.com/llvm/llvm-project/pull/124971
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm
@@ -492,23 +492,40 @@ NativeProcessWindows::OnDebugException(bool first_chance,
}
case DWORD(STATUS_BREAKPOINT):
case STATUS_WX86_BREAKPOINT:
omjavaid wrote:
yes. Heres the detail from ntstatus.h
//
// MessageId: STATUS_WX86_BREAKPOINT
//
// MessageText:
@@ -1012,6 +1012,26 @@ static void
LLDBSwigPythonCallPythonLogOutputCallback(const char *str,
}
}
+// For DebuggerTerminateCallback functions
jimingham wrote:
Is this comment right?
https://github.com/llvm/llvm-project/pull/125006
@@ -0,0 +1,66 @@
+import lldb
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+
+
+class BreakpointAPITestCase(TestBase):
+NO_DEBUG_INFO_TESTCASE = True
+
+def run_command_interpreter_with_output_file(sel
jimingham wrote:
Man there's a lot of boiler plate in hooking up to SWIG... But this all looks
right to me.
I wondered whether the callback would benefit from knowing whether the result
had been dumped immediately or not, but I can't think of a good reason for that.
If this result printing
DavidSpickett wrote:
> I have created two tests.
Which is great, but we need live processes too and I found those, they are in
`lldb/test/Shell/Register/` for example
`lldb/test/Shell/Register/aarch64-gp-read.test`. For some reason we don't check
all registers there just parameter registers,
labath wrote:
ping @jimingham
https://github.com/llvm/llvm-project/pull/123622
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/clayborg approved this pull request.
Want to add a [NFC] to the title as well?
https://github.com/llvm/llvm-project/pull/123206
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo
DavidSpickett wrote:
ping!
https://github.com/llvm/llvm-project/pull/122694
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath wrote:
Let's continue the discussion
[here](https://discourse.llvm.org/t/rfc-fixing-incompatibilties-of-the-x-packet-w-r-t-gdb/84288/8).
(It could work it's just not how gdb implemented it. Sniffing of zero-length
reads was considered, but a qSupported feature was deemed more principl
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
The original code resulted in a misfire in the symtab vs. debug info
deduplication code, which caused us to return the same function twice when
searching via a regex (for functions whose entry point is also no
cmtice wrote:
If DIL is not allowed to recognize any operators except period, arrow, and
parentheses, it seems to me that it won't be any more powerful than the current
'frame variable' implementation, in which case what is the point of having it
at all? (As a matter of fact, it would be less
cmtice wrote:
> > If DIL is not allowed to recognize any operators except period, arrow, and
> > parentheses, it seems to me that it won't be any more powerful than the
> > current 'frame variable' implementation, in which case what is the point of
> > having it at all? (As a matter of fact, i
jimingham wrote:
> I agree with everything except for the last part. The current parser already
> threats `[]` [very
> specially](https://github.com/llvm/llvm-project/blob/89ca3e72ca03efbbfb5ae9b1c71d81f2d1753521/lldb/source/Target/StackFrame.cpp#L781).
> I think it has to do that so it can tr
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/123945
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,537 @@
+import os
+import os.path
+import lldb
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test.gdbclientutils import *
+from lldbsuite.test.lldbgdbproxy import *
+import lldbgdbserverutils
+import re
+
+
+class ThreadSnapshot:
+def __init__(self, thread_
https://github.com/labath approved this pull request.
After much deliberation, I came to the conclusion that it's best to just work
around this problem, given that we're going to be changing how the `x` packet
works (and removing the ambiguity) anyway.
This usage technically was not ambiguous
https://github.com/JDevlieghere approved this pull request.
LGTM with one solution since you're already improving the comments.
https://github.com/llvm/llvm-project/pull/124971
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.ll
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/124971
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -108,7 +108,14 @@ class ExpressionVariable
FlagType m_flags; // takes elements of Flags
// these should be private
JDevlieghere wrote:
```suggestion
/// These members should be private.
/// @{
[...]
lldb::ValueObjectSP m_live_sp;
/// @}
```
https://github.com/fsfod updated
https://github.com/llvm/llvm-project/pull/113102
>From 79408f0a5703c1174ef98130a4106c61cd593d76 Mon Sep 17 00:00:00 2001
From: Thomas Fransham
Date: Mon, 12 Aug 2024 16:04:12 +0100
Subject: [PATCH 1/2] [DebugInfo] Add explicit visibility macros to CodeView
temp
@@ -970,19 +969,21 @@ class CommandObjectThreadUntil : public
CommandObjectParsed {
return;
}
-AddressRange fun_addr_range = sc.function->GetAddressRange();
-Address fun_start_addr = fun_addr_range.GetBaseAddress();
-line_table->FindL
@@ -1007,29 +1009,29 @@ class CommandObjectThreadUntil : public
CommandObjectParsed {
addr_t address =
line_entry.range.GetBaseAddress().GetLoadAddress(target);
if (address != LLDB_INVALID_ADDRESS) {
- if (fun_addr_range.Con
@@ -970,19 +969,21 @@ class CommandObjectThreadUntil : public
CommandObjectParsed {
return;
}
-AddressRange fun_addr_range = sc.function->GetAddressRange();
-Address fun_start_addr = fun_addr_range.GetBaseAddress();
-line_table->FindL
jimingham wrote:
> If DIL is not allowed to recognize any operators except period, arrow, and
> parentheses, it seems to me that it won't be any more powerful than the
> current 'frame variable' implementation, in which case what is the point of
> having it at all? (As a matter of fact, it wou
https://github.com/augusto2112 created
https://github.com/llvm/llvm-project/pull/124971
None
>From cd28fcaf8739a32897a09bd661cb805b3960a7c7 Mon Sep 17 00:00:00 2001
From: Augusto Noronha
Date: Wed, 29 Jan 2025 10:53:23 -0800
Subject: [PATCH] [NFC][lldb] Document a few ivars on the value object
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Augusto Noronha (augusto2112)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/124971.diff
3 Files Affected:
- (modified) lldb/include/lldb/Expression/ExpressionVariable.h (+7)
- (modified) lldb/include/lldb/ValueObject
77 matches
Mail list logo
