https://github.com/labath approved this pull request.
After much deliberation, I came to the conclusion that it's best to just work around this problem, given that we're going to be changing how the `x` packet works (and removing the ambiguity) anyway. This usage technically was not ambiguous because the output packet can only be sent when the target is running (so it can't be confused with an `x` response), but the test code was not tracking the run state of the server. I tried teaching it to do that, but wasn't particularly happy with the result, and given the `x` change, the added complication would not be necessary anyway. For a time I also wanted to wait until the servers start sending the new `x` response, but now it looks like that may still take quite some time. TL;DR: LGTM with the inline suggestion applied https://github.com/llvm/llvm-project/pull/123945 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
