labath added a subscriber: labath.
labath added a comment.
Some more "why do this?" questions from me...
I was looking into using mingw a couple weeks ago, but gave up, so I'm
interested to see your progress here. However, I'd like to avoid adding hacks
into the cmake files if it is not complet
eran.ifrah added a comment.
Comment at: CMakeLists.txt:3
@@ -2,1 +2,3 @@
+if(MINGW_DEBUG)
+# force debugging info into lldb sources
labath wrote:
> Why do we need this? Why is `-DCMAKE_BUILD_TYPE=Debug` not sufficient?
No. As I mentioned in my previous co
Author: labath
Date: Tue Mar 29 05:41:40 2016
New Revision: 264713
URL: http://llvm.org/viewvc/llvm-project?rev=264713&view=rev
Log:
Add missing swig wrappers for r264662
Modified:
lldb/trunk/scripts/interface/SBExpressionOptions.i
Modified: lldb/trunk/scripts/interface/SBExpressionOptions.i
tberghammer added a comment.
You can pass extra compiler flags to the test suit with the -E option (haven't
tested it). I would suggest to use that option and then xfail based on it
(xfail if extra flags contain -foo).
In long term I would prefer to not add a new option to expectedFailureAll bu
Author: labath
Date: Tue Mar 29 07:06:37 2016
New Revision: 264721
URL: http://llvm.org/viewvc/llvm-project?rev=264721&view=rev
Log:
Add ClangUtil.cpp to the xcode project
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
URL:
http://llv
labath created this revision.
labath added reviewers: tberghammer, clayborg.
labath added a subscriber: lldb-commits.
Since r264316, clang started adding DW_AT_GNU_dwo_name attribute to dwo files
(previously, this
attribute was only present in main object files), breaking pretty much every
dwo t
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
Looks good
Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.h:334
@@ +333,3 @@
+virtual std::unique_ptr
+GetDWOForCompileUnit(DWARFCompileUnit &dw
tberghammer added a comment.
What is your opinion about replacing the ProcessGDBRemote::LoadModuleAtAddress
with the following code:
lldb::ModuleSP
ProcessGDBRemote::LoadModuleAtAddress (const FileSpec &file, lldb::addr_t
base_addr, bool value_is_offset)
{
DynamicLoader* loader = Ge
labath marked an inline comment as done.
labath added a comment.
@clayborg: I am going to put this in now, to stabilize the buildbot situation.
I'll be happy to address any concerns in a follow-up commit.
http://reviews.llvm.org/D18547
___
lldb-com
Author: labath
Date: Tue Mar 29 08:42:02 2016
New Revision: 264729
URL: http://llvm.org/viewvc/llvm-project?rev=264729&view=rev
Log:
Fix infinite recursion in DWO file parsing
Summary:
Since r264316, clang started adding DW_AT_GNU_dwo_name attribute to dwo files
(previously, this
attribute was o
This revision was automatically updated to reflect the committed changes.
Closed by commit rL264729: Fix infinite recursion in DWO file parsing (authored
by labath).
Changed prior to commit:
http://reviews.llvm.org/D18547?vs=51896&id=51897#toc
Repository:
rL LLVM
http://reviews.llvm.org/D18
fjricci added a comment.
That was actually one of the fixes I originally tried. My only concern is that
LoadModuleAtAddress is a protected method in the dynamic loader. If you think
it's fine to change it to public, I'll go ahead and do that.
http://reviews.llvm.org/D18531
_
tberghammer added a comment.
I think it should be fine to make it public as it don't do anything what can
mess up the private state of the DynamicLoader. In general visibility in LLDB
are decided in a bit randomly so usually it is fine to change them if the
implementation looks like it won't br
labath added inline comments.
Comment at: CMakeLists.txt:3
@@ -2,1 +2,3 @@
+if(MINGW_DEBUG)
+# force debugging info into lldb sources
eran.ifrah wrote:
> labath wrote:
> > Why do we need this? Why is `-DCMAKE_BUILD_TYPE=Debug` not sufficient?
> No. As I ment
labath added a comment.
So, the way I would achieve this is to have a way to specify "i want to run the
tests with hard-float", or "I want to use thumb instruction set" when running
dotest.py and then based on this information, set the correct compiler flags
**and** xfail/skip tests. When we do
ldrumm added a comment.
Hi Sean
Did you get a chance to look over this? It'd be great to have your input.
Best
Luke
http://reviews.llvm.org/D17027
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
Author: labath
Date: Tue Mar 29 09:39:10 2016
New Revision: 264733
URL: http://llvm.org/viewvc/llvm-project?rev=264733&view=rev
Log:
Revert the "build fix" in r264104
this was needed because lldb-mi temporarily contained references to private
lldb symbols
(lldb_private namespace), which it shoul
Author: labath
Date: Tue Mar 29 10:00:26 2016
New Revision: 264735
URL: http://llvm.org/viewvc/llvm-project?rev=264735&view=rev
Log:
Move DynamicLoader plugins to SystemInitializerFull
Summary: These are not needed by lldb-server. Removing them shrinks the server
by about 0.5%.
Reviewers: zturn
This revision was automatically updated to reflect the committed changes.
Closed by commit rL264735: Move DynamicLoader plugins to SystemInitializerFull
(authored by labath).
Changed prior to commit:
http://reviews.llvm.org/D18206?vs=50813&id=51917#toc
Repository:
rL LLVM
http://reviews.llv
eran.ifrah updated this revision to Diff 51918.
eran.ifrah added a comment.
Fixed: WindowsMiniDump should now also compile and work on MinGW by adding
`Dbghelp` library
Fixed: DebuggerThread: don't pass std::atomic to the LOG macros as it
yields g++ error on MinGW, instead use a temp variable
F
On Tue, Mar 29, 2016 at 8:43 AM, Zachary Turner wrote:
> It's night here, so I will have a detailed look tomorrow. But in the
> meantime, some of the issues don't appear to be addressed. For example the
> issue about why logging is disabled,
>
Fixed with the new patch
> the disabled code i
labath created this revision.
labath added reviewers: clayborg, jingham.
labath added a subscriber: lldb-commits.
the inferior in the test deliberately does not lock a mutex when accessing the
watched variable.
The reason for that is unclear as, based on the logs, the original intention of
the t
Author: gclayton
Date: Tue Mar 29 12:36:38 2016
New Revision: 264753
URL: http://llvm.org/viewvc/llvm-project?rev=264753&view=rev
Log:
Don't try to call getTypeSize() on a class if it isn't complete as clang will
assert and kill the process.
Modified:
lldb/trunk/source/Symbol/ClangASTContext
fjricci added a comment.
I see that DynamicLoaderHexagonDYLD also has a LoadModuleAtAddress function,
which seems to be the same as the one in DynamicLoader, except that the member
functions it calls are overloaded, and it is also missing the newly added
ReadFromMemory code.
I think this funct
Author: gclayton
Date: Tue Mar 29 13:22:07 2016
New Revision: 264762
URL: http://llvm.org/viewvc/llvm-project?rev=264762&view=rev
Log:
When creating typedefs, don't call Type::GetName() since that might recursively
call
"lldb_private::Type::ResolveClangType(lldb_private::Type::ResolveStateTag)"
fjricci updated this revision to Diff 51962.
fjricci added a comment.
Refactor to remove code duplication
http://reviews.llvm.org/D18531
Files:
include/lldb/Target/DynamicLoader.h
source/Plugins/DynamicLoader/Hexagon-DYLD/DynamicLoaderHexagonDYLD.cpp
source/Plugins/DynamicLoader/Hexagon-D
Author: jingham
Date: Tue Mar 29 17:00:08 2016
New Revision: 264793
URL: http://llvm.org/viewvc/llvm-project?rev=264793&view=rev
Log:
Figure out what the fixed expression is, and print it. Added another target
setting to
quietly apply fixits for those who really trust clang's fixits.
Also, move
Author: gclayton
Date: Tue Mar 29 17:09:24 2016
New Revision: 264794
URL: http://llvm.org/viewvc/llvm-project?rev=264794&view=rev
Log:
LLDB top of tree SVN fails to attach to a MacOSX native process by pid only (no
executable).
The problem was that the static DynamicLoaderDarwinKernel::Initiali
Author: gclayton
Date: Tue Mar 29 19:02:13 2016
New Revision: 264810
URL: http://llvm.org/viewvc/llvm-project?rev=264810&view=rev
Log:
Fixed the failing test TestCommandScriptImmediateOutput on MacOSX. Turns out
that there are few things to watch out for when writing pexpect tests:
1 - If you pl
tfiala added a subscriber: tfiala.
tfiala added a comment.
The general idea looks good. You'll want to reach out to the Hexagon dynamic
loader author first on any proposed changes there, though.
Thanks!
-Todd
http://reviews.llvm.org/D18531
___
ll
The general idea looks good. You'll want to reach out to the Hexagon dynamic
loader author first on any proposed changes there, though.
Thanks!
-Todd
> On Mar 29, 2016, at 11:45 AM, Francis Ricci wrote:
>
> fjricci updated this revision to Diff 51962.
> fjricci added a comment.
>
> Refactor
Author: spyffe
Date: Tue Mar 29 22:44:51 2016
New Revision: 264821
URL: http://llvm.org/viewvc/llvm-project?rev=264821&view=rev
Log:
Don't register the addresses of private symbols from expressions.
They're not supposed to go in the symbol table, and in fact the way the JIT
is currently implement
32 matches
Mail list logo
