0 header.
>
> nice find
>
> > I have made changes in the patch attached to fix these problems.
>
> thx for sharing.
> the patch needs a small amount of improvement. see below for my
> suggestions.
>
> > From 306f9db010cf000eb8477aca243fc970f5b95df8 Mon Sep 17
force an exit from the macro code (e.g. through a
goto or a return) in order to prevent undefined results."
This patch adjusts vf_drawtext to use goto error handlers similar to
other locations in ffmpeg.
Aaron
libavfilter-drawtext-avoid-undefined-behavior.patch
Description: B
force an exit from the macro code (e.g. through a
goto or a return) in order to prevent undefined results."
This patch adjusts vf_drawtext to use goto error handlers similar to
other locations in ffmpeg.
Aaron
PS Sorry for having to send again, sent from the wrong address last
time, so patchw
force an exit from the macro code (e.g. through a
goto or a return) in order to prevent undefined results."
This patch adjusts vf_drawtext to use goto error handlers similar to
other locations in ffmpeg.
Aaron
PS Sorry for having to send again, sent from the wrong address last
time, so patchw
This patch supports the new SRT streamid spec allowing caller to send
key/value pairs
of parameters to the listener, including user name. A callback parses the
streamid
- in this case, the parsers chooses the passphrase for the user based on
specified list
of passphrases.
Thanks,
Aaron
From
option is passed). When loading the file over a
network this results in significantly better performance since
avformat_open_input doesn't require a scan of the entire file.
Signed-off-by: Aaron Boushley
---
libavformat/mov.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/libavformat/mo
On Mon, Nov 5, 2018 at 2:21 PM Michael Niedermayer
wrote:
>
> On Mon, Nov 05, 2018 at 11:17:25AM -0800, Aaron Boushley wrote:
> > When parsing a fragmented MP4 with the use_mfra_for option set so that
> > the mfra box is parsed we currently continue to parse all the top level
&g
On Mon, Nov 5, 2018 at 3:13 PM Carl Eugen Hoyos wrote:
>
> 2018-11-06 0:03 GMT+01:00, Aaron Boushley :
> > On Mon, Nov 5, 2018 at 2:21 PM Michael Niedermayer
> > wrote:
>
> >> > diff --git a/libavformat/mov.c b/libavformat/mov.c
> >> > index ec57a0580
On Mon, Nov 5, 2018 at 3:25 PM Aaron Boushley wrote:
>
> On Mon, Nov 5, 2018 at 3:13 PM Carl Eugen Hoyos wrote:
> >
> > 2018-11-06 0:03 GMT+01:00, Aaron Boushley :
> > > On Mon, Nov 5, 2018 at 2:21 PM Michael Niedermayer
> > > wrote:
> >
> > &
doesn't require a scan of the entire file.
Aaron
From 61412c5990037484e13c7daa60d83b8ba548b8a6 Mon Sep 17 00:00:00 2001
From: Aaron Boushley
Date: Mon, 5 Nov 2018 11:02:00 -0800
Subject: [PATCH] libavformat/mov: Speed up fragmented mp4 parsing
When parsing a fragmented MP4 with the use_mfr
On Mon, Nov 5, 2018 at 3:48 PM Aaron Boushley wrote:
>
> Sorry for the second thread, first one was corrupted with a newline
> because I attempted an inline patch. Hopefully the mime-type will be set
> correctly on this one.
> ---
> When parsing a fragmented MP4 with the use_m
Can I get a review on this. Anywhere we have code calling out and
performing undefined behavior we should clean that up.
Aaron
On Sat, Jul 27, 2019 at 7:58 AM Aaron Boushley wrote:
>
> The vf_drawtext filter uses the GET_UTF8 macro in multiple locations.
> Each of these use `continue
,
Aaron
From 8a11e0d673872049b8260cb08f3c7cb40f9a1297 Mon Sep 17 00:00:00 2001
From: Aaron Boxer
Date: Wed, 14 Aug 2019 08:26:17 -0400
Subject: [PATCH] libsrt: support streamid spec
---
libavformat/libsrt.c | 135 +++
1 file changed, 135 insertions(+)
diff
to go from no notification to an error log.
I could also just put a continue call there, or do more research to figure
out if I can go to without having any content on the line.
Suggestions for what I should do differently with that context?
Aaron
On Mon, Sep 9, 2019, 9:13 AM Michael Niederma
ds to this issue, but I
didn't check. I appreciate any comments.
Thanks,
Aaron Levinson
--- next part
From 66796ca78e9b307ba0a8a7c33bd89d006c44ddf8 Mon Sep 17 00:00:00 2001
From: Aaron Levinson
Date: Sun, 26 Mar 2017 01:57:19 -0700
On 3/26/2017 4:41 AM, Matthias Hunstock wrote:
Am 26.03.2017 um 11:50 schrieb Aaron Levinson:
When using the following command to play back either file:
ffmpeg -i -f decklink -pix_fmt uyvy422 "DeckLink SDI
4K", I noticed that with the mpegts file with the AAC audio stream,
From 8654212c2f2a3ee404020cf5b948d7db3e6270f2 Mon Sep 17 00:00:00 2001
From: Aaron Colwell
Date: Mon, 27 Mar 2017 08:00:12 -0700
Subject: [PATCH] movenc: Add support for writing st3d and sv3d boxes.
---
libavformat/movenc.c | 105 +++
1 file
Made all suggested changes and attached a new patch. Thanks for the quick
review.
Aaron
On Mon, Mar 27, 2017 at 10:00 AM James Almer wrote:
> On 3/27/2017 1:02 PM, Aaron Colwell wrote:
> >
> > 0001-movenc-Add-support-for-writing-st3d-andsv3d-boxes.patch
&
addresses the "having to check multiple fields"
objection raised in previous threads because now a single flag can be used
to indicate whether you need to pay attention to the bound_xxx fields or
not. It seems like a more reasonable and extendable compromise to me.
I also don't think different cubemap layouts necessarily should have their
own enum values. This feels roughly akin to merging an audio codec_id and
the channel mapping into a single enum space.
Aaron
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
From 722cbb5f6544323430d883212ac2e38c4eb94e5f Mon Sep 17 00:00:00 2001
From: Aaron Levinson
Date: Wed, 12 Apr 2017 16:33:39 -0700
Subject: [PATCH] Made appropriate changes to be able to successfully build C++
files using a Visual C++ build on Windows.
Purpose: Made appropriate changes to be
From bcc0ec4a0bb64e74b9c9369087708f55569bf50e Mon Sep 17 00:00:00 2001
From: Aaron Levinson
Date: Wed, 12 Apr 2017 16:41:53 -0700
Subject: [PATCH] avdevice/decklink: Removed pthread dependency. Made minor
changes to get the decklink avdevice code to build using Visual C++.
Purpose: avdevice
On 3/26/2017 10:34 AM, Aaron Levinson wrote:
> On 3/26/2017 4:41 AM, Matthias Hunstock wrote:
>> Am 26.03.2017 um 11:50 schrieb Aaron Levinson:
>>> When using the following command to play back either file:
>>> ffmpeg -i -f decklink -pix_fmt uyvy422 "DeckLink S
On 4/12/2017 6:51 PM, Marton Balint wrote:
On Wed, 12 Apr 2017, Aaron Levinson wrote:
From bcc0ec4a0bb64e74b9c9369087708f55569bf50e Mon Sep 17 00:00:00 2001
From: Aaron Levinson
Date: Wed, 12 Apr 2017 16:41:53 -0700
Subject: [PATCH] avdevice/decklink: Removed pthread dependency. Made
minor
From d175e7fc94a2efc4f0bad021c118e4f907832c9c Mon Sep 17 00:00:00 2001
From: Aaron Levinson
Date: Wed, 12 Apr 2017 20:12:11 -0700
Subject: [PATCH] avdevice/decklink: Removed pthread dependency
Purpose: avdevice/decklink: Removed pthread dependency by
replacing semaphore used in code
From aa549cf1c463f4a37bda44b934e17811986f11d9 Mon Sep 17 00:00:00 2001
From: Aaron Levinson
Date: Wed, 12 Apr 2017 20:21:41 -0700
Subject: [PATCH] Made minor changes to get the decklink avdevice code to build
using Visual C++
Purpose: Made minor changes to get the decklink avdevice
code to
7;t the same
as a true debug build.
Thanks,
Aaron Levinson
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
On 4/13/2017 12:21 AM, Hendrik Leppkes wrote:
> On Thu, Apr 13, 2017 at 2:16 AM, Aaron Levinson wrote:
>> diff --git a/configure b/configure
>> index d13d60b..b0f7b1a 100755
>> --- a/configure
>> +++ b/configure
>> @@ -3635,10 +3635,13 @@ case "$toolchain&quo
On 4/13/2017 1:21 AM, Hendrik Leppkes wrote:
On Thu, Apr 13, 2017 at 5:32 AM, Aaron Levinson wrote:
diff --git a/configure b/configure
index b0f7b1a..adb0060 100755
--- a/configure
+++ b/configure
@@ -2992,9 +2992,9 @@ avfoundation_indev_deps="pthreads"
avfoundation_indev
On 4/13/2017 1:27 AM, Hendrik Leppkes wrote:
> On Thu, Apr 13, 2017 at 10:23 AM, Aaron Levinson wrote:
>> diff --git a/configure b/configure
>> index b2fc781..6112b9b 100755
>> --- a/configure
>> +++ b/configure
>> @@ -3637,8 +3637,10 @@ case "$toolchain&
On 4/13/2017 2:10 AM, Hendrik Leppkes wrote:
> On Thu, Apr 13, 2017 at 11:04 AM, Aaron Levinson wrote:
>> static av_unused int pthread_cond_signal(pthread_cond_t *cond)
>> {
>> -win32_cond_t *win32_cond = cond->Ptr;
>> +win32_cond_t *win32_cond = (win32_
On 4/13/2017 12:36 AM, Hendrik Leppkes wrote:
> On Thu, Apr 13, 2017 at 5:34 AM, Aaron Levinson wrote:
>> diff --git a/configure b/configure
>> index adb0060..5b76a33 100755
>> --- a/configure
>> +++ b/configure
>> @@ -3646,6 +3646,8 @@ case "$toolchain&qu
On 4/13/2017 2:12 AM, Hendrik Leppkes wrote:
On Thu, Apr 13, 2017 at 10:36 AM, Aaron Levinson wrote:
Give it some time for the other changes to be reviewed by the people
that actually know decklink itself, you can include that in any new
versions of the patch then, no need to send one for that
On 4/13/2017 3:55 AM, Hendrik Leppkes wrote:
On Thu, Apr 13, 2017 at 12:39 PM, Aaron Levinson wrote:
On 4/13/2017 12:36 AM, Hendrik Leppkes wrote:
diff --git a/configure b/configure
index a383bf2..9a06437 100755
--- a/configure
+++ b/configure
@@ -4843,8 +4843,6 @@ case $target_os in
Oliver wrote:
On 13 April 2017 at 17:20, Aaron Levinson
wrote:
I wanted to build a debug build of ffmpeg using Visual C++ today,
one
without any optimizations. This implies the use of the -Od
compiler
option. Unfortunately, I quickly discovered that the build fails
soon
after it starts
On 4/13/2017 1:23 PM, Hendrik Leppkes wrote:
> On Thu, Apr 13, 2017 at 10:09 PM, Aaron Levinson wrote:
>> On 4/13/2017 3:55 AM, Hendrik Leppkes wrote:
>>>
>>> On Thu, Apr 13, 2017 at 12:39 PM, Aaron Levinson
>>> wrote:
>>>>
>>>> On
From 558b957eb85a669899750b2e150eba7cdee8dcd9 Mon Sep 17 00:00:00 2001
From: Aaron Levinson
Date: Thu, 13 Apr 2017 16:46:59 -0700
Subject: [PATCH] Enhanced configure to improve compiler options associated with
debugging with Visual C++ (MSVC)
Purpose: Enhanced configure to improve compiler
From 48f7daba16e0fcdb83d9abd254800c7b9f4ab684 Mon Sep 17 00:00:00 2001
From: Aaron Levinson
Date: Thu, 13 Apr 2017 17:30:47 -0700
Subject: [PATCH] Enhanced require_pkg_config() in configure to fallback to
require() if pkg-config is missing
Purpose: Enhanced require_pkg_config() in configure to
On 4/13/2017 3:40 PM, Marton Balint wrote:
>
> On Thu, 13 Apr 2017, Aaron Levinson wrote:
>
>> On 4/13/2017 2:12 AM, Hendrik Leppkes wrote:
>>> On Thu, Apr 13, 2017 at 10:36 AM, Aaron Levinson
>> wrote:
>>> Give it some time for the other changes to be r
From da3899b24ad89b4788a3b8191d53b26f5eec328e Mon Sep 17 00:00:00 2001
From: Aaron Levinson
Date: Thu, 13 Apr 2017 23:12:30 -0700
Subject: [PATCH] Fixed problems with QuickSync (QSV) interlaced video
encoding
Purpose: Fixed problems with QuickSync (QSV) interlaced video encoding
that were
On 4/14/2017 1:09 AM, Hendrik Leppkes wrote:
On Fri, Apr 14, 2017 at 2:56 AM, Aaron Levinson wrote:
From 48f7daba16e0fcdb83d9abd254800c7b9f4ab684 Mon Sep 17 00:00:00 2001
From: Aaron Levinson
Date: Thu, 13 Apr 2017 17:30:47 -0700
Subject: [PATCH] Enhanced require_pkg_config() in configure to
From 1059473c449c3079f03461bb42c2d3cc21d1b2c1 Mon Sep 17 00:00:00 2001
From: Aaron Levinson
Date: Fri, 14 Apr 2017 18:14:21 -0700
Subject: [PATCH] Enhanced configure and Makefile to copy .pdb files to
bindir for MSVC builds for make install
Purpose: Enhanced configure and Makefile to copy .pdb
From e0c73c054add0137901d0bf7a7893e42e7e566c8 Mon Sep 17 00:00:00 2001
From: Aaron Levinson
Date: Fri, 14 Apr 2017 18:38:37 -0700
Subject: [PATCH] Added require fallback for libmfx in the case that
pkg-config cannot find libmfx
Purpose: Added require fallback for libmfx in the case that pkg
On 4/14/2017 6:04 PM, James Almer wrote:
On 4/13/2017 9:56 PM, Aaron Levinson wrote:
From 48f7daba16e0fcdb83d9abd254800c7b9f4ab684 Mon Sep 17 00:00:00 2001
From: Aaron Levinson
Date: Thu, 13 Apr 2017 17:30:47 -0700
Subject: [PATCH] Enhanced require_pkg_config() in configure to fallback to
On 4/13/2017 5:03 PM, Aaron Levinson wrote:
> From 558b957eb85a669899750b2e150eba7cdee8dcd9 Mon Sep 17 00:00:00 2001
> From: Aaron Levinson
> Date: Thu, 13 Apr 2017 16:46:59 -0700
> Subject: [PATCH] Enhanced configure to improve compiler options associated
> with debugging with V
On 4/15/2017 4:25 AM, Ricardo Constantino wrote:
> On 15 April 2017 at 02:51, Aaron Levinson wrote:
>
>> From e0c73c054add0137901d0bf7a7893e42e7e566c8 Mon Sep 17 00:00:00 2001
>> From: Aaron Levinson
>> Date: Fri, 14 Apr 2017 18:38:37 -0700
>> Subject: [PATCH] Add
On 4/15/2017 4:19 AM, Marton Balint wrote:
On Thu, 13 Apr 2017, Aaron Levinson wrote:
On 4/13/2017 1:23 PM, Hendrik Leppkes wrote:
[...]
From 00fdc9d15414a92a155eb7d1394bac3736dc9405 Mon Sep 17 00
On 4/16/2017 8:57 AM, Matt Oliver wrote:
On 14 April 2017 at 08:05, Hendrik Leppkes wrote:
On Fri, Apr 14, 2017 at 12:00 AM, Ronald S. Bultje
wrote:
Hi Aaron,
On Thu, Apr 13, 2017 at 4:47 PM, Aaron Levinson
wrote:
#if ARCH_AARCH64
if (ARCH_AARCH64)
return
On 4/15/2017 9:32 PM, James Almer wrote:
On 4/15/2017 7:41 AM, Marton Balint wrote:
On Thu, 13 Apr 2017, Aaron Levinson wrote:
On 4/13/2017 3:40 PM, Marton Balint wrote:
On Thu, 13 Apr 2017, Aaron Levinson wrote:
On 4/13/2017 2:12 AM, Hendrik Leppkes wrote:
On Thu, Apr 13, 2017 at 10:36
On 4/16/2017 10:08 AM, Ronald S. Bultje wrote:
Hi,
On Sun, Apr 16, 2017 at 12:59 PM, Aaron Levinson
wrote:
I like using this approach, but I think such files should only be added to
the build if --disable-optimizations is passed into configure.
Or you could detect in configure if the
On 4/16/2017 12:15 PM, wm4 wrote:
On Sun, 16 Apr 2017 15:23:15 -0300
James Almer wrote:
On 4/16/2017 2:17 PM, Aaron Levinson wrote:
On 4/15/2017 9:32 PM, James Almer wrote:
On 4/15/2017 7:41 AM, Marton Balint wrote:
On Thu, 13 Apr 2017, Aaron Levinson wrote:
On 4/13/2017 3:40 PM, Marton
;s 'strict' pthread implementation (for assert levels above 0).
Maybe it needs to be disabled for C++ sources."
Aaron
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
On 4/15/2017 6:13 AM, Aaron Levinson wrote:
> On 4/15/2017 4:19 AM, Marton Balint wrote:
>>
>> On Thu, 13 Apr 2017, Aaron Levinson wrote:
>>
>>> On 4/13/2017
On 4/16/2017 3:31 PM, Hendrik Leppkes wrote:
On Mon, Apr 17, 2017 at 12:26 AM, Aaron Levinson wrote:
On 4/16/2017 1:33 PM, Timo Rothenpieler wrote:
Thanks, applied.
Regards,
Marton
This seems to have broken the coverity builds:
https://travis-ci.org/FFmpeg/FFmpeg-Coverity/builds
On 4/16/2017 4:25 PM, Aaron Levinson wrote:
On 4/16/2017 3:31 PM, Hendrik Leppkes wrote:
On Mon, Apr 17, 2017 at 12:26 AM, Aaron Levinson
wrote:
On 4/16/2017 1:33 PM, Timo Rothenpieler wrote:
Thanks, applied.
Regards,
Marton
This seems to have broken the coverity builds:
https://travis
From 9e6a9e2b8d58f17c661a3f455e03c95587ec7b18 Mon Sep 17 00:00:00 2001
From: Aaron Levinson
Date: Sun, 16 Apr 2017 17:13:31 -0700
Subject: [PATCH] libavutil/thread.h: Fixed g++ build error when
ASSERT_LEVEL is greater than 1
Purpose: libavutil/thread.h: Fixed g++ build error when ASSERT_LEVEL
I'll try that again with [PATCH] in the subject line.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
From 9e6a9e2b8d58f17c661a3f455e03c95587ec7b18 Mon Sep 17 00:00:00 2001
From: Aaron Levinson
Date: Sun, 16 Apr 2017 17:13:31 -0700
Subject: [PATCH] libavutil/thread.h: Fixed g++ build error when
ASSERT_LEVEL is greater than 1
Purpose: libavutil/thread.h: Fixed g++ build error when ASSERT_LEVEL
On 4/17/2017 8:28 AM, wm4 wrote:
On Mon, 17 Apr 2017 12:06:59 -0300
James Almer wrote:
On 4/17/2017 5:39 AM, Clément Bœsch wrote:
On Sun, Apr 16, 2017 at 05:20:02PM -0700, Aaron Levinson wrote:
From 9e6a9e2b8d58f17c661a3f455e03c95587ec7b18 Mon Sep 17 00:00:00 2001
From: Aaron Levinson
Date
On 4/14/2017 6:51 PM, Aaron Levinson wrote:
From e0c73c054add0137901d0bf7a7893e42e7e566c8 Mon Sep 17 00:00:00 2001
From: Aaron Levinson
Date: Fri, 14 Apr 2017 18:38:37 -0700
Subject: [PATCH] Added require fallback for libmfx in the case that
pkg-config cannot find libmfx
Purpose: Added
From 4f27e910aca6dae6642b4d73cf07fa0d6c4b1618 Mon Sep 17 00:00:00 2001
From: Aaron Levinson
Date: Thu, 20 Apr 2017 23:20:20 -0700
Subject: [PATCH] Fixed memory leaks associated with AVStream objects if
FF_API_LAVF_AVCTX is defined
Purpose: Fixed memory leaks associated with AVStream objects if
On 4/19/2017 2:27 PM, Marton Balint wrote:
On Mon, 17 Apr 2017, James Almer wrote:
On 4/17/2017 5:39 AM, Clément Bœsch wrote:
On Sun, Apr 16, 2017 at 05:20:02PM -0700, Aaron Levinson wrote:
From 9e6a9e2b8d58f17c661a3f455e03c95587ec7b18 Mon Sep 17 00:00:00 2001
From: Aaron Levinson
Date
From 7ea6455cd52ffe561f94bf03f48c4c2cf61b33c5 Mon Sep 17 00:00:00 2001
From: Aaron Levinson
Date: Fri, 21 Apr 2017 15:55:11 -0700
Subject: [PATCH] Added additional note to fate.texi to describe the importance
of not checking out files from git with core.autocrlf set to true
Purpose: Added
On 4/21/2017 4:17 PM, Lou Logan wrote:
> On Fri, 21 Apr 2017 16:05:16 -0700
> Aaron Levinson wrote:
>
>> From 7ea6455cd52ffe561f94bf03f48c4c2cf61b33c5 Mon Sep 17 00:00:00 2001
>> From: Aaron Levinson
>> Date: Fri, 21 Apr 2017 15:55:11 -0700
>> Subject: [PATCH] A
Note that in case it wasn't clear, I confirmed that this patch works by
running make on Linux and examining both the generated text file and the
generated HTML file in a Web browser.
Aaron
On 4/21/2017 4:48 PM, Aaron Levinson wrote:
On 4/21/2017 4:17 PM, Lou Logan wrote:
On Fri, 21 Apr
ssors at all if the fields are public? As far as
I can tell, the benefit to using these accessors is that, if certain
properties become internal in the future, or variable names change, or
the structures become opaque, etc, the code will continue to work.
Aaron Lev
On 4/22/2017 2:16 AM, Clément Bœsch wrote:
On Fri, Apr 21, 2017 at 04:48:27PM -0700, Aaron Levinson wrote:
[...]
diff --git a/doc/fate.texi b/doc/fate.texi
index 7a96c25..f3b8c0c8 100644
--- a/doc/fate.texi
+++ b/doc/fate.texi
@@ -77,6 +77,16 @@ FATE_SAMPLES=fate-suite/ make fate
@float NOTE
On 4/22/2017 12:09 PM, Hendrik Leppkes wrote:
On Sat, Apr 22, 2017 at 9:07 PM, Aaron Levinson wrote:
On 4/22/2017 2:16 AM, Clément Bœsch wrote:
On Fri, Apr 21, 2017 at 04:48:27PM -0700, Aaron Levinson wrote:
[...]
diff --git a/doc/fate.texi b/doc/fate.texi
index 7a96c25..f3b8c0c8 100644
t with the values in src, and besides the copies made of
dest->codec and dest->priv_data earlier in the function, anything else
that is overwritten could in theory leak. But, I guess that would have
been a preexisting issue with this function and not really relevant for
this patch. And th
lements in dest, even though they are owned by src. After doing the
memcpy() call, I think you can fix this by setting dest->coded_side_data
to NULL and dest->nb_coded_side_data to 0.
Everything else looks good.
Aaron Levinson
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
fmpeg was to contribute it to libav first. But, if this patch has to
pass yet another round of code reviews, code reviews that weren't
forthcoming in the first place on ffmpeg-devel when I originally
submitted the patch, then that could be problematic.
Aaro
resolution and move forward. Its one thing to fire off
an e-mail--its another to say things to someone's "face", so to speak.
I'd also suggest, when passions are up, to step aside and then maybe
come back to it later.
Aaron Levinson
define alloc_and_copy_or_fail(obj, size, pad) \
if (src->obj && size > 0) { \
I'm not sure if this patch is intended to be a replacement for your last
"2/2" patch, but this version is missing the the coded_side_data
population code that was in the first version
ame based on the way it is
formed, this in theory could be a problem, although it is unlikely in
practice since LINE_BUFFER_SIZE is 1024. While ideally there would be a
sanity check somewhere in the code to make sure those URLs aren't too
long, an alternative is to copy up to max LINE
On 4/26/2017 12:47 PM, James Almer wrote:
On 4/26/2017 2:46 AM, Aaron Levinson wrote:
On 4/24/2017 3:47 PM, James Almer wrote:
Free coded_frame, coded_side_data and unref hw_device_ctx to prevent
potential leaks.
Signed-off-by: James Almer
---
libavcodec/options.c | 15 +++
1
to populate
milliseconds anyway as follows:
if (!strftime(buf, size, "%Y-%m-%dT%H:%M:%S.000Z", ptm))
Aaron Levinson
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
On 5/1/2017 1:51 AM, Carl Eugen Hoyos wrote:
Hi!
Even without the casts, the patch reduces the number of warnings shown when
compiling compat/strtod from seven to three.
Please comment, Carl Eugen
LGTM
Aaron Levinson
___
ffmpeg-devel mailing list
mmit your patch, but hopefully someone
else will do so.
Aaron Levinson
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
currently taken in configure
doesn't distinguish between encoding and decoding, but the patch as
originally proposed just trades decoding API requirements for encoding
API requirements.
Aaron Levinson
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
f(hls->key_uri)).
In addition, based on the EXT-X-KEY example at
https://developer.apple.com/library/content/technotes/tn2288/_index.html
, it would appear that an EXT-X-KEY declaration may span multiple lines.
Your solution will not work properly in this case.
Aaron Levinson
+
I don't seem to have the original e-mail in my inbox anymore, so I'll
respond to wm4's response. Overall, the new code is a lot cleaner and
easier to understand than the existing code.
See below for more.
Aaron Levinson
On 5/2/2017 5:04 PM, wm4 wrote:
On Fri, 28 Apr 2017
On 4/22/2017 12:22 PM, Aaron Levinson wrote:
On 4/22/2017 12:09 PM, Hendrik Leppkes wrote:
On Sat, Apr 22, 2017 at 9:07 PM, Aaron Levinson
wrote:
On 4/22/2017 2:16 AM, Clément Bœsch wrote:
On Fri, Apr 21, 2017 at 04:48:27PM -0700, Aaron Levinson wrote:
[...]
This is documented in doc
From 345a98d31c6c758f0f82edab1b502cd8aeb3354b Mon Sep 17 00:00:00 2001
From: Aaron Levinson
Date: Wed, 3 May 2017 12:38:39 -0700
Subject: [PATCH] doc: Enhanced fate.texi to reference Windows line endings
section from git-howto.texi
Purpose: Enhanced fate.texi to indicate that FATE will fail if
On 4/21/2017 2:03 PM, James Almer wrote:
On 4/21/2017 12:09 PM, Michael Niedermayer wrote:
On Thu, Apr 20, 2017 at 11:30:13PM -0700, Aaron Levinson wrote:
From 4f27e910aca6dae6642b4d73cf07fa0d6c4b1618 Mon Sep 17 00:00:00 2001
From: Aaron Levinson
Date: Thu, 20 Apr 2017 23:20:20 -0700
Subject
James,
Can you document which patches depend on other patches in this patch set
to make it easier to review this patch set in chunks?
Thanks,
Aaron Levinson
On 5/2/2017 2:55 PM, James Almer wrote:
Some changes and fixes suggested on IRC. Some patches are v3 as they have
been sent before
NAN);
In order to preserve the original logic, why not do the following:
+num = den ? num * intnum / den : (((num * intnum) != 0) ? INFINITY :
NAN);
Aaron Levinson
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
never use 32 characters, its not a big deal to
have a little waste here. The buffer size should match the format
specification. An alternative would be to use "%02hd" or "%02hhd", but
doing so would require casts or using different types for hh, mm, etc.
Aaron Levins
On 5/4/2017 9:15 PM, Steven Liu wrote:
2017-05-03 9:49 GMT+08:00 Aaron Levinson :
On 4/27/2017 7:21 PM, Steven Liu wrote:
2017-04-26 7:30 GMT+08:00 Steven Liu :
fix ticket id: #6353
Signed-off-by: Steven Liu
---
libavformat/hlsenc.c | 24
1 file changed, 24
On 5/2/2017 2:29 PM, wm4 wrote:
On Tue, 2 May 2017 14:17:33 -0700
Aaron Levinson wrote:
On 5/1/2017 11:06 PM, MFojtak wrote:
Currently this muxer does not work at all. I don't know if 000Z would make
it compatible with more player as I don't know any. However, adding Z makes
it
On 4/12/2017 6:08 PM, Aaron Levinson wrote:
> On 3/26/2017 10:34 AM, Aaron Levinson wrote:
>> On 3/26/2017 4:41 AM, Matthias Hunstock wrote:
>>> Am 26.03.2017 um 11:50 schrieb Aaron Levinson:
>>>> When using the following command to play back either file:
>>
On 4/14/2017 6:27 PM, Aaron Levinson wrote:
From 1059473c449c3079f03461bb42c2d3cc21d1b2c1 Mon Sep 17 00:00:00 2001
From: Aaron Levinson
Date: Fri, 14 Apr 2017 18:14:21 -0700
Subject: [PATCH] Enhanced configure and Makefile to copy .pdb files to
bindir for MSVC builds for make install
Purpose
On 4/19/2017 10:43 AM, Aaron Levinson wrote:
> On 4/14/2017 6:51 PM, Aaron Levinson wrote:
>> From e0c73c054add0137901d0bf7a7893e42e7e566c8 Mon Sep 17 00:00:00 2001
>> From: Aaron Levinson
>> Date: Fri, 14 Apr 2017 18:38:37 -0700
>> Subject: [PATCH] Added require fall
On 4/16/2017 4:11 PM, Aaron Levinson wrote:
> On 4/15/2017 6:13 AM, Aaron Levinson wrote:
>> On 4/15/2017 4:19 AM, Marton Balint wrote:
>>>
>>> On Thu, 13 Apr 2017, Aaron Levinson wrote:
>>>
>>>> On 4/13/2017 1:23 PM, Hendrik Leppkes wrote:
>&
On 5/5/2017 12:20 AM, Carl Eugen Hoyos wrote:
2017-05-05 3:29 GMT+02:00 Aaron Levinson :
On 5/4/2017 4:27 PM, Carl Eugen Hoyos wrote:
Hi!
Attached patch is one possibility to fix the following warning with gcc 7:
libavutil/timecode.c: In function ‘av_timecode_make_string’:
libavutil
On 5/5/2017 12:42 AM, Clément Bœsch wrote:
On Fri, May 05, 2017 at 12:11:27AM -0700, Aaron Levinson wrote:
On 4/19/2017 10:43 AM, Aaron Levinson wrote:
On 4/14/2017 6:51 PM, Aaron Levinson wrote:
From e0c73c054add0137901d0bf7a7893e42e7e566c8 Mon Sep 17 00:00:00 2001
From: Aaron Levinson
Date
On 5/5/2017 12:44 AM, Carl Eugen Hoyos wrote:
2017-05-05 9:42 GMT+02:00 Aaron Levinson :
On 5/5/2017 12:20 AM, Carl Eugen Hoyos wrote:
2017-05-05 3:29 GMT+02:00 Aaron Levinson :
On 5/4/2017 4:27 PM, Carl Eugen Hoyos wrote:
Hi!
Attached patch is one possibility to fix the following
On 5/5/2017 12:55 AM, wm4 wrote:
On Thu, 4 May 2017 23:46:30 -0700
Aaron Levinson wrote:
On 4/12/2017 6:08 PM, Aaron Levinson wrote:
On 3/26/2017 10:34 AM, Aaron Levinson wrote:
On 3/26/2017 4:41 AM, Matthias Hunstock wrote:
Am 26.03.2017 um 11:50 schrieb Aaron Levinson
On 5/5/2017 12:57 AM, Clément Bœsch wrote:
On Fri, May 05, 2017 at 12:54:12AM -0700, Aaron Levinson wrote:
[...]
Back to your issue: you should fix the .pc in the upstream project, this
is the correct fix.
The "upstream project" in this case is the Intel Media SDK. This is not an
o
The entire patch set LGTM.
Aaron Levinson
On 5/3/2017 6:41 PM, James Almer wrote:
On 5/3/2017 9:39 PM, Aaron Levinson wrote:
James,
Can you document which patches depend on other patches in this patch set
to make it easier to review this patch set in chunks?
Patch 2 depends on 1. Patches 3
On 5/5/2017 4:57 PM, Marton Balint wrote:
>
>
> On Fri, 5 May 2017, Aaron Levinson wrote:
>
>> On 4/16/2017 4:11 PM, Aaron Levinson wrote:
>>> On 4/15/2017 6:13 AM, Aaron Levinson wrote:
>>>> On 4/15/2017 4:19 AM, Marton Balint wrote:
>>>&g
On 5/5/2017 4:50 AM, Michael Niedermayer wrote:
> On Fri, May 05, 2017 at 11:36:05AM +0200, Hendrik Leppkes wrote:
>> On Fri, May 5, 2017 at 9:57 AM, Clément Bœsch wrote:
>>> On Fri, May 05, 2017 at 12:54:12AM -0700, Aaron Levinson wrote:
>>> [...]
>>>>>
1 - 100 of 240 matches
Mail list logo
