[dpdk-dev] [PATCH] net/mlx5: fix tci mask filter

2018-07-23 Thread Nelio Laranjeiro
In mlx5_traffic_enable() the TCI mask for the VLAN is wrong causing the sub flow engine to reject the rule. Fixes: 272733b5ebfd ("net/mlx5: use flow to enable unicast traffic") Cc: sta...@dpdk.org Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_trigger.c | 10 -- 1 file change

Re: [dpdk-dev] [PATCH] crypto/virtio: fix memory leak

2018-07-23 Thread Zhoujian (jay)
> -Original Message- > From: Pablo de Lara [mailto:pablo.de.lara.gua...@intel.com] > Sent: Thursday, July 19, 2018 5:06 PM > To: Zhoujian (jay) > Cc: dev@dpdk.org; Pablo de Lara ; > sta...@dpdk.org > Subject: [PATCH] crypto/virtio: fix memory leak > > Put session private data back to memp

Re: [dpdk-dev] Patch compilation failure

2018-07-23 Thread De Lara Guarch, Pablo
Hi Qiaobin, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Fu, Qiaobin > Sent: Saturday, July 21, 2018 7:58 PM > To: dev@dpdk.org > Cc: Fu, Qiaobin > Subject: [dpdk-dev] Patch compilation failure > > Dear DPDK developers, > > When I submitted a DPDK patch (h

Re: [dpdk-dev] [PATCH] net/mlx5: fix compilation issues on old kernels

2018-07-23 Thread Shahaf Shuler
Sunday, July 15, 2018 8:32 PM, Mordechay Haimovsky: > Subject: [PATCH] net/mlx5: fix compilation issues on old kernels > > This commit fixes compilation errors due to missing definitions found when > compiling mlx5 PMD from DPDK 17.11-LTS on Ubuntu 12.4 with kernel 3.15. > > Fixes: 75ef62a94301 (

Re: [dpdk-dev] [PATCH] crypto/aesni_mb: call buffer manager allocation

2018-07-23 Thread De Lara Guarch, Pablo
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Tuesday, July 3, 2018 6:58 AM > To: Doherty, Declan > Cc: dev@dpdk.org; De Lara Guarch, Pablo > Subject: [PATCH] crypto/aesni_mb: call buffer manager allocation > > Instead of having a static field for the buffer manager MB_MG

Re: [dpdk-dev] [PATCH] crypto/aesni_gcm: support IPsec Multi-buffer lib v0.50

2018-07-23 Thread De Lara Guarch, Pablo
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Tuesday, July 3, 2018 9:22 AM > To: Doherty, Declan > Cc: dev@dpdk.org; De Lara Guarch, Pablo > Subject: [PATCH] crypto/aesni_gcm: support IPsec Multi-buffer lib v0.50 > > Adds support for the v0.50 of the IPsec Multi-buffer l

Re: [dpdk-dev] [PATCH] crypto/aesni_mb: support IPsec Multi-buffer lib v0.50

2018-07-23 Thread De Lara Guarch, Pablo
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Tuesday, July 3, 2018 9:23 AM > To: Doherty, Declan > Cc: dev@dpdk.org; De Lara Guarch, Pablo > Subject: [PATCH] crypto/aesni_mb: support IPsec Multi-buffer lib v0.50 > > Adds support for the v0.50 of the IPsec Multi-buffer li

Re: [dpdk-dev] Patch compilation failure

2018-07-23 Thread Burakov, Anatoly
On 23-Jul-18 8:57 AM, De Lara Guarch, Pablo wrote: Hi Qiaobin, -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Fu, Qiaobin Sent: Saturday, July 21, 2018 7:58 PM To: dev@dpdk.org Cc: Fu, Qiaobin Subject: [dpdk-dev] Patch compilation failure Dear DPDK developers,

Re: [dpdk-dev] [PATCH v1] crypto/aesni_mb: support 3DES

2018-07-23 Thread De Lara Guarch, Pablo
> -Original Message- > From: Kovacevic, Marko > Sent: Friday, June 8, 2018 10:10 AM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; Jain, Deepak K > ; Kovacevic, Marko > Subject: [PATCH v1] crypto/aesni_mb: support 3DES > > From: Marko Kovacevic > > Added support for 3DES cipher alg

Re: [dpdk-dev] [PATCH v1] crypto/openssl: add support for 8 byte 3DES

2018-07-23 Thread De Lara Guarch, Pablo
> -Original Message- > From: Kovacevic, Marko > Sent: Tuesday, June 12, 2018 11:39 AM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; Jain, Deepak K > ; Kovacevic, Marko ; > Marko > Subject: [PATCH v1] crypto/openssl: add support for 8 byte 3DES > > Added extra case to support 8 byte k

Re: [dpdk-dev] [PATCH v3] crypto/qat: add support for 8 byte 3DES

2018-07-23 Thread De Lara Guarch, Pablo
> -Original Message- > From: Trahe, Fiona > Sent: Friday, July 20, 2018 7:49 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; Trahe, Fiona > ; Kovacevic, Marko > Subject: [PATCH v3] crypto/qat: add support for 8 byte 3DES > > Added extra case to support 8 byte key size for 3DES CBC.

Re: [dpdk-dev] [PATCH v1] crypto/openssl: add support for 8 byte 3DES

2018-07-23 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of De Lara Guarch, Pablo > Sent: Monday, July 23, 2018 9:50 AM > To: Kovacevic, Marko ; dev@dpdk.org > Cc: Jain, Deepak K ; Kovacevic, Marko > > Subject: Re: [dpdk-dev] [PATCH v1] crypto/openssl: add support for 8

Re: [dpdk-dev] [PATCH v1] crypto/aesni_mb: support 3DES

2018-07-23 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of De Lara Guarch, Pablo > Sent: Monday, July 23, 2018 9:49 AM > To: Kovacevic, Marko ; dev@dpdk.org > Cc: Jain, Deepak K > Subject: Re: [dpdk-dev] [PATCH v1] crypto/aesni_mb: support 3DES > > > > > -Origina

Re: [dpdk-dev] [PATCH v3] crypto/qat: add support for 8 byte 3DES

2018-07-23 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of De Lara Guarch, Pablo > Sent: Monday, July 23, 2018 9:55 AM > To: Trahe, Fiona ; dev@dpdk.org > Cc: Kovacevic, Marko > Subject: Re: [dpdk-dev] [PATCH v3] crypto/qat: add support for 8 byte 3DES > > > > >

Re: [dpdk-dev] [PATCH] crypto/virtio: fix memory leak

2018-07-23 Thread De Lara Guarch, Pablo
> -Original Message- > From: Zhoujian (jay) [mailto:jianjay.z...@huawei.com] > Sent: Monday, July 23, 2018 8:45 AM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; sta...@dpdk.org; wangxin (U) > > Subject: RE: [PATCH] crypto/virtio: fix memory leak > > > -Original Message- > >

Re: [dpdk-dev] commit 0ad778b39 (app/testpmd: rework softnic forward mode) compromises testpmd CLI

2018-07-23 Thread Singh, Jasvinder
Hi Moti, I didn't know about Ctrl+D option to quit testpmd as I always used "quit" on cli. Since Ctrl+D was working before this commit, I will send fix soon to cover this case. Thanks, Jasvinder From: Mordechay Haimovsky [mailto:mo...@mellanox.com] Sent: Sunday, July 22, 2018 5:04 PM To: Si

[dpdk-dev] [PATCH] app/testpmd: fix testpmd exit using ctrl+d

2018-07-23 Thread Jasvinder Singh
Fix testpmd app exit by pressing ctrl+d, End-of-Transmission character (EOT) on the empty command line. Fixes: 0ad778b398c6 ("app/testpmd: rework softnic forward mode") Reported-by: Mordechay Haimovsky Signed-off-by: Jasvinder Singh --- app/test-pmd/cmdline.c | 10 ++ lib/librte

[dpdk-dev] [PATCH] doc: fix incorrect create bonding command in testpmd

2018-07-23 Thread Shreyansh Jain
Fixes: e76d7a768ce0 ("doc: fix syntax in testpmd user guide") Cc: john.mcnam...@intel.com Cc: sta...@dpdk.org Signed-off-by: Shreyansh Jain --- Note: Though the git blame suggest e76d7a768c as the last modification for fixes, this actually existed when testpmd doc was added. doc/guides/te

Re: [dpdk-dev] [PATCH] app/crypto-perf: compile with O3

2018-07-23 Thread De Lara Guarch, Pablo
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Monday, June 25, 2018 1:53 PM > To: Doherty, Declan > Cc: dev@dpdk.org; De Lara Guarch, Pablo > Subject: [PATCH] app/crypto-perf: compile with O3 > > The crypto performance application was not being compiled with -O3, which >

Re: [dpdk-dev] [PATCH] examples/vhost_crypto: add multi-core support

2018-07-23 Thread De Lara Guarch, Pablo
Hi Jay/Maxime, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] > Sent: Friday, June 22, 2018 1:36 PM > To: dev@dpdk.org > Cc: maxime.coque...@redhat.com > Subject: [dpdk-dev] [PATCH] examples/vhost_crypto: add multi-core support > > Originally vhost_crypto sample applicatio

Re: [dpdk-dev] [PATCH] ethdev: move sanity checks to non-debug paths

2018-07-23 Thread Aaron Conole
Matan Azrad writes: > Hi Aaron > > From: Aaron Conole >> These checks would have prevented a reported crash in the field. If a user >> builds without ETHDEV_DEBUG, it should make their application more stable, >> not less. >> >> Many of these functions immediately dereference arrays based on th

[dpdk-dev] [PATCH] doc: fix mlx5 dependencies

2018-07-23 Thread Adrien Mazarguil
The new dependency of mlx5 to libmnl must be reflected in documentation. Fixes: 4d5cce06231a ("net/mlx5: lay groundwork for switch offloads") Signed-off-by: Adrien Mazarguil --- doc/guides/nics/mlx5.rst | 19 +++ 1 file changed, 19 insertions(+) diff --git a/doc/guides/nics/mlx

Re: [dpdk-dev] [PATCH] ethdev: move sanity checks to non-debug paths

2018-07-23 Thread Matan Azrad
Hi Aaron From: Aaron Conole > Sent: Monday, July 23, 2018 2:52 PM > To: Matan Azrad > Cc: dev@dpdk.org; Ferruh Yigit ; Marcelo Leitner > ; Shahaf Shuler ; Ori Kam > ; Thomas Monjalon > Subject: Re: [dpdk-dev] [PATCH] ethdev: move sanity checks to non-debug paths > > Matan Azrad writes: > > >

Re: [dpdk-dev] [PATCH v4 1/3] crypto/openssl: add rsa and mod asym op

2018-07-23 Thread De Lara Guarch, Pablo
Hi Shally, > -Original Message- > From: Shally Verma [mailto:shally.ve...@caviumnetworks.com] > Sent: Thursday, July 12, 2018 3:09 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; pathr...@caviumnetworks.com; > nmur...@caviumnetworks.com; Sunila Sahu > ; Ashish Gupta > > Subject: [PATC

Re: [dpdk-dev] [PATCH] sched: add 64-bit counter retrieval API

2018-07-23 Thread Alan Robertson
Looks good to me. Alan. On Wed, Jul 18, 2018 at 3:51 PM, wrote: > From: Alan Dewar > > Add new APIs to retrieve counters in 64-bit wide fields. > > Signed-off-by: Alan Dewar > --- > lib/librte_sched/rte_sched.c | 72 > lib/librte_sched/rte_sched.h

Re: [dpdk-dev] [PATCH v3 4/5] compress/zlib: support burst enqueue/dequeue

2018-07-23 Thread De Lara Guarch, Pablo
> -Original Message- > From: Shally Verma [mailto:shally.ve...@caviumnetworks.com] > Sent: Saturday, July 21, 2018 7:18 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; pathr...@caviumnetworks.com; > mcha...@caviumnetworks.com; ashish.gu...@caviumnetworks.com; > sunila.s...@caviumnetw

Re: [dpdk-dev] [PATCH v3 4/5] compress/zlib: support burst enqueue/dequeue

2018-07-23 Thread Verma, Shally
Hi Pablo >-Original Message- >From: De Lara Guarch, Pablo >Sent: 23 July 2018 18:07 >To: Verma, Shally >Cc: dev@dpdk.org; Athreya, Narayana Prasad >; Challa, Mahipal >; Gupta, Ashish ; Sahu, >Sunila ; Sahu, Sunila > >Subject: RE: [PATCH v3 4/5] compress/zlib: support burst enqueue/dequ

Re: [dpdk-dev] [PATCH v3 4/5] compress/zlib: support burst enqueue/dequeue

2018-07-23 Thread De Lara Guarch, Pablo
> -Original Message- > From: Verma, Shally [mailto:shally.ve...@cavium.com] > Sent: Monday, July 23, 2018 1:53 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; Athreya, Narayana Prasad > ; Challa, Mahipal > ; Gupta, Ashish ; > Sahu, Sunila ; Sahu, Sunila > > Subject: RE: [PATCH v3 4/

[dpdk-dev] [PATCH v2 1/2] common/qat: add sgl header

2018-07-23 Thread Fiona Trahe
This patch refactors the sgl struct so it includes a flexible array of flat buffers as sym and compress PMDs can have different size sgls. Signed-off-by: Tomasz Jozwiak Signed-off-by: Fiona Trahe --- v2 changes: - changed max_segs from int32_t to uint16_t to match max allowed by mbuf - declare

[dpdk-dev] [PATCH v2 2/2] compression/qat: add sgl feature

2018-07-23 Thread Fiona Trahe
This patch adds sgl feature to QAT compression PMD Signed-off-by: Tomasz Jozwiak Signed-off-by: Fiona Trahe --- v2 : no change - just resubmit with the changed 1/2 patch config/common_base | 1 + config/rte_config.h | 1 + doc/guides/compressdevs/f

[dpdk-dev] [PATCH v2 1/2] crypto/scheduler: add mode param parsing

2018-07-23 Thread Fan Zhang
This patch adds the mode parameter parsing to scheduler PMD. Signed-off-by: Fan Zhang --- doc/guides/cryptodevs/scheduler.rst | 5 + drivers/crypto/scheduler/scheduler_pmd.c | 22 ++ 2 files changed, 27 insertions(+) diff --git a/doc/guides/cryptodevs/scheduler.rst

[dpdk-dev] [PATCH v2 0/2] crypto/scheduler: add mode specific parameter support

2018-07-23 Thread Fan Zhang
This patch adds scheduler PMD mode specific parameter support. The packet-size-distr mode now support custom threshold during initialization. v2: - Rebased to master (thanks to Pablo) - Fixed documentation Fan Zhang (2): crypto/scheduler: add mode param parsing crypto/scheduler:

[dpdk-dev] [PATCH v2 2/2] crypto/scheduler: add packet-size-distr mode param parse

2018-07-23 Thread Fan Zhang
This patch adds packet-size-distr mode specific parameter parser to support different threshold packet size value other than default 128 bytes. Signed-off-by: Fan Zhang --- doc/guides/cryptodevs/scheduler.rst| 7 ++- drivers/crypto/scheduler/rte_cryptodev_scheduler.h | 1 + dri

[dpdk-dev] rte_mbuf library likely()/unlikely()

2018-07-23 Thread Morten Brørup
Hi Olivier, I noticed that __rte_pktmbuf_read() could do with an unlikely(), so I went through the entire library. Here are my suggested modifications. diff -bu rte_mbuf.c.orig rte_mbuf.c --- rte_mbuf.c.orig 2018-07-23 15:13:22.0 +0200 +++ rte_mbuf.c 2018-07-23 15:32:53.0

Re: [dpdk-dev] [PATCH] ethdev: move sanity checks to non-debug paths

2018-07-23 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Matan Azrad > Sent: Monday, July 23, 2018 1:14 PM > To: Aaron Conole > Cc: dev@dpdk.org; Yigit, Ferruh ; Marcelo Leitner > ; Shahaf Shuler > ; Ori Kam ; Thomas Monjalon > > Subject: Re: [dpdk-dev] [PATCH] eth

[dpdk-dev] [PATCH v5 0/3]crypto/openssl: support asymmetric crypto

2018-07-23 Thread Shally Verma
This patch series add asymmetric crypto support in openssl pmd changes in v5: - fix -Wimplicit-fallthrough compilation error with gcc-7+ toolchain changes in v4: - add openssl 1.1.0h support in openssl PMD for asym operations. - A compat.h added for PMD compatibility with both 1.0.2 and 1.1.0 -

[dpdk-dev] [PATCH v5 1/3] crypto/openssl: add rsa and mod asym op

2018-07-23 Thread Shally Verma
From: Sunila Sahu - Add compat.h to make pmd compatible to openssl-1.1.0 and backward version - Add rsa sign/verify/encrypt/decrypt and modular operation support Signed-off-by: Sunila Sahu Signed-off-by: Shally Verma Signed-off-by: Ashish Gupta --- drivers/crypto/openssl/compat.h

[dpdk-dev] [PATCH v5 2/3] crypto/openssl: add dh and dsa asym op

2018-07-23 Thread Shally Verma
From: Sunila Sahu - Add dh key generation and shared compute - Add dsa sign and verify operation Signed-off-by: Sunila Sahu Signed-off-by: Shally Verma Signed-off-by: Ashish Gupta --- drivers/crypto/openssl/compat.h | 68 +++ drivers/crypto/openssl/rte_openssl_pmd.c

[dpdk-dev] [PATCH v5 3/3] doc: add asym feature list

2018-07-23 Thread Shally Verma
From: Ashish Gupta Signed-off-by: Sunila Sahu Signed-off-by: Shally Verma Signed-off-by: Ashish Gupta --- doc/guides/cryptodevs/features/openssl.ini | 11 +++ doc/guides/cryptodevs/openssl.rst | 1 + 2 files changed, 12 insertions(+) diff --git a/doc/guides/cryptodevs/featu

[dpdk-dev] [PATCH v4 1/5] compress/zlib: add ZLIB PMD

2018-07-23 Thread Shally Verma
From: Ashish Gupta Add initial PMD setup routines in compressdev framework. ZLIB PMD appears as virtual compression device. User would need to install zlib prior to enabling this PMD. Signed-off-by: Sunila Sahu Signed-off-by: Shally Verma Signed-off-by: Ashish Gupta --- MAINTAINERS

[dpdk-dev] [PATCH v4 0/5] compress: add ZLIB compression PMD

2018-07-23 Thread Shally Verma
This patch series add software zlib library (http://zlib.net/) based compression PMD in DPDK compress drivers. Application must need to install zlib prior to enabling this PMD to avail compression/decompression services. Currently driver only tested for deflate, stateless compression and decompres

[dpdk-dev] [PATCH v4 2/5] compress/zlib: add device PMD ops

2018-07-23 Thread Shally Verma
From: Ashish Gupta Implement device configure and queue pair setup PMD ops Signed-off-by: Sunila Sahu Signed-off-by: Shally Verma Signed-off-by: Ashish Gupta --- drivers/compress/zlib/Makefile | 1 + drivers/compress/zlib/meson.build| 2 +- drivers/compress/zlib/zlib_pm

[dpdk-dev] [PATCH v4 3/5] compress/zlib: create private xform

2018-07-23 Thread Shally Verma
From: Sunila Sahu Create non-shareable private xform for stateless operation processing Signed-off-by: Sunila Sahu Signed-off-by: Shally Verma Signed-off-by: Ashish Gupta --- drivers/compress/zlib/zlib_pmd.c | 94 drivers/compress/zlib/zlib_pmd_ops.c

[dpdk-dev] [PATCH v4 4/5] compress/zlib: support burst enqueue/dequeue

2018-07-23 Thread Shally Verma
From: Sunila Sahu Signed-off-by: Sunila Sahu Signed-off-by: Shally Verma Signed-off-by: Ashish Gupta --- drivers/compress/zlib/zlib_pmd.c | 255 ++- 1 file changed, 254 insertions(+), 1 deletion(-) diff --git a/drivers/compress/zlib/zlib_pmd.c b/drivers/co

[dpdk-dev] [PATCH v4 5/5] doc: add ZLIB PMD guide

2018-07-23 Thread Shally Verma
Add zlib pmd feature support and user guide with build and run instructions Signed-off-by: Sunila Sahu Signed-off-by: Shally Verma Signed-off-by: Ashish Gupta --- MAINTAINERS | 2 + doc/guides/compressdevs/features/zlib.ini | 11 + doc/guides/compressdevs/ind

Re: [dpdk-dev] [PATCH v5 1/3] crypto/openssl: add rsa and mod asym op

2018-07-23 Thread Stephen Hemminger
On Mon, 23 Jul 2018 20:16:03 +0530 Shally Verma wrote: > +#define set_rsa_params(rsa, p, q, ret) \ > + do {rsa->p = p; rsa->q = q; ret = 0; } while (0) > + > +#define set_rsa_crt_params(rsa, dmp1, dmq1, iqmp, ret) \ > + do { \ > + rsa->dmp1 = dmp1; \ > + rsa->dmq1

Re: [dpdk-dev] [PATCH] sched: add 64-bit counter retrieval API

2018-07-23 Thread Stephen Hemminger
On Wed, 18 Jul 2018 15:51:39 +0100 alangordonde...@gmail.com wrote: > From: Alan Dewar > > Add new APIs to retrieve counters in 64-bit wide fields. > > Signed-off-by: Alan Dewar Do you want to consider 64 bit counter roll over on 32 bit platform? The problem is that incrementing an 64 bit val

Re: [dpdk-dev] [PATCH v3 4/5] compress/zlib: support burst enqueue/dequeue

2018-07-23 Thread Stephen Hemminger
On Sat, 21 Jul 2018 23:47:48 +0530 Shally Verma wrote: > -/** Parse comp xform and set private xform/stream parameters */ > +/** Compute next mbuf in the list, assign data buffer and length, > + * returns 0 if mbuf is NULL > + */ > +#define COMPUTE_BUF(mbuf, data, len) \ > +

Re: [dpdk-dev] [PATCH v5 1/3] crypto/openssl: add rsa and mod asym op

2018-07-23 Thread Verma, Shally
>-Original Message- >From: Stephen Hemminger >Sent: 23 July 2018 22:20 >To: Verma, Shally >Cc: pablo.de.lara.gua...@intel.com; dev@dpdk.org; Athreya, Narayana Prasad >; Murthy, >Nidadavolu ; Sahu, Sunila >; Gupta, Ashish > >Subject: Re: [dpdk-dev] [PATCH v5 1/3] crypto/openssl: add r

Re: [dpdk-dev] [PATCH v3 4/5] compress/zlib: support burst enqueue/dequeue

2018-07-23 Thread Verma, Shally
>-Original Message- >From: Stephen Hemminger >Sent: 23 July 2018 22:24 >To: Verma, Shally >Cc: pablo.de.lara.gua...@intel.com; dev@dpdk.org; Athreya, Narayana Prasad >; Challa, >Mahipal ; Gupta, Ashish ; >Sahu, Sunila ; >Sahu, Sunila >Subject: Re: [dpdk-dev] [PATCH v3 4/5] compress/

Re: [dpdk-dev] [PATCH v3 4/5] compress/zlib: support burst enqueue/dequeue

2018-07-23 Thread Stephen Hemminger
On Mon, 23 Jul 2018 17:14:26 + "Verma, Shally" wrote: > >-Original Message- > >From: Stephen Hemminger > >Sent: 23 July 2018 22:24 > >To: Verma, Shally > >Cc: pablo.de.lara.gua...@intel.com; dev@dpdk.org; Athreya, Narayana Prasad > >; Challa, > >Mahipal ; Gupta, Ashish > >; Sahu,

Re: [dpdk-dev] rte_mbuf library likely()/unlikely()

2018-07-23 Thread Stephen Hemminger
On Mon, 23 Jul 2018 15:53:42 +0200 Morten Brørup wrote: > Hi Olivier, > > > > I noticed that __rte_pktmbuf_read() could do with an unlikely(), so I went > through the entire library. Here are my suggested modifications. > > > > > > diff -bu rte_mbuf.c.orig rte_mbuf.c > > --- rte_mbuf

Re: [dpdk-dev] rte_mbuf library likely()/unlikely()

2018-07-23 Thread Honnappa Nagarahalli
Do you see any performance improvements with these changes? -Original Message- From: dev On Behalf Of Morten Brørup Sent: Monday, July 23, 2018 8:54 AM To: Olivier Matz Cc: dev@dpdk.org Subject: [dpdk-dev] rte_mbuf library likely()/unlikely() Hi Olivier, I noticed that __rte_pktmbuf_

Re: [dpdk-dev] [PATCH v4 5/5] doc: add ZLIB PMD guide

2018-07-23 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Shally Verma > Sent: Monday, July 23, 2018 3:51 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; pathr...@caviumnetworks.com; > mcha...@caviumnetworks.com; Sunila Sahu > ; Ashish Gupta > > Subject: [dpdk-dev]

[dpdk-dev] [PATCH] net/mlx5: fix assert for Tx completion queue count

2018-07-23 Thread Yongseok Koh
There should be at least one Tx CQE remained if Tx WQ and txq->elts[] have available slots to send a packet because the size of Tx CQ is exactly calculated from the size of other resources. As it is guaranteed, it is checked by an assertion. max_elts is checked after the assertion for Tx CQ. If no

Re: [dpdk-dev] [PATCH v4 5/5] doc: add ZLIB PMD guide

2018-07-23 Thread Verma, Shally
>-Original Message- >From: De Lara Guarch, Pablo >Sent: 23 July 2018 23:28 >To: Verma, Shally >Cc: dev@dpdk.org; Athreya, Narayana Prasad >; Challa, Mahipal >; Sahu, Sunila ; Gupta, >Ashish >Subject: RE: [dpdk-dev] [PATCH v4 5/5] doc: add ZLIB PMD guide > >External Email > >> -O

[dpdk-dev] [PATCH v3] compress/isal: add chained mbuf support

2018-07-23 Thread Daly, Lee
This patch adds chained mbuf support for input or output buffers during compression/decompression operations. Signed-off-by: Lee Daly --- doc/guides/compressdevs/features/isal.ini | 17 +- doc/guides/compressdevs/isal.rst | 2 - drivers/compress/isal/isal_compress_pmd.c |

Re: [dpdk-dev] [PATCH v2 1/2] common/qat: add sgl header

2018-07-23 Thread De Lara Guarch, Pablo
> -Original Message- > From: Trahe, Fiona > Sent: Monday, July 23, 2018 2:06 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; Trahe, Fiona > ; Jozwiak, TomaszX > Subject: [PATCH v2 1/2] common/qat: add sgl header > > This patch refactors the sgl struct so it includes a flexible arra

[dpdk-dev] [PATCH] net/mlx5: fix possible endless loop when clearing flow flags

2018-07-23 Thread Yongseok Koh
If one of (*priv->rxqs)[] is null, the for loop can iterate infinitely as idx can't be increased. Fixes: cd24d526395e ("net/mlx5: add mark/flag flow action") Cc: Nelio Laranjeiro Signed-off-by: Yongseok Koh --- drivers/net/mlx5/mlx5_flow.c | 8 +++- 1 file changed, 3 insertions(+), 5 delet

Re: [dpdk-dev] rte_mbuf library likely()/unlikely()

2018-07-23 Thread Morten Brørup
> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Monday, July 23, 2018 7:38 PM > To: Morten Brørup > Cc: Olivier Matz; dev@dpdk.org > Subject: Re: [dpdk-dev] rte_mbuf library likely()/unlikely() > > On Mon, 23 Jul 2018 15:53:42 +0200 > Morten Brør

Re: [dpdk-dev] rte_mbuf library likely()/unlikely()

2018-07-23 Thread Morten Brørup
I haven't performance tested, but they are compiler branch prediction hints pointing out the most likely execution path, so I expect them to have a positive effect. E.g. the first comparison in __rte_pktmbuf_read() is very unlikely to be true - it would mean that the application is trying to re

Re: [dpdk-dev] rte_mbuf library likely()/unlikely()

2018-07-23 Thread Stephen Hemminger
On Mon, 23 Jul 2018 20:59:29 +0200 Morten Brørup wrote: > > -Original Message- > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > Sent: Monday, July 23, 2018 7:38 PM > > To: Morten Brørup > > Cc: Olivier Matz; dev@dpdk.org > > Subject: Re: [dpdk-dev] rte_mbuf library like

Re: [dpdk-dev] [PATCH] ethdev: move sanity checks to non-debug paths

2018-07-23 Thread Andrew Rybchenko
On 23.07.2018 17:19, Ananyev, Konstantin wrote: -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Matan Azrad Sent: Monday, July 23, 2018 1:14 PM To: Aaron Conole Cc: dev@dpdk.org; Yigit, Ferruh ; Marcelo Leitner ; Shahaf Shuler ; Ori Kam ; Thomas Monjalon Subjec

Re: [dpdk-dev] [PATCH v3] examples/flow_filtering: add rte_fdir_conf initialization

2018-07-23 Thread Ferruh Yigit
On 7/22/2018 11:39 AM, Rosen Xu wrote: > Rte_fdir_conf of rte_eth_conf should be initialized before > port initialization. It is a workaround solution when working > with Intel I40e. > > Fixes: 4a3ef59a10c8 ("examples/flow_filtering: add simple demo of flow API") > Cc: sta...@dpdk.org > > Signed-

Re: [dpdk-dev] Bypass support in the i40e PMD driver

2018-07-23 Thread Ferruh Yigit
On 7/20/2018 7:39 PM, EJ Raymond wrote: > Hi, > > I'm currently working with the PE310G4BPI71 Bypass card from Silicom, Inc., > This board is based on the i40E chip (Intel X710 - Fortville). In DPDK, > this card makes use of the i40e PMD driver, and I've noticed that bypass > configuration is only

Re: [dpdk-dev] [dpdk-stable] [PATCH] doc: fix incorrect create bonding command in testpmd

2018-07-23 Thread Ferruh Yigit
On 7/23/2018 12:27 PM, Shreyansh Jain wrote: > Fixes: e76d7a768ce0 ("doc: fix syntax in testpmd user guide") > Cc: john.mcnam...@intel.com > Cc: sta...@dpdk.org > > Signed-off-by: Shreyansh Jain > --- > Note: Though the git blame suggest e76d7a768c as the last modification > for fixes, this

[dpdk-dev] [PATCH] net/mlx5: fix queue rollback when starting device

2018-07-23 Thread Yongseok Koh
mlx5_rxq_start() and mlx5_rxq_stop() must be strictly paired because internal reference counter is increased or decreased inside. Also, mlx5_rxq_get() must be paired with mlx5_rxq_release(). Fixes: 7d6bf6b866b8 ("net/mlx5: add Multi-Packet Rx support") Fixes: a1366b1a2be3 ("net/mlx5: add reference

Re: [dpdk-dev] [PATCH v3] compress/isal: add chained mbuf support

2018-07-23 Thread De Lara Guarch, Pablo
Hi Lee, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Daly, Lee > Sent: Monday, July 23, 2018 7:02 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; Daly, Lee > Subject: [dpdk-dev] [PATCH v3] compress/isal: add chained mbuf support > > This patch adds chai

Re: [dpdk-dev] [PATCH v4 5/5] doc: add ZLIB PMD guide

2018-07-23 Thread De Lara Guarch, Pablo
Hi Shally, > -Original Message- > From: Verma, Shally [mailto:shally.ve...@cavium.com] > Sent: Monday, July 23, 2018 7:00 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; Athreya, Narayana Prasad > ; Challa, Mahipal > ; Sahu, Sunila ; > Gupta, Ashish > Subject: RE: [dpdk-dev] [PATCH v4

[dpdk-dev] [pull-request] next-net 18.08 RC2

2018-07-23 Thread Ferruh Yigit
The following changes since commit 711f43ba568acadf6cbccb9f8a29abf0fb3baa25: examples/vm_power: make branch ratio configurable (2018-07-21 00:00:43 +0200) are available in the Git repository at: http://dpdk.org/git/next/dpdk-next-net for you to fetch changes up to 2056d7a3d0de0548b0926231e

Re: [dpdk-dev] [PATCH v2 1/6] net/mlx5: lay groundwork for switch offloads

2018-07-23 Thread Ferruh Yigit
On 7/13/2018 10:40 AM, Adrien Mazarguil wrote: > With mlx5, unlike normal flow rules implemented through Verbs for traffic > emitted and received by the application, those targeting different logical > ports of the device (VF representors for instance) are offloaded at the > switch level and must b

Re: [dpdk-dev] [PATCH v4 1/5] compress/zlib: add ZLIB PMD

2018-07-23 Thread De Lara Guarch, Pablo
> -Original Message- > From: Shally Verma [mailto:shally.ve...@caviumnetworks.com] > Sent: Monday, July 23, 2018 3:51 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; pathr...@caviumnetworks.com; > mcha...@caviumnetworks.com; Ashish Gupta > ; Sunila Sahu > > Subject: [PATCH v4 1/5] c

Re: [dpdk-dev] [PATCH v4 2/5] compress/zlib: add device PMD ops

2018-07-23 Thread De Lara Guarch, Pablo
> -Original Message- > From: Shally Verma [mailto:shally.ve...@caviumnetworks.com] > Sent: Monday, July 23, 2018 3:51 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; pathr...@caviumnetworks.com; > mcha...@caviumnetworks.com; Ashish Gupta > ; Sunila Sahu > > Subject: [PATCH v4 2/5] c

Re: [dpdk-dev] [PATCH v4 4/5] compress/zlib: support burst enqueue/dequeue

2018-07-23 Thread De Lara Guarch, Pablo
> -Original Message- > From: Shally Verma [mailto:shally.ve...@caviumnetworks.com] > Sent: Monday, July 23, 2018 3:51 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; pathr...@caviumnetworks.com; > mcha...@caviumnetworks.com; Sunila Sahu ; > Sunila Sahu ; Ashish Gupta > > Subject: [P

Re: [dpdk-dev] [PATCH] net/mlx5: fix tci mask filter

2018-07-23 Thread Yongseok Koh
> On Jul 23, 2018, at 12:18 AM, Nelio Laranjeiro > wrote: > > In mlx5_traffic_enable() the TCI mask for the VLAN is wrong causing the > sub flow engine to reject the rule. > > Fixes: 272733b5ebfd ("net/mlx5: use flow to enable unicast traffic") > Cc: sta...@dpdk.org > > Signed-off-by: Nelio

Re: [dpdk-dev] rte_mbuf library likely()/unlikely()

2018-07-23 Thread Wiles, Keith
> On Jul 23, 2018, at 2:09 PM, Morten Brørup wrote: > > I haven't performance tested, but they are compiler branch prediction hints > pointing out the most likely execution path, so I expect them to have a > positive effect. We really need to make sure this provides any performance improveme

Re: [dpdk-dev] [PATCH v3 4/6] compress/octeontx: add ops enq deq apis

2018-07-23 Thread De Lara Guarch, Pablo
Hi Ashish, > -Original Message- > From: Ashish Gupta [mailto:ashish.gu...@caviumnetworks.com] > Sent: Friday, July 20, 2018 8:05 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; narayanaprasad.athr...@cavium.com; > mahipal.cha...@cavium.com; Ashish Gupta > ; Shally Verma > ; Sunila Sah

Re: [dpdk-dev] [PATCH] doc: fix mlx5 dependencies

2018-07-23 Thread Yongseok Koh
> On Jul 23, 2018, at 4:50 AM, Adrien Mazarguil > wrote: > > The new dependency of mlx5 to libmnl must be reflected in documentation. > > Fixes: 4d5cce06231a ("net/mlx5: lay groundwork for switch offloads") > > Signed-off-by: Adrien Mazarguil > --- Acked-by: Yongseok Koh Thanks

Re: [dpdk-dev] [PATCH v2 1/6] net/mlx5: lay groundwork for switch offloads

2018-07-23 Thread Stephen Hemminger
On Mon, 23 Jul 2018 22:40:47 +0100 Ferruh Yigit wrote: > On 7/13/2018 10:40 AM, Adrien Mazarguil wrote: > > With mlx5, unlike normal flow rules implemented through Verbs for traffic > > emitted and received by the application, those targeting different logical > > ports of the device (VF represen

[dpdk-dev] [PATCH] net/ixgbe: remove hardcoded CRC STRIP config from ixgbe

2018-07-23 Thread Wei Zhao
There is CRC related ifdefs for ixgbe: CONFIG_RTE_LIBRTE_IXGBE_PF_DISABLE_STRIP_CRC=n It is used in VF drivers ixgbevf_dev_configure() functions. VF cannot change the CRC strip behavior and based on what PF configured it needs to response proper to user ixgbevf_dev_configure() request. Right now wh

[dpdk-dev] [PATCH] app/testpmd: fix commands to config some offload

2018-07-23 Thread Wei Dai
Without this patch, testpmd command to config Rx offload keep_crc would fail and report "Bad argument". This patch aslo fix the command to config the Tx offload mbuf_fast_free. Fixes: 70815c9ecadd ("ethdev: add new offload flag to keep CRC") Fixes: c73a9071877a ("app/testpmd: add commands to test

Re: [dpdk-dev] [PATCH v2 1/6] net/mlx5: lay groundwork for switch offloads

2018-07-23 Thread Shahaf Shuler
Stephen, Tuesday, July 24, 2018 3:51 AM, Stephen Hemminger: > Subject: Re: [dpdk-dev] [PATCH v2 1/6] net/mlx5: lay groundwork for switch > offloads > > On Mon, 23 Jul 2018 22:40:47 +0100 > Ferruh Yigit wrote: > > > > Just to highlight this new PMD level dependency to libmnl. > > > > tap pmd also

[dpdk-dev] [PATCH] net/tap: add probe finish call for tun secondary

2018-07-23 Thread Vipin Varghese
Invoke rte_eth_dev_probing_finish for rte_pmd_tun_probe. Signed-off-by: Vipin Varghese --- drivers/net/tap/rte_eth_tap.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c index 4493507..8c0c5d6 100644 --- a/drivers/net/tap/rte_eth_t

Re: [dpdk-dev] [PATCH] doc: add tested NICs in i40e guide

2018-07-23 Thread Xing, Beilei
> -Original Message- > From: Li, Xiaoyun > Sent: Monday, July 23, 2018 2:34 PM > To: Mcnamara, John ; Xing, Beilei > ; Zhang, Qi Z > Cc: dev@dpdk.org; Li, Xiaoyun > Subject: [PATCH] doc: add tested NICs in i40e guide > > Add suggested kernel driver and firmware version for i40e PMD. >

Re: [dpdk-dev] [PATCH v4 5/5] doc: add ZLIB PMD guide

2018-07-23 Thread Verma, Shally
>-Original Message- >From: De Lara Guarch, Pablo >Sent: 24 July 2018 02:49 >To: Verma, Shally >Cc: dev@dpdk.org; Athreya, Narayana Prasad >; Challa, Mahipal >; Sahu, Sunila ; Gupta, >Ashish >Subject: RE: [dpdk-dev] [PATCH v4 5/5] doc: add ZLIB PMD guide > >External Email > >Hi Shall

Re: [dpdk-dev] [PATCH] net/mlx5: fix possible endless loop when clearing flow flags

2018-07-23 Thread Ori Kam
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Yongseok Koh > Sent: Monday, July 23, 2018 9:28 PM > To: Shahaf Shuler > Cc: dev@dpdk.org; Yongseok Koh ; Nélio Laranjeiro > > Subject: [dpdk-dev] [PATCH] net/mlx5: fix possible endless loop when > clearing flo

Re: [dpdk-dev] Bypass support in the i40e PMD driver

2018-07-23 Thread Xing, Beilei
> -Original Message- > From: Yigit, Ferruh > Sent: Tuesday, July 24, 2018 4:42 AM > To: EJ Raymond ; dev@dpdk.org > Cc: Xing, Beilei ; Zhang, Qi Z ; > Zhang, Helin > Subject: Re: [dpdk-dev] Bypass support in the i40e PMD driver > > On 7/20/2018 7:39 PM, EJ Raymond wrote: > > Hi, > > > >

Re: [dpdk-dev] [PATCH] net/mlx5: fix tci mask filter

2018-07-23 Thread Ori Kam
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Nelio Laranjeiro > Sent: Monday, July 23, 2018 10:19 AM > To: dev@dpdk.org; Yongseok Koh ; Shahaf Shuler > > Cc: sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix tci mask filter > > In mlx5_traffic_e

Re: [dpdk-dev] [PATCH] doc: add tested NICs in i40e guide

2018-07-23 Thread Li, Xiaoyun
> -Original Message- > From: Xing, Beilei > Sent: Tuesday, July 24, 2018 13:27 > To: Li, Xiaoyun ; Mcnamara, John > ; Zhang, Qi Z > Cc: dev@dpdk.org > Subject: RE: [PATCH] doc: add tested NICs in i40e guide > > > > > -Original Message- > > From: Li, Xiaoyun > > Sent: Monday, J

[dpdk-dev] [PATCH] net/mlx5: fix route Netlink message overflow

2018-07-23 Thread Nelio Laranjeiro
Route Netlink message socket is wrongly initialised by registering to the route link group. This causes the socket to receive all link message related to routes whereas the PMD do not expect to receive such information. In some situation it ends by filling the socket at a point that any new messa

[dpdk-dev] [PATCH v2] doc: add recommended matching list in i40e guide

2018-07-23 Thread Xiaoyun Li
Add suggested kernel driver and firmware version for i40e PMD. Signed-off-by: Xiaoyun Li --- doc/guides/nics/i40e.rst | 29 + 1 file changed, 29 insertions(+) --- v2: * Polish the title and section name diff --git a/doc/guides/nics/i40e.rst b/doc/guides/nics/i40e.rs

Re: [dpdk-dev] [PATCH] net/mlx5: fix possible endless loop when clearing flow flags

2018-07-23 Thread Nélio Laranjeiro
On Mon, Jul 23, 2018 at 11:27:44AM -0700, Yongseok Koh wrote: > If one of (*priv->rxqs)[] is null, the for loop can iterate infinitely as > idx can't be increased. > > Fixes: cd24d526395e ("net/mlx5: add mark/flag flow action") > Cc: Nelio Laranjeiro > > Signed-off-by: Yongseok Koh > --- > dri