[PATCH] D123538: [symbolizer] Parse DW_TAG_variable DIs to show line info for globals

jhenderson added a comment. Okay, nothing else from me, but @dblaikie or another debuginfo person should review it too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123538/new/ https://reviews.llvm.org/D123538 ___

[PATCH] D124341: [clang-tidy][NFC] Replace many instances of std::string where a StringRef would suffice.

uabelho added a comment. In D124341#3504427 , @njames93 wrote: > In D124341#3502659 , @uabelho wrote: > >> Hi, >> >> I noticed that this patch isn't NFC. > > Whoops, good catch. I left in some debugging code, fixe

[PATCH] D124730: [RISCV][NFC] Refactor RISC-V vector intrinsic utils.

khchen added a comment. Herald added a subscriber: shiva0217. Thanks for refactoring! Comment at: clang/include/clang/Support/RISCVVIntrinsicUtils.h:55 +// basic vector type, used to compute type info of arguments. +enum class PrimitiveType : uint8_t { + Invalid, -

[PATCH] D124977: [NFC][Clang] Modify expect of fail test or XFAIL because CSKY align is different

zixuan-wu added inline comments. Comment at: clang/test/Sema/builtin-alloca-with-align.c:32 void test8(void) { +#if defined(__csky__) __builtin_alloca_with_align(sizeof(__INT64_TYPE__), __alignof__(__INT64_TYPE__)); // expected-warning {{second argument to __builtin_alloca_

[PATCH] D124977: [NFC][Clang] Modify expect of fail test or XFAIL because CSKY align is different

zixuan-wu updated this revision to Diff 428585. zixuan-wu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124977/new/ https://reviews.llvm.org/D124977 Files: clang/test/CodeGen/c-strings.c clang/test/Sema/builtin-alloca-with-align.c Index: clang/t

[PATCH] D125360: [analyzer] Add taint to the BoolAssignmentChecker

gamesh411 created this revision. gamesh411 added a reviewer: steakhal. Herald added subscribers: manas, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project: All. gamesh4

[PATCH] D125362: [NFC][analyzer] Transitive interestingness in BugReporter

gamesh411 created this revision. gamesh411 added a reviewer: steakhal. Herald added subscribers: manas, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project: All. gamesh4

[PATCH] D125365: [NFC][analyzer] Pass down a State and a Pred ExplodedNode in the MallocChecker

gamesh411 created this revision. gamesh411 added a reviewer: steakhal. Herald added subscribers: manas, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project: All. gamesh4

[PATCH] D124658: [analyzer] Canonicalize SymIntExpr so the RHS is positive when possible

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. Everything passed this time. Thanks for the patience. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124658/new/ https://reviews.llvm.org/D124658 _

[PATCH] D125318: [analyzer] Add UnarySymExpr

martong marked 9 inline comments as done. martong added a comment. Thanks for the review guys! > It feels like `SymbolCast` is a `UnarySymExpr`, but I like to have a distinct > entity for this. Yes, their implementation is similar, but there are subtle differences. > Anyway. There are a lot mo

[PATCH] D125318: [analyzer] Add UnarySymExpr

martong updated this revision to Diff 428601. martong marked 6 inline comments as done. martong added a comment. - Handle UnarySymExpr in SValExplainer - Handle UnarySymExpr in SymbolExpressor - Handle UnarySymExpr in SimpleSvalBuilder's Simplifier - Better assertions - Handle UO_Not Repository:

[PATCH] D125258: [docs][pp-trace] Remove FileNotFound callback

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125258/new/ https://reviews.llvm.org/D125258 __

[PATCH] D123896: [clang-format] fix nested angle brackets parse inside concept definition

curdeius added a comment. Do you need help landing this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123896/new/ https://reviews.llvm.org/D123896 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D123896: [clang-format] fix nested angle brackets parse inside concept definition

predelnik added a comment. Probably, yes. I didn't know I have to do it myself, sorry. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123896/new/ https://reviews.llvm.org/D123896 ___ cfe-commits mailing l

[PATCH] D123896: [clang-format] fix nested angle brackets parse inside concept definition

predelnik added a comment. Ok I've found it on a guide here at last https://llvm.org/docs/MyFirstTypoFix.html Please land a patch for me, @curdeius, my author data is “Sergey Semushin predel...@gmail.com” Thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[clang-tools-extra] ba7b6f4 - [docs][pp-trace] Remove FileNotFound callback

Author: CHIANG, YU-HSUN (Tommy Chiang, oToToT) Date: 2022-05-11T18:14:25+08:00 New Revision: ba7b6f46b37b1926552e96bd102b995f6d36de04 URL: https://github.com/llvm/llvm-project/commit/ba7b6f46b37b1926552e96bd102b995f6d36de04 DIFF: https://github.com/llvm/llvm-project/commit/ba7b6f46b37b1926552e9

[PATCH] D125258: [docs][pp-trace] Remove FileNotFound callback

This revision was automatically updated to reflect the committed changes. Closed by commit rGba7b6f46b37b: [docs][pp-trace] Remove FileNotFound callback (authored by oToToT). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125258/new/ https://reviews.

[clang] 786c721 - Add extension diagnostic for linemarker directives

Author: Ken Matsui Date: 2022-05-11T06:42:00-04:00 New Revision: 786c721c2bbd2e0646e314671e010859550423bf URL: https://github.com/llvm/llvm-project/commit/786c721c2bbd2e0646e314671e010859550423bf DIFF: https://github.com/llvm/llvm-project/commit/786c721c2bbd2e0646e314671e010859550423bf.diff LO

[PATCH] D124534: [clang] Add a diagnostic for line directive of a gnu extension

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG786c721c2bbd: Add extension diagnostic for linemarker directives (authored by ken-matsui, committed by aaron.ballman). Changed prior to commit: ht

[PATCH] D124534: [clang] Add a diagnostic for line directive of a gnu extension

aaron.ballman added a comment. In D124534#3504641 , @ken-matsui wrote: > In D124534#3504610 , @aaron.ballman > wrote: > >> LGTM, thank you for all the hard work on this! I assume you need me to land >> this on

[PATCH] D125340: [clang][NFC][AST] rename the ImportError to ASTImportError

martong added a comment. What are the benefits of this renaming? I mean is there a name clash? Do we have another kind of "import" in Clang or in some of the dependent projects, don't we? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125340/new/

[clang] c7ba568 - Fix test; we now expect a pedantic warning

Author: Aaron Ballman Date: 2022-05-11T06:52:21-04:00 New Revision: c7ba568f40b2d6cbae781223529f63063785b0cf URL: https://github.com/llvm/llvm-project/commit/c7ba568f40b2d6cbae781223529f63063785b0cf DIFF: https://github.com/llvm/llvm-project/commit/c7ba568f40b2d6cbae781223529f63063785b0cf.diff

[PATCH] D124750: [MLIR] Add a utility to sort the operands of commutative ops

Mogball added a comment. I'm open to iterating in tree. Landing this utility first and then try adding it as a canonicalization SGTM. The string could be replaced with an array of tuples (yuck) for now. An enum (constant, block arg, everything else) plus the OperationName. Attributes need to b

[PATCH] D124534: [clang] Add a diagnostic for line directive of a gnu extension

aaron.ballman added a comment. In D124534#3505709 , @aaron.ballman wrote: > In D124534#3504641 , @ken-matsui > wrote: > >> (I use this info for every commit on GitHub, but is this what you expected? >> Please l

[PATCH] D124534: [clang] Add a diagnostic for line directive of a gnu extension

ken-matsui added a comment. > That looks to be exactly what I needed, but you can double-check that you > were properly attributed here: > https://github.com/llvm/llvm-project/commit/786c721c2bbd2e0646e314671e010859550423bf > I added one when I landed. I also adjusted the commit message slight

[PATCH] D125142: [clang][auto-init] Remove -enable flag for "zero" mode

jfb added a subscriber: Florian. jfb added a comment. I think the most relevant post from @rsmith is: https://discourse.llvm.org/t/making-ftrivial-auto-var-init-zero-a-first-class-option/55143/40 He has a prototype: https://reviews.llvm.org/D79249 I assume he would like someone to pursue it furt

[PATCH] D124702: [MSVC] Add support for pragma function

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaAttr.cpp:1070 +SourceLocation Loc, const llvm::SmallVectorImpl &NoBuiltins) { + if (!CurContext->getRedeclContext()->isFileContext()) { +Diag(Loc, diag::err_pragma_intrinsic_function_scope) << "function"

[PATCH] D125373: [pp-trace] Print HashLoc in InclusionDirective callback

oToToT created this revision. oToToT added reviewers: jtsoftware, klimek. Herald added subscribers: kbarton, nemanjai. Herald added a project: All. oToToT requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. The HashLoc in InclusionD

[PATCH] D125243: [OpenCL] Make -cl-ext a driver option

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. LGTM; just a few minor suggestions that you can address at commit time. Comment at: clang/docs/UsersManual.rst:3145-3146 + +Note that some targets e.g. SPIR/SPIR-V enable all

[clang] 0035f71 - [CUDA] Create offloading entries when using the new driver

Author: Joseph Huber Date: 2022-05-11T07:30:21-04:00 New Revision: 0035f7154c2a80c58aea6c6dfcac548050e4c5e0 URL: https://github.com/llvm/llvm-project/commit/0035f7154c2a80c58aea6c6dfcac548050e4c5e0 DIFF: https://github.com/llvm/llvm-project/commit/0035f7154c2a80c58aea6c6dfcac548050e4c5e0.diff

[clang] e7858a9 - [Cuda] Add initial support for wrapping CUDA images in the new driver.

Author: Joseph Huber Date: 2022-05-11T07:30:23-04:00 New Revision: e7858a9fab8c11a44868ad4e0572c6c7618b219a URL: https://github.com/llvm/llvm-project/commit/e7858a9fab8c11a44868ad4e0572c6c7618b219a DIFF: https://github.com/llvm/llvm-project/commit/e7858a9fab8c11a44868ad4e0572c6c7618b219a.diff

[clang] f49d576 - [CUDA] Add wrapper code generation for registering CUDA images

Author: Joseph Huber Date: 2022-05-11T07:30:25-04:00 New Revision: f49d576a882da81292b5730af442fa38899af312 URL: https://github.com/llvm/llvm-project/commit/f49d576a882da81292b5730af442fa38899af312 DIFF: https://github.com/llvm/llvm-project/commit/f49d576a882da81292b5730af442fa38899af312.diff

[PATCH] D123471: [CUDA] Create offloading entries when using the new driver

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0035f7154c2a: [CUDA] Create offloading entries when using the new driver (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D123810: [Cuda] Add initial support for wrapping CUDA images in the new driver.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe7858a9fab8c: [Cuda] Add initial support for wrapping CUDA images in the new driver. (authored by jhuber6). Repository: rG LLVM Github Monorepo C

[PATCH] D123812: [CUDA] Add wrapper code generation for registering CUDA images

This revision was automatically updated to reflect the committed changes. Closed by commit rGf49d576a882d: [CUDA] Add wrapper code generation for registering CUDA images (authored by jhuber6). Changed prior to commit: https://reviews.llvm.org/D123812?vs=426467&id=428622#toc Repository: rG LL

[PATCH] D125011: [MSVC] Add support for pragma alloc_text

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:1136-1137 "expected non-wide string literal in '#pragma %0'">, InGroup; +def warn_pragma_expected_ascii_string : Warning< + "expected ascii string literal in '#pragma %0'">, InG

[PATCH] D125338: [HLSL] add -D option for dxc mode.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a testing suggestion. Comment at: clang/test/Driver/dxc_D.hlsl:5 +// CHECK:"-D" "TEST=2" + Maybe we should also test that the m

[PATCH] D125178: Warn if using `elifdef` & `elifndef` in not C2x & C++2b mode

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:698 +def warn_c2x_compat_pp_directive : Warning< + "use of a '#%select{elifdef|elifndef}0' directive is incompatible with C standards before C2x">, + InGroup, DefaultIgnore; --

[PATCH] D124726: Suggest typoed directives in preprocessor conditionals

aaron.ballman added inline comments. Comment at: clang/test/Preprocessor/suggest-typoed-directive.c:10 +// expected-warning@+11 {{'#elfidef' directive not found, did you mean '#elifdef'?}} +// expected-warning@+11 {{'#elfindef' directive not found, did you mean '#elifdef'?}} +/

[clang] dab5e10 - [clang-format] fix nested angle brackets parse inside concept definition

Author: Sergey Semushin Date: 2022-05-11T14:02:51+02:00 New Revision: dab5e10ea5dbc2e6314e0e7ce54a9c51fbcb44bd URL: https://github.com/llvm/llvm-project/commit/dab5e10ea5dbc2e6314e0e7ce54a9c51fbcb44bd DIFF: https://github.com/llvm/llvm-project/commit/dab5e10ea5dbc2e6314e0e7ce54a9c51fbcb44bd.dif

[PATCH] D123896: [clang-format] fix nested angle brackets parse inside concept definition

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdab5e10ea5db: [clang-format] fix nested angle brackets parse inside concept definition (authored by predelnik, committed by curdeius). Repository:

[PATCH] D125378: [Attribute] Introduce shuffle attribute to be used for __shfl_sync like cross-lane APIs

skc7 created this revision. Herald added subscribers: jdoerfert, hiraditya. Herald added a reviewer: aaron.ballman. Herald added a project: All. skc7 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This change introduces s

[clang] 06a9832 - [ASTMatchers][NFC] Fix name of matcher in docs and add a missing test

Author: Whisperity Date: 2022-05-11T14:15:53+02:00 New Revision: 06a98328fc7b70756782fafff5ebfbec815cf1f5 URL: https://github.com/llvm/llvm-project/commit/06a98328fc7b70756782fafff5ebfbec815cf1f5 DIFF: https://github.com/llvm/llvm-project/commit/06a98328fc7b70756782fafff5ebfbec815cf1f5.diff LO

[PATCH] D125379: [analyzer][solver] Do not negate unsigned ranges

martong created this revision. martong added reviewers: NoQ, steakhal. Herald added subscribers: manas, ASDenysPetrov, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project:

[PATCH] D125006: [pseudo] Support parsing variant target symbols.

hokein updated this revision to Diff 428634. hokein added a comment. add a comment in cxx.bnf explaining why not making all nonterminals as start symbol by default. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125006/new/ https://reviews.llvm.org

[PATCH] D125006: [pseudo] Support parsing variant target symbols.

hokein added a comment. > Would including *every* nonterminal as a start symbol would blow the size up > a bit? > This would eliminate some complexity in the interface. This does increase the size, some datapoints: - ~240 start symbols - number of states: 1.4K -> 2K - number of actions: 83K ->

[PATCH] D125379: [analyzer][solver] Do not negate unsigned ranges

steakhal added a comment. Seems reasonable. Comment at: clang/test/Analysis/constraint_manager_negate_difference.c:145-148 +// FIXME only the TRUE case should appear. But it is better to be +// conservative than faulty. +clang_analyzer_eval(n - m == 1); // expected-

[PATCH] D125318: [analyzer] Add UnarySymExpr

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp:107 +return makeNonLoc(X.castAs().getSymbol(), UO_Not, + X.getType(Context)); default: I'm not sure if we should rely on `SVal::getType()`.

[PATCH] D125378: [Attribute] Introduce shuffle attribute to be used for __shfl_sync like cross-lane APIs

skc7 updated this revision to Diff 428635. skc7 added a comment. clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125378/new/ https://reviews.llvm.org/D125378 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDocs.td clang/lib/CodeGen/CGCall.cpp c

[PATCH] D125178: Warn if using `elifdef` & `elifndef` in not C2x & C++2b mode

ken-matsui updated this revision to Diff 428636. ken-matsui added a comment. Update the code as reviewed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125178/new/ https://reviews.llvm.org/D125178 Files: clang/include/clang/Basic/DiagnosticLexKin

[PATCH] D125178: Warn if using `elifdef` & `elifndef` in not C2x & C++2b mode

ken-matsui added a comment. Thank you for your review! I updated the code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125178/new/ https://reviews.llvm.org/D125178 ___ cfe-commits mailing list cfe-comm

[PATCH] D125360: [analyzer] Add taint to the BoolAssignmentChecker

steakhal added a comment. It turns out this only makes sense for `Obj-C` code :D Anyway, it looks good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125360/new/ https://reviews.llvm.org/D125360 ___ cfe-

[PATCH] D125378: [Attribute] Introduce shuffle attribute to be used for __shfl_sync like cross-lane APIs

skc7 updated this revision to Diff 428637. skc7 added a comment. rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125378/new/ https://reviews.llvm.org/D125378 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDocs.td clang/lib/CodeGen/CGCall.cpp clang/l

[PATCH] D125362: [NFC][analyzer] Transitive interestingness in BugReporter

steakhal added a comment. I think since it changes how taint spreads, this patch deserves a test. Could you please demonstrate the correctness of this patch? Comment at: clang/lib/StaticAnalyzer/Core/BugReporter.cpp:2267 + for (SymbolRef SubSym : SubSyms) { +if (SymbolData

[PATCH] D125365: [NFC][analyzer] Pass down a State and a Pred ExplodedNode in the MallocChecker

steakhal added a comment. Also mention in the summary that we are doing this because we want to do multiple transitions with different NoteTags at different handlers there. For E.g. we want to put NoteTags when we do a taint propagation. That being said, now we model the extent of the allocated

[PATCH] D124874: [clang] add -fmodule-file-home-is-cwd

urnathan accepted this revision. urnathan added a comment. This revision is now accepted and ready to land. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124874/new/ https://reviews.llvm.org/D124874

[PATCH] D124534: [clang] Add a diagnostic for line directive of a gnu extension

Jake-Egan added a comment. Hi, this patch causes a test failure on AIX https://lab.llvm.org/buildbot/#/builders/214/builds/1221/steps/6/logs/FAIL__Clang__noinline_cu Could you please make a fix or revert if it takes too long? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D125378: [Attribute] Introduce shuffle attribute to be used for __shfl_sync like cross-lane APIs

nikic requested changes to this revision. nikic added a comment. This revision now requires changes to proceed. Please specify the semantics of the new LLVM attribute in LangRef -- though I don't really understand why you need an LLVM-side attribute at all. CHANGES SINCE LAST ACTION https://r

[PATCH] D124534: [clang] Add a diagnostic for line directive of a gnu extension

ken-matsui added a comment. Hello @Jake-Egan, I believe the problem was already fixed by the @aaron.ballman's patch here . Thank you for fixing it, @aaron.ballman! Repository: rG LLVM Github Monorepo CHAN

[PATCH] D125383: [ASTMatchers][clang-tidy][NFC] Hoist 'forEachTemplateArgument' matcher into the core library

whisperity created this revision. whisperity added reviewers: aaron.ballman, klimek, hokein, njames93. whisperity added projects: clang, clang-tools-extra. Herald added subscribers: carlosgalvezp, gamesh411, Szelethus, dkrupp, rnkovacs, xazax.hun. Herald added a project: All. whisperity requested

[clang] 75bb815 - [AArch64][SVE] Add aarch64_sve_pcs attribute to Clang

Author: Matt Devereau Date: 2022-05-11T13:33:56Z New Revision: 75bb815231f6967bd5f4e24143141b9fe69d01f8 URL: https://github.com/llvm/llvm-project/commit/75bb815231f6967bd5f4e24143141b9fe69d01f8 DIFF: https://github.com/llvm/llvm-project/commit/75bb815231f6967bd5f4e24143141b9fe69d01f8.diff LOG:

[PATCH] D124998: [AArch64][SVE] Add aarch64_sve_pcs attribute to Clang

This revision was automatically updated to reflect the committed changes. Closed by commit rG75bb815231f6: [AArch64][SVE] Add aarch64_sve_pcs attribute to Clang (authored by MattDevereau). Changed prior to commit: https://reviews.llvm.org/D124998?vs=427335&id=428644#toc Repository: rG LLVM G

[PATCH] D125378: [Attribute] Introduce shuffle attribute to be used for __shfl_sync like cross-lane APIs

cdevadas added inline comments. Comment at: clang/test/CodeGenHIP/shuffle-attr-verify.hip:34 +// CHECK-DAG: attributes #[[attr1]] = { {{[^}]*}}shuffle{{[^}]*}} } \ No newline at end of file Add a new line. Comment at: clang/test/CodeGenHIP/shu

[clang] 26eb042 - [Clang] Introduce clang-offload-packager tool to bundle device files

Author: Joseph Huber Date: 2022-05-11T09:39:13-04:00 New Revision: 26eb04268f4c9c0e2d4ff5bc53ae90cbb7f6c731 URL: https://github.com/llvm/llvm-project/commit/26eb04268f4c9c0e2d4ff5bc53ae90cbb7f6c731 DIFF: https://github.com/llvm/llvm-project/commit/26eb04268f4c9c0e2d4ff5bc53ae90cbb7f6c731.diff

[PATCH] D125165: [Clang] Introduce clang-offload-packager tool to bundle device files

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG26eb04268f4c: [Clang] Introduce clang-offload-packager tool to bundle device files (authored by jhuber6). Herald added a subscriber: kosarev. Change

[PATCH] D124446: [clang-tidy] Add the misc-discarded-return-value check

whisperity added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/DiscardedReturnValueCheck.cpp:96-99 +AST_MATCHER_P(StaticAssertDecl, hasAssertExpr, + ast_matchers::internal::Matcher, InnerMatcher) { + return InnerMatcher.matches(*Node.getAssertExpr(

[PATCH] D125386: [clang][ppc] Creating Seperate Install Target for PPC htm Headers

qiongsiwu1 created this revision. qiongsiwu1 added reviewers: jsji, rzurob. qiongsiwu1 added projects: clang, PowerPC. Herald added subscribers: shchenz, mgorny. Herald added a project: All. qiongsiwu1 requested review of this revision. Herald added a subscriber: cfe-commits. This patch splits out

[PATCH] D125011: [MSVC] Add support for pragma alloc_text

steplong added inline comments. Comment at: clang/test/Sema/pragma-ms-alloc-text.cpp:5 +#pragma alloc_text(a// expected-warning {{expected ',' in '#pragma alloc_text'}} +#pragma alloc_text(a, a // expected-warning {{missing ')' after '#pragma alloc_text'}} expected-

[PATCH] D124726: Suggest typoed directives in preprocessor conditionals

ken-matsui added inline comments. Comment at: clang/test/Preprocessor/suggest-typoed-directive.c:10 +// expected-warning@+11 {{'#elfidef' directive not found, did you mean '#elifdef'?}} +// expected-warning@+11 {{'#elfindef' directive not found, did you mean '#elifdef'?}} +// e

[PATCH] D125386: [clang][ppc] Creating Seperate Install Target for PPC htm Headers

jsji accepted this revision. jsji added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125386/new/ https://reviews.llvm.org/D125386 ___ cfe

[PATCH] D125340: [clang][NFC][AST] rename the ImportError to ASTImportError

phyBrackets added a comment. In D125340#3505723 , @martong wrote: > What are the benefits of this renaming? I mean is there a name clash? Do we > have another kind of "import" in Clang or in some of the dependent projects, > don't we? AS it suggested b

[PATCH] D124256: [OpenCL] Add cl_khr_subgroup_rotate builtins

svenvh updated this revision to Diff 428652. svenvh added a comment. Added macro and macro test. Added reference to Extension spec section. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124256/new/ https://reviews.llvm.org/D124256 Files: clang/lib/Headers/opencl-c-base.h clang/lib

[PATCH] D124256: [OpenCL] Add cl_khr_subgroup_rotate builtins

svenvh added a comment. In D124256#3474043 , @Anastasia wrote: > LGTM! I imagine tablegen side is being tested automatically? The TableGen definitions are tested by `clang/test/Headers/opencl-builtins.cl` > Btw do we need to set the feature macro for SP

[PATCH] D125165: [Clang] Introduce clang-offload-packager tool to bundle device files

thakis added a comment. We now have clang-offload-bundler, clang-offload-packager, clang-offload-wrapper. Do we really need that many distinct binaries for offloading? Any chance we could combine some of those? Comment at: clang/test/Driver/linker-wrapper.c:5 -// RUN: %clan

[PATCH] D125165: [Clang] Introduce clang-offload-packager tool to bundle device files

thakis added inline comments. Comment at: clang/test/Driver/linker-wrapper.c:5 -// RUN: %clang -cc1 %s -triple x86_64-unknown-linux-gnu -emit-obj -o %t.o \ -// RUN: -fembed-offload-object=%S/Inputs/dummy-elf.o,openmp,nvptx64-nvida-cuda,sm_70 \ -// RUN: -fembed-offload-obj

[PATCH] D125165: [Clang] Introduce clang-offload-packager tool to bundle device files

jhuber6 added a comment. In D125165#3506172 , @thakis wrote: > We now have clang-offload-bundler, clang-offload-packager, > clang-offload-wrapper. Do we really need that many distinct binaries for > offloading? Any chance we could combine some of those?

[PATCH] D125340: [clang][NFC][AST] rename the ImportError to ASTImportError

balazske added a comment. Initially the `ImportError` was very related to `ASTImporter` but now the class is used at other less related places and files. `ImportError` is a too generic name for this unless it can be used at any other "import" in clang which is not the case (the class can be ext

[libunwind] c631e33 - [runtimes] Print the testing configuration in use in libunwind and libc++abi

Author: Louis Dionne Date: 2022-05-11T10:18:09-04:00 New Revision: c631e33f316d891b39c1e01217a7422fdc29ced1 URL: https://github.com/llvm/llvm-project/commit/c631e33f316d891b39c1e01217a7422fdc29ced1 DIFF: https://github.com/llvm/llvm-project/commit/c631e33f316d891b39c1e01217a7422fdc29ced1.diff

[PATCH] D125195: [asan][ARMCXXABI] Added missing asan poison array cookie hooks.

rsundahl marked an inline comment as not done. rsundahl added inline comments. Comment at: compiler-rt/test/asan/TestCases/Posix/new_array_cookie_test.cpp:19 C *buffer = new C[argc]; - buffer[-2].x = 10; + buffer[-1].x = 10; // CHECK: AddressSanitizer: heap-buffer-overflow

[PATCH] D124702: [MSVC] Add support for pragma function

steplong updated this revision to Diff 428657. steplong added a comment. - Renamed `AddRangeBasedNoBuiltin` to `AddImplicitMSFunctionNoBuiltinAttr` - Renamed `err_pragma_intrinsic_function_scope` to `err_pragma_expected_file_scope` - Added comment about MSVC accepting struct test - Removed `->get

[PATCH] D120727: [libc++] Overhaul how we select the ABI library

ldionne updated this revision to Diff 428658. ldionne marked 2 inline comments as done. ldionne added a comment. Rebase and address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120727/new/ https://reviews.llvm.org/D120727 Files:

[PATCH] D120727: [libc++] Overhaul how we select the ABI library

ldionne added inline comments. Comment at: libcxxabi/CMakeLists.txt:201 endif() +message(STATUS "Using libc++abi testing configuration: ${LIBCXXABI_TEST_CONFIG}") set(LIBCXXABI_TEST_PARAMS "" CACHE STRING mstorsjo wrote: > Unrelated to the rest of the patch? I

[PATCH] D125340: [clang][NFC][AST] rename the ImportError to ASTImportError

balazske added a comment. I found one other place in **LibASTImporter.rst** where `ImportError` is used. LLDB should be checked too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125340/new/ https://reviews.llvm.org/D125340 __

[PATCH] D124996: [clang][preprocessor] Fix unsigned-ness of utf8 char literals

tahonermann added inline comments. Comment at: clang/test/Lexer/utf8-char-literal.cpp:54-56 +# if !(u8'\xff' == 0xff) +#error u8 char literal is not unsigned +# endif tbaeder wrote: > tahonermann wrote: > > The C++ case looks good now, but the condition doe

[PATCH] D125378: [Attribute] Introduce shuffle attribute to be used for __shfl_sync like cross-lane APIs

jdoerfert requested changes to this revision. jdoerfert added a comment. In D125378#3506001 , @nikic wrote: > Please specify the semantics of the new LLVM attribute in LangRef -- though I > don't really understand why you need an LLVM-side attribute at a

[PATCH] D124946: [clang] serialize ORIGINAL_PCH_DIR relative to BaseDirectory

rmaz added a comment. In D124946#3500454 , @urnathan wrote: > Looks good to me, but perhaps leave it a few days for others to comment (my > familiarity with this code is low). I do know people want relocatable > outputs though. Are we good to go with

[PATCH] D124866: [CUDA][HIP] support __noinline__ as keyword

yaxunl added inline comments. Comment at: clang/lib/Basic/IdentifierTable.cpp:111 KEYSYCL = 0x100, +KEYCUDA = 0x200, KEYALLCXX = KEYCXX | KEYCXX11 | KEYCXX20, delcypher wrote: > yaxunl wrote: > > delcypher wrote: > > > @yaxunl Is

[PATCH] D125379: [analyzer][solver] Do not negate unsigned ranges

martong abandoned this revision. martong added inline comments. Comment at: clang/test/Analysis/constraint_manager_negate_difference.c:125-130 void negate_unsigned_mid(unsigned m, unsigned n) { if (m - n == UINT_MID) { -clang_analyzer_eval(n - m == UINT_MID); // expected-

[PATCH] D125378: [Attribute] Introduce shuffle attribute to be used for __shfl_sync like cross-lane APIs

skc7 added a comment. In D125378#3506215 , @jdoerfert wrote: > In D125378#3506001 , @nikic wrote: > >> Please specify the semantics of the new LLVM attribute in LangRef -- though >> I don't really understand why

[PATCH] D125323: [RISCV] Add the passthru operand for RVV unmasked segment load IR intrinsics.

khchen updated this revision to Diff 428674. khchen added a comment. address Craig's comments, thanks!! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125323/new/ https://reviews.llvm.org/D125323 Files: clang/include/clang/Basic/riscv_vector.td

[PATCH] D124702: [MSVC] Add support for pragma function

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Thanks for all the hard work on this, LGTM! Can you please add a release note to clang/docs/ReleaseNotes.rst for the new functionality (probably best under the `New Pragmas in Cl

[PATCH] D125378: [Attribute] Introduce shuffle attribute to be used for __shfl_sync like cross-lane APIs

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:1323-1344 +def ShuffleDocs : Documentation { + let Category = DocCatFunction; + let Content = [{ +The ``shuffle`` attribute can be placed on a function declaration. It indicates +that the cal

[PATCH] D125395: [analyzer][solver] Handle UnarySymExpr in RangeConstraintSolver

martong created this revision. martong added reviewers: steakhal, NoQ. Herald added subscribers: manas, ASDenysPetrov, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project:

[PATCH] D125378: [Attribute] Introduce shuffle attribute to be used for __shfl_sync like cross-lane APIs

jdoerfert added a comment. In D125378#3506383 , @skc7 wrote: > In D125378#3506215 , @jdoerfert > wrote: > >> In D125378#3506001 , @nikic wrote: >> >>> Please specify the

[PATCH] D125165: [Clang] Introduce clang-offload-packager tool to bundle device files

thakis added a comment. We could add a "clang-offload-bundler and clang-offload-wrapper are deprecated, replace them with $whatever" in the release notes and then remove them a release later, assuming the replacement is straightforward. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D125396: [clang] Fix KEYALL

yaxunl created this revision. yaxunl added reviewers: delcypher, aaron.ballman, tra, rsmith. Herald added a project: All. yaxunl requested review of this revision. Introduce KEYMAX and a generic way to update KEYALL. https://reviews.llvm.org/D125396 Files: clang/lib/Basic/IdentifierTable.cpp

[PATCH] D124866: [CUDA][HIP] support __noinline__ as keyword

yaxunl marked 2 inline comments as done. yaxunl added inline comments. Comment at: clang/lib/Basic/IdentifierTable.cpp:111 KEYSYCL = 0x100, +KEYCUDA = 0x200, KEYALLCXX = KEYCXX | KEYCXX11 | KEYCXX20, yaxunl wrote: > delcypher wro

[PATCH] D124866: [CUDA][HIP] support __noinline__ as keyword

delcypher added inline comments. Comment at: clang/lib/Basic/IdentifierTable.cpp:111 KEYSYCL = 0x100, +KEYCUDA = 0x200, KEYALLCXX = KEYCXX | KEYCXX11 | KEYCXX20, yaxunl wrote: > yaxunl wrote: > > delcypher wrote: > > > yaxunl wro

[PATCH] D125395: [analyzer][solver] Handle UnarySymExpr in RangeConstraintSolver

martong updated this revision to Diff 428683. martong added a comment. - Add false positive test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125395/new/ https://reviews.llvm.org/D125395 Files: clang/lib/StaticAnalyzer/Core/RangeConstraintManag

[PATCH] D125395: [analyzer][solver] Handle UnarySymExpr in RangeConstraintSolver

martong added a comment. Fixes https://github.com/llvm/llvm-project/issues/55241 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125395/new/ https://reviews.llvm.org/D125395 ___ cfe-commits mailing list cf

  1   2   3   >