balazske added a comment.

Initially the `ImportError` was very related to `ASTImporter` but now the class 
is used at other less related places and files. `ImportError` is a too generic 
name for this unless it can be used at any other "import" in clang which is not 
the case (the class can be extended with other special data about the import 
error). Maybe the whole ASTImporter should go into a new namespace, specially 
if `ASTImporter.cpp` would be split into parts?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125340/new/

https://reviews.llvm.org/D125340

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to