svenvh added a comment. In D124256#3474043 <https://reviews.llvm.org/D124256#3474043>, @Anastasia wrote:
> LGTM! I imagine tablegen side is being tested automatically? The TableGen definitions are tested by `clang/test/Headers/opencl-builtins.cl` > Btw do we need to set the feature macro for SPIR/SPIR-V target and then test > it too? Good point! Added. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124256/new/ https://reviews.llvm.org/D124256 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
