[PATCH] D82314: [RFC][Coroutines] Optimize the lifespan of temporary co_await object

lxfind updated this revision to Diff 272916. lxfind added a comment. Address test failures Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82314/new/ https://reviews.llvm.org/D82314 Files: llvm/lib/Transforms/Coroutines/CoroSplit.cpp llvm/test/T

[PATCH] D81920: [clangd] Change FSProvider::getFileSystem to take CurrentWorkingDirectory

uabelho added a comment. In D81920#2109901 , @kadircet wrote: > Can you check if you see the warning with different versions of gcc? Originally I got them with 7.4.0 and now I tried with 9.3.0 and got them there as well. Repository: rG LLVM Github M

[PATCH] D82086: [AST][RecoveryExpr] Fix a crash: don't attach error-type base specifiers.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:2430 + if (BaseType->containsErrors()) { +// FIXME: should we emit a diagnostic here? We already emit a diagnostic +

[PATCH] D81285: [builtins] Change si_int to int in some helper declarations

atrosinenko added a comment. Thank you! In D81285#2110102 , @MaskRay wrote: > > This patch changes types of some integer function arguments or return > > values from si_int to the default int type (typedefed to native_int to make > > it obvious this is

[PATCH] D82436: [clangd] Implement textDocument/foldingRange

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This patch introduces basic textDocument/foldingRange support. It relies on textDocument/docu

[PATCH] D82099: [AST][RecoveryAST] Populate error-bit from Type to Expr.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/AST/DependenceFlags.h:123 + translate(D, TypeDependence::Dependent, Dependent) | + translate(D, TypeDependence::Er

[PATCH] D81869: Modify FPFeatures to use delta not absolute settings to solve PCH compatibility problems

rjmccall added a comment. Just a bunch of minor suggestions. LGTM if you get all the tests worked out and it actually works the way you want on the tests. Comment at: clang/include/clang/AST/Expr.h:2280 } + FPOptionsOverride getFPFeatures(const LangOptions &LO) const { +

[PATCH] D82385: [Analyzer] Fix errors in iterator modeling

gamesh411 added a comment. Hey! See my inline comments, but after those and a quick clang-format, it looks good. Comment at: clang/lib/StaticAnalyzer/Checkers/IteratorModeling.cpp:543 - auto NewState = + auto TmpState = advancePosition(State, LHS, Op, *value); ---

[PATCH] D79677: [Clang][OpenMP][OMPBuilder] (1/4) Privatize `parallel` for `OMPBuilder`

kiranchandramohan added a comment. Thanks @fghanim for this patch. I will get to this on Friday if you can add me as a reviewer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79677/new/ https://reviews.llvm.org/D79677 __

[PATCH] D82385: [Analyzer] Fix errors in iterator modeling

baloghadamsoftware updated this revision to Diff 272927. baloghadamsoftware added a comment. Code reformatted according to Lint Pre-Merge check suggestions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82385/new/ https://reviews.llvm.org/D82385 Files: clang/lib/StaticAnalyzer/Checke

[PATCH] D82185: [Analyzer] Handle pointer implemented as iterators in iterator checkers

gamesh411 added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/IteratorModeling.cpp:623 + + auto TempState = advancePosition(State, OldVal, OK, Offset); + const IteratorPosition *NewPos = getIteratorPosition(TempState, OldVal); Same as in the ot

[PATCH] D82314: [RFC][Coroutines] Optimize the lifespan of temporary co_await object

junparser added a comment. @lxfind, Thank you! And could you please add some testcases? Comment at: llvm/lib/Transforms/Coroutines/CoroSplit.cpp:1286 +continue; + if (CastInst) { +// If we have multiple cast instructions for the alloca, don't -

[clang] 96d4ccf - [VE] Clang toolchain for VE

Author: Kazushi (Jam) Marukawa Date: 2020-06-24T10:12:09+02:00 New Revision: 96d4ccf00c8f746aebb549288fac33dcbb15bc4b URL: https://github.com/llvm/llvm-project/commit/96d4ccf00c8f746aebb549288fac33dcbb15bc4b DIFF: https://github.com/llvm/llvm-project/commit/96d4ccf00c8f746aebb549288fac33dcbb15b

[clang] f0084c3 - [AST][RecoveryExpr] Fix a crash: don't attach error-type base specifiers.

Author: Haojian Wu Date: 2020-06-24T10:13:46+02:00 New Revision: f0084c3bcbc2f2e17ab1a24d19ac6738eb4c4263 URL: https://github.com/llvm/llvm-project/commit/f0084c3bcbc2f2e17ab1a24d19ac6738eb4c4263 DIFF: https://github.com/llvm/llvm-project/commit/f0084c3bcbc2f2e17ab1a24d19ac6738eb4c4263.diff LO

[clang] bfec030 - [AST][RecoveryExpr] Populate error-bit from Type to Expr.

Author: Haojian Wu Date: 2020-06-24T10:29:30+02:00 New Revision: bfec030e69afc73b29aa1b66902ae802a448fc19 URL: https://github.com/llvm/llvm-project/commit/bfec030e69afc73b29aa1b66902ae802a448fc19 DIFF: https://github.com/llvm/llvm-project/commit/bfec030e69afc73b29aa1b66902ae802a448fc19.diff LO

[PATCH] D82099: [AST][RecoveryAST] Populate error-bit from Type to Expr.

hokein marked 2 inline comments as done. hokein added inline comments. Comment at: clang/include/clang/AST/DependenceFlags.h:123 + translate(D, TypeDependence::Dependent, Dependent) | + translate(D, TypeDependence::Error, Error) | + translate(D, TypeDep

[PATCH] D75169: [ARM] Supporting lowering of half-precision FP arguments and returns in AArch32's backend

plotfi added a comment. @pratlucas @ostannard @rjmccall I have noticed this change break on the building of the Swift standard library in downstream apple/swift/master-next. I reduced the test case and found that the chain of bitcasts/extends in ARMTargetLowering::splitValueIntoRegisterParts e

[PATCH] D82099: [AST][RecoveryAST] Populate error-bit from Type to Expr.

This revision was automatically updated to reflect the committed changes. hokein marked an inline comment as done. Closed by commit rGbfec030e69af: [AST][RecoveryExpr] Populate error-bit from Type to Expr. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D79411: [VE] Clang toolchain for VE

This revision was automatically updated to reflect the committed changes. Closed by commit rG96d4ccf00c8f: [VE] Clang toolchain for VE (authored by kaz7, committed by simoll). Changed prior to commit: https://reviews.llvm.org/D79411?vs=272632&id=272932#toc Repository: rG LLVM Github Monorepo

[PATCH] D82086: [AST][RecoveryExpr] Fix a crash: don't attach error-type base specifiers.

This revision was automatically updated to reflect the committed changes. hokein marked an inline comment as done. Closed by commit rGf0084c3bcbc2: [AST][RecoveryExpr] Fix a crash: don't attach error-type base specifiers. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D

[PATCH] D82381: [analyzer] Introduce small improvements to the solver infra

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:467-470 +/// Available representations for the arguments are: +/// * RangeSet +/// * Optional +/// * RangeSet * Why do we have these representations in the first

[PATCH] D75169: [ARM] Supporting lowering of half-precision FP arguments and returns in AArch32's backend

plotfi added inline comments. Comment at: llvm/lib/Target/ARM/ARMISelLowering.cpp:4106 +unsigned NumParts, MVT PartVT, Optional CC) const { + bool IsABIRegCopy = CC.hasValue(); + EVT ValueVT = Val.getValueType(); I'm not well versed in arm CCs, but I suspec

[PATCH] D82425: [SemaCXX] Fix false positive of -Wuninitialized-const-reference in empty function body.

hans added a comment. Okay, since checking this is cheap I suppose we can do it. Comment at: clang/lib/Analysis/UninitializedValues.cpp:410 + if (FunctionDecl *fd = CE->getDirectCallee()) { +if (FunctionTemplateDecl *ftd = fd->getPrimaryTemplate()) + return ftd->getTe

[clang] 1b090db - [ARM] Improve diagnostics message when Neon is unsupported

Author: Victor Campos Date: 2020-06-24T10:20:26+01:00 New Revision: 1b090db0df47f3ebf6acab0316180267e6b96f43 URL: https://github.com/llvm/llvm-project/commit/1b090db0df47f3ebf6acab0316180267e6b96f43 DIFF: https://github.com/llvm/llvm-project/commit/1b090db0df47f3ebf6acab0316180267e6b96f43.diff

[clang] 3d6cab2 - [AArch64][SVE] Add bfloat16 support to load intrinsics

Author: Kerry McLaughlin Date: 2020-06-24T10:32:19+01:00 New Revision: 3d6cab271c7cecf105b77834d837ccd4406700d7 URL: https://github.com/llvm/llvm-project/commit/3d6cab271c7cecf105b77834d837ccd4406700d7 DIFF: https://github.com/llvm/llvm-project/commit/3d6cab271c7cecf105b77834d837ccd4406700d7.di

[PATCH] D82298: [AArch64][SVE] Add bfloat16 support to load intrinsics

sdesmalen accepted this revision. sdesmalen added a comment. LGTM Comment at: clang/include/clang/Basic/arm_sve.td:275 +let ArchGuard = "defined(__ARM_FEATURE_SVE_BF16)" in { + def SVLD1_BF : MInst<"svld1[_{2}]", "dPc", "b", [IsLoad], MemEltTyDefault, "aarch64_sve_

[PATCH] D82288: [analyzer][StdLibraryFunctionsChecker] Add POSIX file handling functions

gamesh411 added a comment. Good job, I really fancy the Summary syntax 👍 Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:740 // we have a TypedefDecl with the name 'FILE'. - for (Decl *D : LookupRes) { + for (Decl *D : LookupRes) if (auto

[PATCH] D75169: [ARM] Supporting lowering of half-precision FP arguments and returns in AArch32's backend

plotfi added a comment. @pratlucas @ostannard @rjmccall I've posted a diff D82443 to address what I think could be a potential fix for the assert I was seeing on the provided reduced IR. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D82213: [Remarks] Add callsite locations to inline remarks

fhahn added a comment. That's interesting. We are also using something similar for the matrix lowering remarks [1]: we traverse the inlining chain bottom up and emit a remark at each step which contains the expression available at that level. I think those approaches could be useful in general

[PATCH] D81847: [ARM] Improve diagnostics message when Neon is unsupported

This revision was automatically updated to reflect the committed changes. Closed by commit rG1b090db0df47: [ARM] Improve diagnostics message when Neon is unsupported (authored by vhscampos). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81847/new/ h

[PATCH] D82298: [AArch64][SVE] Add bfloat16 support to load intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rG3d6cab271c7c: [AArch64][SVE] Add bfloat16 support to load intrinsics (authored by kmclaughlin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82298/new/ htt

[PATCH] D82199: [clang-format] restore indent in conditionals when AlignOperands is DontAlign

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. This may not be the right long-term solution, but the current behavior is pretty broken and this is cheap. Comment at: clang/unittests/Format/FormatTest.cpp:6287 + St

[PATCH] D81456: [clangd] Get rid of WantDiagnostics::Yes

kadircet added a comment. ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81456/new/ https://reviews.llvm.org/D81456 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D82318: Add `FloatingLiteral` to SyntaxTree

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:1239-1242 +1e-2; +2.; +.2; +2.f; Indent -2. Repository: rG LLVM Githu

[PATCH] D82310: Add `BoolLiteralExpression` to SyntaxTree

gribozavr2 accepted this revision. gribozavr2 marked an inline comment as done. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:1240 + true; + false; +} eduucaldas wrote:

[PATCH] D82385: [Analyzer] Fix errors in iterator modeling

baloghadamsoftware updated this revision to Diff 272950. baloghadamsoftware edited the summary of this revision. baloghadamsoftware added a comment. Updated according to the comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82385/new/ https://reviews.llvm.org/D82385 Files: clan

[PATCH] D80301: [yaml][clang-tidy] Fix multiline YAML serialization

DmitryPolukhin updated this revision to Diff 272952. DmitryPolukhin added a comment. Use double quotation for multiline strings. It solves problems with internal newlines because now they are escaped. Also double quotation solves the problem with leading whitespace after newline. In case of sing

[PATCH] D82182: [AArch64][SVE] Add bfloat16 support to perm and select intrinsics

c-rhodes added inline comments. Comment at: clang/include/clang/Basic/arm_sve.td:1115 +let ArchGuard = "defined(__ARM_FEATURE_SVE_BF16)" in { +def SVREV_BF16: SInst<"svrev[_{d}]","dd", "b", MergeNone, "aarch64_sve_rev">; fpetrogalli wrote: > c-rhodes

[PATCH] D82445: [analyzer][solver] Track symbol equivalence

vsavchenko created this revision. vsavchenko added reviewers: NoQ, dcoughlin, ASDenysPetrov, xazax.hun, Szelethus. Herald added subscribers: cfe-commits, martong, Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. Herald added a project: clang. vsavchen

[clang] fd2c4b8 - [AArch64][SVE] Add bfloat16 support to svlen intrinsic

Author: Cullen Rhodes Date: 2020-06-24T10:05:51Z New Revision: fd2c4b8999322031b6cd555007ca69fd83270958 URL: https://github.com/llvm/llvm-project/commit/fd2c4b8999322031b6cd555007ca69fd83270958 DIFF: https://github.com/llvm/llvm-project/commit/fd2c4b8999322031b6cd555007ca69fd83270958.diff LOG:

[clang] 05e10ee - [AArch64][SVE2] Add bfloat16 support to whilerw/whilewr intrinsics

Author: Cullen Rhodes Date: 2020-06-24T10:06:31Z New Revision: 05e10ee0aee02dd3ff30f59a0b5e1faa2d5a21a0 URL: https://github.com/llvm/llvm-project/commit/05e10ee0aee02dd3ff30f59a0b5e1faa2d5a21a0 DIFF: https://github.com/llvm/llvm-project/commit/05e10ee0aee02dd3ff30f59a0b5e1faa2d5a21a0.diff LOG:

[clang] 26502ad - [AArch64][SVE] Add bfloat16 support to perm and select intrinsics

Author: Cullen Rhodes Date: 2020-06-24T10:04:51Z New Revision: 26502ad609222321f6384e3317fc03165c844be1 URL: https://github.com/llvm/llvm-project/commit/26502ad609222321f6384e3317fc03165c844be1 DIFF: https://github.com/llvm/llvm-project/commit/26502ad609222321f6384e3317fc03165c844be1.diff LOG:

[PATCH] D82446: [clang] Fix duplicate warning

kamleshbhalui created this revision. kamleshbhalui added reviewers: rsmith, aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes duplicate warning emitted by clang when char16_t/char32_t is used in the catch block. Fixes this https://bugs.llvm.org/show_bug.

[PATCH] D82360: Add StringLiteral to SyntaxTree

gribozavr2 accepted this revision. gribozavr2 added a comment. This revision is now accepted and ready to land. LGTM with improved testing. Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:1237 + "a\n"; + L"a"; +} Could you add some non-ASCII character

[PATCH] D82312: Add `CharLiteral` to SyntaxTree

gribozavr2 accepted this revision. gribozavr2 added a comment. This revision is now accepted and ready to land. LGTM after new tests are added. Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:1240 + 'a'; + L'a'; +} Could you add tests for escape seque

[PATCH] D82199: [clang-format] restore indent in conditionals when AlignOperands is DontAlign

krasimir updated this revision to Diff 272957. krasimir marked an inline comment as done. krasimir added a comment. - add a FIXME Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82199/new/ https://reviews.llvm.org/D82199 Files: clang/unittests/For

[PATCH] D82445: [analyzer][solver] Track symbol equivalence

vsavchenko updated this revision to Diff 272954. vsavchenko added a comment. Fix incorrect comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82445/new/ https://reviews.llvm.org/D82445 Files: clang/include/clang/StaticAnalyzer/Core/BugReporte

[PATCH] D82448: [AArch64][SVE] Add bfloat16 support to store intrinsics

kmclaughlin created this revision. kmclaughlin added reviewers: sdesmalen, c-rhodes, fpetrogalli, efriedma, stuij, david-arm. Herald added subscribers: llvm-commits, cfe-commits, danielkiss, psnobl, rkruppe, hiraditya, kristof.beyls, tschuett. Herald added projects: clang, LLVM. Bfloat16 support

[PATCH] D82399: [AArch64][SVE2] Add bfloat16 support to whilerw/whilewr intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rG05e10ee0aee0: [AArch64][SVE2] Add bfloat16 support to whilerw/whilewr intrinsics (authored by c-rhodes). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82399/

[PATCH] D82182: [AArch64][SVE] Add bfloat16 support to perm and select intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rG26502ad60922: [AArch64][SVE] Add bfloat16 support to perm and select intrinsics (authored by c-rhodes). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82182/n

[PATCH] D82186: [AArch64][SVE] Add bfloat16 support to svlen intrinsic

This revision was automatically updated to reflect the committed changes. Closed by commit rGfd2c4b899932: [AArch64][SVE] Add bfloat16 support to svlen intrinsic (authored by c-rhodes). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82186/new/ https:

[clang] 7213142 - [libclang] Extend clang_Cursor_Evaluate().

Author: Christian Kandeler Date: 2020-06-24T11:58:39+01:00 New Revision: 72131423cc952ccbd6d8e021ff7c04fa22297fe3 URL: https://github.com/llvm/llvm-project/commit/72131423cc952ccbd6d8e021ff7c04fa22297fe3 DIFF: https://github.com/llvm/llvm-project/commit/72131423cc952ccbd6d8e021ff7c04fa22297fe3.

[clang] 0fad648 - [clang-format] restore indent in conditionals when AlignOperands is DontAlign

Author: Krasimir Georgiev Date: 2020-06-24T13:11:18+02:00 New Revision: 0fad648b65b99b68040fa26c5da9c0bec5b0aa1d URL: https://github.com/llvm/llvm-project/commit/0fad648b65b99b68040fa26c5da9c0bec5b0aa1d DIFF: https://github.com/llvm/llvm-project/commit/0fad648b65b99b68040fa26c5da9c0bec5b0aa1d.d

[PATCH] D65761: Add Windows Control Flow Guard checks (/guard:cf).

ajpaverd added a comment. Herald added a reviewer: jdoerfert. In D65761#2102525 , @mehdi_amini wrote: > It seems like this pass was added in lib/Transforms but does not have any > unit-tests (lit tests) provided. It isn't even linked into `opt`. As it is

[PATCH] D82199: [clang-format] restore indent in conditionals when AlignOperands is DontAlign

krasimir updated this revision to Diff 272964. krasimir added a comment. - refresh Phabricator diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82199/new/ https://reviews.llvm.org/D82199 Files: clang/unittests/Format/FormatTest.cpp Index: cl

[PATCH] D82102: [AST][RecoveryExpr] Populate the error-bit from template arguments to TemplateSepcializationType.

hokein updated this revision to Diff 272963. hokein added a comment. per offline discussion: add error-bit to TemplateArgument which provide a more general fix for missing error-bit in the code path: "error type/expr" -> "teample argument" -> "template specialization typ". Repository: rG LLVM

[PATCH] D82381: [analyzer] Introduce small improvements to the solver infra

xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:373 + ++Upper; + --Lower; + Sorry if my question is dumb, but I do not really have a mental model at this point about where do we actually handle types and ov

[PATCH] D82182: [AArch64][SVE] Add bfloat16 support to perm and select intrinsics

sdesmalen added inline comments. Comment at: llvm/test/CodeGen/AArch64/sve-intrinsics-perm-select.ll:809 +define @rev_bf16( %a) { +; CHECK-LABEL: rev_bf16 Does this test not need the `+bf16` attribute to work? (which implies the patterns are missing the right

[PATCH] D82199: [clang-format] restore indent in conditionals when AlignOperands is DontAlign

krasimir updated this revision to Diff 272966. krasimir added a comment. - try to update Phabricator diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82199/new/ https://reviews.llvm.org/D82199 Files: clang/lib/Format/ContinuationIndenter.cpp

[PATCH] D82182: [AArch64][SVE] Add bfloat16 support to perm and select intrinsics

c-rhodes marked an inline comment as done. c-rhodes added inline comments. Comment at: clang/include/clang/Basic/arm_sve.td:1115 +let ArchGuard = "defined(__ARM_FEATURE_SVE_BF16)" in { +def SVREV_BF16: SInst<"svrev[_{d}]","dd", "b", MergeNone, "aarch64_sve_rev">; ---

[PATCH] D82298: [AArch64][SVE] Add bfloat16 support to load intrinsics

sdesmalen added inline comments. Comment at: llvm/test/CodeGen/AArch64/sve-intrinsics-ld1-addressing-mode-reg-imm.ll:217 + %base_scalar = bitcast * %base to bfloat* + %load = call @llvm.aarch64.sve.ld1.nxv8bf16( %pg, bfloat* %base_scalar) + ret %load Sorry

[PATCH] D82450: [AArch64][SVE] Add multiclass for bfloat16 intrinsic definitions

c-rhodes created this revision. c-rhodes added reviewers: sdesmalen, fpetrogalli, kmclaughlin, efriedma. Herald added subscribers: danielkiss, psnobl, rkruppe, kristof.beyls, tschuett. Herald added a project: clang. Patch implements a multiclass 'SInstBF16', a wrapper around SInst that also define

[PATCH] D82445: [analyzer][solver] Track symbol equivalence

xazax.hun added a comment. I only checked the test cases and the comments so far and it looks very useful and promising. I really hope that the performance will be ok :) I'll look at the actual code changes later. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManag

[PATCH] D71739: [AssumeBundles] Use operand bundles to encode alignment assumptions

Tyker updated this revision to Diff 272968. Tyker marked 2 inline comments as done. Tyker added a comment. addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71739/new/ https://reviews.llvm.org/D71739 Files: clang/lib/CodeGen/CodeG

[PATCH] D80279: [libclang] Extend clang_Cursor_Evaluate().

This revision was automatically updated to reflect the committed changes. Closed by commit rG72131423cc95: [libclang] Extend clang_Cursor_Evaluate(). (authored by ckandeler, committed by fhahn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80279/new

[PATCH] D82199: [clang-format] restore indent in conditionals when AlignOperands is DontAlign

This revision was automatically updated to reflect the committed changes. Closed by commit rG0fad648b65b9: [clang-format] restore indent in conditionals when AlignOperands is DontAlign (authored by krasimir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[clang] 2ace693 - Don't install clang-import-test

Author: Alex Richardson Date: 2020-06-24T12:24:43+01:00 New Revision: 2ace69339ffe3d3432b1fb930f51b490bb8856c8 URL: https://github.com/llvm/llvm-project/commit/2ace69339ffe3d3432b1fb930f51b490bb8856c8 DIFF: https://github.com/llvm/llvm-project/commit/2ace69339ffe3d3432b1fb930f51b490bb8856c8.dif

[PATCH] D82381: [analyzer] Introduce small improvements to the solver infra

vsavchenko marked an inline comment as done. vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:467-470 +/// Available representations for the arguments are: +/// * RangeSet +/// * Optional +/// * RangeSet * --

[PATCH] D71339: [VE,#2] Clang toolchain for SX-Aurora

simoll abandoned this revision. simoll added a comment. Basic Clang support for VE is now upstream: rG96d4ccf0 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71339/new/ https://r

[PATCH] D82386: [clangd] Config: Fragments and parsing from YAML

kadircet added inline comments. Comment at: clang-tools-extra/clangd/ConfigYAML.cpp:29 + llvm::SourceMgr &SM; + llvm::SmallString<256> Buf; + a comment for this buf, especially the reason why it's a member rather than a function-local when needed. (I suppose t

[PATCH] D82445: [analyzer][solver] Track symbol equivalence

vsavchenko marked an inline comment as done. vsavchenko added a comment. > I really hope that the performance will be ok :) I had a test run for one of the earlier implementations of this and it looks like it adds 1-2% to the execution time. And of course I will attach more info on that late

[PATCH] D82185: [Analyzer] Handle pointer implemented as iterators in iterator checkers

baloghadamsoftware updated this revision to Diff 272973. baloghadamsoftware added a comment. Updated according to the comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82185/new/ https://reviews.llvm.org/D82185 Files: clang/lib/StaticAnalyzer/Checkers/InvalidatedIteratorChecker

[PATCH] D82288: [analyzer][StdLibraryFunctionsChecker] Add POSIX file handling functions

Szelethus added a comment. I see a lot of `NoEvalCall`, but I wonder whether modifying `errno` warrants this. Shouldn't we have a alongside `NoEvalCall` and `EvalCallAsPure` an `EvalCallAsPureButInvalidateErrno` invalidation kind? Also, I'm kind of worried by this checker taking on the responsi

[PATCH] D82381: [analyzer] Introduce small improvements to the solver infra

vsavchenko marked an inline comment as done. vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:373 + ++Upper; + --Lower; + xazax.hun wrote: > Sorry if my question is dumb, but I do not really have a mental mo

[PATCH] D82169: Don't install clang-import-test

This revision was automatically updated to reflect the committed changes. Closed by commit rG2ace69339ffe: Don't install clang-import-test (authored by arichardson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82169/new/ https://reviews.llvm.org/D

[PATCH] D82446: [clang] Fix duplicate warning

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseExprCXX.cpp:2273 ParseSpecifierQualifierList(DS, AS_none, DeclSpecContext::DSC_type_specifier); - DS.Finish(Actions, Actions.getASTContext().getPrintingPolicy()); return false; This cha

[PATCH] D81769: [clang-tidy] Repair various issues with modernize-avoid-bind

aaron.ballman added a comment. In D81769#2109936 , @jaafar wrote: > One more simplification from Aaron. Thanks! No problem! Do you need someone to commit on your behalf, btw? If so, let me know what name and email address you would like me to attribute.

[PATCH] D82182: [AArch64][SVE] Add bfloat16 support to perm and select intrinsics

c-rhodes added inline comments. Comment at: llvm/test/CodeGen/AArch64/sve-intrinsics-perm-select.ll:809 +define @rev_bf16( %a) { +; CHECK-LABEL: rev_bf16 sdesmalen wrote: > Does this test not need the `+bf16` attribute to work? (which implies the > patterns a

[PATCH] D82425: [SemaCXX] Fix false positive of -Wuninitialized-const-reference in empty function body.

nick added a comment. Thanks @zequanwu, much appreciated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82425/new/ https://reviews.llvm.org/D82425 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D82386: [clangd] Config: Fragments and parsing from YAML

kadircet added a comment. Thanks! Looks great, I've finally managed to finish all my iterations :D Apart from the comments(IIRC which are mostly minor), it felt like there were a few lines that aren't clang-format'd. Please make sure to run clang-format on the files at some point. ==

[PATCH] D82373: [CodeComplete] Tweak code completion for `typename`

lh123 updated this revision to Diff 272994. lh123 edited the summary of this revision. lh123 added a comment. address comment. Also tweak code completion behavior for `using`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82373/new/ https://revie

[PATCH] D82450: [AArch64][SVE] Add multiclass for bfloat16 intrinsic definitions

sdesmalen added inline comments. Comment at: clang/include/clang/Basic/arm_sve.td:264 + list arch_features = []> { + let ArchGuard = !foldl("", arch_features, lhs, rhs, + lhs # !if(!ne(lhs, ""), " && ", "") # rhs) in {

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

ABataev added inline comments. Comment at: clang/include/clang/AST/StmtOpenMP.h:4781-4784 +/// This represents the '#pragma omp tile' loop transformation directive. +class OMPTileDirective final +: public OMPLoopDirective, + private llvm::TrailingObjects { --

[PATCH] D80301: [yaml][clang-tidy] Fix multiline YAML serialization

DmitryPolukhin updated this revision to Diff 272996. DmitryPolukhin added a comment. Fix test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80301/new/ https://reviews.llvm.org/D80301 Files: clang/include/clang/Tooling/ReplacementsYaml.h clang/

[PATCH] D82373: [CodeComplete] Tweak code completion for `typename`

lh123 added a comment. If this patch looks good, please land it for me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82373/new/ https://reviews.llvm.org/D82373 ___ cfe-commits mailing list cfe-commits

[PATCH] D82385: [Analyzer] Fix errors in iterator modeling

Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/IteratorModeling.cpp:530-532 const auto *Pos = getIteratorPosition(State, LHS); if (!Pos) return; I fear this might be a stupid question, but what's up with `5 + it`? Why do

[PATCH] D82081: [z/OS] Add binary format goff and operating system zos to the triple

Kai updated this revision to Diff 273004. Kai added a comment. - Added a `break;` in several places - Follow local formatting style in `triple.cpp` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82081/new/ https://reviews.llvm.org/D82081 Files: clang/lib/CodeGen/BackendUtil.cpp clan

[PATCH] D77062: [analyzer] Improved zero assumption in CStringChecke::assumeZero

ASDenysPetrov updated this revision to Diff 272997. ASDenysPetrov added a comment. @NoQ thanks for the approval. But I'm afraid we should return the check for `!V.getAs()` back in `CStringChecker::assumeZero`. Look, I paid attention to the fix for https://llvm.org/PR24951 and related commit rG4

[PATCH] D82414: [X86] Replace PROC macros with an enum and a lookup table of processor information.

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. 1 nit, plus the clang-tidy suggestions. Comment at: clang/lib/Basic/Targets/X86.cpp:1559 + "CPU Type without a key feature used in 'target' attribute"); +

[PATCH] D71199: [clang-tidy] New check cppcoreguidelines-prefer-member-initializer

baloghadamsoftware marked 2 inline comments as done. baloghadamsoftware added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-prefer-member-initializer-assignment.cpp:29 +public: + Simple2() : n (0) { +x = 0.0; aaro

[PATCH] D82385: [Analyzer] Fix errors in iterator modeling

baloghadamsoftware marked 2 inline comments as done. baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/IteratorModeling.cpp:530-532 const auto *Pos = getIteratorPosition(State, LHS); if (!Pos) return; Szelethus wro

[PATCH] D82446: [clang] Fix duplicate warning

kamleshbhalui marked an inline comment as done. kamleshbhalui added inline comments. Comment at: clang/lib/Parse/ParseExprCXX.cpp:2273 ParseSpecifierQualifierList(DS, AS_none, DeclSpecContext::DSC_type_specifier); - DS.Finish(Actions, Actions.getASTContext().getPrintingPolic

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

Xiangling_L marked 2 inline comments as done. Xiangling_L added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1881 + if (isAIXLayout(Context) && FieldOffset == CharUnits::Zero() && + (IsUnion || NonOverlappingEmptyFieldFound)) { +FirstNonOverlapping

[PATCH] D82461: [VE] Add clang tests for VE

kaz7 created this revision. kaz7 added reviewers: simoll, k-ishizaka. kaz7 added projects: LLVM, VE. Herald added subscribers: cfe-commits, ormris, jfb, krytarowski. Herald added a project: clang. Add a preprocessor test to check VE predefinitions. Add a driver test to check VE toolchain behavior

[PATCH] D82385: [Analyzer] Fix errors in iterator modeling

gamesh411 accepted this revision. gamesh411 added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/StaticAnalyzer/Checkers/IteratorModeling.cpp:530-532 const auto *Pos = getIteratorPosition(State, LHS); if (!Pos) return; -

[clang] 5f94c9a - [AST][RecoveryExpr] Add error-bit TemplateArgument

Author: Haojian Wu Date: 2020-06-24T16:21:35+02:00 New Revision: 5f94c9a421ec7cc7ece2bd875e010639ee0783ec URL: https://github.com/llvm/llvm-project/commit/5f94c9a421ec7cc7ece2bd875e010639ee0783ec DIFF: https://github.com/llvm/llvm-project/commit/5f94c9a421ec7cc7ece2bd875e010639ee0783ec.diff LO

[PATCH] D81938: [InferAddressSpaces] Handle the pair of `ptrtoint`/`inttoptr`.

arsenm added inline comments. Comment at: clang/test/CodeGenCUDA/amdgpu-kernel-arg-pointer-type.cu:62-64 +// OPT-NOT: alloca +// OPT-NOT: ptrtoint +// OPT-NOT: inttoptr Positive checks are preferable (here and through the rest of the file) Comm

[PATCH] D82446: [clang] Fix duplicate warning

riccibruno added a comment. I apologise for a quick drive-by comment, but this is something I find very annoying when looking at the history of a piece of code: Could you spent a few minutes to make a more descriptive title and description? Fixes duplicate warning emitted by clang when char

[PATCH] D82288: [analyzer][StdLibraryFunctionsChecker] Add POSIX file handling functions

martong marked 8 inline comments as done. martong added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:352-357 CmdLineOption, Szelethus wrote: > D78118#inline-723679 Please mark this `Hidden`. Ok, it missed my attention

[PATCH] D82288: [analyzer][StdLibraryFunctionsChecker] Add POSIX file handling functions

martong updated this revision to Diff 273018. martong marked 4 inline comments as done. martong added a comment. - Add 'Hide' and 'InAlpha', move Off_tMax inside the brace Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82288/new/ https://reviews.llv

  1   2   3   >