hokein marked 2 inline comments as done.
hokein added inline comments.
================
Comment at: clang/include/clang/AST/DependenceFlags.h:123
+ translate(D, TypeDependence::Dependent, Dependent) |
+ translate(D, TypeDependence::Error, Error) |
+ translate(D, TypeDependence::VariablyModified, VariablyModified)) {}
----------------
sammccall wrote:
> oops! seems like we should be able to observe this directly in an AST dump
> test too, which should be failing to mark some nodes as error-dependent.
> (Not sure if there's a simpler example than your crashing testcase though)
yes, in theory. The code path need to go through "error expr" -> "error type"
-> "recovery expr", but it seems not easy to produce a case in non-template
context, either we bail out too early, or the recovery expression is not built.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82099/new/
https://reviews.llvm.org/D82099
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
