vsavchenko marked an inline comment as done. vsavchenko added a comment. > I really hope that the performance will be ok :)
I had a test run for one of the earlier implementations of this and it looks like it adds 1-2% to the execution time. And of course I will attach more info on that later. Additionally, I have a couple of disappeared FPs concerning reference counting, that I still need to figure out. ================ Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:425 +/// +/// * "Merge (or Union) operation" merges two classes into one. It is the +/// main operation to produce non-trivial classes. ---------------- xazax.hun wrote: > I found the mention of union confusing here. Especially since merging means > intersection in terms of the ranges. I think I know what you meant but some > additional clarification is welcome. Gotcha, I guess I'll add parallels with the Union-Find data structure in the implementation and make it more transparent. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82445/new/ https://reviews.llvm.org/D82445 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
