riccibruno added a comment. I apologise for a quick drive-by comment, but this is something I find very annoying when looking at the history of a piece of code:
Could you spent a few minutes to make a more descriptive title and description? Fixes duplicate warning emitted by clang when char16_t/char32_t is used in the catch block. Does not actually explains what is wrong (the duplicate warning is just a symptom), nor does it explains what is done to fix it, nor does it explains *why* this is the right fix. Unless the patch is really trivial I think that it pays to put a little more context in the description. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82446/new/ https://reviews.llvm.org/D82446 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
