On Sat, Apr 18, 2015 at 10:48 AM, Julien Puydt <julien.pu...@laposte.net> wrote: > > May I notice that : > (1) the ticket is in stage needs_review or positive_review ; > (2) what is actually reviewed is a precise commit in a git branch ; > (3) nothing forces the ticket and the branch to be synchronized.
Exactly. As for our current procedure, I would suggest that any change to the commit/branch automatically bumps it down to needs review, and there should be a field/state "merge candidate" used when the release manager is actively merging tickets which would be a strong signal to hold of further changes to this ticket. Hopefully in the long run we can track commits (rather than indirectly track tickets) and have a more continuous integration (e.g. a release branch that is automatically generated by positively reviewed tickets also manually approved by the release manager and tested sequentially on top of each other. Rarely would such a branch need to be rolled back. > so you might discuss things as much as you want, decide whatever you > want : it's going to be a pain as long as the above three points stand! > > Snark on #sagemath > > -- > You received this message because you are subscribed to the Google Groups > "sage-devel" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to sage-devel+unsubscr...@googlegroups.com. > To post to this group, send email to sage-devel@googlegroups.com. > Visit this group at http://groups.google.com/group/sage-devel. > For more options, visit https://groups.google.com/d/optout. -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To post to this group, send email to sage-devel@googlegroups.com. Visit this group at http://groups.google.com/group/sage-devel. For more options, visit https://groups.google.com/d/optout.
