I already proposed a cool-off period, possible but somewhat annoying. Ideally, continuous integration would start merging your ticket the second you set it to positive review. We are not there yet, but we'll do it eventually.
We don't need extra ticket states, we just need to agree to stop changing branches (or, rather, not expect to have those changes show up in Sage) at one of the existing states. Having the release manager run after your moving branches isn't going to scale. Then I have to unmerge your modified ticket and possible dependencies, re-run test, once that is finished somebody else changed their positively-reviewd ticket, ... On Friday, April 17, 2015 at 6:03:45 AM UTC-4, Nathann Cohen wrote: > > Helloooooooo, > > I also believe that something should be done about that, and that it can be > solved in much more satisfying ways. Some propositions: > > - A one-week delay (*) between latest commit and merge. We make sure that > every > last-minute change has been made. It also gives more time for everybody to > look at the branch. > > - 'Freeze' a ticket when the release manager is working on them. E.g.: change > its status to 'closed (merging in process)' > > - Send an (automatic) comment on a ticket when it is being processed. This > solves the problem (as we know what is going on) *and* explains the workflow > to newcomers. E.g.: > > This ticket is being tested before inclusion into the next release. > Don't > touch. > > - When closing a ticket, check that the commit that is being merged is still > the > top of the ticket's branch (the commits are not 'silently' forgotten). If it > isn't, then either: > > - Run the tests again on the new branch. > > - Add a comment to the ticket saying which commits have been ignored (so > that > we can add them in another ticket) > > Very often we figure out that some ticket in positive_review contains a typo, > or > contains a bug (even though the tests pass). Or even need a new 'seealso' > entry. Also, many tickets in positive_review were switched to needs_work > because > somebody didn't like what was done inside. > > I believe that the alternatives above give us many ways to avoid losing > commits > without making it a rule to never change a ticket once it is in > positive_review. > > Nathann > > (*) Totally random number. Can be anything you like. > > -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To post to this group, send email to sage-devel@googlegroups.com. Visit this group at http://groups.google.com/group/sage-devel. For more options, visit https://groups.google.com/d/optout.
