Hellooooooooooooooooooo, > I often have a look at positively reviewed tickets and sometimes ask > questions about the review. Positive review just mean that one person agreed > that the changes were good to be integrated. But it might still interest > other to have a look (or even the reviewer might think of something in the > morning after setting the day before 'positive review'). So I would prefer a > stand by period between the 'positive review' and the 'closed' (= currently > testing if it merges cleanly). One week looks reasonable to me. And it > should not be hard to script.
It is true that several persons requested that tickets should stay in positive review for a while before being merged. On the other hand, if merging them becomes fully automatic, then changing something is really immediate and perhaps we will end up creating more tickets. A bit like we have been makiing much more commits with git than we use to create .diff wiles with mercurial. Nathann -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To post to this group, send email to sage-devel@googlegroups.com. Visit this group at http://groups.google.com/group/sage-devel. For more options, visit https://groups.google.com/d/optout.
