On 04/19/2015 05:41 PM, Nathann Cohen wrote: >> I often have a look at positively reviewed tickets and sometimes ask >> questions about the review. Positive review just mean that one person agreed >> that the changes were good to be integrated. But it might still interest >> other to have a look (or even the reviewer might think of something in the >> morning after setting the day before 'positive review'). So I would prefer a >> stand by period between the 'positive review' and the 'closed' (= currently >> testing if it merges cleanly). One week looks reasonable to me. And it >> should not be hard to script.
> It is true that several persons requested that tickets should stay in > positive review for a while before being merged. On the other hand, if > merging them becomes fully automatic, then changing something is > really immediate and perhaps we will end up creating more tickets. Yep, with all consequences. It would IMHO be much more sensible to use the "Merged in" field (which Volker likes very much, I know), indicating that the branch has currently been merged into the next, not yet released, version. (No need to change that field later, upon closing the ticket, if everything went well.) That way, anybody would (or should) know that he/she must not change the ticket's branch, but it would also easily be possible to revert the ticket's state into "needs work", in case other reviewers (or the original one(s)) happen to find further issues directly related to the ticket's changes (as opposed to desirable changes for a follow-up). Note that when using the "Merged in" field while keeping the ticket's state in "positive review" (or even "needs review"), it's more likely others will take a look at the ticket (in contrast to tickets marked "closed"), and one could even search for tickets with positive review subject to get merged into the current (next) devel release. If the release manager unmerges the ticket again (because of issues he/she or other reviewers/testers discovered), he/she (and only he/she) simply deletes the "Merged in" entry, also setting the ticket back to "needs work" if it isn't already. The above procedure also implies a natural (but possibly pretty short) delay between positive review and closing. It's hard to say in general how long a ticket should last in positive review before getting closed/finally merged; I don't think it makes sense to implement some fixed period (increased during holidays? shorter for blockers? depending on the number of people involved in the ticket? ...). 2ct, -leif -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To post to this group, send email to sage-devel@googlegroups.com. Visit this group at http://groups.google.com/group/sage-devel. For more options, visit https://groups.google.com/d/optout.
