Hi Volker, On 2015-04-15, Volker Braun <vbraun.n...@gmail.com> wrote: >> Can you give a compelling reason why not? I mean, when the ticket branch >> hasn't been merged into the develop branch? > > > Testing imposes a significant delay between merging into the develop branch > and closing the ticket.
Aha, you mean the problem is that the process of merging it into the develop branch takes a significant time, so that it is easily possible that the reviewer thinks "well, it hasn't been merged yet, so, we can still work on it"? OK, that's a good reason to discourage withdrawing positive reviews --- unless we have a way to freeze a ticket while the release manager is merging. > Sure we can have a more complicated trac workflow, > but one way or another it'll just boil down to not changing > positively-reviewed tickets unless the release manager finds an issue. Would it be really so complicated? I suppose you have a script that merges into develop and then tests the branches of positively reviewed ticket (or are you doing it manually?). That script could also contain a line that blocks the associated ticket (i.e., makes it impossible for a non-administrator to change the ticket status) while the script is running. Best regards, SImon -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To post to this group, send email to sage-devel@googlegroups.com. Visit this group at http://groups.google.com/group/sage-devel. For more options, visit https://groups.google.com/d/optout.
