Hi! On 2015-04-15, Volker Braun <vbraun.n...@gmail.com> wrote: > Its of course fine for the release manager to set something back from > positive review.
Quod licet Iovi, non licet bovi... > Also, if there is an actual problem with the ticket then > tests should fail Why? The reviewer could notice (too late) that the code introduces a problem for which there is no test, yet. > But you can't turn around and add another feature on a ticket that already > has positive review. Can you give a compelling reason why not? I mean, when the ticket branch hasn't been merged into the develop branch? Of course, there is a race condition: The scenario is that a reviewer attempts to set the review back from "positive" to "needs work", and at the same time the release manager attempts to merge the ticket branch into the develop branch. It should be possible to write a trac plugin (sorry, I can't do it, but I am sure you can) such that * the release manager's merge attempt implies that all attempts to change the status of the ticket are blocked (with a nice message telling to open a new ticket), and * the release manager's merge attempt will automatically be aborted, if the reviewer sets it back to "needs work" a second before the release manager pushed the button. Best regards, Simon -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To post to this group, send email to sage-devel@googlegroups.com. Visit this group at http://groups.google.com/group/sage-devel. For more options, visit https://groups.google.com/d/optout.
