Am 2015-04-16 um 19:28 schrieb kcrisman: > That said, now that I see part of the problem is not just people changing > tickets, but changing *branches* and *keeping* positive review (or something > analogous to this), I agree that is a different situation. So, here's my > possibly buggy suggestion:
technically, they do not *keep* positive review. They set it to needs_work, needs_review, somebody reviews it, sets it to positive_review. So the ticket went through a full cycle, but the earlier version is merged. And those tickets where this actually happened were usually very minor issues (where the authors presumably had the impression that opening an extra ticket is overkill). The whole discussion was about the semantics of "positive_review". In the release managers workflow, is actually closer to "closed" than I previously assumed, but all other proposal essentially boiled down to introducing one more status of a ticket. Thus it is all about the semantics of the available ticket status. We can then as well codify the current workflow. Therefore, I now created #18228 to change the developer guide to state that one should not push commits to a ticket set to positive review. This ticket needs review. Regards, CH -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To post to this group, send email to sage-devel@googlegroups.com. Visit this group at http://groups.google.com/group/sage-devel. For more options, visit https://groups.google.com/d/optout.
