> > On Thursday, April 16, 2015 at 7:58:32 AM UTC+2, Jeroen Demeyer wrote: >> >> On 2015-04-16 01:33, Nils Bruin wrote: >> > The whole meaning of "positive review" goes out of >> > the window if one still changes the branch on the ticket. >> I disagree. It can easily happen that a problem is found after a ticket >> was set to positive_review. Perhaps some corner case doesn't quite work. >> Or there could be trivial changes like a documentation typo. >> >>
Then open a new ticket. Which is exactly what you would do if the ticket > has been switched to closed, so why is it impossible to do when it is > positive_review? > > Because of the social problem that people probably won't fix it, or at least not by the next stable release (surely not all such tickets would become blockers). Then we'll have (for instance) some new behavior in Sage with an annoying bug that it totally reproducible but not taken care of, instead of just not having that in Sage at all, buggy or no. That said, now that I see part of the problem is not just people changing tickets, but changing *branches* and *keeping* positive review (or something analogous to this), I agree that is a different situation. So, here's my possibly buggy suggestion: * If you actually HAVE a solution to the problem you see in a positive review ticket, then open a new ticket and put it there. * If not, undo positive review and put to "needs work" and presumably it won't get fixed fast enough to matter. Or if someone gets a fix, they could put it on a new ticket. (?) -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To post to this group, send email to sage-devel@googlegroups.com. Visit this group at http://groups.google.com/group/sage-devel. For more options, visit https://groups.google.com/d/optout.
