On 2 January 2014 07:51, Jason Grout <[email protected]> wrote: > On 1/1/14, 11:34 PM, Volker Braun wrote: >> >> The solution (I'd call it "Volker's solution" except that its really >> what everybody else does, so I can't take credit for it) is to tell >> every reviewer that he is responsible for every commit that is not >> already reviewed. Its an extremely simple rule. And if its too much work >> to also review the commits from the dependencies then just start at the >> dependency. Easy as pie. > > > Which is exactly why I think we should have a view that shows what commits > and changes on a ticket have not been reviewed yet. For example, if ticket > 2 depends on ticket 1, and someone goes and reviews ticket 1, it would be > fantastic if on trac we can see a list of changes and/or a total diff that > exists in ticket 2 without seeing the positively-reviewed changes from > ticket 1 (even if ticket 1 has not been merged).
It is rather frequent that some commit gets a positive review (e.g. from me) only to be reverted to "needs work" by someone else (e.g. one of our excellent release managers ;)). If the list of commits coming from dependencies of ticket 2 could be shown with tags showing their review status, that would be nice, though not very well-defined since ticket 1 might have had a series of serveral commits and only the complete set of changes they represent has the positive review, not the individual component commits. Personally, at least until everyone is used to this new system (which I do like using a lot so far, despite some teething troubles) I will avoid reviewing tickets with unreviewed dependencies, whic his the simple version of "Volker's solution". John > > Thanks, > > Jason > > > > -- > You received this message because you are subscribed to the Google Groups > "sage-devel" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > Visit this group at http://groups.google.com/group/sage-devel. > For more options, visit https://groups.google.com/groups/opt_out. -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/sage-devel. For more options, visit https://groups.google.com/groups/opt_out.
