On 1/1/14, 11:34 PM, Volker Braun wrote:
The solution (I'd call it "Volker's solution" except that its really
what everybody else does, so I can't take credit for it) is to tell
every reviewer that he is responsible for every commit that is not
already reviewed. Its an extremely simple rule. And if its too much work
to also review the commits from the dependencies then just start at the
dependency. Easy as pie.

Which is exactly why I think we should have a view that shows what commits and changes on a ticket have not been reviewed yet. For example, if ticket 2 depends on ticket 1, and someone goes and reviews ticket 1, it would be fantastic if on trac we can see a list of changes and/or a total diff that exists in ticket 2 without seeing the positively-reviewed changes from ticket 1 (even if ticket 1 has not been merged).

Thanks,

Jason


--
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-devel.
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to