You can only *safely* review a ticket without its dependencies if every non-fast-forward change to one of the dependencies resets it back to "needs review". This is not a question about review, but a question about your ticket pulling in potentially abandoned code.
On Wednesday, January 1, 2014 7:31:46 AM UTC-10, Jeroen Demeyer wrote: > > Then the diff that I like to see is the diff from (A) to (B). > [...] (that's another disadvantage > of the new workflow, we cannot see any useful diffs after the ticket has > been merged). > You can always get the diff between any two commits out of git. > Then adds a very slight burden on the release manager to not merge any > ticket unless the dependencies have been merged. I don't want to have to click around on trac along the dependency chain to see if all dependencies have been positively reviewed. Also, I don't know of any other big software project that does that. Which almost certainly means that it is not a good idea. -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/sage-devel. For more options, visit https://groups.google.com/groups/opt_out.
