I would be against automatically closing stale issues just because 
realistically we aren't closing issues that fast (I would love if all Sage 
issues were resolved in 90 days, but I don't think that is realistic right 
now). Perhaps as a first step for dealing with all the open issues would be 
doing a better job of triage, especially using priority tags. It's probably 
worth clarifying the circumstances in which we do close an issue as well. But 
that's worth its own separate discussion.

For closing PRs with no activity, if we were to do it automatically, that timer 
should start after the PR is tagged with "changes requested". I don't want to 
punish contributions where it's our fault for not reviewing them in a timely 
manner. Basically we should only be closing PRs where we reviewed them, changes 
were requested, and changes were not made after several months.

Vincent Macri (he/him)
________________________________
From: 'Gonzalo Tornaria' via sage-devel <sage-devel@googlegroups.com>
Sent: Wednesday, January 22, 2025 11:22:43 AM
To: sage-devel@googlegroups.com <sage-devel@googlegroups.com>
Subject: Re: [sage-devel] Policy for closing abandoned PRs

[â–³EXTERNAL]



As a comparision, in void-packages there is the following policy:
 - an issue (or PR) with 90 days of inactivity is labeled "stale" and will send 
a notification.
 - any activity in the issue will reset the "stale" label, so an author can 
just make a status report on receipt of the notification to keep the issue open
 - after 14 days "stale", the issue is closed
 - author (or maintainer?) can reopen the issue. However: note that github does 
not allow reopening a PR *unless* the corresponding branch points to the exact 
same commit as when the PR was closed, so this is sometimes tricky.

Implementing this seems easy, see: 
https://github.com/void-linux/void-packages/blob/master/.github/workflows/stale.yml

There can be certain labels which make the issue exempt from the stale check.

Best,
Gonzalo

--
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion visit 
https://groups.google.com/d/msgid/sage-devel/e11f448f7ff6bf66412d2288c6ca11e6%40cmat.edu.uy.

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion visit 
https://groups.google.com/d/msgid/sage-devel/YQXPR01MB56595203ED3ACF3D8880D4E7F7E12%40YQXPR01MB5659.CANPRD01.PROD.OUTLOOK.COM.

Reply via email to